Timeline
09/29/11:
- 23:17 Changeset [96391] by
-
Add op_call/op_constructor support to JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69120
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
Improve the coverage of JSVALUE32_64 DFG JIT.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::tagOfCallData):
(JSC::DFG::payloadOfCallData):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- 22:22 Changeset [96390] by
-
watchlist: Add cross-checks for WatchList once it is filled.
https://bugs.webkit.org/show_bug.cgi?id=68975
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
instead of having trivial getter and setters.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
pass the validation checks.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
and fix a few style nits.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
validation checks.
- Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
- 22:15 Changeset [96389] by
-
DFG JIT - register not unlocked after usage in ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=69122
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Geoffrey Garen.
Some allocated register is not unlocked after the usage in ArithDiv.
Also there's a typo in "ENBALE_DFG_CONSISTENTCY_CHECK".
- dfg/DFGNode.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 22:05 Changeset [96388] by
-
run-api-tests fails on chromium-win bot
https://bugs.webkit.org/show_bug.cgi?id=69121
On Windows running a perl script needs the interpreter.
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-29
Reviewed by Adam Barth.
- Scripts/run-api-tests:
(buildTestTool):
- 22:04 Changeset [96387] by
-
[Chromium] Layout Test platform/chromium/compositing/3d-corners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69124
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 21:58 Changeset [96386] by
-
fast/text/line-initial-and-final-swashes.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=69103
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 21:44 Changeset [96385] by
-
Fixed Hit testing on Framesets when Frameset is transformed
https://bugs.webkit.org/show_bug.cgi?id=67740
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/frames/frame-set-rotation-hit.html
fast/frames/frame-set-scaling-hit.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
LayoutTests:
- fast/frames/frame-set-rotation-hit-expected.png: Added.
- fast/frames/frame-set-rotation-hit-expected.txt: Added.
- fast/frames/frame-set-rotation-hit.html: Added.
- fast/frames/frame-set-scaling-hit-expected.png: Added.
- fast/frames/frame-set-scaling-hit-expected.txt: Added.
- fast/frames/frame-set-scaling-hit.html: Added.
- 21:11 Changeset [96384] by
-
fix gyp warnings in chromium for renamed files
https://bugs.webkit.org/show_bug.cgi?id=69116
Reviewed by Adam Barth.
- WebCore.gypi:
- 19:30 Changeset [96383] by
-
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235
Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize the native window handles of GTK.
- UIProcess/WebInspectorProxy.h: Add native window handle for inspector window.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::inspectorFilesBasePath): Base folder for inspector resources.
(WebKit::inspectorWindowDestroyed): Invoked when inspector window is closed by user.
(WebKit::WebInspectorProxy::windowDestroyed): Resets the native handles to 0 when user closes the window.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the WebView for inspector.
(WebKit::WebInspectorProxy::platformOpen): Create the window for inspector.
(WebKit::WebInspectorProxy::platformDidClose): Close both WebView & window of inspector.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Update the title of inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL): Return the absolute URL of inspector.html.
(WebKit::WebInspectorProxy::inspectorBaseURL): Return the location where inspector resources are present.
WebProcess is given read access to this folder only for loading file URLs by sandboxed extension.
- 19:18 Changeset [96382] by
-
[EFL] Use C++ type cast instead of C style type cast
https://bugs.webkit.org/show_bug.cgi?id=68321
Reviewed by Martin Robinson.
This is a second step in order to be more compliant with WebKit coding style.
The second step is to change C-type casting with C++-type casting in .cpp files.
In addition, remained efl style '*' pointer placements are moved to the right place as well.
- ewk/ewk_auth_soup.cpp:
- ewk/ewk_contextmenu.cpp:
- ewk/ewk_frame.cpp:
- ewk/ewk_history.cpp:
- ewk/ewk_view.cpp:
- ewk/ewk_view_single.cpp:
- ewk/ewk_view_tiled.cpp:
- 19:09 Changeset [96381] by
-
De-virtualize JSCell::toObject
https://bugs.webkit.org/show_bug.cgi?id=68937
Reviewed by Darin Adler.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.
- runtime/JSCell.cpp:
(JSC::JSCell::toObject):
- runtime/JSCell.h:
Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
- runtime/JSObject.cpp:
- runtime/JSObject.h:
De-virtualized JSObject::toObject and JSString::toObject.
- runtime/JSString.h:
- 17:13 Changeset [96380] by
-
These tests can also time out.
- platform/chromium/test_expectations.txt:
- 17:09 Changeset [96379] by
-
Start refactoring DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=69112
Reviewed by Oliver Hunt.
Again, move JSVALUE64 code into a DFJSpeculativeJIT64.cpp
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT64.cpp: Copied from Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp.
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- 16:47 Changeset [96378] by
-
[Freetype] Some text in Planet GNOME renders in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=69099
Reviewed by Dirk Schulze.
Source/WebCore:
Test: platform/gtk/fonts/synthetic-oblique-positioning.html
Fold the oblique transform into the font matrix itself rather than transforming
the CTM of the context at render time. Not only does this fix the issue, it
prevents unnecessary work on every paint.
- platform/graphics/cairo/FontCairo.cpp:
No longer set the synthetic oblique transformation matrix on the context
when rendering the text. Instead it is now folded into the TM of the font
itself.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::initializeWithFontFace): Fold the oblique transform into the scaled font.
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
LayoutTests:
Add a test which exercises this issue. It seems the problem grows worse
as the y component of the text position increases, so position the text
about halfway down the page.
- platform/gtk/fonts/synthetic-oblique-positioning-expected.png: Added.
- platform/gtk/fonts/synthetic-oblique-positioning-expected.txt: Added.
- platform/gtk/fonts/synthetic-oblique-positioning.html: Added.
- 16:29 Changeset [96377] by
-
Refactor out trivially duplicated code in DFGJITCodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=69109
Reviewed by Oliver Hunt.
Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp
Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code
in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp.
For some function differences are trivial & make more sense to ifdef individually, and some
Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
- dfg/DFGJITCodeGenerator32_64.cpp:
- dfg/DFGJITCodeGenerator64.cpp: Copied from Source/JavaScriptCore/dfg/DFGJITCodeGenerator.cpp.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotCell):
- dfg/DFGJITCompilerInlineMethods.h:
- 16:21 Changeset [96376] by
-
Update image baselines after http://trac.webkit.org/changeset/96366. These are progressions.
- platform/chromium-mac/fast/css/font-smoothing-expected.png:
- platform/chromium-mac/fast/repaint/text-emphasis-v-expected.png:
- platform/chromium-mac/fast/text/emphasis-avoid-ruby-expected.png:
- platform/chromium-mac/fast/text/emphasis-overlap-expected.png:
- platform/chromium-mac/fast/text/soft-hyphen-4-expected.png:
- 16:17 Changeset [96375] by
-
DFG JIT should infer which uses of a variable are not aliased
https://bugs.webkit.org/show_bug.cgi?id=68593
Reviewed by Oliver Hunt.
This separates how a variable is stored (i.e. its virtual register)
from how it's predicted. Each variable now takes a
VariableAccessData as its operand, instead of the virtual register.
The VariableAccessData stores the operand and the prediction. If
multiple uses of a variable are aliased, their VariableAccessDatas
are unified.
This also adds tracking of which argument values are used. It
correctly observes that an argument value is not used, if the
argument is assigned to inside the function before being used.
This also adds tracking of which variables are live at the head of
a basic block, and separates that from a variable being live at the
tail.
Finally, this communicates to both OSR entry and OSR exit code how
a variable is predicted at a particular point in the code, rather
than just communicating how it was predicted in the entire code
block (since with this patch there is no longer the notion of a
variable having just one prediction for a code block).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ActionablePrediction.h: Added.
(JSC::actionablePredictionFromPredictedType):
(JSC::valueObeysPrediction):
(JSC::actionablePredictionToString):
(JSC::ActionablePredictions::ActionablePredictions):
(JSC::ActionablePredictions::setArgument):
(JSC::ActionablePredictions::argument):
(JSC::ActionablePredictions::setVariable):
(JSC::ActionablePredictions::variable):
(JSC::ActionablePredictions::argumentUpperBound):
(JSC::ActionablePredictions::variableUpperBound):
(JSC::ActionablePredictions::pack):
(JSC::ActionablePredictions::packVector):
- bytecode/CodeBlock.h:
- bytecode/PredictionTracker.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::nameOfVariableAccessData):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGGraph.h:
(JSC::DFG::operandIsArgument):
(JSC::DFG::VariableRecord::setFirstTime):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::local):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueSource::nodeIndexFromKind):
(JSC::DFG::ValueSource::kindFromNodeIndex):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- wtf/PackedIntVector.h: Added.
(WTF::PackedIntVector::PackedIntVector):
(WTF::PackedIntVector::operator=):
(WTF::PackedIntVector::size):
(WTF::PackedIntVector::ensureSize):
(WTF::PackedIntVector::resize):
(WTF::PackedIntVector::clearAll):
(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):
(WTF::PackedIntVector::mask):
- wtf/Platform.h:
- wtf/UnionFind.h: Added.
(WTF::UnionFind::UnionFind):
(WTF::UnionFind::find):
(WTF::UnionFind::unify):
- 16:12 Changeset [96374] by
-
Follow-up fix for <rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not
Reviewed by Simon Fraser.
Source/WebCore:
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont): Check for Hoefler Text Black Italic as well.
LayoutTests:
Added Hoefler Text Black Italic to the test case.
- fast/text/line-initial-and-final-swashes.html:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
- 16:09 Changeset [96373] by
-
Build fix.
- 15:52 Changeset [96372] by
-
Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100
Reviewed by Geoff Garen.
This gives us the ability to walk all the MarkedBlocks in an
AllocationSpace and collect the dirty objects, and then use
them as GC roots.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
- heap/AllocationSpace.cpp:
Tidy up the write barrier logic a bit
(JSC::MarkedBlock::gatherDirtyObjects):
(JSC::TakeIfDirty::returnValue):
(JSC::TakeIfDirty::TakeIfDirty):
(JSC::TakeIfDirty::operator()):
(JSC::AllocationSpace::gatherDirtyObjects):
- heap/AllocationSpace.h:
- heap/CardSet.h:
(JSC::::isCardMarked):
(JSC::::clearCard):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- heap/Heap.h:
(JSC::Heap::writeBarrier):
- heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
- heap/SlotVisitor.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
Tidy the write barrier a bit
- 15:42 Changeset [96371] by
-
Merge 96151 - Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
BUG=98161
Review URL: http://codereview.chromium.org/8082012
- 15:39 Changeset [96370] by
-
Merge 96341 - We should ignore the return value of GetRealNamedProperty
BUG=96885
Review URL: http://codereview.chromium.org/8090001
- 15:35 Changeset [96369] by
-
Merge 96294 - <rdar://problem/10196497> first-letter after list marker not updated correctly
BUG=98064
Review URL: http://codereview.chromium.org/8085012
- 15:33 Changeset [96368] by
-
Merge 96260 - JavaScript generated documents don't inherit the cookie URL
BUG=98407
Review URL: http://codereview.chromium.org/8083016
- 15:25 Changeset [96367] by
-
Attempt to make this tool work on Windows.
- Scripts/run-api-tests:
(buildTestTool):
- 15:21 Changeset [96366] by
-
Enable LCD text in Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=68734
Reviewed by Stephen White.
No new tests. Existing layout tests are generated
with LCD text disabled for pixel comparisons.
Duplicate the logic in FontMac.mm to pass settings
for antialiasing and smoothing. Also disable smoothing
for DumpRenderTree.
- platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):
- 15:16 Changeset [96365] by
-
Implement flick gesture in Chromium Gesture Recognizer
https://bugs.webkit.org/show_bug.cgi?id=67930
Reviewed by Dimitri Glazkov.
Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp
- platform/chromium/GestureRecognizerChromium.cpp: (WebCore::GestureRecognizerChromium::isOverMinFlickSpeed): (WebCore::GestureRecognizerChromium::appendScrollGestureEnd): (WebCore::GestureRecognizerChromium::updateValues): (WebCore::GestureRecognizerChromium::scrollEnd):
- platform/chromium/GestureRecognizerChromium.h:
Patch by Varun Jain <varunjain@google.com> on 2011-09-29
- 15:14 Changeset [96364] by
-
[chromium] canvas.toDataURL("image/jpeg"): use libjpeg-turbo data swizzle
https://bugs.webkit.org/show_bug.cgi?id=67402
Reviewed by Kenneth Russell.
libjpeg-turbo can read directly from the input data for the premultiplied BRGX
(SkBitmap) encoding case.
No change in behavior, covered by existing canvas 2d/3d tests
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html
- platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::encodePixels): If JCS_EXTENSIONS is defined (libjpeg-turbo), swizzle
the input BRGX pixels directly within libjpeg-turbo.
- 15:13 Changeset [96363] by
-
Unreviewed windows build fix.
- assembler/MacroAssemblerCodeRef.h:
- dfg/DFGOperations.h:
- 15:02 Changeset [96362] by
-
[EFL] API to get plain text of the frame
https://bugs.webkit.org/show_bug.cgi?id=67114
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-29
Reviewed by Ryosuke Niwa.
Add a function to return a frame's contents converted to plain text,
as already exposed by other ports and needed by DRT when dumping a
frame's contents.
- ewk/ewk_frame.cpp:
(ewk_frame_plain_text_get):
- ewk/ewk_frame.h:
- 14:58 Changeset [96361] by
-
This test can also time out.
- platform/chromium/test_expectations.txt:
- 14:29 Changeset [96360] by
-
[Qt] Try to fix the minial build
- QtTestBrowser/launcherwindow.cpp:
- QtTestBrowser/webpage.cpp:
- 14:15 Changeset [96359] by
-
Delete bogus expectation.
- platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.
- 14:12 Changeset [96358] by
-
Attempt to update these image results again.
- platform/chromium-cg-mac-leopard/http/tests/misc: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt:
- platform/chromium-mac/http/tests/misc/acid3-expected.png:
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
- 14:07 Changeset [96357] by
-
Fixenate the build.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):
- 13:51 Changeset [96356] by
-
Mark test as expected to fail.
- platform/chromium/test_expectations.txt:
- 13:50 Changeset [96355] by
-
[Qt][WK2] Skip all failing tests (10605!) after refactored Qt5.
Rubber-stamped by Tor Arne Vestbø.
- platform/qt-wk2/Skipped:
- 13:45 Changeset [96354] by
-
Structure transitions involving many (> 64) properties sometimes cause structure corruption
https://bugs.webkit.org/show_bug.cgi?id=69102
Reviewed by Darin Adler.
Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
don't lead to the dictionary kind being forgotten.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
- 13:31 Changeset [96353] by
-
Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=69023
Reviewed by Enrica Casucci.
Converted to removeUnrenderedTextNodesAtEnds to use InsertedNodes instead of m_firstNodeInserted
and m_lastLeafInserted. Extracted the logic to update nodes as InsertedNodes::willRemoveNode
(old one was renamed to InsertedNodes::willRemoveNodePreservingChildren).
Also extracted shouldPerformSmartReplace and addSpacesForSmartReplace out of doApply,
and rewrote the logic to obtain endNode and startNode using startOfInsertedContent and
endOfInsertedContent instead of m_firstNodeInserted and m_lastLeafInserted.
Finally, replaced the nullity checks of m_firstNodeInserted and m_lastLeafInserted in
completeHTMLReplacement by nullity checks of start and end positions.
- dom/Node.cpp:
(WebCore::Node::traversePreviousSibling): Added.
- dom/Node.h:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren): Renamed from
willRemoveNode.
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode): Extracted from
removeUnrenderedTextNodesAtEnds.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Takes firstNodeInserted instead of directly
accessing m_firstNodeInserted.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- editing/ReplaceSelectionCommand.h:
- 13:30 Changeset [96352] by
-
Shrink HTMLAnchorElement on 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69094
Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.
- html/HTMLAnchorElement.h: Pack members into a bitfield.
- 13:21 Changeset [96351] by
-
<rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/text/line-initial-and-final-swashes.html
Hoefler Text Italic enables line-initial and -final swashes by default, so disable them. This
change targets only this known-bad font rather than all fonts, because at least one font (Khmer MN)
incorrectly claims to have the line-initial feature enabled, but disabling it actually does
something different and bad (breaking some combining marks).
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::createFeatureSettingDictionary): Added this helper function.
(WebCore::cascadeToLastResortFontDescriptor): Deployed WTF_ARRAY_LENGTH().
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor): Added. Returns a font descriptor
that, in addition to having a cascade list consisting of the last resort font, also has feature
settings to disable line-initial and line-final swashes.
(WebCore::FontPlatformData::ctFont): For Hoefler Text Italic, use cascadeToLastResortAndDisableSwashesFontDescriptor().
LayoutTests:
- fast/text/line-initial-and-final-swashes.html: Added.
- platform/mac/fast/text/line-initial-and-final-swashes-expected.png: Added.
- platform/mac/fast/text/line-initial-and-final-swashes-expected.txt: Added.
- 13:14 Changeset [96350] by
-
Unreviewed: resetting baseline for code generator bindings
Unreviewed build fix
No new tests.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- 12:46 Changeset [96349] by
-
[V8, chromium] More logging to determine cause of a null
v8::Context in V8DOMWindowShell::namedItemAdded().
https://bugs.webkit.org/show_bug.cgi?id=68099
Reviewed by Adam Barth.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):
- 12:40 Changeset [96348] by
-
https://bugs.webkit.org/show_bug.cgi?id=69040
ScrollbarThemeComposite requires a ScrollView to draw scroll corner
Reviewed by Simon Fraser.
No new tests. This will be needed later.
- platform/ScrollbarThemeComposite.cpp:
(WebCore::pageForScrollView):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):
Use pageForScrollView() function which already existed in this file, used in another similar
location.
- platform/chromium/FramelessScrollView.cpp:
- platform/chromium/FramelessScrollView.h:
- platform/gtk/ScrollbarThemeGtk.cpp:
- platform/gtk/ScrollbarThemeGtk.h:
- platform/wx/ScrollbarThemeWx.cpp:
- platform/wx/ScrollbarThemeWx.h:
All these overrides are no longer needed, ScrollbarThemeComposite will do the right thing.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
Removed a special case for updatingControlTints phase. The same case is present in cross-platform
code now, and Qt doesn't have any custom subclasses of ScrollableArea or ScrollView to need
special handling.
This was added in r37377 without a bug or much ChangeLog explanation.
- 12:37 Changeset [96347] by
-
DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux
- assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- 12:37 Changeset [96346] by
-
De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=68839
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
- API/JSCallbackObject.h:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
- debugger/DebuggerActivation.h:
- runtime/Arguments.cpp:
- runtime/Arguments.h:
- runtime/Executable.cpp:
- runtime/Executable.h:
- runtime/GetterSetter.cpp:
- runtime/GetterSetter.h:
- runtime/JSActivation.cpp:
- runtime/JSActivation.h:
- runtime/JSArray.cpp:
- runtime/JSArray.h:
- runtime/JSFunction.cpp:
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSObject.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSPropertyNameIterator.h:
- runtime/JSStaticScopeObject.cpp:
- runtime/JSStaticScopeObject.h:
- runtime/JSValue.h:
- runtime/NativeErrorConstructor.cpp:
- runtime/NativeErrorConstructor.h:
- runtime/RegExpObject.cpp:
- runtime/RegExpObject.h:
- runtime/Structure.cpp:
- runtime/Structure.h:
- runtime/StructureChain.cpp:
- runtime/StructureChain.h:
Inlined the method table access and call to the visitChildren function (the only call sites
to visitChildren are here).
- heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
Changed the field name for the visitChildren function pointer to visitChildren (from
visitChildrenFunctionPtr) to make call sites less verbose.
- runtime/ClassInfo.h:
Discovered JSBoundFunction doesn't have its own ClassInfo (it used JSFunction's ClassInfo) but
overrides visitChildren, so it needs to have its own ClassInfo.
- runtime/JSBoundFunction.cpp:
- runtime/JSBoundFunction.h:
Had to move className up to make sure that the virtual destructor in JSObject wasn't
the first non-inline virtual method in JSObject (as per the comment in the file).
Also moved JSCell::visitChildrenVirtual into JSObject.h in order for it be inline-able
to mitigate the cost of an extra method call.
Also added a convenience accessor function methodTable() to JSCell to return the MethodTable to make
call sites more concise. Implementation is inline in JSObject.h.
- runtime/JSObject.h:
(JSC::JSCell::methodTable):
- runtime/JSCell.h:
Added an out of line virtual destructor to JSWrapperObject and ScopeChainNode to
appease the vtable gods. It refused to compile if there were no virtual methods in
both of these classes due to the presence of a weak vtable pointer.
- runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::~JSWrapperObject):
- runtime/JSWrapperObject.h:
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::~ScopeChainNode):
- runtime/ScopeChain.h:
Source/JavaScriptGlue:
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
- UserObjectImp.cpp:
- UserObjectImp.h:
Source/WebCore:
No new tests.
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
- WebCore.exp.in:
- bindings/js/JSAttrCustom.cpp:
- bindings/js/JSAudioContextCustom.cpp:
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSJavaScriptAudioNodeCustom.cpp:
- bindings/js/JSMessageChannelCustom.cpp:
- bindings/js/JSMessagePortCustom.cpp:
- bindings/js/JSNamedNodeMapCustom.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/JSNodeFilterCustom.cpp:
- bindings/js/JSNodeIteratorCustom.cpp:
- bindings/js/JSSVGElementInstanceCustom.cpp:
- bindings/js/JSSharedWorkerCustom.cpp:
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSTreeWalkerCustom.cpp:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- bindings/js/JSWorkerContextCustom.cpp:
- bindings/js/JSXMLHttpRequestCustom.cpp:
- bindings/js/JSXPathResultCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bridge/qt/qt_instance.cpp:
- bridge/qt/qt_runtime.cpp:
- bridge/qt/qt_runtime.h:
- 12:31 Changeset [96345] by
-
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.
https://bugs.webkit.org/show_bug.cgi?id=68687
Reviewed by Andreas Kling.
- 12:07 Changeset [96344] by
-
Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69075
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 12:03 Changeset [96343] by
-
Unreviewed, rolling out r96340.
http://trac.webkit.org/changeset/96340
https://bugs.webkit.org/show_bug.cgi?id=69098
Caused 10 tests to crash in Debug (Requested by
abarth|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-29
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
- accessibility/AccessibilityRenderObject.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
LayoutTests:
- platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
- platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.
- 11:04 Changeset [96342] by
-
Shrink FontFallbackList.
https://bugs.webkit.org/show_bug.cgi?id=69093
Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.
Reduce the size of FontFallbackList by one CPU word, decreasing memory
consumption by 300 kB (on 64-bit) when loading the full HTML5 spec.
- platform/graphics/FontCache.h:
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::generation):
Store the FontCache generation as an ushort rather than uint.
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
- platform/graphics/FontFallbackList.h:
Pack enum and bool members in a bitfield.
- 10:50 Changeset [96341] by
-
We should ignore the return value of GetRealNamedProperty
https://bugs.webkit.org/show_bug.cgi?id=68840
Reviewed by Nate Chapin.
Source/WebCore:
Instead of skipping the lookup process by using the result of real
named property, we should just indiciate that it wasn't handled by the
interceptor.
Test: http/tests/security/window-named-valueOf.html
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
LayoutTests:
- http/tests/security/window-named-valueOf-expected.txt: Added.
- http/tests/security/window-named-valueOf.html: Added.
- 10:46 Changeset [96340] by
-
ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289
Source/WebCore:
If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned
that it's generally not safe to create objects.
Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.
Reviewed by Darin Adler.
Test: platform/mac/accessibility/aria-liveregion-without-element-access.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
- accessibility/AccessibilityRenderObject.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
LayoutTests:
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
- platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.
- 10:35 Changeset [96339] by
-
[GTK] Dragging a selection does not produce a drag image
https://bugs.webkit.org/show_bug.cgi?id=69064
Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-29
Reviewed by Andreas Kling.
Moved Chromium's generic implementation of Frame::nodeImage and
Frame::dragImageForSeletion to Frame.cpp and simply excluded via
#ifdefs platforms that do not have their own implementation. Removed
all empty implementations of these functions and Qt's which was
functionally identical.
No new tests. Drag-and-drop drag image functionality changes
are incredibly difficult to test in a non-manual way.
- CMakeListsEfl.txt: Delist FrameEfl.cpp.
- GNUmakefile.list.am: Delist FrameGtk.cpp.
- WebCore.gypi: Delist removed Frame*.cpp.
- WebCore.pro: Delist FrameQt.cpp.
- page/Frame.cpp: Moved FrameChromium implementation here.
(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/chromium/FrameChromium.cpp: Removed.
- page/efl/FrameEfl.cpp: Removed.
- page/gtk/FrameGtk.cpp: Removed.
- page/qt/FrameQt.cpp: Removed.
- page/wx/FrameWx.cpp: Removed.
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::createDragImage): Call nodeImage to get
the drag image for a node.
- 10:16 Changeset [96338] by
-
[chromium skia] PNGImageEncoder: hoist constants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=68988
Reviewed by Kenneth Russell.
No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.png.*.html
fast/canvas/toDataURL-alpha.html
fast/canvas/webgl/premultiplyalpha-test.html
- platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::encodePixels): Move constant out of the encoding loop.
(WebCore::PNGImageEncoder::encode): Consistency & style: call encodePixels()
just like we do in the JPEG encoder.
- 10:05 Changeset [96337] by
-
Add unit test for CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=68622
Source/WebCore:
Minor refactoring for testability:
- Made pointInTriangle public.
- Added LayerShape to decouple LayerIntersector and GraphNode.
- Added a public wrapper function for LayerIntersector.
Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::pointInTriangle):
(WebCore::CCLayerSorter::calculateZDiff):
(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
(WebCore::CCLayerSorter::LayerIntersector::go):
(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):
- platform/graphics/chromium/cc/CCLayerSorter.h:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):
Source/WebKit/chromium:
Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.
- WebKit.gypi:
- tests/CCLayerSorterTest.cpp: Added.
(WebCore::TEST):
- 10:04 Changeset [96336] by
-
Rebaseline for r95870
https://bugs.webkit.org/show_bug.cgi?id=69090
Patch by David Reveman <reveman@chromium.org> on 2011-09-29
Reviewed by James Robinson.
- platform/chromium-gpu-cg-mac/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-cg-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
- platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
- platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.png: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.txt: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
- platform/chromium-gpu/compositing/flat-with-transformed-child-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/3d-corners-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/backface-visibility-transformed-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png.
- platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt.
- platform/chromium/test_expectations.txt:
- 09:42 Changeset [96335] by
-
Layout test demonstrating IDBCursor inconsistency bug.
https://bugs.webkit.org/show_bug.cgi?id=69012
Reviewed by Nate Chapin.
- storage/indexeddb/cursor-inconsistency-expected.txt: Added.
- storage/indexeddb/cursor-inconsistency.html: Added.
- 09:32 Changeset [96334] by
-
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235
Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
- 09:25 Changeset [96333] by
-
Generalize expected result to all of MAC.
- platform/chromium/test_expectations.txt:
- 09:24 Changeset [96332] by
-
This test can also time out.
- platform/chromium/test_expectations.txt:
- 09:20 Changeset [96331] by
-
Update expected results on Leopard. As far as I can tell, these are
progressions.
- platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png: Added.
- 09:09 Changeset [96330] by
-
Add some expected failures on Leopard.
- platform/chromium/test_expectations.txt:
- 08:46 Changeset [96329] by
-
Unbreak the "update expectatations" button by using the existing
machinery to create the failureInfo objects.
Unbreak the "close" button on the progress dialog by using |this|
instead of the old name of the object.
Teach the controllers unit test not to talk to the actual network.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 08:34 Changeset [96328] by
-
Update baselines. (Font rendering.)
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Added.
- platform/chromium-mac/http/tests/misc/acid3-expected.png: Added.
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
- 08:32 Changeset [96327] by
-
Update baselines.
- platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.
- platform/chromium-cg-mac/svg/text/selection-background-color-expected.png: Added.
- platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Added.
- platform/chromium-mac-leopard/svg/text: Added.
- platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Added.
- platform/gtk/svg/text/selection-background-color-expected.txt: Removed.
- platform/mac/svg/text/selection-background-color-expected.txt: Removed.
- svg/text/selection-background-color-expected.txt: Added.
- 07:30 Changeset [96326] by
-
Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.
https://bugs.webkit.org/show_bug.cgi?id=69087
The fix has the changes for the test and minor perf framework improvements.
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._defaultRefreshDelay.500._scheduleRefresh):
LayoutTests:
- inspector/performance/resources/network-append-30-requests.html:
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):
- 07:22 WebKitGTK/Releasing edited by
- (diff)
- 07:22 WebKitGTKStableReleases edited by
- (diff)
- 07:21 WebKitGTKStableReleases edited by
- (diff)
- 07:20 WebKitGTKStableReleases edited by
- (diff)
- 07:20 WebKitGTKStableReleases edited by
- (diff)
- 06:59 Changeset [96325] by
-
[GTK] Bump version to 1.7.0
https://bugs.webkit.org/show_bug.cgi?id=69082
Reviewed by Martin Robinson.
Apart from bumping the library version to 1.7.0 this patch also
sets the libtool version to the same one we have for the stable
branch.
- configure.ac:
- 06:53 Changeset [96324] by
-
[GTK] Force single header include in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69084
Reviewed by Martin Robinson.
Only <webkit2/webkit2.h> will be allowed for API users.
- GNUmakefile.am:
- UIProcess/API/gtk/WebKitError.h:
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebLoaderClient.h:
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewBase.h:
- UIProcess/API/gtk/webkit2.h:
- 06:44 QtWebKitRelease22 edited by
- (diff)
- 06:02 QtWebKitRelease22 edited by
- (diff)
- 05:59 Changeset [96323] by
-
Web Inspector: Make search-in-resource test simpler.
https://bugs.webkit.org/show_bug.cgi?id=69025
Source/WebCore:
Changed search-in-resource test.
Removed error parameter from content provider's searchInContent callback.
Reviewed by Pavel Feldman.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):
LayoutTests:
Reviewed by Pavel Feldman.
- http/tests/inspector/search/search-in-resource-expected.txt:
- http/tests/inspector/search/search-in-resource.html:
- http/tests/inspector/search/search-in-resources.html:
- http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):
- 05:56 QtWebKitRelease22 edited by
- (diff)
- 05:29 Changeset [96322] by
-
IndexedDB: Use LevelDB also for in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=68903
Reviewed by Steve Block.
Source/WebCore:
Add LevelDBDatabase::openInMemory() which uses leveldb::NewMemEnv()
to create in-memory LevelDB databases.
Use this in IDBLeveLDBBackingStore::open() when the caller passes in
an empty file path.
This happens in Chromium's incognito mode, and when running layout
tests.
Fix IDBSQLiteBackingStore::backingStoreExists() so it doesn't create
files when passed in an empty file path, but uses the in-memory mode
instead.
Existing layout tests will all be run in-memory.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::~LevelDBDatabase):
(WebCore::openDB):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):
- platform/leveldb/LevelDBDatabase.h:
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
- storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::backingStoreExists):
Source/WebKit/chromium:
Don't fall back to SQLite or use a temporary dir for in-memory
databases (Incognito and layout tests); LevelDB supports in-memory
databases now.
- public/WebIDBFactory.h:
- src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
Tools:
Remove the temporary dir that was necessary before LevelDB supported
in-memory databases.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h:
- 04:59 Changeset [96321] by
-
Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
https://bugs.webkit.org/show_bug.cgi?id=69081
There is a test with 30 requests.
For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.
Reviewed by Pavel Feldman.
Test: inspector/performance/resources/network-append-30-requests.html
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype._refreshResource):
- 04:49 Changeset [96320] by
-
Web Inspector: make inspector protocol validation a part of the build process.
https://bugs.webkit.org/show_bug.cgi?id=68999
Since we'd like to commit to inspector protocol backwards compatibility, violating it
should be a build failure.
Reviewed by Yury Semikhatsky.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- inspector/Inspector.draft-01.json:
- inspector/Inspector.json:
- inspector/generate-inspector-idl:
- inspector/generate-protocol-externs:
- inspector/validate-protocol-compatibility:
- 04:39 Changeset [96319] by
-
Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
LayoutTests:
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
- platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
- platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
- platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.
- 04:06 Changeset [96318] by
-
2011-09-28 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: network log view refresh optimizations
https://bugs.webkit.org/show_bug.cgi?id=69010
Reviewed by Pavel Feldman.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView.prototype.refresh):
- 04:00 Changeset [96317] by
-
[GTK] Explicitly call destructors for objects initialized with placement new syntax
https://bugs.webkit.org/show_bug.cgi?id=69079
Reviewed by Xan Lopez.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):
- 03:33 Changeset [96316] by
-
LayoutTests: media/video-does-not-loop.html failing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=69067
Patch by Arun Patole <bmf834@motorola.com> on 2011-09-29
Reviewed by Philippe Normand.
Update expected test result for video-does-not-loop.html
as the 'pause' event should be fired at the end of playback.
- media/video-does-not-loop-expected.txt:
- 03:30 Changeset [96315] by
-
[Chromium] some Layout Tests in editing/ is failing
https://bugs.webkit.org/show_bug.cgi?id=69078
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 03:07 Changeset [96314] by
-
[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-javascript-doc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69077
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 01:46 WebKitGTK/Releasing edited by
- Confirmed that patch is required even for make-3.82 (diff)
- 01:44 Changeset [96313] by
-
Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.
https://bugs.webkit.org/show_bug.cgi?id=69068
Reviewed by Yury Semikhatsky.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js.
(WebInspector.RawSourceCode): Moved from SourceFile.js.
(WebInspector.UILocation): Moved from SourceFile.js.
- inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 01:36 Changeset [96312] by
-
[Chromium] Layout Test svg/filters/animate-fill.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=69070
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 01:07 Changeset [96311] by
-
[GStreamer] 2 flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=67407
Reviewed by Martin Robinson.
Workaround for GStreamer bug#639941. In GStreamer
0.10.35 basesink reports wrong duration in case of EOS and
negative playback rate. This workaround fixes two media tests,
media/video-timeupdate-reverse-play.html and
media/video-reverse-play-duration.html.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
- 01:03 Changeset [96310] by
-
[GStreamer] fullscreen video pause/play fails
https://bugs.webkit.org/show_bug.cgi?id=66936
Reviewed by Martin Robinson.
Don't use the identity element to avoid painting of the in-window
video. Instead simply make the sink aware of the fullscreen state
and ignore buffers if fullscreen and autovideosink are
active. Also fixed two deadlocks happening when a paused pipeline
is switched to fullscreen and when fullscreen is disabled for a
paused pipeline.
- platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
- platform/graphics/gstreamer/GStreamerGWorld.h:
(WebCore::GStreamerGWorld::isFullscreen):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_render):
(webkit_video_sink_new):
- platform/graphics/gstreamer/VideoSinkGStreamer.h:
- 00:52 Changeset [96309] by
-
JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.
- dfg/DFGNode.h:
- 00:33 Changeset [96308] by
-
Hopefully the last Chromium test expectation update for r96294.
- platform/chromium/test_expectations.txt:
- 00:23 Changeset [96307] by
-
REGRESSION(87010): elements in ECMA-cloud neither filled nor blurred
https://bugs.webkit.org/show_bug.cgi?id=68679
<rdar://problem/10204649>
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Strip prefixes from SVG attributes before testing if they're supported.
Namespaced attributes will be matched using their namespace instead of
the (user-choosable) prefix.
Test: svg/custom/xlink-custom-namespace.svg
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::isSupportedAttribute):
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::isSupportedAttribute):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isSupportedAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
- svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::isSupportedAttribute):
- svg/SVGElement.h:
(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
- svg/SVGExternalResourcesRequired.h:
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::isSupportedAttribute):
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::isSupportedAttribute):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::isSupportedAttribute):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::isSupportedAttribute):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::isSupportedAttribute):
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::isSupportedAttribute):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::isSupportedAttribute):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::isSupportedAttribute):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::isSupportedAttribute):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::isSupportedAttribute):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::isSupportedAttribute):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::isSupportedAttribute):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::isSupportedAttribute):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::isSupportedAttribute):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::isSupportedAttribute):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::isSupportedAttribute):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isSupportedAttribute):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::isSupportedAttribute):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::isSupportedAttribute):
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isSupportedAttribute):
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::isSupportedAttribute):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::isSupportedAttribute):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isSupportedAttribute):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::isSupportedAttribute):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::isSupportedAttribute):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::isSupportedAttribute):
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::addSupportedAttributes):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::isSupportedAttribute):
LayoutTests:
Add a test ensuring that using xlink:href with a different prefix (i.e. xl:href)
works correctly.
- svg/custom/xlink-custom-namespace-expected.png: Added.
- svg/custom/xlink-custom-namespace-expected.txt: Added.
- svg/custom/xlink-custom-namespace.svg: Added.
- 00:12 Changeset [96306] by
-
DFG checkArgumentTypes fails to check boolean predictions
https://bugs.webkit.org/show_bug.cgi?id=69059
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
LayoutTests:
- fast/js/boolean-argument-prediction-expected.txt: Added.
- fast/js/boolean-argument-prediction.html: Added.
- fast/js/script-tests/boolean-argument-prediction.js: Added.
(predictBooleanArgument):
09/28/11:
- 23:32 Changeset [96305] by
-
Chromium test_expectations update for isindex-with-no-form.html
- platform/chromium/test_expectations.txt:
- 23:27 Changeset [96304] by
-
[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062
Chromium test_expectations update
- platform/chromium/test_expectations.txt:
- 23:24 Changeset [96303] by
-
Chromium rebaseline after r96294.
- platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- 23:11 Changeset [96302] by
-
Yet another Chromium linux rebaseline after r96257.
- platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
- platform/chromium/test_expectations.txt:
- 23:07 Changeset [96301] by
-
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
https://bugs.webkit.org/show_bug.cgi?id=68984
Reviewed by Darin Adler.
Just a follow-up fix for the bug 68345. For performance,
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&".
Tests: fast/events/constructors/pop-state-event-constructor.html
fast/events/fire-popstate-event.html
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::initPopStateEvent):
- dom/PopStateEvent.h:
- 23:03 Changeset [96300] by
-
[Qt] Unreviewed gardening after r96257.
- platform/qt-4.8/editing/inserting/4278698-expected.png:
- platform/qt-4.8/editing/inserting/4278698-expected.txt:
- platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png:
- platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt:
- platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png:
- platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt:
- 23:02 Changeset [96299] by
-
[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=66890
Source/WebCore:
Added a GtkDragAndDropHelper class to hold all the logic that is common
between WebKit1 and WebKit2. This will allow greater code sharing between
the two ports.
Reviewed by Philippe Normand.
No new tests. This patch should not change behavior.
- GNUmakefile.list.am: Added the GtkDragAndDropHelper to the sources list.
- platform/gtk/GtkDragAndDropHelper.cpp: Added.
- platform/gtk/GtkDragAndDropHelper.h: Added.
Source/WebKit/gtk:
Use the new GtkWidgetDragAndDropGlue class to hold the logic that will be
common between WebKit1 and WebKit2. Modify WebKitWebView to use this class.
Reviewed by Philippe Normand.
- WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag): Inform the drag-and-drop glue about the drag.
- webkit/webkitwebview.cpp: Use GtkWidgetDragAndDropGlue wherever this class was
maintaining drag-and-drop state itself.
- webkit/webkitwebviewprivate.h: Swap out the drag-and-drop state for an instance
of the glue class.
- 23:01 Changeset [96298] by
-
Update Chromium test expectation and also add back the expected result erroneously removed in r96284.
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
- platform/mac/editing/pasteboard/paste-text-006-expected.txt: Added.
- 22:43 Changeset [96297] by
-
Chromium rebaselines for r96257 part 2.
- editing/deleting/delete-line-011-expected.txt: Added.
- editing/deleting/delete-tab-001-expected.txt: Added.
- editing/deleting/delete-tab-002-expected.txt: Added.
- editing/deleting/delete-tab-003-expected.txt: Added.
- editing/deleting/delete-tab-004-expected.txt: Added.
- editing/deleting/smart-delete-002-expected.txt: Added.
- editing/inserting/insert-text-with-newlines-expected.txt: Added.
- editing/style/smoosh-styles-003-expected.txt: Added.
- editing/style/style-3681552-fix-001-expected.txt: Added.
- editing/style/style-boundary-002-expected.txt: Added.
- editing/style/style-boundary-003-expected.txt: Added.
- editing/style/typing-style-001-expected.txt: Added.
- editing/style/typing-style-002-expected.txt: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-cg-mac/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-linux-x86/editing: Added.
- platform/chromium-linux-x86/editing/pasteboard: Added.
- platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-linux-x86/editing/style: Added.
- platform/chromium-linux-x86/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
- platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
- platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/chromium-linux/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-win-vista/editing/deleting: Removed.
- platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand: Removed.
- platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Removed.
- platform/chromium-win-vista/editing/inserting: Removed.
- platform/chromium-win-vista/editing/inserting/4278698-expected.png: Removed.
- platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Removed.
- platform/chromium-win-vista/editing/selection: Removed.
- platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Removed.
- platform/chromium-win-vista/editing/style: Added.
- platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-win-vista/editing/undo: Removed.
- platform/chromium-win-vista/editing/undo/4063751-expected.png: Removed.
- platform/chromium-win-vista/editing/unsupported-content: Removed.
- platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Removed.
- platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Removed.
- platform/chromium-win-xp/editing/pasteboard: Added.
- platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-win-xp/editing/style: Added.
- platform/chromium-win-xp/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-win-xp/fast/events: Removed.
- platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Added.
- platform/chromium-win/editing/deleting/delete-line-011-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
- platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
- platform/chromium-win/editing/spelling/spelling-expected.txt:
- platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
- platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
- platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
- platform/chromium-win/editing/style/style-boundary-002-expected.txt:
- platform/chromium-win/editing/style/style-boundary-003-expected.txt:
- platform/chromium-win/editing/style/style-boundary-005-expected.txt:
- platform/chromium-win/editing/style/typing-style-001-expected.txt:
- platform/chromium-win/editing/style/typing-style-002-expected.txt:
- platform/chromium-win/fast/events/updateLayoutForHitTest-expected.png:
- platform/chromium-win/fast/events/updateLayoutForHitTest-expected.txt:
- platform/gtk/editing/deleting/delete-line-011-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-002-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-003-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-004-expected.txt: Removed.
- platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
- platform/gtk/editing/style/smoosh-styles-003-expected.txt: Removed.
- platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Removed.
- platform/gtk/editing/style/style-boundary-002-expected.txt: Removed.
- platform/gtk/editing/style/style-boundary-003-expected.txt: Removed.
- platform/gtk/editing/style/typing-style-001-expected.txt: Removed.
- platform/gtk/editing/style/typing-style-002-expected.txt: Removed.
- platform/gtk/fast/repaint/selection-clear-expected.txt: Removed.
- platform/mac/editing/deleting/delete-line-011-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-001-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-002-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-003-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-004-expected.txt: Removed.
- platform/mac/editing/deleting/smart-delete-002-expected.txt: Removed.
- platform/mac/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
- platform/mac/editing/style/smoosh-styles-003-expected.txt: Removed.
- platform/mac/editing/style/style-3681552-fix-001-expected.txt: Removed.
- platform/mac/editing/style/style-boundary-002-expected.txt: Removed.
- platform/mac/editing/style/style-boundary-003-expected.txt: Removed.
- platform/mac/editing/style/typing-style-001-expected.txt: Removed.
- platform/mac/editing/style/typing-style-002-expected.txt: Removed.
- 21:55 Changeset [96296] by
-
Remove some of Chromium test expectations temporarily added for r96257.
- platform/chromium/test_expectations.txt:
- 21:48 Changeset [96295] by
-
.: Fix the WebKit2 WebGL build.
- configure.ac: Add -ldl to the OPENGL_LIBS.
Source/WebKit2: Fix the WebGL build on WebKit2 GTK+.
- GNUmakefile.am: Add OPENGL_LIBS to WebKit2 targets.
- 21:12 Changeset [96294] by
-
<rdar://problem/10196497> first-letter after list marker not updated correctly
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/dynamic/first-letter-after-list-marker.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter): Improved the logic for continuing past list markers
when trying to locate a first letter to update.
LayoutTests:
- fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- fast/dynamic/first-letter-after-list-marker-expected.txt: Added.
- fast/dynamic/first-letter-after-list-marker.html: Added.
- 21:00 Changeset [96293] by
-
Build fix pt 2 for r96286.
- assembler/MacroAssemblerCodeRef.h:
- 20:57 Changeset [96292] by
-
Add a test for accesskey in regard to iframes.
https://bugs.webkit.org/show_bug.cgi?id=67642
Reviewed by Hajime Morita.
To catch any improvement of accesskey behavior in regard to
iframes, it'd be nice to add a test to verify the current behavior.
- fast/dom/access-key-iframe-expected.txt: Added.
- fast/dom/access-key-iframe.html: Added.
- 19:52 Changeset [96291] by
-
[EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
https://bugs.webkit.org/show_bug.cgi?id=68594
As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
isn't effective at all, this patch just removes it.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
- ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_zoom_set_internal):
- 19:49 Changeset [96290] by
-
REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 231
https://bugs.webkit.org/show_bug.cgi?id=68981
Reviewed by Darin Adler.
Source/WebCore:
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLInteger):
Check the failure of charactersToIntStrict().
(WebCore::parseHTMLNonNegativeInteger):
Check the failure of charactersToUIntStrict().
LayoutTests:
- fast/forms/input-text-paste-maxlength-expected.txt:
- fast/forms/input-text-paste-maxlength.html:
- 19:37 Changeset [96289] by
-
Run TestWebKitAPI on Chromium buildbots
https://bugs.webkit.org/show_bug.cgi?id=68678
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 19:32 Changeset [96288] by
-
Build fix attempt for r96286.
- assembler/MacroAssemblerCodeRef.h:
- 19:27 Changeset [96287] by
-
[EFL] Bump minimum requirement for eina.
https://bugs.webkit.org/show_bug.cgi?id=68994
Reviewed by Ryosuke Niwa.
- Source/cmake/FindEFL.cmake:
- 18:36 Changeset [96286] by
-
DFG JIT Operations on 32_64 should use stdcall calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69046
Reviewed by Sam Weinig.
All calls out are expecting stdcall conventions, but the default on OS X are cdecl.
Leave D_DFGOperation_DD calls as the one exception, since we want to be able to link
directly to std library functions like fmod - leave these calls obeying the default
platform calling convention.
- assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- Add implicit constructors for std calls.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- Make this work non-Mac platforms.
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
- Mark all operations as stdcalls.
- 18:34 Changeset [96285] by
-
One last GTK rebaseline for r96257.
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- 18:31 Changeset [96284] by
-
Chromium rebaseline for r96257 part 2.
- platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
- platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/undo: Added.
- platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/unsupported-content: Added.
- platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/chromium-cg-mac/editing/deleting/table-cells-expected.png:
- platform/chromium-cg-mac/editing/execCommand/create-list-with-hr-expected.png: Added.
- platform/chromium-cg-mac/editing/execCommand/find-after-replace-expected.png: Added.
- platform/chromium-cg-mac/editing/execCommand/paste-1-expected.png: Added.
- platform/chromium-cg-mac/editing/execCommand/paste-2-expected.png: Added.
- platform/chromium-cg-mac/editing/inserting/4278698-expected.png: Added.
- platform/chromium-cg-mac/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/3976872-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/chromium-cg-mac/editing/selection/select-all-iframe-expected.png: Added.
- platform/chromium-cg-mac/editing/undo: Added.
- platform/chromium-cg-mac/editing/undo/4063751-expected.png: Added.
- platform/chromium-cg-mac/editing/unsupported-content: Added.
- platform/chromium-cg-mac/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/chromium-cg-mac/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/chromium-linux/editing/deleting/table-cells-expected.png:
- platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-linux/editing/execCommand/paste-1-expected.png:
- platform/chromium-linux/editing/execCommand/paste-2-expected.png:
- platform/chromium-linux/editing/inserting/4278698-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-linux/editing/pasteboard/3976872-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-expected.png:
- platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
- platform/chromium-linux/editing/undo/4063751-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-mac/editing/deleting/table-cells-expected.png:
- platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-mac/editing/execCommand/paste-1-expected.png:
- platform/chromium-mac/editing/execCommand/paste-2-expected.png:
- platform/chromium-mac/editing/inserting/4278698-expected.png:
- platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-mac/editing/pasteboard/3976872-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-expected.png:
- platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png:
- platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
- platform/chromium-mac/editing/undo/4063751-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-win-vista/editing: Added.
- platform/chromium-win-vista/editing/deleting: Added.
- platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand: Added.
- platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Added.
- platform/chromium-win-vista/editing/inserting: Added.
- platform/chromium-win-vista/editing/inserting/4278698-expected.png: Added.
- platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard: Added.
- platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/chromium-win-vista/editing/selection: Added.
- platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Added.
- platform/chromium-win-vista/editing/undo: Added.
- platform/chromium-win-vista/editing/undo/4063751-expected.png: Added.
- platform/chromium-win-vista/editing/unsupported-content: Added.
- platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/chromium-win/editing/deleting/table-cells-expected.png:
- platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-win/editing/execCommand/paste-1-expected.png:
- platform/chromium-win/editing/execCommand/paste-2-expected.png:
- platform/chromium-win/editing/inserting/4278698-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-win/editing/pasteboard/3976872-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-win/editing/selection/select-all-iframe-expected.png:
- platform/chromium-win/editing/undo/4063751-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.
- 18:28 Changeset [96283] by
-
Remove unused createRootLayerPainter from CCLayerTreeHostClient
https://bugs.webkit.org/show_bug.cgi?id=69042
Patch by Antoine Labour <piman@chromium.org> on 2011-09-28
Reviewed by James Robinson.
No new test needed: no semantic change.
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- 18:03 clutter edited by
- (diff)
- 18:03 Changeset [96282] by
-
garden-o-matic results should anticipate 0 unexpected failures.
https://bugs.webkit.org/show_bug.cgi?id=69036
Also fixes controllers: UnexpectedFailures test.
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
- 18:01 Changeset [96281] by
-
Only resolve direction aware properties when properties are direction aware.
https://bugs.webkit.org/show_bug.cgi?id=68968
Reviewed by Eric Seidel.
No new tests / no functionality changed.
Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 17:47 Changeset [96280] by
-
DFG JIT falls back on numerical comparisons when it does not
recognize a prediction
https://bugs.webkit.org/show_bug.cgi?id=68977
Reviewed by Geoffrey Garen.
This fixes both the way comparison implementations are selected. It
also fixes a bug where comparisons other than equality (like < or >)
on objects are compiled as if the comparison was equality.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
- 17:45 Changeset [96279] by
-
ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=69037
Reviewed by Alexey Proskuryakov.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runOpenPanel):
If no delegate is implemented, dismiss the listener
with a cancel. It expects some action.
- 17:45 Changeset [96278] by
-
fast/dom/scroll-element-to-rect.html fails on WK1 Mac port
https://bugs.webkit.org/show_bug.cgi?id=68815
Source/WebCore:
Reviewed by Dan Bernstein.
FrameView::scrollElementToRect() was incorrectly using Element::boundsInWindowSpace(),
which is window-relative (not web view-relative), and has flipped coordinates
in WebKit1.
Change to use Node::getRect() which is what the author intended.
- dom/Element.h:
- page/FrameView.cpp:
(WebCore::FrameView::scrollElementToRect):
LayoutTests:
Reviewed by Dan Bernstein.
Fix these tests to not throw errors when window.internals is not available.
- fast/dom/scroll-element-to-rect-centered.html:
- fast/dom/scroll-element-to-rect.html:
- 17:32 Changeset [96277] by
-
Qt rebsaeline after r96257. It seems like the difference is coming from the font used in select element.
- platform/qt/editing/pasteboard/select-element-1-expected.txt: Copied from
LayoutTests/editing/pasteboard/select-element-1-expected.txt.
- 17:29 Changeset [96276] by
-
Don't clamp cubic-bezier timing functions between 0 and 1
https://bugs.webkit.org/show_bug.cgi?id=45761
Source/WebCore:
Remove the limitation of clamping the cubic-bezier timing function
values between 0 and 1, following the specification change made on
April 5 of this year.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.
Tests: transitions/cubic-bezier-overflow-color.html
transitions/cubic-bezier-overflow-length.html
transitions/cubic-bezier-overflow-shadow.html
transitions/cubic-bezier-overflow-svg-length.html
transitions/cubic-bezier-overflow-transform.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
LayoutTests:
Test overflow behavior of colors, lengths, svg lengths,
shadows and transforms (through rotations). Update the
timing function test to check for now valid values.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.
- fast/css/transition-timing-function-expected.txt:
- fast/css/transition-timing-function.html:
- transitions/cubic-bezier-overflow-color-expected.txt: Added.
- transitions/cubic-bezier-overflow-color.html: Added.
- transitions/cubic-bezier-overflow-length-expected.txt: Added.
- transitions/cubic-bezier-overflow-length.html: Added.
- transitions/cubic-bezier-overflow-shadow-expected.txt: Added.
- transitions/cubic-bezier-overflow-shadow.html: Added.
- transitions/cubic-bezier-overflow-svg-length-expected.txt: Added.
- transitions/cubic-bezier-overflow-svg-length.html: Added.
- transitions/cubic-bezier-overflow-transform-expected.txt: Added.
- transitions/cubic-bezier-overflow-transform.html: Added.
- 17:24 Changeset [96275] by
-
More GTK rebaselines after r96257.
- platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/gtk/editing/deleting/delete-line-005-expected.txt:
- platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/gtk/editing/deleting/regional-indicators-expected.txt:
- platform/gtk/editing/deleting/table-cells-expected.txt:
- platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- 17:21 Changeset [96274] by
-
Remove Chromium failing expectations for tests that now pass.
- platform/chromium/test_expectations.txt:
- 17:20 Changeset [96273] by
-
Chromium rebaseline for r96257 part 1.
- platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Removed.
- platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
- platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
- platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
- platform/chromium-linux/editing/deleting/table-cells-expected.png:
- platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-linux/editing/execCommand/paste-1-expected.png:
- platform/chromium-linux/editing/execCommand/paste-2-expected.png:
- platform/chromium-linux/editing/inserting/4278698-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-linux/editing/pasteboard/3976872-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-expected.png:
- platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-linux/editing/selection/node-removal-1-expected.png:
- platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
- platform/chromium-linux/editing/undo/4063751-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-mac/editing/deleting/table-cells-expected.png:
- platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-mac/editing/execCommand/paste-1-expected.png:
- platform/chromium-mac/editing/execCommand/paste-2-expected.png:
- platform/chromium-mac/editing/inserting/4278698-expected.png:
- platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-mac/editing/pasteboard/3976872-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-expected.png:
- platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-mac/editing/selection/node-removal-1-expected.png:
- platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
- platform/chromium-mac/editing/undo/4063751-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-win-xp/editing/pasteboard: Removed.
- platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3775172-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3857753-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3865854-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3928305-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
- platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-contents-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-contents-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-contents-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-008-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-first-list-item-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-006-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-007-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-008-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-009-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-012-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-013-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-014-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-015-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-016-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-017-expected.txt:
- platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-listitem-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/chromium-win/editing/deleting/forward-delete-expected.txt:
- platform/chromium-win/editing/deleting/list-item-1-expected.txt:
- platform/chromium-win/editing/deleting/merge-different-styles-expected.txt:
- platform/chromium-win/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
- platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
- platform/chromium-win/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
- platform/chromium-win/editing/deleting/table-cells-expected.png:
- platform/chromium-win/editing/deleting/table-cells-expected.txt:
- platform/chromium-win/editing/execCommand/4641880-1-expected.txt:
- platform/chromium-win/editing/execCommand/4641880-2-expected.txt:
- platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
- platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
- platform/chromium-win/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/chromium-win/editing/execCommand/indent-list-item-expected.txt:
- platform/chromium-win/editing/execCommand/indent-selection-expected.txt:
- platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/chromium-win/editing/execCommand/nsresponder-indent-expected.txt:
- platform/chromium-win/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/chromium-win/editing/execCommand/paste-1-expected.png:
- platform/chromium-win/editing/execCommand/paste-1-expected.txt:
- platform/chromium-win/editing/execCommand/paste-2-expected.png:
- platform/chromium-win/editing/execCommand/paste-2-expected.txt:
- platform/chromium-win/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/chromium-win/editing/execCommand/remove-list-item-1-expected.txt:
- platform/chromium-win/editing/inserting/4278698-expected.png:
- platform/chromium-win/editing/inserting/4278698-expected.txt:
- platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
- platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
- platform/chromium-win/editing/inserting/insert-3775316-fix-expected.txt:
- platform/chromium-win/editing/inserting/insert-3851164-fix-expected.txt:
- platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
- platform/chromium-win/editing/inserting/insert-at-end-01-expected.txt:
- platform/chromium-win/editing/inserting/insert-at-end-02-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-001-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-005-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-001-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-002-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-005-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-007-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-009-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-010-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-020-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-023-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-025-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-026-expected.txt:
- platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/chromium-win/editing/inserting/multiple-lines-selected-expected.txt:
- platform/chromium-win/editing/inserting/paragraph-separator-03-expected.txt:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/chromium-win/editing/inserting/redo-expected.txt:
- platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/chromium-win/editing/inserting/typing-001-expected.txt:
- platform/chromium-win/editing/inserting/typing-002-expected.txt:
- platform/chromium-win/editing/inserting/typing-003-expected.txt:
- platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
- platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
- platform/chromium-win/editing/pasteboard/3976872-expected.png:
- platform/chromium-win/editing/pasteboard/3976872-expected.txt:
- platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
- platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
- platform/chromium-win/editing/pasteboard/4076267-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-expected.txt:
- platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
- platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
- platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
- platform/chromium-win/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/chromium-win/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-after-delete-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-004-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
- platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/chromium-win/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/chromium-win/editing/selection/node-removal-1-expected.png:
- platform/chromium-win/editing/selection/node-removal-1-expected.txt:
- platform/chromium-win/editing/selection/node-removal-2-expected.txt:
- platform/chromium-win/editing/selection/replace-selection-1-expected.txt:
- platform/chromium-win/editing/selection/select-all-iframe-expected.png:
- platform/chromium-win/editing/selection/select-all-iframe-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-001-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-002-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-003-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-004-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-007-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-009-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-010-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-011-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-012-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-013-expected.txt:
- platform/chromium-win/editing/style/designmode-expected.txt:
- platform/chromium-win/editing/style/relative-font-size-change-001-expected.txt:
- platform/chromium-win/editing/style/relative-font-size-change-002-expected.txt:
- platform/chromium-win/editing/style/smoosh-styles-001-expected.txt:
- platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
- platform/chromium-win/editing/style/smoosh-styles-003-expected.txt:
- platform/chromium-win/editing/style/style-3998892-fix-expected.txt:
- platform/chromium-win/editing/style/style-boundary-001-expected.txt:
- platform/chromium-win/editing/style/style-boundary-004-expected.txt:
- platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
- platform/chromium-win/editing/undo/4063751-expected.png:
- platform/chromium-win/editing/undo/4063751-expected.txt:
- platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
- platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
- platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
- platform/chromium-win/editing/undo/undo-delete-expected.txt:
- platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
- platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
- platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-delete-001-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-delete-003-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-delete-001-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-delete-002-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-delete-003-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:
- platform/chromium-win/fast/dynamic/move-node-with-selection-expected.txt:
- platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
- platform/gtk/editing/deleting/delete-br-010-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-div-010-expected.txt: Removed.
- platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Removed.
- platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
- 17:09 Changeset [96272] by
-
Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
https://bugs.webkit.org/show_bug.cgi?id=67253
Reviewed by Eric Seidel.
Tools:
Nearly all of the work in this was done by Simon Fraser; I'm
just repackaging it and cleaning it up a bit. This change
modifies port.diff_image() to return a tuple of (pass/fail,
%age), adds the value to the FailureImageHashMismatch, and
writes the value into the full_results.json files to be
displayed in the results page.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/models/test_failures.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
LayoutTests:
- fast/harness/resources/results-test.js:
(mockExpectation):
(runDefaultSingleRowTest):
():
- fast/harness/results.html:
- 17:09 Changeset [96271] by
-
WinCairo build fix.
- WebProcess/WebPage/WebFrame.h: Add include of <wtc/RetainPtr.h>
- 17:06 Changeset [96270] by
-
DelayNode must set the context on delayTime AudioParam to support automation
https://bugs.webkit.org/show_bug.cgi?id=68828
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/delaynode-scheduling.html
- webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
LayoutTests:
- webaudio/delaynode-scheduling-expected.txt: Added.
- webaudio/delaynode-scheduling.html: Added.
- webaudio/delaynode.html:
- webaudio/resources/delay-testing.js: Added.
(createToneBuffer):
(checkDelayedResult.return.var):
(checkDelayedResult):
- 17:02 Changeset [96269] by
-
More Mac rebaselines for r96257.
- platform/mac/editing/execCommand/insertHorizontalRule-expected.png:
- platform/mac/editing/selection/node-removal-1-expected.png:
- 17:00 Changeset [96268] by
-
Add myself to committers.py
- 16:56 Changeset [96267] by
-
Add failing Chromium expectations after r96257.
- platform/chromium/test_expectations.txt:
- 16:24 Changeset [96266] by
-
GTK rebaseline for r96257.
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/gtk/editing/deleting/delete-and-undo-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/gtk/editing/deleting/delete-br-008-expected.txt:
- platform/gtk/editing/deleting/delete-br-010-expected.txt:
- platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-first-list-item-expected.txt:
- platform/gtk/editing/deleting/delete-image-001-expected.txt:
- platform/gtk/editing/deleting/delete-image-002-expected.txt:
- platform/gtk/editing/deleting/delete-image-003-expected.txt:
- platform/gtk/editing/deleting/delete-image-004-expected.txt:
- platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-002-expected.txt:
- platform/gtk/editing/deleting/delete-line-003-expected.txt:
- platform/gtk/editing/deleting/delete-line-004-expected.txt:
- platform/gtk/editing/deleting/delete-line-005-expected.txt:
- platform/gtk/editing/deleting/delete-line-006-expected.txt:
- platform/gtk/editing/deleting/delete-line-007-expected.txt:
- platform/gtk/editing/deleting/delete-line-008-expected.txt:
- platform/gtk/editing/deleting/delete-line-009-expected.txt:
- platform/gtk/editing/deleting/delete-line-010-expected.txt:
- platform/gtk/editing/deleting/delete-line-011-expected.txt:
- platform/gtk/editing/deleting/delete-line-012-expected.txt:
- platform/gtk/editing/deleting/delete-line-013-expected.txt:
- platform/gtk/editing/deleting/delete-line-014-expected.txt:
- platform/gtk/editing/deleting/delete-line-015-expected.txt:
- platform/gtk/editing/deleting/delete-line-016-expected.txt:
- platform/gtk/editing/deleting/delete-line-017-expected.txt:
- platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
- platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
- platform/gtk/editing/deleting/delete-selection-001-expected.txt:
- platform/gtk/editing/deleting/delete-tab-001-expected.txt:
- platform/gtk/editing/deleting/delete-tab-002-expected.txt:
- platform/gtk/editing/deleting/delete-tab-003-expected.txt:
- platform/gtk/editing/deleting/delete-tab-004-expected.txt:
- platform/gtk/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/gtk/editing/deleting/forward-delete-expected.txt:
- platform/gtk/editing/deleting/list-item-1-expected.txt:
- platform/gtk/editing/deleting/merge-different-styles-expected.txt:
- platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/gtk/editing/deleting/merge-no-br-expected.txt:
- platform/gtk/editing/deleting/non-smart-delete-expected.txt:
- platform/gtk/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/gtk/editing/deleting/smart-delete-001-expected.txt:
- platform/gtk/editing/deleting/smart-delete-002-expected.txt:
- platform/gtk/editing/deleting/table-cells-expected.txt:
- platform/gtk/editing/execCommand/4641880-1-expected.txt:
- platform/gtk/editing/execCommand/4641880-2-expected.txt:
- platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
- platform/gtk/editing/execCommand/find-after-replace-expected.txt:
- platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/gtk/editing/execCommand/indent-list-item-expected.txt:
- platform/gtk/editing/execCommand/indent-selection-expected.txt:
- platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/gtk/editing/execCommand/nsresponder-indent-expected.txt:
- platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/gtk/editing/execCommand/paste-1-expected.txt:
- platform/gtk/editing/execCommand/paste-2-expected.txt:
- platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/gtk/editing/execCommand/remove-list-item-1-expected.txt:
- platform/gtk/editing/inserting/4278698-expected.txt:
- platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- platform/gtk/editing/inserting/insert-br-001-expected.txt:
- platform/gtk/editing/inserting/insert-br-003-expected.txt:
- platform/gtk/editing/inserting/insert-br-005-expected.txt:
- platform/gtk/editing/inserting/insert-br-006-expected.txt:
- platform/gtk/editing/inserting/insert-br-007-expected.txt:
- platform/gtk/editing/inserting/insert-br-008-expected.txt:
- platform/gtk/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/gtk/editing/inserting/insert-div-001-expected.txt:
- platform/gtk/editing/inserting/insert-div-002-expected.txt:
- platform/gtk/editing/inserting/insert-div-003-expected.txt:
- platform/gtk/editing/inserting/insert-div-005-expected.txt:
- platform/gtk/editing/inserting/insert-div-006-expected.txt:
- platform/gtk/editing/inserting/insert-div-007-expected.txt:
- platform/gtk/editing/inserting/insert-div-008-expected.txt:
- platform/gtk/editing/inserting/insert-div-009-expected.txt:
- platform/gtk/editing/inserting/insert-div-010-expected.txt:
- platform/gtk/editing/inserting/insert-div-020-expected.txt:
- platform/gtk/editing/inserting/insert-div-023-expected.txt:
- platform/gtk/editing/inserting/insert-div-024-expected.txt:
- platform/gtk/editing/inserting/insert-div-025-expected.txt:
- platform/gtk/editing/inserting/insert-div-026-expected.txt:
- platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/gtk/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/gtk/editing/inserting/multiple-lines-selected-expected.txt:
- platform/gtk/editing/inserting/paragraph-separator-03-expected.txt:
- platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/gtk/editing/inserting/redo-expected.txt:
- platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/gtk/editing/inserting/typing-001-expected.txt:
- platform/gtk/editing/inserting/typing-002-expected.txt:
- platform/gtk/editing/inserting/typing-003-expected.txt:
- platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
- platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
- platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt:
- platform/gtk/editing/pasteboard/3976872-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/8145-3-expected.txt:
- platform/gtk/editing/pasteboard/bad-placeholder-expected.txt:
- platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
- platform/gtk/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/gtk/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/gtk/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/gtk/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/gtk/editing/pasteboard/merge-after-delete-expected.txt:
- platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
- platform/gtk/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/gtk/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-cells-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-016-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-019-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/editing/pasteboard/pasting-object-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
- platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/gtk/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/gtk/editing/selection/node-removal-1-expected.txt:
- platform/gtk/editing/selection/node-removal-2-expected.txt:
- platform/gtk/editing/selection/replace-selection-1-expected.txt:
- platform/gtk/editing/selection/select-all-iframe-expected.txt:
- platform/gtk/editing/spelling/spelling-expected.txt:
- platform/gtk/editing/style/create-block-for-style-001-expected.txt:
- platform/gtk/editing/style/create-block-for-style-002-expected.txt:
- platform/gtk/editing/style/create-block-for-style-003-expected.txt:
- platform/gtk/editing/style/create-block-for-style-004-expected.txt:
- platform/gtk/editing/style/create-block-for-style-007-expected.txt:
- platform/gtk/editing/style/create-block-for-style-009-expected.txt:
- platform/gtk/editing/style/create-block-for-style-010-expected.txt:
- platform/gtk/editing/style/create-block-for-style-011-expected.txt:
- platform/gtk/editing/style/create-block-for-style-012-expected.txt:
- platform/gtk/editing/style/create-block-for-style-013-expected.txt:
- platform/gtk/editing/style/designmode-expected.txt:
- platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
- platform/gtk/editing/style/relative-font-size-change-002-expected.txt:
- platform/gtk/editing/style/smoosh-styles-001-expected.txt:
- platform/gtk/editing/style/smoosh-styles-003-expected.txt:
- platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
- platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
- platform/gtk/editing/style/style-3998892-fix-expected.txt:
- platform/gtk/editing/style/style-boundary-001-expected.txt:
- platform/gtk/editing/style/style-boundary-002-expected.txt:
- platform/gtk/editing/style/style-boundary-003-expected.txt:
- platform/gtk/editing/style/style-boundary-004-expected.txt:
- platform/gtk/editing/style/style-boundary-005-expected.txt:
- platform/gtk/editing/style/typing-style-001-expected.txt:
- platform/gtk/editing/style/typing-style-002-expected.txt:
- platform/gtk/editing/style/unbold-in-bold-expected.txt:
- platform/gtk/editing/undo/4063751-expected.txt:
- platform/gtk/editing/undo/redo-typing-001-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-expected.txt:
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-delete-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-expected.txt:
- platform/gtk/editing/undo/undo-misspellings-expected.txt:
- platform/gtk/editing/undo/undo-typing-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/table-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/table-type-before-expected.txt:
- platform/gtk/fast/dynamic/move-node-with-selection-expected.txt:
- platform/gtk/fast/events/updateLayoutForHitTest-expected.txt:
- platform/gtk/fast/repaint/selection-clear-expected.txt:
- platform/gtk/svg/custom/use-clipped-hit-expected.txt:
- 15:25 Changeset [96265] by
-
garden-o-matic shouldn't depend on test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=69019
Reviewed by Dimitri Glazkov.
This patch moves garden-o-matic from getting full_results.json from
test-results.appspot.com to getting that information directly from the
buildbot. This patch improve the load time and accuracy of
garden-o-matic because test-results.appspot.com is slow and is dropping
a significant number of writes (see
https://bugs.webkit.org/show_bug.cgi?id=68748).
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
- 15:05 Changeset [96264] by
-
Mac rebaseline for r96257.
Also fixed editing/deleting/regional-indicators.html as done in the original patch.
(The fix was included in the original patch but webkit-patch could not apply because of some exotic characters in the test.)
- editing/deleting/delete-ligature-001-expected.txt:
- editing/deleting/regional-indicators.html:
- editing/pasteboard/interchange-newline-2-expected.txt:
- editing/pasteboard/paste-4039777-fix-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- fast/events/5056619-expected.txt:
- platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
- platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
- platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
- platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
- platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
- platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
- platform/mac/editing/deleting/delete-3865854-fix-expected.txt:
- platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
- platform/mac/editing/deleting/delete-3959464-fix-expected.txt:
- platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- platform/mac/editing/deleting/delete-and-undo-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/mac/editing/deleting/delete-block-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-contents-002-expected.txt:
- platform/mac/editing/deleting/delete-block-contents-003-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/mac/editing/deleting/delete-br-008-expected.txt:
- platform/mac/editing/deleting/delete-br-010-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt:
- platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-first-list-item-expected.txt:
- platform/mac/editing/deleting/delete-image-001-expected.txt:
- platform/mac/editing/deleting/delete-image-002-expected.txt:
- platform/mac/editing/deleting/delete-image-003-expected.txt:
- platform/mac/editing/deleting/delete-image-004-expected.txt:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-line-001-expected.txt:
- platform/mac/editing/deleting/delete-line-002-expected.txt:
- platform/mac/editing/deleting/delete-line-003-expected.txt:
- platform/mac/editing/deleting/delete-line-004-expected.txt:
- platform/mac/editing/deleting/delete-line-005-expected.txt:
- platform/mac/editing/deleting/delete-line-006-expected.txt:
- platform/mac/editing/deleting/delete-line-007-expected.txt:
- platform/mac/editing/deleting/delete-line-008-expected.txt:
- platform/mac/editing/deleting/delete-line-009-expected.txt:
- platform/mac/editing/deleting/delete-line-010-expected.txt:
- platform/mac/editing/deleting/delete-line-011-expected.txt:
- platform/mac/editing/deleting/delete-line-012-expected.txt:
- platform/mac/editing/deleting/delete-line-013-expected.txt:
- platform/mac/editing/deleting/delete-line-014-expected.txt:
- platform/mac/editing/deleting/delete-line-015-expected.txt:
- platform/mac/editing/deleting/delete-line-016-expected.txt:
- platform/mac/editing/deleting/delete-line-017-expected.txt:
- platform/mac/editing/deleting/delete-listitem-001-expected.txt:
- platform/mac/editing/deleting/delete-listitem-002-expected.txt:
- platform/mac/editing/deleting/delete-selection-001-expected.txt:
- platform/mac/editing/deleting/delete-tab-001-expected.txt:
- platform/mac/editing/deleting/delete-tab-002-expected.txt:
- platform/mac/editing/deleting/delete-tab-003-expected.txt:
- platform/mac/editing/deleting/delete-tab-004-expected.txt:
- platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/mac/editing/deleting/forward-delete-expected.txt:
- platform/mac/editing/deleting/list-item-1-expected.txt:
- platform/mac/editing/deleting/merge-different-styles-expected.txt:
- platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/mac/editing/deleting/merge-no-br-expected.txt:
- platform/mac/editing/deleting/non-smart-delete-expected.txt:
- platform/mac/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/mac/editing/deleting/smart-delete-001-expected.txt:
- platform/mac/editing/deleting/smart-delete-002-expected.txt:
- platform/mac/editing/deleting/smart-delete-003-expected.txt:
- platform/mac/editing/deleting/smart-delete-004-expected.txt:
- platform/mac/editing/deleting/table-cells-expected.txt:
- platform/mac/editing/execCommand/4641880-1-expected.txt:
- platform/mac/editing/execCommand/4641880-2-expected.txt:
- platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
- platform/mac/editing/execCommand/find-after-replace-expected.txt:
- platform/mac/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/mac/editing/execCommand/indent-list-item-expected.txt:
- platform/mac/editing/execCommand/indent-selection-expected.txt:
- platform/mac/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/mac/editing/execCommand/nsresponder-indent-expected.txt:
- platform/mac/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/mac/editing/execCommand/remove-list-item-1-expected.txt:
- platform/mac/editing/input/5576619-expected.txt:
- platform/mac/editing/input/emacs-ctrl-o-expected.txt:
- platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
- platform/mac/editing/input/text-input-controller-expected.txt:
- platform/mac/editing/inserting/4278698-expected.txt:
- platform/mac/editing/inserting/editing-empty-divs-expected.txt:
- platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
- platform/mac/editing/inserting/insert-3775316-fix-expected.txt:
- platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
- platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
- platform/mac/editing/inserting/insert-at-end-01-expected.txt:
- platform/mac/editing/inserting/insert-at-end-02-expected.txt:
- platform/mac/editing/inserting/insert-br-001-expected.txt:
- platform/mac/editing/inserting/insert-br-003-expected.txt:
- platform/mac/editing/inserting/insert-br-005-expected.txt:
- platform/mac/editing/inserting/insert-br-006-expected.txt:
- platform/mac/editing/inserting/insert-br-007-expected.txt:
- platform/mac/editing/inserting/insert-br-008-expected.txt:
- platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/mac/editing/inserting/insert-div-001-expected.txt:
- platform/mac/editing/inserting/insert-div-002-expected.txt:
- platform/mac/editing/inserting/insert-div-003-expected.txt:
- platform/mac/editing/inserting/insert-div-005-expected.txt:
- platform/mac/editing/inserting/insert-div-006-expected.txt:
- platform/mac/editing/inserting/insert-div-007-expected.txt:
- platform/mac/editing/inserting/insert-div-008-expected.txt:
- platform/mac/editing/inserting/insert-div-009-expected.txt:
- platform/mac/editing/inserting/insert-div-010-expected.txt:
- platform/mac/editing/inserting/insert-div-020-expected.txt:
- platform/mac/editing/inserting/insert-div-023-expected.txt:
- platform/mac/editing/inserting/insert-div-024-expected.txt:
- platform/mac/editing/inserting/insert-div-025-expected.txt:
- platform/mac/editing/inserting/insert-div-026-expected.txt:
- platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
- platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
- platform/mac/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/mac/editing/inserting/redo-expected.txt:
- platform/mac/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/mac/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/mac/editing/inserting/typing-001-expected.txt:
- platform/mac/editing/inserting/typing-002-expected.txt:
- platform/mac/editing/inserting/typing-003-expected.txt:
- platform/mac/editing/inserting/typing-around-br-001-expected.txt:
- platform/mac/editing/inserting/typing-around-image-001-expected.txt:
- platform/mac/editing/inserting/typing-at-end-of-line-expected.txt:
- platform/mac/editing/pasteboard/3976872-expected.txt:
- platform/mac/editing/pasteboard/4076267-2-expected.txt:
- platform/mac/editing/pasteboard/4076267-3-expected.txt:
- platform/mac/editing/pasteboard/4076267-expected.txt:
- platform/mac/editing/pasteboard/8145-3-expected.txt:
- platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
- platform/mac/editing/pasteboard/cut-text-001-expected.txt:
- platform/mac/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/mac/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
- platform/mac/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/mac/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/mac/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/mac/editing/pasteboard/paste-table-003-expected.txt:
- platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
- platform/mac/editing/pasteboard/paste-text-004-expected.txt:
- platform/mac/editing/pasteboard/paste-text-005-expected.txt:
- platform/mac/editing/pasteboard/paste-text-006-expected.txt:
- platform/mac/editing/pasteboard/paste-text-007-expected.txt:
- platform/mac/editing/pasteboard/paste-text-008-expected.txt:
- platform/mac/editing/pasteboard/paste-text-016-expected.txt:
- platform/mac/editing/pasteboard/paste-text-019-expected.txt:
- platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- platform/mac/editing/pasteboard/pasting-object-expected.txt:
- platform/mac/editing/pasteboard/smart-drag-drop-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
- platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/mac/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/mac/editing/selection/node-removal-1-expected.txt:
- platform/mac/editing/selection/node-removal-2-expected.txt:
- platform/mac/editing/selection/replace-selection-1-expected.txt:
- platform/mac/editing/selection/select-all-iframe-expected.txt:
- platform/mac/editing/spelling/spelling-expected.txt:
- platform/mac/editing/style/create-block-for-style-001-expected.txt:
- platform/mac/editing/style/create-block-for-style-002-expected.txt:
- platform/mac/editing/style/create-block-for-style-003-expected.txt:
- platform/mac/editing/style/create-block-for-style-004-expected.txt:
- platform/mac/editing/style/create-block-for-style-007-expected.txt:
- platform/mac/editing/style/create-block-for-style-009-expected.txt:
- platform/mac/editing/style/create-block-for-style-010-expected.txt:
- platform/mac/editing/style/create-block-for-style-011-expected.txt:
- platform/mac/editing/style/create-block-for-style-012-expected.txt:
- platform/mac/editing/style/create-block-for-style-013-expected.txt:
- platform/mac/editing/style/designmode-expected.txt:
- platform/mac/editing/style/relative-font-size-change-001-expected.txt:
- platform/mac/editing/style/relative-font-size-change-002-expected.txt:
- platform/mac/editing/style/smoosh-styles-001-expected.txt:
- platform/mac/editing/style/smoosh-styles-003-expected.txt:
- platform/mac/editing/style/style-3681552-fix-001-expected.txt:
- platform/mac/editing/style/style-3681552-fix-002-expected.txt:
- platform/mac/editing/style/style-3998892-fix-expected.txt:
- platform/mac/editing/style/style-boundary-001-expected.txt:
- platform/mac/editing/style/style-boundary-002-expected.txt:
- platform/mac/editing/style/style-boundary-003-expected.txt:
- platform/mac/editing/style/style-boundary-004-expected.txt:
- platform/mac/editing/style/style-boundary-005-expected.txt:
- platform/mac/editing/style/typing-style-001-expected.txt:
- platform/mac/editing/style/typing-style-002-expected.txt:
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- platform/mac/editing/undo/4063751-expected.txt:
- platform/mac/editing/undo/redo-typing-001-expected.txt:
- platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-combined-delete-expected.txt:
- platform/mac/editing/undo/undo-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-delete-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-expected.txt:
- platform/mac/editing/undo/undo-misspellings-expected.txt:
- platform/mac/editing/undo/undo-typing-001-expected.txt:
- platform/mac/editing/unsupported-content/list-delete-001-expected.txt:
- platform/mac/editing/unsupported-content/list-delete-003-expected.txt:
- platform/mac/editing/unsupported-content/list-type-after-expected.txt:
- platform/mac/editing/unsupported-content/list-type-before-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-001-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-002-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-003-expected.txt:
- platform/mac/editing/unsupported-content/table-type-after-expected.txt:
- platform/mac/editing/unsupported-content/table-type-before-expected.txt:
- platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
- platform/mac/fast/repaint/selection-clear-expected.txt:
- platform/mac/svg/custom/use-clipped-hit-expected.txt:
- 14:58 Changeset [96263] by
-
watchlist: Add a way to load the watchlist from config.
https://bugs.webkit.org/show_bug.cgi?id=68991
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/watchlist: Added.
- Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
Support for loading the watch list.
- Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
Tests for the loading.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
Adjusted to use the common base class.
- Scripts/webkitpy/common/webkitunittest.py: Added.
Made a common base class for functionality used in more than one.
- 14:30 Changeset [96262] by
-
Attempt fix for Leopard python unit test run.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
- 14:02 Changeset [96261] by
-
Merge 95861 - occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941
Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.
Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::keyEvent):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/8072009
- 14:01 Changeset [96260] by
-
JavaScript generated documents don't inherit the cookie URL
https://bugs.webkit.org/show_bug.cgi?id=69003
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/cookies/cookie-theft-with-javascript-doc.html
- dom/Document.h:
(WebCore::Document::setCookieURL):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
- loader/DocumentWriter.h:
LayoutTests:
- http/tests/security/cookies/cookie-theft-with-javascript-doc-expected.txt: Added.
- http/tests/security/cookies/cookie-theft-with-javascript-doc.html: Added.
- http/tests/security/cookies/resources/innocent-victim-with-cookies.html: Added.
- 13:59 Changeset [96259] by
-
Implement callOperation(D_DFGOperation_DD) for DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=69026
Reviewed by Sam Weinig.
- assembler/X86Assembler.h:
(JSC::X86Assembler::fstpl):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- 13:55 Changeset [96258] by
-
REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
https://bugs.webkit.org/show_bug.cgi?id=68938
Source/WebCore:
Reviewed by David Hyatt.
Test: all svg tests in LayoutTests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths): Added a null-check for containingBlock.
Tools:
Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
Reviewed by David Hyatt.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didUpdateLayout): Added width/height queries.
- DumpRenderTree/chromium/WebViewHost.h: Updated defs.
LayoutTests:
Reviewed by David Hyatt.
- fast/frames/flattening/crash-svg-document-expected.txt: Added.
- fast/frames/flattening/crash-svg-document.html: Added.
- 13:51 QtWebKitRelease22 edited by
- (diff)
- 13:51 Changeset [96257] by
-
Setting innerText to an empty string on editable div loses focus
https://bugs.webkit.org/show_bug.cgi?id=62092
Patch by Una Sabovic <una.sabovic@palm.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Source/WebCore:
When selection start or end node is being deleted do not clear the selection.
Instead update the start/end position to an equivalent parent-anchored positions.
When text is inserted/deleted update selection per range modification spec:
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Mutation
Tests: editing/selection/document-mutation.html
editing/selection/editable-div-clear-on-keydown.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWillBeReplaced):
- editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval):
LayoutTests:
Added test to make sure that caret is still present in a focused editable div after its text is deleted.
Updated editing tests to not expect that deleting selection start or end node will clear the selection.
Added test to exercise range modification examples from
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Mutation
- editing/deleting/5546763-expected.txt:
- editing/deleting/delete-4038408-fix-expected.txt:
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-br-011-expected.txt:
- editing/deleting/delete-by-word-001-expected.txt:
- editing/deleting/delete-by-word-002-expected.txt:
- editing/deleting/delete-cell-contents-expected.txt:
- editing/deleting/delete-ligature-002-expected.txt:
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/delete-select-all-002-expected.txt:
- editing/deleting/delete-select-all-003-expected.txt:
- editing/deleting/delete-to-end-of-paragraph-expected.txt:
- editing/deleting/merge-paragraph-into-blockquote-expected.txt:
- editing/deleting/paragraph-in-preserveNewline-expected.txt:
- editing/deleting/pruning-after-merge-1-expected.txt:
- editing/deleting/skip-virama-001-expected.txt:
- editing/deleting/whitespace-pre-1-expected.txt:
- editing/execCommand/4920488-expected.txt:
- editing/execCommand/crash-indenting-list-item-expected.txt:
- editing/execCommand/createLink-expected.txt:
- editing/execCommand/format-block-expected.txt:
- editing/execCommand/format-block-multiple-paragraphs-in-pre-expected.txt:
- editing/execCommand/format-block-with-braces-expected.txt:
- editing/execCommand/hilitecolor-expected.txt:
- editing/execCommand/indent-nested-lists-1-expected.txt:
- editing/execCommand/indent-nested-lists-2-expected.txt:
- editing/execCommand/indent-nested-lists-3-expected.txt:
- editing/execCommand/indent-nested-lists-4-expected.txt:
- editing/execCommand/indent-nested-lists-5-expected.txt:
- editing/execCommand/indent-nested-lists-6-expected.txt:
- editing/execCommand/indent-nested-lists-7-expected.txt:
- editing/execCommand/indent-paragraphs-expected.txt:
- editing/execCommand/indent-with-style-expected.txt:
- editing/execCommand/insertHTML-expected.txt:
- editing/execCommand/outdent-nested-lists-1-expected.txt:
- editing/execCommand/outdent-nested-lists-2-expected.txt:
- editing/execCommand/outdent-nested-lists-3-expected.txt:
- editing/execCommand/outdent-nested-lists-4-expected.txt:
- editing/execCommand/queryCommandState-01-expected.txt:
- editing/execCommand/remove-formatting-2-expected.txt:
- editing/execCommand/remove-formatting-expected.txt:
- editing/execCommand/remove-list-1-expected.txt:
- editing/execCommand/remove-list-items-expected.txt:
- editing/execCommand/switch-list-type-expected.txt:
- editing/execCommand/unlink-expected.txt:
- editing/inserting/insert-3786362-fix-expected.txt:
- editing/inserting/insert-div-021-expected.txt:
- editing/inserting/insert-paragraph-at-end-of-line-expected.txt:
- editing/inserting/insert-thai-characters-001-expected.txt:
- editing/pasteboard/4242293-1-expected.txt:
- editing/pasteboard/5065605-expected.txt:
- editing/pasteboard/block-wrappers-necessary-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
- editing/pasteboard/insert-div-text-into-text-expected.txt:
- editing/pasteboard/interchange-newline-1-expected.txt:
- editing/pasteboard/interchange-newline-3-expected.txt:
- editing/pasteboard/interchange-newline-4-expected.txt:
- editing/pasteboard/merge-end-2-expected.txt:
- editing/pasteboard/merge-end-3-expected.txt:
- editing/pasteboard/merge-end-4-expected.txt:
- editing/pasteboard/merge-end-5-expected.txt:
- editing/pasteboard/merge-end-list-2-expected.txt:
- editing/pasteboard/merge-end-list-expected.txt:
- editing/pasteboard/merge-end-table-2-expected.txt:
- editing/pasteboard/merge-end-table-expected.txt:
- editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- editing/pasteboard/paste-into-anchor-text-expected.txt:
- editing/pasteboard/paste-list-001-expected.txt:
- editing/pasteboard/paste-table-001-expected.txt:
- editing/pasteboard/paste-table-002-expected.txt:
- editing/pasteboard/paste-text-001-expected.txt:
- editing/pasteboard/paste-text-002-expected.txt:
- editing/pasteboard/paste-text-003-expected.txt:
- editing/pasteboard/paste-text-011-expected.txt:
- editing/pasteboard/paste-text-017-expected.txt:
- editing/pasteboard/paste-text-018-expected.txt:
- editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
- editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
- editing/pasteboard/paste-text-with-style-expected.txt:
- editing/pasteboard/prevent-block-nesting-01-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- editing/pasteboard/smart-paste-003-expected.txt:
- editing/pasteboard/smart-paste-004-expected.txt:
- editing/pasteboard/smart-paste-005-expected.txt:
- editing/pasteboard/smart-paste-006-expected.txt:
- editing/selection/5497643-expected.txt:
- editing/selection/5497643.html:
- editing/selection/character-data-mutation-expected.txt:
- editing/selection/character-data-mutation.html:
- editing/selection/document-mutation-expected.txt: Added.
- editing/selection/document-mutation.html: Added.
- editing/selection/editable-div-clear-on-keydown-expected.txt: Added.
- editing/selection/editable-div-clear-on-keydown.html: Added.
- editing/selection/regional-indicators.html:
- editing/style/remove-underline-from-stylesheet-expected.txt:
- editing/style/typing-style-003-expected.txt:
- editing/undo/redo-style-expected.txt:
- editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt:
- editing/undo/undo-indent-expected.txt:
- platform/mac/editing/pasteboard/paste-and-match-style-selector-event.html:
- platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
- platform/qt/editing/deleting/delete-3608462-fix-expected.txt:
- platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
- platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
- platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
- platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
- platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
- platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/qt/editing/deleting/delete-and-undo-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/qt/editing/deleting/delete-br-008-expected.txt:
- platform/qt/editing/deleting/delete-br-010-expected.txt:
- platform/qt/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-first-list-item-expected.txt:
- platform/qt/editing/deleting/delete-image-001-expected.txt:
- platform/qt/editing/deleting/delete-image-002-expected.txt:
- platform/qt/editing/deleting/delete-image-003-expected.txt:
- platform/qt/editing/deleting/delete-image-004-expected.txt:
- platform/qt/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-line-001-expected.txt:
- platform/qt/editing/deleting/delete-line-002-expected.txt:
- platform/qt/editing/deleting/delete-line-003-expected.txt:
- platform/qt/editing/deleting/delete-line-004-expected.txt:
- platform/qt/editing/deleting/delete-line-005-expected.txt:
- platform/qt/editing/deleting/delete-line-006-expected.txt:
- platform/qt/editing/deleting/delete-line-007-expected.txt:
- platform/qt/editing/deleting/delete-line-008-expected.txt:
- platform/qt/editing/deleting/delete-line-009-expected.txt:
- platform/qt/editing/deleting/delete-line-010-expected.txt:
- platform/qt/editing/deleting/delete-line-012-expected.txt:
- platform/qt/editing/deleting/delete-line-013-expected.txt:
- platform/qt/editing/deleting/delete-line-014-expected.txt:
- platform/qt/editing/deleting/delete-line-015-expected.txt:
- platform/qt/editing/deleting/delete-line-016-expected.txt:
- platform/qt/editing/deleting/delete-line-017-expected.txt:
- platform/qt/editing/deleting/delete-line-end-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-listitem-001-expected.txt:
- platform/qt/editing/deleting/delete-listitem-002-expected.txt:
- platform/qt/editing/deleting/delete-selection-001-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/qt/editing/deleting/forward-delete-expected.txt:
- platform/qt/editing/deleting/list-item-1-expected.txt:
- platform/qt/editing/deleting/merge-different-styles-expected.txt:
- platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/qt/editing/deleting/merge-no-br-expected.txt:
- platform/qt/editing/deleting/non-smart-delete-expected.txt:
- platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/qt/editing/deleting/smart-delete-001-expected.txt:
- platform/qt/editing/deleting/smart-delete-003-expected.txt:
- platform/qt/editing/deleting/smart-delete-004-expected.txt:
- platform/qt/editing/deleting/table-cells-expected.txt:
- platform/qt/editing/execCommand/4641880-1-expected.txt:
- platform/qt/editing/execCommand/4641880-2-expected.txt:
- platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
- platform/qt/editing/execCommand/find-after-replace-expected.txt:
- platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/qt/editing/execCommand/indent-list-item-expected.txt:
- platform/qt/editing/execCommand/indent-selection-expected.txt:
- platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/qt/editing/execCommand/nsresponder-indent-expected.txt:
- platform/qt/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/qt/editing/execCommand/paste-1-expected.txt:
- platform/qt/editing/execCommand/paste-2-expected.txt:
- platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
- platform/qt/editing/input/emacs-ctrl-o-expected.txt:
- platform/qt/editing/inserting/4278698-expected.txt:
- platform/qt/editing/inserting/editing-empty-divs-expected.txt:
- platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
- platform/qt/editing/inserting/insert-3775316-fix-expected.txt:
- platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
- platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
- platform/qt/editing/inserting/insert-at-end-01-expected.txt:
- platform/qt/editing/inserting/insert-at-end-02-expected.txt:
- platform/qt/editing/inserting/insert-br-001-expected.txt:
- platform/qt/editing/inserting/insert-br-003-expected.txt:
- platform/qt/editing/inserting/insert-br-005-expected.txt:
- platform/qt/editing/inserting/insert-br-006-expected.txt:
- platform/qt/editing/inserting/insert-br-007-expected.txt:
- platform/qt/editing/inserting/insert-br-008-expected.txt:
- platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/qt/editing/inserting/insert-div-001-expected.txt:
- platform/qt/editing/inserting/insert-div-002-expected.txt:
- platform/qt/editing/inserting/insert-div-003-expected.txt:
- platform/qt/editing/inserting/insert-div-005-expected.txt:
- platform/qt/editing/inserting/insert-div-006-expected.txt:
- platform/qt/editing/inserting/insert-div-007-expected.txt:
- platform/qt/editing/inserting/insert-div-008-expected.txt:
- platform/qt/editing/inserting/insert-div-009-expected.txt:
- platform/qt/editing/inserting/insert-div-010-expected.txt:
- platform/qt/editing/inserting/insert-div-020-expected.txt:
- platform/qt/editing/inserting/insert-div-023-expected.txt:
- platform/qt/editing/inserting/insert-div-024-expected.txt:
- platform/qt/editing/inserting/insert-div-025-expected.txt:
- platform/qt/editing/inserting/insert-div-026-expected.txt:
- platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/qt/editing/inserting/redo-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/qt/editing/inserting/typing-001-expected.txt:
- platform/qt/editing/inserting/typing-002-expected.txt:
- platform/qt/editing/inserting/typing-003-expected.txt:
- platform/qt/editing/inserting/typing-around-br-001-expected.txt:
- platform/qt/editing/inserting/typing-around-image-001-expected.txt:
- platform/qt/editing/pasteboard/3976872-expected.txt:
- platform/qt/editing/pasteboard/4076267-2-expected.txt:
- platform/qt/editing/pasteboard/4076267-3-expected.txt:
- platform/qt/editing/pasteboard/4076267-expected.txt:
- platform/qt/editing/pasteboard/8145-3-expected.txt:
- platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
- platform/qt/editing/pasteboard/cut-text-001-expected.txt:
- platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
- platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/qt/editing/pasteboard/paste-table-003-expected.txt:
- platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
- platform/qt/editing/pasteboard/paste-text-004-expected.txt:
- platform/qt/editing/pasteboard/paste-text-005-expected.txt:
- platform/qt/editing/pasteboard/paste-text-006-expected.txt:
- platform/qt/editing/pasteboard/paste-text-007-expected.txt:
- platform/qt/editing/pasteboard/paste-text-008-expected.txt:
- platform/qt/editing/pasteboard/paste-text-016-expected.txt:
- platform/qt/editing/pasteboard/paste-text-019-expected.txt:
- platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/qt/editing/pasteboard/pasting-object-expected.txt:
- platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
- platform/qt/editing/pasteboard/smart-paste-008-expected.txt:
- platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/qt/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/qt/editing/selection/node-removal-1-expected.txt:
- platform/qt/editing/selection/node-removal-2-expected.txt:
- platform/qt/editing/selection/replace-selection-1-expected.txt:
- platform/qt/editing/selection/select-all-iframe-expected.txt:
- platform/qt/editing/style/create-block-for-style-001-expected.txt:
- platform/qt/editing/style/create-block-for-style-002-expected.txt:
- platform/qt/editing/style/create-block-for-style-003-expected.txt:
- platform/qt/editing/style/create-block-for-style-004-expected.txt:
- platform/qt/editing/style/create-block-for-style-007-expected.txt:
- platform/qt/editing/style/create-block-for-style-009-expected.txt:
- platform/qt/editing/style/create-block-for-style-010-expected.txt:
- platform/qt/editing/style/create-block-for-style-011-expected.txt:
- platform/qt/editing/style/create-block-for-style-012-expected.txt:
- platform/qt/editing/style/create-block-for-style-013-expected.txt:
- platform/qt/editing/style/designmode-expected.txt:
- platform/qt/editing/style/relative-font-size-change-001-expected.txt:
- platform/qt/editing/style/relative-font-size-change-002-expected.txt:
- platform/qt/editing/style/smoosh-styles-001-expected.txt:
- platform/qt/editing/style/smoosh-styles-003-expected.txt:
- platform/qt/editing/style/style-3998892-fix-expected.txt:
- platform/qt/editing/style/style-boundary-001-expected.txt:
- platform/qt/editing/style/style-boundary-004-expected.txt:
- platform/qt/editing/style/unbold-in-bold-expected.txt:
- platform/qt/editing/undo/4063751-expected.txt:
- platform/qt/editing/undo/redo-typing-001-expected.txt:
- platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/qt/editing/undo/undo-combined-delete-expected.txt:
- platform/qt/editing/undo/undo-delete-boundary-expected.txt:
- platform/qt/editing/undo/undo-delete-expected.txt:
- platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/qt/editing/undo/undo-forward-delete-expected.txt:
- platform/qt/editing/undo/undo-misspellings-expected.txt:
- platform/qt/editing/undo/undo-typing-001-expected.txt:
- platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
- platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
- platform/qt/editing/unsupported-content/list-type-after-expected.txt:
- platform/qt/editing/unsupported-content/list-type-before-expected.txt:
- platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
- platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
- platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
- platform/qt/editing/unsupported-content/table-type-after-expected.txt:
- platform/qt/editing/unsupported-content/table-type-before-expected.txt:
- platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
- platform/qt/svg/custom/use-clipped-hit-expected.txt:
- 13:50 QtWebKitRelease22 edited by
- (diff)
- 13:48 Changeset [96256] by
-
[chromium / skia] temporarily add files test expectations pending rebaseline due to skia change
https://bugs.webkit.org/show_bug.cgi?id=69013
Patch by Brian Salomon <bsalomon@google.com> on 2011-09-28
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 13:48 QtWebKitRelease22 edited by
- (diff)
- 13:46 Changeset [96255] by
-
Expose +[WebStorageManager _storageDirectoryPath] as SPI
https://bugs.webkit.org/show_bug.cgi?id=68951
Reviewed by Brady Eidson.
This patch exposes +[WebStorageManager _storageDirectoryPath], which
pulls the path from NSUserDefaults if the preference is set. Otherwise,
it falls back on the default path.
- Storage/WebStorageManager.mm:
(+[WebStorageManager _storageDirectoryPath]): Adding static variable
so that we don't reread user defaults repeatedly.
(WebKitInitializeStorageIfNecessary):
- Storage/WebStorageManagerPrivate.h:
- 13:41 QtWebKitFeatures22 edited by
- (diff)
- 13:28 QtWebKitRelease22 edited by
- (diff)
- 13:21 Changeset [96254] by
-
Merge 95794 - Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312
Reviewed by Yury Semikhatsky.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
- 13:18 Changeset [96253] by
-
FTPDirectoryDocument Shows Garbled String for Last Modified Date
https://bugs.webkit.org/show_bug.cgi?id=69011
Reviewed by Dan Bernstein.
Force WTF::String concatenation instead of an accidental char* pointer addition.
- html/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
- 13:10 Changeset [96252] by
-
Get rebaseline server running again
https://bugs.webkit.org/show_bug.cgi?id=69020
Reviewed by Adam Barth.
Make rebaseline server run again after r90337 (missing format_date_time
import, results_json wasn't outputting anything).
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
- Scripts/webkitpy/tool/servers/reflectionhandler.py:
- 13:07 Changeset [96251] by
-
Move dgrogan from contributor to committer.
- 13:06 Changeset [96250] by
-
Add Mac Skia GPU bots to builders.py
https://bugs.webkit.org/show_bug.cgi?id=69016
Reviewed by Eric Seidel.
This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
GPU tests.
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- 12:56 QtWebKitRelease22 edited by
- (diff)
- 12:55 Changeset [96249] by
-
Fix a regression in r96060. ResourceLoader shouldn't get
initialized with a null DocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=69004
Patch by Nate Chapin <japhet@chromium.org> on 2011-09-28
Reviewed by Csaba Osztrogonác.
This should fix a debug crash in some platforms in
plugins/js-from-destroy.html
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Move the activeDocumentLoader() null checks back
to SubresouceLoader::create().
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
- 12:55 QtWebKitFeatures22 edited by
- (diff)
- 12:54 Changeset [96248] by
-
One more shot at fixing GTK+, this seems to make the dependencies
work.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
- GNUmakefile.am:
- 12:53 Changeset [96247] by
-
Merge bug#68580, bug#68932 for DFG JIT with JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=69017
Reviewed by Oliver Hunt.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
- 12:51 QtWebKitFeatures22 edited by
- (diff)
- 12:24 Changeset [96246] by
-
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
- fast/js/array-prototype-properties-expected.txt: Added.
- fast/js/array-prototype-properties.html: Added.
- fast/js/script-tests/array-prototype-properties.js: Added.
- Added layout test for array prototype functions with undefined as this value.
- ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
- These tests now pass.
- 12:15 Changeset [96245] by
-
GTK+ build fix 3 - the return of the marshal.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
- GNUmakefile.am:
- 12:14 Changeset [96244] by
-
Rebaseline fast/canvas/canvas-composite-transformclip.html and
fast/canvas/canvas-composite.html for Chromium Snow Leopard GPU.
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png:
- 12:02 Changeset [96243] by
-
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- These methods should throw if this value is undefined.
- 11:39 Changeset [96242] by
-
Second try at fixing the GTK+ build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
Source/WebKit2:
- GNUmakefile.am:
Tools:
- GNUmakefile.am:
- 11:14 Changeset [96241] by
-
Try to fix GTK+ build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
- GNUmakefile.am:
- 11:09 Changeset [96240] by
-
[Chromium] remove a passing test from the test expectation file.
https://bugs.webkit.org/show_bug.cgi?id=69008
Reviewed by David Levin.
- platform/chromium/test_expectations.txt:
- 11:06 Changeset [96239] by
-
CSP doesn't work for a wide variety of cases
https://bugs.webkit.org/show_bug.cgi?id=68921
Reviewed by Darin Adler.
Patch suggested by Sam Weinig. It's unclear to me how to test this
change because all our tests run on non-default ports, which is why we
have this bug in the first place. Mozilla uses a proxy while testing
so they can test with URLs like http://example.com, but we don't have
such a facility.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::portMatches):
- 11:05 Changeset [96238] by
-
Value profiling in baseline JIT for JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=68750
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Geoff Garen.
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
- 10:56 QtWebKitReleases edited by
- (diff)
- 10:56 Changeset [96237] by
-
[GTK] Fix webkit2 unit tests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69006
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-28
Reviewed by Martin Robinson.
We are currently using the WorQueue name as thread name which in
this moment can be com.apple.WebKit.ProcessLauncher or
com.apple.CoreIPC.ReceiveQueue. Both names are longer than 31
characters which is the limit of Visual Studio for thread
names. When log is enabled createThread() will assert instead of
truncate the name, so we need to make sure we don't use a name
longer than 31 characters.
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
- 10:54 Changeset [96236] by
-
Rebaseline svg/filters/animate-fill.svg for Chromium.
- platform/chromium-cg-mac/svg/filters/animate-fill-expected.png: Added.
- platform/chromium-mac/svg/filters/animate-fill-expected.png: Added.
- platform/chromium-win/svg/filters/animate-fill-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:46 Changeset [96235] by
-
Let TestWebKitAPI and webkit_unit_tests work for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=68680
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.
- Scripts/run-chromium-webkit-unit-tests:
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
- 10:44 QtWebKit edited by
- (diff)
- 10:40 Changeset [96234] by
-
[Gtk] Implement textInputController.doCommand
https://bugs.webkit.org/show_bug.cgi?id=66496
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-28
Reviewed by Martin Robinson.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::doCommand): Function definition for doCommand
callback. Converted Incoming command to match with WebCore::Editor CommandMap.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
- DumpRenderTree/gtk/TextInputController.cpp:
(doCommandCallback): Callback function for textInputController.doCommand
LayoutTests:
Removed skipped tests under textInputController.doCommand for Gtk Port.
- platform/gtk/Skipped:
- 10:36 Changeset [96233] by
-
[Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules
https://bugs.webkit.org/show_bug.cgi?id=68936
Reviewed by Tony Chang.
Source/WebCore:
Chromium need to be built without Gtk for future version of ChromiumOS.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- WebKit.gyp:
- public/gtk/WebFontInfo.h:
- public/linux/WebFontInfo.h: Copied from Source/WebKit/chromium/public/gtk/WebFontInfo.h.
- 10:35 QtWebKitReleases edited by
- (diff)
- 10:28 Changeset [96232] by
-
watchlist: Suggest corrections for typos and improve error message consistency.
https://bugs.webkit.org/show_bug.cgi?id=68976
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
for typos and improve consistency of the error messages.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
and improve the regex that were already present.
- 10:19 Changeset [96231] by
-
Revert change which broke displaying end script tags in view-source, instead
deal with any trailing </script> tag included by mistake in the XSSAuditor
itself. Correct tests to detect the missing close tags.
https://bugs.webkit.org/show_bug.cgi?id=68898
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::end):
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):
- html/parser/XSSAuditor.cpp:
(WebCore::startsHTMLEndTagAt):
(WebCore::XSSAuditor::snippetForJavaScript):
LayoutTests:
- fast/frames/resources/viewsource-frame-2.html:
- fast/frames/viewsource-plain-text-tags-expected.txt:
- fast/frames/viewsource-plain-text-tags.html:
- 10:15 Changeset [96230] by
-
Wrong integer checks in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68985
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-28
Reviewed by Geoffrey Garen.
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
- 10:06 Changeset [96229] by
-
Remove empty directories.
Source/JavaScriptCore:
- wtf/brew: Removed.
- wtf/unicode/brew: Removed.
Source/WebCore:
- editing/brew: Removed.
- page/brew: Removed.
- platform/brew: Removed.
- platform/graphics/brew: Removed.
- platform/network/brew: Removed.
- platform/text/brew: Removed.
- 10:05 Changeset [96228] by
-
watchlist: Add support for matching added or deleted lines.
https://bugs.webkit.org/show_bug.cgi?id=68972
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
- Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
- Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
to the pattern match to only have the diff lines instead of the DiffFile.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
Add tests for the new patterns and combinations of the patterns.
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
Sort imports. Add changeline support.
- 09:57 Changeset [96227] by
-
Web Inspector: optional arguments support for the frontend needs to be extended.
https://bugs.webkit.org/show_bug.cgi?id=69005
Generator supports optional arguments but they are transferred by value.
It is not suitable if the used type doesn't have operator bool.
I'll transfer such arguments by pointer.
Reviewed by Pavel Feldman.
Build is the test.
- inspector/CodeGeneratorInspector.pm:
(generateFrontendFunction):
(paramTypeTraits):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFailLoading):
- 09:24 Changeset [96226] by
-
[GTK] Loader client implementation for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68085
Reviewed by Martin Robinson.
Adds a new object, WebKitWebLoaderClient, that emits signals for
every page loader callback.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp: Added.
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(webkitWebLoaderClientConstructed):
(webkitWebLoaderClientSetProperty):
(webkitWebLoaderClientGetProperty):
(webkit_web_loader_client_init):
(webkit_web_loader_client_class_init):
- UIProcess/API/gtk/WebKitWebLoaderClient.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the loader client for the view.
(webkit_web_view_init):
(webkit_web_view_get_loader_client): Get the current loader client.
(webkit_web_view_set_loader_client): Set a new loader client.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/tests/testloading.c: Added.
(serverCallback):
(webLoadingFixtureSetup):
(webLoadingFixtureTeardown):
(getURIForPath):
(loadStatusProvisionalLoadStarted):
(loadStatusProvisionalLoadReceivedServerRedirect):
(loadStatusProvisionalLoadFailed):
(loadStatusLoadCommitted):
(loadStatusLoadFinished):
(loadStatusLoadFailed):
(testLoadingStatus):
(loadErrorProvisionalLoadStarted):
(loadErrorProvisionalLoadFailed):
(loadErrorLoadFinished):
(testLoadingError):
(main):
- UIProcess/API/gtk/webkit2marshal.list: Added.
- 09:20 Changeset [96225] by
-
[GTK] Add WebKitError to GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=68508
Reviewed by Martin Robinson.
Source/WebKit2:
Add WebKitNetworkError enum to define network errors.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitError.cpp: Added.
(webkit_network_error_quark):
- UIProcess/API/gtk/WebKitError.h:
- UIProcess/API/gtk/WebKitPrivate.h: Add
COMPILE_ASSERT_MATCHING_ENUM macro.
- UIProcess/API/gtk/webkit2.h: Add WebKitError.h and
WebKitEnumTypes.h
Tools:
- GNUmakefile.am: Add path to webkitgtk derived sources to the
include path.
- 08:52 Changeset [96224] by
-
Reflected attribute input.size wraps on negative values (Chrome), or
returns them (Safari).
https://bugs.webkit.org/show_bug.cgi?id=44886
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-28
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLInputElement/input-size-attribute.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
LayoutTests:
- fast/dom/HTMLInputElement/input-size-attribute-expected.txt: Added.
- fast/dom/HTMLInputElement/input-size-attribute.html: Added.
- fast/dom/HTMLInputElement/script-tests/size-attribute.js:
- fast/dom/HTMLInputElement/size-attribute-expected.txt:
- 08:01 Changeset [96223] by
-
Web Inspector: Add support for search in single resource to page agent.
https://bugs.webkit.org/show_bug.cgi?id=68998
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/search/search-in-resource.html
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
- inspector/ContentSearchUtils.h:
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForSearchMatch):
(WebCore::InspectorPageAgent::searchInResource):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):
- inspector/front-end/SourceFile.js:
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
- inspector/front-end/UISourceCode.js:
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
LayoutTests:
- http/tests/inspector/search/search-in-resource-expected.txt: Added.
- http/tests/inspector/search/search-in-resource.html: Added.
- http/tests/inspector/search/search-in-resources.html:
- http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest.InspectorTest.dumpSearchMatches):
(initialize_SearchTest):
- 07:30 Changeset [96222] by
-
Web Inspector: It'd be useful to have performance stats for the back-end to front-end communication channel.
https://bugs.webkit.org/show_bug.cgi?id=69002
Reviewed by Yury Semikhatsky.
- inspector/CodeGeneratorInspector.pm:
- 07:28 Changeset [96221] by
-
[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-28
Reviewed by Csaba Osztrogonác.
- platform/wk2/Skipped: Skip svg/animations/animate-from-to-keyTimes.html.
- 07:02 Changeset [96220] by
-
Unreviewed, GTK baselines for new tests.
- platform/gtk/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/gtk/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
- platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
- 06:53 Changeset [96219] by
-
Web Inspector: live edit cursor always appears at the beginning of the file.
https://bugs.webkit.org/show_bug.cgi?id=68900
Reviewed by Pavel Feldman.
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):
- 06:41 Changeset [96218] by
-
Unreviewed, skip 2 64-bits Debug crashers on GTK.
- platform/gtk/Skipped: Skip
fast/borders/inline-mask-overlay-image-outset-vertical-rl.html and plugins/js-from-destroy.html
- 05:35 Changeset [96217] by
-
[EFL] Remove *void* parameter in internal functions
https://bugs.webkit.org/show_bug.cgi?id=68867
Reviewed by Andreas Kling.
As a step to let ewk be compliant with webkit coding style,
we need to remove *void* parameter in internal functions.
- ewk/ewk_private.h:
- ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
- ewk/ewk_util.cpp:
(ewk_util_dpi_get):
- 05:35 Changeset [96216] by
-
[Qt] Unreviewed gardening, update expected file after r95745.
- platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt:
- 04:56 Changeset [96215] by
-
Web Inspector: Refactor searching in inspector, add test (fixed non regex search).
https://bugs.webkit.org/show_bug.cgi?id=68930
Reviewed by Yury Semikhatsky.
Source/WebCore:
Search moved out from page agent.
Fixed search for non regex case which is not yet used.
Test: http/tests/inspector/search/search-in-resources.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/ContentSearchUtils.cpp: Added.
(WebCore::ContentSearchUtils::createSearchRegexSource):
(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):
- inspector/ContentSearchUtils.h: Added.
- inspector/InspectorPageAgent.cpp:
(WebCore::hasTextContent):
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::textContentForCachedResource):
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
- inspector/front-end/utilities.js:
():
LayoutTests:
- http/tests/inspector/search/resources/search.css: Added.
(div.searchTestUniqueString):
(div.searchTestUniqueString:hover):
- http/tests/inspector/search/resources/search.html: Added.
- http/tests/inspector/search/resources/search.js: Added.
(searchTestUniqueString):
(doSomething):
- http/tests/inspector/search/search-in-resources-expected.txt: Added.
- http/tests/inspector/search/search-in-resources.html: Added.
- http/tests/inspector/search/search-test.js: Added.
(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest):
- 04:25 Changeset [96214] by
-
[GTK] missing WebKit2 support in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=68992
Rubber-stamped by Andreas Kling.
- Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
webkit2 directory.
- 03:56 Changeset [96213] by
-
[GTK] Fix Programs/unittests/webkit2/testwebview
https://bugs.webkit.org/show_bug.cgi?id=68993
Reviewed by Philippe Normand.
- GNUmakefile.am: Add -DWEBKIT_EXEC_PATH.
- UIProcess/API/gtk/tests/testwebview.c:
(main): Get WebProcess path from WEBKIT_EXEC_PATH environment
variable.
- 02:54 Changeset [96212] by
-
Implement a PopStateEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68896
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/pop-state-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
- dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
- platform/chromium/test_expectations.txt:
- 02:45 Changeset [96211] by
-
[Texmap] Allow TextureMapperGL to work without a GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=68980
Reviewed by Andreas Kling.
Perform a null-check for m_context and initialize that variable.
If a graphics-context doesn't exist, we don't need to reset it.
No new functionality so no new tests.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
- 02:42 Changeset [96210] by
-
Unreviewed fix for test.
- inspector/performance/resources/inspector-startup-time.html:
- 02:30 Changeset [96209] by
-
Web Inspector: UI performance test for Inspector start-up time is required.
https://bugs.webkit.org/show_bug.cgi?id=68986
Reviewed by Yury Semikhatsky.
- inspector/performance/resources/inspector-startup-time.html: Added.
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
- 02:27 Changeset [96208] by
-
Implement an ErrorEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68336
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/error-event-constructor.html
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Returns an unsigned value corresponding to a given key.
- bindings/v8/OptionsObject.h:
- bindings/v8/custom/V8EventConstructors.cpp: Added the ErrorEvent constructor.
- dom/ErrorEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled fast/events/constructors/error-event-constructor.html,
since V8 now has the constructor for ErrorEvent.
- platform/chromium/test_expectations.txt:
- 02:27 Changeset [96207] by
-
[GTK] build-webkit --no-webkit2 still builds WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68892
Reviewed by Martin Robinson.
Take the --no-webkit2 option in account when building WebKitGTK+.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
(buildGtkProject):
- 01:47 Changeset [96206] by
-
[Qt][GTK] Skip http/tests/multipart/stop-crash.html because it fails after r96174.
https://bugs.webkit.org/show_bug.cgi?id=68979
Reviewed by Csaba Osztrogonác.
- platform/gtk/Skipped: Skip http/tests/multipart/stop-crash.html failing
- platform/qt/Skipped: Skip http/tests/multipart/stop-crash.html failing
- 01:28 Changeset [96205] by
-
WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
https://bugs.webkit.org/show_bug.cgi?id=68863
Reviewed by Darin Adler.
The SolarWalk binary does not link against WebKit.framework directly,
so calling NSVersionOfLinkTimeLibrary() will not return the version of
WebKit against which SolarWalk was linked. Since Solar Walk has
released an update that addresses the issue for which this app-specific
hack was originally added, we should just remove the hack.
Source/WebCore:
- WebCore.exp.in: Remove applicationIsSolarWalkMac().
- platform/RuntimeApplicationChecks.cpp: Ditto.
- platform/RuntimeApplicationChecks.h: Ditto.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Remove SolarWalkQuirksUserScript.js.
Source/WebKit/mac:
- Misc/SolarWalkQuirksUserScript.js: Removed.
- WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
leakSolarWalkQuirksUserScriptContents(), and
-[WebView _injectSolarWalkQuirksScript].
(-[WebView _commonInitializationWithFrameName:groupName:]): Do not
inject the Solar Walk quirks script.
- 01:21 Changeset [96204] by
-
fast/canvas/crash-set-font.html failing on all platform because
getCSSCanvasContext needs 4 parameters
https://bugs.webkit.org/show_bug.cgi?id=66291
Reviewed by Csaba Osztrogonác.
- fast/canvas/crash-set-font.html: adding the fourth parameter
- 01:06 Changeset [96203] by
-
Fix potential SVG performance regression (over-invalidation of caches) from 96052
https://bugs.webkit.org/show_bug.cgi?id=68941
<rdar://problem/10196224>
Reviewed by Zoltan Herczeg.
Only invalidate the cache of a filter when target style changes, as of the different types of cached
resources, only filters make use of the style of the target element and thus need to be invalidated
when the target style changes.
No new tests, performance improvement.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientUpdatedFromElement):
- 01:02 Changeset [96202] by
-
[EFL] Allow to skip count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get.
https://bugs.webkit.org/show_bug.cgi?id=65842
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Makes the count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get
as an optional parameter. Developer may pass NULL to skip returning the number of elements
of the requested array.
- ewk/ewk_view.cpp:
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
- 01:00 Changeset [96201] by
-
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed manual rebaseline for linux gpu.
- platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
- 00:54 Changeset [96200] by
-
[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
https://bugs.webkit.org/show_bug.cgi?id=68982
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 00:46 Changeset [96199] by
-
Web Inspector: Unreviewed. Slight adjustment of the test content for better representation of the performance.
- inspector/performance/resources/show-panel.html:
- 00:44 Changeset [96198] by
-
Unreviewed rebaseline pservers-grad-14-b again.
- platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
- platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.
- 00:39 Changeset [96197] by
-
Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
https://bugs.webkit.org/show_bug.cgi?id=68970
Unreviewed fix for a lint error in test_expectations.txt
- platform/chromium/test_expectations.txt:
- 00:22 Changeset [96196] by
-
Missing initialization of member in ImageFrameQt class
https://bugs.webkit.org/show_bug.cgi?id=68943
Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-09-28
Reviewed by Kenneth Rohde Christiansen.
No new tests, this fixes internal implementation detail.
- platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
- 00:12 Changeset [96195] by
-
[EFL] URL of resources are not decoded.
https://bugs.webkit.org/show_bug.cgi?id=66540
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Fix ewk_frame_resources_location_get which was returning the encoded URL of resources.
As a result characters for instance, %20 occurred. For now returned strings are decoded.
- ewk/ewk_frame.cpp:
(ewk_frame_resources_location_get):
- 00:02 Changeset [96194] by
-
Make Chromium Win Release (Tests) a core builder
https://bugs.webkit.org/show_bug.cgi?id=68906
Reviewed by Adam Barth.
Add Chromium Win Release (Tests) to the list of core builders.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
09/27/11:
- 23:46 Changeset [96193] by
-
[Qt] Unreviewed gardening. Add platform specific expected result for new test introduced in r96149.
- platform/qt/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/qt/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- 23:32 Changeset [96192] by
-
Defer call to CSSValue::isPrimitiveValue(), saves ~4% in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=68964
Reviewed by Eric Seidel.
No new tests / no functionality changed.
Doing value->isPrimitiveValue() is relatviely expensive, so moving it after the early returns but
before the result is used saves a significant number of cycles. (Tested with Shark profiler in Safari).
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 22:43 Changeset [96191] by
-
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed rebaseline for skia r2300 roll.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
- platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
- platform/chromium/test_expectations.txt:
- 22:37 Changeset [96190] by
-
Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
https://bugs.webkit.org/show_bug.cgi?id=68970
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 22:33 Changeset [96189] by
-
DFG JIT cannot compile op_new_object, op_new_array,
op_new_array_buffer, or op_new_regexp
https://bugs.webkit.org/show_bug.cgi?id=68580
Reviewed by Oliver Hunt.
This implements all four opcodes, but has op_new_regexp turns off
by default because it unveils some bad speculation logic when
compiling string-validate-input.
With op_new_regexp turned off, this is a 5% win on Kraken and a
0.7% speed-up on V8. Neutral on SunSpider.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::regexpIndex):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownArray):
- 22:26 BuildingGtk edited by
- Changed the libgail dependency to libgail-3-dev (diff)
- 22:23 Changeset [96188] by
-
Unreviewed. Fix a build error in WebKit EFL.
When web socket is disabled, there is a build break in WebKit EFL port.
Currently, web socket is enabled by default in build-webkit script.
Thus, the web socket is also enabled in EFL script of cmake build system for now.
Because, WebKit EFL developers can't work on latest WebKit trunk.
However, IMO, we should fix build errors when web socket is disabled.
- Source/cmake/OptionsEfl.cmake:
- 22:04 Changeset [96187] by
-
Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
https://bugs.webkit.org/show_bug.cgi?id=68939
Reviewed by Darin Adler.
Simplified ReplaceSelectionCommand::positionAtStartOfInsertedContent.
This change revealed a bug in removeUnrenderedTextNodesAtEnds that text nodes without any visible
text at ends are not removed when it has a render object. Fixed the bug by checking the length of
the rendered text. (Tested by editing/pasteboard/pasting-word-in-div-extra-line.html)
This further revealed that caretMaxRenderedOffset doesn't return an offset and caretMaxRenderedOffset
on InlineBox, InlineTextBox, RenderObject, RenderBR, RenderPlaced are never called. To address this
issue, renamed caretMaxRenderedOffset to renderedTextLength for RenderText and removed the rest.
- dom/Position.cpp:
(WebCore::Position::rendersInDifferentPosition):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeHasVisibleRenderText): Added.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Calls nodeHasVisibleRenderText.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Simplified.
- editing/visible_units.cpp:
(WebCore::startOfParagraph): Calls renderedTextLength.
(WebCore::endOfParagraph): Ditto.
- rendering/InlineBox.cpp: Removed caretMaxRenderedOffset.
- rendering/InlineBox.h: Ditto.
- rendering/InlineTextBox.cpp: Ditto.
- rendering/InlineTextBox.h: Ditto.
- rendering/RenderBR.cpp: Ditto.
- rendering/RenderBR.h: Ditto.
- rendering/RenderObject.cpp: Ditto.
- rendering/RenderObject.h: Ditto.
- rendering/RenderReplaced.cpp: Ditto.
- rendering/RenderReplaced.h: Ditto.
- rendering/RenderText.cpp:
(WebCore::RenderText::renderedTextLength): Renamed from caretMaxRenderedOffset.
- rendering/RenderText.h:
- 21:56 Changeset [96186] by
-
[chromium] LayerRenderChromium asserts about leaking textures.
https://bugs.webkit.org/show_bug.cgi?id=68190
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
(WebCore::TextureAllocator::~TextureAllocator):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
- platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.
(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- 21:03 Changeset [96185] by
-
[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
https://bugs.webkit.org/show_bug.cgi?id=68967
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).
Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
- 20:39 Changeset [96184] by
-
DFG JIT should speculate more aggressively on reads of array.length
https://bugs.webkit.org/show_bug.cgi?id=68932
Reviewed by Oliver Hunt.
This is a 2% speed-up on Kraken, neutral elsewhere.
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 20:37 Changeset [96183] by
-
garden-o-matic should load faster and inform the user what is happening
https://bugs.webkit.org/show_bug.cgi?id=68954
Reviewed by Dimitri Glazkov.
This test disables the expected failures tab. The web inspector showed
that loading the data for this tab was slowing down the loading time
for the whole app. We need to find a way to load that data lazily.
This patch also improves the update message to better describe the
progress the app is making analyzing data from the buildbot.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- 19:58 Changeset [96182] by
-
Add layout test for WaveShaperNode
https://bugs.webkit.org/show_bug.cgi?id=68925
Reviewed by Kenneth Russell.
- webaudio/waveshaper-expected.txt: Added.
- webaudio/waveshaper.html: Added.
- 19:48 Changeset [96181] by
-
garden-o-matic should show the first result when examining results
https://bugs.webkit.org/show_bug.cgi?id=68960
Reviewed by Dimitri Glazkov.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- 19:30 Changeset [96180] by
-
Implement a PageTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68067
Patch by Kentaro Hara <haraken@chromium.com> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/page-transition-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
- dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.
- platform/chromium/test_expectations.txt:
- 19:02 Changeset [96179] by
-
Implement a MessageEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68883
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
The spec for MessageEvent is here:
http://www.whatwg.org/specs/web-apps/current-work/#messageevent
Currently, some tests in fast/events/constructors/message-event-constructor.html
are failing or crashing in DRT, as we commented in the test file.
This is because MessageEvent.data is implemented as SerializedScriptValue,
and thus it cannot keep ScriptValue passed by JavaScript.
This is the same issue as the bug (https://bugs.webkit.org/show_bug.cgi?id=68345).
We will soon make a follow-up patch to fix these failures, after this
patch is landed.
Test: fast/events/constructors/message-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the MessageEvent constructor.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Generates MessagePortArray from the list of message ports in the format of JSValues.
- bindings/js/JSDictionary.h:
- bindings/js/JSEventConstructors.cpp: Added #includes for MessageEvent.
- dom/MessageEvent.cpp:
(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
- dom/MessageEvent.h: Added a definition for MessageEvent. Removed an extra leading spaces.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::origin):
(WebCore::MessageEvent::lastEventId):
(WebCore::MessageEvent::source):
(WebCore::MessageEvent::ports):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):
- dom/MessageEvent.idl: Makes MessageEvent constructible.
LayoutTests:
message-event-constructor.html checks the behavior of the MessageEvent constructor.
- fast/dom/constructed-objects-prototypes-expected.txt: Now window has MessageEvent.
- fast/events/constructors/message-event-constructor-expected.txt: Added.
- fast/events/constructors/message-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped message-event-constructor.html, since V8 does not yet have the MessageEvent constructor.
- 18:52 Changeset [96178] by
-
DFG JIT - merge changes between 95905 - 96175
https://bugs.webkit.org/show_bug.cgi?id=68963
Reviewed by Sam Weinig.
Merge missing changes from bug#68677, bug#68784, bug#68785.
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 18:46 Changeset [96177] by
-
[Chromium/FileWriter] race condition in FileWriter completion can lead to assert
https://bugs.webkit.org/show_bug.cgi?id=67684
Reviewed by David Levin.
Source/WebCore:
Tests: fast/filesystem/file-writer-abort-continue.html
fast/filesystem/file-writer-abort.html
Track the state of the backend and be prepared for reentrant user
requests. Limit recursion depth to an arbitrary small constant.
- fileapi/FileWriter.cpp: Lots of event-handling changes.
- fileapi/FileWriter.h:
LayoutTests:
- fast/filesystem/file-writer-abort-continue-expected.txt: Added.
- fast/filesystem/file-writer-abort-continue.html: Added.
- fast/filesystem/file-writer-abort-expected.txt: Added.
- fast/filesystem/file-writer-abort.html: Added.
- fast/filesystem/resources/file-writer-abort-continue.js: Added.
- fast/filesystem/resources/file-writer-abort.js: Added.
- fast/filesystem/resources/file-writer-events.js: Fixed a copy-paste error.
- 18:12 Changeset [96176] by
-
svg/custom/oversized-pattern-scale.svg is useless because the interesting part of the test is off the screen
https://bugs.webkit.org/show_bug.cgi?id=68945
Reviewed by Darin Adler.
Change oversized-pattern-scale so that the interesting part of the pattern is on the screen,
and so that it doesn't draw a scrollbar (making it platform-independent).
Change transformed-pattern-clamp-svg-root so that it doesn't draw a gradient, making it platform-independent.
- svg/custom/oversized-pattern-scale-expected.png:
- svg/custom/oversized-pattern-scale-expected.txt:
- svg/custom/oversized-pattern-scale.svg:
- svg/custom/transformed-pattern-clamp-svg-root-expected.png:
- svg/custom/transformed-pattern-clamp-svg-root-expected.txt:
- svg/custom/transformed-pattern-clamp-svg-root.svg:
- 18:09 Changeset [96175] by
-
Get JSVALUE32_64 DFG JIT building on OS X.
https://bugs.webkit.org/show_bug.cgi?id=68961
Reviewed by Geoff Garen.
- Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file).
- Forward-declare functions in DFGOperations.cpp
- UNUSED_PARAM for unused arguments
- NO_RETURN for unimplemented function that ASSERT_NOT_REACHED
- Fix argument types handled by OpInfo constructor.
- Use SYMBOL_STRING instead of STRINGIZE for asm symbols.
- Add files to Xcode project.
- 18:01 Changeset [96174] by
-
http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=34222
Reviewed by Ryosuke Niwa.
Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).
- http/tests/multipart/stop-crash-expected.txt:
- http/tests/multipart/stop-crash.html:
- 17:25 Changeset [96173] by
-
Unreviewed, rolling out r96141.
http://trac.webkit.org/changeset/96141
https://bugs.webkit.org/show_bug.cgi?id=68190
Breaks PrerenderBrowserTest.PrerenderHTML5Video in
browser_tests
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::createLayerTexture):
(WebCore::LayerRendererChromium::deleteLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TrackingTextureAllocator.cpp: Removed.
- platform/graphics/chromium/TrackingTextureAllocator.h: Removed.
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp.rej: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- 16:51 Changeset [96172] by
-
[chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=68953
Reviewed by Kenneth Russell.
The accelerated drawing code is incompatible with threaded compositing. Rather than tying the two behaviors
together via USE(THREADED_COMPOSITING), this patch guards the accelerated drawing code with its own USE() guard
so the features can advance independently. Today, it's not safe to set both of these flags.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- 16:48 Changeset [96171] by
-
Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68755
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Gavin Barraclough.
We need to load/store and repatch both tag and payload of a property
for GetById/PutById. Also reorder the loads of tag and payload for
GetByOffset as the result tag GPR could reuse the storage GPR.
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 16:42 Changeset [96170] by
-
watchlist: Add support for cc and message rules.
https://bugs.webkit.org/show_bug.cgi?id=68950
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
the cc's and messages for a patch.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
for the rules.
- Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
A generic encapsulation of either a message list or a cc list.
- Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
- 16:32 Changeset [96169] by
-
Macro assembler branch8 & 16 methods vary in treatment of upper bits
https://bugs.webkit.org/show_bug.cgi?id=68301
Reviewed by Sam Weinig.
Fix for branch16 - remove it!
No performance impact.
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
- assembler/MacroAssemblerSH4.h:
- assembler/MacroAssemblerX86Common.h:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
- 16:24 Changeset [96168] by
-
Slightly improve performance of CSSStyleApplyProperty handler lookup.
https://bugs.webkit.org/show_bug.cgi?id=68868
Reviewed by Eric Seidel.
No new tests as no functionality changed.
- css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::propertyHandler):
Make propertyHandler() public and remove redirecting functions.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Perform property handler lookup once and reuse the result.
- 16:11 Changeset [96167] by
-
Chromium baselines for fast/multicol/float-paginate-empty-lines.html
after r96149 and 96162.
- platform/chromium-linux/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/chromium-mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- 16:05 Changeset [96166] by
-
[V8] element.dataset.nonExistingKey should return undefined.
https://bugs.webkit.org/show_bug.cgi?id=68877
Reviewed by Nate Chapin.
Source/WebCore:
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter): Uses v8StringOrUndefined() instead of v8String().
LayoutTests:
- fast/dom/dataset-expected.txt: Updated.
- fast/dom/script-tests/dataset.js: Add a test case.
- 15:53 Changeset [96165] by
-
Chromium rebaseline after r96155.
- platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
- platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
- platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
- platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
- platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- 15:46 Changeset [96164] by
-
Source/JavaScriptCore: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallDataVirtual):
(JSC::JSCallbackFunction::getCallData):
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::getCallDataVirtual):
(JSC::::getCallData):
- API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getCallDataVirtual):
(JSC::ArrayConstructor::getCallData):
- runtime/ArrayConstructor.h:
- runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getCallDataVirtual):
(JSC::BooleanConstructor::getCallData):
- runtime/BooleanConstructor.h:
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::getCallDataVirtual):
(JSC::DateConstructor::getCallData):
- runtime/DateConstructor.h:
- runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getCallDataVirtual):
(JSC::ErrorConstructor::getCallData):
- runtime/ErrorConstructor.h:
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallDataVirtual):
(JSC::FunctionConstructor::getCallData):
- runtime/FunctionConstructor.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::getCallDataVirtual):
(JSC::FunctionPrototype::getCallData):
- runtime/FunctionPrototype.h:
- runtime/InternalFunction.h:
- runtime/JSCell.cpp:
(JSC::JSCell::getCallDataVirtual):
(JSC::JSCell::getCallData):
- runtime/JSCell.h:
(JSC::getCallData):
- runtime/JSFunction.cpp:
(JSC::JSFunction::getCallDataVirtual):
(JSC::JSFunction::getCallData):
- runtime/JSFunction.h:
- runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getCallDataVirtual):
(JSC::NativeErrorConstructor::getCallData):
- runtime/NativeErrorConstructor.h:
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getCallDataVirtual):
(JSC::NumberConstructor::getCallData):
- runtime/NumberConstructor.h:
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getCallDataVirtual):
(JSC::ObjectConstructor::getCallData):
- runtime/ObjectConstructor.h:
- runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getCallDataVirtual):
(JSC::RegExpConstructor::getCallData):
- runtime/RegExpConstructor.h:
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::getCallDataVirtual):
(JSC::StringConstructor::getCallData):
- runtime/StringConstructor.h:
Source/JavaScriptGlue: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCallFunction):
- UserObjectImp.cpp:
(UserObjectImp::getCallDataVirtual):
(UserObjectImp::getCallData):
- UserObjectImp.h:
Source/WebCore: Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404
Reviewed by Darin Adler.
No new tests.
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
- WebCore.exp.in:
- bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):
- bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):
- bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):
- bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):
- bindings/scripts/test/JS/JSTestObj.h:
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
- bridge/qt/qt_runtime.h:
- workers/WorkerContext.h:
Source/WebKit/mac: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
Source/WebKit2: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::getCallDataVirtual):
(WebKit::JSNPMethod::getCallData):
- WebProcess/Plugins/Netscape/JSNPMethod.h:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getCallDataVirtual):
(WebKit::JSNPObject::getCallData):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- 15:43 Changeset [96163] by
-
Unreviewed. Remove duplicate FilterOperation{s}.h that were
accidentally added to the top level of the Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- 15:11 Changeset [96162] by
-
https://bugs.webkit.org/show_bug.cgi?id=68940
Narrow the float/lines pagination heuristic to only kick in if
the previous line broke cleanly and if the floats are occurring
at the start of the line.
Reviewed by Dan Bernstein.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine):
LayoutTests:
- fast/regions/webkit-flow-float-pushed-to-last-region.html:
- platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
- 15:04 Changeset [96161] by
-
webkit-patch doesn't like UTF-8 characters in reviewers names
https://bugs.webkit.org/show_bug.cgi?id=63452
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-27
Reviewed by Eric Seidel.
- Scripts/webkit-patch:
- 14:47 Changeset [96160] by
-
Add a mechanism to test for the compositing tree mutated during painting
https://bugs.webkit.org/show_bug.cgi?id=68738
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Sets a static bool during GraphicsLayer::paintGraphicsLayerContents and ASSERT()s that we never create or
destroy a GraphicsLayer inside this function. Painting should never mutate the GraphicsLayer tree.
Test: compositing/video/video-with-invalid-source.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
LayoutTests:
Adds a test that caused compositing to be disabled during painting before r95863 due to a video load failing.
- compositing/video/video-with-invalid-source-expected.txt: Added.
- compositing/video/video-with-invalid-source.html: Added.
- 14:45 Changeset [96159] by
-
take padding/border on flexbox into account with direction:rtl
https://bugs.webkit.org/show_bug.cgi?id=68846
Reviewed by David Hyatt.
Source/WebCore:
Use the logicalWidth of the flexbox instead of it's availableLogicalWidth
so that we include the flexbox's border and padding.
Also, change all uses of availableLogicalWidth to contentLogicalWidth.
The former takes multi-column into account. Multi-column flexboxes don't
make any sense, so there's no point in calling availableLogicalWidth.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/writing-modes-expected.txt:
- css3/flexbox/writing-modes.html:
- 14:43 QtWebKitSecurity edited by
- (diff)
- 14:41 QtWebKitSecurity edited by
- (diff)
- 14:31 QtWebKitSecurity edited by
- (diff)
- 14:30 QtWebKitReleases edited by
- (diff)
- 14:29 QtWebKitSecurity edited by
- (diff)
- 14:25 Changeset [96158] by
-
Chromium test expectations update.
Make new fast/canvas/canvas-composite.html GPU expectation more specific,
since on Leopard it was conflicting with an older one.
- platform/chromium/test_expectations.txt:
- 14:23 QtWebKitSecurity edited by
- (diff)
- 14:20 QtWebKitReleases edited by
- (diff)
- 14:19 Changeset [96157] by
-
Unreviewed, rolling out r96139.
http://trac.webkit.org/changeset/96139
https://bugs.webkit.org/show_bug.cgi?id=68933
Broke table-percent-height.html on Mac bots (Requested by
mwenge2 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
- rendering/RenderBox.h:
LayoutTests:
- fast/replaced/table-percent-width-expected.txt: Removed.
- fast/replaced/table-percent-width.html: Removed.
- 14:17 QtWebKitReleases edited by
- (diff)
- 14:13 QtWebKitSecurity edited by
- (diff)
- 14:12 Changeset [96156] by
-
need to rebseline these once new aa-gdi-text code lands in skia
https://bugs.webkit.org/show_bug.cgi?id=68920
Reviewed by Kenneth Russell.
- platform/chromium/test_expectations.txt:
- 14:08 QtWebKitSecurity edited by
- (diff)
- 14:06 QtWebKitSecurity edited by
- (diff)
- 14:06 Changeset [96155] by
-
REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns
https://bugs.webkit.org/show_bug.cgi?id=67700
<rdar://problem/10125102>
Reviewed by Darin Adler.
Clamp all resources to the same size, 4096x4096 (arbitrarily chosen), instead of to the size
of the <svg> element. This fixes the case where a transformed element displays part of a resource
outside of the size of the <svg> element.
When drawing an oversized pattern into its tile image, scale the content down to fit. When drawing
the tile image to the screen, scale it back up to fit the expected area. This will cause pixelation
when patterns are over the 4k limit.
Tests: svg/custom/transformed-pattern-clamp-svg-root.svg, svg/custom/oversized-pattern-scale.svg
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRect):
- rendering/svg/SVGImageBufferTools.h:
pattern-excessive-malloc is so excessive that it runs into the floating point precision barrier
when determining the scale to draw the pattern at; drop the size two orders of magnitude, which is
still very excessive but easier to draw with.
Add a test (transformed-pattern-clamp-svg-root.svg) that ensures that patterns on transformed
elements are displayed correctly, instead of being clamped to the size of the <svg> element.
Add a test (oversized-pattern-scale.svg) that ensures that oversized patterns are correctly drawn
into the pattern tile scaled down and then are scaled back up when drawn to the screen.
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
- platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
- svg/custom/pattern-excessive-malloc-expected.txt:
- svg/custom/pattern-excessive-malloc.svg:
- svg/custom/oversized-pattern-scale-expected.png: Added.
- svg/custom/oversized-pattern-scale-expected.txt: Added.
- svg/custom/oversized-pattern-scale.svg: Added.
- svg/custom/transformed-pattern-clamp-svg-root.svg: Added.
- svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
- svg/custom/transformed-pattern-clamp-svg-root-expected.txt: Added.
- 14:04 Changeset [96154] by
-
<rdar://problem/10098679> Assertion failure in RenderLayer::paintPaginatedChildLayer()
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/dynamic/layer-no-longer-paginated.html
FrameView::layout() calls adjustViewSize() before calling RenderLayer::updateLayerPositions().
The former may trigger painting with a layer tree that is not entirely up-to-date. Specifically,
the isPaginated() state of a layer may be incorrect, leading to the assertion in this bug. Instead
of asserting, return early and count on the upcoming updateLayerPositions() to repaint as needed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Replaced the assertion with an early return.
LayoutTests:
- fast/dynamic/layer-no-longer-paginated-expected.txt: Added.
- fast/dynamic/layer-no-longer-paginated.html: Added.
- 14:02 Changeset [96153] by
-
garden-o-matic examine buttons shows both expected and unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=68918
Reviewed by Dimitri Glazkov.
This was a copy/paste error when I refactored this classes to share
more code.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- 13:55 Changeset [96152] by
-
offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes
https://bugs.webkit.org/show_bug.cgi?id=68304
Reviewed by David Hyatt.
Source/WebCore:
When grabbing the x/y values of the RenderBox, we need to take writing mode
flipping into account.
Test: fast/dom/offset-position-writing-modes.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::locationIncludingFlipping):
- rendering/RenderBox.h:
(WebCore::RenderBox::yFlippedForWritingMode):
(WebCore::RenderBox::xFlippedForWritingMode):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
LayoutTests:
- css3/flexbox/writing-modes-expected.txt:
- css3/flexbox/writing-modes.html:
- fast/dom/offset-position-writing-modes-expected.txt: Added.
- fast/dom/offset-position-writing-modes.html: Added.
- 13:54 Changeset [96151] by
-
Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
https://bugs.webkit.org/show_bug.cgi?id=68816
<rdar://problem/10186468>
Reviewed by Simon Fraser.
If a filter returns without writing into its result buffer, make sure to return an cleared buffer.
Test: svg/filters/feMorphology-zero-radius.svg
- 13:51 Changeset [96150] by
-
CompositeEditCommand::prune should remove subtree at once
https://bugs.webkit.org/show_bug.cgi?id=68866
Reviewed by Darin Adler.
Extracted the logic to find the highest ancestor to remove as highestNodeToRemoveInPruning from prune.
This reduces the number of node removals from O(n) to O(1) where n is the depth of the tree.
- editing/CompositeEditCommand.cpp:
(WebCore::hasARenderedDescendant): Takes excludedNode in addition to node. excludedNode is used to ignore
the child node from which we climbed up the tree in highestNodeToRemoveInPruning.
(WebCore::highestNodeToRemoveInPruning): Extracted from prune.
(WebCore::CompositeEditCommand::prune):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- 13:39 Changeset [96149] by
-
https://bugs.webkit.org/show_bug.cgi?id=68922
Source/WebCore:
Paginated floats should not grow the height of a block when they don't end
up being tied to a line. Floats encountered in skipLeadingWhitespace that
paginate can't immediately grow the height of the block, since there may not
end up being any actual line content. We only want to push the height of the
block down if we have actual line content that we want to keep with the
float.
Make positionNewFloatOnLine check if the line is empty or not, and if it is,
it just puts the desired pagination strut into LineInfo. If and when actual
line content is encountered and setEmpty becomes false, we'll grow the block
height then.
Reviewed by Dan Bernstein.
Added fast/multicol/float-paginate-empty-lines.html and
fast/regions/webkit-flow-double-pagination-float-push.html.
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setFloatPaginationStrut):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::positionNewFloatOnLine):
LayoutTests:
Paginated floats should not grow the height of a block when they don't end
up being tied to a line.
Reviewed by Dan Bernstein.
- fast/multicol/float-paginate-empty-lines.html: Added.
- fast/regions/webkit-flow-double-pagination-float-push.html: Added.
- platform/mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
- 13:35 QtWebKitSecurity edited by
- (diff)
- 13:34 QtWebKitSecurity edited by
- (diff)
- 13:29 Changeset [96148] by
-
Add Kaustubh Atrawalkar to the list of contributors.
- Scripts/webkitpy/common/config/committers.py:
- 13:28 QtWebKitSecurity edited by
- (diff)
- 13:24 Changeset [96147] by
-
[Chromium] Fixed layout mode tests break subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=68923
Reviewed by Adam Barth.
Reset fixed layout mode between tests, so that tests that run after
platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
regular 800x600 non-fixed layout.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):
- 13:16 Changeset [96146] by
-
Unreviewed, rolling out r96131.
http://trac.webkit.org/changeset/96131
https://bugs.webkit.org/show_bug.cgi?id=68927
It made 18+ tests crash on all platform (Requested by
Ossy_night on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
- jsc.cpp:
(GlobalObject::finishCreation):
- parser/Parser.h:
(JSC::Parser::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
LayoutTests:
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Removed.
- fast/js/stack-trace-expected.txt: Removed.
- fast/js/stack-trace.html: Removed.
- platform/chromium/test_expectations.txt:
- 13:05 Changeset [96145] by
-
[Qt] QDesktopWebView load zero size view test missing
https://bugs.webkit.org/show_bug.cgi?id=68655
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-27
Reviewed by Chang Shu.
Added test case to check load behavior with zero size view.
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 12:55 Changeset [96144] by
-
watchlist: Add the filename pattern for definitions.
https://bugs.webkit.org/show_bug.cgi?id=68917
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
- Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
- Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
for definitions.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
- 12:53 Changeset [96143] by
-
De-virtualize JSCell::getPrimitiveNumber
https://bugs.webkit.org/show_bug.cgi?id=68851
Reviewed by Darin Adler.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Changed JSCell::getPrimitiveNumber to manually handle the dispatch for
JSCells (JSObject and JSString in this case).
- runtime/JSCell.cpp:
(JSC::JSCell::getPrimitiveNumber):
- runtime/JSCell.h:
Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't
matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
can cover the case for JSNotAnObject.
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber
and changed them to be const. Also made JSString::getPrimitiveNumber public
because it needs to be called from JSCell::getPrimitiveNumber and also since it's
no longer virtual, we want people who have a more specific pointer (JSString*
instead of JSCell*) to not have to pay the cost of a virtual method call.
- runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
- runtime/JSObject.h:
- runtime/JSString.cpp:
(JSC::JSString::getPrimitiveNumber):
- runtime/JSString.h:
- 12:49 Changeset [96142] by
-
Add 'filter' value to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=68471
Reviewed by Simon Fraser.
Add a filter property to RenderStyle when ENABLE(CSS_FILTERS)
is turned on. Similar to -webkit-transform, -webkit-filter is a
list of FilterOperations, each identifying what type of operation
it is. This change simply adds the basic objects, it does not
parse the property to generate the list.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FilterOperation.h: Added.
(WebCore::FilterOperation::~FilterOperation):
(WebCore::FilterOperation::operator!=):
(WebCore::FilterOperation::getOperationType):
(WebCore::FilterOperation::isSameType):
(WebCore::FilterOperation::FilterOperation):
(WebCore::ReferenceFilterOperation::create):
(WebCore::ReferenceFilterOperation::reference):
(WebCore::ReferenceFilterOperation::operator==):
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::BasicColorMatrixFilterOperation::create):
(WebCore::BasicColorMatrixFilterOperation::amount):
(WebCore::BasicColorMatrixFilterOperation::operator==):
(WebCore::BasicColorMatrixFilterOperation::BasicColorMatrixFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::create):
(WebCore::BasicComponentTransferFilterOperation::amount):
(WebCore::BasicComponentTransferFilterOperation::operator==):
(WebCore::BasicComponentTransferFilterOperation::BasicComponentTransferFilterOperation):
(WebCore::GammaFilterOperation::create):
(WebCore::GammaFilterOperation::amplitude):
(WebCore::GammaFilterOperation::exponent):
(WebCore::GammaFilterOperation::offset):
(WebCore::GammaFilterOperation::operator==):
(WebCore::GammaFilterOperation::GammaFilterOperation):
(WebCore::BlurFilterOperation::create):
(WebCore::BlurFilterOperation::stdDeviationX):
(WebCore::BlurFilterOperation::stdDeviationY):
(WebCore::BlurFilterOperation::operator==):
(WebCore::BlurFilterOperation::BlurFilterOperation):
(WebCore::SharpenFilterOperation::create):
(WebCore::SharpenFilterOperation::radius):
(WebCore::SharpenFilterOperation::threshold):
(WebCore::SharpenFilterOperation::amount):
(WebCore::SharpenFilterOperation::operator==):
(WebCore::SharpenFilterOperation::SharpenFilterOperation):
(WebCore::DropShadowFilterOperation::create):
(WebCore::DropShadowFilterOperation::shadow):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
- platform/graphics/filters/FilterOperations.cpp: Added.
(WebCore::FilterOperations::FilterOperations):
(WebCore::FilterOperations::operator==):
- platform/graphics/filters/FilterOperations.h: Added.
(WebCore::FilterOperations::operator!=):
(WebCore::FilterOperations::clear):
(WebCore::FilterOperations::operations):
(WebCore::FilterOperations::size):
(WebCore::FilterOperations::at):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::filter):
(WebCore::InheritedFlags::hasFilter):
(WebCore::InheritedFlags::setFilter):
(WebCore::InheritedFlags::initialFilter):
- rendering/style/StyleAllInOne.cpp: Added include of new StyleFilterData.
- rendering/style/StyleFilterData.cpp: Added.
(WebCore::StyleFilterData::StyleFilterData):
(WebCore::StyleFilterData::operator==):
- rendering/style/StyleFilterData.h: Added.
(WebCore::StyleFilterData::create):
(WebCore::StyleFilterData::copy):
(WebCore::StyleFilterData::operator!=):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h: New filter DataRef.
- 12:41 Changeset [96141] by
-
[chromium] LayerRenderChromium asserts about leaking textures.
https://bugs.webkit.org/show_bug.cgi?id=68190
Reviewed by Kenneth Russell.
This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
(WebCore::TextureAllocator::~TextureAllocator):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
- platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.
(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- 12:34 Changeset [96140] by
-
[EFL] Make ewk_view emit the "load,document,finished" signal.
https://bugs.webkit.org/show_bug.cgi?id=66782
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-27
Reviewed by Antonio Gomes.
Currently, only ewk_frame emits the "load,document,finished" signal
when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
ewk_frame_load_document_finished().
However, in some cases it is not even possible to connect to the
"frame,created" signal to properly monitor the
"load,document,finished" signal, as the former is not emitted.
fast/frames/frame-unload-crash.html, for example, has a page with an
iframe inside an iframe, and this innermost iframe does not seem to be
loaded via FrameLoaderClientEfl::createFrame (which calls all the
machinery which then emits the "frame,created" signal).
We now make ewk_frame_load_document_finished() call the newly-created
ewk_view_load_document_finished() function, whose job is to emit the
"load,document,signal" with the frame as its parameter. This way, one
can just connect to the view and make sure all the signals will get
delivered.
- ewk/ewk_frame.cpp:
(ewk_frame_load_document_finished):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(ewk_view_load_document_finished):
- ewk/ewk_view.h:
- 12:31 Changeset [96139] by
-
Reviewed by David Hyatt.
Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447
Source/WebCore:
If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.
Test: fast/replaced/table-percent-width.html
- rendering/RenderBox.cpp:
(WebCore::avoidSqueezingWidth):
(WebCore::avoidSqueezingHeight):
(WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
- rendering/RenderBox.h:
LayoutTests:
- fast/replaced/table-percent-width.html: Added.
- fast/replaced/table-percent-width-expected.txt: Added.
- 12:00 Changeset [96138] by
-
https://bugs.webkit.org/show_bug.cgi?id=67858
Roll r96070 back in now that the crash has been fixed in r96130.
Source/WebCore:
Reviewed by Darin Adler.
When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.
Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
- platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
- rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.
LayoutTests:
- compositing/iframes/repaint-after-losing-scrollbars-expected.png:
- 11:44 Changeset [96137] by
-
Fix Chromium Mac build after r96130.
- page/FrameView.cpp:
(WebCore::FrameView::layerForOverhangAreas):
- 11:32 Changeset [96136] by
-
[GTK] Use WebKitWebContext in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=67990
Reviewed by Martin Robinson.
Use webkit_web_context_get_default() instead of
WKContextGetSharedProcessContext() and add API to create a view
with a given web context and to return the current context
associated to the view.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetWKContext): Private API to get the WKContext
wrapped by the WebKitWebContext.
- UIProcess/API/gtk/WebKitWebContextPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the webpage using the web
context of the view.
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_init):
(webkit_web_view_class_init):
(webkit_web_view_new): Create a new view with the default context.
(webkit_web_view_new_with_context): Create a new view with the
given context.
(webkit_web_view_get_context): Return the context.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/tests/testwebview.c: Added.
(testWebViewDefaultContext):
(main):
- 11:19 Changeset [96135] by
-
[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.
Install the flag, which indicates whether or not the optimization
script was executed, on the global object.
https://bugs.webkit.org/show_bug.cgi?id=68890
Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
- Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
- 11:17 Changeset [96134] by
-
Autofocus on readonly inputs does not focus the element.
https://bugs.webkit.org/show_bug.cgi?id=24092
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-27
Reviewed by Ryosuke Niwa.
Source/WebCore:
Readonly input elements should be autofocusable. Removed the check.
Tests: fast/forms/autofocus-readonly-attribute.html
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
LayoutTests:
- fast/forms/autofocus-readonly-attribute-expected.txt: Added.
- fast/forms/autofocus-readonly-attribute.html: Added.
- 11:06 Changeset [96133] by
-
[GTK] Add WebKitWebContext to GTK API
https://bugs.webkit.org/show_bug.cgi?id=67931
Reviewed by Philippe Normand.
Initial implementation of WebKitWebContext for WebKit2 GTK API.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebContext.cpp: Added.
(webkitWebContextFinalize):
(webkit_web_context_init):
(webkit_web_context_class_init):
(createDefaultWebContext):
(webkit_web_context_get_default):
- UIProcess/API/gtk/WebKitWebContext.h: Added.
- UIProcess/API/gtk/tests/testwebcontext.c:
(testWebContextDefault):
(main):
- UIProcess/API/gtk/webkit2.h: Add <webkit2/WebKitWebContext.h>.
- 11:04 Changeset [96132] by
-
Remove duplicate of fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
https://bugs.webkit.org/show_bug.cgi?id=68915
Reviewed by Ryosuke Niwa.
r92496 and r92881 were only trying to move the baselines to
platform/mac-snowleopard/platform/mac/fast, but they also inadvertedly
copied the test itself.
- platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.
- 10:58 Changeset [96131] by
-
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Patch by Juan Carlos Montemayor Elosua <j.mont@me.com> on 2011-09-27
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(JSC::StackFrame::toString):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
- parser/Parser.h:
(JSC::Parser::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
LayoutTests:
Unit tests that contain both normal and special cases for stack trace
generation.
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
- fast/js/stack-trace-expected.txt: Added.
- fast/js/stack-trace.html: Added.
- platform/chromium/test_expectations.txt:
- 10:55 Changeset [96130] by
-
Clean up how FrameView accesses the RenderView
https://bugs.webkit.org/show_bug.cgi?id=68914
Reviewed by Sam Weinig.
Clean up how FrameView accesses the content renderer of its
frame. Previously, this was done in several different ways,
only some of which did null-checking.
Use an inline method to avoid having to expose Frame
in the header.
Standardize the terminology to use 'root' for this RenderView.
- page/FrameView.cpp:
(WebCore::rootRenderer):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):
- 10:53 Changeset [96129] by
-
garden-o-matic results view should sort test and builder names
https://bugs.webkit.org/show_bug.cgi?id=68488
Reviewed by Andy Estes.
Previously, the test and builder names were displayed in an arbitrary
order that changed from time to time. That confused one user study
participant. This patch sorts the lists so that they occur in a
predictable order.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- 10:38 Changeset [96128] by
-
[Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882
Unreviewed rebaseline.
- platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:29 Changeset [96127] by
-
AXObjectCache cleared unnecessarily when non-top Document is detached.
https://bugs.webkit.org/show_bug.cgi?id=68636
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-27
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/deleting-iframe-destroys-axcache.html
- dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::detach):
LayoutTests:
- accessibility/deleting-iframe-destroys-axcache.html: Added.
- platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
- 10:27 Changeset [96126] by
-
Unreviewed, rolling out r96108, r96111, r96113, and r96116.
http://trac.webkit.org/changeset/96108
http://trac.webkit.org/changeset/96111
http://trac.webkit.org/changeset/96113
http://trac.webkit.org/changeset/96116
https://bugs.webkit.org/show_bug.cgi?id=68913
Wait for working Qt5 (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
.:
- Source/WebKit.pro:
Source/WebCore:
- WebCore.pri:
- platform/graphics/qt/GraphicsLayerQt.cpp:
Source/WebKit/qt:
- Api/qgraphicswebview.cpp:
- Api/qgraphicswebview.h:
- Api/qwebframe.h:
- Api/qwebhistory.h:
- Api/qwebpage.h:
- Api/qwebsettings.h:
- Api/qwebview.h:
- QtWebKit.pro:
- WebCoreSupport/PageClientQt.h:
- WebCoreSupport/QtWebComboBox.cpp:
- WebCoreSupport/QtWebComboBox.h:
- declarative/declarative.pro:
- declarative/qdeclarativewebview.cpp:
- declarative/qdeclarativewebview_p.h:
- docs/webkitsnippets/webpage/main.cpp:
- examples/platformplugin/WebNotificationPresenter.h:
- tests/tests.pri:
Source/WebKit2:
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::chooseFiles):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/tests/tests.pri:
- UIProcess/API/qt/tests/tests.pro:
- UIProcess/qt/ViewInterface.h:
- UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/ImageDiff.pro:
- MiniBrowser/qt/BrowserView.cpp:
(BrowserView::BrowserView):
- MiniBrowser/qt/BrowserView.h:
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowser.pro:
- MiniBrowser/qt/MiniBrowserApplication.h:
- MiniBrowser/qt/main.cpp:
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/launcherwindow.cpp:
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/locationedit.h:
- QtTestBrowser/main.cpp:
- QtTestBrowser/mainwindow.cpp:
- QtTestBrowser/mainwindow.h:
- QtTestBrowser/webinspector.h:
- QtTestBrowser/webpage.cpp:
- QtTestBrowser/webview.cpp:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::wkView):
(WTR::WebView::pageRef):
(WTR::WebView::~WebView):
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- 10:26 Changeset [96125] by
-
dump-as-markup conversion: editing/pasteboard/merge-end-list.html and merge-end-table.html
https://bugs.webkit.org/show_bug.cgi?id=68857
Reviewed by Kent Tamura.
Converted the tests into dump-as-markup tests. Also split each test into two tests.
- editing/pasteboard/merge-end-list-2-expected.txt: Added.
- editing/pasteboard/merge-end-list-2.html: Added.
- editing/pasteboard/merge-end-list-expected.txt: Added.
- editing/pasteboard/merge-end-list.html:
- editing/pasteboard/merge-end-table-2-expected.txt: Added.
- editing/pasteboard/merge-end-table-2.html: Added.
- editing/pasteboard/merge-end-table-expected.txt: Added.
- editing/pasteboard/merge-end-table.html:
- platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-cg-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt: Removed.
- platform/gtk/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/gtk/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/gtk/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/gtk/editing/pasteboard/merge-end-table-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/mac/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/mac/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/mac/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/mac/editing/pasteboard/merge-end-table-expected.txt: Removed.
- platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/qt/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/qt/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/qt/editing/pasteboard/merge-end-table-expected.txt: Removed.
- 10:18 Changeset [96124] by
-
Crash in WebCore::HTMLParser::createHead
https://bugs.webkit.org/show_bug.cgi?id=32426
Reviewed by Darin Adler.
The crash was fixed some time ago but the test was not landed which kept the bug open.
- fast/parser/crash-HTMLParser-createHead.html: Added.
Tweaked the test case as we now throw an exception (DOM Exception 12).
- 10:06 Changeset [96123] by
-
Fix ENABLE(SQL_DATABASE)=0 build after r95919
https://bugs.webkit.org/show_bug.cgi?id=68902
r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.
Reviewed by Adam Barth.
- platform/sql/SQLiteAuthorizer.cpp:
- platform/sql/SQLiteDatabase.cpp:
- platform/sql/SQLiteFileSystem.cpp:
- platform/sql/SQLiteStatement.cpp:
- platform/sql/SQLiteTransaction.cpp:
- storage/DatabaseAuthorizer.cpp:
- 09:55 Changeset [96122] by
-
Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
https://bugs.webkit.org/show_bug.cgi?id=66291
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/canvas/crash-set-font.html
This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
list as Font::update was never called.
The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
Until this happens, it is better not to crash.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
mutated by the previous property change. Also added a comment explaining why it is safe to do it
this way.
LayoutTests:
- fast/canvas/crash-set-font-expected.txt: Added.
- fast/canvas/crash-set-font.html: Added.
- 09:40 Changeset [96121] by
-
[GTK] Rename WebKit2 GTK+ API main header as webkit2.h
https://bugs.webkit.org/show_bug.cgi?id=65178
Reviewed by Martin Robinson.
Source/WebKit2:
- GNUmakefile.am: Add webkit2.h.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
- webkit2gtk.pc.in: Use webkitgtk-<api-version> as include dir.
Tools:
- GNUmakefile.am:
- GtkLauncher/main.c: Include <webkit2/webkit2.h>.
- 09:38 Changeset [96120] by
-
[Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations
https://bugs.webkit.org/show_bug.cgi?id=68897
Reviewed by Andreas Kling.
No new functionality so no new tests.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::syncCompositingState):
- platform/graphics/texmap/TextureMapperNode.h:
- 09:28 Changeset [96119] by
-
Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()
BUG=96149
Review URL: http://codereview.chromium.org/8055019
- 09:28 Changeset [96118] by
-
[Texmap][Qt] Refactor texture-upload to allow direct chunk update
https://bugs.webkit.org/show_bug.cgi?id=68808
Add a function to BitmapTexture for direct pixel updates.
Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
to RGBA swizzling is done inside that function, there's no need for the
RGBA32PremultipliedBuffer class to contain such function. Also,
RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
an old mistake.
Reviewed by Andreas Kling.
No new tests. Existing tests in LayoutTests/compositing test this.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/opengl/TextureMapperGL.h:
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
- platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
- platform/graphics/qt/TextureMapperQt.h:
- platform/graphics/texmap/TextureMapper.h:
- 09:21 Changeset [96117] by
-
Merge 95926 - <rdar://problem/10156263> ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree
BUG=97952
Review URL: http://codereview.chromium.org/8052011
- 09:12 Changeset [96116] by
-
[Qt][WK2] Buildfix after r96108.
Rubber-stamped by Andreas Kling.
Source/WebKit/qt:
- tests/tests.pri:
Tools:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- 08:52 Changeset [96115] by
-
watchlist: Change watchlistparser.py to be class based.
https://bugs.webkit.org/show_bug.cgi?id=68869
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
- 08:50 Changeset [96114] by
-
Unreviewed followupfix for r96110.
This is a small adjustment of the heap size delta calculation.
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
- 08:37 WebKitGTK/Releasing edited by
- Added link to make patch (diff)
- 08:36 Changeset [96113] by
-
[Qt] Fix build of declarative plugin against Qt5
Reviewed by Andreas Kling.
- declarative/declarative.pro:
- 08:35 Changeset [96112] by
-
watchlist: Break out the diff boilerplate to allow for re-use.
https://bugs.webkit.org/show_bug.cgi?id=68871
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
Break out the diff into a new file.
- Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
- 08:29 Changeset [96111] by
-
[Qt] Fix build of WebKit2 unit-tests after r96108
Reviewed by Andreas Kling.
- UIProcess/API/qt/tests/tests.pri:
- 08:26 Changeset [96110] by
-
Web Inspector: UI performance: introduce heap size tracking stats.
https://bugs.webkit.org/show_bug.cgi?id=68901
It is interesting how much the heap memory is used by Inspector in order of running the test.
Reviewed by Yury Semikhatsky.
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::showDevTools):
(TestShell::closeDevTools):
LayoutTests:
- inspector/performance/resources/network-append-30-requests.html:
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
- 08:17 Changeset [96109] by
-
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=68852
Rebaseline GPU tests for Mac, Win.
Reviewed by Shinichiro Hamaji.
- platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
- platform/chromium/test_expectations.txt:
- 08:11 Changeset [96108] by
-
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.
https://bugs.webkit.org/show_bug.cgi?id=68687
Reviewed by Andreas Kling.
- 07:49 Changeset [96107] by
-
Clipped high quality blur in skia has been fixed. Rebaseline layout tests.
https://bugs.webkit.org/show_bug.cgi?id=68577
Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
- platform/chromium-linux-x86/fast/box-shadow: Removed.
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium/test_expectations.txt:
- 07:13 Changeset [96106] by
-
Source/WebCore: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved.
Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613
Reviewed by Yury Semikhatsky.
- dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
- inspector/Inspector.draft-01.json:
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMAttrImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMNode.prototype._setAttribute):
(WebInspector.DOMNode.prototype._removeAttribute):
(WebInspector.DOMAgent.prototype._attributeModified):
(WebInspector.DOMAgent.prototype._attributeRemoved):
(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMDispatcher.prototype.attributeModified):
(WebInspector.DOMDispatcher.prototype.attributeRemoved):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype):
- inspector/validate-protocol-compatibility:
LayoutTests: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613
Reviewed by Yury Semikhatsky.
- inspector/elements/mutate-unknown-node.html-disabled:
- inspector/elements/set-attribute.html:
- 07:09 Changeset [96105] by
-
[Qt][WK2] Add support for hover API in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68369
Reviewed by Andreas Kling.
Source/WebKit2:
Based on the patch from Igor Oliveira in the same bug.
Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
QString corresponding to the link title. I left textContent out because was
unsure of its use case.
In QDesktopWebView we store the last URL and title emitted to make sure we send
the signal only if either value changes. Tests were added to the QML element to
check: if values are correctly emitted and if we don't emit more signals than
necessary.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didMouseMoveOverElement):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
- UIProcess/API/qt/tests/qmltests/common/test2.html:
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/qt/ClientImpl.cpp:
(qt_wk_mouseDidMoveOverElement):
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
- UIProcess/qt/TouchViewInterface.h:
(WebKit::TouchViewInterface::didMouseMoveOverElement):
- UIProcess/qt/ViewInterface.h:
Tools:
Change the statusbar to show the link URL when hovering links in
MiniBrowser using QDesktopWebView.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onLinkHovered):
- MiniBrowser/qt/BrowserWindow.h:
- 06:23 Changeset [96104] by
-
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
- DEPS:
- 06:12 Changeset [96103] by
-
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 06:00 Changeset [96102] by
-
Unreviewed, rolling out r96070 and r96075.
http://trac.webkit.org/changeset/96070
http://trac.webkit.org/changeset/96075
https://bugs.webkit.org/show_bug.cgi?id=68893
WK2 tests started crashing after r96070 for SL and Qt
(Requested by torarne on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner):
- platform/ScrollableArea.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::imageChanged):
LayoutTests:
- compositing/iframes/repaint-after-losing-scrollbars-expected.png:
- platform/qt/Skipped:
- 05:58 Changeset [96101] by
-
[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
https://bugs.webkit.org/show_bug.cgi?id=68889
Reviewed by Andreas Kling.
Signal parameters needs to be explicitly named in QML to be accessible.
This patch fix this problem.
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qtouchwebpage.h:
- 05:39 Changeset [96100] by
-
[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
https://bugs.webkit.org/show_bug.cgi?id=67732
Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.
Reviewed by Pavel Feldman.
- src/js/Tests.js:
(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
(.TestSuite.prototype.testConsoleOnNavigateBack):
- 05:34 Changeset [96099] by
-
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885
Unreviewed typo fix.
- platform/chromium/test_expectations.txt:
- 05:21 Changeset [96098] by
-
Web Inspector: JS exception upon clicking on "Word Wrap" checkbox in Settings screen
https://bugs.webkit.org/show_bug.cgi?id=68888
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
- 05:06 Changeset [96097] by
-
Web Inspector: migrate RawSourceCode clients to SourceMapping class.
https://bugs.webkit.org/show_bug.cgi?id=68524
Source/WebCore:
Clients should use uiSourceCode(), rawLocationToUILocation(), uiLocationToRawLocation() methods of SourceMapping class.
Initially, RawSourceCode may not have associated SourceMapping, so it is natural to extract this methods and associated state to a separate class.
Reviewed by Yury Semikhatsky.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get sourceMapping):
LayoutTests:
Reviewed by Yury Semikhatsky.
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/raw-source-code.html:
- 04:20 Changeset [96096] by
-
wrap attribute of textarea element cannot be accessed by JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=68592
Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.
Source/WebCore:
Added JS interface for wrap attribute to HTMLTextAreaElement.idl.
Test: fast/forms/textarea-wrap-attribute.html
- html/HTMLTextAreaElement.idl:
LayoutTests:
Added test cases to check accessibility to wrap attribute by JS.
- fast/forms/textarea-wrap-attribute-expected.txt: Added.
- fast/forms/textarea-wrap-attribute.html: Added.
- 03:43 Changeset [96095] by
-
Bump the release number to 1.6.1 and add the NEWS information
- 03:33 Changeset [96094] by
- 03:28 Changeset [96093] by
-
[GTK] Add compatibility methods for DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68884
Reviewed by Philippe Normand.
Add compatibility methods for our DOM bindings.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_blob_slice): alias to the new method name.
(webkit_dom_html_form_element_dispatch_form_change): this was
removed from WebCore, so just print a warning about it.
(webkit_dom_html_form_element_dispatch_form_input): ditto.
- bindings/gobject/WebKitDOMCustom.h:
- 03:22 Changeset [96092] by
-
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
- DEPS:
- 03:15 Changeset [96091] by
-
[Chromium] Layout Test fast compositing/geometry/limit-layer-bounds-transformed-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68886
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 03:06 Changeset [96090] by
-
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 02:56 Changeset [96089] by
-
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68852
Unreviewed test_expectations.txt update. We may need GPU-CG, too.
- platform/chromium/test_expectations.txt:
- 02:51 Changeset [96088] by
-
[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 02:35 Changeset [96087] by
-
[GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Initialize $libwebkitgtkincludedir to
$(prefix)/include/webkitgtk-<api-version>
Source/JavaScriptCore:
Install header files under $libwebkitgtkincludedir/JavaScriptCore.
- GNUmakefile.am: Use $libwebkitgtkincludedir.
- javascriptcoregtk.pc.in: Use webkitgtk-<api-version> as include dir.
Source/WebKit/gtk:
Install header files under $libwebkitgtkincludedir/webkit.
- GNUmakefile.am: Use $libwebkitgtkincludedir.
- webkit.pc.in: Use webkitgtk-<api-version> as include dir.
- 02:31 Changeset [96086] by
-
[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=68881
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 02:24 Changeset [96085] by
-
Unreviewed, GTK gardening
- platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing
in 32-Bits Release.
- platform/gtk/test_expectations.txt: Mark
media/video-timeupdate-reverse-play.html as flaky because of bug 67407.
- 02:00 Changeset [96084] by
-
Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic
https://bugs.webkit.org/show_bug.cgi?id=68875
Reviewed by Kent Tamura.
Added InsertedNode class inside ReplaceSelection to encapsulate m_firstNodeInserted and m_lastLeafInserted.
Deployed it in removeRedundantStylesAndKeepStyleSpanInline, doApply, and insertAsListItems of ReplaceSelectionCommand.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::respondToNodeInsertion):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::InsertedNodes::firstNodeInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::lastLeafInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
- editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval): Moved from DeleteSelectionCommand.cpp.
- editing/htmlediting.h:
- 01:56 Changeset [96083] by
-
[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 01:33 Changeset [96082] by
-
Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing.
https://bugs.webkit.org/show_bug.cgi?id=60972
Patch by Arun Patole <bmf834@motorola.com> on 2011-09-27
Reviewed by Philippe Normand.
Source/WebCore:
The paused attribute should be set to true and the media element should emit a 'paused' at the end of playback.
WHATWG revision r6562: http://html5.org/tools/web-apps-tracker?from=6561&to=6562
Test: media/media-element-play-after-eos.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): set m_paused to true and schedule 'pause' event when playback ended.
LayoutTests:
Update media tests as the 'pause' event should be fired
and 'paused' should be set to true at the end of playback.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- media/media-element-play-after-eos-expected.txt: Added.
- media/media-element-play-after-eos.html: Added.
- media/video-loop-expected.txt:
- 01:21 Changeset [96081] by
-
Unreviewed, GTK gardening.
- platform/gtk/Skipped:
Skip outdated canvas/philip/tests/2d.drawImage.outsidesource.html.
- platform/gtk/test_expectations.txt:
media/video-playing-and-pause.html is flaky.
- 01:08 Changeset [96080] by
-
Unreviewed, GTK rebaseline after r95845, r95897 and r95857.
- platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- platform/gtk/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
- platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- 00:55 Changeset [96079] by
-
[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
https://bugs.webkit.org/show_bug.cgi?id=68848
Reviewed by Andreas Kling.
The presence of the FINAL attribute indicates that the property will not be
overridden by a derived class. This can be used for performance optimizations
by QML.
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qwebnavigationcontroller.h:
- 00:34 Changeset [96078] by
-
<input> with autofocus doesn't lose focus when it has a certain onblur listener
https://bugs.webkit.org/show_bug.cgi?id=68513
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/autofocus-focus-only-once.html
These changes make sure that an element is focused only once when autofocus attribute is used.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::shouldAutofocus):
(WebCore::HTMLFormControlElement::attach):
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::hasAutofocused):
(WebCore::HTMLFormControlElement::setAutofocused):
LayoutTests:
These changes make sure that an element is focused only once when autofocus attribute is used.
- fast/forms/autofocus-focus-only-once-expected.txt: Added.
- fast/forms/autofocus-focus-only-once.html: Added.
- 00:05 Changeset [96077] by
-
[Qt] Add missing test expecteds after r95924.
Unreviewed gardening.
- platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
- platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
09/26/11:
- 23:55 Changeset [96076] by
-
dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
https://bugs.webkit.org/show_bug.cgi?id=68865
Reviewed by Kent Tamura.
Converted the test.
- editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
- editing/deleting/delete-to-end-of-paragraph.html:
- platform/chromium-linux/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- 23:43 Changeset [96075] by
-
[Qt] Skip two tests because they are failing after r96070.
Unreviewed gardening.
- platform/qt/Skipped:
- 23:32 Changeset [96074] by
-
garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
- 23:27 Changeset [96073] by
-
Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68345
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Previously, the following test cases fail or crash:
- shouldBe("new PopStateEvent('eventType', { state: object1 }).state", "object1") -> FAIL
- new PopStateEvent('eventType', { state: document }).state -> CRASH in DRT
This is because PopStateEvent.state is implemented not as ScriptValue but as SerializedScriptValue.
However, we cannot simply change the type of PopStateEvent.state to ScriptValue,
since PopStateEvent can be constructed in the context that does not know ScriptValue.
For example, Document.cpp calls PopStateEvent::create() with SerializedScriptValue
popped from HistoryItem, but we cannot deserialize the SerializedScriptValue into
the corresponding ScriptValue here because the deserialization requires ExecState.
In other words, although we want to store PopStateEvent.state by ScriptValue internally,
PopStateEvent still needs to provide an API to construct it with SerializedScriptValue.
With these observations, this patch makes the following changes:
- If PopStateEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When PopStateEvent.state is called, the ScriptValue is returned.
- If PopStateEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point). When PopStateEvent.state is called, the SerializedScriptValue is
deserialized into the corresponding ScriptValue, and the ScriptValue is returned.
Tests: fast/events/constructors/pop-state-event-constructor.html
fast/events/fire-popstate-event.html
- GNUmakefile.list.am: Added JSPopStateEventCustom.cpp.
- UseJSC.cmake: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state): Custom getter for PopStateEvent.state.
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter): Custom getter for PopStateEvent.state.
- dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit): Added initialization code for PopStateEvent.m_state.
(WebCore::PopStateEvent::PopStateEvent): Ditto.
(WebCore::PopStateEvent::create): Ditto.
(WebCore::PopStateEvent::initPopStateEvent): Ditto.
- dom/PopStateEvent.h:
(WebCore::PopStateEvent::serializedState): Getter.
(WebCore::PopStateEvent::state): Getter.
- dom/PopStateEvent.idl: Change the type of 'stateArg' and 'state' to DOMObject. Added [CustomGetter] to 'state'.
LayoutTests:
- fast/events/constructors/pop-state-event-constructor-expected.txt:
- fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.
- 23:26 Changeset [96072] by
-
[Qt][WK2] One more unreviewed buildfix after r96005.
- WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
- 23:15 Changeset [96071] by
-
[Qt][WK2] Unreviewed buildfix after r96005.
- WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- 22:50 Changeset [96070] by
-
Pixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67858
Reviewed by Darin Adler.
When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.
Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
- platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
- rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.
- 22:12 Changeset [96069] by
-
Translucent scrollbars on composited layers render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58515
Source/WebCore:
Reviewed by Sam Weinig.
Scrollbars in composited elements were getting drawn twice,
because r41203 moved the call to paintOverflowControls() out of
RenderLayer::paintLayer(), but forgot to change RenderLayerBacking::paintIntoLayer().
Test: compositing/scrollbar-painting.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
LayoutTests:
Reviewed by Sam Weinig.
Pixel test with translucent scrollbars, to test whether they get
rendered twice.
- compositing/scrollbar-painting-expected.png: Added.
- compositing/scrollbar-painting-expected.txt: Added.
- compositing/scrollbar-painting.html: Added.
- 20:24 Changeset [96068] by
-
REGRESSION (r95912): Conservative marking doesn't filter out pointers to
MarkedBlock metadata
https://bugs.webkit.org/show_bug.cgi?id=68860
Reviewed by Oliver Hunt.
Bencher says no performance change, maybe a 7% speedup on kraken-imaging-darkroom.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::isAtomAligned): Renamed atomMask to atomAlignment mask
because the mask doesn't produce the actual atom number.
(JSC::MarkedBlock::isLiveCell): Testing just for alignment isn't good
enough; we also need to test that a pointer is beyond the metadata section
of a MarkedBlock, to avoid treating random metadata as a JSCell.
- 19:36 Changeset [96067] by
-
[Qt] Fix WK2 build after r96014
https://bugs.webkit.org/show_bug.cgi?id=68856
Reviewed by Gustavo Noronha Silva.
Commit r96014 added inspectorBaseURL for Qt but removed
inspectorPageURL, adding it back.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL):
- 19:18 Changeset [96066] by
-
[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417
Source/WebCore:
Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.
Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.
- platform/graphics/IntRect.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418
Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
- 19:07 Changeset [96065] by
-
Put back all Chromium platform failing expectations for some tests (they
still fail on all platforms on the GPU bots).
- platform/chromium/test_expectations.txt:
- 18:44 Changeset [96064] by
-
[MutationObservers] implement MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=68824
Reviewed by Darin Adler.
Implements MutationRecord as specified in the thread at
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html,
including some minor naming changes from the original proposal.
This is a small part of the MutationObserver API, see
https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug covering
this feature.
No new tests as this isn't yet exposed to the platform.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/MutationRecord.cpp: Added.
(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::MutationRecord):
(WebCore::MutationRecord::~MutationRecord):
- dom/MutationRecord.h: Added.
(WebCore::MutationRecord::target):
(WebCore::MutationRecord::addedNodes):
(WebCore::MutationRecord::removedNodes):
(WebCore::MutationRecord::previousSibling):
(WebCore::MutationRecord::nextSibling):
(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):
(WebCore::MutationRecord::oldValue):
(WebCore::MutationRecord::setOldValue):
- dom/MutationRecord.idl: Added.
- 18:40 Changeset [96063] by
-
Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943
Reviewed by Adam Barth.
- src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/8054006
- 18:39 Changeset [96062] by
-
Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947
Reviewed by Adam Barth.
The changes are tested by compiling and added compile asserts to do some verification as well.
- platform/CrossThreadCopier.cpp:
Added some compile asserts to verify various match and non-matches for CrossThreadCopier.
- platform/CrossThreadCopier.h:
Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/8057001
- 18:36 Changeset [96061] by
-
Implement a CloseEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68793
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/close-event-constructor.html
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKey): Just removed an extra space.
(WebCore::OptionsObject::getKeyValue): Returns an unsigned short value corresponding to the given key.
- bindings/v8/OptionsObject.h:
- bindings/v8/custom/V8EventConstructors.cpp: Added the CloseEvent constructor.
- websockets/CloseEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled close-event-constructor.html, since now V8 has the CloseEvent constructor.
- platform/chromium/test_expectations.txt:
- 18:29 Changeset [96060] by
-
Clean up CachedResource::load(). Collapse its
logic into a single callsite, taking just a
CachedResourceLoader and a ResourceLoaderOptions.
- Its 'incremental' parameter is redundant.
- With 'incremental' removed, the SecurityCheckPolicy is the only parameter difference between the CachedResource::load() variants. Making it a part of ResourceLoaderOptions removes yet another random enum that is passed around individually.
- We currently have to call setResourceLoaderOptions() before load() on a new CachedResource, so we should just take the ResourceLoaderOptions in load().
https://bugs.webkit.org/show_bug.cgi?id=67443
Reviewed by Antti Koivisto.
No new tests, refactor only.
- loader/DocumentThreadableLoader.cpp:
- loader/FrameLoaderTypes.h: Move SecurityCheckPolicy to ResourceLoaderOptions.h.
- loader/MainResourceLoader.cpp:
- loader/NetscapePlugInStreamLoader.cpp:
- loader/ResourceLoadScheduler.cpp:
- loader/ResourceLoadScheduler.h:
- loader/ResourceLoader.cpp: Enforce SecurityCheckPolicy here instead of SubresourceLoader.
- loader/ResourceLoaderOptions.h: Store SecurityCheckPolicy on ResourceLoaderOptions.
- loader/SubresourceLoader.cpp:
- loader/SubresourceLoader.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::defaultCachedResourceOptions): Define the default ResourceLoaderOptions for
CachedResource loads here instead of as a default parameter on requestResource().
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData): Remove m_incremental, since its purpose
is already enforced in the data() implementation of every CachedResource that doesn't want
incremental loads.
- loader/cache/CachedResourceRequest.h:
- 18:27 Changeset [96059] by
-
garden-o-matic should be pretty in Open Sans.
https://bugs.webkit.org/show_bug.cgi?id=68845
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
- 18:13 Changeset [96058] by
-
Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 17:57 Changeset [96057] by
-
editing/selection/select-bidi-run.html fails on Chromium Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=68832
Unreviewed; remove the failing test expectation because it started passing after r96016.
- platform/chromium/test_expectations.txt:
- 17:55 Changeset [96056] by
-
Skip the test added by r95964 on Qt and GTK because it has been failing
on those two platforms. The failure is tracked by the bugs 68854 and 68855.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 17:52 Changeset [96055] by
-
garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
https://bugs.webkit.org/show_bug.cgi?id=68841
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
- 17:43 Changeset [96054] by
-
IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
https://bugs.webkit.org/show_bug.cgi?id=68818
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/factory-basics.html
Adds ability to enumerate IndexedDB databases within an origin.
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- storage/IDBAny.cpp:
(WebCore::IDBAny::domStringList):
(WebCore::IDBAny::set):
- storage/IDBAny.h:
- storage/IDBBackingStore.h:
- storage/IDBCallbacks.h:
- storage/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
- storage/IDBFactory.h:
- storage/IDBFactory.idl:
- storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):
- storage/IDBLevelDBBackingStore.h:
- storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):
- storage/IDBLevelDBCoding.h:
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
- storage/IDBRequest.h:
- storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::getDatabaseNames):
- storage/IDBSQLiteBackingStore.h:
Source/WebKit/chromium:
Adds ability to enumerate IndexedDB databases within an origin.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
- src/IDBFactoryBackendProxy.h:
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
- src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
- src/WebIDBFactoryImpl.h:
LayoutTests:
Adds ability to enumerate IndexedDB databases within an origin.
- storage/indexeddb/factory-basics-expected.txt: Added.
- storage/indexeddb/factory-basics.html: Added.
- 17:40 Changeset [96053] by
-
Remove failing Chromium expectations for tests that now pass.
Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.
- platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 17:36 Changeset [96052] by
-
<animateColor> applied to filtered ellipse does not update
https://bugs.webkit.org/show_bug.cgi?id=68457
<rdar://problem/10154777>
Reviewed by Darin Adler.
Invalidate the filter's cache when style changes take place so that style changes are respected.
Test: svg/filters/animate-fill.svg
- 17:35 Changeset [96051] by
-
[Qt] [WK2] Fix build after r95982
https://bugs.webkit.org/show_bug.cgi?id=68842
Reviewed by Anders Carlsson.
The patch in r95982 removed the paint() function, because it was doing
nothing (in both implementations). This patch remove the call we had
for it to fix the build.
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::paintContent):
- 17:24 Changeset [96050] by
-
Revert 96034 - Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8046025
TBR=cdn@chromium.org
Review URL: http://codereview.chromium.org/8041053
- 17:23 Changeset [96049] by
-
Removed an unnecessary include in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=68834
Reviewed by Darin Fisher.
- src/WebFrameImpl.cpp:
- 17:23 Changeset [96048] by
-
Remove failing expectations for some ruby tests, since they were
renamed to -disabled with r94327 and thus aren't being run at all.
Add compositing/video-page-visibility.html Windows GPU baselines.
- platform/chromium-gpu-win/compositing/video-page-visibility-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 17:06 Changeset [96047] by
-
Unreviewed Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 17:03 Changeset [96046] by
-
watchlist: Add parsing for definition section.
https://bugs.webkit.org/show_bug.cgi?id=68850
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlist.py:
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
- 16:53 Changeset [96045] by
-
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727
Reviewed by Geoffrey Garen.
JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
- runtime/JSObject.h:
- runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
- 16:45 Changeset [96044] by
-
Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()
BUG=96149
Review URL: http://codereview.chromium.org/8044037
- 16:43 Changeset [96043] by
-
Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2)
BUG=96149
Review URL: http://codereview.chromium.org/8038042
- 16:42 Changeset [96042] by
-
Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode
BUG=96149
Review URL: http://codereview.chromium.org/8037053
- 16:40 Changeset [96041] by
-
Versioning.
- 16:39 Changeset [96040] by
-
New tag.
- 16:39 Changeset [96039] by
-
Merge 95093 - 2011-09-13 Pavel Feldman <pfeldman@google.com>
BUG=96170
Review URL: http://codereview.chromium.org/8028048
- 16:38 Changeset [96038] by
-
Merge r95863.
- 16:36 Changeset [96037] by
-
Update the release number for 1.6.0 and add the NEWS information
- 16:36 Changeset [96036] by
-
Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2)
BUG=96150
Review URL: http://codereview.chromium.org/8044036
- 16:35 Changeset [96035] by
-
Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode
BUG=96150
Review URL: http://codereview.chromium.org/8044035
- 16:31 Changeset [96034] by
-
Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8046025
- 16:29 Changeset [96033] by
-
Remove failing Chromium test expectations for tests that now pass
(mainly due to r95751, which implemented Function.prototype.bind for
JSC, resulting in baseline updates that now work for V8 too).
- platform/chromium/test_expectations.txt:
- 16:26 Changeset [96032] by
-
Merge 95204 - 2011-09-15 James Simonsen <simonjam@chromium.org>
BUG=95761
Review URL: http://codereview.chromium.org/8037052
- 16:23 Changeset [96031] by
-
Merge 95488 - Named property confusion with proto
BUG=95671
Review URL: http://codereview.chromium.org/8036045
- 16:21 Changeset [96030] by
-
Set but unused variables cleanup in v8 bindings (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68079
Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/websocket/tests/hybi/send-object-tostring-check.html
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
LayoutTests:
- http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Added.
- http/tests/websocket/tests/hybi/send-object-tostring-check.html: Added.
- 16:20 Changeset [96029] by
-
Merge 94512 - Unreviewed. Compile fix for r94511.
BUG=95360
Review URL: http://codereview.chromium.org/8048007
- 16:13 Changeset [96028] by
-
Merge 94511 - Crash in Range::processAncestorsAndTheirSiblings.
BUG=95360
Review URL: http://codereview.chromium.org/8041051
- 16:10 Changeset [96027] by
-
Merge 95301 - cachedFont not getting updated for inline SVG text.
BUG=95072
Review URL: http://codereview.chromium.org/8041050
- 16:07 Changeset [96026] by
-
switch the initial value of flex-order to 0
https://bugs.webkit.org/show_bug.cgi?id=68820
Source/WebCore:
The spec changed from having an initial value of 1 to 0.
Reviewed by Ojan Vafai.
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialFlexOrder):
LayoutTests:
Reviewed by Ojan Vafai.
- css3/flexbox/flex-order.html:
- 16:07 Changeset [96025] by
-
Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
BUG=93788
Review URL: http://codereview.chromium.org/8041049
- 16:04 Changeset [96024] by
-
Merge 94991 - <rdar://problem/10054615> Floats in ruby text intrude into the base
BUG=94810
Review URL: http://codereview.chromium.org/8044031
- 16:02 Changeset [96023] by
-
Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397
Reviewed by Simon Fraser.
Source/JavaScriptCore:
Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
- wtf/Platform.h:
WebKitLibraries:
Enable REQUEST_ANIMATION_FRAME for Windows
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows
- platform/win/Skipped:
- 16:02 Changeset [96022] by
-
[chromium] Work around null render surface crash in updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=68838
Reviewed by James Robinson.
Landed directly on the Chromium 874 branch.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateCompositorResources):
- 16:00 Changeset [96021] by
-
Fix WebKitTestRunner builds for Cairo, Windows and Qt.
- WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- 15:58 Changeset [96020] by
-
OfflineAudioDestinationNode must wait for thread completion in uninitialize()
https://bugs.webkit.org/show_bug.cgi?id=68725
Reviewed by Kenneth Russell.
No new tests. This fixes internal implementation details.
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::uninitialize):
- 15:57 Changeset [96019] by
-
Revert a change added by mistake to the last merge
- 15:53 Changeset [96018] by
-
Merge 95924 - Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
BUG=91921
Review URL: http://codereview.chromium.org/8041046
- 15:51 Changeset [96017] by
-
Merge 95462 - Source/WebCore: Issues with merging ruby bases.
BUG=94809
Review URL: http://codereview.chromium.org/8028045
- 15:50 Changeset [96016] by
-
editing/selection/select-bidi-run.html timeouts on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=68831
Reviewed by Enrica Casucci.
Click at (0,0) to reset click count instead of a long leapForward.
- editing/selection/select-bidi-run.html:
- 15:49 Changeset [96015] by
- 15:46 Changeset [96014] by
-
REGRESSION (r95747): Activating the web inspector causes the web process to be killed
https://bugs.webkit.org/show_bug.cgi?id=68762
Reviewed by Anders Carlsson.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
Tell Web process that loading resources from WebCore resources directory is OK.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
- UIProcess/WebProcessProxy.h:
Renamed willLoadHTMLStringWithBaseURL to more generic assumeReadAccessToBaseURL.
- UIProcess/WebInspectorProxy.h:
- UIProcess/efl/WebInspectorEfl.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
Report what base directory Inspector has access to.
- 15:45 Changeset [96013] by
-
[Chromium] Update the test expectaion file for media related tests.
It includes updating bug numbers, removing
media/video-controls-visible-audio-only.html, and unskipping
media/media-document-audio-repaint.html.
https://bugs.webkit.org/show_bug.cgi?id=68254
Reviewed by David Levin.
- platform/chromium/test_expectations.txt:
- 15:45 Changeset [96012] by
-
Merge 95054 - Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.
BUG=92226
Review URL: http://codereview.chromium.org/8048004
- 15:44 Changeset [96011] by
-
Merge 95924 - Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
BUG=91921
Review URL: http://codereview.chromium.org/8044030
- 15:34 Changeset [96010] by
-
Source/WebKit/chromium: Fix copy and paste error in r96002.
- tests/InnerGestureRecognizerTest.cpp:
(TEST_F):
LayoutTests: Remove test that no longer crashes (fixed by r95985).
- platform/chromium/test_expectations.txt:
- 15:28 Changeset [96009] by
-
[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68837
Reviewed by Martin Robinson.
- bindings/scripts/CodeGeneratorGObject.pm: add getters (but not
setters) for 'Replaceable' attributes. Punt for the future
actually making them settable, since it seems non trivial.
- 15:27 Changeset [96008] by
-
Leopard build fix.
- testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):
- 15:22 Changeset [96007] by
-
IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.
Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
- storage/IDBLevelDBCoding.cpp:
- 15:21 Changeset [96006] by
-
[skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
https://bugs.webkit.org/show_bug.cgi?id=68807
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 15:19 Changeset [96005] by
-
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Tools:
Reviewed by Sam Weinig.
Convert DumpRenderTree to use use the repaint rects
exposed via WebKit API when generating the repaint test
overlay.
Fix WebKitTestRunner to work with repaint tests, again
using the repaint rects exposed from WK2.
In both cases, layoutTestController.display() now just
forces a display of the web view, and turns on repaint
rect tracking on the main FrameView.
Later, when pixel results are requested, the alpha overlay
that shows the repaint rects is generated using the list
of rects supplied by WebCore.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(displayWebView):
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(paintRepaintRectOverlay):
(createBitmapContextFromWebView):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::setRepaintRects):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
(WTR::InjectedBundlePage::dump):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::display):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
LayoutTests:
Reviewed by Sam Weinig.
Update Mac results to use the new repaint rects. Differences from old results:
- There are no longer invalidates from scrolling.
- We no longer see the effects of AppKit rect coalescing.
- Composting tests show the overlay now, but repaints in compositing layers do not show.
Bad results in a couple of tests are covered by bugs 68830 and 68829.
- platform/mac/fast/repaint/4774354-expected.png:
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
- platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
- platform/mac/fast/repaint/border-radius-repaint-expected.png:
- platform/mac/fast/repaint/clipped-relative-expected.png:
- platform/mac/fast/repaint/containing-block-position-change-expected.png:
- platform/mac/fast/repaint/control-clip-expected.png:
- platform/mac/fast/repaint/delete-into-nested-block-expected.png:
- platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
- platform/mac/fast/repaint/fixed-scroll-simple-expected.png:
- platform/mac/fast/repaint/flexible-box-overflow-expected.png:
- platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
- platform/mac/fast/repaint/float-move-during-layout-expected.png:
- platform/mac/fast/repaint/float-overflow-expected.png:
- platform/mac/fast/repaint/float-overflow-right-expected.png:
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.png:
- platform/mac/fast/repaint/inline-block-overflow-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/mac/fast/repaint/layer-child-outline-expected.png:
- platform/mac/fast/repaint/layer-outline-expected.png:
- platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/mac/fast/repaint/line-overflow-expected.png:
- platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png:
- platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png:
- platform/mac/fast/repaint/outline-child-repaint-expected.png:
- platform/mac/fast/repaint/outline-shrinking-expected.png:
- platform/mac/fast/repaint/overflow-delete-line-expected.png:
- platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
- platform/mac/fast/repaint/repaint-during-scroll-expected.png:
- platform/mac/fast/repaint/scale-page-shrink-expected.png:
- platform/mac/fast/repaint/search-field-cancel-expected.png:
- platform/mac/fast/repaint/selection-after-remove-expected.png:
- platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/mac/fast/repaint/static-to-positioned-expected.png:
- platform/mac/fast/repaint/table-cell-move-expected.png:
- platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
- platform/mac/fast/repaint/text-shadow-expected.png:
- platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
- 15:19 Changeset [96004] by
- 15:16 Changeset [96003] by
- 15:12 Changeset [96002] by
-
Disable Chromium gesture recognizer tests that started to fail on the
Mac bots recently.
- tests/InnerGestureRecognizerTest.cpp:
(TEST_F):
- 15:10 Changeset [96001] by
-
[Chromium] Remove DFGAliasTracker.h references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=68787
Reviewed by Geoffrey Garen.
DFG/DFGAliasTracker.h was removed in r95389. Cleanup (remove) references
to that file from the gyp project files.
- JavaScriptCore.gypi:
- 15:07 Changeset [96000] by
-
Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366
Source/WebCore:
The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.
Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
- platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::RGBAtoRGB):
LayoutTests:
Update the premultiplyalpha-test from the WebGL conformance tests.
Also use the correct expected result for toDataURL.jpeg.alpha.html.
Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.
- fast/canvas/webgl/premultiplyalpha-test-expected.txt:
- fast/canvas/webgl/premultiplyalpha-test.html:
- platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
- 15:00 Changeset [95999] by
-
Source/WebKit2: Added WKHitTestResult API's.
WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.am:
- UIProcess/API/C/WKHitTestResult.cpp: Added.
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):
- UIProcess/API/C/WKHitTestResult.h: Added.
- UIProcess/API/C/WebKit2.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2API.pri:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Tools: Get hover'ed element URL from HitTest.
mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.
- MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):
- 14:47 Changeset [95998] by
-
[CMake] Remove FindFreetype.cmake
https://bugs.webkit.org/show_bug.cgi?id=68778
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.
CMake has provided its own FindFreetype.cmake forever, so there is no
need to have another implementation in WebKit.
.:
- Source/cmake/FindCairo.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
- Source/cmake/FindFreetype.cmake: Removed.
- Source/cmake/FindPango.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
- Source/cmake/OptionsEfl.cmake: Remove minimum required version
check, it has never been checked and Freetype 2.1.10 from 2005 is
already > 9.0.
Source/WebCore:
No new tests, just a buildsystem change.
- CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
Freetype_{LIBRARIES,INCLUDE_DIRS}.
Source/WebKit/efl:
- CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
Freetype_{LIBRARIES,INCLUDE_DIRS}.
- 14:44 Changeset [95997] by
-
Fix full-page rubber band overhang appearing when gesturing during a slow page load.
https://bugs.webkit.org/show_bug.cgi?id=68568
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=97243
(This also happens on Safari.)
The problem was that ScrollView::overhangAmount() was returning a full-page overhang due to contentsSize() being 0 briefly during a page load, which was then getting used by ScrollAnimatorChromiumMac.mm to update the overhang on a gesture event. This change makes the relevant logic not return an overhang if the contentsSize() is empty.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
No new tests, since this is highly timing-related.
- platform/ScrollView.cpp:
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):
- 14:44 Changeset [95996] by
-
2011-09-26 Alejandro G. Castro <alex@igalia.com>
[GTK] pot file is not properly remove during distcheck
https://bugs.webkit.org/show_bug.cgi?id=68797
Defined DOMAIN variable before DISTCLEANFILES because we are using
it there to identify the .pot file.
Reviewed by Martin Robinson.
- GNUmakefile.am:
2011-09-26 Alejandro G. Castro <alex@igalia.com>
[GTK] pot file is not properly remove during distcheck
https://bugs.webkit.org/show_bug.cgi?id=68797
DOMAIN is already defined, we just add the value to the variable.
Reviewed by Martin Robinson.
- GNUmakefile.am:
- 14:39 Changeset [95995] by
-
Add skeleton parsing for a WatchList.
https://bugs.webkit.org/show_bug.cgi?id=68823
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
Parses the top level watch list sections -- none are defined yet -- and
throws an exception if an invalid one is listed.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
Verify the exception for an invalid section in a watch list.
- Scripts/webkitpy/common/watchlist/watchlist.py: Added.
- 14:35 Changeset [95994] by
-
Merge 94905 - Source/WebCore: Crash due to bad data in SVGDocumentExtensions m_pendingResources
BUG=91092
Review URL: http://codereview.chromium.org/8038032
- 14:32 Changeset [95993] by
-
Merge 94864 - Source/WebCore: Assert being hit in AccessibilityRenderObject::addChildren()
BUG=84885
Review URL: http://codereview.chromium.org/8036039
- 14:24 Changeset [95992] by
-
Merge 94716 - Changes to aria-hidden don't change VO navigation
BUG=84160
Review URL: http://codereview.chromium.org/8037036
- 14:17 Changeset [95991] by
-
Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized readBUG=60653
Review URL: http://codereview.chromium.org/8041039
- 14:06 Changeset [95990] by
-
Add a failing expectation to the test added by r95964 on Chromium Linux and Chromium Windows.
The failure is tracked by the bug 68832.
- platform/chromium/test_expectations.txt:
- 13:57 Changeset [95989] by
-
[Qt][WK2]Unreviewed speculative buildfix after r95968.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- 13:31 Changeset [95988] by
-
[chromium] Revise zoom animator backend to use full transform instead of just scale.
https://bugs.webkit.org/show_bug.cgi?id=68535
Reviewed by Kenneth Russell.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):
(WebCore::Settings::setZoomAnimatorPosition):
(WebCore::Settings::zoomAnimatorPosX):
(WebCore::Settings::zoomAnimatorPosY):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setZoomAnimatorTransform):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
LayoutTests:
- platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
- platform/chromium/compositing/zoom-animator-scale-test.html:
- 13:28 Changeset [95987] by
-
Layout Test fast/animation/request-animation-frame-timestamps-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68821
Switch test to use finishJSTest(), which handles js-test-post.js loading
after the test is complete better.
- fast/animation/request-animation-frame-timestamps-advance.html:
- fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
(window.webkitRequestAnimationFrame):
- platform/chromium/test_expectations.txt:
- 13:08 Changeset [95986] by
-
[CMake] Detect the operating system in a more generic way.
https://bugs.webkit.org/show_bug.cgi?id=67482
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.
So far the buildsystem only considered Windows, Linux and Mac OS X as
valid operating systems, but any Unix (or at least the BSDs) should also
work fine.
By using the OS values CMake itself defines we can check for Unix
systems in a more generic fashion.
- Source/CMakeLists.txt:
- 13:08 Changeset [95985] by
-
REGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68819
Reviewed by Dave Hyatt.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scheduleRelayout): Revert to using view() instead of the RenderView
parameter of isRooted, since only the former returns 0 when the document is detached.
- 13:06 Changeset [95984] by
-
Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible.
https://bugs.webkit.org/show_bug.cgi?id=67399
Reviewed by Pavel Feldman.
- inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
- inspector/front-end/inspector.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.linkifyStringAsFragment):
- 12:58 Changeset [95983] by
-
[EFL] Add virtual method to notify user when wrapping focus
https://bugs.webkit.org/show_bug.cgi?id=68699
Reviewed by Antonio Gomes.
Add a virtual method to ewk_view, so the Chrome gets notified if we
finished focusing all the items and would start over. This way the
browser can decide to handle the subsequent focus changes among its
widgets.
- WebCoreSupport/ChromeClientEfl.cpp: call ewk_view's virtual method to
give it a chance to grab focus
(WebCore::ChromeClientEfl::canTakeFocus):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: add virtual method
(ewk_view_focus_can_cycle):
- ewk/ewk_view.h: add focus direction enum and virtual method
- 12:58 Changeset [95982] by
-
Remove an old DrawingAreaProxy::paint member function
https://bugs.webkit.org/show_bug.cgi?id=68825
Reviewed by Dan Bernstein.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/TiledDrawingAreaProxy.cpp:
- UIProcess/TiledDrawingAreaProxy.h:
- 12:57 Changeset [95981] by
-
Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.
Previous expected result was Chromium-specific because console line
numbers were different in JSC.
Additionally, the test doesn't behave as expected for non-Chromium
ports (window size remains at 800x600). Update the baselines to use
that for now, so that we're still aware of regressions/progressions.
- fast/dom/Window/window-resize-contents-expected.txt:
- platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.
- 12:54 Changeset [95980] by
-
Merge 95074 - Crash in RenderScrollbarPart::imageChanged.
BUG=96444
Review URL: http://codereview.chromium.org/8028035
- 12:52 Changeset [95979] by
-
Merge 95306
BUG=96665
Review URL: http://codereview.chromium.org/8038026
- 12:51 Changeset [95978] by
-
White flash when entering full-screen using element.webkitRequestFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=68481
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; covered by existing full screen tests.
During an animation, renderers may try to paint into the FullScreenRenderer's
GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's
background will cause these paints to fail. Remove this optimization in
containsPaintedContent, and taking non-composited elements into full screen will
animate correctly.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
Source/WebKit2:
Do not re-enable screen updates after exiting compositing mode until a repaint has completed.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
(continueExitCompositingModeAfterRepaintCallback):
(-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):
- 12:49 Changeset [95977] by
-
Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8037034
- 12:48 Changeset [95976] by
-
Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8028034
- 12:46 Changeset [95975] by
-
Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8041034
- 12:43 Changeset [95974] by
-
Unreviewed, rolling out r95960.
http://trac.webkit.org/changeset/95960
https://bugs.webkit.org/show_bug.cgi?id=58608
Significantly changes table border rendering
Source/WebCore:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
LayoutTests:
- fast/borders/border-groove-expected.png: Removed.
- fast/borders/border-groove-expected.txt: Removed.
- fast/borders/border-groove.html: Removed.
- fast/borders/border-inset-expected.png: Removed.
- fast/borders/border-inset-expected.txt: Removed.
- fast/borders/border-inset.html: Removed.
- fast/borders/border-outset-expected.png: Removed.
- fast/borders/border-outset-expected.txt: Removed.
- fast/borders/border-outset.html: Removed.
- fast/borders/border-ridge-expected.png: Removed.
- fast/borders/border-ridge-expected.txt: Removed.
- fast/borders/border-ridge.html: Removed.
- 12:43 Changeset [95973] by
-
Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8043034
- 12:41 Changeset [95972] by
-
Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8043033
- 12:38 Changeset [95971] by
-
Merge 95959 - Delete retired custom font data only on document
destruction, and not on recalc style.
BUG=97994
Review URL: http://codereview.chromium.org/8044027
- 12:37 Changeset [95970] by
-
Merge 95959 - Delete retired custom font data only on document
destruction, and not on recalc style.
BUG=97994
Review URL: http://codereview.chromium.org/8036034
- 12:09 Changeset [95969] by
-
Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 12:01 Changeset [95968] by
-
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Reviewed by Sam Weinig.
Expose WKBundlePage methods to turn on repaint rect tracking
in WebKit2, for WebKitTestRunner.
As part of the change, expose utility methods on WebPage
to get the main Frame and FrameView, which required renaming
the exisiting method that returns a WebFrame. Fix callers
of that method to handle null when necessary.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetMainFrame):
(WKBundlePageSetTracksRepaints):
(WKBundlePageIsTrackingRepaints):
(WKBundlePageResetTrackedRepaints):
(WKBundlePageCopyTrackedRepaintRects):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::findLargestFrameInFrameSet):
(WebKit::WebChromeClient::closeWindowSoon):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::frameLoadCompleted):
(WebKit::WebFrameLoaderClient::restoreViewState):
(WebKit::WebFrameLoaderClient::provisionalLoadStarted):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::createPlugin):
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::documentFragmentFromAttributedString):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::isMainFrame):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTracksRepaints):
(WebKit::WebPage::isTrackingRepaints):
(WebKit::WebPage::resetTrackedRepaints):
(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::clearMainFrameName):
(WebKit::WebPage::layoutIfNeeded):
(WebKit::WebPage::mainFrameHasCustomRepresentation):
(WebKit::WebPage::mainFrame):
(WebKit::WebPage::mainFrameView):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::mainWebFrame):
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):
- 11:57 Changeset [95967] by
-
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Reviewed by Sam Weinig.
Source/WebCore:
Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.
The repaint rects are in WebView coordinates, so we have to
unapply the scroll offset.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::setTracksRepaints):
- page/FrameView.h:
(WebCore::FrameView::isTrackingRepaints):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::trackedRepaintRects):
Source/WebKit/mac:
Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.
- WebView/WebView.mm:
(-[WebView setTracksRepaints:]):
(-[WebView isTrackingRepaints]):
(-[WebView resetTrackedRepaints]):
(-[WebView trackedRepaintRects]):
- WebView/WebViewPrivate.h:
- 11:53 Changeset [95966] by
-
Optimize matching of common pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=68633
Reviewed by Dave Hyatt, Darin Adler, Dimitri Glazkov.
:link, :visited and :focus are quite common. They often used as univeral selectors (including in our
default stylesheet) so we try to match them for all elements in the document. They take always the
slow matching path. In addition we match link styles twice due to visited link pseudo style generation
so the overhead is doubled. As a result substantial portion of our style matching time is spent
dealing with these pseudo classes.
This patch adds new lists to RuleSet for common pseudo class rules. The rules on the lists are only checked
if the element has approprate type and stat. ases where the rightmost pseudo class can then be rejected immediately.
We can also enable the fast path checking for the rest of the selector in many cases.
This seems to be >30% progression in selector matching performance with typical style sheets. It saves ~0.9s
when loading the full HTML5 spec.
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::visitedPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
Add a new lists, some stylistic renamings.
(WebCore::CSSStyleSelector::matchRules):
New link and focus checks.
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
Inline the rightmost selector tag checking, skip if unnecessary.
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
Common pseudo classes now match based on early filtering (though it is not a hash in this case).
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addRule):
Sort pseudo classes to new lists.
(WebCore::RuleSet::collectFeatures):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
Adopt to expanded fast path (this is used by querySelectorAll).
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
Rightmost selector is now checked differently than the rest. RuleSet based selection in CSSStyleSelector
is equivalent to fastCheckRightmostSelector().
(WebCore::isFastCheckableRelation):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::isFrameFocused):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::isCommonPseudoClassSelector):
(WebCore::SelectorChecker::linkMatchesVisitedPseudoClass):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
(WebCore::SelectorChecker::tagMatches):
Refactor a bunch of shared checks into functions.
- 11:52 Changeset [95965] by
-
[Qt]REGRESSION(r95865): It made 4 tests crash
https://bugs.webkit.org/show_bug.cgi?id=68780
Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-09-26
Reviewed by Oliver Hunt.
emitJumpSlowCaseIfNotJSCell(...) cannot be moved
away since the next load depends on it.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
- 11:30 Changeset [95964] by
-
REGRESSION(r74971): Selection doesn't work correctly in BiDi Text
https://bugs.webkit.org/show_bug.cgi?id=57340
Reviewed by Eric Seidel.
Source/WebCore:
This patch adds the end point adjustment mechanism at bidi boundaries similar to the one NSTextView implements.
To understand the problem, suppose we have strong RTL letters "ABC" in a LTR block (visually laid out as CBA).
Per NSTextView convention, logical offsets between each letter is placed as (0)C(2)B(1)A(3). In other words,
placing the caret visually on the left of CBA yields the position inside the text node of "ABC" at offset 0.
Likewise, placing it between C and B yields ("ABC", 2), and placing it on the right of CBA yields ("ABC", 3).
Now suppose a user attempts to select the letter A by a mouse drag from the right of CBA to a point between
B and A. First, the initial mouse down places the selection's base at ("ABC", 3). Then as the mouse pointer
moves to a point on the left of A, the selection's extent is set at ("ABC", 1), selecting "BC".
To mitigate this issue, NSTextView adjusts selection base and extent under certain conditions. In the above
example, NSTextView detects user's intent and changes the selection's base to ("ABC", 0) temporarily.
This patch implements a similar trick on WebKit. We adjust the base or the extent when they're at the left
end or at the right end of a bidi run and the other end is inside of the run. In the above example, the
base position on the right of A is the right end of a bidi run and the extent position between B and A is
inside the same run (CBA), so we would adjust the base to be ("ABC", 0) as NSTextView does.
Take another example abcABC. Note offsets are assigned as (0)a(1)b(2)c(3)C(5)B(4)A(6) When the user starts
a mouse drag from the right of A to a point between B and A, we adjust the selection base to be ("abcABC", 3)
because the base is at the right end of a bidi run and the extent is in the same run. We keep the adjustment
when the mouse pointer moves to a point between C and B. However, when the mouser pointer reaches a point
between letters b and c, the selection extent is placed at ("abcABC", 2). Because the extent is outside of
the bidi run started from the selection base, we restore the original base at this point. Had we not done this,
we'll end up selecting just "c".
While this algorithm is implemented in FrameSelection::setNonDirectionalSelectionIfNeeded, this patch adds
various member functions to RenderedPosition to facilitate abstraction around inline boxes and bidi runs.
Test: editing/selection/select-bidi-run.html
- editing/FrameSelection.cpp:
(WebCore::adjustEndpointsAtBidiBoundary): Added. Implements the endpoints adjustment algorithm.
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded): Calls adjustEndpointsAtBidiBoundary, and
restores the original base as needed.
- editing/FrameSelection.h:
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::prevLeafChild): Added to cache prevLeafChild of the current inline box.
(WebCore::RenderedPosition::nextLeafChild): Ditto for nextLeafChild.
(WebCore::RenderedPosition::isEquivalent): Compares two RenderedPositions considering neighboring inline boxes
so that the rightmost position in a box and the leftmost position in the following box is considered equal.
(WebCore::RenderedPosition::bidiLevelOnLeft): Added. Returns the bidi level of the run on the left. We can't
add a generic bidiLevel to this class because it'll be ambiguous at bidi boundaries.
(WebCore::RenderedPosition::bidiLevelOnRight): Ditto for the run on the right.
(WebCore::RenderedPosition::leftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::rightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun): Returns Position at the left edge of a bidi run
if RenderedPosition is at such a position. Asserts atLeftBoundaryOfBidiRun.
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun): Ditto for the right edge.
- editing/RenderedPosition.h:
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftmostOffsetInBox): Added.
(WebCore::RenderedPosition::atRightmostOffsetInBox): Added.
(WebCore::RenderedPosition::uncachedInlineBox): Added. We can't use a static const variable because gcc thinks
reinterpret_cast<InlineBox*>(1) is not an integral value.
(WebCore::RenderedPosition::RenderedPosition):
- editing/VisibleSelection.h:
(WebCore::VisibleSelection::visibleBase): Added.
(WebCore::VisibleSelection::visibleExtent): Added.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag):
LayoutTests:
- editing/selection/select-bidi-run-expected.txt: Added.
- editing/selection/select-bidi-run.html: Added.
- 11:00 Changeset [95963] by
-
[Qt] Unreviewed gardening.
- platform/qt/fast/dom/Window/window-resize-contents-expected.png: Added after r95897.
- platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Added after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png: Updated after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Updated after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated after r95897.
- platform/qt/fast/ruby/ruby-text-before-after-content-expected.png: Added after r95857.
- platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt: Added after r95857.
- 10:52 Changeset [95962] by
-
Unreviewed, rolling out r95256.
http://trac.webkit.org/changeset/95256
https://bugs.webkit.org/show_bug.cgi?id=68814
Temporary CRASH calls no longer needed (Requested by enne on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
- 10:45 WebKitGTK/Releasing edited by
- (diff)
- 10:36 Changeset [95961] by
-
<http://webkit.org/b/68809> IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing
If wakeSyncThread is called before syncThreadMainLoop starts executing then m_syncThreadHasWorkToDo would be set
while executing the body of the sync thread loop, causing us to skip blocking on the condition variable. This would
lead to us hitting the assertion failure due to m_disabledSuddenTerminationForSyncThread being false, unless the main
thread happened to call wakeSyncThread a second time while the first loop iteration was executing.
Reviewed by Anders Carlsson.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncThreadMainLoop): Clear m_syncThreadHasWorkToDo to indicate that we're about to perform
all pending work.
- 10:34 Changeset [95960] by
-
Groove/inset/outset borders show solid if the color is black.
https://bugs.webkit.org/show_bug.cgi?id=58608
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-26
Reviewed by Simon Fraser.
Source/WebCore:
Lightened the border side colors when drawing borders with styles as
Outset/Inset/Groove/Ridge.
Tests: fast/borders/border-groove.html
fast/borders/border-inset.html
fast/borders/border-outset.html
fast/borders/border-ridge.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
LayoutTests:
- fast/borders/border-groove-expected.png: Added.
- fast/borders/border-groove-expected.txt: Added.
- fast/borders/border-groove.html: Added.
- fast/borders/border-inset-expected.png: Added.
- fast/borders/border-inset-expected.txt: Added.
- fast/borders/border-inset.html: Added.
- fast/borders/border-outset-expected.png: Added.
- fast/borders/border-outset-expected.txt: Added.
- fast/borders/border-outset.html: Added.
- fast/borders/border-ridge-expected.png: Added.
- fast/borders/border-ridge-expected.txt: Added.
- fast/borders/border-ridge.html: Added.
- 10:26 April 2011 Meeting/Getting compile time under control edited by
- (diff)
- 10:13 Changeset [95959] by
-
Delete retired custom font data only on document
destruction, and not on recalc style.
https://bugs.webkit.org/show_bug.cgi?id=68805
Reviewed by Dave Hyatt.
Source/WebCore:
Test: fast/text/custom-font-data-crash.html
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
LayoutTests:
- fast/text/custom-font-data-crash-expected.txt: Added.
- fast/text/custom-font-data-crash.html: Added.
- 10:00 Changeset [95958] by
-
chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639
Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-26
Reviewed by Ryosuke Niwa.
Add missing window.layoutTestController.dumpAsText so that test output matches expectation.
- LayoutTests/editing/style/justify-without-enclosing-block.xhtml:
- 09:44 Changeset [95957] by
-
[chromium] Update VideoLayerChromium textures after texture resources are reclaimed
https://bugs.webkit.org/show_bug.cgi?id=68742
Reviewed by James Robinson.
Source/WebCore:
If video textures are reclaimed (such as during a visibility change on
a tab), the dirty rect for the layer is empty and it skips out of
updating compositor resources, leaving the video textures invalid.
Instead, check the textures here to make sure they're still valid
first before early out so that they can get reupdated if necessary.
Additionally, fix a small bug in pushPropertiesTo where 1 plane RGB
videos would not get drawn because all 3 planes didn't have valid
textures.
Test: compositing/video-page-visibility.html
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::texturesValid):
- platform/graphics/chromium/VideoLayerChromium.h:
LayoutTests:
Without this patch, this video texture is invalid.
- compositing/video-page-visibility-expected.png: Added.
- compositing/video-page-visibility-expected.txt: Added.
- compositing/video-page-visibility.html: Added.
- 09:31 Changeset [95956] by
-
Web Inspector: generic performance UI test for panel switch.
https://bugs.webkit.org/show_bug.cgi?id=68806
Reviewed by Pavel Feldman.
- inspector/performance/resources/show-panel-elements.html: Removed.
- inspector/performance/resources/show-panel-network.html: Removed.
- inspector/performance/resources/show-panel.html: Added.
- 08:55 Changeset [95955] by
-
Clean up code imported from WebKitAPITest
Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
TestWebKitAPI conventions
Reviewed by David Levin.
- TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
namespace name.
(TestWebKitAPI::WebViewDestruction::SetUp):
(TestWebKitAPI::WebViewDestruction::webViewCount):
(TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
(TestWebKitAPI::WebViewDestruction::runMessagePump):
(TestWebKitAPI::WebViewDestruction::TearDown):
(TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
Moved functionality from free functions into these new test fixtures.
- TestWebKitAPI/win/HostWindow.cpp:
- TestWebKitAPI/win/HostWindow.h:
Prefixed Win32 API calls with ::. Updated namespace name.
- 08:51 Changeset [95954] by
-
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26
- DEPS:
- 08:35 WebKitGTKStableReleases edited by
- (diff)
- 08:34 WebKitGTKStableReleases created by
- 08:29 Changeset [95953] by
-
Web Inspector: introduce protocol backwards compatibility validator.
https://bugs.webkit.org/show_bug.cgi?id=68800
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/Inspector.draft-01.json: Copied from Source/WebCore/inspector/Inspector.json.
- inspector/validate-protocol-compatibility: Added.
- 08:28 WebKitGTK edited by
- (diff)
- 08:27 WebKitGTK edited by
- (diff)
- 08:26 WebKitGTK edited by
- (diff)
- 08:03 Changeset [95952] by
- 08:01 Changeset [95951] by
- 07:45 Changeset [95950] by
-
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68796
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26
- platform/qt/Skipped:
- 07:39 Changeset [95949] by
-
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=51639
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26
- platform/qt/Skipped:
- 07:37 QtWebKitReleases edited by
- (diff)
- 07:29 QtWebKitReleases edited by
- (diff)
- 07:25 QtWebKitReleases edited by
- (diff)
- 07:24 QtWebKitReleases edited by
- (diff)
- 07:22 QtWebKitReleases edited by
- (diff)
- 07:19 QtWebKitReleases edited by
- (diff)
- 07:04 QtWebKitReleases edited by
- (diff)
- 06:35 Changeset [95948] by
-
Fix documentation generation by specifying the sources
directory with $(top_srcdir).
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Xan Lopez.
- docs/GNUmakefile.am:
- 06:03 Changeset [95947] by
-
[Qt] Unused variable in QNetworkReplyHandler::sendNetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=68798
Patch by Andreas Kling <kling@webkit.org> on 2011-09-26
Reviewed by Noam Rosenthal.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- 05:52 Changeset [95946] by
-
Second unreviewed build fix for r95941
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
- 05:48 Changeset [95945] by
-
Unreviewed build fix for webkit builds after r95941.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
- 05:16 Changeset [95944] by
-
Merge WebKitAPITest into TestWebKitAPI
This also means that our formerly-WebKitAPITest tests will be run on the bots!
I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
them more idiomatic in a separate pass.
Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
functionality (and names!)
Reviewed by Anders Carlsson.
Tools:
- TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
- TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
- TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
- TestWebKitAPI/win/main.cpp:
(main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
- WebKitAPITest: Removed this directory and its contents.
Source/WebKit/win:
Remove WebKitAPITest
- WebKit.vcproj/WebKit.sln: Removed WebKitAPITest.vcproj. Changed WebKitLauncherWin, which
formerly depended on WebKitAPITest, to now depend on DumpRenderTree, which WebKitAPITest
depended on.
- 05:15 Changeset [95943] by
-
Remove two failing WebKitAPITest tests
The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
Reviewed by Anders Carlsson.
- WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
MainFrameAfterClose tests.
- 05:15 Changeset [95942] by
-
2011-09-26 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] allow resources to hook on click on resource links
https://bugs.webkit.org/show_bug.cgi?id=68528
Reviewed by Yury Semikhatsky.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI.Console.prototype.get Severity): (injectedExtensionAPI.Panels.prototype.create): (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper): (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.hasHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.deregisterHandler):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler): (WebInspector.ExtensionServer.prototype._handleAnchorClicked): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._registerExtension):
- inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createCustomSetting):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/helpScreen.css: (.help-content select): (.help-content select:disabled): (.help-content option):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector._showAnchorLocation):
2011-09-26 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] allow resources to hook on click on resource links
https://bugs.webkit.org/show_bug.cgi?id=68528
Reviewed by Yury Semikhatsky.
- http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest):
- inspector/extensions/extensions-api-expected.txt:
- inspector/extensions/extensions-resources-expected.txt:
- inspector/extensions/extensions-resources.html:
- 05:12 Changeset [95941] by
-
Web Inspector: Timeline: record root event for the function calls enforced by console eval.
https://bugs.webkit.org/show_bug.cgi?id=68695
In a complex web application developer might want to timeline a specific piece of code.
In this case he can do the next steps:
1) start timeline;
2) eval a command in console;
3) stop timeline.
I think it'd be nice to have a root event for the all the events that happened as the result of such eval.
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/timeline/timeline-injected-script-eval.html
- bindings/v8/ScriptFunctionCall.cpp:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::makeCall):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
LayoutTests:
- inspector/timeline/timeline-injected-script-eval-expected.txt: Added.
- inspector/timeline/timeline-injected-script-eval.html: Added.
- platform/chromium/inspector/timeline/timeline-injected-script-eval-expected.txt: Added.
- platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt:
- 05:06 Changeset [95940] by
-
REGRESSION: Empathy crashes when switching theme
https://bugs.webkit.org/show_bug.cgi?id=68600
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(webkit_web_view_set_scroll_adjustments): use the existing
set{Horizontal,Vertical}Adjustment functions, so the code is not
duplicated
(webkit_web_view_dispose): unset the adjustments during dispose,
to avoid late adjustment change notifications hitting the
adjustment watcher
- 04:09 WebKitGTK/Releasing edited by
- (diff)
- 03:51 Changeset [95939] by
-
[Texmap][Qt] Enable TextureMapperGL in platforms where BGRA is not present
https://bugs.webkit.org/show_bug.cgi?id=65473
Reviewed by Andreas Kling.
For now, swap RGBA->BGRA in software if we're in OpenGL ES 2.
We do that by iterating on the pixels and manually swapping each pixel's red and blue
values. This can be done faster with shaders, but for now this is a working solution
for platforms without BGRA support.
No new tests. Existing layout tests cover this.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::endPaint):
- platform/graphics/opengl/TextureMapperGL.h:
- platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::RGBA32PremultimpliedBufferQt::swapRGB):
- 02:29 WebKitGTK/Releasing edited by
- Add link to gtk-release-notes script (diff)
- 02:05 Changeset [95938] by
-
[GTK] Fix coding style bits in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68634
Patch by Sergio Villar Senin <svillar@igalia.com> on 2011-09-26
Reviewed by Martin Robinson.
No new tests needed.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
- 01:48 WebKitGTK edited by
- Add link to releasing page (diff)
- 01:43 WebKitGTK/Releasing edited by
- (diff)
- 01:37 WebKitGTK/Releasing edited by
- (diff)
- 01:36 WebKitGTK/Releasing created by
- Documentation about how to release WebKitGtk+
- 00:21 Changeset [95937] by
-
[mac] Timestamp parameter to requestAnimationFrame is busted in USE(REQUEST_ANIMATION_FRAME_TIMER) path
https://bugs.webkit.org/show_bug.cgi?id=68769
Patch by James Robinson <jamesr@chromium.org> on 2011-09-26
Reviewed by Simon Fraser.
Source/WebCore:
Convert the time parameter from double to DOMTimeStamp using convertSecondsToDOMTimeStamp rather than relying on
implicit double->long conversion, which ignores the units of the value.
Test: fast/animation/request-animation-frame-timestamps-advance.html
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::animationTimerFired):
LayoutTests:
Adds a test that the timestamp parameter to the requestAnimationFrame callback advances between calls.
- fast/animation/request-animation-frame-timestamps-advance-expected.txt: Added.
- fast/animation/request-animation-frame-timestamps-advance.html: Added.
- fast/animation/script-tests/request-animation-frame-timestamps-advance.js: Copied from LayoutTests/fast/animation/script-tests/request-animation-frame-timestamps.js.
(busyWait):
(window.webkitRequestAnimationFrame):
- fast/animation/script-tests/request-animation-frame-timestamps.js:
Remove the element parameter, they aren't a useful part of the test.
- 00:05 Changeset [95936] by
-
Add custom vtable struct to ClassInfo struct
https://bugs.webkit.org/show_bug.cgi?id=68567
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Declared/defined the MethodTable struct and added it to the ClassInfo struct.
Also defined the CREATE_METHOD_TABLE macro to generate these method tables
succinctly where they need to be defined.
Also added to it the first function to use this macro, visitChildren.
This is part of the process of getting rid of all C++ virtual methods in JSCell.
Eventually all virtual functions in JSCell that can't easily be converted to
non-virtual functions will be put into this custom vtable structure.
- runtime/ClassInfo.h:
Added the CREATE_METHOD_TABLE macro call as the last argument to each of the
ClassInfo structs declared in these classes. This saves us from having to visit
each s_info definition in the future when we add more methods to the MethodTable.
- API/JSCallbackConstructor.cpp:
- API/JSCallbackFunction.cpp:
- API/JSCallbackObject.cpp:
- JavaScriptCore.exp:
- runtime/Arguments.cpp:
- runtime/ArrayConstructor.cpp:
- runtime/ArrayPrototype.cpp:
- runtime/BooleanObject.cpp:
- runtime/BooleanPrototype.cpp:
- runtime/DateConstructor.cpp:
- runtime/DateInstance.cpp:
- runtime/DatePrototype.cpp:
- runtime/ErrorInstance.cpp:
- runtime/ErrorPrototype.cpp:
- runtime/ExceptionHelpers.cpp:
- runtime/Executable.cpp:
- runtime/GetterSetter.cpp:
- runtime/InternalFunction.cpp:
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSActivation.cpp:
- runtime/JSArray.cpp:
- runtime/JSByteArray.cpp:
- runtime/JSFunction.cpp:
- runtime/JSGlobalObject.cpp:
- runtime/JSONObject.cpp:
- runtime/JSObject.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSString.cpp:
- runtime/MathObject.cpp:
- runtime/NativeErrorConstructor.cpp:
- runtime/NumberConstructor.cpp:
- runtime/NumberObject.cpp:
- runtime/NumberPrototype.cpp:
- runtime/ObjectConstructor.cpp:
- runtime/ObjectPrototype.cpp:
- runtime/RegExp.cpp:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.cpp:
- runtime/RegExpPrototype.cpp:
- runtime/ScopeChain.cpp:
- runtime/StringConstructor.cpp:
- runtime/StringObject.cpp:
- runtime/StringPrototype.cpp:
- runtime/Structure.cpp:
- runtime/StructureChain.cpp:
Had to make visitChildren and visitChildrenVirtual protected instead of private
because some of the subclasses of JSWrapperObject need access to JSWrapperObject's
visitChildren function pointer in their vtable since they don't provide their own
implementation. Same for RegExpObject.
- runtime/JSWrapperObject.h:
- runtime/RegExpObject.h:
Source/JavaScriptGlue:
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- UserObjectImp.cpp:
Source/WebCore:
No new tests.
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- bindings/js/JSAudioConstructor.cpp:
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSImageConstructor.cpp:
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSOptionConstructor.cpp:
- bindings/js/JSWorkerContextBase.cpp:
Changed the bindings generator to add the call to the CREATE_METHOD_TABLE macro where
necessary.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bridge/c/CRuntimeObject.cpp:
- bridge/c/c_instance.cpp:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
- bridge/jni/jsc/JavaRuntimeObject.cpp:
- bridge/objc/ObjCRuntimeObject.mm:
- bridge/objc/objc_instance.mm:
- bridge/objc/objc_runtime.mm:
- bridge/qt/qt_instance.cpp:
- bridge/qt/qt_pixmapruntime.cpp:
- bridge/qt/qt_runtime.cpp:
- bridge/runtime_array.cpp:
- bridge/runtime_method.cpp:
- bridge/runtime_object.cpp:
Source/WebKit/mac:
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- Plugins/Hosted/ProxyInstance.mm:
- Plugins/Hosted/ProxyRuntimeObject.mm:
Source/WebKit2:
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
09/25/11:
- 23:53 Changeset [95935] by
-
[EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL.
https://bugs.webkit.org/show_bug.cgi?id=63502
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-09-25
Reviewed by Martin Robinson.
The gtk/GtkWidgetBackingStoreCairo.cpp is moved to the cairo/WidgetBackingStoreCairo.cpp and
some codes for EFL are added.
WidgetBackingStoreCairo creates cairo_image_surface and has a role to copy reusable area
when scrolling. So, it will be used in the WebKit2 EFL port's BackingStore.
- CMakeListsEfl.txt:
- GNUmakefile.list.am:
- platform/cairo/WidgetBackingStore.h:
- platform/cairo/WidgetBackingStoreCairo.cpp: Renamed from Source/WebCore/platform/gtk/GtkWidgetBackingStoreCairo.cpp.
(WebCore::createSurfaceForBackingStore):
(WebCore::WidgetBackingStorePrivate::create):
(WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate):
(WebCore::WidgetBackingStore::create):
(WebCore::WidgetBackingStore::WidgetBackingStore):
(WebCore::WidgetBackingStore::~WidgetBackingStore):
(WebCore::WidgetBackingStore::cairoSurface):
(WebCore::WidgetBackingStore::scroll):
- platform/gtk/GtkWidgetBackingStoreX11.cpp:
- 21:13 Changeset [95934] by
-
Finish removing PLATFORM(BREWMP) by removing associated code
https://bugs.webkit.org/show_bug.cgi?id=68779
Reviewed by Sam Weinig.
.:
- Source/cmake/WebKitPackaging.cmake:
- wscript:
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- gyp/JavaScriptCore.gyp:
- wscript:
- wtf/FastMalloc.cpp:
(WTF::fastMallocSize):
- wtf/Vector.h:
- wtf/brew: Removed.
- wtf/brew/MainThreadBrew.cpp: Removed.
- wtf/brew/OwnPtrBrew.cpp: Removed.
- wtf/brew/RefPtrBrew.h: Removed.
- wtf/brew/ShellBrew.h: Removed.
- wtf/brew/StringBrew.cpp: Removed.
- wtf/brew/SystemMallocBrew.h: Removed.
- wtf/unicode/brew: Removed.
- wtf/unicode/brew/UnicodeBrew.cpp: Removed.
- wtf/unicode/brew/UnicodeBrew.h: Removed.
Source/WebCore:
When Geoffrey Garen removed PLATFORM(BREWMP) in
http://trac.webkit.org/changeset/95555, he did not remove all the
associated code. This completes the work started in r95555 by removing
all the code assoicated with PLATFORM(BREWMP).
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/js/ScriptControllerBrew.cpp: Removed.
- editing/brew: Removed.
- editing/brew/EditorBrew.cpp: Removed.
- gyp/WebCore.gyp:
- page/brew: Removed.
- page/brew/ChromeClientBrew.h: Removed.
- page/brew/DragControllerBrew.cpp: Removed.
- page/brew/EventHandlerBrew.cpp: Removed.
- page/brew/FrameBrew.cpp: Removed.
- platform/brew: Removed.
- platform/brew/ClipboardBrew.cpp: Removed.
- platform/brew/ClipboardBrew.h: Removed.
- platform/brew/ContextMenuBrew.cpp: Removed.
- platform/brew/ContextMenuItemBrew.cpp: Removed.
- platform/brew/CursorBrew.cpp: Removed.
- platform/brew/DragDataBrew.cpp: Removed.
- platform/brew/EventLoopBrew.cpp: Removed.
- platform/brew/FileSystemBrew.cpp: Removed.
- platform/brew/KURLBrew.cpp: Removed.
- platform/brew/LanguageBrew.cpp: Removed.
- platform/brew/LocalizedStringsBrew.cpp: Removed.
- platform/brew/LoggingBrew.cpp: Removed.
- platform/brew/MIMETypeRegistryBrew.cpp: Removed.
- platform/brew/PasteboardBrew.cpp: Removed.
- platform/brew/PlatformKeyboardEventBrew.cpp: Removed.
- platform/brew/PlatformMouseEventBrew.cpp: Removed.
- platform/brew/PlatformTouchEventBrew.cpp: Removed.
- platform/brew/PlatformTouchPointBrew.cpp: Removed.
- platform/brew/PopupMenuBrew.cpp: Removed.
- platform/brew/PopupMenuBrew.h: Removed.
- platform/brew/SSLKeyGeneratorBrew.cpp: Removed.
- platform/brew/ScreenBrew.cpp: Removed.
- platform/brew/ScrollbarThemeBrew.cpp: Removed.
- platform/brew/ScrollbarThemeBrew.h: Removed.
- platform/brew/SearchPopupMenuBrew.cpp: Removed.
- platform/brew/SearchPopupMenuBrew.h: Removed.
- platform/brew/SharedBufferBrew.cpp: Removed.
- platform/brew/SharedTimerBrew.cpp: Removed.
- platform/brew/SoundBrew.cpp: Removed.
- platform/brew/SystemTimeBrew.cpp: Removed.
- platform/brew/TemporaryLinkStubs.cpp: Removed.
- platform/brew/WidgetBrew.cpp: Removed.
- platform/graphics/brew: Removed.
- platform/graphics/brew/IconBrew.cpp: Removed.
- platform/graphics/brew/ImageBrew.cpp: Removed.
- platform/graphics/brew/IntPointBrew.cpp: Removed.
- platform/graphics/brew/IntSizeBrew.cpp: Removed.
- platform/network/brew: Removed.
- platform/network/brew/DNSBrew.cpp: Removed.
- platform/network/brew/SocketStreamError.h: Removed.
- platform/network/brew/SocketStreamHandle.h: Removed.
- platform/network/brew/SocketStreamHandleBrew.cpp: Removed.
- platform/network/brew/SocketStreamHandlePrivate.h: Removed.
- platform/text/brew: Removed.
- platform/text/brew/TextBoundariesBrew.cpp: Removed.
- platform/text/brew/TextBreakIteratorBrew.cpp: Removed.
- platform/text/brew/TextCodecBrew.cpp: Removed.
- platform/text/brew/TextCodecBrew.h: Removed.
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl:
Tools:
- Scripts/webkitpy/common/config/build.py:
- waf/build/settings.py:
- 21:05 Changeset [95933] by
-
DFG JIT does not count speculation successes correctly
https://bugs.webkit.org/show_bug.cgi?id=68785
Reviewed by Geoffrey Garen.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGOperations.cpp:
- 20:36 Changeset [95932] by
-
DFG support for op_resolve_global is not enabled
https://bugs.webkit.org/show_bug.cgi?id=68786
Reviewed by Geoffrey Garen.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- 20:30 Changeset [95931] by
-
Implement a CloseEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68340
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-25
Reviewed by Oliver Hunt.
Source/WebCore:
The spec of the CloseEvent constructor is here:
http://dev.w3.org/html5/websockets/#closeevent
Test: fast/events/constructors/close-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the CloseEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for CloseEvent.
- websockets/CloseEvent.h: Added a definition for CloseEventInit.
(WebCore::CloseEventInit::CloseEventInit):
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
- websockets/CloseEvent.idl: Makes CloseEvent constructible.
LayoutTests:
- fast/dom/constructed-objects-prototypes-expected.txt: Now window has CloseEvent.
- fast/events/constructors/close-event-constructor-expected.txt: Added.
- fast/events/constructors/close-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped close-event-constructor.html, since V8 does not yet have the CloseEvent constructor.
- 19:25 Changeset [95930] by
-
DFG static prediction code is no longer needed and should be removed
https://bugs.webkit.org/show_bug.cgi?id=68784
Reviewed by Oliver Hunt.
This gets rid of static prediction code, and ensures that we do not
try to compile code where dynamic predictions are not available.
This is accomplished by immediately performing an OSR exit wherever
a value is retrieved for which no predictions exist.
This also adds value profiling for this on functions used for calls.
The heuristics for deciding when to optimize code are also tweaked,
since it is now profitable to optimize sooner. This may need to be
tweaked further, but this patch only makes minimal changes.
This results in a 16% speed-up on Kraken/ai-astar, leading to a 3%
overall win on Kraken. It's neutral elsewhere.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/CodeBlock.h:
- bytecode/PredictedType.cpp:
(JSC::predictionToString):
- bytecode/PredictedType.h:
(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::mergePredictions):
- bytecode/PredictionTracker.h:
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
- bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeUpdatedPrediction):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::emitBranch):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::valueOfJSConstantNode):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::predict):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 18:40 Changeset [95929] by
-
<rdar://problem/10177824> IconDatabase’s use of ThreadCondition leads to assertion failures in the face of spurious wakeups
It's possible for ThreadCondition::wait to return spuriously without the condition having been signaled.
When that happens we should immediately return to waiting rather than doing our normal work, as some of that
work relies on wakeSyncThread having been called to signal the condition.
Reviewed by Sam Weinig.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Note that we have work for the sync thread to do.
(WebCore::IconDatabase::syncThreadMainLoop): If we were woken with no work to do, immediately
go back to waiting on the condition variable. Otherwise, reset m_syncThreadHasWorkToDo and then
do that work. We also switch to moving m_disabledSuddenTerminationForSyncThread immediately in to
our local shouldReenableSuddenTermination variable since it can be updated by other threads while
we don't hold the lock. This makes it inappropriate to make assumptions about its value after dropping
and reacquiring the lock.
- loader/icon/IconDatabase.h:
- 18:12 Changeset [95928] by
-
Provides a simple LRU cache class in Python.
https://bugs.webkit.org/show_bug.cgi?id=67823
Patch by Ai Makabi <makabi@google.com> on 2011-09-21
Reviewed by Tony Chang.
- Scripts/webkitpy/common/lru_cache.py:
- Scripts/webkitpy/common/lru_cache_unittest.py:
- 17:01 Changeset [95927] by
-
DFG JIT Construct opcode takes a this argument even though it's
not passed
https://bugs.webkit.org/show_bug.cgi?id=68782
Reviewed by Oliver Hunt.
This is performance-neutral, mostly. It's a slight speed-up on
v8-splay.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- 16:58 Changeset [95926] by
-
<rdar://problem/10156263> ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/dynamic/subtree-unrooted.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scheduleRelayout): Replaced the check that the renderer is parented,
which was added in r21162, with a check that it is “rooted”.
LayoutTests:
- fast/dynamic/subtree-unrooted-expected.txt: Added.
- fast/dynamic/subtree-unrooted.html: Added.
- 16:40 Changeset [95925] by
-
DFG tracking of the value in cachedResultRegister does not handle
op_mov correctly
https://bugs.webkit.org/show_bug.cgi?id=68781
Reviewed by Oliver Hunt.
This takes the simplest approach: it makes the old JIT dumber rather
than making the DFG JIT smarter. This is performance-neutral.
- jit/JIT.h:
(JSC::JIT::canBeOptimized):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
- 14:42 Changeset [95924] by
-
Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
https://bugs.webkit.org/show_bug.cgi?id=66124
Reviewed by Dan Bernstein.
Test: fast/ruby/ruby-base-merge-block-children-crash.html
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren): add a firstChild()
check to prevent empty anonymous block addition, just like
moveBlockChildren method.
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveBlockChildren): This was incorrectly
doing optimizations to see if current ruby base has only inline
children before beforeChild and then trying to take out them from
their parent anonymous blocks. The problem is those inlines could
be split and have continuations because of encountering a block
inside inline flow. In those cases, we cannot take the inline out.
So, we should just make children non-inline in the destination
block and transfer the children as it-is.
- rendering/RenderRubyBase.h: remove unncessary functions.
LayoutTests: Issues with merging block children of a ruby
base with another ruby base having inline children.
https://bugs.webkit.org/show_bug.cgi?id=66124
Reviewed by Dan Bernstein.
- fast/ruby/ruby-base-merge-block-children-crash.html: Added.
- platform/mac/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
- 14:15 Changeset [95923] by
-
Unreviewed, remove fast/workers/storage/interrupt-database.html
from GTK test_expectations since it's been skipped in r95809.
- platform/gtk/test_expectations.txt:
- 12:35 Changeset [95922] by
-
Remove PLATFORM(HAIKU) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68774
Reviewed by Sam Weinig.
.:
- Source/cmake/WebKitPackaging.cmake:
- wscript:
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- gyp/JavaScriptCore.gyp:
- heap/MachineStackMarker.cpp:
- wtf/PageAllocation.h:
- wtf/Platform.h:
- wtf/StackBounds.cpp:
- wtf/haiku: Removed.
- wtf/haiku/MainThreadHaiku.cpp: Removed.
- wtf/haiku/StringHaiku.cpp: Removed.
- wtf/text/WTFString.h:
Source/WebCore:
As discussed on webkit-dev, the Haiku port has been inactive for over a
year. A year and a half ago, we discussed removing the port, but folks
said they planned to work on it more. That work does not appear to
have happened in the intervening time.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/js/ScriptControllerHaiku.cpp: Removed.
- editing/haiku: Removed.
- editing/haiku/EditorHaiku.cpp: Removed.
- gyp/WebCore.gyp:
- loader/cache/CachedFont.cpp:
- page/EventHandler.cpp:
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
- page/haiku: Removed.
- page/haiku/DragControllerHaiku.cpp: Removed.
- page/haiku/EventHandlerHaiku.cpp: Removed.
- page/haiku/FrameHaiku.cpp: Removed.
- platform/ContextMenuItem.h:
- platform/Cursor.h:
- platform/DragData.h:
- platform/DragImage.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMenuDescription.h:
- platform/PlatformMouseEvent.h:
- platform/Widget.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/Color.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/ImageBufferData.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/haiku: Removed.
- platform/graphics/haiku/ColorHaiku.cpp: Removed.
- platform/graphics/haiku/FloatPointHaiku.cpp: Removed.
- platform/graphics/haiku/FloatRectHaiku.cpp: Removed.
- platform/graphics/haiku/FontCacheHaiku.cpp: Removed.
- platform/graphics/haiku/FontCustomPlatformData.cpp: Removed.
- platform/graphics/haiku/FontCustomPlatformData.h: Removed.
- platform/graphics/haiku/FontHaiku.cpp: Removed.
- platform/graphics/haiku/FontPlatformData.h: Removed.
- platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp: Removed.
- platform/graphics/haiku/GradientHaiku.cpp: Removed.
- platform/graphics/haiku/GraphicsContextHaiku.cpp: Removed.
- platform/graphics/haiku/IconHaiku.cpp: Removed.
- platform/graphics/haiku/ImageBufferDataHaiku.h: Removed.
- platform/graphics/haiku/ImageBufferHaiku.cpp: Removed.
- platform/graphics/haiku/ImageHaiku.cpp: Removed.
- platform/graphics/haiku/IntPointHaiku.cpp: Removed.
- platform/graphics/haiku/IntRectHaiku.cpp: Removed.
- platform/graphics/haiku/IntSizeHaiku.cpp: Removed.
- platform/graphics/haiku/PathHaiku.cpp: Removed.
- platform/graphics/haiku/SimpleFontDataHaiku.cpp: Removed.
- platform/graphics/haiku/StillImageHaiku.cpp: Removed.
- platform/graphics/haiku/StillImageHaiku.h: Removed.
- platform/haiku: Removed.
- platform/haiku/ClipboardHaiku.cpp: Removed.
- platform/haiku/ClipboardHaiku.h: Removed.
- platform/haiku/ContextMenuHaiku.cpp: Removed.
- platform/haiku/ContextMenuItemHaiku.cpp: Removed.
- platform/haiku/CookieJarHaiku.cpp: Removed.
- platform/haiku/CursorHaiku.cpp: Removed.
- platform/haiku/DragDataHaiku.cpp: Removed.
- platform/haiku/DragImageHaiku.cpp: Removed.
- platform/haiku/EventLoopHaiku.cpp: Removed.
- platform/haiku/FileSystemHaiku.cpp: Removed.
- platform/haiku/LocalizedStringsHaiku.cpp: Removed.
- platform/haiku/LoggingHaiku.cpp: Removed.
- platform/haiku/MIMETypeRegistryHaiku.cpp: Removed.
- platform/haiku/PasteboardHaiku.cpp: Removed.
- platform/haiku/PlatformKeyboardEventHaiku.cpp: Removed.
- platform/haiku/PlatformMouseEventHaiku.cpp: Removed.
- platform/haiku/PlatformWheelEventHaiku.cpp: Removed.
- platform/haiku/PopupMenuHaiku.cpp: Removed.
- platform/haiku/PopupMenuHaiku.h: Removed.
- platform/haiku/RenderThemeHaiku.cpp: Removed.
- platform/haiku/RenderThemeHaiku.h: Removed.
- platform/haiku/ScreenHaiku.cpp: Removed.
- platform/haiku/ScrollbarThemeHaiku.cpp: Removed.
- platform/haiku/ScrollbarThemeHaiku.h: Removed.
- platform/haiku/SearchPopupMenuHaiku.cpp: Removed.
- platform/haiku/SearchPopupMenuHaiku.h: Removed.
- platform/haiku/SharedBufferHaiku.cpp: Removed.
- platform/haiku/SharedTimerHaiku.cpp: Removed.
- platform/haiku/SoundHaiku.cpp: Removed.
- platform/haiku/TemporaryLinkStubs.cpp: Removed.
- platform/haiku/WidgetHaiku.cpp: Removed.
- platform/image-decoders/haiku: Removed.
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Removed.
- platform/text/UnicodeRange.h:
- platform/text/haiku: Removed.
- platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: Removed.
Source/WebKit:
- haiku: Removed.
- haiku/WebCoreSupport: Removed.
- haiku/WebCoreSupport/ChromeClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/ChromeClientHaiku.h: Removed.
- haiku/WebCoreSupport/ContextMenuClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/ContextMenuClientHaiku.h: Removed.
- haiku/WebCoreSupport/DragClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/DragClientHaiku.h: Removed.
- haiku/WebCoreSupport/EditorClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/EditorClientHaiku.h: Removed.
- haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Removed.
- haiku/WebCoreSupport/InspectorClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/InspectorClientHaiku.h: Removed.
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl:
Tools:
- Scripts/webkitpy/common/config/build.py:
- waf/build/settings.py:
- 01:16 Changeset [95921] by
-
[CMake] Remove FindLibXlst.cmake
https://bugs.webkit.org/show_bug.cgi?id=68770
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-25
Reviewed by Adam Barth.
This file should have never been committed -- the library it looks for
is called libxslt, not libxlst, so it has never really been used. When
the buildsystem looked for libxslt, it used CMake's own LibXslt.cmake
instead.
- Source/cmake/FindLibXlst.cmake: Removed.
- 00:03 Changeset [95920] by
-
Attempted build fixes for GTK and Qt.
- GNUmakefile.list.am:
- WebCore.pro:
