Timeline


and

10/03/11:

23:42 Changeset [96573] by rniwa@webkit.org
  • 21 edits in trunk/LayoutTests

Mac rebaseline after r96509.

  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/invalid/017-expected.txt:
  • platform/mac/fast/invalid/018-expected.txt:
  • platform/mac/fast/invalid/020-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/mac/fast/table/inline-form-assert-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
23:22 Changeset [96572] by ossy@webkit.org
  • 24 edits
    3 copies
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected files after r96509.

  • platform/qt/fast/invalid/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png.
  • platform/qt/fast/invalid/017-expected.txt:
  • platform/qt/fast/invalid/018-expected.png: Added.
  • platform/qt/fast/invalid/018-expected.txt:
  • platform/qt/fast/invalid/020-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug23994-expected.png.
  • platform/qt/fast/invalid/020-expected.txt:
  • platform/qt/fast/invalid/table-inside-stray-table-content-expected.png: Added.
  • platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/qt/fast/table/inline-form-assert-expected.png:
  • platform/qt/fast/table/inline-form-assert-expected.txt:
  • platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23994-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.png:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56563-expected.png:
  • platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9024-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug9024-expected.txt.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
21:16 Changeset [96571] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Mac release build fix after r96561, and Leopard build fix after r96568.

  • editing/TextCheckingHelper.h:

(WebCore::TextCheckingParagraph::textCharAt):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):

20:52 Changeset [96570] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Build fix after r96568.

  • accessibility/AccessibilityObject.cpp:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:
  • editing/Editor.cpp:
20:20 Changeset [96569] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314

Reviewed by Geoff Garen.

Fix 32-bit.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

20:10 Changeset [96568] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy.
https://bugs.webkit.org/show_bug.cgi?id=69241

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-03
Reviewed by Ryosuke Niwa.

WebCore has two different code paths for spell-checking:

1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.

At the first step, this patch introduces an indirect wrapper to call
checkTextOfParagraph() in Snow Leopard or later. This is intended to make it easy to
introduce a function for mimicing checkTextOfParagraph() in Chromium platform or
other non-SL or non-Lion platform.

No new tests because this patch does not change a behavior.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling): Calling checkTextOfParagraph() indirectly.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(AXAttributeStringSetSpelling): ditto.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::checkTextOfParagraph): Added.

  • editing/TextCheckingHelper.h:
19:55 Changeset [96567] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314

Reviewed by Oliver Hunt.

1% speed-up in V8 due to 6% speed-up in V8-deltablue.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::storePtr):

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

19:26 Changeset [96566] by darin@apple.com
  • 13 edits in trunk/Source/WebCore

Change cursor to hand over missing plug-in message
https://bugs.webkit.org/show_bug.cgi?id=69312

Reviewed by Sam Weinig.

No tests because we currently don't have any test machinery for cursors.

  • page/EventHandler.cpp:

(WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
to represent either a cursor, or no cursor change.
(WebCore::OptionalCursor::isCursorChange): Added.
(WebCore::OptionalCursor::cursor): Added.
(WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
moved some special cases from handleMouseMoveEvent in here. Moved the logic
for plug-ins and framesets into the specific renderer classes for those.
Added a call to the new getCursor virtual function.
(WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
just be a call to selectCursor and then setCursor. Plug-in-specific code is now
in RenderWidget.

  • page/EventHandler.h: Changed return type of selectCursor.
  • page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
  • page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
(WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
Yes, this has nothing to do with the rest of the patch, but it's good.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
(WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
Overloaded so it can be called with a point rather than an event.
(WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
the logic below.
(WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
Changed to use shouldMissingPluginMessageBeButton.
(WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
a hand when over the missing plug-in message.

  • rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated

for other changes above.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::selectCursor about cursors when over
resizable frame borders.

  • rendering/RenderFrameSet.h: Added getCursor.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.

  • rendering/RenderObject.h: Added getCursor.
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
the cursor when the pointer is over a plug-in. This new code is much better,
because it only kicks in when there is actually a plug-in present. The old
was based on the HTML tag!

  • rendering/RenderWidget.h: Added getCursor.
19:00 Changeset [96565] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should remove builders from the failure grid once they start to pass
https://bugs.webkit.org/show_bug.cgi?id=69309

Unreviewed. dglazkov is on vacation. I need to interest someone else
in reviewing these patches.

This patch follows the update/purge model from UpdateTracker. This
patch is less awesome than it could be because it causes the UI to
flash slightly. In a future patch, we'll want to use these
update/purge notifications to update the UI without flashing. However,
that's not such a big deal because this UI is hidden in the default
view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
18:37 Changeset [96564] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC ASSERT Opening the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=69293

Reviewed by Oliver Hunt.

If a polymorphic access structure list has a duplicated structure, then
don't crash.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

18:16 Changeset [96563] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

On X86, switch bucketCount into a register, timeoutCheck into memory
https://bugs.webkit.org/show_bug.cgi?id=69299

Reviewed by Geoff Garen.

We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
function too frequently (regressing performance). This patch has no perf impact on sunspider.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::branchAdd32):
(JSC::MacroAssemblerX86::branchSub32):

  • Added branchSub32 with AbsoluteAddress.
  • jit/JIT.cpp:

(JSC::JIT::emitTimeoutCheck):

  • Keep timeout count in memory on X86.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • remove X86 specific code, switch bucket count back into a register.
  • jit/JITStubs.cpp:
    • Stop initializing esi (it is no longer the timeoutCheck!)
  • jit/JSInterfaceJIT.h:
    • change definition of esi to be the bucketCountRegister.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
    • Add timeoutCount as a property to global data (the counter should be per-thread).
18:05 Changeset [96562] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG backends don't have access to per-node predictions from the propagator
https://bugs.webkit.org/show_bug.cgi?id=69291

Reviewed by Oliver Hunt.

Nodes now have two notion of predictions: the heap prediction, which is
what came directly from value profiling, and the propagator's predictions,
which arise out of abstract interpretation. Every node has a propagator
prediction, but not every node has a heap prediction; and there is no
guarantee that a node that has both will keep them consistent as the
propagator may have additional information available to it.

This is performance neutral.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
(JSC::DFG::Propagator::setReplacement):

17:29 Changeset [96561] by andersca@apple.com
  • 13 edits in trunk/Source/WebCore

Work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69306

Reviewed by Sam Weinig.

Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
the event has been handled or not. For all other event types, that state is instead
tracked by the return value of the various event handlers.

As a first step, add return values to the various handleWheelEvent functions and
add an assertion in EventHandler::wheelEvent that the return value is the same as
the state of PlatformWheelEvent::isAccepted.

  • Configurations/Base.xcconfig:

Don't warn when using C++11 extensions.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):
Assert that isAccepted matches the return value.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):
Return isAccepted.

  • platform/ScrollAnimator.h:

HandleWheelEvent now returns a boolean.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Return whether the event was handled or not.

  • platform/ScrollView.h:

ScrollView::wheelEvent now returns a bool.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):

  • platform/ScrollableArea.h:

ScrollableArea::handleWheelEvent now returns a bool.

  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
Add return values, based on either the base class calls or the state of
PlatformWheelEvent::isAccepted().

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Ditto.

17:23 Changeset [96560] by levin@chromium.org
  • 4 edits in trunk/Tools

webkitpy: Expose cc_emails and comments from bug.py
https://bugs.webkit.org/show_bug.cgi?id=69308

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due

to comments being exposed.

17:13 Changeset [96559] by eric@webkit.org
  • 2 edits
    1 copy in trunk/PerformanceTests

Add a microbenchmark for a full-page render of the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=69285

Reviewed by Adam Barth.

This was designed to be a test for https://bugs.webkit.org/show_bug.cgi?id=68944
But it seems that by far our dominating cost for the HTML5 benchmark is
time spent laying out lines (which isn't actually that surprising).

I'm adding the performance test for posterity.

  • Parser/html-parser.html:
    • Removed use of "about:blank" which abarth says is a no-op. Made comment more accurate.
  • Parser/html5-full-render.html: Copied from PerformanceTests/Parser/html-parser.html.
17:10 Changeset [96558] by mitz@apple.com
  • 8 edits
    2 adds in trunk

<rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the zero rect for SVG elements
https://bugs.webkit.org/show_bug.cgi?id=69305

Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/custom/boundingBox.html

Rather than asserting and returning the zero rect, take the transform-aware code path for computing SVG
bounding rects.

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.
(WebCore::RenderSVGModelObject::absoluteRects): Replaced an incorrect assertion with code to approximate the bounding
box.

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer): Removed the fixed and useTransform boolean parameters.

  • rendering/svg/SVGRenderSupport.h:

LayoutTests:

  • svg/custom/boundingBox-expected.txt: Added.
  • svg/custom/boundingBox.html: Added.
16:54 Changeset [96557] by jamesr@google.com
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Tweak WebCompositor API for input event handling to express three possible states
https://bugs.webkit.org/show_bug.cgi?id=69304

Reviewed by Darin Fisher.

  • public/WebCompositorClient.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):

16:22 Changeset [96556] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add myself to the watchlist for platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=69297

Patch by James Robinson <jamesr@chromium.org> on 2011-10-03
Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
16:11 Changeset [96555] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Content area does not return to the correct position after rubberbanding
https://bugs.webkit.org/show_bug.cgi?id=69302
<rdar://problem/10102886>

Reviewed by Sam Weinig.

Make sure to schedule a display after adding to the dirty region.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):

16:07 Changeset [96554] by michaeln@google.com
  • 5 edits in trunk/Source/WebCore

A little more WebSQLDatabase thread safety.
https://bugs.webkit.org/show_bug.cgi?id=69277

  • switch to using AtomicallyInitializedStatic where appropiate
  • avoid using some Strings across threads

Reviewed by David Levin.

Existing tests apply.

  • storage/AbstractDatabase.cpp:

(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):

  • storage/AbstractDatabase.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::tracker):

  • storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::instance):

16:05 Changeset [96553] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
https://bugs.webkit.org/show_bug.cgi?id=68874

Reviewed by Enrica Casucci.

Replaced m_firstNodeInserted and m_lastLeafInserted by m_startOfInsertedContent and m_endOfInsertedContent
respectively. Also removed removeNodePreservingChildren and removeNodeAndPruneAncestors in ReplaceSelectionCommand
because they were not virtual in CompositeEditCommand and implicitly overriding the functions was confusing.
Since each of these two functions is used at exactly one place, just update positions and insertedNodes explicitly.

  • editing/CompositeEditCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Update m_endOfInsertedContent by endingSelection().visibleEnd()
instead of m_lastLeafInserted with destination.previous() because moveParagraph could have removed leading whitespace in
the text node referenced by destination. This is tested by an existing layout test.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Update positions as needed. All changes are tested
by the existing layout tests in editing/pasteboard.
(WebCore::ReplaceSelectionCommand::updateNodesInserted):

  • editing/ReplaceSelectionCommand.h:
  • editing/htmlediting.cpp:

(WebCore::hasARenderedDescendant): Moved from CompositeEditCommand.cpp.
(WebCore::highestNodeToRemoveInPruning): Ditto.

  • editing/htmlediting.h:
16:02 Changeset [96552] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r94274): cloned text input loses value
https://bugs.webkit.org/show_bug.cgi?id=69095

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.

Test: fast/forms/clone-input-with-dirty-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributeProperties):

LayoutTests:

Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.

  • fast/forms/clone-input-with-dirty-value-expected.txt: Added.
  • fast/forms/clone-input-with-dirty-value.html: Added.
15:51 Changeset [96551] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r96530.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

15:35 Changeset [96550] by weinig@apple.com
  • 8 edits in trunk/Source/WebCore

Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working with XHR and workers
https://bugs.webkit.org/show_bug.cgi?id=69294

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):
Initialize the ContentSecurityPolicy by calling down to the ScriptExecutionContext.

  • dom/Document.h:

Move the ContentSecurityPolicy member and getter from here to ScriptExecutionContext.h.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setContentSecurityPolicy):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::contentSecurityPolicy):
Add ContentSecurityPolicy member and getter/setter.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::parseReportURI):
(WebCore::ContentSecurityPolicy::createCSPDirective):

  • page/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::create):
Replace Document with ScriptExecutionContext. Add temporary checked casts to document
where necessary.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):
Add initialization of the ContentSecurityPolicy.

15:31 Changeset [96549] by andersca@apple.com
  • 22 edits in trunk

Remove custom scrollbar painting hooks
https://bugs.webkit.org/show_bug.cgi?id=69163

Source/WebCore:

Reviewed by Alexey Proskuryakov.

The custom scrollbar and scroll corner painting hooks aren't used by anyone
so go ahead and remove them. This removes the setter/getter and ChromeClient functions.

  • page/Chrome.cpp:
  • page/ChromeClient.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):

Source/WebKit/chromium:

Reviewed by Alexey Proskuryakov.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars):

Source/WebKit/win:

Reviewed by Alexey Proskuryakov.

Remove now unused WebPreferences and ChromeClient overrides.

  • Interfaces/IWebPreferences.idl:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::unused3):
(WebPreferences::unused4):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Remove overridden ChromeClient member functions.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):
No need to enable custom scrollbar painting.

15:25 Changeset [96548] by abarth@webkit.org
  • 4 edits
    7 adds
    3 deletes in trunk/LayoutTests

Update results again now that Leopard has finally cycled.

  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
15:15 Changeset [96547] by darin@apple.com
  • 22 edits in trunk/Source/WebCore

Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
https://bugs.webkit.org/show_bug.cgi?id=68672

Reviewed by Daniel Bates.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):

  • css/CSSStyleSelector.cpp:

(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::styleForElement):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/haiku/RenderThemeHaiku.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::resolve):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::releaseConnectionForDownload):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):

  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::create):

  • platform/wx/RenderThemeWx.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/style/RenderStyle.cpp:

(WebCore::defaultStyle):
Call leakRef instead of releaseRef. I did this only in the cases where
it was obvious to me this was the right way to do it. I'll keep revisiting
sites still calling it releaseRef until they are all gone.

15:00 Changeset [96546] by ojan@chromium.org
  • 9 edits in trunk/Source/WebCore

remove dead code in flipForWritingMode
https://bugs.webkit.org/show_bug.cgi?id=68948

Reviewed by Hajime Morita.

ChildToParentFlippingAdjustment is never used, so the third argument
to flipForWritingMode always has the same value.

In addition, renamed to flipForWritingModeForChild to be more clear
that it's operating on the child and renamed flipFloatForWritingMode to match.

No new tests. This is just a code cleanup. No functional changes.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::flipFloatForWritingModeForChild):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::flipForWritingModeForChild):
(WebCore::RenderBox::topLeftLocation):

  • rendering/RenderBox.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::nodeAtPoint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::nodeAtPoint):

14:57 Changeset [96545] by jer.noble@apple.com
  • 10 edits in trunk/Source

Unreviewed, rolling out r96526.
http://trac.webkit.org/changeset/96526
https://bugs.webkit.org/show_bug.cgi?id=68587

WEB_AUDIO has numerous 64->32 bit casting warnings, causing
build breakages where -Wall is enabled.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
14:55 Changeset [96544] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Update results to account for Windows Vista.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
14:50 Changeset [96543] by joepeck@webkit.org
  • 3 edits
    2 adds in trunk

<http://webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex/hsl values

Reviewed by Pavel Feldman.

Source/WebCore:

Previously we assumed rgb values were always in byte form,
but they could include percentage values. Ex. rgb(100%,0,0).
This patch fixes this, and in the process includes clamping
for invalid percentages, byte values, and alpha values.

Test: inspector/styles/styles-invalid-color-values.html

  • inspector/front-end/Color.js:

(WebInspector.Color.prototype._clamp):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._individualRGBValueToHexValue):
(WebInspector.Color.prototype._rgbToHex):
(WebInspector.Color.prototype._rgbToHSL):
An individual rgb value can be either a decimal/float or a
percentage. Rewrite the conversion functions to handle either
input. Regardless of the type of input, always return a clamped
decimal/float value between 0 and 255.

(WebInspector.Color.prototype._rgbaToHSLA):
(WebInspector.Color.prototype._hslaToRGBA):
(WebInspector.Color.prototype._parse):
Clamp the alpha value between 0 and 1.

LayoutTests:

This test outputs all of the supported color format representations
for supplied CSS color values. We expect some of the CSS values
to be clamped, e.g. rgb(300,0,0) to rgb(255,0,0). This also tests
that rgb percentages, such as rgb(100%,0,0), work correctly.

  • inspector/styles/styles-invalid-color-values-expected.txt: Added.
  • inspector/styles/styles-invalid-color-values.html: Added.
14:45 Changeset [96542] by abarth@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Update chromium-cg-mac results after http://trac.webkit.org/changeset/96530.

  • platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
14:44 Changeset [96541] by levin@chromium.org
  • 3 edits in trunk/Tools

watchlist: Make watchlist run on a bot.
https://bugs.webkit.org/show_bug.cgi?id=68974

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:

Change to log what is run so that we can see the style command
and the watchlist command being run.

14:44 Changeset [96540] by levin@chromium.org
  • 5 edits in trunk/Tools

watchlist: Allow specified a bug to attach the watchlist info to.
https://bugs.webkit.org/show_bug.cgi?id=69288

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:

Add tests and fix an existing test because the unit tests do not go through the
normal command line processing (so the -g argument remained when we determined bug ids).

  • Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to

get the assert raises regex method.

  • Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
14:42 Changeset [96539] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Update results now that the race condition is fixed. It seems like the
cross-platform results would need to be updated as well, but no bot has
told me that yet.

  • platform/chromium-mac-leopard/svg/as-object: Added.
  • platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
14:37 Changeset [96538] by abarth@webkit.org
  • 14 edits
    8 adds
    3 deletes in trunk/LayoutTests

Update baselines after http://trac.webkit.org/changeset/96530.

  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-cg-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
  • svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
13:57 Changeset [96537] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

[EFL] DRT: Add JSStringUtils.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=66397

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-10-03
Reviewed by Ryosuke Niwa.

Adds helper functions to compare the equality of C-style strings and
JSStringRef objects.

  • DumpRenderTree/efl/JSStringUtils.cpp: Added.

(equals):

  • DumpRenderTree/efl/JSStringUtils.h: Added.
13:51 Changeset [96536] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic should work in Safari 5.1
https://bugs.webkit.org/show_bug.cgi?id=69290

Reviewed by Sam Weinig.

My old implementation of bind was too clever by half. This one seems
to work better, at least according to this test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
13:43 Changeset [96535] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r96532.
http://trac.webkit.org/changeset/96532
https://bugs.webkit.org/show_bug.cgi?id=69289

Accidentally marked failures as expected instead of creating
new baseline. (Requested by krit on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03

  • platform/chromium/test_expectations.txt:
13:39 Changeset [96534] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for DFG JIT 32_64.

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:25 Changeset [96533] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

webkit->chromium DEPS roll 103471->103694
https://bugs.webkit.org/show_bug.cgi?id=69271

This brings in a new tools/win/supalink directory from
http://src.chromium.org/viewvc/chrome?view=rev&revision=103474

Patch by Elliot Poger <epoger@google.com> on 2011-10-03
Reviewed by Adam Barth.

  • DEPS:
13:24 Changeset [96532] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

Uneviewed by rebaseline after SVG Pattern patch with bug 69261.

  • platform/chromium/test_expectations.txt:
13:09 Changeset [96531] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests

PerformanceTests/Parser/html-parser is only testing parsing of the head element
https://bugs.webkit.org/show_bug.cgi?id=69283

Reviewed by Adam Barth.

While investigating https://bugs.webkit.org/show_bug.cgi?id=68944
I found that the html-parser benchmark was only parsing up to the
first script tag per loop! We've fixed this by adding the sandbox
tag which will deny all external loads and allow the parser to
synchronously continue parsing the entire document to completion
(as we had expected it was doing).

This changes the profile somewhat. Line number counting is much
hotter, since we're actually accounting for the parse of the entire
document in our sample.

Total sample time only about doubles, from 1800ms to 3800ms on my machine
which is less than I would have expected.

  • Parser/html-parser.html:
12:54 Changeset [96530] by krit@webkit.org
  • 5 edits
    3 adds in trunk

SVG Pattern tile pixelated on patternTransform
https://bugs.webkit.org/show_bug.cgi?id=69261

Source/WebCore:

Reviewed by Rob Buis.

Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.

Test: svg/custom/pattern-scaled-pattern-space.svg

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

LayoutTests:

Reviewed by Rob Buis.

Add a new test to check that SVG pattern tiles are not pixelated on
scaling with patternTransform.
Updated two more pixel tests. Both changes are progressions.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • svg/custom/pattern-scaled-pattern-space-expected.txt: Added.
  • svg/custom/pattern-scaled-pattern-space.svg: Added.
12:52 Changeset [96529] by jamesr@google.com
  • 10 edits
    1 copy in trunk/Source

[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181

Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

  • public/WebWidget.h:

(WebKit::WebWidget::compositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
12:44 Changeset [96528] by abarth@webkit.org
  • 9 edits
    2 adds
    1 delete in trunk/LayoutTests

Another round of updates after http://trac.webkit.org/changeset/96509.

  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png:
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png:
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png:
  • platform/chromium-win/fast/invalid/017-expected.png:
  • platform/chromium-win/fast/invalid/018-expected.png:
  • platform/chromium-win/fast/invalid/020-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
12:25 Changeset [96527] by fpizlo@apple.com
  • 15 edits
    1 add in trunk/Source/JavaScriptCore

DFG should speculate more aggressively on obvious cases on
polymorphic get_by_id
https://bugs.webkit.org/show_bug.cgi?id=69235

Reviewed by Oliver Hunt.

This implements trivial polymorphic get_by_id. It also fixes
problems in the CSE for CheckStructure in the put_by_id
transition case.

Doing this required knowing whether a polymorphic get_by_id stub
was doing a direct access rather than a call of some kind.

Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
scaled mean of all benchmarks.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Instruction.h:

(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addStructureSet):
(JSC::DFG::Graph::addStructureTransitionData):

  • dfg/DFGNode.h:

(JSC::DFG::StructureTransitionData::StructureTransitionData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::structureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::structureSet):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureSet.h: Added.

(JSC::DFG::StructureSet::StructureSet):
(JSC::DFG::StructureSet::add):
(JSC::DFG::StructureSet::addAll):
(JSC::DFG::StructureSet::remove):
(JSC::DFG::StructureSet::contains):
(JSC::DFG::StructureSet::isSubsetOf):
(JSC::DFG::StructureSet::isSupersetOf):
(JSC::DFG::StructureSet::size):
(JSC::DFG::StructureSet::at):
(JSC::DFG::StructureSet::operator[]):
(JSC::DFG::StructureSet::last):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

12:21 Changeset [96526] by jer.noble@apple.com
  • 10 edits in trunk/Source

Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

No new tests; existing webaudio/ layout tests cover this.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to

the WebCore.framework bundle.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:13 Changeset [96525] by crogers@google.com
  • 24 edits
    2 adds in trunk

BiquadFilterNode .type attribute is not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=69182

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/biquadfilternode-basic.html

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::initialize):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::AudioChannelMerger):

  • webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::AudioChannelSplitter):

  • webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::AudioGainNode):

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::setNodeType):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):

  • webaudio/AudioNode.h:

(WebCore::AudioNode::nodeType):

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):

  • webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):
(WebCore::BiquadFilterNode::setType):

  • webaudio/BiquadFilterNode.h:
  • webaudio/BiquadFilterNode.idl:
  • webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::setType):

  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • webaudio/HighPass2FilterNode.cpp:

(WebCore::HighPass2FilterNode::HighPass2FilterNode):

  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):

  • webaudio/LowPass2FilterNode.cpp:

(WebCore::LowPass2FilterNode::LowPass2FilterNode):

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):

  • webaudio/RealtimeAnalyserNode.cpp:

(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):

  • webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::WaveShaperNode):

LayoutTests:

  • webaudio/biquadfilternode-basic-expected.txt: Added.
  • webaudio/biquadfilternode-basic.html: Added.
12:01 Changeset [96524] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

AX: support role mapping for HTML5 section elements
https://bugs.webkit.org/show_bug.cgi?id=69150

Source/WebCore:

We need to map these HTML5 elements to appropriate ARIA roles. That mapping is:

article -> Document article
nav -> Landmark navigation
aside -> Landmark complementary
section -> Document region
address -> Landmark content info
header -> Landmark banner (unless it's in an article or section)
footer -> Landmark content info (unless it's in an article or section)

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html-section-elements.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html-section-elements-expected.txt: Added.
  • platform/mac/accessibility/html-section-elements.html: Added.
11:55 Changeset [96523] by ademar@webkit.org
  • 2 edits in trunk/Tools

Unreviewed: change my e-mail in commiters.py

(I'm leaving the company and my @openbossa.org will be no more)

  • Scripts/webkitpy/common/config/committers.py:
11:09 Changeset [96522] by cfleizach@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262

Actually commit the files this time.

Reviewed by John Sullivan.

  • platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
  • platform/mac/accessibility/heading-clickpoint.html: Added.
11:05 Changeset [96521] by abarth@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Results from more bots for http://trac.webkit.org/changeset/96498.

  • platform/chromium-cg-mac-leopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/chromium-win-vista/svg/filters: Removed.
  • platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Removed.
11:04 Changeset [96520] by cfleizach@apple.com
  • 6 edits in trunk

AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262

Source/WebCore:

When the contextual menu is opened for a heading, often it will open on empty space because
the heading is wider than the content inside. The click point should thus use the content
inside the heading as the click point.

To accomplish this we need to query whether we have children using children() which is a non-const
method, hence the removal of const from clickPoint().

Reviewed by John Sullivan.

Test: platform/mac/accessibility/heading-clickpoint.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clickPoint):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::clickPoint):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by John Sullivan.

  • platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
  • platform/mac/accessibility/heading-clickpoint.html: Added.
11:00 Changeset [96519] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r96500.
http://trac.webkit.org/changeset/96500
https://bugs.webkit.org/show_bug.cgi?id=69268

Breaks inspector, change landed with no test. (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):

  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():

  • inspector/front-end/Linkifier.js: Removed.
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
10:51 Changeset [96518] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unbork the test_expectations file.

  • platform/chromium/test_expectations.txt:
10:40 Changeset [96517] by antti@apple.com
  • 7 edits in trunk/Source/WebCore

Add exact match attribute selectors to the fast path
https://bugs.webkit.org/show_bug.cgi?id=69159

Reviewed by Sam Weinig.

Attribute selectors are increasingly common and we have them in our default style sheet too.
[foo] and [foo="bar"] type selectors can be resolved quickly and easily in the fast path.

  • Implement fast path checking for simple attribute selectors.
  • Get rid of the ill-defined CSSSelector::hasAttribute(), inline CSSSelector::attribute()


This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(WebCore::CSSSelector::hasTag):
(WebCore::CSSSelector::attribute):
(WebCore::CSSSelector::isAttributeSelector):

  • css/CSSSelectorList.cpp:

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkSelector):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkSelector):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::attributeNameMatches):
(WebCore::SelectorChecker::checkExactAttribute):
(WebCore::SelectorChecker::fastCheckRightmostAttributeSelector):

10:37 Changeset [96516] by abarth@webkit.org
  • 10 edits
    32 adds
    5 deletes in trunk/LayoutTests

Update expectations for tables tests after http://trac.webkit.org/changeset/96509.

  • platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt: Added.
  • platform/chromium-win/fast/forms/file-input-disabled-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/chromium/fast/invalid: Added.
  • platform/chromium/fast/invalid/017-expected.txt: Added.
  • platform/chromium/fast/invalid/018-expected.txt: Added.
  • platform/chromium/fast/invalid/020-expected.txt: Added.
  • platform/chromium/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium/fast/invalid/table-inside-stray-table-content-expected.txt: Added.
  • platform/chromium/fast/table: Added.
  • platform/chromium/fast/table/inline-form-assert-expected.txt: Added.
  • platform/chromium/tables: Added.
  • platform/chromium/tables/mozilla: Added.
  • platform/chromium/tables/mozilla/bugs: Added.
  • platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Added.
  • platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Added.
  • platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug220653-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/core: Added.
  • platform/chromium/tables/mozilla_expected_failures/core/conflicts-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/other: Added.
  • platform/chromium/tables/mozilla_expected_failures/other/empty_cells-expected.txt: Added.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
10:20 Changeset [96515] by reed@google.com
  • 2 edits in trunk/Source/WebCore

respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText.
https://bugs.webkit.org/show_bug.cgi?id=69172

Reviewed by Stephen White.

No new tests. This is a cleanup/optimization, existing tests apply

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

09:57 Changeset [96514] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r95526): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=69265

  • platform/qt/Skipped: Skip failing tests to make buildbot happy.
09:56 Changeset [96513] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Delete bogus expected PNG.

  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Removed.
09:50 Changeset [96512] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

FontFallbackList: Glyph pages waste a lot of memory.
https://bugs.webkit.org/show_bug.cgi?id=69260

Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Dan Bernstein.

Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
glyph pages. This reduces memory consumption by ~900 kB when loading the
full HTML5 spec.

The cost is two additional rehash()es of FontFallbackList::m_pages when
adding the 32nd and 64th pages to the hash map.

  • platform/graphics/FontFallbackList.h:
09:36 Changeset [96511] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add failing uri parameter to provisional-load-failed and load-failed signals
https://bugs.webkit.org/show_bug.cgi?id=69252

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didFailProvisionalLoadWithErrorForFrame): Pass failing URL to
signal handler.
(didFailLoadWithErrorForFrame): Ditto.
(webkit_web_loader_client_class_init): Add failing URL parameter
to provisional-load-failed and load-failed signals.

  • UIProcess/API/gtk/WebKitWebLoaderClient.h:
  • UIProcess/API/gtk/tests/testloading.c:

(loadStatusProvisionalLoadFailed): Update to API changes.
(loadStatusLoadFailed): Ditto.
(loadErrorProvisionalLoadFailed): Ditto.

  • UIProcess/API/gtk/webkit2marshal.list:
09:19 Changeset [96510] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Fix typo causing race condition in this test.

  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
09:19 Changeset [96509] by commit-queue@webkit.org
  • 30 edits
    1 copy
    2 adds in trunk

Right border missing from table with colspan and collapsing border
https://bugs.webkit.org/show_bug.cgi?id=14274

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-10-03
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/bug14274.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):

  • rendering/RenderTable.h:

(WebCore::RenderTable::colToEffCol):

LayoutTests:

  • fast/table/border-collapsing/bug14274-expected.png: Copied from LayoutTests/platform/chromium-win/fast/invalid/020-expected.png.
  • fast/table/border-collapsing/bug14274-expected.txt: Added.
  • fast/table/border-collapsing/bug14274.html: Added.
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/chromium-win/fast/invalid/017-expected.png:
  • platform/chromium-win/fast/invalid/017-expected.txt:
  • platform/chromium-win/fast/invalid/018-expected.png:
  • platform/chromium-win/fast/invalid/018-expected.txt:
  • platform/chromium-win/fast/invalid/020-expected.png:
  • platform/chromium-win/fast/invalid/020-expected.txt:
  • platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/chromium-win/fast/table/inline-form-assert-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
  • platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
  • platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
09:17 Changeset [96508] by carlosgc@webkit.org
  • 5 edits in trunk

[GTK] Fix memory leak when loading url
https://bugs.webkit.org/show_bug.cgi?id=69247

Reviewed by Martin Robinson.

Release URL created with WKURLCreateWithUTF8CString().

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_uri):

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(activateUriEntryCallback):

  • MiniBrowser/gtk/main.c:

(loadURI):

09:16 Changeset [96507] by abarth@webkit.org
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

Update baselines after http://trac.webkit.org/changeset/96498.

  • platform/chromium-linux-x86/svg/filters: Removed.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/chromium-win-vista/svg/filters: Added.
  • platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png: Added.
09:14 Changeset [96506] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

[UNIX] Rename NetscapePluginModule::pluginInfo to NetscapePluginModule::getPluginInfoForLoadedPlugin()
https://bugs.webkit.org/show_bug.cgi?id=69147

Reviewed by Martin Robinson.

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):

09:11 Changeset [96505] by carlosgc@webkit.org
  • 5 edits in trunk/Source

[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69243

Reviewed by Martin Robinson.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.am:
  • GNUmakefile.list.am:
09:03 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the WK2 bot (diff)
09:02 Changeset [96504] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245

Unreviewed rebaseline of Win Chromium DRT results.

  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
08:58 Changeset [96503] by ossy@webkit.org
  • 8 edits
    1 add in trunk/Source

[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162

Use QString::toHtmlEscaped in the Qt5 case.

Source/JavaScriptCore:

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.

(escapeHtml):

  • wtf/wtf.pri:

Source/WebCore:

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.

No new tests needed.

  • WebCore.pro: adjust the include path accordingly

in the v8 case.

Source/WebKit/qt:

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::setToolTip):

08:51 Changeset [96502] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: [chromium] clean up inspector layout test suppressions on chromium.
https://bugs.webkit.org/show_bug.cgi?id=69263

  • platform/chromium/test_expectations.txt:
08:43 Changeset [96501] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening after r96404.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03

  • platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
08:07 Changeset [96500] by loislo@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146

In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.

Reviewed by Yury Semikhatsky.

Test: inspector/performance/resources/network-append-30-requests.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._linkifyLocation):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():

  • inspector/front-end/Linkifier.js: Added.

(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateSourceAnchors):
(WebInspector.Linkifier.prototype._updateAnchor):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
07:56 Changeset [96499] by pfeldman@chromium.org
  • 18 edits in trunk

Source/WebCore: Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
https://bugs.webkit.org/show_bug.cgi?id=69253

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessageImpl):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):

  • inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.get path):
(WebInspector.Cookie.prototype.get domain):
(WebInspector.Cookie.prototype.expires):

  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.searchInContent):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._createResource):

  • inspector/front-end/externs.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.extensionServer.notifyResourceContentCommitted):
(WebInspector.resourceForURL):
(WebInspector.debuggerPresentationModel.linkifyLocation):
(WebInspector.ObjectPropertiesSection):
(WebInspector.ElementsTreeOutline):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):

  • inspector/generate-protocol-externs:

Tools: Unreviewed. Add Zoltán Árvai as contributor.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2011-10-03

  • Scripts/webkitpy/common/config/committers.py:
07:27 Changeset [96498] by krit@webkit.org
  • 6 edits
    3 adds in trunk

feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Opera doesn't limit the range of values for saturation on feColorMatrix from 0 to 1. The limitation
was also removed from the new Filter Effects 1.0 specification. Values outside this range lead to
under- or oversaturation of the filter input image.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/publish/Filters.html#feColorMatrixElement

Test: svg/filters/feColorMatrix-saturate.svg

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build):

LayoutTests:

Reviewed by Nikolas Zimmermann.

Added new test case to test under- or oversaturation of the filter input image if the value
is not in the range of 0..1.
feColorMatrix-values needed a change, since it relies to the old specification text.

  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • svg/filters/feColorMatrix-saturate-expected.png: Added.
  • svg/filters/feColorMatrix-saturate-expected.txt: Added.
  • svg/filters/feColorMatrix-saturate.svg: Added.
  • svg/filters/feColorMatrix-values.svg:
07:21 Changeset [96497] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

[EFL] DRT: Add DumpHistoryItem.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=63992

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-03
Reviewed by Antonio Gomes.

This is the code responsible for dumping the back and forward history
list.

  • DumpRenderTree/efl/DumpHistoryItem.cpp: Added.

(dumpHistoryItem):
(dumpBackForwardListForWebView):
(dumpBackForwardListForWebViews):

  • DumpRenderTree/efl/DumpHistoryItem.h: Added.
07:16 Changeset [96496] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink HTMLLIElement.
https://bugs.webkit.org/show_bug.cgi?id=69250

Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Antti Koivisto.

Don't cache the explicit "value" attribute on the HTMLLIElement,
but fetch it with fastGetAttribute when needed.
This shrinks HTMLLIElement by one CPU word.

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::parseMappedAttribute):
(WebCore::HTMLLIElement::attach):

  • html/HTMLLIElement.h:
07:13 Changeset [96495] by ryuan.choi@samsung.com
  • 3 edits
    3 moves in trunk/Source/WebKit/efl

[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
https://bugs.webkit.org/show_bug.cgi?id=68599

Use a C++ compiler for these files and fix compile issues and coding style.

Reviewed by Hajime Morita.

  • CMakeListsEfl.txt:
  • ewk/ewk_tiled_backing_store.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.c.
  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.c.
  • ewk/ewk_tiled_model.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.c.
07:04 Changeset [96494] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.
https://bugs.webkit.org/show_bug.cgi?id=68439

We use a dispatch queue and a dispatch source in the WebProcess
to receive a notification when the UI Process dies.
The WebProcess then commits suicide.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::parentProcessDiedCallback):
(WebKit::WebProcess::platformInitializeWebProcess):

06:58 Changeset [96493] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r96257.
https://bugs.webkit.org/show_bug.cgi?id=69257

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03

  • platform/qt/Skipped:
06:06 Changeset [96492] by kbalazs@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

libdispatch based ParallelJobs is not enough parallel
https://bugs.webkit.org/show_bug.cgi?id=66378

Reviewed by Zoltan Herczeg.

Use the appropriate libdispatch API for our use case.
Throw away the hard coded limit of parallel threads
and use dispatch_apply with the default priority normal
queue istead of using our own custom serial queue (which
was a misuse of the API). Enabling PARALLEL_JOBS is now
a 60% win (2.63x as fast) on the methanol benchmark
(https://gitorious.org/methanol) with an SVG centric test set
while the old implementation was almost identical (less than 5% win).

  • wtf/ParallelJobsLibdispatch.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

05:56 Changeset [96491] by vsevik@chromium.org
  • 11 edits
    5 adds in trunk

Web Inspector: Add support for backend search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/search/search-in-concatenated-script.html

http/tests/inspector/search/search-in-script.html

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):

  • http/tests/inspector/search/resources/search-concatenated.html: Added.
  • http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-concatenated-script.html: Added.
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-script.html: Added.
  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest):

04:58 Changeset [96490] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r96481.
http://trac.webkit.org/changeset/96481
https://bugs.webkit.org/show_bug.cgi?id=69251

Breaks webkit_unit_tests on Linux(dbg) (Requested by hwennborg
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03

  • WebKit.gypi:
  • public/WebCompositor.h:
  • public/WebWidgetClient.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):

  • src/WebCompositorImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):

  • tests/WebCompositorImplTest.cpp: Removed.
04:37 Changeset [96489] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223

WebKitTestRunner must include Qt / qnamespace header
to get a definition of Qt::MouseButtons.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.

  • WebKitTestRunner/EventSenderProxy.h:
03:55 Changeset [96488] by ossy@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Add Zoltán Árvai as contributor.

  • Scripts/webkitpy/common/config/committers.py:
02:54 Changeset [96487] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=69244

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatParameter):
(WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessage.prototype._formatParameterAsString):
(WebInspector.ConsoleMessage.prototype._printArray):
(WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):

  • inspector/front-end/ConsoleView.js:
02:30 Changeset [96486] by rgabor@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed Qt gardening after r96404

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-03

  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
02:18 WebKit Team edited by yutak@chromium.org
(diff)
02:16 Changeset [96485] by pfeldman@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: restore partial front-end compilability
https://bugs.webkit.org/show_bug.cgi?id=69221

Removed unused isWhitespace; introduced missing classes in Inspector.json;
generated externs for the protocol types along with the commands.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-03
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateBreadcrumb):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/Object.js:
  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._mouseMove):

  • inspector/front-end/View.js:
  • inspector/front-end/externs.js:

(Array.prototype.remove):

  • inspector/generate-protocol-externs:

10/02/11:

23:59 Changeset [96484] by tkent@chromium.org
  • 14 edits
    4 adds in trunk

method/enctype/formMethod/formEnctype properties should be limited to known values.
https://bugs.webkit.org/show_bug.cgi?id=68887

Reviewed by Hajime Morita.

Source/WebCore:

According to the standard and other browser behaviors, the
following IDL properties should be reflected to the corresponding
HTML attributes on setting, but should return normalized values on
getting.

  • HTMLFormElement::method
  • HTMLFormElement::enctype
  • HTMLInputElement::formMethod
  • HTMLInputElement::formEnctype
  • HTMLButtonElement::formMethod
  • HTMLButtonElement::formEnctype

Tests: fast/forms/enctype-attribute.html

fast/forms/method-attribute.html

  • html/HTMLButtonElement.idl:

Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formEnctype):
Normalizes the value by parseEncodingType().
(WebCore::HTMLFormControlElement::setFormEnctype):
Simply calls setAttribute()
(WebCore::HTMLFormControlElement::formMethod):
Normalizes the value by parseMethodType().
(WebCore::HTMLFormControlElement::setFormMethod):
Simply calls setAttribute()

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseMappedAttribute):
Follow the Attributes function renaming.
(WebCore::HTMLFormElement::method):
Normalizes the value by parseMethodType().

  • html/HTMLFormElement.idl:

Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.

  • html/HTMLInputElement.idl: ditto.
  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):
New function made from a part of old parseEncodingType().
(WebCore::FormSubmission::Attributes::updateEncodingType):
Renamed from parseEncodingType().
(WebCore::FormSubmission::Attributes::parseMethodType):
New function made from a part of old parseMethodType().
(WebCore::FormSubmission::Attributes::updateMethodType):
Renamed from parseMethodType().
(WebCore::FormSubmission::create):
Follow the Attributes function renaming.

  • loader/FormSubmission.h:

(WebCore::FormSubmission::Attributes::methodString):
A helper function to provide normalized strings for FormSubmission::Method.

LayoutTests:

  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html: Correct an expectation for HTMLFormElement::method.
  • fast/forms/enctype-attribute-expected.txt: Added.
  • fast/forms/enctype-attribute.html: Added.
  • fast/forms/method-attribute-expected.txt: Added.
  • fast/forms/method-attribute.html: Added.
  • fast/forms/script-tests/submit-form-attributes.js: Correct expectations.
  • fast/forms/submit-form-attributes-expected.txt: ditto.
23:49 Changeset [96483] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990

Reviewed by Geoffrey Garen.

Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.

  • runtime/Structure.h:

(JSC::Structure::transitionCount):

19:13 Changeset [96482] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG misses some obvious opportunities for common subexpression elimination
https://bugs.webkit.org/show_bug.cgi?id=69233

Reviewed by Oliver Hunt.

0.7% speed-up on SunSpider.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

18:11 Changeset [96481] by commit-queue@webkit.org
  • 9 edits
    1 copy in trunk/Source/WebKit/chromium

[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181

Patch by James Robinson <jamesr@chromium.org> on 2011-10-02
Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

  • public/WebWidget.h:

(WebKit::WebWidget::compositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
17:40 Changeset [96480] by weinig@apple.com
  • 6 edits in trunk/Source

Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
https://bugs.webkit.org/show_bug.cgi?id=69230

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in:
  • page/Frame.h:
  • page/mac/FrameMac.mm:

../WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(regExpForLabels):
(searchForLabelsBeforeElement):
(matchLabelsAgainstString):
(matchLabelsAgainstElement):
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):

17:22 Changeset [96479] by barraclough@apple.com
  • 5 edits in trunk

Bug 67455 - Different regular expression result

Reviewed by Darin Adler.

Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.

Source/JavaScriptCore:

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchParentheses):

  • Simplify some nested if else logic.

(JSC::Yarr::Interpreter::backtrackParentheses):

  • Simplify some nested if else logic.
  • Only return early from backtrackParentheses on success/error, not on failure.

LayoutTests:

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
    • Added test cases from bug.
13:02 Changeset [96478] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=68542

Reviewed by Mark Rowe.

  • WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
12:54 Changeset [96477] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223

Source/WebCore:

Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
Add a missing include path and a missing objective source file to WebCore.pro.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

No new tests, build fix.

  • WebCore.pro:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:

Source/WebKit2:

After the merge of the Qt5 refactor branch, networking stuff has been
extracted into a separate library. The qmlplugin needs to link to that
library to get QNetworkReply defined.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

  • UIProcess/API/qt/qmlplugin/qmlplugin.pro:
12:41 Changeset [96476] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an unused member in RenderTable::ColumnStruct
https://bugs.webkit.org/show_bug.cgi?id=69119

Reviewed by Darin Adler.

No test as there should be no change in behavior.

The member was added several years ago and its users were removed or changed. The code would
need a refactoring but this would be tricky to get right. This change just removes the member
to reap the short-term benefits.

  • rendering/RenderTable.h:

(WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.

10:38 Changeset [96475] by abarth@webkit.org
  • 1 edit
    2 adds
    15 deletes in trunk/LayoutTests

Remove temporary baselines after http://trac.webkit.org/changeset/96470.

  • platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/css: Removed.
  • platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css: Removed.
  • platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
  • platform/chromium/svg/filters: Removed.
  • platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.txt: Added.
10:35 Changeset [96474] by abarth@webkit.org
  • 3 edits in trunk/Tools

Clean up obsolete code in gardeningserver.py related to
STATIC_FILE_NAMES. Rather than serve the UI via the Python HTTP
server, we just serve it off the filesystem directly.

We had planned to serve the UI off build.webkit.org, but that server is
somewhat slow. We'll probably serve the UI of some web server, but
we'll need to work that out later.

  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:18 Changeset [96473] by abarth@webkit.org
  • 10 edits in trunk/Tools

Rip out half-backed garden-o-matic features in preparation for wider use
https://bugs.webkit.org/show_bug.cgi?id=69226

This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features. We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting. We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
08:25 Changeset [96472] by abarth@webkit.org
  • 14 edits
    22 adds
    10 deletes in trunk/LayoutTests

Update baseline and expectations after http://trac.webkit.org/changeset/96470

  • platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
  • platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-mac/svg/filters/filter-clip-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/css: Added.
  • platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-win-xp/svg/css: Added.
  • platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
  • platform/chromium/svg/filters: Added.
  • platform/chromium/svg/filters/filter-clip-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
  • platform/mac/svg/filters/filter-clip-expected.txt: Removed.
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
  • platform/qt/svg/filters/filter-clip-expected.txt: Removed.
  • svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • svg/custom/mask-with-all-units-expected.txt: Added.
  • svg/filters/filter-clip-expected.txt: Added.
01:25 Changeset [96471] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
https://bugs.webkit.org/show_bug.cgi?id=68760

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/invalid-lengths.html

Made length-comparison media queries accept only length values. In compatibility mode, numbers
are allowed as well, and they are interpreted as pixels.

  • css/MediaQueryEvaluator.cpp:

(WebCore::computeLength): Added this helper function.
(WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
(WebCore::device_widthMediaFeatureEval): Ditto.
(WebCore::heightMediaFeatureEval): Ditto.
(WebCore::widthMediaFeatureEval): Ditto.

LayoutTests:

  • fast/media/invalid-lengths-expected.txt: Added.
  • fast/media/invalid-lengths.html: Added.
00:15 Changeset [96470] by krit@webkit.org
  • 5 edits
    3 adds in trunk

SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
https://bugs.webkit.org/show_bug.cgi?id=69076

Source/WebCore:

Reviewed by Simon Fraser.

SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
is a performance improvement for platforms without native support for linearRGB color space. The
color space transformation can be avoided.

Test: svg/custom/grayscale-gradient-mask-2.svg

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceMasker.h:

LayoutTests:

Reviewed by Simon Fraser.

Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.

  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • svg/custom/grayscale-gradient-mask-2.svg: Added.

10/01/11:

23:49 Changeset [96469] by abarth@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Tweak expectations for leopard some more.

  • platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
21:34 Changeset [96468] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Correct post-build step for WinCairo test runs.
https://bugs.webkit.org/show_bug.cgi?id=69191

Reviewed by Brian Weinstein.

  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional

shell case to handle the CFLite build.

19:21 Changeset [96467] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Fixing draw matrix for composited layers. This
was a regression introduced by:
http://trac.webkit.org/changeset/96454

https://bugs.webkit.org/show_bug.cgi?id=69217

Reviewed by James Robinson.

Tests: compositor test now pass

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:
18:13 Changeset [96466] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Leopard build fix: Updated for Strong<T> changes.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:
  • WebView/WebScriptDebugger.mm:
17:54 Changeset [96465] by ggaren@apple.com
  • 33 edits
    2 adds in trunk/Source

Removed redundant helper functions for allocating Strong handles
https://bugs.webkit.org/show_bug.cgi?id=69218

Reviewed by Sam Weinig.

../JavaScriptCore:

  • heap/Heap.h:

(JSC::Heap::handleHeap):

  • runtime/JSGlobalData.h: Removed these helper functions, since they

just created indirection.

  • heap/StrongInlines.h: Added. Broke out a header for inline functions

to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.

  • API/JSCallbackObjectFunctions.h:

(JSC::::init):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::setSingleTransition):

  • heap/Local.h:

(JSC::::Local):

  • heap/Strong.h:

(JSC::::Strong):
(JSC::::set):

  • heap/Weak.h:

(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.

  • bytecompiler/BytecodeGenerator.cpp:
  • runtime/JSGlobalData.cpp:
  • runtime/LiteralParser.cpp:
  • runtime/RegExpCache.cpp: Updated for header changes.

../JavaScriptGlue:

  • JSRun.cpp:
  • JSValueWrapper.cpp:

../WebCore:

  • ForwardingHeaders/heap/StrongInlines.h: Added.
  • bindings/js/JSCallbackData.h:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptCachedFrameData.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/runtime_root.cpp:

../WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
15:08 Changeset [96464] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Added myself to reviewers, because I'm now a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
15:03 Changeset [96463] by fpizlo@apple.com
  • 11 edits
    2 adds in trunk/Source/JavaScriptCore

All of JSC's heuristics should be in one place for easier tuning
https://bugs.webkit.org/show_bug.cgi?id=69201

Reviewed by Oliver Hunt.

This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.

It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.

(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/CodeBlock.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

  • runtime/Heuristics.cpp: Added.

(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h: Added.
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

15:01 WebKit Team edited by fpizlo@apple.com
(diff)
14:58 Changeset [96462] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Bencher script makes it difficult to do automated performance testing
https://bugs.webkit.org/show_bug.cgi?id=69207

Reviewed by Sam Weinig.

This adds two new features:

The ability to disable automatic VM detection, which is flaky if any
profiling features are enabled in jsc.

The ability to compute, and report, a scaled result for all benchmark
suites. It is the geometric mean of three numbers: SunSpider's
arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
It is also possible to turn off all other output from bencher and just
get this number with the --brief option.

  • Scripts/bencher:
14:46 Changeset [96461] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Support string length in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69215

Reviewed by Geoff Garen.

Adds a GetStringLength node to the DFG so that we can support
string.length inline.

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownString):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSString.h:

(JSC::JSString::offsetOfLength):

13:48 Changeset [96460] by weinig@apple.com
  • 2 edits in trunk/Tools

WTR is not successfully changing the NSUserDefaults
https://bugs.webkit.org/show_bug.cgi?id=69204

Reviewed by Dan Bernstein.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):
Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
get our overrides picked up.

12:56 Changeset [96459] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Delete bogus text expectation.

  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
12:21 Changeset [96458] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69205

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-01
Reviewed by Gavin Barraclough.

If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):

10:32 Changeset [96457] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note test as timing out.

  • platform/chromium/test_expectations.txt:
10:29 Changeset [96456] by abarth@webkit.org
  • 3 edits
    5 adds
    2 deletes in trunk/LayoutTests

Update Mac baselines.

  • platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/as-object: Added.
  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Removed.
  • platform/chromium-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
00:22 Changeset [96455] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/Source

Unreviewed, rolling out r96421.
http://trac.webkit.org/changeset/96421
https://bugs.webkit.org/show_bug.cgi?id=69206

It broke Qt-WK2 build (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-01

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.pro:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::setToolTip):

00:04 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the WK2 bot (diff)

09/30/11:

20:15 Changeset [96454] by enne@google.com
  • 28 edits
    1 add in trunk/Source

[chromium] Track separate scroll deltas on the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69034

Reviewed by James Robinson.

Source/WebCore:

Test: new tests in CCLayerTreeHostImplTest/CCLayerTreeHostTest

Track scroll deltas and maximum scrolls on LayerChromium/CCLayerImpl.
The CCLayerImpl tree is now able to adjust these scroll deltas
independent of the main thread. To push them back to the main thread,
CCLayerTreeHostImpl collects them all and then bakes them into the
scroll position during a begin frame and commit call. This allows new
deltas to be collected while the scroll position containing the old
delta and the old scroll position will be overwritten during the next
commit.

Only the main frame is supported right now for pushing this scroll
delta back into the authoritative WebKit source to keep both sides in
sync.

Move tilingTransform() to the impl tree because drawTransform() is now
updated using scroll deltas and so the results from calculating draw
transforms needs to be dynamic so that children are updated properly.

Also, exposed DebugScopedSetImplThread public because it's used in a
few places.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore::LayerChromium::scrollDelta):
(WebCore::LayerChromium::scrollable):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setViewport):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::scrollBy):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::maxScrollPosition):
(WebCore::CCLayerImpl::setMaxScrollPosition):
(WebCore::CCLayerImpl::scrollDelta):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::scrollable):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::tilingTransform):
(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

Source/WebKit/chromium:

Add testing support for scroll deltas on layers.

  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyScrollDelta):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostImplTest.cpp: Added.

(WebCore::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebCore::CCLayerTreeHostImplTest::expectClearedScrollDeltasRecursive):
(WebCore::CCLayerTreeHostImplTest::expectContains):
(WebCore::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::applyScrollDelta):
(WTF::MockLayerTreeHostClient::applyScrollDelta):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::CCLayerTreeHostTestScrollSimple::CCLayerTreeHostTestScrollSimple):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollSimple::afterTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::CCLayerTreeHostTestScrollMultipleRedraw):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::afterTest):

  • tests/TreeSynchronizerTest.cpp:

(WebCore::TEST):

20:12 Changeset [96453] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-09-30 Daniel Bates <dbates@webkit.org>

Attempt to fix the Apple Windows and WinCairo Debug builds after
<http://trac.webkit.org/changeset/96446> (https://bugs.webkit.org/show_bug.cgi?id=69203).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove the symbol ?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z since the corresponding function, JSValue::toStrictThisObject(), was removed.
20:07 Changeset [96452] by hyatt@apple.com
  • 8 edits
    21 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=69202

[CSS3 Regions] Make positioned objects use the first region as the ICB when it
is their containing block. Make sure static distance computations take into
account the current region as well.

Reviewed by Sam Weinig.

Source/WebCore:

Added new tests in fast/regions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::startOffsetForContent):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::computeLogicalTopPositionedOffset):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):

  • rendering/RenderFlowThread.h:

LayoutTests:

  • fast/regions/positioned-objects-block-static-in-regions.html: Added.
  • fast/regions/positioned-objects-block-static-in-rtl-regions.html: Added.
  • fast/regions/positioned-objects-in-regions.html: Added.
  • fast/regions/positioned-objects-in-rtl-regions.html: Added.
  • fast/regions/positioned-objects-inline-static-in-regions.html: Added.
  • fast/regions/positioned-objects-inline-static-in-rtl-regions.html: Added.
  • fast/regions/positioned-objects-perpendicular-flows-in-regions.html: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Added.
19:14 Changeset [96451] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG operation results are not set correctly in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69126

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
Reviewed by Gavin Barraclough.

The setupResults routine has the bug of reversing the source and destination.
Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::setupTwoStubArgs):
(JSC::DFG::setupResults):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

19:12 Changeset [96450] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

Adding unit tests for LayerChromium. Emphasis on verifying
behavior of notifySyncRequired callback and tree manipulations.
https://bugs.webkit.org/show_bug.cgi?id=68572

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-30
Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/LayerChromiumTest.cpp: Added.
18:43 Changeset [96449] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Implement currentColor support for CSS gradients
https://bugs.webkit.org/show_bug.cgi?id=58730

Patch by David Barr <davidbarr@chromium.org> on 2011-09-30
Reviewed by Adam Barth.

Source/WebCore:

Allow currentColor as a CSS3 gradient color-stop.

Test: fast/css/linear-gradient-currentcolor.html

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::isCacheable): Make currentColor uncacheable since the
background image may be invalidated if currentColor is used as a gradient stop and
the value of the 'color' property changes.

  • css/CSSParser.cpp:

(WebCore::parseGradientColorOrKeyword): Accept the currentColor keyword.

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::image): Initialize document styleSelector so that
currentColor may be computed for a StyleGeneratedImage.

LayoutTests:

  • fast/css/linear-gradient-currentcolor-expected.txt: Added.
  • fast/css/linear-gradient-currentcolor.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/linear-gradient-currentcolor-expected.png: Added.
18:40 Changeset [96448] by dbates@webkit.org
  • 3 edits in trunk/Tools

Cleanup: Extract code to launch a Mac WebKit application into a common function
https://bugs.webkit.org/show_bug.cgi?id=68662

Reviewed by Adam Roben.

Extracts common code to launch a WebKit application on Mac OS X into a function
so that we can remove duplicate code.

  • Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
  • Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.

(runMacWebKitApp): Added.
(runSafari): Modified to use webkitdirs::runMacWebKitApp().
(runMiniBrowser): Ditto.
(runWebKitTestRunner): Ditto.
(runTestWebKitAPI): Ditto.

18:37 Changeset [96447] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Update baseline for this test on Leopard.

  • platform/chromium-cg-mac-leopard/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
18:29 Changeset [96446] by barraclough@apple.com
  • 14 edits in trunk/Source

Remove toStrictThisObject, toThisString, toThisJSString
https://bugs.webkit.org/show_bug.cgi?id=69203

Rubber stamped by Sam Weinig

These are no longer used.

../JavaScriptCore:

  • JavaScriptCore.exp:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSValue.h:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StrictEvalActivation.h:

../WebCore:

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
18:17 Changeset [96445] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove ASSERT introduced in http://trac.webkit.org/changeset/96427
which is triggering all over the place.

Sorting this out is covered in this bug:
https://bugs.webkit.org/show_bug.cgi?id=69200

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

18:08 Changeset [96444] by levin@chromium.org
  • 9 edits
    4 adds in trunk/Tools

watchlist: Add webkit-patch command to run watchlist.
https://bugs.webkit.org/show_bug.cgi?id=68973

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/host.py: Exposed the watch_list.
  • Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return

the cc and messages as sorted lists. To allow for deterministic ordering.

  • Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
  • Scripts/webkitpy/tool/commands/init.py: Add ApplyWatchListLocal so

that it will be exposed as a command by webkit-patch.

  • Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
  • Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
  • Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
  • Scripts/webkitpy/tool/steps/init.py: Added ApplyWatchList.
  • Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
  • Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
17:58 Changeset [96443] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG does not speculate aggressively enough on put_by_id
https://bugs.webkit.org/show_bug.cgi?id=69114

Reviewed by Oliver Hunt.

This adds new nodes along with optimizations for those nodes:

GetPropertyStorage: CheckStructure used to do both the structure
check and retrieve the storage pointer. Now CheckStructure just
checks the structure, and GetPropertyStorage retrieves the
storage pointer.

PutStructure: Changes the structure, and has the expected store
to load optimization with CheckStructure.

PutByOffset: Directly sets the value. Has store to load
optimization with GetByOffset.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::writeBarrier):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasStorageAccessData):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::impureCSE):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:46 Changeset [96442] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r96426.
http://trac.webkit.org/changeset/96426
https://bugs.webkit.org/show_bug.cgi?id=69199

Broke a zillion image results on Chromium Skia Mac (Requested
by abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-30

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

17:39 Changeset [96441] by levin@chromium.org
  • 4 edits
    2 adds in trunk/Tools

watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
https://bugs.webkit.org/show_bug.cgi?id=69031

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,

a comment to explain something important about the email addresses, and
a comment to let emacs know to treat the file as a python file.

  • Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.

Detects increases or decreases in a pattern.

  • Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
  • Scripts/webkitpy/common/watchlist/watchlist_unittest.py:

Added unit tests for watchlist which has "more" or "less".

  • Scripts/webkitpy/common/watchlist/watchlistparser.py:

Added support for "more" or "less".

17:25 Changeset [96440] by isherman@chromium.org
  • 3 edits
    2 adds in trunk

Fix assertion failure in XSS Auditor
https://bugs.webkit.org/show_bug.cgi?id=69050
https://code.google.com/p/chromium/issues/detail?id=97346

Reviewed by Daniel Bates.

Source/WebCore:

Test: fast/forms/xss-auditor-doesnt-crash.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init): Don't try to decode the HTML body if it is empty.

LayoutTests:

  • fast/forms/xss-auditor-doesnt-crash-expected.txt: Added.
  • fast/forms/xss-auditor-doesnt-crash.html: Added.
17:16 Changeset [96439] by weinig@apple.com
  • 15 edits in trunk

Add support for eventSender.mouseScrollBy in WTR
https://bugs.webkit.org/show_bug.cgi?id=69189

Source/WebKit2:

Reviewed by Simon Fraser.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleWheelEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::wheelEventSyncForTesting):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add sync version of wheel event handling for use in testing.

Tools:

Add implementation of eventSender.mouseScrollBy for the mac.

Reviewed by Simon Fraser.

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::mouseScrollBy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseScrollBy):

LayoutTests:

Reviewed by Simon Fraser.

  • platform/mac-wk2/Skipped:

Removes tests that used eventSender.mouseScrollBy.

16:54 Changeset [96438] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

StringRecursionChecker should not work in terms of EncodedJSValue
https://bugs.webkit.org/show_bug.cgi?id=69188

Reviewed by Oliver Hunt.

0 is not the empty value on 32_64.
Code that casts literals to EncodedJSValues may be unsafe if we change our internal representation.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/StringRecursionChecker.cpp:

(JSC::StringRecursionChecker::throwStackOverflowError):
(JSC::StringRecursionChecker::emptyString):

  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):
(JSC::StringRecursionChecker::earlyReturnValue):

16:30 Changeset [96437] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

Loading page on potterybankids causes reproducible assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69185
<rdar://problem/10218241>

Reviewed by Simon Fraser.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeRepaintRects): Remove assert condition that isn't guaranteed
to be true.

16:05 Changeset [96436] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT, Branch on integer can always be a 32-bit compare.
https://bugs.webkit.org/show_bug.cgi?id=69174

Reviewed by Sam Weinig.

if (shouldSpeculateInteger(node.child1()) && !isStrictInt32(node.child1())),
the JSVALUE64 JIT will currently compare all 64bits in the register, but in
these cases the DataFormat is always a JS boxed integer. In these cases we
can just compare the low 32bits anyway - no need to check the tag.
This allows the code to be unified with the JSVALUE32_64 JIT.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:01 Changeset [96435] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Add missing include for QMimeData
https://bugs.webkit.org/show_bug.cgi?id=69178

Reviewed by Tor Arne Vestbø.

This was implicitly included by other headers, but due to changes in
Qt5 we need to include explicitly.

  • UIProcess/qt/QtWebPageProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:
15:53 Changeset [96434] by simon.fraser@apple.com
  • 3 edits in trunk/Tools

fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=35273

Reviewed by Dan Bernstein.

There are two types of font issue that can cause layout test failure.
First, the user may have non-standard fonts installed that affect the layout
of some tests. For example, some tests use the MS Gothic font if installed.

Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
which override the system fonts (e.g. a copy of Arial from MS Office). For
some tests, this can affect font metrics or fallback behavior.

This change addresses the first problem only. It limits the set of fonts
available through NSFontManager, by swizzling some methods to return
a list of fonts or font families which only include fonts from a hardcoded
whitelist.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
(drt_NSFontManager_availableFontFamilies):
(drt_NSFontManager_availableFonts):
(swizzleNSFontManagerMethods):
(activateTestingFonts):
(adjustFonts):
(createWebViewAndOffscreenWindow):
(prepareConsistentTestingEnvironment):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::InjectedBundle::platformInitialize):

15:31 Changeset [96433] by jnd@chromium.org
  • 15 edits
    3 adds in trunk

Source/WebCore: Support -webkit-tap-highlight-color when enabling touch events support.
https://bugs.webkit.org/show_bug.cgi?id=48544

Reviewed by Kenneth Rohde Christiansen.

Original code from the iOS WebCore code dump, extracted and modified by tijiang@rim and jnd@chromium.
Supports the new CSS property -webkit-tap-highlight-color on platforms which support touch events.
Platform can override WebCore::RenderTheme::platformTapHighlightColor to use its own platform
specific default tap highlight color. Otherwise RenderTheme::defaultTapHighlightColor will be
used as default tap highlight color.

Test: fast/events/touch/tap-highlight-color.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::tapHighlightColor):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::platformTapHighlightColor):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::initialTapHighlightColor):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::tapHighlightColor):
(WebCore::InheritedFlags::setTapHighlightColor):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: Support -webkit-tap-highlight-color in WebCore when enabling touch events support.
https://bugs.webkit.org/show_bug.cgi?id=48544.

Reviewed by Kenneth Rohde Christiansen.

Add a layout test to get customized tap highlight color set by page author.

  • fast/css/getComputedStyle/computed-style-without-renderer.html:
  • fast/css/getComputedStyle/computed-style.html:
  • fast/events/touch/script-tests/tap-highlight-color.js: Added.

(onTouchStart):
(touchTargets):

  • fast/events/touch/tap-highlight-color-expected.txt: Added.
  • fast/events/touch/tap-highlight-color.html: Added.
  • svg/css/getComputedStyle-basic.xhtml:
15:23 Changeset [96432] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-09-30 Oliver Hunt <oliver@apple.com>

Need a sensible GGC policy

Reviewed by Geoff Garen.

This replaces the existing random collection policy
with a deterministic policy based on nursery size.

  • heap/AllocationSpace.cpp: (JSC::AllocationSpace::allocateSlowCase):
  • heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots): (JSC::Heap::collect):
  • heap/Heap.h:
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::resetAllocator):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::nurseryWaterMark): (JSC::MarkedSpace::allocate):
15:12 Changeset [96431] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=69173

RTL/LTR mixtures still not correct in regions. Simplify the loop once I realized it's only
your directionality that matters and not your containing block's.

Reviewed by Dan Bernstein.

Source/WebCore:

Added new test in fast/regions.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):

LayoutTests:

  • fast/regions/multiple-directionality-changes-in-variable-width-regions.html: Added.
  • platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
15:00 Changeset [96430] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed
https://bugs.webkit.org/show_bug.cgi?id=69169

Patch by James Robinson <jamesr@chromium.org> on 2011-09-30
Reviewed by Darin Fisher.

If the compositor does not process the input event the embedder might want to do something with it - for
example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to
open a new tab. This passes that state through the didHandleInputEvent callback.

  • public/WebCompositorClient.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

14:44 Changeset [96429] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG 32-bit support for op_call and op_construct causes
run-javascriptcore-tests to fail
https://bugs.webkit.org/show_bug.cgi?id=69171

Reviewed by Gavin Barraclough.

This fixes one obvious bug that was causing test failures (no
support for dummy slow case for op_add in 32_64), and disables
op_call and op_construct by default.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

14:38 Changeset [96428] by levin@chromium.org
  • 2 edits in trunk/Tools

Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
https://bugs.webkit.org/show_bug.cgi?id=69039

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

Actually skip only one specific test that is failing on Windows.

14:36 Changeset [96427] by mitz@apple.com
  • 4 edits
    3 adds in trunk

<rdar://problem/10208291> first-letter in generated before content with display: table is not updated

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/css-generated-content/first-letter-in-nested-before.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent): Preserve the style type of anonymous
containers around the generated content when updating their style. This preserves the first-letter-ness
of the inline wrapping the first letter, which allows updateFirstLetter() to identify it later.

LayoutTests:

  • fast/css-generated-content/first-letter-in-nested-before-expected.png: Added.
  • fast/css-generated-content/first-letter-in-nested-before-expected.txt: Added.
  • fast/css-generated-content/first-letter-in-nested-before.html: Added.
14:26 Changeset [96426] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956

This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.

Reviewed by Stephen White.

No new tests. This platform is not enabled.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

14:23 Changeset [96425] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r96422.
http://trac.webkit.org/changeset/96422
https://bugs.webkit.org/show_bug.cgi?id=69170

Broke Windows build and kling wanted to roll it out as well
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-30

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::prevOnLineExists):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):

14:15 Changeset [96424] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Crash due to out of bounds read/write in MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=69148

This was a case of being surprised by a poorly aritulcated cell size limit,
plus an incorrect ASSERT guarding the cell size limit.

Reviewed by Oliver Hunt.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::sizeClassFor): Changed heap size ranges to be inclusive,
since it makes the ranges easier to understand.

Bumped up the max cell size to support the use case in this bug. Since the
atomSize is much bigger than it used to be, there isn't much accounting
cost to handling more size classes.

Switched to FixedArray, to help catch SizeClass indexing bugs in the future.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeCellLivenessData): Updated for size ranges
being inclusive.

14:04 Changeset [96423] by hyatt@apple.com
  • 6 edits
    15 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=69167

[CSS3 Regions] Fix some bugs in the computation of the logical left and width offsets
for blocks in variable width regions. Specifically, this patch addresses a minor bug
with overflow:hidden/scroll/auto block placement and with RTL directionality.

Reviewed by Sam Weinig.

Source/WebCore:

Added five new tests in fast/regions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalRightOffsetForContent):
Avoid a double fetch of the border box in a given region by not calling
logicalLeftOffsetForContent. No correctness change here. It's just cleaner.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
Change the shifted optimization to be cached for "self" rather than for "containing block".
Rework the adjustment loop to handle changes in directionality and to fix correctness
issues with RTL.

(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Don't double adjust if an object uses line width as the containing block width. In that
case we already computed the line width in the region, so we don't need to apply any
additional fixup.

(WebCore::RenderBox::renderBoxRegionInfo):

  • rendering/RenderBoxRegionInfo.h:

(WebCore::RenderBoxRegionInfo::RenderBoxRegionInfo):
(WebCore::RenderBoxRegionInfo::isShifted):
Changed the shifted code to be on self rather than on containing block.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
Refactor the layout code for RenderFlowThread to properly set up region rects assuming
right alignment in RTL code. This change forces us to compute our maximum logical width
first before looping through the regions again to set their content rects.

LayoutTests:

  • fast/regions/overflow-in-variable-width-regions.html: Added.
  • fast/regions/overflow-rtl-in-variable-width-regions.html: Added.
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions.html: Added.
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions.html: Added.
  • fast/regions/percentage-margins-rtl-variable-width-regions.html: Added.
  • platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
13:49 Changeset [96422] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
https://bugs.webkit.org/show_bug.cgi?id=64914

Patch by Andreas Kling <kling@webkit.org> on 2011-09-30
Reviewed by Antti Koivisto.

Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
since nobody is using them anymore. nextOnLineExists() is still used by
GTK+ accessibility code.

Also added a compile-time assertion to guard against future bloating of
the InlineBox class.

  • rendering/InlineBox.cpp:

(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):

13:47 Changeset [96421] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162

Use QString::toHtmlEscaped in the Qt5 case.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-09-30
Reviewed by Andreas Kling.

Source/JavaScriptCore:

(escapeHtml):

  • wtf/wtf.pri:

Source/WebCore:

No new tests needed.

  • WebCore.pro: adjust the include path accordingly

in the v8 case.

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::setToolTip):

13:36 Changeset [96420] by abarth@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Update baselines after http://trac.webkit.org/changeset/96404.

  • platform/chromium-cg-mac/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/chromium-cg-mac/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/chromium-linux/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/chromium-mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/chromium-mac/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/chromium-win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/chromium-win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
13:36 Changeset [96419] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix bug in getHostCallReturnValue of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69133

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
Reviewed by Gavin Barraclough.

We need to insert the additional argument in the stack slot before
return address instead of simply pushing it afterwards.
Also getHostCallReturnValue* should be attributed as stdcall
to make the stack cleaned up by the callee.

  • dfg/DFGOperations.cpp:
13:22 Changeset [96418] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] wtf header files are unknown to Qt Creator
https://bugs.webkit.org/show_bug.cgi?id=69158

Adding the HEADERS variable in wtf.pri so that
the header files can be accessed easily.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-09-30
Reviewed by Andreas Kling.

  • wtf/wtf.pri:
13:05 Changeset [96417] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Prevent qDebug() output from DRT and WTR unless --verbose

For DRT we didn't install the message handler early enough to
catch output while constructing the QApplication. For WTR we
didn't even install a message handler.

Since the UI process will forward any output from the web process
we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
in WTR before the web process is started. This is picked up by the
web process which installs its own message handler.

The environment variable can be overriden on the command line if you
want to see output from the web process, or you can pass --verbose to
WTR to see output from both processes.

https://bugs.webkit.org/show_bug.cgi?id=69132

Reviewed by Andreas Kling.

13:04 Changeset [96416] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Make sure WTR sizes the window and item correctly

Revision 96345 changed the logic for how the view and
window was created, but missed a vital part, setting
the size.

We now use a QSGView for the window, that has a simple
item as its root object that is always resized to fit
within the window. The webview is then parented to the
root object and set to anchors.fill: parent. That way
any window geometry changes will propagate to the web
view.

https://bugs.webkit.org/show_bug.cgi?id=69134

Reviewed by Andreas Kling.

13:01 Changeset [96415] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Merge some more of DFGSpeculativeJIT 32_64/64
https://bugs.webkit.org/show_bug.cgi?id=69164

Reviewed by Oliver Hunt.

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCodeGenerator32_64.cpp:
  • dfg/DFGJITCodeGenerator64.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

12:34 Changeset [96414] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Only save the current viewport in PixelDumpSupportEfl.
https://bugs.webkit.org/show_bug.cgi?id=68450

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-30
Reviewed by Antonio Gomes.

The previous implementation saved the whole page contents in the final
PNG, however the baselines and expectations in the tree only want the
current viewport (with a scrollbar, if needed), so we now only save the
currently visible contents.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView): Use
ewk_frame_visible_content_geometry_get instead of
ewk_frame_contents_size_get.

12:11 Changeset [96413] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Remove didCompleteRubberBandForMainFrame UIClient callback
https://bugs.webkit.org/show_bug.cgi?id=69161

Reviewed by Adam Roben.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didCompleteRubberBandForFrame):

12:05 Changeset [96412] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

webkit->chromium DEPS roll 102910->103471
https://bugs.webkit.org/show_bug.cgi?id=69160

Patch by Elliot Poger <epoger@google.com> on 2011-09-30
Reviewed by Adam Barth.

  • DEPS:
11:44 Changeset [96411] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Support and keep track of extra windows (views).
https://bugs.webkit.org/show_bug.cgi?id=68454

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-30
Reviewed by Antonio Gomes.

So far, window.open and related JavaScript code would not work, as
DRTView did not implementation
Ewk_View_Smart_Class::window_{open,close}. The default implementation
in ewk just returns the current window/view, which broke any
layouttest which relied on window.open.

We now properly create and remove these new views. Unfortunately, the
current way ewk works (and due to the fact that we cannot pass class
methods as function pointers to the EFL functions), DRTView needs to
know that DRTChrome exists and call `browser' directly in some points.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onWindowCreate):
(onWindowCloseDelayed):
(onWindowClose):
(drtViewTiledAdd):

11:28 Changeset [96410] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused ReplaceSelectionCommand::copyStyleToChildren
https://bugs.webkit.org/show_bug.cgi?id=69153

Reviewed by Antonio Gomes.

Removed the function because it's no called anywhere.

  • editing/ReplaceSelectionCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
11:20 Changeset [96409] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix EnabledAtRuntime support for constants.
https://bugs.webkit.org/show_bug.cgi?id=67311

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-09-30
Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

11:18 QtWebKitReleases edited by ademar@webkit.org
(diff)
11:18 Changeset [96408] by hyatt@apple.com
  • 32 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=69043

[CSS3 Regions] Blocks split across regions with variable width need to size
differently in each region.

This patch adds the capability for blocks to have variable width and positioning
when split across regions. It is very rudimentary and so far only operates on basic
normal flow RenderBlocks. Future patches will expand the support to cover other layout
constructs like flexible boxes and tables.

Reviewed by Sam Weinig.

Added new tests in fast/regions and updated existing results.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::region):
(WebCore::HitTestResult::setRegion):
The hit test result now holds the active RenderRegion so that hit testing can adjust
block widths and positions when hit testing their border boxes.

  • rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):
The paint info struct now holds the active RenderRegion so that painting can adjust
block widths and positions when painting borders and backgrounds and shadows.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
If our width ever changes, we invalidate all of our cached RenderBoxRegionInfo in all
regions that we span.

(WebCore::RenderBlock::clearRenderBoxRegionInfo):
Called to clear out our cached region-specific information in all regions that we span.

(WebCore::RenderBlock::borderBoxRectInRegionAtPosition):
Returns the borderBoxRect for the region at the specified vertical offset. This rect
can be both shifted horizontally and have a different width from our original border rect.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Modified to call borderBoxRectInRegionAtPosition so that lines will fit inside
the content rect of the border box rect for the specific region.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForContent):
Modified to call logicalLeftOffsetForContent since it's cleaner.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
Called to compute the border box rect in a specific region. The result is cached in a HashMap
in the region itself so that subsequent lookups are fast.

(WebCore::RenderBox::nodeAtPoint):
Modified to use the border box rect in the active region when hit testing the backgrounds of boxes.

(WebCore::RenderBox::paintBoxDecorations):
Modified to use the border box rect in the active region when painting the backgrounds of boxes.

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInRegion):
Helpers for computing logical widths and margins in a specific region. The result is then cached
in a HashMap in the region.

(WebCore::RenderBox::renderBoxRegionInfo):
The function for obtaining the region-specific information for a given box.

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderBoxRectInRegion):
New function for returning the border box rect in a given region.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Make sure mask painting honors the active region.

  • rendering/RenderBoxRegionInfo.h: Added.

(WebCore::RenderBoxRegionInfo::RenderBoxRegionInfo):
(WebCore::RenderBoxRegionInfo::logicalLeft):
(WebCore::RenderBoxRegionInfo::logicalWidth):
(WebCore::RenderBoxRegionInfo::containingBlockChainIsShifted):
New class held by RenderRegions that caches box-specific info for a given region. This will eventually
expand to include custom styles as well, but for now it is limited to a new logical left and a new
logical width, along with a bit for optimizing accumulated shifting when painting/hit testing to avoid
too much groveling up the containing block chain.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
Removed the region fitting optimization, since eventually everyone is going to care, and there's no reason
to limit it with the results now being cached.

(WebCore::RenderFlowThread::layout):
All box-specific region information is always cleared whenever the regions are invalidated.

(WebCore::RenderFlowThread::computeLogicalWidth):
Modified to set up RenderBoxRegionInfo for the flow thread in all regions.

(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
Modified to take the region instead of the region's rectangle so that painting and hit testing of the flow
thread layer tree can properly receive the active region.

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Helper for removing a box's information from all regions. For now it grovels through every region, so eventually
we may want to have a cache of the start/end regions for a given box somewhere.

  • rendering/RenderFlowThread.h:

Removal of the region fitting stuff.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):
Modified to pass the current region down through painting functions so that it is known at paint time.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
Added a new bit to RenderObjects, inRenderFlowThread(), so that it is quick to determine whether or not an
object needs flow thread special casing.

(WebCore::RenderObject::enclosingRenderFlowThread):
Modified enclosingRenderFlowThread to be able to quickly return 0 if the object is not in a flow thread.

(WebCore::RenderObject::containerForRepaint):
Same.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setParent):
setParent now updates inRenderFlowThread() state.

(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::setInRenderFlowThread):
Adding the new bit.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
Make sure when an object is removed from a RenderFlowThread that it deletes its box-specific information
in all regions.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo):
(WebCore::RenderRegion::matchesRenderFlowThreadLogicalWidth):

  • rendering/RenderRegion.h:

Added the new HashMap for holding box-specific region information. Also added an additional optimization to
check if a specific region matches the overall width of the RenderFlowThread. If it does, we don't need to
cache box-specific information for that region.

  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
Modified the PaintInfo construction to include the region argument. It's not optional so that callers will
have to consider it (since masks illustrated this is necessary).

LayoutTests:

  • fast/regions/percentage-margins-variable-width-regions.html: Added.
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
  • platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
  • platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png:
11:14 QtWebKitReleases edited by ademar@webkit.org
(diff)
11:09 Changeset [96407] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

feBlend uses a table of function pointers which reduces inlineability inside the main loop
https://bugs.webkit.org/show_bug.cgi?id=69154
<rdar://problem/10215221>

Reviewed by Darin Adler.

Don't use a table of function pointers inside the feBlend inner loop, instead
use switch and inline functions, bringing a 20% performance gain across the
board to feBlend.

No new tests, minor performance improvement.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::normal):
(WebCore::multiply):
(WebCore::screen):
(WebCore::darken):
(WebCore::lighten):
(WebCore::FEBlend::apply):

10:59 Changeset [96406] by mhahnenberg@apple.com
  • 7 edits in trunk/Source

Add getCallData to MethodTable in ClassInfo
https://bugs.webkit.org/show_bug.cgi?id=69024

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added the getCallData to the MethodTable in the ClassInfo struct.

  • runtime/ClassInfo.h:

Source/WebCore:

No new tests.

  • WebCore.exp.in:

Changed getCallData from private to protected to allow subclasses who
don't override getCallData themselves to reference it in their own
method tables when calling the CREATE_METHOD_TABLE macro.

  • bridge/runtime_method.h:
10:26 Changeset [96405] by qi.2.zhang@nokia.com
  • 14 edits
    1 delete in trunk

WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
https://bugs.webkit.org/show_bug.cgi?id=42698

Reviewed by Andreas Kling.

Source/WebKit2:

Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
and call clearApplicationCache when layoutTest start up.

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearApplicationCache):
(WKBundleSetAppCacheMaximumSize):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearApplicationCache):
(WebKit::InjectedBundle::setAppCacheMaximumSize):

  • WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
and call clearApplicationCache when layoutTest start up.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::clearAllApplicationCaches):
(WTR::LayoutTestController::setAppCacheMaximumSize):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Removed http/tests/appcache/max-size.html from skipped list, and also the "failed" expected file for http/tests/appcache/interrupted-update-expected.html

  • platform/mac-wk2/http/tests/appcache: Removed.
  • platform/mac-wk2/http/tests/appcache/interrupted-update-expected.txt: Removed.
  • platform/wk2/Skipped:
10:05 Changeset [96404] by mitz@apple.com
  • 6 edits
    3 adds in trunk

Complex spaces with synthetic bold are too wide
https://bugs.webkit.org/show_bug.cgi?id=69033

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-30
Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/complex-synthetic-bold-space-width.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Subtract synthetic bold offset from spaceWidth.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem): Ditto.

LayoutTests:

  • fast/text/complex-synthetic-bold-space-width.html: Added.
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/mac/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
10:00 Changeset [96403] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests: Rewrite fast/dom/HTMLInputElement/input-size-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=69130

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-30
Reviewed by Alexey Proskuryakov.

  • fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
  • fast/dom/HTMLInputElement/input-size-attribute.html:
07:54 Changeset [96402] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=69145

This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
and is perfectly suitable for SceneGraph as well. GraphicsScene events
will not be available in QtGui anymore in future. Therefore we also have to change
QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-30
Reviewed by Chang Shu.

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::createMouseEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):

07:44 Changeset [96401] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Replace textInputController.doCommand with eventSender.keyDown in password-echo tests
https://bugs.webkit.org/show_bug.cgi?id=69143

textInputController.doCommand is not supported very well across the platforms. Replace it
with eventSender.keyDown would make the tests pass on more platforms and potentially WK2.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-30
Reviewed by Antonio Gomes.

  • editing/input/resources/password-echo.js:

(init):

07:23 Changeset [96400] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

[UNIX] Add a method to get information for an already loaded plugin module
https://bugs.webkit.org/show_bug.cgi?id=69139

Reviewed by Martin Robinson.

  • Shared/Plugins/Netscape/NetscapePluginModule.h: Add pluginInfo().
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::pluginInfo): Private method to get
the plugin information from the module, it must be called when the
module has been already initialized.
(WebKit::NetscapePluginModule::getPluginInfo): Use pluginInfo() to
get information of the plugin module for the given path.

04:58 Changeset [96399] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

[Qt][WK2] Event delivery in QDesktopWebView is broken after merge of Qt5 refactor
https://bugs.webkit.org/show_bug.cgi?id=69105

This changes QDesktopWebView and QDesktopWebPageProxy to use QMouseEvent instead
of QGraphicsSceneMouseEvent.
Further it removes an endless loop introduced by the QSGItem::event() function
delivering inputMethodEvents but no other events.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-30
Reviewed by Andreas Kling.

  • Shared/NativeWebMouseEvent.h:

(WebKit::NativeWebMouseEvent::nativeEvent):

  • Shared/NativeWebWheelEvent.h:

(WebKit::NativeWebWheelEvent::nativeEvent):

  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::mouseButtonForEvent):
(WebKit::webEventTypeForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):
(QDesktopWebView::mouseMoveEvent):
(QDesktopWebView::mouseReleaseEvent):
(QDesktopWebView::mouseDoubleClickEvent):
(QDesktopWebView::wheelEvent):
(QDesktopWebView::event):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleMouseMoveEvent):
(QDesktopWebPageProxy::handleMousePressEvent):
(QDesktopWebPageProxy::handleMouseReleaseEvent):
(QDesktopWebPageProxy::handleMouseDoubleClickEvent):
(QDesktopWebPageProxy::handleWheelEvent):
(QDesktopWebPageProxy::handleHoverMoveEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
03:44 Changeset [96398] by pfeldman@chromium.org
  • 12 edits
    2 moves in trunk/Source

Web Inspector: [chromium] expose inspector protocol version to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=69092

Source/WebCore:

This change also introduces major/minor inspector version components.

Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • inspector/Inspector-0.1.json: Renamed from Source/WebCore/inspector/Inspector.draft-01.json.
  • inspector/Inspector.json:
  • inspector/generate-inspector-protocol-version: Renamed from Source/WebCore/inspector/validate-protocol-compatibility.

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::inspectorProtocolVersion):
(WebKit::WebDevToolsAgent::supportsInspectorProtocolVersion):

01:07 Changeset [96397] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=54322

Unreviewed test_expectations.txt update. acid3 seems to be IMAGE+TEXT, not IMAGE

  • platform/chromium/test_expectations.txt:
01:00 Changeset [96396] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/frames/frame-set-rotation-hit.html and fast/frames/frame-set-scaling-hit.html are failing
https://bugs.webkit.org/show_bug.cgi?id=69136

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
00:14 Changeset [96395] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

00:12 Changeset [96394] by mrowe@apple.com
  • 1 copy in tags/Safari-535.5

New tag.

00:07 Changeset [96393] by antti@apple.com
  • 7 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=69106
Universal attribute selectors disable style sharing

Reviewed by Dave Hyatt.

Selectors of type [foo="bar"] ended up marking every element style with the affectedByAttributeSelectors bit
rendering style sharing inoperative. This happens on http://www.whatwg.org/specs/web-apps/current-work/ for example.

Instead we now mark style with affectedByUncommonAttributeSelectors bit only if an attribute selector actually
matches the element. Before sharing, we also check the current element against collected attribute rules.
We can share the style if neither element was affected.

This speeds up style matching and applying ~15% on full HTML5 spec (=~0.7s). Sharing percentage goes from 0% to ~30%.
Increased sharing should also save a substantial amount of memory.

  • css/CSSSelector.h:

(WebCore::CSSSelector::isAttributeSelector):

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::collectSpecialRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::selectorListContainsUncommonAttributeSelector):
(WebCore::isCommonAttributeSelectorAttribute):
(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):

  • css/CSSStyleSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::affectedByUncommonAttributeSelectors):
(WebCore::InheritedFlags::setAffectedByUncommonAttributeSelectors):

00:05 Changeset [96392] by jamesr@google.com
  • 17 edits
    3 copies
    1 add in trunk

[chromium] Add WebKit API for sending input events to the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69117

Reviewed by Darin Fisher.

Source/WebCore:

Convert to using an externally-provided thread instead of one managed by CCThreadProxy internally. Most changes
in these files are mechanically changing references from ccThread to s_ccThread to reflect the class-static
nature of this pointer, the rest are removing the old thread creation codepath.

These changes are covered by the CC* unit tests and by the gpu layout tests when run with the
use_threaded_compositing=1 gyp define.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setThread):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Adds a new WebKit interface to allow the embedder to pass input events directly to the compositor thread.
Exposes the new WebCompositor interface and associated client. These interfaces are slightly different in that
they can only be interacted with from the compositor thread.

Changes the initialization path for the compositor thread to using an externally allocated and managed thread
instead of one internal to WebCore so that the embedder can interact with the thread more easily. This also
simplifies the startup and shutdown paths. The contract is that WebCompositor::setThread() must be called
before any compositor can be initialized and the passed-in thread must outlive all compositor instances.

Each WebCompositor instance is associated with a WebWidget. There isn't any way to get a WebCompositor for a
given WebWidget in this patch, that will be done in a follow-up.

  • WebKit.gyp:
  • public/WebCompositor.h:

(WebKit::WebCompositor::~WebCompositor):

  • public/WebCompositorClient.h:

(WebKit::WebCompositorClient::~WebCompositorClient):

  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::CCThreadImpl):

  • src/CCThreadImpl.h:
  • src/WebCompositorImpl.cpp: Added.

(WebKit::WebCompositor::setThread):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):

  • src/WebCompositorImpl.h:

(WebKit::WebCompositorImpl::create):

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):

  • tests/CCThreadTest.cpp:

(WebKit::TEST):

Tools:

Adds support for creating and setting a compositor thread in DRT.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::WebViewHost):

  • DumpRenderTree/chromium/WebViewHost.h:

09/29/11:

23:17 Changeset [96391] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Add op_call/op_constructor support to JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69120

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

Improve the coverage of JSVALUE32_64 DFG JIT.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::tagOfCallData):
(JSC::DFG::payloadOfCallData):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

22:22 Changeset [96390] by levin@chromium.org
  • 6 edits in trunk/Tools

watchlist: Add cross-checks for WatchList once it is filled.
https://bugs.webkit.org/show_bug.cgi?id=68975

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public

instead of having trivial getter and setters.

  • Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to

pass the validation checks.

  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks

and fix a few style nits.

  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the

validation checks.

  • Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
22:15 Changeset [96389] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT - register not unlocked after usage in ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=69122

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Geoffrey Garen.

Some allocated register is not unlocked after the usage in ArithDiv.
Also there's a typo in "ENBALE_DFG_CONSISTENTCY_CHECK".

  • dfg/DFGNode.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

22:05 Changeset [96388] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-api-tests fails on chromium-win bot
https://bugs.webkit.org/show_bug.cgi?id=69121

On Windows running a perl script needs the interpreter.

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-29
Reviewed by Adam Barth.

  • Scripts/run-api-tests:

(buildTestTool):

22:04 Changeset [96387] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test platform/chromium/compositing/3d-corners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69124

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
21:58 Changeset [96386] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

fast/text/line-initial-and-final-swashes.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=69103

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
21:44 Changeset [96385] by fsamuel@chromium.org
  • 3 edits
    6 adds in trunk

Fixed Hit testing on Framesets when Frameset is transformed
https://bugs.webkit.org/show_bug.cgi?id=67740

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/frames/frame-set-rotation-hit.html

fast/frames/frame-set-scaling-hit.html

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::userResize):

LayoutTests:

  • fast/frames/frame-set-rotation-hit-expected.png: Added.
  • fast/frames/frame-set-rotation-hit-expected.txt: Added.
  • fast/frames/frame-set-rotation-hit.html: Added.
  • fast/frames/frame-set-scaling-hit-expected.png: Added.
  • fast/frames/frame-set-scaling-hit-expected.txt: Added.
  • fast/frames/frame-set-scaling-hit.html: Added.
21:11 Changeset [96384] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

fix gyp warnings in chromium for renamed files
https://bugs.webkit.org/show_bug.cgi?id=69116

Reviewed by Adam Barth.

  • WebCore.gypi:
19:30 Changeset [96383] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize the native window handles of GTK.

  • UIProcess/WebInspectorProxy.h: Add native window handle for inspector window.
  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::inspectorFilesBasePath): Base folder for inspector resources.
(WebKit::inspectorWindowDestroyed): Invoked when inspector window is closed by user.
(WebKit::WebInspectorProxy::windowDestroyed): Resets the native handles to 0 when user closes the window.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the WebView for inspector.
(WebKit::WebInspectorProxy::platformOpen): Create the window for inspector.
(WebKit::WebInspectorProxy::platformDidClose): Close both WebView & window of inspector.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Update the title of inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL): Return the absolute URL of inspector.html.
(WebKit::WebInspectorProxy::inspectorBaseURL): Return the location where inspector resources are present.
WebProcess is given read access to this folder only for loading file URLs by sandboxed extension.

19:18 Changeset [96382] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source/WebKit/efl

[EFL] Use C++ type cast instead of C style type cast
https://bugs.webkit.org/show_bug.cgi?id=68321

Reviewed by Martin Robinson.

This is a second step in order to be more compliant with WebKit coding style.
The second step is to change C-type casting with C++-type casting in .cpp files.

In addition, remained efl style '*' pointer placements are moved to the right place as well.

  • ewk/ewk_auth_soup.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
19:09 Changeset [96381] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::toObject
https://bugs.webkit.org/show_bug.cgi?id=68937

Reviewed by Darin Adler.

De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.

  • runtime/JSCell.cpp:

(JSC::JSCell::toObject):

  • runtime/JSCell.h:

Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.

  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:

De-virtualized JSObject::toObject and JSString::toObject.

  • runtime/JSString.h:
17:13 Changeset [96380] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

These tests can also time out.

  • platform/chromium/test_expectations.txt:
17:09 Changeset [96379] by barraclough@apple.com
  • 5 edits
    1 copy in trunk/Source/JavaScriptCore

Start refactoring DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=69112

Reviewed by Oliver Hunt.

Again, move JSVALUE64 code into a DFJSpeculativeJIT64.cpp

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT64.cpp: Copied from Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp.

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

16:47 Changeset [96378] by mrobinson@webkit.org
  • 5 edits
    3 adds in trunk

[Freetype] Some text in Planet GNOME renders in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=69099

Reviewed by Dirk Schulze.

Source/WebCore:

Test: platform/gtk/fonts/synthetic-oblique-positioning.html

Fold the oblique transform into the font matrix itself rather than transforming
the CTM of the context at render time. Not only does this fix the issue, it
prevents unnecessary work on every paint.

  • platform/graphics/cairo/FontCairo.cpp:

No longer set the synthetic oblique transformation matrix on the context
when rendering the text. Instead it is now folded into the TM of the font
itself.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::initializeWithFontFace): Fold the oblique transform into the scaled font.

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Ditto.

LayoutTests:

Add a test which exercises this issue. It seems the problem grows worse
as the y component of the text position increases, so position the text
about halfway down the page.

  • platform/gtk/fonts/synthetic-oblique-positioning-expected.png: Added.
  • platform/gtk/fonts/synthetic-oblique-positioning-expected.txt: Added.
  • platform/gtk/fonts/synthetic-oblique-positioning.html: Added.
16:29 Changeset [96377] by barraclough@apple.com
  • 6 edits
    1 copy in trunk/Source/JavaScriptCore

Refactor out trivially duplicated code in DFGJITCodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=69109

Reviewed by Oliver Hunt.

Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp

Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code
in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp.

For some function differences are trivial & make more sense to ifdef individually, and some
Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGJITCodeGenerator32_64.cpp:
  • dfg/DFGJITCodeGenerator64.cpp: Copied from Source/JavaScriptCore/dfg/DFGJITCodeGenerator.cpp.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchIfNotCell):

  • dfg/DFGJITCompilerInlineMethods.h:
16:21 Changeset [96376] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

Update image baselines after http://trac.webkit.org/changeset/96366. These are progressions.

  • platform/chromium-mac/fast/css/font-smoothing-expected.png:
  • platform/chromium-mac/fast/repaint/text-emphasis-v-expected.png:
  • platform/chromium-mac/fast/text/emphasis-avoid-ruby-expected.png:
  • platform/chromium-mac/fast/text/emphasis-overlap-expected.png:
  • platform/chromium-mac/fast/text/soft-hyphen-4-expected.png:
16:17 Changeset [96375] by fpizlo@apple.com
  • 19 edits
    3 adds in trunk/Source/JavaScriptCore

DFG JIT should infer which uses of a variable are not aliased
https://bugs.webkit.org/show_bug.cgi?id=68593

Reviewed by Oliver Hunt.

This separates how a variable is stored (i.e. its virtual register)
from how it's predicted. Each variable now takes a
VariableAccessData as its operand, instead of the virtual register.
The VariableAccessData stores the operand and the prediction. If
multiple uses of a variable are aliased, their VariableAccessDatas
are unified.

This also adds tracking of which argument values are used. It
correctly observes that an argument value is not used, if the
argument is assigned to inside the function before being used.

This also adds tracking of which variables are live at the head of
a basic block, and separates that from a variable being live at the
tail.

Finally, this communicates to both OSR entry and OSR exit code how
a variable is predicted at a particular point in the code, rather
than just communicating how it was predicted in the entire code
block (since with this patch there is no longer the notion of a
variable having just one prediction for a code block).

(JSC::actionablePredictionFromPredictedType):
(JSC::valueObeysPrediction):
(JSC::actionablePredictionToString):
(JSC::ActionablePredictions::ActionablePredictions):
(JSC::ActionablePredictions::setArgument):
(JSC::ActionablePredictions::argument):
(JSC::ActionablePredictions::setVariable):
(JSC::ActionablePredictions::variable):
(JSC::ActionablePredictions::argumentUpperBound):
(JSC::ActionablePredictions::variableUpperBound):
(JSC::ActionablePredictions::pack):
(JSC::ActionablePredictions::packVector):

  • bytecode/CodeBlock.h:
  • bytecode/PredictionTracker.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::nameOfVariableAccessData):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::operandIsArgument):
(JSC::DFG::VariableRecord::setFirstTime):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::local):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueSource::nodeIndexFromKind):
(JSC::DFG::ValueSource::kindFromNodeIndex):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • wtf/PackedIntVector.h: Added.

(WTF::PackedIntVector::PackedIntVector):
(WTF::PackedIntVector::operator=):
(WTF::PackedIntVector::size):
(WTF::PackedIntVector::ensureSize):
(WTF::PackedIntVector::resize):
(WTF::PackedIntVector::clearAll):
(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):
(WTF::PackedIntVector::mask):

  • wtf/Platform.h:
  • wtf/UnionFind.h: Added.

(WTF::UnionFind::UnionFind):
(WTF::UnionFind::find):
(WTF::UnionFind::unify):

16:12 Changeset [96374] by mitz@apple.com
  • 6 edits in trunk

Follow-up fix for <rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Check for Hoefler Text Black Italic as well.

LayoutTests:

Added Hoefler Text Black Italic to the test case.

  • fast/text/line-initial-and-final-swashes.html:
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
16:09 Changeset [96373] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

15:52 Changeset [96372] by oliver@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100

Reviewed by Geoff Garen.

This gives us the ability to walk all the MarkedBlocks in an
AllocationSpace and collect the dirty objects, and then use
them as GC roots.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::markCellCard):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::markCellCard):

  • heap/AllocationSpace.cpp:

Tidy up the write barrier logic a bit

(JSC::MarkedBlock::gatherDirtyObjects):
(JSC::TakeIfDirty::returnValue):
(JSC::TakeIfDirty::TakeIfDirty):
(JSC::TakeIfDirty::operator()):
(JSC::AllocationSpace::gatherDirtyObjects):

  • heap/AllocationSpace.h:
  • heap/CardSet.h:

(JSC::::isCardMarked):
(JSC::::clearCard):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):

  • heap/SlotVisitor.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

Tidy the write barrier a bit

15:42 Changeset [96371] by inferno@chromium.org
  • 3 edits
    3 copies in branches/chromium/874

Merge 96151 - Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
BUG=98161
Review URL: http://codereview.chromium.org/8082012

15:39 Changeset [96370] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 96341 - We should ignore the return value of GetRealNamedProperty
BUG=96885
Review URL: http://codereview.chromium.org/8090001

15:35 Changeset [96369] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/874

Merge 96294 - <rdar://problem/10196497> first-letter after list marker not updated correctly
BUG=98064
Review URL: http://codereview.chromium.org/8085012

15:33 Changeset [96368] by inferno@chromium.org
  • 3 edits
    3 copies in branches/chromium/874

Merge 96260 - JavaScript generated documents don't inherit the cookie URL
BUG=98407
Review URL: http://codereview.chromium.org/8083016

15:25 Changeset [96367] by abarth@webkit.org
  • 2 edits in trunk/Tools

Attempt to make this tool work on Windows.

  • Scripts/run-api-tests:

(buildTestTool):

15:21 Changeset [96366] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Enable LCD text in Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=68734

Reviewed by Stephen White.

No new tests. Existing layout tests are generated
with LCD text disabled for pixel comparisons.

Duplicate the logic in FontMac.mm to pass settings
for antialiasing and smoothing. Also disable smoothing
for DumpRenderTree.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

15:16 Changeset [96365] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Implement flick gesture in Chromium Gesture Recognizer
https://bugs.webkit.org/show_bug.cgi?id=67930

Reviewed by Dimitri Glazkov.

Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp

  • platform/chromium/GestureRecognizerChromium.cpp: (WebCore::GestureRecognizerChromium::isOverMinFlickSpeed): (WebCore::GestureRecognizerChromium::appendScrollGestureEnd): (WebCore::GestureRecognizerChromium::updateValues): (WebCore::GestureRecognizerChromium::scrollEnd):
  • platform/chromium/GestureRecognizerChromium.h:

Patch by Varun Jain <varunjain@google.com> on 2011-09-29

15:14 Changeset [96364] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] canvas.toDataURL("image/jpeg"): use libjpeg-turbo data swizzle
https://bugs.webkit.org/show_bug.cgi?id=67402

Reviewed by Kenneth Russell.

libjpeg-turbo can read directly from the input data for the premultiplied BRGX
(SkBitmap) encoding case.

No change in behavior, covered by existing canvas 2d/3d tests
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::encodePixels): If JCS_EXTENSIONS is defined (libjpeg-turbo), swizzle
the input BRGX pixels directly within libjpeg-turbo.

15:13 Changeset [96363] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix.

  • assembler/MacroAssemblerCodeRef.h:
  • dfg/DFGOperations.h:
15:02 Changeset [96362] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] API to get plain text of the frame
https://bugs.webkit.org/show_bug.cgi?id=67114

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-29
Reviewed by Ryosuke Niwa.

Add a function to return a frame's contents converted to plain text,
as already exposed by other ports and needed by DRT when dumping a
frame's contents.

  • ewk/ewk_frame.cpp:

(ewk_frame_plain_text_get):

  • ewk/ewk_frame.h:
14:58 Changeset [96361] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test can also time out.

  • platform/chromium/test_expectations.txt:
14:29 Changeset [96360] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Try to fix the minial build

  • QtTestBrowser/launcherwindow.cpp:
  • QtTestBrowser/webpage.cpp:
14:15 Changeset [96359] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Delete bogus expectation.

  • platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.
14:12 Changeset [96358] by abarth@webkit.org
  • 4 edits
    3 adds
    1 delete in trunk/LayoutTests

Attempt to update these image results again.

  • platform/chromium-cg-mac-leopard/http/tests/misc: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt:
  • platform/chromium-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
14:07 Changeset [96357] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixenate the build.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemAdded):

13:51 Changeset [96356] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark test as expected to fail.

  • platform/chromium/test_expectations.txt:
13:50 Changeset [96355] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip all failing tests (10605!) after refactored Qt5.

Rubber-stamped by Tor Arne Vestbø.

  • platform/qt-wk2/Skipped:
13:45 Changeset [96354] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Structure transitions involving many (> 64) properties sometimes cause structure corruption
https://bugs.webkit.org/show_bug.cgi?id=69102

Reviewed by Darin Adler.

Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
don't lead to the dictionary kind being forgotten.

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:
13:31 Changeset [96353] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=69023

Reviewed by Enrica Casucci.

Converted to removeUnrenderedTextNodesAtEnds to use InsertedNodes instead of m_firstNodeInserted
and m_lastLeafInserted. Extracted the logic to update nodes as InsertedNodes::willRemoveNode
(old one was renamed to InsertedNodes::willRemoveNodePreservingChildren).

Also extracted shouldPerformSmartReplace and addSpacesForSmartReplace out of doApply,
and rewrote the logic to obtain endNode and startNode using startOfInsertedContent and
endOfInsertedContent instead of m_firstNodeInserted and m_lastLeafInserted.

Finally, replaced the nullity checks of m_firstNodeInserted and m_lastLeafInserted in
completeHTMLReplacement by nullity checks of start and end positions.

  • dom/Node.cpp:

(WebCore::Node::traversePreviousSibling): Added.

  • dom/Node.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren): Renamed from
willRemoveNode.
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode): Extracted from
removeUnrenderedTextNodesAtEnds.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Takes firstNodeInserted instead of directly
accessing m_firstNodeInserted.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):

  • editing/ReplaceSelectionCommand.h:
13:30 Changeset [96352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Shrink HTMLAnchorElement on 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69094

Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.

  • html/HTMLAnchorElement.h: Pack members into a bitfield.
13:21 Changeset [96351] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/text/line-initial-and-final-swashes.html

Hoefler Text Italic enables line-initial and -final swashes by default, so disable them. This
change targets only this known-bad font rather than all fonts, because at least one font (Khmer MN)
incorrectly claims to have the line-initial feature enabled, but disabling it actually does
something different and bad (breaking some combining marks).

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::createFeatureSettingDictionary): Added this helper function.
(WebCore::cascadeToLastResortFontDescriptor): Deployed WTF_ARRAY_LENGTH().
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor): Added. Returns a font descriptor
that, in addition to having a cascade list consisting of the last resort font, also has feature
settings to disable line-initial and line-final swashes.
(WebCore::FontPlatformData::ctFont): For Hoefler Text Italic, use cascadeToLastResortAndDisableSwashesFontDescriptor().

LayoutTests:

  • fast/text/line-initial-and-final-swashes.html: Added.
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.txt: Added.
13:14 Changeset [96350] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed: resetting baseline for code generator bindings

Unreviewed build fix

No new tests.

  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
12:46 Changeset [96349] by japhet@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8, chromium] More logging to determine cause of a null
v8::Context in V8DOMWindowShell::namedItemAdded().

https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemAdded):

12:40 Changeset [96348] by ap@apple.com
  • 9 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=69040
ScrollbarThemeComposite requires a ScrollView to draw scroll corner

Reviewed by Simon Fraser.

No new tests. This will be needed later.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::pageForScrollView):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):
Use pageForScrollView() function which already existed in this file, used in another similar
location.

  • platform/chromium/FramelessScrollView.cpp:
  • platform/chromium/FramelessScrollView.h:
  • platform/gtk/ScrollbarThemeGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/wx/ScrollbarThemeWx.cpp:
  • platform/wx/ScrollbarThemeWx.h:

All these overrides are no longer needed, ScrollbarThemeComposite will do the right thing.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):

Removed a special case for updatingControlTints phase. The same case is present in cross-platform
code now, and Qt doesn't have any custom subclasses of ScrollableArea or ScrollView to need
special handling.
This was added in r37377 without a bug or much ChangeLog explanation.

12:37 Changeset [96347] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux

  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

12:37 Changeset [96346] by mhahnenberg@apple.com
  • 78 edits in trunk/Source

De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=68839

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.

  • API/JSCallbackObject.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/Executable.cpp:
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp:
  • runtime/GetterSetter.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSPropertyNameIterator.cpp:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSValue.h:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:
  • runtime/StructureChain.cpp:
  • runtime/StructureChain.h:

Inlined the method table access and call to the visitChildren function (the only call sites
to visitChildren are here).

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):

Changed the field name for the visitChildren function pointer to visitChildren (from
visitChildrenFunctionPtr) to make call sites less verbose.

  • runtime/ClassInfo.h:

Discovered JSBoundFunction doesn't have its own ClassInfo (it used JSFunction's ClassInfo) but
overrides visitChildren, so it needs to have its own ClassInfo.

  • runtime/JSBoundFunction.cpp:
  • runtime/JSBoundFunction.h:

Had to move className up to make sure that the virtual destructor in JSObject wasn't
the first non-inline virtual method in JSObject (as per the comment in the file).
Also moved JSCell::visitChildrenVirtual into JSObject.h in order for it be inline-able
to mitigate the cost of an extra method call.

Also added a convenience accessor function methodTable() to JSCell to return the MethodTable to make
call sites more concise. Implementation is inline in JSObject.h.

  • runtime/JSObject.h:

(JSC::JSCell::methodTable):

  • runtime/JSCell.h:

Added an out of line virtual destructor to JSWrapperObject and ScopeChainNode to
appease the vtable gods. It refused to compile if there were no virtual methods in
both of these classes due to the presence of a weak vtable pointer.

  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::~JSWrapperObject):

  • runtime/JSWrapperObject.h:
  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::~ScopeChainNode):

  • runtime/ScopeChain.h:

Source/JavaScriptGlue:

Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.

  • WebCore.exp.in:
  • bindings/js/JSAttrCustom.cpp:
  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/js/JSCSSRuleCustom.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  • bindings/js/JSMessageChannelCustom.cpp:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSNodeIteratorCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSSharedWorkerCustom.cpp:
  • bindings/js/JSStyleSheetCustom.cpp:
  • bindings/js/JSTreeWalkerCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
12:31 Changeset [96345] by vestbo@webkit.org
  • 55 edits in trunk

[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi

QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.

Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.

https://bugs.webkit.org/show_bug.cgi?id=68687

Reviewed by Andreas Kling.

12:07 Changeset [96344] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69075

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:03 Changeset [96343] by abarth@webkit.org
  • 12 edits
    2 deletes in trunk

Unreviewed, rolling out r96340.
http://trac.webkit.org/changeset/96340
https://bugs.webkit.org/show_bug.cgi?id=69098

Caused 10 tests to crash in Debug (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-29

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::childrenChanged):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::childrenChanged):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

LayoutTests:

  • platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
  • platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.
11:04 Changeset [96342] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Shrink FontFallbackList.
https://bugs.webkit.org/show_bug.cgi?id=69093

Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.

Reduce the size of FontFallbackList by one CPU word, decreasing memory
consumption by 300 kB (on 64-bit) when loading the full HTML5 spec.

  • platform/graphics/FontCache.h:
  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::generation):

Store the FontCache generation as an ushort rather than uint.

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::FontFallbackList):

  • platform/graphics/FontFallbackList.h:

Pack enum and bool members in a bitfield.

10:50 Changeset [96341] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

We should ignore the return value of GetRealNamedProperty
https://bugs.webkit.org/show_bug.cgi?id=68840

Reviewed by Nate Chapin.

Source/WebCore:

Instead of skipping the lookup process by using the result of real
named property, we should just indiciate that it wasn't handled by the
interceptor.

Test: http/tests/security/window-named-valueOf.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

LayoutTests:

  • http/tests/security/window-named-valueOf-expected.txt: Added.
  • http/tests/security/window-named-valueOf.html: Added.
10:46 Changeset [96340] by cfleizach@apple.com
  • 12 edits
    2 adds in trunk

ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289

Source/WebCore:

If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned
that it's generally not safe to create objects.

Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-liveregion-without-element-access.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::childrenChanged):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::childrenChanged):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.
10:35 Changeset [96339] by commit-queue@webkit.org
  • 7 edits
    5 deletes in trunk/Source/WebCore

[GTK] Dragging a selection does not produce a drag image
https://bugs.webkit.org/show_bug.cgi?id=69064

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-29
Reviewed by Andreas Kling.

Moved Chromium's generic implementation of Frame::nodeImage and
Frame::dragImageForSeletion to Frame.cpp and simply excluded via
#ifdefs platforms that do not have their own implementation. Removed
all empty implementations of these functions and Qt's which was
functionally identical.

No new tests. Drag-and-drop drag image functionality changes
are incredibly difficult to test in a non-manual way.

  • CMakeListsEfl.txt: Delist FrameEfl.cpp.
  • GNUmakefile.list.am: Delist FrameGtk.cpp.
  • WebCore.gypi: Delist removed Frame*.cpp.
  • WebCore.pro: Delist FrameQt.cpp.
  • page/Frame.cpp: Moved FrameChromium implementation here.

(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

  • page/chromium/FrameChromium.cpp: Removed.
  • page/efl/FrameEfl.cpp: Removed.
  • page/gtk/FrameGtk.cpp: Removed.
  • page/qt/FrameQt.cpp: Removed.
  • page/wx/FrameWx.cpp: Removed.
  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::createDragImage): Call nodeImage to get
the drag image for a node.

10:16 Changeset [96338] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium skia] PNGImageEncoder: hoist constants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=68988

Reviewed by Kenneth Russell.

No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.png.*.html
fast/canvas/toDataURL-alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/image-encoders/skia/PNGImageEncoder.cpp:

(WebCore::encodePixels): Move constant out of the encoding loop.
(WebCore::PNGImageEncoder::encode): Consistency & style: call encodePixels()
just like we do in the JPEG encoder.

10:05 Changeset [96337] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source

Add unit test for CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=68622

Source/WebCore:

Minor refactoring for testability:

  • Made pointInTriangle public.
  • Added LayerShape to decouple LayerIntersector and GraphNode.
  • Added a public wrapper function for LayerIntersector.

Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::pointInTriangle):
(WebCore::CCLayerSorter::calculateZDiff):
(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
(WebCore::CCLayerSorter::LayerIntersector::go):
(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerSorter.h:

(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):

Source/WebKit/chromium:

Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/CCLayerSorterTest.cpp: Added.

(WebCore::TEST):

10:04 Changeset [96336] by commit-queue@webkit.org
  • 5 edits
    2 moves
    5 adds
    8 deletes in trunk/LayoutTests

Rebaseline for r95870
https://bugs.webkit.org/show_bug.cgi?id=69090

Patch by David Reveman <reveman@chromium.org> on 2011-09-29
Reviewed by James Robinson.

  • platform/chromium-gpu-cg-mac/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.txt: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
  • platform/chromium-gpu/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-gpu/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium-gpu/platform/chromium/compositing/backface-visibility-transformed-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png.
  • platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt.
  • platform/chromium/test_expectations.txt:
09:42 Changeset [96335] by dgrogan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test demonstrating IDBCursor inconsistency bug.
https://bugs.webkit.org/show_bug.cgi?id=69012

Reviewed by Nate Chapin.

  • storage/indexeddb/cursor-inconsistency-expected.txt: Added.
  • storage/indexeddb/cursor-inconsistency.html: Added.
09:32 Changeset [96334] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowConstructed): Set the developer extra flags to true to enable inspect element.

09:25 Changeset [96333] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Generalize expected result to all of MAC.

  • platform/chromium/test_expectations.txt:
09:24 Changeset [96332] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test can also time out.

  • platform/chromium/test_expectations.txt:
09:20 Changeset [96331] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Update expected results on Leopard. As far as I can tell, these are
progressions.

  • platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png: Added.
09:09 Changeset [96330] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Add some expected failures on Leopard.

  • platform/chromium/test_expectations.txt:
08:46 Changeset [96329] by abarth@webkit.org
  • 4 edits in trunk/Tools

Unbreak the "update expectatations" button by using the existing
machinery to create the failureInfo objects.

Unbreak the "close" button on the progress dialog by using |this|
instead of the old name of the object.

Teach the controllers unit test not to talk to the actual network.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
08:34 Changeset [96328] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Update baselines. (Font rendering.)

  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Added.
  • platform/chromium-mac/http/tests/misc/acid3-expected.png: Added.
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
08:32 Changeset [96327] by abarth@webkit.org
  • 1 edit
    6 adds
    2 deletes in trunk/LayoutTests

Update baselines.

  • platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.
  • platform/chromium-cg-mac/svg/text/selection-background-color-expected.png: Added.
  • platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/text: Added.
  • platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Added.
  • platform/gtk/svg/text/selection-background-color-expected.txt: Removed.
  • platform/mac/svg/text/selection-background-color-expected.txt: Removed.
  • svg/text/selection-background-color-expected.txt: Added.
07:30 Changeset [96326] by loislo@chromium.org
  • 5 edits in trunk

Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.
https://bugs.webkit.org/show_bug.cgi?id=69087

The fix has the changes for the test and minor perf framework improvements.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._defaultRefreshDelay.500._scheduleRefresh):

LayoutTests:

  • inspector/performance/resources/network-append-30-requests.html:
  • inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):

07:22 WebKitGTK/Releasing edited by mrobinson@webkit.org
(diff)
07:22 WebKitGTKStableReleases edited by mrobinson@webkit.org
(diff)
07:21 WebKitGTKStableReleases edited by mrobinson@webkit.org
(diff)
07:20 WebKitGTKStableReleases edited by mrobinson@webkit.org
(diff)
07:20 WebKitGTKStableReleases edited by mrobinson@webkit.org
(diff)
06:59 Changeset [96325] by sergio@webkit.org
  • 2 edits in trunk

[GTK] Bump version to 1.7.0
https://bugs.webkit.org/show_bug.cgi?id=69082

Reviewed by Martin Robinson.

Apart from bumping the library version to 1.7.0 this patch also
sets the libtool version to the same one we have for the stable
branch.

  • configure.ac:
06:53 Changeset [96324] by carlosgc@webkit.org
  • 8 edits in trunk/Source/WebKit2

[GTK] Force single header include in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69084

Reviewed by Martin Robinson.

Only <webkit2/webkit2.h> will be allowed for API users.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitError.h:
  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebLoaderClient.h:
  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.h:
  • UIProcess/API/gtk/webkit2.h:
06:44 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
06:02 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
05:59 Changeset [96323] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: Make search-in-resource test simpler.
https://bugs.webkit.org/show_bug.cgi?id=69025

Source/WebCore:

Changed search-in-resource test.
Removed error parameter from content provider's searchInContent callback.

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.searchInContent):

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector/search/search-in-resource-expected.txt:
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-resources.html:
  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):

05:56 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
05:29 Changeset [96322] by hans@chromium.org
  • 11 edits in trunk

IndexedDB: Use LevelDB also for in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=68903

Reviewed by Steve Block.

Source/WebCore:

Add LevelDBDatabase::openInMemory() which uses leveldb::NewMemEnv()
to create in-memory LevelDB databases.

Use this in IDBLeveLDBBackingStore::open() when the caller passes in
an empty file path.
This happens in Chromium's incognito mode, and when running layout
tests.

Fix IDBSQLiteBackingStore::backingStoreExists() so it doesn't create
files when passed in an empty file path, but uses the in-memory mode
instead.

Existing layout tests will all be run in-memory.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::~LevelDBDatabase):
(WebCore::openDB):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

  • platform/leveldb/LevelDBDatabase.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::backingStoreExists):

Source/WebKit/chromium:

Don't fall back to SQLite or use a temporary dir for in-memory
databases (Incognito and layout tests); LevelDB supports in-memory
databases now.

  • public/WebIDBFactory.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

Tools:

Remove the temporary dir that was necessary before LevelDB supported
in-memory databases.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:
04:59 Changeset [96321] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
https://bugs.webkit.org/show_bug.cgi?id=69081

There is a test with 30 requests.
For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.

Reviewed by Pavel Feldman.

Test: inspector/performance/resources/network-append-30-requests.html

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype._refreshResource):

04:49 Changeset [96320] by pfeldman@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: make inspector protocol validation a part of the build process.
https://bugs.webkit.org/show_bug.cgi?id=68999

Since we'd like to commit to inspector protocol backwards compatibility, violating it
should be a build failure.

Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • inspector/Inspector.draft-01.json:
  • inspector/Inspector.json:
  • inspector/generate-inspector-idl:
  • inspector/generate-protocol-externs:
  • inspector/validate-protocol-compatibility:
04:39 Changeset [96319] by pfeldman@chromium.org
  • 7 edits
    4 deletes in trunk

Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
  • platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
  • platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.
04:06 Changeset [96318] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-09-28 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: network log view refresh optimizations
https://bugs.webkit.org/show_bug.cgi?id=69010

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView.prototype.refresh):
04:00 Changeset [96317] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] Explicitly call destructors for objects initialized with placement new syntax
https://bugs.webkit.org/show_bug.cgi?id=69079

Reviewed by Xan Lopez.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):

03:33 Changeset [96316] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTests: media/video-does-not-loop.html failing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=69067

Patch by Arun Patole <bmf834@motorola.com> on 2011-09-29
Reviewed by Philippe Normand.

Update expected test result for video-does-not-loop.html
as the 'pause' event should be fired at the end of playback.

  • media/video-does-not-loop-expected.txt:
03:30 Changeset [96315] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] some Layout Tests in editing/ is failing
https://bugs.webkit.org/show_bug.cgi?id=69078

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
03:07 Changeset [96314] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-javascript-doc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69077

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
01:46 WebKitGTK/Releasing edited by plaes@plaes.org
Confirmed that patch is required even for make-3.82 (diff)
01:44 Changeset [96313] by podivilov@chromium.org
  • 5 edits
    1 move
    1 add
    1 delete in trunk

Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.
https://bugs.webkit.org/show_bug.cgi?id=69068

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js.

(WebInspector.RawSourceCode): Moved from SourceFile.js.
(WebInspector.UILocation): Moved from SourceFile.js.

  • inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js

(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
01:36 Changeset [96312] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test svg/filters/animate-fill.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=69070

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
01:07 Changeset [96311] by philn@webkit.org
  • 3 edits in trunk

[GStreamer] 2 flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=67407

Reviewed by Martin Robinson.

Workaround for GStreamer bug#639941. In GStreamer
0.10.35 basesink reports wrong duration in case of EOS and
negative playback rate. This workaround fixes two media tests,
media/video-timeupdate-reverse-play.html and
media/video-reverse-play-duration.html.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):

01:03 Changeset [96310] by philn@webkit.org
  • 6 edits in trunk/Source/WebCore

[GStreamer] fullscreen video pause/play fails
https://bugs.webkit.org/show_bug.cgi?id=66936

Reviewed by Martin Robinson.

Don't use the identity element to avoid painting of the in-window
video. Instead simply make the sink aware of the fullscreen state
and ignore buffers if fullscreen and autovideosink are
active. Also fixed two deadlocks happening when a paused pipeline
is switched to fullscreen and when fullscreen is disabled for a
paused pipeline.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/GStreamerGWorld.h:

(WebCore::GStreamerGWorld::isFullscreen):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_render):
(webkit_video_sink_new):

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
00:52 Changeset [96309] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.

  • dfg/DFGNode.h:
00:33 Changeset [96308] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Hopefully the last Chromium test expectation update for r96294.

  • platform/chromium/test_expectations.txt:
00:23 Changeset [96307] by timothy_horton@apple.com
  • 59 edits
    3 adds in trunk

REGRESSION(87010): elements in ECMA-cloud neither filled nor blurred
https://bugs.webkit.org/show_bug.cgi?id=68679
<rdar://problem/10204649>

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Strip prefixes from SVG attributes before testing if they're supported.
Namespaced attributes will be matched using their namespace instead of
the (user-choosable) prefix.

Test: svg/custom/xlink-custom-namespace.svg

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::isSupportedAttribute):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::isSupportedAttribute):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isSupportedAttribute):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute):

  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::isSupportedAttribute):

  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::isSupportedAttribute):

  • svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::isSupportedAttribute):

  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::isSupportedAttribute):

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):

  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::isSupportedAttribute):

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):

  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::isSupportedAttribute):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::isSupportedAttribute):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::isSupportedAttribute):

  • svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::isSupportedAttribute):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::isSupportedAttribute):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):

  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::isSupportedAttribute):

  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::isSupportedAttribute):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::isSupportedAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::isSupportedAttribute):

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::isSupportedAttribute):

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::isSupportedAttribute):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isSupportedAttribute):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::isSupportedAttribute):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::isSupportedAttribute):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::isSupportedAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::isSupportedAttribute):

  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::isSupportedAttribute):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::isSupportedAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::isSupportedAttribute):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::isSupportedAttribute):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::isSupportedAttribute):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::isSupportedAttribute):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isSupportedAttribute):

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::isSupportedAttribute):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::isSupportedAttribute):

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::isSupportedAttribute):

  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::isSupportedAttribute):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::isSupportedAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isSupportedAttribute):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::isSupportedAttribute):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::isSupportedAttribute):

  • svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::isSupportedAttribute):

  • svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::addSupportedAttributes):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::isSupportedAttribute):

  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::isSupportedAttribute):

LayoutTests:

Add a test ensuring that using xlink:href with a different prefix (i.e. xl:href)
works correctly.

  • svg/custom/xlink-custom-namespace-expected.png: Added.
  • svg/custom/xlink-custom-namespace-expected.txt: Added.
  • svg/custom/xlink-custom-namespace.svg: Added.
00:12 Changeset [96306] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG checkArgumentTypes fails to check boolean predictions
https://bugs.webkit.org/show_bug.cgi?id=69059

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

LayoutTests:

  • fast/js/boolean-argument-prediction-expected.txt: Added.
  • fast/js/boolean-argument-prediction.html: Added.
  • fast/js/script-tests/boolean-argument-prediction.js: Added.

(predictBooleanArgument):

Note: See TracTimeline for information about the timeline view.