Timeline


and

10/09/11:

22:57 Changeset [97043] by ryuan.choi@samsung.com

[EFL] Refactor zoom related APIs.
https://bugs.webkit.org/show_bug.cgi?id=62842

Current zoom apis can't support the case of using both page zoom and text
zoom.

As a first step to refactor, this split ewk_{view|frame}_zoom_{get|set}
to use both page_zoom and text zoom individually.
In addition, introduce ewk_view_scale_{get|set} to support proportional scaling.

ewk_view_zoom_{get|set} will remain unchanged until the behavior of smart_zoom
was changed.

Reviewed by Antonio Gomes.

  • ewk/ewk_frame.cpp: Remove ewk_frame_zoom_text_only_{get|set}.

(ewk_frame_page_zoom_get): Renamed from ewk_frame_zoom_get().
(ewk_frame_page_zoom_set): Renamed from ewk_frame_zoom_set().
(ewk_frame_text_zoom_get): Extracted from ewk_frame_zoom_get().
(ewk_frame_text_zoom_set): Extracted from ewk_frame_zoom_set().

  • ewk/ewk_frame.h:
  • ewk/ewk_view.cpp: Remove ewk_view_zoom_text_only_{get|set}

(_ewk_view_smart_zoom_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_zoom_get): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_page_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_page_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_scale_get): Added.
(ewk_view_scale_set): Added.
(ewk_view_text_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_text_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_zoom_weak_set): Change ewk_frame_zoom_get to ewk_frame_page_zoom_get().
(ewk_view_zoom_animated_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_region): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_relative_radius): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().

  • ewk/ewk_view.h:
22:09 Changeset [97042] by dbates@webkit.org

Another attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
to a single precision result. I am unsure if this fix is correct. We need to look into this some
more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.

21:54 Changeset [97041] by dbates@webkit.org

Attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
an integer. I am unsure if this fix is correct. We need to look into this some more. See
<https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.

21:28 Changeset [97040] by dbates@webkit.org

Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)
https://bugs.webkit.org/show_bug.cgi?id=69735

Patch by Luke Macpherson <macpherson@chromium.org> on 2011-10-09
Reviewed by Daniel Bates.

Source/WebCore:

  • testing/Internals.cpp:

Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::setZoomParameters):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Add symbols that are now required by ScrollableArea.
(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

21:05 Changeset [97039] by commit-queue@webkit.org

Improve Null or Undefined test in 32_64 DFG
https://bugs.webkit.org/show_bug.cgi?id=69734

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.

Currently Null or Undefined value test in 32_64 DFG will check
Null and Undefined tag separately and introduce one more branch.
It can be improved in the way how the baseline JIT is doing - by
relying on the fact that "UndefinedTag + 1 == NullTag and NullTag & 1".

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

20:25 Changeset [97038] by tkent@chromium.org

Remove redundant code of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=69701

Reviewed by Darin Adler.

No new tests, just a refactoring.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::deselectItems):
Rename inner deselectItems() to deselectItemsWithoutValidation().
(WebCore::HTMLSelectElement::setSelectedIndex):
Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
ditto, and update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::listBoxSelectItem):
Update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::activeSelectionEndListIndex):
Update a callsite of lastSelectedListIndex().
(WebCore::HTMLSelectElement::selectAll):
Update callsites of functions which are changed to non-static.
(WebCore::HTMLSelectElement::saveLastSelection):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::menuListOnChange): ditto.
(WebCore::HTMLSelectElement::scrollToSelection): ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
(WebCore::HTMLSelectElement::setRecalcListItems):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::selectedIndex): ditto.
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
Made this non-static, and renamed from setSelectedIndex() because
of conflict with an existing function.
(WebCore::HTMLSelectElement::optionToListIndex):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::dispatchFocusEvent):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
Made this non-static, and renamed from deselectItems() to avoid conflict.
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::defaultEventHandler):
Merged a static function and a non-static function.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.

20:11 Changeset [97037] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - Bug fix for ConvertThis
https://bugs.webkit.org/show_bug.cgi?id=69721

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

19:29 Changeset [97036] by abarth@webkit.org

Remove "near miss" XSS vulnerabilities in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69708

Reviewed by David Levin.

Collin Jackson did a security audit of garden-o-matic. He hasn't found
any actual vulnerabilities yet, but he did identify a couple "near
misses" where a slight change in garden-o-matic could lead to a
vulnerability. This patch removes those potential issues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
18:15 Changeset [97035] by abarth@webkit.org

CSP should log unrecognized directives to the console
https://bugs.webkit.org/show_bug.cgi?id=69728

Reviewed by Sam Weinig.

Source/WebCore:

Several of the web developers who have been experimenting with CSP have
run into trouble with directives we don't support. For example, one
developer was confused for a while why image-src didn't do what he
expected. Logging a message to the console will help these folks
figure out what's going on.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
(WebCore::ContentSecurityPolicy::addDirective):

  • page/ContentSecurityPolicy.h:

LayoutTests:

Update expected results to include new console message about unrecognized directives.

  • http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
17:21 Changeset [97034] by wjmaclean@chromium.org

[chromium] Zoom animator front-end
https://bugs.webkit.org/show_bug.cgi?id=68035

Source/WebCore:

Adds necessary components to ScrollAnimatorNone to support a zoom animation
feature. Includes test infrastructure via testing/Internals to capture
in-progress texture scaling (zoom-animator-scale-test.html) as well as a
final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.

Removes temporary test fields from Settings.

Reviewed by Kenneth Russell.

Test: platform/chromium/compositing/zoom-animator-scale-test2.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged):

  • page/FrameView.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::notifyZoomChanged):
(WebCore::ScrollAnimator::zoomTranslation):
(WebCore::ScrollAnimator::resetZoom):
(WebCore::ScrollAnimator::setZoomParametersForTest):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::zoomScale):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
(WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::zoom):
(WebCore::ScrollAnimatorNone::handleGestureEvent):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorNone.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::zoomAnimatorTransformChanged):

  • platform/ScrollableArea.h:
  • testing/Internals.cpp:

(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::getPageScaleFactor):
(WebCore::Internals::setZoomParameters):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

Modifications to get zoom texture-scale parameters from ScaleAnimator directly
instead of via Settings.

Reviewed by Kenneth Russell.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

Reviewed by Kenneth Russell.

  • platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
  • platform/chromium/compositing/zoom-animator-scale-test.html:
  • platform/chromium/compositing/zoom-animator-scale-test2-expected.txt: Added.
  • platform/chromium/compositing/zoom-animator-scale-test2.html: Added.
  • platform/chromium/test_expectations.txt:
15:40 Changeset [97033] by fpizlo@apple.com

Remove unused callOperation code of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69722

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

13:15 Changeset [97032] by mitz@apple.com

<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
https://bugs.webkit.org/show_bug.cgi?id=69727

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell

used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
obey its flippedness.

13:14 Changeset [97031] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble
https://bugs.webkit.org/show_bug.cgi?id=69720

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by
a FPR and will be used for further optimizations, though we currently
don't fully utilize it. For now when filling a JS value which was
spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat
to DataFormatJS to avoid compilation errors.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):

13:07 Changeset [97030] by fpizlo@apple.com

DFG should not always speculate that a ByVal access has an integer index
https://bugs.webkit.org/show_bug.cgi?id=69716

Reviewed by Oliver Hunt.

1% win on SunSpider, neutral elsewhere.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::byValHasIntBase):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

09:15 Changeset [97029] by kov@webkit.org

Tagging 1.6.0.

09:14 Changeset [97028] by kov@webkit.org

Tagging 1.6.1.

06:09 Changeset [97027] by jnd@chromium.org

Change bug of tap-highlight-color.html to bug 66577 and close bug 48544.
https://bugs.webkit.org/show_bug.cgi?id=48544

Unreviewed.

  • platform/chromium/test_expectations.txt:
03:39 Changeset [97026] by ossy@webkit.org

[Qt] Unreviewed weekend gardening, skip failing tests

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
03:19 Changeset [97025] by commit-queue@webkit.org

Fix value profiling in 32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=69717

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

Current value profiling for 32_64 JIT is broken and cannot record
correct predicated types, which results in many speculation failures
in the 32_64 DFG JIT, fallbacks to baseline JIT, and re-optimizations
again and again.
With this fix 32_64 DFG JIT can demonstrate real performance gains.

  • bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeStatistics):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):

Empty value check should be performed on decoded JSValue,
as for 32_64 empty value is not identical to encoded 0.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

Record the right profiling result for 32_64.

03:02 Changeset [97024] by ossy@webkit.org

[Qt] Unreviewed weekend gardening.

  • platform/qt/fast/images/color-jpeg-with-color-profile-expected.png: Added after r96970.
  • platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Added after r96970.
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added after r97021.
  • platform/qt/svg/clip-path/clip-path-transform-1-expected.png: Added after r96712.
  • platform/qt/svg/clip-path/clip-path-transform-1-expected.txt: Added after r96712.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.png: Added after r96712.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Added after r96712.
  • platform/qt/svg/custom/grayscale-gradient-mask-2-expected.png: Added after r96470.
  • platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Added after r96470.
03:00 Changeset [97023] by benjamin@webkit.org

Do not compare the first glyph to itself in Font::drawGlyphBuffer()
https://bugs.webkit.org/show_bug.cgi?id=69715

Reviewed by Andreas Kling.

When looking for glyphs with similar properties, we should
skip the first one since the comparison of fontData
and offset will always fail.

This is covered by the existing tests.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):

01:08 Changeset [97022] by commit-queue@webkit.org

Remove 32 bit restrictions in DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69711

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

op_call/op_construct support was disabled for 32 bit DFG JIT because
there was regression in javascriptcore tests. Now the bugs are fixed
and there should be no regression. This makes 32 bit DFG have the same
capability as 64 bit DFG, and improves the coverage.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

00:23 Changeset [97021] by commit-queue@webkit.org

[Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
https://bugs.webkit.org/show_bug.cgi?id=69700

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-09
Reviewed by Adam Barth.

  • http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml:
  • platform/qt/Skipped:

10/08/11:

21:23 Changeset [97020] by inferno@chromium.org

Merge 96999 - Make isXMLMIMEType regex use TLS

BUG=94487
Review URL: http://codereview.chromium.org/8210003

21:19 Changeset [97019] by inferno@chromium.org

Merge 96991 - https://bugs.webkit.org/show_bug.cgi?id=69471

BUG=98582
Review URL: http://codereview.chromium.org/8212005

18:20 Changeset [97018] by inferno@chromium.org

Merge 96984 - XSLT-generated document should inherit its SecurityOrigin from the source document

BUG=99512
Review URL: http://codereview.chromium.org/8213002

17:24 Changeset [97017] by jschuh@chromium.org

Make ThreadGlobalData members use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=69710

Reviewed by Adam Barth.

No functional changes. No new tests required.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:
16:26 Changeset [97016] by mhahnenberg@apple.com

Add static version of JSCell::getConstructData
https://bugs.webkit.org/show_bug.cgi?id=69673

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::getConstructData):

  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getConstructData):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getConstructData):

  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::getConstructData):

  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getConstructData):

  • runtime/DateConstructor.h:
  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::getConstructData):

  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getConstructData):

  • runtime/FunctionConstructor.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getConstructData):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getConstructData):

  • runtime/JSFunction.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::getConstructData):

  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getConstructData):

  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getConstructData):

  • runtime/ObjectConstructor.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getConstructData):

  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getConstructData):

  • runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::JSAudioConstructor::getConstructData):

  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::getConstructData):

  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp:

(WebCore::JSOptionConstructor::getConstructData):

  • bindings/js/JSOptionConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getConstructData):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getConstructData):

  • bridge/runtime_object.h:

Source/WebKit2:

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getConstructData):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
14:31 Changeset [97015] by mhahnenberg@apple.com

Add static version of JSCell::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=69593

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

(JSC::DebuggerActivation::getOwnPropertySlot):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):

  • runtime/Arguments.h:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/DatePrototype.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/ErrorPrototype.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):

  • runtime/JSArray.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::getOwnPropertySlot):

  • runtime/JSBoundFunction.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlot):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlot):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlot):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • runtime/JSString.h:
  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):

  • runtime/MathObject.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlot):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):

  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):

  • runtime/StringPrototype.h:

Source/JavaScriptGlue:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

  • UserObjectImp.cpp:

(UserObjectImp::getOwnPropertySlot):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):

  • bindings/js/JSDOMWindowShell.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):

  • bridge/runtime_object.h:

Source/WebKit2:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlot):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
13:42 Changeset [97014] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - GetLocal should produce a cell result for Array predictions
https://bugs.webkit.org/show_bug.cgi?id=69699

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

It should match SetLocal where only payload is stored for array predictions.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:40 Changeset [97013] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=69702

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

There are some errors in generating code for Branch and LogicalNot,
when the operand is predicted as ObjectOrOther.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

10:46 Changeset [97012] by mrobinson@webkit.org

[GTK] Implement drag and drop support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63706

Reviewed by Philippe Normand.

Source/WebCore:

  • platform/DragData.h:
  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::text): Mark as const.
(WebCore::DataObjectGtk::markup): Ditto.
(WebCore::DataObjectGtk::urlLabel): Ditto.

  • platform/gtk/DataObjectGtk.h: Remove unused member

m_dragContext.
(WebCore::DataObjectGtk::url): Mark as const.
(WebCore::DataObjectGtk::uriList): Ditto.
(WebCore::DataObjectGtk::filenames): Ditto.
(WebCore::DataObjectGtk::image): Ditto.
(WebCore::DataObjectGtk::hasText): Ditto.
(WebCore::DataObjectGtk::hasMarkup): Ditto.
(WebCore::DataObjectGtk::hasURIList): Ditto.
(WebCore::DataObjectGtk::hasURL): Ditto.
(WebCore::DataObjectGtk::hasFilenames): Ditto.
(WebCore::DataObjectGtk::hasImage): Ditto.

  • platform/gtk/DragIcon.cpp: Added. A helper which takes care of

creating a transparent drag window for drags.

  • platform/gtk/DragIcon.h: Added.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • Shared/gtk/ArgumentCodersGtk.cpp: Added.

(CoreIPC::encodeImage): Encode a GdkPixbuf.
(CoreIPC::decodeImage): Decode a GdkPixbuf.
(CoreIPC::encodeDataObject): Encode a DataObjectGtk.
(CoreIPC::decodeDataObject): Decode a DataObjectGtk.
(CoreIPC::::encode): Encode DragData.
(CoreIPC::::decode): Decode DragData.

  • Shared/gtk/ArgumentCodersGtk.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::startDrag):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_init): Set the view as a potential drop destination.
(webkitWebViewBaseDragDataGet): Added, delegate to GtkDragAndDropHelper.
(webkitWebViewBaseDragEnd): Ditto.
(webkitWebViewBaseDragDataReceived): Ditto.
(webkitWebViewBaseDragEnter): Ditto.
(webkitWebViewBaseDragMotion): Ditto.
(doDragLeaveLater): Ditto.
(webkitWebViewBaseDragLeave): Ditto.
(webkitWebViewBaseDragDrop): Ditto.
(webkit_web_view_base_class_init): Override GtkWidget drag and drop methods.
(webkitWebViewBaseStartDrag): Calls gtk_drag_begin() to start a drag operation.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add webkitWebViewBaseStartDrag().
  • UIProcess/PageClient.h: Add startDrag().
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Share the Qt version.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: Added.
  • WebProcess/WebPage/WebPage.cpp: Add drag support for GTK+.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.
09:12 Changeset [97011] by qi.2.zhang@nokia.com

[WK2] Update Skipped file
https://bugs.webkit.org/show_bug.cgi?id=69650

Reviewed by Andreas Kling.

Unskip passed ApplicationCache test cases.

  • platform/wk2/Skipped:
08:37 Changeset [97010] by commit-queue@webkit.org

[Qt] [WK2] Wrong handling of visibility in QTouchWebPage
https://bugs.webkit.org/show_bug.cgi?id=69670

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-10-08
Reviewed by Andreas Kling.

Replace QTouchWebPage visibility handling by Show/Hide events with use of
QSGItem::visibleChanged signal.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::onVisibleChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
07:19 Changeset [97009] by inferno@chromium.org

Add support for ADDRESS_SANITIZER in RenderArena
allocate, free calls.
https://bugs.webkit.org/show_bug.cgi?id=69636

Reviewed by Darin Adler.

Use malloc, free directly without using the debug header. Otherwise,
we won't be able to detect out of bounds access in debug header.

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

06:10 Changeset [97008] by ossy@webkit.org

[Qt] Unreviewed weekend gardening.

  • platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Updated after 96886.
  • platform/qt/Skipped: Skip http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml - http://webkit.org/b/69700
  • platform/qt/fast/css/text-transform-select-expected.png: Added after r96987.
  • platform/qt/fast/css/text-transform-select-expected.txt: Added after r96987.
02:05 Changeset [97007] by tkent@chromium.org

Remove some static functions of HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69621

Reviewed by Darin Adler.

Merge a static function and the corresponding non-static member function
into one function if there are no other callers of the static function.

No new tests, just a refactoring.

  • html/HTMLFormControlElement.h:

Make formControlName() protected because it is called from
HTMLSelectElement.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseMappedAttribute):
Remove two argument of parseMultipleAttribute().
(WebCore::HTMLSelectElement::selectAll):
Merged the static function and the member function.
(WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::parseMultipleAttribute):

  • Make this non-static member function.
  • Use reattachIfAttached().

(WebCore::HTMLSelectElement::appendFormData): Merged.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
(WebCore::HTMLSelectElement::length): Merged with optionCount().

  • html/HTMLSelectElement.h:
01:54 Changeset [97006] by commit-queue@webkit.org

Unreviewed, rolling out r96996.
http://trac.webkit.org/changeset/96996
https://bugs.webkit.org/show_bug.cgi?id=69697

It broke all tests on the Qt bot (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-08

Source/JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::getCallDataVirtual):

  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getCallDataVirtual):

  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getCallDataVirtual):

  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::getCallDataVirtual):

  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getCallDataVirtual):

  • runtime/DateConstructor.h:
  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
(JSC::createTypeErrorFunction):

  • runtime/Error.h:
  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::getCallDataVirtual):

  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getCallDataVirtual):

  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::getCallDataVirtual):

  • runtime/FunctionPrototype.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getCallDataVirtual):

  • runtime/JSCell.h:

(JSC::getCallData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getCallDataVirtual):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::getCallDataVirtual):

  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getCallDataVirtual):

  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getCallDataVirtual):

  • runtime/ObjectConstructor.h:
  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getCallDataVirtual):

  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getCallDataVirtual):

  • runtime/StringConstructor.h:
  • runtime/Structure.h:

Source/JavaScriptGlue:

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCallFunction):

  • UserObjectImp.cpp:

(UserObjectImp::getCallDataVirtual):

  • UserObjectImp.h:

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::JSHTMLAllCollection::getCallDataVirtual):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getCallDataVirtual):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getCallDataVirtual):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getCallDataVirtual):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectGetCallData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallDataVirtual):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getCallDataVirtual):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallDataVirtual):
(JSC::Bindings::isJavaScriptFunction):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getCallDataVirtual):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getCallDataVirtual):

  • bridge/runtime_object.h:

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::getCallDataVirtual):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallDataVirtual):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
01:15 Changeset [97005] by fpizlo@apple.com

DFG JIT - only Array predictions can result in unboxed cells in register file
https://bugs.webkit.org/show_bug.cgi?id=69695

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

In current DFG JIT, only array predictions can result in unboxed cells
in register file, not for the other cell predictions.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):

00:31 Changeset [97004] by rniwa@webkit.org

Snow Leopard build fix after r96976. Apparently we just need a full rebuild.

  • config.h:
00:04 Changeset [97003] by commit-queue@webkit.org

bug fixes for ArrayPush and ArrayPop in 32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69696

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-07
Reviewed by Filip Pizlo.

On 32-bit, we should use TimesEight (8) instead of ScalePtr (4)
to compute the address of a JS array element.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10/07/11:

23:37 Changeset [97002] by mhahnenberg@apple.com

Add static version of JSCell::deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=69659

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::deleteProperty):

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::deleteProperty):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::deleteProperty):

  • runtime/Arguments.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::deleteProperty):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::deleteProperty):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::deleteProperty):

  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::deleteProperty):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):

  • runtime/JSVariableObject.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::deleteProperty):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deleteProperty):

  • runtime/StrictEvalActivation.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::deleteProperty):

  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::deleteProperty):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::deleteProperty):

  • bridge/runtime_object.h:
22:37 Changeset [97001] by rniwa@webkit.org

[JSC]Two tests fails after r95489 & r95488
https://bugs.webkit.org/show_bug.cgi?id=68428

Move V8-specific results to Chromium and put JSC result in cross-platform directory.
Also unskip the tests on Mac.

  • http/tests/security/document-all-expected.txt:
  • http/tests/security/window-named-proto-expected.txt:
  • platform/chromium/http/tests/security/document-all-expected.txt: Copied from

LayoutTests/http/tests/security/document-all-expected.txt.

  • platform/chromium/http/tests/security/window-named-proto-expected.txt: Copied from

LayoutTests/http/tests/security/window-named-proto-expected.txt.

  • platform/gtk/http/tests/security/document-all-expected.txt: Removed.
  • platform/gtk/http/tests/security/window-named-proto-expected.txt: Removed.
  • platform/mac/Skipped:
  • platform/qt/http/tests/security/document-all-expected.txt: Removed.
  • platform/qt/http/tests/security/window-named-proto-expected.txt: Removed.
19:46 Changeset [97000] by jeffm@apple.com

Add WKPageContextMenuClient callback when context menu is dismissed
https://bugs.webkit.org/show_bug.cgi?id=69553

Add contextMenuDismissed callback to WKPageContextMenuClient, and bump the API
version of this client to 1 so we continue to work with old clients.

  • Shared/APIClientTraits.cpp: Added array of interface sizes for WKPageContextMenuClient.
  • Shared/APIClientTraits.h: Added APIClientTraits for WKPageContextMenuClient.
  • UIProcess/API/C/WKPage.h: Added contextMenuDismissed callback to WKPageContextMenuClient and bumped kWKPageContextMenuClientCurrentVersion.
  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::contextMenuDismissed): Added.

  • UIProcess/WebPageContextMenuClient.h: Added WebPageContextMenuClient::contextMenuDismissed().
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu): Notify client when context menu is dismissed.

19:22 Changeset [96999] by jschuh@chromium.org

Make isXMLMIMEType regex use TLS
https://bugs.webkit.org/show_bug.cgi?id=69665

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/workers/worker-multi-startup.html

  • dom/DOMImplementation.cpp:

(WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
(WebCore::XMLMIMETypeRegExp::~XMLMIMETypeRegExp):
(WebCore::XMLMIMETypeRegExp::isXMLMIMEType):
(WebCore::DOMImplementation::isXMLMIMEType):

  • dom/DOMImplementation.h:
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::xmlTypeRegExp):

LayoutTests:

  • fast/workers/worker-multi-startup-expected.txt: Added.
  • fast/workers/worker-multi-startup.html: Added.
19:08 Changeset [96998] by simonjam@chromium.org

[Chromium] Allow failure of another Mac Skia test.

Unreviewed.

  • platform/chromium/test_expectations.txt: Added first-of-type-pseudo-class.html.
19:01 Changeset [96997] by commit-queue@webkit.org

Unreviewed, rolling out r96847.
http://trac.webkit.org/changeset/96847
https://bugs.webkit.org/show_bug.cgi?id=69684

may have caused memory regression on win chromium (Requested
by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

18:44 Changeset [96996] by mhahnenberg@apple.com

Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/Error.cpp:

(JSC::createTypeErrorFunction):

Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData. This
just makes execution fail earlier in a place where the source of the error is
easy to trace. These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:

Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:

(JSC::getCallData):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:
  • runtime/Structure.h:

Source/JavaScriptGlue:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCallFunction):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectGetCallData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::isJavaScriptFunction):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::createStructure):
(JSC::Bindings::QtRuntimeConnectionMethod::createStructure):

  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
17:43 Changeset [96995] by oliver@apple.com

Add missing break statement.

17:41 Changeset [96994] by bfulgham@webkit.org

[WinCairo] Unreviewed Skiplist update to get bot green.

  • platform/wincairo/Skipped: Turn off a few more tests.
17:06 Changeset [96993] by oliver@apple.com

Support some string intrinsics in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69678

Reviewed by Gavin Barraclough.

Add support for charAt and charCodeAt intrinsics in the DFG.

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:06 Changeset [96992] by mhahnenberg@apple.com

Add static version of JSCell::put
https://bugs.webkit.org/show_bug.cgi?id=69382

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::put):

(JSC::DebuggerActivation::put):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::put):

  • runtime/Arguments.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::put):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::put):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::put):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::put):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::put):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::put):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):

  • runtime/JSStaticScopeObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::put):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::put):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::put):

  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::put):

  • runtime/StringObject.h:

Source/JavaScriptGlue:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

  • UserObjectImp.cpp:

(UserObjectImp::put):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::put):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::put):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::put):

  • bridge/runtime_object.h:
16:58 Changeset [96991] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=69471

We now wrap the window script NPObject which is requested by NPAPI plugins for
scripting. The wrapped NPObject pointer maintains a weak reference to the
window script NPObject and is cleared out when the window script object is destroyed.
The NPObject wrapper is destroyed when the last outstanding reference is released.

Reviewed by Nate Chapin.

No tests added as there is no change in functionality.

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2011-10-07

  • WebCore.gypi:
  • bindings/v8/NPObjectWrapper.cpp: Added.

(WebCore::NPObjectWrapper::NPObjectWrapper):
(WebCore::NPObjectWrapper::create):
(WebCore::NPObjectWrapper::clear):
(WebCore::NPObjectWrapper::getWrapper):
(WebCore::NPObjectWrapper::getUnderlyingNPObject):
(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):
(WebCore::NPObjectWrapper::NPDeallocate):
(WebCore::NPObjectWrapper::NPPInvalidate):
(WebCore::NPObjectWrapper::NPHasMethod):
(WebCore::NPObjectWrapper::NPInvoke):
(WebCore::NPObjectWrapper::NPInvokeDefault):
(WebCore::NPObjectWrapper::NPHasProperty):
(WebCore::NPObjectWrapper::NPGetProperty):
(WebCore::NPObjectWrapper::NPSetProperty):
(WebCore::NPObjectWrapper::NPRemoveProperty):
(WebCore::NPObjectWrapper::NPNEnumerate):
(WebCore::NPObjectWrapper::NPNConstruct):
(WebCore::NPObjectWrapper::NPInvokePrivate):

  • bindings/v8/NPObjectWrapper.h: Added.
  • bindings/v8/NPV8Object.cpp:

(_NPN_EvaluateHelper):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):

  • bindings/v8/ScriptController.h:
16:38 Changeset [96990] by commit-queue@webkit.org

Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-07
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Added.

(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • public/WebContentLayerClient.h: Added.

(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • public/WebLayer.h: Added.

(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerClient.h: Added.

(WebKit::WebLayerClient::~WebLayerClient):

  • public/WebLayerTreeView.h: Added.

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerTreeViewClient.h: Added.

(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • src/WebContentLayer.cpp: Added.

(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):

  • src/WebContentLayerImpl.cpp: Added.

(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):

  • src/WebContentLayerImpl.h: Added.
  • src/WebLayer.cpp: Added.

(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):

  • src/WebLayerImpl.cpp: Added.

(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):

  • src/WebLayerImpl.h: Added.
  • src/WebLayerTreeView.cpp: Added.

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):

  • src/WebLayerTreeViewImpl.cpp: Added.

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h: Added.
16:38 Changeset [96989] by abarth@webkit.org

Add a Content-Security-Policy to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69668

Reviewed by David Levin.

This will help mitigate cross-site script and will also help us dogfood CSP.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
16:38 Changeset [96988] by barraclough@apple.com

Refactor DFG to make for use of callOperation
https://bugs.webkit.org/show_bug.cgi?id=69672

Reviewed by Oliver Hunt.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • Added new callOperation calls, don't ASSERT flushed (use helpers for unexpected calls, too).
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Switch operationNewObject/operationCreateThis to return Cells,
    • Added C_DFGOperation_E/C_DFGOperation_EC/J_DFGOperation_EA/J_DFGOperation_EJA call types.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • Replace code plating calls to operations to with calls to callOperation.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • Replace code plating calls to operations to with calls to callOperation.
16:29 Changeset [96987] by commit-queue@webkit.org

CSS text-transform should apply to select elements
https://bugs.webkit.org/show_bug.cgi?id=69503

Patch by Ben Wells <benwells@chromium.org> on 2011-10-07
Reviewed by Ojan Vafai.

Source/WebCore:

Select elements are drawn in two ways depending on whether they are multiple and what their size is.
Neither method previously handled text-transforms. Both of these rendering styles are now updated to transform
their text correctly.

Test: fast/css/text-transform-select.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setText):
(WebCore::RenderMenuList::itemText):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::applyTextTransform):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::textWithoutTranscoding):

  • rendering/RenderText.h:

LayoutTests:

  • fast/css/text-transform-select-expected.txt: Added.
  • fast/css/text-transform-select.html: Added.
  • platform/chromium-linux/fast/css/text-transform-select-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:20 Changeset [96986] by commit-queue@webkit.org

First round of unit tests for CCLayerTreeHostCommon.
https://bugs.webkit.org/show_bug.cgi?id=69197

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-07
Reviewed by James Robinson.

This round of tests focuses on verifying the computation of matrix transforms
in calculateDrawTransformsAndVisibility.

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp: Added.

(WebCore::setLayerPropertiesForTesting):
(WebCore::executeCalculateDrawTransformsAndVisibility):
(WebCore::remove3DComponentOfMatrix):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(WebCore::TEST):

16:18 Changeset [96985] by tony@chromium.org

fix a crash when loading non-html multipart data
https://bugs.webkit.org/show_bug.cgi?id=69675

Reviewed by Adam Barth.

Source/WebCore:

setupForReplaceByMIMEType calls DocumentWriter::end(). This leads to
a crash on Mac because WebHTMLRepresentation() calls commitLoad(nil),
which tries to write to the DocumentWriter. By just inlining the code
to load the last page, we avoid this crash (and makes the non-html
multipart code more like the html multipart code).

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):

LayoutTests:

  • http/tests/multipart/load-last-non-html-frame.php: Ensure same output on Apple Mac and Chromium (was getting different number of trailing new lines).
16:00 Changeset [96984] by commit-queue@webkit.org

XSLT-generated document should inherit its SecurityOrigin from the source document
https://bugs.webkit.org/show_bug.cgi?id=69661

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-07
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml

  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

  • http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added.
  • http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml: Added.
15:11 Changeset [96983] by oliver@apple.com

Support string indexing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69671

Reviewed by Gavin Barraclough.

Emit code to support inline indexing of strings

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

Shared code to perform string indexing.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Use compileGetByValOnString if we predict that the base object
is a string in GetByVal.

  • runtime/JSString.h:

(JSC::JSString::offsetOfFiberCount):
(JSC::JSString::offsetOfValue):

15:11 BuildingOnWindows edited by rniwa@webkit.org
Add a link to … (diff)
15:00 Changeset [96982] by bfulgham@webkit.org

[WinCairo] Unreviewed Skiplist update to get WinCairo bot green.

  • platform/wincairo/Skipped: Skip a few failing test categories.
14:30 Changeset [96981] by rniwa@webkit.org

Re-enable a test fixed by r93529.

  • platform/win/Skipped:
13:52 Changeset [96980] by fpizlo@apple.com

DFG ConvertThis speculation logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=69663

Reviewed by Oliver Hunt.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:43 Changeset [96979] by ap@apple.com

[Mac] Scrollbars in embedded PDFs should update when system preferences change
https://bugs.webkit.org/show_bug.cgi?id=69654

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h: Added an scrollbarStyleChanged() override. ScrollAnimatorMac sets scrollbar frame to a bogus (0, 0, thickness, thickness) one when style changes, and expects clients to move them back in place.
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::isOnActivePage): Fixed a typo that prevented ScrollAnimatorMac from updating style of PDF view scrollbars. (WebKit::BuiltInPDFView::scrollbarStyleChanged): Reposition scrollbars and content after style change. The behavior is not perfect in edge cases, but roughly matches ScrollView.
13:27 Changeset [96978] by oliver@apple.com

2011-10-07 Oliver Hunt <oliver@apple.com>

Verify that our call speculation is valid.

Reviewed by Filip Pizlo.

Before specialising an intrinsic we need to verify that
we our speculation is correct.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
13:24 Changeset [96977] by bfulgham@webkit.org

[WinCairo] Unreviewed build correction for the build bot.

Release_Cairo_CFLite and Debug_Cairo_CFLite targets so that
build-jsc can find the target it needs to run the JSC tests.

13:23 Changeset [96976] by commit-queue@webkit.org

Unreviewed, rolling out r96944.
http://trac.webkit.org/changeset/96944
https://bugs.webkit.org/show_bug.cgi?id=69662

Caused many tests to crash on Snow Leopard (Requested by rniwa
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

  • platform/graphics/Color.h:

(WebCore::Color::Color):

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

13:15 Changeset [96975] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=69658

[CSS3 Regions] Box painting of overflow into regions is incorrect because children were being
incorrectly clamped to their containing block region ranges. Change the clamping model so that
renderRegionForLine no longer does it. A block will now truly have an accurate range across
all the regions that paint it. Instead, do the clamping at the time a child box asks the containing
block for its information. At that time clamp to the start and end regions, so that we never ask
a containing block for info about a region that it doesn't exist in.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new test in fast/regions and updated an old result to be correct.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::clampToStartAndEndRegions):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:

LayoutTests:

  • fast/regions/bottom-overflow-out-of-first-region.html: Added.
  • fast/regions/top-overflow-out-of-second-region.html:
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
13:05 Changeset [96974] by commit-queue@webkit.org

Remove compile time flag ENABLE_PASSWORD_ECHO
https://bugs.webkit.org/show_bug.cgi?id=69647

Source/WebCore:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

  • config.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

Source/WebKit/qt:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

LayoutTests:

WK2 tests are passing after r96740 (bug 68924).

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

  • platform/wk2/Skipped:
12:45 Changeset [96973] by cfleizach@apple.com

Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
https://bugs.webkit.org/show_bug.cgi?id=69562

Source/WebCore:

Some fake objects, like AXImageMapLink, have weak references to their parent's (since they are fake objects and
need some connection to the parent). However, if the parent disappears before the child, then we're left with a
out of date reference to that parent.

The fix is to allow these elements to clear their parentage when the parent goes away.

Reviewed by Darin Adler.

Test: accessibility/image-map-update-parent-crash.html

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isVisible):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clearChildren):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObjectForSection):

LayoutTests:

Reviewed by Darin Adler.

  • accessibility/image-map-update-parent-crash-expected.txt: Added.
  • accessibility/image-map-update-parent-crash.html: Added.
12:32 Changeset [96972] by commit-queue@webkit.org

Pack StyleRareNonInheritedData even harder on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69648

Patch by Andreas Kling <kling@webkit.org> on 2011-10-07
Reviewed by Benjamin Poulain.

Rearrange the members of StyleRareNonInheritedData to fold as much
as possible into the padding at the end of RefCounted.

This shrinks StyleRareNonInheritedData by 16 bytes on 64-bit,
reducing memory consumption by another 140 kB when loading the
full HTML5 spec.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

  • rendering/style/StyleRareNonInheritedData.h:
12:28 Changeset [96971] by rniwa@webkit.org

Chromium rebaseline. The test started to pass after r96873.

  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-006-expected.png: Added.
  • platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
  • platform/chromium/test_expectations.txt:
12:26 Changeset [96970] by caryclark@google.com

Source/WebCore: Enable color profiles, unless profile is grayscale
https://bugs.webkit.org/show_bug.cgi?id=69622
https://bugs.webkit.org/show_bug.cgi?id=49950
http://code.google.com/p/chromium/issues/detail?id=80844

Further specialize the earlier fix described in 49950 to
allow color profiles in YCbCr images, but disallow color
profiles marked as grayData.
(see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )

Reviewed by Adam Barth.

Test: fast/images/gray-scale-jpeg-with-color-profile.html

fast/images/color-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readColorProfile):
(WebCore::JPEGImageReader::decode):

LayoutTests: Reviewed by Adam Barth.

Add a image with a color profile that's not gray.
https://bugs.webkit.org/show_bug.cgi?id=69622

Test that we properly render JPEGs with embedded non-gray color profiles.

  • fast/images/color-jpeg-with-color-profile.html: Added.
  • fast/images/resources/icc-v2-gbr.jpg: Added.
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
12:25 Changeset [96969] by ossy@webkit.org

Unreviewed, rolling out r96938.
http://trac.webkit.org/changeset/96938
https://bugs.webkit.org/show_bug.cgi?id=69653

It broke zillion tests and make testing so slow (Requested by
ossy_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebKit2:

  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::applicationCacheDirectory):

LayoutTests:

  • platform/qt-wk2/Skipped:
12:23 Changeset [96968] by ossy@webkit.org

Unreviewed gardening after r96958.

  • platform/qt/test_expectations.txt: Remove a file, because it is skipped too.
12:17 Changeset [96967] by simonjam@chromium.org

[Chromium] Rebaseline test after r96870.

Unreviewed.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-cg-mac/editing/pasteboard/merge-end-blockquote-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Removed.
12:12 Changeset [96966] by cfleizach@apple.com

AX: re-organize fake elements to use new AccessibilityMockObject
https://bugs.webkit.org/show_bug.cgi?id=69588

This adds an AccessibilityMockObject for "fake" elements to descend from.
Its benefit is to consolidate the various ways that these fake elements are setting
and returning their parent objects.

No functional change, hence no new tests.

Reviewed by Jon Honeycutt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):

  • accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::node):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::addChildren):

  • accessibility/AccessibilityMenuList.h:

(WebCore::toAccessibilityMenuList):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
(WebCore::AccessibilityMenuListOption::isVisible):

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityMockObject.cpp: Added.

(WebCore::AccessibilityMockObject::AccessibilityMockObject):
(WebCore::AccessibilityMockObject::~AccessibilityMockObject):

  • accessibility/AccessibilityMockObject.h: Added.

(WebCore::AccessibilityMockObject::parentObject):
(WebCore::AccessibilityMockObject::setParent):
(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::addChildren):
(WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):

  • accessibility/AccessibilityTable.h:

(WebCore::toAccessibilityTable):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::setParent):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::headerObjectForSection):
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
(WebCore::AccessibilityTableColumn::addChildren):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/AccessibilityTableHeaderContainer.h:
11:57 Changeset [96965] by oliver@apple.com

Fix 32-bit build.

11:55 Changeset [96964] by tony@chromium.org

Fix chromium compile when using the components build. This test
helper file is using methods not available when compiling as a dll.

  • WebKit.gyp:
11:47 Changeset [96963] by rniwa@webkit.org

REGRESSION(r96257): fast/repaint/selection-clear.html fail
https://bugs.webkit.org/show_bug.cgi?id=69060

Reviewed by Enrica Casucci.

After r96257, we no longer clear selection upon node removal so the selection should
still be rendered after the node removal in this test.

Changed the color of selection from red to green to indicate the success.

  • fast/repaint/selection-clear.html:
  • platform/mac/fast/repaint/selection-clear-expected.png:
11:39 Changeset [96962] by oliver@apple.com

Support direct calls to intrinsic functions
https://bugs.webkit.org/show_bug.cgi?id=69646

Reviewed by Gavin Barraclough.

Add support for optimising non-method_check calls
to intrinsic functions (eg. when Math.abs, etc are
cached in local variables).

  • bytecode/CodeBlock.h:

(JSC::getCallLinkInfoBytecodeIndex):

Support searching CallLinkInfos by bytecode index

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Add support for linked calls in addition to method_check
when searching for intrinsics

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::function):

Add ability to store a JSFunction* in a node - this is safe
as the function will be marked by the codeblock we're compiling

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::checkFunctionElimination):
(JSC::DFG::Propagator::performNodeCSE):

Add support for new CheckFunction node, and implement CSE pass.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Rather trivial implementation of CheckFunction

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

Need to propagate bytecode index for calls now.

11:16 Changeset [96961] by japhet@chromium.org

Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
This is one of the steps required to remove the SubresourceLoaderClient interface,
which will simplify the layering in the loader.
https://bugs.webkit.org/show_bug.cgi?id=69567

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedRawResource.cpp: Added.
  • loader/cache/CachedRawResource.h: Added.
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),

which was only used to decided whether the CachedResource should count toward
CachedResourceLoader::requestCount().

  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cache/CachedResourceRequest.h:
  • loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.

(WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),

since we won't be checking any callbacks before the load completes.

  • loader/icon/IconLoader.h:
11:14 Changeset [96960] by simonjam@chromium.org

[Chromium] Update test_expectations after V8 roll.

Unreviewed.

  • platform/chromium/test_expectations.txt:
11:06 Changeset [96959] by commit-queue@webkit.org

Add WebCore platform interfaces needed by updated PeerConnection design
https://bugs.webkit.org/show_bug.cgi?id=68460

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-07
Reviewed by Adam Barth.

Added the PeerConnection platform files to WebCore/platform/mediastream

Currently not testable.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/mediastream/MediaStreamComponent.h: Added.

(WebCore::MediaStreamComponent::create):
(WebCore::MediaStreamComponent::source):
(WebCore::MediaStreamComponent::enabled):
(WebCore::MediaStreamComponent::setEnabled):
(WebCore::MediaStreamComponent::MediaStreamComponent):

  • platform/mediastream/MediaStreamDescriptor.h: Added.

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):
(WebCore::MediaStreamDescriptor::label):
(WebCore::MediaStreamDescriptor::component):
(WebCore::MediaStreamDescriptor::numberOfComponents):
(WebCore::MediaStreamDescriptor::ended):
(WebCore::MediaStreamDescriptor::setEnded):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

  • platform/mediastream/MediaStreamSource.h: Added.

(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::id):
(WebCore::MediaStreamSource::type):
(WebCore::MediaStreamSource::name):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):

  • platform/mediastream/PeerHandler.cpp: Added.

(WebCore::PeerHandler::PeerHandler):
(WebCore::PeerHandler::~PeerHandler):
(WebCore::PeerHandler::produceInitialOffer):
(WebCore::PeerHandler::handleInitialOffer):
(WebCore::PeerHandler::processSDP):
(WebCore::PeerHandler::processPendingStreams):
(WebCore::PeerHandler::sendDataStreamMessage):
(WebCore::PeerHandler::stop):

  • platform/mediastream/PeerHandler.h: Added.

(WebCore::PeerHandlerClient::~PeerHandlerClient):
(WebCore::PeerHandler::create):

10:44 Changeset [96958] by commit-queue@webkit.org

background-color affects the font color in disabled textarea.
https://bugs.webkit.org/show_bug.cgi?id=65361

Patch by Vineet Chaudary <vineet.chaudhary@motorola.com> on 2011-10-07
Reviewed by Darin Adler.

Source/WebCore:

For the transparent/translucent background colors use lightening fortext color.

  • rendering/RenderTextControl.cpp:

(WebCore::disabledTextColor):

LayoutTests:

For the background-color White and transparent the text color should be same.

  • fast/forms/input-disabled-color.html: Modified test case.
  • platform/chromium/test_expectations.txt: Needs rebaseline.
  • platform/gtk/fast/forms/input-disabled-color-expected.png: Changed expected result.
  • platform/gtk/fast/forms/input-disabled-color-expected.txt: Changed expected result.
  • platform/mac/test_expectations.txt: Needs rebaseline.
  • platform/qt/test_expectations.txt: Needs rebaseline.
  • platform/win/test_expectations.txt: Needs rebaseline.
10:33 Changeset [96957] by inferno@chromium.org

Merge 96610 - Resource loader should block HTTP redirects to local resources

BUG=95374
Review URL: http://codereview.chromium.org/8198008

10:20 Changeset [96956] by abarth@webkit.org

Add missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
https://bugs.webkit.org/show_bug.cgi?id=66236

Reviewed by Darin Adler.

These APIs are all very new and everyone who's using them should be
aware that they are vendor-prefixed and subject to adjustments as the
spec evolves. Recently, we changed these APIs to more carefully check
whether required parameters are actually present. This patch adds
tests to verify that we're doing the proper checks.

  • fast/files/not-enough-arguments-expected.txt: Added.
  • fast/files/not-enough-arguments.html: Added.
  • fast/filesystem/not-enough-arguments-expected.txt: Added.
  • fast/filesystem/not-enough-arguments.html: Added.
10:19 Changeset [96955] by inferno@chromium.org

Merge 96632 - Source/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.

BUG=96902
Review URL: http://codereview.chromium.org/8206006

10:12 Changeset [96954] by inferno@chromium.org

Merge 96707 - Crash in SVGTRefElement::updateReferencedText.

BUG=95359
Review URL: http://codereview.chromium.org/8203008

10:02 Changeset [96953] by inferno@chromium.org

Merge 96427 - <rdar://problem/10208291> first-letter in generated before content with display: table is not updated

BUG=96427
Review URL: http://codereview.chromium.org/8201005

10:00 Changeset [96952] by commit-queue@webkit.org

Implement currentColor support for box-shadow and text-shadow
https://bugs.webkit.org/show_bug.cgi?id=68218

Source/WebCore:

Patch by David Barr <davidbarr@chromium.org> on 2011-10-07
Reviewed by Simon Fraser.

Test: fast/box-shadow/box-shadow-currentcolor.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Add CSSValueCurrentcolor to supported keywords.

LayoutTests:

Patch by David Barr <davidbarr@google.com> on 2011-10-07
Reviewed by Simon Fraser.

  • fast/box-shadow/box-shadow-currentcolor-expected.png: Added.
  • fast/box-shadow/box-shadow-currentcolor-expected.txt: Added.
  • fast/box-shadow/box-shadow-currentcolor.html: Added.
09:59 Changeset [96951] by inferno@chromium.org

Merge 96826 - Add check for JavaScript URLs in HTMLPlugInImageElement::allowedToLoadFrameURL

BUG=98053
Review URL: http://codereview.chromium.org/8206005

09:45 Changeset [96950] by inferno@chromium.org

Merge 96834 - <rdar://problem/10232866> Assertion failure beneath blockSelectionGaps() when a selected node is removed

BUG=99104
Review URL: http://codereview.chromium.org/8200004

09:44 Changeset [96949] by pfeldman@chromium.org

Web Inspector: add Audits panel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69633

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/AuditCategories.js:
  • inspector/front-end/AuditLauncherView.js:
  • inspector/front-end/AuditResultView.js:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/NetworkLog.js:
  • inspector/front-end/treeoutline.js:
09:43 Changeset [96948] by inferno@chromium.org

Merge 96868 - Crash in VisiblePosition::canonicalPosition.

BUG=99138
Review URL: http://codereview.chromium.org/8199007

09:42 Changeset [96947] by andreas.kling@nokia.com

Functions that return "const Color" should simply return "Color".

Rubber-stamped by Antti Koivisto.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::rendererBackgroundColor):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderTable.h:

(WebCore::RenderTable::bgColor):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:
09:35 Changeset [96946] by abarth@webkit.org

Remove setShouldPaintCustomScrollbars, which has no callers
https://bugs.webkit.org/show_bug.cgi?id=69300

Reviewed by Darin Adler.

Anders tells me this function no longer has any callers. We should
remove it before it grows any!

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
09:33 Changeset [96945] by pfeldman@chromium.org

Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
https://bugs.webkit.org/show_bug.cgi?id=69634

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):

09:24 Changeset [96944] by andreas.kling@nokia.com

Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521

Reviewed by Antti Koivisto.

Unroll BorderValue's Color member so we can pack the color's validity flag
in BorderValue's bitfield.

This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
16 bytes. This reduces memory consumption by 760 kB when loading the full
HTML5 spec.

  • platform/graphics/Color.h:

(WebCore::Color::Color):

Allow construction of Color objects with specific validity.

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
Made those variables private and added color(), setColor() accessors.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):

Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
when setting BorderValue colors.

(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

Made color getters return "Color" instead of "const Color&" since
BorderValue no longer has an actual object to return the reference to.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

Adapt to RenderStyle color getters now returning "Color" instead of
"const Color&".

09:22 Changeset [96943] by commit-queue@webkit.org

[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=66380

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-07
Reviewed by Antonio Gomes.

This encapsulates EWebKit into an object that manages multiple windows
and provides a cleaner interface to EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.

(DumpRenderTreeChrome::create):
(DumpRenderTreeChrome::DumpRenderTreeChrome):
(DumpRenderTreeChrome::~DumpRenderTreeChrome):
(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::removeWindow):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::extraViews):
(DumpRenderTreeChrome::mainFrame):
(DumpRenderTreeChrome::mainView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onStatusbarTextSet):
(DumpRenderTreeChrome::onTitleChanged):
(DumpRenderTreeChrome::onDocumentLoadFinished):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
  • DumpRenderTree/efl/EventSender.cpp:

(sendClick): Use browser->mainFrame() instead of mainFrame.
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
(mouseMoveToCallback): Ditto.
(mouseScrollByCallback): Ditto.
(keyDownCallback): Ditto.
(scalePageByCallback): Ditto.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::counterValueForElementById): Use
browser->mainFrame() instead of mainFrame.
(LayoutTestController::pageNumberForElementById): Ditto.
(LayoutTestController::numberOfPages): Ditto.
(LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
(LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
(LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
(LayoutTestController::numberOfActiveAnimations): Ditto.
(LayoutTestController::suspendAnimations): Ditto.
(LayoutTestController::resumeAnimations): Ditto.
(LayoutTestController::setWebViewEditable): Ditto.
(LayoutTestController::webHistoryItemCount): Use browser->mainView()
instead of browser.
(LayoutTestController::queueLoad): Ditto.
(LayoutTestController::setAcceptsEditing): Ditto.
(LayoutTestController::setUserStyleSheetEnabled): Ditto.
(LayoutTestController::setPrivateBrowsingEnabled): Ditto.
(LayoutTestController::setFrameFlatteningEnabled): Ditto.
(LayoutTestController::setSpatialNavigationEnabled): Ditto.
(LayoutTestController::setPluginsEnabled): Ditto.
(LayoutTestController::findString): Ditto.
(LayoutTestController::setDeveloperExtrasEnabled): Ditto.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView): Use browser->mainFrame() instead of
mainFrame.

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke): Ditto.
(LoadHTMLStringItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.
(ReloadItem::invoke): Use browser->mainView() instead of browser.

09:16 Changeset [96942] by philn@webkit.org

[GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
https://bugs.webkit.org/show_bug.cgi?id=69630

Reviewed by Martin Robinson.

Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
replace use of gst_ghost_pad_new_no_target_from_template() and
gst_ghost_pad_set_target() with a single call to
gst_ghost_pad_new_from_template(). These changes keep the element
compatible with GStreamer 0.10 while preparing the port to 0.11.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_class_init):
(webkit_web_src_init):

08:51 Changeset [96941] by commit-queue@webkit.org

[Freetype] Pseudo-italics do not work
https://bugs.webkit.org/show_bug.cgi?id=40856

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-07
Reviewed by Philippe Normand.

Source/WebCore:

  • platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
(WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
given one that wasn't oblique or italic, activate the synthetic oblique bit.

LayoutTests:

Add test results which show this test passing now.

  • platform/gtk/Skipped: Unskip a passing test.
  • platform/gtk/fast/text/fake-italic-expected.png: Added.
  • platform/gtk/fast/text/fake-italic-expected.txt: Added.
08:47 Changeset [96940] by philn@webkit.org

[GStreamer] avoid direct access to GstMessage structure field
https://bugs.webkit.org/show_bug.cgi?id=69629

Reviewed by Martin Robinson.

Use gst_message_get_structure() instead of direct access to the
structure field. No direct benefit apart from compatibility with
GStreamer 0.11.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::gstGWorldSyncMessageCallback):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):

08:36 Changeset [96939] by pfeldman@chromium.org

Web Inspector: add timeline panel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69628

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/SidebarTreeElement.js:

(WebInspector.SidebarTreeElement):

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js:

(WebInspector.SourceHTMLTokenizer.prototype.nextToken):

  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/TimelineGrid.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.updateMainViewWidth):
(WebInspector.TimelinePanel.prototype.onResize):
(WebInspector.TimelinePanel.prototype._windowChanged):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineRecordGraphRow.prototype._onClick):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

08:09 Changeset [96938] by qi.2.zhang@nokia.com

[Qt][WK2] ApplicationCache LayoutTests failed
https://bugs.webkit.org/show_bug.cgi?id=69541

Reviewed by Chang Shu.

Source/WebKit2:

  1. Moved applicationCacheDirectory to common code.
  2. Added interface setApplicationCacheDirectory to allow UI client overriding.
  3. Renamed all platform-dependent implementations of applicationCacheDirectory to platformDefaultApplicationCacheDirectory.
  4. On Qt, set the platformDefaultApplicationCacheDirectory to the default data location.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setApplicationCacheDirectory):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

LayoutTests:

Unskip passed tests.

  • platform/qt-wk2/Skipped:
07:56 Changeset [96937] by podivilov@chromium.org

Unreviewed, rolling out r96892.
http://trac.webkit.org/changeset/96892
https://bugs.webkit.org/show_bug.cgi?id=69626

it broke windows canary bots (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

  • WebCore.gyp/scripts/rule_binding.py:
07:49 Changeset [96936] by dominicc@chromium.org

[JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
https://bugs.webkit.org/show_bug.cgi?id=69599

Reviewed by Sam Weinig.

DFG JIT manipulates MetaAllocatorHandles across threads, eg in
allocating JITCode buffers on a background thread to execute a
proxy autoconfiguration PAC file but garbage collecting it in
response to allocation on the main thread. Disabling
ThreadRestrictionVerification until there is a verification scheme
that understands this handoff.

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::allocate):

07:28 Changeset [96935] by andreas.kling@nokia.com

Shrink StyleInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69625

Reviewed by Antti Koivisto.

Rearrange the members of StyleInheritedData to fold as much
as possible into the padding at the end of RefCounted.

This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
memory consumption by 500 kB when loading the full HTML5 spec.

  • rendering/style/StyleInheritedData.cpp:

(WebCore::StyleInheritedData::StyleInheritedData):

  • rendering/style/StyleInheritedData.h:
07:18 Changeset [96934] by philn@webkit.org

Unreviewed, skip failing svg test in GTK.

  • platform/gtk/Skipped: Skip svg/filters/feColorMatrix-saturate.svg
07:08 Changeset [96933] by philn@webkit.org

Unreviewed, skip http/tests/multipart/load-last-non-html-frame.php in GTK.

  • platform/gtk/Skipped:
06:55 Changeset [96932] by pfeldman@chromium.org

Web Inspector: make ScriptsPanel compile
https://bugs.webkit.org/show_bug.cgi?id=69623

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/Object.js:
  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

  • inspector/front-end/StatusBarButton.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update.appendResult):
(WebInspector.WatchExpressionsSection.prototype.update):
(WebInspector.WatchExpressionTreeElement.prototype.startEditing):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.WorkerManager.prototype._pageInspectorClosing):
(WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane.prototype.removeWorker):

  • inspector/front-end/externs.js:

(WebInspector.linkifyURL):
(InjectedFakeWorker):

  • inspector/front-end/inspector.js:
06:38 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
05:34 Changeset [96931] by hausmann@webkit.org

[Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
https://bugs.webkit.org/show_bug.cgi?id=69617

Reviewed by Andreas Kling.

Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
logic.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
05:17 Changeset [96930] by podivilov@chromium.org

Unreviewed, rolling out r96879.
http://trac.webkit.org/changeset/96879
https://bugs.webkit.org/show_bug.cgi?id=69618

Broke CCLayerTreeHostTestShortlived1 on chromium mac.
(Requested by podivilov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):

04:35 Changeset [96929] by pfeldman@chromium.org

Web Inspector: add ResourcesPanel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69612

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/ResourceView.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.StorageCategoryView):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.last):

  • inspector/front-end/externs.js:

(WebInspector.openRequestInNetworkPanel):

04:11 Changeset [96928] by zoltan@webkit.org

[Qt] http/tests/multipart/load-last-non-html-frame.php is failing
https://bugs.webkit.org/show_bug.cgi?id=69615

Ossyize failing test.

  • platform/qt/Skipped:
03:59 Changeset [96927] by podivilov@chromium.org

Unreviewed, rolling out r96909.
http://trac.webkit.org/changeset/96909
https://bugs.webkit.org/show_bug.cgi?id=69616

Broke chromium mac compilation (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Removed.
  • public/WebContentLayerClient.h: Removed.
  • public/WebLayer.h: Removed.
  • public/WebLayerClient.h: Removed.
  • public/WebLayerTreeView.h: Removed.
  • public/WebLayerTreeViewClient.h: Removed.
  • src/WebContentLayer.cpp: Removed.
  • src/WebContentLayerImpl.cpp: Removed.
  • src/WebContentLayerImpl.h: Removed.
  • src/WebLayer.cpp: Removed.
  • src/WebLayerImpl.cpp: Removed.
  • src/WebLayerImpl.h: Removed.
  • src/WebLayerTreeView.cpp: Removed.
  • src/WebLayerTreeViewImpl.cpp: Removed.
  • src/WebLayerTreeViewImpl.h: Removed.
03:54 Changeset [96926] by podivilov@chromium.org

2011-10-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, revert r96924.

  • public/WebContentLayer.h:
03:19 Changeset [96925] by vsevik@chromium.org

Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
https://bugs.webkit.org/show_bug.cgi?id=69558

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
03:12 Changeset [96924] by podivilov@chromium.org

2011-10-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix mac build after r96909.

  • public/WebContentLayer.h:
02:53 Changeset [96923] by annacc@chromium.org

Turn ENABLE_VIDEO_TRACK on for chromium.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

  • features.gypi:
02:51 Changeset [96922] by mario@webkit.org

[GTK] Don't expose objects with unknown role on GTK
https://bugs.webkit.org/show_bug.cgi?id=69561

Reviewed by Chris Fleizach.

Source/WebCore:

Ignore accessibility objects in accessibilityPlatformIncludesObject.

Test: platform/gtk/accessibility/unknown-roles-not-exposed.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
For unknown accessibility objects, return IgnoreObject.

LayoutTests:

New test to check that unknown objects are not exposed in GTK.

  • platform/gtk/accessibility/unknown-roles-not-exposed-expected.txt: Added.
  • platform/gtk/accessibility/unknown-roles-not-exposed.html: Added.

Added new expectation for new accessibility layout test introduced
in r96127 that was not possible to add before because of this bug.

  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
02:35 Changeset [96921] by philn@webkit.org

Unreviewed, GTK baselines for
security/redirect-BLOCKED-to-localURL.html test.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.
02:33 Changeset [96920] by loislo@chromium.org

Web Inspector: UI performance test for logging 100 messages to the console.
https://bugs.webkit.org/show_bug.cgi?id=69608

Reviewed by Pavel Feldman.

  • inspector/performance/resources/console-append-100-lines.html: Added.
02:27 Changeset [96919] by pfeldman@chromium.org

2011-10-07 Pavel Feldman <pfeldman@google.com>

Not reviewed: also add glass pane to the frame document's body.

  • src/js/DevTools.js:
02:19 Changeset [96918] by tkent@chromium.org

Move <input type=file> tests to fast/forms/file/
https://bugs.webkit.org/show_bug.cgi?id=69504

Reviewed by Hajime Morita.

  • fast/forms/file-input-change-event-expected.txt: Removed.
  • fast/forms/file-input-change-event.html: Removed.
  • fast/forms/file-input-direction.html: Removed.
  • fast/forms/file-input-disabled.html: Removed.
  • fast/forms/file-input-hit-test-expected.txt: Removed.
  • fast/forms/file-input-hit-test.html: Removed.
  • fast/forms/file-input-reset-expected.html: Removed.
  • fast/forms/file-input-reset.html: Removed.
  • fast/forms/file/file-input-change-event-expected.txt: Copied from LayoutTests/fast/forms/file-input-change-event-expected.txt.
  • fast/forms/file/file-input-change-event.html: Copied from LayoutTests/fast/forms/file-input-change-event.html.
  • fast/forms/file/file-input-direction.html: Copied from LayoutTests/fast/forms/file-input-direction.html.
  • fast/forms/file/file-input-disabled.html: Copied from LayoutTests/fast/forms/file-input-disabled.html.
  • fast/forms/file/file-input-hit-test-expected.txt: Copied from LayoutTests/fast/forms/file-input-hit-test-expected.txt.
  • fast/forms/file/file-input-hit-test.html: Copied from LayoutTests/fast/forms/file-input-hit-test.html.
  • fast/forms/file/file-input-reset-expected.html: Copied from LayoutTests/fast/forms/file-input-reset-expected.html.
  • fast/forms/file/file-input-reset.html: Copied from LayoutTests/fast/forms/file-input-reset.html.
  • fast/forms/file/get-file-upload-expected.txt: Copied from LayoutTests/fast/forms/get-file-upload-expected.txt.
  • fast/forms/file/get-file-upload.html: Copied from LayoutTests/fast/forms/get-file-upload.html.
  • fast/forms/file/hidden-input-file-expected.html: Copied from LayoutTests/fast/forms/hidden-input-file.html.
  • fast/forms/file/hidden-input-file.html: Copied from LayoutTests/fast/forms/hidden-input-file.html.
  • fast/forms/file/input-file-directory-upload-expected.txt: Copied from LayoutTests/fast/forms/input-file-directory-upload-expected.txt.
  • fast/forms/file/input-file-directory-upload.html: Copied from LayoutTests/fast/forms/input-file-directory-upload.html.
  • fast/forms/file/input-file-label-expected.txt: Copied from LayoutTests/fast/forms/input-file-label-expected.txt.
  • fast/forms/file/input-file-label.html: Copied from LayoutTests/fast/forms/input-file-label.html.
  • fast/forms/file/input-file-not-open-without-gesture-expected.txt: Copied from LayoutTests/fast/forms/input-file-not-open-without-gesture-expected.txt.
  • fast/forms/file/input-file-not-open-without-gesture.html: Copied from LayoutTests/fast/forms/input-file-not-open-without-gesture.html.
  • fast/forms/file/input-file-re-render.html: Copied from LayoutTests/fast/forms/input-file-re-render.html.
  • fast/forms/get-file-upload-expected.txt: Removed.
  • fast/forms/get-file-upload.html: Removed.
  • fast/forms/hidden-input-file.html: Removed.
  • fast/forms/input-file-directory-upload-expected.txt: Removed.
  • fast/forms/input-file-directory-upload.html: Removed.
  • fast/forms/input-file-label-expected.txt: Removed.
  • fast/forms/input-file-label.html: Removed.
  • fast/forms/input-file-not-open-without-gesture-expected.txt: Removed.
  • fast/forms/input-file-not-open-without-gesture.html: Removed.
  • fast/forms/input-file-re-render.html: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/file: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/file-input-direction-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/file: Added.
  • platform/chromium-cg-mac/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-direction-expected.png.
  • platform/chromium-cg-mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-disabled-expected.png.
  • platform/chromium-cg-mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-cg-mac/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-linux/fast/forms/file: Added.
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-linux/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-direction-expected.png.
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.png.
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.txt.
  • platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-linux/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.txt.
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/file: Added.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.png.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-mac/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/chromium-mac/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-win/fast/forms/file: Added.
  • platform/chromium-win/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-win/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-win/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/chromium-win/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/chromium-win/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-direction-expected.png.
  • platform/chromium-win/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-win/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.png.
  • platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.txt.
  • platform/chromium-win/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-win/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.txt.
  • platform/chromium-win/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/chromium-win/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/file: Added.
  • platform/gtk/fast/forms/file-input-direction-expected.png: Removed.
  • platform/gtk/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/gtk/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/gtk/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/gtk/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/file-input-direction-expected.png.
  • platform/gtk/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/file-input-direction-expected.txt.
  • platform/gtk/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/file-input-disabled-expected.png.
  • platform/gtk/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/file-input-disabled-expected.txt.
  • platform/gtk/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.png.
  • platform/gtk/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt.
  • platform/gtk/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/gtk/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/gtk/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/file: Added.
  • platform/mac-leopard/fast/forms/file-input-direction-expected.png: Removed.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-direction-expected.png.
  • platform/mac-leopard/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.png.
  • platform/mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
  • platform/mac-leopard/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-file-re-render-expected.png.
  • platform/mac-leopard/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/mac/Skipped:
  • platform/mac/fast/forms/file: Added.
  • platform/mac/fast/forms/file-input-direction-expected.png: Removed.
  • platform/mac/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/mac/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/mac/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file-input-direction-expected.png.
  • platform/mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-direction-expected.txt.
  • platform/mac/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
  • platform/mac/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
  • platform/mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-file-re-render-expected.png.
  • platform/mac/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-file-re-render-expected.txt.
  • platform/mac/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/mac/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/mac/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/mac/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/fast/forms/file: Added.
  • platform/qt/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/qt/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/qt/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/file-input-direction-expected.txt.
  • platform/qt/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/file-input-disabled-expected.txt.
  • platform/qt/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/win/Skipped:
02:12 Changeset [96917] by pfeldman@chromium.org

Web Inspector: glass pane does not disappear after network panel's grid column resize.
https://bugs.webkit.org/show_bug.cgi?id=69607

Reviewed by Yury Semikhatsky.

  • src/js/DevTools.js:
02:04 Changeset [96916] by paroga@webkit.org

Unreviewed build fix after r95604.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::isLinkVisited):
(PlatformStrategiesWinCE::addVisitedLink):

01:31 Changeset [96915] by pfeldman@chromium.org

Web Inspector: add Elements and Network panels to the compilation
https://bugs.webkit.org/show_bug.cgi?id=69604

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-07
Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):

  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:
  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._startEditingConfig):

  • inspector/front-end/Drawer.js:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
(WebInspector.ElementsPanel.prototype._registerShortcuts):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
(WebInspector.ElementsTreeElement.prototype._startEditingTagName):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog._show):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype.startEditing):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype._updateOffscreenRows):
(WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):

  • inspector/front-end/Panel.js:
  • inspector/front-end/Popover.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._editBreakpointCondition):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/TimelineGrid.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.EditingConfig):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.formatLocalized):
(WebInspector.openLinkExternallyLabel):
(WebInspector.openInNetworkPanelLabel):
(WebInspector.copyLinkAddressLabel):

  • inspector/front-end/externs.js:

(WebInspector.extensionServer.notifyObjectSelected):
(WebInspector.openResource):

  • inspector/front-end/inspector.js:

(WebInspector.resourceForURL):

01:11 Changeset [96914] by annacc@chromium.org

Change enum value names for TextTrack::readyState and TextTrack::mode
https://bugs.webkit.org/show_bug.cgi?id=69603

Reviewed by David Levin.

No new tests. No new functionality.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::trackLoadStarted):
(WebCore::LoadableTextTrack::trackLoadError):
(WebCore::LoadableTextTrack::trackLoadCompleted):

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):

  • html/TextTrack.h:
00:59 Changeset [96913] by annacc@chromium.org

Adding parens in WebVTTParser.cpp to appease compiler preferences.
https://bugs.webkit.org/show_bug.cgi?id=69602

Reviewed by David Levin.

No new tests. No new functionality.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

00:43 Changeset [96912] by japhet@chromium.org

Always call setActive() in WebViewImpl::setFocus(),
not just when enabling focus.
https://bugs.webkit.org/show_bug.cgi?id=65220

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::loadFrame):
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp: Added.
00:06 Changeset [96911] by tkent@chromium.org

Test update for r96893.
https://bugs.webkit.org/show_bug.cgi?id=53752

r96893 changed the behavior of dataset-gc.html and
dataset-xhtml.xhtml. We update these tests because the new
behavior matches to Firefox and Opera.

  • fast/dom/dataset-gc-expected.txt:
  • fast/dom/dataset-xhtml-expected.txt:
  • fast/dom/script-tests/dataset-gc.js:
  • fast/dom/script-tests/dataset-xhtml.js:
  • platform/chromium/test_expectations.txt:
00:04 Changeset [96910] by bbudge@chromium.org

Adds a field, "saveAs", to WebFileChooserParams to present the file chooser
dialog in "Save As" mode (allows the user to choose a possibly non-existent file
for saving).
https://bugs.webkit.org/show_bug.cgi?id=69301

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h:

(WebKit::WebFileChooserParams::WebFileChooserParams):

10/06/11:

23:49 Changeset [96909] by commit-queue@webkit.org

Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-06
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Added.

(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • public/WebContentLayerClient.h: Added.

(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • public/WebLayer.h: Added.

(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerClient.h: Added.

(WebKit::WebLayerClient::~WebLayerClient):

  • public/WebLayerTreeView.h: Added.

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerTreeViewClient.h: Added.

(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • src/WebContentLayer.cpp: Added.

(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):

  • src/WebContentLayerImpl.cpp: Added.

(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):

  • src/WebContentLayerImpl.h: Added.
  • src/WebLayer.cpp: Added.

(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):

  • src/WebLayerImpl.cpp: Added.

(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):

  • src/WebLayerImpl.h: Added.
  • src/WebLayerTreeView.cpp: Added.

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):

  • src/WebLayerTreeViewImpl.cpp: Added.

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h: Added.
23:19 Changeset [96908] by tkent@chromium.org

[Chromium] Build fix for r96907.

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::valueChanged):
Use HTMLSelectElement instead of SelectElement.

23:05 Changeset [96907] by tkent@chromium.org

Remove SelectElement class
https://bugs.webkit.org/show_bug.cgi?id=69518

Reviewed by Ryosuke Niwa.

SelectElement used to be an abstract class for HTMLSelectElement
and WMLSelectElement. SelectElement is not needed anymore because
WML was removed.

This patch just removes SelectElement by moving SelectElement
functions to HTMLSelectElement.

No new tests. Just a refactoring.

  • WebCore.vcproj/WebCore.vcproj:

Rename dom\SelectElementWin.cpp to html\HTMLSelectElementWin.cpp.

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::setSelected):
Remove unnecessary cast.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
Use HTMLSelectElement instead of SelectElement.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(optionFromSelection): ditto.
(webkit_accessible_selection_get_selection_count): ditto.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(notifyChildrenSelectionChange): ditto.

  • dom/OptionElement.cpp:

(WebCore::OptionElement::optionIndex): ditto.

  • dom/OptionElement.h: ditto.
  • dom/SelectElement.cpp:

(WebCore::SelectElementData::checkListItems): ditto.
(WebCore::SelectElementData::listItems): ditto.

  • dom/SelectElementWin.cpp: Removed.
  • dom/SelectElement.h: Removed SelectElement class declaration.
  • html/HTMLSelectElement.cpp: Move functions from SelectElement.cpp.

(WebCore::HTMLSelectElement::selectedIndex):
Removed 'SelectElement::' because the function is moved to HTMLSelectElement.
(WebCore::HTMLSelectElement::deselectItems): dito.
(WebCore::HTMLSelectElement::setSelectedIndex): dito.
(WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
(WebCore::HTMLSelectElement::activeSelectionEndListIndex): ditto.
(WebCore::HTMLSelectElement::length): ditto.
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.
(WebCore::HTMLSelectElement::parseMappedAttribute): ditto.
(WebCore::HTMLSelectElement::selectAll): ditto.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::recalcListItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::defaultEventHandler): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::menuListOnChange): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
(WebCore::HTMLSelectElement::scrollToSelection): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree): ditto.
(WebCore::nextValidIndex): Moved from SelectElement.cpp.
(WebCore::nextSelectableListIndex): ditto.
(WebCore::previousSelectableListIndex): ditto.
(WebCore::firstSelectableListIndex): ditto.
(WebCore::lastSelectableListIndex): ditto.
(WebCore::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): ditto.
(WebCore::HTMLSelectElement::parseMultipleAttribute): ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::stripLeadingWhiteSpace): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::optionCount): ditto.
(WebCore::toSelectElement): ditto.

  • html/HTMLSelectElementWin.cpp: Copied from Source/WebCore/dom/SelectElementWin.cpp.

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

  • html/HTMLSelectElement.h: Removed 'virtual' of SelectElement functions.

(WebCore::HTMLSelectElement::size):
(WebCore::HTMLSelectElement::multiple):
(WebCore::HTMLSelectElement::listItems):
(WebCore::HTMLSelectElement::updateValidity):

  • rendering/RenderListBox.cpp: Replace SelectElement with HTMLSelectElement

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::scrollToRevealSelection):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::valueChanged):

  • rendering/RenderMenuList.cpp: Replace SelectElement with HTMLSelectElement

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::valueChanged):
(WebCore::RenderMenuList::listBoxSelectItem):
(WebCore::RenderMenuList::multiple):
(WebCore::RenderMenuList::didSetSelectedIndex):
(WebCore::RenderMenuList::didUpdateActiveOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemAccessibilityText):
(WebCore::RenderMenuList::itemToolTip):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::listSize):
(WebCore::RenderMenuList::selectedIndex):
(WebCore::RenderMenuList::itemIsSeparator):
(WebCore::RenderMenuList::itemIsLabel):
(WebCore::RenderMenuList::itemIsSelected):
(WebCore::RenderMenuList::setTextFromItem):

22:42 Changeset [96906] by abarth@webkit.org

Port PixelZoomer to work in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69577

Reviewed by David Levin.

Tools:

This implementation of PixelZoomer is basically a fork of the
implementation used by results.html. These two apps have different
requirements on where this code lives. results.html wants to be
self-contained whereas garden-o-matic wants to live in the public_html
folder of the buildbot. We could do something fancy here to share the
code, but that's not likely to be of much benefit.

I had to change a few things about pixelzoomer to accounter for the
differences in DOM between results.html and garden-o-matic, but
surprisingly little. I also moved all the code into an anonymous
function, which is the style we're suing for module separation in
garden-o-matic. Finally, some jQuery-ims snuck in because I didn't
want to drag along too many extra functions from results.html.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.

(.pixel-zoom-container):
(.pixel-zoom-container > *):
(.pixel-zoom-container .scaled-image-container):
(.scaled-image-container > img):

LayoutTests:

Change the timeout constant to so that it matches garden-o-matic. In
garden-o-matic, 200 MS was too fast because you mouse around the UI a
lot more.

  • fast/harness/results.html:
22:22 Changeset [96905] by amruthraj@motorola.com

Add Motorola Mobility to team.html
https://bugs.webkit.org/show_bug.cgi?id=69597

Reviewed by Ryosuke Niwa.

  • team.html:
22:16 Changeset [96904] by bfulgham@webkit.org

[WinCairo] Correct improper identification of WKQC extensions.
https://bugs.webkit.org/show_bug.cgi?id=69600

  • DerivedSources.make: Make sure we are not building the

WinCairo variant.

21:33 Changeset [96903] by mrowe@apple.com

Versioning.

21:32 Changeset [96902] by mrowe@apple.com

New tag.

21:21 Changeset [96901] by simonjam@chromium.org

[Chromium] Fix test expectations. Broken test from r96870. Bug filed.

Unreviewed.

  • platform/chromium/test_expectations.txt: Added smart-paste-008.html on all platforms.
21:20 Changeset [96900] by commit-queue@webkit.org

Unreviewed, rolling out r96896.
http://trac.webkit.org/changeset/96896
https://bugs.webkit.org/show_bug.cgi?id=69601

broke windows and mac chromium builds (Requested by simonjam
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Removed.
  • public/WebContentLayerClient.h: Removed.
  • public/WebLayer.h: Removed.
  • public/WebLayerClient.h: Removed.
  • public/WebLayerTreeView.h: Removed.
  • public/WebLayerTreeViewClient.h: Removed.
  • src/WebContentLayer.cpp: Removed.
  • src/WebContentLayerImpl.cpp: Removed.
  • src/WebContentLayerImpl.h: Removed.
  • src/WebLayer.cpp: Removed.
  • src/WebLayerImpl.cpp: Removed.
  • src/WebLayerImpl.h: Removed.
  • src/WebLayerTreeView.cpp: Removed.
  • src/WebLayerTreeViewImpl.cpp: Removed.
  • src/WebLayerTreeViewImpl.h: Removed.
20:52 Changeset [96899] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

  • DEPS:
20:23 Changeset [96898] by rniwa@webkit.org

Windows rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because it's a real failure
(tracked by the bug 69587).

  • platform/win/Skipped:
  • platform/win/editing/deleting/delete-br-010-expected.txt:
  • platform/win/editing/deleting/regional-indicators-expected.txt: Removed.
  • platform/win/editing/inserting/insert-3907422-fix-expected.txt: Copied from LayoutTests/editing/inserting/insert-3907422-fix-expected.txt.
  • platform/win/editing/pasteboard/paste-text-002-expected.txt: Copied from LayoutTests/editing/pasteboard/paste-text-002-expected.txt.
  • platform/win/editing/pasteboard/paste-text-004-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-text-004-expected.txt.
  • platform/win/editing/pasteboard/paste-text-005-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-text-005-expected.txt.
  • platform/win/editing/pasteboard/paste-text-008-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-text-008-expected.txt.
  • platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
20:14 Changeset [96897] by rniwa@webkit.org

Chromium Mac rebaselines after r96870.

  • platform/chromium-cg-mac-snowleopard/editing: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-3907422-fix-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-004-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/editing/spelling: Added.
  • platform/chromium-cg-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/pasteboard: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing: Added.
  • platform/chromium-mac-snowleopard/editing/inserting: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3907422-fix-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-004-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/spelling: Added.
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast: Added.
  • platform/chromium-mac-snowleopard/fast/events: Added.
  • platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Added.
  • platform/chromium-win/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
20:01 Changeset [96896] by commit-queue@webkit.org

Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-06
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Added.

(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • public/WebContentLayerClient.h: Added.

(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • public/WebLayer.h: Added.

(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerClient.h: Added.

(WebKit::WebLayerClient::~WebLayerClient):

  • public/WebLayerTreeView.h: Added.

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerTreeViewClient.h: Added.

(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • src/WebContentLayer.cpp: Added.

(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):

  • src/WebContentLayerImpl.cpp: Added.

(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):

  • src/WebContentLayerImpl.h: Added.
  • src/WebLayer.cpp: Added.

(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):

  • src/WebLayerImpl.cpp: Added.

(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):

  • src/WebLayerImpl.h: Added.
  • src/WebLayerTreeView.cpp: Added.

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):

  • src/WebLayerTreeViewImpl.cpp: Added.

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h: Added.
19:55 Changeset [96895] by joepeck@webkit.org

Reviewed by Kent Tamura.

Pass "accept" mime type information into FileChooser at all call sites
https://bugs.webkit.org/show_bug.cgi?id=69592

No new tests. This only exposes some more information to
WebKit ports, no functionality change in WebCore.

  • html/FileInputType.cpp:

(WebCore::FileInputType::receiveDropForDirectoryUpload):

19:48 Changeset [96894] by fpizlo@apple.com

DFG should not always speculate that ConvertThis is operating on an object
https://bugs.webkit.org/show_bug.cgi?id=69570

Reviewed by Oliver Hunt.

Mostly neutral, but with a slight regression in Kraken since it increases
coverage in DFG and thus reveals some performance pathologies (which I
prefer to think of as performance opportunities, in a good way).

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):

  • bytecode/PredictedType.h:

(JSC::isOtherPrediction):
(JSC::mergePredictions):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

19:44 Changeset [96893] by tkent@chromium.org

[JSC binding] Fix inconsistent behavior of DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=53752

Reviewed by Darin Adler.

Source/WebCore:

The dataset behavior was inconsistent. The get operation handled
data-* attributes first, and the put and delete operations handled
JavaScript properties first.

Like Firefox and Opera, the put and delete operations should
handle data-* attribute first.

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deleteProperty):

Handles DOMStringMap first, then returns false if the DOMStringMap makes an error.

(WebCore::JSDOMStringMap::putDelegate): ditto.

LayoutTests:

  • fast/dom/dataset-expected.txt:
  • fast/dom/script-tests/dataset.js:
    • Change the expectation for a case deleting a property of which name can't be a data-* attribute. This behavior matches to Firefox and Opera.
    • Add test cases to check put/get/delete priorities.
  • platform/chromium/test_expectations.txt: V8 binding is not ready for this change.
19:43 Changeset [96892] by thakis@chromium.org

[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
https://bugs.webkit.org/show_bug.cgi?id=69589

Reviewed by Adam Barth.

When building with make -j40, all the binding rules are built en bloc. Since this script currently
uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
255 by default, so the build used to fail with
"open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.

  • WebCore.gyp/scripts/rule_binding.py:
19:33 Changeset [96891] by jer.noble@apple.com

Some media tests fail when run inside a directory path containing periods.
https://bugs.webkit.org/show_bug.cgi?id=69580

Reviewed by Darin Adler.

To determine the extension, retrieve the last string following a period instead of the second.

  • media/media-blocked-by-beforeload.html:
  • media/video-source-load.html:
  • media/video-source-moved.html:
  • media/video-source-removed.html:
19:23 Changeset [96890] by gyuyoung.kim@samsung.com

[EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
https://bugs.webkit.org/show_bug.cgi?id=69505

Reviewed by Andreas Kling.

Source/WebKit/efl:

ewk_view_viewport_attributes_get() has used implicit casting for width and height of viewport.
However, it is better to use *int* data type as parameter data type instead of *float* casting.

  • ewk/ewk_view.cpp:

(ewk_view_viewport_attributes_get):

  • ewk/ewk_view.h:

Tools:

  • EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.

(on_viewport_changed):

19:09 Changeset [96889] by mhahnenberg@apple.com

Windows build fix

Unreviewed build fix. Weird runtime failures on Windows due to
linking issues caused by the ClassInfo struct in JSByteArray not
being declared with JS_EXPORTDATA.

  • runtime/JSByteArray.h:
18:56 Changeset [96888] by rniwa@webkit.org

Chromium Windows and Chromium Linux rebaselines for r96870. Also skip editing/pasteboard/smart-paste-008.html
because it's a real failure (tracked by the bug 69587).

  • platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/chromium-win/editing/deleting/delete-br-010-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-011-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-012-expected.txt:
  • platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Added.
  • platform/chromium-win/editing/inserting/multiple-lines-selected-expected.txt:
  • platform/chromium-win/editing/pasteboard/5032095-expected.txt:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-text-004-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
  • platform/chromium-win/fast/events/ondragenter-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:09 Changeset [96887] by bfulgham@webkit.org

[WinCairo] Unreviewed test correction.

  • Scripts/webkitdirs.pm:

(argumentsForConfiguration): Add 'wincairo' option to the set of
configuration flags used by run-javascript-core tests, so that it
does not attempt to run Apple's release version.

18:02 Changeset [96886] by rniwa@webkit.org

Qt rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because it's a real failure
(tracked by the bug 69587).

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/qt/editing/deleting/delete-br-010-expected.txt:
  • platform/qt/editing/deleting/delete-line-012-expected.txt:
  • platform/qt/editing/deleting/delete-listitem-001-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Copied from LayoutTests/editing/inserting/insert-3907422-fix-expected.txt.
  • platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Copied from LayoutTests/editing/pasteboard/interchange-newline-1-expected.txt.
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Copied from LayoutTests/editing/pasteboard/paste-text-002-expected.txt.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Copied from LayoutTests/editing/pasteboard/paste-text-003-expected.txt.
  • platform/qt/editing/pasteboard/paste-text-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-008-expected.txt:
17:49 Changeset [96885] by bfulgham@webkit.org

[WinCairo] Unreviewed test correction.

  • BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set of known build slave types so that test-result-archive won't fail when running tests.
17:49 Changeset [96884] by simonjam@chromium.org

[Chromium] Remove passing tests from test_expectations.txt.

Unreviewed.

  • platform/chromium/test_expectations.txt:
17:47 Changeset [96883] by fpizlo@apple.com

Structure does not reset m_previous when pinning the property map
https://bugs.webkit.org/show_bug.cgi?id=69583

Reviewed by Gavin Barraclough.

This is an 0.6% performance improvement in V8, and 0.2% overall.

  • runtime/Structure.cpp:

(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):

  • runtime/Structure.h:
17:43 Changeset [96882] by rniwa@webkit.org

GTK rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because it's a real failure
(tracked by the bug 69587).

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/gtk/editing/deleting/delete-br-010-expected.txt:
  • platform/gtk/editing/deleting/delete-line-012-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Copied from

LayoutTests/editing/inserting/insert-3907422-fix-expected.txt.

  • platform/gtk/editing/inserting/multiple-lines-selected-expected.txt:
  • platform/gtk/editing/pasteboard/5032095-expected.txt:
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Copied from

LayoutTests/editing/pasteboard/interchange-newline-1-expected.txt.

  • platform/gtk/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/gtk/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/gtk/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Copied from

LayoutTests/editing/pasteboard/paste-text-002-expected.txt.

  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Copied from

LayoutTests/editing/pasteboard/paste-text-003-expected.txt.

  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
17:34 Changeset [96881] by andersca@apple.com

When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
https://bugs.webkit.org/show_bug.cgi?id=69586

Reviewed by Darin Adler.

../JavaScriptCore:

  • Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

  • jsc.cpp:

(runInteractive):
Move interpreterName into runInteractive.

  • wtf/StdLibExtras.h:

When building with clang, disable the -Wglobal-constructors and -Wexit-time-destructors
warnings around the variable declaration.

../JavaScriptGlue:

  • Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebCore:

  • Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

  • WebCore.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(gaussianKernelFactor):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):
Change the gaussian kernel factor global to be an inline function instead.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebKit/mac:

  • Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

../WebKit2:

  • Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

  • WebKit2.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

17:20 Changeset [96880] by andersca@apple.com

Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69584

Reviewed by Darin Adler.

../JavaScriptCore:

Add DEFINE_DEBUG_ONLY_GLOBAL macro.

  • wtf/StdLibExtras.h:

../WebCore:

Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.

  • bindings/js/JSLazyEventListener.cpp:
  • dom/Node.cpp:
  • dom/Range.cpp:
  • history/CachedPage.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/cache/CachedResource.cpp:
  • page/Frame.cpp:
  • page/Page.cpp:
  • rendering/BidiRun.cpp:
  • rendering/RenderObject.cpp:
  • svg/SVGElementInstance.cpp:
  • xml/XMLHttpRequest.cpp:

../WebKit/mac:

Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

../WebKit2:

Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.

  • UIProcess/WebContext.cpp:
  • UIProcess/WebPageProxy.cpp:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebPage.cpp:
17:17 Changeset [96879] by jamesr@google.com

[chromium] Remove USE(THREADED_COMPOSITING) from the tree
https://bugs.webkit.org/show_bug.cgi?id=69489

Reviewed by Darin Fisher.

Source/WebCore:

This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Updated CCLayerTreeHostTest::onEndTest() to pump all pending messages
after posting the Quit task and before tearing down any test
infrastructure.

  • features.gypi:
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):

17:16 Changeset [96878] by jamesr@google.com

[chromium] Remove obsolete WebWidgetClient::didActivateAcceleratedCompositing call
https://bugs.webkit.org/show_bug.cgi?id=69576

Reviewed by Darin Fisher.

The chromium implementation of this function went away at r104017.

  • public/WebWidgetClient.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

16:58 Changeset [96877] by dgrogan@chromium.org

Return null for the value of IDB key cursors instead of ASSERTing
https://bugs.webkit.org/show_bug.cgi?id=69131

This is in support of the IndexedDB performance improvement here:
http://codereview.chromium.org/7834006/

Reviewed by Tony Chang.

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::value):

16:52 Changeset [96876] by ap@apple.com

[Mac] Should be able to scroll embedded PDFs using mouse
https://bugs.webkit.org/show_bug.cgi?id=69579

Reviewed by Darin Adler.

Hit testing doesn't find scrollbars installed by a plug-in, so mouse events don't work.

As we want to use WebKit scrollbars with PDF plug-in, a cleaner long-term solution would be
to have a base class under PluginViewBase that can handle scrolling instead of doing that
in PluginView and Plugin.

  • plugins/PluginViewBase.h: (WebCore::PluginViewBase::horizontalScrollbar): (WebCore::PluginViewBase::verticalScrollbar): Added accessors for scrollbars installed by plug-in.
  • rendering/nodeAtPoint.cpp: (WebCore::RenderEmbeddedObject::nodeAtPoint): Like RenderLayer, add scrollbars to hit result after normal hit testing.
  • rendering/RenderEmbeddedObject.h: Added a nodeAtPoint override.
  • rendering/RenderWidget.h: Made nodeAtPoint() protected instead of private, so that RenderEmbeddedObject could call it.
16:48 Changeset [96875] by oliver@apple.com

Write barrier shouldn't allocate temporaries inside control flow
https://bugs.webkit.org/show_bug.cgi?id=69582

Reviewed by Gavin Barraclough.

Reorder the code to avoid spill-related badness.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::writeBarrier):

16:42 Changeset [96874] by mitz@apple.com

<rdar://problem/9717490> Flash of white when navigating daringfireball.net
https://bugs.webkit.org/show_bug.cgi?id=69581

Reviewed by Darin Adler.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.

16:40 Changeset [96873] by mitz@apple.com

Added a comment explaining code added in r96834.

Suggested by Darin Adler.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

16:39 Changeset [96872] by alexis.menard@openbossa.org

[Qt][WK2] WebIconDatabase expects a file path not a directory.
https://bugs.webkit.org/show_bug.cgi?id=69557

Reviewed by Andreas Kling.

WebIconDatabase::setDatabasePath expects a file path not a directory.
I used the same name as the Mac port.

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

16:39 Changeset [96871] by fpizlo@apple.com

DFG::shouldSpeculate methods are too complicated
https://bugs.webkit.org/show_bug.cgi?id=69560

Reviewed by Geoffrey Garen.

Moved shouldSpeculate methods to DFG::Node, and cleaned them up to
just use node predictions.

By itself this would have meant that SpeculativeJIT code would have
had to say things like m_jit.graph()[nodeIndex].shouldSpeculateXYZ().
So this adds an at(NodeIndex) method to JITCodeGenerator. I replaced
all uses of the m_jit.graph()[nodeIndex] idiom with at(nodeIndex).

This is an 0.4% progression overall that shows up in all benchmarks,
for reasons unknown.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::at):
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::detectPeepHoleBranch):
(JSC::DFG::integerResult):
(JSC::DFG::noResult):
(JSC::DFG::cellResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::storageResult):
(JSC::DFG::doubleResult):
(JSC::DFG::initConstantInfo):
(JSC::DFG::appendCallWithExceptionCheck):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateDouble):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::shouldSpeculateArrayOrOther):
(JSC::DFG::Node::shouldSpeculateObject):
(JSC::DFG::Node::shouldSpeculateCell):
(JSC::DFG::Node::canSpeculateInteger):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::isKnownString):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

16:16 Changeset [96870] by rniwa@webkit.org

Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Reviewed by Enrica Casucci.

Source/WebCore:

This patch fundamentally alters the kind of styles we preserve while merging or moving paragraphs.
StylizedMarkupAccumulator no longer wraps nodes by computed style when it's not annotating for interchange.
Instead, it accumulates implicit and inline styles of ancestors of the serialized contents.

The most significant code change is in StyledMarkupAccumulator::serializeNodes where we setup m_wrappingStyle
by merging implicit and inline style of ancestors with mergeInlineAndImplicitStyleOfElement. Because it walks up
the DOM tree upwards, it should not be overriding any CSS properties. Consequently, mergeStyle,
mergeInlineStyleOfElement, and mergeInlineAndImplicitStyleOfElement are modified to take CSSPropertyOverrideMode.

New behavior matches that of Internet Explorer and Firefox when merging paragraphs.

Tests: editing/deleting/merge-paragraph-from-address.html

editing/deleting/merge-paragraph-from-h6-with-style-2.html
editing/deleting/merge-paragraph-from-h6-with-style.html
editing/deleting/merge-paragraph-from-h6.html
editing/deleting/merge-paragraph-from-listing.html
editing/deleting/merge-paragraph-from-p-with-style-2.html
editing/deleting/merge-paragraph-from-p-with-style-3.html
editing/deleting/merge-paragraph-from-p-with-style.html
editing/deleting/merge-paragraph-into-h1-with-style.html
editing/deleting/merge-paragraph-into-h1.html
editing/deleting/merge-paragraph-into-pre.html

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::hasValue): Made const.

  • css/CSSValueList.h:
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls mergeInlineStyleOfElement.
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Ditto.

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties): Takes a boolean includeBackgroundColor.
(WebCore::isEditingProperty): Extracted from elementIsStyledSpanOrHTMLEquivalent.
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Calls isEditingProperty.
(WebCore::EditingStyle::mergeTypingStyle): Calls mergeStyle.
(WebCore::EditingStyle::mergeInlineStyleOfElement): Takes CSSPropertyOverrideMode.
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Added.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Added.
(WebCore::mergeTextDecorationValues): Extracted from mergeStyle.
(WebCore::EditingStyle::mergeStyle): Takes CSSPropertyOverrideMode.

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::nodeToSplitToAvoidPastingIntoInlineNodesWithStyle): Extracted from doApply.
(WebCore::ReplaceSelectionCommand::doApply): Calls nodeToSplitToAvoidPastingIntoInlineNodesWithStyle.
(WebCore::ReplaceSelectionCommand::performTrivialReplace): Exit early when we need to split the tree to avoid
pasting into inline nodes with style. Also remove a collapsed or spurious br.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes):

LayoutTests:

Many rebaselines are due to text nodes merged correctly after ReplaceSelectionCommand because
they started to use the fast path (perfromTrivialReplace).

New tests:

  • editing/deleting/merge-paragraph-from-address-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-address.html: Added.
  • editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-2-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-2.html: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-3-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-3.html: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
  • editing/deleting/merge-paragraph-from-h6.html: Added.
  • editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-listing.html: Added.
  • editing/deleting/merge-paragraph-from-p-with-style-2-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-p-with-style-2.html: Added.
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-p-with-style.html: Added.
  • editing/deleting/merge-paragraph-into-blockquote-expected.txt:
  • editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
  • editing/deleting/merge-paragraph-into-h1.html: Added.
  • editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-pre.html: Added.

Rebaselines:

  • editing/pasteboard/5521237-expected.txt: A collapsed br at the end is removed.
  • editing/spelling/script-tests/spelling-backspace-between-lines.js: text nodes are merged.

(testWithDelete):
(testWithForwardDelete):

  • editing/spelling/spelling-backspace-between-lines-expected.txt:
  • editing/style/apply-through-end-of-document-expected.txt: A collapsed br at the end is removed.
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.txt: "bar" is merged into p from

pre and losing monospace style.

  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt: A text node is split into

two with no visual effect.

Rebaselines due to text nodes being merged:

  • editing/deleting/5032066-expected.txt:
  • editing/deleting/delete-across-editable-content-boundaries-2-expected.txt:
  • editing/deleting/delete-across-editable-content-boundaries-3-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/insert-div-text-into-text-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-list-2-expected.txt:
  • editing/pasteboard/merge-end-table-2-expected.txt:
  • editing/pasteboard/paste-after-inline-style-element-expected.txt:
  • editing/pasteboard/paste-blockquote-2-expected.txt:
  • editing/pasteboard/paste-blockquote-3-expected.txt:
  • editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
  • editing/pasteboard/paste-into-blockquote-with-document-font-color-expected.txt:
  • editing/pasteboard/pasting-word-in-div-extra-line-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/delete-line-012-expected.txt:
  • platform/mac/editing/deleting/delete-listitem-001-expected.txt:
  • platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
  • platform/mac/editing/pasteboard/5032095-expected.txt:
  • platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
16:02 Changeset [96869] by gavinp@chromium.org

REGRESSION (r96595): First frame in assertion backtraces is no longer labeled "1"
https://bugs.webkit.org/show_bug.cgi?id=69556

Reviewed by Adam Roben.

  • wtf/Assertions.cpp:
15:55 Changeset [96868] by inferno@chromium.org

Crash in VisiblePosition::canonicalPosition.
https://bugs.webkit.org/show_bug.cgi?id=69568

Reviewed by Ryosuke Niwa.

Source/WebCore:

Move the position's containerNode calculation after layout is
complete(in updateLayoutIgnorePendingStylesheets).

Test: editing/selection/selection-plugin-clear-crash.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::canonicalPosition):

LayoutTests:

  • editing/selection/selection-plugin-clear-crash-expected.txt: Added.
  • editing/selection/selection-plugin-clear-crash.html: Added.
15:47 Changeset [96867] by commit-queue@webkit.org

Unreviewed, rolling out r96861.
http://trac.webkit.org/changeset/96861
https://bugs.webkit.org/show_bug.cgi?id=69573

This patch didn't compile on windows (Requested by annacc on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

Source/WebCore:

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

Source/WebKit/chromium:

  • features.gypi:
15:44 Changeset [96866] by commit-queue@webkit.org

The GTK+ WebKit2 headers produce a lot of style warnings
https://bugs.webkit.org/show_bug.cgi?id=69481

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-06
Reviewed by David Levin.

Prevent emitting so many style warnings for GTK+ API. We skip header
files in the WebKit2 GTK+ API directory and also avoid warnings about
identifier names that begin with "webkit_" in files that contain the
string "gtk".

  • Scripts/webkitpy/style/checker.py: Do not check header files in

Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
adding the ability to specify a regular expression in the skip list. Remove
a few files from the skipped list that no longer exist.

  • Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
  • Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn

about identifiers that begin with "webkit_".

  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
15:43 Changeset [96865] by bfulgham@webkit.org

[WinCairo] Correct config.json for WinCairo Test builds.
https://bugs.webkit.org/show_bug.cgi?id=69272

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Remove old 'WinCairo Debug (Build)' label and replace with correct 'WinCairo Release' label.
14:59 Changeset [96864] by andersca@apple.com

In background window, page flashes white if it enters and then immediately leaves compositing mode
https://bugs.webkit.org/show_bug.cgi?id=69566
<rdar://problem/9521192>

Reviewed by Dan Bernstein.

Don't update the backing store state if we're just about to exit accelerated compositing mode. Otherwise
the UI process will try to render an empty layer tree for a short period of time, leading to a white flash.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):

14:58 Changeset [96863] by levin@chromium.org

Add a style checker watchlist definition and add myself to it.
https://bugs.webkit.org/show_bug.cgi?id=69564

Reviewed by Daniel Bates.

  • Scripts/webkitpy/common/config/watchlist:
14:56 Changeset [96862] by simonjam@chromium.org

[Chromium] Remove passing tests from test_expectations.txt.

Unreviewed.

  • platform/chromium/test_expectations.txt:
14:44 Changeset [96861] by annacc@chromium.org

Source/WebCore: Adding parens in WebVTTParser.cpp to appease compiler preferences.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

No new tests. No new functionality.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

Source/WebKit/chromium: Turn ENABLE_VIDEO_TRACK on for chromium.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

  • features.gypi:
14:43 Changeset [96860] by fpizlo@apple.com

DFG implementation of UInt32ToNumber is missing a break statement
https://bugs.webkit.org/show_bug.cgi?id=69552

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

14:36 Changeset [96859] by fsamuel@chromium.org

Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
https://bugs.webkit.org/show_bug.cgi?id=69009

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Upcoming patches may make use of absoluteBoundingBoxRect on a const RenderObject, so this needed to be fixed.
Making useTransforms default to true instead of false and replacing instances of absoluteBoundingBoxRect() to
absoluteBoundingBoxRectIgnoringTransforms() partially addreses FIXME: useTransforms should go away eventually.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::screenRect):

  • dom/Node.cpp:

(WebCore::Node::getRect):
(WebCore::Node::renderRect):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/DOMNodeHighlighter.cpp:
  • plugins/IFrameShimSupport.cpp:

(WebCore::getPluginOcclusions):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteQuads):

  • rendering/RenderBox.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):

  • rendering/RenderInline.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::paintingRootRect):

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteRects):
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteQuads):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteQuads):

  • rendering/RenderText.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::showPopup):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
(WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeSafari::paintSearchFieldResultsButton):

  • rendering/RenderView.cpp:

(WebCore::RenderView::absoluteRects):
(WebCore::RenderView::absoluteQuads):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::absoluteRects):

  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::absoluteQuads):

  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::absoluteQuads):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::absoluteRects):
(WebCore::RenderSVGModelObject::absoluteQuads):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::absoluteQuads):

  • rendering/svg/RenderSVGText.h:
  • testing/Internals.cpp:

(WebCore::Internals::boundingBox):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
14:34 Changeset [96858] by commit-queue@webkit.org

Move windows specific TextChecker implementation common to all ports.
https://bugs.webkit.org/show_bug.cgi?id=68532

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-10-06
Reviewed by Anders Carlsson.

All the TextChecker feature implementation files are moved outside of win port since they are
platform independent and can be moved across all ports. Only the implementation of TextChecker
class is platform dependent now and has been retained across all ports. Rest all files has been
moved for all ports usage.

  • Shared/API/c/WKBase.h: Add WKGrammarDetailRef & WKTextCheckerRef types.
  • Shared/API/c/win/WKBaseWin.h: Remove WKGrammarDetailRef & WKTextCheckerRef types.
  • Shared/APIObject.h: Moved TypeGrammarDetail & TypeTextChecker from platform specific section to UIProcess types.
  • UIProcess/API/C/WKAPICast.h: Added mapping for WKTextCheckerRef & WKGrammarDetailRef.
  • UIProcess/API/C/WKGrammarDetail.cpp: Renamed from Source/WebKit2/UIProcess/API/C/win/WKGrammarDetail.cpp.
  • UIProcess/API/C/WKGrammarDetail.h: Renamed from Source/WebKit2/UIProcess/API/C/win/WKGrammarDetail.h.
  • UIProcess/API/C/WKTextChecker.cpp: Renamed from Source/WebKit2/UIProcess/API/C/win/WKTextChecker.cpp.
  • UIProcess/API/C/WKTextChecker.h: Renamed from Source/WebKit2/UIProcess/API/C/win/WKTextChecker.h.
  • UIProcess/API/C/win/WKAPICastWin.h: Removed mapping for WKTextCheckerRef & WKGrammarDetailRef.
  • UIProcess/WebGrammarDetail.cpp: Renamed from Source/WebKit2/UIProcess/win/WebGrammarDetail.cpp.
  • UIProcess/WebGrammarDetail.h: Renamed from Source/WebKit2/UIProcess/win/WebGrammarDetail.h.
  • UIProcess/WebTextChecker.cpp: Renamed from Source/WebKit2/UIProcess/win/WebTextChecker.cpp.
  • UIProcess/WebTextChecker.h: Renamed from Source/WebKit2/UIProcess/win/WebTextChecker.h.
  • UIProcess/WebTextCheckerClient.cpp: Renamed from Source/WebKit2/UIProcess/win/WebTextCheckerClient.cpp.
  • UIProcess/WebTextCheckerClient.h: Renamed from Source/WebKit2/UIProcess/win/WebTextCheckerClient.h.
  • win/WebKit2.vcproj: Corrected paths for renamed files.
  • win/WebKit2Generated.make: Corrected paths for renamed files.
14:26 Changeset [96857] by hausmann@webkit.org

[Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
https://bugs.webkit.org/show_bug.cgi?id=69520

Reviewed by Csaba Osztrogonác.

.:

  • Source/WebKit.pri: Introduce convenience qt5 scope.
  • Source/WebKit.pro: Replace QT_MAJOR_VERSION stuff with qt5 scope.

Source/WebCore:

  • WebCore.pri: Use qt5 scope.
  • WebCore.pro: Use qt5 scope and pull in QtScript for the time being.

Source/WebKit/qt:

  • QtWebKit.pro: Convenience, use qt5 scope.
  • declarative/declarative.pro: Ditto.
  • tests/tests.pri: Ditto.
14:06 Changeset [96856] by tony@chromium.org

last frame of a multipart response is not displayed
https://bugs.webkit.org/show_bug.cgi?id=69449

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/multipart/load-last-non-html-frame.php

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): for non-progressive load pages, commit the load so the

last frame will be displayed.

  • loader/DocumentLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

  • http/tests/multipart/load-last-non-html-frame-expected.txt: Added.
  • http/tests/multipart/load-last-non-html-frame.php: Added.
13:59 Changeset [96855] by andersca@apple.com

Crash when PluginProxy object is destroyed inside PluginProxy::pluginScriptableNPObject
https://bugs.webkit.org/show_bug.cgi?id=69559
<rdar://problem/9704066>

Reviewed by Maciej Stachowiak.

Protect the plug-in itself in the call to pluginScriptableNPObject. In some cases, sending
the synchronous message to the plug-in process can end up causing the web process to handle
an incoming message that will destroy t he plug-in.

Unfortunately, this is highly timing-dependent and can't be tested reliably.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginScriptableNPObject):

13:49 Changeset [96854] by barraclough@apple.com

Unreviewed build fix for DFG JIT 32_64 release builds.

  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGJITCompiler32_64.cpp:
    • Remove three unused methods.
13:28 Changeset [96853] by simonjam@chromium.org

[Chromium] Rebaseline test missed in r96814.

Unreviewed.

  • platform/chromium-mac-snowleopard/printing/return-from-printing-mode-expected.png: Added.
  • platform/chromium-mac/printing/return-from-printing-mode-expected.png: Removed.
12:36 Changeset [96852] by krit@webkit.org

2011-10-06 Dirk Schulze <krit@webkit.org>

Unreviewed: 3rd chunk of new SVG baseline for lion.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-03-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
12:33 Changeset [96851] by ojan@chromium.org

extend flexbox testing to test children and parents of the flexbox
https://bugs.webkit.org/show_bug.cgi?id=69495

Reviewed by Tony Chang.

Checking children of flex items allows for making sure that padding/border
get properly taken into account. Checking the parent of the flexbox allows
for checking that margins on the flexbox itself are applied correctly.

Also, make it so that failures print the outerHTML of the failing case to
make it easier to diagnose.

  • css3/flexbox/001.html:
  • css3/flexbox/resources/flexbox.js:
  • css3/flexbox/writing-modes.html:
12:32 Changeset [96850] by caryclark@google.com

New chromium-mac image baselines for focus-ring fix in
http://code.google.com/p/chromium/issues/detail?id=97956

Committed for Elliot Poger <epoger@google.com> by Cary Clark.
Unreviewed.

  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5099303-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png:
  • platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-mac/fast/forms/input-paste-undo-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/inline/25277-2-expected.png:
  • platform/chromium-mac/fast/inline/25277-expected.png:
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.png:
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png:
  • platform/chromium-mac/fast/repaint/focus-ring-expected.png:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
12:30 Changeset [96849] by gavinp@chromium.org

conditionalize m_cachedScript stacks to just Chromium port
https://bugs.webkit.org/show_bug.cgi?id=69537

New stack saving telemetry code in ScriptElement shouldn't have
been put in all ports; just narrowing it to the chromium port will
save other ports the memory hit of this diagnostic code.

Reviewed by Nate Chapin.

No new tests.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
12:28 Changeset [96848] by commit-queue@webkit.org

[EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
https://bugs.webkit.org/show_bug.cgi?id=69450

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-06
Reviewed by Ryosuke Niwa.

This should avoid stderr messages when running
webarchive/test-link-rel-icon.html.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setIconDatabaseEnabled):

12:27 Changeset [96847] by commit-queue@webkit.org

Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
https://bugs.webkit.org/show_bug.cgi?id=69370

Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-06
Reviewed by James Robinson.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

12:20 Changeset [96846] by crogers@google.com

BiquadFilterNode must not reset filter state if type attribute is set to the same type
https://bugs.webkit.org/show_bug.cgi?id=69485

Reviewed by Kenneth Russell.

No new tests. This particular case is difficult to test with a layout test using OfflineAudioContext.

  • webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::setType):

  • webaudio/BiquadProcessor.h:
12:16 Changeset [96845] by krit@webkit.org

2011-10-06 Dirk Schulze <krit@webkit.org>

Unreviewed: 2nd chunk of new SVG baseline for lion.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/color-prof-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-04-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/painting-render-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-10-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
12:15 Changeset [96844] by commit-queue@webkit.org

[EFL] Do not create cairo surfaces with the wrong size for form elements
https://bugs.webkit.org/show_bug.cgi?id=69533

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-06
Reviewed by Ryosuke Niwa.

RenderThemeEfl::cacheThemePartResizeAndReset resizes the Ecore_Evas
associated with an entry, but did not reset the size attribute of the
struct -- in practice, this meant the subsequent call to
themePartCacheEntrySurfaceCreate would create a cairo surface with the
previous size, thus rendering an element with the wrong size.

No new tests, this is triggered by running running pixel tests for
running, in this order, fast/forms/button-sizes.html,
fast/forms/input-appearance-preventDefault.html,
fast/forms/input-appearance-spinbutton-disabled-readonly.html,
fast/forms/input-appearance-width.html,
fast/forms/input-button-sizes.html,
fast/forms/input-placeholder-text-indent.html and
fast/forms/input-text-click-inside.html (!).

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::cacheThemePartResizeAndReset): Reset the
size attribute when resizing the canvas.

12:07 Changeset [96843] by crogers@google.com

Make sure OfflineAudioContext can not be created with a sample-rate less than 44.1KHz
https://bugs.webkit.org/show_bug.cgi?id=69483

Reviewed by Kenneth Russell.

No new tests.

  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createBuffer):

12:03 Changeset [96842] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=69544

[CSS3 Regions] Compute the starting and ending regions of a block, so that we can clamp
descendants to those regions. This is preparation for having true overflow in the boxes
in each region, and it's also a performance optimization to reduce the amount of
region walking that the RenderFlowThread is doing.

Add a range map to RenderFlowThread to cache the start/end regions for each box.

Amend everyone who calls renderRegionForLine to pass in the box that is making the query.
This box is then used to clamp to start and end regions so that any regions outside of that
range will never be examined.

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/regions/top-overflow-out-of-second-region.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::regionAtBlockOffset):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::~RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::takeRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/top-overflow-out-of-second-region.html: Added.
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
12:00 Changeset [96841] by barraclough@apple.com

DFG JIT 32_64 should check type of values being filled by fillSpeculateInt
https://bugs.webkit.org/show_bug.cgi?id=69549

Reviewed by Oliver Hunt.

This breaks sunspider/3d-cube.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):

  • Speculation check on the tag.
11:58 Changeset [96840] by simonjam@chromium.org

[Chromium] Add baselines for new Mac tests. Revert test_expectations breakage.

Unreviewed.

  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/border-collapsing/cached-69296-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png.
  • platform/chromium/test_expectations.txt:
11:55 Changeset [96839] by abarth@webkit.org

Add missing tests for LegacyDefaultOptionalArguments for setCustomValidity
https://bugs.webkit.org/show_bug.cgi?id=69532

Reviewed by Andreas Kling.

These APIs are relatively new and it's unlikely that many folks will
call them without their argument. Making the parameters required
aligns WebKit more closely with the specifications for this API at
minimal compatibility cost.

  • fast/dom/set-custom-validity-with-too-few-arguments-expected.txt: Added.
  • fast/dom/set-custom-validity-with-too-few-arguments.html: Added.
11:33 Changeset [96838] by krit@webkit.org

Unreviewed: irst chunk of new SVG baseline for lion.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
11:31 Changeset [96837] by mhahnenberg@apple.com

Snow Leopard build fix

Unreviewed build fix

11:17 Changeset [96836] by barraclough@apple.com

Add explicit JSGlobalThis type.
https://bugs.webkit.org/show_bug.cgi?id=69478

Reviewed by Darin Adler.

JSC supports a split global object, as used by WebCore for the Window. As a stage
of making this visible to JSC, make it so that if the global this value is not the
global object itself, it must be a subclass of JSGlobalThis.

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::finishCreation):

  • Don't pass the thisValue to JSGlobalObject::finishCreation.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added JSGlobalThis.h
  • jsc.cpp:

(GlobalObject::finishCreation):

  • Don't pass the thisValue to JSGlobalObject::finishCreation.
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::finishCreation):

  • finishCreation takes a JSGlobalThis, or thisValue is implicit.
  • runtime/JSGlobalThis.h: Added.

(JSC::JSGlobalThis::create):
(JSC::JSGlobalThis::JSGlobalThis):
(JSC::JSGlobalThis::finishCreation):

  • Thin wrapper on JSNonFinalObject to allow type checking.
  • testRegExp.cpp:

(GlobalObject::finishCreation):

  • Don't pass the thisValue to JSGlobalObject::finishCreation.

Source/JavaScriptGlue:

  • JSRun.h:

(JSGlueGlobalObject::create):

  • Don't pass the thisValue to JSGlobalObject::finishCreation.

Source/WebCore:

  • ForwardingHeaders/runtime/JSGlobalThis.h: Added.
    • Added forwarding header.
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::finishCreation):

  • bindings/js/JSDOMGlobalObject.h:
    • finishCreation takes a JSGlobalThis, or thisValue is implicit.
  • bindings/js/JSDOMWindowShell.h:
    • Make the window shell a subclass of JSGlobalThis.
  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::finishCreation):

  • Don't pass the thisValue to JSGlobalObject::finishCreation.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • Don't pass the thisValue to JSGlobalObject::finishCreation, for worker contexts.
11:10 Changeset [96835] by annacc@chromium.org

Fix CodeGeneratorV8 for EnabledAtRuntime when class has no parent class.
https://bugs.webkit.org/show_bug.cgi?id=69480

Reviewed by Adam Barth.

No new tests. No new functionality, yet.

  • bindings/scripts/CodeGeneratorV8.pm:
11:04 Changeset [96834] by mitz@apple.com

<rdar://problem/10232866> Assertion failure beneath blockSelectionGaps() when a selected node is removed

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/selection/invalid-in-RenderView.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance): Ensure that the VisibleSelection used to set the selection
in the RenderView is valid, by reconstructing it from the current selection.

LayoutTests:

  • editing/selection/invalid-in-RenderView-expected.txt: Added.
  • editing/selection/invalid-in-RenderView.html: Added.
11:03 Changeset [96833] by carlosgc@webkit.org

[GTK] Add estimated-progress property to WebKitWebLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=69509

Reviewed by Martin Robinson.

It allows to monitor the estimated progress of a lof operation by
connecting to the notify signal.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didChangeProgress): Update estimated-progress property and notify when
it changes.
(webkitWebLoaderClientConstructed): Add implementations for
didStartProgress, didChangeProgress and didFinishProgress.
(webkitWebLoaderClientGetProperty):
(webkit_web_loader_client_class_init): Add estimated-progress property.
(webkit_web_loader_client_get_estimated_progress): Returns the
value of estimated-progress property.

  • UIProcess/API/gtk/WebKitWebLoaderClient.h:
  • UIProcess/API/gtk/tests/testloading.c:

(webLoadingFixtureSetup):
(loadProgressEstimatedProgressChanged):
(loadProgressLoadFinished):
(testLoadProgress):
(main):

10:53 Changeset [96832] by commit-queue@webkit.org

InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
https://bugs.webkit.org/show_bug.cgi?id=69538

Patch by Andreas Kling <kling@webkit.org> on 2011-10-06
Reviewed by Dan Bernstein.

Remove erroneous ENABLE(SVG) guards around the initialization and use
of InlineBox::hasVirtualLogicalHeight.

This variable is used by TrailingFloatsRootInlineBox and should always
be respected regardless of SVG support.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):

10:42 Changeset [96831] by mhahnenberg@apple.com

JSC objects need to know their own cell size at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69390

Reviewed by Geoffrey Garen.

Added the cellSize field to ClassInfo and the static calculation of
size of each class to the CREATE_METHOD_TABLE macro, which will be
renamed in a followup patch to make its name match its broader use.

Also added a few ClassInfo structs so that each object that is allocated has its
correct size.

Changed JSByteArray s_defaultInfo to s_info so that the template will get the
correct ClassInfo struct from it when it's allocated.

  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.h:

(JSC::allocateCell):

  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:

(JSC::JSCell::cellSize):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StrictEvalActivation.h:
10:41 Changeset [96830] by alex@webkit.org

2011-10-06 Alejandro G. Castro <alex@igalia.com>

[WK2] [GTK] Add Skipped file for Webkit2 test runner
https://bugs.webkit.org/show_bug.cgi?id=69517

Reviewed by Martin Robinson.

  • platform/gtk-wk2/Skipped: Added.

2011-10-06 Alejandro G. Castro <alex@igalia.com>

[WK2] [GTK] Add Skipped file for Webkit2 test runner
https://bugs.webkit.org/show_bug.cgi?id=69517

Use the shared WK2 skipped file also in GTK port.

Reviewed by Martin Robinson.

  • Scripts/old-run-webkit-tests: (readSkippedFiles):
10:39 Changeset [96829] by carlosgc@webkit.org

[GTK] Implement cache model for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68434

Reviewed by Martin Robinson.

Source/WebCore:

Add a function to FileSystem to get the free space of the file
system where the given path is on.

  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:

(WebCore::getVolumeFreeSizeForPath):

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_cache_model):
(webkit_web_context_get_cache_model):

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/tests/testwebcontext.c:

(testWebContextCacheModel):
(main):

  • WebProcess/gtk/WebProcessGtk.cpp:

(WebKit::getCacheDiskFreeSize): Helper function to get free space
of the file system where the cache directory is on.
(WebKit::getMemorySize): Helper function to get the total memory
of the system in MB.
(WebKit::WebProcess::platformSetCacheModel): Implement
platformSetCacheModel for Gtk port using calculateCacheSizes().

10:34 Changeset [96828] by amruthraj@motorola.com

Adding myself to the committers list.

10:22 Changeset [96827] by commit-queue@webkit.org

Test how DOMTokenList methods react to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66537

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-06
Reviewed by Darin Adler.

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:

(createElement):

10:14 Changeset [96826] by commit-queue@webkit.org

Add check for JavaScript URLs in HTMLPlugInImageElement::allowedToLoadFrameURL
https://bugs.webkit.org/show_bug.cgi?id=68813

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-06
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-object-element.html

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):

LayoutTests:

  • http/tests/security/xss-DENIED-object-element-expected.txt: Added.
  • http/tests/security/xss-DENIED-object-element.html: Added.
10:12 Changeset [96825] by yurys@chromium.org

Web Inspector: avoid assertion failure in ~InspectorDebuggerAgent in case of workers
https://bugs.webkit.org/show_bug.cgi?id=69534

Make sure frontend is disconnected before WorkerInspectorController is destroyed.

Reviewed by Pavel Feldman.

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::~WorkerInspectorController):

10:05 Changeset [96824] by commit-queue@webkit.org

Test how filesystem methods react to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66538

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-06
Reviewed by Darin Adler.

  • fast/filesystem/filesystem-missing-arguments-expected.txt: Added.
  • fast/filesystem/filesystem-missing-arguments.html: Added.
10:04 Changeset [96823] by ap@apple.com

https://bugs.webkit.org/show_bug.cgi?id=69492
[Mac] Should be able to scroll embedded PDFs from keyboard

Reviewed by Darin Adler.

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::handleScroll):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::handleScroll):
  • WebProcess/Plugins/PluginProxy.h: Added a handleScroll method. A plug-in gets it if it doesn't handle a keyboard event, and WebCore decides that this is an event for scrolling. A plug-in can decide whether it scrolls main content, or some scrollable subview of its own.
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::handleMouseEvent): Added a comment explaining returned value. (WebKit::BuiltInPDFView::handleScroll): Just call ScrollableArea, it will do everything.
  • WebProcess/Plugins/PDF/BuiltInPDFView.h: Added a handleScroll override.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::scroll): Pass a PluginViewBase scroll to plug-in to handle. (WebKit::PluginView::handleEvent): Added a FIXME.
  • WebProcess/Plugins/PluginView.h:
09:58 Changeset [96822] by commit-queue@webkit.org

REGRESSION (r95852?): Disappearing Border on bugs.webkit.org attachments <table>
https://bugs.webkit.org/show_bug.cgi?id=69296

Source/WebCore:

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-10-06
Reviewed by David Hyatt.

Test: fast/table/border-collapsing/cached-69296.html

Remember BorderValue in CollapsedBorderValue by value.
See https://bugs.webkit.org/show_bug.cgi?id=69296#c7 for motivation.

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::exists):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::operator==):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::collapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder):

LayoutTests:

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-10-06
Reviewed by David Hyatt.

Collapsed borders should not disappear.

  • fast/table/border-collapsing/cached-69296-expected.png: Added.
  • fast/table/border-collapsing/cached-69296-expected.txt: Added.
  • fast/table/border-collapsing/cached-69296.html: Added.
09:57 Changeset [96821] by carlosgc@webkit.org

[GTK] Do not use C API in GTK+ API public headers
https://bugs.webkit.org/show_bug.cgi?id=69506

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitDefines.h: Added.
  • UIProcess/API/gtk/WebKitError.h: Use WEBKIT_API instead of WK_EXPORT.
  • UIProcess/API/gtk/WebKitWebContext.h: Ditto.
  • UIProcess/API/gtk/WebKitWebLoaderClient.h: Ditto.
  • UIProcess/API/gtk/WebKitWebView.h: Ditto.
  • UIProcess/API/gtk/WebKitWebViewBase.h: Ditto.
  • UIProcess/API/gtk/docs/GNUmakefile.am: Ignore WEBKIT_API

decorator in docs.

  • UIProcess/API/gtk/webkit2.h: Include <webkit2/WebKitDefines.h>
09:51 Changeset [96820] by commit-queue@webkit.org

Test how media element TimeRange methods react to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66532

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-06
Reviewed by Adam Barth.

  • media/video-buffered-too-few-arguments-expected.txt: Added.
  • media/video-buffered-too-few-arguments.html: Added.
09:40 Changeset [96819] by gavinp@chromium.org

save resource zeroing stacks in ScriptElement for debugging
https://bugs.webkit.org/show_bug.cgi?id=69453

The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
75604). This patch will save a stack in the ScriptElement when this happens, so that if
we do later crash, we can see how we did the first zeroing.

See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
this change will help track down.

Reviewed by Nate Chapin.

No new tests, this shouldn't affect output at all, and isn't particularly testable.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
09:37 Changeset [96818] by commit-queue@webkit.org

Fix compilation by adding some missing ENABLE(VIDEO|XSLT)
https://bugs.webkit.org/show_bug.cgi?id=69522

Unreviewed build fix

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-06

  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
09:31 Changeset [96817] by pfeldman@chromium.org

Web Inspector: add Styles and Metrics sidebars to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69529

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.requestCSSNameCompletions):

  • inspector/front-end/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):
(WebInspector.CSSKeywordCompletions.isColorAwareProperty):

  • inspector/front-end/Checkbox.js:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._updateMetrics):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/externs.js:

(WebInspector.linkifyResourceAsNode):
(Element.prototype.scrollIntoViewIfNeeded):
(Element.prototype.selectionLeftOffset):

  • inspector/front-end/inspector.js:
  • inspector/front-end/utilities.js:
09:22 Changeset [96816] by pfeldman@chromium.org

Web Inspector: extract DOMPresentation, make EventListenersSidebar compile
https://bugs.webkit.org/show_bug.cgi?id=69527

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.nodeNameInCorrectCase):
(WebInspector.DOMNode.prototype.moveTo):
(WebInspector.DOMNode.prototype.isXMLNode):

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):

  • inspector/front-end/DOMPresentation.js: Added.

(WebInspector.DOMPresentation.decorateNodeLabel):
(WebInspector.DOMPresentation.linkifyNodeReference):
(WebInspector.DOMPresentation.linkifyNodeById):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateBreadcrumb):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/PropertiesSection.js:
  • inspector/front-end/Section.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
09:12 Changeset [96815] by pfeldman@chromium.org

Web Inspector: add all Resource panel views to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69526

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._contextMenu):
(WebInspector.Cookies.cookieMatchesResourceURL):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._onDeleteFromGrid):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._queryFinished):

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._queryFinished):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showDatabase):

  • inspector/front-end/TextPrompt.js:
08:51 Changeset [96814] by caryclark@google.com

Unreviewed: Update all chromium-mac baseline images that differ only
in their scrollbar appearance.

  • platform/chromium-mac/css1/basic/comments-expected.png:
  • platform/chromium-mac/css1/basic/containment-expected.png:
  • platform/chromium-mac/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/css1/box_properties/border-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_style-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_width-expected.png:
  • platform/chromium-mac/css1/box_properties/clear-expected.png:
  • platform/chromium-mac/css1/box_properties/float_margin-expected.png:
  • platform/chromium-mac/css1/box_properties/height-expected.png:
  • platform/chromium-mac/css1/box_properties/margin-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_top-expected.png:
  • platform/chromium-mac/css1/box_properties/padding-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_top-expected.png:
  • platform/chromium-mac/css1/box_properties/width-expected.png:
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac/css1/classification/display-expected.png:
  • platform/chromium-mac/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac/css1/classification/white_space-expected.png:
  • platform/chromium-mac/css1/color_and_background/background-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_position-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-mac/css1/font_properties/font_size-expected.png:
  • platform/chromium-mac/css1/font_properties/font_weight-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-mac/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac/css1/pseudo/firstletter-expected.png:
  • platform/chromium-mac/css1/pseudo/firstline-expected.png:
  • platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-mac/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-mac/css1/text_properties/line_height-expected.png:
  • platform/chromium-mac/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png:
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-mac/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-mac/css1/units/color_units-expected.png:
  • platform/chromium-mac/css1/units/length_units-expected.png:
  • platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-004-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-008-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-010-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-012-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-014-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-023-expected.png:
  • platform/chromium-mac/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-mac/editing/selection/select-all-003-expected.png:
  • platform/chromium-mac/editing/selection/select-all-004-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-mac/fast/block/float/008-expected.png: Added.
  • platform/chromium-mac/fast/block/float/013-expected.png:
  • platform/chromium-mac/fast/block/float/019-expected.png: Added.
  • platform/chromium-mac/fast/block/float/021-expected.png:
  • platform/chromium-mac/fast/block/float/025-expected.png:
  • platform/chromium-mac/fast/block/float/026-expected.png:
  • platform/chromium-mac/fast/block/float/027-expected.png:
  • platform/chromium-mac/fast/block/float/028-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.png: Added.
  • platform/chromium-mac/fast/block/float/035-expected.png: Added.
  • platform/chromium-mac/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/chromium-mac/fast/block/float/br-with-clear-2-expected.png: Added.
  • platform/chromium-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
  • platform/chromium-mac/fast/block/float/nested-clearance-expected.png: Added.
  • platform/chromium-mac/fast/block/float/relative-painted-twice-expected.png:
  • platform/chromium-mac/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/104-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-mac/fast/block/positioning/047-expected.png:
  • platform/chromium-mac/fast/block/positioning/055-expected.png:
  • platform/chromium-mac/fast/block/positioning/auto/007-expected.png:
  • platform/chromium-mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/negative-rel-position-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/relative-overflow-block-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/chromium-mac/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/chromium-mac/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-mac/fast/body-propagation/overflow/002-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/003-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/004-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/006-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/007-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-sizing/box-sizing-expected.png: Added.
  • platform/chromium-mac/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-mac/fast/clip/014-expected.png:
  • platform/chromium-mac/fast/css-generated-content/014-expected.png:
  • platform/chromium-mac/fast/css/005-expected.png:
  • platform/chromium-mac/fast/css/MarqueeLayoutTest-expected.png:
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-mac/fast/css/border-height-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-background-image-expected.png:
  • platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/hsl-color-expected.png:
  • platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/line-height-overflow-expected.png: Added.
  • platform/chromium-mac/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Added.
  • platform/chromium-mac/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-mac/fast/flexbox/009-expected.png:
  • platform/chromium-mac/fast/flexbox/016-expected.png:
  • platform/chromium-mac/fast/flexbox/flex-hang-expected.png: Added.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac/fast/forms/form-hides-table-expected.png:
  • platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-mac/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-mac/fast/inline-block/tricky-baseline-expected.png:
  • platform/chromium-mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-mac/fast/inline/inline-continuation-borders-expected.png:
  • platform/chromium-mac/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png:
  • platform/chromium-mac/fast/layers/overflow-scroll-auto-switch-expected.png: Added.
  • platform/chromium-mac/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/chromium-mac/fast/lists/001-expected.png:
  • platform/chromium-mac/fast/lists/001-vertical-expected.png:
  • platform/chromium-mac/fast/lists/008-expected.png:
  • platform/chromium-mac/fast/lists/008-vertical-expected.png:
  • platform/chromium-mac/fast/lists/li-br-expected.png: Added.
  • platform/chromium-mac/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-mac/fast/lists/olstart-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png:
  • platform/chromium-mac/fast/multicol/client-rects-expected.png:
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-mac/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac/fast/overflow/002-expected.png:
  • platform/chromium-mac/fast/overflow/003-expected.png:
  • platform/chromium-mac/fast/overflow/005-expected.png: Added.
  • platform/chromium-mac/fast/overflow/007-expected.png:
  • platform/chromium-mac/fast/overflow/008-expected.png:
  • platform/chromium-mac/fast/overflow/childFocusRingClip-expected.png:
  • platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-mac/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-mac/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/chromium-mac/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-auto-table-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-update-transform-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/chromium-mac/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-mac/fast/overflow/scrollbar-position-update-expected.png:
  • platform/chromium-mac/fast/overflow/table-overflow-float-expected.png:
  • platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
  • platform/chromium-mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/chromium-mac/fast/repaint/select-option-background-color-expected.png:
  • platform/chromium-mac/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/chromium-mac/fast/replaced/005-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac/fast/selectors/166-expected.png:
  • platform/chromium-mac/fast/table/023-expected.png: Added.
  • platform/chromium-mac/fast/table/027-vertical-expected.png:
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/034-expected.png:
  • platform/chromium-mac/fast/table/038-vertical-expected.png:
  • platform/chromium-mac/fast/table/040-expected.png:
  • platform/chromium-mac/fast/table/040-vertical-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/chromium-mac/fast/table/edge-offsets-expected.png:
  • platform/chromium-mac/fast/table/empty-cells-expected.png:
  • platform/chromium-mac/fast/table/height-percent-test-expected.png: Added.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/overflowHidden-expected.png:
  • platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/wide-colspan-expected.png: Added.
  • platform/chromium-mac/fast/table/wide-column-expected.png: Added.
  • platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/large-text-composed-char-expected.png:
  • platform/chromium-mac/fast/text/softHyphen-expected.png: Added.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.png:
  • platform/chromium-mac/fast/text/wbr-expected.png:
  • platform/chromium-mac/fast/text/whitespace/024-expected.png:
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-mac/fast/text/word-break-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/chromium-mac/fonts/cursive-expected.png:
  • platform/chromium-mac/fonts/default-expected.png:
  • platform/chromium-mac/fonts/fantasy-expected.png:
  • platform/chromium-mac/fonts/serif-expected.png:
  • platform/chromium-mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-mac/printing/return-from-printing-mode-expected.png: Added.
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/altglyph-expected.png:
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/chromium-mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/chromium-mac/svg/custom/junk-data-expected.png:
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/chromium-mac/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/chromium-mac/svg/in-html/circle-expected.png:
  • platform/chromium-mac/svg/overflow: Added.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/chromium-mac/svg/text/kerning-expected.png:
  • platform/chromium-mac/svg/text/multichar-glyph-expected.png:
  • platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug120364-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug22019-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug23151-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug43039-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug5835-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug650-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug92143-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-mac/tables/mozilla/core/nested1-expected.png:
  • platform/chromium-mac/tables/mozilla/core/one_row-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test6-expected.png:
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png:
  • platform/chromium/test_expectations.txt:
08:36 Changeset [96813] by commit-queue@webkit.org

Unreviewed, rolling out r96791.
http://trac.webkit.org/changeset/96791
https://bugs.webkit.org/show_bug.cgi?id=69528

webkit_unit_tests broken on Mac and Win (Requested by
hwennborg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):

08:35 Changeset [96812] by mnaganov@chromium.org

Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown.
https://bugs.webkit.org/show_bug.cgi?id=69482

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._helpClicked):

08:17 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
07:49 BuildingQt5OnHarmattan created by hausmann@webkit.org
07:44 Changeset [96811] by commit-queue@webkit.org

allow new-run-webkit-tests to run on Lion
https://bugs.webkit.org/show_bug.cgi?id=69429

Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
directory to fallback lists (even though that directory doesn't exist yet)

Patch by Elliot Poger <epoger@google.com> on 2011-10-06
Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
07:07 Changeset [96810] by hans@chromium.org

[Chromium] WebKit.gyp fix to unbreak Linux(shared) build after r96791

Unreviewed gardening.

  • WebKit.gyp:
06:43 Changeset [96809] by gavinp@chromium.org

export new stack dumping method
https://bugs.webkit.org/show_bug.cgi?id=69018

The original landing of bug 69018 didn't export WTFGetBacktrace, so that when bug 69453 landed, the first use
of this function, many builds broke. So here we add the exports, so that the function is usable.

Reviewed by Adam Roben.

06:37 Changeset [96808] by commit-queue@webkit.org

Provide configure option to switch between JSC and V8.
https://bugs.webkit.org/show_bug.cgi?id=69469

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-06
Reviewed by Philippe Normand.

This is first of the patches to support building of V8 with
WebKit GTK. With this patch, new command line switch named
'--with-jsengine' is introduced, using which we can choose to
build either jsc or v8.

  • GNUmakefile.am:
  • configure.ac:
06:20 Changeset [96807] by pfeldman@chromium.org

Web Inspector: add 10 more front-end classes to the compilation process.
https://bugs.webkit.org/show_bug.cgi?id=69445

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/HAREntry.js:
  • inspector/front-end/HandlerRegistry.js:
  • inspector/front-end/IFrameView.js:
  • inspector/front-end/JavaScriptSourceFrame.js:
  • inspector/front-end/PanelEnablerView.js:

(WebInspector.PanelEnablerView):

  • inspector/front-end/PartialQuickSort.js:
  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
(WebInspector.PropertiesSidebarPane.prototype.update):

  • inspector/front-end/ShowMoreDataGridNode.js:
  • inspector/front-end/SidebarTreeElement.js:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/WelcomeView.js:
  • inspector/front-end/externs.js:

(WebInspector.addMainEventListeners):

06:15 Changeset [96806] by alexis.menard@openbossa.org

[Qt][WK2] Cursor should change when hovering links or input fields.
https://bugs.webkit.org/show_bug.cgi?id=69519

Reviewed by Simon Hausmann.

This is a temporary fix until Qt5 brings support for changing cursor
per item. This patch enforce the change of the cursor at application
level.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didChangeCursor):

06:14 Changeset [96805] by pfeldman@chromium.org

Web Inspector: make ElementsTreeOutline compile
https://bugs.webkit.org/show_bug.cgi?id=69439

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMSyntaxHighlighter.js:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
(WebInspector.ElementsPanel.prototype._inspectElementRequested):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
(WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
(WebInspector.ElementsTreeElement.prototype._startEditingTagName):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
():

  • inspector/front-end/externs.js:

(WebInspector.highlightDOMNode):
(WebInspector.resourceURLForRelatedNode):

06:04 Changeset [96804] by pfeldman@chromium.org

Web Inspector: Inspector fails to start if there was at least one watch expression.
https://bugs.webkit.org/show_bug.cgi?id=69516

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane):

05:58 QtWebKit edited by hausmann@webkit.org
(diff)
05:56 QtWebKit edited by hausmann@webkit.org
(diff)
05:53 Changeset [96803] by dominicc@chromium.org

Don't make virtual calls in Node::parentNode.
https://bugs.webkit.org/show_bug.cgi?id=69266

Reviewed by Antti Koivisto.

ShadowRoot and SVGShadowRoot remain semantically separate (eg
isShadowRoot/isSVGShadowRoot) but share a flag
(IsShadowRootOrSVGShadowRootFlag, hitherto IsShadowRootFlag just
for ShadowRoot). In combination with IsSVGFlag ShadowRoot (false)
can be distinguished from SVGShadowRoot (true). This lets us make
isSVGShadowRoot non-virtual.

No change in behavior => No new tests.

  • dom/Node.cpp:

(WebCore::Node::shadowHost):

  • dom/Node.h:

(WebCore::Node::isSVGShadowRoot):
(WebCore::Node::isShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):

  • rendering/svg/SVGShadowTreeElements.cpp:

(WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement):
(WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):

  • rendering/svg/SVGShadowTreeElements.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):

  • svg/SVGElement.h:
  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::SVGGElement):

  • svg/SVGGElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::SVGStyledElement):

  • svg/SVGStyledElement.h:
  • svg/SVGStyledLocatableElement.cpp:

(WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):

  • svg/SVGStyledLocatableElement.h:
  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):

  • svg/SVGStyledTransformableElement.h:
04:57 Changeset [96802] by ossy@webkit.org

REGRESSION(r96347): Build is broken with MSVC compiler if !PLATFORM(WINDOWS)
https://bugs.webkit.org/show_bug.cgi?id=69413

Reviewed by Darin Adler.

  • assembler/MacroAssemblerCodeRef.h: Define STDCALL for MSVC in a proper way.
04:31 Changeset [96801] by ossy@webkit.org

[Qt] inspector/styles/styles-disable-inherited.html make the next test fail after r96257
https://bugs.webkit.org/show_bug.cgi?id=69257

Unreviewed gardening.

  • platform/qt/Skipped:
04:23 Changeset [96800] by commit-queue@webkit.org

[Qt][WK2][Mac] QtWebProcess should not show up in the Dock.
https://bugs.webkit.org/show_bug.cgi?id=69432

We can set the environment variable QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM
in the WebProcess stub to disable the automatic foreground transformation.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-06
Reviewed by Andreas Kling.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::QtWebProcess::setupChildProcess):

03:53 Changeset [96799] by ossy@webkit.org

[Qt] REGRESSION(r96779): It made svg/as-image/svg-nested.html timeout
https://bugs.webkit.org/show_bug.cgi?id=69511

  • platform/qt/Skipped: Skip svg/as-image/svg-nested.html until fix.
03:10 Changeset [96798] by jknotten@chromium.org

Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Reviewed by Tony Gentilcore.

Source/WebCore:

Tests: fast/events/page-scaled-mouse-click-iframe.html

fast/events/page-scaled-mouse-click.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::contentsScrollOffset):
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::frameScaleFactor):
(WebCore::MouseRelatedEvent::computePageLocation):
(WebCore::MouseRelatedEvent::computeRelativePosition):

LayoutTests:

  • fast/events/page-scaled-mouse-click-expected.txt: Added.
  • fast/events/page-scaled-mouse-click-iframe-expected.txt: Added.
  • fast/events/page-scaled-mouse-click-iframe.html: Added.
  • fast/events/page-scaled-mouse-click.html: Added.
  • fast/events/resources/page-scaled-mouse-click-iframe-inner.html: Added.
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js: Added.

():
(clearEventLog):
(testEvents):
(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js: Added.

():
(clearEventLog):
(sendEvents):
(testEvents):

03:07 Changeset [96797] by sergio@webkit.org

Unreviewed. Skipped a test that lacks a console message.

  • platform/gtk/Skipped: skipped

http/tests/security/redirect-BLOCKED-to-localURL.html

02:57 Changeset [96796] by sergio@webkit.org

Unreviewed. Skipping a test that requires
continuousMouseScrollBy() which is not yet supported by GTK
EventSender API.

  • platform/gtk/Skipped: skipped

fast/events/wheelevent-direction-inverted-from-device.html

02:30 Changeset [96795] by zherczeg@webkit.org

Unreviewed, Qt rebaseline after r96789.

  • platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-frames-expected.txt: Added.
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-goback2-expected.txt: Added.
02:08 Changeset [96794] by fpizlo@apple.com

SpeculativeJIT::isKnownString() is wrong
https://bugs.webkit.org/show_bug.cgi?id=69501

Reviewed by Oliver Hunt.

Removed the wrong case (GetLocal predicted String) and added a case that
works (StrCat).

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownString):

02:00 Changeset [96793] by hans@chromium.org

IndexedDB: Remove SQLite-LevelDB migration code
https://bugs.webkit.org/show_bug.cgi?id=69264

Reviewed by Tony Chang.

Source/WebCore:

Remove migration functionality.

Just removing code, so no new tests.

  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

  • storage/IDBFactoryBackendImpl.h:

Source/WebKit/chromium:

Remove setOverrideBackingStoreType. It was used in the layout test
for migration.

  • public/WebIDBFactory.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

Tools:

Remove setOverrideIndexedDBBackingStore. It was used in the layout
test for migration.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Remove layout test covering migration.

  • storage/indexeddb/migrate-basics-expected.txt: Removed.
  • storage/indexeddb/migrate-basics.html: Removed.
01:09 Changeset [96792] by philn@webkit.org

Unreviewed, GTK rebaseline after r96620.

  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
00:12 Changeset [96791] by commit-queue@webkit.org

[chromium] Remove USE(THREADED_COMPOSITING) from the tree
https://bugs.webkit.org/show_bug.cgi?id=69489

Patch by James Robinson <jamesr@chromium.org> on 2011-10-06
Reviewed by Darin Fisher.

Source/WebCore:

This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):

10/05/11:

23:34 Changeset [96790] by commit-queue@webkit.org

[chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=69498

Patch by James Robinson <jamesr@chromium.org> on 2011-10-05
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setThreadedCompositingEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
23:04 Changeset [96789] by arv@chromium.org

[QT] Fix DRT after r96779

unreviewed.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::dumpHistoryItem):

23:00 Changeset [96788] by haraken@chromium.org

Refactor IDL attributes about constructor
https://bugs.webkit.org/show_bug.cgi?id=69074

Reviewed by Adam Barth.

Currently, IDL attributes about constructor are confusing:

  • [CustomConstructFunction] means that there is a custom constructor for JSC.
  • [V8CustomConstructor] means that there is a custom constructor for V8.
  • [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
  • For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
  • ObjC, CPP and GObject bindings do not support custom constructors.

This patch makes the following changes:

  • Rename [CustomConstructFunction] to [JSCustomConstructor].
  • [JSCustomConstructor] means that there is a custom constructor for JSC.
  • [V8CustomConstructor] means that there is a custom constructor for V8.
  • [CustomConstructor] means that there is a custom constructor for both JSC and V8.

No new tests. No change in behavior. Confirm that build succeeds.

  • bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]

(GenerateHeader):
(GenerateAttributesHashTable):
(GenerateImplementation):
(GenerateConstructorDefinition):

  • css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/Event.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageChannel.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • html/DOMFormData.idl: Ditto.
  • html/canvas/ArrayBuffer.idl: Ditto.
  • html/canvas/DataView.idl: Ditto.
  • html/canvas/Float32Array.idl: Ditto.
  • html/canvas/Float64Array.idl: Ditto.
  • html/canvas/Int16Array.idl: Ditto.
  • html/canvas/Int32Array.idl: Ditto.
  • html/canvas/Int8Array.idl: Ditto.
  • html/canvas/Uint16Array.idl: Ditto.
  • html/canvas/Uint32Array.idl: Ditto.
  • html/canvas/Uint8Array.idl: Ditto.
  • p2p/PeerConnection.idl: Ditto.
  • page/EventSource.idl: Ditto.
  • page/WebKitPoint.idl: Ditto.
  • webaudio/AudioContext.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
  • websockets/WebSocket.idl: Ditto.
  • workers/SharedWorker.idl: Ditto.
  • workers/Worker.idl: Ditto.
  • xml/XMLHttpRequest.idl: Ditto.
  • xml/XSLTProcessor.idl: Ditto.
22:37 Changeset [96787] by bfulgham@webkit.org

[WinCairo] Unreviewed build fix.

  • platform/wincairo/Skipped: Skip css3 folder (for now).
21:18 Changeset [96786] by aestes@apple.com

Source/WebCore: Add the option to suppress rendering until the document's load event fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a WebCore setting that suppresses painting and compositing layer
updates until the document's load event fires. This masks the effects
of incremental rendering (for clients that opt in) by ensuring that all
sub-resources have loaded and a full layout has taken place before
painting the document for the first time.

No tests currently possible. Testing this would require the ability for
DRT to dump state while resources are loading, which it doesn't
currently do.

  • dom/Document.cpp:

(WebCore::Document::implicitClose): If rendering was previously
suppressed, force a repaint and compositing layer update.
(WebCore::Document::visualUpdatesAllowed): Add a helper method to
determine if the document is in a state where rendering is allowed.

  • dom/Document.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setSuppressIncrementalRendering):
(WebCore::Settings::suppressIncrementalRendering):

  • rendering/RenderLayer.cpp:

(WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and
painting suppression checks into a single helper function for
readability's sake.
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): If we should
suppress compositing layer updates and the load event has yet to fire,
return early.

Source/WebKit/mac: Add an option to suppress rendering until the document's load event fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a new private WebPreference.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
(-[WebPreferences suppressRenderingWhileInitiallyLoading]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2: Add an option to suppress rendering until the document's load event fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a new WKPreference.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSuppressRenderingWhileInitiallyLoading):
(WKPreferencesGetSuppressRenderingWhileInitiallyLoading):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

20:37 Changeset [96785] by yutak@chromium.org

WebSocket: Add extensions attribute
https://bugs.webkit.org/show_bug.cgi?id=69408

Reviewed by Kent Tamura.

Source/WebCore:

Add WebSocket's "extensions" attribute as specified in the WebSocket API
<http://dev.w3.org/html5/websockets/#the-websocket-interface>.

WebSocket protocol extension is not implemented at all, thus this attribute
always returns an empty string.

Test: http/tests/websocket/tests/hybi/extensions.html

http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::extensions):
If the hixie-76 protocol is chosen, we need to return "undefined" in order to
keep behavior of the ports which have not used the newer hybi protocol yet.

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

LayoutTests:

  • http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
  • http/tests/websocket/tests/hixie76/undefined-attributes.html:

Added "extensions" attribute to the list because it shouldn't be defined
when hixie-76 protocol is used.

  • http/tests/websocket/tests/hybi/extensions-expected.txt: Added.
  • http/tests/websocket/tests/hybi/extensions.html:

Added. Test whether .extensions attribute always returns an empty string.

20:04 Changeset [96784] by simon.fraser@apple.com

r96770 broke binary compatibility with Safari
https://bugs.webkit.org/show_bug.cgi?id=69496

Reviewed by Dan Bernstein.

Fix binary compatibility issue by declaring the deprecated methods inside a extern "C" block.

  • UIProcess/API/C/WKContext.cpp:
19:38 Changeset [96783] by rniwa@webkit.org

Windows build fix attempt after r96760.

19:27 Changeset [96782] by dominicc@chromium.org

IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
https://bugs.webkit.org/show_bug.cgi?id=69406

Reviewed by Hajime Morita.

No change in behavior => No new tests.

  • dom/Node.cpp:

(WebCore::Node::setShadowHost): Don't twiddle the flag.

  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.

  • dom/TreeScope.h:
19:15 Changeset [96781] by simonjam@chromium.org

[Chromium] Update test expectations for Web Audio on Windows.

Unreviewed.

  • platform/chromium/test_expectations.txt:
19:04 Changeset [96780] by crogers@google.com

Define a log2f() function for Windows in wtf/MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=69491

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/MathExtras.h:

(log2f):

Source/WebCore:

No new tests. This change is tested in existing layout tests.

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

18:40 Changeset [96779] by arv@chromium.org

window.location.href and others needlessly decodes URI-encoded characters
https://bugs.webkit.org/show_bug.cgi?id=30225

Reviewed by Darin Adler.

Source/WebCore:

Don't decode KURL::path() and stop using KURL::deprecatedString() in Location methods.

This slightly changes how we parse data and javascript URLs (non hierarchical URLs) to
not encode so aggressively.

  • fileapi/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::crackFileSystemURL): Manually decode path()

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultObjectContentType): Manually decode path()

  • page/Location.cpp:

(WebCore::Location::href): Use string() instead of deprecatedString()

  • page/Location.h:

(WebCore::Location::toString): Inline call to href()

  • platform/KURL.cpp:

(WebCore::KURL::path): Don't decode.
(WebCore::escapeAndAppendNonHierarchicalPart): Rename escapeAndAppendFragment to escapeAndAppendNonHierarchicalPart

since this is now used for more than just fragments.

(WebCore::KURL::parse): Don't decode

  • platform/KURLGoogle.cpp:

(WebCore::KURL::path): Remove out of date comment

  • platform/qt/KURLQt.cpp:

(WebCore::KURL::fileSystemPath): Manually decode path()

  • platform/win/ClipboardWin.cpp:

(WebCore::createGlobalHDropContent): Manually decode path()

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::href): Use string() instead of deprecatedString()

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::toString): Inline call to href()

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(normalizeLayoutTestURLInternal): Remove extra encode.

LayoutTests:

The path part of location.href and location.pathname are now not decoded and we keep percent escape sequences.

data and javascript URLs only encodes non ascii characters.

  • fast/dom/anchor-origin-expected.txt:
  • fast/dom/anchor-origin.html: Change to not use document.write since we don't want to output HTML.
  • fast/history/history-back-initial-vs-final-url-expected.txt:
  • fast/loader/subframe-navigate-during-main-frame-load-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/mailto-expected.txt:
  • fast/url/script-tests/file-http-base.js:
  • fast/url/script-tests/segments.js:
  • fast/url/script-tests/standard-url.js:
  • fast/url/segments-expected.txt:
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/segments.html: Use UTF-8
  • fast/url/standard-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • platform/chromium-cg-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-linux/fast/url/standard-url-expected.txt:
  • platform/chromium-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-win/fast/url/standard-url-expected.txt:
  • platform/chromium/fast/dom/anchor-origin-expected.txt: Removed.
18:14 Changeset [96778] by darin@apple.com

Fix build.

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:

(TestWebKitAPI::TEST): Remove underscore prefix from call to
WKContextRegisterURLSchemeAsEmptyDocument.

17:56 Changeset [96777] by darin@apple.com

[Mac] Use four more named cursors if present
https://bugs.webkit.org/show_bug.cgi?id=69488

Reviewed by Dan Bernstein.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
"ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
falls back if the cursors are not present.

17:51 Changeset [96776] by tony@chromium.org

force margin:auto to 0 in flex items
https://bugs.webkit.org/show_bug.cgi?id=69475

Reviewed by Ojan Vafai.

Source/WebCore:

The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

LayoutTests:

  • css3/flexbox/002.html:
  • css3/flexbox/003.html:
  • css3/flexbox/004.html:
  • css3/flexbox/writing-modes.html:
17:44 Changeset [96775] by dino@apple.com

Computed style for filter property
https://bugs.webkit.org/show_bug.cgi?id=68477

Reviewed by Simon Fraser.

Reports the computed style for the new -webkit-filter
property value.

Test: css3/filters/filter-property-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedFilter):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

New test to exercise computed style for -webkit-filter. Note
that drop-shadow is not yet supported.

  • css3/filters/filter-property-computed-style-expected.txt: Added.
  • css3/filters/filter-property-computed-style.html: Added.
  • css3/filters/script-tests/filter-property-computed-style.js: Added.

(testComputedFilterRule):

17:40 Changeset [96774] by jer.noble@apple.com

Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

No new tests; existing webaudio/ layout tests cover this.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to

the WebCore.framework bundle.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
17:35 Changeset [96773] by bfulgham@webkit.org

[WinCairo] Switch to building Release target, and activate tests.
https://bugs.webkit.org/show_bug.cgi?id=69272

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

Change from debug to release target. Switch from "Build" to
"BuildAndTest"

17:34 Changeset [96772] by commit-queue@webkit.org

Make destructor of WebURLLoaderClient virtual.
https://bugs.webkit.org/show_bug.cgi?id=69457

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-10-05
Reviewed by Darin Fisher.

  • public/WebURLLoaderClient.h:

(WebKit::WebURLLoaderClient::~WebURLLoaderClient):

17:29 Changeset [96771] by bfulgham@webkit.org

[WinCairo] unreviewed build correction.

  • platform/wincairo/Skipped: Update to get build green.
17:08 Changeset [96770] by simon.fraser@apple.com

In WebKitTestRunner, text has font smoothing in pixel snapshots
https://bugs.webkit.org/show_bug.cgi?id=69396

Source/WebKit2:

Reviewed by Darin Adler.

Plumb through a method on WKContext that controls whether font smoothing
is enabled. Since this is a global setting, such a method is more appropriate
than a preference.

Remove leading underscores on some WKContext functions, but keep
exported versions of same for binary compatibility.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetAlwaysUsesComplexTextCodePath):
(WKContextSetShouldUseFontSmoothing):
(WKContextSetAdditionalPluginsDirectory):
(WKContextRegisterURLSchemeAsEmptyDocument):
(WKContextSetHTTPPipeliningEnabled):
(_WKContextSetAdditionalPluginsDirectory):
(_WKContextRegisterURLSchemeAsEmptyDocument):
(_WKContextSetAlwaysUsesComplexTextCodePath):
(_WKContextSetHTTPPipeliningEnabled):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::setShouldUseFontSmoothing):
(WebKit::WebContext::httpPipeliningEnabled):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setShouldUseFontSmoothing):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Tools:

Reviewed by Darin Adler.

Call the new WKContext method that disables font smoothing in
WebKitTestRunner, so that pixel snapshots don't have font smoothing
enabled. Remove leading underscore from a WKContext function call.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

17:01 Changeset [96769] by ojan@chromium.org

[flexbox] take marginBeforeForChild into account when positioning children
https://bugs.webkit.org/show_bug.cgi?id=69313

Reviewed by Tony Chang.

Source/WebCore:

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

LayoutTests:

  • css3/flexbox/002.html:
  • css3/flexbox/writing-modes.html:
17:00 Changeset [96768] by levin@chromium.org

Improve the watchlist for threading entries.
https://bugs.webkit.org/show_bug.cgi?id=69463

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
16:59 Changeset [96767] by simonjam@chromium.org

[Chromium] Update test expectations after Skia roll.

Unreviewed.

  • platform/chromium/test_expectations.txt: Added select-background-none.html on Linux.
16:46 Changeset [96766] by vangelis@chromium.org

Switching threaded compositor from a compile time option to a
run time one.
https://bugs.webkit.org/show_bug.cgi?id=69391

Reviewed by Darin Fisher.

Source/WebCore:

Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
called from anywhere,

No new tests as it doesn't add new functionality.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::compositeImmediately):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):
(WebKit::WebSettingsImpl::setUseThreadedCompositor):

  • src/WebSettingsImpl.h:

(WebKit::WebSettingsImpl::useThreadedCompositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):

16:40 Changeset [96765] by andersca@apple.com

Flash of white when unminimizing windows
https://bugs.webkit.org/show_bug.cgi?id=69476
<rdar://problem/10202680>

Reviewed by Simon Fraser.

Whenever the UI process requests an immediate backing store update, make sure to resume
painting if it's suspended.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState):

16:27 Changeset [96764] by dino@apple.com

Parse '-webkit-filter' property syntax
https://bugs.webkit.org/show_bug.cgi?id=68473

Reviewed by Nikolas Zimmermann.

Parse the new -webkit-filter property, looking for shorthand
functions then testing number, type and value of parameters.

Note that support for drop-shadow() was omitted from this
patch because parsing CSS shadow syntax was going to require some
refactoring of the box and text shadow code. The followup
bug is https://bugs.webkit.org/show_bug.cgi?id=69108.

Also, computed style will return null for filters at the moment.
That's https://bugs.webkit.org/show_bug.cgi?id=68477.

Tests: css3/filters/filter-property-parsing-invalid.html

css3/filters/filter-property-parsing.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Build files updated for new WebKitCSSFilterValue classes.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMCSS.mm:

Test if value is WebKitCSSFilterValue.

  • css/CSSParser.cpp:

(WebCore::filterInfoForName):
(WebCore::CSSParser::isValidFilterArgument):
(WebCore::CSSParser::parseFilter):

  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::filterOperationForType):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSStyleSelector.h:

Handle the new shorthand functions in -webkit-filter.

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSFilterValue):

Add virtual function that returns false here.

  • css/WebKitCSSFilterValue.cpp: Added.

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::cssText):

  • css/WebKitCSSFilterValue.h: Added.

(WebCore::WebKitCSSFilterValue::create):
(WebCore::WebKitCSSFilterValue::operationType):
(WebCore::WebKitCSSFilterValue::isWebKitCSSFilterValue):

  • css/WebKitCSSFilterValue.idl: Added.

WebKitCSSFilterValue modelled closely on WebKitCSSTransformValue,
basically identifying the type of operation in a CSSValueList.

  • page/DOMWindow.idl:

New WebKitCSSFilterValue constructor.

  • platform/graphics/filters/FilterOperation.h:

(WebCore::BlurFilterOperation::create):
(WebCore::BlurFilterOperation::stdDeviationX):
(WebCore::BlurFilterOperation::stdDeviationY):
(WebCore::BlurFilterOperation::BlurFilterOperation):
(WebCore::SharpenFilterOperation::create):
(WebCore::SharpenFilterOperation::radius):
(WebCore::SharpenFilterOperation::threshold):
(WebCore::SharpenFilterOperation::SharpenFilterOperation):

Use Length rather than double for parameters that are CSS lengths.

New tests that exercise the -webkit-filter syntax, with
(nearly) all the function shorthands. Since this patch also
added a global WebKitCSSFilterValue interface, the window
tests needed update, but only on the platforms that have
ENABLE(CSS_FILTERS).

  • css3/filters/filter-property-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt: Added.
  • css3/filters/filter-property-parsing-invalid-expected.txt: Added.
  • css3/filters/filter-property-parsing-invalid.html: Added.
  • css3/filters/filter-property-parsing.html: Added.
  • css3/filters/script-tests/filter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • css3/filters/script-tests/filter-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testFilterRule):

  • css3/filters/script-tests/filter-property.js:

Updated old test which was missing quotes, plus new tests that
exercise the shorthand feature.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/win/fast/js/global-constructors-expected.txt:

Updated isAppleWebkit() platform files for the new WebKitCSSFilterValue
API exposed on Window.

16:05 Changeset [96763] by crogers@google.com

Rebaseline webaudio/audiobuffersource-playbackrate.html due to http://trac.webkit.org/changeset/96745
https://bugs.webkit.org/show_bug.cgi?id=69470

Unreviewed.

  • webaudio/audiobuffersource-playbackrate-expected.wav:
15:51 Changeset [96762] by fpizlo@apple.com

Assertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
https://bugs.webkit.org/show_bug.cgi?id=69346

Reviewed by Oliver Hunt.

Removed the assertion, since it was completely wrong for op_post_inc.
Short of having specialized PostInc nodes in the DFG, there is no
robust way of asserting what this assertion was trying to assert while
also supporting op_post_inc.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

15:49 Changeset [96761] by crogers@google.com

Fix Windows build - it doesn't have a log2f() function...
https://bugs.webkit.org/show_bug.cgi?id=69473

Unreviewed build fix.

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

15:44 Changeset [96760] by ggaren@apple.com

Added a simpler mechanism for registering one-off finalizers
https://bugs.webkit.org/show_bug.cgi?id=69466

Reviewed by Oliver Hunt.

  • heap/Heap.cpp:

(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize):

  • heap/Heap.h: New function for adding an arbitrary finalizer for an

arbitrary cell without declaring any special classes or Handles yourself.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableBase::clearCodeVirtual):
(JSC::EvalExecutable::clearCodeVirtual):
(JSC::ProgramExecutable::clearCodeVirtual):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCodeVirtual):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation): Use the new mechanism for eager
finalization of executables.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::clearRareData):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::registerWeakMap): Use the new mechanism for eager
finalization of weak maps.

15:42 Changeset [96759] by jamesr@google.com

[chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
https://bugs.webkit.org/show_bug.cgi?id=69467

Reviewed by Kenneth Russell.

Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
false-positive ASSERT().

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

15:39 Changeset [96758] by commit-queue@webkit.org

Unreviewed, rolling out r96756.
http://trac.webkit.org/changeset/96756
https://bugs.webkit.org/show_bug.cgi?id=69472

Many builds broken due to WTFGetBacktrace not being exported
from JavaScriptCore (Requested by aroben on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-05

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
15:23 Changeset [96757] by aroben@apple.com

Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer

RetainPtr's behavior of allowing the template parameter to be either a pointer type or a
pointed-to type confused us when we implemented hashTableDeletedValue.

Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
in HashMap/HashSet fails to compile

Reviewed by John Sullivan.

Source/JavaScriptCore:

  • wtf/RetainPtr.h:

(WTF::RetainPtr::hashTableDeletedValue): Changed to use the PtrType typedef rather than T*,
since T might itself be a pointer.

(WTF::PtrHash<RetainPtr<P> >): Updated this to use PtrType everywhere, even though T* didn't
seem to be causing a problem.

Tools:

Add tests for using RetainPtrs inside HashMap and HashSet

  • TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.

(TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
and value type of HashMap.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added new file.

15:03 Changeset [96756] by gavinp@chromium.org

save resource zeroing stacks in ScriptElement for debugging
https://bugs.webkit.org/show_bug.cgi?id=69453

The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
75604). This patch will save a stack in the ScriptElement when this happens, so that if
we do later crash, we can see how we did the first zeroing.

See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
this change will help track down.

Reviewed by Nate Chapin.

No new tests, this shouldn't affect output at all, and isn't particularly testable.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
14:57 Changeset [96755] by oliver@apple.com

2011-10-05 Oliver Hunt <oliver@apple.com>

Remove last vestiges of anonymous storage.

Reviewed by Gavin Barraclough.

One anonymous storage function escaped my prior purge of
this feature, this patch removes it.

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::finishCreation):
  • runtime/JSObject.h:
14:48 Changeset [96754] by ap@apple.com

More build fix.

  • WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix.
14:46 Changeset [96753] by abarth@webkit.org

Mark as Expected in garden-o-matic is confusing
https://bugs.webkit.org/show_bug.cgi?id=69452

Reviewed by David Levin.

krit didn't understand the difference between this button and the
Rebaseline button because both of them seem to indicate that the new
behavior is expected. This patch renames "Mark as Expected" to "Expect
Failure" to make it clear that we're just expecting the test to fail
rather than accepting the new results as passing. We might need to
iterate on these names a bit more if folks continue to find them
confusing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
14:40 Changeset [96752] by bfulgham@webkit.org

[WinCairo] Create a Skipped file to support the new WinCairo test bot.
https://bugs.webkit.org/show_bug.cgi?id=69280
(Fix bad check-in).

Reviewed by Adam Roben.

  • platform/wincairo: Added.
  • platform/wincairo/Skipped: Added.
14:40 Changeset [96751] by annacc@chromium.org

Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=69456

Reviewed by David Levin.

No new tests. No new functionality.

  • html/track/CueParser.cpp:

(WebCore::CueParser::didFinishLoading):

  • html/track/CueParser.h:
14:36 Changeset [96750] by fpizlo@apple.com

DFG should be capable of a broader range of speculations on branch and not
https://bugs.webkit.org/show_bug.cgi?id=69322

Reviewed by Oliver Hunt.

  • bytecode/PredictedType.h:

(JSC::isFinalObjectOrOtherPrediction):
(JSC::isArrayOrOtherPrediction):

  • dfg/DFGJITCodeGenerator.cpp:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArrayOrOther):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

14:35 Changeset [96749] by bfulgham@webkit.org

[WinCairo] Create a Skipped file to support the new WinCairo test bot.
https://bugs.webkit.org/show_bug.cgi?id=69280

Reviewed by Adam Roben.

  • platform/wincairo: Added.
  • platform/wincairo/Skipped: Added.
14:35 Changeset [96748] by ddkilzer@apple.com

<http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db

Reviewed by Alexey Proskuryakov.

  • Storage/WebStorageManager.mm:

(+[WebStorageManager _storageDirectoryPath]): Restore call to
-[NSString stringByStandardizingPath]. Also fix over-release of
sLocalStoragePath if the initial -objectForKey: call returned an
NSString object. Use pthread_once to be thread-safe.

14:31 WikiStart edited by ariya@webkit.org
(diff)
14:31 JavaScriptCore created by ariya@webkit.org
let's just call it JavaScriptCore, without ".. Overview" suffix
14:15 Changeset [96747] by ap@apple.com

32-bit build fix.

  • WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors. In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure.
14:13 WikiStart edited by ariya@webkit.org
link to JavaScriptCore Overview (diff)
14:01 Changeset [96746] by abarth@webkit.org

Add watchlist entries for abarth
https://bugs.webkit.org/show_bug.cgi?id=69461

Reviewed by David Levin.

I might have gone a bit overboard. We'll see if this is too much spam
for me.

  • Scripts/webkitpy/common/config/watchlist:
13:53 Changeset [96745] by jer.noble@apple.com

WEB_AUDIO does not compile on Leopard 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69292

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; covered by all existing audio tests.

Use of float and double within the WEB_AUDIO implementation have been harmonized, with most
calculations done using floats, with narrowPrecisionToFloat() added when necessary to
narrow double results down to floats, and with float constants initialized with float values:

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createByMixingToMono):

  • platform/audio/AudioBus.h:

(WebCore::AudioBus::sampleRate):
(WebCore::AudioBus::setSampleRate):

  • platform/audio/AudioDSPKernel.h:

(WebCore::AudioDSPKernel::AudioDSPKernel):
(WebCore::AudioDSPKernel::sampleRate):

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/AudioDestination.h:
  • platform/audio/AudioFileReader.h:
  • platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::AudioProcessor):
(WebCore::AudioProcessor::sampleRate):

  • platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::decibelsToLinear):
(WebCore::AudioUtilities::linearToDecibels):
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):

  • platform/audio/AudioUtilities.h:
  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::parameterValue):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):

  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::sampleRate):
(WebCore::DynamicsCompressor::nyquist):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::saturate):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/DynamicsCompressorKernel.h:
  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::EqualPowerPanner):

  • platform/audio/EqualPowerPanner.h:
  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::create):
(WebCore::HRTFDatabase::HRTFDatabase):

  • platform/audio/HRTFDatabase.h:

(WebCore::HRTFDatabase::sampleRate):

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):

  • platform/audio/HRTFDatabaseLoader.h:

(WebCore::HRTFDatabaseLoader::databaseSampleRate):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
(WebCore::HRTFElevation::createForSubject):
(WebCore::HRTFElevation::createByInterpolatingSlices):

  • platform/audio/HRTFElevation.h:

(WebCore::HRTFElevation::sampleRate):
(WebCore::HRTFElevation::HRTFElevation):

  • platform/audio/HRTFKernel.cpp:

(WebCore::extractAverageGroupDelay):
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):

  • platform/audio/HRTFKernel.h:

(WebCore::HRTFKernel::create):
(WebCore::HRTFKernel::frameDelay):
(WebCore::HRTFKernel::sampleRate):
(WebCore::HRTFKernel::HRTFKernel):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::fftSizeForSampleRate):

  • platform/audio/HRTFPanner.h:

(WebCore::HRTFPanner::sampleRate):

  • platform/audio/Panner.cpp:

(WebCore::Panner::create):

  • platform/audio/Panner.h:
  • platform/audio/chromium/AudioBusChromium.cpp:

(WebCore::AudioBus::loadPlatformResource):

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationMac::AudioDestinationMac):

  • platform/audio/mac/AudioDestinationMac.h:

(WebCore::AudioDestinationMac::sampleRate):

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/mac/AudioFileReaderMac.h:
  • webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::DecodingTask::create):
(WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask):

  • webaudio/AsyncAudioDecoder.h:

(WebCore::AsyncAudioDecoder::DecodingTask::sampleRate):

  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):

  • webaudio/AudioBasicProcessorNode.h:
  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::createFromAudioFileData):
(WebCore::AudioBuffer::AudioBuffer):

  • webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::sampleRate):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

  • webaudio/AudioBufferSourceNode.h:
  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::AudioChannelMerger):

  • webaudio/AudioChannelMerger.h:

(WebCore::AudioChannelMerger::create):

  • webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::AudioChannelSplitter):

  • webaudio/AudioChannelSplitter.h:

(WebCore::AudioChannelSplitter::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::createBuffer):

  • webaudio/AudioContext.h:

(WebCore::AudioContext::sampleRate):

  • webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::AudioGainNode):

  • webaudio/AudioGainNode.h:

(WebCore::AudioGainNode::create):

  • webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

  • webaudio/AudioListener.h:

(WebCore::AudioListener::setPosition):
(WebCore::AudioListener::setOrientation):
(WebCore::AudioListener::setVelocity):

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):

  • webaudio/AudioNode.h:

(WebCore::AudioNode::sampleRate):

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::getAzimuthElevation):

  • webaudio/AudioPannerNode.h:

(WebCore::AudioPannerNode::create):

  • webaudio/AudioParam.cpp:

(WebCore::AudioParam::value):
(WebCore::AudioParam::smoothedValue):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateSampleAccurateValues):

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::timeToSampleFrame):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • webaudio/AudioSourceNode.h:

(WebCore::AudioSourceNode::AudioSourceNode):

  • webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

  • webaudio/BiquadFilterNode.h:

(WebCore::BiquadFilterNode::create):

  • webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • webaudio/BiquadProcessor.h:
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::create):

  • webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):

  • webaudio/DefaultAudioDestinationNode.h:

(WebCore::DefaultAudioDestinationNode::sampleRate):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):

  • webaudio/DelayDSPKernel.h:
  • webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • webaudio/DelayNode.h:

(WebCore::DelayNode::create):

  • webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • webaudio/DelayProcessor.h:
  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::create):

  • webaudio/HighPass2FilterNode.cpp:

(WebCore::HighPass2FilterNode::HighPass2FilterNode):

  • webaudio/HighPass2FilterNode.h:

(WebCore::HighPass2FilterNode::create):

  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::create):
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
(WebCore::JavaScriptAudioNode::initialize):

  • webaudio/JavaScriptAudioNode.h:
  • webaudio/LowPass2FilterNode.cpp:

(WebCore::LowPass2FilterNode::LowPass2FilterNode):

  • webaudio/LowPass2FilterNode.h:

(WebCore::LowPass2FilterNode::create):

  • webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::sampleRate):

  • webaudio/RealtimeAnalyserNode.cpp:

(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):

  • webaudio/RealtimeAnalyserNode.h:

(WebCore::RealtimeAnalyserNode::create):

  • webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::process):

  • webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::WaveShaperProcessor):

  • webaudio/WaveShaperProcessor.h:

Source/WebKit/chromium:

Platform-independent portions of WEB_AUDIO have changed from double -> float, and
platform-specific subclasses must change as well.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestination::hardwareSampleRate):

  • src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::sampleRate):

13:36 Changeset [96744] by bfulgham@webkit.org

[WinCairo] Teach old-run-webkit-tests about wincairo.
https://bugs.webkit.org/show_bug.cgi?id=69280

Reviewed by Adam Roben.

  • Scripts/old-run-webkit-tests: Handle wincairo case.

(buildPlatformResultHierarchy):
(readSkippedFiles): Ditto

  • Scripts/webkitdirs.pm: Deal with wincairo build case.

(determineConfiguration):

13:28 Changeset [96743] by caio.oliveira@openbossa.org

[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=69274

Reviewed by Andreas Kling.

Use currently existing QtWidgets to provide an implementation of
window.alert(), window.confirm() and window.prompt().

  • Shared/WebString.h:

(WebKit::WebString::createNull):
(WebKit::WebString::WebString):
Add a way to create a Null WebString. RunJavaScriptPrompt will differentiate
between empty and null strings.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
Create helper functions to enable and disable mouse events. This is useful for
disabling mouse events in the WebView when we show QtWidget dialogs to avoid
unwanted interaction with the page.

(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::init):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(createNullWKString):
(qt_wk_runJavaScriptPrompt):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::runJavaScriptAlert):
(WebKit::TouchViewInterface::runJavaScriptConfirm):
(WebKit::TouchViewInterface::runJavaScriptPrompt):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
13:25 Changeset [96742] by michaeln@google.com

Merge 96554 - A little more WebSQLDatabase thread safety.

https://bugs.webkit.org/show_bug.cgi?id=69277

  • switch to using AtomicallyInitializedStatic where appropiate
  • avoid using some Strings across threads

Reviewed by David Levin.

Existing tests apply.

  • storage/AbstractDatabase.cpp:

(WebCore::guidMutex):

(WebCore::guidToVersionMap):

(WebCore::guidToDatabaseMap):

(WebCore::guidForOriginAndName):

(WebCore::AbstractDatabase::databaseInfoTableName):

(WebCore::AbstractDatabase::AbstractDatabase):

(WebCore::AbstractDatabase::performOpenAndVerify):

(WebCore::AbstractDatabase::getVersionFromDatabase):

(WebCore::AbstractDatabase::setVersionInDatabase):

  • storage/AbstractDatabase.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::tracker):

  • storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::instance):

TBR=michaeln@google.com
Review URL: http://codereview.chromium.org/8152004

13:01 Changeset [96741] by commit-queue@webkit.org

Unreviewed, rolling out r96733.
http://trac.webkit.org/changeset/96733
https://bugs.webkit.org/show_bug.cgi?id=69454

Broke GCC for some reason (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-05

  • wtf/ListHashSet.h:

(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):

12:46 Changeset [96740] by commit-queue@webkit.org

[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
https://bugs.webkit.org/show_bug.cgi?id=68924

Source/WebKit2:

Implemented WKBundlePage private APIs to support the above functions.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetComposition):
(WKBundlePageHasComposition):
(WKBundlePageConfirmComposition):
(WKBundlePageConfirmCompositionWithText):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting):
(WebKit::WebPage::hasCompositionForTesting):
(WebKit::WebPage::confirmCompositionForTesting):

  • WebProcess/WebPage/WebPage.h:

Tools:

Added TextInputController files and JS interfaces for the above functions.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/DerivedSources.pro:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::textInputController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.

(WTR::TextInputController::create):
(WTR::TextInputController::TextInputController):
(WTR::TextInputController::~TextInputController):
(WTR::TextInputController::wrapperClass):
(WTR::TextInputController::makeWindowObject):
(WTR::TextInputController::setMarkedText):
(WTR::TextInputController::hasMarkedText):
(WTR::TextInputController::unmarkText):
(WTR::TextInputController::insertText):

  • WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

  • platform/wk2/Skipped:
12:22 Changeset [96739] by ap@apple.com

[Mac] Make built-in PDF description localizable
https://bugs.webkit.org/show_bug.cgi?id=69442

Reviewed by Dan Bernstein.

Source/WebCore:

Added strings for plug-in's name and for its supported MIME type.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in:
  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::builtInPDFPluginName):
(WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription):

  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:

(WebCore::builtInPDFPluginName):
(WebCore::pdfDocumentTypeDescription):

  • platform/LocalizedStrings.h:

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Use a localized string instead of a literal one.
12:07 Changeset [96738] by oliver@apple.com

Add rudimentary filtering to write barriers
https://bugs.webkit.org/show_bug.cgi?id=69392

Reviewed by Filip Pizlo.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add approximate filtering for write barriers based on the
target's mark bit. Also add some macros to support dumping
GC phase timings.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::markCellCard):

  • heap/Heap.cpp:

(JSC::GCTimer::GCTimerScope::GCTimerScope):
(JSC::GCTimer::GCTimerScope::~GCTimerScope):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

Add phase timing information.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::offsetOfMarks):
(JSC::MarkedBlock::gatherDirtyCells):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

../../../../Volumes/Data/git/WebKit/OpenSource/Tools:

When we're recording gc phase times Heap.o picks up
some exit time destructors, so we'll just ignore Heap.o
in this check.

  • Scripts/check-for-exit-time-destructors:
12:04 Changeset [96737] by levin@chromium.org

Attempt to fix the bindings test (broken by r96727).
Reviewed by Adam Barth.

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

11:46 Changeset [96736] by jamesr@google.com

[chromium] Hook WebCompositor interface for input events up to the compositor proper
https://bugs.webkit.org/show_bug.cgi?id=69394

Reviewed by Darin Fisher.

Source/WebCore:

This wires up WebCompositorImpl to the compositor itself so we can handle input events as scrolls on the
compositor thread, although it doesn't actually wire up any input events to actual scrolling. The way this
works:

  • CCThreadProxy owns an adapter that implements the CCScrollController interface
  • CCThreadProxy owns a CCInputHandler, which is implemented by WebKit::WebCompositorImpl, that has a pointer to

the adapter

  • CCLayerTreeHost has an identifier (an int) for its WebKit::WebCompositorImpl that's initialized in

initializeLayerRenderer. This identifier is exposed to its owner (WebKit::WebViewImpl) so the embedder can wire
up the threading logic behind the scenes.

This is just plumbing, no change in behavior.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCInputHandler.h: Added.

(WebCore::CCInputHandler::~CCInputHandler):
(WebCore::CCInputHandler::CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::compositorIdentifier):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScrollController.h: Added.

(WebCore::CCScrollController::CCScrollController):
(WebCore::CCScrollController::~CCScrollController):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::compositorIdentifier):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxyScrollControllerAdapter::create):
(WebCore::CCThreadProxyScrollControllerAdapter::~CCThreadProxyScrollControllerAdapter):
(WebCore::CCThreadProxyScrollControllerAdapter::scrollRootLayer):
(WebCore::CCThreadProxyScrollControllerAdapter::CCThreadProxyScrollControllerAdapter):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::compositorIdentifier):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

This teaches WebCompositorImpl about WebCore::CCInputHandler, which WebCompositorImpl implements, and
CCScrollController, which WebCompositorImpl will use in the future to do actual scrolling. One thing that is a
bit unusual here is WebCore::CCInputHandler::create() which is defined in WebCompositorImpl.cpp. This is
because we need a WebKit object (WebKit::WebCompositorImpl) to be owned by a WebCore object (WebCore::CCThreadProxy).
The WebCore side only needs to know about the interface, CCInputHandler, but the actual implementation has to
live in WebKit in order to know about the concrete type.

  • src/WebCompositorImpl.cpp:

(WebCore::CCInputHandler::create):
(WebKit::WebCompositor::fromIdentifier):
(WebKit::WebCompositorImpl::fromIdentifier):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::identifier):

  • src/WebCompositorImpl.h:

(WebKit::WebCompositorImpl::create):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
  • tests/WebCompositorImplTest.cpp:
11:36 Changeset [96735] by rniwa@webkit.org

Merge 96552 - REGRESSION(r94274): cloned text input loses value
https://bugs.webkit.org/show_bug.cgi?id=69095

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.

Test: fast/forms/clone-input-with-dirty-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributeProperties):

LayoutTests:

Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.

  • fast/forms/clone-input-with-dirty-value-expected.txt: Added.
  • fast/forms/clone-input-with-dirty-value.html: Added.

Review URL: http://codereview.chromium.org/8142040

11:31 Changeset [96734] by rniwa@webkit.org

Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event
https://bugs.webkit.org/show_bug.cgi?id=69315

Reviewed by Kent Tamura.

Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.

Added a manual test. Unfortunately, the test always passes in DRT.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/FrameSelection.h:
  • manual-tests/mutate-unfocused-text-with-selection.html: Added.

Review URL: http://codereview.chromium.org/8133029

11:29 Changeset [96733] by andersca@apple.com

Use std::reverse_iterator for ListHashSet reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=69446

Reviewed by Darin Adler.

  • wtf/ListHashSet.h:

Use the std::reverse_iterator iterator adaptor for the ListHashSet reverse iterators
and get rid of the ListHashSetReverseIterator and ListHashSetConstReverseIterator classes.

11:22 Changeset [96732] by commit-queue@webkit.org

Shrink OutlineValue.
https://bugs.webkit.org/show_bug.cgi?id=69436

Patch by Andreas Kling <kling@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

Move OutlineValue::m_isAuto up into the base class (BorderValue.)
This shrinks OutlineValue by 32 bit, which in turn shrinks
StyleBackgroundData by one CPU word.

This reduces memory consumption by 250 kB (on 64-bit) when loading
the full HTML5 spec.

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::isAuto):

11:21 Changeset [96731] by commit-queue@webkit.org

[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
https://bugs.webkit.org/show_bug.cgi?id=69365

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

Source/WebCore:

Expose computeViewportAttributes for mac build.

  • WebCore.exp.in:

Source/WebKit2:

Implement retrieving viewport configuration as text in WebProcess.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageViewportConfigurationAsText):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewportConfigurationAsText):

  • WebProcess/WebPage/WebPage.h:

Tools:

Added js API in WTR LayoutTestController.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::dumpConfigurationForViewport):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip passed tests on Qt. The tests work on Mac, too. But they are skipped by
platform/mac/Skipped.

  • platform/qt-wk2/Skipped:
11:20 WebKitGTK edited by plaes@plaes.org
Fix links (diff)
11:18 Changeset [96730] by simonjam@chromium.org

[Chromium] Add baselines for new SVG tests from r96712.

  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
11:17 WebKitGTK/1.4.x edited by plaes@plaes.org
Fix title (diff)
11:16 WebKitGTK/1.4.x edited by plaes@plaes.org
Remove strikethrough so it's a bit more readable. (diff)
11:15 Changeset [96729] by barraclough@apple.com

Make Object.prototype getter/setter methods match ES5 behaviour
https://bugs.webkit.org/show_bug.cgi?id=69393

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The rest of Object.prototype no longer substitute Null/Undefined with the global object,
this is old ES3 behaviour. Remove it here too.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

LayoutTests:

Update tests to conform with ES5 style handling of 'this' in host functions.

  • fast/dom/Window/Location/window-override-location-using-defineGetter.html:
  • fast/dom/Window/Location/window-override-window-using-defineGetter.html:
  • fast/js/exception-sequencing-binops.js:
  • fast/js/exception-sequencing.html:
  • fast/js/pic/delete-global-object.html:
11:15 WebKitGTK/1.4.x edited by plaes@plaes.org
Added changeset descriptions for 1.4.1 (diff)
11:10 WebKitGTK/1.6.x edited by plaes@plaes.org
Added link to 1.4.x (diff)
11:09 WebKitGTK/1.4.x created by plaes@plaes.org
Preliminary page for 1.4.x
11:09 Changeset [96728] by scherkus@chromium.org

2011-10-05 Andrew Scherkus <scherkus@chromium.org>

Unreviewed. Skipping media layout tests for Mac Leopard GPU.

They're a maintenance burden and we don't run the GPU compositor on Leopard.

  • platform/chromium/test_expectations.txt:
11:08 Changeset [96727] by annacc@chromium.org

Source/WebCore: Functions to make <track> enabled at runtime, including changes to
CodeGeneratorvV8 to allow entire interfaces (not just attributes) to
be runtime-enabled.
https://bugs.webkit.org/show_bug.cgi?id=69352

Reviewed by Adam Barth.

No new tests. No new functionality.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):

  • bindings/scripts/CodeGeneratorV8.pm:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):

  • html/HTMLTrackElement.idl:

Source/WebKit/chromium: Functions to make <track> enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69352

Reviewed by Adam Barth.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableVideoTrack):
(WebKit::WebRuntimeFeatures::isVideoTrackEnabled):

11:07 Changeset [96726] by kbr@google.com

Mask underlying RENDERER and VENDOR strings
https://bugs.webkit.org/show_bug.cgi?id=69389

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/canvas/webgl/renderer-and-vendor-strings.html

  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getParameter):

LayoutTests:

  • fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
  • fast/canvas/webgl/renderer-and-vendor-strings.html: Added.
11:02 Changeset [96725] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac)

Temporarily disable Skia on Mac on Leopard and Snow Leopard.

  • LayoutTests/platform/chromium/test_expectations.txt:
11:00 WebKitGTK/1.6.x edited by plaes@plaes.org
Add back "Changes merged" (diff)
10:59 WebKitGTK/1.6.x edited by plaes@plaes.org
Added 1.6.1 for history purposes (diff)
10:56 Changeset [96724] by commit-queue@webkit.org

[EFL] ImageDiff: Do not clear the image before it is processed and compared
https://bugs.webkit.org/show_bug.cgi?id=69378

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-05
Reviewed by Antonio Gomes.

Commit 61836 to Evas added a few cleanup calls to some
evas_object_image functions which effectively made ImageDiff consider
all images to be equal.

It turns out that now evas_object_image_colorspace_set clears any
data set, so the call to evas_object_image_data_set was not having any
effect.

  • DumpRenderTree/efl/ImageDiff.cpp:

(readImageFromStdin): Call evas_object_image_data_set after
evas_object_image_colorspace_set.

10:54 WebKitGTK/1.6.x created by plaes@plaes.org
Create proper page for 1.6.x releases
10:51 Changeset [96723] by commit-queue@webkit.org

[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=68449

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-05
Reviewed by Antonio Gomes.

evas_render() must be called to close up temporary files and unmap unused
resources. evas_object_image_data_set() must be called after an
evas_object_image_data_get() to balance an internal reference count.

  • DumpRenderTree/efl/ImageDiff.cpp:

(differenceImageFromDifferenceBuffer):
(calculateDifference):
(printImage):
(printImageDifferences):

10:44 Changeset [96722] by paroga@webkit.org

Get rid of posixThread in MachineStackMarker::Thread
https://bugs.webkit.org/show_bug.cgi?id=54836

Reviewed by Oliver Hunt.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::getCurrentPlatformThread):
(JSC::equalThread):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):

10:41 Changeset [96721] by commit-queue@webkit.org

Spec change - option.label should be reflected like option.value
https://bugs.webkit.org/show_bug.cgi?id=68684

Patch by Sachin Puranik <jcqt43@motorola.com> on 2011-10-05
Reviewed by Darin Adler.

Source/WebCore:

Incorporating the recent change in spec for label attribute of
option element. While retrieving the "Label" IDL attribute return
the "Label" content attribute if present , else return the
value of textContent attribute.

Tests: fast/forms/option-label-trim-html-spaces.html

fast/forms/option-value-and-label-changed-by-js.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):style fixes

  • dom/OptionElement.h: make collectOptionInnerText() protected.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::label): return innerText if label attribute un-available.
(WebCore::HTMLOptionElement::setLabel):setLabel() implementation.

  • html/HTMLOptionElement.h: add setLabel declaration.
  • html/HTMLOptionElement.idl: Change reflect to ConvertNullToNullString in idl

LayoutTests:

IDL "Label" attribute of option element should return textContent IDL attribute
if conetent attribute "Label" is unavailable. Changed the tests to match
above said behaviour. Added new tests.

  • fast/forms/option-label-trim-html-spaces-expected.txt: Html space triming test.
  • fast/forms/option-label-trim-html-spaces.html: Html space triming test.
  • fast/forms/option-value-and-label-changed-by-js-expected.txt: Attribute change from JS.
  • fast/forms/option-value-and-label-changed-by-js.html: Attribute change from JS.
  • fast/forms/option-value-and-label-expected.txt: Changed test case as per new spec.
  • fast/forms/option-value-and-label.html: Changed test case as per new spec.
10:39 Changeset [96720] by commit-queue@webkit.org

[GTK] Fix compilation with gtk v2.20.1
https://bugs.webkit.org/show_bug.cgi?id=69418

Unreviewed build fix

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-05

  • platform/gtk/GtkDragAndDropHelper.cpp:
10:19 Changeset [96719] by loislo@chromium.org

Unreviewed. Reduce test flakyness.
There was a race between Inspector's internal page reloaded message and load event.

  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-load-event.html:
10:05 Changeset [96718] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=68731

Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
translation offset and clip rects when overflow or outlines spill out.

Reviewed by Darin Adler.

Source/WebCore:

Added new test in fast/regions.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOverflowRect):

LayoutTests:

  • fast/regions/outline-sides-in-region.html: Added.
  • platform/mac/fast/regions/outline-sides-in-region-expected.png: Added.
  • platform/mac/fast/regions/outline-sides-in-region-expected.txt: Added.
09:52 Changeset [96717] by ggaren@apple.com

Removed JSValue::toJSNumber
https://bugs.webkit.org/show_bug.cgi?id=69399

No perf. change.

toJSNumber() used to provide an implicit fast path for immediate numbers,
but those fast paths are all explicit now, so it's just cruft.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:
09:51 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the WK2 bot (diff)
09:45 Changeset [96716] by yurys@chromium.org

2011-10-05 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix: make InspectorStateClient.h Private in XCode project.

  • WebCore.xcodeproj/project.pbxproj:
09:39 Changeset [96715] by mrobinson@webkit.org

libsoup-CRITICAL : soup_message_io_pause: assertion `io != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=64263

Reviewed by Xan Lopez.

No new tests. This is difficult to test because it relies on network
timing and to catch and parse stdout.

Instead of allowing messages to pause and unpause after receiving headers,
we wait until the completion of the sendRequestCallback. This will ensure
that the SoupSession is in the correct state to allow for pausing and unpausing.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::platformSetDefersLoading): Don't pause and unpause
until the sendRequestCallback is called. We detect this situation by
checking whether or not we have an input stream yet. Previously the code
was only pausing until after soupMessage->status_code was not equal to
SOUP_STATUS_NONE. This means that the message was pausable right after
headers are received. sendRequestCallback happens some time after that.

09:27 Changeset [96714] by ossy@webkit.org

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Unskip sputnik tests, because they pass with newer Qt5.
09:27 Changeset [96713] by loislo@chromium.org

Unreviewed build fix for Debug builders.

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

09:20 Changeset [96712] by krit@webkit.org

SVG 1.1: ineffectual transform attribute for ClipPath
https://bugs.webkit.org/show_bug.cgi?id=55361

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Respect 'transform' attribute/property for <clip-path>.
If the masking code path is used the mask context gets transformed, otherwise the path itself.

Tests: svg/clip-path/clip-path-transform-1.svg

svg/clip-path/clip-path-transform-2.svg
svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping): Transform the clip path.
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Transform the context of the mask image.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Repaint rect must get concatenated with the current animated transformation.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Point for hit testing must be transformed by the current animated transformation.

  • rendering/svg/RenderSVGResourceClipper.h:

LayoutTests:

Reviewed by Nikolas Zimmermann.

Test that the clip path gets concatenated with the current animated transformation and
that hit testing is affected correctly.

  • platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-transform-1-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Added.
  • svg/clip-path/clip-path-transform-1.svg: Added. Test clipping to path with transform.
  • svg/clip-path/clip-path-transform-2.svg: Added. Test masking with transform.
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Added.
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html: Added.
  • svg/dynamic-updates/script-tests/SVGClipPathElement-transform-influences-hitTesting.js: Added.

(executeBackgroundTest):
(executeTest):

09:14 Changeset [96711] by pfeldman@chromium.org

Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline.
https://bugs.webkit.org/show_bug.cgi?id=69431

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.hide):
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._nodeRemoved):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.wireToDomAgent):
(WebInspector.ElementsTreeOutline.prototype.setVisible):
(WebInspector.ElementsTreeOutline.prototype.addEventListener):
(WebInspector.ElementsTreeOutline.prototype.removeEventListener):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
(WebInspector.ElementsTreeOutline.prototype.findTreeElement.parentNode):
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype.adjustCollapsedRange):
(WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
(WebInspector.ElementsTreeElement.prototype.insertChildElement):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._editingCancelled):
():

  • inspector/front-end/externs.js:

(WebInspector.ElementsTreeOutline):

  • inspector/front-end/utilities.js:

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpElementsTree):
(initialize_ElementTest.InspectorTest.expandElementsTree.onAllNodesAvailable):
(initialize_ElementTest.InspectorTest.expandElementsTree):

  • inspector/elements/edit-dom-actions.html:
  • inspector/styles/styles-update-from-js.html:
09:10 Changeset [96710] by yurys@chromium.org

Web Inspector: provide a way for persisting worker inspector state
https://bugs.webkit.org/show_bug.cgi?id=69422

Source/WebCore:

Worker inspector can persist and restore its state. InspectorStateClient is
exctracted into a separate interface and has a custom implementation in case
of worker inspector.

Reviewed by Pavel Feldman.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorClient.h:
  • inspector/InspectorState.cpp:

(WebCore::InspectorState::InspectorState):

  • inspector/InspectorState.h:
  • inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h.

(WebCore::InspectorStateClient::~InspectorStateClient):
(WebCore::InspectorStateClient::updateInspectorStateCookie):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

  • inspector/WorkerInspectorController.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postMessageToPageInspector):
(WebCore::SharedWorkerProxy::updateInspectorStateCookie):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::updateInspectorStateCookie):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:

Source/WebKit/chromium:

Provided an API for saving/restoring worker inspector state.

Reviewed by Pavel Feldman.

  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):

  • public/WebSharedWorker.h:

(WebKit::WebSharedWorker::reattachDevTools):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::WebSharedWorkerImpl::reattachDevTools):

  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::updateInspectorStateCookie):

  • src/WebWorkerClientImpl.h:
09:09 Changeset [96709] by loislo@chromium.org

Web Inspector: debugger-activation-crash2.html are flaky.
https://bugs.webkit.org/show_bug.cgi?id=69428

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/debugger-activation-crash2-expected.txt:
  • inspector/debugger/debugger-activation-crash2.html:
  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.
09:00 WebKitGTK edited by plaes@plaes.org
Link to a new page for stable version tracking (diff)
08:51 Changeset [96708] by gavinp@chromium.org

REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
https://bugs.webkit.org/show_bug.cgi?id=69424

Skip an extra frame in WTFReportBacktrace. As well, I now don't count skipped frames in maxFrames,
so I've updated maxFrames to 31, as with one skipped frame the previous value was effectively
31 reported frames.

Reviewed by Adam Roben.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
08:40 Changeset [96707] by inferno@chromium.org

Crash in SVGTRefElement::updateReferencedText.
https://bugs.webkit.org/show_bug.cgi?id=67555

Reviewed by Rob Buis.

Source/WebCore:

Test: svg/text/tref-event-listener-crash.svg

  • svg/SVGTRefElement.cpp:

(WebCore::SubtreeModificationEventListener::clear): This fixes the
crash. there can be cases when our target is removed, but our event
listener is alive. when our tref is going away, we need to disable
those event listeners by nulling out our tref element.
(WebCore::SubtreeModificationEventListener::handleEvent): Adding
null check for tref element, which can happen in cases where
event listener's clear is called, but we could not remove it from
the target.
(WebCore::SVGTRefElement::~SVGTRefElement): There are always
cases when removedFromDocument is not called. So, important to
clear event listener in those cases.
(WebCore::SVGTRefElement::svgAttributeChanged): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::buildPendingResource): Common function
to prevent triple duplication of same code. made it more readable.
(WebCore::SVGTRefElement::insertedIntoDocument): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::removedFromDocument): Use new helper
removeEventListener.
(WebCore::SVGTRefElement::clearEventListener): Helper to clear
event listener. Name chosen to not collide with Node::removeEventListener.

  • svg/SVGTRefElement.h: definition of new helpers.
  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedIntoDocument): Copy same
logic as tref and use element. more asserts and easy bailouts.

LayoutTests:

  • svg/text/tref-event-listener-crash-expected.txt: Added.
  • svg/text/tref-event-listener-crash.svg: Added.
08:18 Changeset [96706] by pfeldman@chromium.org

2011-10-05 Pavel Feldman <pfeldman@google.com>

Not reviewed: restoring : shortcut in inspector.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSidebarButtons):
08:13 Changeset [96705] by andreas.kling@nokia.com

Shrink FontDescription.
https://bugs.webkit.org/show_bug.cgi?id=69426

Reviewed by Nikolas Zimmermann.

Pack FontDescription's members in a bitfield, effectively shrinking
the class by two CPU-words. This reduces memory consumption by ~1 MB
on 64-bit when loading the full HTML5 spec.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::orientation):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::widthVariant):

07:51 Changeset [96704] by kbalazs@webkit.org

[Qt][WK2] First test always fails because of useless xcb dump
https://bugs.webkit.org/show_bug.cgi?id=69132

Unskip the first test because the failure always affects the first test we run
so skipping makes no sense.

  • platform/qt-wk2/Skipped:
07:30 Changeset [96703] by vsevik@chromium.org

Web Inspector: Add support for search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/search/search-in-concatenated-script.html

http/tests/inspector/search/search-in-script.html

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts.var):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):

  • http/tests/inspector/search/resources/search-concatenated.html: Added.
  • http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-concatenated-script.html: Added.
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-script.html: Added.
  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest):

  • inspector/debugger/content-providers.html:
  • platform/qt/Skipped:
07:20 Changeset [96702] by alexis.menard@openbossa.org

[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
https://bugs.webkit.org/show_bug.cgi?id=69111

Reviewed by Kenneth Rohde Christiansen.

Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.

Source/WebCore:

No new tests : existing ones should cover.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::SharedCookieJarQt):

Source/WebKit2:

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDataLocation):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

07:19 Changeset [96701] by kbalazs@webkit.org

[Qt][WK2] Try to paint the bot green.

Unreviewed gardening.

  • platform/qt-wk2/Skipped:
07:14 Changeset [96700] by paroga@webkit.org

Unreviewed build fix for !ENABLE(FILTERS) after r96203.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientUpdatedFromElement):

06:53 Changeset [96699] by kbalazs@webkit.org

WTR needs an implementation for eventSender.continuousMouseScrollBy
https://bugs.webkit.org/show_bug.cgi?id=69417

Unreviewed gardening: skip dependent test.

  • platform/wk2/Skipped:
06:08 Changeset [96698] by kbalazs@webkit.org

[Qt][WK2] Unreviewed build fix.

Don't use WebCore directly in WTR.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

05:21 Changeset [96697] by loislo@chromium.org

Unreviewed build fix for windows bots after r96679.

  • html/NumberInputType.h:
05:03 Changeset [96696] by loislo@chromium.org

Unreviewed rebaseline for test.

  • inspector/debugger/linkifier-expected.txt:
04:55 Changeset [96695] by pfeldman@chromium.org

Web Inspector: make ResourceView(s) compile
https://bugs.webkit.org/show_bug.cgi?id=69351

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._sortCookies):

  • inspector/front-end/DataGrid.js:
  • inspector/front-end/EmptyView.js:
  • inspector/front-end/FontView.js:

(WebInspector.FontView.prototype._createContentIfNeeded):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/NetworkItemView.js:
  • inspector/front-end/ResourceCookiesView.js:
  • inspector/front-end/ResourceHTMLView.js:

(WebInspector.ResourceHTMLView.prototype.hide):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._refreshParms):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
(WebInspector.ResourceHeadersView.prototype._refreshHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersText):

  • inspector/front-end/ResourceJSONView.js:

(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):

  • inspector/front-end/ResourcePreviewView.js:
  • inspector/front-end/ResourceResponseView.js:
  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):

  • inspector/front-end/SourceFrame.js:
  • inspector/front-end/TabbedPane.js:
  • inspector/front-end/UIUtils.js:

(Number.secondsToString):
(Number.bytesToString):

  • inspector/front-end/inspector.js:
04:41 Changeset [96694] by loislo@chromium.org

Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146

In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/linkifier.html

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/linkifier-expected.txt: Added.
  • inspector/debugger/linkifier.html: Added.
04:38 Changeset [96693] by andreas.kling@nokia.com

REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
https://bugs.webkit.org/show_bug.cgi?id=64914

Reviewed by Antti Koivisto.

Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
since nobody is using them anymore. nextOnLineExists() is still used by
GTK+ accessibility code.

Also added a compile-time assertion to guard against future bloating of
the InlineBox class.

  • rendering/InlineBox.cpp:

(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):

04:24 Changeset [96692] by andreas.kling@nokia.com

Shrink FontFallbackList.
https://bugs.webkit.org/show_bug.cgi?id=69093

Rubber-stamped by Antti Koivisto.

Workaround MSVC quirk by making enum bitfield "unsigned".

  • platform/graphics/FontFallbackList.h:
04:19 Changeset [96691] by andreas.kling@nokia.com

Shrink StyleRareNonInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69331

Reviewed by Darin Adler.

Workaround MSVC quirk by making enum bitfields "unsigned".

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::transformStyle3D):
(WebCore::InheritedFlags::backfaceVisibility):
(WebCore::InheritedFlags::pageSizeType):

  • rendering/style/StyleRareNonInheritedData.h:
03:32 Changeset [96690] by paroga@webkit.org

Unreviewed WinCE build fix for r96595.

  • wtf/Assertions.cpp:

RtlCaptureStackBackTrace() isn't available on WinCE.

03:12 Changeset [96689] by pfeldman@chromium.org

Web Inspector: add CSS model classes to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69376

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-05
Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CSSCompletions.js:
  • inspector/front-end/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):

  • inspector/front-end/ResourceTreeModel.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._containsInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

  • inspector/front-end/externs.js:

(Array.prototype.keySet):

02:28 Changeset [96688] by levin@chromium.org

watchlist: Add more rules for chromium public api and sort the file.
https://bugs.webkit.org/show_bug.cgi?id=69323

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
02:26 Changeset [96687] by hans@chromium.org

Rebaseline fast/repaint/japanese-rl-selection-repaint-in-regions.html
for chromium-cg-mac after r96675. (By Garden-o-Matic.)

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
02:25 Changeset [96686] by tkent@chromium.org

Input styles are unexpectedly shared regardless of required status difference.
https://bugs.webkit.org/show_bug.cgi?id=69402

Reviewed by Daniel Bates.

Source/WebCore:

Tests: fast/css/pseudo-required-shared.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().

LayoutTests:

  • fast/css/pseudo-required-shared-expected.html: Added.
  • fast/css/pseudo-required-shared.html: Added.
02:21 Changeset [96685] by levin@chromium.org

watchlist: Don't add the same message to a bug more than once.
https://bugs.webkit.org/show_bug.cgi?id=69303

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine

if a message is in the comments already.

  • Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:

Pick a bug supplied by the mock. Change the test due to different output
from the mock watch list tool.

  • Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return

another email so it will be filtered out, fix bugs to have the cc and comment fields,
and fix fetch_bug to handle bug_id's which are text (because that took me way too long
to debug).

  • Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments

and/or cc's that are already in the bug.

  • Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,

and remove a comment that is filtered out.

02:09 Changeset [96684] by kbalazs@webkit.org

[Qt][WK2] Unreviewed build fix after r96643.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

02:03 Changeset [96683] by rgabor@webkit.org

[Qt] Unreviewed gardening, update expected file after r96509.

  • platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt:
01:21 Changeset [96682] by yurys@chromium.org

[Chromium] Web Inspector: save inspector state into single string instead of string map
https://bugs.webkit.org/show_bug.cgi?id=69335

Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):

  • src/WebDevToolsAgentImpl.h:
01:09 Changeset [96681] by rgabor@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip new failing tests.
01:03 Changeset [96680] by carlosgc@webkit.org

[GTK] Use WKRetainPtr for WK types in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=69404

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextFinalize):
(createDefaultWebContext):
(webkitWebContextGetWKContext):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_uri):
(webkit_web_view_load_alternate_html):

Note: See TracTimeline for information about the timeline view.