Timeline


and

10/11/11:

23:10 Changeset [97236] by rniwa@webkit.org

Rebaseline after r97225.

  • fast/dom/constructed-objects-prototypes-expected.txt:
23:09 Changeset [97235] by barraclough@apple.com

Unreviewed, temporarily reverted r97216 due to bug #69897.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

23:05 Changeset [97234] by commit-queue@webkit.org

DFG 32_64 - fix silentFillGPR
https://bugs.webkit.org/show_bug.cgi?id=69903

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-11
Reviewed by Filip Pizlo.

Fix a small bug in silentFillGPR,
and add the newly introduced DFG file to CMakeListsEfl.

  • CMakeListsEfl.txt:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

22:56 Changeset [97233] by commit-queue@webkit.org

[chromium] Add accessor for plugin request to not scale print output.
https://bugs.webkit.org/show_bug.cgi?id=68853

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • public/WebPlugin.h:

(WebKit::WebPlugin::isPrintScalingDisabled):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):

  • src/WebFrameImpl.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isPrintScalingDisabled):

  • src/WebPluginContainerImpl.h:
22:35 Changeset [97232] by commit-queue@webkit.org

Separate compositor client thread from webkit's main thread.
https://bugs.webkit.org/show_bug.cgi?id=69048

Patch by Antoine Labour <piman@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

Source/WebCore:

Covered by compositing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCMainThread.cpp:
  • platform/graphics/chromium/cc/CCMainThread.h:
  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::setMainThread):
(WebCore::CCProxy::CCProxy):

  • platform/graphics/chromium/cc/CCProxy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::currentThread):

  • src/CCMainThreadImpl.cpp: Added.

(WTF::TaskWrapper::TaskWrapper):
(WTF::TaskWrapper::~TaskWrapper):
(WTF::TaskWrapper::run):
(WebCore::CCMainThread::initialize):
(WebCore::CCMainThread::postTask):

22:25 Changeset [97231] by simon.fraser@apple.com

Some more WK2 test skipping.

  • platform/wk2/Skipped:
22:14 Changeset [97230] by simon.fraser@apple.com

Add some tests to the WK2 skipped list which require layoutTestController or
textInputController methods not implemented yet, and remove a WK2-specific
result that is not longer correct.

  • platform/mac-wk2/fast/css/pseudo-any-expected.txt: Removed.
  • platform/wk2/Skipped:
21:45 Changeset [97229] by simon.fraser@apple.com

Fix Leopard and Snow Leopard builds, which don't use the scrollbar painter.

  • platform/mac/ScrollAnimatorMac.mm:
21:36 Changeset [97228] by rniwa@webkit.org

Check in failing test expectation after r95897. The failure is tracked by the bug 69069.

  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
21:36 Changeset [97227] by simon.fraser@apple.com

Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Reviewed by Darin Adler.

Source/WebCore:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

Fix scroll animator code for Mac and Chromium that was casting the ScrollbarTheme
without type-checking it to test whether it's the mock theme.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::startRepeatingTimer):

  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scroll):
(WebCore::ScrollAnimatorWin::accelerationTime):
(WebCore::ScrollAnimatorWin::animateScroll):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollbarOverlayStyle):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::maxOverlapBetweenPages):
(WebCore::Scrollbar::Scrollbar):

  • platform/ScrollbarTheme.cpp: Copied from Source/WebCore/platform/mock/ScrollbarThemeMock.h.

(WebCore::ScrollbarTheme::theme):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::isMockTheme):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::layout):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::chromiumScrollbarTheme):
(WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(+[ScrollbarPrefsObserver behaviorPrefsChanged:]):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::macScrollbarTheme):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):

  • platform/mock/ScrollbarThemeMock.h:

(WebCore::ScrollbarThemeMock::isMockTheme):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):

  • rendering/RenderLayer.cpp:

(WebCore::cornerRect):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):

  • rendering/RenderScrollbarTheme.h:

(WebCore::RenderScrollbarTheme::scrollbarThickness):
(WebCore::RenderScrollbarTheme::buttonsPlacement):
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
(WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
(WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
(WebCore::RenderScrollbarTheme::registerScrollbar):
(WebCore::RenderScrollbarTheme::unregisterScrollbar):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::scrollbarThickness):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::menuListInternalPadding):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):

Source/WebKit/chromium:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbar::defaultThickness):

Source/WebKit/qt:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

Source/WebKit/win:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • WebScrollBar.cpp:

(WebScrollBar::requestedWidth):
(WebScrollBar::requestedHeight):

  • WebView.cpp:

(WebView::WebViewWndProc):

Source/WebKit2:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paintControls):

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::bounds):

21:21 Changeset [97226] by mrobinson@webkit.org

[GTK] [WebKit2] Make adding another unit test easier
https://bugs.webkit.org/show_bug.cgi?id=69409

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Include the new testing makefile.

Source/WebKit2:

  • GNUmakefile.am: Add the new WebKit2 API tests.
  • UIProcess/API/gtk/tests/GNUmakefile.am: Added.
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp: Added. A fixture for creating load tracking tests.
  • UIProcess/API/gtk/tests/LoadTrackingTest.h: Added.
  • UIProcess/API/gtk/tests/TestMain.cpp: Copied from Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c.

(main):

  • UIProcess/API/gtk/tests/TestMain.h: Added.
  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp: Copied from Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Added.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c.
  • UIProcess/API/gtk/tests/WebViewTest.cpp: Added. A fixture for generic WebView tests.
  • UIProcess/API/gtk/tests/WebViewTest.h: Added.
  • UIProcess/API/gtk/tests/testloading.c: Removed.
  • UIProcess/API/gtk/tests/testwebcontext.c: Removed.

Tools:

  • Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute

new WebKit2 tests.

21:05 Changeset [97225] by haraken@chromium.org

Implement a WebKitTransitionEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69829

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the WebKitTransitionEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initWebKitTransitionEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional WebKitTransitionEventInit eventInitDict)]
interface WebKitTransitionEvent : Event {

...;

}

dictionary WebKitTransitionEventInit : EventInit {

DOMString propertyName;
double elapsedTime;

}

Test: fast/events/constructors/webkit-transition-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the WebKitTransitionEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for WebKitTransitionEvent.
  • dom/WebKitTransitionEvent.cpp:

(WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit):
(WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):

  • dom/WebKitTransitionEvent.h: Added a definition for WebKitTransitionEventInit.

(WebCore::WebKitTransitionEvent::create):
(WebCore::WebKitTransitionEvent::isWebKitTransitionEvent):

  • dom/WebKitTransitionEvent.idl: Makes WebKitTransitionEvent constructible.

LayoutTests:

webkit-transition-event-constructor.html checks the behavior of the WebKitTransitionEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/events/constructors/webkit-transition-event-constructor-expected.txt: Added.
  • fast/events/constructors/webkit-transition-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped webkit-transition-event-constructor.html, since V8 does not yet have the WebKitTransitionEvent constructor.
20:45 Changeset [97224] by commit-queue@webkit.org

Source/WebCore: :checked pseudo selector not matching selected option
https://bugs.webkit.org/show_bug.cgi?id=63192

Patch by Sameer Patil <mkrp87@motorola.com> on 2011-10-11
Reviewed by Kent Tamura.

Test: fast/css/checked-pseudo-selector.html

Option element selected state need to be checked in checkOneSelector,
so that it can be considered as checked on querySelectorAll(':checked').

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests: :checked pseudo selector not matching selected option
https://bugs.webkit.org/show_bug.cgi?id=63192

Patch by Sameer Patil <mkrp87@motorola.com> on 2011-10-11
Reviewed by Kent Tamura.

  • fast/css/checked-pseudo-selector-expected.txt: Added.
  • fast/css/checked-pseudo-selector.html: Added.
20:29 Changeset [97223] by ryuan.choi@samsung.com

StorageAreaSync::sync needs a transaction for better performance.
https://bugs.webkit.org/show_bug.cgi?id=57694

Reviewed by Darin Adler.

For now, StorageAreaSync::sync execute SQLite operations for all items outside
a transaction.
However, SQLite operations outside a transaction are all atomic and thus
writes will block on I/O, which makes the process slow during heavy I/O.
This wrapped them with BEGIN TRANSACTION and END TRANSACTION for the better
performance.

No new tests required.
No functional changes if transaction doesn't fail.
And also, it is difficult to test the case of transaction fails.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::sync):

20:27 Changeset [97222] by ojan@chromium.org

margin-right is ignored with vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=69686

Reviewed by Darin Adler.

Source/WebCore:

We need to use the parent's writing mode when grabbing
the margin start/end for the purposes of computing the parent's
preferred widths.

Test: fast/writing-mode/margins.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/writing-mode/margins-expected.txt: Added.
  • fast/writing-mode/margins.html: Added.
20:00 Changeset [97221] by commit-queue@webkit.org

[WebSocket] update pywebsocket to 0.6b6.
https://bugs.webkit.org/show_bug.cgi?id=69824

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-10-11
Reviewed by Kent Tamura.

WebKit supports WebSocket with version 8 based protocol for now.
We should update its protocol to version 13 based one like hybi-17.
pywebsocket 0.6b6 supports both of version 8 and 13.

  • Scripts/webkitpy/thirdparty/init.py:
19:42 Changeset [97220] by commit-queue@webkit.org

Unreviewed, rolling out r97202, r97207, and r97215.
http://trac.webkit.org/changeset/97202
http://trac.webkit.org/changeset/97207
http://trac.webkit.org/changeset/97215
https://bugs.webkit.org/show_bug.cgi?id=69894

Broke builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-11

Source/WebCore:

  • platform/PopupMenuClient.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

  • rendering/RenderMenuList.h:
  • rendering/RenderObject.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::showPopup):

  • rendering/RenderTextControlSingleLine.h:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:
  • src/AutofillPopupMenuClient.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

  • tests/PopupMenuTest.cpp:

LayoutTests:

  • fast/dom/popup-menu-client-test-expected.txt: Removed.
  • fast/dom/popup-menu-client-test.html: Removed.
19:26 Changeset [97219] by mrobinson@webkit.org

[Soup] ResourceHandleSoup does not handle encodedBlobData
https://bugs.webkit.org/show_bug.cgi?id=52092

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add support for sending encoded blob data during requests.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::addFileToSoupMessageBody): Added this helper.
(WebCore::blobIsOutOfDate): Ditto.
(WebCore::addEncodedBlobItemToSoupMessageBody): Ditto.
(WebCore::addEncodedBlobToSoupMessageBody): Ditto.
(WebCore::addFormElementsToSoupMessage): No longer flatten form data, as we
cannot do this in the case where the form data contains blobs. Now handle
the blob case.
(WebCore::loadResourceSynchronously): Add blob support for synchronous loading.

LayoutTests:

  • platform/gtk/Skipped: Unskip tests which are now passing.
19:05 Changeset [97218] by fpizlo@apple.com

DFG does not have flow-sensitive intraprocedural control flow analysis
https://bugs.webkit.org/show_bug.cgi?id=69690

Reviewed by Gavin Barraclough.

Implemented a control flow analysis (CFA). It currently propagates type
proofs only. For example, if all predecessors to a basic block have
checks that variable X is a JSFinalObject with structure 0xabcdef, then
this basic block will now know this fact and will know that it does not
have to emit either JSFinalObject checks or any structure checks since
the structure is precisely known. The CFA takes heap side-effects into
account (though somewhat conservatively), so that if the object pointed
to by variable X could have possibly undergone a structure transition
then this is reflected: the analysis may simply say that X's structure
is unknown.

This also propagates a wealth of other type information which is
currently not being used. For example, we now know when a variable can
only hold doubles. Even if a variable may hold other types at different
points in its live range, we can still prove exactly when it will only
be double.

There's a bunch of stuff that the CFA could do that it still does not
do, like precise handling of PutStructure (i.e. structure transitions),
precise handling of CheckFunction and CheckMethod, etc. So this is
very much intended to be a starting point rather than an end unto
itself.

This is a 1% win on V8 (mostly due to a 3% win on richards and deltablue)
and a 1% win on Kraken (mostly due to a 6% win on imaging-desaturate).
Neutral on SunSpider.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/ActionablePrediction.h: Removed.
  • bytecode/PredictedType.cpp:

(JSC::predictionToString):

  • bytecode/PredictedType.h:
  • dfg/DFGAbstractState.cpp: Added.

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::~AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h: Added.

(JSC::DFG::AbstractState::forNode):
(JSC::DFG::AbstractState::isValid):

  • dfg/DFGAbstractValue.h: Added.

(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::addAll):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::last):
(JSC::DFG::StructureAbstractValue::predictionFromStructures):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::top):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGBasicBlock.h: Added.

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::setupPredecessors):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::block):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGNode.h:

(JSC::DFG::NodeIndexTraits::defaultValue):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::takenBytecodeOffsetDuringParsing):
(JSC::DFG::Node::notTakenBytecodeOffsetDuringParsing):
(JSC::DFG::Node::setTakenBlockIndex):
(JSC::DFG::Node::setNotTakenBlockIndex):
(JSC::DFG::Node::takenBlockIndex):
(JSC::DFG::Node::notTakenBlockIndex):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGOperands.h: Added.

(JSC::DFG::operandIsArgument):
(JSC::DFG::OperandValueTraits::defaultValue):
(JSC::DFG::Operands::Operands):
(JSC::DFG::Operands::numberOfArguments):
(JSC::DFG::Operands::numberOfLocals):
(JSC::DFG::Operands::argument):
(JSC::DFG::Operands::local):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::setArgumentFirstTime):
(JSC::DFG::Operands::setLocalFirstTime):
(JSC::DFG::Operands::operand):
(JSC::DFG::Operands::setOperand):
(JSC::DFG::Operands::clear):
(JSC::DFG::dumpOperands):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictions):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
(JSC::DFG::Propagator::globalCFA):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureSet.h:

(JSC::DFG::StructureSet::clear):
(JSC::DFG::StructureSet::predictionFromStructures):
(JSC::DFG::StructureSet::operator==):
(JSC::DFG::StructureSet::dump):

  • dfg/DFGVariableAccessData.h: Added.
19:04 Changeset [97217] by crogers@google.com

Merge 97214 - Heap buffer overflow in Webaudio FFTFrame::doFFT

BUG=99211
Review URL: http://codereview.chromium.org/8231033

18:53 Changeset [97216] by barraclough@apple.com

DFG JIT 32_64 - Fix silentFillGPR for non-integer constants.
https://bugs.webkit.org/show_bug.cgi?id=69890

Reviewed by Oliver Hunt.

Cell constants are currently hitting the valueOfInt32Constant case, there is no constant handling for JSValues.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

18:53 Changeset [97215] by rniwa@webkit.org

Second attempt to fix Chromium Windows build after r97202.

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::boundingBoxRect):
(WebKit::TestPopupMenuClient::setFocusedNode):

18:48 Changeset [97214] by crogers@google.com

Heap buffer overflow in Webaudio FFTFrame::doFFT
https://bugs.webkit.org/show_bug.cgi?id=69447

Reviewed by Kenneth Russell.

No new tests. This only changes internal implementation details.

  • platform/audio/HRTFKernel.cpp:

(WebCore::extractAverageGroupDelay):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::fftSizeForSampleRate):

18:40 Changeset [97213] by rniwa@webkit.org

Second Qt minimum release build fix attempt after r97163.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

18:38 Changeset [97212] by simon.fraser@apple.com

WebKitTestRunner needs to link with WebKit for NSURL category methods
https://bugs.webkit.org/show_bug.cgi?id=69892

Reviewed by Sam Weinig.

WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
the +_web_originalDataAsString selector on NSURL was not recognized. Link with
WebKit.framework to fix this.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
18:37 Changeset [97211] by rniwa@webkit.org

GTK build fix attempt after r97197.

  • wtf/BitVector.h:
18:27 Changeset [97210] by rniwa@webkit.org

Qt minimum release build fix attempt after r97163.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

18:18 Changeset [97209] by rniwa@webkit.org

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
18:16 Changeset [97208] by oliver@apple.com

Clang build broken
https://bugs.webkit.org/show_bug.cgi?id=69891

Reviewed by Darin Adler.

Rename CachedResourceClient::type to CachedResourceClient::resourceClientType
to avoid conflict in CSSImportRule.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::didAddClient):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::didAddClient):

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didAddClient):

  • loader/cache/CachedImage.h:

(WebCore::CachedImageClient::resourceClientType):

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::next):

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::didAddClient):

18:12 Changeset [97207] by rniwa@webkit.org

Chromium build fix attempt after r97202.

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::boundingBoxRect):

18:11 Changeset [97206] by oliver@apple.com

Remove unintentional logging.

18:07 Changeset [97205] by rniwa@webkit.org

Dir attribute is converted into direction property when merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=69680

Reviewed by Enrica Casucci.

Source/WebCore:

Don't include direction and unicode-bidi properties in the wrapping style.

Tests: editing/deleting/merge-paragraph-into-h1-with-dir-2.html

editing/deleting/merge-paragraph-into-h1-with-dir.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Skip unicode-bidi and direction properties.
(WebCore::EditingStyle::wrappingStyleForSerialization): Extracted from StyledMarkupAccumulator::serializeNodes.

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes): Calls wrappingStyleForSerialization.

LayoutTests:

Added tests to merge paragraphs inside a block with dir attribute. WebKit should not add
direction or unicode-bidi properties.

  • editing/deleting/merge-paragraph-into-h1-with-dir-2-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-dir-2.html: Added.
  • editing/deleting/merge-paragraph-into-h1-with-dir-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-dir.html: Added.
17:41 Changeset [97204] by thakis@chromium.org

[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
https://bugs.webkit.org/show_bug.cgi?id=69589

Reviewed by Dirk Pranke.

When building with make -j40, all the binding rules are built en bloc. Since this script currently
uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
255 by default, so the build used to fail with
"open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.

  • WebCore.gyp/scripts/rule_binding.py:
17:24 Changeset [97203] by oliver@apple.com

Tidy up card walking logic
https://bugs.webkit.org/show_bug.cgi?id=69883

Reviewed by Gavin Barraclough.

Special case common cell sizes when walking a block's
cards.

  • heap/CardSet.h:

(JSC::::testAndClear):

  • heap/Heap.cpp:

(JSC::GCTimer::GCCounter::GCCounter):
(JSC::GCTimer::GCCounter::count):
(JSC::GCTimer::GCCounter::~GCCounter):
(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStack::reset):

  • heap/MarkStack.h:

(JSC::MarkStack::visitCount):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::append):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::gatherDirtyCellsWithSize):
(JSC::MarkedBlock::gatherDirtyCells):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

17:19 Changeset [97202] by fsamuel@chromium.org

Towards making PopupMenuClient more testable
https://bugs.webkit.org/show_bug.cgi?id=69631

Reviewed by Simon Fraser.

Source/WebCore:

Added some functions to window.internals to allow testing of parts of PopupMenuClient.

Test: fast/dom/popup-menu-client-test.html

  • platform/PopupMenuClient.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::boundingBoxRect):

  • rendering/RenderMenuList.h:

(WebCore::RenderMenuList::RenderMenuList::isPopupMenuClient):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isPopupMenuClient):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::boundingBoxRect):

  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlSingleLine::isPopupMenuClient):

  • testing/Internals.cpp:

(WebCore::Internals::toPopupMenuClient):
(WebCore::Internals::popupClientPaddingLeft):
(WebCore::Internals::popupClientPaddingRight):
(WebCore::Internals::popupClientBoundingBoxRect):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::boundingBoxRect):

  • src/AutofillPopupMenuClient.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

LayoutTests:

  • fast/dom/popup-menu-client-test-expected.txt: Added.
  • fast/dom/popup-menu-client-test.html: Added.
17:17 Changeset [97201] by ap@apple.com

[Mac] Crash when opening an embedded PDF in a background tab
https://bugs.webkit.org/show_bug.cgi?id=69880

Reviewed by Darin Adler.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::BuiltInPDFView): (WebKit::BuiltInPDFView::~BuiltInPDFView): (WebKit::BuiltInPDFView::initialize): (WebKit::BuiltInPDFView::destroy): Moved initialization and destruction code from C++ constructor and destructor to designated functions. Not part of the fix, but seems related enough to fix.
17:16 Changeset [97200] by ap@apple.com

[Mac] Crash when opening an embedded PDF in a background tab
https://bugs.webkit.org/show_bug.cgi?id=69880

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Don't call plug-in that doesn't even have a controller yet.
17:12 Changeset [97199] by japhet@chromium.org

Make CachedResourceClientWalker templates, and
have it check and filter out bad casts when iterating
(currently we rely on CachedResourceClients being careful
to inherit from the right subclass for the type of resource
they want to load).
https://bugs.webkit.org/show_bug.cgi?id=69877

Reviewed by Adam Barth.

No new tests, no functionality change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceClient.h:
  • loader/cache/CachedResourceClientWalker.cpp: Removed.
  • loader/cache/CachedResourceClientWalker.h:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
16:50 Changeset [97198] by abarth@webkit.org

sheriffbot takes too long to acknowledge rollout commands
https://bugs.webkit.org/show_bug.cgi?id=69871

Reviewed by Eric Seidel.

We used to update the working copy before acknowledging the command
because we wanted to ping all the relevant IRC nicks. That's caused a
bunch of frustration because folks don't know whether the bot has heard
their commands.

This patch makes the bot reply immediately before updating the working
copy. All the relevenat folks are still pinged when the bot finishes
preparing the rollout.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
16:50 Changeset [97197] by fpizlo@apple.com

DFG virtual register allocator should be more aggressive in
reusing temporary slots
https://bugs.webkit.org/show_bug.cgi?id=69868

Reviewed by Oliver Hunt.

1.2% win on V8, neutral elsewhere. The win is probably because it
increases precision of GC conservative scans.

This required making the DFG::ScoreBoard operate over a bitvector
of preserved variables, rather than just a preserved variable
threshold. To do this, I improved the WTF::BitVector class to make
it more user-friendly. It still retains all previous functionality.
Also made changes to PackedIntVector to accomodate those changes.
Finally, this adds more debugging to the virtual register allocator
and to the OSR exit code, as this was necessary to track down bugs
in an earlier version of this patch.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getLocal):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::allocateVirtualRegisters):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::highWatermark):
(JSC::DFG::ScoreBoard::dump):
(JSC::DFG::ScoreBoard::max):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueRecovery::dump):

  • wtf/BitVector.cpp:

(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::dump):

  • wtf/BitVector.h:

(WTF::BitVector::BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):

  • wtf/PackedIntVector.h:

(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):

16:48 Changeset [97196] by abarth@webkit.org

test-webkitpy fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=69873

Reviewed by Eric Seidel.

This patch fixes one of the two failures. I'll need to track down the
other failure another time.

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
16:43 Changeset [97195] by wjmaclean@chromium.org

[chromium] Fix compilation guards in ScrollAnimatorNone (GESTURE_EVENTS).
https://bugs.webkit.org/show_bug.cgi?id=69853

Reviewed by Kenneth Russell.

Adding missing guards ENABLE(GESTURE_EVENTS) in ScrollAnimatorNone. So
far this hasn't been a problem since GESTURE_EVENTS are usually turned on
whenever SMOOTH_SCROLLING is, but it could be a problem if this changes.

No new tests (compilation without errors is the test).

  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollAnimatorNone.h:
16:34 Changeset [97194] by kbr@google.com

[chromium] Check for lost context at beginning of compositor's execution
https://bugs.webkit.org/show_bug.cgi?id=69776

Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/webgl-loses-compositor-context.html

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

LayoutTests:

Added test case which asserts when run in Chrome with dynamic GPU
switching enabled and without the fix in this patch.

  • platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium/compositing/webgl-loses-compositor-context-expected.txt: Added.
  • platform/chromium/compositing/webgl-loses-compositor-context.html: Added.
16:23 Changeset [97193] by dmazzoni@google.com

WebAccessibilityObject needs titleUIElement
https://bugs.webkit.org/show_bug.cgi?id=69869

Reviewed by Dimitri Glazkov.

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::titleUIElement):

16:15 Changeset [97192] by abarth@webkit.org

garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
https://bugs.webkit.org/show_bug.cgi?id=65230

Reviewed by Dimitri Glazkov.

This patch causes us to treat crashed or hung run-webkit-tests runs
similarly to how we treat compile failures. In some sense, they're
similar because they prevent us from getting test coverage.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
16:05 Changeset [97191] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=69874
WebKit2 snapshot APIs should take the device scale factor into account
-and corresponding-
<rdar://problem/10269112>

Reviewed by Darin Adler.

Add the deviceScaleFactor as a scale on the snapshot's context to create a
snapshot of the appropriate resolution. This matches the manner in which we scale
the context in DrawingAreaImpl::display().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

16:04 Changeset [97190] by abarth@webkit.org

Failing builder display in garden-o-matic should have the same visual style as the failure grid
https://bugs.webkit.org/show_bug.cgi?id=69876

Reviewed by Dimitri Glazkov.

This patch generalizes the view we use for failing builders in the
FailureGrid so that we can use it for the list of builders that aren't
compiling.

One downside of this patch is that it makes it harder to tell when
debug builders are failing (as opposed to release builders) because
that information isn't presented in this view. A future patch will
improve this aspect.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
15:51 Changeset [97189] by barraclough@apple.com

DFG JIT 32_64 - Switch to cdecl calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69863

Reviewed by Oliver Hunt.

This makes it easier to keep the stack correctly aligned, which is required on OS X.

  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • Provide default FunctionPtr constructors for CDECL functions on STDCALL platforms.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • Switch calls to poke arguments rather than pushing them.

(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
(JSC::DFG::addCallArgumentBoxed):

  • Helper functions to stack up call arguments on X86.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • Don't push, poke!
  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • Don't push, poke!
  • dfg/DFGOperations.cpp:
    • Switch ReturnAddress wrappers to push return address last, update asm trampolines.
  • dfg/DFGOperations.h:
    • switch DFG_OPERATION to assert CDECL on STDCALL platforms.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::fmodWithCDecl):
(JSC::DFG::SpeculativeJIT::compile):

  • On STDCALL platforms wrap fmod, since DFG_OPERATION wrappers are CDECL.
15:43 Changeset [97188] by wjmaclean@chromium.org

Loss of precision when converting from double to int and double to float in FrameView::zoomAnimatorTransformChanged()
https://bugs.webkit.org/show_bug.cgi?id=69739

Source/WebCore:

Reviewed by Simon Fraser.

Change 'double' parameters in FrameView:: & ScrollableArea::zoomAnimatorTransformChanged()
to 'float' to avoid loss of precision warnings when invoking setPageScalefactor.

Test coverage provided by existing zoom-animator tests.

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged):

  • page/FrameView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::zoomAnimatorTransformChanged):

  • platform/ScrollableArea.h:

Source/WebKit2:

Change 'double' parameters to 'float' to match changes in FrameView.

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

14:56 Changeset [97187] by fpizlo@apple.com

Some API tests are timing out in Release
https://bugs.webkit.org/show_bug.cgi?id=69787

Reviewed by Mark Rowe.

NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
magic to ensure that GTest builds in release mode in clang with NDEBUG set.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/config.h:
14:42 Changeset [97186] by noam.rosenthal@nokia.com

Unreviewed build fix, unbreaking the Qt minimal bot.
Some #ifdef ENABLED(TILED_BACKING_STORE) clauses were missing.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

14:24 Changeset [97185] by rniwa@webkit.org

Mac rebaseline after r96610.

  • platform/chromium/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Copied from

LayoutTests/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt.

  • platform/mac/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Copied from

LayoutTests/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt.

14:14 Changeset [97184] by ap@apple.com

[Mac] Small embedded PDFs are not fully repainted when scrolling
https://bugs.webkit.org/show_bug.cgi?id=69861

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent): Account for vertical centering when deciding which pages to paint.
14:12 Changeset [97183] by inferno@chromium.org

Merge 97180 - Source/WebCore: Generalize r95461 change to include table-cell and

allow splitting between :before, :after content.

BUG=99880
Review URL: http://codereview.chromium.org/8232016

14:10 Changeset [97182] by rniwa@webkit.org

Mac rebaseline after r96675.

  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
14:09 Changeset [97181] by inferno@chromium.org

Generalize r95461 change to include table-cell and
allow splitting between :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=69854

Reviewed by Eric Seidel.

  • fast/table/table-row-before-after-content-around-table-cell-expected.png: Added.
  • fast/table/table-row-before-after-content-around-table-cell-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-table-cell.html: Added.
14:05 Changeset [97180] by inferno@chromium.org

Source/WebCore: Generalize r95461 change to include table-cell and
allow splitting between :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=69854

Reviewed by Eric Seidel.

Test: fast/table/table-row-before-after-content-around-table-cell.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

LayoutTests: Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
https://bugs.webkit.org/show_bug.cgi?id=68624

Reviewed by Eric Seidel.

  • fast/lists/inline-before-content-after-list-marker-expected.png: Added.
  • fast/lists/inline-before-content-after-list-marker-expected.txt: Added.
  • fast/lists/inline-before-content-after-list-marker.html: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added.
  • fast/runin/runin-between-list-marker-and-before-content.html: Added.
  • fast/runin/runin-into-div-with-float-child-expected.png: Added.
  • fast/runin/runin-into-div-with-float-child-expected.txt: Added.
  • fast/runin/runin-into-div-with-float-child.html: Added.
  • fast/runin/runin-not-go-into-float-expected.png: Added.
  • fast/runin/runin-not-go-into-float-expected.txt: Added.
  • fast/runin/runin-not-go-into-float.html: Added.
14:02 Changeset [97179] by rniwa@webkit.org

Mac rebaseline after r96958.

  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/test_expectations.txt:
13:58 Changeset [97178] by rniwa@webkit.org

Move test expectations added by r96987 to Chromium Linux directory,
and add the baseline for Mac port.

  • fast/css/text-transform-select-expected.txt: Removed.
  • platform/chromium-linux/fast/css/text-transform-select-expected.txt: Copied from

LayoutTests/fast/css/text-transform-select-expected.txt.

  • platform/mac/fast/css/text-transform-select-expected.png: Added.
  • platform/mac/fast/css/text-transform-select-expected.txt: Added.
13:46 Changeset [97177] by dmazzoni@google.com

AccessibilityMenuList should fire change notification when popup is not open.
https://bugs.webkit.org/show_bug.cgi?id=69440

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/menu-list-sends-change-notification.html

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

LayoutTests:

  • accessibility/menu-list-sends-change-notification.html: Added.
  • platform/chromium/accessibility/menu-list-sends-change-notification-expected.txt: Added.
13:44 Changeset [97176] by abarth@webkit.org

garden-o-matic links to flakiness dashboard should open in a new tab
https://bugs.webkit.org/show_bug.cgi?id=69864

Reviewed by Dimitri Glazkov.

This bug was obvious in the first five minutes of using this new
feature. :)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
13:44 Changeset [97175] by dglazkov@chromium.org

[Chromium] Suddenly, things are crashing sporadically.

  • platform/chromium/test_expectations.txt: Document the crashes.
13:37 Changeset [97174] by abarth@webkit.org

Tweak the Content-Security-Policy for garden-o-matic. It turns out
that * doesn't really mean "all". I've emailed the W3C working group
about changing the spec.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
13:36 Changeset [97173] by dglazkov@chromium.org

[Chromium] fast/js/regexp-overflow.html is slow everywhere.

  • platform/chromium/test_expectations.txt: Widened platform specifiers.
13:34 Changeset [97172] by abarth@webkit.org

garden-o-matic should link to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=69862

Reviewed by Dimitri Glazkov.

The flakiness dashboard has lots of great information about the failure
history of each test. This patch adds a link from garden-o-matic to
the flakiness dashboard so the gardener can look at this information.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
13:21 Changeset [97171] by levin@chromium.org

watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
https://bugs.webkit.org/show_bug.cgi?id=69789

Reviewed by Eric Seidel.

Made the signature of _assertRaisesRegexp match that of Python 2.7.

  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
  • Scripts/webkitpy/common/webkitunittest.py: Ditto.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
12:56 Changeset [97170] by dglazkov@chromium.org

[Chromium] Mark more flakes as flakes.

  • platform/chromium/test_expectations.txt: Marked flakes.
12:37 Changeset [97169] by commit-queue@webkit.org

[EFL] DRT: Do not abort() when an unknown key is pressed.
https://bugs.webkit.org/show_bug.cgi?id=69856

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

A lot of tests crash due to the previous behaviour. Just using the
received name of the pressed key works most of the time, and when it
does not the failing tests should tell us.

  • DumpRenderTree/efl/EventSender.cpp:

(keyPadNameFromJSValue):
(keyNameFromJSValue):
(keyDownCallback):

12:22 Changeset [97168] by commit-queue@webkit.org

IndexedDB: implement IDBFactory.cmp method
https://bugs.webkit.org/show_bug.cgi?id=62293

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-11
Reviewed by Tony Chang.

Source/WebCore:

  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBKey.cpp:

(WebCore::IDBKey::compare):
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):

  • storage/IDBKey.h:

LayoutTests:

Check for IDBFactory.deleteDatabase (NYI) marked as FAIL. crbug.com/72002
Tests for array keys (NYI) marked as FAIL. crbug.com/99876
Tests for invalid key exception types marked as FAIL. crbug.com/98930

  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/factory-basics.html:
12:01 Changeset [97167] by ap@apple.com

Embedding of PDF's with <object> or <embed> fails when there is no MIME type specified
https://bugs.webkit.org/show_bug.cgi?id=64934

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Check URL extension, too, like GetPluginPath does in UI process. One difference is that UI process additionally tries platform specific extension to MIME type mapping, but that doesn't matter for PDF, which does not have other standard extensions.
11:39 Changeset [97166] by dglazkov@chromium.org

[Chromium] Unbarf Win testers after ambiguous expectations were added in r97149.

  • platform/chromium/test_expectations.txt: Made expectation more specific.
11:35 Changeset [97165] by noam.rosenthal@nokia.com

[Texmap] TextureMapperGL leaves GL in a modified state.
https://bugs.webkit.org/show_bug.cgi?id=68983

Reviewed by Andreas Kling.

Disable the vertexAttribArray after clipping.

No new functionality so no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginClip):

11:07 Changeset [97164] by dmazzoni@google.com

[Chromium] Fix expectations for two accessibility tests.
https://bugs.webkit.org/show_bug.cgi?id=69827

These tests were never run on Chromium before, so they're not new
failures. aria-roles had different expectations on different Mac
platforms, but on Chromium the results will always be the same, so
added Chromium-specific expectations. image-map-update-parent is
timing out, the cause here is unclear but it was never running before
so there's no new bug.

Unreviewed.

  • platform/chromium/accessibility/aria-roles-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:43 Changeset [97163] by noam.rosenthal@nokia.com

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Kenneth Rohde Christiansen.

Enable "externally managed" tiles in TextureMapperNodes.
Currently, TextureMapperNodes manage tiles themselves, the tiles being there only to
overcome the 2k texture size limitation. For WebKit2, we want those tiles to be managed
externally, namely through the web process via the remote tile backend for
TiledBackingStore.

This patch adds a store for those externally managed tiles, and adds the necessary code to
paint them instead of the owned tiles when appropriate.

In addition, in order to support externally managed remote tiles, we have to calculate per-
layer visible rects and pass them to the web process. The new collectVisibleContentRects
does this - and is directly tied to the externally-managed tile approach.

Code is disabled for now, but covered by existing compositing tests.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::clampRect):
(WebCore::TextureMapperNode::collectVisibleContentRects):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::targetRectForTileRect):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::createContentsTile):
(WebCore::TextureMapperNode::removeContentsTile):
(WebCore::TextureMapperNode::setTileBackBufferTextureForDirectlyCompositedImage):
(WebCore::TextureMapperNode::clearAllDirectlyCompositedImageTiles):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
(WebCore::TextureMapperNode::swapContentsBuffers):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::size):
(WebCore::TextureMapperNode::setTileOwnership):
(WebCore::TextureMapperNode::setID):
(WebCore::TextureMapperNode::id):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::ExternallyManagedTile::ExternallyManagedTile):
(WebCore::TextureMapperNode::State::State):

10:41 Changeset [97162] by dglazkov@chromium.org

[Chromium] Gardening flakey test expectations.

  • platform/chromium/test_expectations.txt: Updated for recent flakes.
10:16 Changeset [97161] by commit-queue@webkit.org

[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
https://bugs.webkit.org/show_bug.cgi?id=69749

Patch by Claudio Saavedra <csaavedra@igalia.com> on 2011-10-11
Reviewed by Martin Robinson.

  • platform/gtk/GtkAuthenticationDialog.cpp:

(WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
Ditto.

10:03 Changeset [97160] by ap@apple.com

Build fix.

  • WebCore.exp.in: Export GraphicsContext::clearShadow().
09:57 Changeset [97159] by adamk@chromium.org

[MutationObservers] Add stub implementation of WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=68949

Reviewed by Ryosuke Niwa, Oliver Hunt, and Dimitri Glazkov.

Source/WebCore:

See https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug.

This patch adds a stub WebKitMutationObserver and its supporting classes
MutationCallback and MutationObserverOptions.
No implementation is provided for the all-important observe() and
disconnect() methods.

Note that WebKitMutationObserver is vendor-prefixed since it has a
constructor exposed on DOMWindow. None of the rest of the API needs
prefixing, as it's only available via a call through a MutationObserver
callback (created by instantiating WebKitMutationObserver).

Given the number of files required to get just the stub up and running,
it seems reasonable to leave the actual implementation for the next
patch (or more likely several patches). I've left FIXMEs in all the places
that'll need augmentation.

Tests: fast/mutation/mutation-observer-constructor.html

fast/mutation/observe-exceptions.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetProperty):

  • bindings/js/JSMutationCallbackCustom.cpp: Added.

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSWebKitMutationObserverCustom.cpp: Added.

(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.

(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: Added.

(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/MutationCallback.h: Added.

(WebCore::MutationCallback::~MutationCallback):

  • dom/MutationCallback.idl: Added.
  • dom/MutationObserverOptions.h: Added.

(WebCore::MutationObserverOptions::create):
(WebCore::MutationObserverOptions::childList):
(WebCore::MutationObserverOptions::setChildList):
(WebCore::MutationObserverOptions::attributes):
(WebCore::MutationObserverOptions::setAttributes):
(WebCore::MutationObserverOptions::characterData):
(WebCore::MutationObserverOptions::setCharacterData):
(WebCore::MutationObserverOptions::subtree):
(WebCore::MutationObserverOptions::setSubtree):
(WebCore::MutationObserverOptions::attributeOldValue):
(WebCore::MutationObserverOptions::setAttributeOldValue):
(WebCore::MutationObserverOptions::characterDataOldValue):
(WebCore::MutationObserverOptions::setCharacterDataOldValue):
(WebCore::MutationObserverOptions::MutationObserverOptions):

  • dom/WebKitMutationObserver.cpp: Added.

(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):

  • dom/WebKitMutationObserver.h: Added.
  • dom/WebKitMutationObserver.idl: Added.
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi: Added 'enable_mutation_observers' variable.

LayoutTests:

Add basic tests and skip them in all ports for now.

  • fast/mutation/mutation-observer-constructor-expected.txt: Added.
  • fast/mutation/mutation-observer-constructor.html: Added.
  • fast/mutation/observe-exceptions-expected.txt: Added.
  • fast/mutation/observe-exceptions.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:53 Changeset [97158] by commit-queue@webkit.org

[Qt] [WK2] NRWT failed to launch MiniBrowser after test run
https://bugs.webkit.org/show_bug.cgi?id=68016

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-11
Reviewed by Chang Shu.

  • Scripts/webkitpy/layout_tests/port/qt.py:
09:48 Changeset [97157] by commit-queue@webkit.org

Need more efficient ways to set inline CSS styles
https://bugs.webkit.org/show_bug.cgi?id=58157

Patch by Arun Patole <BMF834@motorola.com> on 2011-10-11
Reviewed by Dimitri Glazkov.

No new tests added as this is just a code optimization.

Code optimization:

-Used CSSPropertyNames, CSSValues and CSSPrimitiveValues instead of Strings.
-Removed displayString(), webkitTransitionString(), opacityString() functions as they will no longer be needed after this change.
-Moved makeOpaque and makeTransparent functionality to MediaControlPanelElement from MediaControlRootElement.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::makeOpaque):
(WebCore::MediaControlRootElement::makeTransparent):

  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::makeOpaque):
(WebCore::MediaControlRootElementChromium::makeTransparent):

09:43 Changeset [97156] by dglazkov@chromium.org

Created component model branch.

09:41 Changeset [97155] by ap@apple.com

[Mac] Should be able to display multi-page PDFs in subframes
https://bugs.webkit.org/show_bug.cgi?id=69804

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::updateScrollbars): Page step should be exactly one page, so that one could step over the document page by page. It certainly shouldn't be a portion of the whole document. (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Moved duplicated code from load callbacks here. (WebKit::BuiltInPDFView::calculateSizes): Calculate document size including gutters, and remember page boxes. (WebKit::BuiltInPDFView::paint): Split into separate functions. (WebKit::BuiltInPDFView::paintBackground): Just paint gray background for the whole dirty rect. (WebKit::BuiltInPDFView::paintContent): Paint pages and shadow under them. This code is still fairly naive, as it doesn't understand annotations or page rotation. Constants for shadows roughly match PDFView, but not quite, since it draws entirely custom shadows. (WebKit::BuiltInPDFView::paintControls): Moved scrollbar and scroll corner painting here. (WebKit::BuiltInPDFView::streamDidFinishLoading): Moved common code into pdfDocumentDidLoad(). (WebKit::BuiltInPDFView::manualStreamDidFinishLoading): Ditto.
09:13 Changeset [97154] by commit-queue@webkit.org

[Qt] WebProcess using proxy settings for localhost as well
https://bugs.webkit.org/show_bug.cgi?id=69611

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-10-11
Reviewed by Chang Shu.

Implemented checks in queryProxy to return QNetworkProxy::NoProxy for localhost and 127.0.0.1

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::EnvHttpProxyFactory::queryProxy):

09:02 Changeset [97153] by commit-queue@webkit.org

Switch RegisterSizedBoolean/dfgConvertJSValueToInt32 return type to size_t
https://bugs.webkit.org/show_bug.cgi?id=69821

Patch by Gavin Barraclough <baraclough@apple.com> on 2011-10-11
Reviewed by Filip Pizlo.

Operations returning types Z (int32_t) and B (RegisterSizedBoolean - implemented as an
intptr_t) are indistinguishable on 32-bit Linux, preventing the DFG JIT from building.

dfgConvertJSValueToInt32 would be better returning a value known to be register sized, for
JSVALUE64 (we currently zero-extend in JIT code, potentially introducing an unnecessary
move), so by switching all associated operations to return a size_t we can fix the type
problem on Linux & make it a small tweak that removes an unnecessary instruction.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • comparisons now return a size_t.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • Removed Z_DFGOperation_EJ form.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

  • comparisons now return a size_t.
  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

  • comparisons now return a size_t.
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Change return types for comparison operations & dfgConvertJSValueToInt32 to size_t, Both need to return values zero extended to fill a register.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):

  • comparisons now return a size_t.
  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compare):

  • comparisons now return a size_t.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compare):

  • comparisons now return a size_t.
07:43 Changeset [97152] by pfeldman@chromium.org

Web Inspector: make Extensions component compile.
https://bugs.webkit.org/show_bug.cgi?id=69833

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/BinarySearch.js:
  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.Network.prototype.addRequestHeaders):
(injectedExtensionAPI.AuditResultImpl.prototype.addResult):
(injectedExtensionAPI.AuditResultNode.prototype.addChild):

  • inspector/front-end/ExtensionAuditCategory.js:
  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane.prototype.setExpression):

  • inspector/front-end/ExtensionRegistryStub.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._postNotification):
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype._registerExtension):
(WebInspector.ExtensionStatus):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/Object.js:

(WebInspector.Object.prototype.dispatchEventToListeners):

  • inspector/front-end/externs.js:

(console.warn):
(console.assert):
(console.error):
():
(AuditResult):
(EventSink):
(ExtensionSidebarPane):
(Panel):
(PanelWithSidebar):
(Request):
(Resource):
(Timeline):

07:04 Changeset [97151] by podivilov@chromium.org

Web Inspector: implement CompilerSourceMappingProvider.
https://bugs.webkit.org/show_bug.cgi?id=69423

Reviewed by Pavel Feldman.

Source/WebCore:

CompilerSourceMappingProvider implements a cross-domain communication channel for loading source mappings and source files.
Front-end page can't send XHRs to source mapping server directly due to SOP restrictions. Instead, we inject an invisible
iframe that is loaded from source mapping server and use window.postMessage to communicate with it. iframe has a different
origin and thus doesn't have access to front-end window.

Test: http/tests/inspector/compiler-source-mapping-provider.html

  • inspector/front-end/CompilerSourceMappingProvider.js:

(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded.didLoadData):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
(WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
(WebInspector.CompilerSourceMappingProvider.prototype._onMessage):
(WebInspector.CompilerSourceMappingProvider.prototype._cancelRequest):

  • inspector/front-end/inspector.js:

(WebInspector.installSourceMappingForTest):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-provider-expected.txt: Added.
  • http/tests/inspector/compiler-source-mapping-provider.html: Added.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app-map: Added.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Added.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app.js: Added.

(window.onload):
(handleClick):

  • http/tests/inspector/resources/compiler-source-mapping-provider/foo.js: Added.

(ClickHandler):
(ClickHandler.prototype.handle):

06:30 Changeset [97150] by commit-queue@webkit.org

[EFL] DRT: Return the right window count in LayoutTestController.
https://bugs.webkit.org/show_bug.cgi?id=69764

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

Follow-up to r96943: now that we have DumpRenderTreeChrome and
DumpRenderTreeView in the tree, we can correctly count the number of
open windows in DRT.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::windowCount):

06:11 Changeset [97149] by reed@google.com

re-add support for GDI text behind a compile flag
https://bugs.webkit.org/show_bug.cgi?id=69530

Reviewed by James Robinson.

Source/WebCore:

Reverts back to using GDI for text (when possible)
but keeps skia-text version behind a compile-flag. If/when we can
resolve the outstanding soft-clip and intl-performance bugs with the
skia version, we may change the compile-flag to reenable skia.

Previous change http://trac.webkit.org/changeset/94589 removed the GDI code.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt:
05:54 Changeset [97148] by ossy@webkit.org

REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=69800

Patch by Jer Noble <jer.noble@apple.com> on 2011-10-11
Reviewed by Csaba Osztrogonác.

Tools:

Enable WEB_AUDIO at runtime.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

Rebaseline after r96774.

  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
05:52 clutter edited by tomeu.vizoso@collabora.com
(diff)
05:47 Changeset [97147] by commit-queue@webkit.org

[EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
https://bugs.webkit.org/show_bug.cgi?id=69769

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setIconDatabaseEnabled):

05:36 clutter edited by tomeu.vizoso@collabora.com
(diff)
05:20 Changeset [97146] by mario@webkit.org

[Gtk] Update test expectation after r96712.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

  • platform/gtk/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/gtk/svg/clip-path/clip-path-transform-1-expected.txt: Added.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.txt: Added.
04:51 Changeset [97145] by podivilov@chromium.org

2011-10-11 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, roll chromium revision to pick HTML speech input images update.

  • DEPS:
04:34 Changeset [97144] by mario@webkit.org

[Gtk] Skip test crashing due to bug 60931.
https://bugs.webkit.org/show_bug.cgi?id=60931

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

  • platform/gtk/Skipped: Skipped

http/tests/security/cookies/cookie-theft-with-javascript-doc.html

04:32 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
04:12 Changeset [97143] by ossy@webkit.org

[Qt] Support multipart responses is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=47060

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
    • Skip multipart tests.
    • Unskip http/tests/misc/timer-vs-loading.htm, because it isn't multipart test and it passes.
04:07 Changeset [97142] by mario@webkit.org

[Gtk] Update test expectation after r96970.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
03:49 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:40 Changeset [97141] by mario@webkit.org

[Gtk] Update test expectation after r97103.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.png: Added.
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt: Added.
03:35 Changeset [97140] by podivilov@chromium.org

2011-10-11 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark two accessibility tests as failing on chromium.

  • platform/chromium/test_expectations.txt:
03:30 Changeset [97139] by vestbo@webkit.org

[Qt] Remove all references to QTDIR_build and standalone_package

Qt is now modularized, which means we no longer import WebKit into
the Qt source tree. Instead we use git submodules, and building
QtWebKit as "part of Qt" is really building QtWebKit as from trunk.

To decrease the number of buildsystem configurations we also remove
the standalone_package code-path used when we were providing tarballs
with the derived sources pre-generated.

Reviewed by Simon Hausmann.

03:15 Changeset [97138] by podivilov@chromium.org

2011-10-11 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline test expectations after r104864 (chromium).

  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-cg-mac/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
  • platform/chromium-cg-mac/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
  • platform/chromium-cg-mac/fast/speech/input-appearance-speechbutton-expected.png: Removed.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png: Removed.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-numberandspeech-expected.txt.
  • platform/chromium/fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-searchandspeech-expected.txt.
  • platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-speechbutton-expected.txt.
02:31 Changeset [97137] by andreas.kling@nokia.com

Shrink WebCore::Node on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69768

Reviewed by Antti Koivisto.

Rearrange TreeShared and Node members so that the node flags fall
into the padding at the end of TreeShared on 64-bit, reducing the
size of Node (and all subclasses) by 8 bytes.

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.h:
  • platform/TreeShared.h:

(WebCore::TreeShared::TreeShared):

02:30 Changeset [97136] by mario@webkit.org

[Gtk] Update test expectations after r96987, r97088 and r97114.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

  • platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
  • platform/gtk/fast/css/text-transform-select-expected.png: Added.
  • platform/gtk/fast/css/text-transform-select-expected.txt: Added.
  • platform/gtk/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-render-inline-expected.txt: Added.
  • platform/gtk/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/gtk/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
01:45 Changeset [97135] by tkent@chromium.org

Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69812

Reviewed by Ryosuke Niwa.

Move SelectElementData::m_recalcListItems,
SelectElementData::m_listItems, and related functions of
SelectElementData class to HTMLSelectElement.

Non-const listItems() was removed because it is used only in
recalcListItemsInternal() and it can access m_listItems diretly.

Static recalcListItems() is changed to non-static, and renamed to
recalcListItemsInternal() in order to avoid confusion with the
existing recalcListItems().

No new tests, just a refactoring.

  • dom/SelectElement.cpp:

Move checkListItems() and listItems() to HTMLSelectElement.
(WebCore::SelectElementData::SelectElementData):
Remove Initialization of m_recalcListItems.

  • dom/SelectElement.h:

Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes m_recalcListItems.
(WebCore::HTMLSelectElement::recalcListItems):
Rename the static recalcListItems() to recalcListItemsInternal().
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::checkListItems):
Moved from SelectElementData.
(WebCore::HTMLSelectElement::listItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::recalcListItemsInternal):

  • Make this non-static.
  • Renamed from recalcListItems() to avoid confilct with another recalcListItems().
  • Use m_recalcListItems and m_listItems directly.

(WebCore::HTMLSelectElement::selectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
(WebCore::HTMLSelectElement::saveFormControlState):
Update callsites of listItems() and recalcListItems().
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree):
Update a recalcListItems() callsite.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::length): ditto.

  • html/HTMLSelectElement.h:

Move m_recalcListItems, m_listItems, and related functions from SelectElementData.

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
Update a listItems() callsite.

01:44 Changeset [97134] by dmazzoni@google.com

Update Chromium text_expectations to skip mac- and win-specific accessibility
tests. Unreviewed.

01:38 Changeset [97133] by bashi@chromium.org

[Chromium] Complex script code path breaks on Windows XP when a CFF font is used
https://bugs.webkit.org/show_bug.cgi?id=69497

Reviewed by Kent Tamura.

Don't use CFF webfonts when ScriptShape() can't handle it.
ScriptShape() indicates us the case by setting fNoGlyphIndex to TRUE.
If it's TRUE, we don't use the font. This could happen with early
version of Uniscribe on WinXP.

No new tests because the version of Uniscribe depends on environment.
One can install newer version of Uniscribe on WinXP.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::canUseGlyphIndex): Added.
(WebCore::UniscribeHelper::shape): Don't use the shape result when canUseGlyphIndex() returns false.

01:28 Changeset [97132] by commit-queue@webkit.org

Fix crash with toDataURL to JPEG
https://bugs.webkit.org/show_bug.cgi?id=69681

Patch by John Bauman <jbauman@chromium.org> on 2011-10-11
Reviewed by Kenneth Russell.

Move RefPtr declaration outside if to make sure image data still
exists through CGImageToDataURL.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL):

00:54 Changeset [97131] by commit-queue@webkit.org

Expose WebLayer::isNull
https://bugs.webkit.org/show_bug.cgi?id=69813

Patch by Antoine Labour <piman@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

  • public/WebLayer.h:

(WebKit::WebLayer::isNull):

00:50 Changeset [97130] by reni@webkit.org

[Qt] Update test expectation after r97109.

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-11

  • platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
00:40 Changeset [97129] by commit-queue@webkit.org

Add missing copyright notice in DFG JIT files
https://bugs.webkit.org/show_bug.cgi?id=69809

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-11
Reviewed by Gavin Barraclough.

  • dfg/DFGJITCodeGenerator32_64.cpp:
  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGJITCompilerInlineMethods.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:
00:28 Changeset [97128] by dmazzoni@google.com

Tools: Update Chromium accessibility support in DRT.
https://bugs.webkit.org/show_bug.cgi?id=69676

Reviewed by Chris Fleizach.

Adds several missing properties and methods to enable more
tests to pass, and in particular adds support for notification
callbacks.

  • DumpRenderTree/chromium/AccessibilityController.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::reset):
(AccessibilityController::getFocusedElement):
(AccessibilityController::shouldLogAccessibilityEvents):
(AccessibilityController::notificationReceived):
(AccessibilityController::logAccessibilityEventsCallback):

  • DumpRenderTree/chromium/AccessibilityController.h:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(getHelpText):
(getStringValue):
(getOrientation):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::isEqual):
(AccessibilityUIElement::notificationReceived):
(AccessibilityUIElement::roleGetterCallback):
(AccessibilityUIElement::titleGetterCallback):
(AccessibilityUIElement::descriptionGetterCallback):
(AccessibilityUIElement::helpTextGetterCallback):
(AccessibilityUIElement::stringValueGetterCallback):
(AccessibilityUIElement::xGetterCallback):
(AccessibilityUIElement::yGetterCallback):
(AccessibilityUIElement::widthGetterCallback):
(AccessibilityUIElement::heightGetterCallback):
(AccessibilityUIElement::intValueGetterCallback):
(AccessibilityUIElement::minValueGetterCallback):
(AccessibilityUIElement::maxValueGetterCallback):
(AccessibilityUIElement::childrenCountGetterCallback):
(AccessibilityUIElement::insertionPointLineNumberGetterCallback):
(AccessibilityUIElement::selectedTextRangeGetterCallback):
(AccessibilityUIElement::isEnabledGetterCallback):
(AccessibilityUIElement::isRequiredGetterCallback):
(AccessibilityUIElement::isFocusedGetterCallback):
(AccessibilityUIElement::isFocusableGetterCallback):
(AccessibilityUIElement::isSelectedGetterCallback):
(AccessibilityUIElement::isSelectableGetterCallback):
(AccessibilityUIElement::isMultiSelectableGetterCallback):
(AccessibilityUIElement::isExpandedGetterCallback):
(AccessibilityUIElement::isCheckedGetterCallback):
(AccessibilityUIElement::isVisibleGetterCallback):
(AccessibilityUIElement::isOffScreenGetterCallback):
(AccessibilityUIElement::isCollapsedGetterCallback):
(AccessibilityUIElement::hasPopupGetterCallback):
(AccessibilityUIElement::isValidGetterCallback):
(AccessibilityUIElement::orientationGetterCallback):
(AccessibilityUIElement::showMenuCallback):
(AccessibilityUIElement::pressCallback):
(AccessibilityUIElement::isEqualCallback):
(AccessibilityUIElement::addNotificationListenerCallback):
(AccessibilityUIElement::removeNotificationListenerCallback):
(AccessibilityUIElement::takeFocusCallback):
(AccessibilityUIElement::fallbackCallback):
(RootAccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElementList::getOrCreate):

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppVariant.cpp:

(CppVariant::invokeDefault):

  • DumpRenderTree/chromium/CppVariant.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

LayoutTests: Enable accessibility tests on chromium and update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=69676

Reviewed by Chris Fleizach.

  • platform/chromium/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
  • platform/chromium/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/chromium/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
  • platform/chromium/accessibility/platform-name-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
00:00 Changeset [97127] by abarth@webkit.org

Update test results.

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::existingWrapper):
(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::existingWrapper):
(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::existingWrapper):
(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::existingWrapper):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

10/10/11:

22:33 Changeset [97126] by simonjam@chromium.org

[Chromium] Fix expectations from r97120. (again)

Unreviewed.

  • platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
22:12 Changeset [97125] by inferno@chromium.org

Merge 97124 - Style not updated on text fragment in :first-letter nested in :before table.

BUG=99294
Review URL: http://codereview.chromium.org/8229001

22:08 Changeset [97124] by inferno@chromium.org

Style not updated on text fragment in :first-letter
nested in :before table.
https://bugs.webkit.org/show_bug.cgi?id=69540

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/css-generated-content/first-letter-in-nested-before-table.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

  • fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
  • fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
  • fast/css-generated-content/first-letter-in-nested-before-table.html: Added.
21:57 Changeset [97123] by tkent@chromium.org

Unreviewed, rolling out r97121.
http://trac.webkit.org/changeset/97121
https://bugs.webkit.org/show_bug.cgi?id=69815

Many layout tests failed (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

  • dom/SelectElement.cpp:

(WebCore::SelectElementData::SelectElementData):
(WebCore::SelectElementData::checkListItems):
(WebCore::SelectElementData::listItems):

  • dom/SelectElement.h:

(WebCore::SelectElementData::shouldRecalcListItems):
(WebCore::SelectElementData::setShouldRecalcListItems):
(WebCore::SelectElementData::rawListItems):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
(WebCore::HTMLSelectElement::nextSelectableListIndex):
(WebCore::HTMLSelectElement::previousSelectableListIndex):
(WebCore::HTMLSelectElement::firstSelectableListIndex):
(WebCore::HTMLSelectElement::lastSelectableListIndex):
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::insertedIntoTree):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):

  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::listItems):

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

21:55 Changeset [97122] by simonjam@chromium.org

[Chromium] Fix expectations from r97120.

Unreviewed.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt.
  • platform/chromium/editing/pasteboard/smart-paste-008-expected.txt:
21:16 Changeset [97121] by tkent@chromium.org

Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69812

Reviewed by Ryosuke Niwa.

Move SelectElementData::m_recalcListItems,
SelectElementData::m_listItems, and related functions of
SelectElementData class to HTMLSelectElement.

Non-const listItems() was removed because it is used only in
recalcListItemsInternal() and it can access m_listItems diretly.

Static recalcListItems() is changed to non-static, and renamed to
recalcListItemsInternal() in order to avoid confusion with the
existing recalcListItems().

No new tests, just a refactoring.

  • dom/SelectElement.cpp:

Move checkListItems() and listItems() to HTMLSelectElement.
(WebCore::SelectElementData::SelectElementData):
Remove Initialization of m_recalcListItems.

  • dom/SelectElement.h:

Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes m_recalcListItems.
(WebCore::HTMLSelectElement::recalcListItems):
Rename the static recalcListItems() to recalcListItemsInternal().
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::checkListItems):
Moved from SelectElementData.
(WebCore::HTMLSelectElement::listItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::recalcListItemsInternal):

  • Make this non-static.
  • Renamed from recalcListItems() to avoid confilct with another recalcListItems().
  • Use m_recalcListItems and m_listItems directly.

(WebCore::HTMLSelectElement::selectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
(WebCore::HTMLSelectElement::saveFormControlState):
Update callsites of listItems() and recalcListItems().
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree):
Update a recalcListItems() callsite.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::length): ditto.

  • html/HTMLSelectElement.h:

Move m_recalcListItems, m_listItems, and related functions from SelectElementData.

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
Update a listItems() callsite.

20:01 Changeset [97120] by simonjam@chromium.org

[Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests.

Unreviewed.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png.
  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:15 Changeset [97119] by rniwa@webkit.org

Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.

  • platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from

LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.

  • platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.
18:14 Changeset [97118] by fpizlo@apple.com

DFG JSVALUE64 spill/fill code should not box integers and doubles
https://bugs.webkit.org/show_bug.cgi?id=69782

Reviewed by Oliver Hunt.

Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat.
This required changing all of the places that spill registers (both silently
and not) and filling registers (both silently and on demand). It also required
changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile)
may have the wrong format for the old JIT (unboxed int or double).

This is a slight win on Kraken (0.25%) and neutral elsewhere.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::spill):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::spill):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::virtualRegister):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

18:01 Changeset [97117] by barraclough@apple.com

DFG JIT switch dfgConvert methods to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69806

Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

  • dfg/DFGOperations.h:
17:57 Changeset [97116] by inferno@chromium.org

Merge 97114 - <rdar://problem/10246137> Duplicate ::after content when both ::before and ::after are styled as table parts
BUG=99348
Review URL: http://codereview.chromium.org/8222024

17:49 Changeset [97115] by rniwa@webkit.org

Another Chromium rebaseline after r97102.

  • platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed.
  • platform/chromium-win/fast/events/ondragenter-expected.txt: Removed.
  • platform/chromium/fast/events/ondragenter-expected.txt: Copied from

LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt.

  • platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from

LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt.

  • platform/chromium/test_expectations.txt:
17:46 Changeset [97114] by mitz@apple.com

<rdar://problem/10246137> Duplicate ::after content when both ::before and ::after are styled as table parts

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/css-generated-content/table-parts-before-and-after.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Prevented table part childern after a ::before table from being merged
into it.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): Prevented children after a ::before table section from being merged
into it.

LayoutTests:

  • fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
  • fast/css-generated-content/table-parts-before-and-after.html: Added.
17:41 Changeset [97113] by japhet@chromium.org

Source/WebCore: Most of the functions in CachedResourceClient are specific
to a single type of CachedResource. Move these callbacks into
separate subclasses of CachedResourceClient, and leave only
the common callback (notifyFinished) in the base class.
https://bugs.webkit.org/show_bug.cgi?id=69790

Reviewed by Adam Barth.

No new tests, no functionality changed intended.

  • css/CSSFontFaceSource.h:
  • css/CSSImageValue.h:
  • css/CSSImportRule.h:
  • dom/ProcessingInstruction.cpp:
  • dom/ProcessingInstruction.h:
  • html/HTMLLinkElement.h:
  • html/ImageDocument.h:
  • loader/ImageLoader.h:
  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResourceClient.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/CachedXSLStyleSheet.h:
  • platform/chromium/ClipboardChromium.h:
  • platform/gtk/ClipboardGtk.h:
  • platform/mac/ClipboardMac.h:
  • platform/qt/ClipboardQt.h:
  • platform/win/ClipboardWin.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:
  • xml/XSLImportRule.h:

Source/WebKit/mac: Use a CachedImageClient instead of CachedResourceClient
in WebHTMLView.
https://bugs.webkit.org/show_bug.cgi?id=69790

Reviewed by Adam Barth.

  • WebView/WebHTMLView.mm:

(promisedDataClient):

Source/WebKit2: Use a CachedImageClient instead of CachedResourceClient
in WebDragClientMac.
https://bugs.webkit.org/show_bug.cgi?id=69790

Reviewed by Adam Barth.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(promisedDataClient):

17:35 Changeset [97112] by rniwa@webkit.org

Chromium rebaseline after r97102.

  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/chromium-win/fast/events/ondragenter-expected.txt:
17:29 Changeset [97111] by rniwa@webkit.org

Fix a typo pointed by Sam (Weinig).

  • coding/coding-style.html:
17:18 Changeset [97110] by commit-queue@webkit.org

Unreviewed, rolling out r97087.
http://trac.webkit.org/changeset/97087
https://bugs.webkit.org/show_bug.cgi?id=69805

failing assert on debug builds (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

Source/WebCore:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):

  • loader/DocumentWriter.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

LayoutTests:

  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Removed.
  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Removed.
17:11 Changeset [97109] by abarth@webkit.org

[V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=69792

Reviewed by Nate Chapin.

We used to hard code the list of active DOM objects in the code
generator, but now we have an IDL attribute. This patch switches the
code generator over to using the IDL attribute.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GetDomMapFunction):

17:10 Changeset [97108] by thakis@chromium.org

[chromium] Pull tools/clang from upstream.
https://bugs.webkit.org/show_bug.cgi?id=69797

Reviewed by Adam Barth.

  • DEPS:
17:08 Changeset [97107] by barraclough@apple.com

Remove some unused methods from the DFG JIT.

Rubber stamped by Oliver Hunt

Thee methods were only used by the non-speculative JIT, and can be removed.

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCodeGenerator32_64.cpp:
  • dfg/DFGJITCodeGenerator64.cpp:
    • removed:

nonSpeculativeAdd
nonSpeculativeArithSub
nonSpeculativeArithMod
nonSpeculativeCheckHasInstance
nonSpeculativeInstanceOf

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • removed:

operationArithMod
operationInstanceOf
operationThrowHasInstanceError

16:59 Changeset [97106] by adamk@chromium.org

Support Distributed-CompileC as an action name in filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=69783

Reviewed by Ojan Vafai.

  • Scripts/filter-build-webkit:
16:56 Changeset [97105] by barraclough@apple.com

Switch most calls in DFGJITCodeGenerator to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69802

Reviewed by Oliver Hunt.

Compares, add, mod are the easy cases.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
16:34 Changeset [97104] by simon.fraser@apple.com

3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276

Reviewed by Anders Carlsson.

Use a snapshot of the window, rather than an image from the web process
for pixel testing in WebKitTestRunner. This correctly captures compositing
layers, so works for 3D transform tests.

  • WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
use that instead of the image we get from the web process.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage): Ditto.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::windowSnapshotImage): Ditto.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::windowSnapshotImage): Ditto.

16:32 Changeset [97103] by thakis@chromium.org

PluginDocumentParser uses incorrect syntax for background color
https://bugs.webkit.org/show_bug.cgi?id=69694

Reviewed by Adam Barth.

Source/WebCore:

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

LayoutTests:

  • platform/mac/plugins/iframe-plugin-bgcolor-expected.txt: Added
  • plugins/iframe-plugin-bgcolor.html: Added.
  • plugins/iframe-plugin-bgcolor-expected.png: Added.
16:09 Changeset [97102] by rniwa@webkit.org

REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
https://bugs.webkit.org/show_bug.cgi?id=69587

Reviewed by Enrica Casucci.

Source/WebCore:

Insert a space at the correct offset when startNode is a text node.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):

LayoutTests:

Unskip the test. Also rebaseline a test for a nbsp/sp change.

  • platform/win/Skipped:
  • platform/win/fast/events/ondragenter-expected.txt:
15:54 Changeset [97101] by barraclough@apple.com

DFG: Switch GetById / PutById to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69795

Reviewed by Oliver Hunt.

Also make the take base as a cell, so 32_64 doesn't have to set up the cell tag.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::appropriatePutByIdFunction):

15:42 QtWebKitBuildSystemCleanup edited by vestbo@webkit.org
(diff)
15:42 Changeset [97100] by jer.noble@apple.com

MediaControlSeekButtonElement should support seeking by changing the playback rate.
https://bugs.webkit.org/show_bug.cgi?id=63595

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-controls-scanning.html

Add a new property to HTMLMediaElement, supportsScanning(), which returns whether the
element is capable of playing its media at a rate greater than 1x. HTMLMediaElement passes
this call through to MediaPlayer and MediaPlayerPrivate. If this property returns true, the
built-in scanning controls can prefer to scan by changing the playbackRate, rather than by
repeatedly seeking small amounts of time. Unless overridden by specific media engines, this
property defaults to "false".

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsScanning): Added. Calls through to MediaPlayer.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsScanning): Added. Calls through to MediaPlayerPrivate.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::supportsScanning): Added. Defaults to "false".

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::supportsScanning): Added.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(WebCore::MediaPlayerPrivateQTKit::supportsScanning): Added.

MediaControlSeekButtonElement now queries HTMLMediaElement::supportsScanning() to see if the
media element can implement its seeking behavior by scanning the media at greater than 1x
rate. Note whether the media was playing or paused when the seek begins, so that the playing
state can be restored when seeking ends. Instead of capturing the mouse after mouseDown,
the seek button now responds to setActive() and begins seeking when the button is active
and stops when it becomes inactive.

Some behaviors have changed: clicking on the seek button no longer causes the media element
to pause; the media will end in the same state it began after the click. cStepTime has been
eliminated; Clicking the seek button will always skip by at least cSeekTime, or 0.2s.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Initialize new

ivars.

(WebCore::MediaControlSeekButtonElement::defaultEventHandler): Mark mouseDown and mouseUp

as defaultHandled, so as not to trigger drag start and drag end actions.

(WebCore::MediaControlSeekButtonElement::setActive): Call startTimer or stopTimer based

on whether the button is active or not.

(WebCore::MediaControlSeekButtonElement::startTimer): Determine whether to scan or skip

and start the seekTimer.

(WebCore::MediaControlSeekButtonElement::stopTimer): Restore the playing state and

stop the timer.

(WebCore::MediaControlSeekButtonElement::seekTimerFired): Depending on whether we're

scanning or skipping, jump ahead or change the playback rate.

  • html/shadow/MediaControlElements.h:

LayoutTests:

  • media/video-controls-scanning-expected.txt: Added.
  • media/video-controls-scanning.html: Added.
  • platform/mac/media/video-controls-scanning-expected.txt: Added.
15:41 Changeset [97099] by fpizlo@apple.com

REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=69412

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

LayoutTests:

  • fast/js/dfg-min-max-expected.txt: Added.
  • fast/js/dfg-min-max.html: Added.
  • fast/js/script-tests/dfg-min-max.js: Added.

(doMin):
(doMax):

15:39 Changeset [97098] by dmazzoni@google.com

Adding myself to the committers file.

15:32 Changeset [97097] by mhahnenberg@apple.com

Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:

Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.

  • runtime/Error.cpp:

(JSC::createTypeErrorFunction):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData. This
just makes execution fail earlier in a place where the source of the error is
easy to trace. These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:

Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:

(JSC::getCallData):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:
  • runtime/Structure.h:

Source/JavaScriptGlue:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCallFunction):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectGetCallData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::isJavaScriptFunction):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeMetaMethod::createStructure):
(JSC::Bindings::QtRuntimeConnectionMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::createStructure):

  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
15:17 Changeset [97096] by simonjam@chromium.org

[Chromium] Add baselines for new tests. Update baselines for 10.6 debug and rolled out v8 change.

Unreviewed.

  • platform/chromium-mac-snowleopard/fast/lists/inline-before-content-after-list-marker-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
  • platform/chromium-win/fast/lists/inline-before-content-after-list-marker-expected.png: Added.
  • platform/chromium-win/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:05 Changeset [97095] by joepeck@webkit.org

<http://webkit.org/b/69575> Extract WebOpenPanelResultListener out into its own file

Reviewed by David Kilzer.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Extract the WebOpenPanelResultListener class out into
its own file. No functional change.

  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebOpenPanelResultListener.h: Added.
  • WebCoreSupport/WebOpenPanelResultListener.mm: Added.

(-[WebOpenPanelResultListener dealloc]):
(-[WebOpenPanelResultListener finalize]):
(-[WebOpenPanelResultListener cancel]):
(-[WebOpenPanelResultListener chooseFilename:]):
(-[WebOpenPanelResultListener chooseFilenames:]):

  • WebView/WebUIDelegate.h:
15:02 Changeset [97094] by levin@chromium.org

Quick fix for watchlist unit test failures when using Python 2.7+
Reviewed by Adam Barth.

Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
better fix.

  • Scripts/webkitpy/common/webkitunittest.py: Always use our

version of assertRaisesRegexp.

15:01 Changeset [97093] by jer.noble@apple.com

media/video-loop.html is failing on Lion because of negative currentTime()
https://bugs.webkit.org/show_bug.cgi?id=69468

Reviewed by Darin Adler.

No new tests. Covered by media/video-loop.html test.

AVFoundation will occasionally return small, negative current times during loop operations.
Clean up these negative times before returning the currentTime.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):

14:46 Changeset [97092] by inferno@chromium.org

Merge 97088 - Exiting fullscreen shouldn't crash if the element that was fullscreened had associated anonymous blocks.

BUG=97006
Review URL: http://codereview.chromium.org/8218021

14:43 Changeset [97091] by inferno@chromium.org

Merge 95371 - Don't detach elements from the render tree when entering fullscreen mode

BUG=97006
Review URL: http://codereview.chromium.org/8218020

14:32 Changeset [97090] by inferno@chromium.org

Merge 97087 - ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads

BUG=99750
Review URL: http://codereview.chromium.org/8223012

14:31 Changeset [97089] by commit-queue@webkit.org

Unreviewed, rolling out r97082.
http://trac.webkit.org/changeset/97082
https://bugs.webkit.org/show_bug.cgi?id=69784

broke Windows build (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.

(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

14:31 Changeset [97088] by commit-queue@webkit.org

Exiting fullscreen shouldn't crash if the element that was fullscreened
had associated anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=68503

Source/WebCore:

Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-10-10
Reviewed by Simon Fraser.

Test: fullscreen/full-screen-render-inline.html
Test: fullscreen/parent-flow-inline-with-block-child.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveChildrenTo):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::moveChildrenTo):

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::unwrapRenderer):
Move all children back to the parent, not just the firstChild.

LayoutTests:

When exiting fullscreen, if the child of the RenderFullScreen is a
block and the parent has inline flow elements, the parent's children
should be made non-inline before adding the fullscreened element back
to the parent.

Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-10-10
Reviewed by Simon Fraser.

  • fullscreen/full-screen-render-inline.html: Added.
  • fullscreen/full-screen-render-inline-expected.png: Added.
  • fullscreen/full-screen-render-inline-expected.txt: Added.
  • fullscreen/parent-flow-inline-with-block-child.html: Added.
  • fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
14:28 Changeset [97087] by commit-queue@webkit.org

ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-10
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):

  • loader/DocumentWriter.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

LayoutTests:

  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Added.
  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Added.
14:21 Changeset [97086] by inferno@chromium.org

Merge 97075 - Style for updated due to inability to locate

:before content in presence of listmarkers and runins.

BUG=97599
Review URL: http://codereview.chromium.org/8216022

14:17 Changeset [97085] by inferno@chromium.org

Merge 97074 - Handle insertion into an anonymous table part that

is followed by a non-anonymous block correctly.

BUG=99338
Review URL: http://codereview.chromium.org/8226006

14:15 WebKit Team edited by mhahnenberg@apple.com
(diff)
14:14 Changeset [97084] by commit-queue@webkit.org

Add missing ifdef for JAVASCRIPT_DEBUGGER feature.
https://bugs.webkit.org/show_bug.cgi?id=69758

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-10
Reviewed by Adam Barth.

No new tests added since this is a build failure fix.

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:
  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
14:13 WebKit Team edited by mhahnenberg@apple.com
(diff)
14:11 WebKit Team edited by mhahnenberg@apple.com
(diff)
14:10 WebKit Team edited by mhahnenberg@apple.com
(diff)
14:02 Changeset [97083] by barraclough@apple.com

Switch last calls from DFGSpeculativeJIT to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69780

Reviewed by Oliver Hunt.

Also, rename type in operations for booleans from Z to B, since Z is the mathematical symbol for integers.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • wtf/Platform.h:
14:02 Changeset [97082] by simon.fraser@apple.com

3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276

Reviewed by Anders Carlsson.

The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
the window when doing pixel tests.

Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
  • WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.

(WTR::createBitmapCGContext): Utility function to create a bitmap context.
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
We need the window to autodisplay for Core Animation to render layers and start animations.

14:01 Changeset [97081] by simon.fraser@apple.com

WebKitTestRunner needs layoutTestController.setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=42688

Reviewed by Anders Carlsson.

Tools:

Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
This sets a flag that the platform layer uses to indicate that
the window is the key window, which fixes focus ring drawing
in pixel results.

Also focus the web view when we get a 'didCommitLoad' for the main
frame, as DumpRenderTree does.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::postSetWindowIsKey):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
(WTR::LayoutTestController::addChromeInputField):
(WTR::LayoutTestController::removeChromeInputField):
(WTR::LayoutTestController::focusWebView):
(WTR::LayoutTestController::setWindowIsKey):
(WTR::LayoutTestController::callAddChromeInputFieldCallback):
(WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
(WTR::LayoutTestController::callFocusWebViewCallback):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass

so that we can override -isKeyWindow. Use a boolean member variable
to track window key status.
(WTR::PlatformWebView::setWindowIsKey):
(WTR::PlatformWebView::windowIsKey):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
(WTR::closeOtherPage): Use the same cast as other functions.
(WTR::focus): Implement to call setWindowIsKey(true)
(WTR::unfocus): Implement to call setWindowIsKey(false)
(WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
(WTR::TestController::initialize):
(WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow isKeyWindow]):
(WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
(WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
(WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

Adjust the Skipped list for WebKit2, unskipping some tests, but
keeping others skipped for new reasons.

  • platform/wk2/Skipped:
13:48 Changeset [97080] by commit-queue@webkit.org

[EFL] Do not cache a frame's contents size.
https://bugs.webkit.org/show_bug.cgi?id=69772

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-10
Reviewed by Antonio Gomes.

As part of the process of experimenting with having scrollbars with
an actual size, it became clear that setting the contents size via
ChromeClient::contentsSizeChanged() and keeping the value around does
not work.

Case in point: FrameView::adjustViewSize() can result in nested
ScrollView::updateScrollbars() calls in which the innermost ones run
ChromeClient::contentsSizeChanged() before the outermost ones. This
means the ewk_frame's smart data will store an old value.

  • ewk/ewk_frame.cpp:

(ewk_frame_contents_size_get):
(ewk_frame_contents_size_changed):

13:05 Changeset [97079] by simon.fraser@apple.com

REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation
https://bugs.webkit.org/show_bug.cgi?id=69238

Reviewed by Darin Adler.

Fix PLT regression from additional scrollbars invalidations.

Don't invalidate the scrollbar rect from setHasHorizontalScrollbar()
and setHasVerticalScrollbar(), because this is called during FrameView
teardown, at which point the invalidation is redundant.

Instead, invalidate from ScrollView::updateScrollbars(), which is
called only when scrollbars change because of size or layout
changes.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):

12:54 Changeset [97078] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - bug fix for V8 benchmark cases "crypto" and "raytrace"
https://bugs.webkit.org/show_bug.cgi?id=69748

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-10
Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetMethod):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):

12:52 Changeset [97077] by commit-queue@webkit.org

check-webkit-style: Add readability exception for Ewk_* data types.
https://bugs.webkit.org/show_bug.cgi?id=69763

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-10
Reviewed by David Levin.

Many EFL-related files (such as EditorClientEfl.h or
DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
check-webkit-style.

Add an exception for them, just like there are exceptions for
Evas_*, Ecore_* and others.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:47 Changeset [97076] by kbr@google.com

Merge 96726 - Mask underlying RENDERER and VENDOR strings
https://bugs.webkit.org/show_bug.cgi?id=69389

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/canvas/webgl/renderer-and-vendor-strings.html

  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getParameter):

LayoutTests:

  • fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
  • fast/canvas/webgl/renderer-and-vendor-strings.html: Added.

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/8218017

12:47 Changeset [97075] by inferno@chromium.org

Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
https://bugs.webkit.org/show_bug.cgi?id=68624

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/lists/inline-before-content-after-list-marker.html

fast/runin/runin-between-list-marker-and-before-content.html
fast/runin/runin-into-div-with-float-child.html
fast/runin/runin-not-go-into-float.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild): Fix as per spec that
we should not be skipping over floating/positioned renderers to
push runins into neighbouring block. This matches Opera renderings.

  • rendering/RenderObject.cpp: Add const to parameter variable

to make call from beforePseudoElementRenderer easier. Also matches
CounterNode.h definition.
(WebCore::RenderObject::nextInPreOrder):
(WebCore::RenderObject::nextInPreOrderAfterChildren):

  • rendering/RenderObject.h: Same const addition.
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::beforePseudoElementRenderer):
Remove skipping of floating/positioned renderers, similar to
handleRunIn. Revert code change in r94857 and add better next
sibling iterator. This addresses the layouttest in r94857 where
:before content is in its own anonymous rendertable.

LayoutTests:

  • fast/lists/inline-before-content-after-list-marker-expected.png: Added.
  • fast/lists/inline-before-content-after-list-marker-expected.txt: Added.
  • fast/lists/inline-before-content-after-list-marker.html: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added.
  • fast/runin/runin-between-list-marker-and-before-content.html: Added.
  • fast/runin/runin-into-div-with-float-child-expected.png: Added.
  • fast/runin/runin-into-div-with-float-child-expected.txt: Added.
  • fast/runin/runin-into-div-with-float-child.html: Added.
  • fast/runin/runin-not-go-into-float-expected.png: Added.
  • fast/runin/runin-not-go-into-float-expected.txt: Added.
  • fast/runin/runin-not-go-into-float.html: Added.
11:58 Changeset [97074] by inferno@chromium.org

Handle insertion into an anonymous table part that
is followed by a non-anonymous block correctly.
https://bugs.webkit.org/show_bug.cgi?id=69536

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/table/table-insert-before-non-anonymous-block.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::splitColumn):

LayoutTests:

  • fast/table/table-insert-before-non-anonymous-block-expected.png: Added.
  • fast/table/table-insert-before-non-anonymous-block-expected.txt: Added.
  • fast/table/table-insert-before-non-anonymous-block.html: Added.
11:56 Changeset [97073] by aroben@apple.com

Build fix

  • wtf/MainThread.h: Pull in Platform.h since this file uses PLATFORM() macros.
11:45 Changeset [97072] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - Bug fix for BranchNull
https://bugs.webkit.org/show_bug.cgi?id=69743

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-10
Reviewed by Darin Adler.

This fixes the error in access-binary-trees. All SunSpider cases passed.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):

11:43 Changeset [97071] by barraclough@apple.com

DFG JIT: callOperation should return the Call.
https://bugs.webkit.org/show_bug.cgi?id=69682

Reviewed by Oliver Hunt.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):
(JSC::DFG::appendCallWithExceptionCheckSetResult):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::appendCall):

  • wtf/Platform.h:
11:12 Changeset [97070] by rniwa@webkit.org

Style guide should mandate use of pass-by-reference for out arguments
https://bugs.webkit.org/show_bug.cgi?id=69766

Reviewed by Darin Adler.

This matches the convention used throughout WebCore.

  • coding/coding-style.html:
11:01 Changeset [97069] by tkent@chromium.org

Make static functions in HTMLSelectElement.cpp member functions of HTMLSelectElement class
https://bugs.webkit.org/show_bug.cgi?id=69755

Reviewed by Ryosuke Niwa.

No new tests, just a refactoring.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::nextValidIndex):
Make this a static member function of HTMLSelectElement.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Make this a member function of HTMLSelectElement.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::selectAll): Update callsite of the above functions.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.

  • html/HTMLSelectElement.h:
    • Add the above function declarations.
    • Move SkipDirection definition from HTMLSelectElement.cpp.
10:39 QtWebKitBuildSystemCleanup edited by vestbo@webkit.org
(diff)
10:24 Changeset [97068] by dmazzoni@google.com

[Chromium] Get rid of WebAccessibilityCache.
https://bugs.webkit.org/show_bug.cgi?id=68224

Reviewed by Dimitri Glazkov.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebAccessibilityCache.h: Removed.
  • src/WebAccessibilityCache.cpp: Removed.
  • src/WebAccessibilityCacheImpl.cpp: Removed.
  • src/WebAccessibilityCacheImpl.h: Removed.

Tools:

  • DumpRenderTree/chromium/AccessibilityController.cpp:

(AccessibilityController::bindToJavascript):

10:19 QtWebKitBuildSystemCleanup created by vestbo@webkit.org
10:03 Changeset [97067] by pfeldman@chromium.org

Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
https://bugs.webkit.org/show_bug.cgi?id=69726

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._breakpointResolved):

  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.CompilerSourceMapping.prototype.sources):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.isXMLNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
(WebInspector.DOMDispatcher.prototype.characterDataModified):
(WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
(WebInspector.DOMDispatcher.prototype.childNodeInserted):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView):

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerPausedDetails):
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerModel.prototype.get callFrames):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.PresentationConsoleMessage):
(WebInspector.PresentationCallFrame.prototype.evaluate):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._documentUpdated.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._documentUpdated):

  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Object.js:

(WebInspector.Object.prototype.dispatchEventToListeners):
(WebInspector.Event):
(WebInspector.Event.prototype.stopPropagation):
(WebInspector.Event.prototype.preventDefault):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.SourceMapping):
(WebInspector.RawSourceCode.SourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):
(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createStatusbarButtons):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.ContentProvider.SearchMatch):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

  • inspector/front-end/externs.js:
  • inspector/generate-protocol-externs:

LayoutTests:

  • inspector/debugger/raw-source-code.html:
09:58 Changeset [97066] by loislo@chromium.org

Unreviewed fix for the test. The amount of used memory was calculated incorrectly.

  • inspector/performance/resources/network-append-30-requests.html:
09:40 Changeset [97065] by loislo@chromium.org

Web Inspector: Linkifier.reset throw an exception if it is called after reset of debuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=69756

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):

09:39 Changeset [97064] by dglazkov@chromium.org

Revert 91125 - 2011-07-15 Rob Buis <rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:

TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/8222009

09:14 BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
(diff)
09:09 Changeset [97063] by podivilov@chromium.org

Web Inspector: RawSourceCode could be mapped to multiple sources.
https://bugs.webkit.org/show_bug.cgi?id=68526

Source/WebCore:

Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
then one UISourceCode associated with a RawSourceCode.

Reviewed by Pavel Feldman.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/scripts-panel.html:
07:51 Changeset [97062] by andreas.kling@nokia.com

Shrink RenderLayer and ScrollableArea.
https://bugs.webkit.org/show_bug.cgi?id=69759

Reviewed by Antti Koivisto.

Rearrange the members of RenderLayer and its base class ScrollableArea
to maximize struct packing, shrinking RenderLayer by one CPU word on
32-bit (and two on 64-bit.)

This reduces memory consumption by 134 kB (on 64-bit) when loading the
full HTML5 spec.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::verticalScrollElasticity):
(WebCore::ScrollableArea::horizontalScrollElasticity):
(WebCore::ScrollableArea::scrollbarOverlayStyle):

Cast the now-bitfield members to the appropriate enum types.

  • rendering/RenderLayer.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

Move shouldBeNormalFlowOnly() call out of initializer list since it
depends on m_renderer being initialized.

07:47 Changeset [97061] by kbalazs@webkit.org

Unreviewed gardening after r96958.
https://bugs.webkit.org/show_bug.cgi?id=69757

Unreviewed gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-10

  • platform/qt/Skipped:
07:06 Changeset [97060] by podivilov@chromium.org

2011-10-10 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix test after r97056.

  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
  • platform/chromium/test_expectations.txt:
06:24 Changeset [97059] by pfeldman@chromium.org

Merge 96319 - Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
  • platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
  • platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8222004

06:07 Changeset [97058] by caryclark@google.com

[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
https://bugs.webkit.org/show_bug.cgi?id=69656
https://bugs.webkit.org/show_bug.cgi?id=62987
https://bugs.webkit.org/show_bug.cgi?id=62889

Reviewed by Stephen White.

Skia on Linux and Windows uses different font engines from
Skia on Mac. After determining that the underlying CoreText
can handle it, enabling this allows justification to work
correctly.

Tests: fast/text/justify-ideograph-complex.html

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText):

06:04 Changeset [97057] by loislo@chromium.org

Web Inspector: memory leak in Resource panel.
https://bugs.webkit.org/show_bug.cgi?id=69754

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.reset):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.childViews):

05:40 Changeset [97056] by podivilov@chromium.org

Web Inspector: saving JavaScript after live edit resets scroller position.
https://bugs.webkit.org/show_bug.cgi?id=69340

Source/WebCore:

Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.contentChanged):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/ui-source-code-expected.txt:
  • inspector/debugger/ui-source-code.html:
04:43 Changeset [97055] by loislo@chromium.org

Unreviewed test fix for r97050.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

04:29 Changeset [97054] by andreas.kling@nokia.com

Shrink RenderListItem on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69751

Reviewed by Kenneth Rohde Christiansen.

Rearrange members to utilize the padding at the end of RenderBlock.
This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption
by 60 kB when loading the full HTML5 spec.

  • rendering/RenderListItem.h:
04:27 Changeset [97053] by podivilov@chromium.org

2011-10-10 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.

  • tests/CCThreadTest.cpp: (WebKit::TEST):
03:52 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:51 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:48 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:43 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:14 Changeset [97052] by andreas.kling@nokia.com

Shrink RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=69707

Reviewed by Antti Koivisto.

Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
Enum bitfields were changed to "unsigned" for the MSVC signedness quirk.

Also move one 32-bit member to the head of RootInlineBox so it falls into the
padding at the end of InlineFlowBox on 64-bit.

This reduces memory consumption by 780 kB (on 64-bit) when loading the full
HTML5 spec.

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineBreakBidiStatus):

  • rendering/RootInlineBox.h:
03:08 Changeset [97051] by podivilov@chromium.org

2011-10-10 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, attempt to fix chromium mac build after r97034.

  • platform/ScrollAnimatorNone.h:
02:57 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
02:54 Changeset [97050] by loislo@chromium.org

Web Inspector: small memory leak in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=69744

Scripts panel doesn't clean the list of child views.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):

02:33 Changeset [97049] by yurys@chromium.org

Web Inspector: allow to start WorkerContext paused
https://bugs.webkit.org/show_bug.cgi?id=69635

Source/WebCore:

Allow to pause WorkerContext on start.

Reviewed by Pavel Feldman.

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setPauseOnNextStatement):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):

  • bindings/v8/WorkerScriptDebugServer.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext): this method will start
running worker message loop in "debug" mode, i.e. it will process only inspector
tasks until method InspectorRuntimeAgent::resume is called.
(WebCore::InspectorRuntimeAgent::resume):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::resume): method which is called from WebKit layer
when it is known that inspector state was restored and it is OK to resume worker execution.

  • inspector/WorkerInspectorController.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):

  • workers/DedicatedWorkerThread.h:
  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):

  • workers/SharedWorkerThread.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread): WorkerThread is passed a booleand flag indicating
whether the context should be paused and wait for explicit resume command before it
starts running its script.
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

Source/WebKit/chromium:

Expose methods for pausing shared worker on start.

Reviewed by Pavel Feldman.

  • public/WebSharedWorker.h:

(WebKit::WebSharedWorker::pauseWorkerContextOnStart): specifies that the worker
context should be paused and weit for explicit call to resumeWorkerContext before
running its script.
(WebKit::WebSharedWorker::resumeWorkerContext):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::startWorkerContext):
(WebKit::WebSharedWorkerImpl::pauseWorkerContextOnStart):
(WebKit::resumeWorkerContextTask):
(WebKit::WebSharedWorkerImpl::resumeWorkerContext):
(WebKit::WebSharedWorkerImpl::attachDevTools):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::WebSharedWorkerImpl::reattachDevTools):
(WebKit::WebSharedWorkerImpl::detachDevTools):
(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):

  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::updateInspectorStateCookie):

  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp:

(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::detachDevTools):
(WebKit::WebWorkerImpl::dispatchDevToolsMessage):

02:23 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
02:21 Changeset [97048] by hausmann@webkit.org

[Qt] Fix build with qreal == float on MeeGo 1.2 Harmattan

Reviewed by Andreas Kling.

Explicitly choose the qreal variant of qMin, since QPointF is using qreal.

  • UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):

02:20 Changeset [97047] by carlosgc@webkit.org

[GTK] Add methods to reload the view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69613

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/testloading.c:

(loadReloadProvisionalLoadStarted):
(loadReloadLoadFinished):
(testLoadTimeoutFinishLoop):
(testLoadReload):
(main):

02:03 Changeset [97046] by commit-queue@webkit.org

Unreviewed, rolling out r97045.
http://trac.webkit.org/changeset/97045
https://bugs.webkit.org/show_bug.cgi?id=69746

makes apple bots very crashy :( (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

  • platform/graphics/Color.h:

(WebCore::Color::Color):

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

00:50 Changeset [97045] by andreas.kling@nokia.com

Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

  • config.h: Touch to force full rebuild.

Source/WebCore:

Unroll BorderValue's Color member so we can pack the color's validity flag
in BorderValue's bitfield.

This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
16 bytes. This reduces memory consumption by 760 kB when loading the full
HTML5 spec.

  • platform/graphics/Color.h:

(WebCore::Color::Color):

Allow construction of Color objects with specific validity.

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
Made those variables private and added color(), setColor() accessors.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):

Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
when setting BorderValue colors.

(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

Made color getters return "Color" instead of "const Color&" since
BorderValue no longer has an actual object to return the reference to.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

Adapt to RenderStyle color getters now returning "Color" instead of
"const Color&".

00:15 Changeset [97044] by yurys@chromium.org

Missing m_notificationPresenter initialization in WorkerThread constructor
https://bugs.webkit.org/show_bug.cgi?id=69741

Added missing m_notificationPresenter(0)

Reviewed by Pavel Feldman.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):

10/09/11:

22:57 Changeset [97043] by ryuan.choi@samsung.com

[EFL] Refactor zoom related APIs.
https://bugs.webkit.org/show_bug.cgi?id=62842

Current zoom apis can't support the case of using both page zoom and text
zoom.

As a first step to refactor, this split ewk_{view|frame}_zoom_{get|set}
to use both page_zoom and text zoom individually.
In addition, introduce ewk_view_scale_{get|set} to support proportional scaling.

ewk_view_zoom_{get|set} will remain unchanged until the behavior of smart_zoom
was changed.

Reviewed by Antonio Gomes.

  • ewk/ewk_frame.cpp: Remove ewk_frame_zoom_text_only_{get|set}.

(ewk_frame_page_zoom_get): Renamed from ewk_frame_zoom_get().
(ewk_frame_page_zoom_set): Renamed from ewk_frame_zoom_set().
(ewk_frame_text_zoom_get): Extracted from ewk_frame_zoom_get().
(ewk_frame_text_zoom_set): Extracted from ewk_frame_zoom_set().

  • ewk/ewk_frame.h:
  • ewk/ewk_view.cpp: Remove ewk_view_zoom_text_only_{get|set}

(_ewk_view_smart_zoom_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_zoom_get): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_page_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_page_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_scale_get): Added.
(ewk_view_scale_set): Added.
(ewk_view_text_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_text_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_zoom_weak_set): Change ewk_frame_zoom_get to ewk_frame_page_zoom_get().
(ewk_view_zoom_animated_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_region): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_relative_radius): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().

  • ewk/ewk_view.h:
22:09 Changeset [97042] by dbates@webkit.org

Another attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
to a single precision result. I am unsure if this fix is correct. We need to look into this some
more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.

21:54 Changeset [97041] by dbates@webkit.org

Attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
an integer. I am unsure if this fix is correct. We need to look into this some more. See
<https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.

21:28 Changeset [97040] by dbates@webkit.org

Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)
https://bugs.webkit.org/show_bug.cgi?id=69735

Patch by Luke Macpherson <macpherson@chromium.org> on 2011-10-09
Reviewed by Daniel Bates.

Source/WebCore:

  • testing/Internals.cpp:

Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::setZoomParameters):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Add symbols that are now required by ScrollableArea.
(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

21:05 Changeset [97039] by commit-queue@webkit.org

Improve Null or Undefined test in 32_64 DFG
https://bugs.webkit.org/show_bug.cgi?id=69734

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.

Currently Null or Undefined value test in 32_64 DFG will check
Null and Undefined tag separately and introduce one more branch.
It can be improved in the way how the baseline JIT is doing - by
relying on the fact that "UndefinedTag + 1 == NullTag and NullTag & 1".

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

20:25 Changeset [97038] by tkent@chromium.org

Remove redundant code of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=69701

Reviewed by Darin Adler.

No new tests, just a refactoring.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::deselectItems):
Rename inner deselectItems() to deselectItemsWithoutValidation().
(WebCore::HTMLSelectElement::setSelectedIndex):
Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
ditto, and update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::listBoxSelectItem):
Update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::activeSelectionEndListIndex):
Update a callsite of lastSelectedListIndex().
(WebCore::HTMLSelectElement::selectAll):
Update callsites of functions which are changed to non-static.
(WebCore::HTMLSelectElement::saveLastSelection):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::menuListOnChange): ditto.
(WebCore::HTMLSelectElement::scrollToSelection): ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
(WebCore::HTMLSelectElement::setRecalcListItems):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::selectedIndex): ditto.
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
Made this non-static, and renamed from setSelectedIndex() because
of conflict with an existing function.
(WebCore::HTMLSelectElement::optionToListIndex):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::dispatchFocusEvent):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
Made this non-static, and renamed from deselectItems() to avoid conflict.
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::defaultEventHandler):
Merged a static function and a non-static function.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.

20:11 Changeset [97037] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - Bug fix for ConvertThis
https://bugs.webkit.org/show_bug.cgi?id=69721

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

19:29 Changeset [97036] by abarth@webkit.org

Remove "near miss" XSS vulnerabilities in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69708

Reviewed by David Levin.

Collin Jackson did a security audit of garden-o-matic. He hasn't found
any actual vulnerabilities yet, but he did identify a couple "near
misses" where a slight change in garden-o-matic could lead to a
vulnerability. This patch removes those potential issues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
18:15 Changeset [97035] by abarth@webkit.org

CSP should log unrecognized directives to the console
https://bugs.webkit.org/show_bug.cgi?id=69728

Reviewed by Sam Weinig.

Source/WebCore:

Several of the web developers who have been experimenting with CSP have
run into trouble with directives we don't support. For example, one
developer was confused for a while why image-src didn't do what he
expected. Logging a message to the console will help these folks
figure out what's going on.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
(WebCore::ContentSecurityPolicy::addDirective):

  • page/ContentSecurityPolicy.h:

LayoutTests:

Update expected results to include new console message about unrecognized directives.

  • http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
17:21 Changeset [97034] by wjmaclean@chromium.org

[chromium] Zoom animator front-end
https://bugs.webkit.org/show_bug.cgi?id=68035

Source/WebCore:

Adds necessary components to ScrollAnimatorNone to support a zoom animation
feature. Includes test infrastructure via testing/Internals to capture
in-progress texture scaling (zoom-animator-scale-test.html) as well as a
final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.

Removes temporary test fields from Settings.

Reviewed by Kenneth Russell.

Test: platform/chromium/compositing/zoom-animator-scale-test2.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged):

  • page/FrameView.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::notifyZoomChanged):
(WebCore::ScrollAnimator::zoomTranslation):
(WebCore::ScrollAnimator::resetZoom):
(WebCore::ScrollAnimator::setZoomParametersForTest):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::zoomScale):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
(WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::zoom):
(WebCore::ScrollAnimatorNone::handleGestureEvent):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorNone.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::zoomAnimatorTransformChanged):

  • platform/ScrollableArea.h:
  • testing/Internals.cpp:

(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::getPageScaleFactor):
(WebCore::Internals::setZoomParameters):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

Modifications to get zoom texture-scale parameters from ScaleAnimator directly
instead of via Settings.

Reviewed by Kenneth Russell.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

Reviewed by Kenneth Russell.

  • platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
  • platform/chromium/compositing/zoom-animator-scale-test.html:
  • platform/chromium/compositing/zoom-animator-scale-test2-expected.txt: Added.
  • platform/chromium/compositing/zoom-animator-scale-test2.html: Added.
  • platform/chromium/test_expectations.txt:
15:40 Changeset [97033] by fpizlo@apple.com

Remove unused callOperation code of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69722

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

13:15 Changeset [97032] by mitz@apple.com

<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
https://bugs.webkit.org/show_bug.cgi?id=69727

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell

used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
obey its flippedness.

13:14 Changeset [97031] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble
https://bugs.webkit.org/show_bug.cgi?id=69720

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by
a FPR and will be used for further optimizations, though we currently
don't fully utilize it. For now when filling a JS value which was
spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat
to DataFormatJS to avoid compilation errors.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):

13:07 Changeset [97030] by fpizlo@apple.com

DFG should not always speculate that a ByVal access has an integer index
https://bugs.webkit.org/show_bug.cgi?id=69716

Reviewed by Oliver Hunt.

1% win on SunSpider, neutral elsewhere.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::byValHasIntBase):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

09:15 Changeset [97029] by kov@webkit.org

Tagging 1.6.0.

09:14 Changeset [97028] by kov@webkit.org

Tagging 1.6.1.

06:09 Changeset [97027] by jnd@chromium.org

Change bug of tap-highlight-color.html to bug 66577 and close bug 48544.
https://bugs.webkit.org/show_bug.cgi?id=48544

Unreviewed.

  • platform/chromium/test_expectations.txt:
03:39 Changeset [97026] by ossy@webkit.org

[Qt] Unreviewed weekend gardening, skip failing tests

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
03:19 Changeset [97025] by commit-queue@webkit.org

Fix value profiling in 32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=69717

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

Current value profiling for 32_64 JIT is broken and cannot record
correct predicated types, which results in many speculation failures
in the 32_64 DFG JIT, fallbacks to baseline JIT, and re-optimizations
again and again.
With this fix 32_64 DFG JIT can demonstrate real performance gains.

  • bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeStatistics):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):

Empty value check should be performed on decoded JSValue,
as for 32_64 empty value is not identical to encoded 0.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

Record the right profiling result for 32_64.

03:02 Changeset [97024] by ossy@webkit.org

[Qt] Unreviewed weekend gardening.

  • platform/qt/fast/images/color-jpeg-with-color-profile-expected.png: Added after r96970.
  • platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Added after r96970.
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added after r97021.
  • platform/qt/svg/clip-path/clip-path-transform-1-expected.png: Added after r96712.
  • platform/qt/svg/clip-path/clip-path-transform-1-expected.txt: Added after r96712.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.png: Added after r96712.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Added after r96712.
  • platform/qt/svg/custom/grayscale-gradient-mask-2-expected.png: Added after r96470.
  • platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Added after r96470.
03:00 Changeset [97023] by benjamin@webkit.org

Do not compare the first glyph to itself in Font::drawGlyphBuffer()
https://bugs.webkit.org/show_bug.cgi?id=69715

Reviewed by Andreas Kling.

When looking for glyphs with similar properties, we should
skip the first one since the comparison of fontData
and offset will always fail.

This is covered by the existing tests.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):

01:08 Changeset [97022] by commit-queue@webkit.org

Remove 32 bit restrictions in DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69711

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

op_call/op_construct support was disabled for 32 bit DFG JIT because
there was regression in javascriptcore tests. Now the bugs are fixed
and there should be no regression. This makes 32 bit DFG have the same
capability as 64 bit DFG, and improves the coverage.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

00:23 Changeset [97021] by commit-queue@webkit.org

[Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
https://bugs.webkit.org/show_bug.cgi?id=69700

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-09
Reviewed by Adam Barth.

  • http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml:
  • platform/qt/Skipped:

10/08/11:

21:23 Changeset [97020] by inferno@chromium.org

Merge 96999 - Make isXMLMIMEType regex use TLS

BUG=94487
Review URL: http://codereview.chromium.org/8210003

21:19 Changeset [97019] by inferno@chromium.org

Merge 96991 - https://bugs.webkit.org/show_bug.cgi?id=69471

BUG=98582
Review URL: http://codereview.chromium.org/8212005

18:20 Changeset [97018] by inferno@chromium.org

Merge 96984 - XSLT-generated document should inherit its SecurityOrigin from the source document

BUG=99512
Review URL: http://codereview.chromium.org/8213002

17:24 Changeset [97017] by jschuh@chromium.org

Make ThreadGlobalData members use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=69710

Reviewed by Adam Barth.

No functional changes. No new tests required.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:
16:26 Changeset [97016] by mhahnenberg@apple.com

Add static version of JSCell::getConstructData
https://bugs.webkit.org/show_bug.cgi?id=69673

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::getConstructData):

  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getConstructData):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getConstructData):

  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::getConstructData):

  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getConstructData):

  • runtime/DateConstructor.h:
  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::getConstructData):

  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getConstructData):

  • runtime/FunctionConstructor.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getConstructData):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getConstructData):

  • runtime/JSFunction.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::getConstructData):

  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getConstructData):

  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getConstructData):

  • runtime/ObjectConstructor.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getConstructData):

  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getConstructData):

  • runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::JSAudioConstructor::getConstructData):

  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::getConstructData):

  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp:

(WebCore::JSOptionConstructor::getConstructData):

  • bindings/js/JSOptionConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getConstructData):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getConstructData):

  • bridge/runtime_object.h:

Source/WebKit2:

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getConstructData):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
14:31 Changeset [97015] by mhahnenberg@apple.com

Add static version of JSCell::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=69593

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

(JSC::DebuggerActivation::getOwnPropertySlot):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):

  • runtime/Arguments.h:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/DatePrototype.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/ErrorPrototype.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):

  • runtime/JSArray.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::getOwnPropertySlot):

  • runtime/JSBoundFunction.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlot):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlot):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlot):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • runtime/JSString.h:
  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):

  • runtime/MathObject.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlot):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):

  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):

  • runtime/StringPrototype.h:

Source/JavaScriptGlue:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

  • UserObjectImp.cpp:

(UserObjectImp::getOwnPropertySlot):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):

  • bindings/js/JSDOMWindowShell.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):

  • bridge/runtime_object.h:

Source/WebKit2:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlot):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
13:42 Changeset [97014] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - GetLocal should produce a cell result for Array predictions
https://bugs.webkit.org/show_bug.cgi?id=69699

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

It should match SetLocal where only payload is stored for array predictions.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:40 Changeset [97013] by commit-queue@webkit.org

JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=69702

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

There are some errors in generating code for Branch and LogicalNot,
when the operand is predicted as ObjectOrOther.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

10:46 Changeset [97012] by mrobinson@webkit.org

[GTK] Implement drag and drop support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63706

Reviewed by Philippe Normand.

Source/WebCore:

  • platform/DragData.h:
  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::text): Mark as const.
(WebCore::DataObjectGtk::markup): Ditto.
(WebCore::DataObjectGtk::urlLabel): Ditto.

  • platform/gtk/DataObjectGtk.h: Remove unused member

m_dragContext.
(WebCore::DataObjectGtk::url): Mark as const.
(WebCore::DataObjectGtk::uriList): Ditto.
(WebCore::DataObjectGtk::filenames): Ditto.
(WebCore::DataObjectGtk::image): Ditto.
(WebCore::DataObjectGtk::hasText): Ditto.
(WebCore::DataObjectGtk::hasMarkup): Ditto.
(WebCore::DataObjectGtk::hasURIList): Ditto.
(WebCore::DataObjectGtk::hasURL): Ditto.
(WebCore::DataObjectGtk::hasFilenames): Ditto.
(WebCore::DataObjectGtk::hasImage): Ditto.

  • platform/gtk/DragIcon.cpp: Added. A helper which takes care of

creating a transparent drag window for drags.

  • platform/gtk/DragIcon.h: Added.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • Shared/gtk/ArgumentCodersGtk.cpp: Added.

(CoreIPC::encodeImage): Encode a GdkPixbuf.
(CoreIPC::decodeImage): Decode a GdkPixbuf.
(CoreIPC::encodeDataObject): Encode a DataObjectGtk.
(CoreIPC::decodeDataObject): Decode a DataObjectGtk.
(CoreIPC::::encode): Encode DragData.
(CoreIPC::::decode): Decode DragData.

  • Shared/gtk/ArgumentCodersGtk.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::startDrag):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_init): Set the view as a potential drop destination.
(webkitWebViewBaseDragDataGet): Added, delegate to GtkDragAndDropHelper.
(webkitWebViewBaseDragEnd): Ditto.
(webkitWebViewBaseDragDataReceived): Ditto.
(webkitWebViewBaseDragEnter): Ditto.
(webkitWebViewBaseDragMotion): Ditto.
(doDragLeaveLater): Ditto.
(webkitWebViewBaseDragLeave): Ditto.
(webkitWebViewBaseDragDrop): Ditto.
(webkit_web_view_base_class_init): Override GtkWidget drag and drop methods.
(webkitWebViewBaseStartDrag): Calls gtk_drag_begin() to start a drag operation.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add webkitWebViewBaseStartDrag().
  • UIProcess/PageClient.h: Add startDrag().
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Share the Qt version.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: Added.
  • WebProcess/WebPage/WebPage.cpp: Add drag support for GTK+.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.
09:12 Changeset [97011] by qi.2.zhang@nokia.com

[WK2] Update Skipped file
https://bugs.webkit.org/show_bug.cgi?id=69650

Reviewed by Andreas Kling.

Unskip passed ApplicationCache test cases.

  • platform/wk2/Skipped:
08:37 Changeset [97010] by commit-queue@webkit.org

[Qt] [WK2] Wrong handling of visibility in QTouchWebPage
https://bugs.webkit.org/show_bug.cgi?id=69670

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-10-08
Reviewed by Andreas Kling.

Replace QTouchWebPage visibility handling by Show/Hide events with use of
QSGItem::visibleChanged signal.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::onVisibleChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
07:19 Changeset [97009] by inferno@chromium.org

Add support for ADDRESS_SANITIZER in RenderArena
allocate, free calls.
https://bugs.webkit.org/show_bug.cgi?id=69636

Reviewed by Darin Adler.

Use malloc, free directly without using the debug header. Otherwise,
we won't be able to detect out of bounds access in debug header.

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

06:10 Changeset [97008] by ossy@webkit.org

[Qt] Unreviewed weekend gardening.

  • platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Updated after 96886.
  • platform/qt/Skipped: Skip http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml - http://webkit.org/b/69700
  • platform/qt/fast/css/text-transform-select-expected.png: Added after r96987.
  • platform/qt/fast/css/text-transform-select-expected.txt: Added after r96987.
02:05 Changeset [97007] by tkent@chromium.org

Remove some static functions of HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69621

Reviewed by Darin Adler.

Merge a static function and the corresponding non-static member function
into one function if there are no other callers of the static function.

No new tests, just a refactoring.

  • html/HTMLFormControlElement.h:

Make formControlName() protected because it is called from
HTMLSelectElement.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseMappedAttribute):
Remove two argument of parseMultipleAttribute().
(WebCore::HTMLSelectElement::selectAll):
Merged the static function and the member function.
(WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::parseMultipleAttribute):

  • Make this non-static member function.
  • Use reattachIfAttached().

(WebCore::HTMLSelectElement::appendFormData): Merged.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
(WebCore::HTMLSelectElement::length): Merged with optionCount().

  • html/HTMLSelectElement.h:
01:54 Changeset [97006] by commit-queue@webkit.org

Unreviewed, rolling out r96996.
http://trac.webkit.org/changeset/96996
https://bugs.webkit.org/show_bug.cgi?id=69697

It broke all tests on the Qt bot (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-08

Source/JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::getCallDataVirtual):

  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getCallDataVirtual):

  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getCallDataVirtual):

  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::getCallDataVirtual):

  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getCallDataVirtual):

  • runtime/DateConstructor.h:
  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
(JSC::createTypeErrorFunction):

  • runtime/Error.h:
  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::getCallDataVirtual):

  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getCallDataVirtual):

  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::getCallDataVirtual):

  • runtime/FunctionPrototype.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getCallDataVirtual):

  • runtime/JSCell.h:

(JSC::getCallData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getCallDataVirtual):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::getCallDataVirtual):

  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getCallDataVirtual):

  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getCallDataVirtual):

  • runtime/ObjectConstructor.h:
  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getCallDataVirtual):

  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getCallDataVirtual):

  • runtime/StringConstructor.h:
  • runtime/Structure.h:

Source/JavaScriptGlue:

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCallFunction):

  • UserObjectImp.cpp:

(UserObjectImp::getCallDataVirtual):

  • UserObjectImp.h:

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::JSHTMLAllCollection::getCallDataVirtual):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getCallDataVirtual):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getCallDataVirtual):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getCallDataVirtual):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectGetCallData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallDataVirtual):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getCallDataVirtual):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallDataVirtual):
(JSC::Bindings::isJavaScriptFunction):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getCallDataVirtual):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getCallDataVirtual):

  • bridge/runtime_object.h:

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::getCallDataVirtual):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallDataVirtual):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
01:15 Changeset [97005] by fpizlo@apple.com

DFG JIT - only Array predictions can result in unboxed cells in register file
https://bugs.webkit.org/show_bug.cgi?id=69695

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

In current DFG JIT, only array predictions can result in unboxed cells
in register file, not for the other cell predictions.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):

00:31 Changeset [97004] by rniwa@webkit.org

Snow Leopard build fix after r96976. Apparently we just need a full rebuild.

  • config.h:
00:04 Changeset [97003] by commit-queue@webkit.org

bug fixes for ArrayPush and ArrayPop in 32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69696

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-07
Reviewed by Filip Pizlo.

On 32-bit, we should use TimesEight (8) instead of ScalePtr (4)
to compute the address of a JS array element.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10/07/11:

23:37 Changeset [97002] by mhahnenberg@apple.com

Add static version of JSCell::deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=69659

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::deleteProperty):

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::deleteProperty):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::deleteProperty):

  • runtime/Arguments.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::deleteProperty):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::deleteProperty):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::deleteProperty):

  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::deleteProperty):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):

  • runtime/JSVariableObject.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::deleteProperty):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deleteProperty):

  • runtime/StrictEvalActivation.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::deleteProperty):

  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::deleteProperty):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::deleteProperty):

  • bridge/runtime_object.h:
22:37 Changeset [97001] by rniwa@webkit.org

[JSC]Two tests fails after r95489 & r95488
https://bugs.webkit.org/show_bug.cgi?id=68428

Move V8-specific results to Chromium and put JSC result in cross-platform directory.
Also unskip the tests on Mac.

  • http/tests/security/document-all-expected.txt:
  • http/tests/security/window-named-proto-expected.txt:
  • platform/chromium/http/tests/security/document-all-expected.txt: Copied from

LayoutTests/http/tests/security/document-all-expected.txt.

  • platform/chromium/http/tests/security/window-named-proto-expected.txt: Copied from

LayoutTests/http/tests/security/window-named-proto-expected.txt.

  • platform/gtk/http/tests/security/document-all-expected.txt: Removed.
  • platform/gtk/http/tests/security/window-named-proto-expected.txt: Removed.
  • platform/mac/Skipped:
  • platform/qt/http/tests/security/document-all-expected.txt: Removed.
  • platform/qt/http/tests/security/window-named-proto-expected.txt: Removed.
19:46 Changeset [97000] by jeffm@apple.com

Add WKPageContextMenuClient callback when context menu is dismissed
https://bugs.webkit.org/show_bug.cgi?id=69553

Add contextMenuDismissed callback to WKPageContextMenuClient, and bump the API
version of this client to 1 so we continue to work with old clients.

  • Shared/APIClientTraits.cpp: Added array of interface sizes for WKPageContextMenuClient.
  • Shared/APIClientTraits.h: Added APIClientTraits for WKPageContextMenuClient.
  • UIProcess/API/C/WKPage.h: Added contextMenuDismissed callback to WKPageContextMenuClient and bumped kWKPageContextMenuClientCurrentVersion.
  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::contextMenuDismissed): Added.

  • UIProcess/WebPageContextMenuClient.h: Added WebPageContextMenuClient::contextMenuDismissed().
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu): Notify client when context menu is dismissed.

19:22 Changeset [96999] by jschuh@chromium.org

Make isXMLMIMEType regex use TLS
https://bugs.webkit.org/show_bug.cgi?id=69665

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/workers/worker-multi-startup.html

  • dom/DOMImplementation.cpp:

(WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
(WebCore::XMLMIMETypeRegExp::~XMLMIMETypeRegExp):
(WebCore::XMLMIMETypeRegExp::isXMLMIMEType):
(WebCore::DOMImplementation::isXMLMIMEType):

  • dom/DOMImplementation.h:
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::xmlTypeRegExp):

LayoutTests:

  • fast/workers/worker-multi-startup-expected.txt: Added.
  • fast/workers/worker-multi-startup.html: Added.
19:08 Changeset [96998] by simonjam@chromium.org

[Chromium] Allow failure of another Mac Skia test.

Unreviewed.

  • platform/chromium/test_expectations.txt: Added first-of-type-pseudo-class.html.
19:01 Changeset [96997] by commit-queue@webkit.org

Unreviewed, rolling out r96847.
http://trac.webkit.org/changeset/96847
https://bugs.webkit.org/show_bug.cgi?id=69684

may have caused memory regression on win chromium (Requested
by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

18:44 Changeset [96996] by mhahnenberg@apple.com

Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/Error.cpp:

(JSC::createTypeErrorFunction):

Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData. This
just makes execution fail earlier in a place where the source of the error is
easy to trace. These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:

Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:

(JSC::getCallData):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:
  • runtime/Structure.h:

Source/JavaScriptGlue:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCallFunction):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectGetCallData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::isJavaScriptFunction):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::createStructure):
(JSC::Bindings::QtRuntimeConnectionMethod::createStructure):

  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
17:43 Changeset [96995] by oliver@apple.com

Add missing break statement.

17:41 Changeset [96994] by bfulgham@webkit.org

[WinCairo] Unreviewed Skiplist update to get bot green.

  • platform/wincairo/Skipped: Turn off a few more tests.
17:06 Changeset [96993] by oliver@apple.com

Support some string intrinsics in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69678

Reviewed by Gavin Barraclough.

Add support for charAt and charCodeAt intrinsics in the DFG.

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:06 Changeset [96992] by mhahnenberg@apple.com

Add static version of JSCell::put
https://bugs.webkit.org/show_bug.cgi?id=69382

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::put):

(JSC::DebuggerActivation::put):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::put):

  • runtime/Arguments.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::put):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::put):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::put):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::put):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::put):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::put):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):

  • runtime/JSStaticScopeObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::put):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::put):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::put):

  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::put):

  • runtime/StringObject.h:

Source/JavaScriptGlue:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

  • UserObjectImp.cpp:

(UserObjectImp::put):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::put):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::put):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::put):

  • bridge/runtime_object.h:
16:58 Changeset [96991] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=69471

We now wrap the window script NPObject which is requested by NPAPI plugins for
scripting. The wrapped NPObject pointer maintains a weak reference to the
window script NPObject and is cleared out when the window script object is destroyed.
The NPObject wrapper is destroyed when the last outstanding reference is released.

Reviewed by Nate Chapin.

No tests added as there is no change in functionality.

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2011-10-07

  • WebCore.gypi:
  • bindings/v8/NPObjectWrapper.cpp: Added.

(WebCore::NPObjectWrapper::NPObjectWrapper):
(WebCore::NPObjectWrapper::create):
(WebCore::NPObjectWrapper::clear):
(WebCore::NPObjectWrapper::getWrapper):
(WebCore::NPObjectWrapper::getUnderlyingNPObject):
(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):
(WebCore::NPObjectWrapper::NPDeallocate):
(WebCore::NPObjectWrapper::NPPInvalidate):
(WebCore::NPObjectWrapper::NPHasMethod):
(WebCore::NPObjectWrapper::NPInvoke):
(WebCore::NPObjectWrapper::NPInvokeDefault):
(WebCore::NPObjectWrapper::NPHasProperty):
(WebCore::NPObjectWrapper::NPGetProperty):
(WebCore::NPObjectWrapper::NPSetProperty):
(WebCore::NPObjectWrapper::NPRemoveProperty):
(WebCore::NPObjectWrapper::NPNEnumerate):
(WebCore::NPObjectWrapper::NPNConstruct):
(WebCore::NPObjectWrapper::NPInvokePrivate):

  • bindings/v8/NPObjectWrapper.h: Added.
  • bindings/v8/NPV8Object.cpp:

(_NPN_EvaluateHelper):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):

  • bindings/v8/ScriptController.h:
16:38 Changeset [96990] by commit-queue@webkit.org

Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-07
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Added.

(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • public/WebContentLayerClient.h: Added.

(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • public/WebLayer.h: Added.

(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerClient.h: Added.

(WebKit::WebLayerClient::~WebLayerClient):

  • public/WebLayerTreeView.h: Added.

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebLayerTreeViewClient.h: Added.

(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • src/WebContentLayer.cpp: Added.

(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):

  • src/WebContentLayerImpl.cpp: Added.

(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):

  • src/WebContentLayerImpl.h: Added.
  • src/WebLayer.cpp: Added.

(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):

  • src/WebLayerImpl.cpp: Added.

(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):

  • src/WebLayerImpl.h: Added.
  • src/WebLayerTreeView.cpp: Added.

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):

  • src/WebLayerTreeViewImpl.cpp: Added.

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h: Added.
16:38 Changeset [96989] by abarth@webkit.org

Add a Content-Security-Policy to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69668

Reviewed by David Levin.

This will help mitigate cross-site script and will also help us dogfood CSP.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
16:38 Changeset [96988] by barraclough@apple.com

Refactor DFG to make for use of callOperation
https://bugs.webkit.org/show_bug.cgi?id=69672

Reviewed by Oliver Hunt.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • Added new callOperation calls, don't ASSERT flushed (use helpers for unexpected calls, too).
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Switch operationNewObject/operationCreateThis to return Cells,
    • Added C_DFGOperation_E/C_DFGOperation_EC/J_DFGOperation_EA/J_DFGOperation_EJA call types.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • Replace code plating calls to operations to with calls to callOperation.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • Replace code plating calls to operations to with calls to callOperation.
16:29 Changeset [96987] by commit-queue@webkit.org

CSS text-transform should apply to select elements
https://bugs.webkit.org/show_bug.cgi?id=69503

Patch by Ben Wells <benwells@chromium.org> on 2011-10-07
Reviewed by Ojan Vafai.

Source/WebCore:

Select elements are drawn in two ways depending on whether they are multiple and what their size is.
Neither method previously handled text-transforms. Both of these rendering styles are now updated to transform
their text correctly.

Test: fast/css/text-transform-select.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setText):
(WebCore::RenderMenuList::itemText):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::applyTextTransform):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::textWithoutTranscoding):

  • rendering/RenderText.h:

LayoutTests:

  • fast/css/text-transform-select-expected.txt: Added.
  • fast/css/text-transform-select.html: Added.
  • platform/chromium-linux/fast/css/text-transform-select-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:20 Changeset [96986] by commit-queue@webkit.org

First round of unit tests for CCLayerTreeHostCommon.
https://bugs.webkit.org/show_bug.cgi?id=69197

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-07
Reviewed by James Robinson.

This round of tests focuses on verifying the computation of matrix transforms
in calculateDrawTransformsAndVisibility.

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp: Added.

(WebCore::setLayerPropertiesForTesting):
(WebCore::executeCalculateDrawTransformsAndVisibility):
(WebCore::remove3DComponentOfMatrix):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(WebCore::TEST):

16:18 Changeset [96985] by tony@chromium.org

fix a crash when loading non-html multipart data
https://bugs.webkit.org/show_bug.cgi?id=69675

Reviewed by Adam Barth.

Source/WebCore:

setupForReplaceByMIMEType calls DocumentWriter::end(). This leads to
a crash on Mac because WebHTMLRepresentation() calls commitLoad(nil),
which tries to write to the DocumentWriter. By just inlining the code
to load the last page, we avoid this crash (and makes the non-html
multipart code more like the html multipart code).

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):

LayoutTests:

  • http/tests/multipart/load-last-non-html-frame.php: Ensure same output on Apple Mac and Chromium (was getting different number of trailing new lines).
16:00 Changeset [96984] by commit-queue@webkit.org

XSLT-generated document should inherit its SecurityOrigin from the source document
https://bugs.webkit.org/show_bug.cgi?id=69661

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-07
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml

  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

  • http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added.
  • http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml: Added.
15:11 Changeset [96983] by oliver@apple.com

Support string indexing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69671

Reviewed by Gavin Barraclough.

Emit code to support inline indexing of strings

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

Shared code to perform string indexing.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Use compileGetByValOnString if we predict that the base object
is a string in GetByVal.

  • runtime/JSString.h:

(JSC::JSString::offsetOfFiberCount):
(JSC::JSString::offsetOfValue):

15:11 BuildingOnWindows edited by rniwa@webkit.org
Add a link to … (diff)
15:00 Changeset [96982] by bfulgham@webkit.org

[WinCairo] Unreviewed Skiplist update to get WinCairo bot green.

  • platform/wincairo/Skipped: Skip a few failing test categories.
14:30 Changeset [96981] by rniwa@webkit.org

Re-enable a test fixed by r93529.

  • platform/win/Skipped:
13:52 Changeset [96980] by fpizlo@apple.com

DFG ConvertThis speculation logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=69663

Reviewed by Oliver Hunt.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:43 Changeset [96979] by ap@apple.com

[Mac] Scrollbars in embedded PDFs should update when system preferences change
https://bugs.webkit.org/show_bug.cgi?id=69654

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h: Added an scrollbarStyleChanged() override. ScrollAnimatorMac sets scrollbar frame to a bogus (0, 0, thickness, thickness) one when style changes, and expects clients to move them back in place.
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::isOnActivePage): Fixed a typo that prevented ScrollAnimatorMac from updating style of PDF view scrollbars. (WebKit::BuiltInPDFView::scrollbarStyleChanged): Reposition scrollbars and content after style change. The behavior is not perfect in edge cases, but roughly matches ScrollView.
13:27 Changeset [96978] by oliver@apple.com

2011-10-07 Oliver Hunt <oliver@apple.com>

Verify that our call speculation is valid.

Reviewed by Filip Pizlo.

Before specialising an intrinsic we need to verify that
we our speculation is correct.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
13:24 Changeset [96977] by bfulgham@webkit.org

[WinCairo] Unreviewed build correction for the build bot.

Release_Cairo_CFLite and Debug_Cairo_CFLite targets so that
build-jsc can find the target it needs to run the JSC tests.

13:23 Changeset [96976] by commit-queue@webkit.org

Unreviewed, rolling out r96944.
http://trac.webkit.org/changeset/96944
https://bugs.webkit.org/show_bug.cgi?id=69662

Caused many tests to crash on Snow Leopard (Requested by rniwa
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

  • platform/graphics/Color.h:

(WebCore::Color::Color):

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

13:15 Changeset [96975] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=69658

[CSS3 Regions] Box painting of overflow into regions is incorrect because children were being
incorrectly clamped to their containing block region ranges. Change the clamping model so that
renderRegionForLine no longer does it. A block will now truly have an accurate range across
all the regions that paint it. Instead, do the clamping at the time a child box asks the containing
block for its information. At that time clamp to the start and end regions, so that we never ask
a containing block for info about a region that it doesn't exist in.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new test in fast/regions and updated an old result to be correct.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::clampToStartAndEndRegions):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:

LayoutTests:

  • fast/regions/bottom-overflow-out-of-first-region.html: Added.
  • fast/regions/top-overflow-out-of-second-region.html:
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
13:05 Changeset [96974] by commit-queue@webkit.org

Remove compile time flag ENABLE_PASSWORD_ECHO
https://bugs.webkit.org/show_bug.cgi?id=69647

Source/WebCore:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

  • config.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

Source/WebKit/qt:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

LayoutTests:

WK2 tests are passing after r96740 (bug 68924).

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

  • platform/wk2/Skipped:
12:45 Changeset [96973] by cfleizach@apple.com

Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
https://bugs.webkit.org/show_bug.cgi?id=69562

Source/WebCore:

Some fake objects, like AXImageMapLink, have weak references to their parent's (since they are fake objects and
need some connection to the parent). However, if the parent disappears before the child, then we're left with a
out of date reference to that parent.

The fix is to allow these elements to clear their parentage when the parent goes away.

Reviewed by Darin Adler.

Test: accessibility/image-map-update-parent-crash.html

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isVisible):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clearChildren):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObjectForSection):

LayoutTests:

Reviewed by Darin Adler.

  • accessibility/image-map-update-parent-crash-expected.txt: Added.
  • accessibility/image-map-update-parent-crash.html: Added.
12:32 Changeset [96972] by commit-queue@webkit.org

Pack StyleRareNonInheritedData even harder on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69648

Patch by Andreas Kling <kling@webkit.org> on 2011-10-07
Reviewed by Benjamin Poulain.

Rearrange the members of StyleRareNonInheritedData to fold as much
as possible into the padding at the end of RefCounted.

This shrinks StyleRareNonInheritedData by 16 bytes on 64-bit,
reducing memory consumption by another 140 kB when loading the
full HTML5 spec.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

  • rendering/style/StyleRareNonInheritedData.h:
12:28 Changeset [96971] by rniwa@webkit.org

Chromium rebaseline. The test started to pass after r96873.

  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-006-expected.png: Added.
  • platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
  • platform/chromium/test_expectations.txt:
12:26 Changeset [96970] by caryclark@google.com

Source/WebCore: Enable color profiles, unless profile is grayscale
https://bugs.webkit.org/show_bug.cgi?id=69622
https://bugs.webkit.org/show_bug.cgi?id=49950
http://code.google.com/p/chromium/issues/detail?id=80844

Further specialize the earlier fix described in 49950 to
allow color profiles in YCbCr images, but disallow color
profiles marked as grayData.
(see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )

Reviewed by Adam Barth.

Test: fast/images/gray-scale-jpeg-with-color-profile.html

fast/images/color-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readColorProfile):
(WebCore::JPEGImageReader::decode):

LayoutTests: Reviewed by Adam Barth.

Add a image with a color profile that's not gray.
https://bugs.webkit.org/show_bug.cgi?id=69622

Test that we properly render JPEGs with embedded non-gray color profiles.

  • fast/images/color-jpeg-with-color-profile.html: Added.
  • fast/images/resources/icc-v2-gbr.jpg: Added.
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
12:25 Changeset [96969] by ossy@webkit.org

Unreviewed, rolling out r96938.
http://trac.webkit.org/changeset/96938
https://bugs.webkit.org/show_bug.cgi?id=69653

It broke zillion tests and make testing so slow (Requested by
ossy_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebKit2:

  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::applicationCacheDirectory):

LayoutTests:

  • platform/qt-wk2/Skipped:
12:23 Changeset [96968] by ossy@webkit.org

Unreviewed gardening after r96958.

  • platform/qt/test_expectations.txt: Remove a file, because it is skipped too.
12:17 Changeset [96967] by simonjam@chromium.org

[Chromium] Rebaseline test after r96870.

Unreviewed.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-cg-mac/editing/pasteboard/merge-end-blockquote-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Removed.
12:12 Changeset [96966] by cfleizach@apple.com

AX: re-organize fake elements to use new AccessibilityMockObject
https://bugs.webkit.org/show_bug.cgi?id=69588

This adds an AccessibilityMockObject for "fake" elements to descend from.
Its benefit is to consolidate the various ways that these fake elements are setting
and returning their parent objects.

No functional change, hence no new tests.

Reviewed by Jon Honeycutt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):

  • accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::node):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::addChildren):

  • accessibility/AccessibilityMenuList.h:

(WebCore::toAccessibilityMenuList):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
(WebCore::AccessibilityMenuListOption::isVisible):

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityMockObject.cpp: Added.

(WebCore::AccessibilityMockObject::AccessibilityMockObject):
(WebCore::AccessibilityMockObject::~AccessibilityMockObject):

  • accessibility/AccessibilityMockObject.h: Added.

(WebCore::AccessibilityMockObject::parentObject):
(WebCore::AccessibilityMockObject::setParent):
(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::addChildren):
(WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):

  • accessibility/AccessibilityTable.h:

(WebCore::toAccessibilityTable):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::setParent):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::headerObjectForSection):
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
(WebCore::AccessibilityTableColumn::addChildren):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/AccessibilityTableHeaderContainer.h:
11:57 Changeset [96965] by oliver@apple.com

Fix 32-bit build.

11:55 Changeset [96964] by tony@chromium.org

Fix chromium compile when using the components build. This test
helper file is using methods not available when compiling as a dll.

  • WebKit.gyp:
11:47 Changeset [96963] by rniwa@webkit.org

REGRESSION(r96257): fast/repaint/selection-clear.html fail
https://bugs.webkit.org/show_bug.cgi?id=69060

Reviewed by Enrica Casucci.

After r96257, we no longer clear selection upon node removal so the selection should
still be rendered after the node removal in this test.

Changed the color of selection from red to green to indicate the success.

  • fast/repaint/selection-clear.html:
  • platform/mac/fast/repaint/selection-clear-expected.png:
11:39 Changeset [96962] by oliver@apple.com

Support direct calls to intrinsic functions
https://bugs.webkit.org/show_bug.cgi?id=69646

Reviewed by Gavin Barraclough.

Add support for optimising non-method_check calls
to intrinsic functions (eg. when Math.abs, etc are
cached in local variables).

  • bytecode/CodeBlock.h:

(JSC::getCallLinkInfoBytecodeIndex):

Support searching CallLinkInfos by bytecode index

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Add support for linked calls in addition to method_check
when searching for intrinsics

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::function):

Add ability to store a JSFunction* in a node - this is safe
as the function will be marked by the codeblock we're compiling

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::checkFunctionElimination):
(JSC::DFG::Propagator::performNodeCSE):

Add support for new CheckFunction node, and implement CSE pass.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Rather trivial implementation of CheckFunction

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

Need to propagate bytecode index for calls now.

11:16 Changeset [96961] by japhet@chromium.org

Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
This is one of the steps required to remove the SubresourceLoaderClient interface,
which will simplify the layering in the loader.
https://bugs.webkit.org/show_bug.cgi?id=69567

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedRawResource.cpp: Added.
  • loader/cache/CachedRawResource.h: Added.
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),

which was only used to decided whether the CachedResource should count toward
CachedResourceLoader::requestCount().

  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cache/CachedResourceRequest.h:
  • loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.

(WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),

since we won't be checking any callbacks before the load completes.

  • loader/icon/IconLoader.h:
11:14 Changeset [96960] by simonjam@chromium.org

[Chromium] Update test_expectations after V8 roll.

Unreviewed.

  • platform/chromium/test_expectations.txt:
11:06 Changeset [96959] by commit-queue@webkit.org

Add WebCore platform interfaces needed by updated PeerConnection design
https://bugs.webkit.org/show_bug.cgi?id=68460

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-07
Reviewed by Adam Barth.

Added the PeerConnection platform files to WebCore/platform/mediastream

Currently not testable.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/mediastream/MediaStreamComponent.h: Added.

(WebCore::MediaStreamComponent::create):
(WebCore::MediaStreamComponent::source):
(WebCore::MediaStreamComponent::enabled):
(WebCore::MediaStreamComponent::setEnabled):
(WebCore::MediaStreamComponent::MediaStreamComponent):

  • platform/mediastream/MediaStreamDescriptor.h: Added.

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):
(WebCore::MediaStreamDescriptor::label):
(WebCore::MediaStreamDescriptor::component):
(WebCore::MediaStreamDescriptor::numberOfComponents):
(WebCore::MediaStreamDescriptor::ended):
(WebCore::MediaStreamDescriptor::setEnded):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

  • platform/mediastream/MediaStreamSource.h: Added.

(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::id):
(WebCore::MediaStreamSource::type):
(WebCore::MediaStreamSource::name):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):

  • platform/mediastream/PeerHandler.cpp: Added.

(WebCore::PeerHandler::PeerHandler):
(WebCore::PeerHandler::~PeerHandler):
(WebCore::PeerHandler::produceInitialOffer):
(WebCore::PeerHandler::handleInitialOffer):
(WebCore::PeerHandler::processSDP):
(WebCore::PeerHandler::processPendingStreams):
(WebCore::PeerHandler::sendDataStreamMessage):
(WebCore::PeerHandler::stop):

  • platform/mediastream/PeerHandler.h: Added.

(WebCore::PeerHandlerClient::~PeerHandlerClient):
(WebCore::PeerHandler::create):

10:44 Changeset [96958] by commit-queue@webkit.org

background-color affects the font color in disabled textarea.
https://bugs.webkit.org/show_bug.cgi?id=65361

Patch by Vineet Chaudary <vineet.chaudhary@motorola.com> on 2011-10-07
Reviewed by Darin Adler.

Source/WebCore:

For the transparent/translucent background colors use lightening fortext color.

  • rendering/RenderTextControl.cpp:

(WebCore::disabledTextColor):

LayoutTests:

For the background-color White and transparent the text color should be same.

  • fast/forms/input-disabled-color.html: Modified test case.
  • platform/chromium/test_expectations.txt: Needs rebaseline.
  • platform/gtk/fast/forms/input-disabled-color-expected.png: Changed expected result.
  • platform/gtk/fast/forms/input-disabled-color-expected.txt: Changed expected result.
  • platform/mac/test_expectations.txt: Needs rebaseline.
  • platform/qt/test_expectations.txt: Needs rebaseline.
  • platform/win/test_expectations.txt: Needs rebaseline.
10:33 Changeset [96957] by inferno@chromium.org

Merge 96610 - Resource loader should block HTTP redirects to local resources

BUG=95374
Review URL: http://codereview.chromium.org/8198008

10:20 Changeset [96956] by abarth@webkit.org

Add missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
https://bugs.webkit.org/show_bug.cgi?id=66236

Reviewed by Darin Adler.

These APIs are all very new and everyone who's using them should be
aware that they are vendor-prefixed and subject to adjustments as the
spec evolves. Recently, we changed these APIs to more carefully check
whether required parameters are actually present. This patch adds
tests to verify that we're doing the proper checks.

  • fast/files/not-enough-arguments-expected.txt: Added.
  • fast/files/not-enough-arguments.html: Added.
  • fast/filesystem/not-enough-arguments-expected.txt: Added.
  • fast/filesystem/not-enough-arguments.html: Added.
10:19 Changeset [96955] by inferno@chromium.org

Merge 96632 - Source/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.

BUG=96902
Review URL: http://codereview.chromium.org/8206006

10:12 Changeset [96954] by inferno@chromium.org

Merge 96707 - Crash in SVGTRefElement::updateReferencedText.

BUG=95359
Review URL: http://codereview.chromium.org/8203008

10:02 Changeset [96953] by inferno@chromium.org

Merge 96427 - <rdar://problem/10208291> first-letter in generated before content with display: table is not updated

BUG=96427
Review URL: http://codereview.chromium.org/8201005

10:00 Changeset [96952] by commit-queue@webkit.org

Implement currentColor support for box-shadow and text-shadow
https://bugs.webkit.org/show_bug.cgi?id=68218

Source/WebCore:

Patch by David Barr <davidbarr@chromium.org> on 2011-10-07
Reviewed by Simon Fraser.

Test: fast/box-shadow/box-shadow-currentcolor.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Add CSSValueCurrentcolor to supported keywords.

LayoutTests:

Patch by David Barr <davidbarr@google.com> on 2011-10-07
Reviewed by Simon Fraser.

  • fast/box-shadow/box-shadow-currentcolor-expected.png: Added.
  • fast/box-shadow/box-shadow-currentcolor-expected.txt: Added.
  • fast/box-shadow/box-shadow-currentcolor.html: Added.
09:59 Changeset [96951] by inferno@chromium.org

Merge 96826 - Add check for JavaScript URLs in HTMLPlugInImageElement::allowedToLoadFrameURL

BUG=98053
Review URL: http://codereview.chromium.org/8206005

09:45 Changeset [96950] by inferno@chromium.org

Merge 96834 - <rdar://problem/10232866> Assertion failure beneath blockSelectionGaps() when a selected node is removed

BUG=99104
Review URL: http://codereview.chromium.org/8200004

09:44 Changeset [96949] by pfeldman@chromium.org

Web Inspector: add Audits panel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69633

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/AuditCategories.js:
  • inspector/front-end/AuditLauncherView.js:
  • inspector/front-end/AuditResultView.js:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/NetworkLog.js:
  • inspector/front-end/treeoutline.js:
09:43 Changeset [96948] by inferno@chromium.org

Merge 96868 - Crash in VisiblePosition::canonicalPosition.

BUG=99138
Review URL: http://codereview.chromium.org/8199007

09:42 Changeset [96947] by andreas.kling@nokia.com

Functions that return "const Color" should simply return "Color".

Rubber-stamped by Antti Koivisto.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::rendererBackgroundColor):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderTable.h:

(WebCore::RenderTable::bgColor):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:
09:35 Changeset [96946] by abarth@webkit.org

Remove setShouldPaintCustomScrollbars, which has no callers
https://bugs.webkit.org/show_bug.cgi?id=69300

Reviewed by Darin Adler.

Anders tells me this function no longer has any callers. We should
remove it before it grows any!

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
09:33 Changeset [96945] by pfeldman@chromium.org

Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
https://bugs.webkit.org/show_bug.cgi?id=69634

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):

09:24 Changeset [96944] by andreas.kling@nokia.com

Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521

Reviewed by Antti Koivisto.

Unroll BorderValue's Color member so we can pack the color's validity flag
in BorderValue's bitfield.

This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
16 bytes. This reduces memory consumption by 760 kB when loading the full
HTML5 spec.

  • platform/graphics/Color.h:

(WebCore::Color::Color):

Allow construction of Color objects with specific validity.

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
Made those variables private and added color(), setColor() accessors.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):

Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
when setting BorderValue colors.

(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

Made color getters return "Color" instead of "const Color&" since
BorderValue no longer has an actual object to return the reference to.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

Adapt to RenderStyle color getters now returning "Color" instead of
"const Color&".

09:22 Changeset [96943] by commit-queue@webkit.org

[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=66380

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-07
Reviewed by Antonio Gomes.

This encapsulates EWebKit into an object that manages multiple windows
and provides a cleaner interface to EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.

(DumpRenderTreeChrome::create):
(DumpRenderTreeChrome::DumpRenderTreeChrome):
(DumpRenderTreeChrome::~DumpRenderTreeChrome):
(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::removeWindow):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::extraViews):
(DumpRenderTreeChrome::mainFrame):
(DumpRenderTreeChrome::mainView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onStatusbarTextSet):
(DumpRenderTreeChrome::onTitleChanged):
(DumpRenderTreeChrome::onDocumentLoadFinished):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
  • DumpRenderTree/efl/EventSender.cpp:

(sendClick): Use browser->mainFrame() instead of mainFrame.
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
(mouseMoveToCallback): Ditto.
(mouseScrollByCallback): Ditto.
(keyDownCallback): Ditto.
(scalePageByCallback): Ditto.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::counterValueForElementById): Use
browser->mainFrame() instead of mainFrame.
(LayoutTestController::pageNumberForElementById): Ditto.
(LayoutTestController::numberOfPages): Ditto.
(LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
(LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
(LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
(LayoutTestController::numberOfActiveAnimations): Ditto.
(LayoutTestController::suspendAnimations): Ditto.
(LayoutTestController::resumeAnimations): Ditto.
(LayoutTestController::setWebViewEditable): Ditto.
(LayoutTestController::webHistoryItemCount): Use browser->mainView()
instead of browser.
(LayoutTestController::queueLoad): Ditto.
(LayoutTestController::setAcceptsEditing): Ditto.
(LayoutTestController::setUserStyleSheetEnabled): Ditto.
(LayoutTestController::setPrivateBrowsingEnabled): Ditto.
(LayoutTestController::setFrameFlatteningEnabled): Ditto.
(LayoutTestController::setSpatialNavigationEnabled): Ditto.
(LayoutTestController::setPluginsEnabled): Ditto.
(LayoutTestController::findString): Ditto.
(LayoutTestController::setDeveloperExtrasEnabled): Ditto.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView): Use browser->mainFrame() instead of
mainFrame.

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke): Ditto.
(LoadHTMLStringItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.
(ReloadItem::invoke): Use browser->mainView() instead of browser.

09:16 Changeset [96942] by philn@webkit.org

[GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
https://bugs.webkit.org/show_bug.cgi?id=69630

Reviewed by Martin Robinson.

Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
replace use of gst_ghost_pad_new_no_target_from_template() and
gst_ghost_pad_set_target() with a single call to
gst_ghost_pad_new_from_template(). These changes keep the element
compatible with GStreamer 0.10 while preparing the port to 0.11.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_class_init):
(webkit_web_src_init):

08:51 Changeset [96941] by commit-queue@webkit.org

[Freetype] Pseudo-italics do not work
https://bugs.webkit.org/show_bug.cgi?id=40856

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-07
Reviewed by Philippe Normand.

Source/WebCore:

  • platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
(WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
given one that wasn't oblique or italic, activate the synthetic oblique bit.

LayoutTests:

Add test results which show this test passing now.

  • platform/gtk/Skipped: Unskip a passing test.
  • platform/gtk/fast/text/fake-italic-expected.png: Added.
  • platform/gtk/fast/text/fake-italic-expected.txt: Added.
08:47 Changeset [96940] by philn@webkit.org

[GStreamer] avoid direct access to GstMessage structure field
https://bugs.webkit.org/show_bug.cgi?id=69629

Reviewed by Martin Robinson.

Use gst_message_get_structure() instead of direct access to the
structure field. No direct benefit apart from compatibility with
GStreamer 0.11.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::gstGWorldSyncMessageCallback):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):

08:36 Changeset [96939] by pfeldman@chromium.org

Web Inspector: add timeline panel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69628

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/SidebarTreeElement.js:

(WebInspector.SidebarTreeElement):

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js:

(WebInspector.SourceHTMLTokenizer.prototype.nextToken):

  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/TimelineGrid.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.updateMainViewWidth):
(WebInspector.TimelinePanel.prototype.onResize):
(WebInspector.TimelinePanel.prototype._windowChanged):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineRecordGraphRow.prototype._onClick):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

08:09 Changeset [96938] by qi.2.zhang@nokia.com

[Qt][WK2] ApplicationCache LayoutTests failed
https://bugs.webkit.org/show_bug.cgi?id=69541

Reviewed by Chang Shu.

Source/WebKit2:

  1. Moved applicationCacheDirectory to common code.
  2. Added interface setApplicationCacheDirectory to allow UI client overriding.
  3. Renamed all platform-dependent implementations of applicationCacheDirectory to platformDefaultApplicationCacheDirectory.
  4. On Qt, set the platformDefaultApplicationCacheDirectory to the default data location.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setApplicationCacheDirectory):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

LayoutTests:

Unskip passed tests.

  • platform/qt-wk2/Skipped:
07:56 Changeset [96937] by podivilov@chromium.org

Unreviewed, rolling out r96892.
http://trac.webkit.org/changeset/96892
https://bugs.webkit.org/show_bug.cgi?id=69626

it broke windows canary bots (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

  • WebCore.gyp/scripts/rule_binding.py:
07:49 Changeset [96936] by dominicc@chromium.org

[JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
https://bugs.webkit.org/show_bug.cgi?id=69599

Reviewed by Sam Weinig.

DFG JIT manipulates MetaAllocatorHandles across threads, eg in
allocating JITCode buffers on a background thread to execute a
proxy autoconfiguration PAC file but garbage collecting it in
response to allocation on the main thread. Disabling
ThreadRestrictionVerification until there is a verification scheme
that understands this handoff.

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::allocate):

07:28 Changeset [96935] by andreas.kling@nokia.com

Shrink StyleInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69625

Reviewed by Antti Koivisto.

Rearrange the members of StyleInheritedData to fold as much
as possible into the padding at the end of RefCounted.

This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
memory consumption by 500 kB when loading the full HTML5 spec.

  • rendering/style/StyleInheritedData.cpp:

(WebCore::StyleInheritedData::StyleInheritedData):

  • rendering/style/StyleInheritedData.h:
07:18 Changeset [96934] by philn@webkit.org

Unreviewed, skip failing svg test in GTK.

  • platform/gtk/Skipped: Skip svg/filters/feColorMatrix-saturate.svg
07:08 Changeset [96933] by philn@webkit.org

Unreviewed, skip http/tests/multipart/load-last-non-html-frame.php in GTK.

  • platform/gtk/Skipped:
06:55 Changeset [96932] by pfeldman@chromium.org

Web Inspector: make ScriptsPanel compile
https://bugs.webkit.org/show_bug.cgi?id=69623

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/Object.js:
  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

  • inspector/front-end/StatusBarButton.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update.appendResult):
(WebInspector.WatchExpressionsSection.prototype.update):
(WebInspector.WatchExpressionTreeElement.prototype.startEditing):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.WorkerManager.prototype._pageInspectorClosing):
(WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane.prototype.removeWorker):

  • inspector/front-end/externs.js:

(WebInspector.linkifyURL):
(InjectedFakeWorker):

  • inspector/front-end/inspector.js:
06:38 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
05:34 Changeset [96931] by hausmann@webkit.org

[Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
https://bugs.webkit.org/show_bug.cgi?id=69617

Reviewed by Andreas Kling.

Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
logic.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
05:17 Changeset [96930] by podivilov@chromium.org

Unreviewed, rolling out r96879.
http://trac.webkit.org/changeset/96879
https://bugs.webkit.org/show_bug.cgi?id=69618

Broke CCLayerTreeHostTestShortlived1 on chromium mac.
(Requested by podivilov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):

04:35 Changeset [96929] by pfeldman@chromium.org

Web Inspector: add ResourcesPanel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69612

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/ResourceView.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.StorageCategoryView):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.last):

  • inspector/front-end/externs.js:

(WebInspector.openRequestInNetworkPanel):

04:11 Changeset [96928] by zoltan@webkit.org

[Qt] http/tests/multipart/load-last-non-html-frame.php is failing
https://bugs.webkit.org/show_bug.cgi?id=69615

Ossyize failing test.

  • platform/qt/Skipped:
03:59 Changeset [96927] by podivilov@chromium.org

Unreviewed, rolling out r96909.
http://trac.webkit.org/changeset/96909
https://bugs.webkit.org/show_bug.cgi?id=69616

Broke chromium mac compilation (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContentLayer.h: Removed.
  • public/WebContentLayerClient.h: Removed.
  • public/WebLayer.h: Removed.
  • public/WebLayerClient.h: Removed.
  • public/WebLayerTreeView.h: Removed.
  • public/WebLayerTreeViewClient.h: Removed.
  • src/WebContentLayer.cpp: Removed.
  • src/WebContentLayerImpl.cpp: Removed.
  • src/WebContentLayerImpl.h: Removed.
  • src/WebLayer.cpp: Removed.
  • src/WebLayerImpl.cpp: Removed.
  • src/WebLayerImpl.h: Removed.
  • src/WebLayerTreeView.cpp: Removed.
  • src/WebLayerTreeViewImpl.cpp: Removed.
  • src/WebLayerTreeViewImpl.h: Removed.
03:54 Changeset [96926] by podivilov@chromium.org

2011-10-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, revert r96924.

  • public/WebContentLayer.h:
03:19 Changeset [96925] by vsevik@chromium.org

Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
https://bugs.webkit.org/show_bug.cgi?id=69558

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
03:12 Changeset [96924] by podivilov@chromium.org

2011-10-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix mac build after r96909.

  • public/WebContentLayer.h:
02:53 Changeset [96923] by annacc@chromium.org

Turn ENABLE_VIDEO_TRACK on for chromium.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

  • features.gypi:
02:51 Changeset [96922] by mario@webkit.org

[GTK] Don't expose objects with unknown role on GTK
https://bugs.webkit.org/show_bug.cgi?id=69561

Reviewed by Chris Fleizach.

Source/WebCore:

Ignore accessibility objects in accessibilityPlatformIncludesObject.

Test: platform/gtk/accessibility/unknown-roles-not-exposed.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
For unknown accessibility objects, return IgnoreObject.

LayoutTests:

New test to check that unknown objects are not exposed in GTK.

  • platform/gtk/accessibility/unknown-roles-not-exposed-expected.txt: Added.
  • platform/gtk/accessibility/unknown-roles-not-exposed.html: Added.

Added new expectation for new accessibility layout test introduced
in r96127 that was not possible to add before because of this bug.

  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
02:35 Changeset [96921] by philn@webkit.org

Unreviewed, GTK baselines for
security/redirect-BLOCKED-to-localURL.html test.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.
02:33 Changeset [96920] by loislo@chromium.org

Web Inspector: UI performance test for logging 100 messages to the console.
https://bugs.webkit.org/show_bug.cgi?id=69608

Reviewed by Pavel Feldman.

  • inspector/performance/resources/console-append-100-lines.html: Added.
02:27 Changeset [96919] by pfeldman@chromium.org

2011-10-07 Pavel Feldman <pfeldman@google.com>

Not reviewed: also add glass pane to the frame document's body.

  • src/js/DevTools.js:
02:19 Changeset [96918] by tkent@chromium.org

Move <input type=file> tests to fast/forms/file/
https://bugs.webkit.org/show_bug.cgi?id=69504

Reviewed by Hajime Morita.

  • fast/forms/file-input-change-event-expected.txt: Removed.
  • fast/forms/file-input-change-event.html: Removed.
  • fast/forms/file-input-direction.html: Removed.
  • fast/forms/file-input-disabled.html: Removed.
  • fast/forms/file-input-hit-test-expected.txt: Removed.
  • fast/forms/file-input-hit-test.html: Removed.
  • fast/forms/file-input-reset-expected.html: Removed.
  • fast/forms/file-input-reset.html: Removed.
  • fast/forms/file/file-input-change-event-expected.txt: Copied from LayoutTests/fast/forms/file-input-change-event-expected.txt.
  • fast/forms/file/file-input-change-event.html: Copied from LayoutTests/fast/forms/file-input-change-event.html.
  • fast/forms/file/file-input-direction.html: Copied from LayoutTests/fast/forms/file-input-direction.html.
  • fast/forms/file/file-input-disabled.html: Copied from LayoutTests/fast/forms/file-input-disabled.html.
  • fast/forms/file/file-input-hit-test-expected.txt: Copied from LayoutTests/fast/forms/file-input-hit-test-expected.txt.
  • fast/forms/file/file-input-hit-test.html: Copied from LayoutTests/fast/forms/file-input-hit-test.html.
  • fast/forms/file/file-input-reset-expected.html: Copied from LayoutTests/fast/forms/file-input-reset-expected.html.
  • fast/forms/file/file-input-reset.html: Copied from LayoutTests/fast/forms/file-input-reset.html.
  • fast/forms/file/get-file-upload-expected.txt: Copied from LayoutTests/fast/forms/get-file-upload-expected.txt.
  • fast/forms/file/get-file-upload.html: Copied from LayoutTests/fast/forms/get-file-upload.html.
  • fast/forms/file/hidden-input-file-expected.html: Copied from LayoutTests/fast/forms/hidden-input-file.html.
  • fast/forms/file/hidden-input-file.html: Copied from LayoutTests/fast/forms/hidden-input-file.html.
  • fast/forms/file/input-file-directory-upload-expected.txt: Copied from LayoutTests/fast/forms/input-file-directory-upload-expected.txt.
  • fast/forms/file/input-file-directory-upload.html: Copied from LayoutTests/fast/forms/input-file-directory-upload.html.
  • fast/forms/file/input-file-label-expected.txt: Copied from LayoutTests/fast/forms/input-file-label-expected.txt.
  • fast/forms/file/input-file-label.html: Copied from LayoutTests/fast/forms/input-file-label.html.
  • fast/forms/file/input-file-not-open-without-gesture-expected.txt: Copied from LayoutTests/fast/forms/input-file-not-open-without-gesture-expected.txt.
  • fast/forms/file/input-file-not-open-without-gesture.html: Copied from LayoutTests/fast/forms/input-file-not-open-without-gesture.html.
  • fast/forms/file/input-file-re-render.html: Copied from LayoutTests/fast/forms/input-file-re-render.html.
  • fast/forms/get-file-upload-expected.txt: Removed.
  • fast/forms/get-file-upload.html: Removed.
  • fast/forms/hidden-input-file.html: Removed.
  • fast/forms/input-file-directory-upload-expected.txt: Removed.
  • fast/forms/input-file-directory-upload.html: Removed.
  • fast/forms/input-file-label-expected.txt: Removed.
  • fast/forms/input-file-label.html: Removed.
  • fast/forms/input-file-not-open-without-gesture-expected.txt: Removed.
  • fast/forms/input-file-not-open-without-gesture.html: Removed.
  • fast/forms/input-file-re-render.html: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/file: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/file-input-direction-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/file: Added.
  • platform/chromium-cg-mac/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-direction-expected.png.
  • platform/chromium-cg-mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-disabled-expected.png.
  • platform/chromium-cg-mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-cg-mac/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-linux/fast/forms/file: Added.
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-linux/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-direction-expected.png.
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.png.
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.txt.
  • platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-linux/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.txt.
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/file: Added.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.png.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-mac/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/chromium-mac/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-win/fast/forms/file: Added.
  • platform/chromium-win/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-win/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-win/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/chromium-win/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/chromium-win/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-direction-expected.png.
  • platform/chromium-win/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-direction-expected.txt.
  • platform/chromium-win/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.png.
  • platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.txt.
  • platform/chromium-win/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.png.
  • platform/chromium-win/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.txt.
  • platform/chromium-win/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/chromium-win/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/file: Added.
  • platform/gtk/fast/forms/file-input-direction-expected.png: Removed.
  • platform/gtk/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/gtk/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/gtk/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/gtk/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/file-input-direction-expected.png.
  • platform/gtk/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/file-input-direction-expected.txt.
  • platform/gtk/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/file-input-disabled-expected.png.
  • platform/gtk/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/file-input-disabled-expected.txt.
  • platform/gtk/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.png.
  • platform/gtk/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt.
  • platform/gtk/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/gtk/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/gtk/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/file: Added.
  • platform/mac-leopard/fast/forms/file-input-direction-expected.png: Removed.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-direction-expected.png.
  • platform/mac-leopard/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.png.
  • platform/mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
  • platform/mac-leopard/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-file-re-render-expected.png.
  • platform/mac-leopard/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/mac/Skipped:
  • platform/mac/fast/forms/file: Added.
  • platform/mac/fast/forms/file-input-direction-expected.png: Removed.
  • platform/mac/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/mac/fast/forms/file-input-disabled-expected.png: Removed.
  • platform/mac/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file-input-direction-expected.png.
  • platform/mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-direction-expected.txt.
  • platform/mac/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
  • platform/mac/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
  • platform/mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-file-re-render-expected.png.
  • platform/mac/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-file-re-render-expected.txt.
  • platform/mac/fast/forms/hidden-input-file-expected.png: Removed.
  • platform/mac/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/mac/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/mac/fast/forms/input-file-re-render-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/fast/forms/file: Added.
  • platform/qt/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/qt/fast/forms/file-input-disabled-expected.txt: Removed.
  • platform/qt/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/file-input-direction-expected.txt.
  • platform/qt/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/file-input-disabled-expected.txt.
  • platform/qt/fast/forms/hidden-input-file-expected.txt: Removed.
  • platform/win/Skipped:
02:12 Changeset [96917] by pfeldman@chromium.org

Web Inspector: glass pane does not disappear after network panel's grid column resize.
https://bugs.webkit.org/show_bug.cgi?id=69607

Reviewed by Yury Semikhatsky.

  • src/js/DevTools.js:
02:04 Changeset [96916] by paroga@webkit.org

Unreviewed build fix after r95604.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::isLinkVisited):
(PlatformStrategiesWinCE::addVisitedLink):

01:31 Changeset [96915] by pfeldman@chromium.org

Web Inspector: add Elements and Network panels to the compilation
https://bugs.webkit.org/show_bug.cgi?id=69604

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-07
Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):

  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:
  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._startEditingConfig):

  • inspector/front-end/Drawer.js:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
(WebInspector.ElementsPanel.prototype._registerShortcuts):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
(WebInspector.ElementsTreeElement.prototype._startEditingTagName):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog._show):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype.startEditing):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype._updateOffscreenRows):
(WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):

  • inspector/front-end/Panel.js:
  • inspector/front-end/Popover.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._editBreakpointCondition):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/TimelineGrid.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.EditingConfig):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.formatLocalized):
(WebInspector.openLinkExternallyLabel):
(WebInspector.openInNetworkPanelLabel):
(WebInspector.copyLinkAddressLabel):

  • inspector/front-end/externs.js:

(WebInspector.extensionServer.notifyObjectSelected):
(WebInspector.openResource):

  • inspector/front-end/inspector.js:

(WebInspector.resourceForURL):

01:11 Changeset [96914] by annacc@chromium.org

Change enum value names for TextTrack::readyState and TextTrack::mode
https://bugs.webkit.org/show_bug.cgi?id=69603

Reviewed by David Levin.

No new tests. No new functionality.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::trackLoadStarted):
(WebCore::LoadableTextTrack::trackLoadError):
(WebCore::LoadableTextTrack::trackLoadCompleted):

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):

  • html/TextTrack.h:
00:59 Changeset [96913] by annacc@chromium.org

Adding parens in WebVTTParser.cpp to appease compiler preferences.
https://bugs.webkit.org/show_bug.cgi?id=69602

Reviewed by David Levin.

No new tests. No new functionality.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

00:43 Changeset [96912] by japhet@chromium.org

Always call setActive() in WebViewImpl::setFocus(),
not just when enabling focus.
https://bugs.webkit.org/show_bug.cgi?id=65220

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::loadFrame):
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp: Added.
00:06 Changeset [96911] by tkent@chromium.org

Test update for r96893.
https://bugs.webkit.org/show_bug.cgi?id=53752

r96893 changed the behavior of dataset-gc.html and
dataset-xhtml.xhtml. We update these tests because the new
behavior matches to Firefox and Opera.

  • fast/dom/dataset-gc-expected.txt:
  • fast/dom/dataset-xhtml-expected.txt:
  • fast/dom/script-tests/dataset-gc.js:
  • fast/dom/script-tests/dataset-xhtml.js:
  • platform/chromium/test_expectations.txt:
00:04 Changeset [96910] by bbudge@chromium.org

Adds a field, "saveAs", to WebFileChooserParams to present the file chooser
dialog in "Save As" mode (allows the user to choose a possibly non-existent file
for saving).
https://bugs.webkit.org/show_bug.cgi?id=69301

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h:

(WebKit::WebFileChooserParams::WebFileChooserParams):

Note: See TracTimeline for information about the timeline view.