Timeline


and

10/18/11:

23:57 Changeset [97836] by haraken@chromium.org
  • 13 edits
    1 delete in trunk

Generate a SharedWorker constructor of V8 using [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=67879

Reviewed by Hajime Morita.

Source/WebCore:

Spec: http://dev.w3.org/html5/workers/#shared-workers-and-the-sharedworker-interface
This patch changed SharedWorker::create(..., context, ec) to
SharedWorker::create(context, ..., ec), since a parameter specified by [CallWith]
should come at the beginning (c.f. bug 69799).

Test: ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor

ui_tests:WorkerTest.FLAKY_SharedWorkerFastName

  • WebCore.gypi: Removed bindings/v8/custom/V8SharedWorkerCustom.cpp
  • WebCore.pro: Ditto.
  • bindings/js/JSSharedWorkerCustom.cpp: Moved ScriptExecutionContext parameter to the beginning.

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/v8/custom/V8SharedWorkerCustom.cpp: Removed.
  • workers/SharedWorker.cpp: Moved ScriptExecutionContext parameter to the beginning.

(WebCore::SharedWorker::create): Ditto.

  • workers/SharedWorker.h: Ditto.
  • workers/SharedWorker.idl: Added [Constructor] IDL.

LayoutTests:

Added test cases for an undefined name and a null name on SharedWorker constructor.

  • fast/workers/resources/shared-worker-name.js:

(test7.try.worker.port.onmessage):
(test7): A test case for a null name.
(test8.worker.port.onmessage):
(test8): Ditto.
(test9.try.worker.port.onmessage):
(test9): A test case for an undefined name.
(test10.worker.port.onmessage):
(test10): Ditto.

  • fast/workers/shared-worker-constructor-expected.txt:
  • fast/workers/shared-worker-constructor.html:
  • fast/workers/shared-worker-name-expected.txt:
  • platform/chromium-win/fast/workers/shared-worker-constructor-expected.txt: Updated SyntaxError with TypeError. The reason why ui_tests has been so far working without updating this error type is that shared-worker-constructor.html is marked FLAKY in chromium.
23:42 Changeset [97835] by yuzo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Attempt to fix Linux Clang compilation error.

Unreviewed.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestThreadOnly::runTestThreaded):
(WTF::TEST_F):

22:36 Changeset [97834] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out last Windows build fix because it was wrong.

22:18 Changeset [97833] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 97786 - Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox

BUG=100459
Review URL: http://codereview.chromium.org/8345035

22:16 Changeset [97832] by hayato@chromium.org
  • 1 add in branches/components/README.components-branch

A test commit, adding a README.components-branch file.

21:32 Changeset [97831] by jnd@chromium.org
  • 5 edits in trunk

Source/WebCore: Implement NSProcessInfo::systemUptime on Mac Leopard.
https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(-[NSProcessInfo systemUptime]):

LayoutTests: Enable touch tests on Mac Leopard.
https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
20:55 Changeset [97830] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out last Windows build fix because it was wrong.

20:47 Changeset [97829] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix part of the Windows build.

Export!

20:10 Changeset [97828] by ojan@chromium.org
  • 10 edits
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

Unreviewed. New expected results after http://trac.webkit.org/changeset/97707.

  • fast/table/height-percent-test-vertical-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/height-percent-test-vertical-expected.txt.
  • platform/chromium-linux/fast/table/028-vertical-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png.
  • platform/chromium-win-vista/fast/writing-mode/fallback-orientation-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.txt:
  • platform/chromium-win/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt: Removed.
19:54 Changeset [97827] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Switched ropes from malloc memory to GC memory
https://bugs.webkit.org/show_bug.cgi?id=70364

Reviewed by Gavin Barraclough.

~1% SunSpider speedup. Neutral elsewhere. Removes one cause for strings
having C++ destructors.

  • heap/MarkStack.cpp:

(JSC::visitChildren): Call the JSString visitChildren function now,
since it's no longer a no-op.

  • runtime/JSString.cpp:

(JSC::JSString::~JSString): Moved this destructor out of line because
it's called virtually, so there's no value to inlining.

(JSC::JSString::RopeBuilder::expand): Switched RopeBuilder to be a thin
initializing wrapper around JSString. JSString now represents ropes
directly, rather than relying on an underlying malloc object.

(JSC::JSString::visitChildren): Visit our rope fibers, since they're GC
objects now.

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Updated for operating on JSStrings instead
of malloc objects.

(JSC::JSString::replaceCharacter): Removed optimizations for substringing
ropes and replacing subsections of ropes. We want to reimplement versions
of these optimizations in the future, but this patch already has good
performance without them.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString): Lots of mechanical changes here. The two important
things are: (1) The fibers in JSString::m_fibers are JSStrings now, not
malloc objects; (2) I simplified the JSString constructor interface to
only accept PassRefPtr<StringImpl>, instead of variations on that like
UString, reducing refcount churn.

  • runtime/JSValue.h:
  • runtime/JSValue.cpp:

(JSC::JSValue::toPrimitiveString): Updated this function to return a
JSString instead of a UString, since that's what clients want now.

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createEmptyString): Updated for interface changes above.

  • runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

  • runtime/StringObject.h:

(JSC::StringObject::create): Don't create a new JSString if we already
have a JSString.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncConcat): Updated for interface changes above.

18:50 Changeset [97826] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, fix partial commit of r97825!

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

18:49 Changeset [97825] by barraclough@apple.com
  • 4 edits in trunk

Date.prototype.toISOString fails to throw exception
https://bugs.webkit.org/show_bug.cgi?id=70394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

  • Should throw a range error if the internal value is not finite.

LayoutTests:

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:

(throwsRangeError):

  • fixed test case.
18:37 Changeset [97824] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fix baseline for fast/history/history-back-twice-with-subframes-assert.html
https://bugs.webkit.org/show_bug.cgi?id=70393

Reviewed by James Robinson.

the baseline added in r97821 appears to have had a couple of
extra lines in it.

  • fast/history/history-back-twice-with-subframes-assert-expected.txt:
18:37 Changeset [97823] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Try to jostle the windows build back to life.

  • rendering/HitTestResult.h:
18:16 Changeset [97822] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Update chromium leopard cg baseline.

Unreviewed, baseline update.

  • platform/chromium-cg-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
17:52 Changeset [97821] by andersca@apple.com
  • 3 edits
    2 adds in trunk

Assertion failure when going back in page with navigated subframes
https://bugs.webkit.org/show_bug.cgi?id=70389
<rdar://problem/8988444>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/history/history-back-twice-with-subframes-assert.html

If a single navigation ends up loading multiple frame, the first committed frame will
end up calling recursiveUpdateForCommit on the main frame which will null out the provisional item
for all frames on the page. This means that it can null out the provisional item for any frames
that are still yet to be committed which causes the aforementioned assertion failure.

Fix this by only nulling out the provisional history item (and saving/restoring the scroll position and
some other things) for frames that already contain the URL that the item requested. If a frame is being loaded,
it will null out its provisional history item when it's committed.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveUpdateForCommit):

LayoutTests:

  • fast/history/history-back-twice-with-subframes-assert-expected.txt: Added.
  • fast/history/history-back-twice-with-subframes-assert.html: Added.
17:47 Changeset [97820] by levin@chromium.org
  • 7 edits in trunk/Tools

watchlist: Should try to run if it can and not throw on mistakes.
https://bugs.webkit.org/show_bug.cgi?id=70358

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
  • Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
  • Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
17:40 Changeset [97819] by weinig@apple.com
  • 14 edits in trunk

Source/WebKit2: Move uses of C SPI out of WKView.h and into WKViewPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKViewPrivate.h:

Move declarations here.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView pageRef]):
(-[WKView canChangeFrameLayout:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
(-[WKView setFrame:andScrollBy:]):
Move definitions to private category.

  • UIProcess/API/mac/PDFViewController.mm:
  • UIProcess/mac/WKFullScreenWindowController.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:

Update to include WKViewPrivate.h where necessary.

Tools: Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindowController.m:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  • TestWebKitAPI/mac/JavaScriptTestMac.mm:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:
  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

Update to include WKViewPrivate.h where necessary.

17:22 QtWebKitHacking edited by caio.oliveira@openbossa.org
(diff)
17:15 Changeset [97818] by dpranke@chromium.org
  • 18 edits in trunk

Unreviewed, rolling out r97765.
http://trac.webkit.org/changeset/97765
https://bugs.webkit.org/show_bug.cgi?id=70388

"broke webkit_unit_tests, http/tests/xmlhttprequest
/xmlhttprequest-test-send-flag.html on linux debug" (Requested
by dpranke on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

Source/WebCore:

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::willSendRequest):
(WebCore::DocumentThreadableLoader::didSendData):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::data):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setRequestedFromNetworkingLayer):

  • loader/cache/CachedResourceClient.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::willSendRequest):
(WebCore::CachedResourceRequest::didFinishLoading):
(WebCore::CachedResourceRequest::didReceiveResponse):
(WebCore::CachedResourceRequest::didReceiveData):

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Removed.
  • loader/chromium/CachedResourceRequestChromium.cpp: Removed.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:

(WebCore::DocumentThreadableLoader::didDownloadData):

  • loader/icon/IconLoader.h:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse):

LayoutTests:

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
16:53 Changeset [97817] by mhahnenberg@apple.com
  • 22 edits in trunk/Source

Rename static put to putByIndex
https://bugs.webkit.org/show_bug.cgi?id=70281

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.cpp:

(JSC::Arguments::putVirtual):
(JSC::Arguments::putByIndex):

  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncMap):

  • runtime/JSArray.cpp:

(JSC::JSArray::put):
(JSC::JSArray::putVirtual):
(JSC::JSArray::putByIndex):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::putVirtual):
(JSC::JSByteArray::putByIndex):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putVirtual):
(JSC::JSCell::putByIndex):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putVirtual):
(JSC::JSNotAnObject::putByIndex):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putVirtual):
(JSC::JSObject::putByIndex):

  • runtime/JSObject.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putVirtual):
(JSC::RegExpMatchesArray::putByIndex):

Source/WebCore:

No new tests.

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::putVirtual):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_array.h:
16:53 Changeset [97816] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark storage/domstorage/events/documentURI as a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=70386

Unreviewed, expectations change.

on chromium snowleopard.

  • platform/chromium/test_expectations.txt:
16:44 Changeset [97815] by dpranke@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Add a new chromium baseline for fast/multicol/vertical-rl/rule-style.html.

Unreviewed, baseline update.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
16:40 Changeset [97814] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt:
16:38 Changeset [97813] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):
Fix typo.

16:36 Changeset [97812] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed warning fix after https://bugs.webkit.org/show_bug.cgi?id=70269

  • WebCore.pro:
16:25 Changeset [97811] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Stop leaking internal names in WKView API header
https://bugs.webkit.org/show_bug.cgi?id=70380

Reviewed by Anders Carlsson.

Move _frameSizeUpdatesDisabledCount to WKViewData. Since we cannot change the size of
WKView due to the fragile Objective-C ABI, we must rename the existing variable unused. If
drop 32-bit support, we will be able to remove it.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView disableFrameSizeUpdates]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView frameSizeUpdatesDisabled]):

  • WebKit2.xcodeproj/project.pbxproj:
16:20 Changeset [97810] by ap@apple.com
  • 14 edits in trunk/Source

Expose PDF information in hit test result
https://bugs.webkit.org/show_bug.cgi?id=70353

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absolutePDFURL):
  • rendering/HitTestResult.h: Added HitTestResult::absolutePDFURL(). It will contain a URL when over a PDF object or embed; not sure if we want this for PDFImageDocuments.
16:19 Changeset [97809] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Preserve offscreen tiles instead of immediately recycling them
https://bugs.webkit.org/show_bug.cgi?id=70352

Reviewed by James Robinson.

Tested by existing layout tests.

Prior to having a TextureManager class, tiled layers recycled their
textures internally to avoid reallocation. Unfortunately, it recycled
these tiles as soon as they went offscreen, even if they were still
valid. Instead, keep tiles around forever, letting the TextureManager
decide (via LRU) when to reclaim the underlying textures. This will
improve scrolling performance due to not needing to repaint tiles.

This change does lead to more texture reallocation for any textures
that get reclaimed, but the command buffer implementation already
pools and reuses texture ids, so it should not introduce additional
flush syncs. If there's any performance penalty, it'll be at the
driver level, but I'd prefer to measure that there's a problem before
prematurely optimizing and adding complexity to the TextureManager.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
16:17 Changeset [97808] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101
https://bugs.webkit.org/show_bug.cgi?id=70340
<rdar://problem/9548174>

We have seen a number of crash reports for this issue that seem to occurr when
the user drags an image from a web page onto the desktop.
We have not been able to reproduce this crash, therefore this is a speculative fix,
but the theory is that the dragging source has been already released when draggedImage
is called.
This patch attempts a fix for the problem by retaining the dragging source when
NSFilePromiseDragSource is created.

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(-[WKPasteboardFilePromiseOwner initWithSource:]):
(-[WKPasteboardFilePromiseOwner dealloc]):

16:14 Changeset [97807] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash after storing credentials in Keychain
https://bugs.webkit.org/show_bug.cgi?id=70376
<rdar://problem/9647503>

Reviewed by Dan Bernstein.

  • Shared/mac/SecKeychainItemResponseData.cpp: (WebKit::SecKeychainItemResponseData::encode): (WebKit::SecKeychainItemResponseData::decode): Actually send keychain item over, too. In shimSecKeychainItemCreateFromContent(), we are going to use it to override SecKeychainItemCreateFromContent(), and we cannot return noErr from this function without returning a non-null keychain item.
16:08 Changeset [97806] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

This revised fix doesn't break SL build.
https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed and landed by Sam Weinig.

Patch by Damian Kaleta <dkaleta@apple.com> on 2011-10-18

  • UIProcess/API/mac/WKView.mm:

(+[WKView hideWordDefinitionWindow]): Hides the definition window.

  • UIProcess/API/mac/WKViewPrivate.h:
16:06 Changeset [97805] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
https://bugs.webkit.org/show_bug.cgi?id=68957

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-characterdata.html

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

  • fast/mutation/observe-characterdata-expected.txt: Added.
  • fast/mutation/observe-characterdata.html: Added.
16:06 Changeset [97804] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

Move spellCheckerDocumentTag and handleCorrectionPanelResult from WKViewPrivate to WKViewInternal
https://bugs.webkit.org/show_bug.cgi?id=70377

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView spellCheckerDocumentTag]):
(-[WKView handleCorrectionPanelResult:]):
Move definition of methods to (Internal) area.

  • UIProcess/API/mac/WKViewInternal.h:

Add methods.

  • UIProcess/API/mac/WKViewPrivate.h:

Remove methods.

  • UIProcess/cf/WebBackForwardListCF.cpp:

Add missing newline.

  • UIProcess/mac/CorrectionPanel.mm:

Change #include to WKViewInternal.h

  • WebKit2.xcodeproj/project.pbxproj:

Sort some files.

16:05 Changeset [97803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Scroll animator tracing
https://bugs.webkit.org/show_bug.cgi?id=70280

Patch by Scott Byer <scottbyer@chromium.org> on 2011-10-18
Reviewed by James Robinson.

No functional difference, no test needed.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

16:02 Changeset [97802] by jamesr@google.com
  • 7 edits in trunk/Source

[chromium] Remove USE(THREADED_COMPOSITING) from the tree, this is controlled by a runtime setting
https://bugs.webkit.org/show_bug.cgi?id=70356

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.h:
15:58 Changeset [97801] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

cleanup some FIXMEs in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=70374

Reviewed by Darin Adler.

No new tests. Existing tests cover all changes.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):

  • rendering/RenderFlexibleBox.h:

Removed the FIXME to implement computePreferredLogicalWidths. It doesn't
seem to be necessary, at least not with the current test cases.

15:57 Changeset [97800] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Move WKView helper files into a sub-group
https://bugs.webkit.org/show_bug.cgi?id=70375

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:

Move some files around.

15:48 Changeset [97799] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove expectations for tests that are no longer failing.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
15:47 Changeset [97798] by joepeck@webkit.org
  • 5 edits in trunk

<http://webkit.org/b/70365> Web Inspector: Some localizedStrings.js Updates

Reviewed by Darin Adler.

Source/WebCore:

Fixed syntax issue, added missing strings, and removed a duplicate.

  • English.lproj/localizedStrings.js:

Tools:

  • Scripts/check-inspector-strings:

Updated to the new webkitpy way to determine checkout root.

  • Scripts/webkitdirs.pm:

(copyInspectorFrontendFiles):
Made it so build-webkit --inspector-frontend copies over
the localizedStrings.js file as well as the frontend files.

15:45 Changeset [97797] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] DRT: Clear list of visited pages before each test.
https://bugs.webkit.org/show_bug.cgi?id=70355

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-18
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add ewk_history_clear as a way to clear the list of visited pages in a
Ewk_History, in a similar fashion to Qt's QWebHistory::clear().

  • ewk/ewk_history.cpp:

(ewk_history_clear):

  • ewk/ewk_history.h:

Tools:

r97596 uncovered a bug in the implementation: the list of visited
links was not cleared between tests, which caused tests such as
fast/repaint/outline-repaint-glitch.html to be flaky (the link color
changed depending on whether fast/repaint/border-repaint-glitch.html
was visited before or not).

Call ewk_history_clear to make sure the visited links list does not
persist between tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

15:38 Changeset [97796] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

fix unused-but-set-variable warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=70344

Reviewed by Adam Barth.

This is a new compiler warning in gcc 4.6.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):

15:37 Changeset [97795] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable out-of-thread compositing in WebKit compositor API
https://bugs.webkit.org/show_bug.cgi?id=69850

Patch by Antoine Labour <piman@chromium.org> on 2011-10-18
Reviewed by James Robinson.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

15:14 Changeset [97794] by mitz@apple.com
  • 3 edits
    3 adds in trunk

Certain column-rule styles render incorrectly in vertical writing modes
https://bugs.webkit.org/show_bug.cgi?id=70362

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/vertical-rl/rule-style.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Use the correct border sides for vertical writing modes.

LayoutTests:

  • fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • fast/multicol/vertical-rl/rule-style.html: Added.
15:07 Changeset [97793] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix broken binding tests by changing G_MAXUSHORT to G_MAXUINT in WebKitDOMTestObj.cpp.
https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Daniel Bates.

Tests: fixing WebKitDOMTestObj.cpp

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_class_init): Change G_MAXUSHORT to G_MAXUINT

15:04 Changeset [97792] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r97788.
http://trac.webkit.org/changeset/97788
https://bugs.webkit.org/show_bug.cgi?id=70366

broke compile (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewPrivate.h:
14:57 Changeset [97791] by barraclough@apple.com
  • 5 edits in trunk

Array.prototype methods missing exception checks
https://bugs.webkit.org/show_bug.cgi?id=70360

Reviewed by Geoff Garen.

Missing exception checks after calls to the static getProperty helper,
these may result in the wrong exception being thrown (or an ASSERT being hit,
as is currently the case running test-262).

Source/JavaScriptCore:

No performance impact.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

  • fast/js/array-proto-func-property-getter-except-expected.txt:
  • fast/js/script-tests/array-proto-func-property-getter-except.js:
    • The test results that change were only testing for an absence of a crash; the new results are correct (the first exception thrown should be the one returned).
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    • Check in passing results.
14:07 Changeset [97790] by dpranke@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Add missing baselines for fast/selectors/visited-descendant.

Unreviewed, expectations change.

  • platform/chromium-cg-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-linux/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-win/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-win/fast/selectors/visited-descendant-expected.txt: Added.
14:01 Changeset [97789] by adamk@chromium.org
  • 3 edits in trunk/LayoutTests

Corrected bad cut-and-paste in MutationObserver test description.

Unreviewed.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
13:50 Changeset [97788] by kdecker@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-10-18 Damian Kaleta <dkaleta@apple.com>

Add WebKit API to hide the definition window
https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm: (-[WKView hideWordDefinitionWindow]): Hides the definition window.
  • UIProcess/API/mac/WKViewPrivate.h:
13:44 Changeset [97787] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 97786 - Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox

BUG=97786
Review URL: http://codereview.chromium.org/8346010

13:42 Changeset [97786] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox
https://bugs.webkit.org/show_bug.cgi?id=70183

Patch by Julien Chaffraix <jchaffraix@webkit.org> on 2011-10-18
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/flexbox/layoutHorizontal-crash.html

The deferred scroll information update logic was not updated when an object was destroy'ed.

The fix is very simple. As the deferred logic was only used with deprecated flexbox, it is a
pretty uncommon cases so let's optimize the new code for the common case.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

LayoutTests:

  • fast/flexbox/layoutHorizontal-crash-expected.txt: Added.
  • fast/flexbox/layoutHorizontal-crash.html: Added.
13:09 Changeset [97785] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[MutationObservers] Clean up MutationObserver code in Node
https://bugs.webkit.org/show_bug.cgi?id=70349

Reviewed by Ryosuke Niwa.

Three small cleanups.

No new tests, no behavior change.

  • dom/Node.cpp:

(WebCore::Node::clearRareData): Use indices instead of iterator in for loop; fix typo.
(WebCore::Node::registerMutationObserver): Inline single call to Node::ensureMutationObserverEntries.

  • dom/Node.h: Make mutationObserverEntries private.
12:55 Changeset [97784] by jamesr@google.com
  • 10 edits
    1 add in trunk/Source

[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.

(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

12:35 Changeset [97783] by ojan@chromium.org
  • 5 edits
    12 adds in trunk

implement flex-flow:column
https://bugs.webkit.org/show_bug.cgi?id=70082

Reviewed by David Hyatt.

Source/WebCore:

There's still a bug with a FIXME where we don't compute the right
size for the container of the flexbox in the presence of
orthogonal flows. That's the cause of all the failing cases
in the tests.

Tests: css3/flexbox/flex-flow-border.html

css3/flexbox/flex-flow-margins.html
css3/flexbox/flex-flow-orientations.html
css3/flexbox/flex-flow-overflow.html
css3/flexbox/flex-flow-padding.html
css3/flexbox/flex-flow.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isColumnFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
Use isHorizontalFlow and isLeftToRightFlow so that methods like
flowAwareBorderStart look exactly like borderStart with
isHorizontalWritingMode and isLeftToRightDirection replaced.

(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::transformedWritingMode):
Transform the writing-mode based of the flex-flow and direction
values. That methods like flowAwareBorderBefore look exactly like
borderBefore, except it switches over a different value.

(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-flow-border-expected.txt: Added.
  • css3/flexbox/flex-flow-border.html: Added.

Failures are due to not handling orthogonal flows correctly.

  • css3/flexbox/flex-flow-expected.txt: Added.
  • css3/flexbox/flex-flow-margins-expected.txt: Added.
  • css3/flexbox/flex-flow-margins.html: Added.
  • css3/flexbox/flex-flow-orientations-expected.txt: Added.
  • css3/flexbox/flex-flow-orientations.html: Added.
  • css3/flexbox/flex-flow-overflow-expected.txt: Added.
  • css3/flexbox/flex-flow-overflow.html: Added.
  • css3/flexbox/flex-flow-padding-expected.txt: Added.
  • css3/flexbox/flex-flow-padding.html: Added.

Failures are due to not handling orthogonal flows correctly.

  • css3/flexbox/flex-flow.html: Added.
  • css3/flexbox/resources/flexbox.js:

Added the ability to check offsets that include clientLeft/clientTop
and for checking clientWidth/clientHeight. This is neede dfor the border tests.

12:31 Changeset [97782] by dglazkov@chromium.org
  • 4 edits
    2 copies in trunk/Tools

Split TestExpectationsEditor into its own file.
https://bugs.webkit.org/show_bug.cgi?id=70348

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
12:24 Changeset [97781] by rniwa@webkit.org
  • 2 edits in trunk/Tools

[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=70313

Reviewed by Adam Barth.

Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
this parameter because build-webkit and other scripts don't accept it.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:10 Changeset [97780] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[chromium] Tracking update rects in LayerChromium and CCLayerImpl.
https://bugs.webkit.org/show_bug.cgi?id=69441

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-18
Reviewed by James Robinson.

This patch does not do much on its own, but is just part 1 of a
string of other patches which will use these rects for
visualization and scissoring. The appropriate testing will be
associated with those patches.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::updateRect):
(WebCore::CCLayerImpl::setUpdateRect):

11:19 Changeset [97779] by tony@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore

Merge 97724 - r97638 caused 3 printing crashes
https://bugs.webkit.org/show_bug.cgi?id=70284

Reviewed by Kent Tamura.

Null check element.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/8344008

11:18 Changeset [97778] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Change CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
for IDL attributes of type unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Xan Lopez.

Tests: small change to WebKitDOMTestObj.cpp

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGValueTypeName): convert unsigned short to uint instead of ushort

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property): expect g_value_get_uint instead of g_value_get_ushort
(webkit_dom_test_obj_class_init): expect G_MAXUSHORT instead of G_MAXUINT16

11:06 Changeset [97777] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
https://bugs.webkit.org/show_bug.cgi?id=70322

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):

10:56 Changeset [97776] by abarth@webkit.org
  • 2 edits in trunk/Tools

Subscribe myself to WebIDL changes
https://bugs.webkit.org/show_bug.cgi?id=70341

Reviewed by David Levin.

I've also added some documentation and refactored my previous
subscriptions to make it eaiser for others to subscribe as well.

  • Scripts/webkitpy/common/config/watchlist:
10:39 Changeset [97775] by caryclark@google.com
  • 174 edits
    55 adds in trunk/LayoutTests

Rebaseline most remaining IMAGE diffs for chromium-mac (Skia)
on SnowLeopard (10.6).

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
  • platform/chromium-mac/fast/css/outline-auto-location-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-mac/fast/events/autoscroll-expected.png:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-2-expected.png:
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac/fast/text/justify-nbsp-expected.png:
  • platform/chromium-mac/fast/text/justify-padding-distribution-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/font-face-cascade-order-expected.png:
  • platform/chromium-mac/svg/custom/font-face-simple-expected.png:
  • platform/chromium-mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac/transforms/2d/compound-transforms-vs-containers-expected.png:
10:37 Changeset [97774] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Add myself to the newfangled watchlist plumbing.
https://bugs.webkit.org/show_bug.cgi?id=70338

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist: Added sheepishly.
10:34 Changeset [97773] by eric.carlson@apple.com
  • 19 edits
    3 deletes in trunk/Source/WebCore

2011-10-18 Eric Carlson <eric.carlson@apple.com>

Use the new cached cue loader
https://bugs.webkit.org/show_bug.cgi?id=70269

Reviewed by Antti Koivisto.

No new tests, no functionality changed.

  • CMakeLists.txt: Remove CueParser.cpp/h and CueParserPrivate.h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadTextTracks): (WebCore::HTMLMediaElement::textTrackReadyStateChanged): New, not implemented yet. (WebCore::HTMLMediaElement::textTrackModeChanged): Ditto. (WebCore::HTMLMediaElement::textTrackCreated): Ditto. (WebCore::HTMLMediaElement::textTrackAddCues): Ditto. (WebCore::HTMLMediaElement::textTrackRemoveCues): Ditto. (WebCore::HTMLMediaElement::textTrackAddCue): Ditto. (WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::load): Update for interface change (WebCore::HTMLTrackElement::textTrackLoadingCompleted): New, dispatch 'load' or 'error' event.
  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::LoadableTextTrack): Add TextTrackClient and TextTrackLoadingClient

parameters.

(WebCore::LoadableTextTrack::load): Make url parameter KURL instead of String. Create the

cue loader, trigger the load.

(WebCore::LoadableTextTrack::newCuesAvailable): New callback from the loader. Not implemented yet.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Ditto.

  • html/LoadableTextTrack.h:
  • html/MutableTextTrack.cpp: (WebCore::MutableTextTrack::MutableTextTrack): Add TextTrackClient parameter.
  • html/MutableTextTrack.h: (WebCore::MutableTextTrack::create):
  • html/TextTrack.cpp: (WebCore::TextTrack::TextTrack): Add TextTrackClient parameter. (WebCore::TextTrack::~TextTrack): Tell the client to remove all cues, forget the client. (WebCore::TextTrack::setReadyState): Tell client about ready state change. (WebCore::TextTrack::setMode): Tell client about mode change.
  • html/TextTrack.h: (WebCore::TextTrackClient::textTrackAddCues): New client interface. (WebCore::TextTrackClient::textTrackRemoveCues): Ditto. (WebCore::TextTrackClient::textTrackAddCue): Ditto. (WebCore::TextTrackClient::textTrackRemoveCue): Ditto. (WebCore::TextTrack::create): (WebCore::TextTrack::trackType): New. (WebCore::TextTrack::client): Ditto. (WebCore::TextTrack::setClient): Ditto.
  • html/track/CueParser.cpp: Removed.
  • html/track/CueParser.h: Removed.
  • html/track/CueParserPrivate.h: Removed.
  • html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::fileIdentifierMaximumLength): New, return length of WebVTT file

magic number.

(WebCore::WebVTTParser::hasRequiredFileIdentifier): Update to use constants instead of hard

coded lengths.

(WebCore::WebVTTParser::WebVTTParser): Initialize "m_client" in the initilization list

instead of setting it in the constructor.

(WebCore::WebVTTParser::getNewCues): Renamed from fetchParsedCues.

  • html/track/WebVTTParser.h: (WebCore::WebVTTParser::create): Take a WebVTTParserClient* instead of a CueParserPrivateClient*.
  • loader/CueLoader.cpp: (WebCore::CueLoader::CueLoader): (WebCore::CueLoader::~CueLoader): Remove client. (WebCore::CueLoader::cueLoadTimerFired): Tell client about new clues and/or that the load

has finished.

(WebCore::CueLoader::processNewCueData): Process newly loaded data.
(WebCore::CueLoader::didReceiveData): Ditto.
(WebCore::CueLoader::notifyFinished): Do final processing as necessary, prime the timer

to call client.

(WebCore::CueLoader::load): Create resource loader, initiate loading.
(WebCore::CueLoader::newCuesParsed): Prime timer to tell client about newly parsed cues.
(WebCore::CueLoader::getNewCues): Get new cues from parser.

  • loader/CueLoader.h: (WebCore::CueLoader::create):
10:33 Changeset [97772] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Fix a unit test in TestFailures.
https://bugs.webkit.org/show_bug.cgi?id=70337

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,

the value of a method property should always be lowercase.

10:26 QtWebKitHacking edited by caio.oliveira@openbossa.org
File naming conventions (diff)
10:21 Changeset [97771] by abarth@webkit.org
  • 90 edits in trunk

Always enable ENABLE(XPATH)
https://bugs.webkit.org/show_bug.cgi?id=70217

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we're reducing the complexity of WebKit by
removing unneeded configuration options. ENABLE(XPATH) is enabled on
every port, so we are removing the ability to disable the feature.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.pro:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/objc/DOMCustomXPathNSResolver.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

  • bindings/objc/DOMXPath.mm:

(kit):

  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getXPathNSResolver):

  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Document.idl:
  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • features.pri:
  • inspector/InspectorDOMAgent.cpp:
  • page/DOMWindow.idl:
  • xml/NativeXPathNSResolver.cpp:
  • xml/NativeXPathNSResolver.h:
  • xml/XPathEvaluator.cpp:
  • xml/XPathEvaluator.h:
  • xml/XPathEvaluator.idl:
  • xml/XPathException.h:
  • xml/XPathException.idl:
  • xml/XPathExpression.cpp:
  • xml/XPathExpression.h:
  • xml/XPathExpression.idl:
  • xml/XPathExpressionNode.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathFunctions.h:
  • xml/XPathGrammar.y:
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h:
  • xml/XPathNSResolver.idl:
  • xml/XPathNodeSet.cpp:
  • xml/XPathNodeSet.h:
  • xml/XPathParser.cpp:
  • xml/XPathParser.h:
  • xml/XPathPath.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp:
  • xml/XPathPredicate.h:
  • xml/XPathResult.cpp:
  • xml/XPathResult.h:
  • xml/XPathResult.idl:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathUtil.cpp:
  • xml/XPathUtil.h:
  • xml/XPathValue.cpp:
  • xml/XPathValue.h:
  • xml/XPathVariableReference.cpp:
  • xml/XPathVariableReference.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/win:

  • Interfaces/DOMWindow.idl:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:17 Changeset [97770] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

garden-o-matic should not report flaking in expected failures as failures.
https://bugs.webkit.org/show_bug.cgi?id=70279

Reviewed by Adam Barth.

On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
same for garden-o-matic.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,

rewrote the logic for determining expected or unexpected failures as a central analysis tool.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
10:06 Changeset [97769] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Staged commit, part 6.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html5-input-number-expected.txt: Added.
  • platform/mac/accessibility/html5-input-number.html: Added.
10:04 Changeset [97768] by barraclough@apple.com
  • 6 edits in trunk/LayoutTests

Indexed arguments on the Arguments object should be enumerable.
https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

  • fast/js/kde/function-expected.txt:
  • fast/js/kde/script-tests/function.js:

(foo2):

  • This tests using 'in'.
  • fast/js/arguments-expected.txt:
  • fast/js/script-tests/arguments.js:

(descriptor):

  • This tests using 'Object.getOwnPropertyDescriptor'.
  • ietestcenter/Javascript/15.2.3.14-3-4-expected.txt:
    • This tests using 'Object.keys'.
10:03 Changeset [97767] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indexed arguments on the Arguments object should be enumerable.
https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyDescriptor):

  • The 'enumerable' property should be true for indexed arguments.

(JSC::Arguments::getOwnPropertyNames):

  • Don't guard the adding of indexed properties with 'IncludeDontEnumProperties'.
09:59 Changeset [97766] by alexis.menard@openbossa.org
  • 21 edits
    3 deletes in trunk

[Qt] Merge QML plugin for WebKit2 with the original WebKit1 plugin

.:

We don't need a sepearate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • Source/WebKit.pro:

Source/WebKit/qt:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • declarative/declarative.pro:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • UIProcess/API/qt/qmlplugin/plugin.cpp: Removed.
  • UIProcess/API/qt/qmlplugin/qmldir: Removed.
  • UIProcess/API/qt/qmlplugin/qmlplugin.pro: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
09:31 Changeset [97765] by japhet@chromium.org
  • 16 edits
    2 copies in trunk

Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks

for didFail() and didFinishLoading(), so we need to differentiate here.

(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()

instead of ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting

DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
'data' input parameter will contain all data received so far, and we need to determine the
incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
the incremental data.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):

  • loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel

the request, so protect appropriately.

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
09:15 Changeset [97764] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r97752.
http://trac.webkit.org/changeset/97752
https://bugs.webkit.org/show_bug.cgi?id=70332

Caused assertion failures in MediaList::setParentStyleSheet()
on the apple bots. (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

  • css/CSSMediaRule.h:
  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

  • css/MediaList.h:
  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):
(WebCore::StyleSheet::setMedia):

09:08 Changeset [97763] by dglazkov@chromium.org
  • 1 add in branches/chromium/912/codereview.settings

Added codereview settings.

09:07 Changeset [97762] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Change TextTrack to use the word DISABLED instead of OFF for mode
https://bugs.webkit.org/show_bug.cgi?id=70268

Reviewed by Daniel Bates.

No new tests. No new functionality.

  • html/TextTrack.cpp:

(WebCore::TextTrack::setMode): use Disabled instead of Off

  • html/TextTrack.h: update Mode enum to use Disabled instead of Off
09:04 Changeset [97761] by dglazkov@chromium.org
  • 1 copy in branches/chromium/912

Created branch 912.

08:51 Changeset [97760] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT when displaying context menu in input field
https://bugs.webkit.org/show_bug.cgi?id=69859

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-10-18
Reviewed by Simon Hausmann.

When creating a submenu in the context menu, the submenu of type
QWidget is statically cast to QObject before calling setParent on
it. QObject::setParent asserts if the object is a QWidget. So, call
setParent of QWidget itself.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::createContextMenu):

08:50 Changeset [97759] by cfleizach@apple.com
  • 3 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit, part 5.

Reviewed by Darin Adler.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):

08:48 Changeset [97758] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Move default stylesheet loading to a separate function
https://bugs.webkit.org/show_bug.cgi?id=70331

Reviewed by Andreas Kling.

  • Move default stylesheet loading out from CSSStyleSelector::styleForElement()
  • Rename e -> element
  • Remove pointless reffing of the placeholder style.
  • css/CSSStyleSelector.cpp:

(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::isAtShadowBoundary):
(WebCore::CSSStyleSelector::styleForElement):

08:43 Changeset [97757] by cfleizach@apple.com
  • 4 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 4.

Reviewed by Darin Adler.

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::isMockObject):
(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

08:38 Changeset [97756] by cfleizach@apple.com
  • 7 edits
    2 adds in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 3. Committing the new spin button classes.

Reviewed by Darin Adler.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilitySpinButton.cpp: Added.

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h: Added.

(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

08:28 Changeset [97755] by cfleizach@apple.com
  • 6 edits in trunk/Source

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

../WebCore:

Phase 2 of the staged commit.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

../WebKit/chromium:

Reviewed by Darin Adler.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
08:26 Changeset [97754] by kov@webkit.org
  • 4 edits in trunk/Source

Fix distcheck.

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-10-18

Source/JavaScriptCore

  • GNUmakefile.list.am: fix a typo and add a missing header to the

list.

Source/WebKit/gtk/po

  • GNUmakefile.am: create po directory when it's not there yet both

when updating the pot and the po files.

08:22 Changeset [97753] by cfleizach@apple.com
  • 3 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

This will be a staged commit since the first time around Windows layout tests started crashing for an undeterminable reason.

Reviewed by Darin Adler.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:
08:05 Changeset [97752] by andreas.kling@nokia.com
  • 9 edits in trunk/Source/WebCore

MediaList: Remove inheritance from StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=70203

Reviewed by Darin Adler.

  • css/MediaList.h:

(WebCore::MediaList::parentStyleSheet):
(WebCore::MediaList::setParentStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

Change MediaList to no longer inherit from StyleBase. The parent()/setParent()
mechanism was replaced by explicit parentStyleSheet()/setParentStyleSheet().

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
CSSRules are never moved between stylesheets, so the parent style sheet pointer
is valid for the MediaList's lifetime.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().

(WebCore::StyleSheet::setMedia):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
Assert that the parent sheet is either null, or this, as MediaLists should never
be reparented to other sheets.
Assert that the StyleSheet is indeed a CSSStyleSheet. XSLStyleSheet inherits from
StyleSheet, but it shouldn't be using the MediaList.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

Add MediaList* specific overload for root() since it can't fall back
to root(StyleBase*) anymore.

  • WebCore.xcodeproj/project.pbxproj:

Add some PrivateHeaders to accomodate the JSDOMBinding.h changes.

  • css/CSSMediaRule.h:

Remove unnecessary forward-declaration of MediaList.

07:35 Changeset [97751] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebCore

XSLStyleSheet only needs to manage XSLImportRule children.
https://bugs.webkit.org/show_bug.cgi?id=70326

Reviewed by Antti Koivisto.

  • css/StyleBase.h:
  • xml/XSLImportRule.h:
  • css/CSSRule.h:

(WebCore::CSSRule::isImportRule):

Move StyleBase::isImportRule() down to CSSRule. Since XSLImportRule no longer
implements it, it's now specific to CSSImportRule.

  • xml/XSLStyleSheet.h:

Change m_children to be a vector of XSLImportRules. Also remove length(),
item() and append() since they were only used internally to modify m_children.

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
(WebCore::XSLStyleSheet::clearDocuments):
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::locateStylesheetSubResource):

Remove now-unnecessary isImportRule() checks and tidy up the code a bit.

07:22 Changeset [97750] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed Qt rebaseline after r97738.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
07:16 Changeset [97749] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove const modifier from ctx_menu functions.
https://bugs.webkit.org/show_bug.cgi?id=70090

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-18
Reviewed by Andreas Kling.

Functions ewk_context_menu_show and ewk_context_menu_custom_get
have got const modifer to ensure that Ewk_Context_Menu won't be
changed. The methods emit events through
evas_object_smart_callback_call with Ewk_Context_Menu as parameter
which is converted to void *. In this case an application which
receives those events may change Ewk_Context_Menu.

Additionaly the name of ewk_context_menu_custom_get has been changed
to ewk_context_menu_customize because an application is able to
modify the items of context menu.

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_customize):
(ewk_context_menu_show):

  • ewk/ewk_private.h:
07:12 Changeset [97748] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
https://bugs.webkit.org/show_bug.cgi?id=70329

Reviewed by Andreas Kling.

Use LoadSpy::wait() instead of the TestCase::tryCompare(). They should be equivalent,
but I'm getting strange results with tryCompare(). This commit also adds an extra check
to make sure the hovered link is the correct one.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
06:51 Changeset [97747] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Some QML tests were accidentally committed.
https://bugs.webkit.org/show_bug.cgi?id=70321

Reviewed by Andreas Kling.

These tests were committed by accident. They should not be there.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
06:03 Changeset [97746] by philn@webkit.org
  • 16 edits
    2 adds
    2 deletes in trunk

[Gtk] Support for client-based geolocation
https://bugs.webkit.org/show_bug.cgi?id=64970

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-10-18
Reviewed by Martin Robinson.

.:

Remove flag for enabling client-based geolocation since
it is used by default on Gtk port and hence not configurable.

  • configure.ac:

Source/WebCore:

Add feature defines for client-based geolocation when geolocation is enabled,
since this is the providing method that is now used by default. Remove
service-based providing method completely as it is not needed anymore.

  • GNUmakefile.am: Add feature defines for client-based geolocation.
  • GNUmakefile.list.am: Remove GeolocationServiceGtk.* files from compilation.
  • platform/gtk/GeolocationServiceGtk.cpp: Removed.
  • platform/gtk/GeolocationServiceGtk.h: Removed.

Source/WebKit/gtk:

Add DumpRenderTree support functions for client-based geolocation tests
and implement GeolocationClientGtk. The implementation is based on Zecke's
implementation of GeolocationService class in WebCore, which is now redundant
and subsequently removed.

  • GNUmakefile.am: Add GeolocationClientGtk.* files to compilation.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Add support functions to operate

with GeolocationClientMock.
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/GeolocationClientGtk.cpp: Added.

(WebKit::getPositionCallback):
(WebKit::positionChangedCallback):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::geolocationDestroyed):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::lastPosition):
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
(WebKit::GeolocationClient::positionChanged):
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):

  • WebCoreSupport/GeolocationClientGtk.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_init): Use GeolocationClientMock as geolocation client
when running in DumpRenderTree.

Tools:

Add support for testing client-based geolocation tests in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): Reset GeolocationClientMock.
(createWebView): Create web view after declaring DumpRenderTree mode.
That way a mock client for geolocation is used instead of a GeoClue
client if a web view is created when testing.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for

geolocation layout tests.
(LayoutTestController::setMockGeolocationPosition):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):

  • Scripts/build-webkit: Note that the Gtk port is using client-based

geolocation, even though changing this flag has no effect on compilation.

LayoutTests:

Unskip geolocation tests that now pass.

  • platform/gtk/Skipped:
05:58 Changeset [97745] by antti@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION(r97248): :visited as descendant selector broken
https://bugs.webkit.org/show_bug.cgi?id=70122

Source/WebCore:

Reviewed by Nikolas Zimmerman.

Make ":visited foo" and similar selectors work correctly again. They can affect
the visited style of an element inside a visited link.

Test: fast/selectors/visited-descendant.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

Apply visited style to children of visited links too.


  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

Don't disable visited matching until we run into first ancestor link or use combinator other than child/descendant.

(WebCore::SelectorChecker::determineLinkMatchType):

Look into child/descendant component selectors too to determine the link match type.

LayoutTests:

Reviewed by Nikolas Zimmerman.

  • fast/selectors/visited-descendant.html: Added.
  • platform/mac/fast/selectors/visited-descendant-expected.txt: Added.
05:52 Changeset [97744] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=70297

Reviewed by Simon Hausmann.

Qt treat the first and last hover movements as special HoverMove and HoverLeave events, but
WebKit doesn't make the difference, so we need to create move events for them.

While HoverEnter is in practice equivalent to HoverMove, the HoverLeave event is a bit
different because we want to emulate that the mouse is not only leaving the current node, but
completely leaving the whole document. The way to do this is to manufacture a move event with
a very far position, and was inspired by WebView::handleMouseEvent() in
Source/WebKit/win/WebView.cpp.

This patch fixes DesktopWebViewLinkHovered QML tests.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverLeaveEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
05:51 Changeset [97743] by caseq@chromium.org
  • 4 edits in trunk/Tools

2011-10-07 Andrey Kosyakov <caseq@chromium.org>

[Chromium] suppress console output from DevTools window
https://bugs.webkit.org/show_bug.cgi?id=69632

Reviewed by Pavel Feldman.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::showDevTools):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didAddMessageToConsole): (WebViewHost::reset): (WebViewHost::setLogConsoleOutput):
  • DumpRenderTree/chromium/WebViewHost.h:
05:46 Changeset [97742] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

Move CSSRule specific virtuals from StyleBase down into CSSRule.
https://bugs.webkit.org/show_bug.cgi?id=70240

Reviewed by Darin Adler.

Move all the isFooRule() virtuals except isImportRule() to CSSRule
since they only make sense for its subclasses. isRule() remains in
StyleBase since we still need it for the parent chain traversal.
isImportRule() remains because XSLImportRule implements it.

Also moved insertedIntoParent() and removed its usage in
XSLStyleSheet since it is only reimplemented by CSSImportRule.

  • css/CSSRule.h:

(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::insertedIntoParent):

  • css/StyleBase.h:

(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isCSSStyleSheet):

  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::append):

05:39 Changeset [97741] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Option.value should trim extra internal html spaces
https://bugs.webkit.org/show_bug.cgi?id=69455

Patch by Sachin Puranik <jcqt43@motorola.com> on 2011-10-18
Reviewed by Kent Tamura.

Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.

Source/WebCore:

Test: fast/forms/option-value-trim-html-spaces.html

  • dom/OptionElement.cpp: Removed a function as this implementation is moved to the HTMLOptionElement.cpp file.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::value): Implementation of .value function which will now trim the html white spaces.

LayoutTests:

  • fast/forms/option-value-trim-html-spaces-expected.txt: Test case to test the text triming on the value attribute.
  • fast/forms/option-value-trim-html-spaces.html: Test case to test the text triming on the value attribute.
05:29 Changeset [97740] by alexis.menard@openbossa.org
  • 11 edits
    1 move
    5 adds
    2 deletes in trunk/Source/WebKit2

[Qt][WK2] WebPreferences are impossible to use in QML.
https://bugs.webkit.org/show_bug.cgi?id=70141

Reviewed by Kenneth Rohde Christiansen.

Make it possible to use qwkpreferences in QML. Renamed it
to follow our new style regarding class names. This class is
now a QObject that is exposed as a property of the view.
The tests give an idea of the usage.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::preferences):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::preferences):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qwebpreferences.cpp: Added.

(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferences::QWebPreferences):
(QWebPreferences::~QWebPreferences):
(QWebPreferences::autoLoadImages):
(QWebPreferences::setAutoLoadImages):
(QWebPreferences::javascriptEnabled):
(QWebPreferences::setJavascriptEnabled):
(QWebPreferences::pluginsEnabled):
(QWebPreferences::setPluginsEnabled):
(QWebPreferences::offlineWebApplicationCacheEnabled):
(QWebPreferences::setOfflineWebApplicationCacheEnabled):
(QWebPreferences::localStorageEnabled):
(QWebPreferences::setLocalStorageEnabled):
(QWebPreferences::XSSAuditingEnabled):
(QWebPreferences::setXSSAuditingEnabled):
(QWebPreferences::privateBrowsingEnabled):
(QWebPreferences::setPrivateBrowsingEnabled):
(QWebPreferences::dnsPrefetchEnabled):
(QWebPreferences::setDnsPrefetchEnabled):
(QWebPreferences::standardFontFamily):
(QWebPreferences::setStandardFontFamily):
(QWebPreferences::fixedFontFamily):
(QWebPreferences::setFixedFontFamily):
(QWebPreferences::serifFontFamily):
(QWebPreferences::setSerifFontFamily):
(QWebPreferences::sansSerifFontFamily):
(QWebPreferences::setSansSerifFontFamily):
(QWebPreferences::cursiveFontFamily):
(QWebPreferences::setCursiveFontFamily):
(QWebPreferences::fantasyFontFamily):
(QWebPreferences::setFantasyFontFamily):
(QWebPreferences::minimumFontSize):
(QWebPreferences::setMinimumFontSize):
(QWebPreferences::defaultFontSize):
(QWebPreferences::setDefaultFontSize):
(QWebPreferences::defaultFixedFontSize):
(QWebPreferences::setDefaultFixedFontSize):

  • UIProcess/API/qt/qwebpreferences.h: Added.
  • UIProcess/API/qt/qwebpreferences_p.h: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/javascript.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/localStorage.html: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::preferences):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qwkpreferences.cpp: Removed.
  • UIProcess/qt/qwkpreferences.h: Removed.
  • UIProcess/qt/qwkpreferences_p.h: Removed.
  • WebKit2.pro:
  • WebKit2API.pri:
04:52 Changeset [97739] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix compilation error by include WebErrors.h file.
https://bugs.webkit.org/show_bug.cgi?id=70309

Unreviewed build fix

Added a header file to fix compilation error.

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-18

  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
04:50 Changeset [97738] by mihnea@adobe.com
  • 29 edits
    4 adds in trunk

[CSS Regions]Parse @-webkit-region rule
https://bugs.webkit.org/show_bug.cgi?id=70021

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/parsing-region-style-rule.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::cssText):

  • css/CSSParser.cpp:

(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::createRegionStylingRule):

  • css/CSSParser.h:

(WebCore::CSSParser::reusableRegionSelectorVector):

  • css/CSSRegionStyleRule.cpp: Added.

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::cssText):

  • css/CSSRegionStyleRule.h: Added.
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::rulesText):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::selectorsText):

  • css/CSSSelectorList.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addRegionStyleRule):
(WebCore::RuleSet::addRulesFromSheet):

  • css/CSSStyleSelector.h:
  • css/StyleBase.h:

(WebCore::StyleBase::isRegionStyleRule):

  • css/tokenizer.flex:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/regions/parsing-region-style-rule-expected.txt: Added.
  • fast/regions/parsing-region-style-rule.html: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
04:41 Changeset [97737] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r97735.
http://trac.webkit.org/changeset/97735
https://bugs.webkit.org/show_bug.cgi?id=70317

some people apparently use build-jsc with the qt port without
building webkit first (Requested by torarne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(buildQMakeProject):
(buildQMakeQtProject):

03:56 Changeset [97736] by philn@webkit.org
  • 35 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r97602 and r97596.

  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/gtk/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/gtk/fast/block/margin-collapse/056-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
  • platform/gtk/fast/history/visited-link-background-color-expected.txt:
  • platform/gtk/fast/overflow/overflow_hidden-expected.txt:
  • platform/gtk/fast/selectors/017-expected.txt:
  • platform/gtk/fast/selectors/061-expected.txt:
  • platform/gtk/fast/table/028-vertical-expected.txt:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/gtk/svg/hixie/cascade/002-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
03:36 Changeset [97735] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Remove dead code in build-webkit

build-webkit will iterate over a list of subdirectories to build,
but this feature is only used by the Apple ports. For QtWebKit we
always pass an empty directory to buildQMakeProject, which makes
the logic for dealing with sub-projects in buildQMakeProject just
added noise.

If we do want this feature at some point, we should redo it in
the context of the upcoming build system changes for Qt.

Reviewed by Simon Hausmann.

03:14 BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Updated the patch set to include the latest fixes. (diff)
03:05 BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Updated the patch set to include the latest fixes. (diff)
03:04 Changeset [97734] by vestbo@webkit.org
  • 3 edits in trunk/Tools

Remove traces of Symbian support from the build scripts

Reviewed by Simon Hausmann.

03:03 Changeset [97733] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Implement geolocation provider for qt port
https://bugs.webkit.org/show_bug.cgi?id=59199

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-10-18
Reviewed by Simon Hausmann.

Based on patch by Kenneth Christiansen <kenneth.r.christiansen@nokia.com>

Implements default location provider for WK2 QtWebKit (WebGeolocationProviderQt),
allowing QtWebKit clients to implement or override their own provider using WK2 APIs.

  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/qt/WebGeolocationProviderQt.cpp: Added.

(toLocationProvider):
(locationStartUpdating):
(locationStopUpdating):
(WebGeolocationProviderQt::create):
(WebGeolocationProviderQt::provider):
(WebGeolocationProviderQt::WebGeolocationProviderQt):
(WebGeolocationProviderQt::~WebGeolocationProviderQt):
(WebGeolocationProviderQt::updateTimeout):
(WebGeolocationProviderQt::positionUpdated):
(WebGeolocationProviderQt::startUpdating):
(WebGeolocationProviderQt::stopUpdating):

  • UIProcess/qt/WebGeolocationProviderQt.h: Added.
  • WebKit2.pro:
02:28 Changeset [97732] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: support displaying multiple sources per single script in ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=69847

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
02:18 Changeset [97731] by kbalazs@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

ParallelJobs: maximum number of threads should be determined dynamically
https://bugs.webkit.org/show_bug.cgi?id=68540

Reviewed by Zoltan Herczeg.

Add logic to determine the number of cores and use this as
the maximum number of threads. The implementation currently
covers Linux, Darwin, Windows, AIX, Solaris, OpenBSD and NetBSD.
The patch was tested on Linux, Mac and Windows which was enough to
cover all code path. It should work on the rest accoring to the
documentation of those OS's. The hard coded constant is still used
on uncovered OS's which should be fixed in the future.

  • wtf/ParallelJobs.h: Removed the default value of the requestedJobNumber

argument because clients should always fill it and the 0 default value
was incorrect anyway.
(WTF::ParallelJobs::ParallelJobs):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::determineMaxNumberOfParallelThreads):

  • wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):

02:11 Changeset [97730] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r97672.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
02:09 Changeset [97729] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-10-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix lion build breakage s/class Length/struct Length/.

  • loader/cache/CachedImage.h:
  • platform/graphics/Image.h:
01:48 Changeset [97728] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

[UNIX] Use SOCK_SEQPACKET when available
https://bugs.webkit.org/show_bug.cgi?id=61287

Reviewed by Darin Adler.

Sockets of type SEQPACKET are actually DGRAM sockets but that
notifies the other end when the connection is closed. When
SEQPACKET sockets are not available GTK+ port uses STREAM sockets
while Qt port uses DGRAM sockets.

  • PluginProcess/PluginProcess.cpp: Use SOCK_SEQPACKET if possible.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Ditto.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Ditto.

01:39 Changeset [97727] by zimmermann@webkit.org
  • 17 edits in trunk/Source/WebCore

2011-10-18 Nikolas Zimmermann <nzimmermann@rim.com>

Prepare SVGImage intrinsic size negotiation: Add intrinsic size & ratio calculation functionality to Image
https://bugs.webkit.org/show_bug.cgi?id=70314

Reviewed by Antti Koivisto.

Add a "void computeIntrinsicDimension(Length& intrinsicWidth, Lengt& intrinsicHeight, FloatSize& intrinsicRatio)" helper method
to Image/GeneratedImage/SVGImage and make it accessible through StyleImage.

For a regular Image the intrinsicWidth/Height contains just a Length(size().width(), Fixed). In contrary SVGImages pass on the
style()->width()/height() values from the render style of the RenderSVGRoot renderer. These information are needed to implement
the size negotiation between embedded SVG images and the embedder.

No new tests, as this new functionality is not yet used.

  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::computeIntrinsicDimensions):
  • loader/cache/CachedImage.h:
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::computeIntrinsicDimensions):
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/Image.cpp: (WebCore::Image::computeIntrinsicDimensions):
  • platform/graphics/Image.h:
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::computeIntrinsicDimensions):
  • platform/graphics/cg/PDFDocumentImage.h:
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions):
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::computeIntrinsicDimensions):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::computeIntrinsicDimensions):
  • svg/graphics/SVGImage.h:
01:04 Changeset [97726] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Different dimensions are reported for elements onscreen and in the Metrics pane
https://bugs.webkit.org/show_bug.cgi?id=70242

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
00:20 Changeset [97725] by haraken@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97697.
http://trac.webkit.org/changeset/97697
https://bugs.webkit.org/show_bug.cgi?id=68978

some tests are broken

Source/WebCore:

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
(WebCore::V8MessageEvent::initMessageEventCallback):

  • dom/MessageEvent.cpp:

(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::isMessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):

  • dom/MessageEvent.idl:

LayoutTests:

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:

10/17/11:

23:39 Changeset [97724] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

r97638 caused 3 printing crashes
https://bugs.webkit.org/show_bug.cgi?id=70284

Reviewed by Kent Tamura.

Null check element.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

23:30 Changeset [97723] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r97677.
http://trac.webkit.org/changeset/97677
https://bugs.webkit.org/show_bug.cgi?id=70308

A dependent revision was rolled out. (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
23:23 Changeset [97722] by tkent@chromium.org
  • 2 edits in trunk/Tools

A follow-up of r97716.
https://bugs.webkit.org/show_bug.cgi?id=68803

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset): Initialize m_dumpCreateView.

22:50 Changeset [97721] by commit-queue@webkit.org
  • 17 edits
    4 deletes in trunk

Unreviewed, rolling out r97669.
http://trac.webkit.org/changeset/97669
https://bugs.webkit.org/show_bug.cgi?id=70305

Broke accessibility tests on Windows (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityMockObject.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySpinButton.cpp: Removed.
  • accessibility/AccessibilitySpinButton.h: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

  • platform/mac/accessibility/html5-input-number-expected.txt: Removed.
  • platform/mac/accessibility/html5-input-number.html: Removed.
22:39 Changeset [97720] by tkent@chromium.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

Remove OptionGroupElement
https://bugs.webkit.org/show_bug.cgi?id=70220

Reviewed by Darin Adler.

No new tests, just a refactoring.

  • CMakeLists.txt: Remove OptionGroupElement.cpp and/or OptionGroupElement.h.
  • GNUMakefile.am.list: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/DOMAllInOne.cpp: ditto.
  • dom/OptionElement.cpp:

(WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().

  • dom/OptionGroupElement.cpp: Removed.
  • dom/OptionGroupElement.h: Removed.
  • html/HTMLOptGroupElement.cpp:

(WebCore::isHTMLOptGroupElement): Added.

  • html/HTMLOptGroupElement.h:
    • Don't inherit OptionGroupElement.
    • Make groupLabelText() non-virtual.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):
Use Use hasTagName(optgroupTag) instead of isOptionGroupElement().

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().
(WebCore::RenderListBox::paintItemForeground):
Use hasTagName(optgroupTag) instead of isOptionGroupElement().

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemText):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().
(WebCore::RenderMenuList::itemIsEnabled):
Use Use hasTagName(optgroupTag) instead of isOptionGroupElement().
(WebCore::RenderMenuList::itemIsLabel): ditto.

22:32 Changeset [97719] by barraclough@apple.com
  • 6 edits in trunk

Reverted r997709, this caused test failures.

Source/JavaScriptCore:

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
22:04 Changeset [97718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] TexMapGL renders a strange one-pixel border of BitmapTexture.
https://bugs.webkit.org/show_bug.cgi?id=70293

TextureMapperGL renders the strange border in
http://www.webkit.org/blog-files/leaves/index.html
Bug occurs because BitmapTexture is larger than the content due to rounding to
NPOT, and its pixel data is never initialized.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-10-17
Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::texImage2DResourceSafe):
(WebCore::BitmapTextureGL::reset):

21:57 Changeset [97717] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

Correct a dupe.

21:47 Changeset [97716] by jochen@chromium.org
  • 14 edits
    4 adds in trunk

Source/WebCore: Make NavigationAction wrap a ResourceRequest instead of a KURL.
https://bugs.webkit.org/show_bug.cgi?id=68803

With this, FrameLoaderClient::dispatchCreatePage knows about the
request that will be used for the initial navigaion of the to be
created page.

Reviewed by Nate Chapin.

Test: platform/chromium/fast/loader/create-view-target-blank.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):

  • loader/NavigationAction.cpp:

(WebCore::NavigationAction::NavigationAction):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::isEmpty):
(WebCore::NavigationAction::url):
(WebCore::NavigationAction::resourceRequest):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):

  • WebCore.exp: updated

Source/WebKit/chromium: Make NavigationAction wrap a ResourceRequest instead of a KURL.
https://bugs.webkit.org/show_bug.cgi?id=68803

Use the request in the NavigationAction, if the FrameLoadRequest
doesn't already contain a request.

Reviewed by Nate Chapin.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createWindow):

Tools: [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
https://bugs.webkit.org/show_bug.cgi?id=68803

Reviewed by Nate Chapin.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpCreateView):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldDumpCreateView):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createView):

LayoutTests: Verify that the URL to be opened in the new window is passed by dispatchCreateWindow down to createView.
https://bugs.webkit.org/show_bug.cgi?id=68803

Reviewed by Nate Chapin.

  • platform/chromium/fast/loader/create-view-target-blank-expected.txt: Added.
  • platform/chromium/fast/loader/create-view-target-blank.html: Added.
  • platform/chromium/fast/loader/resources/done.html: Added.
21:37 Changeset [97715] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

XSSAuditor bypass with remote script ending in ? character
https://bugs.webkit.org/show_bug.cgi?id=70255

Patch by Tom Sepez <tsepez@chromium.org> on 2011-10-17
Reviewed by Daniel Bates.

Fix XSSAuditor bypass where unterminated src="" attribute could pick up
text from page causing failed XSS detection. Constrain match to domain
portions of src attribute only.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-source-unterminated.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Added.
21:31 Changeset [97714] by adamk@chromium.org
  • 13 edits
    1 delete in trunk/Source/WebCore

Parse MutationObserverOptions directly into a bitfield
https://bugs.webkit.org/show_bug.cgi?id=70287

Reviewed by Ryosuke Niwa.

Replaces the MutationObserverOptions class with a typedef,
used to pass a bitfield composed of enums defined in
WebKitMutationObserver.h.

No new tests because no behavior should change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDictionary.h: Removed now-unused method.
  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/MutationObserverOptions.h: Removed.
  • dom/Node.cpp:

(WebCore::Node::registerMutationObserver):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::MutationObserverEntry):
(WebCore::MutationObserverEntry::matches):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:
21:29 Changeset [97713] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

fallback-orientation.html is failing on Linux too.

21:08 Changeset [97712] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Add compile-time asserts for RenderStyle::(Non)InheritedFlags size.
https://bugs.webkit.org/show_bug.cgi?id=69803

Reviewed by Darin Adler.

No new tests.

Adds COMPILE_ASSERTs for the size of RenderStyle::InheritedFlags and
RenderStyle::NonInheritedFlags to ensure that they are not accidentally
grown in future changes.
Change types of unsigned bitfields to unsigned char to ensure that the
above assertions remain true when building on windows.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle):
Adds assertions to ensure struct sizes do not change.

  • rendering/style/RenderStyle.h:

Changes unsigned to unsigned char as outlined above.

21:08 Changeset [97711] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

Test cleanups after http://trac.webkit.org/changeset/97707.

  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/qt/fast/table/028-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
20:41 Changeset [97710] by japhet@chromium.org
  • 2 edits in trunk/Tools

Add myself to watchlists, and add a watch
for Source/WebCore/loader/.
https://bugs.webkit.org/show_bug.cgi?id=70263

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
20:26 Changeset [97709] by barraclough@apple.com
  • 6 edits in trunk

Source/JavaScriptCore: Rename deregister* to unregister*
https://bugs.webkit.org/show_bug.cgi?id=70272

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

Renamed deregisterWeakMap to unregisterWeakMap.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::unregisterWeakMap):

LayoutTests: Poisoning of strict caller/arguments inappropriately poisoning "in"
https://bugs.webkit.org/show_bug.cgi?id=63398

Reviewed by Sam Weinig.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
    • added tests.
20:23 Changeset [97708] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix a new[]/delete mismatch in InnerGestureRecognizerTest that makes valgrind sad
https://bugs.webkit.org/show_bug.cgi?id=70273

Patch by James Robinson <jamesr@chromium.org> on 2011-10-17
Reviewed by Mihai Parparita.

  • tests/InnerGestureRecognizerTest.cpp:

(TouchSequence::~TouchSequence):

20:13 Changeset [97707] by ojan@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97662.
http://trac.webkit.org/changeset/97662
https://bugs.webkit.org/show_bug.cgi?id=68497

Was not the cause of the test failures.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.png:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
20:12 Changeset [97706] by rniwa@webkit.org
  • 6 edits in trunk/Source

Rename deregister* to unregister*
https://bugs.webkit.org/show_bug.cgi?id=70272

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renamed deregisterWeakMap to unregisterWeakMap.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::unregisterWeakMap):

Source/WebCore:

Renamed deregisterHandler to unregisterHandler.

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionServerClient.prototype.unregisterHandler):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.unregisterHandler):

20:09 Changeset [97705] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] add test failures after http://trac.webkit.org/changeset/97693.
See https://bugs.webkit.org/show_bug.cgi?id=70300 for more details.

  • platform/chromium/test_expectations.txt:
19:59 Changeset [97704] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Expose the kit() frame function to the rest of ewk.
https://bugs.webkit.org/show_bug.cgi?id=70253

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

Now that we have the EWKPrivate namespace, it makes sense to make the
kit() function accessible there instead of having it as a static local
function in ewk_frame.

While on it, get rid of ewk_frame_core_get, which is obsolete after
EWKPrivate::coreFrame.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientEfl::dispatchCreatePage):
(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • ewk/ewk_frame.cpp:

(_ewk_frame_loader_efl_get):
(_ewk_frame_children_iterator_next):
(ewk_frame_child_find):
(ewk_frame_hit_test_new):
(EWKPrivate::kitFrame):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):

19:25 Changeset [97703] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] The BGRA32PremultimpliedBuffer should not inherit the RefCounted class.
https://bugs.webkit.org/show_bug.cgi?id=70098

The BitmapTexture has a BGRA32PremultimpliedBuffer object using OwnPtr, not RefPtr.
It causes following assertion fail, RefCountedBase::m_deletionHasBegun.
It is better that the BGRA32PremultimpliedBuffer does not inherit the RefCounted
because the BitmapTexture only has and uses a BGRA32PremultimpliedBuffer object.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-10-17
Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/TextureMapperGL.h:
19:19 Changeset [97702] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Search in resource crashes when there is no resource with given url.
https://bugs.webkit.org/show_bug.cgi?id=69767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-non-existing-resource.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

LayoutTests:

  • http/tests/inspector/search/search-in-non-existing-resource-expected.txt: Added.
  • http/tests/inspector/search/search-in-non-existing-resource.html: Added.
19:17 Changeset [97701] by mihnea@adobe.com
  • 88 edits in trunk

[CSS Regions]Change content:-webkit-from-flow to -webkit-flow-from
https://bugs.webkit.org/show_bug.cgi?id=70104

Reviewed by David Hyatt.

  1. -webkit-flow-from is now a property instead of being an addition to content property.
  2. -webkit-flow-from takes an identifier instead of string.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseRegionThread):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/content-flowed-into-regions-no-scroll.html:
  • fast/regions/content-webkit-from-flow-parsing-expected.txt:
  • fast/regions/float-pushed-width-change.html:
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • fast/regions/flow-anonymous-children.html:
  • fast/regions/flow-content-basic-vertical-rl.html:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/flow-content-basic.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/hit-test-float.html:
  • fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
  • fast/regions/no-split-line-box.html:
  • fast/regions/outline-sides-in-region.html:
  • fast/regions/overflow-in-uniform-regions-dynamic.html:
  • fast/regions/overflow-in-uniform-regions.html:
  • fast/regions/overflow-in-variable-width-regions.html:
  • fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-rtl-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-with-stacking-context-rtl.html:
  • fast/regions/overflow-size-change-with-stacking-context.html:
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
  • fast/regions/percentage-margins-rtl-variable-width-regions.html:
  • fast/regions/percentage-margins-variable-width-regions.html:
  • fast/regions/position-writing-modes-in-variable-width-regions.html:
  • fast/regions/positioned-objects-block-static-in-regions.html:
  • fast/regions/positioned-objects-block-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-block-static-spanning-regions.html:
  • fast/regions/positioned-objects-in-regions.html:
  • fast/regions/positioned-objects-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-in-regions.html:
  • fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions.html:
  • fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
  • fast/regions/positioned-objects-spanning-regions.html:
  • fast/regions/region-element-dynamic-attach-flow.html:
  • fast/regions/region-element-dynamic-detach-flow.html:
  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • fast/regions/region-overflow-break.html:
  • fast/regions/render-region-renderer.html:
  • fast/regions/resources/region-style.css:

(.regionArticle):

  • fast/regions/script-tests/content-webkit-from-flow-parsing.js:

(testCSSText):
(testComputedStyle):

  • fast/regions/script-tests/region-element-display-restriction.js:

(createRegionElement):

  • fast/regions/text-region-breaks.html:
  • fast/regions/text-region-split-after-resize.html:
  • fast/regions/text-region-split-horizontal-bt.html:
  • fast/regions/text-region-split-small-pagination.html:
  • fast/regions/text-region-split-vertical-rl.html:
  • fast/regions/text-region-split-vertical.html:
  • fast/regions/text-region-split.html:
  • fast/regions/top-overflow-out-of-second-region.html:
  • fast/regions/webkit-flow-double-pagination-float-push.html:
  • fast/regions/webkit-flow-float-pushed-to-last-region.html:
  • fast/regions/webkit-flow-float-unable-to-push.html:
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html:
  • fast/regions/webkit-flow-inlines-dynamic.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • fast/repaint/line-flow-with-floats-in-regions.html:
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
  • fast/repaint/region-painting-via-layout.html:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
19:11 Changeset [97700] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Assign a bug for flaky layout tests
https://bugs.webkit.org/show_bug.cgi?id=70298

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
19:03 Changeset [97699] by dpranke@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

platform/chromium/compositing/plugins/webplugin* failing on cg snowleopard
https://bugs.webkit.org/show_bug.cgi?id=70294

Unreviewed, expectations change.

  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
18:55 Changeset [97698] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • DEPS:
18:50 Changeset [97697] by haraken@chromium.org
  • 9 edits in trunk

MessageEvent.data can be stored as ScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=68978

Reviewed by Hajime Morita.

Source/WebCore:

Currently, the following test cases fail or crash:

  • shouldBe("new MessageEvent('eventType', { data: test_object }).data", "test_object") -> FAIL
  • new MessageEvent('eventType', { data: document }).data -> CRASH

This is because MessageEvent.data is implemented just as SerializedScriptValue
and it cannot keep ScriptValue passed by JavaScript. This patch makes the following changes:

  • If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.

When MessageEvent.data is called, the ScriptValue is returned.

  • If MessageEvent is constructed with SerializedScriptValue, it is stored as

SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point because of lack of ExecState). When MessageEvent.data is called,
the SerializedScriptValue is deserialized into the corresponding ScriptValue,
and the ScriptValue is returned.

This patch does not make a fix for ObjC bindings code, since we need to first fix
the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.

Test: fast/events/constructors/message-event-constructor.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::JSMessageEvent::initMessageEvent): Changed SerializedScriptValue to ScriptValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
(WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::isMessageEvent): Removed extra spaces.

  • dom/MessageEvent.h: Added DataType::DataTypeScriptValue.

(WebCore::MessageEvent::create): Supported ScriptValue.
(WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
(WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
(WebCore::MessageEvent::dataAsString): Ditto.
(WebCore::MessageEvent::dataAsBlob): Ditto.
(WebCore::MessageEvent::dataAsArrayBuffer): Ditto.

  • dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part.

LayoutTests:

Removed failures and crashes.

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:
18:38 Changeset [97696] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Unified spell-checking and legacy spell checking should be easy to switch
https://bugs.webkit.org/show_bug.cgi?id=69242

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-17
Reviewed by Hajime Morita.

WebCore has two different code paths for spell-checking:

1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.

This patch introduces a flag to change code paths dynamically.
This patch also includes build fix for QT, GTK, and Windows platforms.

No new tests because this patch does not change a behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling):

Changed static if-USE(UNIFIED_TEXT_CHECKING) statement to dynamic
condition branch to achieve easy code path change.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm: ditto.

(AXAttributeStringSetSpelling):

  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling): ditto.
(WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): ditto.
(WebCore::Editor::markMisspellingsAfterTypingToWord): ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
(WebCore::Editor::changeBackToReplacedString): ditto.
(WebCore::Editor::markMisspellingsAndBadGrammar): ditto.
(WebCore::Editor::unifiedTextCheckerEnabled):

Utility method to check using unified text checking or not.

  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

Same as WebCore::AccessibilityObject::hasMisspelling.

(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::TextCheckingHelper::unifiedTextCheckerEnabled):

Utility method to check using unified text checking or not.

(WebCore::unifiedTextCheckerEnabled): ditto.

  • editing/TextCheckingHelper.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

Includes a flag to change the code path.

  • page/Settings.h:

(WebCore::Settings::setUnifiedTextCheckerEnabled):

Sets a flag to change the code path.

(WebCore::Settings::unifiedTextCheckerEnabled):

A flag to change the code path.

18:36 Changeset [97695] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 97691.

  • html/HTMLTableCellElement.h:

(WebCore::toHTMLTableCellElement): Avoid declaring the same function twice.

18:34 Changeset [97694] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add a missing semi-colon in ExternalPopupMenu.cpp
https://bugs.webkit.org/show_bug.cgi?id=70232

Patch by Peter Beverloo <peter@chromium.org> on 2011-10-17
Reviewed by Andreas Kling.

  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::didAcceptIndices):

18:33 Changeset [97693] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Unreviewed, rolling out r97661.
http://trac.webkit.org/changeset/97661

Confirmed this patch was not the cause of the test failures.

Source/WebCore:

display:inline-block elements don't correctly handle orthogonal writing-modes
https://bugs.webkit.org/show_bug.cgi?id=69957

Reading min/maxPreferredLogicalWidth from a child uses the child's writing-mode.
Instead, we need to grab the result based on the parent's writing-mode.
In the case of orthogonal writing-modes, we need the child's logical height.

Tests: fast/writing-mode/borders-expected.html

fast/writing-mode/borders.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

display:inline-block elements don't correctly handle orthogonal writing-modes
https://bugs.webkit.org/show_bug.cgi?id=69957

  • fast/writing-mode/borders-expected.html: Added.
  • fast/writing-mode/borders.html: Added.
18:24 Changeset [97692] by jamesr@google.com
  • 9 edits
    1 delete in trunk/Source

Unreviewed, rolling out r97690.
http://trac.webkit.org/changeset/97690
https://bugs.webkit.org/show_bug.cgi?id=70161

Hits assertion in CCLayerTreeHostTests

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCMainThread.h:
  • platform/graphics/chromium/cc/CCMainThreadTask.h:

(WebCore::createMainThreadTask):

  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Removed.
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::stop):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTest::endTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

  • tests/CCThreadTest.cpp:

(WebKit::PingPongTestUsingTasks::ping):

18:19 Changeset [97691] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove colSpan / rowSpan caching from RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=69569

Reviewed by Darin Adler.

Memory optimization, no change in behavior expected.

This change removes m_colSpan & m_rowSpan from RenderTableCell (inspired by
kling's memory shaving effort).

This makes us save 8 bytes per RenderTableCell on my machine (x86-64). No slowdown
on PageCycler Alexa-US.

This change refactored the way we handle updates from the DOM side to simplify
the code using the following: colspan / rowspan updates always go through
parseMappedAttribute where we already check for the renderer type. Thus removed the
generic updateFromElement and replaced it with colSpanOrRowSpanChanged. This removes
a virtual dispatch.

As there is no way to know if an attribute has changed in the parseMappedAttribute code,
we now unconditionally call colSpanOrRowSpanChanged. Looking at Chromium's page data,
colSpan and rowSpan are never changed outside the HTML markup thus such a change should
have a limited impact.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute): Updated after updateFromElement
removal.

  • html/HTMLTableCellElement.h:

(WebCore::toHTMLTableCellElement): Added the usual conversion functions.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell): Added a boolean to know if we have
the right type of associated DOM node to avoid the cost of checking that every
time.

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Forwarded the calls to our object if we have the right type (normal case).

(WebCore::RenderTableCell::colSpanOrRowSpanChanged): Handles the
updateFromElement calls but in a more streamlined way.

  • rendering/RenderTableCell.h:
18:15 Changeset [97690] by jamesr@google.com
  • 9 edits
    1 add in trunk/Source

[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.

(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

18:12 Changeset [97689] by tkent@chromium.org
  • 15 edits in branches/chromium/874

Merge 97351 - REGRESSION(r89915): <input type=email multiple> don't show the default value
https://bugs.webkit.org/show_bug.cgi?id=69895

Reviewed by Hajime Morita.

Source/WebCore:

m_valueIfDirty became unexpectedly empty because
EmailInputType::sanitizeValue() returned an empty string for a
null input string.

To solve this issue, HTMLInputElement::sanitizeValue() checks
nullness, and remove the null check of sanitizeValue() of
InputType subclasses.
Also, we make InputType::sanitizeValue() const.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::sanitizeValue):

  • Make this const.
  • Remove null check.
  • html/ColorInputType.h: Make sanitizeValue() const.
  • html/EmailInputType.cpp:

(WebCore::EmailInputType::sanitizeValue): Make this const.

  • html/EmailInputType.h: Make sanitizeValue() const.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::sanitizeValue):
(WebCore::HTMLInputElement::updateValueIfNeeded):

  • html/InputType.cpp:

(WebCore::InputType::sanitizeValue):
Returns a null string if the input string is null, and
don't call InputType::sanitizeValue() in this case.

  • html/InputType.h: Make sanitizeValue() const.
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::sanitizeValue): Make this const.

  • html/NumberInputType.h: Make sanitizeValue() const.
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::sanitizeValue):

  • Make this const.
  • Remove null check.
  • html/RangeInputType.h: Make sanitizeValue() const.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::sanitizeValue): Make this const.

  • html/TextFieldInputType.h: Make sanitizeValue() const.

LayoutTests:

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:

TBR=tkent@chromium.org
BUG=http://code.google.com/p/chromium/issues/detail?id=99829
Review URL: http://codereview.chromium.org/8336009

18:10 Changeset [97688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r97641.
http://trac.webkit.org/changeset/97641
https://bugs.webkit.org/show_bug.cgi?id=70288

"This change may have broken mouse/hit-test coordinate tests."
(Requested by jeffm7 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • platform/Widget.cpp:

(WebCore::Widget::convertFromContainingWindow):
(WebCore::Widget::convertToContainingWindow):

18:07 Changeset [97687] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParser: Remove unused variable 'propertyComponents'
https://bugs.webkit.org/show_bug.cgi?id=70230

Patch by Andreas Kling <kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

(WebCore::CSSParser::markPropertyEnd):

17:56 Changeset [97686] by imasaki@chromium.org
  • 1 edit
    20 adds
    2 deletes in trunk/LayoutTests

[Chromium] rebaseline fullscreen layout tests using rebaseline tools.
https://bugs.webkit.org/show_bug.cgi?id=70165

Reviewed by David Levin.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-cg-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
  • platform/chromium-cg-mac/fullscreen/full-screen-zIndex-after-expected.png: Removed.
  • platform/chromium-linux/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-linux/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium/fullscreen/video-controls-override-expected.txt: Added.
17:54 Changeset [97685] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Update comments about transform hierarchy in CCLayerTreeHostCommon
https://bugs.webkit.org/show_bug.cgi?id=69765

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-17
Reviewed by James Robinson.

Only comments changed, no tests needed.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

17:46 Changeset [97684] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Make non-recognized keys work in events as well.
https://bugs.webkit.org/show_bug.cgi?id=69860

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
here: it has a select box with a few non-latin options, and one of them
is selected via the keyboard.

In this specific case, we need to make EventHandler::keyEvent send a
keyPressEvent to SelectElement, so that
SelectElement::defaultEventHandler calls typeAheadFind(). This happens
only when PlatformKeyEvent::text() is not empty, which was not the case
so far.

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

17:45 Changeset [97683] by jchaffraix@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests
ASSERTION FAILED: !m_layoutRoot->container()
!m_layoutRoot->container()->needsLayout() with generated content

https://bugs.webkit.org/show_bug.cgi?id=61411

Reviewed by Andy Estes.

The bug was fixed by r95926 or bug 62120. Landing the tests from the bug.

  • fast/dynamic/crash-generated-counter-expected.txt: Added.
  • fast/dynamic/crash-generated-counter.html: Added.
  • fast/dynamic/crash-generated-image-expected.txt: Added.
  • fast/dynamic/crash-generated-image.html: Added.
  • fast/dynamic/crash-generated-quote-expected.txt: Added.
  • fast/dynamic/crash-generated-quote.html: Added.
  • fast/dynamic/crash-generated-text-expected.txt: Added.
  • fast/dynamic/crash-generated-text.html: Added.
17:44 Changeset [97682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Do not check for Frame::contentRenderer() in ewk_view_repaint.
https://bugs.webkit.org/show_bug.cgi?id=70118

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Kenneth Rohde Christiansen.

When we have a scrollbar with an actual width, there might be a call
to ChromeClientEfl::invalidateContentsAndWindow() after
Document::detach() was called, making the call to contentRenderer()
return 0 even though everything is fine.

Example test case: animations/animation-shorthand.html.

  • ewk/ewk_view.cpp:

(ewk_view_repaint):

17:41 Changeset [97681] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Filtering of URLs when serializing back forward list saves bad current index value
https://bugs.webkit.org/show_bug.cgi?id=70282
<rdar://problem/10057763>

Reviewed by Sam Weinig.

When reading the serialized b-f list, perform a sanity check on the current index.
If it is invalid, we set it to NoCurrentItemIndex to prevent further corruption of
the list.

When serializing the b-f list, currentIndex can be negative in the case where the list
has one item only, and that item gets filtered out. In this instance currentIndex should
just be -1. A crashing case showed an index that was more negative, a situation that I
could not replicate. Since this value will get cleaned up when the b-f list is restored,
I just strengthened the assertion to check for a more negative index in case we run into it again.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the assertion
in case we go beyond NoCurrentItemIndex (which, as an int, is -1).
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

17:36 BuildingGtk edited by mrobinson@webkit.org
(diff)
17:33 Changeset [97680] by barraclough@apple.com
  • 5 edits in trunk

Exception ordering in String.prototype.replace
https://bugs.webkit.org/show_bug.cgi?id=70290

Source/JavaScriptCore:

If pattern is not a regexp, it should be converted toString before the replacement value has it's toString conversion called.

Reviewed by Oliver Hunt.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

LayoutTests:

Reviewed by Oliver Hunt.

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
    • Check in passing results.
17:26 Changeset [97679] by vrk@chromium.org
  • 4 edits in branches/chromium/874/Source

Merge 97451 - Clear WebMediaPlayerClientImpl back pointer on destruction
https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):

  • platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

  • src/WebMediaPlayerClientImpl.h:

TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/8333009

17:07 Changeset [97678] by alokp@chromium.org
  • 6 edits
    12 adds in trunk

Add layout tests for WebPlugin compositor path
https://bugs.webkit.org/show_bug.cgi?id=69027

Reviewed by James Robinson.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printEnd):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestWebPlugin.cpp: Added.

(premultiplyAlpha):
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::~TestWebPlugin):
(TestWebPlugin::mimeType):
(TestWebPlugin::initialize):
(TestWebPlugin::destroy):
(TestWebPlugin::updateGeometry):
(TestWebPlugin::parsePrimitive):
(TestWebPlugin::parseColor):
(TestWebPlugin::parseOpacity):
(TestWebPlugin::initScene):
(TestWebPlugin::drawScene):
(TestWebPlugin::destroyScene):
(TestWebPlugin::initProgram):
(TestWebPlugin::initPrimitive):
(TestWebPlugin::drawPrimitive):
(TestWebPlugin::loadShader):
(TestWebPlugin::loadProgram):

  • DumpRenderTree/chromium/TestWebPlugin.h: Added.

(TestWebPlugin::scriptableObject):
(TestWebPlugin::paint):
(TestWebPlugin::updateFocus):
(TestWebPlugin::updateVisibility):
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin::handleInputEvent):
(TestWebPlugin::didReceiveResponse):
(TestWebPlugin::didReceiveData):
(TestWebPlugin::didFinishLoading):
(TestWebPlugin::didFailLoading):
(TestWebPlugin::didFinishLoadingFrameRequest):
(TestWebPlugin::didFailLoadingFrameRequest):
(TestWebPlugin::Scene::Scene):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

LayoutTests:

  • platform/chromium/compositing/plugins: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha.html: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha.html: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection.html: Added.
16:57 Changeset [97677] by cfleizach@apple.com
  • 3 edits in trunk/Source/WebKit/chromium

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Build fix. Fix matching enums.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
16:54 Changeset [97676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Set a default charset when creating a view.
https://bugs.webkit.org/show_bug.cgi?id=69771

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

Most (or all) ports default to iso-8859-1 when creating a view (or their
equivalent of a view), so we should do that too.

This makes fast/dom/Document/document-charset.html pass.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

16:54 Changeset [97675] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG bytecode parser should understand inline stacks
https://bugs.webkit.org/show_bug.cgi?id=70278

Reviewed by Oliver Hunt.

The DFG bytecode parser is now capable of parsing multiple code blocks at
once. This remains turned off since not all inlining functionality is
implemented.

This required making a few changes elsewhere in the system. The bytecode
parser now may do some of the same things that the bytecode generator does,
like allocating constants and identifiers. Basic block linking relies on
bytecode indices, which are only meaningful within the context of one basic
block. This is fine, so long as linking is done eagerly whenever switching
from one code block to another.

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::InlineStackEntry::executable):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.h:

(JSC::DFG::GetBytecodeBeginForBlock::GetBytecodeBeginForBlock):
(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):

  • dfg/DFGNode.h:
  • runtime/Identifier.h:

(JSC::IdentifierMapIndexHashTraits::emptyValue):

  • runtime/JSValue.h:
  • wtf/StdLibExtras.h:

(WTF::binarySearchWithFunctor):

16:51 Changeset [97674] by dimich@chromium.org
  • 4 edits in branches/chromium/874/Source/WebCore

Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/8333006

16:49 Changeset [97673] by barraclough@apple.com
  • 9 edits in trunk

Incorrect behavior from String match/search & undefined pattern
https://bugs.webkit.org/show_bug.cgi?id=70286

Reviewed by Sam weinig.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):

  • In case of undefined, pattern is "".

(JSC::stringProtoFuncSearch):

  • In case of undefined, pattern is "".

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    • Check in passing results.
16:42 Changeset [97672] by rniwa@webkit.org
  • 5 edits in trunk/Tools

[nrwt] Add new category for MISSING
https://bugs.webkit.org/show_bug.cgi?id=69990

Reviewed by Dirk Pranke.

Treat missing results as a new category in summerize_results.

Because Chromium port wants to turn bots red when there are tests with missing results,
extracted the logic to compute the exit code as exit_code_from_summarized_results in
base and chromium ports.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
16:41 Changeset [97671] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary calls to columnRectAt()
https://bugs.webkit.org/show_bug.cgi?id=70283

Reviewed by Darin Adler.

These call sites only needed one of the column dimensions, which are independent of the column
index, and can be retrieved directly from the ColumnInfo.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::hitTestColumns):

16:40 Changeset [97670] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Patch by Andreas Kling <kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

Add debug-only checks in Element's fastHasAttribute() and fastGetAttribute() to verify
that we aren't looking up the "style" attribute or any of the SVG animatable attributes.

No new tests, erroneous behavior is covered by assertions.

  • WebCore.exp.in: Export Element::fastAttributeLookupAllowed() for debug builds

since it's used by the inline fast*Attribute() calls.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Use getAttribute() for class.

  • css/SelectorChecker.cpp:

(WebCore::linkAttribute): Use getAttribute() for xlink:href.

  • dom/Element.cpp:

(WebCore::Element::getAttribute): Manually inline fastGetAttribute() in ideal case.
(WebCore::Element::fastAttributeLookupAllowed): Checks if an attribute can be used
with the fast lookup functions.

  • dom/Element.h:

(WebCore::Element::fastHasAttribute): Add assertion.
(WebCore::Element::fastGetAttribute): Ditto.

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute): Use getAttribute() for class.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle): Ditto.

  • html/ClassList.cpp:

(WebCore::ClassList::ClassList): Ditto.
(WebCore::ClassList::addInternal): Ditto.
(WebCore::ClassList::removeInternal): Ditto.
(WebCore::ClassList::toString): Ditto.

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements): Use getAttribute() for xlink:href.

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::rotateMode): Use getAttribute() for rotate.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::animationMode): Use getAttribute() for values.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isAnimatableAttribute): Added, returns true if the given
QualifiedName represents an animatable attribute.

  • svg/SVGElement.h:
  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::srcValue): Use getAttribute() for xlink:href.
(WebCore::SVGFontFaceUriElement::loadFont): Ditto.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::xlinkHref): Ditto.

  • svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::hasValidGlyphElement): Ditto.

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::type): Use getAttribute() for type.

16:37 Changeset [97669] by cfleizach@apple.com
  • 17 edits
    4 adds in trunk

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityMockObject.cpp:

(WebCore::AccessibilityMockObject::AccessibilityMockObject):

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::isMockObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySpinButton.cpp: Added.

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h: Added.

(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html5-input-number-expected.txt: Added.
  • platform/mac/accessibility/html5-input-number.html: Added.
16:34 Changeset [97668] by lforschler@apple.com
  • 8 edits in tags/Safari-535.6.2/Source

Merged r97514.

16:30 Changeset [97667] by dimich@chromium.org
  • 5 edits
    3 adds in trunk/Source/WebCore

Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

16:26 Changeset [97666] by lforschler@apple.com
  • 5 edits in tags/Safari-535.6.2/Source

Versioning.

16:22 Changeset [97665] by lforschler@apple.com
  • 1 copy in tags/Safari-535.6.2

New Tag.

16:15 Changeset [97664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

quote "attributes" keyword in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=64348

Patch by Arno Renevier <arno@renevier.net> on 2011-10-17
Reviewed by Darin Adler.

No change of functionality. No new tests.

  • bindings/scripts/CodeGeneratorGObject.pm:
16:12 Changeset [97663] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

More tweaking of chromium fullscreen expectations.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
15:56 Changeset [97662] by ojan@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97654.
http://trac.webkit.org/changeset/97654
https://bugs.webkit.org/show_bug.cgi?id=68497

Caused a number of Chromium failures.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.png:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
15:53 Changeset [97661] by ojan@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r97653.
http://trac.webkit.org/changeset/97653
https://bugs.webkit.org/show_bug.cgi?id=69957

Caused a number of Chromium failures.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/writing-mode/borders-expected.html: Removed.
  • fast/writing-mode/borders.html: Removed.
15:38 Changeset [97660] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fullscreen/video-controls-override.html is still failing on chromium bots.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
15:31 Changeset [97659] by adamk@chromium.org
  • 13 edits
    2 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for attributes
https://bugs.webkit.org/show_bug.cgi?id=68956

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-attributes.html

This adds an initial implementation for registering mutation observers on nodes,
delivering mutation records at the end of the outer-most script invokation and
observing mutations to element attributes.

Note that the outer-most script invokation only works in V8.

Note also that support for observing changes to the style attribute when updated
via the style property is not implemented here.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createAttributes):

  • dom/MutationRecord.h:
  • dom/MutationRecord.idl:
  • dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverData):
(WebCore::Node::ensureMutationObserverData):
(WebCore::Node::registeredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::deregisterMutationObserver):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::operator==):
(WebCore::MutationObserverData::MutationObserverData):
(WebCore::MutationObserverData::~MutationObserverData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::wasDeregistered):
(WebCore::activeMutationObservers):
(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt: Added.
  • fast/mutation/observe-attributes.html: Added.
15:30 Changeset [97658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLKeygenElement: Don't cache keytype and challenge attributes.
https://bugs.webkit.org/show_bug.cgi?id=68365

Patch by Andreas Kling <kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::parseMappedAttribute):
(WebCore::HTMLKeygenElement::appendFormData):

  • html/HTMLKeygenElement.h:
15:21 Changeset [97657] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Update chromium gpu baselines for fast/canvas/canvas-composite-transformclip.html .

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
14:54 Changeset [97656] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove some expectations that are no longer failing.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
14:51 Changeset [97655] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=70207
After deleting defineSetter, it is absent but appears in name list

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

  • This should check whether static functions have been reified.

LayoutTests:

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js:
    • Added test case for getOwnPropertyNames.
14:50 Changeset [97654] by ojan@chromium.org
  • 9 edits in trunk

incorrect height with height:auto and writing-mode:vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=68497

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

I'm not sure I completely understand the changes to the height/width
of the body/html elements, but the new height/width look correct to me.

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
14:46 Changeset [97653] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

display:inline-block elements don't correctly handle orthogonal writing-modes
https://bugs.webkit.org/show_bug.cgi?id=69957

Reviewed by David Hyatt.

Source/WebCore:

Reading min/maxPreferredLogicalWidth from a child uses the child's writing-mode.
Instead, we need to grab the result based on the parent's writing-mode.
In the case of orthogonal writing-modes, we need the child's logical height.

Tests: fast/writing-mode/borders-expected.html

fast/writing-mode/borders.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/writing-mode/borders-expected.html: Added.
  • fast/writing-mode/borders.html: Added.
14:42 Changeset [97652] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations change.

Add back in the failing fullscreen tests; also add in some
flaky failures.

  • platform/chromium/test_expectations.txt:
14:41 Changeset [97651] by arv@chromium.org
  • 4 edits in trunk/LayoutTests

REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
https://bugs.webkit.org/show_bug.cgi?id=70210

Reviewed by Darin Adler.

Change the test to not call debug() inside the test functions since that fails on V8
because we are already at the maximum allowed stack depth.

  • fast/js/script-tests/stack-overflow-arrity-catch.js:

(test1): Changed to not call debug but set a boolean variable that is later checked.
(test2): Ditto.

  • fast/js/stack-overflow-arrity-catch-expected.txt:
  • platform/chromium/test_expectations.txt:
14:29 Changeset [97650] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Mac build fix.

14:22 Changeset [97649] by dimich@chromium.org
  • 5 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r97643.
http://trac.webkit.org/changeset/97643
https://bugs.webkit.org/show_bug.cgi?id=70270

Broke iframe reparenting tests (Requested by dimich on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Removed.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Removed.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Removed.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument):

14:14 Changeset [97648] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

14:09 Changeset [97647] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Removing suppressions for the fullscreen/ tests - it looks
like they're mostly passing now. I will pick up the tests that
are still failing in a subsequent patch.

  • platform/chromium/test_expectations.txt:
13:58 Changeset [97646] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • heap/HandleStack.cpp: Added a missing #include.
13:58 Changeset [97645] by leandro@webkit.org
  • 4 edits in trunk

Unreviewed; actually enable/disable microdata support in CMake.

Follow-up to r97471, which did not plug the option to enable/disable
microdata into the buildsystem.

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_MICRODATA feature, turned off by default.
  • Source/cmake/OptionsWinCE.cmake: Ditto.
  • Source/cmakeconfig.h.cmake: Add ENABLE_MICRODATA #cmakedefine.
13:51 Changeset [97644] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix.

longer existant symbol.

  • heap/MarkStack.cpp:

(JSC::MarkStackArray::shrinkAllocation): Cast to the right type.

13:46 Changeset [97643] by dimich@chromium.org
  • 5 edits
    4 adds in trunk/Source/WebCore

window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

13:43 Changeset [97642] by ggaren@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Simplified GC marking logic
https://bugs.webkit.org/show_bug.cgi?id=70258

Reviewed by Filip Pizlo.

No perf. change.

This is a first step toward GC allocating string backing stores, starting
with ropes. It also enables future simplifications and optimizations.

  • Replaced some complex mark stack logic with a simple linear stack of

JSCell pointers.

  • Replaced logic for short-circuiting marking based on JSType and/or

Structure flags with special cases for object, array, and string.

  • Fiddled with inlining for better codegen.
  • heap/Heap.cpp:

(JSC::Heap::Heap): Provide more vptrs to SlotVisitor, for use in marking.

  • heap/HeapRootVisitor.h: Removed unused functions that no longer build.
  • heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::shrinkAllocation):
(JSC::MarkStack::reset):
(JSC::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):
(JSC::MarkStack::internalAppend): Replaced complex mark set logic with
simple linear stack.

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::SlotVisitor): Updated for above changes.

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSArray.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • runtime/JSObject.h: Don't inline visitChildren; it's too big.
  • runtime/Structure.h:

(JSC::MarkStack::internalAppend): Nixed the short-circuit for CompoundType
because it prevented strings from owning GC pointers.

  • runtime/WriteBarrier.h:

(JSC::MarkStack::appendValues): No need to validate; internalAppend will
do that for us.

13:29 Changeset [97641] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Widget window coordinate functions should use root view coordinate functions
https://bugs.webkit.org/show_bug.cgi?id=70152

Reviewed by Darin Adler.

No new tests, no changes to functionality.

  • platform/Widget.cpp:

(WebCore::Widget::convertFromContainingWindow): Use convertFromRootView().
(WebCore::Widget::convertToContainingWindow): Use convertToRootView().

13:15 Changeset [97640] by cmarrin@apple.com
  • 8 edits in trunk/Source

Throttle rate of requestAnimationFrame when page is not visible
https://bugs.webkit.org/show_bug.cgi?id=67873

Reviewed by Anders Carlsson.

Source/WebCore:

Add logic to suspend and resume scripted animations when page is hidden,
minimized or the tab is not visible. The hide/minimize notification comes
in from WebKit/WebKit2 to a new set of functions.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::didMoveOnscreen):
(WebCore::Page::willMoveOffscreen):
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):

  • page/Page.h:

Source/WebKit/mac:

Plumb through notification when the window is hidden/shown or
minimized/unminimized

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

Source/WebKit2:

Plumb through notification when the window is hidden/shown or
minimized/unminimized

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):

13:03 Changeset [97639] by noam.rosenthal@nokia.com
  • 25 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

  • UIProcess/LayerTreeHostProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

  • WebProcess/WebPage/LayerTreeHost.messages.in: Added.
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

12:49 Changeset [97638] by antti@apple.com
  • 21 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=69966
Eliminate separate RenderStyle for visited link style

Reviewed by Dave Hyatt and Nikolas Zimmermann.

There are only a few properties that can apply to visited links and they can
be part of the regular style. Many things will get simpler when the separate
RenderStyle for visited links is eliminated.

  • Add valid visited link properties as separate fields to RenderStyle. The visitedLinkColor goes to inherited, everything else goes to rare data structures.
  • Make RenderStyle::visitedDependentColor() get the visited style from the new fields.
  • As VISITED_LINK pseudo style doesn't exists anymore, remove all code dealing with it.
  • Make CSSStyleSelector and ApplyPropertyColor apply the visited link style to the newly added fields instead of a separate RenderStyle.
  • Same thing with SVGRenderStyle, SVGCSSStyleSelector.
  • Fixup the SVG visited link style code to use the new fields.

This is ~15% progression in styleForElement performance over the HTML5 spec load.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::applyPropertyToRegularStyle):
(WebCore::CSSStyleSelector::applyPropertyToVisitedLinkStyle):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setVisitedLinkColor):
(WebCore::InheritedFlags::setVisitedLinkBackgroundColor):
(WebCore::InheritedFlags::setVisitedLinkBorderLeftColor):
(WebCore::InheritedFlags::setVisitedLinkBorderRightColor):
(WebCore::InheritedFlags::setVisitedLinkBorderBottomColor):
(WebCore::InheritedFlags::setVisitedLinkBorderTopColor):
(WebCore::InheritedFlags::setVisitedLinkOutlineColor):
(WebCore::InheritedFlags::setVisitedLinkColumnRuleColor):
(WebCore::InheritedFlags::setVisitedLinkTextEmphasisColor):
(WebCore::InheritedFlags::setVisitedLinkTextFillColor):
(WebCore::InheritedFlags::setVisitedLinkTextStrokeColor):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setVisitedLinkFillPaint):
(WebCore::SVGRenderStyle::setVisitedLinkStrokePaint):
(WebCore::SVGRenderStyle::visitedLinkFillPaintType):
(WebCore::SVGRenderStyle::visitedLinkFillPaintColor):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintType):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintColor):

  • rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleFillData::StyleFillData):
(WebCore::StyleFillData::operator==):
(WebCore::StyleStrokeData::StyleStrokeData):
(WebCore::StyleStrokeData::operator==):

  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleInheritedData.cpp:

(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):

  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):

  • rendering/style/StyleMultiColData.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

12:22 Changeset [97637] by eric.carlson@apple.com
  • 12 edits
    2 adds in trunk/Source/WebCore

2011-10-17 Eric Carlson <eric.carlson@apple.com>

Cues should be loaded by the cached resource loader
https://bugs.webkit.org/show_bug.cgi?id=70134

Reviewed by Darin Adler.

No new tests, changes covered by existing tests.

  • CMakeLists.txt: Add CachedCues.cpp/h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • loader/cache/CachedCues.cpp: Added. (WebCore::CachedCues::CachedCues): (WebCore::CachedCues::~CachedCues): (WebCore::CachedCues::data): Called when new data has been loaded, pass it to all registered

clients.

  • loader/cache/CachedCues.h: Added.
  • loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType): Cues have low loader priority.
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceClient.h: (WebCore::CachedResourceClient::didReceiveData): New client interface.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): Create and return a new cue loader. (WebCore::CachedResourceLoader::requestCues): (WebCore::CachedResourceLoader::checkInsecureContent): Cues aren't mentioned in the CPS spec

yet, but they only work with a media element so use the mdia policy.

(WebCore::CachedResourceLoader::canRequest): Allow cues to be loaded from any origin like media.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):
  • platform/network/chromium/ResourceRequest.h:
12:09 Changeset [97636] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source

Merge 97546 - [Chromium] Some WebSQLDatabase in worker bug fixes.

BUG=71551
Review URL: http://codereview.chromium.org/8317017

11:20 Changeset [97635] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/10293929> REGRESSION (r97525): iChat transcript has horizontal scroll bar when the conversation includes a wide image
https://bugs.webkit.org/show_bug.cgi?id=70204

Reviewed by Darin Adler.

Source/WebCore:

Reverted r97525, which was supposed to fix <http://webkit.org/b/29447>.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/replaced/table-percent-width-expected.txt: Updated the results to

show that this test is failing after reverting r97525.

11:17 Changeset [97634] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

garden-o-matic operations fail because of CSP.
https://bugs.webkit.org/show_bug.cgi?id=70249

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
10:55 Changeset [97633] by adachan@apple.com
  • 7 edits
    1 add in trunk

Source/WebCore: Export KURL::baseAsString() so it can be called in WebProcessProxy::assumeReadAccessToBaseURL() in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

No new tests. There is no change in functionality.

  • WebCore.exp.in: Export KURL::baseAsString().

Source/WebKit2: Calling WKPageLoadAlternateHTMLString() where baseURL does not point to a directory causes an invalid message to be returned from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::assumeReadAccessToBaseURL): Add the file path of url's base URL to m_localPathsWithAssumedReadAccess,
since url may not point to a directory.

Tools: Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add the new file.

10:24 Changeset [97632] by rniwa@webkit.org
  • 3 edits
    1 copy
    1 move in trunk

Source/WebCore: Touch Internals.cpp to make 64-bit GTK+ build happy.

  • testing/Internals.cpp:

LayoutTests: Moved V8-specific result to platform/chromium and added JSC result in cross-platform directory.

  • fast/files/url-required-arguments-expected.txt: Replaced with

LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt.

  • platform/chromium/fast/files/url-required-arguments-expected.txt: Copied from

LayoutTests/fast/files/url-required-arguments-expected.txt.

  • platform/qt/fast/files/url-required-arguments-expected.txt: Removed.
10:12 Changeset [97631] by rniwa@webkit.org
  • 2 edits in trunk

GTK build fix patch by Gustavo Noronha Silva.

  • Source/autotools/symbols.filter:
10:09 Changeset [97630] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=70245

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-17

  • platform/qt-wk2/Skipped:
10:01 Changeset [97629] by cfleizach@apple.com
  • 13 edits in trunk/Source/WebCore

AX: children() method should be consolidated in AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=70243

Code cleanup, no new tests.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::children):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::addChildren):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilitySlider.cpp:
  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:
  • accessibility/AccessibilityTableHeaderContainer.h:
09:56 Changeset [97628] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Search matches highlighting in text does not work correctly.
https://bugs.webkit.org/show_bug.cgi?id=70244

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/utilities-highlight-results.html

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • inspector/utilities-highlight-results-expected.txt: Added.
  • inspector/utilities-highlight-results.html: Added.
09:47 Changeset [97627] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: webkit won't always send live region notifications
https://bugs.webkit.org/show_bug.cgi?id=70030

Source/WebCore:

Webkit purposefully does not send live region notifications if some AT client has not accessed the AX tree in between
the last live region update (ostensibly to improve performance).
However, this is problematic if a screen reader misses one notification... it has no idea what happened and the only
recourse is to rescan the page for changes. The correct thing to do is to always send notifications.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-liveregions-notifications-always-sent.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged):

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-notifications-always-sent.html: Added.
09:26 Changeset [97626] by darin@apple.com
  • 5 edits in trunk/Tools

Add some more *.pyc ignores in directories with Python scripts.

  • QueueStatusServer: Added property svn:ignore.
  • Scripts/webkitpy/common/watchlist: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
09:25 Changeset [97625] by darin@apple.com
  • 2 edits in trunk/LayoutTests

Cleared a stray executable bit.

  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed property svn:executable.
09:23 Changeset [97624] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] Add methods to get/set a custom text enconding to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69524

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_custom_charset):
(webkit_web_view_set_custom_charset):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCustomCharset):
(beforeAll):

08:28 Changeset [97623] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2][meta] Fix failing API tests
https://bugs.webkit.org/show_bug.cgi?id=70236

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-10-17
Reviewed by Csaba Osztrogonác.

In order to run WebKit2 API tests we need the WebProcess to be in
the path so let's add the bin directory when running the API tests of Qt.

  • Scripts/run-qtwebkit-tests:
08:26 Changeset [97622] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=68456

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-17
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitdirs.pm:

(buildQMakeProject):

07:53 Changeset [97621] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: fix handling of source mapping entries with no mapping.
https://bugs.webkit.org/show_bug.cgi?id=69941

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

  • inspector/debugger/compiler-source-mapping-expected.txt:
  • inspector/debugger/compiler-source-mapping.html:
07:21 Changeset [97620] by aroben@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536, part 3

  • runtime/JSAPIValueWrapper.h:
  • runtime/JSObject.h:

Use JS_EXPORTDATA to export the s_info members.

07:10 Changeset [97619] by tkent@chromium.org
  • 33 edits
    48 adds
    7 deletes in trunk/LayoutTests

[Chromium] Update test expectations for r97596 and r97602.

  • platform/chromium-cg-mac-leopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-linux/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/chromium-linux/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-linux/fast/selectors/017-expected.png:
  • platform/chromium-linux/fast/selectors/061-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
  • platform/chromium-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26553-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug26553-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
  • platform/chromium-mac/fast/selectors/017-expected.png: Removed.
  • platform/chromium-mac/fast/selectors/061-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46623-1-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51140-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug8950-expected.png: Removed.
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/chromium-win/fast/dom/34176-expected.txt:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.txt:
  • platform/chromium-win/fast/selectors/017-expected.png:
  • platform/chromium-win/fast/selectors/017-expected.txt:
  • platform/chromium-win/fast/selectors/061-expected.png:
  • platform/chromium-win/fast/selectors/061-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/chromium/test_expectations.txt:
07:03 Changeset [97618] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r97564

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Moved declaration of globalData variable into ENABLE(JIT) blocks, since it is only used
there.

07:02 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
07:01 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
07:01 Changeset [97617] by ossy@webkit.org
  • 17 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update Qt specific expected results after r97602.

  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/qt/fast/selectors/017-expected.png:
  • platform/qt/fast/selectors/017-expected.txt:
  • platform/qt/fast/selectors/061-expected.png:
  • platform/qt/fast/selectors/061-expected.txt:
07:01 Changeset [97616] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a passing test and add platform specific expected result.

  • platform/qt/Skipped:
  • platform/qt/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/qt/fast/events/reveal-link-when-focused-expected.txt: Added.
06:41 Changeset [97615] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536, part 2

JSC::setUpStaticFunctionSlot with its new mangled name. SOrted the rest of the file while I
was at it.

06:40 Changeset [97614] by zecke@webkit.org
  • 2 edits in trunk/Tools

[build] Introduce Qt/SH4 buildbot
https://bugs.webkit.org/show_bug.cgi?id=70227

Patch by Holger Hans Peter Freyther <holger@moiji-mobile.com> on 2011-10-17
Reviewed by Adam Roben.

Add buildslave for Linux/Qt/SH4.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
06:39 Changeset [97613] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: don't check for debugger pause details in interactive ui tests
https://bugs.webkit.org/show_bug.cgi?id=70228

Removed debugger pause details validation. The only check left is that debugger pause event is fired when expected.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testPauseWhenLoadingDevTools):
(.TestSuite.prototype.testPauseWhenScriptIsRunning.didEvaluateInConsole):
(.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause):
(.TestSuite.prototype.testPauseWhenScriptIsRunning):
(.TestSuite.prototype.testPauseInSharedWorkerInitialization):
(.TestSuite.prototype._waitForScriptPause):

06:25 Changeset [97612] by aroben@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix

Here's the error:

5>c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\obj\webcore\derivedsources\jssvgpathsegcurvetoquadraticrel.cpp(128) : fatal error C1128: number of sections exceeded object file format limit : compile with /bigobj

  • win/tools/vsprops/common.vsprops: Specify /bigobj to the compiler.
06:21 Changeset [97611] by mnaganov@chromium.org
  • 20 edits in trunk

Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
https://bugs.webkit.org/show_bug.cgi?id=61179

This is exteremely helpful when dealing with DOM wrappers, as
their properties are mostly implemented with getters and thus not
stored in heap snapshots.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showObjectPopover):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.get flags):
(WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromError):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

  • inspector/profiler/heap-snapshot.html:
05:58 Changeset [97610] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed export of

JSC::setUpStaticFunctionSlot, which no longer exists. Also removed incorrect exports of
s_info members, which need to be exported via JS_EXPORTDATA instead.

05:53 Changeset [97609] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Remove reference to third_party/skia/gpu.
It was removed from Chromium DEPS in Chromium r105526.

  • DEPS:
05:41 BuildingQt5OnHarmattan edited by christian.webkit@gmail.com
(diff)
05:41 Changeset [97608] by jesus@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
https://bugs.webkit.org/show_bug.cgi?id=69832

Reviewed by Kenneth Rohde Christiansen.

We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Implement serialization of ResourceResponse.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForResponse):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

05:38 BuildingQt5OnHarmattan edited by christian.webkit@gmail.com
(diff)
05:35 Changeset [97607] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
04:46 Changeset [97606] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted
https://bugs.webkit.org/show_bug.cgi?id=70018

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/commit-selector.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):

LayoutTests:

  • inspector/styles/commit-selector-expected.txt: Added.
  • inspector/styles/commit-selector.html: Added.
04:38 Changeset [97605] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSS/XSLStyleSheet: Remove insert() and remove().
https://bugs.webkit.org/show_bug.cgi?id=70226

Reviewed by Antti Koivisto.

Remove insert() and remove() from XSLStyleSheet. CSSStyleSheet retains remove()
since it's used by InspectorStyleSheet as well as SVGFontFaceElement.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::remove):

Remove range check. This method is internal to WebKit and the call sites
already take care of it.

(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
04:16 Changeset [97604] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=70224

  • platform/chromium/test_expectations.txt:

Mark some tests failing until bots have test results.

04:09 Changeset [97603] by commit-queue@webkit.org
  • 2 edits in trunk

[webkit]Debug Build Bot failure
https://bugs.webkit.org/show_bug.cgi?id=70222

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-17
Reviewed by Xan Lopez.

  • Source/autotools/symbols.filter: Corrected the filter name for getLocationAndLengthFronRange
03:38 Changeset [97602] by antti@apple.com
  • 17 edits in trunk/LayoutTests

Make more :visited pseudo class tests work
https://bugs.webkit.org/show_bug.cgi?id=70224

Reviewed by Andreas Kling.

Link <a href=""> is always considered visited so we can use that in tests that try to apply :visited.

Mac results only, requires rebaselining of other platforms.

  • css3/selectors3/html/css3-modsel-17.html:
  • css3/selectors3/html/css3-modsel-61.html:
  • css3/selectors3/xhtml/css3-modsel-17.xml:
  • css3/selectors3/xhtml/css3-modsel-61.xml:
  • css3/selectors3/xml/css3-modsel-17.xml:
  • css3/selectors3/xml/css3-modsel-61.xml:
  • fast/selectors/017.html:
  • fast/selectors/061.html:
  • platform/mac/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/mac/fast/selectors/017-expected.txt:
  • platform/mac/fast/selectors/061-expected.txt:
03:24 Changeset [97601] by ossy@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening after r97598. Remove obsolete Qt 4.8 specific expected results.

  • platform/qt-4.8/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug8950-expected.png: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug8950-expected.txt: Removed.
03:23 Changeset [97600] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=70219

  • platform/chromium/test_expectations.txt:

Mark some tests failing until bots have test results.

03:03 Changeset [97599] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/borders/border-radius-complex-inner-expected.png: Added after r97318.
  • platform/qt/fast/borders/border-radius-complex-inner-expected.txt: Added after r97318.
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.png: Added after r97481.
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.txt: Added after r97481.
  • platform/qt/fast/repaint/region-painting-via-layout-expected.png: Added after r97370.
  • platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Added after r97370.
02:51 Changeset [97598] by ossy@webkit.org
  • 19 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r97596.

  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/history/visited-link-background-color-expected.png:
  • platform/qt/fast/history/visited-link-background-color-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.png:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.txt:
02:18 Changeset [97597] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

when CSS pseudo selectors are applied (:before and :after) the *-of-line keyboard navigation does not work
https://bugs.webkit.org/show_bug.cgi?id=10123

Patch by Rosen Dash <rosen.dash@motorola.com> on 2011-10-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch addresses folllowing two issues:

  1. When CSS pseudo elements are before or after is used with content attribute containing single character at the start/end of text and we try to move cursor by right navigation key, the page freezes falling into an infinite loop.
  2. When these elements try to insert some text between a text line, navigation by right/left arrow key is prohibited.

Tests: editing/selection/css-pseudo-element-hang.html

editing/selection/css-pseudo-element.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

LayoutTests:

  • editing/selection/css-pseudo-element-expected.txt: Added.
  • editing/selection/css-pseudo-element-hang-expected.txt: Added.
  • editing/selection/css-pseudo-element-hang.html: Added.
  • editing/selection/css-pseudo-element.html: Added.
02:15 Changeset [97596] by antti@apple.com
  • 14 edits in trunk

Test :visited pseudo class
https://bugs.webkit.org/show_bug.cgi?id=70219

Source/WebCore:

Reviewed by Andreas Kling.

Currently DRT doesn't support :visited. All tests where it should match have wrong checked in results.

  • Make <a href=""> to match :visited in DRT. It already does on browsers. A number of existing tests for :visited use it already, the rest can be modified to use it.
  • Make render tree dumps correctly dump the visited state dependent color.
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkStateSlowCase):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

Reviewed by Andreas Kling.

Update Mac results for tests that already use <a href="">.

All other platforms need rebaselining too.

  • platform/mac/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/mac/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/mac/fast/dom/34176-expected.txt:
  • platform/mac/fast/events/reveal-link-when-focused-expected.txt:
  • platform/mac/fast/history/visited-link-background-color-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
02:04 Changeset [97595] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] test expectation update
https://bugs.webkit.org/show_bug.cgi?id=69624

  • platform/chromium/test_expectations.txt:

Correct expectation of zoom-animator-scale-test2.html.

02:02 Changeset [97594] by satish@chromium.org
  • 3 edits in trunk/Source/WebCore

Avoid leaking document when leaving google.com due to geolocation
permission request.
https://bugs.webkit.org/show_bug.cgi?id=58027

Reviewed by Kenneth Rohde Christiansen.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find): added
(WebCore::Geolocation::reset): cleared all pending notifiers.
(WebCore::Geolocation::clearWatch): removed from pending notifier set.

  • page/Geolocation.h:

(WebCore::Geolocation::Watchers::find): added

02:01 Changeset [97593] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r97436, r97506, r97532 and r97537.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

01:58 Changeset [97592] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WebKit2][gtk] Rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI
https://bugs.webkit.org/show_bug.cgi?id=70040

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-17
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitError.cpp:
  • UIProcess/API/gtk/WebKitError.h:
00:51 Changeset [97591] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix clang WebKitGTK+ build.

Patch by Andrei Lavreniyuk <andy.lavr@gmail.com> on 2011-10-17
Reviewed by Martin Robinson.

  • plugins/gtk/PluginViewGtk.cpp:
00:20 Changeset [97590] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectation.
https://bugs.webkit.org/show_bug.cgi?id=70013

  • platform/chromium/test_expectations.txt:

Add more cavas test crashes on Windows GPU.

10/16/11:

23:32 Changeset [97589] by abarth@webkit.org
  • 4 edits in trunk/Source

Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
https://bugs.webkit.org/show_bug.cgi?id=70216

Reviewed by Eric Seidel.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

No port enables this feature. It was added for the previous Android
port (and should have been an editing behavior in any case).

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

23:29 Changeset [97588] by wjmaclean@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

[chromium] Rebaseline layout test zoom-animator-scale-test2.html for win, mac
https://bugs.webkit.org/show_bug.cgi?id=69624

Reviewed by Kent Tamura.

Also modifies timeout in zoom-animator-scale-test2.html to try and reduce flake, generate
win baselines.

  • platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
  • platform/chromium/compositing/zoom-animator-scale-test2.html:
  • platform/chromium/test_expectations.txt:
23:05 Changeset [97587] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

Expose rangeFromLocationAndLength and locationAndLengthFromRange via internals object
https://bugs.webkit.org/show_bug.cgi?id=68330

Reviewed by Hajime Morita.

Source/WebCore:

Add rangeFromLocationAndLength, locationFromRange, and lengthFromRange to window.internals.

Test: editing/text-iterator/range-to-from-location-and-length.html

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::scrollElementToRect):
(WebCore::Internals::rangeFromLocationAndLength):
(WebCore::Internals::locationFromRange):
(WebCore::Internals::lengthFromRange):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add a basic test that uses internals.rangeFromLocationAndLength, internals.locationFromRange,
and internals.lengthFromRange.

  • editing/text-iterator/range-to-from-location-and-length-expected.txt: Added.
  • editing/text-iterator/range-to-from-location-and-length.html: Added.
23:02 Changeset [97586] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Generate MessageChannel constructor by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70214

Reviewed by Adam Barth.

This patch generates an MessageChannel constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires special logic.

Tests: fast/dom/global-constructors.html

fast/events/message-port.html
fast/events/message-port-no-wrapper.html
fast/dom/Window/window-postmessage-args.html

  • bindings/js/JSMessageChannelCustom.cpp: Removed the MessageChannel constructor.
  • dom/MessageChannel.idl: Generates the MessageChannel constructor for JSC.
22:44 Changeset [97585] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

[Mac] fontForSelection and styleForSelectionStart should be moved to EditorMac
https://bugs.webkit.org/show_bug.cgi?id=70114

Reviewed by Hajime Morita.

Moved fontForSelection and styleForSelectionStart from Editor to EditorMac
and made styleForSelectionStart static local.

  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/mac/EditorMac.mm:

(WebCore::styleForSelectionStart):
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

22:06 Changeset [97584] by haraken@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Generate EventSource constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70212

Reviewed by Adam Barth.

Removed JSEventSourceCustom.cpp.

Tests: fast/dom/global-constructors.html

fast/eventsource/eventsource-constructor.html
fast/eventsource/eventsource-attribute-listeners.html

  • GNUmakefile.list.am: Removed JSEventSourceCustom.cpp.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSEventSourceCustom.cpp: Removed this file.
  • page/EventSource.idl: Removed 'JSCustomConstructor' IDL.
21:27 Changeset [97583] by commit-queue@webkit.org
  • 11 edits
    1 delete in trunk/Source/WebCore

Inline CSSPrimitiveValue::isQuirkValue() as non-virtual function
https://bugs.webkit.org/show_bug.cgi?id=64865

Patch by David Barr <davidbarr@chromium.org> on 2011-10-16
Reviewed by Darin Adler.

Based on profiling and patch from:
Tamas Czene <Czene.Tamas@stud.u-szeged.hu>

This is expected to produce a small performance progression.
Additional memory overhead is avoided by using spare bits.
CSSQuirkPrimitiveValue is removed as it becomes just a factory.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive):

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::createAllowingMarginQuirk):
Moved from CSSQuirkPrimitiveValue::create.
(WebCore::CSSPrimitiveValue::isQuirkValue):

  • css/CSSQuirkPrimitiveValue.h: Removed.
  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

21:03 Changeset [97582] by tkent@chromium.org
  • 16 edits
    72 moves
    252 adds
    123 deletes in trunk/LayoutTests

Update test exepctations.

  • Add baseline files for new tests
  • Update for Skia focus ring change
  • Update for Mac spelling underline change
  • Optimize test results for them
  • css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt.
  • css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt.
  • editing/deleting/delete-3959464-fix-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-3959464-fix-expected.txt.
  • editing/deleting/delete-block-contents-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-block-contents-003-expected.txt.
  • editing/deleting/delete-trailing-ws-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt.
  • editing/deleting/delete-ws-fixup-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt.
  • editing/inserting/insert-br-004-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-004-expected.txt.
  • editing/inserting/insert-br-005-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-005-expected.txt.
  • editing/inserting/insert-br-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-007-expected.txt.
  • editing/inserting/insert-div-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-007-expected.txt.
  • editing/inserting/insert-div-012-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-012-expected.txt.
  • editing/inserting/insert-div-013-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-013-expected.txt.
  • editing/inserting/insert-div-014-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-014-expected.txt.
  • editing/inserting/insert-div-015-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-015-expected.txt.
  • editing/inserting/insert-div-016-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-016-expected.txt.
  • editing/inserting/insert-div-017-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-017-expected.txt.
  • editing/inserting/insert-div-018-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-018-expected.txt.
  • editing/inserting/insert-div-019-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-019-expected.txt.
  • editing/inserting/insert-div-020-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-020-expected.txt.
  • editing/inserting/insert-div-022-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-022-expected.txt.
  • editing/inserting/insert-div-025-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-025-expected.txt.
  • editing/inserting/insert-div-027-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-027-expected.txt.
  • editing/inserting/insert-tab-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-tab-002-expected.txt.
  • editing/inserting/insert-tab-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-tab-003-expected.txt.
  • editing/inserting/return-key-with-selection-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt.
  • editing/inserting/return-key-with-selection-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt.
  • editing/inserting/return-key-with-selection-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt.
  • editing/inserting/typing-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/typing-002-expected.txt.
  • editing/inserting/typing-around-br-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/typing-around-br-001-expected.txt.
  • editing/pasteboard/paste-text-013-expected.txt: Removed.
  • editing/pasteboard/paste-text-019-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/paste-text-019-expected.txt.
  • editing/selection/extend-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/extend-by-word-001-expected.txt.
  • editing/selection/move-backwords-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt.
  • editing/selection/move-by-character-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-character-001-expected.txt.
  • editing/selection/move-by-line-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-line-001-expected.txt.
  • editing/selection/move-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-word-001-expected.txt.
  • editing/style/block-styles-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/block-styles-007-expected.txt.
  • editing/style/create-block-for-style-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-002-expected.txt.
  • editing/style/create-block-for-style-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-003-expected.txt.
  • editing/style/create-block-for-style-004-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-004-expected.txt.
  • editing/style/create-block-for-style-006-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-006-expected.txt.
  • editing/style/create-block-for-style-008-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-008-expected.txt.
  • editing/style/create-block-for-style-009-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-009-expected.txt.
  • editing/style/create-block-for-style-011-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-011-expected.txt.
  • editing/style/create-block-for-style-012-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-012-expected.txt.
  • editing/style/create-block-for-style-013-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-013-expected.txt.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-016-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-018-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-020-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-022-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-027-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/spelling/inline_spelling_markers-expected.png:
  • platform/chromium-cg-mac-leopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-007-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-012-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-013-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-014-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-015-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-016-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-017-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-018-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-019-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-020-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-022-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-027-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/chromium-cg-mac/editing/deleting/delete-tab-003-expected.png: Removed.
  • platform/chromium-cg-mac/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
  • platform/chromium-cg-mac/editing/deleting/delete-ws-fixup-002-expected.png: Removed.
  • platform/chromium-cg-mac/editing/inserting/insert-tab-003-expected.png: Removed.
  • platform/chromium-cg-mac/editing/inserting/typing-around-br-001-expected.png: Removed.
  • platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-1-expected.png: Removed.
  • platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/5234383-1-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/5234383-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/select-from-textfield-outwards-expected.png: Removed.
  • platform/chromium-cg-mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
  • platform/chromium-cg-mac/editing/style/create-block-for-style-006-expected.png: Removed.
  • platform/chromium-cg-mac/editing/style/create-block-for-style-011-expected.png: Removed.
  • platform/chromium-cg-mac/editing/style/create-block-for-style-012-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac-leopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac-leopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac-leopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3928305-fix-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/delete-3928305-fix-expected.png.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-007-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-007-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-012-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-012-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-013-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-014-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-014-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-015-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-015-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-016-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-016-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-017-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-017-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-018-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-018-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-019-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-019-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-020-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-020-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-022-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-022-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-027-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-027-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-013-expected.png.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-014-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-014-expected.png.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.png.
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-002-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-003-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-003-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-004-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-006-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-006-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-008-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-009-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-009-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-011-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-012-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-013-expected.png.
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/5569741-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/5418891-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/typing-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Removed.
  • platform/chromium-mac/editing/selection/13804-expected.png: Removed.
  • platform/chromium-mac/editing/selection/5234383-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/5234383-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
  • platform/chromium-mac/editing/spelling/spelling-expected.png: Removed.
  • platform/chromium-mac/editing/style/5046875-2-expected.png: Removed.
  • platform/chromium-mac/editing/style/block-styles-007-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/height-width-inline-table-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/height-width-table-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/chromium/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-block-contents-003-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-br-004-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-br-005-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-br-007-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-007-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-012-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-013-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-014-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-015-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-016-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-017-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-018-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-019-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-020-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-022-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-025-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-027-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-tab-002-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-tab-003-expected.txt: Removed.
  • platform/mac/editing/inserting/return-key-with-selection-001-expected.txt: Removed.
  • platform/mac/editing/inserting/return-key-with-selection-002-expected.txt: Removed.
  • platform/mac/editing/inserting/return-key-with-selection-003-expected.txt: Removed.
  • platform/mac/editing/inserting/typing-002-expected.txt: Removed.
  • platform/mac/editing/inserting/typing-around-br-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-019-expected.txt: Removed.
  • platform/mac/editing/selection/extend-by-word-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-backwords-by-word-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-by-character-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-by-line-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-by-word-001-expected.txt: Removed.
  • platform/mac/editing/style/block-styles-007-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-002-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-003-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-004-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-006-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-008-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-009-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-011-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-012-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-013-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • platform/win/editing/inserting/insert-div-013-expected.txt: Removed.
  • platform/win/editing/inserting/insert-div-015-expected.txt: Removed.
  • platform/win/editing/inserting/insert-div-019-expected.txt: Removed.
  • platform/win/editing/inserting/insert-paragraph-03-expected.txt: Removed.
  • platform/win/editing/selection/move-by-word-001-expected.txt: Removed.
  • platform/win/editing/style/create-block-for-style-008-expected.txt: Removed.
20:13 Changeset [97581] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Generate XMLHttpRequest constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70208

Reviewed by Adam Barth.

This patch generates an XMLHttpRequest constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires a special logic.

Tests: fast/dom/global-constructors.html

fast/dom/XMLHttpRequest-constants.html
fast/dom/xmlhttprequest-constructor-in-detached-document.html
http/tests/security/cookies/xmlhttprequest.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: Removed an XMLHttpRequest custom constructor.
  • bindings/scripts/CodeGeneratorV8.pm: Currently, CodeGeneratorV8.pm generates constructor code whenever [Constructor] is specified, even if [V8CustomConstructor] is specified. This is wrong. This patch fixes the condition where the constructor code is generated.
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-binding-tests result.
  • xml/XMLHttpRequest.h: Added a necessary header.
  • xml/XMLHttpRequest.idl: V8 is still using a custom constructor.
19:02 Changeset [97580] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Generate XSLTProcessor constructor for JSC by [Constructor] IDL.
https://bugs.webkit.org/show_bug.cgi?id=70206

Reviewed by Adam Barth.

Tests: fast/xsl/xslt-processor.html

fast/xsl/default-html.html
fast/dom/global-constructors.html

  • bindings/js/JSXSLTProcessorCustom.cpp: Removed a custom constructor.
  • xml/XSLTProcessor.idl: Removed 'JSCustomConstructor'.
18:11 Changeset [97579] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[chromium] Remove PageAllocatorSymbian.h, OSAllocatorSymbian.cpp, gtk/ThreadingGtk.cpp from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=70205

Reviewed by James Robinson.

wtf/PageAllocatorSymbian.h and wtf/OSAllocatorSymbian.cpp were removed in r97557.
wtf/gtk/ThreadingGtk.cpp was removed in r97269.

16:30 Changeset [97578] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

Support [Constructor] IDL for JSC.
https://bugs.webkit.org/show_bug.cgi?id=70101

Reviewed by Adam Barth.

The spec for [Constructor] IDL is here: http://www.w3.org/TR/WebIDL/#Constructor
This patch introduced [Constructor] IDL for JSC. This patch also added
[ConstructorRaisesException] for JSC. If [ConstructorRaisesException] is specified,
a placeholder for ExceptionCode is passed to XXX::create(), like XXX::create(..., ec).

Notes:

  • We do not yet support constructor overloading.
  • We do not yet support [Optional] without CallWithDefaultValue for constructor arguments.

Tests: Source/WebCore/bindings/scripts/test/TestInterface.idl

Source/WebCore/bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Generates constructor declaration code to a header file, if a given DOM object has constructor.
(GenerateImplementation): Uses GenerateArgumentsCountCheck() and GenerateParametersCheck().
(GenerateArgumentsCountCheck): Splits out of GenerateImplementation() for reuse.
(GenerateParametersCheck): Splits out of GenerateImplementation() for reuse.
(GenerateConstructorDefinition): Generates constructor definition code.

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated the run-binding-tests results.

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionClassMethod):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto.

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):

14:37 Changeset [97577] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/files/url-required-arguments-expected.txt: Added.
12:19 Changeset [97576] by dslomov@google.com
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70186
Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.

Reviewed by Oliver Hunt.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):
(WebCore::JSDOMWindow::postMessage):
(WebCore::JSDOMWindow::webkitPostMessage):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
(WebCore::JSMessageEvent::initMessageEvent):
(WebCore::JSMessageEvent::webkitInitMessageEvent):

  • bindings/js/JSMessagePortCustom.h:

(WebCore::handlePostMessage):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::state):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:
08:55 Changeset [97575] by mitz@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
https://bugs.webkit.org/show_bug.cgi?id=70197

Reviewed by Dave Kilzer.

Source/WebCore:

Test: fast/block/float/avoidance-rtl.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Changed
logicalLeftOffsetForContent() to startOffsetForContent() to get the right value in the
right-to-left case.

LayoutTests:

  • fast/block/float/avoidance-rtl-expected.png: Added.
  • fast/block/float/avoidance-rtl-expected.txt: Added.
  • fast/block/float/avoidance-rtl.html: Added.
03:28 Changeset [97574] by abarth@webkit.org
  • 113 edits in trunk

Always enable ENABLE(DOM_STORAGE)
https://bugs.webkit.org/show_bug.cgi?id=70189

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we are reducing the complexity of WebKit by
removing unnecessary configuration options. DOMStorage is not a core
part of the web platform. It should always be enabled.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.exp.in:
  • WebCore.pro:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::storageIdCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:
  • dom/Document.cpp:

(WebCore::Document::createEvent):

  • dom/Event.cpp:

(WebCore::Event::isStorageEvent):

  • dom/Event.h:
  • dom/Node.cpp:
  • features.pri:
  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::storageIdImpl):

  • inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::init):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didUseDOMStorage):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):

  • inspector/generate-inspector-idl:
  • page/Chrome.cpp:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::localStorage):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates):

  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Page.cpp:
  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::closeLocalStorage):

  • page/PageGroup.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):

  • page/Settings.h:

(WebCore::Settings::sessionStorageQuota):

  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageTask.h:
  • storage/LocalStorageThread.cpp:
  • storage/LocalStorageThread.h:
  • storage/Storage.cpp:
  • storage/Storage.h:
  • storage/Storage.idl:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::scheduleSync):

  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp:
  • storage/StorageEvent.h:
  • storage/StorageEvent.idl:
  • storage/StorageEventDispatcher.cpp:
  • storage/StorageEventDispatcher.h:
  • storage/StorageMap.cpp:
  • storage/StorageMap.h:
  • storage/StorageNamespace.cpp:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

  • storage/StorageSyncManager.h:
  • storage/StorageTracker.cpp:
  • storage/StorageTracker.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/StorageAreaProxy.cpp:
  • src/StorageAreaProxy.h:
  • src/StorageEventDispatcherChromium.cpp:
  • src/StorageEventDispatcherImpl.cpp:
  • src/StorageEventDispatcherImpl.h:
  • src/StorageNamespaceProxy.cpp:
  • src/StorageNamespaceProxy.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableLocalStorage):
(WebKit::WebRuntimeFeatures::isLocalStorageEnabled):
(WebKit::WebRuntimeFeatures::enableSessionStorage):
(WebKit::WebRuntimeFeatures::isSessionStorageEnabled):

  • src/WebStorageAreaImpl.cpp:
  • src/WebStorageAreaImpl.h:
  • src/WebStorageEventDispatcherImpl.cpp:
  • src/WebStorageEventDispatcherImpl.h:
  • src/WebStorageNamespaceImpl.cpp:
  • src/WebStorageNamespaceImpl.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Storage/WebStorageManager.mm:
  • Storage/WebStorageManagerInternal.h:
  • Storage/WebStorageTrackerClient.h:
  • Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::dispatchDidModifyOrigin):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Tools:

  • Scripts/build-webkit:
  • waf/build/settings.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/events/event-creation.html:

10/15/11:

22:59 Changeset [97573] by abarth@webkit.org
  • 9 edits in trunk/Source

Rename ENABLE(SKIA_TEXT) to USE(SKIA_TEXT)
https://bugs.webkit.org/show_bug.cgi?id=70191

Reviewed by Daniel Bates.

Source/WebCore:

SKIA_TEXT is not a WebKit feature. It's a macro that determines
whether we use a feature of the underly library (Skia).

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

Source/WebKit/chromium:

  • features.gypi:
22:00 Changeset [97572] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-10-15 Eric Carlson <eric.carlson@apple.com>

Make VIDEO_TRACK compile with warnings as errors enabled
https://bugs.webkit.org/show_bug.cgi?id=70188

Reviewed by Filip Pizlo.

No new tests, no functionality changed.

  • html/TextTrackCueList.h: Fix an include.
  • html/track/CueParser.cpp: (WebCore::CueParser::supportsType): Remove unused param.
  • html/track/CueParser.h: (WebCore::CueParserClient::~CueParserClient): Add virtual destructor.
  • html/track/CueParserPrivate.h: (WebCore::CueParserPrivateClient::~CueParserPrivateClient): Ditto.
  • loader/CueLoader.h: (WebCore::CueLoaderClient::~CueLoaderClient): Ditto. (WebCore::CueLoader::~CueLoader): Ditto.
21:35 Changeset [97571] by abarth@webkit.org
  • 58 edits in trunk

Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
https://bugs.webkit.org/show_bug.cgi?id=70194

Reviewed by Daniel Bates.

Source/WebCore:

TILED_BACKING_STORE isn't a web platform feature. It's an
implementation strategy for WebKit that's used by some ports
and not by others.

  • features.pri:
  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::setView):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):

  • page/Settings.cpp:

(WebCore::Settings::setTiledBackingStoreEnabled):

  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollPosition):

  • platform/graphics/Tile.h:
  • platform/graphics/TiledBackingStore.cpp:
  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreBackend.h:
  • platform/graphics/TiledBackingStoreClient.h:
  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::paint):

  • platform/graphics/qt/TileQt.cpp:
  • platform/graphics/qt/TileQt.h:
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::syncCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::State::State):

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::_q_scaleChanged):
(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::paint):
(QGraphicsWebView::isTiledBackingStoreFrozen):
(QGraphicsWebView::setTiledBackingStoreFrozen):

  • Api/qwebframe.cpp:
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateWindow):

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):

  • WebCoreSupport/PageClientQt.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

Source/WebKit2:

  • Shared/DrawingAreaInfo.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/PageClient.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • Scripts/build-webkit:
21:19 Changeset [97570] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove unused ENABLE(SKIA_GPU)
https://bugs.webkit.org/show_bug.cgi?id=70192

Reviewed by Daniel Bates.

There do not appear to be any references to this macro.

  • features.gypi:
20:33 Changeset [97569] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the last remnant of WBXML
https://bugs.webkit.org/show_bug.cgi?id=70187

Reviewed by Daniel Bates.

The bulk of the WBXML code was removed in 2009, but we missed one block.

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::initMIMETypeEntensionMap):

17:54 Changeset [97568] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

The s390 and s390x architectures both use 64-bit double type
that conforms to the IEEE-754 standard.

https://bugs.webkit.org/show_bug.cgi?id=69940

Patch by Dan Horák <dan@danny.cz> on 2011-10-15
Reviewed by Gavin Barraclough.

  • wtf/dtoa/utils.h:
17:18 Changeset [97567] by ojan@chromium.org
  • 2 edits in trunk/Tools

run-webkit-tests should accept --child-processes
https://bugs.webkit.org/show_bug.cgi?id=69713

Reviewed by Adam Barth.

Only set --child-processes=1 if --child-processes it not
passed on the commandline.

  • Scripts/run-webkit-tests:
16:46 Changeset [97566] by arv@chromium.org
  • 1055 edits in trunk/LayoutTests

JS Test Harness: Make console and description elements optional in the HTML
https://bugs.webkit.org/show_bug.cgi?id=69881

Reviewed by Darin Adler.

This makes the description element and the console element in the HTML files
optional and these gets created as needed by the call to description() and debug().

This removes the description and console elements from a lots of files in LayoutTests/fast/

  • fast/js/resources/js-test-pre.js:
15:47 Changeset [97565] by darin@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r97533): fast/forms/select-script-onchange.html failed after
https://bugs.webkit.org/show_bug.cgi?id=70173

Reviewed by Ryosuke Niwa.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setValue): Removed unneeded boolean argument
[true for deselect].
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Added explicit
boolean arguments for all calls to setSelectedIndex to restore pre-r97533
behavior.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

  • html/HTMLSelectElement.h:

Removed default of true for userDrivenChange. Each caller should pass it
explicitly. Longer term we should use an enum instead of a boolean or find
some other way of avoiding the argument.
(WebCore::HTMLSelectElement::setSelectedIndex):
Pass false for userDrivenChange as the old code did pre-r97533.

14:44 Changeset [97564] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=70157

Reviewed by Geoff Garen.

Added FunctionExecutable::produceCodeBlockFor() and rewired compileForCallInternal()
and compileForConstructInternal() to use this method. This required more cleanly
exposing some of CodeBlock's tiering functionality and moving the CompilationKind
enum to Executable.h, as this was the easiest way to make it available to the
declarations/definitions of CodeBlock, FunctionExecutable, and BytecodeGenerator.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::copyDataFromAlternative):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setAlternative):

  • bytecompiler/BytecodeGenerator.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::codeBlockFor):

12:35 Changeset [97563] by scheib@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Populate WebMouseEvent movementX/Y on Mac
https://bugs.webkit.org/show_bug.cgi?id=70167

Reviewed by Adam Barth.

  • src/mac/WebInputEventFactory.mm:

(WebKit::setWebEventLocationFromEventInView):

12:34 Changeset [97562] by dbates@webkit.org
  • 3 edits
    1 delete in trunk/Tools

Extract common gdb code into its own function; Remove script gdb-safari
https://bugs.webkit.org/show_bug.cgi?id=68499

Reviewed by David Kilzer.

Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
runSafari}() and in the script gdb-safari to launch gdb to debug an application.
We should extract the common parts into a function that can be shared by all callers
so as to remove duplicate code.

As a side effect of removing duplicate code we can remove the script gdb-safari since
its code has been incorporated into webkitdirs::debugSafari() which is called by the
script debug-safari.

  • Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
  • Scripts/gdb-safari: Removed.
  • Scripts/webkitdirs.pm:

(execMacWebKitAppForDebugging): Added; Extracted common debugging code from
debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
script gdb-safari to here.
(debugSafari): Added.
(runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
runSafari() always returns 1 on Windows and the script run-safari exits using this
value as its exit status. Hence, the script run-safari always exits with a nonzero
exit status (i.e. abnormal termination) on Windows. Instead, we should return the
exit status of the WebKit launcher application.
(debugMiniBrowser): Modified to call debugMacWebKitApp().
(debugWebKitTestRunner): Ditto.

12:14 Changeset [97561] by robert@webkit.org
  • 3 edits
    1 add in trunk/Tools

[webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
https://bugs.webkit.org/show_bug.cgi?id=70056

Reviewed by Adam Barth.

The preferred file-order for patches is LayoutTests at the end and
ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use
it when creating patches for review and landing.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/config/orderfile: Added.
09:17 Changeset [97560] by commit-queue@webkit.org
  • 25 edits
    5 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r97559.
http://trac.webkit.org/changeset/97559
https://bugs.webkit.org/show_bug.cgi?id=70176

Broke build on Mac (Requested by noamr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-15

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Removed.
  • UIProcess/LayerTreeHostProxy.messages.in: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Removed.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::deletedLayerIDs):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::didSynchronize):
(WebCore::WebGraphicsLayer::layerInfo):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::needsDisplayRect):
(WebCore::WebGraphicsLayer::takeLayersToDelete):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::divideIntoTiles):
(WebCore::collectCompositingInfoForThisLayer):
(WebCore::collectCompositingInfoRecursively):
(WebCore::WebGraphicsLayer::sendLayersToUIProcess):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/LayerTreeHost.messages.in: Removed.
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
  • WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.
09:01 Changeset [97559] by noam.rosenthal@nokia.com
  • 25 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

  • UIProcess/LayerTreeHostProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

  • WebProcess/WebPage/LayerTreeHost.messages.in: Added.
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

08:15 Changeset [97558] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Missed mac result from r97555

Unreviewed.

  • platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
06:25 Changeset [97557] by laszlo.1.gombos@nokia.com
  • 75 edits
    4 deletes in trunk

[Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
https://bugs.webkit.org/show_bug.cgi?id=69920
Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2011-10-15
Reviewed by Kenneth Rohde Christiansen.

  • Source/WebKit.pri:
  • Source/WebKit.pro:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot): (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):
  • Scripts/webkitpy/style/checker.py: Remove rules for the WebKit/qt/symbian/platformplugin directory.
  • Scripts/webkitpy/style/checker_unittest.py:
  • Tools.pro:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: (WTR::LayoutTestController::platformInitialize):
  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::isExistingLibrary):
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • benchmarks/qscriptengine/qscriptengine.pro:
  • JavaScriptCore.pri:
  • JavaScriptCore.pro:
  • heap/MarkStack.h: (JSC::::shrinkAllocation):
  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JITStubs.cpp:
  • jsc.pro:
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString):
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncLastIndexOf):
  • runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/Atomics.h:
  • wtf/MathExtras.h:
  • wtf/OSAllocator.h: (WTF::OSAllocator::decommitAndRelease):
  • wtf/OSAllocatorSymbian.cpp: Removed.
  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
  • wtf/PageAllocation.h:
  • wtf/PageAllocatorSymbian.h: Removed.
  • wtf/PageBlock.cpp:
  • wtf/Platform.h:
  • wtf/StackBounds.cpp:
  • wtf/wtf.pri:
  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setPage):
  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • Api/qwebview.cpp: (QWebView::QWebView):
  • QtWebKit.pro:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
  • declarative/declarative.pro:
  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage):
  • symbian: Removed.
  • symbian/backup_registration.xml: Removed.
  • symbian/bwins: Removed.
  • symbian/bwins/QtWebKitu.def: Removed.
  • symbian/eabi: Removed.
  • symbian/eabi/QtWebKitu.def: Removed.
  • symbian/platformplugin: Removed.
  • symbian/platformplugin/HTML5VideoPlugin.cpp: Removed.
  • symbian/platformplugin/HTML5VideoPlugin.h: Removed.
  • symbian/platformplugin/HTML5VideoWidget.cpp: Removed.
  • symbian/platformplugin/HTML5VideoWidget.h: Removed.
  • symbian/platformplugin/OverlayWidget.cpp: Removed.
  • symbian/platformplugin/OverlayWidget.h: Removed.
  • symbian/platformplugin/PlayerButton.cpp: Removed.
  • symbian/platformplugin/PlayerButton.h: Removed.
  • symbian/platformplugin/PlayerLabel.cpp: Removed.
  • symbian/platformplugin/PlayerLabel.h: Removed.
  • symbian/platformplugin/WebPlugin.cpp: Removed.
  • symbian/platformplugin/WebPlugin.h: Removed.
  • symbian/platformplugin/images: Removed.
  • symbian/platformplugin/images/button_cannotplay.png: Removed.
  • symbian/platformplugin/images/button_close.png: Removed.
  • symbian/platformplugin/images/button_pause.png: Removed.
  • symbian/platformplugin/images/button_play.png: Removed.
  • symbian/platformplugin/images/button_sound_off.png: Removed.
  • symbian/platformplugin/images/button_sound_on.png: Removed.
  • symbian/platformplugin/images/loading_buffering_1.png: Removed.
  • symbian/platformplugin/images/loading_buffering_2.png: Removed.
  • symbian/platformplugin/images/loading_buffering_3.png: Removed.
  • symbian/platformplugin/images/loading_buffering_4.png: Removed.
  • symbian/platformplugin/platformplugin.pro: Removed.
  • symbian/platformplugin/platformplugin.qrc: Removed.
  • symbian/platformplugin/qss: Removed.
  • symbian/platformplugin/qss/OverlayWidget.qss: Removed.
  • symbian/platformplugin/qwebkitplatformplugin.h: Removed.
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::focusInputTypes):
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::focusInputTypes):
  • tests/tests.pri:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::checkMemoryUsage):
  • config.h:
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator int):
  • features.pri:
  • page/NavigatorBase.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
  • platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
  • plugins/PluginDatabase.cpp:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::unload):
  • plugins/PluginPackage.h: (WebCore::PluginPackage::version):
  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect):
  • plugins/PluginView.h:
  • plugins/npapi.h:
  • plugins/symbian: Removed.
  • plugins/symbian/PluginContainerSymbian.cpp: Removed.
  • plugins/symbian/PluginContainerSymbian.h: Removed.
  • plugins/symbian/PluginDatabaseSymbian.cpp: Removed.
  • plugins/symbian/PluginPackageSymbian.cpp: Removed.
  • plugins/symbian/PluginViewSymbian.cpp: Removed.
  • plugins/symbian/npinterface.h: Removed.
06:00 Changeset [97556] by robert@webkit.org
  • 1 edit
    17 adds in trunk/LayoutTests

Platform-specific results for r97555

Unreviewed.

  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/height-width-table-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/height-width-table-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/height-width-table-001-expected.txt: Added.
04:32 Changeset [97555] by robert@webkit.org
  • 3 edits
    33 copies
    6 moves
    31 adds
    8 deletes in trunk

CSS 2.1 failure: height-width-table-001.htm
https://bugs.webkit.org/show_bug.cgi?id=69709

Reviewed by Simon Fraser.

Source/WebCore:

CSS 2.1 expects CSS table elements to treat fixed height/width as
excluding table borders, but HTML table elements to treat fixed height/width as
including them.

See http://lists.w3.org/Archives/Public/www-style/2011Jan/0178.html

http://lists.w3.org/Archives/Public/public-css-testsuite/2011Oct/0005.html

It looks like some clarification is pending in the specs, but the new behaviour
lets WebKit pass the following tests in the suite CSS and also match FF:

height-width-table-001.htm
height-width-inline-table-001.htm
abspos-containing-block-initial-004d.htm

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

LayoutTests:

  • css2.1/20110323/abspos-containing-block-initial-001-ref.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-001.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004-ref.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004a.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004b.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004c.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004d.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Added.
  • css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004e.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004f.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005-ref.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005a.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005b.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005c.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005d.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-007-ref.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-007.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009-ref.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009a.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009b.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Added
  • css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009e.htm: Added.
  • css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009f.htm: Added.
  • css2.1/20110323/height-width-inline-table-001.htm: Added.
  • css2.1/20110323/height-width-table-001.htm: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.txt: Removed.
  • platform/mac/fast/backgrounds/positioned-root-expected.png: Removed.
  • platform/mac/fast/backgrounds/table-root-expected.png: Removed.
  • platform/mac/fast/backgrounds/table-root-expected.txt: Removed.
  • platform/qt/fast/backgrounds/positioned-root-expected.png: Removed.
  • platform/qt/fast/backgrounds/positioned-root-expected.txt: Removed.
  • platform/qt/fast/backgrounds/table-root-expected.png: Removed.
  • platform/qt/fast/backgrounds/table-root-expected.txt: Removed.
02:37 Changeset [97554] by commit-queue@webkit.org
  • 25 edits
    5 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r97549.
http://trac.webkit.org/changeset/97549
https://bugs.webkit.org/show_bug.cgi?id=70174

It broke the SL build (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-15

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Removed.
  • UIProcess/LayerTreeHostProxy.messages.in: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Removed.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::deletedLayerIDs):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::didSynchronize):
(WebCore::WebGraphicsLayer::layerInfo):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::needsDisplayRect):
(WebCore::WebGraphicsLayer::takeLayersToDelete):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::divideIntoTiles):
(WebCore::collectCompositingInfoForThisLayer):
(WebCore::collectCompositingInfoRecursively):
(WebCore::WebGraphicsLayer::sendLayersToUIProcess):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/LayerTreeHost.messages.in: Removed.
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
  • WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.
01:28 Changeset [97553] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix typo in webkitpy help
https://bugs.webkit.org/show_bug.cgi?id=70169

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/commands/upload.py:
00:59 Changeset [97552] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Trivial fix for a missing change in r97512
https://bugs.webkit.org/show_bug.cgi?id=70166

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-15
Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::link):

00:59 Changeset [97551] by darin@apple.com
  • 10 edits in trunk/Source/WebCore

Make toHTMLElement fail to compile if you try to use it on an HTMLElement*
https://bugs.webkit.org/show_bug.cgi?id=70164

Reviewed by Adam Barth.

Refactoring covered by existing tests.

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter): Removed unneeded casts and
some unneeded local variables as well. Changed the name of the local variable
for the HTMLFrameElement to frameElement to avoid confusion with the Frame.

  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL): Removed unneeded HTMLElement
check; we can call hasTagName directly on a Node and that takes care of
checking both that it's an HTMLElement and checking the tag name.

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::nodeMatches): Use toHTMLElement instead of
a cast. Also changed hasAttribute calls to fastHasAttribute and getAttribute
calls to fastGetAttribute since these are neither style attributes nor SVG
animatables.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Use toHTMLElement.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto.

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::show): Removed unneeded toHTMLElement call.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setOuterHTML): Use toHTMLElement.

  • html/HTMLElement.h: Added toHTMLElement overload to catch calls when the

pointer is already HTMLElement* or a pointer to a class derived from it.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems): Use toHTMLElement.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Use toHTMLElement.

00:44 Changeset [97550] by commit-queue@webkit.org
  • 10 edits
    3 copies
    1 add in trunk/Source

Add WebAcceleratedContentLayer backed by a texture to support accelerated content hosting
https://bugs.webkit.org/show_bug.cgi?id=70084

Patch by Antoine Labour <piman@chromium.org> on 2011-10-15
Reviewed by James Robinson.

Source/WebCore:

Covered by existing compositing/ tests

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::pluginLayerProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setTextureId):
(WebCore::PluginLayerChromium::setFlipped):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::flipped):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setFlipped):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebExternalTextureLayer.h: Added.

(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

  • src/WebExternalTextureLayer.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::textureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):
(WebKit::WebExternalTextureLayer::operator PassRefPtr<WebExternalTextureLayerImpl>):

  • src/WebExternalTextureLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebKit::WebExternalTextureLayerImpl::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::drawsContent):
(WebKit::WebExternalTextureLayerImpl::paintContents):
(WebKit::WebExternalTextureLayerImpl::notifySyncRequired):

  • src/WebExternalTextureLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.
00:32 Changeset [97549] by noam.rosenthal@nokia.com
  • 25 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

  • UIProcess/LayerTreeHostProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

  • WebProcess/WebPage/LayerTreeHost.messages.in: Added.
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

00:28 Changeset [97548] by tony@chromium.org
  • 2 edits in trunk/Tools

fix another typo in treemap.html
https://bugs.webkit.org/show_bug.cgi?id=70149

Reviewed by Ojan Vafai.

Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.

  • TestResultServer/static-dashboards/treemap.html:
00:19 Changeset [97547] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

IndexedDB: some string keys not properly stored and retrieved
https://bugs.webkit.org/show_bug.cgi?id=62348

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-15
Reviewed by Tony Chang.

Just adding Mark Pilgrim's test case from bug; this was fixed at some
point, presumably when we moved to LevelDB.

  • storage/indexeddb/odd-strings-expected.txt: Added.
  • storage/indexeddb/odd-strings.html: Added.
00:16 Changeset [97546] by michaeln@google.com
  • 4 edits in trunk/Source

[Chromium] Some WebSQLDatabase in worker bug fixes.
https://bugs.webkit.org/show_bug.cgi?id=70071

  • Test for a NULL webView WebWorkerClientImpl.
  • Avoid altering Database instance lifetimes during WorkerThread::stop().

Source/WebCore:

Existing tests coverage applies.

Reviewed by David Levin.

  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

Source/WebKit/chromium:

Reviewed by David Levin.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):

00:08 Changeset [97545] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[FileSystem API] File readonly attributes test
https://bugs.webkit.org/show_bug.cgi?id=69687

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-15
Reviewed by Adam Barth.

  • fast/filesystem/simple-readonly-file-object-expected.txt: Added.
  • fast/filesystem/simple-readonly-file-object.html: Added.
00:03 Changeset [97544] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[File API] URL methods required arguments
https://bugs.webkit.org/show_bug.cgi?id=69692

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-15
Reviewed by Adam Barth.

  • fast/files/url-required-arguments-expected.txt: Added.
  • fast/files/url-required-arguments.html: Added.
00:02 Changeset [97543] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[File API] Test how FileReader substitutes illegal UTF-8 characters
https://bugs.webkit.org/show_bug.cgi?id=69691

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

  • fast/files/file-reader-fffd-expected.txt: Added.
  • fast/files/file-reader-fffd.html: Added.

10/14/11:

23:52 Changeset [97542] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[FileSystem API] readonly attributes test
https://bugs.webkit.org/show_bug.cgi?id=69655

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

  • fast/filesystem/resources/simple-readonly.js: Added.

(setReadonlyProperty):
(errorCallback):
(getFileCallback):
(successCallback):

  • fast/filesystem/simple-readonly-expected.txt: Added.
  • fast/filesystem/simple-readonly.html: Added.
23:51 Changeset [97541] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[FileSystem API] restricted Unicode characters in names
https://bugs.webkit.org/show_bug.cgi?id=69657

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

  • fast/filesystem/op-restricted-unicode-expected.txt: Added.
  • fast/filesystem/op-restricted-unicode.html: Added.
  • fast/filesystem/resources/op-restricted-unicode.js: Added.

(testCases.name.precondition.tests):
(testCases):

23:26 Changeset [97540] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Update expected results.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::serializedValueCallback):

22:45 Changeset [97539] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

GTK build fix after r97533.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(optionFromSelection):
(webkit_accessible_selection_get_selection_count):

21:37 Changeset [97538] by ddkilzer@apple.com
  • 4 edits in trunk/Source

<http://webkit.org/b/70158> Fix clang compiler warnings

Reviewed by Darin Adler.

Source/WebCore:

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes): Use std::max<float>()
instead of std::max().

Source/WebKit/mac:

The following two methods in WebDelegateImplementationCaching.h
are ambiguous in WebChromeClient::runJavaScriptPrompt() because
the compiler can't decide how to convert the WTF::String
defaultText argument:

id CallUIDelegate(WebView *, SEL, id, id);
id CallUIDelegate(WebView *, SEL, id, BOOL);

The fix is to perform the conversion explicitly.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::runJavaScriptPrompt): Extract a defaultString
variable to convert the WTF::String to an NSString*, then
use defaultString in place of defaultText.

19:00 Changeset [97537] by mhahnenberg@apple.com
  • 102 edits in trunk/Source

Rename getOwnPropertySlot to getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=69810

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlotVirtual):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::staticFunctionGetter):

(JSC::DebuggerActivation::getOwnPropertySlotVirtual):
(JSC::DebuggerActivation::getOwnPropertySlot):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlot):

  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlotVirtual):
(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlotVirtual):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlotVirtual):

  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlotVirtual):

  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlotVirtual):

  • runtime/DatePrototype.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlotVirtual):

  • runtime/ErrorPrototype.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlotVirtual):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlot):

  • runtime/JSArray.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::getOwnPropertySlotVirtual):

  • runtime/JSBoundFunction.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlotVirtual):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlotVirtual):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlotVirtual):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlotVirtual):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::hasOwnPropertyForWrite):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlotVirtual):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONObject::getOwnPropertySlotVirtual):
(JSC::Walker::walk):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::hasOwnProperty):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlotVirtual):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlot):

  • runtime/JSString.h:
  • runtime/Lookup.h:

(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlotVirtual):

  • runtime/MathObject.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlotVirtual):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlotVirtual):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlotVirtual):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlotVirtual):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlotVirtual):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlotVirtual):

  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlotVirtual):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlotVirtual):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlotVirtual):

  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlotVirtual):

  • runtime/StringPrototype.h:

Source/JavaScriptGlue:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

  • UserObjectImp.cpp:

(UserObjectImp::getOwnPropertySlotVirtual):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotVirtual):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::DialogHandler::returnValue):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlotVirtual):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertySlotVirtual):
(WebCore::JSTestInterface::getOwnPropertySlot):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertySlotVirtual):
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertySlotVirtual):
(WebCore::JSTestObj::getOwnPropertySlot):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlotVirtual):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlotVirtual):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getOwnPropertySlot):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlotVirtual):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlotVirtual):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlotVirtual):

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlotVirtual):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlotVirtual):

  • bridge/runtime_object.h:

Source/WebKit2:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlotVirtual):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
18:25 Changeset [97536] by barraclough@apple.com
  • 65 edits in trunk

Most built-in properties are not deletable
https://bugs.webkit.org/show_bug.cgi?id=61014

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Our static hash tables don't allow for deleting properties.
This is the cause of a bunch of expected failures in LayoutTests/sputnik.

This fixes the problem by reifying all static functions immediately prior
to the first deletion. Reification is tracked by a flag on the structure,
so properties will no longer 'bounce-back' on later access.

Theoretically there could probably also be an issue with custom accessor
properties, but we probably do not really require any of these to be
Configurable anyway. I'll follow up with a separate patch to address this.

  • runtime/ClassInfo.h:

(JSC::ClassInfo::hasStaticProperties):

  • detects static property tables.
  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

  • call reifyStaticFunctions before deletion.

(JSC::JSObject::reifyStaticFunctions):

  • If the class has static functions, set them up now.
  • runtime/JSObject.h:

(JSC::JSObject::staticFunctionsReified):

  • returns true if static functions have been reified, and as such should no longer be added.
  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • If static functions have been reified do not add.
  • runtime/Lookup.h:

(JSC::HashTable::ConstIterator::ConstIterator):
(JSC::HashTable::ConstIterator::operator->):
(JSC::HashTable::ConstIterator::operator*):
(JSC::HashTable::ConstIterator::operator!=):
(JSC::HashTable::ConstIterator::operator++):
(JSC::HashTable::ConstIterator::skipInvalidKeys):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):

  • setUpStaticFunctionSlot may not add, returns a bool.

(JSC::lookupPut):

  • remove redundant branch.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • initialize new flag in constructors.
  • runtime/Structure.h:

(JSC::Structure::staticFunctionsReified):
(JSC::Structure::setStaticFunctionsReified):

  • added flag

LayoutTests:

Mostly checking in passing results, added a couple of extra test cases to fast/js/delete-syntax.

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js:
  • ietestcenter/Javascript/11.4.1-4.a-10-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/S15.4.4_A1.1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4.1_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4_A3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.10_Date.prototype.getFullYear/S15.9.5.10_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.11_Date.prototype.getUTCFullYear/S15.9.5.11_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.12_Date.prototype.getMonth/S15.9.5.12_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.13_Date.prototype.getUTCMonth/S15.9.5.13_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.14_Date.prototype.getDate/S15.9.5.14_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.15_Date.prototype.getUTCDate/S15.9.5.15_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.16_Date.prototype.getDay/S15.9.5.16_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.17_Date.prototype.getUTCDay/S15.9.5.17_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.18_Date.prototype.getHours/S15.9.5.18_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.19_Date.prototype.getUTCHours/S15.9.5.19_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.20_Date.prototype.getMinutes/S15.9.5.20_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.21_Date.prototype.getUTCMinutes/S15.9.5.21_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.22_Date.prototype.getSeconds/S15.9.5.22_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.23_Date.prototype.getUTCSeconds/S15.9.5.23_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.24_Date.prototype.getMilliseconds/S15.9.5.24_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.25_Date.prototype.getUTCMilliseconds/S15.9.5.25_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.26_Date.prototype.getTimezoneOffset/S15.9.5.26_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.27_Date.prototype.setTime/S15.9.5.27_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.28_Date.prototype.setMilliseconds/S15.9.5.28_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.29_Date.prototype.setUTCMilliseconds/S15.9.5.29_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.2_Date.prototype.toString/S15.9.5.2_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.30_Date.prototype.setSeconds/S15.9.5.30_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.31_Date.prototype.setUTCSeconds/S15.9.5.31_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.32_Date.prototype.setMinutes/S15.9.5.32_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.33_Date.prototype.setUTCMinutes/S15.9.5.33_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.34_Date.prototype.setHours/S15.9.5.34_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.35_Date.prototype.setUTCHours/S15.9.5.35_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.36_Date.prototype.setDate/S15.9.5.36_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.37_Date.prototype.setUTCDate/S15.9.5.37_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.38_Date.prototype.setMonth/S15.9.5.38_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.39_Date.prototype.setUTCMonth/S15.9.5.39_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.3_Date.prototype.toDateString/S15.9.5.3_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.40_Date.prototype.setFullYear/S15.9.5.40_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.41_Date.prototype.setUTCFullYear/S15.9.5.41_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.42_Date.prototype.toUTCString/S15.9.5.42_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.4_Date.prototype.toTimeString/S15.9.5.4_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.5_Date.prototype.toLocaleString/S15.9.5.5_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.6_Date.prototype.toLocaleDateString/S15.9.5.6_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.7_Date.prototype.toLocaleTimeString/S15.9.5.7_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.8_Date.prototype.valueOf/S15.9.5.8_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.9_Date.prototype.getTime/S15.9.5.9_A1_T2-expected.txt:
17:53 Changeset [97535] by darin@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Try to fix Chromium build.

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::valueChanged):
Use toHTMLSelectElement instead of toSelectElement.

17:48 Changeset [97534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r97533.

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

17:30 Changeset [97533] by darin@apple.com
  • 16 edits in trunk/Source/WebCore

Follow up the recent HTMLSelectElement improvements with a little bit more
https://bugs.webkit.org/show_bug.cgi?id=70139

Reviewed by Ryosuke Niwa.

Refactoring, covered by existing tests.

Mostly, this adds a toHTMLSelectElement and uses it wherever possible.

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute): Use toHTMLSelectElement.
(WebCore::AccessibilityListBox::addChildren): Ditto. Also removed unneeded toHTMLElement.

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren): Ditto.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMultiSelectable): Ditto.
(WebCore::AccessibilityRenderObject::stringValue): Removed checks on the type of the
underlying node, since other code already assumes that a menu list renderer is only
created for a select element. Streamlined the code a bit and removed some unneeded
local variables.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::indexSetter): Use toHTMLSelectElement.

  • bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove): Ditto.
(WebCore::JSHTMLSelectElement::indexSetter): Ditto.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll): Ditto.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect): Ditto.

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions): Ditto.
(WebCore::HTMLOptGroupElement::ownerSelectElement): Ditto.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::selected): Changed code to call renamed
updateListItemSelectedStates rather than the confusing old name
recalcListItemsIfNeeded.
(WebCore::HTMLOptionElement::childrenChanged): Changed to call
optionElementChildrenChanged rather than calling childrenChanged,
because the children of the select element did not change!
(WebCore::HTMLOptionElement::ownerSelectElement): Use toHTMLSelectElement.

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::remove): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::selectedIndex): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::setSelectedIndex): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::setLength): Use toHTMLSelectElement.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setSelectedIndexByUser): Call setSelectedIndex
without the now-unneeded internal suffix.
(WebCore::HTMLSelectElement::parseMappedAttribute): When the code says that
we should "determine selectedness of the items", call updateListItemSelectedStates
rather than the confusingly named recalcListItemsIfNeeded.
(WebCore::HTMLSelectElement::updateListItemSelectedStates): Renamed
recalcListItemsIfNeeded to this, since that's what this function is for.
(WebCore::HTMLSelectElement::optionElementChildrenChanged): Added. Does
the same work as childrenChanged, although it does not call up to the
base class childrenChanged function. Later we might find we can remove
some of the work here, for example it's not clear we should call the
accessibility childrenChanged function.
(WebCore::HTMLSelectElement::nextValidIndex): Changed this to a member function
and made it get the list items itself rather than requiring they be passed in.
(WebCore::HTMLSelectElement::nextSelectableListIndex): Updated for change to
nextValidIndex.
(WebCore::HTMLSelectElement::previousSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): Ditto.
(WebCore::HTMLSelectElement::listItems): Removed unneeded const_cast, since
recalcListItems is now a const member function. Call recalcListItems by that
name instead of recalcListItemsInternal.
(WebCore::HTMLSelectElement::recalcListItems): Renamed from recalcListItemsInternal
and made this a const member function. The data members that this needs to modify
are now mutable.
(WebCore::HTMLSelectElement::setSelectedIndex): Renamed from setSelectedIndexInternal.
Changed call to updateValidity to instead call setNeedsValidityCheck, since both
do the same thing.
(WebCore::HTMLSelectElement::parseMultipleAttribute): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Updated for change to
nextValidIndex, removed unneeded comparison with zero that's already handled by
casting to an unsigned type, and use setSelectedIndex instead of using
setSelectedIndexInternal since they are both the same thing.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Removed another unneeded
comparision with zero that's handled by casting to an unsigned type.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Use size_t instead of unsigned
for a vector index.
(WebCore::HTMLSelectElement::typeAheadFind): Use setSelectedIndex instead of
setSelectedIndexInternal.
(WebCore::HTMLSelectElement::insertedIntoTree): Removed unneeded explicit boolean
when calling a function that already has a default value of true.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Use setSelectedIndex
instead of setSelectedIndexInternal.

  • html/HTMLSelectElement.h: Made childrenChanged private. Added

optionElementChildrenChanged. Renamed recalcListItemsIfNeeded to the clearer
updateListItemSelectedStates. Removed unused listBoxSelectItem. Removed
updateValidity after changing all callers to instead call setNeedsValidityCheck.
Made canSelectAll and selectAll non-virtual. Removed recalcListItemsInternal
since it's the same thing as recalcListItems now. Renamed setSelectedIndexInternal
to setSelectedIndex since it's the same function, just with a few arguments we
don't want to allow outside callers to pass. Changed nextValidIndex into a
non-static member function. Made m_listItems and m_shouldRecalcListItems mutable.
Added a toHTMLSelectElement function, modeled on the toElement function.

  • html/ValidityState.cpp:

(WebCore::ValidityState::valueMissing): Use toHTMLSelectElement.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::scrollToRevealSelection): Ditto.
(WebCore::RenderListBox::size): Ditto.
(WebCore::RenderListBox::numItems): Ditto.
(WebCore::RenderListBox::addFocusRingRects): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
(WebCore::RenderListBox::paintItemBackground): Ditto.
(WebCore::RenderListBox::panScroll): Ditto.
(WebCore::RenderListBox::autoscroll): Ditto.
(WebCore::RenderListBox::stopAutoscroll): Ditto.
(WebCore::RenderListBox::valueChanged): Ditto.
(WebCore::RenderListBox::nodeAtPoint): Ditto.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
(WebCore::RenderMenuList::updateFromElement): Ditto.
(WebCore::RenderMenuList::setTextFromOption): Ditto.
(WebCore::RenderMenuList::showPopup): Ditto.
(WebCore::RenderMenuList::valueChanged): Ditto.
(WebCore::RenderMenuList::listBoxSelectItem): Ditto.
(WebCore::RenderMenuList::multiple): Ditto.
(WebCore::RenderMenuList::didSetSelectedIndex): Ditto.
(WebCore::RenderMenuList::didUpdateActiveOption): Ditto.
(WebCore::RenderMenuList::itemText): Ditto.
(WebCore::RenderMenuList::itemAccessibilityText): Ditto.
(WebCore::RenderMenuList::itemToolTip): Ditto.
(WebCore::RenderMenuList::itemIsEnabled): Ditto. Also use the
disabled function instead of the virtual isEnabledFormControl
function to check if the optgroup is enabled.
(WebCore::RenderMenuList::itemStyle): Ditto.
(WebCore::RenderMenuList::itemBackgroundColor): Ditto.
(WebCore::RenderMenuList::listSize): Ditto.
(WebCore::RenderMenuList::selectedIndex): Ditto.
(WebCore::RenderMenuList::itemIsSeparator): Ditto.
(WebCore::RenderMenuList::itemIsLabel): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.
(WebCore::RenderMenuList::setTextFromItem): Ditto.

17:04 Changeset [97532] by mhahnenberg@apple.com
  • 84 edits in trunk

Rename virtual put to putVirtual
https://bugs.webkit.org/show_bug.cgi?id=69851

Reviewed by Darin Adler.

.:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • Source/autotools/symbols.filter:

Source/JavaScriptCore:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::putVirtual):

  • API/JSObjectRef.cpp:

(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):

(JSC::DebuggerActivation::putVirtual):
(JSC::DebuggerActivation::put):

  • debugger/DebuggerActivation.h:
  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • runtime/Arguments.cpp:

(JSC::Arguments::putVirtual):

  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::putVirtual):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::putVirtual):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::putVirtual):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putVirtual):
(JSC::JSCell::put):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::putVirtual):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putVirtual):
(JSC::JSGlobalObject::putWithAttributes):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putVirtual):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::putVirtual):
(JSC::JSObject::put):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSValue::put):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putVirtual):

  • runtime/JSStaticScopeObject.h:
  • runtime/Lookup.h:

(JSC::lookupPut):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::putVirtual):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::putVirtual):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putVirtual):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::putVirtual):

  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::putVirtual):

  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectSetProperty):

  • UserObjectImp.cpp:

(UserObjectImp::putVirtual):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::putVirtual):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putVirtual):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomPut):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::putVirtual):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::setMember):
(JavaJSObject::setSlot):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::putVirtual):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::put):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::putVirtual):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::putVirtual):

  • bridge/runtime_object.h:
  • bridge/testqtbindings.cpp:

(main):

Source/WebKit/efl:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/mac:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::putVirtual):
(WebKit::JSNPObject::put):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

16:42 Changeset [97531] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r97519.
http://trac.webkit.org/changeset/97519
https://bugs.webkit.org/show_bug.cgi?id=70156

Broke 79+ tests on bots (Requested by dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

16:13 Changeset [97530] by levin@chromium.org
  • 4 edits in trunk/Tools

watchlist: Add a validation check for the email names in the list.
https://bugs.webkit.org/show_bug.cgi?id=70154

Reviewed by Adam Barth.

If an email is listed which doesn't have a bugzilla log in, then any emails
added to the bug along with that email will fail to happen, so try to prevent this
from happening by validating that emails added to the watchlist are known to be
contributors.

  • Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
16:04 Changeset [97529] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Windows rebaseline after r97522.

  • platform/win/fast/harness/results-expected.txt:
15:56 Changeset [97528] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97522.

  • platform/chromium/fast/harness/results-expected.txt: Tweakaged.
15:52 Changeset [97527] by bdakin@apple.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

These tests results should really be in the mac-specific directory. They were
added earlier today with https://bugs.webkit.org/show_bug.cgi?id=68641

Rubber-stamped by Andy Estes and Jon Honeycutt.

  • fast/css/clip-text-in-scaled-div-expected.png: Removed.
  • fast/css/clip-text-in-scaled-div-expected.txt: Removed.
  • platform/mac/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/mac/fast/css/clip-text-in-scaled-div-expected.txt: Added.
15:51 Changeset [97526] by dglazkov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Remove the duplicelious expectation.

  • platform/chromium/fast/css/getComputedStyle/computed-style-border-image-expected.txt: Removed.
15:49 Changeset [97525] by robert@webkit.org
  • 5 edits
    2 adds in trunk

Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447

If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/replaced/table-percent-width.html

  • rendering/RenderBox.cpp:

(WebCore::shouldExpandToIntrinsicDimension):
(WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/replaced/table-percent-width-expected.txt: Added.
  • fast/replaced/table-percent-width.html: Added.
  • platform/chromium-win/fast/replaced/table-percent-height-expected.txt: Rebaselined
15:45 Changeset [97524] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Fix the bad expected result that I added earlier.

  • fast/css/getComputedStyle/computed-style-border-image-expected.txt:
15:42 Changeset [97523] by abarth@webkit.org
  • 2 edits in trunk/Tools

Hide status bubbles from queues which are very far behind
https://bugs.webkit.org/show_bug.cgi?id=70133

Reviewed by Eric Seidel.

The mac-ews is so far behind that we shouldn't show its status bubble.
The status bubble just makes contributors sad.

  • QueueStatusServer/handlers/statusbubble.py:
15:40 Changeset [97522] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

nrwt's results.html should show crashed tests before flaky tests
https://bugs.webkit.org/show_bug.cgi?id=66041

Reviewed by Ojan Vafai.

Fixed the over by changing the order in which we aggregate results.

  • fast/harness/resources/results-test.js: Added a test.
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
15:37 Changeset [97521] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=70143

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
  • Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
15:35 Changeset [97520] by dglazkov@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Update expectations after r97502.

  • platform/chromium/fast/css/getComputedStyle/computed-style-border-image-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:24 Changeset [97519] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

[Chromium Skia on Mac] Improve focus ring
https://bugs.webkit.org/show_bug.cgi?id=70124

Reviewed by Eric Seidel.

The focus ring code formerly outset the bounds of
the component rectangles by fractional amounts. Because
the rectangles are SkIRect (integer based), the fractional
outset had no effect.

The equivalent code in GraphicsContextMac.mm computes
the curve radius and rectangle outset with integers, so
the use of floats in Skia's case, besides not working,
is unnecessary.

The Skia code also failed to take the offset into account.
In LayoutTests, the focus rings either have an offset of
0 or 2. The CoreGraphics code increases the ring's rectangles
by the offset, then passes the result to wkDrawFocusRing.

I did not find any documentation about how wkDrawFocusRing
further inflates the focus ring, but empirically I determined
that adding 2 to the offset generated rings with identical
outer diameters.

With these adjustments, the layout tests generate focus rings
in the Skia on Mac case that match the coverage of the
Chromium CG-based platform, in particular, matching:

editing/inserting/editable-inline-element.html
editing/selection/3690703-2.html

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

15:17 Changeset [97518] by commit-queue@webkit.org
  • 5 edits in trunk

[Qt] Enable fullscreen api on Qt
https://bugs.webkit.org/show_bug.cgi?id=70131

Source/WebCore:

As a result, we have 3 passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-14
Reviewed by Noam Rosenthal.

  • features.pri:

LayoutTests:

As a result, we have 3 passed tests.
fullscreen/full-screen-api.html
fullscreen/full-screen-iframe-not-allowed.html
fullscreen/full-screen-remove-ancestor-during-transition.html

Patch by Chang Shu <cshu@webkit.org> on 2011-10-14
Reviewed by Noam Rosenthal.

  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
15:13 Changeset [97517] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70148
Should switch to CoreUI version of CorrectionDot, GrammarDot, and SpellingDot
-and corresponding-
<rdar://problem/10208281>

Reviewed by Anders Carlsson.

Use NS*Dot whenever it's available, and fallback to *Dot only when it is not.

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::createPatternColor):
(WebCore::GraphicsContext::drawLineForTextChecking):

15:13 Changeset [97516] by dslomov@google.com
  • 13 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=70120
[Chromium] Pass MessagePortArray to SerializedScriptValue::serialize/deserialize.
This patch augments SerializedScriptValue with MessagePortArray* parameter to implement MessagePort
transfer within the message in the future.

Reviewed by David Levin.

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):

  • workers/Worker.idl:

Source/WebKit/chromium:

  • src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

15:11 Changeset [97515] by levin@chromium.org
  • 4 edits in trunk/Tools

watchlist: If the style check fails, then the watchlist will not be run.
https://bugs.webkit.org/show_bug.cgi?id=69484

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/queues.py: Run the watch list even

if the style part fails and don't allow watch list failures turn the
bot run red.

  • Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
  • Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
15:11 Changeset [97514] by jeffm@apple.com
  • 8 edits in trunk/Source

../WebCore: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

Add infrastructure to convert from any frame view's coordinate system to the
root view's coordinate system.

Reviewed by Simon Fraser.

No new tests (yet), this is covered by <https://bugs.webkit.org/show_bug.cgi?id=70136>.

  • WebCore.exp.in: Exported WebCore::ScrollView::contentsToRootView(), used by InjectedBundleHitTestResult.cpp.


  • platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents): Added (both point and rect versions).
(WebCore::ScrollView::contentsToRootView): Ditto.

  • platform/ScrollView.h: Added member functions to convert to/from root view coordinates.


  • platform/Widget.cpp:

(WebCore::Widget::convertFromRootView): Added (both point and rect versions).
(WebCore::Widget::convertToRootView): Ditto.

  • platform/Widget.h: Added member functions to convert to/from root view coordinates.

../WebKit2: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

WebKit2 clients only have knowledge of the WKView's coordinate system, they have no way to
convert from subframe view coordinates , so any rect that we expose through WK2 APIs should
be in WKView coordinates.

Reviewed by Simon Fraser.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::imageRect): Use WebCore::FrameView::contentsToRootView() to convert the image rect to WKView coordinates.

15:03 Changeset [97513] by dglazkov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] Update expectations after r97487.

  • platform/chromium-cg-mac-snowleopard/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:01 Changeset [97512] by fpizlo@apple.com
  • 17 edits
    1 add in trunk/Source/JavaScriptCore

Reflective Arguments retrieval should be hardened for the
possibility of inlining
https://bugs.webkit.org/show_bug.cgi?id=70068

Reviewed by Oliver Hunt.

CodeBlock can now track, as part of its RareData, the virtual inline
stack at callsites. CallFrame walking can now rematerialize "inline"
CallFrames by combining the meta-data in CodeBlock with the information
already in the JS stack. Arguments can now safely retrieve the
arguments from inline CallFrames.

The DFG already had the notion of a "CodeOrigin" in preparation for
inlining. This notion will now be saved into the CodeBlock, if the DFG
had done inlining. So, CodeOrigin has been moved to bytecode/ and has
been changed to behave more like a struct since that is how it's
meant to be used.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:

(JSC::CodeBlock::inlineCallFrames):
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::codeOriginForReturn):

  • bytecode/CodeOrigin.h: Added.

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):
(JSC::getCallReturnOffsetForCodeOrigin):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGNode.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::isInlineCallFrame):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::setInlineCallFrame):
(JSC::ExecState::isInlineCallFrame):
(JSC::ExecState::trueCallerFrame):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::findFunctionCallFrame):

  • interpreter/Register.h:

(JSC::Register::operator=):
(JSC::Register::inlineCallFrame):

  • runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):

  • runtime/Executable.h:

(JSC::FunctionExecutable::parameterCount):

15:00 Changeset [97511] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSParser: Remove StyleBase usage.
https://bugs.webkit.org/show_bug.cgi?id=70150

Reviewed by Darin Adler.

Split CSSParser::m_parsedStyleObjects into two vectors of
CSSRules and MediaLists.

  • css/CSSParser.cpp:

(WebCore::CSSParser::createMediaList):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:
14:58 Changeset [97510] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] unskipping full screen layout tests. We will do rebaselines later.
https://bugs.webkit.org/show_bug.cgi?id=70144

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
14:50 Changeset [97509] by abarth@webkit.org
  • 18 edits in trunk

canvas getImageData should explain why it throws SECURITY_ERR
https://bugs.webkit.org/show_bug.cgi?id=70088

Reviewed by Darin Adler.

Source/WebCore:

Log as message to the console when getImageData fails because the
canvas is tainted.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

LayoutTests:

Update test results to show the new error message.

  • http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt:
  • http/tests/canvas/philip/tests/security.drawImage.image-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.cross-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
  • http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt:
  • http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
  • http/tests/security/canvas-remote-read-svg-image-expected.txt:
14:33 Changeset [97508] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

Inspector: Remove StyleBase usage.
https://bugs.webkit.org/show_bug.cgi?id=70138

Reviewed by Antti Koivisto.

Be fully specific about whether we're operating on a CSSRule or
a CSSStyleSheet.

No behavior change expected, this merely is a cleanup.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::parentStyleSheet):
(WebCore::InspectorCSSAgent::asCSSStyleRule):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):

14:25 Changeset [97507] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97502.

  • platform/chromium/test_expectations.txt: Updated expectations.
14:18 Changeset [97506] by mhahnenberg@apple.com
  • 58 edits in trunk/Source

Rename virtual deleteProperty to deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=69884

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::deletePropertyVirtual):
(JSC::::deleteProperty):

  • API/JSObjectRef.cpp:

(JSObjectDeleteProperty):

(JSC::DebuggerActivation::deletePropertyVirtual):
(JSC::DebuggerActivation::deleteProperty):

  • debugger/DebuggerActivation.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyVirtual):

  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::deletePropertyVirtual):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::deletePropertyVirtual):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::deletePropertyVirtual):
(JSC::JSCell::deleteProperty):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::deletePropertyVirtual):

  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::deletePropertyVirtual):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::deletePropertyVirtual):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deletePropertyVirtual):

  • runtime/JSVariableObject.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::deletePropertyVirtual):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deletePropertyVirtual):

  • runtime/StrictEvalActivation.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::deletePropertyVirtual):

  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.

  • WebCore.exp.in:
  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deletePropertyVirtual):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::deletePropertyVirtual):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::deletePropertyVirtual):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deletePropertyVirtual):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deletePropertyVirtual):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deletePropertyVirtual):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::remove):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/NP_jsobject.cpp:

(_NPN_RemoveProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::removeMember):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::deletePropertyVirtual):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::deletePropertyVirtual):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::deletePropertyVirtual):

  • bridge/runtime_object.h:

Source/WebKit/mac:

Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::deletePropertyVirtual):
(WebKit::JSNPObject::deleteProperty):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::removeProperty):

14:17 Changeset [97505] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/bindings/v8

Merge 97429
BUG=98582
Review URL: http://codereview.chromium.org/8293008

14:12 Changeset [97504] by dglazkov@chromium.org
  • 8 edits in trunk/Tools

Plumb style-checker filter up to command options and make land-cowboy use it.
https://bugs.webkit.org/show_bug.cgi?id=70119

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
  • Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
  • Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
  • Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
  • Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
  • Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
  • Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
13:58 Changeset [97503] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError.
https://bugs.webkit.org/show_bug.cgi?id=70016

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitError.h:
13:57 Changeset [97502] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

Web Inspector: WebProcess crashes hard when inspecting elements with border-images applied
https://bugs.webkit.org/show_bug.cgi?id=70105

Source/WebCore:

Reviewed by Dave Hyatt.

Fix three different crashes related to getting computed style for border-image.
In both valueForNinePieceImageSlice() and valueForNinePieceImageQuad(),
assign 'right' to 'left' because we've computed a value for 'right' already.
Otherwise this would leave 'right' as null, causing later crashes in cssText().

In mapNinePieceImage(), borderImage->imageValue() can be null for a border-image
shorthand that is missing the image value.

Test: fast/css/getComputedStyle/computed-style-border-image.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Reviewed by Dave Hyatt.

Computed style test for border-image.

  • fast/css/getComputedStyle/computed-style-border-image-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-border-image.html: Added.
13:53 Changeset [97501] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

  • DEPS:
13:33 Changeset [97500] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Skip TestWebKitSettings test.
https://bugs.webkit.org/show_bug.cgi?id=70129

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

Skip running TestWebKitSettings test till a bug
https://bugs.webkit.org/show_bug.cgi?id=70127 gets fixed.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Skip TestWebKitSettings test.

13:16 Changeset [97499] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r97497.

  • editing/markup.cpp:

(WebCore::isNonTableCellHTMLBlockElement):

13:02 Changeset [97498] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Bump class version after r97421.
https://bugs.webkit.org/show_bug.cgi?id=70102

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Joseph Pecoraro.

r97421 changed the signature of the run_open_panel virtual method in
Ewk_Smart_Class, so we need to bump the class version.

  • ewk/ewk_view.h:
12:55 Changeset [97497] by dcheng@chromium.org
  • 11 edits in trunk/Source

Context-aware HTML paste for Chromium
https://bugs.webkit.org/show_bug.cgi?id=62112

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add createFragmentFromMarkupWithContext which understands enough about DOM structure to
retain necessary elements to preserve structure and appearance when extracting a subset of
a DOM tree.

Covered by existing layout tests.

  • editing/MarkupAccumulator.h:
  • editing/markup.cpp:

(WebCore::isNonTableCellHTMLBlockElement):
(WebCore::isHTMLBlockElement):
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::ancestorToRetainStructureAndAppearance):
(WebCore::ancestorToRetainStructureAndAppearanceWithNoRenderer):
(WebCore::findNodesSurroundingContext):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):

  • editing/markup.h:
  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::getData):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add WebKit side for plumbing to receive context for HTML paste.

  • public/WebClipboard.h:

(WebKit::WebClipboard::readHTML):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardReadHTML):

12:52 Changeset [97496] by weinig@apple.com
  • 2 edits in trunk/Tools

Remove the Leopard slaves.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
12:49 Changeset [97495] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium skia] Add media/video-playing-and-pause.html to test expectations pending rebaseline
https://bugs.webkit.org/show_bug.cgi?id=70125

Patch by Brian Salomon <bsalomon@google.com> on 2011-10-14
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
12:48 Changeset [97494] by chang.shu@nokia.com
  • 4 edits in trunk/LayoutTests

2011-10-14 Chang Shu <cshu@webkit.org>

[WK2] Unreviewed gardening.

Some fullscreen tests are passing now on mac WK2 after EventSender support.

  • platform/gtk-wk2/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
12:47 Changeset [97493] by commit-queue@webkit.org
  • 10 edits in trunk

[Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
https://bugs.webkit.org/show_bug.cgi?id=70028

Patch by Peter Beverloo <peter@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • gyp_webkit:

Tools:

  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):
(buildChromium):

12:45 Changeset [97492] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed Skipped change to get bot green again.

  • platform/wincairo/Skipped: Skipped all animations, since tests do

not exactly match Windows results on Apple test output.

12:31 Changeset [97491] by japhet@chromium.org
  • 6 edits in trunk/Source/WebCore

Check CachedResourceClient types with ASSERTs rather
than if statements.
https://bugs.webkit.org/show_bug.cgi?id=70113

Reviewed by Adam Barth.

No new tests, no functionality change.

  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResourceClientWalker.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
12:18 Changeset [97490] by mitz@apple.com
  • 5 edits in trunk/WebKitLibraries

REGRESSION (Safari 5.1 - 5.1.1): CSS nesw-resize cursor shows up as a sw-resize cursor
https://bugs.webkit.org/show_bug.cgi?id=70081

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h: Unrelated change, perhaps needed for bug 68478.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:54 Changeset [97489] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Don't assert that CSSRules are CSSRules.

Rubber-stamped by Antti Koivisto.

  • css/CSSRule.h:

(WebCore::CSSRule::isRule):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insert):

11:48 Changeset [97488] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97481.

  • platform/chromium/test_expectations.txt: Updated.
11:45 Changeset [97487] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted Leopard build fix.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

11:41 Changeset [97486] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium Mac build fix after r97478.

  • src/mac/WebSubstringUtil.mm:

(WebKit::WebSubstringUtil::attributedSubstringInRange):

11:36 Changeset [97485] by andreas.kling@nokia.com
  • 15 edits in trunk/Source/WebCore

CSSStyleSheet should only ever contain CSSRules.
https://bugs.webkit.org/show_bug.cgi?id=70116

Reviewed by Antti Koivisto.

Move child management from the StyleSheet class down into
CSSStyleSheet and XSLStyleSheet. XSLStyleSheet continues to
manage StyleBase objects, while CSSStyleSheet now only contains
CSSRule.

This is enforced at both compile time and runtime with explicit
types and assertions.

  • css/CSSRule.h:

(WebCore::CSSRule::isRule):

Promoted to a public method so we can use it in assertions.

  • css/CSSRuleList.h:

(WebCore::CSSRuleList::create):
(WebCore::CSSRuleList::styleSheet):

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::CSSRuleList):

  • bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

Change backing to a CSSStyleSheet instead of a StyleSheet.

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::item):

Remove redundant assertions.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

  • css/CSSStyleSelector.cpp:

(WebCore::RuleSet::addRulesFromSheet):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::collectStyleSheets):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

Use more specific CSSRule* since that's what we get from
CSSStyleSheet::item() now.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

Orphaning logic from ~StyleSheet() moved to subclass dtors.

  • css/StyleSheet.h:
  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insert):
(WebCore::CSSStyleSheet::remove):

Moved from StyleSheet and changed to only accept CSSRules.

  • css/StyleSheet.h:
  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::length):
(WebCore::XSLStyleSheet::item):
(WebCore::XSLStyleSheet::append):
(WebCore::XSLStyleSheet::insert):
(WebCore::XSLStyleSheet::remove):

Moved from StyleSheet though still uses StyleBase.

11:34 Changeset [97484] by leandro@webkit.org
  • 3 edits in trunk/Tools

Unreviewed; add missing #includes.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  • DumpRenderTree/efl/EventSender.cpp:
11:27 Changeset [97483] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r97375.
http://trac.webkit.org/changeset/97375
https://bugs.webkit.org/show_bug.cgi?id=70115

It breaks loading of webpages in QtWebKit2 (Requested by jeez_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForNavigationAction):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

11:26 Changeset [97482] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Include dom/ExceptionCode.h instead of Filesystem APIs headers
to fix compile error when ENABLE_WORKERS=1 and ENABLE_FILE_SYSTEM=0
https://bugs.webkit.org/show_bug.cgi?id=70036

Patch by Yuji Sanachan <sanachan.y@gmail.com> on 2011-10-14
Reviewed by Darin Adler.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScript):

11:14 Changeset [97481] by bdakin@apple.com
  • 5 edits
    3 adds in trunk

Text drawn via -webkit-background-clip:text should be non-blurry with all scaling
techniques
https://bugs.webkit.org/show_bug.cgi?id=68641

Source/WebCore:

Patch by Darin Adler <darin@apple.com> on 2011-10-14
Reviewed by Simon Fraser. Committed by Beth Dakin.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer): Allocate a buffer based on the
scale
factor of the context.

  • platform/graphics/GraphicsContext.h: Added createCompatibleBuffer.
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
createCompatibleBuffer.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/css/clip-text-in-scaled-div-expected.png: Added.
  • fast/css/clip-text-in-scaled-div-expected.txt: Added.
  • fast/css/clip-text-in-scaled-div.html: Added.
11:00 Changeset [97480] by rniwa@webkit.org
  • 10 edits in trunk/Source/WebCore

Move selectionStartStyle and selectionHasStyle to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=69882

Reviewed by Enrica Casucci.

Moved selectionHasStyle and selectionStartStyle from Editor to EditingStyle.
Also moved much of code in Editor::selectionStartCSSPropertyValue to method of EditingStyle.

In addition, moved Range::editingStartPosition to htmlediting where it belongs
and renamed it to adjustedSelectionStartForStyleComputation.

  • dom/Range.cpp:
  • dom/Range.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle): Extracted from selectionHasStyle.
(WebCore::EditingStyle::legacyFontSize): Extracted from selectionStartCSSPropertyValue.
(WebCore::EditingStyle::styleAtSelectionStart): Moved from Editor::selectionStartStyle.

  • editing/EditingStyle.h:
  • editing/Editor.cpp:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::selectionHasStyle):
(WebCore::Editor::selectionStartCSSPropertyValue):

  • editing/Editor.h:
  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

  • editing/htmlediting.cpp:

(WebCore::adjustedSelectionStartForStyleComputation): Moved from Range::editingStartPosition.

  • editing/htmlediting.h:
10:57 Changeset [97479] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Redundant comparison in AccessibilityObject.cpp updateAXLineStartForVisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=70074

Reviewed by Chris Fleizach.

Removed redundant code.

  • accessibility/AccessibilityObject.cpp:

(WebCore::updateAXLineStartForVisiblePosition):

10:54 Changeset [97478] by rniwa@webkit.org
  • 18 edits in trunk/Source

Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
https://bugs.webkit.org/show_bug.cgi?id=69964

Reviewed by Enrica Casucci.

Source/WebCore:

Extracted the logic to determine the scope element as FrameSelection::rootEditableElementOrDocumentElement
and deployed it in WebKit layer. Made locationAndLengthFromRange take a scope element and renamed it to
getLocationAndLengthFromRange.

  • WebCore.exp.in:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::rootEditableElementOrDocumentElement):

  • editing/FrameSelection.h:
  • editing/TextIterator.cpp:

(WebCore::TextIterator::getLocationAndLengthFromRange):

  • editing/TextIterator.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::firstRectForCharacterRange):
(WebKit::WebFrameImpl::characterIndexForPoint):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):
(WebKit::WebViewImpl::caretOrSelectionRange):

  • src/mac/WebSubstringUtil.mm:

(WebKit::WebSubstringUtil::attributedSubstringInRange):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::firstRectForCharacterRange):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _convertToNSRange:]):
(-[WebFrame _convertToDOMRange:]):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::firstRectForCharacterRange):

Source/WebKit2:

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::getSelectedRange):
(WebKit::WebPage::characterIndexForPoint):
(WebKit::convertToRange):

10:23 Changeset [97477] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Performance fix for ResolveGlobal
https://bugs.webkit.org/show_bug.cgi?id=70096

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-14
Reviewed by Gavin Barraclough.

Structure check of global object should be a pointer comparison
instead of a tag and payload pair comparison. This fix improves
SunSpider by 7% on Linux 32, with bitops-bitwise-and improved by 4.75X.
Also two trivial fixes for successful 32-bit build are included.

  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:15 Changeset [97476] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebKit/win

Remove layerX / layerY from the Windows API
https://bugs.webkit.org/show_bug.cgi?id=70051

Reviewed by Darin Adler.

Renamed layerX to unused1 and layerY to unused2 to keep the
binary compatibility.

  • DOMEventsClasses.cpp:

(DOMUIEvent::unused1):
(DOMUIEvent::unused2):

  • DOMEventsClasses.h:

(DOMKeyboardEvent::unused1):
(DOMKeyboardEvent::unused2):
(DOMMouseEvent::unused1):
(DOMMouseEvent::unused2):
(DOMWheelEvent::unused1):
(DOMWheelEvent::unused2):

  • Interfaces/DOMEvents.idl:
10:12 Changeset [97475] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
https://bugs.webkit.org/show_bug.cgi?id=69770

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Antonio Gomes.

We were just appending the given URL to the absolute URI of the main
frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
instead of "file:///foo/bar/theother/url.html".

This should make fast/dom/navigation-type-navigate.html behave
better (it still fails, but later).

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):

10:04 Changeset [97474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] r97438: Inconsistent use of flattening vs flattering in function names/comments
https://bugs.webkit.org/show_bug.cgi?id=70092

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

Fixes the miss-spelling of 'PROP_ENABLE_FRAME_FLATTENING' as 'PROP_ENABLE_FRAME_FLATTERING'
introduced with change set r97438.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Property name correction.
(webKitSettingsGetProperty): Property name correction.
(webkit_settings_class_init): Property name correction.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Spelling correction.

09:49 Changeset [97473] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
    • Skip a failing test.
    • Typo fix after r97471.
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added after r97388.
09:21 Changeset [97472] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Skip MicroData tests on Mac and WinCairo as well.

  • platform/mac/Skipped:
  • platform/wincairo/Skipped:
09:13 Changeset [97471] by rniwa@webkit.org
  • 33 edits
    23 adds in trunk

Microdata: Basic implementation of document.getItems() method.
https://bugs.webkit.org/show_bug.cgi?id=68610

Patch by Arko Saha <arko@motorola.com> on 2011-10-13
Reviewed by Ryosuke Niwa.

.:

Added ENABLE(MICRODATA) feature flag.

  • configure.ac:

Source/WebCore:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

Tests: fast/dom/MicroData/001.html

fast/dom/MicroData/002.html
fast/dom/MicroData/003.html
fast/dom/MicroData/004.html
fast/dom/MicroData/005.html
fast/dom/MicroData/006.html
fast/dom/MicroData/007.html
fast/dom/MicroData/008.html
fast/dom/MicroData/009.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • dom/Document.cpp:

(WebCore::Document::getItems): Returns NodeList of the element in the Document that
create items, that are not part of other items, and that are of one of the types
given in the argument. If no tokens specified/undefined in the argument, then
return a NodeList containing all top level microdata items.
(WebCore::Document::removeCachedMicroDataItemList): Remove Microdata item node list
from cache.

  • dom/Document.h:
  • dom/Document.idl: Added getItems() microdata DOM API.
  • dom/MicroDataItemList.cpp: Added.

(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):
(WebCore::MicroDataItemList::nodeMatches):

  • dom/MicroDataItemList.h: Added.

(WebCore::MicroDataItemList::create):

  • dom/Node.cpp:

(WebCore::Node::itemTypeAttributeChanged): It is responsible to invalidate the Microdata
item node cache when itemType attribute changes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
(WebCore::NodeListsNodeData::invalidateMicrodataItemListCaches): Invalidate Microdata item
list cache.
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:
  • dom/NodeRareData.h:
  • features.pri:
  • html/HTMLAttributeNames.in: Added itemid, itemprop, itemscope, itemtype attributes.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Handle itemtype attribute change.

  • html/HTMLElement.idl: Added itemid, itemprop, itemscope, itemtypes microdata attributes.

Source/WebKit/chromium:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

  • features.gypi:

Tools:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

  • Scripts/build-webkit:

WebKitLibraries:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Added test-cases for document.getItems() method.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
Skipping test-cases for now as Microdata DOM API is not yet enabled.

  • fast/dom/MicroData: Added.
  • fast/dom/MicroData/001-expected.txt: Added.
  • fast/dom/MicroData/001.html: Added.
  • fast/dom/MicroData/002-expected.txt: Added.
  • fast/dom/MicroData/002.html: Added.
  • fast/dom/MicroData/003-expected.txt: Added.
  • fast/dom/MicroData/003.html: Added.
  • fast/dom/MicroData/004-expected.txt: Added.
  • fast/dom/MicroData/004.html: Added.
  • fast/dom/MicroData/005-expected.txt: Added.
  • fast/dom/MicroData/005.html: Added.
  • fast/dom/MicroData/006-expected.txt: Added.
  • fast/dom/MicroData/006.html: Added.
  • fast/dom/MicroData/007-expected.txt: Added.
  • fast/dom/MicroData/007.html: Added.
  • fast/dom/MicroData/008-expected.txt: Added.
  • fast/dom/MicroData/008.html: Added.
  • fast/dom/MicroData/009-expected.txt: Added.
  • fast/dom/MicroData/009.html: Added.
  • fast/dom/MicroData/resources: Added.
  • fast/dom/MicroData/resources/microdata-common.js: Added.

(createElem):
(runTest):

  • platform/win/Skipped:
08:50 Changeset [97470] by ossy@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Roll-back second part of r97252. :)

  • Scripts/webkitpy/layout_tests/port/qt.py:
08:45 BuildingQt5OnHarmattan edited by abecsi@webkit.org
(diff)
08:36 Changeset [97469] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
https://bugs.webkit.org/show_bug.cgi?id=70106

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Antonio Gomes.

OwnFastMallocPtr was being used as a smart pointer that automatically called
free() on the strings returned by the EFL or by ewk.

However, when WTF is built in release mode, it uses its own memory management
code instead of using the system malloc(), free() and friends. This means bad
things will happen when one uses WTF's free() on memory allocated with system
malloc() by the EFL or ewk.

The easiest way to solve this is to call free() ourselves.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):
(getFinalTestURL):

08:32 Changeset [97468] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebCore

Stricter management of WebKitCSSKeyframeRules.
https://bugs.webkit.org/show_bug.cgi?id=70109

Reviewed by Antti Koivisto.

Covered by existing tests.

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseKeyframeRule):

Return a WebKitCSSKeyframeRule instead of a CSSRule.

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::deleteRule):

Moved style sheet orphaning logic for @-webkit-keyframe
from CSSRuleList into WebKitCSSKeyframesRule::deleteRule()
since that's the only caller operating on those rules.

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):
(WebCore::WebKitCSSKeyframesRule::insertRule):

Change isKeyframeRule() checks to assertions since we know
our rules are always WebKitCSSKeyframeRules. Also tidied up.

08:10 Changeset [97467] by andreas.kling@nokia.com
  • 1 edit
    2 deletes in trunk/Source/WebCore

Unreviewed, actually remove StyleList.* after r97640.

  • css/StyleList.cpp: Removed.
  • css/StyleList.h: Removed.
08:04 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
07:57 Changeset [97466] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] enable qmltests for qt5
https://bugs.webkit.org/show_bug.cgi?id=70037

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-10-14
Reviewed by Chang Shu.

Qml tests seem to be disabled for some reason. This patch enables the tests by including qmltests to SUBDIRS.

  • UIProcess/API/qt/tests/tests.pro:
07:49 Changeset [97465] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit2

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
https://bugs.webkit.org/show_bug.cgi?id=66134

Unreviewed build fix after r97462.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2011-10-14

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

07:43 Changeset [97464] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

[EFL] Add DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=68458

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/cmake/eflsymbols.filter: Export DumpRenderTreeSupportEfl

symbols so that DumpRenderTree can link to them.

Source/WebKit/efl:

This class is similar to their counterparts present in the Qt and GTK+
ports, and it is responsible for providing an interface to certain
WebCore methods needed by DumpRenderTree.

  • CMakeListsEfl.txt: Conditionally add the svg directories to the

include path.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Added.

(DumpRenderTreeSupportEfl::DumpRenderTreeSupportEfl):
(DumpRenderTreeSupportEfl::~DumpRenderTreeSupportEfl):
(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::counterValueByElementId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::numberOfPagesForElementId):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseSVGAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::resumeAnimations):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::suspendAnimations):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::garbageCollectorCollect):
(DumpRenderTreeSupportEfl::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportEfl::javaScriptObjectsCount):
(DumpRenderTreeSupportEfl::workerThreadCount):
(DumpRenderTreeSupportEfl::childHistoryItems):
(DumpRenderTreeSupportEfl::historyItemTarget):
(DumpRenderTreeSupportEfl::isTargetItem):
(DumpRenderTreeSupportEfl::setMockScrollbarsEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h: Added.
  • ewk/ewk_frame.cpp:

(EWKPrivate::coreFrame): Export the WebCore::Frame* related to an
ewk_frame.

  • ewk/ewk_history.cpp: Remove functions which have been moved to

DumpRenderTreeSupportEfl.
(_ewk_history_item_list_get): _ewk_history_item_new ->
ewk_history_item_new_from_core.
(ewk_history_history_item_back_get): Ditto.
(ewk_history_history_item_current_get): Ditto.
(ewk_history_history_item_forward_get): Ditto.
(ewk_history_history_item_nth_get): Ditto.
(ewk_history_item_new): Ditto.
(ewk_history_item_new_from_core): Rename from _ewk_history_item_new.
(EWKPrivate::coreHistoryItem): Export the WebCore::HistoryItem*
related to an Ewk_History_Item.

  • ewk/ewk_private.h: Create the EWKPrivate namespace, remove functions

which have been moved to DumpRenderTreeSupportEfl.

  • ewk/ewk_util.cpp: Remove functions which have been moved to

DumpRenderTreeSupportEfl.

  • ewk/ewk_view.cpp:

(EWKPrivate::corePage): Export the WebCore::Page* related to an
ewk_view.

Tools:

Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::onDocumentLoadFinished):

  • DumpRenderTree/efl/GCControllerEfl.cpp:

(GCController::collect):
(GCController::collectOnAlternateThread):
(GCController::getJSObjectCount):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::counterValueForElementById):
(LayoutTestController::pageNumberForElementById):
(LayoutTestController::numberOfPages):
(LayoutTestController::workerThreadCount):
(LayoutTestController::findString):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::sampleSVGAnimationForElementAtTime):
(LayoutTestController::numberOfActiveAnimations):
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

07:17 Changeset [97463] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.

Unreviewed.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

07:09 Changeset [97462] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
https://bugs.webkit.org/show_bug.cgi?id=66134

Reviewed by Simon Hausmann.

Do the resize to contents on the web process side.

Based on patch by Zalan Bujtas.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::resizeToContentsIfNeeded):

  • WebProcess/WebPage/WebPage.h:
07:05 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt version on Windows bots (diff)
06:55 Changeset [97461] by ossy@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Roll-back r97252 with unit test fix.

Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
05:48 Changeset [97460] by andreas.kling@nokia.com
  • 12 edits in trunk/Source/WebCore

Merge StyleList into StyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70100

Reviewed by Antti "printf" Koivisto.

Merge all functionality from StyleList into StyleSheet,
since StyleSheet was the only subclass of StyleList anyway.

Also removed FIXME's about throwing exceptions in CSSRuleList
since they were incorrect. The call sites already handle the
relevant cases.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::CSSRuleList):
(WebCore::CSSRuleList::length):
(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::deleteRule):
(WebCore::CSSRuleList::append):
(WebCore::CSSRuleList::insertRule):

  • css/CSSRuleList.h:

(WebCore::CSSRuleList::create):
(WebCore::CSSRuleList::styleSheet):

  • css/StyleList.cpp: Removed.
  • css/StyleList.h: Removed.
  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::append):
(WebCore::StyleSheet::insert):
(WebCore::StyleSheet::remove):

  • css/StyleSheet.h:

(WebCore::StyleSheet::length):
(WebCore::StyleSheet::item):

05:31 BuildingQt5OnHarmattan edited by lars.knudsen@nokia.com
(diff)
04:40 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the WK2 bot (diff)
04:30 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
04:00 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
04:00 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:23 Changeset [97459] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

tables/mozilla/bugs/bug53690-1.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67745

Reviewed by Eric Seidel.

Previously, this script had just errored out. This patch removes the
script, making the results more sane.

  • platform/chromium-win/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug53690-1-expected.txt:
  • tables/mozilla/bugs/bug53690-1.html:
03:17 BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com
(diff)
03:15 Changeset [97458] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Build is broken with new ld
https://bugs.webkit.org/show_bug.cgi?id=70097

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
03:14 Changeset [97457] by hausmann@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Fix build after QSGItem API changes
https://bugs.webkit.org/show_bug.cgi?id=69926

Reviewed by Kenneth Rohde Christiansen.

Commit c825865cdd88445aa1db94cdf0da89426919acdb in qtdeclarative changed the
signatures of the Drag & Drop event handlers in QSGItem. The SG specific events
were replaced with the plain QDrag* events, which are now used for widgets as well
as the Qt scene graph.

This patch adapts the desktop webview as well as the page proxy to handle these
kind of events.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragLeaveEvent):
(QDesktopWebView::dropEvent):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleDragEnterEvent):
(QDesktopWebPageProxy::handleDragLeaveEvent):
(QDesktopWebPageProxy::handleDragMoveEvent):
(QDesktopWebPageProxy::handleDropEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
03:09 BuildingGtk edited by nayankk@motorola.com
(diff)
03:04 BuildingQt5OnHarmattan edited by kenneth@webkit.org
(diff)
03:02 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
02:55 Changeset [97456] by abarth@webkit.org
  • 2 edits
    1 move
    3 deletes in trunk/LayoutTests

tables/mozilla/bugs/bug9024.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67744

Reviewed by Eric Seidel.

Previously, this script had just errored out. This patch removes the
scripts, which lets us share the same baseline across all the ports.

  • platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • tables/mozilla/bugs/bug9024-expected.txt: Added.
  • tables/mozilla/bugs/bug9024.html:
02:42 Changeset [97455] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=70013

  • platform/chromium/test_expectations.txt:

Add more canvas crashes.

02:28 Changeset [97454] by mihnea@adobe.com
  • 81 edits in trunk

[CSS Regions] Change -webkit-flow to -webkit-flow-into
https://bugs.webkit.org/show_bug.cgi?id=70014

Reviewed by David Hyatt.

  1. -webkit-flow is renamed to -webkit-flow-into
  2. -webkit-flow-into takes <ident> instead of strings

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::validFlowName):
(WebCore::CSSParser::parseFlowThread):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/content-flowed-into-regions-no-scroll.html:
  • fast/regions/float-pushed-width-change.html:
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • fast/regions/flow-anonymous-children.html:
  • fast/regions/flow-content-basic-vertical-rl.html:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/flow-content-basic.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/hit-test-float.html:
  • fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
  • fast/regions/no-split-line-box.html:
  • fast/regions/outline-sides-in-region.html:
  • fast/regions/overflow-in-uniform-regions-dynamic.html:
  • fast/regions/overflow-in-uniform-regions.html:
  • fast/regions/overflow-in-variable-width-regions.html:
  • fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-rtl-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-with-stacking-context-rtl.html:
  • fast/regions/overflow-size-change-with-stacking-context.html:
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
  • fast/regions/percentage-margins-rtl-variable-width-regions.html:
  • fast/regions/percentage-margins-variable-width-regions.html:
  • fast/regions/position-writing-modes-in-variable-width-regions.html:
  • fast/regions/positioned-objects-block-static-in-regions.html:
  • fast/regions/positioned-objects-block-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-block-static-spanning-regions.html:
  • fast/regions/positioned-objects-in-regions.html:
  • fast/regions/positioned-objects-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-in-regions.html:
  • fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions.html:
  • fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
  • fast/regions/positioned-objects-spanning-regions.html:
  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • fast/regions/region-overflow-break.html:
  • fast/regions/resources/region-style.css:

(.flowArticle):

  • fast/regions/script-tests/webkit-flow-parsing.js:

(test):
(testComputedStyle):
(testNotInherited):

  • fast/regions/text-region-breaks.html:
  • fast/regions/text-region-split-after-resize.html:
  • fast/regions/text-region-split-horizontal-bt.html:
  • fast/regions/text-region-split-small-pagination.html:
  • fast/regions/text-region-split-vertical-rl.html:
  • fast/regions/text-region-split-vertical.html:
  • fast/regions/text-region-split.html:
  • fast/regions/top-overflow-out-of-second-region.html:
  • fast/regions/webkit-flow-double-pagination-float-push.html:
  • fast/regions/webkit-flow-float-pushed-to-last-region.html:
  • fast/regions/webkit-flow-float-unable-to-push.html:
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html:
  • fast/regions/webkit-flow-inlines-dynamic.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
  • fast/regions/webkit-flow-parsing-expected.txt:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • fast/repaint/line-flow-with-floats-in-regions.html:
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
  • fast/repaint/region-painting-via-layout.html:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
02:15 Changeset [97453] by hans@chromium.org
  • 17 edits
    2 deletes in trunk/Source

IndexedDB: Remove SQLite backing store
https://bugs.webkit.org/show_bug.cgi?id=69620

Reviewed by Darin Fisher.

Remove the SQLite backing store implementation; it is not used anymore.
Also remove the maximumSize parameter, it is not used either.

Source/WebCore:

No new functionality, so no new tests.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • storage/IDBBackingStore.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):

  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBSQLiteBackingStore.cpp: Removed.
  • storage/IDBSQLiteBackingStore.h: Removed.

Source/WebKit/chromium:

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
(WebKit::IDBFactoryBackendProxy::open):

  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

  • src/WebIDBFactoryImpl.h:
02:06 Changeset [97452] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-10-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix mac builds. r97448 broke them.

  • WebCore.xcodeproj/project.pbxproj: Set ImageBySizeCache.h role to private.
01:36 Changeset [97451] by jschuh@chromium.org
  • 6 edits in trunk/Source

Clear WebMediaPlayerClientImpl back pointer on destruction
https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):

  • platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

  • src/WebMediaPlayerClientImpl.h:
01:34 Changeset [97450] by hans@chromium.org
  • 6 edits in trunk

IndexedDB: Make IDBCursor.value() return an IDBAny object
https://bugs.webkit.org/show_bug.cgi?id=70024

Reviewed by Tony Chang.

Source/WebCore:

This is to work around the fact that the V8 bindings mechanism does
eager deserialization of SerializedScriptValue attributes. This means
that the value is fetched from the back-end only once, when the
IDBCursor is first wrapped. When the cursor's value changes, this is
not reflected.

We work around this by making IDBCursor.value() return the
SerializedScriptValue wrapped in an IDBAny object.

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::value):

  • storage/IDBCursor.h:
  • storage/IDBCursorWithValue.idl:

LayoutTests:

Update test expectations since more of this test now passes.

  • storage/indexeddb/cursor-inconsistency-expected.txt:
01:12 Changeset [97449] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Fix compilation when the JS Debugger is disabled.
https://bugs.webkit.org/show_bug.cgi?id=70007

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-14
Reviewed by Antti Koivisto.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:
  • inspector/WorkerInspectorController.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

01:11 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
01:08 Changeset [97448] by zimmermann@webkit.org
  • 59 edits
    2 copies in trunk/Source/WebCore

2011-10-13 Nikolas Zimmermann <nzimmermann@rim.com>

Prepare SVGImage intrinsic size negotiation: Introduce an IntSize <-> SVGImage cache in CachedImage
https://bugs.webkit.org/show_bug.cgi?id=69416

Reviewed by Antti Koivisto.

Refactor ImageBySizeCache out of CSSImageGeneratorValue as CachedImage wants to use the same type of cache for its purposes.
When introducing the SVGImage intrinsic size negotiation the container size of an SVGImage is dependant on the place where
it gets embedded (eg width/height attributes of host documents <img> force a certain size).

Currently CachedImage only contains a single RefPtr<Image>, which it constructs out of the decoded data.
Multiple RenderObjects share the same CachedImages, when embedding eg. a SVG document in a <html:img> or using it in a background-image for a <div>.
Consider the case where two RenderObjects use the same CachedImage, each with a different container size (200x100 vs 100x200) and the embedded
document contains a viewBox and some arbitary preserveAspectRatio settings. To honour these we have to relayout the document with the desired
size (percentual unit resolving etc, all depend on the RenderSVGRoots size).

With the current design this is hard to realize, w/o requring to relayout the embedded document for each embedder that uses an SVGImage.
This patch introduces a cache right within CachedImage, which manages a map of images to certain sizes, by utilizing the new ImageBySizeCache.

CachedImage::imageForRenderer() takes a RenderObject* parameter, which it uses to look up the last set image container size for a renderer.
Using that size it queries the cache whether it already has an SVGImage for that size, if not it gets created, by creating a whole
new instance of SVGImage, filling it with the already decoded data, and passing on a fixed image container size, which overrides the
size that RenderSVGRoot reports, when computeReplacedLogicalWidth/Height is called and thus laying out the document at the desired size.
This image is then put in the cache for further reusability.

Likewise CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter and stores that in the cache with an associated container size.
It requires to touch several files which use CachedImage throughout WebCore/WebKit/WebKit2.

The actual cache is not yet turned on yet, so this is not a functional change so far, as it needs some other changes to SVGImage,
which will come with the master patch in bug 47156.

No new tests yet, as the new cache isn't turned on yet.

  • CMakeLists.txt: Add rendering/ImageBySizeCache.* to build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
  • bindings/objc/DOM.mm: Ditto (for CachedImage::image()). (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::variantFromObject): Ditto (for CachedImage::image()).
  • css/CSSCanvasValue.cpp: s/m_clients/clients()/, which now live in the ImageBySizeCache instead of CSSImageGeneratorValue. (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized): (WebCore::CSSCanvasValue::image):
  • css/CSSGradientValue.cpp: Ditto. (WebCore::CSSGradientValue::image):
  • css/CSSImageGeneratorValue.cpp: Move the sizes/clients/images cache into a new ImageBySizeCache class, to make it usable for CachedImage as well. (WebCore::CSSImageGeneratorValue::addClient): Adapt to move. (WebCore::CSSImageGeneratorValue::removeClient): Ditto. (WebCore::CSSImageGeneratorValue::getImage): Ditto. (WebCore::CSSImageGeneratorValue::putImage): Ditto.
  • css/CSSImageGeneratorValue.h: (WebCore::CSSImageGeneratorValue::clients): Forwarded to the ImageBySizeCache.
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): CachedImage::canRender() now takes a RenderObject* parameter.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): Use new CachedImage::imageSizeForRenderer(RenderObject*) method. (WebCore::HTMLImageElement::height): Ditto. (WebCore::HTMLImageElement::naturalWidth): Ditto. (WebCore::HTMLImageElement::naturalHeight): Ditto.
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish): Ditto. (WebCore::ImageDocument::scale): Ditto. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::imageUpdated): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto.
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): Use new CachedImage::imageForRenderer(RenderObject*) method.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): Ditto. (WebCore::size): Ditto (for CachedImage::imageSizeForRenderer()). (WebCore::CanvasRenderingContext2D::drawImage): Ditto. (WebCore::CanvasRenderingContext2D::createPattern): Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
  • loader/cache/CachedImage.cpp: Add currently _disabled_ cache for SVGImages. The intrinsic size negotiation will need to use multiple SVGImages for each requested size (equal to the size of the embedding place for the image) - make it possible to cache these SVGImages, and maintain a cache for them. The hash code is a 1:1 refactoring from the already present code in CSSImageGeneratorValue, now named 'ImageBySizeCache'. (WebCore::CachedImage::lookupImageForSize): Looks up an Image from the cache for a given IntSize. Currently turned off. (WebCore::CachedImage::lookupImageForRenderer): Looks up an Image from the cache for a given renderer. Currently turned off. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Looks up an Image from the cache or creates a new SVGImage for a given size and caches it, if possible. Currently turned off. All following changes share this: Don't operate on m_image directly, instead always look up one from the cache for a given size or renderer - if that's not present fallback to m_image. When an SVGImage is first created by CachedImage::createImage() and stored in m_image, the cache remains empty.

If eg. <img width="30" height="70" src="foo.svg"> is used which implies a container size of 30x70 a new SVGImage is created with the additional information of a 30x70 container size
which is immediately passed to the SVGImage after its creation. This SVGImage is put in the ImageBySizeCache associated with a container size of 30x70.
We now have two SVGImage objects present, one living in CachedImage::m_image, created by createImage() during data decoding, and one living in the ImageBySizeCache
created by lookupOrCreateImageForRenderer() associated with the 30x70 container. The first SVGImage::size() will return a value as defined in the referenced foo.svg,
whereas the SVGImage::size() call of the new SVGImage living in the cache reports 30x70 and renders according to that.

Whenever any method of CachedImage is called with a RenderObject* or IntSize, we can't just operate on m_image anymore but instead have to lookup the right
images for a certain renderer/size from the cache and operate on these. When calling eg. CachedImage::image() with a null renderer, m_image is returned.
When passing with a valid renderer only cache lookups are done if the m_image is actually a SVGImage, otherwhise lookupImageForSize/Renderer will just return the m_image.
There is no logical change induced for non-SVGImage derived images.

CachedImage::image() of course needs a RenderObject* parameter now, to identify which of the images from the cache to use, if the underlying image is a SVGImage.
Luckily these information are already present in StyleCachedImage/StyleImage & friends and only need to be added for some additional methods.
(WebCore::CachedImage::image): FIXME
(WebCore::CachedImage::imageForRenderer): Call lookupOrCreateImageForRenderer() instead of returning m_image, if it's not null. Its a no-op for non SVGImage derived objects.
(WebCore::CachedImage::setContainerSizeForRenderer): For non-SVGImages, just pass on the size to the m_image. For SVGImages, associate the passed in renderer with the IntSize in the cache.

This does NOT create the SVGImage yet, this is delayed until imageForRenderer() is called for a given renderer that wants this size.

(WebCore::CachedImage::imageSize): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
(WebCore::CachedImage::imageRect): Ditto.
(WebCore::CachedImage::clear): Force clearing the m_svgImageCache.
(WebCore::CachedImage::data): Call m_image->size() instead of imageSize(), to avoid having to pass a null renderer to imageSize() as here no renderer is available yet.
(WebCore::CachedImage::destroyDecodedData): Don't destroy decoded data for SVG images, as m_data needs to be accessable at any time to construct a cloned SVGImage.

In future we don't need this anymore if we make sure multiple SVGImages share the same trees, but that's for a follow-up patch.

(WebCore::CachedImage::decodedSizeChanged): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
(WebCore::CachedImage::didDraw): Ditto.
(WebCore::CachedImage::shouldPauseAnimation): Ditto.
(WebCore::CachedImage::animationAdvanced): Ditto.
(WebCore::CachedImage::changedInRect): Ditto. (eg. when leaving out this change animated SVG images wouldn't update anymore, as the animation didn't happen on m_image!)

  • loader/cache/CachedImage.h: imageForRenderer/canRender/setContainerSizeForRenderer/imageSizeForRenderer now all take a RenderObject* parameter to identifiy the current user of the image. (WebCore::CachedImage::canRender): Pass on the incoming renderer to imageSizeForRenderer().
  • page/DragController.cpp: (WebCore::getImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Ditto.
  • page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): Ditto. (WebCore::PageSerializer::addImageToResources): Ditto. (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration): Ditto.
  • page/PageSerializer.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject): Ditto.
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Ditto.
  • platform/graphics/Image.h: (WebCore::Image::isSVGImage): Add boolean helper to identify SVGImages, just like isBitmapImage().
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::declareAndWriteDragImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage): Ditto.
  • platform/mac/HTMLConverter.mm: (fileWrapperForElement): Ditto.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Ditto.
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Ditto.
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.
  • platform/win/ClipboardWin.cpp: (WebCore::writeImageToDataObject): Ditto.
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Ditto.
  • platform/wince/PasteboardWinCE.cpp: (WebCore::Pasteboard::writeImage): Ditto.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::image): Ditto.
  • rendering/ImageBySizeCache.cpp: Copied from WebCore/css/CSSImageGeneratorValue.cpp, to preserve history for the original cache code. (WebCore::ImageBySizeCache::ImageBySizeCache): Straight copy from CSSImageGeneratorValue, renamed to ImageBySizeCache, removing all but the cache relevant code. (WebCore::ImageBySizeCache::addClient): Ditto. (WebCore::ImageBySizeCache::removeClient): Ditto. (WebCore::ImageBySizeCache::getImage): Ditto. (WebCore::ImageBySizeCache::putImage): Ditto. (WebCore::ImageBySizeCache::clear): New function, that clears the cache, introduced for the needs of CachedImage. (WebCore::ImageBySizeCache::imageForSize): New function to query an Image* for a given IntSize, introduced for the needs of CachedImage. (WebCore::ImageBySizeCache::sizeForClient): New function to query an IntSize for a given renderer.
  • rendering/ImageBySizeCache.h: Copied from WebCore/css/CSSImageGeneratorValue.h. (WebCore::ImageBySizeCache::clients):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): CachedImage::canRender() now takes a RenderObject* parameter. (WebCore::InlineFlowBox::paintBoxDecorations): Ditto. (WebCore::InlineFlowBox::paintMask): Ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages): Ditto. (WebCore::RenderBox::repaintLayerRectsForImage): Ditto.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Ditto. (WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto (for CachedImage::setContainerSizeForRenderer()). (WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageSizeForError): Use new CachedImage::imageForRenderer(RenderObject*) method. (WebCore::RenderImage::setImageSizeForAltText): Ditto. (WebCore::RenderImage::computeReplacedLogicalWidth): FIXME
  • rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass on m_renderer to CachedImage::setContainerSizeForRenderer().
  • rendering/RenderImageResource.h: Remove constness from setContainerSizeForRenderer. (WebCore::RenderImageResource::image): Pass on m_renderer to CachedImage::image(). (WebCore::RenderImageResource::imageSize): Pass on m_renderer to CachedImage::imageSizeForRenderer().
  • rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Remove constness, pass on m_renderer to StyleImage::setContainerSizeForRenderer().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use new CachedImage::imageForRenderer(RenderObject*) method. (WebCore::RenderLayerBacking::updateImageContents): Ditto.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter.
  • rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): CachedImage::canRender() now takes a RenderObject* parameter. (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Ditto.
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::canRender): Pass on incoming renderer to CachedImage::canRender(). (WebCore::StyleCachedImage::imageSize): Pass on incoming renderer to CachedImage::imageSizeForRenderer(). (WebCore::StyleCachedImage::setContainerSizeForRenderer): Pass on incoming renderer to CachedImage::setContainerSizeForRenderer(). (WebCore::StyleCachedImage::addClient): Remove unneeded return statment in void method. (WebCore::StyleCachedImage::removeClient): Ditto. (WebCore::StyleCachedImage::image): Pass on incoming renderer to CachedImage::image().
  • rendering/style/StyleCachedImage.h: Add RenderObject* parameter to canRender()/setContainerSizeForRenderer(). image() already has one, that was unused so far.
  • rendering/style/StyleGeneratedImage.cpp: Inlined setContainerSizeForRenderer.
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Add RenderObject* parameter.
  • rendering/style/StyleImage.h: (WebCore::StyleImage::canRender): Ditto.
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build): Use new CachedImage::imageForRenderer(RenderObject*) method.
  • svg/graphics/SVGImage.cpp: Cleanup file, the include hack seems not needed anymore. (WebCore::SVGImage::setContainerSize): s/LayoutSize/IntSize/ to match the code in platform/.
  • svg/graphics/SVGImage.h: Ditto. (WebCore::SVGImage::isSVGImage): Return true.
01:04 Changeset [97447] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Make it possible for plugins to get current fullscreen element.
WebCore::Document already has webkitCurrentFullScreenElement().
Add a wrapper for it in WebKit::WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=70076

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-14
Reviewed by Darin Fisher.

  • public/WebDocument.h:
  • src/WebDocument.cpp:

(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::isHTMLDocument):
(WebKit::WebDocument::isPluginDocument):
(WebKit::WebDocument::fullScreenElement):

00:07 Changeset [97446] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Speculation failures in ValueToInt32 are causing a 2x slow-down
in Kraken/stanford-crypto-pbkdf2
https://bugs.webkit.org/show_bug.cgi?id=70089

Reviewed by Gavin Barraclough.

If we can't truncate to Int32 using machine code, then don't fail
speculation. Just call JSC::toInt32.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

00:01 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt version on the bots (diff)
Note: See TracTimeline for information about the timeline view.