Timeline


and

10/25/11:

23:57 Changeset [98437] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

C/C++ needs ; after each statement.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

23:56 Changeset [98436] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Mac, Qt, and Windows rebaseline r98407.

  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
23:47 Changeset [98435] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

GTK build fix attempt after r98413 and r98416.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::geometryDidChange):

23:46 Changeset [98434] by commit-queue@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r98379.
http://trac.webkit.org/changeset/98379
https://bugs.webkit.org/show_bug.cgi?id=70875

Did not pass on JSC ports (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
23:25 Changeset [98433] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r98346.
http://trac.webkit.org/changeset/98346
https://bugs.webkit.org/show_bug.cgi?id=70874

Breaks JSC-based bots. (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
  • inspector/debugger/watch-expressions-panel-switch.html: Removed.
23:20 Changeset [98432] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Flaky Test: editing/pasteboard/copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):

When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

  • editing/pasteboard/copy-standalone-image.html:
  • platform/chromium/test_expectations.txt:
22:55 Changeset [98431] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Split DFGJITCodeGenerator::callOperation methods
https://bugs.webkit.org/show_bug.cgi?id=70870

Reviewed by Filip Pizlo.

The DFGJITCodeGenerator currently contains two sets of callOperation methods.
One set works with the JSVALUE64 value representation and passes arguments in
registers (suitable for use on x86-64), and one set works with the JSVALUE32_64
value representation and passes arguments in memory (suitable for use on x86).
By refactoring out the representation and calling convention specific aspects
of the code we can also configure the DFG JIT to operator on platforms that use
the JSVALUE32_64 value representation but pass arguments in registers.

On platforms supported by the JIT, the payload precedes the tag of a value in
argument/result ordering, as such, in order to make the setupResults method
generally applicable to return the results of a function that are returned in
two registers, the ordering of arguments to this function has been reversed -
as is the ordering of augments passed to setupArguments methods, with respect
to the ordering with which they are passed in to callOperation.
This inconsistency will be resolved in a later change when we combine the pairs
of arguments passed into callOperation, such that the function signatures can
be made consistent across the two value representations (the callOperation
methods will be passed a reference to a struct representing the JSValue
temporary, this will consist of two gprs on 32_64 and one on 64).

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):

  • moved, removed tag,payload version of this method.

(JSC::DFG::setupArguments):
(JSC::DFG::setupArgumentsExecState):
(JSC::DFG::setupArgumentsWithExecState):

  • Calling convention specific portion of callOperation refactored out into these methods.

(JSC::DFG::callOperation):

  • updated these methods to use setupArguments* methods.

(JSC::DFG::setupResults):

  • setupResults is now passed payload,tag.

(JSC::DFG::appendCallWithExceptionCheckSetResult):

  • Added fpr versions of this function.

(JSC::DFG::appendCallSetResult):

  • Added versions of this function without exception check.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • setupResults is now passed payload,tag.
22:17 Changeset [98430] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

  • platform/qt/Skipped:
22:02 Changeset [98429] by nduca@chromium.org
  • 15 edits in trunk/Source

[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::hasThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebLayerTreeView.h:
  • src/WebCompositorImpl.cpp:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

21:57 Changeset [98428] by xji@chromium.org
  • 7 edits
    2 adds in trunk

--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Get next or previous root inline box (which is not in the same
render object as the current root inline box) by traversing DOM node.

Test: editing/selection/move-by-word-visually-inline-block-positioned-element.html

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element.html:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
20:06 Changeset [98427] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

JSEventTarget.cpp has a bunch of unnessary includes
https://bugs.webkit.org/show_bug.cgi?id=70865

Reviewed by Eric Seidel.

In the process of removing these includes, I noticed we had a bunch of
non-autogenerated code in this file, which I've now autogenerated.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

  • One subtly here is the outter static_cast, which is caused by an inheritance infelicity in JavaScriptAudioNode, which I've noted with a FIXME. In any case, the extra static_cast shouldn't cause any trouble.
  • webaudio/JavaScriptAudioNode.h:
19:14 Changeset [98426] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

V8DOMWrapper.cpp has unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=70863

Reviewed by Eric Seidel.

  • bindings/v8/V8DOMWrapper.cpp:
19:12 Changeset [98425] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

Fix ad hoc test.

unreviewed.

  • fast/canvas/webgl/gl-teximage.html:
19:11 Changeset [98424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

Fix occurrence of unpainted tiles while scrolling and zooming.
https://bugs.webkit.org/show_bug.cgi?id=70711

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
For the proper calculation to generate a float number, at least one of operatees must be a float type.
But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
so it generates smaller result than expected result when it is using ceil API.
As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_recalc_renderers):
(ewk_tiled_backing_store_zoom_weak_set):

18:59 Changeset [98423] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

Resetting baseline for test bindings

Unreviewed preemptive build fix

No new tests.

  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
18:49 Changeset [98422] by mhahnenberg@apple.com
  • 59 edits in trunk/Source

Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::deletePropertyByIndex):

  • API/JSObjectRef.cpp:

(JSObjectDeleteProperty):

(JSC::DebuggerActivation::deleteProperty):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):

  • runtime/JSArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:
  • runtime/JSVariableObject.h:
  • runtime/RegExpMatchesArray.h:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StrictEvalActivation.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::deleteProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::deleteProperty):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::remove):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/NP_jsobject.cpp:

(_NPN_RemoveProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::removeMember):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::removeProperty):

18:45 Changeset [98421] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/slider-allows-title-ui-element.html

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::isControl):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
  • platform/mac/accessibility/slider-allows-title-ui-element.html: Added.
18:38 Changeset [98420] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

fast/forms/form-associated-element-crash3.html has
been timing out very regularly on linux debug.

18:15 Changeset [98419] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=67588

Some of variables which aren't related with loop count or other variables
inside of loop are moved out of loop.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):

18:13 Changeset [98418] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix after r97587.

  • win/WebKit2CFLite.def:
18:01 Changeset [98417] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix expectation.

unreviewed.

  • platform/chromium/fast/js/kde/garbage-n-expected.txt:
18:00 Changeset [98416] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
https://bugs.webkit.org/show_bug.cgi?id=67227
<rdar://problem/10048319>

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Apply the scale factor when painting.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Apply the scale factor when painting.

(WebKit::PluginProxy::geometryDidChange):
Make sure to apply the contents scale factor to the backing store size.

(WebKit::PluginProxy::update):
Apply the scale factor (when painting).

17:56 Changeset [98415] by mhahnenberg@apple.com
  • 76 edits in trunk/Source

Remove putVirtual
https://bugs.webkit.org/show_bug.cgi?id=70740

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):

(JSC::DebuggerActivation::put):

  • debugger/DebuggerActivation.h:
  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::put):
(JSC::JSCell::putByIndex):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSValue::put):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectSetProperty):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::put):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomPut):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::setMember):
(JavaJSObject::setSlot):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:
  • bridge/testqtbindings.cpp:

(main):

Source/WebKit/efl:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/mac:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

17:34 Changeset [98414] by andersca@apple.com
  • 3 edits in trunk

Add radar.

17:30 Changeset [98413] by andersca@apple.com
  • 18 edits in trunk

Plug-ins have no way to find out when the device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=67226

Reviewed by Sam Weinig.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

  • PluginProcess/PluginControllerProxy.h:

This now takes the contentsScaleFactor and calls contentsScaleFactorChanged on its plug-in
if the scale factor changes.

  • PluginProcess/PluginControllerProxy.messages.in:

GeometryDidChange now takes a contents scale factor parameter.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::contentsScaleFactorChanged):
Implement contentsScaleFactorChanged and call NPP_SetValue with the new scale factor.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::contentsScaleFactorChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Add stub.

  • WebProcess/Plugins/Plugin.h:

Add pure virtual contentsScaleFactorChanged member function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Add geometryDidChange overload that doesn't take any parameters. Make it send over the
new scale factor to the plug-in process.

(WebKit::PluginProxy::contentsScaleFactorChanged):
Call geometryDidChange.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setDeviceScaleFactor):
Call Plugin::contentsScaleFactorChanged.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):
Call setDeviceScaleFactor on all registered plug-ins.

Tools:

Keep a cached copy of the contents scale and update it when it changes.

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:

(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::cachedContentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::NPP_New):
(ContentsScaleFactor::NPP_SetValue):

LayoutTests:

Update test to check that the scale factor is updated correctly.

  • platform/mac-wk2/plugins/contents-scale-factor.html:
16:43 Changeset [98412] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

EventTargetFactory.in is not sorted
https://bugs.webkit.org/show_bug.cgi?id=70855

Reviewed by Eric Seidel.

PerformanceTests:

Add a microbenchmark for wrapping event target.

  • Bindings: Added.
  • Bindings/event-target-wrapper.html: Added.
  • Parser/resources/runner.js:

(runLoop):

  • Let the user of the harness get a callback when the test is done.

Source/WebCore:

This patch sorts the file. I was not able to measure a performance
difference using the microbenchmark included with this patch.

  • dom/EventTargetFactory.in:
16:42 Changeset [98411] by fsamuel@chromium.org
  • 7 edits
    3 adds in trunk/LayoutTests

Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

  • fast/table/table-anonymous-cell-bug-expected.png: Added.
  • fast/table/table-anonymous-cell-bug-expected.txt:
  • fast/table/table-anonymous-cell-bug.html:
  • fast/table/table-anonymous-row-bug-expected.png: Added.
  • fast/table/table-anonymous-row-bug-expected.txt:
  • fast/table/table-anonymous-row-bug.html:
  • fast/table/table-anonymous-section-bug-expected.png: Added.
  • fast/table/table-anonymous-section-bug-expected.txt:
  • fast/table/table-anonymous-section-bug.html:
16:39 Changeset [98410] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Windows build. Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSEventTarget.cpp:
16:19 Changeset [98409] by weinig@apple.com
  • 2 edits in trunk/Tools

Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).

(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

16:17 Changeset [98408] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

  • editing/selection/table-lineboundary-expected.txt: Added.
  • editing/selection/table-lineboundary.html: Added.
16:10 Changeset [98407] by arv@chromium.org
  • 1609 edits
    1 delete in trunk

JS Test Harness: Make successfullyParsed optional
https://bugs.webkit.org/show_bug.cgi?id=70784

Reviewed by Ojan Vafai.

Tools:

  • Scripts/make-new-script-test:

(writeTestFile): Update the template for script tests.

LayoutTests:

This makes "successfullyParsed = true" optional in favor of tracking syntax errors
using window.onerror.

  • fast/*: Remove successfullyParsed.
  • fast/dom/Window/new-window-opener.html: Cleanup.
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/webkitConvertPoint.html: Ditto.
  • fast/dom/Window/webkitConvertPointUpdateLayout.html: Ditto.
  • fast/js/kde/evil-n.html: This is now a normal test since it is not supposed to fail.
  • fast/js/kde/garbage-n-expected.txt:
  • fast/js/kde/garbage-n.html: Use shouldHaveHadError instead of js-test-post-n.js
  • fast/js/kde/string-1-n.html: Ditto.
  • fast/js/kde/string-2-n.html: Ditto.
  • fast/js/resources/js-test-post-async.js: Ensure we didn't get an error.
  • fast/js/resources/js-test-post-function.js: Ditto.
  • fast/js/resources/js-test-post-n.js: Removed.
  • fast/js/resources/js-test-pre.js: Added shouldHaveHadError function that can be used to assert that the

error message is what was expected.
Ensure we didn't get an error in finistJSTest.

16:10 Changeset [98406] by bdakin@apple.com
  • 9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore:

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds
platform-independent GraphicsContext::applyDeviceScaleFactor().

  • WebCore.exp.in:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been
reverted to do what it used to do before that was added; it just calls into
WebCoreSystemInterface directly.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

Source/WebKit2:

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and
adjusting the base CTM.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

16:06 Changeset [98405] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::appendCallWithExceptionCheck):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

16:02 Changeset [98404] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

More gardening.

  • platform/chromium/test_expectations.txt: Missed some cases where

video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

16:00 Changeset [98403] by andersca@apple.com
  • 19 edits
    3 adds in trunk

Source/WebCore: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

  • plugins/npapi.h:

Source/WebKit2: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

  • PluginProcess/PluginControllerProxy.h:

Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):

  • PluginProcess/PluginCreationParameters.h:

Add contentsScaleFactor to the creation parameters.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

  • WebProcess/Plugins/PluginController.h:

Add contentsScaleFactor pure virtual member function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

  • WebProcess/Plugins/PluginView.h:

Add contentsScaleFactor().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.

(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add tests.

  • platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
  • platform/mac-wk2/plugins/contents-scale-factor.html: Added.
15:55 Changeset [98402] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Forward declare MutationObserverEntry as a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853

Reviewed by Ryosuke Niwa.

Node.h forward declared MutationObserverEntry as a class, and clang
complains if the two declarations don't match.

  • dom/Node.h:
15:51 Changeset [98401] by leviw@chromium.org
  • 8 edits in branches/subpixellayout/Source

Mac build fixes and adding pixelSnapped convenience methods for accessors that needed them.

15:45 Changeset [98400] by mitz@apple.com
  • 3 edits
    1 add in trunk/Source/WebCore

Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70851

Reviewed by Dave Hyatt.

  • manual-tests/caret-in-columns-flipped.html: Added.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
from this function, since not all callers were expecting it to account for flippedness. This makes
it similar to adjustRectForColumns() in not adjusting for flippedness.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
columns, then flipping.

15:35 Changeset [98399] by weinig@apple.com
  • 6 edits
    2 adds in trunk

Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Source/WebKit2:

Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
and didFailLoad.

Reviewed by Anders Carlsson.

Test: WKBrowsingContextLoadDelegateTest

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(setUpPageLoaderClient):

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Tools:

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2ObjC: Added.
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.

(WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
(WKBrowsingContextLoadDelegateTest::SetUp):
(WKBrowsingContextLoadDelegateTest::TearDown):
(-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
(TEST_F):
Add basic testing for WKBrowsingContextLoadDelegate.

14:56 Changeset [98398] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854

Reviewed by Oliver Hunt.

Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.

This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):

  • bytecode/CodeBlock.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

14:44 Changeset [98397] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

More unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark another test

as crashing. Moved 2 tests together as they hit the same ASSERT
on the bots.

14:25 Changeset [98396] by eae@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore/platform

Fix scrollbars for chromium/linux

14:16 Changeset [98395] by ap@apple.com
  • 2 edits in trunk/Tools

make-script-test-wrappers should not look outside fast/js
https://bugs.webkit.org/show_bug.cgi?id=66357

Reviewed by Maciej Stachowiak.

  • Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support

fast/js.

14:11 Changeset [98394] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion failure when zooming a PDF in an iframe
https://bugs.webkit.org/show_bug.cgi?id=70849

Reviewed by Alexey Proskuryakov.

If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

14:10 Changeset [98393] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source

Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <piman@chromium.org> on 2011-10-25
Reviewed by James Robinson.

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

13:59 Changeset [98392] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
13:56 Changeset [98391] by eae@chromium.org
  • 1101 edits
    2420 copies
    54 deletes in branches/subpixellayout

Merging trunk changes up until 98381 into subpixel branch.

13:54 Changeset [98390] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add a --make option to update-webkit to engage the Makefile-based build system
https://bugs.webkit.org/show_bug.cgi?id=70847

Reviewed by Dimitri Glazkov.

I can never remember what crazy environment variables I'm supposed to
set to tell GYP what to do.

  • Scripts/update-webkit:
13:46 Changeset [98389] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
https://bugs.webkit.org/show_bug.cgi?id=70827
<rdar://problem/10342925>

Reviewed by Adam Barth.

Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
able to make a test case that would reproduce this crash, we do check m_currentItem for null
everywhere else, and the crash log indicates that this would fix the crash.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveUpdateForCommit):

13:44 Changeset [98388] by abarth@webkit.org
  • 74 edits
    1 add in trunk/Source

EventTarget.h shouldn't need to know about every feature and ifdef
https://bugs.webkit.org/show_bug.cgi?id=70659

Reviewed by Darin Adler.

Source/WebCore:

This patch follows the approach of Event.h and introduces an
interfaceName virtual function that returns the name of the DOM
interface for the concrete type of the object. This function lets us
remove a large number of fake dynamic casts.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
    • Teach action_makenames how to handle the new "in" file.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • Use the new autogenerated macro to remove a large amount of feature-specific code.
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • bindings/objc/DOM.mm:

(kit):

  • The SVGElementInstance branch was never taken previously because SVGElementInstance::toNode returns a non-NULL value. This code was introduced in http://trac.webkit.org/changeset/42618 and doesn't appear to have ever worked as the author intended.
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • Use the new autogenerated macro to remove a large amount of feature-specific code.
  • dom/EventNames.cpp:

(WebCore::EventNames::EventNames):

  • dom/EventNames.h:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in: Added.
    • Add a new "in" file that lists all the EventTargets.
  • dom/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::interfaceName):

  • dom/LocalMediaStream.h:
  • dom/MediaStream.cpp:

(WebCore::MediaStream::interfaceName):

  • dom/MediaStream.h:
  • dom/MessagePort.cpp:

(WebCore::MessagePort::interfaceName):

  • dom/MessagePort.h:
  • dom/Node.cpp:

(WebCore::Node::toNode):
(WebCore::Node::interfaceName):

  • dom/Node.h:
  • dom/make_event_factory.pl:
    • Generalize make_event_factory.pl to be able to generate interfaces for different namespaces.
  • fileapi/FileReader.cpp:

(WebCore::FileReader::interfaceName):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::interfaceName):

  • fileapi/FileWriter.h:
  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::interfaceName):

  • loader/appcache/DOMApplicationCache.h:
  • notifications/Notification.cpp:

(WebCore::Notification::interfaceName):

  • notifications/Notification.h:

(WebCore::Notification::scriptExecutionContext):

  • p2p/PeerConnection.cpp:

(WebCore::PeerConnection::interfaceName):

  • p2p/PeerConnection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::interfaceName):
(WebCore::DOMWindow::toDOMWindow):

  • page/DOMWindow.h:
  • page/EventSource.cpp:

(WebCore::EventSource::interfaceName):

  • page/EventSource.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::interfaceName):

  • storage/IDBDatabase.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::interfaceName):

  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::interfaceName):

  • storage/IDBTransaction.h:
  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::interfaceName):

  • storage/IDBVersionChangeRequest.h:
  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::interfaceName):

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::toNode):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::interfaceName):
(WebCore::AudioContext::scriptExecutionContext):

  • webaudio/AudioContext.h:
  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::interfaceName):

  • webaudio/JavaScriptAudioNode.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::interfaceName):

  • websockets/WebSocket.h:
  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::interfaceName):

  • workers/DedicatedWorkerContext.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::performTask):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::interfaceName):

  • workers/SharedWorker.h:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::interfaceName):

  • workers/SharedWorkerContext.h:
  • workers/Worker.cpp:

(WebCore::Worker::interfaceName):

  • workers/Worker.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::interfaceName):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::interfaceName):

  • xml/XMLHttpRequestUpload.h:

Source/WebKit/chromium:

This cast isn't needed because dispatchEvent is a virtual function.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask):

13:42 Changeset [98387] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

  • DumpRenderTree/efl/EventSender.cpp:

(sendMouseEvent):
(keyDownCallback):

13:38 Changeset [98386] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
restrictions for now.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):

13:36 Changeset [98385] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811

Reviewed by Adam Barth.

This patch does not have any effect on generated bindings.

  • dom/DataTransferItems.idl:
  • page/History.idl:
  • storage/IDBIndex.idl:
  • xml/XMLHttpRequest.idl:
13:30 Changeset [98384] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=70818

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

  • public/WebGraphicsContext3D.h:
13:23 Changeset [98383] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixing Windows build after r98367

Unreviewed build fix

13:22 Changeset [98382] by leandro@webkit.org
  • 1 edit
    106 adds in trunk/LayoutTests

[EFL] Unreviewed. Add CSS1 pixel baselines.

  • platform/efl/css1: [...]
13:01 Changeset [98381] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebKit/chromium

Make it possible to create and dispatch a message event through chromium API

Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data->messageData. Reordered includes.

https://bugs.webkit.org/show_bug.cgi?id=69962

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-25
Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebDOMEvent.h:
  • public/WebDOMMessageEvent.h: Added.
  • public/WebDocument.h:
  • public/WebNode.h:
  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::hasPendingActivity):

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::operator WTF::PassRefPtr<WebCore::Event>):

  • src/WebDOMMessageEvent.cpp: Added.

(WebKit::WebDOMMessageEvent::initMessageEvent):

  • src/WebDocument.cpp:

(WebKit::WebDocument::createEvent):

  • src/WebNode.cpp:

(WebKit::WebNode::dispatchEvent):

12:50 Changeset [98380] by japhet@chromium.org
  • 18 edits in trunk

Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks

for didFail() and didFinishLoading(), so we need to differentiate here.

(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()

instead of ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting

DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
'data' input parameter will contain all data received so far, and we need to determine the
incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
the incremental data.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):

  • loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel

the request, so protect appropriately.

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
12:48 Changeset [98379] by abarth@webkit.org
  • 8 edits in trunk

Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Patch by Pavel Podivilov <podivilov@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
12:45 Changeset [98378] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add function to get geometry of focused element
https://bugs.webkit.org/show_bug.cgi?id=70728

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Added function to ewk_frame to get the geometry of the focused
element within the frame object.

  • ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
the focused element within the given frame object.

  • ewk/ewk_frame.h:
12:37 Changeset [98377] by dbates@webkit.org
  • 2 edits in trunk/Tools

build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834

Reviewed by Antonio Gomes.

Currently build-webkit --clean both cleans the build directory and builds WebKit for
CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
as per its description in the usage message of build-webkit.

  • Scripts/webkitdirs.pm:

(buildCMakeProjectOrExit):

12:32 Changeset [98376] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add necessary information for callback instropection
https://bugs.webkit.org/show_bug.cgi?id=70735

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Provide the information about smart callbacks emitted by the ewk_view
object, so that these can be easily forwarded by other objects or used
by bindings in other languages without having to keep track of all of
them manually.

  • ewk/ewk_view.cpp:

(ewk_view_base_smart_set):

12:31 Changeset [98375] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Marking a test as timing

out.

12:28 Changeset [98374] by cevans@google.com
  • 2 edits in trunk/Source/WebCore

Manage the CSS property array length correctly
https://bugs.webkit.org/show_bug.cgi?id=70783

Reviewed by Adam Barth.

  • css/CSSParser.cpp:

(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.

12:26 Changeset [98373] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

avoid unnecessary layouts of flex items during the flex pass
https://bugs.webkit.org/show_bug.cgi?id=70557

Reviewed by Ojan Vafai.

If the preferred size of a flex item is provided, we don't need to
layout the flex item when computing the preferred size. This allows
us to only call layout on each flex item once in the common case.

No new tests, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:
12:12 UsingGitWithWebKit edited by jberlin@webkit.org
Add instructions for how to tell git to ignore "changes" by file system … (diff)
12:10 Changeset [98372] by fsamuel@chromium.org
  • 5 edits
    6 adds in trunk

Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html

fast/table/table-anonymous-row-bug.html
fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

  • fast/table/table-anonymous-cell-bug-expected.txt: Added.
  • fast/table/table-anonymous-cell-bug.html: Added.
  • fast/table/table-anonymous-row-bug-expected.txt: Added.
  • fast/table/table-anonymous-row-bug.html: Added.
  • fast/table/table-anonymous-section-bug-expected.txt: Added.
  • fast/table/table-anonymous-section-bug.html: Added.
12:10 Changeset [98371] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp

Fixing false assertion and correcting unrounded values for adjusting height and offset for floats.

12:05 Changeset [98370] by leviw@chromium.org
  • 2 edits
    3 copies in branches/chromium/912

Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8390012

12:01 Changeset [98369] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
<rdar://problem/10312733>

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

  • WebProcess/Plugins/Plugin.h:

Add wantsWindowRelativeCoordinates.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

11:59 Changeset [98368] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-25
Reviewed by Darin Adler.

11:51 Changeset [98367] by mhahnenberg@apple.com
  • 6 edits in trunk/Source

Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • JavaScriptCore.exp:
  • runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
  • runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can

reference it in their MethodTables.

Source/WebCore:

No new tests.

  • bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so

subclasses can reference it in their MethodTables.

11:24 Changeset [98366] by zherczeg@webkit.org
  • 3 edits in trunk/LayoutTests

Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

  • fast/css/uri-token-parsing-expected.txt:
  • fast/css/uri-token-parsing.html:
11:17 Changeset [98365] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

11:10 Changeset [98364] by jchaffraix@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
11:06 Changeset [98363] by jchaffraix@webkit.org
  • 1 edit
    1 add
    6 deletes in trunk/LayoutTests

Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

  • platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
  • platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
10:54 Changeset [98362] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

"Open with" item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
<rdar://problem/10034302>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/PDFViewController.mm:

(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a "Copy" item. If a "Copy" item is not found,
inserts the Open With item at the top of the context menu.

10:54 Changeset [98361] by simon.fraser@apple.com
  • 8 edits
    9 adds
    2 deletes in trunk

REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html

transforms/3d/hit-testing/rotated-hit-test-with-child.html
transforms/3d/hit-testing/rotated-hit-test2.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):

  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/HitTestingTransformState.cpp:

(WebCore::HitTestingTransformState::boundsOfMappedQuad):

  • rendering/HitTestingTransformState.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

  • platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
  • platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
  • transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
  • transforms/3d/hit-testing/composited-hit-test.html: Added.
  • transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
  • transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
  • transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
  • transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
  • transforms/3d/hit-testing/rotated-hit-test.html:
  • transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
  • transforms/3d/hit-testing/rotated-hit-test2.html: Added.
10:44 Changeset [98360] by enne@google.com
  • 16 edits
    2 adds in trunk/Source/WebCore

[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.

(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h: Added.

(WebCore::CCTextureUpdater::allocator):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitOnImplThread):

10:42 Changeset [98359] by jer.noble@apple.com
  • 7 edits in trunk

compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

  • compositing/video/video-poster.html: Seek, instead of play, to trigger

creation of a layer

  • http/tests/media/video-load-twice.html: Use waitForEventOnce so that

canPlayThrough listener is triggered only once.

  • media/video-test.js: Add a new function, waitForEventOnce.

(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

10:22 Changeset [98358] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):

  • editing/visible_units.h:
10:22 Changeset [98357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard <girard@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

10:18 Changeset [98356] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:17 Changeset [98355] by caryclark@google.com
  • 1 edit
    742 adds in trunk/LayoutTests

Unreviewed gardening: fifth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 742 files for brevity.]

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.

...

  • platform/chromium-mac-leopard/transitions: Added.
  • platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-mac-leopard/transitions/svg-text-shadow-transition-expected.png: Added.
10:04 Changeset [98354] by annacc@chromium.org
  • 2 edits in trunk/Tools

Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

09:53 Changeset [98353] by commit-queue@webkit.org
  • 9 edits
    6 adds in trunk

Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html

fast/dom/MicroData/itemtype-add-remove-tokens.html
fast/dom/MicroData/itemtype-attribute-test.html

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::nodeMatches):

  • html/DOMSettableTokenList.h:

(WebCore::DOMSettableTokenList::tokens):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

  • fast/dom/MicroData/006.html:
  • fast/dom/MicroData/007.html:
  • fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
  • fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
  • fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
  • fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
  • fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
  • fast/dom/MicroData/itemtype-attribute-test.html: Added.
09:52 Changeset [98352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

  • WebCoreSupport/GtkAdjustmentWatcher.cpp:

(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

09:40 Changeset [98351] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

  • MiniBrowser/gtk/BrowserWindow.c:

(focus):
(unFocus):
(browserWindowUIClientInit):

09:39 Changeset [98350] by mitz@apple.com
  • 4 edits in trunk

<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

  • page/Page.cpp:

(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools:

  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

09:26 Changeset [98349] by caryclark@google.com
  • 1 edit
    734 adds in trunk/LayoutTests

Unreviewed gardening: fourth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 728 of 734 files for brevity.]

  • platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/scrolled-marker-paint-expected.png: Added.
  • platform/chromium-mac-leopard/fast/media: Added.

...

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
08:35 Changeset [98348] by yurys@chromium.org
  • 13 edits in trunk

Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

  • inspector/front-end/Settings.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):

  • inspector/front-end/elementsPanel.css:
  • inspector/front-end/inspectorCommon.css:

(.sidebar-separator):
(.sidebar-label):

  • inspector/front-end/scriptsPanel.css:

(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox > input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

  • src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.

():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

08:21 Changeset [98347] by thakis@chromium.org
  • 4 edits in trunk/Source

Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium: [chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70753

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

  • WebKit.gypi:
08:06 Changeset [98346] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
  • inspector/debugger/watch-expressions-panel-switch.html: Added.
07:26 Changeset [98345] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

  • inspector/debugger/compiler-source-mapping-expected.txt:
  • inspector/debugger/compiler-source-mapping.html:
07:24 Changeset [98344] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

Check for empty string in parseArcFlag
https://bugs.webkit.org/show_bug.cgi?id=70763

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/path-invalid.html

  • svg/SVGParserUtilities.cpp:

(WebCore::parseArcFlag):

LayoutTests:

  • svg/path-arc-invalid-expected.txt: Added.
  • svg/path-arc-invalid.html: Added.
07:22 Changeset [98343] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

LayoutTests:

  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
07:04 Changeset [98342] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Double number step=.5 should be considered valid in <input type="number" step=".5">
https://bugs.webkit.org/show_bug.cgi?id=70320

Patch by Sachin Puranik <sachin.puranik@motorola.com> on 2011-10-25
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-step-as-double.html

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType): Changed the function to consider
step as valid even if it starts with "."

LayoutTests:

  • fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
  • fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
  • fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports

consider .5 as a valid double value for step attribute of input element.

  • fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
  • fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
  • fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
  • fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider

.2 as valid real number now.

  • fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.
06:57 Changeset [98341] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Audits panel context menu for links not working properly
https://bugs.webkit.org/show_bug.cgi?id=70813

Reviewed by Pavel Feldman.

  • inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):
(WebInspector.AuditResultView.prototype._contextMenuEventFired):

06:49 Changeset [98340] by eric@webkit.org
  • 3 edits in trunk/Tools

WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
https://bugs.webkit.org/show_bug.cgi?id=64471

Reviewed by Adam Roben.

Speculative fix.

  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
06:49 Changeset [98339] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Resources panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/resources-search-match-index.html

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.ResourcesSearchController):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
(WebInspector.ResourcesSearchController.prototype.previousSearchResult):
(WebInspector.ResourcesSearchController.prototype._searchResult):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):

  • inspector/front-end/treeoutline.js:

LayoutTests:

  • http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
  • http/tests/inspector/search/resources-search-match-index.html: Added.
06:45 Changeset [98338] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

  • platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.
06:38 Changeset [98337] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

This change allows us to use the template based features of the meta type system
such as using the WebView classes as types for QVariant.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebview.h:
06:17 Changeset [98336] by vsevik@chromium.org
  • 9 edits in branches/chromium/912/Source/WebCore

Merge 98105 - Web Inspector: Advanced search is working very slowly and does not show searching progress.
https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

  • inspector/front-end/inspector.css:

(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):

  • inspector/front-end/utilities.js:

():

BUG=101337
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8381041

06:09 Changeset [98335] by vsevik@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js

Revert 98334 -

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8375054

06:00 Changeset [98334] by vsevik@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js
05:59 Changeset [98333] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
https://bugs.webkit.org/show_bug.cgi?id=70812

Reviewed by Pavel Feldman.

Check if highlighted element is present while displaying object popover.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):

04:01 Changeset [98332] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit2

[Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
as the UI process drawing area proxy for tiled based rendering.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-25
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::setPage):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::QTouchWebView):
(QTouchWebView::touchEvent):
(QTouchWebView::onVisibleChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
02:54 Changeset [98331] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Reviewed by Pavel Feldman.

  • page/Console.cpp:

(WebCore::Console::time):
(WebCore::Console::timeEnd):

02:39 Changeset [98330] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
https://bugs.webkit.org/show_bug.cgi?id=58559

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
02:35 Changeset [98329] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
https://bugs.webkit.org/show_bug.cgi?id=53030

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
02:25 Changeset [98328] by caseq@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Reviewed by Pavel Feldman.

  • change webInspector.inspectedPage.reload() to accept multiple options in an object
  • add an ability to inject a script upon a page reload
  • return script id in addScriptToEvaluateOnLoad()
  • provide removeScriptToEvaluateOnLoad()
  • store scripts to evaluate on load in inspector state cookie

Source/WebCore:

Test: inspector/extensions/extensions-reload.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.InspectedWindow.prototype.reload):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onReload):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):

LayoutTests:

  • inspector/extensions/extensions-reload-expected.txt: Added.
  • inspector/extensions/extensions-reload.html: Added.
01:37 Changeset [98327] by carlosgc@webkit.org
  • 6 edits in trunk/Source/WebKit2

[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69825

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(webkitBackForwardListItemGetWKItem):

  • UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_go_to_back_forward_list_item):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(testBackForwardListNavigation):

01:24 Changeset [98326] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: print expired message count before remaining messages.
https://bugs.webkit.org/show_bug.cgi?id=70736

Reviewed by Yury Semikhatsky.

  • inspector/Inspector-0.1.json:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::restore):

  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleModel.js:
01:19 Changeset [98325] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2]Critical warning while building WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=70591

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Martin Robinson.

  • WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK
00:06 Changeset [98324] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r98309.
http://trac.webkit.org/changeset/98309
https://bugs.webkit.org/show_bug.cgi?id=70801

Test fails on mac (Requested by benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-image-expected.txt: Removed.
  • fast/canvas/canvas-composite-image.html: Removed.

10/24/11:

23:59 Changeset [98323] by ossy@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add missing result after r98309.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-24

  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
  • platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.
23:51 Changeset [98322] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=70481

Update test results to reflect that the plugin clipping rectangle
is now correct.

  • platform/gtk/Skipped: Unskip the test.
  • platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.
22:43 Changeset [98321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):

21:57 Changeset [98320] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Chromium build fix: #include window.h for HANDLE.

  • platform/graphics/opentype/OpenTypeUtilities.h:
21:49 Changeset [98319] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Include ThreadSafeRefCounted.h since the class declared in this header file
inherits from ThreadSafeRefCounted.

  • storage/IDBIndexBackendInterface.h:
21:33 Changeset [98318] by ggaren@apple.com
  • 5 edits in trunk/Source

Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.

Source/JavaScriptCore:

Source/WebKit/win:

  • WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):

  • WebIconDatabase.cpp:

(WebIconDatabase::didImportIconURLForPageURL):

21:26 Changeset [98317] by rniwa@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: Fix a typo.

  • bindings/v8/JavaScriptCallFrame.h:

Source/WebKit/win: threadsafeCopy has been renamed to isolatedCopy.

  • WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):

20:54 Changeset [98316] by ggaren@apple.com
  • 86 edits
    3 deletes in trunk/Source

Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698

Reviewed by David Levin.

Source/JavaScriptCore:

  • Removed SharedUChar because most of its functionality has moved into

other abstraction layers, and we want remaining clients to choose their
abstractions explicitly instead of relying on StringImpl to provide this
behavior implicitly, since we think they can sometimes make more efficient
choices.

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names could give the impression that the resulting object was
thread-safe, but actually it's just an isolated copy, which is not
thread-safe by itself, but can be used to implement a thread-safe
algorithm through isolation.

  • wtf/CrossThreadRefCounted.h: Removed.
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl): Removed the stuff mentioned above.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::length): Ditto.

(WTF::StringImpl::isolatedCopy): Inlined this, since it's now trivial.

  • wtf/text/WTFString.cpp:

(WTF::String::isolatedCopy):

  • wtf/text/WTFString.h: Updated for StringImpl changes.
  • API/OpaqueJSString.h:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.order:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/OwnFastMallocPtr.h:
  • wtf/RefCounted.h:
  • wtf/SizeLimits.cpp:
  • wtf/ThreadSafeRefCounted.h:
  • wtf/wtf.pri:
  • yarr/YarrPattern.h: Updated these files to accomodate removal of

CrossThreadRefCounted.h.

Source/WebCore:

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

  • Updated a bunch of files for header dependency changes, now that

CrossThreadRefCounted is gone.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
  • WebCore.exp.in:
  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • css/CSSPropertySourceData.h:
  • css/CSSValue.h:
  • css/StyleMedia.h:
  • css/WebKitCSSMatrix.h:
  • dom/QualifiedName.h:
  • fileapi/LocalFileSystem.h:

(WebCore::LocalFileSystem::SystemBasePath::operator String):

  • history/CachedFrame.h:
  • history/CachedPage.h:
  • history/HistoryItem.h:
  • html/canvas/CanvasStyle.h:
  • inspector/InspectorResourceAgent.h:
  • loader/FormState.h:
  • loader/TextResourceDecoder.h:
  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):

  • page/ContentSecurityPolicy.h:
  • page/Coordinates.h:

(WebCore::Coordinates::isolatedCopy):

  • page/Geoposition.h:

(WebCore::Geoposition::isolatedCopy):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):

  • page/SecurityOrigin.h:
  • page/animation/AnimationBase.h:
  • platform/CrossThreadCopier.cpp:

(WebCore::::copy):

  • platform/FileChooser.h:
  • platform/KURL.cpp:

(WebCore::KURL::copy):

  • platform/cf/SchedulePair.h:
  • platform/network/BlobData.cpp:

(WebCore::BlobDataItem::detachFromCurrentThread):
(WebCore::BlobData::detachFromCurrentThread):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

  • platform/network/MIMEHeader.h:
  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy):

  • platform/network/ResourceLoadInfo.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::copyData):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::copyData):

  • platform/sql/SQLValue.cpp:

(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):

  • rendering/style/QuotesData.h:
  • storage/AbstractDatabase.cpp:

(WebCore::updateGuidVersionMap):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):

  • storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::tableNames):

  • storage/DatabaseDetails.h:
  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::databaseDirectoryPath):
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):

  • storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::addDatabase):

  • storage/SQLError.h:

(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):

  • storage/SQLResultSetRowList.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::SQLStatement):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::syncTimerFired):

  • storage/StorageAreaSync.h:
  • storage/StorageMap.cpp:

(WebCore::StorageMap::importItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):

  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::willDeleteAllOrigins):

  • svg/SVGPathSeg.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::url):
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::SharedWorkerThread):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

Source/WebKit/chromium:

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

  • src/WorkerFileSystemCallbacksBridge.cpp:

Source/WebKit/mac:

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

  • Storage/WebDatabaseTrackerClient.mm:

(DidModifyOriginData::dispatchToMainThread):

20:36 Changeset [98315] by mnaganov@chromium.org
  • 5 edits in trunk/Tools

Fix bug summary when rolling Chromium DEPS to LKGR.
https://bugs.webkit.org/show_bug.cgi?id=69917

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/roll.py:
  • Scripts/webkitpy/tool/commands/roll_unittest.py:
20:17 Changeset [98314] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove empty directory.

  • p2p: Removed.
19:54 Changeset [98313] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[chromium] Refactor painting/updating/drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-24
Reviewed by James Robinson.

This refactoring separates the "early exits" from the actual loop
that draws layers. As part of this, it was also appropriate to
clean up the way that masks and replicas are dealt with when
painting and updating. The purpose of all this is to make things
easier to test, and for a scissoring optimization that needs to
know exatly what gets drawn. Existing layout tests were able to
verify the refactoring did not change behavior.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeAppended):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

19:53 Changeset [98312] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening.

Add a new baseline for snow-leopard.

  • platform/chromium-mac-snowleopard/svg/filters: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added.
19:47 Changeset [98311] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

Simplify url accessors on WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70797

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):

  • UIProcess/API/C/WKPage.h:

Add accessors to C SPI.

  • UIProcess/API/mac/WKBrowsingContextController.h:

Remove unreachableURL accessor for now. It may make a glorious return when we have
error page support.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
Implement these in terms of the new C SPI.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):
Add computation of the "active" URL, which is the URL one would show
in an address field. It is the pending URL when there is one, the provisional
URL when there is one, and otherwise the committed/final URL.

(WebKit::WebPageProxy::provisionalURL):
(WebKit::WebPageProxy::committedURL):
Add access to the main frame URL.

  • UIProcess/WebPageProxy.h:
19:38 Changeset [98310] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=68944

Reviewed by Antti Koivisto.

No new tests / Covered by existing tests.

Removes all virtual dispatch from CSSStyleApplyProperty by converting to use static function pointers for dispatch.
Uses class templates instead of function templates to allow default parameters and also to share parameter declarations across static functions.
All constructor parameters become template parameters. This improves the level of compiler optimization that can be achieved.
Overall this achieved a ~2% overall speedup on run-safari PerformanceTests/Parser/html5-full-render.html,
and profiling showed a reduction in the time spent inside CSSStyleSelector::applyProperty().

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(WebCore::defaultInitialColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::createHandler):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleApplyProperty.h:

(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(WebCore::CSSStyleApplyProperty::propertyHandler):
(WebCore::CSSStyleApplyProperty::setPropertyHandler):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::invalidColor):

19:28 Changeset [98309] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-24
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-image-expected.txt: Added.
  • fast/canvas/canvas-composite-image.html: Added.
19:15 Changeset [98308] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK and Windows rebaselines after r98199.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
18:24 Changeset [98307] by jchaffraix@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r98294 and r98306.
http://trac.webkit.org/changeset/98294
http://trac.webkit.org/changeset/98306
https://bugs.webkit.org/show_bug.cgi?id=70790

the first patch broke chromium-mac and the second gclient
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gypi:
17:44 Changeset [98306] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70785

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

Patch by Nico Weber <thakis@chromium.org> on 2011-10-24

  • WebKit.gypi:
17:44 Changeset [98305] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Build fix after r98300.

  • WebCore.gypi:
  • WebCore.pro:
17:33 Changeset [98304] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

It should be possible for Widget subclasses to control whether transforms affect the frame rect
https://bugs.webkit.org/show_bug.cgi?id=70787

Reviewed by Sam Weinig.

Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
this behavior and have the frame rect set to the absolute content box without any transforms applied.

  • platform/Widget.h:

(WebCore::Widget::transformsAffectFrameRect):
Add new member function.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):
Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
false, just set the frame rect to the absolute content box.

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Call updateWidgetGeometry.

  • rendering/RenderWidget.h:
17:26 Changeset [98303] by eae@chromium.org
  • 39 edits
    2 adds in branches/subpixellayout/Source

Add support for chromium port, currently in a state where DRT builds and most layout tests passes.

17:21 Changeset [98302] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Crash in void JSC::validateCell<JSC::RegExp*>(JSC::RegExp*)
https://bugs.webkit.org/show_bug.cgi?id=70689

Reviewed by Filip Pizlo.

While performing codegen we need to make the GlobalData explicitly
aware of the codeblock being compiled, as compilation may trigger GC
and CodeBlock holds GC values, but has not yet been assigned to its
owner executable.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:
  • heap/AllocationSpace.cpp:

(JSC::AllocationSpace::allocateSlowCase):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

17:19 Changeset [98301] by jchaffraix@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline after r98293.

  • platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png: Added.
17:13 Changeset [98300] by rniwa@webkit.org
  • 46 edits
    36 adds in trunk

Microdata: Add itemprop, itemref, itemvalue attributes.
https://bugs.webkit.org/show_bug.cgi?id=69839

Patch by Arko Saha <arko@motorola.com> on 2011-10-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/MicroData/itemprop-add-remove-tokens.html

fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
fast/dom/MicroData/itemprop-must-be-read-only.html
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
fast/dom/MicroData/itemref-add-remove-tokens.html
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
fast/dom/MicroData/itemref-must-be-read-only.html
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
fast/dom/MicroData/itemvalue-reflects-href-attr.html
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
fast/dom/MicroData/itemvalue-returns-element-itself.html
fast/dom/MicroData/itemvalue-returns-null.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::toJS):
(WebCore::JSHTMLElement::itemValue):
(WebCore::JSHTMLElement::setItemValue):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
(WebCore::V8HTMLElement::itemValueAccessorSetter):

  • dom/MicroDataItemList.cpp:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::itemValueText):
(WebCore::HTMLAnchorElement::setItemValueText):

  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::itemValueText):
(WebCore::HTMLAreaElement::setItemValueText):

  • html/HTMLAreaElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::itemProp): Returns element's itemprop content attribute.
(WebCore::HTMLElement::setItemProp): Sets itemprop value on changing elemet's
itemprop attribute.
(WebCore::HTMLElement::itemRef): Returns element's itemref content attribute.
(WebCore::HTMLElement::setItemRef): Sets itemref value on changing elemet's
itemref attribute.
(WebCore::HTMLElement::setItemValue): Sets element's itemvalue. If the element has no
itemprop attribute or if element has an itemscope attribute, it throws INVALID_ACCESS_ERR
exception.
(WebCore::HTMLElement::itemValue): Returns the elements itemvalue.

If the element has no itemprop attribute it returns null.
If the element has an itemscope attribute, it returns the element itself.
If the element is a meta element: It acts as it would if it was reflecting the element's
content content attribute.
If the element is an audio, embed, iframe, img, source, track, or video element: It acts
as it would if it was reflecting the element's src content attribute.
If the element is an a, area, or link element: It act as it would if it was reflecting the
href content attribute.
If the element is an object element: It acts as it would if it was reflecting the element's
data content attribute.

(WebCore::HTMLElement::itemValueText):
(WebCore::HTMLElement::setItemValueText):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::itemValueText):
(WebCore::HTMLEmbedElement::setItemValueText):

  • html/HTMLEmbedElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::itemValueText):
(WebCore::HTMLIFrameElement::setItemValueText):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::itemValueText):
(WebCore::HTMLImageElement::setItemValueText):

  • html/HTMLImageElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::itemValueText):
(WebCore::HTMLLinkElement::setItemValueText):

  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::itemValueText):
(WebCore::HTMLMediaElement::setItemValueText):

  • html/HTMLMediaElement.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::itemValueText):
(WebCore::HTMLMetaElement::setItemValueText):

  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::itemValueText):
(WebCore::HTMLObjectElement::setItemValueText):

  • html/HTMLObjectElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::itemValueText):
(WebCore::HTMLSourceElement::setItemValueText):

  • html/HTMLSourceElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::itemValueText):
(WebCore::HTMLTrackElement::setItemValueText):

  • html/HTMLTrackElement.h:
  • html/MicroDataItemValue.cpp: Added.

(WebCore::MicroDataItemValue::MicroDataItemValue):
(WebCore::MicroDataItemValue::createFromString):
(WebCore::MicroDataItemValue::createFromNode):

  • html/MicroDataItemValue.h: Added.

(WebCore::MicroDataItemValue::isNode):
(WebCore::MicroDataItemValue::getNode):
(WebCore::MicroDataItemValue::getString):

LayoutTests:

Added test-cases for Microdata itemprop, itemref, itemvalue attributes.

  • fast/dom/MicroData/002-expected.txt:
  • fast/dom/MicroData/002.html:
  • fast/dom/MicroData/003-expected.txt:
  • fast/dom/MicroData/003.html:
  • fast/dom/MicroData/005-expected.txt:
  • fast/dom/MicroData/005.html:
  • fast/dom/MicroData/006-expected.txt:
  • fast/dom/MicroData/009.html:
  • fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Added.
  • fast/dom/MicroData/itemprop-add-remove-tokens.html: Added.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Added.
  • fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Added.
  • fast/dom/MicroData/itemprop-must-be-read-only.html: Added.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Added.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Added.
  • fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Added.
  • fast/dom/MicroData/itemref-add-remove-tokens.html: Added.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Added.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Added.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Added.
  • fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Added.
  • fast/dom/MicroData/itemref-must-be-read-only.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-href-attr.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Added.
  • fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-returns-element-itself.html: Added.
  • fast/dom/MicroData/itemvalue-returns-null-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-returns-null.html: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Added.
  • fast/dom/MicroData/resources/microdata-common.js:

(createElement):
(runTest):

17:00 Changeset [98299] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Object-or-other branch speculation may corrupt the state for OSR if the child of the
branch is an integer
https://bugs.webkit.org/show_bug.cgi?id=70777

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

LayoutTests:

  • fast/js/dfg-other-branch-expected.txt: Added.
  • fast/js/dfg-other-branch.html: Added.
  • fast/js/script-tests/dfg-other-branch.js: Added.

(foo):
(bar):

16:45 Changeset [98298] by jchaffraix@webkit.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

Bug 58013 has landed 3 months ago and it looks like the rebaseline was forgotten.
The new result is consistent with the other platforms.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:43 Changeset [98297] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Switching FloatingObjectTree/Interval to use rounded ints instead of LayoutUnits to correct comparisons with the line box tree.

16:22 Changeset [98296] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

op_new_array_buffer is not inlined correctly
https://bugs.webkit.org/show_bug.cgi?id=70770

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Disabled inlining of op_new_array_buffer, for now.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-inline-new-array-buffer-expected.txt: Added.
  • fast/js/dfg-inline-new-array-buffer.html: Added.
  • fast/js/script-tests/dfg-inline-new-array-buffer.js: Added.

(foo):
(bar):

16:03 Changeset [98295] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused instance variable
https://bugs.webkit.org/show_bug.cgi?id=70750

Reviewed by Dimitri Glazkov.

  • rendering/RenderTextControl.h:
16:02 Changeset [98294] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

  • WebCore.gyp/WebCore.gyp:
15:56 Changeset [98293] by timothy_horton@apple.com
  • 3 edits
    3 adds in trunk

feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
https://bugs.webkit.org/show_bug.cgi?id=70035
<rdar://problem/10280177>

Reviewed by Nikolas Zimmermann.

Make feColorMatrix's type attribute be "matrix" by default.

Test: svg/filters/feColorMatrix-default-type.svg

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):

15:51 Changeset [98292] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Build fix. Rename all instances of a variable when it gets changed
https://bugs.webkit.org/show_bug.cgi?id=70732

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

  • ewk/ewk_js.cpp:

(ewk_js_property_set): s/obj/object/

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add): s/exec/executeState/

15:51 Changeset [98291] by commit-queue@webkit.org
  • 10 edits in trunk/Source/JavaScriptCore

Add boolean speculations to DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=70706

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

Different from the boolean speculations in DFG 64, the boolean
speculations in DFG 32_64 will use a 32bit GPR to hold the primitive
boolean instead of a JSBoolean. This choice is not only for
performance, but also to save a register as we're short of registers on
X86.
To accomplish this we make use of DataFormatBoolean, allow a value to
be represented as a primitive boolean and converted from/to a
JSBoolean.
This patch also fixes SpillOrder in 32_64, which should be different
from 64, and fixes needDataFormatConversion logic in 32_64.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest32):

We don't expect byte test actually as it doesn't work for registers
esp..edi on X86.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::checkConsistency):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::cellResult):
(JSC::DFG::booleanResult):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

15:49 Changeset [98290] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Build fix. Add include path to find npapi.h
https://bugs.webkit.org/show_bug.cgi?id=70730

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

  • DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
15:39 Changeset [98289] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Unbreak binding generation tests
https://bugs.webkit.org/show_bug.cgi?id=70768

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Darin Adler.

Update the expected output of V8 binding tests to match
results c/o https://bugs.webkit.org/show_bug.cgi?id=70065

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::idbKeyCallback):

15:26 Changeset [98288] by eric@webkit.org
  • 3 edits in trunk/Tools

Plugin tests are failing after switching WK2 to NRWT
https://bugs.webkit.org/show_bug.cgi?id=70760

Reviewed by Simon Fraser.

Perpetuate this horrible hack.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:19 Changeset [98287] by leviw@chromium.org
  • 2 edits
    7 adds
    1 delete in trunk/LayoutTests

Adding Chromium expectations from http://trac.webkit.org/changeset/98263

Unreviewed.

  • platform/chromium-cg-mac-snowleopard/svg/as-object: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object: Removed.
  • platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:15 Changeset [98286] by leviw@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Fixing a collision in Mac results and adding qt results from http://trac.webkit.org/changeset/98263

Unreviewed test expectations update.

  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Fixing collision that removes

an empty text node.

  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt: Added.
15:07 Changeset [98285] by weinig@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit2

Hook up minimalist load delegate to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70764

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
Add loadDelegate getter/setter. As per convention, the delegate is not
retained.

(didStartProvisionalLoadForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(setUpPageLoaderClient):
(-[WKBrowsingContextController initWithPageRef:]):
Hookup the delegate to a WKPageLoaderClient.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Added.

Add load delegate as a proper protocol.

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

14:58 Changeset [98284] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r98266.
http://trac.webkit.org/changeset/98266
https://bugs.webkit.org/show_bug.cgi?id=70767

Broke the chromium build. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

  • features.gypi:
14:29 Changeset [98283] by lforschler@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

14:19 Changeset [98282] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] Add isTraceEventEnabled to PlatformSupport.
https://bugs.webkit.org/show_bug.cgi?id=70618

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::isTraceEventEnabled):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::isTraceEventEnabled):

14:01 Changeset [98281] by mihnea@adobe.com
  • 4 edits in trunk/Source/WebCore

Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
https://bugs.webkit.org/show_bug.cgi?id=70746

Reviewed by Tony Chang.

Covered by existing tests.

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::rulesText):

  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::selectorsText):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssText): Use CSSRuleList::rulesText() method instead of explicit loop.

13:57 Changeset [98280] by msaboff@apple.com
  • 9 edits in trunk/Source

WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Source/WebCore:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue. Changed MemoryPressureHandler::install
to use new function.

Reviewed by Geoffrey Garen.

No new tests. Moved functionality to WebKitSystemInterface.

  • WebCore.exp.in:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

13:54 Changeset [98279] by eric@webkit.org
  • 6 edits in trunk/Tools

NRWT doesn't support ORWT's --root option, but should
https://bugs.webkit.org/show_bug.cgi?id=70416

Reviewed by Dirk Pranke.

Add support for ORWT's --root option which is used for
running tests with a nightly build of WebKit.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/base.py:
    • webkit_build_path was never called by any code, removed.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13:51 Changeset [98278] by commit-queue@webkit.org
  • 27 edits in trunk

IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
https://bugs.webkit.org/show_bug.cgi?id=70065

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(TypeCanFailConversion):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::continueFunction):

  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBKey.cpp:

(WebCore::IDBKey::IDBKey):
(WebCore::IDBKey::compare):

  • storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):

  • storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • storage/IDBKeyRange.h:

(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • storage/IDBKeyRange.idl:
  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::keyFromQuery):

Source/WebKit/chromium:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

  • src/AssertMatchingEnums.cpp:
  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::assignNull):

LayoutTests:

Updated expectations now that most tests match spec. Includes change to
objectstore-basics test to avoid hitting https://bugs.webkit.org/show_bug.cgi?id=70041
since this CL stops hiding that bug.

  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/open-cursor-expected.txt:
13:48 Changeset [98277] by alokp@chromium.org
  • 5 edits in trunk/Source/WebCore

[chromium] Make accelerated drawing work with threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70656

Reviewed by James Robinson.

Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

13:47 Changeset [98276] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixing Windows build

Unreviewed build fix

13:41 Changeset [98275] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Optimize Node::isInShadowTree to execute in constant-time
https://bugs.webkit.org/show_bug.cgi?id=67686

Reviewed by Dimitri Glazkov.

No expected change in behavior, so no new tests.

  • dom/Node.cpp:

(WebCore::Node::isInShadowTree):

13:40 Changeset [98274] by ojan@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Some more fixups from http://trac.webkit.org/changeset/98265.

The leopard bot results are incorrect, but that's because the
chromium leopard bots have not compiled in a few days. Once
the bots are fixed, we'll need to rebaseline this test again for
leopard.

  • platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
13:35 Changeset [98273] by lforschler@apple.com
  • 1 copy in tags/Safari-534.52.3

New tag.

13:32 Changeset [98272] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Fix Localization.

13:11 Changeset [98271] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] Expose WebThread::postDelayedTask to CCThread
https://bugs.webkit.org/show_bug.cgi?id=70712

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCThread.h:

Source/WebKit/chromium:

  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::postDelayedTask):

  • src/CCThreadImpl.h:
12:55 Changeset [98270] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Add URL getters for the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70752

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(autoreleased):
Added helpers for autoreleasing.

(-[WKBrowsingContextController activeURL]):
Added buy not implemented yet.

(-[WKBrowsingContextController pendingURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController commitedURL]):
(-[WKBrowsingContextController unreachableURL]):
Added getters.

(-[WKBrowsingContextController title]):
Convert to new autoreleased helper.

12:53 Changeset [98269] by nduca@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
https://bugs.webkit.org/show_bug.cgi?id=70688

Reviewed by Tony Chang.

  • tests/RunAllTests.cpp:

(main):

  • tests/WebUnitTests.cpp:

(WebKit::InitTestSuite):
(WebKit::RunAllUnitTests):
(WebKit::DeleteTestSuite):

  • tests/WebUnitTests.h:
12:41 Changeset [98268] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Geoffrey Garen.

Current BitVector uses the highest bit of m_bitsOrPointer to indicate
whether it's an inlined bit set or a pointer to an outOfLine bit set.
This check may fail in case the pointer also has the highest bit set,
which is surely possible on IA32 (Linux).
In this case the check failure can result in unexpected behaviors,
for example if the BitVector is incorrectly determined as having an
inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
modify the memory adjacent to the BitVector object.
This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
or outofline, based on the assumption that the pointer to OutOfLineBits
should be 4 or 8 byte aligned.
We could mark the lowest bit (bit 0) with 1 for inlined bit set,
and bits 1~bitsInPointer are used for bit set/test.
In this case we need do one bit more shift for bit set/test.

  • wtf/BitVector.cpp:

(WTF::BitVector::resizeOutOfLine):

  • wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):

12:40 Changeset [98267] by jchaffraix@webkit.org
  • 6 edits
    7 adds
    3 deletes in trunk/LayoutTests

Unreviewed rebaseline of svg/W3C-SVG-1.1-SE/coords-units-03-b.html

The new baselines all match the existing ones. Not sure if we really pass the test as
2 lines should be 200px but at least all the baselines are consistent (within some font
differences).

  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
12:29 Changeset [98266] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-24
Reviewed by David Levin.

  • features.gypi:
12:22 Changeset [98265] by ojan@chromium.org
  • 2 edits
    1 move
    1 add
    4 deletes in trunk/LayoutTests

Cleanup some test expectations missed in r98183.

  • platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
  • platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
  • platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
  • platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:02 Changeset [98264] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
https://bugs.webkit.org/show_bug.cgi?id=70747

Reviewed by Tony Chang.

  • Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
11:56 Changeset [98263] by leviw@chromium.org
  • 4 edits
    3 adds in trunk

<svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
11:41 Changeset [98262] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Node::registeredMutationObserversOfType should be prefixed by "get"
https://bugs.webkit.org/show_bug.cgi?id=70359

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-24
Reviewed by Ojan Vafai.

This change renames Node::registeredMutationObserversOfType to
Node::getRegisteredMutationObserversOfType per the WebKit style guide.

No tests needed as the change is only method renaming.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:
11:37 Changeset [98261] by mhahnenberg@apple.com
  • 27 edits in trunk/Source

Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
https://bugs.webkit.org/show_bug.cgi?id=70271

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renaming versions of getOwnPropertySlot that use an unsigned as the property
name to "getOwnPropertySlotByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlotByIndex):

  • runtime/Arguments.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlotVirtual):
(JSC::JSByteArray::getOwnPropertySlotByIndex):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlotVirtual):
(JSC::JSCell::getOwnPropertySlotByIndex):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlotVirtual):
(JSC::JSNotAnObject::getOwnPropertySlotByIndex):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlotByIndex):

  • runtime/JSObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlotByIndex):

  • runtime/JSString.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlotVirtual):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlotVirtual):
(JSC::StringObject::getOwnPropertySlotByIndex):

  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Renaming versions of getOwnPropertySlot that use an unsigned as the property
name to "getOwnPropertySlotByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlotVirtual):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):

  • bridge/runtime_array.h:
11:37 Changeset [98260] by jchaffraix@webkit.org
  • 3 edits
    7 adds in trunk/LayoutTests

Unreviewed gardening rebaselining.

Updating those baselines as they match Mac and looks like progressions. Linux was needing a wrong
rebaseline, so it was not rebaselined.

  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint: Added.
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium/test_expectations.txt:
11:36 Changeset [98259] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Add zoom and title support to Objective-C WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=70744

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):

11:31 Changeset [98258] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

IndexedDB add should fail adding an inline and passed key simultaneously
https://bugs.webkit.org/show_bug.cgi?id=58598

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html

Implement the spec clause: passing a key into add() or put() when
the object store has a key path ("inline key") is an error.

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html: Added.
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Added.
11:29 Changeset [98257] by lforschler@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

11:07 Changeset [98256] by msaboff@apple.com
  • 5 edits in trunk/WebKitLibraries

WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Added new WebKitSystemInterface method CreateVMPressureDispatchOnMainQueue.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:05 Changeset [98255] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Improve debug compositing border colors
https://bugs.webkit.org/show_bug.cgi?id=70742

Reviewed by Dean Jackson.

Improve the appearance of the debug borders used to indicate compositing:

  1. Use green for normal layers, orange for tiled layers
  2. Make the repaint counter translucent
  3. Change the color of the repaint counter to show when accelerated drawing is enabled.
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::updateDebugIndicators):

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

10:54 Changeset [98254] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing repaint issues from truncated damage rects. Fixing a remaining loop in RenderDeprecatedFlexibleBox. Properly constructing FloatWithRect with a LayoutRect, which fixes lots of line layout issues.

10:34 Changeset [98253] by caryclark@google.com
  • 3 edits
    741 adds in trunk/LayoutTests

Unreviewed gardening: third chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 743 files for brevity.]

  • platform/chromium-mac-leopard/fast/block/positioning/absolute-length-of-neg-666666-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.

...

  • platform/chromium-mac-leopard/fast/lists/ol-display-types-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/ol-start-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/olstart-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:33 Changeset [98252] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Crash when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=70725

Reviewed by Chang Shu.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

10:24 Changeset [98251] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Attempt to fix Windows build by updating to the new interface.

  • DOMEventsClasses.cpp:

(DOMEvent::createInstance):

09:44 Changeset [98250] by carlosgc@webkit.org
  • 5 edits in trunk/Source

[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69745

Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:
09:39 Changeset [98249] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] New failing test fast/events/dropzone-002.html
https://bugs.webkit.org/show_bug.cgi?id=61625

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: The test has been passing

on all platforms except leopard for several days.

09:31 Changeset [98248] by apavlov@chromium.org
  • 3 edits in branches/chromium/912

Merge 98243 - Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Reviewed by Pavel Feldman.

Source/WebCore:

We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt:
  • inspector/styles/styles-add-new-rule.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/8380009

08:54 Changeset [98247] by vsevik@chromium.org
  • 8 edits in branches/chromium/912

Merge 97975 - Web Inspector: Advanced search results should keep working after pretty print toggled.
https://bugs.webkit.org/show_bug.cgi?id=70347

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchScope.prototype.createSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
(WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._materializeBreakpoint):

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane):
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
(WebInspector.ScriptsSearchResultsPane.LinkifierFormatter):
(WebInspector.ScriptsSearchResultsPane.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):

  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/raw-source-code.html:

BUG=101016
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8382007

08:26 Changeset [98246] by lforschler@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

08:24 Changeset [98245] by carlosgc@webkit.org
  • 11 edits
    6 adds in trunk/Source/WebKit2

[GTK] Initial implementation of back forward list for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69343

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitBackForwardList.cpp: Added.

(webkitBackForwardListFinalize):
(webkit_back_forward_list_init):
(webkit_back_forward_list_class_init):
(webkitBackForwardListGetOrCreateItem): Helper function that
creates a new WebKitBackForwardListItem for the given
WebBackForwardListItem or returns it from the cache if it's
already cached.
(webkitBackForwardListCreateList): Helper function to convert a
WKArray of WebBackForwardListItems into a GList of
WebKitBackForwardListItems.
(webkitBackForwardListCreate): Create a new WebKitBackForwardList.
(webkitBackForwardListChanged): Emits changed signal when the back
forward list changes.
(webkit_back_forward_list_get_current_item):
(webkit_back_forward_list_get_back_item):
(webkit_back_forward_list_get_forward_item):
(webkit_back_forward_list_get_nth_item):
(webkit_back_forward_list_get_length):
(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):

  • UIProcess/API/gtk/WebKitBackForwardList.h: Added.
  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Added.

(webkitBackForwardListItemFinalize):
(webkit_back_forward_list_item_init):
(webkit_back_forward_list_item_class_init):
(historyItemsMap): Global cache for WebKitBackForwardListItems.
(webkitBackForwardListItemFinalized):
(webkitBackForwardListItemGetOrCreate): Helper function that
creates a new WebKitBackForwardListItem for the given
WebBackForwardListItem or returns it from the global cache if it's
already cached.
(webkit_back_forward_list_item_get_uri):
(webkit_back_forward_list_item_get_title):
(webkit_back_forward_list_item_get_original_uri):

  • UIProcess/API/gtk/WebKitBackForwardListItem.h: Added.
  • UIProcess/API/gtk/WebKitBackForwardListPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didChangeBackForwardList): Call webkitBackForwardListChanged() to
notify that the list has changed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didChangeBackForwardList.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkit_web_view_get_back_forward_list): Return the back forward
list of the view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new test.
  • UIProcess/API/gtk/tests/TestBackForwardList.cpp: Added.

(serverCallback):
(testBackForwardListNavigation):
(testBackForwardListLimitAndCache):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/TestMain.h:

(Test::~Test): Check there are no objects leaked.
(Test::objectFinalized): Callback called when a GObject is
deleted, used to remove the watched object the list.
(Test::assertObjectIsDeletedWhenTestFinishes): Add an object to
the list of watched objects and add a weak pointer to remove it
from the list when the object is finalized. If there aren't
objects leaked, the list should be empty when the test finishes.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest): Watch the web view to make sure it's
not leaked.

  • UIProcess/API/gtk/tests/WebViewTest.h: Make WebViewTest inherit

from Test class.

  • UIProcess/API/gtk/webkit2.h: Include WebKitBackForwardList.h and

WebKitBackForwardListItem.h.

  • UIProcess/API/gtk/webkit2marshal.list:
08:23 Changeset [98244] by lforschler@apple.com
  • 1 copy in tags/Safari-534.52.1

New tag.

08:23 Changeset [98243] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Reviewed by Pavel Feldman.

Source/WebCore:

We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt:
  • inspector/styles/styles-add-new-rule.html:
08:20 Changeset [98242] by lforschler@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

08:17 Changeset [98241] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Add helper function to set the loader client in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70594

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetLoaderClient): Helper function to set the loader
client.
(webkitWebViewConstructed): Use webkitWebViewSetLoaderClient() to
avoid unnecessary checks.
(webkit_web_view_set_loader_client): Use
webkitWebViewSetLoaderClient().

08:14 Changeset [98240] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: do not force document loading on reload (should happen on demand).
https://bugs.webkit.org/show_bug.cgi?id=70724

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._documentUpdated):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.setVisible):

LayoutTests:

  • inspector/debugger/dom-breakpoints.html:
  • inspector/debugger/error-in-watch-expressions.html:
07:56 Changeset [98239] by carlosgc@webkit.org
  • 32 edits in trunk

[GTK] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=70717

Reviewed by Xan Lopez.

With newer glib it's not needed anymore and with previous versions
it was already called by g_type_init().

Source/WebKit/gtk:

  • tests/testapplicationcache.c:

(main):

  • tests/testatk.c:

(main):

  • tests/testatkroles.c:

(main):

  • tests/testcopyandpaste.c:

(main):

  • tests/testdomdocument.c:

(main):

  • tests/testdomdomwindow.c:

(main):

  • tests/testdomnode.c:

(main):

  • tests/testdownload.c:

(main):

  • tests/testglobals.c:

(main):

  • tests/testhittestresult.c:

(main):

  • tests/testhttpbackend.c:

(main):

  • tests/testkeyevents.c:

(main):

  • tests/testloading.c:

(main):

  • tests/testmimehandling.c:

(main):

  • tests/testnetworkrequest.c:

(main):

  • tests/testnetworkresponse.c:

(main):

  • tests/testwebbackforwardlist.c:

(main):

  • tests/testwebdatasource.c:

(main):

  • tests/testwebframe.c:

(main):

  • tests/testwebhistoryitem.c:

(main):

  • tests/testwebplugindatabase.c:

(main):

  • tests/testwebresource.c:

(main):

  • tests/testwebsettings.c:

(main):

  • tests/testwebview.c:
  • tests/testwindow.c:

(main):

Source/WebKit2:

  • UIProcess/API/gtk/tests/TestMain.cpp:

(main):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(main):

  • GtkLauncher/main.c:

(main):

  • MiniBrowser/gtk/main.c:

(main):

07:41 Changeset [98238] by eric.carlson@apple.com
  • 19 edits
    4 deletes in trunk/Source/WebCore

Drop MutableTextTrack and make TextTrack always mutable
https://bugs.webkit.org/show_bug.cgi?id=62890

The MutableTextTrack type was removed from the spec, all text tracks are now mutable.

Reviewed by Sam Weinig.

No new tests needed, the changes just refactor existing code.

  • CMakeLists.txt: Remove all traces of MutableTextTrack.
  • CodeGenerators.pri: Ditto.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/gobject/GNUmakefile.am: Ditto.
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
  • bindings/js/JSTextTrackCustom.cpp: Removed.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTrack): Return a TextTrack instead of a MutableTextTrack.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Return a TextTrack instead of a MutableTextTrack.

  • html/MutableTextTrack.cpp: Removed.
  • html/MutableTextTrack.h: Removed.
  • html/MutableTextTrack.idl: Removed.
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Remove Type parameter.
(WebCore::TextTrack::addCue): New, moved from MutableTextTrack.
(WebCore::TextTrack::removeCue): Ditto.
(WebCore::TextTrack::newCuesLoaded): Ditto.
(WebCore::TextTrack::fetchNewestCues): Ditto.

  • html/TextTrack.h:

(WebCore::TextTrack::create): Remove Type parameter

  • html/TextTrack.idl: Add addCue and removeCue.
07:32 Changeset [98237] by yurys@chromium.org
  • 21 edits in trunk

Web Inspector: allow debugging dedicated worker initialization
https://bugs.webkit.org/show_bug.cgi?id=70723

Source/WebCore:

Now it is possible to pause each new dedicated worker on start. The user
needs to select a checkbox and then each newly created dedicated worker
will be paused on the first statement until the user resumes it explicitely.

Reviewed by Pavel Feldman.

  • inspector/Inspector.json: resume command is added. It is similar to GDB's run

command, i.e. worker execution will be paused until explicit "resume" command is
received.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStartImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::resume):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart): returns true
if the user chose to automatically pause all new workers.

  • inspector/InspectorWorkerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::resume):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.loadCompleted):
(WebInspector.WorkerManager.prototype._workerCreated):
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._openInspectorWindow):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):

  • workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

  • workers/WorkerContextProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext): additional flag specifying
worker initial state(paused/not paused) is added to the factory method. The flag
will be carried to the corresponding WorkerThread.
(WebCore::WorkerMessagingProxy::connectToInspector):

  • workers/WorkerMessagingProxy.h:

Source/WebKit/chromium:

Pass worker thread start mode to the worker thread.

Reviewed by Pavel Feldman.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

  • src/WebWorkerClientImpl.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
06:52 Changeset [98236] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986

Add a setting to choose an indent from "8 spaces", "4 spaces" (default), "2 spaces", or "Tab character".

Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-10-21
Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get p):
(WebInspector.SettingsScreen.prototype._createSelectSetting.changeListener):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel):

  • inspector/front-end/TextViewer.js:
06:31 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
05:52 Changeset [98235] by alex@webkit.org
  • 3 edits in trunk/LayoutTests

2011-10-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip failing test in GTK, added bug 70720. Rebaseline
prototype-inheritance-2.html.

  • platform/gtk/Skipped: skipped fast/events/event-creation.html.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Reset expected results after r98199.
05:23 Changeset [98234] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

  • DEPS:
05:08 Changeset [98233] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: add "Add to Watch" option to context menu on selection in source frame
https://bugs.webkit.org/show_bug.cgi?id=69924

Reviewed by Pavel Feldman.

  • added 'Add to Watch' context menu item in scripts panel;
  • include both default and custom items into a context menu if selection is present;
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegate.prototype.addToWatch):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
(WebInspector.WatchExpressionsSection.prototype.addExpression):
(WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):

04:04 Changeset [98232] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Audits hang on pages without img[src] elements
https://bugs.webkit.org/show_bug.cgi?id=70604

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/audits/audits-panel-noimages-functional.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

LayoutTests:

  • inspector/audits/audits-panel-noimages-functional-expected.txt: Added.
  • inspector/audits/audits-panel-noimages-functional.html: Added.
03:29 Changeset [98231] by commit-queue@webkit.org
  • 6 edits in trunk

[Qt] fast/events/media-focus-in-standalone-media-document.html fails
https://bugs.webkit.org/show_bug.cgi?id=70110

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-10-24
Reviewed by Simon Hausmann.

Source/WebCore:

ExtensionMap should also include media files mapping.

  • platform/qt/MIMETypeRegistryQt.cpp: Added media files mapping.

Source/WebKit/qt:

We should check for supported media mime types as well in the MIMETypeRegistry.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType): check for supported media mime type.

LayoutTests:

Remove media-focus-in-standalone-media-document.html from Qt Skipped test list.

  • platform/qt/Skipped:
03:10 Changeset [98230] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-10-24 Pavel Feldman <pfeldman@google.com>

Not reviewed: [chromium] follow up to 98228 - added missing css.

  • WebCore.gypi:
03:01 Changeset [98229] by vsevik@chromium.org
  • 8 edits
    2 copies in branches/chromium/912

Merge 97959 - Web Inspector: Enable support for advanced search in script's static content provider.
https://bugs.webkit.org/show_bug.cgi?id=70354

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-static.html

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showSourceLine):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/search/search-in-static-expected.txt: Added.
  • http/tests/inspector/search/search-in-static.html: Added.

BUG=101008
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8368025

03:01 Changeset [98228] by pfeldman@chromium.org
  • 20 edits
    1 move
    7 adds in trunk/Source/WebCore

Web Inspector: Make CSS files load upon View demand; split inspector.css into views.
https://bugs.webkit.org/show_bug.cgi?id=70694

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

  • inspector/front-end/PanelEnablerView.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView):

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TextViewer.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WelcomeView.js:

(WebInspector.WelcomeView):

  • inspector/front-end/auditsPanel.css: Renamed from Source/WebCore/inspector/front-end/audits.css.
02:40 Changeset [98227] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: make view load CSS files upon show.
https://bugs.webkit.org/show_bug.cgi?id=70696

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/view-css.html

  • inspector/front-end/View.js:

(WebInspector.View):
(WebInspector.View.prototype._callOnVisibleChildren):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processWillHide):
(WebInspector.View.prototype._processWasHidden):
(WebInspector.View.prototype._processOnResize):
(WebInspector.View.prototype.show):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.registerRequiredCSS):
(WebInspector.View.prototype._loadCSSIfNeeded):
(WebInspector.View.prototype._doLoadCSS):
(WebInspector.View.prototype._disableCSSIfNeeded):
(WebInspector.View.prototype._doUnloadCSS):

LayoutTests:

  • inspector/view-css-expected.txt: Added.
  • inspector/view-css.html: Added.
  • inspector/view-events-expected.txt:
  • inspector/view-events.html:
02:26 Changeset [98226] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] WebView does not get focus when being clicked / touched in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=70613

Make TouchWebView and DesktopWebView take the focus whenever it receives
a MouseClick or a TouchEvent.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-24
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::touchEvent):

  • UIProcess/API/qt/qtouchwebview.h:
02:25 Changeset [98225] by pfeldman@chromium.org
  • 13 edits in trunk/Source/WebCore

Web Inspector: make DataGrid a view
https://bugs.webkit.org/show_bug.cgi?id=70695

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.onResize):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._queryFinished):
(WebInspector.DatabaseQueryView.prototype._queryError):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._queryFinished):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype.onResize):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.onResize):
(WebInspector.NetworkLogView.prototype._createTable):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView):

01:54 Changeset [98224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leaks in WebContextGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=70505

Free the output of g_build_filename()

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2011-10-24
Reviewed by Martin Robinson.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

01:52 Changeset [98223] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r98199

Patch by Kosztyo Kristof <kkristof@inf.u-szeged.hu> on 2011-10-24

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
01:14 Changeset [98222] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Forms] Setting defaultValue should hide an input placeholder.
https://bugs.webkit.org/show_bug.cgi?id=70586

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-10-24
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/placeholder-and-default-value-expected.html

fast/forms/placeholder-and-default-value.html

When input element has default value, we should not display
placeholder. Changing default value should tell rendering engine about
changing display of input element.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Calls updatePlaceholderVisibility for valueAttr if it doesn't have dirty value.

LayoutTests:

This test checks "value" attribute (default value) changing in two
ways, one is using setDefault method and another is setAttribute
method.

  • fast/forms/placeholder-and-default-value-expected.html: Added. Render text input element with "Default" value.
  • fast/forms/placeholder-and-default-value.html: Added. Render text input element with placeholder attribute and a script to change default value of input element to "Default" from empty.
00:53 Changeset [98221] by alex@webkit.org
  • 2 edits in trunk/Tools

2011-10-24 Alejandro G. Castro <alex@igalia.com>

[WK2] [GTK] WebKitTestRunner crashes with heap corruption
https://bugs.webkit.org/show_bug.cgi?id=69403

We did not added autotoolsconfig.h to the config.h file and we
were adding Platform.h without the config.h in the
WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
the Prefix file.

Reviewed by Martin Robinson.

  • WebKitTestRunner/WebKitTestRunnerPrefix.h:
00:42 Changeset [98220] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r98179.

  • bytecode/CodeBlock.h:

Moved CodeBlock::baselineVersion() into ENABLE(JIT) block,
since it is only used there.

10/23/11:

23:59 Changeset [98219] by darin@apple.com
  • 10 edits
    2 deletes in trunk/Source/WebCore

Eliminate OptionElement (second and final part)
https://bugs.webkit.org/show_bug.cgi?id=70710

Reviewed by Kent Tamura.

  • CMakeLists.txt: Removed OptionElement.h and OptionElement.cpp.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/OptionElement.cpp: Removed.
  • dom/OptionElement.h: Removed.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveLastSelection): Eliminate use of the
toOptionElement function. Use hasTagName and toHTMLOptionElement instead.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
(WebCore::HTMLSelectElement::recalcListItems): Ditto.
(WebCore::HTMLSelectElement::selectedIndex): Ditto.
(WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
(WebCore::HTMLSelectElement::saveFormControlState): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
(WebCore::HTMLSelectElement::appendFormData): Ditto.
(WebCore::HTMLSelectElement::reset): Ditto.
(WebCore::HTMLSelectElement::updateSelectedState): Ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

  • html/HTMLSelectElement.h: Changed the argument type of the

deselectItemsWithoutValidation function to HTMLElement* since that's
the type of an item in our items vector now.

23:54 Changeset [98218] by yuzo@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Attempt to fix compilation error for Chromium OS.

Unreviewed.

  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind):

22:53 Changeset [98217] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed a typo Darin spotted.

  • wtf/StringHasher.h:

(WTF::StringHasher::hash): Expelliarmus!

22:51 Changeset [98216] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed StringImpl::createStrippingNullCharacters
https://bugs.webkit.org/show_bug.cgi?id=70700

Reviewed by David Levin.

It was unused.

21:36 Changeset [98215] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

<img crossorigin> should fail to load when CORS check fails
https://bugs.webkit.org/show_bug.cgi?id=69732

Reviewed by Darin Adler.

Source/WebCore:

When loading an image with the crossorigin attribute, the spec says
that we're not supposed to load the image if the CORS check fails.
This "fails fast" behavior is intended to help developers understand
whether they've configured CORS correctly (instead of only catching the
error later when trying to read back the canvas).

Our new behavior matches the spec and Firefox.

Test: http/tests/security/img-with-failed-cors-check-fails-to-load.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that images loaded with the crossorigin attribute fail to load if
the CORS access check doesn't pass.

  • http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt: Added.
  • http/tests/security/img-with-failed-cors-check-fails-to-load.html: Added.
20:58 Changeset [98214] by fpizlo@apple.com
  • 9 edits
    3 adds in trunk

DFG should inline constructors
https://bugs.webkit.org/show_bug.cgi?id=70675

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Adds support for inlining constructors. Also fixes two pathologies
uncovered along the way: CheckMethod claimed that it never returned a
result (causing CheckMethod -> SetLocal -> GetLocal sequences to
result in the GetLocal doing OSR exit), and get_by_id parsing never
checked if it was hot in slow path. Also fiddled with inlining
heuristics; it appears that for now, the more inlining, the happier
V8 is. Finally, a bug was uncovered where a silent spill of a boxed
integer that had previously been spilled unboxed causes the silent
fill to forget to unbox.

This appears to be a 4% speed-up on V8 in their harness, or a 1%
speed-up in my harness. The difference is due to warm-up: in my
harness we see significant amounts of time spent in compilation, but
in V8's harness compilation gets amortizes. Profiling indicates that
we have the potential for a 5% win from basic optimizations like
generating OSR exits lazily and holding onto bytecode longer.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::mightInlineFunctionFor):
(JSC::DFG::canInlineFunctionFor):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

  • runtime/Executable.h:

(JSC::isCall):
(JSC::ExecutableBase::intrinsicFor):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:

LayoutTests:

Reviewed by Oliver Hunt.

Adds test that asserts that register pressure induced by inlining doesn't
result in spilling corrupting values.

  • fast/js/dfg-inlining-reg-alloc-expected.txt: Added.
  • fast/js/dfg-inlining-reg-alloc.html: Added.
  • fast/js/script-tests/dfg-inlining-reg-alloc.js: Added.

(foo):
(bar):
(baz):

20:40 Changeset [98213] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expecation change. inspector/elements/edit-dom-actions.html times out since around r98120:98133 (chromium 106751:106770).

Unreviewed.

  • platform/chromium/test_expectations.txt:
19:57 Changeset [98212] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Remove unused code from EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=70590

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-23
Reviewed by Andreas Kling.

Removed unused function on_closeWindow from EWebLauncher

  • EWebLauncher/main.c:
19:54 Changeset [98211] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation change for "r98183 causes 4 snowleopard tests to fail".
https://bugs.webkit.org/show_bug.cgi?id=70704

Unreviewed.

  • platform/chromium/test_expectations.txt:
19:23 Changeset [98210] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[chromium] Remove RopeImpl.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70703

Reviewed by Kent Tamura.

runtime/RopeImpl.{h,cpp} were removed in r97872, remove references
to these files from the gyp project files.

19:18 Changeset [98209] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove GeolocationServiceGtk.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70702

Reviewed by Kent Tamura.

platform/gtk/GeolocationServiceGtk.{h,cpp} were removed in r97746, so
remove references to these files from the gyp files.

  • WebCore.gypi:
18:49 Changeset [98208] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Move StyleSheet::addSubresourceStyleURLs() to CSSStyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70690

Patch by Andreas Kling <kling@webkit.org> on 2011-10-23
Reviewed by Antti Koivisto.

This method isn't part of the StyleSheet DOM interface, nor is it used by
XSLStyleSheet, so move it down to CSSStyleSheet and make it non-virtual.
Also remove some nearby unneeded casts from CSSStyleSheet* to StyleSheet*.

  • css/CSSStyleSheet.h:
  • css/StyleSheet.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
(WebCore::HTMLStyleElement::disabled):
(WebCore::HTMLStyleElement::setDisabled):

18:42 Changeset [98207] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove style sheet constructors that take a style sheet parent.
https://bugs.webkit.org/show_bug.cgi?id=70692

Patch by Andreas Kling <kling@webkit.org> on 2011-10-23
Reviewed by Antti Koivisto.

Style sheets are never directly parented by other style sheets, they always
go via a rule (such as @import.)

  • css/CSSStyleSheet.cpp:
  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):

  • css/StyleSheet.cpp:
  • css/StyleSheet.h:
17:37 Changeset [98206] by macpherson@chromium.org
  • 2 edits in trunk/Tools

Add watchlist for WebCore/css and put myself on it.
https://bugs.webkit.org/show_bug.cgi?id=70701

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:

Add watchlist for WebCore/css and put myself on it.

17:21 Changeset [98205] by mhahnenberg@apple.com
  • 6 edits in trunk/Source

Add deleteProperty to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70162

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • JavaScriptCore.exp:
  • runtime/ClassInfo.h: Added both versions of deleteProperty to the MethodTable.
  • runtime/JSFunction.h: Changed JSFunction::deleteProperty to

be protected rather than private for subclasses who don't provide their own
implementation.

Source/WebCore:

No new tests.

  • WebCore.exp.in:
17:11 Changeset [98204] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Update baselines for run-bindings-tests.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
14:14 Changeset [98203] by mhahnenberg@apple.com
  • 54 edits in trunk/Source

Remove getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=70638

Reviewed by Darin Adler.

Source/JavaScriptCore:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectIsConstructor):
(JSObjectCallAsConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::getConstructData):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSObject.h:

(JSC::getConstructData):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::construct):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::construct):

Source/WebKit2:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
11:01 Changeset [98202] by ggaren@apple.com
  • 3 edits in trunk/LayoutTests

Not reviewed.

Updated two test results I missed in my last check-in.

These tests depended on non-deterministic effects of hash order, so I
had to update them:

  • http/tests/inspector/search/search-in-resources-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
00:34 Changeset [98201] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the SL build.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): Cast
away int vs unisgned warning.

00:27 Changeset [98200] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

[GTK] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=69410

Tools:

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-10-23
Reviewed by Martin Robinson.

Implement the KeyDown function on Gtk platform.

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::dispatchEvent):
(WTR::getModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip passed tests.

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-10-23
Reviewed by Martin Robinson.

  • platform/gtk-wk2/Skipped:
00:21 Changeset [98199] by ggaren@apple.com
  • 13 edits in trunk

Separated string lifetime bits from character buffer state bits
https://bugs.webkit.org/show_bug.cgi?id=70673

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Moved the static/immortal bit into the bottom bit of the refcount, and
moved all other bits into the high bits of the hash code.

This is the first step toward a new Characters/PassString class, and it
makes ref/deref slightly more efficient.

  • create_hash_table:
  • wtf/StringHasher.h:

(WTF::StringHasher::hash): Tweaked the string hashing function to leave
the top bits clear, so they can be used as flags.

Fixed some small differences between the PERL copy of this function and
the C++ copy of this function, which could have in theory caused subtle
crashes.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::sharedBuffer):
(WTF::StringImpl::createWithTerminatingNullCharacter):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::cost): Renamed s_refCountFlagShouldReportedCost to
s_didReportExtraCost, since the original name was both self-contradictory
and used as a double-negative.

(WTF::StringImpl::isIdentifier):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::hasTerminatingNullCharacter):
(WTF::StringImpl::isAtomic):
(WTF::StringImpl::setIsAtomic):
(WTF::StringImpl::setHash):
(WTF::StringImpl::rawHash):
(WTF::StringImpl::hasHash):
(WTF::StringImpl::existingHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::hasOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringImpl::bufferOwnership):
(WTF::StringImpl::isStatic): Moved the static/immortal bit into the bottom
bit of the refcount. Now, all lifetime information lives in the refcount
field. Moved the other bits into the hash code field.

Source/WebCore:

Reviewed by Anders Carlsson.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashValue): Updated for string hashing changes in JavaScriptCore.

LayoutTests:

Reviewed by Anders Carlsson.

These tests depended on non-deterministic effects of hash order, so I
had to update them:

  • fast/dom/prototype-inheritance-2-expected.txt: Updated for slightly

different order of discovering properties.

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js: Updated not to depend on iteration

order, since that's not what this test is about.

  • http/tests/inspector/inspector-test.js: Updated not to depend on

global function iteration order. This test setup is pretty spaghetti.
I think I avoided making it even more spaghetti.

  • inspector/storage-panel-dom-storage-expected.txt: Updated for changed

iteration order.

10/22/11:

22:03 Changeset [98198] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

HTTPBodyStream in NSURLRequest gets lost when using CFNetwork loader
https://bugs.webkit.org/show_bug.cgi?id=70583
<rdar://problem/10281227>

Reviewed by Darin Adler.

Call WebCore::setHTTPBody() only if we actually have a FormData. Unconditionally calling it
results in us passing 0 to wkCFURLRequestSetHTTPRequestBodyParts() which resets any input
stream specified by the user on the NSURLRequest. This code matches the behavior in the
Foundation version of doUpdatePlatformRequest().

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

17:40 Changeset [98197] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Make relayout-nested-positioned-elements-crash.html more reliable
https://bugs.webkit.org/show_bug.cgi?id=70672

Reviewed by Kenneth Rohde Christiansen.

The test relayout-nested-positioned-elements-crash relies on implementation
details of the test runner. If the function runTest() is run
during the test, the result will be different than the expected results.

Change the test to use the Javascript test framework.
Ensure the element has the correct style in the final state.

  • fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt:
  • fast/block/positioning/relayout-nested-positioned-elements-crash.html:
16:46 Changeset [98196] by commit-queue@webkit.org
  • 19 edits
    30 moves
    1 add
    1 delete in trunk/Source/WebCore

Move all MediaStream and PeerConnection related non-platform files to WebCore/mediastream
https://bugs.webkit.org/show_bug.cgi?id=70233

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-22
Reviewed by Adam Barth.

Removed affected files from build systems that don't have a MEDIA_STREAM build flag.

No new tests since we're just moving files.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • dom/DOMAllInOne.cpp:
  • dom/DispatchTask.h: Removed unused file.
  • dom/ScriptExecutionContext.cpp:
  • mediastream/LocalMediaStream.cpp: Renamed from Source/WebCore/dom/LocalMediaStream.cpp.

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
(WebCore::LocalMediaStream::stop):
(WebCore::LocalMediaStream::stopTimerFired):
(WebCore::LocalMediaStream::~LocalMediaStream):
(WebCore::LocalMediaStream::toLocalMediaStream):

  • mediastream/LocalMediaStream.h: Renamed from Source/WebCore/dom/LocalMediaStream.h.
  • mediastream/LocalMediaStream.idl: Renamed from Source/WebCore/dom/LocalMediaStream.idl.
  • mediastream/MediaStream.cpp: Renamed from Source/WebCore/dom/MediaStream.cpp.

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::readyState):
(WebCore::MediaStream::toMediaStream):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::scriptExecutionContext):
(WebCore::MediaStream::eventTargetData):
(WebCore::MediaStream::ensureEventTargetData):

  • mediastream/MediaStream.h: Renamed from Source/WebCore/dom/MediaStream.h.

(WebCore::MediaStream::label):
(WebCore::MediaStream::tracks):
(WebCore::MediaStream::descriptor):
(WebCore::MediaStream::refEventTarget):
(WebCore::MediaStream::derefEventTarget):

  • mediastream/MediaStream.idl: Renamed from Source/WebCore/dom/MediaStream.idl.
  • mediastream/MediaStreamClient.h: Renamed from Source/WebCore/page/MediaStreamClient.h.

(WebCore::MediaStreamClient::~MediaStreamClient):

  • mediastream/MediaStreamController.cpp: Renamed from Source/WebCore/page/MediaStreamController.cpp.

(WebCore::MediaStreamController::Request::Request):
(WebCore::MediaStreamController::Request::localId):
(WebCore::MediaStreamController::Request::frameController):
(WebCore::MediaStreamController::MediaStreamController):
(WebCore::MediaStreamController::~MediaStreamController):
(WebCore::MediaStreamController::isClientAvailable):
(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::registerRequest):
(WebCore::MediaStreamController::generateStream):
(WebCore::MediaStreamController::streamGenerated):
(WebCore::MediaStreamController::streamGenerationFailed):

  • mediastream/MediaStreamController.h: Renamed from Source/WebCore/page/MediaStreamController.h.
  • mediastream/MediaStreamEvent.cpp: Renamed from Source/WebCore/p2p/MediaStreamEvent.cpp.

(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
(WebCore::MediaStreamEvent::~MediaStreamEvent):
(WebCore::MediaStreamEvent::initMediaStreamEvent):
(WebCore::MediaStreamEvent::stream):

  • mediastream/MediaStreamEvent.h: Renamed from Source/WebCore/p2p/MediaStreamEvent.h.

(WebCore::MediaStreamEvent::isMediaStreamEvent):

  • mediastream/MediaStreamEvent.idl: Renamed from Source/WebCore/p2p/MediaStreamEvent.idl.
  • mediastream/MediaStreamFrameController.cpp: Renamed from Source/WebCore/page/MediaStreamFrameController.cpp.

(WebCore::MediaStreamFrameController::Request::~Request):
(WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
(WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
(WebCore::MediaStreamFrameController::Request::Request):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::create):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::abort):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest):
(WebCore::MediaStreamFrameController::RequestMap::abort):
(WebCore::MediaStreamFrameController::RequestMap::abortAll):
(WebCore::MediaStreamFrameController::MediaStreamFrameController):
(WebCore::MediaStreamFrameController::~MediaStreamFrameController):
(WebCore::MediaStreamFrameController::securityOrigin):
(WebCore::MediaStreamFrameController::scriptExecutionContext):
(WebCore::MediaStreamFrameController::pageController):
(WebCore::MediaStreamFrameController::enterDetachedState):
(WebCore::MediaStreamFrameController::isClientAvailable):
(WebCore::MediaStreamFrameController::disconnectPage):
(WebCore::MediaStreamFrameController::disconnectFrame):
(WebCore::MediaStreamFrameController::transferToNewPage):
(WebCore::MediaStreamFrameController::parseGenerateStreamOptions):
(WebCore::MediaStreamFrameController::generateStream):
(WebCore::MediaStreamFrameController::streamGenerated):
(WebCore::MediaStreamFrameController::streamGenerationFailed):

  • mediastream/MediaStreamFrameController.h: Renamed from Source/WebCore/page/MediaStreamFrameController.h.

(WebCore::MediaStreamFrameController::IdGenerator::IdGenerator):
(WebCore::MediaStreamFrameController::IdGenerator::getNextId):

  • mediastream/MediaStreamList.cpp: Renamed from Source/WebCore/dom/MediaStreamList.cpp.

(WebCore::MediaStreamList::create):
(WebCore::MediaStreamList::MediaStreamList):
(WebCore::MediaStreamList::~MediaStreamList):
(WebCore::MediaStreamList::length):
(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::append):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):

  • mediastream/MediaStreamList.h: Renamed from Source/WebCore/dom/MediaStreamList.h.
  • mediastream/MediaStreamList.idl: Renamed from Source/WebCore/dom/MediaStreamList.idl.
  • mediastream/MediaStreamRegistry.cpp: Renamed from Source/WebCore/platform/MediaStreamRegistry.cpp.

(WebCore::MediaStreamRegistry::registry):
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::mediaStream):

  • mediastream/MediaStreamRegistry.h: Renamed from Source/WebCore/platform/MediaStreamRegistry.h.
  • mediastream/MediaStreamTrack.cpp: Renamed from Source/WebCore/dom/MediaStreamTrack.cpp.

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):

  • mediastream/MediaStreamTrack.h: Renamed from Source/WebCore/dom/MediaStreamTrack.h.
  • mediastream/MediaStreamTrack.idl: Renamed from Source/WebCore/dom/MediaStreamTrack.idl.
  • mediastream/MediaStreamTrackList.cpp: Renamed from Source/WebCore/dom/MediaStreamTrackList.cpp.

(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::~MediaStreamTrackList):
(WebCore::MediaStreamTrackList::length):
(WebCore::MediaStreamTrackList::item):

  • mediastream/MediaStreamTrackList.h: Renamed from Source/WebCore/dom/MediaStreamTrackList.h.
  • mediastream/MediaStreamTrackList.idl: Renamed from Source/WebCore/dom/MediaStreamTrackList.idl.
  • mediastream/PeerConnection.cpp: Renamed from Source/WebCore/p2p/PeerConnection.cpp.

(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::~PeerConnection):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::iceProcessingCompleted):
(WebCore::PeerConnection::sdpGenerated):
(WebCore::PeerConnection::dataStreamMessageReceived):
(WebCore::PeerConnection::remoteStreamAdded):
(WebCore::PeerConnection::remoteStreamRemoved):
(WebCore::PeerConnection::toPeerConnection):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::stop):
(WebCore::PeerConnection::eventTargetData):
(WebCore::PeerConnection::ensureEventTargetData):
(WebCore::PeerConnection::scheduleInitialNegotiation):
(WebCore::PeerConnection::initialNegotiationTimerFired):
(WebCore::PeerConnection::ensureStreamChangeScheduled):
(WebCore::PeerConnection::streamChangeTimerFired):
(WebCore::PeerConnection::scheduleReadyStateChange):
(WebCore::PeerConnection::readyStateChangeTimerFired):
(WebCore::PeerConnection::changeReadyState):

  • mediastream/PeerConnection.h: Renamed from Source/WebCore/p2p/PeerConnection.h.

(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):

  • mediastream/PeerConnection.idl: Renamed from Source/WebCore/p2p/PeerConnection.idl.
  • mediastream/SignalingCallback.h: Renamed from Source/WebCore/p2p/SignalingCallback.h.

(WebCore::SignalingCallback::~SignalingCallback):

  • mediastream/SignalingCallback.idl: Renamed from Source/WebCore/p2p/SignalingCallback.idl.
  • page/Frame.cpp:
  • page/Navigator.cpp:
  • page/Page.cpp:
15:38 Changeset [98195] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] run-launcher script fails after testing WK2 tests
https://bugs.webkit.org/show_bug.cgi?id=70676

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-10-22
Reviewed by Andreas Kling.

Pass the '-2' flag instead of '--webkit-test-runner' when executing
run-launcher script after testing with WebKitTestRunner.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:31 Changeset [98194] by pfeldman@chromium.org
  • 40 edits in trunk

Source/WebCore: Web Inspector: get rid of View::hide, View::set visible, View::attach,
View::set visible.
https://bugs.webkit.org/show_bug.cgi?id=70523

This change also introduces assetions that forces view attach / detach operations
to be performed explicitly.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-10-20
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
(WebInspector.ApplicationCacheItemsView.prototype.willHide):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype.wasShown):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.wasShown):
(WebInspector.ConsolePanel.prototype.willHide):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.wasShown):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype.wasShown):
(WebInspector.CookieItemsView.prototype.willHide):
(WebInspector.CookieItemsView.prototype._updateWithCookies):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype.willHide):

  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype.wasShown):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide):
(WebInspector.DetailedHeapshotView.prototype._changeView):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.willHide):

  • inspector/front-end/EmptyView.js:

(WebInspector.EmptyView.prototype.wasShown):

  • inspector/front-end/FontView.js:

(WebInspector.FontView.prototype.wasShown):

  • inspector/front-end/IFrameView.js:

(WebInspector.IFrameView):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype.wasShown):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype.wasShown):
(WebInspector.ResourceContentView.prototype.wasShown):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.wasShown):
(WebInspector.NetworkLogView.prototype.willHide):
(WebInspector.NetworkPanel.prototype.wasShown):

  • inspector/front-end/Panel.js:

(WebInspector.Panel):
(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

  • inspector/front-end/PanelEnablerView.js:
  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype.willHide):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.wasShown):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype.wasShown):

  • inspector/front-end/ResourceHTMLView.js:

(WebInspector.ResourceHTMLView.prototype.wasShown):
(WebInspector.ResourceHTMLView.prototype.willHide):

  • inspector/front-end/ResourceJSONView.js:

(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.wasShown):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.prototype.wasShown):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.wasShown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.wasShown):
(WebInspector.TimelinePanel.prototype.willHide):

  • inspector/front-end/View.js:

(WebInspector.View):
(WebInspector.View.prototype.get visible):
(WebInspector.View.prototype.setHideOnDetach):
(WebInspector.View.prototype._wasShown):
(WebInspector.View.prototype._willHide):
(WebInspector.View.prototype._onResize):
(WebInspector.View.prototype.wasShown):
(WebInspector.View.prototype.willHide):
(WebInspector.View.prototype.onResize):
(WebInspector.View.prototype.show):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.doResize):
(WebInspector.View.prototype.dispatchToSelfAndChildren):
(WebInspector.View.prototype.dispatchToChildren):
(WebInspector.View.prototype._handleInsertedIntoDocument):

LayoutTests: Web Inspector: get rid of View::hide, View::set visible, View::attach.
https://bugs.webkit.org/show_bug.cgi?id=70523

Patch by Pavel Feldman <pfeldman@google.com> on 2011-10-20
Reviewed by Yury Semikhatsky.

  • inspector/debugger/scripts-panel.html:
  • inspector/view-events-expected.txt:
  • inspector/view-events.html:
09:38 Changeset [98193] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] Missing env variables cause WKTR to crash
https://bugs.webkit.org/show_bug.cgi?id=70674

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-10-22
Reviewed by Martin Robinson.

Set two environment variables that the Gtk's port of WebKitTestRunner
depends on and crashes if they're not explicitly set by the user.
Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
properly uses the _build_path method.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Set

TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
environment variables.

03:53 Changeset [98192] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateAndAdjustDirectionality()
https://bugs.webkit.org/show_bug.cgi?id=70582

Reviewed by Darin Adler.

No new tests. It's very hard to make a reliable test.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality):
Clear *strongDirectionalityTextNode even if hasStrongDirectionality is false.

10/21/11:

22:52 Changeset [98191] by mitz@apple.com
  • 2 edits
    1 add in trunk/Source/WebCore

Caret is drawn in the wrong place in multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70662

Reviewed by Gavin Barraclough.

  • manual-tests/caret-in-columns.html: Added.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret): Removed the call to offsetForContents(). That function takes
a point in local coordinates, whereas this function was applying it to a point in painting root
coordinates. The desired effect was only to undo the scroll adjustment done by the caller,
paintObject().
(WebCore::RenderBlock::paintObject): Pass the original, rather than scroll-adjusted, paint offset
to paintCaret().

22:32 Changeset [98190] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Change efl style local variables with WebKit coding Style.
https://bugs.webkit.org/show_bug.cgi?id=69988

Reviewed by Antonio Gomes.

Change *sd* variable name with *smartData*. Some variables were changed by Bug 69988.

  • ewk/ewk_frame.cpp:

(ewk_frame_view_get):
(ewk_frame_uri_set):
(ewk_frame_uri_get):
(ewk_frame_contents_size_get):
(ewk_frame_load_document_finished):
(ewk_frame_load_error):
(ewk_frame_title_set):
(ewk_frame_uri_changed):
(ewk_frame_editor_client_selection_changed):
(ewk_frame_editor_client_contents_changed):
(EWKPrivate::coreFrame):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_smart_disable_render):
(_ewk_view_smart_enable_render):
(EWKPrivate::corePage):

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_add):
(_ewk_view_single_smart_resize):

21:57 Changeset [98189] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Clicking a print button in a PDF doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=70663
<rdar://problem/9795014>

Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printMainFrame): Added a public method

that PDFViewController could call.

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView PDFViewPerformPrint:]):
(WebKit::PDFViewController::print):
Connect PDFView delegate method for printing.

20:58 Changeset [98188] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG inlining sometimes fails to reset constant references
https://bugs.webkit.org/show_bug.cgi?id=70668

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Reset constant references when we need to (new block created) and not
when we don't (change of inlining depth).

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

Reviewed by Anders Carlsson.

Added a new test that covers this specific bug as well as the general
ability to perform inlining, and the ability to OSR out of an inline
stack.

  • fast/js/dfg-inline-constant-expected.txt: Added.
  • fast/js/dfg-inline-constant.html: Added.
  • fast/js/script-tests/dfg-inline-constant.js: Added.

(foo):
(bar):

20:56 Changeset [98187] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Lookup does not work on text using web fonts in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70669
<rdar://problem/10147441>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):
If the font for the range is web font (and therefore no NSFont is
available), use the system font of the same size. While not great,
it approximates what WebKit1 does.

20:25 Changeset [98186] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crash below CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::WebPageProxy::DidPerformDictionaryLookup>
https://bugs.webkit.org/show_bug.cgi?id=70667
<rdar://problem/9622186>

Reviewed by Anders Carlsson.

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
Account for the fact that the options dictionary can be null. This is due to Lookup passing
back a null, rather than empty, dictionary when it could not find any interesting characteristics.

20:15 Changeset [98185] by nduca@chromium.org
  • 13 edits in trunk/Source

[chromium] Make setVisibility extension- and thread-correct
https://bugs.webkit.org/show_bug.cgi?id=70635

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

19:51 Changeset [98184] by weinig@apple.com
  • 5 edits
    3 adds in trunk/Source/WebKit2

Add WKBrowsingContextGroup which wraps WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=70665

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextGroup.h: Added.
  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Added.

(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup pageGroupRef]):

  • UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processGroup:browsingContextGroup:]):

  • WebKit2.xcodeproj/project.pbxproj:
19:24 Changeset [98183] by ojan@chromium.org
  • 4 edits
    15 adds
    2 deletes in trunk/LayoutTests

Fixup test expectations now that http://trac.webkit.org/changeset/98173 has landed.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Added.
  • platform/chromium-cg-mac/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/fallback-orientation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
  • platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
  • platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:42 Changeset [98182] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Removed the test since it has been passing on

the bots for at least a week.

18:32 Changeset [98181] by jchaffraix@webkit.org
  • 1 edit
    1 add
    4 deletes in trunk/LayoutTests

Unreviewed rebaseline.

This test started failing on the bot. As this is a progression, updating the baseline.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.txt: Removed.
  • platform/chromium/fast/multicol/flipped-blocks-border-after-expected.png: Added.
18:26 Changeset [98180] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt: Those changes have been consistently passing on

the bots for at least 10 days.

18:22 Changeset [98179] by fpizlo@apple.com
  • 31 edits in trunk/Source/JavaScriptCore

DFG should have inlining
https://bugs.webkit.org/show_bug.cgi?id=69996

Reviewed by Oliver Hunt.

Implements inlining that's hooked into the bytecode parser. Only
works for calls, for now, though nothing fundamentally prevents us
from inlining constructor calls. 2% overall speed-up on all
benchmarks. 7% speed-up on V8 (around 34% and 27% on deltablue and
richards respectively), neutral on Kraken and SunSpider.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::setInstructionCount):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::inlineDepth):
(JSC::CodeOrigin::operator==):
(JSC::CodeOrigin::inlineStack):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
(JSC::DFG::UnlinkedBlock::UnlinkedBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::handleSuccessor):
(JSC::DFG::ByteCodeParser::determineReachability):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::canInlineOpcodes):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForConstruct):

  • dfg/DFGGraph.cpp:

(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::decodedCodeMapFor):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::baselineCodeBlockFor):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::shouldGenerate):

  • dfg/DFGOperands.h:

(JSC::DFG::Operands::ensureLocals):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::getLocal):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrameSlow):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallSlowCase):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::profiledCodeBlockFor):
(JSC::FunctionExecutable::parameterCount):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
  • runtime/JSFunction.h:
18:15 Changeset [98178] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70647
Common but unreproducible crash under [ScrollbarPartAnimation setCurrentProgress:]
-and corresponding-
<rdar://problem/9542018>

Reviewed by Sam Weinig.

This patch implements two speculative fixes for this crash.

First, block exceptions around all of the code responsible for calling
stopAnimation. If that code throws any exceptions, we want to make sure the other
animations are still stopped.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

Only send AppKit these notifications for active pages. I originally made these
assertions, and I found that they were hit a surprising number of times. If we
only send notifications for active pages, then we should greatly reduce and
possibly eliminate our chances of hitting this crash.
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):

17:48 Changeset [98177] by mhahnenberg@apple.com
  • 10 edits in trunk/Source

Add put to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70439

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ClassInfo.h: Added put and putByIndex to the MethodTable.
  • runtime/JSFunction.h: Changed access modifier for put to protected since some

subclasses of JSFunction need to reference it in their MethodTables.

Source/WebCore:

No new tests.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp: Added static put since it was overlooked in

previous patches.
(WebCore::JSDOMWindow::putVirtual):
(WebCore::JSDOMWindow::put):

  • bindings/js/JSDOMWindowShell.cpp: Ditto.

(WebCore::JSDOMWindowShell::putVirtual):
(WebCore::JSDOMWindowShell::put):

  • bindings/js/JSDOMWindowShell.h:
17:39 Changeset [98176] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merged r98112.

17:38 Changeset [98175] by dslomov@google.com
  • 9 edits in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70580
[Chromium] Implement MessagePort transfer in chromium port of webkit.

Reviewed by David Levin.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeTransferredMessagePort):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::tryGetTransferredMessagePort):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70580
[Chromium] Implement MessagePort transfer in chromium port of webkit.
Results for JSC include some FAILs - this will be addressed when JSC
implements message port transfers as well (https://bugs.webkit.org/show_bug.cgi?id=70658)

Reviewed by David Levin.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:
  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js:

(testTransfers.channel0.port2.onmessage):
(testTransfers):
(channel.port2.onmessage):

  • platform/chromium-win/fast/events/message-port-multi-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
17:16 Changeset [98174] by eae@chromium.org
  • 18 adds in branches/subpixellayout/Source/WebCore/platform

Add missing files for fixed-point implementation

17:10 Changeset [98173] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

r97693 caused 42 failures on the chromium mac bots
https://bugs.webkit.org/show_bug.cgi?id=70300

Can't test this until https://bugs.webkit.org/show_bug.cgi?id=70660
is fixed. The fix for that bug will test this codepath as well though.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

17:04 Changeset [98172] by commit-queue@webkit.org
  • 6 edits in trunk

Setting form.enctype reflected attribute behaves strangely.
https://bugs.webkit.org/show_bug.cgi?id=44879

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-10-21
Reviewed by Darin Adler.

Source/WebCore:

The spec says form.enctype should be application/x-www-form-urlencoded,
So as "text", "plain", "multipart" or "form-data" these are not a valid value so must be ignored.

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):

LayoutTests:

Leading/trailing white-spaces should not be allowed while specifying attribute value.
Added more test coverage for form.enctype attribute.

  • fast/forms/encoding-test.html:
  • fast/forms/enctype-attribute-expected.txt:
  • fast/forms/enctype-attribute.html: Corrected test case as per new behavior.
17:01 Changeset [98171] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

Ensure periodic flushing of canvas drawing context
https://bugs.webkit.org/show_bug.cgi?id=70646

Reviewed by Simon Fraser.

No new tests. No current way to track tests that cause hangs or
non-deterministic drops in performance.

  • platform/graphics/cg/ImageBufferDataCG.h: Adds a timestamp of last tracked flush.
  • platform/graphics/cg/ImageBufferCG.cpp: Ensures periodic flushes on the drawing context.

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context): Flushes context if we're beyond flush interval.
(WebCore::ImageBuffer::copyNativeImage): Updates last flush timestamp.
(WebCore::ImageBuffer::getUnmultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::getPremultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::putUnmultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::putPremultipliedImageData): Updates last flush timestamp.

16:54 Changeset [98170] by lforschler@apple.com
  • 13 edits in branches/safari-534.52-branch/Source

Merged r98027.

16:53 Changeset [98169] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Gardening update.

  • platform/chromium/test_expectations.txt: We are randomly hitting

a known ASSERT on this test case.

16:52 Changeset [98168] by lforschler@apple.com
  • 11 edits in branches/safari-534.52-branch/Source

Merge 97810 & 97813.

16:20 Changeset [98167] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Bencher script doesn't measure GC times accurately
https://bugs.webkit.org/show_bug.cgi?id=70588

Reviewed by Geoff Garen.

Added two new options which allow different ways of measuring GC times:

--measure-gc, which omits calls to gc() between benchmark invocations.
This option takes an optional argument, which is the name of the
VM in which to enable this feature. This allows comparing a single VM
against itself, with and without GC.

--rerun <N>, which causes each sample measurement to include N invocations
which do not have gc() calls between them. The default is N = 1, which
results in the same behavior as before.

You can use either --measure-gc or --rerun <N> for N > 1 (preferably
N >= 3) to get more of a contribution from GC to the measured times.
--rerun results in tighter confidence intervals than --measure-gc, since
it amortizes GC effects in each sample, while with --measure-gc some
samples will see GC and some won't leading to a higher standard devation
and thus requiring more samples to reduce confidence intervals to
managable levels.

  • Scripts/bencher:
16:18 Changeset [98166] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Style guide should mention the preference of index over iterator
https://bugs.webkit.org/show_bug.cgi?id=70285

Reviewed by Darin Adler.

Per discussion on https://lists.webkit.org/pipermail/webkit-dev/2011-October/018274.html,
we prefer index over iterators.

  • coding/coding-style.html:
16:12 Changeset [98165] by eae@chromium.org
  • 286 edits in branches/subpixellayout/Source

Merging subpixel patch into branch. Currently builds on the qt and mac ports.

15:56 Changeset [98164] by abarth@webkit.org
  • 16 edits in trunk/Source

Introduce Event::hasInterface to make uses of interfaceName more readable
https://bugs.webkit.org/show_bug.cgi?id=70652

Reviewed by Eric Seidel.

Source/WebCore:

Eric felt that this approach would be more readable because it requires
less syntax at each callsite.

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • dom/Event.cpp:

(WebCore::Event::hasInterface):

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::handleEvent):

Source/WebKit/chromium:

Update call sites to the new interface.

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::isMutationEvent):
(WebKit::WebDOMEvent::isTextEvent):
(WebKit::WebDOMEvent::isCompositionEvent):
(WebKit::WebDOMEvent::isMessageEvent):
(WebKit::WebDOMEvent::isWheelEvent):
(WebKit::WebDOMEvent::isOverflowEvent):
(WebKit::WebDOMEvent::isPageTransitionEvent):
(WebKit::WebDOMEvent::isPopStateEvent):
(WebKit::WebDOMEvent::isProgressEvent):
(WebKit::WebDOMEvent::isXMLHttpRequestProgressEvent):
(WebKit::WebDOMEvent::isWebKitAnimationEvent):
(WebKit::WebDOMEvent::isWebKitTransitionEvent):
(WebKit::WebDOMEvent::isBeforeLoadEvent):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

15:52 Changeset [98163] by adamk@chromium.org
  • 4 edits
    2 adds in trunk

[MutationObservers] Implement basic subtree observation
https://bugs.webkit.org/show_bug.cgi?id=70436

Reviewed by Ryosuke Niwa.

Source/WebCore:

Note that this patch only implements "basic" subtree semantics,
not the fully robust semantics described in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html.
Most importantly, this change does not handle the case where mutations
occur in a temporarily detached subtree.

The plan is to implement those semantics in a followup to avoid
blocking other parts of the MutationObserver spec that rely on
the existence of subtree observation but not its specific
implementation.

Test: fast/mutation/observe-subtree.html

  • dom/Node.cpp:

(WebCore::addMatchingObservers): Static helper method for registeredMutationObserversOfType().
(WebCore::Node::registeredMutationObserversOfType): Walk up the tree looking for observers.

  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::hasAllOptions): A stricter, renamed from matches().

LayoutTests:

  • fast/mutation/observe-subtree-expected.txt: Added.
  • fast/mutation/observe-subtree.html: Added.
15:33 Changeset [98162] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/qt

[Qt] Remote debugging needs QWebInspector to work
https://bugs.webkit.org/show_bug.cgi?id=70651

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-10-21
Reviewed by Kenneth Rohde Christiansen.

Removing QWebInspector dependency from remote inspector.

  • Api/qwebinspector.cpp:
  • Api/qwebinspector_p.h:

(QWebInspectorPrivate::QWebInspectorPrivate):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::InspectorClientQt):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
(WebCore::InspectorClientQt::detachRemoteFrontend):
(WebCore::InspectorClientQt::sendMessageToFrontend):

  • WebCoreSupport/InspectorClientQt.h:
  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

  • WebCoreSupport/InspectorServerQt.h:
15:30 Changeset [98161] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Mark member variables of WebKit2 API @private
https://bugs.webkit.org/show_bug.cgi?id=70655

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKView.h:
15:26 Changeset [98160] by weinig@apple.com
  • 4 edits
    3 moves in trunk/Source/WebKit2

Rename WKProcessCluster to WKProcessGroup
https://bugs.webkit.org/show_bug.cgi?id=70654

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKProcessCluster.h: Removed.
  • UIProcess/API/mac/WKProcessCluster.mm: Removed.
  • UIProcess/API/mac/WKProcessClusterInternal.h: Removed.
  • UIProcess/API/mac/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessCluster.h.
  • UIProcess/API/mac/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessCluster.mm.

(-[WKProcessGroup initWithInjectedBundleURL:]):

  • UIProcess/API/mac/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessClusterInternal.h.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processCluster:]):

  • WebKit2.xcodeproj/project.pbxproj:
15:09 Changeset [98159] by weinig@apple.com
  • 9 edits in trunk

Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=70653

Reviewed by Simon Fraser.

Source/WebKit2:

Requiring a context and pagegroup removes the concept of global contexts,
which is something that is both confusing, and makes Objective-C wrapping
harder.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processCluster:]):

  • UIProcess/API/mac/WKViewPrivate.h:

Remove init methods that didn't take both a context and a pagegroup.

Tools:

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithContext:pageGroup:]):
(-[BrowserWindowController windowWillClose:]):
(createNewPage):
(-[BrowserWindowController awakeFromNib]):

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
Update testing code to pass a PageGroup as necessary.

15:01 Changeset [98158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Wrong type conversion in InspectorServerQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=70639

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-10-21
Reviewed by Noam Rosenthal.

Wrong type conversion causes WebSocket handshake failures for the remote inspector.

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::parseWebSocketChallengeNumber):

14:59 Changeset [98157] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

webkitpy: Teach NRWT about the EFL port
https://bugs.webkit.org/show_bug.cgi?id=70637

Allows using efl as a platform when executing NRWT.

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-10-21
Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/efl.py: Added.
  • Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects

when using PortFactory.get(port_name='efl').

14:43 Changeset [98156] by eae@chromium.org
  • 2728 edits
    1452 copies
    52 deletes in branches/subpixellayout

Merging trunk changes up until 98153 into subpixel branch.

14:34 Changeset [98155] by lforschler@apple.com
  • 38 edits
    3 adds in branches/safari-534.52-branch/Source

Merge rdar://problem/10310999

14:30 Changeset [98154] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

IndexedDB: objectStore.transaction property should be readonly
https://bugs.webkit.org/show_bug.cgi?id=62395

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-21
Reviewed by Tony Chang.

Source/WebCore:

Implement the IDBObjectStore.transaction property defined by the spec.

Test: storage/indexeddb/readonly-properties.html

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::transaction):

  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/readonly-properties-expected.txt: Added.
  • storage/indexeddb/readonly-properties.html: Added.
14:26 Changeset [98153] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash after printing a view with accelerated compositing content
https://bugs.webkit.org/show_bug.cgi?id=70643
<rdar://problem/9479083>

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): We cannot rely on -[WKView drawRect:] calling endPrinting() for us. That call to endPrinting() is still necessary to paint e.g. when resizing a window while a print dialog is present.
14:22 Changeset [98152] by lforschler@apple.com
  • 5 edits
    3 copies in branches/safari-534.52-branch

Merged r98060.

14:16 Changeset [98151] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98013.

14:13 Changeset [98150] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.52-branch

Merged r97821.

14:10 Changeset [98149] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r97808.

14:09 Changeset [98148] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r97807.

14:08 Changeset [98147] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r97681.

14:07 Changeset [98146] by abarth@webkit.org
  • 35 edits in trunk/Source

Event.h has too many virtual isMumbleEvent() functions
https://bugs.webkit.org/show_bug.cgi?id=70636

Reviewed by Dimitri Glazkov.

Source/WebCore:

We should use the new interfaceName() way of doing run-time type inference.

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventCustom.cpp:

(WebCore::JSEvent::clipboardData):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::clipboardDataAccessorGetter):

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::interfaceName):

  • dom/BeforeTextInsertedEvent.h:
  • dom/ClipboardEvent.cpp:
  • dom/ClipboardEvent.h:
  • dom/CompositionEvent.cpp:
  • dom/CompositionEvent.h:
  • dom/ErrorEvent.cpp:
  • dom/ErrorEvent.h:
  • dom/Event.cpp:

(WebCore::Event::storesResultAsString):
(WebCore::Event::storeResult):
(WebCore::Event::clipboardData):

  • dom/Event.h:
  • dom/Event.idl:
    • Remove this interface from the CPP bindings because this function no longer exists. It's unclear to me how strong our API commitments are in the CPP bindings.
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:
  • dom/MutationEvent.cpp:
  • dom/MutationEvent.h:
  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

  • dom/OverflowEvent.cpp:
  • dom/OverflowEvent.h:
  • dom/PageTransitionEvent.h:
  • dom/ProgressEvent.h:
  • dom/TextEvent.cpp:
  • dom/TextEvent.h:
  • dom/WheelEvent.cpp:
  • dom/WheelEvent.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::defaultEventHandler):

  • svg/SVGZoomEvent.cpp:
  • svg/SVGZoomEvent.h:

Source/WebKit/chromium:

Update these callsites to the new API.

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::isKeyboardEvent):
(WebKit::WebDOMEvent::isMutationEvent):
(WebKit::WebDOMEvent::isTextEvent):
(WebKit::WebDOMEvent::isCompositionEvent):
(WebKit::WebDOMEvent::isClipboardEvent):
(WebKit::WebDOMEvent::isMessageEvent):
(WebKit::WebDOMEvent::isWheelEvent):
(WebKit::WebDOMEvent::isBeforeTextInsertedEvent):
(WebKit::WebDOMEvent::isOverflowEvent):
(WebKit::WebDOMEvent::isPageTransitionEvent):
(WebKit::WebDOMEvent::isProgressEvent):
(WebKit::WebDOMEvent::isBeforeLoadEvent):

14:06 Changeset [98145] by lforschler@apple.com
  • 4 edits in branches/safari-534.52-branch/Source/WebCore

Merged r97433.

14:04 Changeset [98144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Flush denormals in Biquad, ZeroPole, and DynamicsCompressor.

We only flush when saving the state variables instead of in the
loops so that we don't impact performance too much when there are
no denormals. This will at least not propagate the denormals any
further within the class.

https://bugs.webkit.org/show_bug.cgi?id=70626

Patch by Raymond Toy <rtoy@google.com> on 2011-10-21
Reviewed by Kenneth Russell.

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::process):
Flush denormals when storing the filter state back in to class
filter state.

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):
Ditto.

  • platform/audio/ZeroPole.cpp:

(WebCore::ZeroPole::process):
Ditto.

14:01 Changeset [98143] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merged r96874.

13:57 Changeset [98142] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96864.

13:56 Changeset [98141] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96855.

13:54 Changeset [98140] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r94472.

13:52 Changeset [98139] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96765.

13:52 Changeset [98138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] WebFrameLoaderClient::shouldFallback() should use a port-specific implementation
https://bugs.webkit.org/show_bug.cgi?id=70055

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-10-21
Reviewed by Luiz Agostini.

In QtWebKit 1, our FrameLoaderClient::shouldFallback was checking for InterruptedForPolicyChange
error. In WebKit2, we are relying on the common implementation for WebFrameLoaderClient::shouldFallback
which doesn't check for the same error. Here we add this check only for Qt.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldFallBack):

13:51 Changeset [98137] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, yet another flaky crashing test.

  • platform/chromium/test_expectations.txt:
13:50 Changeset [98136] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96555.

13:48 Changeset [98135] by lforschler@apple.com
  • 6 edits
    3 copies in branches/safari-534.52-branch

Merged r95226.

13:37 Changeset [98134] by jchaffraix@webkit.org
  • 2 edits
    7 adds
    4 deletes in trunk/LayoutTests

Gardening rebaselines.

  • platform/chromium-linux-x86/fast/multicol/vertical-lr: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
  • platform/chromium-linux/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
  • platform/chromium-linux/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
  • platform/chromium-win/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/chromium/fast/multicol: Added.
  • platform/chromium/fast/multicol/vertical-lr: Added.
  • platform/chromium/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium/fast/multicol/vertical-rl: Added.
  • platform/chromium/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/chromium/test_expectations.txt:

The dumps are weird on SL so we don't land them but mark the test as PASS TEXT.

13:02 Changeset [98133] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: This test is flaky and crashing

sometimes on snow-leopard.

13:00 Changeset [98132] by lforschler@apple.com
  • 8 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r94454.

12:58 Changeset [98131] by lforschler@apple.com
  • 4 edits in branches/safari-534.52-branch/Source

Merged r94371.

12:56 Changeset [98130] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Fix r98125 by having duplicate entries for Win Debug.

  • platform/chromium/test_expectations.txt:
12:56 Changeset [98129] by lforschler@apple.com
  • 5 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r94340.

12:54 Changeset [98128] by lforschler@apple.com
  • 7 edits in branches/safari-534.52-branch/Source

Merged r94298.

12:53 Changeset [98127] by kerz@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/html/HTMLKeygenElement.cpp

Hand merge of patch for bug 70617 from Gaurav Shah

12:51 Changeset [98126] by lforschler@apple.com
  • 14 edits
    2 copies in branches/safari-534.52-branch/Source/WebKit2

Merged 94115.

12:43 Changeset [98125] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: The test is now also failing on debug on XP.
12:38 Changeset [98124] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Advanced search results should be cleared on navigation.
https://bugs.webkit.org/show_bug.cgi?id=70627

Reviewed by Pavel Feldman.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController):
(WebInspector.AdvancedSearchController.prototype._frameNavigated):

12:36 Changeset [98123] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Add finalizer to JSObject
https://bugs.webkit.org/show_bug.cgi?id=70336

Reviewed by Darin Adler.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor): Skip the call to the destructor
if we're a JSFinalObject, since the finalizer takes care of things.

  • runtime/JSCell.h:

(JSC::JSCell::~JSCell): Remove the GC validation due to a conflict with
future changes and the fact that we no longer always call the destructor, making
the information provided less useful.

  • runtime/JSObject.cpp:

(JSC::JSObject::finalize): Add finalizer for JSObject.
(JSC::JSObject::allocatePropertyStorage): The first time we need to allocate out-of-line
property storage, we add a finalizer to ourself.

  • runtime/JSObject.h:
12:33 Changeset [98122] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark call-base-resolution.html as crashing on snow-leopard.
12:19 Changeset [98121] by adamk@chromium.org
  • 15 edits
    4 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for childList changes
https://bugs.webkit.org/show_bug.cgi?id=68955

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds a ChildListMutationScope object which manages the coalescing of
multiple child removals and additions within DOM operations into single childList
mutation records.

Note that this patch doesn't cover all the cases which can be coalesced (it only
covers ContainerNode.*, and Node.innerHTML/innerText). A separate bug,
https://bugs.webkit.org/show_bug.cgi?id=70385, has been opened to track the
remaining cases.

Test: fast/mutation/observe-childList.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ChildListMutationScope.cpp: Added.

(WebCore::ChildListAccumulation::ChildListAccumulation::ChildListAccumulation):
(WebCore::ChildListAccumulation::ChildListAccumulation::~ChildListAccumulation):
(WebCore::ChildListAccumulation::ChildListAccumulation::childAdded):
(WebCore::ChildListAccumulation::ChildListAccumulation::willRemoveChild):
(WebCore::ChildListAccumulation::ChildListAccumulation::dispatch):
(WebCore::ChildListAccumulation::ChildListAccumulation::clear):
(WebCore::ChildListAccumulation::ChildListAccumulation::isEmpty):
(WebCore::ChildListAccumulation::ChildListAccumulator::ChildListAccumulator):
(WebCore::ChildListAccumulation::ChildListAccumulator::~ChildListAccumulator):
(WebCore::ChildListAccumulation::ChildListAccumulator::initialize):
(WebCore::ChildListAccumulation::ChildListAccumulator::instance):
(WebCore::ChildListAccumulation::ChildListAccumulator::childAdded):
(WebCore::ChildListAccumulation::ChildListAccumulator::willRemoveChild):
(WebCore::ChildListAccumulation::ChildListAccumulator::incrementScopingLevel):
(WebCore::ChildListAccumulation::ChildListAccumulator::decrementScopingLevel):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):

  • dom/ChildListMutationScope.h: Added.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::willRemoveChildren):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::setTextContent):
(WebCore::Node::registeredMutationObserversOfType):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::disconnect):

  • html/HTMLElement.cpp:

(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
  • fast/mutation/observe-childList-expected.txt: Added.
  • fast/mutation/observe-childList.html: Added.
11:43 Changeset [98120] by jchaffraix@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

Unreviewed gardening: rebaseline 2 tests (small color difference).

  • platform/chromium-linux-x86/fast/multicol: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
11:31 Changeset [98119] by caryclark@google.com
  • 24 edits
    689 adds in trunk/LayoutTests

Unreviewed gardening: second chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 706 of 712 files for brevity.]

  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.

...

  • platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-rtl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-short-ltr-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-short-rtl-expected.png: Added.
11:20 Changeset [98118] by jeffm@apple.com
  • 3 edits in trunk/WebKitLibraries

Focus rings are too thin in HiDPI in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70396

Rename wkSetPatternBaseCTM() to wkSetBaseCTM().

Reviewed by Beth Dakin.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:13 Changeset [98117] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Unreviewed, rolling out r98079.
http://trac.webkit.org/changeset/98079
https://bugs.webkit.org/show_bug.cgi?id=70624

The extensions tests enabled are failing on the Chromium Win
Dbg bot (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-21

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(buildExtensionAPIInjectedScript):

LayoutTests:

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:12 Changeset [98116] by vsevik@chromium.org
  • 24 edits in branches/chromium/912

Merge 97851 - Web Inspector: Enable caseSensitive search / Regex support in advanced search.
https://bugs.webkit.org/show_bug.cgi?id=70335

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get searchConfig):
(WebInspector.FileBasedSearchResultsPane.prototype._createSearchRegex):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.SearchResult):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.searchInContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.searchInContent):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.searchInContent):
(WebInspector.ContentProvider.prototype.searchInContent):

  • inspector/front-end/inspector.css:

(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel label.search-config-label):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/search/search-in-concatenated-script.html:
  • http/tests/inspector/search/search-in-resource-expected.txt:
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt:
  • http/tests/inspector/search/search-in-script.html:

BUG=101007
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8371003

11:03 Changeset [98115] by mitz@apple.com
  • 3 edits
    6 adds in trunk

Column rules positioned incorrectly in vertical-rl block with horizontal border or padding
https://bugs.webkit.org/show_bug.cgi?id=70622

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/multicol/vertical-lr/rules-with-border-before.html

fast/multicol/vertical-rl/rules-with-border-before.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Changed to use the physical left border and padding for the
left edge of the horizontal column rule.

LayoutTests:

  • fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • fast/multicol/vertical-lr/rules-with-border-before.html: Added.
  • fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • fast/multicol/vertical-rl/rules-with-border-before.html: Added.
10:55 Changeset [98114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] WebKit build does not respect QMAKE_MAC_SDK variable.
https://bugs.webkit.org/show_bug.cgi?id=70596

Instead of only relying on DARWIN_MAJOR_VERSION we also
check QMAKE_MAC_SDK. In case QMAKE_MAC_SDK is not defined
we are still falling back to DARWIN_MAJOR_VERSION.

Patch by Andy Shaw <andy.shaw@digia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-21
Reviewed by Noam Rosenthal.

10:46 Changeset [98113] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Flash of white when loading a page after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=70615
<rdar://problem/10306906>

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _processDidCrash]):
(-[WKView _didRelaunchProcess]):
Remove calls to setNeedsDisplay here.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):
Call setNeedsDisplay, but only if calling out to the loader client didn't relaunch the web process.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setPaintingEnabled):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::setPaintingEnabled):

  • WebProcess/WebPage/DrawingAreaImpl.h:

Add a way to disable painting completely for a drawing area.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Disable painting while setting up the web page, otherwise we'll get paint requests when we set the
active state of the web page.

10:41 Changeset [98112] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

10:39 Changeset [98111] by commit-queue@webkit.org
  • 3 edits
    3 adds
    3 deletes in trunk/LayoutTests

re-enable layout tests against chromium-mac-snowleopard (Skia) baselines
https://bugs.webkit.org/show_bug.cgi?id=70612

Patch by Elliot Poger <epoger@google.com> on 2011-10-21
Reviewed by Adam Barth.

  • platform/chromium-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.png: Added.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-mac/fast/repaint/continuation-after-outline-expected.png:
  • platform/chromium/test_expectations.txt:
10:39 Changeset [98110] by vsevik@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/inspector/front-end/ScriptsPanel.js

Merge 97777 - Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
https://bugs.webkit.org/show_bug.cgi?id=70322

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):

BUG=101006
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8373002

10:32 Changeset [98109] by gyuyoung.kim@samsung.com
  • 13 edits in trunk/Source/WebKit/efl

[EFL] Change efl style local variables with WebKit coding Style.
https://bugs.webkit.org/show_bug.cgi?id=69988

Reviewed by Antonio Gomes.

In common with Bug 69073, this is a third step in order to be more compliant with WebKit coding style.
We have used one-letter| two-letter local variable according to efl style. However, it's
more difficult for other reviewers to review EFL patches. So, this patch changes efl style
local variable with meaningful one.

  • Use *menu* instead of *o* in comment of ewk_contextmenu.cpp.
  • Use *list* instead of *l* local variable
  • Use *ewkPolicy* instead of *ewk_policy* in ewk_cookies.cpp
  • Use *smartData* instead of *sd* local variable for Ewk_XXXX_Smart_Data struct.
  • Use *width*, *height* instead of *w*, *h* local variables.
  • Use *scrollX*, *scrollY*, *scrollWidth*, *scrollHeight*, *centerX*, *centerY*, *deltaX*, *deltaY*,

*baseX*, *baseY* instead of *sx*, *sy*, *sw*, *sh*, *cx*, *cy*, *dx*, *dy*, *bx*, *by*.

  • Use *red*, *green*, *blue*, *alpha*, *contentRed*, *contentGreen*, *contentBlue* and *contentAlpha*

instead of *r*,*g*,*b*,*a*,*cr*,*cg*,*cb*,*ca*.

  • Use *tilePositionX*, *tilePositionY* instead of *ox*,*oy* in tiled backingstore files.
  • Use *object* instead of *obj*
  • Use *length* instead of *len*
  • Use *coreFrame* instead of *cf*
  • Use *buffer* instead of *buf*
  • Use *item* instead of *i*
  • Use *currentColumn*, *currentRow* instead of *m_col*, *m_row*
  • Remove "_" in local variable.
  • And so on.
  • ewk/ewk_auth_soup.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_js.cpp:
  • ewk/ewk_main.cpp:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_model.cpp:
  • ewk/ewk_view.cpp:
10:28 Changeset [98108] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Gtk] mousemove event always has metaKey == true
https://bugs.webkit.org/show_bug.cgi?id=35299

Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-10-21
Reviewed by Martin Robinson.

Source/WebCore:

GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state. Use GDK_META_MASK instead.

Test: platform/gtk/fast/events/event-sender-metakey.html

  • platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

Tools:

  • DumpRenderTree/gtk/EventSender.cpp:

(gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
keyboard events. So making it in sync with WebCore files.
(mouseMoveToCallback): Sending modifier keys state for mouse move event.

LayoutTests:

For testing state of metaKey for mouse and keyboard events generated
using evnetSender object.

  • platform/gtk/fast/events/event-sender-metakey-expected.txt: Added.
  • platform/gtk/fast/events/event-sender-metakey.html: Added.
10:06 Changeset [98107] by vsevik@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 97702 - Web Inspector: Search in resource crashes when there is no resource with given url.
https://bugs.webkit.org/show_bug.cgi?id=69767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-non-existing-resource.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

LayoutTests:

  • http/tests/inspector/search/search-in-non-existing-resource-expected.txt: Added.
  • http/tests/inspector/search/search-in-non-existing-resource.html: Added.

BUG=101005
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8370003

10:04 Changeset [98106] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Style and Link elements' sheet() should return CSSStyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70608

Patch by Andreas Kling <kling@webkit.org> on 2011-10-21
Reviewed by Antti Koivisto.

Return a CSSStyleSheet* instead of a StyleSheet* in these functions
since we know they are always CSSStyleSheets.
Also remove some now-unnecessary isCSSStyleSheet() checks.

  • dom/StyleElement.h:

(WebCore::StyleElement::sheet):

  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::sheet):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

09:58 Changeset [98105] by vsevik@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: Advanced search is working very slowly and does not show searching progress.
https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

  • inspector/front-end/inspector.css:

(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):

  • inspector/front-end/utilities.js:

():

09:42 Changeset [98104] by zmo@google.com
  • 8 edits in trunk/Source

Implement mechanism to enable privileged webgl extensions
https://bugs.webkit.org/show_bug.cgi?id=70538

Reviewed by Darin Fisher.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::allowPrivilegedExtensions): check page/Settings flag.

  • page/Settings.cpp: Add the flag.

(WebCore::Settings::Settings):
(WebCore::Settings::setPrivilegedWebGLExtensionsEnabled):

  • page/Settings.h: Ditto.

(WebCore::Settings::privilegedWebGLExtensionsEnabled):

Source/WebKit/chromium:

  • public/WebSettings.h: Add the flag.
  • src/WebSettingsImpl.cpp: Ditto.

(WebKit::WebSettingsImpl::setPrivilegedWebGLExtensionsEnabled):

  • src/WebSettingsImpl.h: Ditto.
08:56 Changeset [98103] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: first line in file is not highlighted.
https://bugs.webkit.org/show_bug.cgi?id=70504

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._initializeTextViewer):

08:43 Changeset [98102] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Simplify CSSStyleRule::setSelectorText().
https://bugs.webkit.org/show_bug.cgi?id=70607

Reviewed by Antti Koivisto.

Remove unnecessary isCSSStyleSheet() check and redundant Document finding
logic (CSSStyleSheet::document() will return the owner node's Document just
like this code would.)

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

08:15 Changeset [98101] by caryclark@google.com
  • 1 edit
    712 adds in trunk/LayoutTests

Unreviewed gardening: first chunk of rebaselines for Chromium-Skia
on Leopard.

[Omitting 707 of 713 files for brevity.]

  • platform/chromium-mac-leopard/css1: Added.
  • platform/chromium-mac-leopard/css1/basic: Added.
  • platform/chromium-mac-leopard/css1/basic/class_as_selector-expected.png: Added.

...

  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
07:33 Changeset [98100] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing a11y test in GTK.

  • platform/gtk/Skipped: Skip accessibility/menu-list-sends-change-notification.html
07:16 Changeset [98099] by philn@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 3 new tests.

  • platform/gtk/fast/css/clip-text-in-scaled-div-expected.txt: Added.
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Added.
  • platform/gtk/fast/selectors/visited-descendant-expected.txt: Added.
06:47 Changeset [98098] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

watchlist: Add a new entry for WebKit2 GTK+ public API
https://bugs.webkit.org/show_bug.cgi?id=70601

Reviewed by Philippe Normand.

Subscribe myself to WebKit2 GTK+ API patches. Also add a message
for patches that might include new API that points to the WebKit2
GTK+ API guidelines.

  • Scripts/webkitpy/common/config/watchlist:
06:36 Changeset [98097] by caryclark@google.com
  • 492 edits
    6 adds in trunk/LayoutTests

Unreviewed gardening: rebaselining to account for focus ring changes in
http://trac.webkit.org/changeset/97971

  • platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
  • platform/chromium-mac/fast/css/outline-auto-location-expected.png:
  • platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-mac/fast/inline/25277-2-expected.png:
  • platform/chromium-mac/fast/inline/25277-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.png:
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png:
  • platform/chromium-mac/fast/repaint/focus-ring-expected.png:
  • platform/chromium-mac/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium/test_expectations.txt:
05:43 Changeset [98096] by alex@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-10-21 Alejandro G. Castro <alex@igalia.com>

[cairo] Forward declaration of GraphicsContextState uses class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=70522

The type is a struct not a class, replace the definition in the
forward declaration.

Reviewed by Martin Robinson.

  • platform/graphics/cairo/PlatformContextCairo.h:
05:39 Changeset [98095] by yurys@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: remove debugger support for out-of-process dedicated workers
https://bugs.webkit.org/show_bug.cgi?id=70602

Now that Chromium uses in-process dedicated workers, remove support for out-of-process
dedicated workers debugger.

Reviewed by Pavel Feldman.

  • public/WebWorker.h:
  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):

  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp:
  • src/WebWorkerImpl.h:
05:02 Changeset [98094] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/events/touch/page-scaled-touch-gesture-click.html is failing
https://bugs.webkit.org/show_bug.cgi?id=70593

It was introduced in r97988. Skip it.

  • platform/qt/Skipped:
04:02 WebKitGTK/AddingNewWebKit2API edited by carlosgc@webkit.org
Add comments about new public headers (diff)
03:56 WebKitGTK/AddingNewWebKit2API edited by carlosgc@webkit.org
Add comment about includes (diff)
03:46 WebKitGTK/AddingNewWebKit2API edited by carlosgc@webkit.org
Add point about C API (diff)
03:37 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
03:28 HackingGtk edited by carlosgc@webkit.org
Add link to WebKit2 new API guidelines (diff)
03:26 Changeset [98093] by hausmann@webkit.org
  • 7 edits
    47 deletes in trunk

Remove QtScript source code from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=64088

Reviewed by Tor Arne Vestbø.

Removed dead code that isn't developed anymore.

.:

  • Source/WebKit.pro:

Source/JavaScriptCore:

  • JavaScriptCore.gypi:
  • JavaScriptCore.pri:
  • qt/api/QtScript.pro: Removed.
  • qt/api/qscriptconverter_p.h: Removed.
  • qt/api/qscriptengine.cpp: Removed.
  • qt/api/qscriptengine.h: Removed.
  • qt/api/qscriptengine_p.cpp: Removed.
  • qt/api/qscriptengine_p.h: Removed.
  • qt/api/qscriptfunction.cpp: Removed.
  • qt/api/qscriptfunction_p.h: Removed.
  • qt/api/qscriptoriginalglobalobject_p.h: Removed.
  • qt/api/qscriptprogram.cpp: Removed.
  • qt/api/qscriptprogram.h: Removed.
  • qt/api/qscriptprogram_p.h: Removed.
  • qt/api/qscriptstring.cpp: Removed.
  • qt/api/qscriptstring.h: Removed.
  • qt/api/qscriptstring_p.h: Removed.
  • qt/api/qscriptsyntaxcheckresult.cpp: Removed.
  • qt/api/qscriptsyntaxcheckresult.h: Removed.
  • qt/api/qscriptsyntaxcheckresult_p.h: Removed.
  • qt/api/qscriptvalue.cpp: Removed.
  • qt/api/qscriptvalue.h: Removed.
  • qt/api/qscriptvalue_p.h: Removed.
  • qt/api/qscriptvalueiterator.cpp: Removed.
  • qt/api/qscriptvalueiterator.h: Removed.
  • qt/api/qscriptvalueiterator_p.h: Removed.
  • qt/api/qtscriptglobal.h: Removed.
  • qt/benchmarks/benchmarks.pri: Removed.
  • qt/benchmarks/benchmarks.pro: Removed.
  • qt/benchmarks/qscriptengine/qscriptengine.pro: Removed.
  • qt/benchmarks/qscriptengine/tst_qscriptengine.cpp: Removed.
  • qt/benchmarks/qscriptvalue/qscriptvalue.pro: Removed.
  • qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp: Removed.
  • qt/tests/qscriptengine/qscriptengine.pro: Removed.
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: Removed.
  • qt/tests/qscriptstring/qscriptstring.pro: Removed.
  • qt/tests/qscriptstring/tst_qscriptstring.cpp: Removed.
  • qt/tests/qscriptvalue/qscriptvalue.pro: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue.h: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Removed.
  • qt/tests/qscriptvalueiterator/qscriptvalueiterator.pro: Removed.
  • qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp: Removed.
  • qt/tests/tests.pri: Removed.
  • qt/tests/tests.pro: Removed.

Tools:

  • Scripts/webkitpy/style/checker_unittest.py:
03:05 WebKitGTK/AddingNewWebKit2API created by carlosgc@webkit.org
Initial guidelines for adding new API to WebKit2 GTK+
02:15 Changeset [98092] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt][WK2] Typo fix.

  • tests/util.h:
02:11 Changeset [98091] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk

bytecompiler sometimes generates incorrect bytecode for put_by_id
https://bugs.webkit.org/show_bug.cgi?id=70403

Patch by Zheng Liu <zheng.z.liu@intel.com> on 2011-10-21
Reviewed by Filip Pizlo.

  • bytecompiler/NodesCodegen.cpp:

(JSC::AssignDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):

02:08 Changeset [98090] by ossy@webkit.org
  • 4 edits in trunk/Source

[Qt][WK2] Buildfix for newer Qt5. Remove duplicated defines.

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/util.h:
02:00 Changeset [98089] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-10-21 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK+ build after r98081.

  • UIProcess/API/gtk/WebKitWebView.h:
01:55 Changeset [98088] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r98085.
http://trac.webkit.org/changeset/98085
https://bugs.webkit.org/show_bug.cgi?id=70589

It broke the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-21

Source/WebKit/qt:

  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/util.h:
01:49 Changeset [98087] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] 2 inspector/extensions tests times out on Mac and linux after r97850
https://bugs.webkit.org/show_bug.cgi?id=70414

Unreviewed. Skipped inspector/extensions/extensions-{events,network}.html

  • platform/qt/Skipped:
01:44 Changeset [98086] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix API documentation comment for webkit_web_view_get_estimated_load_progress()
https://bugs.webkit.org/show_bug.cgi?id=70587

Reviewed by Philippe Normand.

It's should start with / to be recognized as API documentation.

  • UIProcess/API/gtk/WebKitWebView.cpp:
01:44 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the WK2 bot (diff)
01:40 Changeset [98085] by ossy@webkit.org
  • 4 edits in trunk/Source

[Qt][WK2] Unreviewed buildfix for newer Qt5. Remove duplicated defines.

Source/WebKit/qt:

  • tests/util.h:

(waitForSignal):

Source/WebKit2:

  • UIProcess/API/qt/tests/util.h:
01:32 Changeset [98084] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
https://bugs.webkit.org/show_bug.cgi?id=65680

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-21
Reviewed by Ryosuke Niwa.

Generally API methods using macros NULL checking in WebKit-EFL.
The macros ensure that code is smaller, version of view object
is checked and error message is displayed if NULL is passed.

  • ewk/ewk_view.cpp:

(ewk_view_mode_get):

01:24 Changeset [98083] by tkent@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Add tests to check behavior of border attribute with a large number or an invalid value.
https://bugs.webkit.org/show_bug.cgi?id=69055

Reviewed by Daniel Bates.

r96290 changed the behavior of integer parsing so that large
number strings which can not be represented in 32 bit integers
makes an error. However, border attribute behavior wasn't changed
by r96290 because its default value is 0 and
parseHTMLNonNegativeInteger() had set 0 in a case of overflow.

  • fast/dom/HTMLImageElement/image-with-invalid-border-expected.html: Added.
  • fast/dom/HTMLImageElement/image-with-invalid-border.html: Added.
  • fast/dom/HTMLInputElement/input-with-invalid-border-expected.html: Added.
  • fast/dom/HTMLInputElement/input-with-invalid-border.html: Added.
  • fast/dom/HTMLObjectElement/object-with-invalid-border-expected.html: Added.
  • fast/dom/HTMLObjectElement/object-with-invalid-border.html: Added.
01:19 Changeset [98082] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG should not try to predict argument types by looking at the values of
argument registers at the time of compilation
https://bugs.webkit.org/show_bug.cgi?id=70578

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(JSC::DFG::tryCompileFunction):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:
  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):

01:17 Changeset [98081] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69823

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_go_back):
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):

  • UIProcess/API/gtk/WebKitWebView.h:
01:09 Changeset [98080] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_stop_loading() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69610

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_stop_loading):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(provisionalLoadFailedCallback):
(loadFailedCallback):

  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(LoadStopTrackingTest::loadCommitted):
(LoadStopTrackingTest::loadFailed):
(LoadStopTrackingTest::loadFinished):
(testLoadCancelled):
(serverCallback):
(beforeAll):

00:51 Changeset [98079] by caseq@chromium.org
  • 9 edits
    2 adds in trunk

Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

LayoutTests:

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
00:19 Changeset [98078] by ossy@webkit.org
  • 919 edits in trunk/LayoutTests

[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
even if the family does not match.
https://bugs.webkit.org/show_bug.cgi?id=55036

Unreviewed. Update tests after r97990, and unskip them. (part 6)

  • platform/qt/tables/: [...]
  • platform/qt/transforms/: [...]
  • platform/qt/transitions/: [...]
  • platform/qt/Skipped:
00:07 Changeset [98077] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation change: fast/canvas/webgl/WebGLContextEvent.html now passes.

Unreviewed. The test passes since http://trac.webkit.org/changeset/98044/

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.