Timeline


and

10/27/11:

23:50 Changeset [98700] by nduca@chromium.org

[chromium] Implement frame rate control portions of CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=70713

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added.

(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::postTickTask):
(WebCore::CCDelayBasedTimeSource::onTick):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added.

(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setClient):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp: Added.

(WebCore::CCFrameRateControllerTimeSourceAdapter::create):
(WebCore::CCFrameRateControllerTimeSourceAdapter::~CCFrameRateControllerTimeSourceAdapter):
(WebCore::CCFrameRateControllerTimeSourceAdapter::onTimerTick):
(WebCore::CCFrameRateControllerTimeSourceAdapter::CCFrameRateControllerTimeSourceAdapter):
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::~CCFrameRateController):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
(WebCore::CCFrameRateController::didAbortAllPendingFrames):

  • platform/graphics/chromium/cc/CCFrameRateController.h: Added.

(WebCore::CCFrameRateControllerClient::~CCFrameRateControllerClient):
(WebCore::CCFrameRateController::setClient):
(WebCore::CCFrameRateController::setActive):

  • platform/graphics/chromium/cc/CCTimeSource.h: Added.

(WebCore::CCTimeSourceClient::~CCTimeSourceClient):
(WebCore::CCTimeSource::~CCTimeSource):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCDelayBasedTimeSourceTest.cpp: Added.

(WebKitTests::TEST):

  • tests/CCFrameRateControllerTest.cpp: Added.

(WebKitTests::FakeCCFrameRateControllerClient::FakeCCFrameRateControllerClient):
(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::frameBegun):
(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCSchedulerTestCommon.h: Added.

(WebKitTests::FakeCCTimeSourceClient::FakeCCTimeSourceClient):
(WebKitTests::FakeCCTimeSourceClient::reset):
(WebKitTests::FakeCCTimeSourceClient::tickCalled):
(WebKitTests::FakeCCTimeSourceClient::onTimerTick):
(WebKitTests::FakeCCThread::FakeCCThread):
(WebKitTests::FakeCCThread::reset):
(WebKitTests::FakeCCThread::hasPendingTask):
(WebKitTests::FakeCCThread::runPendingTask):
(WebKitTests::FakeCCThread::pendingDelay):
(WebKitTests::FakeCCThread::postTask):
(WebKitTests::FakeCCThread::postDelayedTask):
(WebKitTests::FakeCCThread::threadID):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):

23:44 Changeset [98699] by commit-queue@webkit.org

[GTK] Create .xz tarballs during distcheck
https://bugs.webkit.org/show_bug.cgi?id=71001

Patch by Priit Laes <plaes@plaes.org> on 2011-10-27
Reviewed by Martin Robinson.

  • configure.ac: Switched tarballs to use .xz compression.
23:26 Changeset [98698] by rniwa@webkit.org

Unskip platform/mac/editing/deleting/backward-delete.html on Chromium because it passes on my Mac.

  • platform/chromium/test_expectations.txt:
23:18 Changeset [98697] by rniwa@webkit.org

Group editing test expectations for Chromium in one place.

  • platform/chromium/test_expectations.txt:
23:06 Changeset [98696] by rniwa@webkit.org

Chromium Mac rebaselines.

  • platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png:
  • platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-cg-mac-leopard/fast/dom/blur-contenteditable-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/find-after-replace-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/4278698-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/3976872-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-all-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/undo: Added.
  • platform/chromium-cg-mac-snowleopard/editing/undo/4063751-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/unsupported-content: Added.
  • platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added.
  • platform/chromium/test_expectations.txt:
22:52 Changeset [98695] by haraken@chromium.org

Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL
https://bugs.webkit.org/show_bug.cgi?id=71088

Reviewed by Adam Barth.

I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536,
but I found that it has the same meaning as [ActiveDOMObject] IDL.
This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL.

No change in behavior.

Tests: fast/dom/global-constructors.html

fast/eventsource/eventsource-constructor.html
fast/eventsource/eventsource-attribute-listeners.html
fast/files/blob-slice-test.html
fast/files/file-reader-abort.html
ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor
ui_tests:WorkerTest.FLAKY_SharedWorkerFastName
ui_tests:WorkerTest.FLAKY_WorkerConstructor
ui_tests:WorkerTest.FLAKY_WorkerEventListener

  • bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActiveDOMWrapper" with "ActiveDOMObject".

(GenerateConstructorCallback):

  • bindings/scripts/test/TestInterface.idl: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result.

(WebCore::isObservable):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::V8TestInterface::toActiveDOMObject):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h: Ditto.

(WebCore::V8TestInterface::existingWrapper):

  • fileapi/FileReader.idl: Removed [V8ConstructorSetsActiveDOMWrapper] IDL.
  • mediastream/PeerConnection.idl: Ditto.
  • page/EventSource.idl: Ditto.
  • workers/SharedWorker.idl: Ditto.
  • workers/Worker.idl: Ditto.
22:39 Changeset [98694] by yutak@chromium.org

Race condition in SocketStreamHandleCFNet when PAC script is used
https://bugs.webkit.org/show_bug.cgi?id=70894

Reviewed by Alexey Proskuryakov.

Pass callback functions that call ref() or deref() as retain/release member
of CFStreamClientContext.

No new tests, as it is not possible to write a test with PAC script enabled.

  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::scheduleStreams):
(WebCore::SocketStreamHandle::retainSocketStreamHandle):
(WebCore::SocketStreamHandle::releaseSocketStreamHandle):
(WebCore::SocketStreamHandle::pacExecutionCallbackMainThread):
This callback may be called after platformClose() is already called. We should
not create new streams in this case.
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::readStreamCallback):
This manual ref/deref can be safely removed as m_readStream holds the reference.
(WebCore::SocketStreamHandle::writeStreamCallback):
Ditto.

22:39 Changeset [98693] by yutak@chromium.org

WebSocket: Connecting to localhost:8880 takes one second on Windows
https://bugs.webkit.org/show_bug.cgi?id=64788

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).

22:37 Changeset [98692] by commit-queue@webkit.org

Reland patch ensure font load before calling Skia during printing
https://bugs.webkit.org/show_bug.cgi?id=70390

Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-27
Reviewed by James Robinson.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

22:22 Changeset [98691] by msaboff@apple.com

Test Failure in fast/dom/prototype-inheritance-2.html after r98495
https://bugs.webkit.org/show_bug.cgi?id=71058

Rebaselined these results due to hash order changes in r98495.

Reviewed by Darin Adler.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
22:11 Changeset [98690] by abarth@webkit.org

Attempt to fix the Qt build.

  • WebCore.pro:
22:10 Changeset [98689] by rniwa@webkit.org

Remove erroneous expected results after r98685.

  • platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png: Removed.
  • platform/chromium-win/editing/selection/click-before-and-after-table-expected.png: Removed.
  • platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt: Removed.
  • platform/qt/editing/selection/click-before-and-after-table-expected.png: Removed.
21:58 Changeset [98688] by rniwa@webkit.org

binding test rebaseline after r98679.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):

21:55 Changeset [98687] by abarth@webkit.org

Dis-integrate run-bindings-tests with webkitpy
https://bugs.webkit.org/show_bug.cgi?id=71092

Reviewed by Ryosuke Niwa.

These tests aren't really adding any value.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
21:44 Changeset [98686] by abarth@webkit.org

Move type-specific exception descriptions into the implementation files for each type
https://bugs.webkit.org/show_bug.cgi?id=71081

Reviewed by Eric Seidel.

There's no reason to centralize this information. It belongs with each
exception type. This patch is in preparation for autogenerating the central file.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMCoreException.cpp: Added.

(WebCore::DOMCoreException::initializeDescription):

  • dom/DOMCoreException.h:
  • dom/EventException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.

(WebCore::EventException::initializeDescription):

  • dom/EventException.h:
  • dom/ExceptionBase.h:

(WebCore::ExceptionBase::code):
(WebCore::ExceptionBase::name):
(WebCore::ExceptionBase::message):
(WebCore::ExceptionBase::description):

  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/RangeException.cpp: Copied from Source/WebCore/xml/XPathException.h.

(WebCore::RangeException::initializeDescription):

  • dom/RangeException.h:
  • fileapi/FileException.cpp: Added.

(WebCore::FileException::initializeDescription):

  • fileapi/FileException.h:
  • fileapi/OperationNotAllowedException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.

(WebCore::OperationNotAllowedException::initializeDescription):

  • fileapi/OperationNotAllowedException.h:
  • storage/IDBDatabaseException.cpp: Added.

(WebCore::IDBDatabaseException::initializeDescription):

  • storage/IDBDatabaseException.h:
  • storage/SQLException.cpp: Added.

(WebCore::SQLException::initializeDescription):

  • storage/SQLException.h:
  • svg/SVGException.cpp: Copied from Source/WebCore/dom/EventException.h.

(WebCore::SVGException::initializeDescription):

  • svg/SVGException.h:
  • xml/XMLHttpRequestException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.

(WebCore::XMLHttpRequestException::initializeDescription):

  • xml/XMLHttpRequestException.h:
  • xml/XPathException.cpp: Copied from Source/WebCore/xml/XPathException.h.

(WebCore::XPathException::initializeDescription):

  • xml/XPathException.h:
21:24 Changeset [98685] by rniwa@webkit.org

Fix click-before-and-after-table.html for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70869

Reviewed by Tony Chang.

Fixed the test by wrapping tests in a function to avoid shadowing "top" variable.

  • editing/selection/click-before-and-after-table.html:
  • platform/chromium/test_expectations.txt:
20:50 Changeset [98684] by mrobinson@webkit.org

Fix the GTK+ build after r98664.

  • WebProcess/Plugins/Plugin.h: Add an IntSize forward declaration.
20:50 Changeset [98683] by johnnyg@google.com

Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
20:47 Changeset [98682] by eric@webkit.org

REGRESSION (r98639): NRWT crashes when parsing leaks output
https://bugs.webkit.org/show_bug.cgi?id=71087

Unreviewed. Sadly we have no good way to test logging.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:
19:54 Changeset [98681] by dbates@webkit.org

CMake: Add support to optionally install the built JavaScript shell
https://bugs.webkit.org/show_bug.cgi?id=71062

Reviewed by Antonio Gomes.

.:

Adds a CMake option, called SHOULD_INSTALL_JS_SHELL, that when
defined will generate an installation rule to install the built
JavaScript shell into /bin (with respect to the prefix path).

By default, we don't define this option and hence don't generate
an installation rule for the JavaScript shell.

  • Source/CMakeLists.txt:

Source/JavaScriptCore:

Generate an installation rule for installing the JavaScript shell in
/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
is defined.

  • shell/CMakeLists.txt:
19:47 Changeset [98680] by commit-queue@webkit.org

[EFL] Fix variable renaming issue inside ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=71020

Unreviewed build fix.

Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2011-10-27

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

19:43 Changeset [98679] by haraken@chromium.org

Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70215

Reviewed by Adam Barth.

Source/JavaScriptCore:

Added a method that judges if a given JSValue is empty.

Tests: transforms/svg-vs-css.xhtml

transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml

  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::JSValue::isEmpty):

Source/WebCore:

This patch implements [Optional=CallWithNullValue] IDL for JSC.
While a parameter specified as [Optional=CallWithDefaultValue] is
handled as a string "undefined", a parameter specified as
[Optional=CallWithNullValue] is handled as a null string.
(Note: not a string "null", but a null string).

c.f. [Optional=CallWithNullValue] is implemented in V8 in bug 67458.

Tests: fast/dom/global-constructors.html

transforms/svg-vs-css.xhtml
transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml

  • GNUmakefile.list.am: Removed JSWebKitCSSMatrixCustom.cpp.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDOMBinding.h: MAYBE_MISSING_PARAMETER(exec, index, policy) returns the index-th parameter, if the parameter exists. It returns an undefined value, if the index-th parameter is missing and the policy is MissingIsUndefined. It returns an empty value, otherwise (i.e. if the index-th parameter is missing and the policy is MissingIsEmpty).
  • bindings/js/JSWebKitCSSMatrixCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck): Supported [Optional=CallWithNullValue].
(GenerateConstructorDefinition): Supported [Optional=CallWithNullValue].

  • css/WebKitCSSMatrix.idl: Removed [JSCustomConstructor].
19:30 Changeset [98678] by johnnyg@google.com

Add more test expectations and chromium results.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/getComputedStyle: Removed.
  • platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:40 Changeset [98677] by mrobinson@webkit.org

[GTK] Remove most of the documentation errors from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=70670

Reviewed by Gustavo Noronha Silva.

Fix most of the documentation errors for WebKit and make many
missing symbols show up in the documentation.

  • webkit/webkitglobals.h: Doc fixes.
  • webkit/webkitspellchecker.h: Ditto.
  • webkit/webkitspellcheckerenchant.cpp: Ditto.
  • webkit/webkitwebbackforwardlist.h: Ditto.
  • webkit/webkitwebdatasource.cpp: Ditto.
  • webkit/webkitwebframe.cpp: Ditto.
  • webkit/webkitwebinspector.cpp: Ditto.
  • webkit/webkitwebinspector.h: Ditto.
  • webkit/webkitwebplugin.h: Ditto.
  • webkit/webkitwebplugindatabase.cpp: Ditto.
  • webkit/webkitwebplugindatabase.h: Ditto.
  • webkit/webkitwebsettings.h: Ditto.
  • webkit/webkitwebview.cpp: Ditto.

(webkit_web_view_class_init): Ditto.

  • webkit/webkitwebview.h: Ditto.
18:28 Changeset [98676] by jchaffraix@webkit.org

RenderTableCell m_row and m_column should not be signed values
https://bugs.webkit.org/show_bug.cgi?id=70369

Reviewed by Darin Adler.

No new tests, refactoring only.

The gist of the change is to update row / column handling in the table's
rendering code to use unsigned values. Not all the code is switched over
to unsigned but this is a good start.

Using unsigned makes a lot more sense that allowing some negative indexes
to creep in the algorithms. Also it enables us to "free" the unused signed
bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a
follow-up patch.

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):
Removed 2 casts to int as the left side now computes to an unsigned too.
Added some ASSERT to make sure we don't get negative values (colSpan / rowSpan
are always >= 1 by definition but better to be safe).

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObjectForSection):

  • accessibility/AccessibilityTableColumn.h:

Switched m_columnIndex to unsigned to remove any signed / unsigned comparisons.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::cellAbove):
(WebCore::RenderTable::cellBelow):
(WebCore::RenderTable::cellBefore):
(WebCore::RenderTable::cellAfter):
Mostly mechanical changes to avoid signed / unsigned comparisons or casts.

  • rendering/RenderTable.h:

(WebCore::RenderTable::numEffCols):
(WebCore::RenderTable::colToEffCol):
Updated a couple of functions to use an unsigned.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::col):
(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::row):
(WebCore::RenderTableCell::setRow):
Updated after switching the fields to unsigned. Also added 2 constants
to cover the not-initialized-yet value for row and column indexes.
Note: we don't enforce that you can't reach those indexes but neither
did the previous code!

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Lots of mechanical: signed -> unsigned changes. However we had
to change the logic a bit as it assumed that m_cRow started at
-1 and increased from there. The new meaning of m_cRow is the
number of rows seen and m_cRow - 1 is where to insert your new
cells.

(WebCore::RenderTableSection::addCell):
Checked the callers and all increase m_cRow before calling the function.
Added an ASSERT to catch up wrong usage in the future.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::numRows): Switched to unsigned.

18:11 Changeset [98675] by mitz@apple.com

Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com
https://bugs.webkit.org/show_bug.cgi?id=71085

Reviewed by Jon Honeycutt.

Source/WebCore:

Test: fast/css-generated-content/attr-missing.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): If the element does not have the attribute specified
in the attr() function in the content property, set the content to the empty string, per
<http://www.w3.org/TR/CSS21/generate.html#content>.

LayoutTests:

  • fast/css-generated-content/attr-missing-expected.txt: Added.
  • fast/css-generated-content/attr-missing.html: Added.
18:09 Changeset [98674] by msaboff@apple.com

ENH: Add 8 bit string support to JSC JIT
https://bugs.webkit.org/show_bug.cgi?id=71073

Changed the JIT String character access generation to create code
to check the character size and load8() or load16() as approriate.

Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movzbl_mr):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadCharacterString):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JSInterfaceJIT.h:

(JSC::ThunkHelpers::stringImplFlagsOffset):
(JSC::ThunkHelpers::stringImpl8BitFlag):

  • jit/ThunkGenerators.cpp:

(JSC::stringCharLoad):

18:01 Changeset [98673] by mikelawther@chromium.org

Test that :visited style can be overridden by child element style
Added as requested on https://bugs.webkit.org/show_bug.cgi?id=70470

https://bugs.webkit.org/show_bug.cgi?id=70568

Reviewed by Antti Koivisto.

  • fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • fast/css/child-style-can-override-visited-style.html: Added.
17:57 Changeset [98672] by vangelis@chromium.org

Expose Settings::setAcceleratedCompositingForFixedPositionEnabled to WebSettingsImpl.
https://bugs.webkit.org/show_bug.cgi?id=71077

Reviewed by James Robinson.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingForFixedPositionEnabled):

  • src/WebSettingsImpl.h:
17:50 Changeset [98671] by commit-queue@webkit.org

[Qt] Failure to build when QT_NO_CURSOR defined
https://bugs.webkit.org/show_bug.cgi?id=71060

Patch by Helder Correia <helder.correia@palm.com> on 2011-10-27
Reviewed by Noam Rosenthal.

PlatformVideoWindowQt needs to wrap some code around #ifndef
QT_NO_CURSOR in order to build QtWebKit when QT_NO_CURSOR is defined.

Build fix, no new tests.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::closeEvent):
(FullScreenVideoWindow::hideCursor):
(FullScreenVideoWindow::showCursor):

17:44 Changeset [98670] by tony@chromium.org

add snow leopard results for flexbox repaint tests
https://bugs.webkit.org/show_bug.cgi?id=71069

Reviewed by Ojan Vafai.

  • css3/flexbox/repaint-rtl-column.html:
  • css3/flexbox/repaint.html:
  • platform/mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
  • platform/mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
17:42 Writing Layout Tests for DumpRenderTree edited by arv@chromium.org
Remove part about needing #console and #description (diff)
17:40 Changeset [98669] by commit-queue@webkit.org

[chromium] Remove some APIs which are not used anymore.
https://bugs.webkit.org/show_bug.cgi?id=71068

Patch by Peng Huang <penghuang@chromium.org> on 2011-10-27
Reviewed by Darin Fisher.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
17:39 Changeset [98668] by johnnyg@google.com

Unreviewed, more gardening.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium/test_expectations.txt:
17:37 Changeset [98667] by commit-queue@webkit.org

[chromium] Track when CCLayerImpl properties have changed.
https://bugs.webkit.org/show_bug.cgi?id=70442

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-27
Reviewed by James Robinson.

Source/WebCore:

To determine a good scissor rect, we must determine what
will change on the screen on the next redraw. This patch
tracks the necessary information on CCLayerImpl and marks
a flag indicating whether this layer will "damage" the screen.
The other portion of "change", the updateRect, was already
landed in https://bugs.webkit.org/show_bug.cgi?id=69441.

New unit test added to CCLayerImplTest to test this patch.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::scrollBy):
(WebCore::CCLayerImpl::noteLayerPropertyChangedForSubtree):
(WebCore::CCLayerImpl::noteLayerPropertyChangedForDescendants):
(WebCore::CCLayerImpl::setBounds):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::setAnchorPoint):
(WebCore::CCLayerImpl::setAnchorPointZ):
(WebCore::CCLayerImpl::setMasksToBounds):
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setPosition):
(WebCore::CCLayerImpl::setPreserves3D):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::setDebugBorderWidth):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::setScrollPosition):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::setDoubleSided):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::layerPropertyChanged):
(WebCore::CCLayerImpl::resetLayerPropertyChanged):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerImplTest.cpp: Added.

(WebCore::TEST):

17:31 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
how to write good test case (edit 4), clean up grammar errors and … (diff)
17:29 Changeset [98666] by levin@chromium.org

Test expectation errors should include the file name and platform in both the log and exception info.
https://bugs.webkit.org/show_bug.cgi?id=71067

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
17:21 Changeset [98665] by eric@webkit.org

new-run-webkit-tests doesn't understand --qt or --gtk
https://bugs.webkit.org/show_bug.cgi?id=63970

Reviewed by Ojan Vafai.

Add support for --qt and --gtk to NRWT.
I also removed some incorrect comments in the option parsing
code (options which we already implement, but said we didn't)
as well as moved --platform parsing out of the "results_options"
section into the top configuration section.

Now run-webkit-tests no longer needs NRWT-specific code for passing
--platform=qt, etc.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:18 Changeset [98664] by andersca@apple.com

Add a Plugin::geometryDidChange that will work with transforms
https://bugs.webkit.org/show_bug.cgi?id=71072

Reviewed by Simon Fraser.

Source/WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Add a new Plugin::geometryDidChange pure virtual member function, that takes
the size of the plug-in, the clip rect (in plug-in coordinates), and a matrix that makes
it possible to convert between root view coordinates and plug-in coordinates.

PluginView only calls this new geometryDidChange member function if
Plugin::wantsWindowRelativeCoordinates returns false, which is only true for BuiltInPDFView right now.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add stub.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::updateScrollbars):
(WebKit::BuiltInPDFView::pdfDocumentDidLoad):
(WebKit::BuiltInPDFView::paintContent):
(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):
(WebKit::BuiltInPDFView::geometryDidChange):
(WebKit::BuiltInPDFView::setScrollOffset):
(WebKit::BuiltInPDFView::maximumScrollPosition):
(WebKit::BuiltInPDFView::visibleHeight):
(WebKit::BuiltInPDFView::visibleWidth):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

There's no need to keep track of the plug-in rect anymore.

  • WebProcess/Plugins/Plugin.h:

Add and document geometryDidChange.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:

Add stub.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):
Call geometryDidChange.

17:12 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
how to write good test case (edit 3), how to tweak pixel / text dumping (diff)
17:06 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
How to write good test case (edit 2), pixel tests (diff)
17:01 Changeset [98663] by johnnyg@google.com

Unreviewed, gardening chromium.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table: Added.
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
  • platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/fast/css/getComputedStyle: Removed.
  • platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium/svg/css: Removed.
  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
17:00 Changeset [98662] by eae@chromium.org

Merging trunk changes up until 98654 into subpixel branch.

16:58 Changeset [98661] by abarth@webkit.org

Exception subtypes have incorrect namespace indentation
https://bugs.webkit.org/show_bug.cgi?id=71075

Reviewed by Eric Seidel.

This patch is in preparation for editing these headers. We decided to
not indent namespaces in headers and update the headers as we edited
them.

  • dom/DOMCoreException.h:

(WebCore::DOMCoreException::create):
(WebCore::DOMCoreException::DOMCoreException):

  • dom/EventException.h:

(WebCore::EventException::create):
(WebCore::EventException::EventException):

  • dom/RangeException.h:

(WebCore::RangeException::create):
(WebCore::RangeException::RangeException):

  • xml/XMLHttpRequestException.h:

(WebCore::XMLHttpRequestException::create):
(WebCore::XMLHttpRequestException::XMLHttpRequestException):

  • xml/XPathException.h:

(WebCore::XPathException::create):
(WebCore::XPathException::XPathException):

16:55 Changeset [98660] by kbr@google.com

Implement new restrictions on uniform and attribute location lengths
https://bugs.webkit.org/show_bug.cgi?id=70981

Reviewed by Chris Marrin.

Source/WebCore:

Tests: fast/canvas/webgl/attrib-location-length-limits.html

fast/canvas/webgl/uniform-location-length-limits.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::validateLocationLength):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

  • fast/canvas/webgl/attrib-location-length-limits-expected.txt: Added.
  • fast/canvas/webgl/attrib-location-length-limits.html: Added (imported from WebGL conformance suite).
  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):
(WebGLTestUtils.): Updated to latest version in WebGL conformance suite.

  • fast/canvas/webgl/uniform-location-length-limits-expected.txt: Added.
  • fast/canvas/webgl/uniform-location-length-limits.html: Added (imported from WebGL conformance suite).
  • platform/mac/Skipped: Temporarily skip new tests on Mac until WebKit's copy of ANGLE is upgraded.
16:49 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
How to write good test case (edit 1), mostly text cases and 'do you need a … (diff)
16:38 Changeset [98659] by commit-queue@webkit.org

[MutationObservers] Implement subtree observation of transiently disconnected nodes
https://bugs.webkit.org/show_bug.cgi?id=70788

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds support for observing all descendant nodes reachable from a subtree
observation until delivery of mutations -- even if they become detached. We do this by
introducing a "transient registration" which can exist for a short time along side
normal registrations on Node. Transient registrations have a reference to the node
which "owns" the subtree observation registration (the "registrationNode"). Transient
registrations are cleared immediately before mutations are delivered to an observer,
or when the observer re-observes at the registrationNode, in-effect resetting the
observation.

New tests added to fast/mutation/observe-subtree.html.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/Node.cpp:

(WebCore::addMatchingObservers):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifySubtreeObserversOfDisconnection):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::MutationObserverEntry):
(WebCore::MutationObserverEntry::operator==):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):
(WebCore::unregisterTransientEntries):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::observedNodeDestructed):
(WebCore::WebKitMutationObserver::observedSubtreeWillDisconnect):
(WebCore::WebKitMutationObserver::clearTransientEntries):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:

LayoutTests:

Added tests which assert that nodes can be detached from a subtree where observation is registered
and still be observed -- until the end of the current "microtask".

  • fast/mutation/observe-subtree-expected.txt:
  • fast/mutation/observe-subtree.html:
16:35 Changeset [98658] by fpizlo@apple.com

If the bytecode generator emits code after the return in the first basic block,
DFG's inliner crashes
https://bugs.webkit.org/show_bug.cgi?id=71071

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Removed some cruft dealing with parsing failures due to unsupported functionality
(that's never reached anymore due to it being caught in DFGCapabilities). This
allowed me to repurpose the bool return from parseBlock() to mean: true if we
should continue to parse, or false if we've already parsed all live code.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-inline-early-return-expected.txt: Added.
  • fast/js/dfg-inline-early-return.html: Added.
  • fast/js/script-tests/dfg-inline-early-return.js: Added.

(foo):
(bar):

16:24 Changeset [98657] by psolanki@apple.com

Ask CG to not parse image metadata
https://bugs.webkit.org/show_bug.cgi?id=71029

Reviewed by Simon Fraser.

We don't need CG to parse the image metadata since WebCore never uses it. Passing this
option shaves off time spent under CGImageSourceCopyPropertiesAtIndex. Under Instruments I
saw the time drop from ~75ms to ~25ms when loading http://boston.com/bigpicture and the
first link on that page.

No new tests because no change in functionality.

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

16:21 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Splitting the existing content in a better structure, added some content … (diff)
16:15 Changeset [98656] by dgrogan@chromium.org

Move eventqueue from Document to ScriptExecutionContext so that it can be accessed from workers
https://bugs.webkit.org/show_bug.cgi?id=57789

Extract interface from EventQueue and create two new subclasses:
DocumentEventQueue and WorkerEventQueue. DocumentEventQueue is the
old EventQueue implementation that uses DOMTimer(0) to post async
events. WorkerEventQueue posts events to its thread's message loop.

Reviewed by David Levin.

No new tests - IndexedDB will use this but isn't ready yet. I don't
know of any other API available in workers that I can test this with.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::eventQueue):

  • dom/DocumentEventQueue.cpp: Renamed from Source/WebCore/dom/EventQueue.cpp.

(WebCore::shouldDispatchScrollEventSynchronously):
(WebCore::DocumentEventQueueTimer::DocumentEventQueueTimer):
(WebCore::DocumentEventQueueTimer::fired):
(WebCore::DocumentEventQueue::create):
(WebCore::DocumentEventQueue::DocumentEventQueue):
(WebCore::DocumentEventQueue::~DocumentEventQueue):
(WebCore::DocumentEventQueue::enqueueEvent):
(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
(WebCore::DocumentEventQueue::cancelEvent):
(WebCore::DocumentEventQueue::close):
(WebCore::DocumentEventQueue::pendingEventTimerFired):
(WebCore::DocumentEventQueue::dispatchEvent):

  • dom/DocumentEventQueue.h: Copied from Source/WebCore/dom/EventQueue.h.
  • dom/EventQueue.h:
  • dom/ScriptExecutionContext.h:
  • page/EventHandler.cpp: Change EventQueue to DocumentEventQueue.

(WebCore::EventHandler::sendScrollEvent): Change EventQueue to DocumentEventQueue.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo): Change EventQueue to DocumentEventQueue.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollTo): Change EventQueue to DocumentEventQueue.

  • storage/IDBDatabase.cpp:
  • storage/IDBRequest.cpp:
  • storage/IDBTransaction.cpp:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::eventQueue):

  • workers/WorkerContext.h:
  • workers/WorkerEventQueue.cpp: Added.

(WebCore::WorkerEventQueue::create):
(WebCore::WorkerEventQueue::WorkerEventQueue):
(WebCore::WorkerEventQueue::~WorkerEventQueue):
(WebCore::WorkerEventQueue::EventDispatcherTask::create):
(WebCore::WorkerEventQueue::EventDispatcherTask::dispatchEvent):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::cancel):
(WebCore::WorkerEventQueue::EventDispatcherTask::EventDispatcherTask):
(WebCore::WorkerEventQueue::removeEvent):
(WebCore::WorkerEventQueue::enqueueEvent):
(WebCore::WorkerEventQueue::cancelEvent):
(WebCore::WorkerEventQueue::close):

  • workers/WorkerEventQueue.h: Copied from Source/WebCore/dom/EventQueue.h.
16:14 Changeset [98655] by johnnyg@google.com

Unreviewed, new chromium expectations for shading/anti-aliasing changes.

  • fast/borders/borderRadiusDashed06-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/fast/table/028-vertical-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/audio-repaint-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/filters: Added.
  • platform/chromium-cg-mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-cg-mac/fast/backgrounds/background-leakage-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/css/shadow-multiple-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-clip-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-separator-painting-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-style-color-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/select-empty-option-height-expected.png: Removed.
  • platform/chromium-cg-mac/media/audio-repaint-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-cg-mac/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-narrow-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text: Added.
  • platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom: Added.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed06-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Removed.
  • platform/chromium-mac/fast/text/emphasis-overlap-expected.png: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-clip-expected.png: Removed.
  • platform/chromium-win-xp/media: Added.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium/media/video-zoom-controls-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/win-xp/media/audio-repaint-expected.txt: Removed.
  • svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
16:06 Changeset [98654] by commit-queue@webkit.org

[GStreamer] Prevent memory leak when fullscreening a video
https://bugs.webkit.org/show_bug.cgi?id=71043

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-27
Reviewed by Gustavo Noronha Silva.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/GStreamerGWorld.h:
16:03 Changeset [98653] by leviw@chromium.org

Fixing the Mac build by rolling out Region changes. Only RenderRegion needed the previous fix.

15:51 Changeset [98652] by commit-queue@webkit.org

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-10-27
Reviewed by David Kilzer.

Make FeatureDefines Identical Across OS X Projects
https://bugs.webkit.org/show_bug.cgi?id=71051

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
15:38 Changeset [98651] by vsevik@chromium.org

Web Inspector: HTTP headers merged incorrect in Chrome
https://bugs.webkit.org/show_bug.cgi?id=69674

Reviewed by Pavel Feldman.

  • src/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

15:34 Changeset [98650] by commit-queue@webkit.org

Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols
https://bugs.webkit.org/show_bug.cgi?id=71047

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-10-27
Reviewed by David Kilzer.

  • WebCore.exp.in:
15:28 Changeset [98649] by eae@chromium.org

Qt/chromium linux fixes and cleanup

15:25 Changeset [98648] by leviw@chromium.org

Fixing region's usage of integers and INT_MAX with LayoutUnit-friendly versions

15:19 Changeset [98647] by fpizlo@apple.com

Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic
https://bugs.webkit.org/show_bug.cgi?id=71045

Reviewed by Geoff Garen.

Make sure that if a structure is pinned, it also has a property map.

  • runtime/Structure.cpp:

(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTableForPinning):

  • runtime/Structure.h:

(JSC::Structure::materializePropertyMapIfNecessaryForPinning):

15:07 Changeset [98646] by andersca@apple.com

Rename Plugin::geometryDidChange to Plugin::deprecatedGeometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71065

Reviewed by Simon Fraser.

In preparation for adding a version of geometryDidChange that doesn't take window coordinates.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::deprecatedGeometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::deprecatedGeometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

15:05 Changeset [98645] by commit-queue@webkit.org

Unreviewed, rolling out r98626.
http://trac.webkit.org/changeset/98626
https://bugs.webkit.org/show_bug.cgi?id=71066

Does not compile on cr-win (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-27

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

14:56 Changeset [98644] by tony@chromium.org

Fix a compiler warning caught by gcc 4.6.1. Need to return something.

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::nextAction):

14:54 Changeset [98643] by msaboff@apple.com

32bit build failure after r98624
https://bugs.webkit.org/show_bug.cgi?id=71064

Disambiguated operator overload with unsigned index (0u).

Reviewed by Sam Weinig.

  • runtime/UString.h:

(JSC::operator==):

14:48 Changeset [98642] by annacc@chromium.org

Individually Skip track-related LayoutTests rather than block-Skipping them.
https://bugs.webkit.org/show_bug.cgi?id=71037

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
14:43 Changeset [98641] by leviw@chromium.org

Painting Mac scrollbars on integer bounds.

14:42 Changeset [98640] by vsevik@chromium.org

Web Inspector: Advanced search style fixes.
https://bugs.webkit.org/show_bug.cgi?id=71036

Reviewed by Pavel Feldman.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView):

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/inspector.css:

(.search-view .search-panel):
(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body:not(.platform-mac) .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body.platform-mac .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(#drawer-status-bar .search-status-bar-progress):
(body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress):
(body.platform-mac #drawer-status-bar .search-status-bar-progress):

14:29 Changeset [98639] by eric@webkit.org

REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=66227

Reviewed by Adam Roben.

I believe this should fix the bug.

  • Scripts/run-webkit-tests: make NRWT default for --leaks
  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
(LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
(LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.

  • Scripts/webkitpy/layout_tests/port/mac.py:

Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.

14:21 Changeset [98638] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71061

[CSS Line Grid] Add support for parsing the line-grid property.

Source/WebCore:

New tests in fast/line-grid.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineGrid):
(WebCore::InheritedFlags::setLineGrid):
(WebCore::InheritedFlags::initialLineGrid):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/line-grid: Added.
  • fast/line-grid/line-grid-parsing-expected.txt: Added.
  • fast/line-grid/line-grid-parsing.html: Added.
  • fast/line-grid/script-tests: Added.
  • fast/line-grid/script-tests/line-grid-parsing.js: Added.
14:09 Changeset [98637] by fsamuel@chromium.org

iframes seem to occasionally doubly scale or scale incorrectly when pageScaleFactor != 1.0
https://bugs.webkit.org/show_bug.cgi?id=70552

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/frames/iframe-double-scale-contents.html

The iframe's document style was using the page's scale factor, rather than the frame's (1.0).
If the page scale factor was set after layout was complete, then this would have no impact because the iframe's document style and layout is not recomputed,
but if the page scale factor is set prior to creating and laying out the iframe, the iframe's content would be doubly scaled.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

LayoutTests:

  • fast/frames/iframe-double-scale-contents-expected.png: Added.
  • fast/frames/iframe-double-scale-contents-expected.txt: Added.
  • fast/frames/iframe-double-scale-contents.html: Added.
  • fast/frames/resources/iframe-content-scaling-bug-iframe.html: Added.
14:04 Changeset [98636] by reed@google.com

test_rebaseline_expectations failing
https://bugs.webkit.org/show_bug.cgi?id=71033

Reviewed by Adam Barth.

Resolve overlaps

  • platform/chromium/test_expectations.txt:
13:55 Changeset [98635] by mitz@apple.com

Updated expected results after r98608.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:53 Changeset [98634] by commit-queue@webkit.org

[Chromium] Need setPrinting
https://bugs.webkit.org/show_bug.cgi?id=46152

Patch by Stephen Chenney <schenney@chromium.org> on 2011-10-27
Reviewed by Hajime Morita.

Source/WebKit/chromium:

  • public/WebFrame.h: Added pure virtual prototype for printPagesWithBoundaries. Added enum

and changed parameters for renderTreeAsText.

  • src/WebFrameImpl.cpp:

(WebKit::ChromePrintContext::spoolAllPagesWithBoundaries): Added this method, based on
the static in PrintContext. This uses Chromium specific page spooling and transforms.
(WebKit::WebFrameImpl::renderTreeAsText): Updated to allow text dump in printed format.
(WebKit::WebFrameImpl::printPagesWithBoundaries): Added method for testing printing page
breaks.

  • src/WebFrameImpl.h: Added prototype.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
(LayoutTestController::reset): Clearing flags for setPrinting.
(LayoutTestController::setPrinting): Set flags for setPrinting.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
(LayoutTestController::isPrinting): Method to return the setPrinting status.

  • DumpRenderTree/chromium/TestShell.cpp:

(dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
(TestShell::dump): Modified to dump setPrinting-specific output.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
active.

  • DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.

LayoutTests:

  • platform/chromium/test_expectations.txt: Removing setPrinting tests from the expected failures.
  • platform/chromium-linux/printing/setPrinting-expected.png: Added.
  • platform/chromium-linux/printing/setPrinting-expected.txt: Added.
  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/chromium-mac/printing/setPrinting-expected.png: Added.
  • platform/chromium-mac/printing/setPrinting-expected.txt: Added.
  • platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/chromium-win/printing/setPrinting-expected.png: Added.
  • platform/chromium-win/printing/setPrinting-expected.txt: Added.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/mac/printing/setPrinting-expected.png: Rebaselined for the change to the test html.
  • platform/mac/printing/setPrinting-expected.txt: Rebaselined for the change to the test html.
  • printing/setPrinting.html: Modified the test to make the box have a colored border instead of the solid background, as the solid background does not print on chromium.
13:52 Changeset [98633] by lforschler@apple.com

Versioning.

13:43 Changeset [98632] by leandro@webkit.org

[EFL] Unreviewed. Add pixel test baselines for animations,
compositing, dom, editing, fonts, mathml, media, printing,
transforms and transitions.

  • platform/efl/animations: [...]
  • platform/efl/compositing: [...]
  • platform/efl/dom: [...]
  • platform/efl/editing: [...]
  • platform/efl/fonts: [...]
  • platform/efl/mathml: [...]
  • platform/efl/media: [...]
  • platform/efl/printing: [...]
  • platform/efl/transforms: [...]
  • platform/efl/transitions: [...]
13:42 Changeset [98631] by nduca@chromium.org

Unreviewed, fix CCSchedulerStateMachine build errors.

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
13:41 Changeset [98630] by jamesr@google.com

Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

13:40 Changeset [98629] by commit-queue@webkit.org

Fix building on GNU/kFreeBSD
https://bugs.webkit.org/show_bug.cgi?id=71005

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-10-27
Reviewed by Darin Adler.

  • config.h:
  • wtf/Platform.h:
13:30 Changeset [98628] by tony@chromium.org

fix sizing of auto sized flexbox
https://bugs.webkit.org/show_bug.cgi?id=70839

Reviewed by David Hyatt.

Source/WebCore:

Correctly set the height of the flexbox when we have a column flow
and the height is auto.

Tests: css3/flexbox/columns-auto-size.html

css3/flexbox/flex-flow-margins-auto-size.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Always computeLogicalHeight() after we're done placing children.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): Set the height as we place children.

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt: Added.
  • css3/flexbox/columns-auto-size.html: Added.
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt: Added.
  • css3/flexbox/flex-flow-margins-auto-size.html: Added.

A bunch of these cases fail, but that's because of bug 70769.

13:28 Changeset [98627] by vangelis@chromium.org

Source/WebCore: Add support for creating compositing layers for fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=69796

position:fixed elements will get a compositing layer if:

  1. Settings:acceleratedCompositingForFixedPositionEnabled() returns true,
  2. The element has its own stacking context (e.g. has a z-index), and
  3. The element's container is the RenderView (e.g. not a descendant of a transformed element)

Reviewed by Simon Fraser.

Test: compositing/geometry/fixed-position-composited-switch.html

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForFixedPositionEnabled):
(WebCore::Settings::acceleratedCompositingForFixedPositionEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:
  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForFixedPosition):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: Adding tests for fixed positioned elements getting their own composited layer.
https://bugs.webkit.org/show_bug.cgi?id=69796

Reviewed by Simon Fraser.

  • compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-switch.html: Added.
13:20 Changeset [98626] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=70390
Ensure font load for Skia backend during printing.

Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-27
Reviewed by James Robinson.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

13:19 Changeset [98625] by lforschler@apple.com

Versioning.

13:16 Changeset [98624] by msaboff@apple.com

Investigate storing strings in 8-bit buffers when possible
https://bugs.webkit.org/show_bug.cgi?id=66161

Source/JavaScriptCore:

Investigate storing strings in 8-bit buffers when possible
https://bugs.webkit.org/show_bug.cgi?id=66161

Added support for 8 bit string data in StringImpl. Changed
(UChar*) m_data to m_data16. Added char* m_data8 as a union
with m_data16. Added UChar* m_copyData16 to the other union
to store a 16 bit copy of an 8 bit string when needed.
Added characters8() and characters16() accessor methods
that assume the caller has checked the underlying string type
via the new is8Bit() method. The characters() method will
return a UChar* of the string, materializing a 16 bit copy if the
string is an 8 bit string. Added two flags, one for 8 bit buffer
and a second for a 16 bit copy for an 8 bit string.

Fixed method name typo (StringHasher::defaultCoverter()).

Over time the goal is to eliminate calls to characters() and
us the character8() and characters16() accessors.

This patch does not include changes that actually create 8 bit
strings. This is the first of at least 8 patches. Subsequent
patches will be submitted for JIT changes, making the JSC lexer,
parser and literal parser, JavaScript string changes and
then changes in webcore to take advantage of the 8 bit strings.

This change is performance neutral for SunSpider and V8 when
run from the command line with "jsc".

Reviewed by Geoffrey Garen.

(JSC::Interpreter::callEval):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • runtime/Identifier.cpp:

(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::toUInt32):

  • runtime/Identifier.h:

(JSC::Identifier::equal):
(JSC::operator==):
(JSC::operator!=):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):

  • runtime/UString.cpp:

(JSC::UString::UString):
(JSC::equalSlowCase):
(JSC::UString::utf8):

  • runtime/UString.h:

(JSC::UString::characters):
(JSC::UString::characters8):
(JSC::UString::characters16):
(JSC::UString::is8Bit):
(JSC::UString::operator[]):
(JSC::UString::find):
(JSC::operator==):

  • wtf/StringHasher.h:

(WTF::StringHasher::computeHash):
(WTF::StringHasher::defaultConverter):

  • wtf/text/AtomicString.cpp:

(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicString::add):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(WTF::AtomicString::contains):
(WTF::AtomicString::find):
(WTF::AtomicString::add):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):

  • wtf/text/StringConcatenate.h:
  • wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::hash):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::containsOnlyWhitespace):
(WTF::StringImpl::substring):
(WTF::StringImpl::characterStartingAt):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::fill):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::stripMatchedCharacters):
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::replace):
(WTF::StringImpl::defaultWritingDirection):
(WTF::StringImpl::adopt):
(WTF::StringImpl::createWithTerminatingNullCharacter):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::create):
(WTF::StringImpl::create8):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::flagsOffset):
(WTF::StringImpl::flagIs8Bit):
(WTF::StringImpl::dataOffset):
(WTF::StringImpl::is8Bit):
(WTF::StringImpl::characters8):
(WTF::StringImpl::characters16):
(WTF::StringImpl::characters):
(WTF::StringImpl::has16BitShadow):
(WTF::StringImpl::setHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::copyChars):
(WTF::StringImpl::operator[]):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::isolatedCopy):

  • wtf/text/WTFString.cpp:

(WTF::String::String):
(WTF::String::append):
(WTF::String::format):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):

  • wtf/text/WTFString.h:

(WTF::String::find):
(WTF::String::findIgnoringCase):
(WTF::String::contains):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):

  • wtf/unicode/Unicode.h:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::execute):

  • yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::execute):

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):

Source/WebCore:

Changes to support 8 bit StringImpl changes.

Reviewed by Geoffrey Garen.

No new tests, refactored StringImpl for 8 bit strings.

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

Source/WebKit2:

Added export of StringImpl::getData16SlowCase for linking tests.

Reviewed by Geoffrey Garen.

  • win/WebKit2.def:
13:08 Changeset [98623] by johnnyg@google.com

Unreviewed, more chromium baselines for new multicol tests.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol: Removed.
  • platform/chromium-linux/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-linux/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
13:01 Changeset [98622] by weinig@apple.com

Add allowsPlugIns property to WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=70987

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WKBrowsingContextGroupTest.GetSetPluginsEnabled

  • UIProcess/API/mac/WKBrowsingContextGroup.h:
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
Rename to allowsJavaScript/setAllowsJavaScript.

(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
Add allowsPlugIns/setAllowsPlugIns.

Tools:

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:

Add basic test for WKBrowsingContextGroup.allowsPlugIns.

13:01 Changeset [98621] by lforschler@apple.com

New tag.

12:57 Changeset [98620] by johnnyg@google.com

Unreviewed, rebaselines after multi-col changes.

  • platform/chromium-win-vista/fast/css/getComputedStyle: Added.
  • platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium-win-xp/fast/css/getComputedStyle: Added.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/chromium/svg/css: Added.
  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Added.
12:52 Changeset [98619] by commit-queue@webkit.org

[Qt] Failure to build when QT_NO_MENU defined
https://bugs.webkit.org/show_bug.cgi?id=70970

Patch by Helder Correia <helder.correia@palm.com> on 2011-10-27
Reviewed by Andreas Kling.

iterateContextMenu() must be wrapped around #ifndef QT_NO_MENU.

Build fix, no new tests.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12:33 Changeset [98618] by nduca@chromium.org

[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714

Source/WebCore:

Reland of ill-fated r98612.

Reviewed by James Robinson.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.

(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):

Source/WebKit/chromium:

Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/CCSchedulerStateMachineTest.cpp: Added.

(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):

12:22 Changeset [98617] by podivilov@chromium.org

Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):

  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
  • fast/canvas/canvas-putImageData.js:
12:16 Changeset [98616] by johnnyg@google.com

unreviewed, test expectations

  • platform/chromium/test_expectations.txt:
12:15 Changeset [98615] by antti@apple.com

REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Dave Hyatt.

If we apply an explicitly inherited property, we need to apply any further
non-inherited properties as the property might get overridden again.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):

  • css/CSSStyleSelector.h:
12:12 Changeset [98614] by jchaffraix@webkit.org

Remove RenderTableSection::m_gridRows
https://bugs.webkit.org/show_bug.cgi?id=70570

Reviewed by Darin Adler.

No new test, refactoring only.

Just nuke the old field that was duplicating
m_grid.size().

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::numRows):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paint):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
s/m_gridRows/m_grid.size()/.
Also updated the code as m_grid.size() is unsigned.

(WebCore::RenderTableSection::recalcCells):
The old code would keep the grid's memory but we have to clear it to properly
count the elements. To avoid lots of small reallocations, we reallocate the
buffer at the old capacity upfront.

11:45 Changeset [98613] by nduca@chromium.org

Unreviewed, rolling out r98612.
http://trac.webkit.org/changeset/98612
https://bugs.webkit.org/show_bug.cgi?id=70714

Broke build

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCSchedulerStateMachineTest.cpp: Removed.
11:29 Changeset [98612] by nduca@chromium.org

[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.

(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCSchedulerStateMachineTest.cpp: Added.

(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):

11:27 Changeset [98611] by lforschler@apple.com

New tag.

11:13 Changeset [98610] by lforschler@apple.com

Merged r98530.

11:11 Changeset [98609] by lforschler@apple.com

Merged r98526.

10:59 Changeset [98608] by mitz@apple.com

<rdar://problem/10262205> Allow column progression to be independent of writing mode
https://bugs.webkit.org/show_bug.cgi?id=71028

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/multicol/block-axis-horizontal-bt.html

fast/multicol/block-axis-horizontal-tb.html
fast/multicol/block-axis-vertical-lr.html
fast/multicol/block-axis-vertical-rl.html
fast/multicol/flipped-blocks-hit-test.html

Allow “columns” to be stacked along the block axis rather than the inline axis. This can facilitate
paginated interfaces. A column-axis property is added in order to enable this mode.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the column-axis property.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map ColumnAxis values to identifiers.
(WebCore::CSSPrimitiveValue::operator ColumnAxis): Map identifiers to ColumnAxis values.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Updated to return false for the column-axis property.

  • css/CSSPropertyNames.in: Added -webkit-column-axis.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Handle column-axis.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo): Added m_progressionAxis to the initialization list.
(WebCore::ColumnInfo::progressionAxis): Added this getter.
(WebCore::ColumnInfo::setProgressionAxis): Added this setter.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren): Simplified, and thus also made this function work
with block-axis column progression.
(WebCore::RenderBlock::paintColumnRules): Added code to paint rules between columns with block-axis
progression.
(WebCore::RenderBlock::paintColumnContents): Adjusted the painting offset for the block-axis
column progression case.
(WebCore::RenderBlock::nodeAtPoint): Fixed hit-testing in flipped-blocks writing modes. This is
covered by flipped-blocks-hit-test.html.
(WebCore::RenderBlock::hitTestColumns): Adjusted the offset for the block-axis column progression
case.
(WebCore::RenderBlock::calcColumnWidth): Set the column width to the content logical width in
the block-axis column progression case. The column-width and column-count properties are ignored.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Set the column progression axis based on
the style.
(WebCore::RenderBlock::columnCount): Broke up an assertion into two.
(WebCore::RenderBlock::columnRectAt): Updated for block-axis column progression.
(WebCore::RenderBlock::adjustPointToColumnContents): Ditto.
(WebCore::RenderBlock::adjustRectForColumns): Ditto.
(WebCore::RenderBlock::adjustForColumns): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns): Adjusted the offser for the block-axis column
progression case.
(WebCore::RenderLayer::hitTestChildLayerColumns): Ditto.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::columnAxis): Added this getter.
(WebCore::InheritedFlags::hasInlineColumnAxis): Added. Checks the column axis against the writing
mode.
(WebCore::InheritedFlags::specifiesColumns): Changed to return true if the specified column axis
is the block axis.
(WebCore::InheritedFlags::setColumnAxis): Added this setter.
(WebCore::InheritedFlags::initialColumnAxis): Added. Returns AutoColumnAxis.

  • rendering/style/RenderStyleConstants.h: Added a ColumnAxis enum.
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData): Added m_axis to the initialization list.
(WebCore::StyleMultiColData::operator==): Compare m_axis.

  • rendering/style/StyleMultiColData.h: Added m_axis member variable.

LayoutTests:

  • fast/multicol/block-axis-horizontal-bt.html: Added.
  • fast/multicol/block-axis-horizontal-tb.html: Added.
  • fast/multicol/block-axis-vertical-lr.html: Added.
  • fast/multicol/block-axis-vertical-rl.html: Added.
  • fast/multicol/flipped-blocks-hit-test-expected.txt: Added.
  • fast/multicol/flipped-blocks-hit-test.html: Added.
  • fast/multicol/resources/block-axis.css: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/mac/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/mac/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
10:58 Changeset [98607] by johnnyg@google.com

Unreviewed, adding additional expected failures.

  • platform/chromium/test_expectations.txt:
10:55 Changeset [98606] by mhahnenberg@apple.com

Fixing windows build

Unreviewed build fix

10:54 Changeset [98605] by lforschler@apple.com

Merged r98503.

10:52 Changeset [98604] by lforschler@apple.com

Merge 98304.

10:46 Changeset [98603] by eae@chromium.org

Mac/chromium and plugin fixes

10:42 Changeset [98602] by johnnyg@google.com

Unreviewed, fixing duplicate entries in test expectations.

  • platform/chromium/test_expectations.txt:
10:38 Changeset [98601] by mhahnenberg@apple.com

Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986

Reviewed by Geoffrey Garen.

Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
HAS_MEMBER_NAMED macro to use that template to check if the specified class
does indeed have a method with that name. This mechanism is not currently
used anywhere, but will be in the future when adding virtual methods from
JSObject to the MethodTable.

  • runtime/ClassInfo.h:
10:33 Changeset [98600] by mihnea@adobe.com

[CSSRegions]Flag regions with custom styling
https://bugs.webkit.org/show_bug.cgi?id=70733

Reviewed by David Hyatt.

Region elements that have custom region styling are now marked accordingly.

Source/WebCore:

Test: fast/regions/render-region-custom-style-mark.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkRegionStyle):

  • css/CSSStyleSelector.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::hasCustomRegionStyle):
(WebCore::RenderRegion::setHasCustomRegionStyle):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderFlowThreads):

LayoutTests:

  • fast/regions/render-region-custom-style-mark.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Added.
10:27 Changeset [98599] by carlosgc@webkit.org

[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
https://bugs.webkit.org/show_bug.cgi?id=71027

Reviewed by Martin Robinson.

Fixes windowless plugins in GTK+ port.

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::paint): When scaleFactor is 1, simply
call the paint method that doesn't receive a scaleFactor.

10:24 Changeset [98598] by commit-queue@webkit.org

Unreviewed, rolling out r98556.
http://trac.webkit.org/changeset/98556
https://bugs.webkit.org/show_bug.cgi?id=71031

The test added by the patch doesn't pass on Snow Leopard
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-27

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • editing/TextCheckingHelper.cpp:

(WebCore::checkTextOfParagraph):

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • editing/spelling/spelling-unified-emulation-expected.txt: Removed.
  • editing/spelling/spelling-unified-emulation.html: Removed.
10:22 Changeset [98597] by rniwa@webkit.org

Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
since r98542 regressed it. The failure is tracked by the bug 71032.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:19 Changeset [98596] by reed@google.com

[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):

  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
10:17 Changeset [98595] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for table tests.

  • platform/efl/tables: [...]
10:04 Changeset [98594] by tony@chromium.org

use main/cross instead of logical width/height when talking about flow direction
https://bugs.webkit.org/show_bug.cgi?id=70977

Reviewed by Ojan Vafai.

Flexbox code uses logical in function names to refer to the flow
direction. This is confusing because writing mode also uses logical,
but this is a diffent usage. To avoid confusion, be explicit about
main vs cross axis. Extent is used instead of width/height.

No new tests, just a refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisLengthForChild):
(WebCore::RenderFlexibleBox::crossAxisLength):
(WebCore::RenderFlexibleBox::setCrossExtent):
(WebCore::RenderFlexibleBox::crossExtentForChild):
(WebCore::RenderFlexibleBox::mainExtentForChild):
(WebCore::RenderFlexibleBox::crossAxisExtent):
(WebCore::RenderFlexibleBox::mainAxisExtent):
(WebCore::RenderFlexibleBox::crossAxisContentExtent):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
(WebCore::RenderFlexibleBox::flowAwareLocationForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only

matters in the main axis, there's no reason to deambiguate it here.

(WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always

in the cross axis direction, so don't include that in the method name.

(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Alignment is always

in the cross axis direction, so don't include that in the method name.

(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

  • rendering/RenderFlexibleBox.h:
10:01 Changeset [98593] by mhahnenberg@apple.com

De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • API/JSContextRef.cpp:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::toThisObject):

  • runtime/JSActivation.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::toThisObject):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::toThisObject):

  • runtime/JSObject.h:

(JSC::JSValue::toThisObject):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::toThisObject):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::toThisObject):

  • runtime/JSString.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::toThisObject):

  • runtime/StrictEvalActivation.h:

Source/WebCore:

No new tests.

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::toThisObject):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bridge/NP_jsobject.cpp:

(_NPN_Invoke):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):

Source/WebKit/mac:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

09:41 Changeset [98592] by aroben@apple.com

Windows build fix after r98512

  • html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE

guard.

09:36 Changeset [98591] by lforschler@apple.com

Merge 98394.

09:32 Changeset [98590] by aroben@apple.com

Regenerate WebCore's Localizable.strings file

All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
some strings (which must have been hand-added) got moved to a different part of the file.

  • English.lproj/Localizable.strings:
09:26 Changeset [98589] by lforschler@apple.com

Merge 98369.

09:24 Changeset [98588] by aroben@apple.com

Add WKBundlePageGetBackingScaleFactor

Fixes <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
can't reliably determine the scale factor of snapshots returned via
WKBundlePageCreateSnapshot* API

Reviewed by Sam Weinig.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetBackingScaleFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Added. Calls through to WebPage::deviceScaleFactor.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::deviceScaleFactor):

  • WebProcess/WebPage/WebPage.h:

Added. Calls through to Page::deviceScaleFactor.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
(TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
(TestWebKitAPI::createWindow): Conjure up a window.
(TestWebKitAPI::TEST): Ask the injected bundle code to call the new
WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
factors and when using a custom scale factor, and check that we get those same scale factors
back.

  • TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.

(TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
members.
(TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
(TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
from the page using the new API and send it back.

09:18 Changeset [98587] by philn@webkit.org

Unreviewed, GTK rebaseline.

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
09:16 Changeset [98586] by kerz@chromium.org

Merge 98112 - Fix Windows build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

TBR=simon.fraser@apple.com
Review URL: http://codereview.chromium.org/8399043

09:15 Changeset [98585] by kerz@chromium.org

Merge 98060 - Hidden composited iframes cause infinite loop
https://bugs.webkit.org/show_bug.cgi?id=52655

Source/WebCore:

Reviewed by Darin Adler.

visibility:hidden is problematic for compositing, because it causes
RenderLayers to be removed from the z-order layer tree. This confuses
RenderLayerCompositor in several ways; it never sees these layers
when traversing the tree as it computes compositing requirements, or
rebuilds the layer tree.

This is a particular problem with composited iframes. When an iframe
becomes composited, scheduleSetNeedsStyleRecalc() is called on that
iframe's ownerElement in the parent document. If this happens inside
Document::updateStyleForAllDocuments(), we get into an infinite loop
because notifyIFramesOfCompositingChange() queues up style update as we
bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
never empties out.

This is an initial, conservative fix that doesn't attempt to fix all
the issues with visibility. It changes RenderLayerCompositor to count
the number of compositing RenderLayers, and to not leave compositing
mode if there are any (even if they are hidden, so not hit while
traversing the z-order tree). This avoids the infinite loop.

Test: compositing/visibility/hidden-iframe.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerBecameComposited):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):

LayoutTests:

Reviewed by Darin Adler.

Test with a visibility:hidden iframe, whose subframe becomes composited.

  • compositing/visibility/hidden-iframe-expected.txt: Added.
  • compositing/visibility/hidden-iframe.html: Added.

TBR=simon.fraser@apple.com
Review URL: http://codereview.chromium.org/8399041

09:00 Changeset [98584] by philn@webkit.org

Unreviewed, skipping 2 new failing tests in GTK.

  • platform/gtk/Skipped: Skip

fast/canvas/canvas-composite-image.html and editing/spelling/spelling-unified-emulation.html.

08:47 Changeset [98583] by vsevik@chromium.org

Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
  • inspector/debugger/watch-expressions-panel-switch.html: Added.
  • platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.

BUG=101496
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8401034

08:43 Changeset [98582] by lforschler@apple.com

Merge 95534.

08:41 Changeset [98581] by yurys@chromium.org

2011-10-27 Yury Semikhatsky <yurys@chromium.org>

Rebaseline tables/mozilla_expected_failures/bugs/bug14007-2.html after r98542.

  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
08:24 Changeset [98580] by commit-queue@webkit.org

Microdata: Add test cases for itemscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=71014

Patch by Arko Saha <arko@motorola.com> on 2011-10-27
Reviewed by Ryosuke Niwa.

  • fast/dom/MicroData/itemscope-attribute-test-expected.txt: Added.
  • fast/dom/MicroData/itemscope-attribute-test.html: Added.
  • fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Added.
  • fast/dom/MicroData/itemscope-must-be-read-write.html: Added.
08:19 Changeset [98579] by commit-queue@webkit.org

[Qt][WK2]Add setViewportSize API to WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=71006

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

Fixed layout rendering needs the viewport size information on the WebProcess
side to be able to do viewport attribute calculations.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewportSize):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::viewportSize):

  • WebProcess/WebPage/WebPage.messages.in:
08:14 Changeset [98578] by dcheng@chromium.org

Clean up MicroDataItemValue to use const String& instead of String
https://bugs.webkit.org/show_bug.cgi?id=70978

Reviewed by Tony Chang.

  • html/MicroDataItemValue.cpp:

(WebCore::MicroDataItemValue::MicroDataItemValue):

  • html/MicroDataItemValue.h:
08:12 Changeset [98577] by yurys@chromium.org

2011-10-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
08:09 Changeset [98576] by kbalazs@webkit.org

MiniBrowser crashes when started with 0 arguments

Rubber-stamped by Simon Hausmann.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):
Fix typo error.

08:06 Changeset [98575] by commit-queue@webkit.org

[WebSocket] update pywebsocket to 0.7.
https://bugs.webkit.org/show_bug.cgi?id=70992

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-10-27
Reviewed by Kent Tamura.

pywebsocket 0.7 fixed the bug on dual stack support on OS X.

  • Scripts/webkitpy/thirdparty/init.py:
08:05 Changeset [98574] by commit-queue@webkit.org

Fix a small bug in callOperation after r98431
https://bugs.webkit.org/show_bug.cgi?id=70984

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-27
Reviewed by Geoffrey Garen.

TrustedImmPtr is not expecting "int" type parameters.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

08:03 Changeset [98573] by antti@apple.com

Use StringHasher to generate the matched declaration cache hash
https://bugs.webkit.org/show_bug.cgi?id=71012

Reviewed by Kenneth Rohde Christiansen and Andreas Kling.

It is faster and better than the current custom function.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::computeDeclarationHash):

07:51 Changeset [98572] by haraken@chromium.org

Refactor OptionsObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=70572

Reviewed by Adam Barth.

For example, OptionsObject::getKeyBool() is an alias of
OptionsObject::getKeyValue(const String& key, bool& value).
We should remove OptionsObject::getKeyXXXX() (XXXX is some specific type)
and unify them into OptionsObject::get(const String& key, XXXX& value).
c.f. Corresponding JSC methods are unified into
JSDictionary::convertValue(JSC::ExecState*, JSC::JSValue, XXXX&).

The result of git diff is weird, but this patch is making just the following changes:

  • Replaced getKeyBool(), getKeyInt32(), getKeyDouble() and getKeyString() with get().
  • Renamed getKeyStringWithUndefinedOrNullCheck() to getWithUndefinedOrNullCheck().
  • Removed getKeyDOMStringList() and getKeyKeyRange(), since these are not used.
  • Move definitions of get() from .h to .cpp.

No new tests. No change in behavior.

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get): Renamed from getKeyValue().
(WebCore::OptionsObject::getKey): No change to this method. git diff seems to misunderstand as if it is modified.
(WebCore::OptionsObject::getKeyDOMStringList): Removed, since no one is using it.
(WebCore::OptionsObject::getKeyKeyRange): Ditto.
(WebCore::OptionsObject::getWithUndefinedOrNullCheck): No change to this method. git diff seems to misunderstand as if it is modified.

  • bindings/v8/OptionsObject.h: Moved definitions of get() to OptionsObject.cpp
  • bindings/v8/custom/V8EventConstructors.cpp:
  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback): Replaced getKeyXXXX() to get();

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Ditto.

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Ditto.

07:51 Changeset [98571] by lforschler@apple.com

Merge fix for https://bugs.webkit.org/show_bug.cgi?id=70976

07:36 Changeset [98570] by alexis.menard@openbossa.org

[Qt][WK2] Move the C API callback setup out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=70965

Reviewed by Andreas Kling.

Move out the setup of C API callback into ClientImpl file
so that QtWebPageProxy will be less polluted.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didSameDocumentNavigationForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(qt_wk_decidePolicyForNavigationAction):
(qt_wk_decidePolicyForResponse):
(setupPageLoaderClient):
(setupPageUiClient):
(setupPagePolicyClient):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::viewInterface):

07:33 Changeset [98569] by reed@google.com

need to rebaseline after skia 2527 lands, fixing an off-by-1 bug in blending (with alpha==0)
https://bugs.webkit.org/show_bug.cgi?id=70963

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
07:26 Changeset [98568] by commit-queue@webkit.org

StyleSheet.parentStyleSheet does not work.
https://bugs.webkit.org/show_bug.cgi?id=70956

Patch by Andreas Kling <kling@webkit.org> on 2011-10-27
Reviewed by Antti Koivisto.

Source/WebCore:

Since StyleSheet is only ever parented by a CSSRule, we need
to go through that rule when resolving the StyleSheet's parent.

Test: fast/css/stylesheet-parentStyleSheet.html

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::parentStyleSheet):

LayoutTests:

  • fast/css/stylesheet-parentStyleSheet-expected.txt: Added.
  • fast/css/stylesheet-parentStyleSheet.html: Added.
07:23 Changeset [98567] by commit-queue@webkit.org

Disable blending when drawing opaque layers
https://bugs.webkit.org/show_bug.cgi?id=70085

Patch by Antoine Labour <piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.

Covered by compositing/ tests, as well as a new unit test:
CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::opaque):

07:03 Changeset [98566] by commit-queue@webkit.org

Chromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by https://bugs.webkit.org/attachment.cgi?id=112342
https://bugs.webkit.org/show_bug.cgi?id=70953

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-27
Reviewed by David Levin.

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::hasPendingActivity):

07:00 Changeset [98565] by yurys@chromium.org

2011-10-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
06:35 Changeset [98564] by commit-queue@webkit.org

make lion observe MAC lines in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=70941

Patch by Elliot Poger <epoger@google.com> on 2011-10-27
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
06:35 Changeset [98563] by commit-queue@webkit.org

IndexedDB: Passing empty array to IDBDatabase.transaction should raise exception
https://bugs.webkit.org/show_bug.cgi?id=70251

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-27
Reviewed by Adam Barth.

Source/WebCore:

IDBDatabase.transaction() supported being called with an empty array to
lock all object stores. Support for this was rejected from inclusion in
the IDB spec due to performance concerns. This patch removes that
functionality.

A special case in the spec (passing a string instead of an array) worked
in WebKit accidentally, by resolving the string to an empty array. This
needed explicit support. Support for DOMString[] is added to the binding
code generators (reliant on DOMStringList) to ensure JS arrays are not
coerced to DOMStrings. This matches the proposed IDL.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression):
(GetNativeType):
(JSValueToNative):
(IsArrayType):

  • bindings/scripts/IDLStructure.pm:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.h:

(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.idl:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::objectStore):

LayoutTests:

Many tests relied on the non-specified behavior of passing an empty
array into IDBDatabase.transaction() to include all object stores in
scopes. Worse, non-arrays would be treated as empty arrays, and hence
"just worked".

  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/tutorial.html:
06:31 Changeset [98562] by commit-queue@webkit.org

Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-27
Reviewed by David Levin.

  • features.gypi:
06:22 Changeset [98561] by commit-queue@webkit.org

Crash due to nested first-letter selectors
https://bugs.webkit.org/show_bug.cgi?id=70457

Source/WebCore:

Now only the lowest-level first-letter pseudostyle will be applied to
a given piece of text. Previously the last renderer to have layout
done would have its pseudostyle applied, no matter where it was in the
tree.

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.

  • renderer/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter): Use the pseudostyle from
the lowest level node to have one

LayoutTests:

Adding layout test for nested first-letter pseudostyles causing a crash.

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.

  • fast/css/nested-first-letter-with-float-crash.html: Added
  • fast/css/nested-first-letter-with-float-crash-expected.txt: Added
06:19 Changeset [98560] by abecsi@webkit.org

[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

This fixes the commonview tests that were failing
after r98447.
WebViewAbstraction must forward actions to both
the TouchWebView and the DesktopWebView.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

06:08 BuildingQt5OnHarmattan edited by abecsi@webkit.org
(diff)
06:07 Changeset [98559] by jknotten@chromium.org

[Chromium] Allow DRT to be built without notifications enabled.
https://bugs.webkit.org/show_bug.cgi?id=70919

Reviewed by Tony Gentilcore.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):

06:05 Changeset [98558] by commit-queue@webkit.org

[Qt][WK2]Content size changed event does not require viewport attribute calculation.
https://bugs.webkit.org/show_bug.cgi?id=70920

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

Remove unnecessary recalculation of viewport attributes.

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::contentSizeChanged):

06:02 Changeset [98557] by abecsi@webkit.org

Fix the build if NO_LISTBOX_RENDERING is enabled
https://bugs.webkit.org/show_bug.cgi?id=71009

Reviewed by Kenneth Rohde Christiansen.

If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the
HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533.
Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup.

This is covered by:
Source/WebCore/manual-tests/no-listbox-rendering.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxSelectItem): Reintroduce.

  • html/HTMLSelectElement.h:
05:52 Changeset [98556] by commit-queue@webkit.org

Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-27
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

  • editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):

Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.

  • testing/Internals.cpp:

(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

  • editing/spelling/spelling-unified-emulation-expected.txt: Added.
  • editing/spelling/spelling-unified-emulation.html: Added.
05:37 Changeset [98555] by philn@webkit.org

Unreviewed, remove those un-needed files committed by error in
r98554.

  • platform/audio/gstreamer/#AudioFileReaderGStreamer.h#: Removed.
  • platform/audio/gstreamer/.#AudioFileReaderGStreamer.h: Removed.
05:31 Changeset [98554] by philn@webkit.org

[GStreamer] WebAudio AudioFileReader implementation
https://bugs.webkit.org/show_bug.cgi?id=69834

.:

Patch by Philippe Normand <pnormand@igalia.com> and Zan Dobersek <zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.

  • configure.ac: Check for libfftw and gstreamer-audio if WebAudio

build is enabled.

Source/WebCore:

Patch by Philippe Normand <pnormand@igalia.com> and Zan Dobersek <zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.

Basic FileReader implementation, supporting one or 2 audio
channels. An empty AudioDestination is also provided, its complete
implementation is handled in bug 69835.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp: Added.

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::start):
(WebCore::AudioDestinationGStreamer::stop):

  • platform/audio/gstreamer/AudioDestinationGStreamer.h: Added.

(WebCore::AudioDestinationGStreamer::isPlaying):
(WebCore::AudioDestinationGStreamer::sampleRate):
(WebCore::AudioDestinationGStreamer::sourceProvider):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: Added.

(WebCore::getGStreamerAudioCaps):
(WebCore::getFloatFromByteReader):
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkNewBufferCallback):
(WebCore::messageCallback):
(WebCore::onGStreamerDeinterleavePadAddedCallback):
(WebCore::onGStreamerDeinterleaveReadyCallback):
(WebCore::onGStreamerDecodebinPadAddedCallback):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::handleBuffer):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::deinterleavePadsConfigured):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/gtk/AudioBusGtk.cpp: Added.

(WebCore::AudioBus::loadPlatformResource):

Source/WebKit/gtk:

Reviewed by Martin Robinson.

  • GNUmakefile.am: Link against libfftw.

Source/WebKit2:

Reviewed by Martin Robinson.

  • GNUmakefile.am: Link against libfftw.
05:23 Changeset [98553] by philn@webkit.org

Unreviewed, GTK rebaseline after r98507.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
05:19 Changeset [98552] by philn@webkit.org

Unreviewed, rebaseline of the bindings tests after r98501 which
removed getOwnPropertySlotVirtual.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
04:51 Changeset [98551] by vsevik@chromium.org

http/tests/inspector/search/search-in-resources.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=70993

Reviewed by Pavel Feldman.

  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest.InspectorTest.dumpSearchResults):

04:50 Changeset [98550] by loislo@chromium.org

WebInspector: View throughs the exception when a child view are removed by removeChildren call.
https://bugs.webkit.org/show_bug.cgi?id=71002

Another followup fix after r98225.

Reviewed by Pavel Feldman.

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._queryFinished):
(WebInspector.DatabaseTableView.prototype._queryError):

04:49 Changeset [98549] by vsevik@chromium.org

Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
https://bugs.webkit.org/show_bug.cgi?id=70906

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/selected-call-frame-after-formatting-source.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):

LayoutTests:

  • inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Added.
  • inspector/debugger/selected-call-frame-after-formatting-source.html: Added.
04:47 Changeset [98548] by steveblock@google.com

Numerous debug build fixes

Unreviewed build fix.

No new tests, buuld fix only.

  • loader/icon/IconDatabase.cpp: urlForLogging() is used by both LOG() and LOG_ERROR()
  • storage/AbstractDatabase.h: databaseDebugName() is used by both LOG() and LOG_ERROR()
  • storage/DatabaseTask.cpp: m_complete is only available when !LOG_DISABLED
04:43 Changeset [98547] by jocelyn.turcotte@nokia.com

[Qt] Improve command line arguments handling for MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=70616

Reviewed by Kenneth Rohde Christiansen.

  • Use two dashes for word arguments.
  • Return with an error when an unsupported argument is given.
  • Allow the URL to be placed before option arguments.
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/utils.cpp:

(takeOptionFlag):
(takeOptionValue):

  • MiniBrowser/qt/utils.h:
04:36 Changeset [98546] by vsevik@chromium.org

Web Inspector: Refactor ScriptsPanel so that ConsoleView does not depend on it.
https://bugs.webkit.org/show_bug.cgi?id=70899

Moved methods used in console view to DebuggerPresentationModel.
Changed debuggerPaused handler logic so that selectedCallFrame is never null when debugger is paused.

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._updateCallFrame):

04:30 Changeset [98545] by vsevik@chromium.org

Web Inspector: Add support for advanced search in content scripts.
https://bugs.webkit.org/show_bug.cgi?id=70923

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsSearchScope.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

04:30 Changeset [98544] by ossy@webkit.org

[Qt] NRWT doesn't work on qt-mac platform
https://bugs.webkit.org/show_bug.cgi?id=64445

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.

(useNewRunWebKitTests):

  • Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
02:55 Changeset [98543] by loislo@chromium.org

Unreviewed one line fix for DOMStorageItemsView.
It have to use this.detachChildViews instead of this.element.removeChildren after r98225.

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype.update):

02:39 Changeset [98542] by antti@apple.com

Matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=70931

Reviewed by Darin Adler.

Sets of style declarations are applied repeatedly for different elements when calculating the document style.
The same set of applied declarations results in the same non-inherited style, independent of the element and
its context. We can use this to build a cache to speed up style applying and to share more style data for
reduced memory usage.

The patch reduces RenderStyle memory use ~40% and total memory use by ~7% over HTML5 spec load.
It is also ~10% progression in PerformanceTests/Parser/html5-full-render.html.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::isInherited):

We need to know which properties are inherited, something we didn't have available so far.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

A set of declarations is only cacheable if it contains no element specific style. This way we
don't need to worry about cache invalidation. The whole style selector is reconstructed if the
stylesheets change, invalidating the cache too.


(WebCore::CSSStyleSelector::styleForElement):

Trigger image loads bit earlier so cached style will have them too.


(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):

Allow skipping over non-inherited properties.


(WebCore::CSSStyleSelector::computeDeclarationHash):

Hash function for declartion cache lookups.


(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):

Lookup from cache.


(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):

Add to cache.


(WebCore::CSSStyleSelector::applyMatchedDeclarations):

If cached style is found, copy the non-inherited properties from the cache and apply the inherited properties (if any) only.


Font and zoom changes force full applying as they can affect values of other properties (this can be relaxed later).


  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::MatchResult::MatchResult):

Cacheability bit.


  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::copyNonInheritedFrom):

  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::copyNonInheritedFrom):

  • rendering/style/SVGRenderStyle.h:


Functions for assembling RenderStyle from non-inherited parts of the cached style.

02:38 BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com
(diff)
02:37 Changeset [98541] by caseq@chromium.org

Web Inspector: [Extensions API] add ignoreCache flag to options of inspectedWindow.reload()
https://bugs.webkit.org/show_bug.cgi?id=70926

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/extensions-ignore-cache.html

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onReload):

  • inspector/front-end/externs.js:

():

LayoutTests:

  • http/tests/inspector/extensions-ignore-cache-expected.txt: Added.
  • http/tests/inspector/extensions-ignore-cache.html: Added.
02:33 Changeset [98540] by rgabor@webkit.org

Unreviewed, fix typo in skiplist.

  • platform/qt/Skipped:
02:29 BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com
(diff)
01:54 Changeset [98539] by rgabor@webkit.org

Unreviewed. Add bugzilla link to skipped test.

  • platform/qt/Skipped:
00:53 Changeset [98538] by yurys@chromium.org

inspector/storage-panel-dom-storage.html has results platform dependant?
https://bugs.webkit.org/show_bug.cgi?id=70985

The items set in DOM storage is unsorted and as result the test is platform dependant.
We will sort it before the dumping.

Patch by Ilya Tikhonovsky <loislo@chromium.org> on 2011-10-27
Reviewed by Yury Semikhatsky.

  • inspector/storage-panel-dom-storage-expected.txt:
  • inspector/storage-panel-dom-storage.html:
  • platform/chromium/test_expectations.txt:

10/26/11:

23:50 Changeset [98537] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
23:37 Changeset [98536] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test_expectations.

inspector/storage-panel-dom-storage.html has results platform dependant?
https://bugs.webkit.org/show_bug.cgi?id=70985

  • platform/chromium/test_expectations.txt:
23:27 Changeset [98535] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expecatations for search-in-resources.html

http/tests/inspector/search/search-in-resources.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=70993

  • http/tests/inspector/search/search-in-resources-expected.txt:
  • platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Removed.
22:16 Changeset [98534] by rniwa@webkit.org

Chromium Windows and Linux rebaselines.

  • platform/chromium-linux/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-linux/platform/mac/editing: Added.
  • platform/chromium-linux/platform/mac/editing/pasteboard: Added.
  • platform/chromium-linux/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
  • platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
21:56 Changeset [98533] by rniwa@webkit.org

Console message in copy-standalone-image-crash.html bleeds into the result of copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=70957

Reviewed by Ojan Vafai.

The bug was caused by the delayed hideDiv call in a mousedown event listener.
Fixed the bug by not attaching this event listener inside DRT or TestRunner.

  • editing/pasteboard/copy-standalone-image-crash.html:
18:51 Changeset [98532] by jchaffraix@webkit.org

Massive gardening.

  • platform/chromium/test_expectations.txt: Lots of tests were regularly failing

or timing out but were not marked. Added them as they were consistently flaky.

18:12 Changeset [98531] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-linux/http/tests/inspector: Added.
  • platform/chromium-linux/http/tests/inspector/search: Added.
  • platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Added.

Rebaselined (looks like the urls are sorted differently on Linux).

  • platform/chromium/test_expectations.txt: Marked inspector/storage-panel-dom-storage.html

as TEXT as it started failing on the bots.

17:43 Changeset [98530] by sfalken@apple.com

ResourceError doesn't support custom domains on Windows
https://bugs.webkit.org/show_bug.cgi?id=70983
<rdar://problem/10352145>

Reviewed by Oliver Hunt.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformLazyInit): Add fallback case for unknown error types.

17:29 Changeset [98529] by mitz@apple.com

Fix a slider thumb rendering regression in Chromium on OS X in r98520.

Reviewed by Anders Carlsson.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Reverted the changes to the Chromium code path.

17:26 Changeset [98528] by leviw@chromium.org

Fixing FixedPoint's flooredIntSize, adding an adjustedBorderBoxRectForCellRounding method to get Table border painting correct, and fixing float and linebox layout since my last checkin.

17:21 Changeset [98527] by jchaffraix@webkit.org

Unreviewed, rolling out r98486.
http://trac.webkit.org/changeset/98486
https://bugs.webkit.org/show_bug.cgi?id=70748

Broke Chromium's test_expectation.txt

Source/WebCore:

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):

  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
17:20 Changeset [98526] by ap@apple.com

REGRESSION (r98153): Safari crashes if WebProcess crashed during printing
https://bugs.webkit.org/show_bug.cgi?id=70982

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Null check page, it may be invalid already.
17:19 Changeset [98525] by oliver@apple.com

Restore structure-clearing behaviour of allocateCell<>
https://bugs.webkit.org/show_bug.cgi?id=70976

Reviewed by Geoffrey Garen.

This restores the logic that allows the markstack to filter
live objects that have not yet been initialised.

  • runtime/JSCell.h:

(JSC::JSCell::clearStructure):

Validation-safe method to clear a cell's structure.

(JSC::allocateCell):

Call the above method.

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

Don't visit cells that haven't been initialised.

15:42 Changeset [98524] by jchaffraix@webkit.org

Unreviewed trivial renaming.

  • fast/js/dfg-intrinsic-osr-exit-expected.html: Removed.
  • fast/js/dfg-intrinsic-osr-exit-expected.txt: Copied from LayoutTests/fast/js/dfg-intrinsic-osr-exit-expected.html.
15:26 Changeset [98523] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

storage/domstorage/events/basic-setattribute.html is a flaky crasher.

15:12 Changeset [98522] by jamesr@google.com

Merge 98112 - Fix Windows build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/8363033

15:11 Changeset [98521] by jamesr@google.com

Merge 98060 - Hidden composited iframes cause infinite loop
https://bugs.webkit.org/show_bug.cgi?id=52655

Source/WebCore:

Reviewed by Darin Adler.

visibility:hidden is problematic for compositing, because it causes
RenderLayers to be removed from the z-order layer tree. This confuses
RenderLayerCompositor in several ways; it never sees these layers
when traversing the tree as it computes compositing requirements, or
rebuilds the layer tree.

This is a particular problem with composited iframes. When an iframe
becomes composited, scheduleSetNeedsStyleRecalc() is called on that
iframe's ownerElement in the parent document. If this happens inside
Document::updateStyleForAllDocuments(), we get into an infinite loop
because notifyIFramesOfCompositingChange() queues up style update as we
bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
never empties out.

This is an initial, conservative fix that doesn't attempt to fix all
the issues with visibility. It changes RenderLayerCompositor to count
the number of compositing RenderLayers, and to not leave compositing
mode if there are any (even if they are hidden, so not hit while
traversing the z-order tree). This avoids the infinite loop.

Test: compositing/visibility/hidden-iframe.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerBecameComposited):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):

LayoutTests:

Reviewed by Darin Adler.

Test with a visibility:hidden iframe, whose subframe becomes composited.

  • compositing/visibility/hidden-iframe-expected.txt: Added.
  • compositing/visibility/hidden-iframe.html: Added.

TBR=simon.fraser@apple.com
Review URL: http://codereview.chromium.org/8403008

14:41 Changeset [98520] by mitz@apple.com

<rdar://problem/10350775> REGRESSION (r97032): Slider thumb is not drawn
https://bugs.webkit.org/show_bug.cgi?id=70891

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView): Set the WebCoreFlippedView’s size, because NSSliderCell
always shrinks the slider thumb to fit in the control view’s bounds.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Removed workaround code no longer needed after
r97032.

14:33 Changeset [98519] by lforschler@apple.com

Versioning.

14:32 Changeset [98518] by caryclark@google.com

Unreviewed gardening: sixth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 674 of 680 files for brevity.]

  • platform/chromium-mac-leopard/svg/as-background-image: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Added.

...

  • platform/chromium-mac-leopard/tables/mozilla/core/margins-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_col_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
14:13 Changeset [98517] by fpizlo@apple.com

REGRESSION (r97030): Cannot log in to progressive.com
https://bugs.webkit.org/show_bug.cgi?id=70094

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

  • fast/js/dfg-intrinsic-osr-exit-expected.html: Added.
  • fast/js/dfg-intrinsic-osr-exit.html: Added.
  • fast/js/script-tests/dfg-intrinsic-osr-exit.js: Added.

(foo):

14:09 Changeset [98516] by lforschler@apple.com

New tag.

13:43 Changeset [98515] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for CSS3 tests.

  • platform/efl/css3: [...]
13:20 Changeset [98514] by crogers@google.com

Add chromium bridging for AudioSourceProviderClient and setFormat() method so we can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70650

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebAudioSourceProvider.h:

(WebKit::WebAudioSourceProvider::setClient):

  • public/WebAudioSourceProviderClient.h: Copied from Source/WebKit/chromium/public/WebAudioSourceProvider.h.

(WebKit::WebAudioSourceProviderClient::~WebAudioSourceProviderClient):

  • public/WebMediaPlayer.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::setFormat):

  • src/WebMediaPlayerClientImpl.h:

(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::~AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::wrap):

13:19 Changeset [98513] by jeffm@apple.com

WebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=70943

If WebKitOmitPDFSupport pref is set, disable both the new "plug-in" for subframes and the PDFKit-based support for the main frame only.

Reviewed by Alexey Proskuryakov.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getPlugins): Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.

  • UIProcess/WebContext.h: Added omitPDFSupport().


  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType): Don't show PDFs if WebKitOmitPDFSupport is set.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::omitPDFSupport): Added.

12:57 Changeset [98512] by crogers@google.com

Add AudioSourceProviderClient and setFormat() method so we can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70155

Reviewed by Eric Carlson.

No new tests. There isn't yet an implementation to test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::setAudioSourceNode):
Let MediaPlayer know about the MediaElementAudioSourceNode so it can callback with audio stream format information.

  • platform/audio/AudioSourceProvider.h:

(WebCore::AudioSourceProvider::setClient):
Add abstract setClient() method so a client may know about stream format information when it becomes available.

  • platform/audio/AudioSourceProviderClient.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.

(WebCore::AudioSourceProviderClient::~AudioSourceProviderClient):
Add abstract class AudioSourceProviderClient which implements setFormat() to receive audio stream format information.

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):
Concrete implementation of setFormat() so MediaElementAudioSourceNode can create necessary audio converters.

  • webaudio/MediaElementAudioSourceNode.h:

Make MediaElementAudioSourceNode implement AudioSourceProviderClient so it can get audio stream format information
when its setFormat() method is called.

12:55 Changeset [98511] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for CSS2.1 tests.

  • platform/efl/css2.1: [...]
12:06 Changeset [98510] by rniwa@webkit.org

Chromium Mac rebaseline.

  • platform/chromium-mac-leopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
12:01 Changeset [98509] by weinig@apple.com

Add initial setting to WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=70942

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WKBrowsingContextGroupTest.

  • UIProcess/API/mac/WKBrowsingContextGroup.h:
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup isJavaScriptEnabled]):
(-[WKBrowsingContextGroup setJavaScriptEnabled:]):
Add setting to enabled/disable javascript. By default it is enabled.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.

Add basic test that setting the javaScriptEnabled setting takes. It is not
possible to test its effect quite yet.

11:58 Changeset [98508] by jchaffraix@webkit.org

Unreviewed, rolling out r98483.
http://trac.webkit.org/changeset/98483
https://bugs.webkit.org/show_bug.cgi?id=47156

Change is causing some crashes and ASSERTs.

Source/WebCore:

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupImageForSize):
(WebCore::CachedImage::lookupImageForRenderer):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::computeIntrinsicDimensions):
(WebCore::CachedImage::createImage):

  • loader/cache/CachedImage.h:
  • page/ChromeClient.h:
  • rendering/ImageBySizeCache.cpp:

(WebCore::ImageBySizeCache::addClient):
(WebCore::ImageBySizeCache::removeClient):
(WebCore::ImageBySizeCache::imageForSize):
(WebCore::ImageBySizeCache::sizeForClient):

  • rendering/ImageBySizeCache.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):

  • rendering/RenderImage.h:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::setContainerSizeForRenderer):

  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderImageResourceStyleImage.h:

(WebCore::RenderImageResourceStyleImage::image):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::computePreferredLogicalWidths):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
(WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.h:

(WebCore::StyleGeneratedImage::setContainerSizeForRenderer):

  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::setContainerSizeForRenderer):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicWidth):
(WebCore::RenderSVGRoot::computeIntrinsicHeight):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paint):
(WebCore::RenderSVGRoot::calcViewport):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp:

(WebCore::SVGLength::determineViewport):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::relativeWidthValue):
(WebCore::SVGSVGElement::relativeHeightValue):
(WebCore::SVGSVGElement::currentViewBoxRect):

  • svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
(WebCore::SVGSVGElement::hasSetContainerSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::size):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::dataChanged):

  • svg/graphics/SVGImage.h:

LayoutTests:

  • css2.1/20110323/background-intrinsic-001.htm: Removed.
  • css2.1/20110323/background-intrinsic-002.htm: Removed.
  • css2.1/20110323/background-intrinsic-003.htm: Removed.
  • css2.1/20110323/background-intrinsic-004.htm: Removed.
  • css2.1/20110323/background-intrinsic-005.htm: Removed.
  • css2.1/20110323/background-intrinsic-006.htm: Removed.
  • css2.1/20110323/background-intrinsic-007.htm: Removed.
  • css2.1/20110323/background-intrinsic-008.htm: Removed.
  • css2.1/20110323/background-intrinsic-009.htm: Removed.
  • css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-height.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-none.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width-height.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-height.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-none.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width-height.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width.svg: Removed.
  • fast/backgrounds/size/contain-and-cover-zoomed.html: Removed.
  • fast/images/percent-height-image-expected.txt:
  • fast/images/percent-height-image.html:
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac/css1/text_properties/vertical_align-expected.txt:
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/mac/fast/block/float/015-expected.png:
  • platform/mac/fast/block/float/015-expected.txt:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Removed.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Removed.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.png: Removed.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Removed.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Removed.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/mac/svg/as-image/same-image-two-instances-expected.png: Removed.
  • platform/mac/svg/as-image/same-image-two-instances-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png:
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • svg/as-background-image/background-image-preserveaspectRatio-support.html: Removed.
  • svg/as-background-image/background-image-tiled.html: Removed.
  • svg/as-background-image/resources/construction-tape.svg: Removed.
  • svg/as-background-image/resources/hearts.svg:
  • svg/as-background-image/same-image-two-instances-background-image.html: Removed.
  • svg/as-image/img-preserveAspectRatio-support-1.html: Removed.
  • svg/as-image/resources/circle-default-meet.svg: Removed.
  • svg/as-image/resources/circle-default-none.svg: Removed.
  • svg/as-image/resources/circle-default-slice.svg: Removed.
  • svg/as-image/resources/circle-nosize.svg: Removed.
  • svg/as-image/resources/circle-viewbox-default.svg: Removed.
  • svg/as-image/resources/circle-viewbox-meet.svg: Removed.
  • svg/as-image/resources/circle-viewbox-none.svg: Removed.
  • svg/as-image/resources/circle-viewbox-slice.svg: Removed.
  • svg/as-image/resources/green-relative-size-rect.svg:
  • svg/as-image/same-image-two-instances.html: Removed.
  • svg/as-image/svg-as-relative-image-with-explicit-size.html: Removed.
  • svg/as-image/svg-image-change-content-size.xhtml: Removed.
  • svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Removed.
  • svg/zoom/page/zoom-background-image-tiled.html: Removed.
  • svg/zoom/page/zoom-background-images.html: Removed.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Removed.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Removed.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Removed.
11:51 Changeset [98507] by eric.carlson@apple.com

Constructors for all TextTrack interfaces should be available on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=70734

Source/WebCore:

Reviewed by Sam Weinig.

window-properties-expected.txt and global-constructors-expected.txt updated for this change.

  • page/DOMWindow.idl: Add HTMLTrackElement, TextTrack, and TextTrackCueList.

LayoutTests:

Reviewed by Sam Weinig.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
11:41 Changeset [98506] by aestes@apple.com

REGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
https://bugs.webkit.org/show_bug.cgi?id=70872

Reviewed by Eric Carlson.

r93108 added a call to HTMLMediaElement::configureMediaControls() in
HTMLMediaElement::prepareForLoad(), which creates shadow DOM media
controls and is only appropriate to call when media elements are not
backed by plug-in proxies.

Resolve this by refactoring configureMediaControls() to do the right
thing for the plug-in proxy case by calling MediaPlayer::setControls().

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged): Call
configureMediaControls() directly and remove the preprocessor
conditional.
(WebCore::HTMLMediaElement::configureMediaControls): Call
MediaPlayer::setControls() if PLUGIN_PROXY_FOR_VIDEO is enabled.

11:36 Changeset [98505] by jonlee@apple.com

selectedIndex gets set from -1 to 0 when modifying options
https://bugs.webkit.org/show_bug.cgi?id=70547
<rdar://problem/8388856>

Reviewed by Darin Adler.

Source/WebCore:

Changing the text causes a recalculation of the list items, which in the menu list case
forces the first element to be selected. We check the value of the selected option prior,
and restore it if it differs.

Test: fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

  • html/HTMLSelectElement.h: promote usesMenuList() from private to public for use by HTMLOptionElement

LayoutTests:

The added tests set the selected index to either -1 or 1 (a legitimate value), and then change
the text, value, and label of the option. In all cases, the selected index should remain unchanged.

  • fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html: Added.
11:29 Changeset [98504] by zherczeg@webkit.org

Add new CSS escape sequence parsing tests
https://bugs.webkit.org/show_bug.cgi?id=70909

Reviewed by Darin Adler.

Test escape various sequences terminated by \n \f \r and \r\n.

  • fast/css/parsing-css-escapes-expected.txt: Added.
  • fast/css/parsing-css-escapes.html: Added.
11:11 Changeset [98503] by ap@apple.com

Embedded PDFs should be known to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=70864

Reviewed by Darin Adler.

  • WebProcess/Plugins/Plugin.h: Plugin stream load notifications now contain a suggested file name, in case the plug-in wants to save the file properly.
  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::addArchiveResource): Add the PDF as resource in DocumentLoader. (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Call addArchiveResource. (WebKit::BuiltInPDFView::initialize): We need to remember source URL to create a resource for that. The URL needs to match one in HitTestResult, so we can't use response URL. (WebKit::BuiltInPDFView::streamDidReceiveResponse): Remember suggested file name, so that we could put it in archive resource later. (WebKit::BuiltInPDFView::manualStreamDidReceiveResponse): Ditto.
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::streamDidReceiveResponse): (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse): Pass an empty string for suggested file name. No plug-in that runs in a separate process cares about it, so it's not sent to the plugin process.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::streamDidReceiveResponse): (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Updated for new signatures.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::streamDidReceiveResponse): (WebKit::PluginProxy::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/PluginProxy.h: Updated for new signatures.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::Stream::didReceiveResponse): (WebKit::PluginView::manualLoadDidReceiveResponse): Pass suggested file name to plug-in, in case the plug-in wants to save the file properly.
10:56 Changeset [98502] by rniwa@webkit.org

Chromium Mac editing test rebaseline.

  • platform/chromium-cg-mac-leopard/platform/mac/editing: Added.
  • platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard: Added.
  • platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/security: Added.
  • platform/chromium-mac-leopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac: Added.
  • platform/chromium-mac-leopard/platform/mac/editing: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/pasteboard: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-snowleopard/http: Added.
  • platform/chromium-mac-snowleopard/http/tests: Added.
  • platform/chromium-mac-snowleopard/http/tests/security: Added.
  • platform/chromium-mac-snowleopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform: Added.
  • platform/chromium-mac-snowleopard/platform/mac: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:55 Changeset [98501] by mhahnenberg@apple.com

Remove getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=70741

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

(JSC::DebuggerActivation::getOwnPropertySlot):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:
  • runtime/DatePrototype.h:

(JSC::DatePrototype::create):

  • runtime/ErrorPrototype.cpp:
  • runtime/ErrorPrototype.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::hasOwnProperty):

  • runtime/JSObject.h:

(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • runtime/JSString.h:
  • runtime/MathObject.cpp:
  • runtime/MathObject.h:

(JSC::MathObject::create):

  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::createStructure):

  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:
  • runtime/StringPrototype.h:

Source/JavaScriptGlue:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::returnValue):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit2:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
10:54 Changeset [98500] by alex@webkit.org

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] Update NEWS and configure.ac for 1.7.1 release
https://bugs.webkit.org/show_bug.cgi?id=70932

Reviewed by Martin Robinson.

  • configure.ac: Bumped version number.

2011-10-26 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Update NEWS and configure.ac for 1.7.1 release
https://bugs.webkit.org/show_bug.cgi?id=70932

Reviewed by Martin Robinson.

  • NEWS: Added release notes.
10:53 Changeset [98499] by ojan@chromium.org

Fix typo. The expected results don't change.

  • fast/writing-mode/borders.html:
  • fast/writing-mode/margins.html:
10:45 Changeset [98498] by alex@webkit.org

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • GNUmakefile.am: Added WebKit2 compilation to the distcheck.
  • configure.ac: Removed WebKit2 doc generation for the moment.

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add MemoryStatistics.h to the sources list.

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add a bunch of missing files from API and sources, also include more files in the EXTRA_DIST.
  • UIProcess/API/gtk/docs/GNUmakefile.am: Add the version.xml to the cleaning section.

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • WebKitTestRunner/GNUmakefile.am: Add missing files to the sources and EXTRA_DIST.
10:40 Changeset [98497] by alex@webkit.org

2011-10-26 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Fix gtk-doc warnings and style issues in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=70930

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
  • UIProcess/API/gtk/WebKitSettings.cpp: (webkit_settings_class_init):
  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
10:35 Changeset [98496] by alex@webkit.org

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix distcheck compilation
https://bugs.webkit.org/show_bug.cgi?id=70921

Add EventTargetFactory.in to the dist files, required after
r98388.

Reviewed by Martin Robinson.

  • GNUmakefile.am:

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix distcheck compilation
https://bugs.webkit.org/show_bug.cgi?id=70921

Add new files required by doc compilation to the clean process.

Reviewed by Martin Robinson.

  • docs/GNUmakefile.am:
10:12 Changeset [98495] by msaboff@apple.com

Increase StringImpl Flag Bits for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=70937

Increased the number of bits used for flags in StringImpl
from 6 to 8 bits. This frees up 2 flag bits that will be
used for 8-bit string support. Updated hash methods accordingly.
Changed hash value masking from the low bits to the high
bits.

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • create_hash_table:
  • wtf/StringHasher.h:

(WTF::StringHasher::hash):

  • wtf/text/StringImpl.h:

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashValue):

10:06 Changeset [98494] by andersca@apple.com

Use the right contents scale factor for non-Mac plug-ins
https://bugs.webkit.org/show_bug.cgi?id=70939

Reviewed by Adam Roben.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

10:05 Changeset [98493] by dglazkov@chromium.org

Merge 98492 - REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

  • fast/css/adjacent-sibling-selector-expected.txt: Removed.
  • fast/css/adjacent-sibling-selector.html: Removed.

TBR=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/8390051

09:58 Changeset [98492] by dglazkov@chromium.org

REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

  • fast/css/adjacent-sibling-selector-expected.txt: Removed.
  • fast/css/adjacent-sibling-selector.html: Removed.
09:30 Changeset [98491] by mitz@apple.com

Build fix.

Reverted r98488, which caused the scripts’ status messages to be included in the generated
files.

  • create_hash_table:
  • create_jit_stubs:
09:27 Changeset [98490] by kbalazs@webkit.org

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

Unreviewed Qt-Debug gardening.

Add CRASH+PASS expectation instead of the skipping madness
because the first inspector test is always a flaky crash,
no matter which one is that.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
09:20 Changeset [98489] by apavlov@chromium.org

Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):

  • inspector/front-end/inspector.js:

(WebInspector._updateErrorAndWarningCounts):

09:05 Changeset [98488] by vestbo@webkit.org

Don't print regular output to STDERR when generating hashtables and JIT stubs

Reviewed by Simon Hausmann.

09:02 Changeset [98487] by kbalazs@webkit.org

[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/transforms/scrollIntoView-transformed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=70935

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915
The test became flaky after added platform result.

Skip flaky tests.

  • platform/qt-wk2/Skipped:
08:48 Changeset [98486] by reed@google.com

[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):

LayoutTests:

  • platform/chromium/test_expectations.txt:
08:43 Changeset [98485] by carlosgc@webkit.org

[GTK] Add missing symbols to WebKit2 gtk-doc files
https://bugs.webkit.org/show_bug.cgi?id=70927

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add sections for

WebKitBackForwardList, WebKitBackForwardListItem and WebKitSettings.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add missing symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add missing types.
08:40 Changeset [98484] by carlosgc@webkit.org

[GTK] Inconsistent name of WebKitSettings macros
https://bugs.webkit.org/show_bug.cgi?id=70924

Reviewed by Martin Robinson.

Rename WEBKIT_TYPE_WEB_SETTINGS as WEBKIT_TYPE_SETTINGS and
WEBKIT_IS_WEB_SETTINGS as WEBKIT_IS_SETTINGS.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_init):
(webkit_settings_new):
(webkit_settings_get_enable_javascript):
(webkit_settings_set_enable_javascript):
(webkit_settings_get_auto_load_images):
(webkit_settings_set_auto_load_images):
(webkit_settings_get_load_icons_ignoring_image_load_setting):
(webkit_settings_set_load_icons_ignoring_image_load_setting):
(webkit_settings_get_enable_offline_web_application_cache):
(webkit_settings_set_enable_offline_web_application_cache):
(webkit_settings_get_enable_html5_local_storage):
(webkit_settings_set_enable_html5_local_storage):
(webkit_settings_get_enable_html5_database):
(webkit_settings_set_enable_html5_database):
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
(webkit_settings_get_enable_frame_flattening):
(webkit_settings_set_enable_frame_flattening):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):
(webkit_settings_get_enable_java):
(webkit_settings_set_enable_java):
(webkit_settings_get_javascript_can_open_windows_automatically):
(webkit_settings_set_javascript_can_open_windows_automatically):
(webkit_settings_get_enable_hyperlink_auditing):
(webkit_settings_set_enable_hyperlink_auditing):

  • UIProcess/API/gtk/WebKitSettings.h:
08:27 Changeset [98483] by zimmermann@webkit.org

2011-10-26 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

Reviewed by Antti Koivisto.

Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

  • css2.1/20110323/background-intrinsic-001.htm: Added.
  • css2.1/20110323/background-intrinsic-002.htm: Added.
  • css2.1/20110323/background-intrinsic-003.htm: Added.
  • css2.1/20110323/background-intrinsic-004.htm: Added.
  • css2.1/20110323/background-intrinsic-005.htm: Added.
  • css2.1/20110323/background-intrinsic-006.htm: Added.
  • css2.1/20110323/background-intrinsic-007.htm: Added.
  • css2.1/20110323/background-intrinsic-008.htm: Added.
  • css2.1/20110323/background-intrinsic-009.htm: Added.
  • css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width.svg: Added.
  • fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
  • fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
  • fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
  • platform/mac/fast/block/float/015-expected.txt: Ditto.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
  • svg/as-background-image/background-image-tiled.html: Added.
  • svg/as-background-image/resources/construction-tape.svg: Added.
  • svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
  • svg/as-background-image/same-image-two-instances-background-image.html: Added.
  • svg/as-image/img-preserveAspectRatio-support-1.html: Added.
  • svg/as-image/resources/circle-default-meet.svg: Added.
  • svg/as-image/resources/circle-default-none.svg: Added.
  • svg/as-image/resources/circle-default-slice.svg: Added.
  • svg/as-image/resources/circle-nosize.svg: Added.
  • svg/as-image/resources/circle-viewbox-default.svg: Added.
  • svg/as-image/resources/circle-viewbox-meet.svg: Added.
  • svg/as-image/resources/circle-viewbox-none.svg: Added.
  • svg/as-image/resources/circle-viewbox-slice.svg: Added.
  • svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
  • svg/as-image/same-image-two-instances.html: Added.
  • svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
  • svg/as-image/svg-image-change-content-size.xhtml: Added.
  • svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
  • svg/zoom/page/zoom-background-image-tiled.html: Added.
  • svg/zoom/page/zoom-background-images.html: Added.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.

2011-10-26 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

SVGs do not work as tiled background images
https://bugs.webkit.org/show_bug.cgi?id=16281

Apply preserveAspectRatio and synthesize viewboxes in <img>
https://bugs.webkit.org/show_bug.cgi?id=34521

SVG background doesn't resize properly when dimensions are changed
https://bugs.webkit.org/show_bug.cgi?id=42944

Images with percent height inside a floated div should use intrinsic height.
https://bugs.webkit.org/show_bug.cgi?id=45439

SVG image in HTML changes size as the window is resized
https://bugs.webkit.org/show_bug.cgi?id=52045

Reviewed by Antti Koivisto.

Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

Tests: css2.1/20110323/background-intrinsic-001.htm

css2.1/20110323/background-intrinsic-002.htm
css2.1/20110323/background-intrinsic-003.htm
css2.1/20110323/background-intrinsic-004.htm
css2.1/20110323/background-intrinsic-005.htm
css2.1/20110323/background-intrinsic-006.htm
css2.1/20110323/background-intrinsic-007.htm
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
svg/as-image/same-image-two-instances.html
svg/as-image/svg-as-relative-image-with-explicit-size.html
svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html

  • loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size. (WebCore::CachedImage::lookupImageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize(). (WebCore::createSVGImage): Refactored from createImage(), contains the SVGImage creation part only. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed. (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache. (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer. (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter. (WebCore::CachedImage::addClientForRenderer): Special variant of addClient(), overriding the existing in CachedResource. (WebCore::CachedImage::removeClientForRenderer): Special variant of removeClient(), that also clears the image in the ImageBySizeCache. (WebCore::CachedImage::createImage): Refactor SVGImage creation into createSVGImage() free function, to be useable from lookupOrCreateImageForRenderer().
  • loader/cache/CachedImage.h: Expose removeClientForRenderer().
  • page/ChromeClient.h: (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
  • rendering/ImageBySizeCache.cpp: (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid. (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage. (WebCore::ImageBySizeCache::setClient): New helper function, that combines the usage of addClient/removeClient, for the use in CachedImage. (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting. (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
  • rendering/ImageBySizeCache.h: Expose setClient() & imageForRenderer().
  • rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images. (WebCore::resolveWidthForRatio): New inline helper function used bz calculateImageIntrinsicDimensions. (WebCore::resolveHeightForRatio): Ditto. (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. (WebCore::resolveAgainstIntrinsicRatio): Ditto. (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec. (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer(). (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
  • rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0). (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged(). (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded(). (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct. (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages. (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null. (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
  • rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
  • rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
  • rendering/RenderImageResourceStyleImage.cpp: (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending. (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed. (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter. (WebCore::StyleCachedImage::addClient): Forward to new addClientForRenderer(). (WebCore::StyleCachedImage::removeClient): Call new removeClientForRenderer() instead of removeClient(), so the ImageBySizeCache is also updated.
  • rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
  • rendering/style/StyleImage.h: Ditto.
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
  • rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages). (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now. (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
  • rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::containerSize): (WebCore::RenderSVGRoot::setContainerSize):
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
  • svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement. (WebCore::SVGSVGElement::SVGSVGElement): Ditto. (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
  • svg/SVGSVGElement.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImageChromeClient::setObserver): Helper function. (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage. (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor. (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size. (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement. (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs. (WebCore::SVGImage::draw): Stop calling layout() while painting! (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document. (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation. (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
  • svg/graphics/SVGImage.h:
07:59 Changeset [98482] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 CPU-CG.

  • platform/chromium/test_expectations.txt:
07:56 Changeset [98481] by kenneth@webkit.org

Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
https://bugs.webkit.org/show_bug.cgi?id=70328

Reviewed by Simon Hausmann.

Also remove checks for m_client in DeviceMotionController as it can never be null.

No new tests, as the suspend/resume functionality is not fully working yet.

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):

  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::suspend):
(WebCore::DeviceOrientationController::resume):

  • dom/DeviceOrientationController.h:
  • dom/Document.cpp:

(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
(WebCore::Document::stopActiveDOMObjects):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • page/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::suspend):
(WebCore::GeolocationController::resume):

  • page/GeolocationController.h:
07:54 Changeset [98480] by kbalazs@webkit.org

[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/css/font-face-descending-unicode-range.html fails
https://bugs.webkit.org/show_bug.cgi?id=70922
Skipped

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915
The svg test has correct pixel results so it's ok to add platform results.

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
07:50 Changeset [98479] by lforschler@apple.com

Merged r93720.

07:44 Changeset [98478] by lforschler@apple.com

Merge 98178.

07:44 Changeset [98477] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert change to test_expectations.txt due to test failures.

  • platform/chromium/test_expectations.txt:
07:32 Changeset [98476] by pfeldman@chromium.org

2011-10-26 Pavel Feldman <pfeldman@google.com>

Not reviewed: follow up to 98236 - moved inspector settings initialization earlier to unbreak settings panel.

  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel):
06:56 Changeset [98475] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 GPU.

  • platform/chromium/test_expectations.txt:
06:50 Changeset [98474] by abecsi@webkit.org

[Qt][WK2] Rename clean-up of QtPinchGestureRecognizer and QtViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=70903

Reviewed by Kenneth Rohde Christiansen.

Rename computeTouchCenter to computePinchCenter,
and use the plural form of coordinate where appropriate.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::_q_viewportUpdated):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::computePinchCenter):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
06:34 Changeset [98473] by kbalazs@webkit.org

Unreviewed Qt-WK2 gardening.

[Qt][WK2] Crash with http/tests/websocket/tests/hixie76/long-invalid-header.html
https://bugs.webkit.org/show_bug.cgi?id=70917

[Qt][WK2] fast/events/drag-selects-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=70907

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915

  • platform/qt-wk2/Skipped:
06:32 Changeset [98472] by hausmann@webkit.org

Name viewport change event consistently.
https://bugs.webkit.org/show_bug.cgi?id=70901

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

No tests needed as the change is only method renaming.

  • page/Chrome.cpp:

(WebCore::Chrome::dispatchViewportPropertiesDidChange):

  • page/Chrome.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::dispatchViewportPropertiesDidChange):

  • page/Page.cpp:

(WebCore::Page::updateViewportArguments):

Source/WebKit/efl:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::dispatchViewportPropertiesDidChange):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::dispatchViewportPropertiesDidChange):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/qt:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::dispatchViewportPropertiesDidChange):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit2:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeViewportProperties):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::didChangeViewportProperties):

  • UIProcess/qt/QtDesktopWebPageProxy.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::didChangeViewportProperties):

  • UIProcess/qt/QtTouchViewInterface.h:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didChangeViewportProperties):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
06:24 Changeset [98471] by senorblanco@chromium.org

[chromium] Canvas2D should rate-limit drawing to prevent swamping the GPU process.
https://bugs.webkit.org/show_bug.cgi?id=70367

Source/WebCore:

Reviewed by James Robinson.

Sadly, we don't have infrastructure to test this kind of GPU swamping
yet.

  • WebCore.gypi:

Add RateLimiter.* to the Chromium build.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::contentChanged):
When the layer is notified that the contents have changed, ping the
rate limiter.

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
Call (new) virtual contentChanged() on a layer when its contents have
been changed (e.g., by a drawing call).

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::contentChanged):
New virtual contentChanged().

  • platform/graphics/chromium/RateLimiter.cpp: Added.

(WebCore::RateLimiter::create):
Rate limiter factory function.
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
Public API to start rate limiting a context.
(WebCore::RateLimiter::stop):
Public API to stop rate limiting a context.
(WebCore::RateLimiter::rateLimitContext):
Internal timer callback when a context should be rate limited.

  • platform/graphics/chromium/RateLimiter.h: Added.
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
Remove rate limiting timer and extension check (moved to RateLimiter).
(WebCore::WebGLLayerChromium::contentChanged):
The function formerly known as setTextureUpdated(), now renamed to
match the base class virtual contentChanged(). Call rate limiter in
CCLayerTreeHost (local implementation removed).
(WebCore::WebGLLayerChromium::setContext):
When the context is changed, stop the pending rate limiter on the old
context. Remove extension check (moved to RateLimiter).

  • platform/graphics/chromium/WebGLLayerChromium.h:

Remove rate limiting timer and extension check (moved to RateLimiter).

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
Public API for starting per-context rate limiter.
(WebCore::CCLayerTreeHost::stopRateLimiter):
Public API for stopping per-context rate limiter.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Implementation of per-GraphicsContext3D RateLimiter.

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::markContextChanged):
Remove the call to setTextureChanged (it will be handled internally
by the compositor in setContextNeedsDisplay() instead). This decouples
GraphicsContext3D from WebGLLayerChromium a bit.

06:17 Changeset [98470] by lforschler@apple.com

Merge 98171.

06:10 Changeset [98469] by pfeldman@chromium.org

2011-10-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing inspector extensions tests.

  • inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
06:03 Changeset [98468] by lforschler@apple.com

Merged r98153.

06:01 Changeset [98467] by lforschler@apple.com

Merged r98113.

05:58 Changeset [98466] by ossy@webkit.org

[Qt] Unreviewed gardening.

Skip failing tests temporarily because of missing Qt Mobility on the buildbot.

  • platform/qt-arm/Skipped:
05:39 Changeset [98465] by carlosgc@webkit.org

[GTK] Remove g_thread_init() calls from gtk-doc scanner too
https://bugs.webkit.org/show_bug.cgi?id=70908

Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

  • docs/GNUmakefile.am:

Source/WebKit2:

  • UIProcess/API/gtk/docs/GNUmakefile.am:
05:33 Changeset [98464] by yurys@chromium.org

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, gardening. Mark editing/selection/designmode-no-caret.html as failing in debug mode.

  • platform/chromium/test_expectations.txt:
05:11 Changeset [98463] by kbalazs@webkit.org

[Qt] inspector/extensions/extensions-console.html is failing
https://bugs.webkit.org/show_bug.cgi?id=70905

Unreviewed gardening. Skip failing test.

  • platform/qt/Skipped:
04:44 Changeset [98462] by kbalazs@webkit.org

ParallelJobs path of FEConvolveMatrix is erroneous
https://bugs.webkit.org/show_bug.cgi?id=70409

Reviewed by Zoltan Herczeg.

Covered by existing tests.

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
Reject the silly idea that bytes per pixel ratio is 3 in preserveAlphaValues mode.
The bug was hidden so far because that computation has no effect when we are going
with the full inferior area in one round (in that case clipBottom and yEnd are equals
and the value of the expression is always 0). With ParallelJobs we process sub-areas
on each thread which has triggered the issue.

03:46 WebKitGTK/1.6.x edited by kov@webkit.org
(diff)
02:59 Changeset [98461] by hausmann@webkit.org

[Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.

Reviewed by Tor Arne Vestbø.

We're using QScroller since r98460, which requires QWidget/QApplication. So
use QApplication and QtWidgets for the time being.

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
02:49 Changeset [98460] by abecsi@webkit.org

[Qt][WK2] Add the animations on the ViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=66664

Reviewed by Kenneth Rohde Christiansen.

Introduce a QScroller based panning and a QVariantAnimation based scale animation.
QScroller also handles flick gestures and animates overshoot.
If a pinch gesture ends, the scale animation will scale and reposition the content
such that it is within valid boundaries. The content is by default animated such
that the content position as seen in the center of the visible viewport stays
in the center, unless the content would be out of valid bounds.
The patch also simplifies the ViewportUpdateGuard by using reference counting
instead of a boolean for defering update requests.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::bindToScaleLimits):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::innerBoundedScale):
(WebKit::QtViewportInteractionEngine::outerBoundedScale):
(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::stopAnimations):
(WebKit::QtViewportInteractionEngine::calculateBoundariesForScale):
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::scroller):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::ScaleAnimation):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::updateCurrentValue):

02:41 Changeset [98459] by rgabor@webkit.org

[Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt

  • platform/qt/Skipped:
02:38 Changeset [98458] by yurys@chromium.org

Unreviewed, rolling out r98393.
http://trac.webkit.org/changeset/98393
https://bugs.webkit.org/show_bug.cgi?id=70892

"Compilation is broken on Chromium Webkit Mac Builder (dbg) "
(Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

  • tests/LayerChromiumTest.cpp:
  • tests/WebLayerTest.cpp: Removed.
02:33 Changeset [98457] by rniwa@webkit.org

Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
https://bugs.webkit.org/show_bug.cgi?id=70880

Reviewed by Eric Seidel.

Use option key (instead of control key) to move between word boundaries on Mac.

  • editing/selection/caret-mode-paragraph-keys-navigation.html:
  • platform/chromium/test_expectations.txt:
02:25 Changeset [98456] by pfeldman@chromium.org

Web Inspector: order console message parameters for better optional parameters handling.
https://bugs.webkit.org/show_bug.cgi?id=70809

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):

LayoutTests:

  • inspector/console/console-preserve-log.html:
02:14 Changeset [98455] by rniwa@webkit.org

Fix rebaseline done in r98439.

  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/copy-standalone-image-expected.txt: Added.
02:07 Changeset [98454] by vsevik@chromium.org

Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
  • inspector/debugger/watch-expressions-panel-switch.html: Added.
  • platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
01:52 Changeset [98453] by fsamuel@chromium.org

Page Scale Factor broken when navigating history on pages with child frames
https://bugs.webkit.org/show_bug.cgi?id=70459

Reviewed by Darin Fisher.

With frameScaleFactor now always returning 1.0 for subframes and pageScaleFactor for the mainFrame,
and there being only a single pageScaleFactor, history for scaling is broken. Scaling history is
saved on a per frame basis but restored, overriding the per-page pageScaleFactor multiple times.
As a result, sometimes pages that have subframes end up getting a scale factor of 1.0 instead
of the correct scale factor that was assigned to the main frame.

No new tests because I don't know how to test this.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

01:52 Changeset [98452] by rniwa@webkit.org

Filed more bugs.

  • platform/chromium/test_expectations.txt:
01:45 Changeset [98451] by rniwa@webkit.org

More Chromium test expectation updates. Filed a bunch of bugs to track real failures
and removed erroneous failing test expectations.

  • platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
01:29 Changeset [98450] by hausmann@webkit.org

[Qt][WK2] Rewrite MiniBrowser in QML
https://bugs.webkit.org/show_bug.cgi?id=70315

Add the first QML based implementation of MiniBrowser.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Source/WebKit2:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-26
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):

2011-10-20 Zeno Albisser <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

Tools:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
(BrowserWindow::load):
(BrowserWindow::keyPressEvent):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

  • MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

  • MiniBrowser/qt/icons/next.png: Added.
  • MiniBrowser/qt/icons/previous.png: Added.
  • MiniBrowser/qt/icons/refresh.png: Added.
  • MiniBrowser/qt/icons/stop.png: Added.
  • MiniBrowser/qt/main.cpp:

(main):

  • MiniBrowser/qt/qml/BrowserWindow.qml: Added.
01:29 Changeset [98449] by hausmann@webkit.org

2011-10-20 Zeno Albisser <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

01:29 Changeset [98448] by hausmann@webkit.org

[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70529

Remove obsolete code for a new QML based implementation
of MiniBrowser.
Change BrowserWindow to derive from QSGView instead of
QMainWindow. QSGView is used as a top level window that
provides the container for placing QML content.
Make MiniBrowserApplication derive from QGuiApplication
instead of QApplication.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

  • MiniBrowser/qt/BrowserView.cpp: Removed.
  • MiniBrowser/qt/BrowserView.h: Removed.
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
  • MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

  • MiniBrowser/qt/main.cpp:
01:28 Changeset [98447] by hausmann@webkit.org

[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

In order to rewrite MiniBrowser in QML we need a suitable
mechanism for triggering navigation actions.
Due to the QtWidgets dependency of QAction the current
solution is not suitable anymore. Therefore we introduce
invokable methods and export properties in QWebNavigationController.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

Source/WebKit2:

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qwebkittypes.h: Removed.
  • UIProcess/API/qt/qwebnavigationcontroller.cpp:

(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::canGoBack):
(QWebNavigationController::canGoForward):
(QWebNavigationController::canStop):
(QWebNavigationController::canReload):
(QWebNavigationController::goBack):
(QWebNavigationController::goForward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):

  • UIProcess/API/qt/qwebnavigationcontroller.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopEnabledAfterLoadStarted):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationStatusAtStartup):

  • UIProcess/qt/ClientImpl.cpp:

(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didSameDocumentNavigationForFrame):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::canGoBack):
(QtWebPageProxy::goBack):
(QtWebPageProxy::canGoForward):
(QtWebPageProxy::goForward):
(QtWebPageProxy::canStop):
(QtWebPageProxy::stop):
(QtWebPageProxy::canReload):
(QtWebPageProxy::reload):
(QtWebPageProxy::navigationStateChanged):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

  • UIProcess/qt/QtWebPageProxy.h:
  • WebKit2API.pri:

Tools:

  • MiniBrowser/qt/BrowserView.cpp:
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

01:27 Changeset [98446] by commit-queue@webkit.org

[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66366

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-26
Reviewed by Ryosuke Niwa.

Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
Adds to ewk_view_viewport_attributes_get NULL checks to avoid unexpected results since this is API.

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
(ewk_view_viewport_attributes_get):

01:24 Changeset [98445] by yurys@chromium.org

Unreviewed, rolling out r98429.
http://trac.webkit.org/changeset/98429
https://bugs.webkit.org/show_bug.cgi?id=70881

"webkit_gpu_tests fail in Chromium" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebLayerTreeView.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::setThread):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

01:13 Changeset [98444] by gyuyoung.kim@samsung.com

[EFL] Unregister viewport,changed signal in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=70478

Reviewed by Eric Seidel.

'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
doesn't support proper DPI value though viewport is using DPI value to compute layout values.
This signal is for mobile device.

  • EWebLauncher/main.c:

(browserCreate):

01:07 Changeset [98443] by rniwa@webkit.org

Cleanup Chromium test expectation. These tests were erroneously marked as timing out intermittently
even though the Chromium issue 66085 was fixed a long time ago.

Remove failing expectations from these tests except http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
which is still timing out intermittently on Chromium Linux. Filed the bug 70878 to track the failure.

  • platform/chromium/test_expectations.txt:
00:57 Changeset [98442] by commit-queue@webkit.org

Remove temporary hack needed to ease Chromium/WebKit commit.
https://bugs.webkit.org/show_bug.cgi?id=70791

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-26
Reviewed by Darin Fisher.

  • public/WebDocument.h:
00:57 Changeset [98441] by rniwa@webkit.org

Chromium editing test rebaselines and editing test expectations updates.

  • platform/chromium-linux/editing/selection/5354455-2-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/12882-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5354455-2-expected.png: Added.
  • platform/chromium-mac/editing/inserting/12882-expected.png: Removed.
  • platform/chromium-mac/editing/selection/5354455-2-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
00:52 Changeset [98440] by commit-queue@webkit.org

Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-26
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-image-expected.txt: Added.
  • fast/canvas/canvas-composite-image.html: Added.
00:36 Changeset [98439] by rniwa@webkit.org

Chromium Mac rebaseline, trusting the baseline optimizer.

  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • platform/chromium-cg-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
00:07 Changeset [98438] by rniwa@webkit.org

Another GTK build fix attempt after r98413 and r98416.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

10/25/11:

23:57 Changeset [98437] by rniwa@webkit.org

C/C++ needs ; after each statement.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

23:56 Changeset [98436] by rniwa@webkit.org

Mac, Qt, and Windows rebaseline r98407.

  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
23:47 Changeset [98435] by rniwa@webkit.org

GTK build fix attempt after r98413 and r98416.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::geometryDidChange):

23:46 Changeset [98434] by commit-queue@webkit.org

Unreviewed, rolling out r98379.
http://trac.webkit.org/changeset/98379
https://bugs.webkit.org/show_bug.cgi?id=70875

Did not pass on JSC ports (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
23:25 Changeset [98433] by commit-queue@webkit.org

Unreviewed, rolling out r98346.
http://trac.webkit.org/changeset/98346
https://bugs.webkit.org/show_bug.cgi?id=70874

Breaks JSC-based bots. (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
  • inspector/debugger/watch-expressions-panel-switch.html: Removed.
23:20 Changeset [98432] by rniwa@webkit.org

Flaky Test: editing/pasteboard/copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):

When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

  • editing/pasteboard/copy-standalone-image.html:
  • platform/chromium/test_expectations.txt:
22:55 Changeset [98431] by barraclough@apple.com

Split DFGJITCodeGenerator::callOperation methods
https://bugs.webkit.org/show_bug.cgi?id=70870

Reviewed by Filip Pizlo.

The DFGJITCodeGenerator currently contains two sets of callOperation methods.
One set works with the JSVALUE64 value representation and passes arguments in
registers (suitable for use on x86-64), and one set works with the JSVALUE32_64
value representation and passes arguments in memory (suitable for use on x86).
By refactoring out the representation and calling convention specific aspects
of the code we can also configure the DFG JIT to operator on platforms that use
the JSVALUE32_64 value representation but pass arguments in registers.

On platforms supported by the JIT, the payload precedes the tag of a value in
argument/result ordering, as such, in order to make the setupResults method
generally applicable to return the results of a function that are returned in
two registers, the ordering of arguments to this function has been reversed -
as is the ordering of augments passed to setupArguments methods, with respect
to the ordering with which they are passed in to callOperation.
This inconsistency will be resolved in a later change when we combine the pairs
of arguments passed into callOperation, such that the function signatures can
be made consistent across the two value representations (the callOperation
methods will be passed a reference to a struct representing the JSValue
temporary, this will consist of two gprs on 32_64 and one on 64).

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):

  • moved, removed tag,payload version of this method.

(JSC::DFG::setupArguments):
(JSC::DFG::setupArgumentsExecState):
(JSC::DFG::setupArgumentsWithExecState):

  • Calling convention specific portion of callOperation refactored out into these methods.

(JSC::DFG::callOperation):

  • updated these methods to use setupArguments* methods.

(JSC::DFG::setupResults):

  • setupResults is now passed payload,tag.

(JSC::DFG::appendCallWithExceptionCheckSetResult):

  • Added fpr versions of this function.

(JSC::DFG::appendCallSetResult):

  • Added versions of this function without exception check.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • setupResults is now passed payload,tag.
22:17 Changeset [98430] by xji@chromium.org

Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

  • platform/qt/Skipped:
22:02 Changeset [98429] by nduca@chromium.org

[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::hasThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebLayerTreeView.h:
  • src/WebCompositorImpl.cpp:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

21:57 Changeset [98428] by xji@chromium.org

--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Get next or previous root inline box (which is not in the same
render object as the current root inline box) by traversing DOM node.

Test: editing/selection/move-by-word-visually-inline-block-positioned-element.html

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element.html:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
20:06 Changeset [98427] by abarth@webkit.org

JSEventTarget.cpp has a bunch of unnessary includes
https://bugs.webkit.org/show_bug.cgi?id=70865

Reviewed by Eric Seidel.

In the process of removing these includes, I noticed we had a bunch of
non-autogenerated code in this file, which I've now autogenerated.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

  • One subtly here is the outter static_cast, which is caused by an inheritance infelicity in JavaScriptAudioNode, which I've noted with a FIXME. In any case, the extra static_cast shouldn't cause any trouble.
  • webaudio/JavaScriptAudioNode.h:
19:14 Changeset [98426] by abarth@webkit.org

V8DOMWrapper.cpp has unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=70863

Reviewed by Eric Seidel.

  • bindings/v8/V8DOMWrapper.cpp:
19:12 Changeset [98425] by arv@chromium.org

Fix ad hoc test.

unreviewed.

  • fast/canvas/webgl/gl-teximage.html:
19:11 Changeset [98424] by commit-queue@webkit.org

Fix occurrence of unpainted tiles while scrolling and zooming.
https://bugs.webkit.org/show_bug.cgi?id=70711

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
For the proper calculation to generate a float number, at least one of operatees must be a float type.
But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
so it generates smaller result than expected result when it is using ceil API.
As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_recalc_renderers):
(ewk_tiled_backing_store_zoom_weak_set):

18:59 Changeset [98423] by mhahnenberg@apple.com

Resetting baseline for test bindings

Unreviewed preemptive build fix

No new tests.

  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
18:49 Changeset [98422] by mhahnenberg@apple.com

Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::deletePropertyByIndex):

  • API/JSObjectRef.cpp:

(JSObjectDeleteProperty):

(JSC::DebuggerActivation::deleteProperty):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):

  • runtime/JSArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:
  • runtime/JSVariableObject.h:
  • runtime/RegExpMatchesArray.h:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StrictEvalActivation.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::deleteProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::deleteProperty):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::remove):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/NP_jsobject.cpp:

(_NPN_RemoveProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::removeMember):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::removeProperty):

18:45 Changeset [98421] by cfleizach@apple.com

AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/slider-allows-title-ui-element.html

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::isControl):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
  • platform/mac/accessibility/slider-allows-title-ui-element.html: Added.
18:38 Changeset [98420] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

fast/forms/form-associated-element-crash3.html has
been timing out very regularly on linux debug.

18:15 Changeset [98419] by commit-queue@webkit.org

[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=67588

Some of variables which aren't related with loop count or other variables
inside of loop are moved out of loop.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):

18:13 Changeset [98418] by bfulgham@webkit.org

[WinCairo] Unreviewed build fix after r97587.

  • win/WebKit2CFLite.def:
18:01 Changeset [98417] by arv@chromium.org

[Chromium] Fix expectation.

unreviewed.

  • platform/chromium/fast/js/kde/garbage-n-expected.txt:
18:00 Changeset [98416] by andersca@apple.com

CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
https://bugs.webkit.org/show_bug.cgi?id=67227
<rdar://problem/10048319>

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Apply the scale factor when painting.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Apply the scale factor when painting.

(WebKit::PluginProxy::geometryDidChange):
Make sure to apply the contents scale factor to the backing store size.

(WebKit::PluginProxy::update):
Apply the scale factor (when painting).

17:56 Changeset [98415] by mhahnenberg@apple.com

Remove putVirtual
https://bugs.webkit.org/show_bug.cgi?id=70740

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):

(JSC::DebuggerActivation::put):

  • debugger/DebuggerActivation.h:
  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::put):
(JSC::JSCell::putByIndex):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSValue::put):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectSetProperty):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::put):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomPut):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::setMember):
(JavaJSObject::setSlot):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:
  • bridge/testqtbindings.cpp:

(main):

Source/WebKit/efl:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/mac:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

17:34 Changeset [98414] by andersca@apple.com

Add radar.

17:30 Changeset [98413] by andersca@apple.com

Plug-ins have no way to find out when the device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=67226

Reviewed by Sam Weinig.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

  • PluginProcess/PluginControllerProxy.h:

This now takes the contentsScaleFactor and calls contentsScaleFactorChanged on its plug-in
if the scale factor changes.

  • PluginProcess/PluginControllerProxy.messages.in:

GeometryDidChange now takes a contents scale factor parameter.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::contentsScaleFactorChanged):
Implement contentsScaleFactorChanged and call NPP_SetValue with the new scale factor.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::contentsScaleFactorChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Add stub.

  • WebProcess/Plugins/Plugin.h:

Add pure virtual contentsScaleFactorChanged member function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Add geometryDidChange overload that doesn't take any parameters. Make it send over the
new scale factor to the plug-in process.

(WebKit::PluginProxy::contentsScaleFactorChanged):
Call geometryDidChange.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setDeviceScaleFactor):
Call Plugin::contentsScaleFactorChanged.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):
Call setDeviceScaleFactor on all registered plug-ins.

Tools:

Keep a cached copy of the contents scale and update it when it changes.

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:

(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::cachedContentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::NPP_New):
(ContentsScaleFactor::NPP_SetValue):

LayoutTests:

Update test to check that the scale factor is updated correctly.

  • platform/mac-wk2/plugins/contents-scale-factor.html:
16:43 Changeset [98412] by abarth@webkit.org

EventTargetFactory.in is not sorted
https://bugs.webkit.org/show_bug.cgi?id=70855

Reviewed by Eric Seidel.

PerformanceTests:

Add a microbenchmark for wrapping event target.

  • Bindings: Added.
  • Bindings/event-target-wrapper.html: Added.
  • Parser/resources/runner.js:

(runLoop):

  • Let the user of the harness get a callback when the test is done.

Source/WebCore:

This patch sorts the file. I was not able to measure a performance
difference using the microbenchmark included with this patch.

  • dom/EventTargetFactory.in:
16:42 Changeset [98411] by fsamuel@chromium.org

Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

  • fast/table/table-anonymous-cell-bug-expected.png: Added.
  • fast/table/table-anonymous-cell-bug-expected.txt:
  • fast/table/table-anonymous-cell-bug.html:
  • fast/table/table-anonymous-row-bug-expected.png: Added.
  • fast/table/table-anonymous-row-bug-expected.txt:
  • fast/table/table-anonymous-row-bug.html:
  • fast/table/table-anonymous-section-bug-expected.png: Added.
  • fast/table/table-anonymous-section-bug-expected.txt:
  • fast/table/table-anonymous-section-bug.html:
16:39 Changeset [98410] by abarth@webkit.org

Attempt to fix the Windows build. Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSEventTarget.cpp:
16:19 Changeset [98409] by weinig@apple.com

Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).

(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

16:17 Changeset [98408] by rniwa@webkit.org

Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

  • editing/selection/table-lineboundary-expected.txt: Added.
  • editing/selection/table-lineboundary.html: Added.
16:10 Changeset [98407] by arv@chromium.org

JS Test Harness: Make successfullyParsed optional
https://bugs.webkit.org/show_bug.cgi?id=70784

Reviewed by Ojan Vafai.

Tools:

  • Scripts/make-new-script-test:

(writeTestFile): Update the template for script tests.

LayoutTests:

This makes "successfullyParsed = true" optional in favor of tracking syntax errors
using window.onerror.

  • fast/*: Remove successfullyParsed.
  • fast/dom/Window/new-window-opener.html: Cleanup.
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/webkitConvertPoint.html: Ditto.
  • fast/dom/Window/webkitConvertPointUpdateLayout.html: Ditto.
  • fast/js/kde/evil-n.html: This is now a normal test since it is not supposed to fail.
  • fast/js/kde/garbage-n-expected.txt:
  • fast/js/kde/garbage-n.html: Use shouldHaveHadError instead of js-test-post-n.js
  • fast/js/kde/string-1-n.html: Ditto.
  • fast/js/kde/string-2-n.html: Ditto.
  • fast/js/resources/js-test-post-async.js: Ensure we didn't get an error.
  • fast/js/resources/js-test-post-function.js: Ditto.
  • fast/js/resources/js-test-post-n.js: Removed.
  • fast/js/resources/js-test-pre.js: Added shouldHaveHadError function that can be used to assert that the

error message is what was expected.
Ensure we didn't get an error in finistJSTest.

16:10 Changeset [98406] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore:

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds
platform-independent GraphicsContext::applyDeviceScaleFactor().

  • WebCore.exp.in:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been
reverted to do what it used to do before that was added; it just calls into
WebCoreSystemInterface directly.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

Source/WebKit2:

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and
adjusting the base CTM.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

16:06 Changeset [98405] by barraclough@apple.com

Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::appendCallWithExceptionCheck):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

16:02 Changeset [98404] by jchaffraix@webkit.org

More gardening.

  • platform/chromium/test_expectations.txt: Missed some cases where

video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

16:00 Changeset [98403] by andersca@apple.com

Source/WebCore: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

  • plugins/npapi.h:

Source/WebKit2: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

  • PluginProcess/PluginControllerProxy.h:

Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):

  • PluginProcess/PluginCreationParameters.h:

Add contentsScaleFactor to the creation parameters.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

  • WebProcess/Plugins/PluginController.h:

Add contentsScaleFactor pure virtual member function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

  • WebProcess/Plugins/PluginView.h:

Add contentsScaleFactor().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.

(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add tests.

  • platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
  • platform/mac-wk2/plugins/contents-scale-factor.html: Added.
15:55 Changeset [98402] by adamk@chromium.org

Forward declare MutationObserverEntry as a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853

Reviewed by Ryosuke Niwa.

Node.h forward declared MutationObserverEntry as a class, and clang
complains if the two declarations don't match.

  • dom/Node.h:
15:51 Changeset [98401] by leviw@chromium.org

Mac build fixes and adding pixelSnapped convenience methods for accessors that needed them.

15:45 Changeset [98400] by mitz@apple.com

Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70851

Reviewed by Dave Hyatt.

  • manual-tests/caret-in-columns-flipped.html: Added.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
from this function, since not all callers were expecting it to account for flippedness. This makes
it similar to adjustRectForColumns() in not adjusting for flippedness.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
columns, then flipping.

15:35 Changeset [98399] by weinig@apple.com

Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Source/WebKit2:

Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
and didFailLoad.

Reviewed by Anders Carlsson.

Test: WKBrowsingContextLoadDelegateTest

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(setUpPageLoaderClient):

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Tools:

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2ObjC: Added.
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.

(WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
(WKBrowsingContextLoadDelegateTest::SetUp):
(WKBrowsingContextLoadDelegateTest::TearDown):
(-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
(TEST_F):
Add basic testing for WKBrowsingContextLoadDelegate.

14:56 Changeset [98398] by fpizlo@apple.com

Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854

Reviewed by Oliver Hunt.

Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.

This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):

  • bytecode/CodeBlock.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

14:44 Changeset [98397] by jchaffraix@webkit.org

More unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark another test

as crashing. Moved 2 tests together as they hit the same ASSERT
on the bots.

14:25 Changeset [98396] by eae@chromium.org

Fix scrollbars for chromium/linux

14:16 Changeset [98395] by ap@apple.com

make-script-test-wrappers should not look outside fast/js
https://bugs.webkit.org/show_bug.cgi?id=66357

Reviewed by Maciej Stachowiak.

  • Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support

fast/js.

14:11 Changeset [98394] by andersca@apple.com

Assertion failure when zooming a PDF in an iframe
https://bugs.webkit.org/show_bug.cgi?id=70849

Reviewed by Alexey Proskuryakov.

If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

14:10 Changeset [98393] by commit-queue@webkit.org

Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <piman@chromium.org> on 2011-10-25
Reviewed by James Robinson.

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

13:59 Changeset [98392] by commit-queue@webkit.org

LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
13:56 Changeset [98391] by eae@chromium.org

Merging trunk changes up until 98381 into subpixel branch.

13:54 Changeset [98390] by abarth@webkit.org

Add a --make option to update-webkit to engage the Makefile-based build system
https://bugs.webkit.org/show_bug.cgi?id=70847

Reviewed by Dimitri Glazkov.

I can never remember what crazy environment variables I'm supposed to
set to tell GYP what to do.

  • Scripts/update-webkit:
13:46 Changeset [98389] by andersca@apple.com

REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
https://bugs.webkit.org/show_bug.cgi?id=70827
<rdar://problem/10342925>

Reviewed by Adam Barth.

Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
able to make a test case that would reproduce this crash, we do check m_currentItem for null
everywhere else, and the crash log indicates that this would fix the crash.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveUpdateForCommit):

13:44 Changeset [98388] by abarth@webkit.org

EventTarget.h shouldn't need to know about every feature and ifdef
https://bugs.webkit.org/show_bug.cgi?id=70659

Reviewed by Darin Adler.

Source/WebCore:

This patch follows the approach of Event.h and introduces an
interfaceName virtual function that returns the name of the DOM
interface for the concrete type of the object. This function lets us
remove a large number of fake dynamic casts.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
    • Teach action_makenames how to handle the new "in" file.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • Use the new autogenerated macro to remove a large amount of feature-specific code.
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • bindings/objc/DOM.mm:

(kit):

  • The SVGElementInstance branch was never taken previously because SVGElementInstance::toNode returns a non-NULL value. This code was introduced in http://trac.webkit.org/changeset/42618 and doesn't appear to have ever worked as the author intended.
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • Use the new autogenerated macro to remove a large amount of feature-specific code.
  • dom/EventNames.cpp:

(WebCore::EventNames::EventNames):

  • dom/EventNames.h:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in: Added.
    • Add a new "in" file that lists all the EventTargets.
  • dom/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::interfaceName):

  • dom/LocalMediaStream.h:
  • dom/MediaStream.cpp:

(WebCore::MediaStream::interfaceName):

  • dom/MediaStream.h:
  • dom/MessagePort.cpp:

(WebCore::MessagePort::interfaceName):

  • dom/MessagePort.h:
  • dom/Node.cpp:

(WebCore::Node::toNode):
(WebCore::Node::interfaceName):

  • dom/Node.h:
  • dom/make_event_factory.pl:
    • Generalize make_event_factory.pl to be able to generate interfaces for different namespaces.
  • fileapi/FileReader.cpp:

(WebCore::FileReader::interfaceName):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::interfaceName):

  • fileapi/FileWriter.h:
  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::interfaceName):

  • loader/appcache/DOMApplicationCache.h:
  • notifications/Notification.cpp:

(WebCore::Notification::interfaceName):

  • notifications/Notification.h:

(WebCore::Notification::scriptExecutionContext):

  • p2p/PeerConnection.cpp:

(WebCore::PeerConnection::interfaceName):

  • p2p/PeerConnection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::interfaceName):
(WebCore::DOMWindow::toDOMWindow):

  • page/DOMWindow.h:
  • page/EventSource.cpp:

(WebCore::EventSource::interfaceName):

  • page/EventSource.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::interfaceName):

  • storage/IDBDatabase.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::interfaceName):

  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::interfaceName):

  • storage/IDBTransaction.h:
  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::interfaceName):

  • storage/IDBVersionChangeRequest.h:
  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::interfaceName):

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::toNode):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::interfaceName):
(WebCore::AudioContext::scriptExecutionContext):

  • webaudio/AudioContext.h:
  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::interfaceName):

  • webaudio/JavaScriptAudioNode.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::interfaceName):

  • websockets/WebSocket.h:
  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::interfaceName):

  • workers/DedicatedWorkerContext.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::performTask):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::interfaceName):

  • workers/SharedWorker.h:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::interfaceName):

  • workers/SharedWorkerContext.h:
  • workers/Worker.cpp:

(WebCore::Worker::interfaceName):

  • workers/Worker.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::interfaceName):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::interfaceName):

  • xml/XMLHttpRequestUpload.h:

Source/WebKit/chromium:

This cast isn't needed because dispatchEvent is a virtual function.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask):

13:42 Changeset [98387] by commit-queue@webkit.org

[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

  • DumpRenderTree/efl/EventSender.cpp:

(sendMouseEvent):
(keyDownCallback):

13:38 Changeset [98386] by weinig@apple.com

Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
restrictions for now.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):

13:36 Changeset [98385] by podivilov@chromium.org

Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811

Reviewed by Adam Barth.

This patch does not have any effect on generated bindings.

  • dom/DataTransferItems.idl:
  • page/History.idl:
  • storage/IDBIndex.idl:
  • xml/XMLHttpRequest.idl:
13:30 Changeset [98384] by commit-queue@webkit.org

[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=70818

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

  • public/WebGraphicsContext3D.h:
13:23 Changeset [98383] by mhahnenberg@apple.com

Fixing Windows build after r98367

Unreviewed build fix

13:22 Changeset [98382] by leandro@webkit.org

[EFL] Unreviewed. Add CSS1 pixel baselines.

  • platform/efl/css1: [...]
13:01 Changeset [98381] by commit-queue@webkit.org

Make it possible to create and dispatch a message event through chromium API

Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data->messageData. Reordered includes.

https://bugs.webkit.org/show_bug.cgi?id=69962

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-25
Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebDOMEvent.h:
  • public/WebDOMMessageEvent.h: Added.
  • public/WebDocument.h:
  • public/WebNode.h:
  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::hasPendingActivity):

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::operator WTF::PassRefPtr<WebCore::Event>):

  • src/WebDOMMessageEvent.cpp: Added.

(WebKit::WebDOMMessageEvent::initMessageEvent):

  • src/WebDocument.cpp:

(WebKit::WebDocument::createEvent):

  • src/WebNode.cpp:

(WebKit::WebNode::dispatchEvent):

12:50 Changeset [98380] by japhet@chromium.org

Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks

for didFail() and didFinishLoading(), so we need to differentiate here.

(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()

instead of ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting

DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
'data' input parameter will contain all data received so far, and we need to determine the
incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
the incremental data.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):

  • loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel

the request, so protect appropriately.

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
12:48 Changeset [98379] by abarth@webkit.org

Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Patch by Pavel Podivilov <podivilov@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
12:45 Changeset [98378] by commit-queue@webkit.org

[EFL] Add function to get geometry of focused element
https://bugs.webkit.org/show_bug.cgi?id=70728

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Added function to ewk_frame to get the geometry of the focused
element within the frame object.

  • ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
the focused element within the given frame object.

  • ewk/ewk_frame.h:
12:37 Changeset [98377] by dbates@webkit.org

build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834

Reviewed by Antonio Gomes.

Currently build-webkit --clean both cleans the build directory and builds WebKit for
CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
as per its description in the usage message of build-webkit.

  • Scripts/webkitdirs.pm:

(buildCMakeProjectOrExit):

12:32 Changeset [98376] by commit-queue@webkit.org

[EFL] Add necessary information for callback instropection
https://bugs.webkit.org/show_bug.cgi?id=70735

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Provide the information about smart callbacks emitted by the ewk_view
object, so that these can be easily forwarded by other objects or used
by bindings in other languages without having to keep track of all of
them manually.

  • ewk/ewk_view.cpp:

(ewk_view_base_smart_set):

12:31 Changeset [98375] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Marking a test as timing

out.

12:28 Changeset [98374] by cevans@google.com

Manage the CSS property array length correctly
https://bugs.webkit.org/show_bug.cgi?id=70783

Reviewed by Adam Barth.

  • css/CSSParser.cpp:

(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.

12:26 Changeset [98373] by tony@chromium.org

avoid unnecessary layouts of flex items during the flex pass
https://bugs.webkit.org/show_bug.cgi?id=70557

Reviewed by Ojan Vafai.

If the preferred size of a flex item is provided, we don't need to
layout the flex item when computing the preferred size. This allows
us to only call layout on each flex item once in the common case.

No new tests, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:
12:12 UsingGitWithWebKit edited by jberlin@webkit.org
Add instructions for how to tell git to ignore "changes" by file system … (diff)
12:10 Changeset [98372] by fsamuel@chromium.org

Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html

fast/table/table-anonymous-row-bug.html
fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

  • fast/table/table-anonymous-cell-bug-expected.txt: Added.
  • fast/table/table-anonymous-cell-bug.html: Added.
  • fast/table/table-anonymous-row-bug-expected.txt: Added.
  • fast/table/table-anonymous-row-bug.html: Added.
  • fast/table/table-anonymous-section-bug-expected.txt: Added.
  • fast/table/table-anonymous-section-bug.html: Added.
12:10 Changeset [98371] by leviw@chromium.org

Fixing false assertion and correcting unrounded values for adjusting height and offset for floats.

12:05 Changeset [98370] by leviw@chromium.org

Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8390012

12:01 Changeset [98369] by andersca@apple.com

PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
<rdar://problem/10312733>

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

  • WebProcess/Plugins/Plugin.h:

Add wantsWindowRelativeCoordinates.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

11:59 Changeset [98368] by commit-queue@webkit.org

Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-25
Reviewed by Darin Adler.

11:51 Changeset [98367] by mhahnenberg@apple.com

Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • JavaScriptCore.exp:
  • runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
  • runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can

reference it in their MethodTables.

Source/WebCore:

No new tests.

  • bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so

subclasses can reference it in their MethodTables.

11:24 Changeset [98366] by zherczeg@webkit.org

Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

  • fast/css/uri-token-parsing-expected.txt:
  • fast/css/uri-token-parsing.html:
11:17 Changeset [98365] by oliver@apple.com

Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

11:10 Changeset [98364] by jchaffraix@webkit.org

Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
11:06 Changeset [98363] by jchaffraix@webkit.org

Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

  • platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
  • platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
10:54 Changeset [98362] by sullivan@apple.com

"Open with" item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
<rdar://problem/10034302>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/PDFViewController.mm:

(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a "Copy" item. If a "Copy" item is not found,
inserts the Open With item at the top of the context menu.

10:54 Changeset [98361] by simon.fraser@apple.com

REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html

transforms/3d/hit-testing/rotated-hit-test-with-child.html
transforms/3d/hit-testing/rotated-hit-test2.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):

  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/HitTestingTransformState.cpp:

(WebCore::HitTestingTransformState::boundsOfMappedQuad):

  • rendering/HitTestingTransformState.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

  • platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
  • platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
  • transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
  • transforms/3d/hit-testing/composited-hit-test.html: Added.
  • transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
  • transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
  • transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
  • transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
  • transforms/3d/hit-testing/rotated-hit-test.html:
  • transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
  • transforms/3d/hit-testing/rotated-hit-test2.html: Added.
10:44 Changeset [98360] by enne@google.com

[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.

(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h: Added.

(WebCore::CCTextureUpdater::allocator):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitOnImplThread):

10:42 Changeset [98359] by jer.noble@apple.com

compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

  • compositing/video/video-poster.html: Seek, instead of play, to trigger

creation of a layer

  • http/tests/media/video-load-twice.html: Use waitForEventOnce so that

canPlayThrough listener is triggered only once.

  • media/video-test.js: Add a new function, waitForEventOnce.

(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

10:22 Changeset [98358] by rniwa@webkit.org

Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):

  • editing/visible_units.h:
10:22 Changeset [98357] by commit-queue@webkit.org

Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard <girard@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

10:18 Changeset [98356] by nduca@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
10:17 Changeset [98355] by caryclark@google.com

Unreviewed gardening: fifth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 742 files for brevity.]

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.

...

  • platform/chromium-mac-leopard/transitions: Added.
  • platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-mac-leopard/transitions/svg-text-shadow-transition-expected.png: Added.
10:04 Changeset [98354] by annacc@chromium.org

Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

09:53 Changeset [98353] by commit-queue@webkit.org

Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html

fast/dom/MicroData/itemtype-add-remove-tokens.html
fast/dom/MicroData/itemtype-attribute-test.html

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::nodeMatches):

  • html/DOMSettableTokenList.h:

(WebCore::DOMSettableTokenList::tokens):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

  • fast/dom/MicroData/006.html:
  • fast/dom/MicroData/007.html:
  • fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
  • fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
  • fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
  • fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
  • fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
  • fast/dom/MicroData/itemtype-attribute-test.html: Added.
09:52 Changeset [98352] by commit-queue@webkit.org

[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

  • WebCoreSupport/GtkAdjustmentWatcher.cpp:

(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

09:40 Changeset [98351] by commit-queue@webkit.org

[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

  • MiniBrowser/gtk/BrowserWindow.c:

(focus):
(unFocus):
(browserWindowUIClientInit):

09:39 Changeset [98350] by mitz@apple.com

<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

  • page/Page.cpp:

(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools:

  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

09:26 Changeset [98349] by caryclark@google.com

Unreviewed gardening: fourth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 728 of 734 files for brevity.]

  • platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/scrolled-marker-paint-expected.png: Added.
  • platform/chromium-mac-leopard/fast/media: Added.

...

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
08:35 Changeset [98348] by yurys@chromium.org

Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

  • inspector/front-end/Settings.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):

  • inspector/front-end/elementsPanel.css:
  • inspector/front-end/inspectorCommon.css:

(.sidebar-separator):
(.sidebar-label):

  • inspector/front-end/scriptsPanel.css:

(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox > input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

  • src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.

():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

08:21 Changeset [98347] by thakis@chromium.org

Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium: [chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70753

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

  • WebKit.gypi:
08:06 Changeset [98346] by vsevik@chromium.org

Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
  • inspector/debugger/watch-expressions-panel-switch.html: Added.
07:26 Changeset [98345] by podivilov@chromium.org

Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

  • inspector/debugger/compiler-source-mapping-expected.txt:
  • inspector/debugger/compiler-source-mapping.html:
07:24 Changeset [98344] by jschuh@chromium.org

Check for empty string in parseArcFlag
https://bugs.webkit.org/show_bug.cgi?id=70763

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/path-invalid.html

  • svg/SVGParserUtilities.cpp:

(WebCore::parseArcFlag):

LayoutTests:

  • svg/path-arc-invalid-expected.txt: Added.
  • svg/path-arc-invalid.html: Added.
07:22 Changeset [98343] by podivilov@chromium.org

Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

LayoutTests:

  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
07:04 Changeset [98342] by commit-queue@webkit.org

Double number step=.5 should be considered valid in <input type="number" step=".5">
https://bugs.webkit.org/show_bug.cgi?id=70320

Patch by Sachin Puranik <sachin.puranik@motorola.com> on 2011-10-25
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-step-as-double.html

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType): Changed the function to consider
step as valid even if it starts with "."

LayoutTests:

  • fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
  • fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
  • fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports

consider .5 as a valid double value for step attribute of input element.

  • fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
  • fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
  • fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
  • fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider

.2 as valid real number now.

  • fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.
06:57 Changeset [98341] by apavlov@chromium.org

Web Inspector: [Chromium] Audits panel context menu for links not working properly
https://bugs.webkit.org/show_bug.cgi?id=70813

Reviewed by Pavel Feldman.

  • inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):
(WebInspector.AuditResultView.prototype._contextMenuEventFired):

06:49 Changeset [98340] by eric@webkit.org

WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
https://bugs.webkit.org/show_bug.cgi?id=64471

Reviewed by Adam Roben.

Speculative fix.

  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
06:49 Changeset [98339] by vsevik@chromium.org

Web Inspector: Resources panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/resources-search-match-index.html

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.ResourcesSearchController):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
(WebInspector.ResourcesSearchController.prototype.previousSearchResult):
(WebInspector.ResourcesSearchController.prototype._searchResult):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):

  • inspector/front-end/treeoutline.js:

LayoutTests:

  • http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
  • http/tests/inspector/search/resources-search-match-index.html: Added.
06:45 Changeset [98338] by ossy@webkit.org

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

  • platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.
06:38 Changeset [98337] by commit-queue@webkit.org

[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

This change allows us to use the template based features of the meta type system
such as using the WebView classes as types for QVariant.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebview.h:
06:17 Changeset [98336] by vsevik@chromium.org

Merge 98105 - Web Inspector: Advanced search is working very slowly and does not show searching progress.
https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

  • inspector/front-end/inspector.css:

(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):

  • inspector/front-end/utilities.js:

():

BUG=101337
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8381041

06:09 Changeset [98335] by vsevik@chromium.org

Revert 98334 -

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8375054

06:00 Changeset [98334] by vsevik@chromium.org
05:59 Changeset [98333] by caseq@chromium.org

Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
https://bugs.webkit.org/show_bug.cgi?id=70812

Reviewed by Pavel Feldman.

Check if highlighted element is present while displaying object popover.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):

04:01 Changeset [98332] by commit-queue@webkit.org

[Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
as the UI process drawing area proxy for tiled based rendering.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-25
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::setPage):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::QTouchWebView):
(QTouchWebView::touchEvent):
(QTouchWebView::onVisibleChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
02:54 Changeset [98331] by nduca@chromium.org

[chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Reviewed by Pavel Feldman.

  • page/Console.cpp:

(WebCore::Console::time):
(WebCore::Console::timeEnd):

02:39 Changeset [98330] by ossy@webkit.org

[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
https://bugs.webkit.org/show_bug.cgi?id=58559

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
02:35 Changeset [98329] by ossy@webkit.org

[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
https://bugs.webkit.org/show_bug.cgi?id=53030

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
02:25 Changeset [98328] by caseq@chromium.org

Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Reviewed by Pavel Feldman.

  • change webInspector.inspectedPage.reload() to accept multiple options in an object
  • add an ability to inject a script upon a page reload
  • return script id in addScriptToEvaluateOnLoad()
  • provide removeScriptToEvaluateOnLoad()
  • store scripts to evaluate on load in inspector state cookie

Source/WebCore:

Test: inspector/extensions/extensions-reload.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.InspectedWindow.prototype.reload):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onReload):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):

LayoutTests:

  • inspector/extensions/extensions-reload-expected.txt: Added.
  • inspector/extensions/extensions-reload.html: Added.
01:37 Changeset [98327] by carlosgc@webkit.org

[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69825

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(webkitBackForwardListItemGetWKItem):

  • UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_go_to_back_forward_list_item):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(testBackForwardListNavigation):

01:24 Changeset [98326] by pfeldman@chromium.org

Web Inspector: print expired message count before remaining messages.
https://bugs.webkit.org/show_bug.cgi?id=70736

Reviewed by Yury Semikhatsky.

  • inspector/Inspector-0.1.json:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::restore):

  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleModel.js:
01:19 Changeset [98325] by commit-queue@webkit.org

[WK2]Critical warning while building WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=70591

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Martin Robinson.

  • WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK
00:06 Changeset [98324] by commit-queue@webkit.org

Unreviewed, rolling out r98309.
http://trac.webkit.org/changeset/98309
https://bugs.webkit.org/show_bug.cgi?id=70801

Test fails on mac (Requested by benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-image-expected.txt: Removed.
  • fast/canvas/canvas-composite-image.html: Removed.

10/24/11:

23:59 Changeset [98323] by ossy@webkit.org

[Qt] Unreviewed gardening, add missing result after r98309.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-24

  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
  • platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.
23:51 Changeset [98322] by mrobinson@webkit.org

REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=70481

Update test results to reflect that the plugin clipping rectangle
is now correct.

  • platform/gtk/Skipped: Unskip the test.
  • platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.
22:43 Changeset [98321] by commit-queue@webkit.org

DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):

21:57 Changeset [98320] by ggaren@apple.com

Chromium build fix: #include window.h for HANDLE.

  • platform/graphics/opentype/OpenTypeUtilities.h:
21:49 Changeset [98319] by rniwa@webkit.org

Include ThreadSafeRefCounted.h since the class declared in this header file
inherits from ThreadSafeRefCounted.

  • storage/IDBIndexBackendInterface.h:
21:33 Changeset [98318] by ggaren@apple.com

Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.

Source/JavaScriptCore:

Source/WebKit/win:

  • WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):

  • WebIconDatabase.cpp:

(WebIconDatabase::didImportIconURLForPageURL):

21:26 Changeset [98317] by rniwa@webkit.org

Source/WebCore: Fix a typo.

  • bindings/v8/JavaScriptCallFrame.h:

Source/WebKit/win: threadsafeCopy has been renamed to isolatedCopy.

  • WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):

20:54 Changeset [98316] by ggaren@apple.com

Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698

Reviewed by David Levin.

Source/JavaScriptCore:

  • Removed SharedUChar because most of its functionality has moved into

other abstraction layers, and we want remaining clients to choose their
abstractions explicitly instead of relying on StringImpl to provide this
behavior implicitly, since we think they can sometimes make more efficient
choices.

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names could give the impression that the resulting object was
thread-safe, but actually it's just an isolated copy, which is not
thread-safe by itself, but can be used to implement a thread-safe
algorithm through isolation.

  • wtf/CrossThreadRefCounted.h: Removed.
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl): Removed the stuff mentioned above.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::length): Ditto.

(WTF::StringImpl::isolatedCopy): Inlined this, since it's now trivial.

  • wtf/text/WTFString.cpp:

(WTF::String::isolatedCopy):

  • wtf/text/WTFString.h: Updated for StringImpl changes.
  • API/OpaqueJSString.h:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.order:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/OwnFastMallocPtr.h:
  • wtf/RefCounted.h:
  • wtf/SizeLimits.cpp:
  • wtf/ThreadSafeRefCounted.h:
  • wtf/wtf.pri:
  • yarr/YarrPattern.h: Updated these files to accomodate removal of

CrossThreadRefCounted.h.

Source/WebCore:

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

  • Updated a bunch of files for header dependency changes, now that

CrossThreadRefCounted is gone.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
  • WebCore.exp.in:
  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • css/CSSPropertySourceData.h:
  • css/CSSValue.h:
  • css/StyleMedia.h:
  • css/WebKitCSSMatrix.h:
  • dom/QualifiedName.h:
  • fileapi/LocalFileSystem.h:

(WebCore::LocalFileSystem::SystemBasePath::operator String):

  • history/CachedFrame.h:
  • history/CachedPage.h:
  • history/HistoryItem.h:
  • html/canvas/CanvasStyle.h:
  • inspector/InspectorResourceAgent.h:
  • loader/FormState.h:
  • loader/TextResourceDecoder.h:
  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):

  • page/ContentSecurityPolicy.h:
  • page/Coordinates.h:

(WebCore::Coordinates::isolatedCopy):

  • page/Geoposition.h:

(WebCore::Geoposition::isolatedCopy):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):

  • page/SecurityOrigin.h:
  • page/animation/AnimationBase.h:
  • platform/CrossThreadCopier.cpp:

(WebCore::::copy):

  • platform/FileChooser.h:
  • platform/KURL.cpp:

(WebCore::KURL::copy):

  • platform/cf/SchedulePair.h:
  • platform/network/BlobData.cpp:

(WebCore::BlobDataItem::detachFromCurrentThread):
(WebCore::BlobData::detachFromCurrentThread):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

  • platform/network/MIMEHeader.h:
  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy):

  • platform/network/ResourceLoadInfo.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::copyData):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::copyData):

  • platform/sql/SQLValue.cpp:

(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):

  • rendering/style/QuotesData.h:
  • storage/AbstractDatabase.cpp:

(WebCore::updateGuidVersionMap):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):

  • storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::tableNames):

  • storage/DatabaseDetails.h:
  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::databaseDirectoryPath):
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):

  • storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::addDatabase):

  • storage/SQLError.h:

(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):

  • storage/SQLResultSetRowList.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::SQLStatement):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::syncTimerFired):

  • storage/StorageAreaSync.h:
  • storage/StorageMap.cpp:

(WebCore::StorageMap::importItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):

  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::willDeleteAllOrigins):

  • svg/SVGPathSeg.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::url):
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::SharedWorkerThread):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

Source/WebKit/chromium:

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

  • src/WorkerFileSystemCallbacksBridge.cpp:

Source/WebKit/mac:

  • Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

  • Storage/WebDatabaseTrackerClient.mm:

(DidModifyOriginData::dispatchToMainThread):

20:36 Changeset [98315] by mnaganov@chromium.org

Fix bug summary when rolling Chromium DEPS to LKGR.
https://bugs.webkit.org/show_bug.cgi?id=69917

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/roll.py:
  • Scripts/webkitpy/tool/commands/roll_unittest.py:
20:17 Changeset [98314] by abarth@webkit.org

Remove empty directory.

  • p2p: Removed.
19:54 Changeset [98313] by commit-queue@webkit.org

[chromium] Refactor painting/updating/drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-24
Reviewed by James Robinson.

This refactoring separates the "early exits" from the actual loop
that draws layers. As part of this, it was also appropriate to
clean up the way that masks and replicas are dealt with when
painting and updating. The purpose of all this is to make things
easier to test, and for a scissoring optimization that needs to
know exatly what gets drawn. Existing layout tests were able to
verify the refactoring did not change behavior.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeAppended):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

19:53 Changeset [98312] by jchaffraix@webkit.org

Unreviewed gardening.

Add a new baseline for snow-leopard.

  • platform/chromium-mac-snowleopard/svg/filters: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added.
19:47 Changeset [98311] by weinig@apple.com

Simplify url accessors on WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70797

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):

  • UIProcess/API/C/WKPage.h:

Add accessors to C SPI.

  • UIProcess/API/mac/WKBrowsingContextController.h:

Remove unreachableURL accessor for now. It may make a glorious return when we have
error page support.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
Implement these in terms of the new C SPI.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):
Add computation of the "active" URL, which is the URL one would show
in an address field. It is the pending URL when there is one, the provisional
URL when there is one, and otherwise the committed/final URL.

(WebKit::WebPageProxy::provisionalURL):
(WebKit::WebPageProxy::committedURL):
Add access to the main frame URL.

  • UIProcess/WebPageProxy.h:
19:38 Changeset [98310] by macpherson@chromium.org

REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=68944

Reviewed by Antti Koivisto.

No new tests / Covered by existing tests.

Removes all virtual dispatch from CSSStyleApplyProperty by converting to use static function pointers for dispatch.
Uses class templates instead of function templates to allow default parameters and also to share parameter declarations across static functions.
All constructor parameters become template parameters. This improves the level of compiler optimization that can be achieved.
Overall this achieved a ~2% overall speedup on run-safari PerformanceTests/Parser/html5-full-render.html,
and profiling showed a reduction in the time spent inside CSSStyleSelector::applyProperty().

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(WebCore::defaultInitialColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::createHandler):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleApplyProperty.h:

(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(WebCore::CSSStyleApplyProperty::propertyHandler):
(WebCore::CSSStyleApplyProperty::setPropertyHandler):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::invalidColor):

19:28 Changeset [98309] by commit-queue@webkit.org

Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-24
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-image-expected.txt: Added.
  • fast/canvas/canvas-composite-image.html: Added.
19:15 Changeset [98308] by rniwa@webkit.org

GTK and Windows rebaselines after r98199.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
18:24 Changeset [98307] by jchaffraix@webkit.org

Unreviewed, rolling out r98294 and r98306.
http://trac.webkit.org/changeset/98294
http://trac.webkit.org/changeset/98306
https://bugs.webkit.org/show_bug.cgi?id=70790

the first patch broke chromium-mac and the second gclient
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gypi:
17:44 Changeset [98306] by jchaffraix@webkit.org

[chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70785

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

Patch by Nico Weber <thakis@chromium.org> on 2011-10-24

  • WebKit.gypi:
17:44 Changeset [98305] by rniwa@webkit.org

Build fix after r98300.

  • WebCore.gypi:
  • WebCore.pro:
17:33 Changeset [98304] by andersca@apple.com

It should be possible for Widget subclasses to control whether transforms affect the frame rect
https://bugs.webkit.org/show_bug.cgi?id=70787

Reviewed by Sam Weinig.

Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
this behavior and have the frame rect set to the absolute content box without any transforms applied.

  • platform/Widget.h:

(WebCore::Widget::transformsAffectFrameRect):
Add new member function.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):
Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
false, just set the frame rect to the absolute content box.

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Call updateWidgetGeometry.

  • rendering/RenderWidget.h:
17:26 Changeset [98303] by eae@chromium.org

Add support for chromium port, currently in a state where DRT builds and most layout tests passes.

17:21 Changeset [98302] by oliver@apple.com

Crash in void JSC::validateCell<JSC::RegExp*>(JSC::RegExp*)
https://bugs.webkit.org/show_bug.cgi?id=70689

Reviewed by Filip Pizlo.

While performing codegen we need to make the GlobalData explicitly
aware of the codeblock being compiled, as compilation may trigger GC
and CodeBlock holds GC values, but has not yet been assigned to its
owner executable.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:
  • heap/AllocationSpace.cpp:

(JSC::AllocationSpace::allocateSlowCase):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

17:19 Changeset [98301] by jchaffraix@webkit.org

Unreviewed rebaseline after r98293.

  • platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png: Added.
17:13 Changeset [98300] by rniwa@webkit.org

Microdata: Add itemprop, itemref, itemvalue attributes.
https://bugs.webkit.org/show_bug.cgi?id=69839

Patch by Arko Saha <arko@motorola.com> on 2011-10-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/MicroData/itemprop-add-remove-tokens.html

fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
fast/dom/MicroData/itemprop-must-be-read-only.html
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
fast/dom/MicroData/itemref-add-remove-tokens.html
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
fast/dom/MicroData/itemref-must-be-read-only.html
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
fast/dom/MicroData/itemvalue-reflects-href-attr.html
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
fast/dom/MicroData/itemvalue-returns-element-itself.html
fast/dom/MicroData/itemvalue-returns-null.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::toJS):
(WebCore::JSHTMLElement::itemValue):
(WebCore::JSHTMLElement::setItemValue):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
(WebCore::V8HTMLElement::itemValueAccessorSetter):

  • dom/MicroDataItemList.cpp:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::itemValueText):
(WebCore::HTMLAnchorElement::setItemValueText):

  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::itemValueText):
(WebCore::HTMLAreaElement::setItemValueText):

  • html/HTMLAreaElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::itemProp): Returns element's itemprop content attribute.
(WebCore::HTMLElement::setItemProp): Sets itemprop value on changing elemet's
itemprop attribute.
(WebCore::HTMLElement::itemRef): Returns element's itemref content attribute.
(WebCore::HTMLElement::setItemRef): Sets itemref value on changing elemet's
itemref attribute.
(WebCore::HTMLElement::setItemValue): Sets element's itemvalue. If the element has no
itemprop attribute or if element has an itemscope attribute, it throws INVALID_ACCESS_ERR
exception.
(WebCore::HTMLElement::itemValue): Returns the elements itemvalue.

If the element has no itemprop attribute it returns null.
If the element has an itemscope attribute, it returns the element itself.
If the element is a meta element: It acts as it would if it was reflecting the element's
content content attribute.
If the element is an audio, embed, iframe, img, source, track, or video element: It acts
as it would if it was reflecting the element's src content attribute.
If the element is an a, area, or link element: It act as it would if it was reflecting the
href content attribute.
If the element is an object element: It acts as it would if it was reflecting the element's
data content attribute.

(WebCore::HTMLElement::itemValueText):
(WebCore::HTMLElement::setItemValueText):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::itemValueText):
(WebCore::HTMLEmbedElement::setItemValueText):

  • html/HTMLEmbedElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::itemValueText):
(WebCore::HTMLIFrameElement::setItemValueText):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::itemValueText):
(WebCore::HTMLImageElement::setItemValueText):

  • html/HTMLImageElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::itemValueText):
(WebCore::HTMLLinkElement::setItemValueText):

  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::itemValueText):
(WebCore::HTMLMediaElement::setItemValueText):

  • html/HTMLMediaElement.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::itemValueText):
(WebCore::HTMLMetaElement::setItemValueText):

  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::itemValueText):
(WebCore::HTMLObjectElement::setItemValueText):

  • html/HTMLObjectElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::itemValueText):
(WebCore::HTMLSourceElement::setItemValueText):

  • html/HTMLSourceElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::itemValueText):
(WebCore::HTMLTrackElement::setItemValueText):

  • html/HTMLTrackElement.h:
  • html/MicroDataItemValue.cpp: Added.

(WebCore::MicroDataItemValue::MicroDataItemValue):
(WebCore::MicroDataItemValue::createFromString):
(WebCore::MicroDataItemValue::createFromNode):

  • html/MicroDataItemValue.h: Added.

(WebCore::MicroDataItemValue::isNode):
(WebCore::MicroDataItemValue::getNode):
(WebCore::MicroDataItemValue::getString):

LayoutTests:

Added test-cases for Microdata itemprop, itemref, itemvalue attributes.

  • fast/dom/MicroData/002-expected.txt:
  • fast/dom/MicroData/002.html:
  • fast/dom/MicroData/003-expected.txt:
  • fast/dom/MicroData/003.html:
  • fast/dom/MicroData/005-expected.txt:
  • fast/dom/MicroData/005.html:
  • fast/dom/MicroData/006-expected.txt:
  • fast/dom/MicroData/009.html:
  • fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Added.
  • fast/dom/MicroData/itemprop-add-remove-tokens.html: Added.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Added.
  • fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Added.
  • fast/dom/MicroData/itemprop-must-be-read-only.html: Added.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Added.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Added.
  • fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Added.
  • fast/dom/MicroData/itemref-add-remove-tokens.html: Added.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Added.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Added.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Added.
  • fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Added.
  • fast/dom/MicroData/itemref-must-be-read-only.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-href-attr.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Added.
  • fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-returns-element-itself.html: Added.
  • fast/dom/MicroData/itemvalue-returns-null-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-returns-null.html: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Added.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Added.
  • fast/dom/MicroData/resources/microdata-common.js:

(createElement):
(runTest):

17:00 Changeset [98299] by fpizlo@apple.com

Object-or-other branch speculation may corrupt the state for OSR if the child of the
branch is an integer
https://bugs.webkit.org/show_bug.cgi?id=70777

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

LayoutTests:

  • fast/js/dfg-other-branch-expected.txt: Added.
  • fast/js/dfg-other-branch.html: Added.
  • fast/js/script-tests/dfg-other-branch.js: Added.

(foo):
(bar):

16:45 Changeset [98298] by jchaffraix@webkit.org

Unreviewed gardening.

Bug 58013 has landed 3 months ago and it looks like the rebaseline was forgotten.
The new result is consistent with the other platforms.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:43 Changeset [98297] by leviw@chromium.org

Switching FloatingObjectTree/Interval to use rounded ints instead of LayoutUnits to correct comparisons with the line box tree.

16:22 Changeset [98296] by fpizlo@apple.com

op_new_array_buffer is not inlined correctly
https://bugs.webkit.org/show_bug.cgi?id=70770

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Disabled inlining of op_new_array_buffer, for now.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-inline-new-array-buffer-expected.txt: Added.
  • fast/js/dfg-inline-new-array-buffer.html: Added.
  • fast/js/script-tests/dfg-inline-new-array-buffer.js: Added.

(foo):
(bar):

16:03 Changeset [98295] by joepeck@webkit.org

Remove unused instance variable
https://bugs.webkit.org/show_bug.cgi?id=70750

Reviewed by Dimitri Glazkov.

  • rendering/RenderTextControl.h:
16:02 Changeset [98294] by thakis@chromium.org

[chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

  • WebCore.gyp/WebCore.gyp:
15:56 Changeset [98293] by timothy_horton@apple.com

feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
https://bugs.webkit.org/show_bug.cgi?id=70035
<rdar://problem/10280177>

Reviewed by Nikolas Zimmermann.

Make feColorMatrix's type attribute be "matrix" by default.

Test: svg/filters/feColorMatrix-default-type.svg

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):

15:51 Changeset [98292] by commit-queue@webkit.org

[EFL] Build fix. Rename all instances of a variable when it gets changed
https://bugs.webkit.org/show_bug.cgi?id=70732

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

  • ewk/ewk_js.cpp:

(ewk_js_property_set): s/obj/object/

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add): s/exec/executeState/

15:51 Changeset [98291] by commit-queue@webkit.org

Add boolean speculations to DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=70706

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

Different from the boolean speculations in DFG 64, the boolean
speculations in DFG 32_64 will use a 32bit GPR to hold the primitive
boolean instead of a JSBoolean. This choice is not only for
performance, but also to save a register as we're short of registers on
X86.
To accomplish this we make use of DataFormatBoolean, allow a value to
be represented as a primitive boolean and converted from/to a
JSBoolean.
This patch also fixes SpillOrder in 32_64, which should be different
from 64, and fixes needDataFormatConversion logic in 32_64.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest32):

We don't expect byte test actually as it doesn't work for registers
esp..edi on X86.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::checkConsistency):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::cellResult):
(JSC::DFG::booleanResult):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

15:49 Changeset [98290] by commit-queue@webkit.org

[EFL] Build fix. Add include path to find npapi.h
https://bugs.webkit.org/show_bug.cgi?id=70730

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

  • DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
15:39 Changeset [98289] by tony@chromium.org

Unbreak binding generation tests
https://bugs.webkit.org/show_bug.cgi?id=70768

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Darin Adler.

Update the expected output of V8 binding tests to match
results c/o https://bugs.webkit.org/show_bug.cgi?id=70065

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::idbKeyCallback):

15:26 Changeset [98288] by eric@webkit.org

Plugin tests are failing after switching WK2 to NRWT
https://bugs.webkit.org/show_bug.cgi?id=70760

Reviewed by Simon Fraser.

Perpetuate this horrible hack.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:19 Changeset [98287] by leviw@chromium.org

Adding Chromium expectations from http://trac.webkit.org/changeset/98263

Unreviewed.

  • platform/chromium-cg-mac-snowleopard/svg/as-object: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object: Removed.
  • platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:15 Changeset [98286] by leviw@chromium.org

Fixing a collision in Mac results and adding qt results from http://trac.webkit.org/changeset/98263

Unreviewed test expectations update.

  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Fixing collision that removes

an empty text node.

  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt: Added.
15:07 Changeset [98285] by weinig@apple.com

Hook up minimalist load delegate to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70764

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
Add loadDelegate getter/setter. As per convention, the delegate is not
retained.

(didStartProvisionalLoadForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(setUpPageLoaderClient):
(-[WKBrowsingContextController initWithPageRef:]):
Hookup the delegate to a WKPageLoaderClient.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Added.

Add load delegate as a proper protocol.

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

14:58 Changeset [98284] by commit-queue@webkit.org

Unreviewed, rolling out r98266.
http://trac.webkit.org/changeset/98266
https://bugs.webkit.org/show_bug.cgi?id=70767

Broke the chromium build. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

  • features.gypi:
14:29 Changeset [98283] by lforschler@apple.com

Versioning.

14:19 Changeset [98282] by nduca@chromium.org

[chromium] Add isTraceEventEnabled to PlatformSupport.
https://bugs.webkit.org/show_bug.cgi?id=70618

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::isTraceEventEnabled):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::isTraceEventEnabled):

14:01 Changeset [98281] by mihnea@adobe.com

Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
https://bugs.webkit.org/show_bug.cgi?id=70746

Reviewed by Tony Chang.

Covered by existing tests.

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::rulesText):

  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::selectorsText):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssText): Use CSSRuleList::rulesText() method instead of explicit loop.

13:57 Changeset [98280] by msaboff@apple.com

WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Source/WebCore:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue. Changed MemoryPressureHandler::install
to use new function.

Reviewed by Geoffrey Garen.

No new tests. Moved functionality to WebKitSystemInterface.

  • WebCore.exp.in:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

13:54 Changeset [98279] by eric@webkit.org

NRWT doesn't support ORWT's --root option, but should
https://bugs.webkit.org/show_bug.cgi?id=70416

Reviewed by Dirk Pranke.

Add support for ORWT's --root option which is used for
running tests with a nightly build of WebKit.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/base.py:
    • webkit_build_path was never called by any code, removed.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13:51 Changeset [98278] by commit-queue@webkit.org

IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
https://bugs.webkit.org/show_bug.cgi?id=70065

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(TypeCanFailConversion):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::continueFunction):

  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBKey.cpp:

(WebCore::IDBKey::IDBKey):
(WebCore::IDBKey::compare):

  • storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):

  • storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • storage/IDBKeyRange.h:

(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • storage/IDBKeyRange.idl:
  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::keyFromQuery):

Source/WebKit/chromium:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

  • src/AssertMatchingEnums.cpp:
  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::assignNull):

LayoutTests:

Updated expectations now that most tests match spec. Includes change to
objectstore-basics test to avoid hitting https://bugs.webkit.org/show_bug.cgi?id=70041
since this CL stops hiding that bug.

  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/open-cursor-expected.txt:
13:48 Changeset [98277] by alokp@chromium.org

[chromium] Make accelerated drawing work with threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70656

Reviewed by James Robinson.

Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

13:47 Changeset [98276] by mhahnenberg@apple.com

Fixing Windows build

Unreviewed build fix

13:41 Changeset [98275] by adamk@chromium.org

Optimize Node::isInShadowTree to execute in constant-time
https://bugs.webkit.org/show_bug.cgi?id=67686

Reviewed by Dimitri Glazkov.

No expected change in behavior, so no new tests.

  • dom/Node.cpp:

(WebCore::Node::isInShadowTree):

13:40 Changeset [98274] by ojan@chromium.org

Some more fixups from http://trac.webkit.org/changeset/98265.

The leopard bot results are incorrect, but that's because the
chromium leopard bots have not compiled in a few days. Once
the bots are fixed, we'll need to rebaseline this test again for
leopard.

  • platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
13:35 Changeset [98273] by lforschler@apple.com

New tag.

13:32 Changeset [98272] by lforschler@apple.com

Fix Localization.

13:11 Changeset [98271] by nduca@chromium.org

[chromium] Expose WebThread::postDelayedTask to CCThread
https://bugs.webkit.org/show_bug.cgi?id=70712

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCThread.h:

Source/WebKit/chromium:

  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::postDelayedTask):

  • src/CCThreadImpl.h:
12:55 Changeset [98270] by weinig@apple.com

Add URL getters for the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70752

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(autoreleased):
Added helpers for autoreleasing.

(-[WKBrowsingContextController activeURL]):
Added buy not implemented yet.

(-[WKBrowsingContextController pendingURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController commitedURL]):
(-[WKBrowsingContextController unreachableURL]):
Added getters.

(-[WKBrowsingContextController title]):
Convert to new autoreleased helper.

12:53 Changeset [98269] by nduca@chromium.org

[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
https://bugs.webkit.org/show_bug.cgi?id=70688

Reviewed by Tony Chang.

  • tests/RunAllTests.cpp:

(main):

  • tests/WebUnitTests.cpp:

(WebKit::InitTestSuite):
(WebKit::RunAllUnitTests):
(WebKit::DeleteTestSuite):

  • tests/WebUnitTests.h:
12:41 Changeset [98268] by commit-queue@webkit.org

BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Geoffrey Garen.

Current BitVector uses the highest bit of m_bitsOrPointer to indicate
whether it's an inlined bit set or a pointer to an outOfLine bit set.
This check may fail in case the pointer also has the highest bit set,
which is surely possible on IA32 (Linux).
In this case the check failure can result in unexpected behaviors,
for example if the BitVector is incorrectly determined as having an
inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
modify the memory adjacent to the BitVector object.
This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
or outofline, based on the assumption that the pointer to OutOfLineBits
should be 4 or 8 byte aligned.
We could mark the lowest bit (bit 0) with 1 for inlined bit set,
and bits 1~bitsInPointer are used for bit set/test.
In this case we need do one bit more shift for bit set/test.

  • wtf/BitVector.cpp:

(WTF::BitVector::resizeOutOfLine):

  • wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):

12:40 Changeset [98267] by jchaffraix@webkit.org

Unreviewed rebaseline of svg/W3C-SVG-1.1-SE/coords-units-03-b.html

The new baselines all match the existing ones. Not sure if we really pass the test as
2 lines should be 200px but at least all the baselines are consistent (within some font
differences).

  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
12:29 Changeset [98266] by commit-queue@webkit.org

Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-24
Reviewed by David Levin.

  • features.gypi:
12:22 Changeset [98265] by ojan@chromium.org

Cleanup some test expectations missed in r98183.

  • platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
  • platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
  • platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
  • platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:02 Changeset [98264] by levin@chromium.org

check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
https://bugs.webkit.org/show_bug.cgi?id=70747

Reviewed by Tony Chang.

  • Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
11:56 Changeset [98263] by leviw@chromium.org

<svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
11:41 Changeset [98262] by commit-queue@webkit.org

Node::registeredMutationObserversOfType should be prefixed by "get"
https://bugs.webkit.org/show_bug.cgi?id=70359

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-24
Reviewed by Ojan Vafai.

This change renames Node::registeredMutationObserversOfType to
Node::getRegisteredMutationObserversOfType per the WebKit style guide.

No tests needed as the change is only method renaming.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:
11:37 Changeset [98261] by mhahnenberg@apple.com

Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
https://bugs.webkit.org/show_bug.cgi?id=70271

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renaming versions of getOwnPropertySlot that use an unsigned as the property
name to "getOwnPropertySlotByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlotByIndex):

  • runtime/Arguments.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlotVirtual):
(JSC::JSByteArray::getOwnPropertySlotByIndex):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlotVirtual):
(JSC::JSCell::getOwnPropertySlotByIndex):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlotVirtual):
(JSC::JSNotAnObject::getOwnPropertySlotByIndex):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlotByIndex):

  • runtime/JSObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlotByIndex):

  • runtime/JSString.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlotVirtual):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlotVirtual):
(JSC::StringObject::getOwnPropertySlotByIndex):

  • runtime/StringObject.h:

Source/WebCore:

No new tests.

Renaming versions of getOwnPropertySlot that use an unsigned as the property
name to "getOwnPropertySlotByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlotVirtual):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):

  • bridge/runtime_array.h:
11:37 Changeset [98260] by jchaffraix@webkit.org

Unreviewed gardening rebaselining.

Updating those baselines as they match Mac and looks like progressions. Linux was needing a wrong
rebaseline, so it was not rebaselined.

  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint: Added.
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium/test_expectations.txt:
11:36 Changeset [98259] by weinig@apple.com

Add zoom and title support to Objective-C WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=70744

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):

11:31 Changeset [98258] by commit-queue@webkit.org

IndexedDB add should fail adding an inline and passed key simultaneously
https://bugs.webkit.org/show_bug.cgi?id=58598

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html

Implement the spec clause: passing a key into add() or put() when
the object store has a key path ("inline key") is an error.

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html: Added.
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Added.
11:29 Changeset [98257] by lforschler@apple.com

Versioning.

11:07 Changeset [98256] by msaboff@apple.com

WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Added new WebKitSystemInterface method CreateVMPressureDispatchOnMainQueue.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:05 Changeset [98255] by simon.fraser@apple.com

Improve debug compositing border colors
https://bugs.webkit.org/show_bug.cgi?id=70742

Reviewed by Dean Jackson.

Improve the appearance of the debug borders used to indicate compositing:

  1. Use green for normal layers, orange for tiled layers
  2. Make the repaint counter translucent
  3. Change the color of the repaint counter to show when accelerated drawing is enabled.
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::updateDebugIndicators):

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

10:54 Changeset [98254] by leviw@chromium.org

Fixing repaint issues from truncated damage rects. Fixing a remaining loop in RenderDeprecatedFlexibleBox. Properly constructing FloatWithRect with a LayoutRect, which fixes lots of line layout issues.

10:34 Changeset [98253] by caryclark@google.com

Unreviewed gardening: third chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 743 files for brevity.]

  • platform/chromium-mac-leopard/fast/block/positioning/absolute-length-of-neg-666666-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.

...

  • platform/chromium-mac-leopard/fast/lists/ol-display-types-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/ol-start-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/olstart-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:33 Changeset [98252] by kbalazs@webkit.org

[Qt][WK2] Crash when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=70725

Reviewed by Chang Shu.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

10:24 Changeset [98251] by abarth@webkit.org

Attempt to fix Windows build by updating to the new interface.

  • DOMEventsClasses.cpp:

(DOMEvent::createInstance):

09:44 Changeset [98250] by carlosgc@webkit.org

[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69745

Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:
09:39 Changeset [98249] by jchaffraix@webkit.org

[chromium] New failing test fast/events/dropzone-002.html
https://bugs.webkit.org/show_bug.cgi?id=61625

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: The test has been passing

on all platforms except leopard for several days.

09:31 Changeset [98248] by apavlov@chromium.org

Merge 98243 - Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Reviewed by Pavel Feldman.

Source/WebCore:

We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt:
  • inspector/styles/styles-add-new-rule.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/8380009

08:54 Changeset [98247] by vsevik@chromium.org

Merge 97975 - Web Inspector: Advanced search results should keep working after pretty print toggled.
https://bugs.webkit.org/show_bug.cgi?id=70347

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchScope.prototype.createSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
(WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._materializeBreakpoint):

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane):
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
(WebInspector.ScriptsSearchResultsPane.LinkifierFormatter):
(WebInspector.ScriptsSearchResultsPane.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):

  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/raw-source-code.html:

BUG=101016
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8382007

08:26 Changeset [98246] by lforschler@apple.com

Versioning.

08:24 Changeset [98245] by carlosgc@webkit.org

[GTK] Initial implementation of back forward list for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69343

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitBackForwardList.cpp: Added.

(webkitBackForwardListFinalize):
(webkit_back_forward_list_init):
(webkit_back_forward_list_class_init):
(webkitBackForwardListGetOrCreateItem): Helper function that
creates a new WebKitBackForwardListItem for the given
WebBackForwardListItem or returns it from the cache if it's
already cached.
(webkitBackForwardListCreateList): Helper function to convert a
WKArray of WebBackForwardListItems into a GList of
WebKitBackForwardListItems.
(webkitBackForwardListCreate): Create a new WebKitBackForwardList.
(webkitBackForwardListChanged): Emits changed signal when the back
forward list changes.
(webkit_back_forward_list_get_current_item):
(webkit_back_forward_list_get_back_item):
(webkit_back_forward_list_get_forward_item):
(webkit_back_forward_list_get_nth_item):
(webkit_back_forward_list_get_length):
(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):

  • UIProcess/API/gtk/WebKitBackForwardList.h: Added.
  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Added.

(webkitBackForwardListItemFinalize):
(webkit_back_forward_list_item_init):
(webkit_back_forward_list_item_class_init):
(historyItemsMap): Global cache for WebKitBackForwardListItems.
(webkitBackForwardListItemFinalized):
(webkitBackForwardListItemGetOrCreate): Helper function that
creates a new WebKitBackForwardListItem for the given
WebBackForwardListItem or returns it from the global cache if it's
already cached.
(webkit_back_forward_list_item_get_uri):
(webkit_back_forward_list_item_get_title):
(webkit_back_forward_list_item_get_original_uri):

  • UIProcess/API/gtk/WebKitBackForwardListItem.h: Added.
  • UIProcess/API/gtk/WebKitBackForwardListPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didChangeBackForwardList): Call webkitBackForwardListChanged() to
notify that the list has changed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didChangeBackForwardList.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkit_web_view_get_back_forward_list): Return the back forward
list of the view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new test.
  • UIProcess/API/gtk/tests/TestBackForwardList.cpp: Added.

(serverCallback):
(testBackForwardListNavigation):
(testBackForwardListLimitAndCache):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/TestMain.h:

(Test::~Test): Check there are no objects leaked.
(Test::objectFinalized): Callback called when a GObject is
deleted, used to remove the watched object the list.
(Test::assertObjectIsDeletedWhenTestFinishes): Add an object to
the list of watched objects and add a weak pointer to remove it
from the list when the object is finalized. If there aren't
objects leaked, the list should be empty when the test finishes.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest): Watch the web view to make sure it's
not leaked.

  • UIProcess/API/gtk/tests/WebViewTest.h: Make WebViewTest inherit

from Test class.

  • UIProcess/API/gtk/webkit2.h: Include WebKitBackForwardList.h and

WebKitBackForwardListItem.h.

  • UIProcess/API/gtk/webkit2marshal.list:
08:23 Changeset [98244] by lforschler@apple.com

New tag.

08:23 Changeset [98243] by apavlov@chromium.org

Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Reviewed by Pavel Feldman.

Source/WebCore:

We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt:
  • inspector/styles/styles-add-new-rule.html:
08:20 Changeset [98242] by lforschler@apple.com

Versioning.

08:17 Changeset [98241] by carlosgc@webkit.org

[GTK] Add helper function to set the loader client in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70594

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetLoaderClient): Helper function to set the loader
client.
(webkitWebViewConstructed): Use webkitWebViewSetLoaderClient() to
avoid unnecessary checks.
(webkit_web_view_set_loader_client): Use
webkitWebViewSetLoaderClient().

08:14 Changeset [98240] by pfeldman@chromium.org

Web Inspector: do not force document loading on reload (should happen on demand).
https://bugs.webkit.org/show_bug.cgi?id=70724

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._documentUpdated):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.setVisible):

LayoutTests:

  • inspector/debugger/dom-breakpoints.html:
  • inspector/debugger/error-in-watch-expressions.html:
07:56 Changeset [98239] by carlosgc@webkit.org

[GTK] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=70717

Reviewed by Xan Lopez.

With newer glib it's not needed anymore and with previous versions
it was already called by g_type_init().

Source/WebKit/gtk:

  • tests/testapplicationcache.c:

(main):

  • tests/testatk.c:

(main):

  • tests/testatkroles.c:

(main):

  • tests/testcopyandpaste.c:

(main):

  • tests/testdomdocument.c:

(main):

  • tests/testdomdomwindow.c:

(main):

  • tests/testdomnode.c:

(main):

  • tests/testdownload.c:

(main):

  • tests/testglobals.c:

(main):

  • tests/testhittestresult.c:

(main):

  • tests/testhttpbackend.c:

(main):

  • tests/testkeyevents.c:

(main):

  • tests/testloading.c:

(main):

  • tests/testmimehandling.c:

(main):

  • tests/testnetworkrequest.c:

(main):

  • tests/testnetworkresponse.c:

(main):

  • tests/testwebbackforwardlist.c:

(main):

  • tests/testwebdatasource.c:

(main):

  • tests/testwebframe.c:

(main):

  • tests/testwebhistoryitem.c:

(main):

  • tests/testwebplugindatabase.c:

(main):

  • tests/testwebresource.c:

(main):

  • tests/testwebsettings.c:

(main):

  • tests/testwebview.c:
  • tests/testwindow.c:

(main):

Source/WebKit2:

  • UIProcess/API/gtk/tests/TestMain.cpp:

(main):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(main):

  • GtkLauncher/main.c:

(main):

  • MiniBrowser/gtk/main.c:

(main):

07:41 Changeset [98238] by eric.carlson@apple.com

Drop MutableTextTrack and make TextTrack always mutable
https://bugs.webkit.org/show_bug.cgi?id=62890

The MutableTextTrack type was removed from the spec, all text tracks are now mutable.

Reviewed by Sam Weinig.

No new tests needed, the changes just refactor existing code.

  • CMakeLists.txt: Remove all traces of MutableTextTrack.
  • CodeGenerators.pri: Ditto.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/gobject/GNUmakefile.am: Ditto.
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
  • bindings/js/JSTextTrackCustom.cpp: Removed.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTrack): Return a TextTrack instead of a MutableTextTrack.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Return a TextTrack instead of a MutableTextTrack.

  • html/MutableTextTrack.cpp: Removed.
  • html/MutableTextTrack.h: Removed.
  • html/MutableTextTrack.idl: Removed.
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Remove Type parameter.
(WebCore::TextTrack::addCue): New, moved from MutableTextTrack.
(WebCore::TextTrack::removeCue): Ditto.
(WebCore::TextTrack::newCuesLoaded): Ditto.
(WebCore::TextTrack::fetchNewestCues): Ditto.

  • html/TextTrack.h:

(WebCore::TextTrack::create): Remove Type parameter

  • html/TextTrack.idl: Add addCue and removeCue.
07:32 Changeset [98237] by yurys@chromium.org

Web Inspector: allow debugging dedicated worker initialization
https://bugs.webkit.org/show_bug.cgi?id=70723

Source/WebCore:

Now it is possible to pause each new dedicated worker on start. The user
needs to select a checkbox and then each newly created dedicated worker
will be paused on the first statement until the user resumes it explicitely.

Reviewed by Pavel Feldman.

  • inspector/Inspector.json: resume command is added. It is similar to GDB's run

command, i.e. worker execution will be paused until explicit "resume" command is
received.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStartImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::resume):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart): returns true
if the user chose to automatically pause all new workers.

  • inspector/InspectorWorkerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::resume):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.loadCompleted):
(WebInspector.WorkerManager.prototype._workerCreated):
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._openInspectorWindow):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):

  • workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

  • workers/WorkerContextProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext): additional flag specifying
worker initial state(paused/not paused) is added to the factory method. The flag
will be carried to the corresponding WorkerThread.
(WebCore::WorkerMessagingProxy::connectToInspector):

  • workers/WorkerMessagingProxy.h:

Source/WebKit/chromium:

Pass worker thread start mode to the worker thread.

Reviewed by Pavel Feldman.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

  • src/WebWorkerClientImpl.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
06:52 Changeset [98236] by pfeldman@chromium.org

Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986

Add a setting to choose an indent from "8 spaces", "4 spaces" (default), "2 spaces", or "Tab character".

Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-10-21
Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get p):
(WebInspector.SettingsScreen.prototype._createSelectSetting.changeListener):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel):

  • inspector/front-end/TextViewer.js:
06:31 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
05:52 Changeset [98235] by alex@webkit.org

2011-10-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip failing test in GTK, added bug 70720. Rebaseline
prototype-inheritance-2.html.

  • platform/gtk/Skipped: skipped fast/events/event-creation.html.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Reset expected results after r98199.
05:23 Changeset [98234] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

  • DEPS:
05:08 Changeset [98233] by caseq@chromium.org

Web Inspector: add "Add to Watch" option to context menu on selection in source frame
https://bugs.webkit.org/show_bug.cgi?id=69924

Reviewed by Pavel Feldman.

  • added 'Add to Watch' context menu item in scripts panel;
  • include both default and custom items into a context menu if selection is present;
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegate.prototype.addToWatch):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
(WebInspector.WatchExpressionsSection.prototype.addExpression):
(WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):

04:04 Changeset [98232] by apavlov@chromium.org

Web Inspector: Audits hang on pages without img[src] elements
https://bugs.webkit.org/show_bug.cgi?id=70604

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/audits/audits-panel-noimages-functional.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

LayoutTests:

  • inspector/audits/audits-panel-noimages-functional-expected.txt: Added.
  • inspector/audits/audits-panel-noimages-functional.html: Added.
03:29 Changeset [98231] by commit-queue@webkit.org

[Qt] fast/events/media-focus-in-standalone-media-document.html fails
https://bugs.webkit.org/show_bug.cgi?id=70110

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-10-24
Reviewed by Simon Hausmann.

Source/WebCore:

ExtensionMap should also include media files mapping.

  • platform/qt/MIMETypeRegistryQt.cpp: Added media files mapping.

Source/WebKit/qt:

We should check for supported media mime types as well in the MIMETypeRegistry.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType): check for supported media mime type.

LayoutTests:

Remove media-focus-in-standalone-media-document.html from Qt Skipped test list.

  • platform/qt/Skipped:
03:10 Changeset [98230] by pfeldman@chromium.org

2011-10-24 Pavel Feldman <pfeldman@google.com>

Not reviewed: [chromium] follow up to 98228 - added missing css.

  • WebCore.gypi:
03:01 Changeset [98229] by vsevik@chromium.org

Merge 97959 - Web Inspector: Enable support for advanced search in script's static content provider.
https://bugs.webkit.org/show_bug.cgi?id=70354

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-static.html

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showSourceLine):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/search/search-in-static-expected.txt: Added.
  • http/tests/inspector/search/search-in-static.html: Added.

BUG=101008
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8368025

03:01 Changeset [98228] by pfeldman@chromium.org

Web Inspector: Make CSS files load upon View demand; split inspector.css into views.
https://bugs.webkit.org/show_bug.cgi?id=70694

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

  • inspector/front-end/PanelEnablerView.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView):

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TextViewer.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WelcomeView.js:

(WebInspector.WelcomeView):

  • inspector/front-end/auditsPanel.css: Renamed from Source/WebCore/inspector/front-end/audits.css.
02:40 Changeset [98227] by pfeldman@chromium.org

Web Inspector: make view load CSS files upon show.
https://bugs.webkit.org/show_bug.cgi?id=70696

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/view-css.html

  • inspector/front-end/View.js:

(WebInspector.View):
(WebInspector.View.prototype._callOnVisibleChildren):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processWillHide):
(WebInspector.View.prototype._processWasHidden):
(WebInspector.View.prototype._processOnResize):
(WebInspector.View.prototype.show):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.registerRequiredCSS):
(WebInspector.View.prototype._loadCSSIfNeeded):
(WebInspector.View.prototype._doLoadCSS):
(WebInspector.View.prototype._disableCSSIfNeeded):
(WebInspector.View.prototype._doUnloadCSS):

LayoutTests:

  • inspector/view-css-expected.txt: Added.
  • inspector/view-css.html: Added.
  • inspector/view-events-expected.txt:
  • inspector/view-events.html:
02:26 Changeset [98226] by commit-queue@webkit.org

[Qt][WK2] WebView does not get focus when being clicked / touched in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=70613

Make TouchWebView and DesktopWebView take the focus whenever it receives
a MouseClick or a TouchEvent.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-24
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::touchEvent):

  • UIProcess/API/qt/qtouchwebview.h:
02:25 Changeset [98225] by pfeldman@chromium.org

Web Inspector: make DataGrid a view
https://bugs.webkit.org/show_bug.cgi?id=70695

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.onResize):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._queryFinished):
(WebInspector.DatabaseQueryView.prototype._queryError):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._queryFinished):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype.onResize):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.onResize):
(WebInspector.NetworkLogView.prototype._createTable):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView):

01:54 Changeset [98224] by commit-queue@webkit.org

[GTK] [WK2] Memory leaks in WebContextGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=70505

Free the output of g_build_filename()

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2011-10-24
Reviewed by Martin Robinson.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

01:52 Changeset [98223] by rgabor@webkit.org

[Qt] Unreviewed gardening after r98199

Patch by Kosztyo Kristof <kkristof@inf.u-szeged.hu> on 2011-10-24

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
01:14 Changeset [98222] by commit-queue@webkit.org

[Forms] Setting defaultValue should hide an input placeholder.
https://bugs.webkit.org/show_bug.cgi?id=70586

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-10-24
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/placeholder-and-default-value-expected.html

fast/forms/placeholder-and-default-value.html

When input element has default value, we should not display
placeholder. Changing default value should tell rendering engine about
changing display of input element.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Calls updatePlaceholderVisibility for valueAttr if it doesn't have dirty value.

LayoutTests:

This test checks "value" attribute (default value) changing in two
ways, one is using setDefault method and another is setAttribute
method.

  • fast/forms/placeholder-and-default-value-expected.html: Added. Render text input element with "Default" value.
  • fast/forms/placeholder-and-default-value.html: Added. Render text input element with placeholder attribute and a script to change default value of input element to "Default" from empty.
00:53 Changeset [98221] by alex@webkit.org

2011-10-24 Alejandro G. Castro <alex@igalia.com>

[WK2] [GTK] WebKitTestRunner crashes with heap corruption
https://bugs.webkit.org/show_bug.cgi?id=69403

We did not added autotoolsconfig.h to the config.h file and we
were adding Platform.h without the config.h in the
WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
the Prefix file.

Reviewed by Martin Robinson.

  • WebKitTestRunner/WebKitTestRunnerPrefix.h:
00:42 Changeset [98220] by paroga@webkit.org

Interpreter build fix after r98179.

  • bytecode/CodeBlock.h:

Moved CodeBlock::baselineVersion() into ENABLE(JIT) block,
since it is only used there.

10/23/11:

23:59 Changeset [98219] by darin@apple.com

Eliminate OptionElement (second and final part)
https://bugs.webkit.org/show_bug.cgi?id=70710

Reviewed by Kent Tamura.

  • CMakeLists.txt: Removed OptionElement.h and OptionElement.cpp.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/OptionElement.cpp: Removed.
  • dom/OptionElement.h: Removed.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveLastSelection): Eliminate use of the
toOptionElement function. Use hasTagName and toHTMLOptionElement instead.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
(WebCore::HTMLSelectElement::recalcListItems): Ditto.
(WebCore::HTMLSelectElement::selectedIndex): Ditto.
(WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
(WebCore::HTMLSelectElement::saveFormControlState): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
(WebCore::HTMLSelectElement::appendFormData): Ditto.
(WebCore::HTMLSelectElement::reset): Ditto.
(WebCore::HTMLSelectElement::updateSelectedState): Ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

  • html/HTMLSelectElement.h: Changed the argument type of the

deselectItemsWithoutValidation function to HTMLElement* since that's
the type of an item in our items vector now.

23:54 Changeset [98218] by yuzo@google.com

[chromium] Attempt to fix compilation error for Chromium OS.

Unreviewed.

  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind):

22:53 Changeset [98217] by ggaren@apple.com

Fixed a typo Darin spotted.

  • wtf/StringHasher.h:

(WTF::StringHasher::hash): Expelliarmus!

22:51 Changeset [98216] by ggaren@apple.com

Removed StringImpl::createStrippingNullCharacters
https://bugs.webkit.org/show_bug.cgi?id=70700

Reviewed by David Levin.

It was unused.

21:36 Changeset [98215] by abarth@webkit.org

<img crossorigin> should fail to load when CORS check fails
https://bugs.webkit.org/show_bug.cgi?id=69732

Reviewed by Darin Adler.

Source/WebCore:

When loading an image with the crossorigin attribute, the spec says
that we're not supposed to load the image if the CORS check fails.
This "fails fast" behavior is intended to help developers understand
whether they've configured CORS correctly (instead of only catching the
error later when trying to read back the canvas).

Our new behavior matches the spec and Firefox.

Test: http/tests/security/img-with-failed-cors-check-fails-to-load.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that images loaded with the crossorigin attribute fail to load if
the CORS access check doesn't pass.

  • http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt: Added.
  • http/tests/security/img-with-failed-cors-check-fails-to-load.html: Added.
20:58 Changeset [98214] by fpizlo@apple.com

DFG should inline constructors
https://bugs.webkit.org/show_bug.cgi?id=70675

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Adds support for inlining constructors. Also fixes two pathologies
uncovered along the way: CheckMethod claimed that it never returned a
result (causing CheckMethod -> SetLocal -> GetLocal sequences to
result in the GetLocal doing OSR exit), and get_by_id parsing never
checked if it was hot in slow path. Also fiddled with inlining
heuristics; it appears that for now, the more inlining, the happier
V8 is. Finally, a bug was uncovered where a silent spill of a boxed
integer that had previously been spilled unboxed causes the silent
fill to forget to unbox.

This appears to be a 4% speed-up on V8 in their harness, or a 1%
speed-up in my harness. The difference is due to warm-up: in my
harness we see significant amounts of time spent in compilation, but
in V8's harness compilation gets amortizes. Profiling indicates that
we have the potential for a 5% win from basic optimizations like
generating OSR exits lazily and holding onto bytecode longer.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::mightInlineFunctionFor):
(JSC::DFG::canInlineFunctionFor):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

  • runtime/Executable.h:

(JSC::isCall):
(JSC::ExecutableBase::intrinsicFor):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:

LayoutTests:

Reviewed by Oliver Hunt.

Adds test that asserts that register pressure induced by inlining doesn't
result in spilling corrupting values.

  • fast/js/dfg-inlining-reg-alloc-expected.txt: Added.
  • fast/js/dfg-inlining-reg-alloc.html: Added.
  • fast/js/script-tests/dfg-inlining-reg-alloc.js: Added.

(foo):
(bar):
(baz):

20:40 Changeset [98213] by yuzo@google.com

[chromium] Test expecation change. inspector/elements/edit-dom-actions.html times out since around r98120:98133 (chromium 106751:106770).

Unreviewed.

  • platform/chromium/test_expectations.txt:
19:57 Changeset [98212] by commit-queue@webkit.org

[EFL] Remove unused code from EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=70590

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-23
Reviewed by Andreas Kling.

Removed unused function on_closeWindow from EWebLauncher

  • EWebLauncher/main.c:
19:54 Changeset [98211] by yuzo@google.com

[chromium] Test expectation change for "r98183 causes 4 snowleopard tests to fail".
https://bugs.webkit.org/show_bug.cgi?id=70704

Unreviewed.

  • platform/chromium/test_expectations.txt:
19:23 Changeset [98210] by noel.gordon@gmail.com

[chromium] Remove RopeImpl.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70703

Reviewed by Kent Tamura.

runtime/RopeImpl.{h,cpp} were removed in r97872, remove references
to these files from the gyp project files.

19:18 Changeset [98209] by noel.gordon@gmail.com

[chromium] Remove GeolocationServiceGtk.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70702

Reviewed by Kent Tamura.

platform/gtk/GeolocationServiceGtk.{h,cpp} were removed in r97746, so
remove references to these files from the gyp files.

  • WebCore.gypi:
18:49 Changeset [98208] by commit-queue@webkit.org

Move StyleSheet::addSubresourceStyleURLs() to CSSStyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70690

Patch by Andreas Kling <kling@webkit.org> on 2011-10-23
Reviewed by Antti Koivisto.

This method isn't part of the StyleSheet DOM interface, nor is it used by
XSLStyleSheet, so move it down to CSSStyleSheet and make it non-virtual.
Also remove some nearby unneeded casts from CSSStyleSheet* to StyleSheet*.

  • css/CSSStyleSheet.h:
  • css/StyleSheet.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
(WebCore::HTMLStyleElement::disabled):
(WebCore::HTMLStyleElement::setDisabled):

18:42 Changeset [98207] by commit-queue@webkit.org

Remove style sheet constructors that take a style sheet parent.
https://bugs.webkit.org/show_bug.cgi?id=70692

Patch by Andreas Kling <kling@webkit.org> on 2011-10-23
Reviewed by Antti Koivisto.

Style sheets are never directly parented by other style sheets, they always
go via a rule (such as @import.)

  • css/CSSStyleSheet.cpp:
  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):

  • css/StyleSheet.cpp:
  • css/StyleSheet.h:
17:37 Changeset [98206] by macpherson@chromium.org

Add watchlist for WebCore/css and put myself on it.
https://bugs.webkit.org/show_bug.cgi?id=70701

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:

Add watchlist for WebCore/css and put myself on it.

17:21 Changeset [98205] by mhahnenberg@apple.com

Add deleteProperty to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70162

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • JavaScriptCore.exp:
  • runtime/ClassInfo.h: Added both versions of deleteProperty to the MethodTable.
  • runtime/JSFunction.h: Changed JSFunction::deleteProperty to

be protected rather than private for subclasses who don't provide their own
implementation.

Source/WebCore:

No new tests.

  • WebCore.exp.in:
17:11 Changeset [98204] by abarth@webkit.org

Update baselines for run-bindings-tests.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
14:14 Changeset [98203] by mhahnenberg@apple.com

Remove getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=70638

Reviewed by Darin Adler.

Source/JavaScriptCore:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:

(JSObjectIsConstructor):
(JSObjectCallAsConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::getConstructData):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSObject.h:

(JSC::getConstructData):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::construct):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::construct):

Source/WebKit2:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
11:01 Changeset [98202] by ggaren@apple.com

Not reviewed.

Updated two test results I missed in my last check-in.

These tests depended on non-deterministic effects of hash order, so I
had to update them:

  • http/tests/inspector/search/search-in-resources-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
00:34 Changeset [98201] by ggaren@apple.com

Try to fix the SL build.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): Cast
away int vs unisgned warning.

00:27 Changeset [98200] by commit-queue@webkit.org

[GTK] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=69410

Tools:

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-10-23
Reviewed by Martin Robinson.

Implement the KeyDown function on Gtk platform.

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::dispatchEvent):
(WTR::getModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip passed tests.

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-10-23
Reviewed by Martin Robinson.

  • platform/gtk-wk2/Skipped:
00:21 Changeset [98199] by ggaren@apple.com

Separated string lifetime bits from character buffer state bits
https://bugs.webkit.org/show_bug.cgi?id=70673

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Moved the static/immortal bit into the bottom bit of the refcount, and
moved all other bits into the high bits of the hash code.

This is the first step toward a new Characters/PassString class, and it
makes ref/deref slightly more efficient.

  • create_hash_table:
  • wtf/StringHasher.h:

(WTF::StringHasher::hash): Tweaked the string hashing function to leave
the top bits clear, so they can be used as flags.

Fixed some small differences between the PERL copy of this function and
the C++ copy of this function, which could have in theory caused subtle
crashes.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::sharedBuffer):
(WTF::StringImpl::createWithTerminatingNullCharacter):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::cost): Renamed s_refCountFlagShouldReportedCost to
s_didReportExtraCost, since the original name was both self-contradictory
and used as a double-negative.

(WTF::StringImpl::isIdentifier):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::hasTerminatingNullCharacter):
(WTF::StringImpl::isAtomic):
(WTF::StringImpl::setIsAtomic):
(WTF::StringImpl::setHash):
(WTF::StringImpl::rawHash):
(WTF::StringImpl::hasHash):
(WTF::StringImpl::existingHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::hasOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringImpl::bufferOwnership):
(WTF::StringImpl::isStatic): Moved the static/immortal bit into the bottom
bit of the refcount. Now, all lifetime information lives in the refcount
field. Moved the other bits into the hash code field.

Source/WebCore:

Reviewed by Anders Carlsson.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashValue): Updated for string hashing changes in JavaScriptCore.

LayoutTests:

Reviewed by Anders Carlsson.

These tests depended on non-deterministic effects of hash order, so I
had to update them:

  • fast/dom/prototype-inheritance-2-expected.txt: Updated for slightly

different order of discovering properties.

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js: Updated not to depend on iteration

order, since that's not what this test is about.

  • http/tests/inspector/inspector-test.js: Updated not to depend on

global function iteration order. This test setup is pretty spaghetti.
I think I avoided making it even more spaghetti.

  • inspector/storage-panel-dom-storage-expected.txt: Updated for changed

iteration order.

Note: See TracTimeline for information about the timeline view.