Timeline


and

11/01/11:

23:26 Changeset [99040] by leviw@chromium.org

Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
https://bugs.webkit.org/show_bug.cgi?id=71321

Reviewed by Darin Adler.

Updating the usage of LayoutUnits in the *View classes to mirror the proper use
as derived in the subpixellayout branch.

This entails scrolling only with integers (and rounding once we've made the switch)
and using integers for window coordinates, with LayoutUnits for content coordinates.

No new tests -- no change in behavior.

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::zoomAnimatorTransformChanged):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::updateScrollCorner):

  • page/FrameView.h:

(WebCore::FrameView::trackedRepaintRects):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutWidth):
(WebCore::ScrollView::layoutHeight):
(WebCore::ScrollView::fixedLayoutSize):
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::scrollbarAtPoint):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::visibleWidth):
(WebCore::ScrollView::visibleHeight):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::adjustScrollPositionWithinRange):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):

  • rendering/RenderView.h:

(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):

22:48 Changeset [99039] by annacc@chromium.org

Small fixes for WebVTTParser.
https://bugs.webkit.org/show_bug.cgi?id=71334

Reviewed by Darin Adler.

No new tests. This is needed to enable other tests, coming soon.

  • html/track/WebVTTParser.cpp:

(WebCore::hasLongWebVTTIdentifier): changed to return true when header is

exactly "WEBVTT"

(WebCore::WebVTTParser::collectTimingsAndSettings): fix typos, position should

only progress once when checking the character after a timestamp.

20:34 Changeset [99038] by imasaki@chromium.org

2011-11-01 Kenji Imasaki <imasaki@chromium.org>

[Chromium] Unreviewed. Did rebaselines of media/media-document-audio-repaint.html.

  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
20:20 Changeset [99037] by weinig@apple.com

resolve-ChangeLogs --help should be faster.

Reviewed by Adam Roben.

  • Scripts/resolve-ChangeLogs:

(usageAndExit):
Add a call to usageAndExit() before doing work to find unmerged changelogs
if --help or something illegal is provided on the command line.

19:52 Changeset [99036] by darin@apple.com

Cut down on malloc/free a bit in the parser arena
https://bugs.webkit.org/show_bug.cgi?id=71343

Reviewed by Oliver Hunt.

  • parser/ParserArena.cpp:

(JSC::ParserArena::deallocateObjects): Call the destructors of
the deletable objects before freeing the pools. Don't call
fastFree on the deletable objects any more.

  • parser/ParserArena.h:

(JSC::ParserArena::allocateDeletable): Use allocateFreeable
instead of fastMalloc here.

19:47 Changeset [99035] by darin@apple.com

Change HTMLSelectElement::setSelectedIndex to use enums instead of bools
https://bugs.webkit.org/show_bug.cgi?id=70184

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring that does not require new tests.

  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLSelectElement _activateItemAtIndex:]): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
(-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]): Ditto.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setSelected): Replaced setSelectedIndex call with a
call to the new optionSelectionStateChanged function.
(WebCore::HTMLOptionElement::insertedIntoTree): Ditto.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement): Updated since m_userDrivenChange
was renamed to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::optionSelectedByUser): Removed deselect argument,
which was always true for all callers. Updated comment.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Updated comment.
(WebCore::HTMLSelectElement::setOption): Call the new optionSelectionStateChanged
function. The code used to explicitly ask the function it calls to deselect base
on the value of m_multiple, but that is no longer needed because the selectOption
function itself takes care of that check.
(WebCore::HTMLSelectElement::dispatchChangeEventForMenuList): Renamed this function.
Also updated for name change to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::setSelectedIndex): Moved the formerly-inlined function
here from the header and changed it to call the renamed selectOption function.
(WebCore::HTMLSelectElement::optionSelectionStateChanged): Added this function.
It is used by callers that were previously using setSelectedIndex and passing
"false" for the deselect argument. It's better now that setSelectedIndex is now a
pure DOM setter function without the multiple purposes it had before. This function
now has the logic that handles the special handling when deselecting an option,
which used to be at the top of the next function.
(WebCore::HTMLSelectElement::selectOption): Renamed this from setSelectedIndex.
Replaced boolean arguments with flags. Removed code to handle the special case
when we deselect an option; that's now handled in the optionSelectionStateChanged
function. Added an assertion to replace a comment and updated for other renaming.
(WebCore::HTMLSelectElement::dispatchBlurEvent): Updated for name change.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Changed to call the
new selectOption function and also updated for other name changes.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

  • html/HTMLSelectElement.h: Changed the setSelectedIndex to be a pure setter

function for the selectedIndex DOM property. Added a optionSelectedByUser function
for the other use of setSelectedIndex, but removed the always true "deselect"
argument from it. Added a optionSelectionStateChanged function for use in the
HTMLOptionElement implementation. Renamed menuListOnChange to
dispatchChangeEventForMenuList for clarity. Added a SelectOptionFlag and
SelectOptionFlags type for the arguments to the selectOption function, formerly
implemented as an overload of setSelectedIndex (and called setSelectedIndexInternal
before that). Renamed m_userDrivenChange to m_isProcessingUserDrivenChange.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.

Source/WebKit/chromium:

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.

19:24 Changeset [99034] by weinig@apple.com

Implement lookupGetter/lookupSetter in terms of getPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71336

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerActivation.h:

Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.

  • runtime/JSObject.cpp:

(JSC::JSObject::lookupGetter):
(JSC::JSObject::lookupSetter):

  • runtime/JSObject.h:

De-virtualize lookupGetter/lookupSetter, and implement them in terms of
getPropertyDescriptor.

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • page/DOMWindow.idl:

Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.

LayoutTests:

  • fast/dom/getter-on-window-object2-expected.txt:

Update results now that lookupGetter/lookupSetter match getOwnPropertyDescriptor.
The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.

19:18 Changeset [99033] by nduca@chromium.org

[chromium] Move resource-releasing logic into CCProxy and cleanup setNeedsCommit
https://bugs.webkit.org/show_bug.cgi?id=71269

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::setVisible):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setVisible):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::composite):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestScrollSimple::beginTest):
(CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):

19:16 Changeset [99032] by cevans@google.com

Merge 98935
BUG=101018
Review URL: http://codereview.chromium.org/8386021

19:08 Changeset [99031] by commit-queue@webkit.org

[Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
https://bugs.webkit.org/show_bug.cgi?id=71342

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-01
Reviewed by Darin Adler.

Tools:

[NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
[NSString substringFromIndex:] with an index out of the string range.

The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
from the root of the disk.
The problem was hidden because the exception are catched when calling the delegate.

This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
in a subdirectory of the main frame.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[NSURL _drt_descriptionSuitableForTestResult]):

LayoutTests:

Update the test results following the fix of _drt_descriptionSuitableForTestResult.

  • webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
19:08 Changeset [99030] by cevans@google.com

Merge 98763
BUG=99597
Review URL: http://codereview.chromium.org/8423033

19:05 Changeset [99029] by cevans@google.com

Merge 98561
BUG=100526
Review URL: http://codereview.chromium.org/8399045

18:53 Changeset [99028] by cevans@google.com

Merge 98033
BUG=99603
Review URL: http://codereview.chromium.org/8372052

18:52 Changeset [99027] by annacc@chromium.org

Makes [Reflect] work for constants.
This is needed to avoid platform-specific define conflicts, specifically
TextTrack::ERROR conflicts with a windows define.
https://bugs.webkit.org/show_bug.cgi?id=70951

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-constants.html

  • bindings/scripts/CodeGenerator.pm:

(GenerateCompileTimeCheckForEnumsIfNeeded):

Check for [Reflect] and assign name accordingly.

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Update test file.
  • bindings/scripts/test/JS/JSTestObj.cpp: Update test file.

(WebCore::jsTestObjCONST_JAVASCRIPT):

  • bindings/scripts/test/JS/JSTestObj.h: Update test file.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Update test file.
  • bindings/scripts/test/TestObj.idl: Update test file.
  • bindings/scripts/test/V8/V8TestObj.cpp: Update test file.
  • html/LoadableTextTrack.cpp: Use new DOM const name.

(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):

  • html/TextTrack.cpp: Use new DOM const name.

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):

  • html/TextTrack.h: Use new DOM const name.
  • html/TextTrack.idl: Use Reflect for ERROR, but leave other DOM const names.

LayoutTests:

  • media/track/track-constants-expected.txt: Added.
  • media/track/track-constants.html: Added.
  • media/track/track-load-error-readyState.html: Updated with new const name.
  • media/track/track-load-from-element-readyState.html: Updated with new const name.
  • media/track/track-load-from-src-readyState.html: Updated with new const name.

VIDEO_TRACK is not enabled on these ports, so skipping this test:

  • platform/mac/Skipped:
  • platform/win/Skipped:
18:51 Changeset [99026] by cevans@google.com

Merge 98010
BUG=100177
Review URL: http://codereview.chromium.org/8437038

18:42 Changeset [99025] by cevans@google.com

Merge 98344
BUG=100863
Review URL: http://codereview.chromium.org/8440026

18:33 Changeset [99024] by leviw@chromium.org

Amend missing uses of LayoutUnit in RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=71254

Reviewed by Darin Adler.

Switching relevant uses of integers in RenderBlock to LayoutUnits.

No new tests -- no changes in behavior.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintContents):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::baselinePosition):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::FloatWithRect::FloatWithRect):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):

18:32 Changeset [99023] by cevans@google.com

Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/8437036

18:23 Changeset [99022] by macpherson@chromium.org

WIP: Add CSS property to control printing of backgrounds for individual elements.
https://bugs.webkit.org/show_bug.cgi?id=64583

Reviewed by Eric Seidel.

Added test LayoutTests/fast/css/webkit-color-adjust.html,
Updated tests under LayoutTests/fast/css/getComputedStyle
Updated test under LayoutTests/svg/css

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialForceBackgroundsToWhite):

18:20 Changeset [99021] by dominicc@chromium.org

Remove initErrorEvent method
https://bugs.webkit.org/show_bug.cgi?id=71338

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/ErrorEvent.cpp: Crush.
  • dom/ErrorEvent.h: Kill.
  • dom/ErrorEvent.idl: Destroy.

LayoutTests:

  • http/tests/workers/worker-importScriptsOnError-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
18:12 Changeset [99020] by jchaffraix@webkit.org

Pack RenderTableCell bits
https://bugs.webkit.org/show_bug.cgi?id=71135

Reviewed by Darin Adler.

Source/WebCore:

Tested by RenderTableCellTest unit test.
(unfortunately Chromium specific...)

This saves another 8 bytes on RenderTableCell on x86-64.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

Changed the field order to use more strict packing.

(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::setRow):
Added overflow checks to the 2 previous methods. We
CRASH even in release to avoid potential badness
(the limit is currently above 2 billions rows or columns
which is high enough to prevent it being hit by accident)

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/RenderTableCellTest.cpp: Added.

Added some tests for the column/row index limit
that was implemented in RenderTableCell.

17:55 Changeset [99019] by eae@chromium.org

Switch background/border image back to Int
https://bugs.webkit.org/show_bug.cgi?id=71240

Reviewed by Darin Adler.

Switch background- and border-image rendering back to int to align with
device pixels.

No new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::calculateAdjustedInnerBorder):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):

17:36 Changeset [99018] by mhahnenberg@apple.com

De-virtualize JSObject::defineSetter
https://bugs.webkit.org/show_bug.cgi?id=71303

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

(JSC::DebuggerActivation::defineSetter):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineSetter):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineSetter):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::defineSetter):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineSetter):

Source/WebCore:

No new tests.

Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineSetter):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::defineSetter):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

17:34 Changeset [99017] by timothy_horton@apple.com

SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>

Reviewed by Darin Adler.

Fix svg/filters/invalidate-on-child-layout.svg to not include nonexistent onload handler.

  • svg/filters/invalidate-on-child-layout.svg:
17:15 Changeset [99016] by eae@chromium.org

Switch PopupMenuClient to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71308

Reviewed by Darin Adler.

Switch PopupMenuClient and rendering classes implementing it to layout
type abstraction.

No new tests.

  • platform/PopupMenuClient.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
Revert scroll positions and scroll offsets to ints to align with device
pixels.

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

  • rendering/RenderTextControlSingleLine.h:
17:09 Changeset [99015] by japhet@chromium.org

Source/WebCore: [chromium] As of r98380, ThreadableLoaderClients are having their
ResourceRequest::TargetType clobbered. They set their own
type, but CachedResourceRequest (through which they now flow)
sets a TargetType without bothering to see if one has already been set.
https://bugs.webkit.org/show_bug.cgi?id=70972

Reviewed by Darin Fisher.

No new tests, this is chromium-specific and only affects
behavior seen in full builds of chromium.

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):Don't setTargetType()

if the value is something other than the default already.

  • platform/network/chromium/ResourceRequest.h: Change default

TargetType to TargetIsUnspecified.

Source/WebKit/chromium: Add 2 new TargetTypes (to match ResourceRequest::TargetType)
and ensure we don't pass chromium a TargetType it doesn't
yet understand.
https://bugs.webkit.org/show_bug.cgi?id=70972

Reviewed by Darin Fisher.

  • public/WebURLRequest.h:
  • src/WebURLRequest.cpp:
17:08 Changeset [99014] by eae@chromium.org

Use IntPoint for screen coordinates in MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=71327

Reviewed by Darin Adler.

Change mouse events to use int/IntPoint for screen/window coordinates and
LayoutUnit/LayoutPoint for coordinates adjusted for zooming.

No new tests.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::computeRelativePosition):

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::screenLocation):
Revert screenLocation and windowLocation back to int.

  • page/DragController.cpp:

(WebCore::elementUnderMouse):
Change elementUnderMouse to use a LayoutPoint for hit testing.

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:

Revert m_currentMousePosition to IntPoint as it represents a
screen coordinate.

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):
Revert PlatformMouseEvent to int/IntPoint as it represents a screen
coordinate.

16:58 Changeset [99013] by tony@chromium.org

REGRESSION: -webkit-flex() should be an invalid value
https://bugs.webkit.org/show_bug.cgi?id=71320

Reviewed by Ojan Vafai.

This regressed in http://trac.webkit.org/changeset/98773 .

No new tests, covered by css3/flexbox/flex-parsing.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

16:53 Changeset [99012] by johnnyg@google.com

Rebaseline getter-on-window-object2.html after r99005.

  • platform/chromium/fast/dom/getter-on-window-object2-expected.txt: Added.
16:33 Changeset [99011] by dgrogan@chromium.org

IndexedDB: get EventQueue from ScriptExecutionContext instead of Document
https://bugs.webkit.org/show_bug.cgi?id=71147

When IDB is used from a worker thread ScriptExecutionContext will
be a WorkerContext, not a Document. This was the impetus behind
moving EventQueue into ScriptExecutionContext in r98656.

Reviewed by Nate Chapin.

No new tests. No new functionality yet.

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::enqueueEvent):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::enqueueEvent):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::enqueueEvent):

16:31 Changeset [99010] by commit-queue@webkit.org

CSS: Remove unused virtual parseString() in style and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=71300

Patch by Andreas Kling <kling@webkit.org> on 2011-11-01
Reviewed by Darin Adler.

  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.cpp:
  • css/WebKitCSSKeyframeRule.h:
16:13 Changeset [99009] by fpizlo@apple.com

DFG inlining breaks function.arguments
https://bugs.webkit.org/show_bug.cgi?id=71329

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The DFG was forgetting to store code origin mappings for inlined
call sites. Some of the fast-path optimizations for
CallFrame::trueCallerFrame() were wrong. An assertion in Arguments
was wrong.

I also took the opportunity to decrease code duplication between
DFG64 and DFG32_64, because I didn't feel like writing the same
code twice.

  • bytecode/CodeBlock.h:

(JSC::ExecState::isInlineCallFrame):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGNode.h:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:
  • runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):

LayoutTests:

Reviewed by Oliver Hunt.

Test that using bar.arguments, where bar was inlined into baz,
works correctly.

  • fast/js/dfg-inline-arguments-simple-expected.txt: Added.
  • fast/js/dfg-inline-arguments-simple.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-simple.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

16:02 Changeset [99008] by eae@chromium.org

Switch RenderObject to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71249

Switch RenderObject to LayoutRect/Size/Point abstraction.

Reviewed by Darin Adler.

No new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::viewRect):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localCaretRect):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::maximalOutlineSize):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::absoluteOutlineBounds):
(WebCore::RenderObject::outlineBoundsForRepaint):
(WebCore::adjustForAbsoluteZoom):

16:01 Changeset [99007] by tony@chromium.org

Update result to match mac repaint result. When we forced a layout on
the test (when landing the mac-sl results), it caused this result to
change slightly.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
15:53 Changeset [99006] by alokp@chromium.org

[chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71318

Reviewed by James Robinson.

Fixed a typo for --enable-hardware-gpu flag.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:36 Changeset [99005] by weinig@apple.com

Expand fast/dom/getter-on-window-object2.html to test Object.getOwnPropertyDescriptor as well
https://bugs.webkit.org/show_bug.cgi?id=71332

Reviewed by Anders Carlsson.

  • fast/dom/getter-on-window-object2-expected.txt:
  • fast/dom/getter-on-window-object2.html:

Convert to shouldBe style tests and expand test to also test Object.getOwnPropertyDescriptor,
which currently fail for getters/setters defined over window properties.

15:32 Changeset [99004] by commit-queue@webkit.org

[chromium] Media Stream API: Adding supporting classes to WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=71008

Expanding WebMediaStreamDescriptor and adding WebMediaStreamSource

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-01
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.

(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::~WebMediaStreamSource):
(WebKit::WebMediaStreamSource::isNull):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::initialize):

  • src/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.

(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::reset):
(WebKit::WebMediaStreamSource::operator PassRefPtr<MediaStreamSource>):
(WebKit::WebMediaStreamSource::operator MediaStreamSource*):
(WebKit::WebMediaStreamSource::initialize):
(WebKit::WebMediaStreamSource::id):
(WebKit::WebMediaStreamSource::type):
(WebKit::WebMediaStreamSource::name):

15:12 Changeset [99003] by johnnyg@google.com

Suppress svg/filters/invalidate-on-child-layout.svg until the fix lands.

  • platform/chromium/test_expectations.txt:
15:06 Changeset [99002] by xji@chromium.org

Refactor: change Scrollable::m_scrollOrigin from protected to private.
https://bugs.webkit.org/show_bug.cgi?id=71236

Reviewed by Darin Adler.

Only refactor, no new tests needed.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::computeScrollDimensions):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):

14:54 Changeset [99001] by lforschler@apple.com

Versioning.

14:50 Changeset [99000] by lforschler@apple.com

Merged r98824.

14:45 Changeset [98999] by lforschler@apple.com

New Tag.

14:32 Changeset [98998] by weinig@apple.com

Expand prototype setting test to test Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=71322

Reviewed by Anders Carlsson.

  • fast/js/script-tests/prototypes.js:

Also test setting proto using Object.defineProperty.

13:55 Changeset [98997] by dominicc@chromium.org

display: table-cell and box-sizing: border-box calculates content-box height
https://bugs.webkit.org/show_bug.cgi?id=69425

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/box-sizing/table-cell.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

  • fast/box-sizing/table-cell-expected.txt: Added.
  • fast/box-sizing/table-cell.html: Added.
13:52 Changeset [98996] by imasaki@chromium.org

[Chromium] Unreviewed. Remove media/audio-repaint.html from test expectaion.

  • platform/chromium/test_expectations.txt:
13:40 Changeset [98995] by lforschler@apple.com

New tag.

13:13 Changeset [98994] by nduca@chromium.org

CCSchedulerTests fail on Chromium Windows (dbg) after r98915
https://bugs.webkit.org/show_bug.cgi?id=71294

Reviewed by James Robinson.

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

12:52 Changeset [98993] by commit-queue@webkit.org

StringImpl::reallocate() should have a 8-bit version
https://bugs.webkit.org/show_bug.cgi?id=71210

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-01
Reviewed by Geoffrey Garen.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::reallocate):

  • wtf/text/StringImpl.h:
12:28 Changeset [98992] by commit-queue@webkit.org

chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71286

Patch by Elliot Poger <epoger@google.com> on 2011-11-01
Reviewed by Stephen White.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
12:24 Changeset [98991] by leandro@webkit.org

[EFL] Unreviewed. Add remaining pixel baselines.

  • platform/efl/http: Added.
  • platform/efl/http/tests: Added.
  • platform/efl/http/tests/local: Added.
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/efl/http/tests/misc: Added.
  • platform/efl/http/tests/misc/acid2-expected.png: Added.
  • platform/efl/http/tests/misc/error404-expected.png: Added.
  • platform/efl/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/efl/http/tests/misc/frame-access-during-load-expected.png: Added.
  • platform/efl/http/tests/misc/generated-content-inside-table-expected.png: Added.
  • platform/efl/http/tests/misc/iframe404-expected.png: Added.
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.png: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/efl/http/tests/navigation: Added.
  • platform/efl/http/tests/navigation/error404-basic-expected.png: Added.
  • platform/efl/http/tests/navigation/error404-goback-expected.png: Added.
  • platform/efl/http/tests/navigation/error404-subframeload-expected.png: Added.
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/efl/http/tests/navigation/postredirect-basic-expected.png: Added.
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.png: Added.
  • platform/efl/http/tests/security: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
  • platform/efl/http/tests/uri: Added.
  • platform/efl/http/tests/uri/css-href-expected.png: Added.
  • platform/efl/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/efl/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/efl/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/efl/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/efl/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/efl/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/efl/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
12:18 Changeset [98990] by alokp@chromium.org

[chromium] Add testing for --enable-accelerated-drawing
https://bugs.webkit.org/show_bug.cgi?id=70822

Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/accelerated-drawing/alpha.html

  • WebCore.exp.in:
  • page/Settings.cpp:
  • page/Settings.h:

(WebCore::Settings::setAcceleratedDrawingEnabled):

  • testing/Internals.cpp:

(WebCore::Internals::setAcceleratedDrawingEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • platform/chromium/compositing/accelerated-drawing: Added.
  • platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Added.
  • platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Added.
  • platform/chromium/compositing/accelerated-drawing/alpha.html: Added.
12:13 Changeset [98989] by timothy_horton@apple.com

SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>

Reviewed by Nikolas Zimmermann.

Call SVGResourcesCache::clientLayoutChanged whenever the element or its children need layout. Previously,
invalidation was only performed if the element itself needed layout; now we also invalidate if any child
needs layout and there is a filter applied, as the cached filter result can depend on the layout of children.

Test: svg/filters/invalidate-on-child-layout.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):

Add a test that ensures that changing the layout of a child of a filtered element invalidates the filter.

  • platform/mac/svg/filters/invalidate-on-child-layout-expected.png: Added.
  • platform/mac/svg/filters/invalidate-on-child-layout-expected.txt: Added.
  • svg/filters/invalidate-on-child-layout.svg: Added.
12:05 Changeset [98988] by jer.noble@apple.com

Four media tests failing on Lion due to incorrect cached times.
https://bugs.webkit.org/show_bug.cgi?id=69574

Reviewed by Eric Carlson.

Source/WebCore:

Do not invalidate the cached time when receiving a mediaPlayerRateChanged notification
while paused. AVFoundation in particular can return different results for currentTime()
when asked after being paused, breaking layout tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

LayoutTests:

Some media engines will cause multiple timeupdate events after pausing; so deregister
the timeupdate event listener after receiving the first one.

  • media/video-pause-immediately.html:
11:54 Changeset [98987] by gavinp@chromium.org

properly end requests when a bad status code return happens
https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.
There is a chromium test going through code review at http://codereview.chromium.org/8404001/

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

11:40 Changeset [98986] by rniwa@webkit.org

Rebaseline after r98896.

  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  • platform/chromium-win-vista/fast/forms: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
11:39 Changeset [98985] by arv@chromium.org

Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
https://bugs.webkit.org/show_bug.cgi?id=64628

Reviewed by Adam Barth.

Covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.idl:
11:37 Changeset [98984] by rniwa@webkit.org

Rebaseline after r98979.

  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  • platform/chromium-win-vista/fast/forms: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
11:30 Changeset [98983] by abecsi@webkit.org

[Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295

Reviewed by Simon Hausmann.

Suppress superfluous debug messages of Qt5.

  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
  • UIProcess/API/qt/tests/util.cpp:

(messageHandler):

  • UIProcess/API/qt/tests/util.h:
11:30 Changeset [98982] by leandro@webkit.org

[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

  • platform/efl/fast/table: [...]
  • platform/efl/fast/text: [...]
  • platform/efl/fast/tokenizer: [...]
  • platform/efl/fast/transforms: [...]
  • platform/efl/fast/writing-mode: [...]
  • platform/efl/fast/xsl: [...]
11:07 Changeset [98981] by imasaki@chromium.org

[Chromium] Unreviewed. Did rebaselines of media/audio-repaint.html

  • platform/chromium-gpu-linux/media/audio-repaint-expected.png:
11:02 Changeset [98980] by jchaffraix@webkit.org

REGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowStruct grid
https://bugs.webkit.org/show_bug.cgi?id=71246

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-empty-section-calcBorder.html

fast/table/crash-empty-section-fixed-layout-calcArray.html

The refactoring in r98738 changed the way we handle the size to avoid throwing off
the memory. The new logic would end up never shrinking the grid's size (prior to that
we would grow to the appropriate size and throw the excess capacity with shrinkToFit).
Not shrinking would mean that we would potentially read RowStruct with the default values
(for instance no |rowRenderer|).

addCell will properly grow the grid as needed to accomodate the rows and the protruding
cells with a rowspan so we introduce a variable to keep track of the size needed. At the
end, we just shrink it to this size.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::recalcCells):
Introduce a variable to keep the grid size and shrink to that size to match the old code.

LayoutTests:

Those tests checks that an empty section would not lead to reading
RowStruct without a |rowRenderer| which would crash.

  • fast/table/crash-empty-section-calcBorder-expected.txt: Added.
  • fast/table/crash-empty-section-calcBorder.html: Added.
  • fast/table/crash-empty-section-fixed-layout-calcArray-expected.txt: Added.
  • fast/table/crash-empty-section-fixed-layout-calcArray.html: Added.
10:59 Changeset [98979] by caseq@chromium.org

Unreviewed followup for the previous commit (removing another duplicate line).

  • platform/chromium/test_expectations.txt:
10:57 Changeset [98978] by caseq@chromium.org

[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
https://bugs.webkit.org/show_bug.cgi?id=71277

Reviewed by Simon Fraser.

Source/WebCore:

Disabled assert() in hasVisibleDescendant() until callers are fixed.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant):

LayoutTests:

  • platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().
10:35 Changeset [98977] by lforschler@apple.com

Merge r98936 and update Versioning.

10:31 Changeset [98976] by arv@chromium.org

Unreviewed. Fix ChangeLog which broke in r98733.

10:19 Changeset [98975] by hausmann@webkit.org

[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
https://bugs.webkit.org/show_bug.cgi?id=71299

Reviewed by Andreas Kling.

Source/WebKit/qt:

Export an overload of QtDRT::injectInternalsObjects that is used by
the WK2 injected bundle.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::injectInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt

build to enable WebCoreTestSupport::injectInternalsObject.
(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
10:11 Changeset [98974] by leandro@webkit.org

[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

  • platform/efl/fast/media: [...]
  • platform/efl/fast/multicol: [...]
  • platform/efl/fast/overflow: [...]
  • platform/efl/fast/parser: [...]
  • platform/efl/fast/reflections: [...]
  • platform/efl/fast/regions: [...]
  • platform/efl/fast/repaint: [...]
  • platform/efl/fast/replaced: [...]
  • platform/efl/fast/ruby: [...]
  • platform/efl/fast/runin: [...]
  • platform/efl/fast/selectors: [...]
10:05 Changeset [98973] by jocelyn.turcotte@nokia.com

[Qt] Merge common desktop and touch view APIs under a base class.
https://bugs.webkit.org/show_bug.cgi?id=71280

Reviewed by Andreas Kling.

Source/WebKit2:

  • Make QDesktopWebView and QTouchWebView inherit from QBaseWebView.
  • Move methods from QTouchWebPage to QTouchWebView (through the base class).

We use the same convenience macros as Qt internally by hiding QObject::d_ptr
with QBaseWebView::d_ptr instead of inheriting QBaseWebViewPrivate from
QQuickItemPrivate.
Also, QBaseWebView currently inherits from QQuickPaintedItem since QDesktopWebView
needs it, but should be changed as soon as this is not required anymore.

  • UIProcess/API/qt/qbasewebview.cpp: Added.

(QBaseWebViewPrivate::QBaseWebViewPrivate):
(QBaseWebViewPrivate::setPageProxy):
(QBaseWebView::QBaseWebView):
(QBaseWebView::~QBaseWebView):
(QBaseWebView::load):
(QBaseWebView::url):
(QBaseWebView::loadProgress):
(QBaseWebView::title):
(QBaseWebView::navigationController):
(QBaseWebView::preferences):

  • UIProcess/API/qt/qbasewebview.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
  • UIProcess/API/qt/qbasewebview_p.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.

(QBaseWebViewPrivate::~QBaseWebViewPrivate):

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
(QDesktopWebViewPrivate::webView):
(QDesktopWebViewPrivate::setViewNeedsDisplay):
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::hasFocus):
(QDesktopWebViewPrivate::isVisible):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeUrl):
(QDesktopWebViewPrivate::didChangeTitle):
(QDesktopWebViewPrivate::didChangeStatusText):
(QDesktopWebViewPrivate::loadDidBegin):
(QDesktopWebViewPrivate::loadDidSucceed):
(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebViewPrivate::init):
(QDesktopWebView::~QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
(QDesktopWebView::pageRef):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
(QDesktopWebViewPrivate::engine):
(QDesktopWebViewPrivate::chooseFiles):
(QDesktopWebViewPrivate::_q_onOpenPanelFilesSelected):
(QDesktopWebViewPrivate::_q_onOpenPanelFinished):
(QDesktopWebViewPrivate::didMouseMoveOverElement):
(QDesktopWebViewPrivate::navigationPolicyForURL):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPageProxy):
(QTouchWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:

(QTouchWebPagePrivate::touchPageProxy):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::QTouchWebView):
(QTouchWebView::~QTouchWebView):
(QTouchWebView::page):
(QTouchWebView::geometryChanged):
(QTouchWebView::onVisibleChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:

(QTouchWebViewPrivate::touchPageProxy):

  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::load):
(WebViewAbstraction::url):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationStatusAtStartup):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::didChangeViewportProperties):
(WebKit::QtTouchViewInterface::didChangeUrl):
(WebKit::QtTouchViewInterface::didChangeTitle):
(WebKit::QtTouchViewInterface::loadDidBegin):
(WebKit::QtTouchViewInterface::loadDidCommit):
(WebKit::QtTouchViewInterface::loadDidSucceed):
(WebKit::QtTouchViewInterface::loadDidFail):
(WebKit::QtTouchViewInterface::didChangeLoadProgress):

  • WebKit2API.pri:

Tools:

Remove unneded forwarding logic for TouchWebView since those properties are
now in the view just as the desktop web view.

  • MiniBrowser/qt/qml/TouchView.qml:
09:51 Changeset [98972] by andersca@apple.com

PluginProxy shouldn't use window-relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71261

Reviewed by Adam Roben.

Change PluginProxy::wantsWindowRelativeCoordinates to return false and remove
m_frameRectInWindowCoordinates and m_clipRectInWindowCoordinates. This is yet another step
towards eliminating window-relative coordinates wherever possible.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Since the dirty rect passed to paint is now in plug-in coordinates, there's no need to convert it
from window coordinates to plug-in coordinates before passing it to BackingStore::paint.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Assert that we're not calling this anymore.

(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return false.

09:45 Changeset [98971] by alokp@chromium.org

Roll chromium DEPS.

Unreviewed.

  • DEPS:
09:28 Changeset [98970] by darin@apple.com

Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
https://bugs.webkit.org/show_bug.cgi?id=71289

Reviewed by Dan Bernstein.

Just adding a null check. I don't have access to an actual PDF with
this problem but crashes from the field indicate they exist.

  • WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument): Skip the code to add the script text
to an array when the script is null.

08:59 Changeset [98969] by reed@google.com

[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
https://bugs.webkit.org/show_bug.cgi?id=71284

Reviewed by Stephen White.

No new tests. This is preparing for an API change to Skia.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):

08:56 Changeset [98968] by leandro@webkit.org

[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

  • platform/efl/fast/html: [...]
  • platform/efl/fast/images: [...]
  • platform/efl/fast/inline-block: [...]
  • platform/efl/fast/inline: [...]
  • platform/efl/fast/innerHTML: [...]
  • platform/efl/fast/inspector-support: [...]
  • platform/efl/fast/invalid: [...]
  • platform/efl/fast/layers: [...]
  • platform/efl/fast/lists: [...]
  • platform/efl/fast/loader: [...]
08:47 Changeset [98967] by andreas.kling@nokia.com

CSSStyleSheet: Operate directly on the rule vector internally.

Rubber-stamped by Antti Koivisto.

There's no need to go through the public, range-checking item() method
working on m_children. Also changed length() -> m_children.size().

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

08:44 Changeset [98966] by caseq@chromium.org

Unreviewed. Fixed conflicting entries in test expectations.

  • platform/chromium/test_expectations.txt:
08:40 Changeset [98965] by kenneth@webkit.org

The QtViewportInteractionEngine should consider DPI adjustment
https://bugs.webkit.org/show_bug.cgi?id=71283

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qtouchwebview.cpp:

Add some default values for now to make sure we are testing the
DPI adjustment / CSS-item space conversion.

(QTouchWebViewPrivate::updateViewportConstraints):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):

Clean up the guard to be more understandable.

(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):

Add methods for converting between CSS and item space.

(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):

Make it clean which methods uses which coord space.

(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemScale):

Rename calculateBoundariesForScale and change its implementation to
be correct. The new name reflects the space in which the computation
takes place and reflects similar Qt API.

(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

Make sure to consider the right coord space.

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::Constraints::Constraints):

Add the devicePixelRatio.

08:32 Changeset [98964] by caseq@chromium.org

Unreviewed. Marked inspector extensions tests as crash on win debug.

  • platform/chromium/test_expectations.txt:
08:23 Changeset [98963] by andreas.kling@nokia.com

CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285

Reviewed by Antti Koivisto.

Move addSubresourceStyleURLs() into the rules that actually implement it.
Add type checks and casts at the (only) call site.

  • css/CSSFontFaceRule.h:
  • css/CSSImportRule.h:
  • css/CSSRule.h:
  • css/CSSStyleRule.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

08:19 Changeset [98962] by cfleizach@apple.com

AX: some popup buttons not announced by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=67743

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Added.
  • platform/mac/accessibility/aria-popup-buttons-on-native-elements.html: Added.
08:16 Changeset [98961] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
08:02 Changeset [98960] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
07:41 Changeset [98959] by hausmann@webkit.org

Prospective clang build fix.

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent): Handle GestureSingleTap in the event type switch.

06:58 Changeset [98958] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix chromium interactive tests.

  • src/js/Tests.js: (.TestSuite.prototype.showPanel):
06:34 Changeset [98957] by caio.oliveira@openbossa.org

[Qt] Create infrastructure for Qt's builtin bundle in web process.
https://bugs.webkit.org/show_bug.cgi?id=71279

Reviewed by Simon Hausmann.

Create a builtin bundle for Qt port: an InjectedBundle which the code is together
with the Qt's web process instead of being in a different library. This gives us
access to many hooks at web process (using WKBundle* functions of C API) without
adding any maintenance burden to cross-port code.

Since we also use a InjectedBundle in the WebKitTestRunner, we only install our
builtin bundle if there's no other installed. This is fine because WTR won't use
the extra runtime features that we plan to provide with the builtin bundle.

  • WebKit2.pro:
  • WebProcess/qt/QtBuiltinBundle.cpp: Added.

(WebKit::QtBuiltinBundle::~QtBuiltinBundle):
(WebKit::QtBuiltinBundle::shared):
(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didCreatePage):
(WebKit::QtBuiltinBundle::willDestroyPage):
(WebKit::QtBuiltinBundle::bundlePageForPageRef):

  • WebProcess/qt/QtBuiltinBundle.h: Added.

(WebKit::QtBuiltinBundle::toRef):
Object that holds a WKBundleRef and keeps track of the pages in the current context.

  • WebProcess/qt/QtBuiltinBundlePage.cpp: Added.

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):

  • WebProcess/qt/QtBuiltinBundlePage.h: Added.

(WebKit::QtBuiltinBundlePage::page):
Our representation for pages from the bundle perspective. This will be the right
place to registering page related clients.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
If there's no bundle to be loaded, initialize Qt builtin bundle, which will register the
bundle client for this context.

06:32 Changeset [98956] by apavlov@chromium.org

Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
https://bugs.webkit.org/show_bug.cgi?id=71275

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):

LayoutTests:

  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
06:09 Changeset [98955] by caseq@chromium.org

Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
05:59 Changeset [98954] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix extensions tests.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel):
05:53 Changeset [98953] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector extensions tests.

  • inspector/extensions/extensions.html:
05:36 Changeset [98952] by pfeldman@chromium.org

Web Inspector: do not switch panels on Cmd + -> while in console.
https://bugs.webkit.org/show_bug.cgi?id=71281

Reviewed by Yury Semikhatsky.

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyDown):

05:34 Changeset [98951] by alexis.menard@openbossa.org

Unreviewed Qt documentation fix.

This signal is Qt 4.8 material.

  • Api/qwebpage.cpp:
04:36 Changeset [98950] by jocelyn.turcotte@nokia.com

check-webkit-style: Allow names starting with "_q_".
https://bugs.webkit.org/show_bug.cgi?id=70625

Reviewed by Tor Arne Vestbø.

Used by the Qt port as the standard prefix for private slots.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
03:35 Changeset [98949] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
03:29 Changeset [98948] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
03:17 Changeset [98947] by commit-queue@webkit.org

[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
https://bugs.webkit.org/show_bug.cgi?id=60951

Adjust symbols visibility for WebCore.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-01
Reviewed by Simon Hausmann.

  • WebCore.pro:
03:14 Changeset [98946] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: add InspectorView.js entry into WebKit.qrc

  • inspector/front-end/WebKit.qrc:
03:05 Changeset [98945] by pfeldman@chromium.org

Web Inspector: introduce PanelContainer class, start moving panel management from inspector.js to the new class.
https://bugs.webkit.org/show_bug.cgi?id=71272

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.setVisible):

  • inspector/front-end/InspectorView.js: Added.

(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.currentPanel):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._canGoBackInHistory):
(WebInspector.InspectorView.prototype._goBackInHistory):
(WebInspector.InspectorView.prototype._canGoForwardInHistory):
(WebInspector.InspectorView.prototype._goForwardInHistory):
(WebInspector.InspectorView.prototype._pushToHistory):

  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.eventHasCtrlOrMeta):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.show):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createPanels):
(WebInspector._panelSelected):
(WebInspector.addPanel):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.select):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.expandElementsTree):

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):

  • inspector/debugger/debugger-expand-scope.html:
  • inspector/debugger/debugger-proto-property.html:
  • inspector/debugger/dom-breakpoints.html:
  • inspector/elements/elements-img-tooltip.html:
  • inspector/elements/elements-panel-limited-children.html:
  • inspector/storage-panel-dom-storage.html:
  • inspector/styles/styles-new-API.html:
  • inspector/view-css.html:
  • inspector/view-events.html:
03:02 Changeset [98944] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for fast/ tests.

  • platform/efl/fast/doctypes: [...]
  • platform/efl/fast/dom: [...]
  • platform/efl/fast/dynamic: [...]
  • platform/efl/fast/encoding: [...]
  • platform/efl/fast/events: [...]
  • platform/efl/fast/fast-mobile-scrolling: [...]
  • platform/efl/fast/flexbox: [...]
  • platform/efl/fast/forms: [...]
  • platform/efl/fast/frames: [...]
  • platform/efl/fast/gradients: [...]
02:54 Changeset [98943] by hausmann@webkit.org

[WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEvent::TapType
https://bugs.webkit.org/show_bug.cgi?id=71274

Reviewed by Kenneth Christiansen.

Source/WebCore:

  • features.pri: Enable GESTURE_EVENTS.

Source/WebKit2:

  • Shared/WebEvent.h: Add GestureSingleTap as gesture type.
  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Support converting
WebEven::GestureSingleTap to PlatformGestureEvent::TapType.

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::isGestureEventType): GestureSingleTap is a valid gesture event type.

  • WebKit2.pro: Add WebGestureEvent.cpp to the build.
02:54 Changeset [98942] by hausmann@webkit.org

[Qt][WK2] Fix valgrind error about uninitialized variable
https://bugs.webkit.org/show_bug.cgi?id=71273

Reviewed by Kenneth Christiansen.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify): Initialize isPrimary.

00:35 Changeset [98941] by caseq@chromium.org

Unreviewed gardening (fixed platform qualifiers for visibility-image-layers.html)

  • platform/chromium/test_expectations.txt:
00:24 Changeset [98940] by yurys@chromium.org

Unreviewed, rolling out r98847.
http://trac.webkit.org/changeset/98847
https://bugs.webkit.org/show_bug.cgi?id=71268

"Debugger test failures on multiple platforms" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-01

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

LayoutTests:

  • inspector/debugger/bind-script-to-resource-expected.txt: Removed.
  • inspector/debugger/bind-script-to-resource.html: Removed.
  • inspector/debugger/linkifier-expected.txt:
  • inspector/debugger/linkifier.html:
00:11 Changeset [98939] by yurys@chromium.org

2011-11-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline test started failing because syntax errors in inline handlers
are now reported to console.

window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991

  • fast/js/invalid-syntax-for-function-expected.txt:

10/31/11:

23:52 Changeset [98938] by caseq@chromium.org

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
23:43 Changeset [98937] by fpizlo@apple.com

The GC should be parallel
https://bugs.webkit.org/show_bug.cgi?id=70995

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added parallel tracing to the GC. This works by having local mark
stacks per thread, and a global shared one. Threads sometimes
donate cells from the mark stack to the global one if the heuristics
tell them that it's affordable to do so. Threads that have depleted
their local mark stacks try to steal some from the shared one.

Marking is now done using an atomic weak relaxed CAS (compare-and-swap).

This is a 23% speed-up on V8-splay when I use 4 marking threads,
leading to a 3.5% speed-up on V8.

It also appears that this reduces GC pause times on real websites by
more than half.

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::markRoots):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::~MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::MarkStack::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStackSegment::data):
(JSC::MarkStackSegment::capacityFromSize):
(JSC::MarkStackSegment::sizeFromCapacity):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::mergeOpaqueRootsIfNecessary):
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::canRemoveLast):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::canDonateSomeCells):
(JSC::MarkStackArray::size):
(JSC::ParallelModeEnabler::ParallelModeEnabler):
(JSC::ParallelModeEnabler::~ParallelModeEnabler):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::testAndSetMarked):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::SlotVisitor):

  • heap/WeakReferenceHarvester.h:
  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Bitmap.h:

(WTF::::Bitmap):
(WTF::::get):
(WTF::::set):
(WTF::::testAndSet):
(WTF::::testAndClear):
(WTF::::concurrentTestAndSet):
(WTF::::concurrentTestAndClear):
(WTF::::clear):
(WTF::::clearAll):
(WTF::::nextPossiblyUnset):
(WTF::::findRunOfZeros):
(WTF::::count):
(WTF::::isEmpty):
(WTF::::isFull):

  • wtf/MainThread.h:

(WTF::isMainThreadOrGCThread):

  • wtf/Platform.h:
  • wtf/ThreadSpecific.h:

(WTF::::isSet):

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeGCThreads):
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

Source/WebCore:

Reviewed by Geoff Garen.

Added parallel tracing to the GC. This required loosening some assertions,
since some code may now be called from outside the main thread.

No new tests, since no behavior was changed.

  • platform/TreeShared.h:

(WebCore::TreeShared::parent):

22:43 Changeset [98936] by aestes@apple.com

Document pointer not null-checked in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71265
<rdar://problem/10374427>

Reviewed by Dan Bernstein.

Return false in FrameView::isOnActivePage() if m_frame->document() is
null. Other calls to m_frame->document() in FrameView also have a null
check. The frame can have a null document if the FrameLoader is loading
the initial empty document.

No test possible without triggering assertions in debug builds. This is
tracked by <http://webkit.org/b/71264>.

  • page/FrameView.cpp:

(WebCore::FrameView::isOnActivePage):

21:24 Changeset [98935] by commit-queue@webkit.org

Source/WebCore: Fix a crash relating to anonymous block merging in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

Test: fullscreen/anonymous-block-merge-crash.html

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::unwrapRenderer):

LayoutTests: Test case for a crash relating to merging of anonymous blocks in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

  • fullscreen/anonymous-block-merge-crash.html: Added.
20:37 Changeset [98934] by commit-queue@webkit.org

V8MessageEvent::dataAccessorGetter does not return a reference to its caller
https://bugs.webkit.org/show_bug.cgi?id=71229

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-31
Reviewed by Adam Barth.

Test: fast/events/dispatch-message-string-data.html

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

18:47 Changeset [98933] by reni@webkit.org

[Qt] Build fix after r98853.

Rubber-stamped by Andreas Kling.

  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:

(WebCore::XSLImportRule::parentStyleSheet):

18:15 Changeset [98932] by mhahnenberg@apple.com

De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):

  • runtime/ExceptionHelpers.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defaultValue):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::defaultValue):

  • runtime/JSObject.h:

(JSC::JSObject::toPrimitive):

Source/WebCore:

No new tests.

Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.

  • WebCore.exp.in:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::defaultValue):

  • bridge/runtime_object.h:
18:09 Changeset [98931] by leviw@chromium.org

Switch RoundedRect back to integers
https://bugs.webkit.org/show_bug.cgi?id=71238

Reviewed by Darin Adler.

Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.

No new tests -- no change in behavior.

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):

  • platform/graphics/RoundedRect.h:

(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):

  • rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include
18:06 Changeset [98930] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=70666
BitmapImage::dataChanged() needs to clear all incomplete frames.

Patch by Peter Kasting <pkasting@google.com> on 2011-10-31
Reviewed by James Robinson.

No tests, as I don't know of a way to send an image to the renderer in
small pieces (with script run between pieces no less).

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::dataChanged):

18:01 Changeset [98929] by leviw@chromium.org

Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=71243

Reviewed by Eric Seidel.

Replacing remaining integer uses with LayoutUnits in the aforementioned classes.

No new tests -- no change in behavior.

  • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::intrinsicSize):
(WebCore::RenderApplet::createWidgetIfNecessary):

  • rendering/RenderApplet.h:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::controlClipRect):

  • rendering/RenderButton.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

  • rendering/RenderDeprecatedFlexibleBox.h:
17:59 Changeset [98928] by andersca@apple.com

PluginProxy::Update should pass the painted rect in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71257

Reviewed by Adam Roben.

This is one step in the process of migrating away from window relative coordinates
and use plug-in relative coordinates instead, since window relative coordinates won't work
with transforms.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Convert the dirty rect back to plug-in coordinates.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::update):
No need to convert the painted rect back to plug-in coordinates anymore.

  • WebProcess/Plugins/PluginProxy.messages.in:

Document that the painted rect is in plug-in coordinates.

17:50 Changeset [98927] by aroben@apple.com

Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT

Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
total of N bytes!").

17:43 Changeset [98926] by commit-queue@webkit.org

[Chromium] Media Stream API: add the Chromium WebKit interfaces
https://bugs.webkit.org/show_bug.cgi?id=58550

Source/WebCore:

Changes the PeerHandler platform interface so that embedders can more easily use it.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::didCompleteICEProcessing):
(WebCore::PeerConnection::didGenerateSDP):
(WebCore::PeerConnection::didReceiveDataStreamMessage):
(WebCore::PeerConnection::didAddRemoteStream):
(WebCore::PeerConnection::didRemoveRemoteStream):

  • mediastream/PeerConnection.h:
  • platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.

(WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient):

  • platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.h.
  • platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.

(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):

  • platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerHandler.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

Source/WebKit/chromium:

Adds the bridging code + the minimum amount of Web* supporting code.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • bridge/PeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/PeerHandler.cpp.

(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):

  • bridge/PeerConnectionHandlerInternal.cpp: Added.

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::~PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

  • bridge/PeerConnectionHandlerInternal.h: Added.
  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::createPeerConnectionHandler):

  • public/WebMediaStreamDescriptor.h: Added.

(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::~WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::isNull):

  • public/WebPeerConnectionHandler.h: Added.

(WebKit::WebPeerConnectionHandler::~WebPeerConnectionHandler):

  • public/WebPeerConnectionHandlerClient.h: Added.

(WebKit::WebPeerConnectionHandlerClient::~WebPeerConnectionHandlerClient):

  • src/WebMediaStreamDescriptor.cpp: Added.

(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::reset):
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStreamDescriptor::operator WebCore::MediaStreamDescriptor*):

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

17:39 Changeset [98925] by aroben@apple.com

Fix linker warnings on Windows

  • WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and

JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting
compiled via *AllInOne.cpp files.

17:29 Changeset [98924] by commit-queue@webkit.org

[GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-31
Reviewed by Martin Robinson.

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

17:29 Changeset [98923] by andersca@apple.com

PluginControllerProxy should call Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71255

Reviewed by Sam Weinig.

Pass enough information over in the GeometryDidChange message sent from
PluginProxy to PluginControllerProxy so that PluginControllerProxy can call
Plugin::geometryDidChange.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::invalidate):
(WebKit::PluginControllerProxy::paintEntirePlugin):
Update for rename from m_frameRect to m_frameRectInWindowCoordinates.

(WebKit::PluginControllerProxy::geometryDidChange):
This now takes the plug-in size and the plug-in to root view transform as well.

  • PluginProcess/PluginControllerProxy.h:

Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates.

  • PluginProcess/PluginControllerProxy.messages.in:

Update message signature.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::platformGeometryDidChange):
Use the plug-in size instead of the frame rect size.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:

Add encoder/decoder for WebCore::AffineTransform.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Compute the frame rect in window coordinates and send it over.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange.

17:27 Changeset [98922] by johnnyg@google.com

Unreviewed gardening; bind-script-to-resource.html times out on chromium mac.

  • platform/chromium/test_expectations.txt:
17:27 Changeset [98921] by commit-queue@webkit.org

[chromium] Calling methods of WebFontImpl causes assertions
https://bugs.webkit.org/show_bug.cgi?id=71232

Added FontCachePurgePreventer in several methods.

Patch by Yuzhu Shen <yzshen@google.com> on 2011-10-31
Reviewed by James Robinson.

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::calculateWidth):
(WebKit::WebFontImpl::offsetForPosition):
(WebKit::WebFontImpl::selectionRectForText):
(WebKit::WebFontImpl::estimateTextBounds):

17:21 Changeset [98920] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

  • platform/qt/Skipped: Skip failing tests.
17:18 Changeset [98919] by ossy@webkit.org

Unreviewed, rolling out r98918.
http://trac.webkit.org/changeset/98918
https://bugs.webkit.org/show_bug.cgi?id=71256

Wrong commit (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-31

  • platform/qt/Skipped:
17:10 Changeset [98918] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

  • platform/qt/Skipped: Skip failing tests.
17:01 Changeset [98917] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98673 and r98608.

  • platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
16:57 Changeset [98916] by mhahnenberg@apple.com

Interpreter build fix

Unreviewed build fix

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

16:56 Changeset [98915] by nduca@chromium.org

[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=71100

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCSchedulerFrameRateControllerClientAdapter::create):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::~CCScheduler):
(WebCore::CCScheduler::setNeedsAnimate):
(WebCore::CCScheduler::setNeedsCommit):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didSwapBuffersAbort):
(WebCore::CCScheduler::onBeginFrame):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(WebCore::CCSchedulerStateMachine::redrawPending):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::hasMoreUpdates):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::setUpdateMoreResourcesPending):
(WebCore::StateMachine::updateMoreResourcesPending):
(WebCore::TEST):

  • tests/CCSchedulerTest.cpp:
16:53 Changeset [98914] by lforschler@apple.com

New tag.

16:52 Changeset [98913] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98852.

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

  • platform/qt/css1/text_properties/vertical_align-expected.png:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/qt/fast/block/float/015-expected.png:
  • platform/qt/fast/block/float/015-expected.txt:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/qt/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/qt/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/qt/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
16:50 Changeset [98912] by fpizlo@apple.com

DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202

Reviewed by Oliver Hunt.

Value profiles now have an extra special slot not used by the old JIT's
profiling, which is reserved for OSR exits.

The DFG's OSR exit code now knows which register, node index, and value
profiling site was responsible for the (possibly flawed) information that
led to the OSR failure. This is somewhat opportunistic and imperfect;
if there's a lot of control flow between the value profiling site and the
OSR failure point, then this mechanism simply gives up. It also gives up
if the OSR failure is caused by either known deficiencies in the DFG
(like that we always assume that the index in a strict charCodeAt access
is within bounds) or where the OSR failure would be catalogues and
profiled through other means (like slow case counters).

This patch also adds the notion of a JSValueRegs, which is either a
single register in JSVALUE64 or a pair in JSVALUE32_64. We should
probably move the 32_64 DFG towards using this, since it often makes it
easier to share code between 64 and 32_64.

Also fixed a number of pathologies that this uncovered. op_method_check
didn't have a value profiling site on the slow path. GetById should not
always force OSR exit if it never executed in the old JIT; we may be
able to infer its type if it's a array or string length get. Finally,
these changes benefit from a slight tweak to optimization delay
heuristics (profile fullness is now 0.35 instead of 0.25).

3.8% speed-up on Kraken, mostly due to ~35% on both stanford-crypto-aes
and imaging-darkroom.

  • bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::specFailBucket):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::jsValueRegs):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):

  • dfg/DFGJITCodeGenerator.h:

(JSC::JSValueOperand::jsValueRegs):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::valueProfileFor):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_method_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_method_check):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/JSValue.h:
16:49 Changeset [98911] by japhet@chromium.org

Rename the remaining uses of Cue in WebCore/loader/
to TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=71231

Reviewed by Eric Carlson.

No new tests, strictly a renaming.

  • loader/TextTrackLoader.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cache/CachedTextTrack.cpp:
  • platform/network/chromium/ResourceRequest.h:
16:46 Changeset [98910] by adamk@chromium.org

[MutationObservers] Support characterDataOldValue for characterData mutations
https://bugs.webkit.org/show_bug.cgi?id=70862

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/CharacterData.cpp:

(WebCore::hasOldValue):
(WebCore::isOldValueRequested):
(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createCharacterData):

  • dom/MutationRecord.h:

LayoutTests:

Added oldValue test cases to existing characterData tests.

  • fast/mutation/observe-characterdata-expected.txt:
  • fast/mutation/observe-characterdata.html:
16:43 Changeset [98909] by weinig@apple.com

Remove need for virtual JSObject::unwrappedObject
https://bugs.webkit.org/show_bug.cgi?id=71034

Reviewed by Geoffrey Garen.

../JavaScriptCore:

Update exports.

Add JSGlobalThis.cpp.

  • runtime/JSGlobalThis.cpp: Added.

(JSC::JSGlobalThis::visitChildren):
(JSC::JSGlobalThis::unwrappedObject):

  • runtime/JSGlobalThis.h:

(JSC::JSGlobalThis::createStructure):
Move underlying object from JSDOMWindowShell down to JSGlobalThis
and corresponding visitChildren method.

  • runtime/JSObject.cpp:

(JSC::JSObject::unwrappedObject):
Change unwrappedObject from virtual, to just needing an if check.

  • runtime/JSObject.h:

(JSC::JSObject::isGlobalThis):

  • runtime/JSType.h:

Add isGlobalThis predicate and type.

../WebCore:

Move the member containing the global object from the JSDOMWindowShell
down to the JSGlobalThis class, and update JSDOMWindowShell to go through
an inline helper (which just casts) to get the window.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):
(WebCore::JSDOMWindowShell::lookupGetter):
(WebCore::JSDOMWindowShell::lookupSetter):
(WebCore::JSDOMWindowShell::impl):

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::createStructure):

16:40 Changeset [98908] by commit-queue@webkit.org

[EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
https://bugs.webkit.org/show_bug.cgi?id=71228

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-31
Reviewed by Antonio Gomes.

Source/WebKit/efl:

r93833 has introduced
ewk_view_setting_scripts_can_close_windows_{get,set}, but its
counterpart to allow scripts to open windows kept its weird name.

This makes the functions to allow windows to open and close windows to
have confusingly different name patterns.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_open_windows_get):
(ewk_view_setting_scripts_can_open_windows_set):

  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

16:38 Changeset [98907] by andersca@apple.com

Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
https://bugs.webkit.org/show_bug.cgi?id=71252

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::pluginBounds):

  • WebProcess/Plugins/PluginProxy.h:
16:34 Changeset [98906] by lforschler@apple.com

Versioning.

16:28 Changeset [98905] by andersca@apple.com

Implement PluginProxy::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71251

Reviewed by Sam Weinig.

Keep track of the plug-in size, the clip rect in plug-in coordinates and the
transformation matrix from the root view to the plug-in.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:
16:19 Changeset [98904] by lforschler@apple.com

Updated fix for r98470.

16:18 Changeset [98903] by commit-queue@webkit.org

WTF::StringImpl::create(const char*, unsigned) calls itself
https://bugs.webkit.org/show_bug.cgi?id=71206

The original implementation just calls itself, causing infinite recursion.
Cast the first parameter to const LChar* to fix that.

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-31
Reviewed by Ryosuke Niwa.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::create):

16:18 Changeset [98902] by johnnyg@google.com

Chromium rebaselines, unreviewed.

  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-gpu-win/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:12 Changeset [98901] by rniwa@webkit.org

Mac rebaseline after r98852.

  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
16:09 Changeset [98900] by commit-queue@webkit.org

IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-31
Reviewed by Darin Fisher.

  • public/WebIDBKey.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebIDBKey.cpp:
16:09 Changeset [98899] by rniwa@webkit.org

WebKit nests pre on copy and paste when the pre is the root editable element
https://bugs.webkit.org/show_bug.cgi?id=70800

Reviewed by Darin Adler.

Source/WebCore:

Fixed the bug by removing nested block elements in removeRedundantStylesAndKeepStyleSpanInline.

Tests: editing/pasteboard/contenteditable-pre-2.html

editing/pasteboard/contenteditable-pre.html

  • editing/ApplyStyleCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Remove block
elements if it's identical to its parent and there are no contents between the two. Also remove
contenteditable attribute from an element if the parent is already richly editable.
(WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles after removing the placeholder
br so that the above check doesn't get affected by the placeholder.

  • editing/htmlediting.cpp:

(WebCore::areIdenticalElements): Moved from ApplyStyleCommand.
(WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp.

  • editing/htmlediting.h:
  • editing/markup.cpp:

LayoutTests:

Added tests for copying and pasting contents inside pre. WebKit should not nest pre's.

  • editing/execCommand/insert-list-with-noneditable-content-expected.txt: A redundant

contenteditable attribute is removed.

  • editing/pasteboard/4930986-2-expected.txt: Trailing space in style attribute is removed.
  • editing/pasteboard/contenteditable-pre-2-expected.txt: Added.
  • editing/pasteboard/contenteditable-pre-2.html: Added.
  • editing/pasteboard/contenteditable-pre-expected.txt: Added.
  • editing/pasteboard/contenteditable-pre.html: Added.
  • editing/pasteboard/copy-null-characters-expected.txt: A redundant contenteditable attribute

is removed.

  • editing/pasteboard/paste-code-in-pre-expected.txt: Pre no longer nests itself erroneously.
  • editing/pasteboard/paste-pre-001-expected.txt: Ditto.
  • editing/pasteboard/paste-pre-002-expected.txt: Ditto.
  • editing/selection/4895428-4-expected.txt: A redundant contenteditable attribute is removed.
16:08 Changeset [98898] by andersca@apple.com

Fix the X11 build.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

16:07 Changeset [98897] by andersca@apple.com

Factor code to resize the plug-in backing store out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=71250

Reviewed by Adam Roben.

Add a PluginProxy::contentsScaleFactor helper function to get rid of a bunch of PLATFORM(MAC) #ifdefs,
and move the code to update the backing store out into a separate function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::contentsScaleFactor):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::update):

  • WebProcess/Plugins/PluginProxy.h:
16:02 Changeset [98896] by commit-queue@webkit.org

text/plain form encoding ignored and incorrectly specified in request header.
https://bugs.webkit.org/show_bug.cgi?id=20795

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-10-31
Reviewed by Darin Adler.

Source/WebCore:

This patch fixes the behaviour of forms where enctype is set to
text/plain, encoding is also text/plain.

Tests: fast/forms/form-get-textplain.html

http/tests/misc/form-post-textplain.html

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • platform/network/FormData.cpp:

(WebCore::FormData::create):
(WebCore::FormData::appendKeyValuePairItems):

  • platform/network/FormData.h:

(WebCore::FormData::parseEncodingType):

  • platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding scheme for text/plain.

  • platform/network/FormDataBuilder.h:

LayoutTests:

Added tests for GET and POST methods for text/plain enctype.
Forms submitted using GET with a content-type of text/plain actually,
send data in URL encoded in the URL.
Forms with POST method and content-type of text/plain actually send data in text/plain.
Modified expected results for mailto tests as per the new behavior.

  • fast/forms/form-get-textplain-expected.txt: Added.
  • fast/forms/form-get-textplain.html: Added.
  • fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
  • http/tests/misc/form-post-textplain-expected.txt: Added.
  • http/tests/misc/form-post-textplain.html: Added.
  • http/tests/misc/resources/form-post-textplain.php: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  • platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
16:00 Changeset [98895] by johnnyg@google.com

RenderImage.cpp calls SVGImage even if it's not defined
https://bugs.webkit.org/show_bug.cgi?id=71247

This fixes a compile error when ENABLE_SVG=0.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::embeddedContentBox):

15:55 Changeset [98894] by jeffm@apple.com

Add more APIs to WKUserContentURLPattern.h
https://bugs.webkit.org/show_bug.cgi?id=71245

Add additional WKUserContentURLPattern APIs to match what was provided by
the equivalent WebKit1 API.

Reviewed by Darin Adler.

  • Shared/API/c/WKUserContentURLPattern.cpp:

(WKUserContentURLPatternCopyHost): Added.
(WKUserContentURLPatternCopyScheme): Added.
(WKUserContentURLPatternIsValid): Added.
(WKUserContentURLPatternMatchesSubdomains): Added.

  • Shared/API/c/WKUserContentURLPattern.h: Added new APIs.


  • Shared/WebUserContentURLPattern.h:

(WebKit::WebUserContentURLPattern::host): Added.
(WebKit::WebUserContentURLPattern::scheme): Added.
(WebKit::WebUserContentURLPattern::isValid): Added.
(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.

15:52 Changeset [98893] by podivilov@chromium.org

Update XMLHttpRequest.send idl declaration to match implementation.
https://bugs.webkit.org/show_bug.cgi?id=71121

Reviewed by Adam Barth.

  • xml/XMLHttpRequest.idl:
15:51 Changeset [98892] by andersca@apple.com

More work on making plug-ins work better with transforms
https://bugs.webkit.org/show_bug.cgi?id=71241

Reviewed by Darin Adler.

Source/WebCore:

Export symbols used by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):
Implement NetscapePlugin::geometryDidChange and store the plug-in size,
the clip rect and the root view transform. Use the transform to compute the window
relative frame and clip rects.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add new member variables.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):
Always call the new Plugin::geometryDidChange.

15:38 Changeset [98891] by commit-queue@webkit.org

Fix DFG JIT compilation on Linux targets.
https://bugs.webkit.org/show_bug.cgi?id=70904

Patch by Andy Wingo <wingo@igalia.com> on 2011-10-31
Reviewed by Darin Adler.

  • jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this

macro.

  • dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the

simplified definition from jit/JITStubs.cpp.
(FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue):
Use the macro to access trampoline targets through the PLT on PIC
systems, instead of introducing a text relocation. Otherwise, the
library fails to link.

15:31 Changeset [98890] by commit-queue@webkit.org

[EFL] Make cache flush when max size of cache has been changed
https://bugs.webkit.org/show_bug.cgi?id=70805

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-31
Reviewed by Ryosuke Niwa.

Calls the ewk_tile_unused_cache_auto_flush function after changing max
size of cache when ewk_tile_unused_cache_max_set is called. Without
this change when new value is lower than the old one the cache may use
more memory than max value set. This situation is not expected by the
user.

  • ewk/ewk_tiled_model.cpp:

(ewk_tile_unused_cache_max_set):

15:24 Changeset [98889] by mhahnenberg@apple.com

De-virtualize JSObject::defineGetter
https://bugs.webkit.org/show_bug.cgi?id=71134

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.

(JSC::DebuggerActivation::defineGetter):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineGetter):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineGetter):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):

Source/WebCore:

No new tests.

Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineGetter):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::defineGetter):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineGetter):
(WebCore::JSLocationPrototype::defineGetter):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

Source/WebKit/qt:

Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.

  • Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):

15:22 Changeset [98888] by commit-queue@webkit.org

Microdata: Support for itemid attribute.
https://bugs.webkit.org/show_bug.cgi?id=71007

Patch by Arko Saha <arko@motorola.com> on 2011-10-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

itemid attribute: To give a global identifier for the Microdata items.
The itemid attribute, if specified, must have a value that is a valid URL potentially
surrounded by spaces.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid

Tests: fast/dom/MicroData/itemid-attribute-test.html

fast/dom/MicroData/itemid-must-see-resolved-url.html

  • html/HTMLElement.idl:

LayoutTests:

Added test-cases for itemid attribute.

  • fast/dom/MicroData/itemid-attribute-test-expected.txt: Added.
  • fast/dom/MicroData/itemid-attribute-test.html: Added.
  • fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Added.
  • fast/dom/MicroData/itemid-must-see-resolved-url.html: Added.
15:13 Changeset [98887] by msaboff@apple.com

Towards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=71138

Restructure and movement of Lexer and Parser code.
Moved Lexer and Parser objects out of JSGlobalData.
Added a new ParserTokens class and instance to JSGlobalData that
have JavaScript token related definitions.
Replaced JSGlobalData arguments to Node classes with lineNumber,
as that was the only use of the JSGlobalData.
Combined JSParser and Parser classes into one class,
eliminating JSParser.h and .cpp.
Various supporting #include changes.

These mostly mechanical changes are done in preparation to
making the Lexer and Parser template classes.

Reviewed by Darin Adler.

(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

  • parser/JSParser.cpp: Removed.
  • parser/JSParser.h: Removed.
  • parser/Lexer.cpp:

(JSC::Keywords::Keywords):
(JSC::Lexer::Lexer):
(JSC::Lexer::~Lexer):
(JSC::Lexer::setCode):
(JSC::Lexer::parseIdentifier):

  • parser/Lexer.h:

(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
(JSC::Keywords::~Keywords):
(JSC::Lexer::setIsReparsing):
(JSC::Lexer::isReparsing):
(JSC::Lexer::lineNumber):
(JSC::Lexer::setLastLineNumber):
(JSC::Lexer::lastLineNumber):
(JSC::Lexer::prevTerminator):
(JSC::Lexer::sawError):
(JSC::Lexer::getErrorMessage):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
(JSC::Lexer::convertHex):
(JSC::Lexer::convertUnicode):
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):

  • parser/NodeConstructors.h:

(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ElementNode::ElementNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyNode::PropertyNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::ArgumentsNode::ArgumentsNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::SourceElements::SourceElements):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::ParameterNode::ParameterNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::CaseClauseNode::CaseClauseNode):
(JSC::ClauseListNode::ClauseListNode):
(JSC::CaseBlockNode::CaseBlockNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):

  • parser/NodeInfo.h:
  • parser/Nodes.cpp:

(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

  • parser/Nodes.h:

(JSC::Node::lineNo):

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::~Parser):
(JSC::Parser::parseInner):
(JSC::Parser::allowAutomaticSemicolon):
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseVarDeclaration):
(JSC::Parser::parseConstDeclaration):
(JSC::Parser::parseDoWhileStatement):
(JSC::Parser::parseWhileStatement):
(JSC::Parser::parseVarDeclarationList):
(JSC::Parser::parseConstDeclarationList):
(JSC::Parser::parseForStatement):
(JSC::Parser::parseBreakStatement):
(JSC::Parser::parseContinueStatement):
(JSC::Parser::parseReturnStatement):
(JSC::Parser::parseThrowStatement):
(JSC::Parser::parseWithStatement):
(JSC::Parser::parseSwitchStatement):
(JSC::Parser::parseSwitchClauses):
(JSC::Parser::parseSwitchDefaultClause):
(JSC::Parser::parseTryStatement):
(JSC::Parser::parseDebuggerStatement):
(JSC::Parser::parseBlockStatement):
(JSC::Parser::parseStatement):
(JSC::Parser::parseFormalParameters):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::Parser::parseExpressionOrLabelStatement):
(JSC::Parser::parseExpressionStatement):
(JSC::Parser::parseIfStatement):
(JSC::Parser::parseExpression):
(JSC::Parser::parseAssignmentExpression):
(JSC::Parser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::Parser::isBinaryOperator):
(JSC::Parser::parseBinaryExpression):
(JSC::Parser::parseProperty):
(JSC::Parser::parseObjectLiteral):
(JSC::Parser::parseStrictObjectLiteral):
(JSC::Parser::parseArrayLiteral):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseArguments):
(JSC::Parser::parseMemberExpression):
(JSC::Parser::parseUnaryExpression):

  • parser/Parser.h:

(JSC::isEvalNode):
(JSC::EvalNode):
(JSC::DepthManager::DepthManager):
(JSC::DepthManager::~DepthManager):
(JSC::ScopeLabelInfo::ScopeLabelInfo):
(JSC::Scope::Scope):
(JSC::Scope::startSwitch):
(JSC::Scope::endSwitch):
(JSC::Scope::startLoop):
(JSC::Scope::endLoop):
(JSC::Scope::inLoop):
(JSC::Scope::breakIsValid):
(JSC::Scope::continueIsValid):
(JSC::Scope::pushLabel):
(JSC::Scope::popLabel):
(JSC::Scope::getLabel):
(JSC::Scope::setIsFunction):
(JSC::Scope::isFunction):
(JSC::Scope::isFunctionBoundary):
(JSC::Scope::declareVariable):
(JSC::Scope::declareWrite):
(JSC::Scope::preventNewDecls):
(JSC::Scope::allowsNewDecls):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::setNeedsFullActivation):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getUncapturedWrittenVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::setStrictMode):
(JSC::Scope::strictMode):
(JSC::Scope::isValidStrictMode):
(JSC::Scope::shadowsArguments):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::ScopeRef::ScopeRef):
(JSC::ScopeRef::operator->):
(JSC::ScopeRef::index):
(JSC::ScopeRef::hasContainingScope):
(JSC::ScopeRef::containingScope):
(JSC::Parser::AllowInOverride::AllowInOverride):
(JSC::Parser::AllowInOverride::~AllowInOverride):
(JSC::Parser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::setPopped):
(JSC::Parser::currentScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::declareWrite):
(JSC::Parser::findCachedFunctionInfo):
(JSC::Parser::isFunctionBodyNode):
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::nextTokenIsColon):
(JSC::Parser::consume):
(JSC::Parser::getToken):
(JSC::Parser::match):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::startLoop):
(JSC::Parser::endLoop):
(JSC::Parser::startSwitch):
(JSC::Parser::endSwitch):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::breakIsValid):
(JSC::Parser::continueIsValid):
(JSC::Parser::pushLabel):
(JSC::Parser::popLabel):
(JSC::Parser::getLabel):
(JSC::Parser::autoSemiColon):
(JSC::Parser::canRecurse):
(JSC::Parser::lastTokenEnd):
(JSC::Parser::DepthManager::DepthManager):
(JSC::Parser::DepthManager::~DepthManager):
(JSC::Parser::parse):
(JSC::parse):

  • parser/ParserTokens.h: Added.

(JSC::JSTokenInfo::JSTokenInfo):

  • parser/SourceCode.h:

(JSC::SourceCode::subExpression):

  • parser/SourceProviderCacheItem.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):

15:07 Changeset [98886] by benjamin@webkit.org

The test input-paste-undo.html needs update to work properly
https://bugs.webkit.org/show_bug.cgi?id=71091

Reviewed by David Kilzer.

Update the test to select the text that needs to be copied
so that it effectively go in the pasteboard on execCommand.

The test now dumps result as text, testing if the height does not
change with the form edition.

  • fast/forms/input-paste-undo-expected.txt: Added.
  • fast/forms/input-paste-undo.html:
  • platform/chromium-linux/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/efl/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/gtk/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/gtk/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/mac/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/mac/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/qt/fast/forms/input-paste-undo-expected.txt: Removed.
15:03 Changeset [98885] by yurys@chromium.org

window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991

Source/WebCore:

Uncaught syntax errors in inline event handlers are now reported to
window.onerror handler.

Reviewed by Geoffrey Garen.

Tests: fast/events/window-onerror-exception-in-attr.html

fast/events/window-onerror-syntax-error-in-attr.html

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction): report exception as usual
if it happens during event handler compilation.

LayoutTests:

Added a couple of window.onerror tests for the cases when uncaught exception
occurs in inline event handler. Test for non-syntax errors passed before this change
as well and just extends test coverage for window.onerror functionality.

Reviewed by Geoffrey Garen.

  • fast/events/window-onerror-exception-in-attr-expected.txt: Added.
  • fast/events/window-onerror-exception-in-attr.html: Added.
  • fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
  • fast/events/window-onerror-syntax-error-in-attr.html: Added.
  • platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
14:34 Changeset [98884] by johnnyg@google.com

Unreviewed, more expectations changes for svg.

  • platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/overflow: Added.
  • platform/chromium-cg-mac-snowleopard/fast/overflow/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-cg-mac/fast/overflow: Removed.
  • platform/chromium-cg-mac/fast/overflow/003-expected.png: Removed.
  • platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page: Removed.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.txt: Removed.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-mac/fast/overflow/003-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium/svg/zoom: Added.
  • platform/chromium/svg/zoom/page: Added.
  • platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
14:33 Changeset [98883] by eae@chromium.org

Overridden LayoutRect method still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71166

Reviewed by Eric Seidel.

Change all virtual controlClipRect, windowResizerRect, windowClipRect,
visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
localCaretRect functions to have the same signature.

  • page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::windowResizerRect):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderButton.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::visibleContentRect):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localCaretRect):

  • rendering/RenderObject.h:

(WebCore::RenderObject::outlineBoundsForRepaint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):

  • rendering/RenderText.h:
  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

  • rendering/svg/RenderSVGInlineText.h:
14:31 Changeset [98882] by lforschler@apple.com

New tag.

14:24 Changeset [98881] by imasaki@chromium.org

[Chromium] Did rebaselines of media/audio-repaint.html.

Unreviewed.

  • platform/chromium-gpu-linux/media/audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
14:23 Changeset [98880] by lforschler@apple.com

Versioning.

14:07 Changeset [98879] by dslomov@google.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Transfer of MessagePorts implemented.

Reviewed by David Levin.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Some 'FAIL's remain in expected test results. These are due to the fact that
JSC bindings chose not to throw type error exception for non-serializable values -
non-serializable values are serialized as null.

Reviewed by David Levin.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/events/message-port-multi-expected.txt:
14:03 Changeset [98878] by fpizlo@apple.com

REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
https://bugs.webkit.org/show_bug.cgi?id=71227

Reviewed by Oliver Hunt.

No new tests, since while I can see exactly where the DFG went wrong on the
site in question from looking at the generated machine code, and while I can
certainly believe that such a scenario would happen, I cannot visualize how
to make it happen reproducibly. It requires an odd combination of double
values getting spilled and then refilled, but then reboxed at just the right
time so that the spilled value is an unboxed double while the in-register
value is a boxed double.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

13:50 Changeset [98877] by eric@webkit.org

webkitpy tests depend too much on the user's environment
https://bugs.webkit.org/show_bug.cgi?id=71234

Reviewed by Dirk Pranke.

This change just makes a bunch of our older tests use
more modern mocking to avoid trying to launch processes
or read from the user's filesystem during unittesting.

I found many of these by adding an assert in Executive.run_command
that we were not unittesting. I can't add that assert always
as there are some valid uses of Executive during unittesting.
Once I fix more of these, I may find a way to add such an assert conditionally.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
13:31 Changeset [98876] by eae@chromium.org

Change WebKit/WebKit2 to use explicit conversion between FixedRect/Point/Size and the int equivalents. Follow up to change 98869.

13:29 Changeset [98875] by johnnyg@google.com

Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847

  • platform/chromium/test_expectations.txt:
13:25 Changeset [98874] by lforschler@apple.com

Merged r98389.

13:22 Changeset [98873] by andersca@apple.com

Rename a couple of NetscapePlugin and PluginProxy member variables
https://bugs.webkit.org/show_bug.cgi?id=71086

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::deprecatedGeometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::deprecatedGeometryDidChange):
(WebKit::PluginProxy::update):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

12:51 Changeset [98872] by eae@chromium.org

Merging trunk changes up until 98861 into subpixel branch.

12:27 Changeset [98871] by imasaki@chromium.org

Did rebaselines for failing tests for fullscreen layout tests.
https://bugs.webkit.org/show_bug.cgi?id=70512

Reviewed by David Levin.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:
12:09 Changeset [98870] by caseq@chromium.org

Unreviewed. Fixed duplicate lines in test expectations.

  • platform/chromium/test_expectations.txt:
12:06 Changeset [98869] by leviw@chromium.org

Adding explicit FixedRect constructors to IntRect. Previously, FixedRect->IntRect went through FloatRect, which lost precision and caused overflow in some cases. Fixing some scrollbar paint issues on Mac.

11:54 Changeset [98868] by caseq@chromium.org

Unreviewed. More rebaselines after r98852.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png.
  • platform/chromium-cg-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-mac/fast/block/float/015-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png.
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Removed.
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Removed.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Removed.
11:16 Changeset [98867] by leandro@webkit.org

[EFL] Unreviewed. Update Skipped list.

  • platform/efl/Skipped: Reorder test groups so that they appear in a

more logical manner. Add some other tests that are failing since
recent updates.

10:54 Changeset [98866] by caseq@chromium.org

Unreviewed. Marked tests as failing after r98852.

  • platform/chromium/test_expectations.txt:
10:46 Changeset [98865] by johnnyg@google.com

Unreviewed, expectations for fast/js tests.

  • platform/chromium/fast/js/regexp-caching-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:43 Changeset [98864] by carlosgc@webkit.org

[GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball
https://bugs.webkit.org/show_bug.cgi?id=71224

Reviewed by Martin Robinson.

  • GNUmakefile.gtk-doc.am: Copy html and tmpl dirs to

$(distdir)/$(DOC_MODULE).

10:38 Changeset [98863] by caseq@chromium.org

Unreviewed tests rebaseline following r98852.

  • fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-leopard/fast/block/float/015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-cg-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-linux/fast/block/float/015-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-linux/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/015-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png.
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-win/fast/block/float/015-expected.png:
  • platform/chromium-win/fast/block/float/015-expected.txt:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/chromium-win/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
  • svg/as-background-image/svg-as-background-4-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt.
  • svg/as-image/svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-image/svg-as-relative-image-expected.txt.
  • svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Renamed from LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt.
10:30 Changeset [98862] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.

  • platform/efl/fast/backgrounds: [...]
  • platform/efl/fast/block: [...]
  • platform/efl/fast/body-propagation: [...]
  • platform/efl/fast/borders: [...]
  • platform/efl/fast/box-shadow: [...]
  • platform/efl/fast/canvas: [...]
  • platform/efl/fast/clip: [...]
  • platform/efl/fast/compact: [...]
  • platform/efl/fast/css-generated-content: [...]
  • platform/efl/fast/css: [...]
10:02 Changeset [98861] by andreas.kling@nokia.com

CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223

Reviewed by Antti Koivisto.

Moved insertedIntoParent() down into CSSImportRule and renamed it to
requestStyleSheet(). CSSImportRule is the only user of this function.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::requestStyleSheet):

  • css/CSSImportRule.h:
  • css/CSSRule.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insertRule):

09:35 Changeset [98860] by annacc@chromium.org

Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html

media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Added.
  • media/track/track-load-error-readyState.html: Added.
  • media/track/track-load-from-element-readyState-expected.txt: Added.
  • media/track/track-load-from-element-readyState.html: Added.
  • media/track/track-load-from-src-readyState-expected.txt: Added.
  • media/track/track-load-from-src-readyState.html: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:
09:04 clutter edited by kov@webkit.org
My suggestions (diff)
08:53 Changeset [98859] by andreas.kling@nokia.com

CSSRule: Devirtualize type() and isFooRule()
https://bugs.webkit.org/show_bug.cgi?id=71221

Reviewed by Antti Koivisto.

Store the rule type in a CSSRule member (packed with the parent-is-rule flag)
and let the isFooRule() functions return type() == FOO_TYPE.

CSSPageRule will no longer return true for isStyleRule(), tweaked call sites
accordingly.

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::CSSCharsetRule):

  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):

  • css/CSSFontFaceRule.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):

  • css/CSSImportRule.h:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):

  • css/CSSMediaRule.h:
  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):

  • css/CSSPageRule.h:
  • css/CSSRegionStyleRule.cpp:

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):

  • css/CSSRegionStyleRule.h:
  • css/CSSRule.h:

(WebCore::CSSRule::type):
(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::isImportRule):
(WebCore::CSSRule::CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):

  • css/CSSStyleRule.h:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::CSSUnknownRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):

  • css/WebKitCSSKeyframesRule.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asCSSStyleRule):

08:49 Changeset [98858] by abecsi@webkit.org

[Qt][WK2] Fix qmltests after r98460 added widgets dependency.

Reviewed by Simon Hausmann.

Use QApplication and QtWidgets until we get rid of the widgets dependency of QScroller.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

08:30 clutter edited by tomeu.vizoso@collabora.com
(diff)
08:29 Changeset [98857] by pfeldman@chromium.org

2011-10-31 Pavel Feldman <pfeldman@google.com>

Not reviewed: reorder inspector js files to fix remote mode.

  • inspector/front-end/inspector.html:
08:09 Changeset [98856] by apavlov@chromium.org

Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
https://bugs.webkit.org/show_bug.cgi?id=70936

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.event):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.context.event):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.get proxyElement):
(WebInspector.TextPrompt.prototype.attach):
(WebInspector.TextPrompt.prototype.attachAndStartEditing):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):
(WebInspector.TextPrompt.prototype.get text):
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype._onKeyDown):
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretInsidePrompt):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.isCaretOnFirstLine):
(WebInspector.TextPrompt.prototype.isCaretOnLastLine):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPromptConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.get historyData):
(WebInspector.TextPromptWithHistory.prototype.setHistoryData):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype._pushCurrentText):
(WebInspector.TextPromptWithHistory.prototype._previous):
(WebInspector.TextPromptWithHistory.prototype._next):
(WebInspector.TextPromptWithHistory.prototype._currentHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):

07:32 Changeset [98855] by pfeldman@chromium.org

Web Inspector: move localization support into UIUtil.js, reduce externs.
https://bugs.webkit.org/show_bug.cgi?id=71220

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/compile-front-end.sh:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype.focus):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.afterShow):

  • inspector/front-end/Drawer.js:
  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog.prototype._hide):

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
(WebInspector.HelpScreen.prototype._onBlur):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut._keyName):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._onSearchFieldManualFocus):
(WebInspector.SearchController.prototype._onKeyDown):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype._toolbarDragStart):

  • inspector/front-end/UIUtils.js:

(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.var):
(WebInspector.startEditing):
(WebInspector.UIString):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.platform):
(WebInspector.isMac):
(WebInspector.platformFlavor):
(WebInspector.port):
(WebInspector.installPortStyles):
(WebInspector._windowFocused):
(WebInspector._windowBlurred):
(WebInspector.previousFocusElement):
(WebInspector.currentFocusElement):
(WebInspector._focusChanged):
(WebInspector.setCurrentFocusElement):

  • inspector/front-end/externs.js:

(Event.prototype.initWebKitWheelEvent):
(window.getComputedStyle):
(InspectorBackend.runAfterPendingDispatches):

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):
(WebInspector.addMainEventListeners):

Source/WebKit/chromium:

  • src/js/DevTools.js:
07:15 Changeset [98854] by kenneth@webkit.org

[Qt] MiniBrowser doesn't resize as the size is always overridden
https://bugs.webkit.org/show_bug.cgi?id=71212

Reviewed by Simon Hausmann.

Remove call overriden the size.

  • MiniBrowser/qt/main.cpp:

(main):

07:13 Changeset [98853] by andreas.kling@nokia.com

Kill StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=71218

Reviewed by Antti Koivisto.

Remove the StyleBase class and make all subclasses stand alone. CSSRule and StyleSheet
now inherit from RefCounted<T> instead, and XSLImportRule doesn't even need that,
so StyleBase is replaced by nothing.

  • css/StyleBase.cpp:
  • css/StyleBase.h:

Removed.

  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::~CSSRule):
(WebCore::CSSRule::useStrictParsing):
(WebCore::CSSRule::setParentStyleSheet):
(WebCore::CSSRule::setParentRule):
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
(WebCore::CSSRule::baseURL):
(WebCore::CSSRule::CSSRule):

CSSRule now inherits directly from RefCounted, and has either a CSSRule or a
CSSStyleSheet as its parent. Made these getters/setters inline since they are
trivial now.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Purge StyleBase.* from the build systems.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

New root() functions for CSSRule and StyleSheet.

  • bindings/js/JSNodeCustom.h:

Remove StyleBase.h include.

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::parentStyleSheet):

Added CSS-specific parentStyleSheet() so we don't have to cast it to a
CSSStyleSheet* at the call sites.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):

  • css/StyleSheet.h:

(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):
(WebCore::StyleSheet::isCSSStyleSheet):
(WebCore::StyleSheet::isXSLStyleSheet):

StyleSheet now inherits directly from RefCounted and always has a parent CSSRule
though it can be null. parentStyleSheet() returns that rule's parent style sheet.
Moved the relevant guts from StyleBase down here.

  • loader/cache/CachedStyleSheetClient.h:

Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedResourceClient.

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::parentStyleSheet):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):

  • xml/XSLImportRule.h:

(WebCore::XSLImportRule::create):
(WebCore::XSLImportRule::setParentStyleSheet):

Remove inheritance from StyleBase, and have create() return a PassOwnPtr instead.
This is fine, since XSLStyleSheet is the only object that ever manages these rules.

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedIntoDocument):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore::CSSStyleSheet::document):
(WebCore::CSSStyleSheet::styleSheetChanged):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::insertedIntoParent):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):

  • css/CSSRegionStyleRule.cpp:

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

  • css/CSSStyleDeclaration.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::append):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::parentStyleSheet):

  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::checkLoaded):
(WebCore::XSLStyleSheet::loadChildSheet):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

Use the new, more explicit, parenting functions of StyleSheet.

07:07 Changeset [98852] by zimmermann@webkit.org

2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

Reviewed by Antti Koivisto.

Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

  • css2.1/20110323/background-intrinsic-001.htm: Added.
  • css2.1/20110323/background-intrinsic-002.htm: Added.
  • css2.1/20110323/background-intrinsic-003.htm: Added.
  • css2.1/20110323/background-intrinsic-004.htm: Added.
  • css2.1/20110323/background-intrinsic-005.htm: Added.
  • css2.1/20110323/background-intrinsic-006.htm: Added.
  • css2.1/20110323/background-intrinsic-007.htm: Added.
  • css2.1/20110323/background-intrinsic-008.htm: Added.
  • css2.1/20110323/background-intrinsic-009.htm: Added.
  • css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width.svg: Added.
  • fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
  • fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
  • fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
  • platform/mac/fast/block/float/015-expected.txt: Ditto.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
  • svg/as-background-image/background-image-tiled.html: Added.
  • svg/as-background-image/resources/construction-tape.svg: Added.
  • svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
  • svg/as-background-image/same-image-two-instances-background-image.html: Added.
  • svg/as-image/img-preserveAspectRatio-support-1.html: Added.
  • svg/as-image/resources/circle-default-meet.svg: Added.
  • svg/as-image/resources/circle-default-none.svg: Added.
  • svg/as-image/resources/circle-default-slice.svg: Added.
  • svg/as-image/resources/circle-nosize.svg: Added.
  • svg/as-image/resources/circle-viewbox-default.svg: Added.
  • svg/as-image/resources/circle-viewbox-meet.svg: Added.
  • svg/as-image/resources/circle-viewbox-none.svg: Added.
  • svg/as-image/resources/circle-viewbox-slice.svg: Added.
  • svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
  • svg/as-image/same-image-two-instances.html: Added.
  • svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
  • svg/as-image/svg-image-change-content-size.xhtml: Added.
  • svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
  • svg/zoom/page/zoom-background-image-tiled.html: Added.
  • svg/zoom/page/zoom-background-images.html: Added.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.
  • svg/zoom/page/zoom-svg-as-image.html: Added.
  • svg/zoom/page/zoom-svg-as-relative-image.html: Added.

2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

SVGs do not work as tiled background images
https://bugs.webkit.org/show_bug.cgi?id=16281

Apply preserveAspectRatio and synthesize viewboxes in <img>
https://bugs.webkit.org/show_bug.cgi?id=34521

SVG background doesn't resize properly when dimensions are changed
https://bugs.webkit.org/show_bug.cgi?id=42944

Images with percent height inside a floated div should use intrinsic height.
https://bugs.webkit.org/show_bug.cgi?id=45439

SVG image in HTML changes size as the window is resized
https://bugs.webkit.org/show_bug.cgi?id=52045

Reviewed by Antti Koivisto.

Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

Tests: css2.1/20110323/background-intrinsic-001.htm

css2.1/20110323/background-intrinsic-002.htm
css2.1/20110323/background-intrinsic-003.htm
css2.1/20110323/background-intrinsic-004.htm
css2.1/20110323/background-intrinsic-005.htm
css2.1/20110323/background-intrinsic-006.htm
css2.1/20110323/background-intrinsic-007.htm
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
svg/as-image/same-image-two-instances.html
svg/as-image/svg-as-relative-image-with-explicit-size.html
svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
svg/zoom/page/zoom-svg-as-image.html
svg/zoom/page/zoom-svg-as-relative-image.html

  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor. (WebCore::CSSImageGeneratorValue::getImage): Ditto.
  • loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed. (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize(). (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache. (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer. (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter.
  • loader/cache/CachedImage.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
  • platform/graphics/Image.h: (WebCore::Image::setImageObserver): Add helper.
  • rendering/ImageBySizeCache.cpp: Cleanup code. (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid. (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage. (WebCore::ImageBySizeCache::getImage): Add zoom parameter. (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get requested size from cache, instead of actual cached sizes. (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting. (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
  • rendering/ImageBySizeCache.h: Cleaup code, introduce struct that replaces the std::pair<IntSize, int>. (WebCore::SizeZoomAndCount::SizeZoomAndCount):
  • rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images. (WebCore::resolveWidthForRatio): New inline helper function used by calculateImageIntrinsicDimensions. (WebCore::resolveHeightForRatio): Ditto. (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. (WebCore::resolveAgainstIntrinsicRatio): Ditto. (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec. (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer(). (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
  • rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0). (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged(). (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded(). (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct. (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages. (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null. (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
  • rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
  • rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
  • rendering/RenderImageResourceStyleImage.cpp: (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending. (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed. (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter.
  • rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
  • rendering/style/StyleImage.h: Ditto.
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
  • rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages). (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now. (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
  • rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::containerSize): (WebCore::RenderSVGRoot::setContainerSize):
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
  • svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement. (WebCore::SVGSVGElement::SVGSVGElement): Ditto. (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
  • svg/SVGSVGElement.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage. (WebCore::SVGImage::createWithDataAndSize): Add new helper function. (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor. (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size. (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement. (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs. (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document. (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation. (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
  • svg/graphics/SVGImage.h:
07:04 QtWebKitForQt5 edited by hausmann@webkit.org
(diff)
06:51 Changeset [98851] by caio.oliveira@openbossa.org

[Qt] Make QWebPreferences hold a QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=71219

Reviewed by Andreas Kling.

Change QWebPreferences to keep a pointer to QtWebPageProxy. The reason is that
some features we want to control (like the messaging exchange between WebView and
the web process) are not available via WKPreferencesRef.

QtWebPageProxy now uses an OwnPtr to keep the QWebPreferences to clarify the
ownership relationship. Before this change the QWebPreferences created was leaking.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferencesRef):

  • UIProcess/API/qt/qwebpreferences.h:
  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::preferences):

  • UIProcess/qt/QtWebPageProxy.h:
05:45 Changeset [98850] by yurys@chromium.org

2011-10-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end
files on Qt.

  • inspector/front-end/WebKit.qrc:
05:28 Changeset [98849] by vsevik@chromium.org

Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT.

  • platform/qt/Skipped:
05:00 Changeset [98848] by caseq@chromium.org

Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.

  • platform/chromium/test_expectations.txt:
04:55 Changeset [98847] by pfeldman@chromium.org

Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/bind-script-to-resource.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Script.js:

LayoutTests:

  • inspector/debugger/bind-script-to-resource-expected.txt: Added.
  • inspector/debugger/bind-script-to-resource.html: Added.
  • inspector/debugger/linkifier.html:
04:55 Changeset [98846] by carlosgc@webkit.org

[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71111

Reviewed by Martin Robinson.

Convenient method to create a WebKitSettings object with initial
settings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_new_with_settings):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsNewWithSettings):
(beforeAll):

04:45 Changeset [98845] by carlosgc@webkit.org

[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add WebKitSettingsPrivate.h.
  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkitSettingsAttachSettingsToPage): Set the preferences of the
given WebKitSettings object to the page group of the given WKPage.

  • UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Create the default WebKitSettings for
the view.
(webkit_web_view_set_settings):
(webkit_web_view_get_settings):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSettings):
(beforeAll):

04:23 Changeset [98844] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71012
Use StringHasher to generate the matched declaration cache hash

Reviewed by Sam Weinig.

Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):

  • css/CSSStyleSelector.h:
03:28 Changeset [98843] by caseq@chromium.org

Unreviewed.
Removed Mac10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
03:26 Changeset [98842] by carlosgc@webkit.org

Unreviewed. Fix make distcheck build.

Source/WebCore:

  • GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and

EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST.

Source/WebKit2:

  • GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST,

since its generation was removed from configure.ac in r98498.

02:35 Changeset [98841] by caseq@chromium.org

Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.

  • platform/chromium/test_expectations.txt:
02:18 Changeset [98840] by pfeldman@chromium.org

Web Inspector: factor out ResourceUtils, clean up externs.
https://bugs.webkit.org/show_bug.cgi?id=71192

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-31
Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:

(WebInspector.Resource.displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._createResource):

  • inspector/front-end/ResourceUtils.js: Added.

(WebInspector.resourceForURL):
(WebInspector.forAllResources):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.registerLinkifierPlugin):
(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyURL):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
(WebInspector.populateHrefContextMenu):
(WebInspector.completeURL):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.selectElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.networkResourceById):

  • inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.selectionLeftOffset):

01:37 Changeset [98839] by apavlov@chromium.org

Web Inspector: Using keyboard to increment/decrement units is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=71119

Reviewed by Pavel Feldman.

Source/WebCore:

This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.prototype._attributesModified):

LayoutTests:

  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:
01:28 Changeset [98838] by caseq@chromium.org

Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.

  • platform/chromium/test_expectations.txt:
00:48 Changeset [98837] by abarth@webkit.org

[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed
https://bugs.webkit.org/show_bug.cgi?id=71205

Reviewed by Ryosuke Niwa.

WebKit style is to use the implicit Boolean conversions rather than
calling get() on these pointer types. This patch cleans up most (all?)
of these style issues in the Chromium port in the hopes that they'll be
copy/pasted less in the future.

  • src/ApplicationCacheHostInternal.h:

(WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::setMainDocumentError):
(WebKit::FrameLoaderClientImpl::committedLoad):
(WebKit::FrameLoaderClientImpl::finishedLoading):
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::postMessageToRemote):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::hitTest):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::characterIndexForPoint):
(WebKit::WebFrameImpl::selectionAsText):
(WebKit::WebFrameImpl::selectionAsMarkup):
(WebKit::WebFrameImpl::getPrintPageShrink):
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printEnd):
(WebKit::WebFrameImpl::scopeStringMatches):

  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::type):

  • src/WebIDBKeyRange.cpp:

(WebKit::WebIDBKeyRange::lower):
(WebKit::WebIDBKeyRange::upper):
(WebKit::WebIDBKeyRange::lowerOpen):
(WebKit::WebIDBKeyRange::upperOpen):

  • src/WebImageCG.cpp:

(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::cancelLoad):
(WebKit::WebMediaPlayerClientImpl::play):
(WebKit::WebMediaPlayerClientImpl::pause):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
(WebKit::WebMediaPlayerClientImpl::naturalSize):
(WebKit::WebMediaPlayerClientImpl::hasVideo):
(WebKit::WebMediaPlayerClientImpl::hasAudio):
(WebKit::WebMediaPlayerClientImpl::setVisible):
(WebKit::WebMediaPlayerClientImpl::duration):
(WebKit::WebMediaPlayerClientImpl::currentTime):
(WebKit::WebMediaPlayerClientImpl::seek):
(WebKit::WebMediaPlayerClientImpl::seeking):
(WebKit::WebMediaPlayerClientImpl::setEndTime):
(WebKit::WebMediaPlayerClientImpl::setRate):
(WebKit::WebMediaPlayerClientImpl::paused):
(WebKit::WebMediaPlayerClientImpl::supportsFullscreen):
(WebKit::WebMediaPlayerClientImpl::supportsSave):
(WebKit::WebMediaPlayerClientImpl::setVolume):
(WebKit::WebMediaPlayerClientImpl::networkState):
(WebKit::WebMediaPlayerClientImpl::readyState):
(WebKit::WebMediaPlayerClientImpl::maxTimeSeekable):
(WebKit::WebMediaPlayerClientImpl::buffered):
(WebKit::WebMediaPlayerClientImpl::dataRate):
(WebKit::WebMediaPlayerClientImpl::totalBytesKnown):
(WebKit::WebMediaPlayerClientImpl::totalBytes):
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
(WebKit::WebMediaPlayerClientImpl::setSize):
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
(WebKit::WebMediaPlayerClientImpl::setPreload):
(WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin):
(WebKit::WebMediaPlayerClientImpl::movieLoadType):
(WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
(WebKit::WebMediaPlayerClientImpl::decodedFrameCount):
(WebKit::WebMediaPlayerClientImpl::droppedFrameCount):
(WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::startDelayedLoad):

  • src/WebURLRequest.cpp:

(WebKit::WebURLRequest::extraData):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::theme):
(WebKit::WebViewImpl::mainFrameImpl):
(WebKit::WebViewImpl::tabKeyCyclesThroughElements):
(WebKit::WebViewImpl::hideSelectPopup):
(WebKit::WebViewImpl::popupClosed):
(WebKit::WebViewImpl::focusedWebCoreFrame):
(WebKit::WebViewImpl::close):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::caretOrSelectionRange):
(WebKit::WebViewImpl::settings):
(WebKit::WebViewImpl::pageEncoding):
(WebKit::WebViewImpl::setPageEncoding):
(WebKit::WebViewImpl::setInitialFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::copyImageAt):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragLeave):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
(WebKit::WebViewImpl::inspectElementAt):
(WebKit::WebViewImpl::applyAutofillSuggestions):

  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::postMessageTask):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

00:10 Changeset [98836] by vangelis@chromium.org

Add missing declaration in WebSettings.h
https://bugs.webkit.org/show_bug.cgi?id=71165

Reviewed by Darin Fisher.

  • public/WebSettings.h:

10/30/11:

19:50 Changeset [98835] by yutak@chromium.org

WebSocket: iframe in reload-crash.html reloads forever
https://bugs.webkit.org/show_bug.cgi?id=71098

Reviewed by Kent Tamura.

iframe in this test should not get reloaded more than once.

  • http/tests/websocket/tests/hixie76/reload-crash.html:

Provide the value of reloadCount to the script in iframe.

  • http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html:

Call location.reload() only if reloadCount is zero.

  • http/tests/websocket/tests/hybi/reload-crash.html:
  • http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html:
18:50 Changeset [98834] by fpizlo@apple.com

JSParser::parsePrimaryExpression should have an overflow check
https://bugs.webkit.org/show_bug.cgi?id=71197

Reviewed by Geoff Garen.

  • parser/JSParser.cpp:

(JSC::JSParser::parsePrimaryExpression):

18:43 Changeset [98833] by commit-queue@webkit.org

Unreviewed, rolling out r98819, r98823, r98825, and r98830.
http://trac.webkit.org/changeset/98819
http://trac.webkit.org/changeset/98823
http://trac.webkit.org/changeset/98825
http://trac.webkit.org/changeset/98830
https://bugs.webkit.org/show_bug.cgi?id=71199

Broke Chromium Windows bot (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
17:21 Changeset [98832] by fpizlo@apple.com

DFG ValueAdd(string, int) should not fail speculation
https://bugs.webkit.org/show_bug.cgi?id=71195

Reviewed by Geoff Garen.

1% speed-up on V8.

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):

15:47 Changeset [98831] by fpizlo@apple.com

The DFG inliner should not flush the callee
https://bugs.webkit.org/show_bug.cgi?id=71191

Reviewed by Oliver Hunt.

0.6% speed-up on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeOrigin.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrameSlow):

15:42 Changeset [98830] by eric@webkit.org

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
15:06 Changeset [98829] by rik@webkit.org

Add Peter Beverloo's feed to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

  • config.ini:
12:34 Changeset [98828] by rniwa@webkit.org

Remove crash expectations from tests that have not been crashing on Chromium.

  • platform/chromium/test_expectations.txt:
09:29 Changeset [98827] by mrobinson@webkit.org

[GTK] Switch to a backing store approach for painting WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

  • platform/cairo/WidgetBackingStore.h:

(WebCore::WidgetBackingStore::size): Added this getter for the size.

  • platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.

  • platform/graphics/cairo/CairoUtilities.h:
  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.

  • WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use

the WebCore namespace to avoid lots of uses of "WebCore::".

  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.

  • webkit/webkitwebviewprivate.h: Add the backing store member.
09:03 Changeset [98826] by commit-queue@webkit.org

Unreviewed, rolling out r98803.
http://trac.webkit.org/changeset/98803
https://bugs.webkit.org/show_bug.cgi?id=71186

Causing test and assertion failures on some platforms
(Requested by anttik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyMatchedDeclarations):

00:57 Changeset [98825] by eric@webkit.org

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed. I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.

This was a regression from moving to a clean environment.
ChromiumWin (and possibly other ports), need the "PATH"
environment copied over. This wasn't caught in my testing
because although we had unittests to cover this, they
weren't being run on anything but windows. The vast majority
of this change is just fixing the unittests to use our
modern MockFileSystem/MockUser/MockExecutive so they can
be run on any system (and removing the platform checks from
the unittests so they are run everywhere).

The actual fix is the single line "PATH" string added to base.py.
The rest of this change is just fixing the Chromium port unittests
to run on all systems (including changing the Chromium port to
use FileSystem.path_to_module instead of file).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

10/29/11:

22:36 Changeset [98824] by mrowe@apple.com

Build fix.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

20:06 Changeset [98823] by eric@webkit.org

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

Fix the Qt port and unittest the function so we don't break it again.

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
17:45 Changeset [98822] by mrowe@apple.com

Build fix.

  • editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord):

16:27 Changeset [98821] by dcheng@chromium.org

Rename DataTransferItems to DataTransferItemList
https://bugs.webkit.org/show_bug.cgi?id=71151

Per feedback that Items and Item are hard to distinguish between, the HTML5 spec renamed
DataTransferItems to DataTransferItemList:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransferitemlist-interface

Reviewed by Tony Chang.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.h:
  • dom/Clipboard.idl:
  • dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTransferItems.cpp.

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::length):
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::deleteItem):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::add):

  • dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransferItems.h.

(WebCore::DataTransferItemList::~DataTransferItemList):

  • dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTransferItems.idl.
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemListChromium.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::addPasteboardItem):

  • platform/chromium/DataTransferItemListChromium.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.h.
  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::items):

  • platform/qt/ClipboardQt.h:
  • platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.cpp.

(WebCore::DataTransferItemListQt::create):
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::addPasteboardItem):

  • platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.h.
15:55 Changeset [98820] by annacc@chromium.org

Add track-text-track-destructor-crash.html to Skipped files for mac and win
https://bugs.webkit.org/show_bug.cgi?id=71182

Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped:
  • platform/win/Skipped:
15:06 Changeset [98819] by eric@webkit.org

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment just like ORWT did.
I've manually validated that NRWT now copies over
the same environment variables that ORWT did.
This new code is exercised by existing setup_environ_for_server tests.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
15:04 Changeset [98818] by rniwa@webkit.org

Mac rebaseline after r98813.

  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
14:34 Changeset [98817] by rniwa@webkit.org

Add flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
The failure is tracked by the bug 71181.

  • platform/chromium/test_expectations.txt:
14:20 Changeset [98816] by rniwa@webkit.org

GTK+ and Qt rebaselines after r98794.

  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5134759-expected.txt:
13:35 Changeset [98815] by robert@webkit.org

Second attempt to add results for tests introduced in http://trac.webkit.org/changeset/98812

  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png.
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt.
13:14 Changeset [98814] by robert@webkit.org

Qt and Gtk Results for tests updated by http://trac.webkit.org/changeset/98812

Unreviewed, platform-specific results.

  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
13:06 Changeset [98813] by robert@webkit.org

Add results for tests introduced in http://trac.webkit.org/changeset/98812.

Unreviewed, platform-specific results.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
12:15 Changeset [98812] by robert@webkit.org

CSS 2.1 failure: block-non-replaced-width-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69278

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthUsing):

Include the margins in the calculation of logical width even when the containing block's
width is zero. This is required by section '10.3.3 Block-level, non-replaced elements in
normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-008.htm in the CSS
test suite.

LayoutTests:

  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt: The pixel result is preserved, but the width of the containing block in the render tree now accurately reflects the rendered size of the cells.
  • platform/chromium/test_expectations.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
11:58 Changeset [98811] by abarth@webkit.org

Add results for tests introduced in http://trac.webkit.org/changeset/98805.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win-vista/css2.1: Removed.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
11:29 Changeset [98810] by abarth@webkit.org

Update results after http://trac.webkit.org/changeset/98794 to remove
0x0 DIV from the render tree.

  • platform/chromium-win/editing/pasteboard/5134759-expected.txt:
11:26 Changeset [98809] by abarth@webkit.org

Update line number in baseline.

  • platform/chromium-linux-x86/fast/dom: Removed.
  • platform/chromium/fast/dom/nested-script-exceptions-expected.txt: Added.
10:28 Changeset [98808] by robert@webkit.org

Platform-specific results for r98805

Unreviewed, add new results.

  • platform/gtk/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
09:52 Changeset [98807] by annacc@chromium.org

Make sure TextTracks are destructed if HTMLMediaElement goes away.
https://bugs.webkit.org/show_bug.cgi?id=71148

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-text-track-destructor-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

Destroy the client (this) on TextTracks.

(WebCore::HTMLMediaElement::loadTextTracks):

Move TextTrack creation to loadNextTextTrack.

(WebCore::HTMLMediaElement::loadNextTextTrack):

Keep track of new TextTrack in a list.

(WebCore::HTMLMediaElement::addTrack):

Keep track of new TextTrack in a list.

  • html/HTMLMediaElement.h:

Add m_textTracks and loadNextTextTrack().

LayoutTests:

  • media/track/track-text-track-destructor-crash-expected.txt: Added.
  • media/track/track-text-track-destructor-crash.html: Added.
09:18 Changeset [98806] by jochen@chromium.org

Implement IDBFactory.deleteDatabase
https://bugs.webkit.org/show_bug.cgi?id=62622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/factory-deletedatabase-interactions.html

storage/indexeddb/factory-deletedatabase.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::deleteDatabase):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::deleteDatabase):

  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
(WebKit::WebIDBFactoryImpl::deleteDatabase):

  • src/WebIDBFactoryImpl.h:

LayoutTests:

  • storage/indexeddb/factory-basics-expected.txt: Updated.
  • storage/indexeddb/factory-basics.html: Updated.
  • storage/indexeddb/factory-deletedatabase-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions.html: Added.
  • storage/indexeddb/factory-deletedatabase.html: Added.
  • storage/indexeddb/open-close-version-expected.txt: Updated.
  • storage/indexeddb/open-close-version.html: Updated.
07:52 Changeset [98805] by robert@webkit.org

CSS 2.1 failure: dynamic-top-change-001 to 004 fail
https://bugs.webkit.org/show_bug.cgi?id=68149

Reviewed by David Hyatt.

Source/WebCore:

In these tests a child inherits its top value from its parent and the parent's top value
is later updated by an onload event. The updated value is expected to cascade to the child.

The tests were failing because updating the value did not cascade immediately to the child inheriting it, though
it could be forced eventually with a full recalculation of the RenderStyle by changing the zoom factor
or opening the inspector.

The fix is to let the parent RenderStyle know that a child inherits a property explicitly and
recalculate children's style if the parent ever changes. This only happens if the property is inherited
explicitly, it does not apply to cases where the property is inherited by default.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
(WebCore::InheritedFlags::hasExplicitlyInheritedProperties):

LayoutTests:

  • css2.1/20110323/dynamic-top-change-001.htm: Added.
  • css2.1/20110323/dynamic-top-change-002.htm: Added.
  • css2.1/20110323/dynamic-top-change-003.htm: Added.
  • css2.1/20110323/dynamic-top-change-004.htm: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: See https://bugs.webkit.org/show_bug.cgi?id=68149#c15
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
07:45 Changeset [98804] by kbalazs@webkit.org

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

02:36 Changeset [98803] by antti@apple.com

Tighten font change conditions in matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=71026

Reviewed by Darin Adler.

We currently test if font description has changed to see if all properties need to be applied. However
only a few size related metrics can actually affect other properties. We can just test those, making
the cache somewhat more effective while also making the equality test faster.

  • css/CSSStyleSelector.cpp:

(WebCore::fontDifferenceAffectsNonInherited):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
values of non-text CSS properties.

02:10 Changeset [98802] by abarth@webkit.org

DOMURL should keep its own state rather than storing it on ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=71169

Reviewed by Eric Seidel.

This patch untwists this code. I think this code was originally
twisted because these APIs moved onto DOMURL after they were first
implemented.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • fileapi/FileWriter.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:
01:21 Changeset [98801] by commit-queue@webkit.org

Unreviewed, rolling out r98780.
http://trac.webkit.org/changeset/98780
https://bugs.webkit.org/show_bug.cgi?id=71173

Broke Qt bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-29

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

00:58 Changeset [98800] by antti@apple.com

REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Ryosuke Niwa.

In an effort to gain Hyatt points, add a less obscure test for this case.

  • fast/css/inherited-properties-explicit-expected.txt: Added.
  • fast/css/inherited-properties-explicit.html: Added.
00:19 Changeset [98799] by commit-queue@webkit.org

Unreviewed, rolling out r98795.
http://trac.webkit.org/changeset/98795
https://bugs.webkit.org/show_bug.cgi?id=71171

Causes worker tests to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-29

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

00:04 Changeset [98798] by rniwa@webkit.org

Mac rebaseline after r98617.

  • platform/mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt:
  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

10/28/11:

23:41 Changeset [98797] by rniwa@webkit.org

Rebaseline after r98775.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
23:31 Changeset [98796] by rniwa@webkit.org

Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

22:51 Changeset [98795] by abarth@webkit.org

MessagePort should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=71167

Reviewed by Eric Seidel.

I couldn't quite get rid of all the uses of the
ScriptExecutionContext::m_messagePorts in this patch. I hope to get
rid of them in the future as the "extra data" design for
ScriptExecutionContext emerges.

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

22:27 Changeset [98794] by rniwa@webkit.org

The copy and paste result in nested scrollbars on http://dojotoolkit.org/widgets
https://bugs.webkit.org/show_bug.cgi?id=70799

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit's treating a fully selected root with background property as a special common ancestor.
A variant of this bug was caused by treating any element with text-decoration property as a presentational element.

Fixed the above two bugs by not serializing the said nodes. The effective background color was already serialized
by wrappingStyleForSerialization, there was nothing to be done besides stop including it in highestAncestorToWrapMarkup.

For text-decoration property, added the logic to compute the effective value in EditingStyle::init. Also treat it
as a non-inheritable editing property so that the rest of EditingStyle just works.

Test: editing/pasteboard/avoid-copying-body-with-background.html

  • editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list of editing properties.

(WebCore::copyEditingProperties):
(WebCore::EditingStyle::init): Compute the effective text decoration when propertiesToInclude is
EditingPropertiesInEffect.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

  • editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgroundColorInEffect to

EditingPropertiesInEffect.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an assertion that's no longer valid.
(WebCore::isElementPresentational): Don't consider an element with text-decoration as a presentational element.
(WebCore::highestAncestorToWrapMarkup): Don't consider fully selected root as a special common ancestor ever.
Background color is computed property when we compute the wrapping style.
(WebCore::createMarkup):

LayoutTests:

Added a test to copy contents inside a body with background and text-decoration properties.

WebKit should not copy body element.

  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: an erroneous inline div

is replaced by a span.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: two style spans are

merged into one.

  • editing/pasteboard/19644-2-expected.txt: div is replaced by span. This is okay because it's the only

content in the body. Even though we now only put the gray background under text as inline style as
opposed to apply at the block level, that's what execCommand('BackColor'...) does and what user expects.

  • editing/pasteboard/avoid-copying-body-with-background-expected.txt: Added.
  • editing/pasteboard/avoid-copying-body-with-background.html: Added.
  • editing/pasteboard/preserve-underline-color-expected.txt:
  • platform/mac/editing/pasteboard/5134759-expected.txt:
18:56 Changeset [98793] by abarth@webkit.org

Rename ExceptionCodeDescription.in to DOMExceptions.in
https://bugs.webkit.org/show_bug.cgi?id=71157

Reviewed by Eric Seidel.

.:

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

This file is now used for more than just the descriptions of the exceptions.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDescription.in.
  • dom/ExceptionCodeDescription.in: Removed.
  • dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_exception_code_description.pl.
  • dom/make_exception_code_description.pl: Removed.
18:47 Changeset [98792] by crogers@google.com

SincResampler must be able to resample progressively
https://bugs.webkit.org/show_bug.cgi?id=71131

Reviewed by Kenneth Russell.

No new tests. There is not yet an implementation using progressive resampling to test.

  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):

  • platform/audio/SincResampler.h:
18:31 Changeset [98791] by adamk@chromium.org

[MutationObservers] Support attributeOldValue for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70861

Reviewed by Ryosuke Niwa.

Source/WebCore:

Respect 'attributeOldValue' when passed to WebKitMutationObserver.observe().

If multiple observers have different attributeOldValue settings in
their registrations, two different MutationRecords are created (one is
a wrapper around the other).

If a single observer has multiple registrations that apply to a single
mutation, and those registrations have different values for
attributeOldValue, the observer is passed the oldValue.

  • dom/Element.cpp:

(WebCore::hasOldValue):
(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createWithNullOldValue):

  • dom/MutationRecord.h:

(WebCore::MutationRecord::oldValue):

LayoutTests:

Added test cases for attributeOldValue to existing tests.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
18:14 Changeset [98790] by abarth@webkit.org

Delete ExceptionCode.cpp, which is empty
https://bugs.webkit.org/show_bug.cgi?id=71159

Reviewed by Eric Seidel.

This file has been stripped down to nothing and can be removed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ExceptionCode.cpp: Removed.
17:51 Changeset [98789] by commit-queue@webkit.org

Unreviewed, rolling out r98776.
http://trac.webkit.org/changeset/98776
https://bugs.webkit.org/show_bug.cgi?id=71164

caused lots of test crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus):
(WebCore::RenderLayer::dirtyZOrderLists):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode):

LayoutTests:

  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):

  • compositing/visibility/animation-visibility-expected.png: Removed.
  • compositing/visibility/animation-visibility-expected.txt: Removed.
  • compositing/visibility/animation-visibility.html: Removed.
17:32 Changeset [98788] by sullivan@apple.com

Improvement to the fix for:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Dan Bernstein.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):
Do the frame->settings() check after the !page check, since
a null page means null settings.

17:30 Changeset [98787] by abarth@webkit.org

Make DOMURL a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=71162

Reviewed by Eric Seidel.

This removes a bunch of hand-rolled ifdefed code.

  • dom/ActiveDOMObject.h:
    • One-argument constructors should be explicit.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):

  • html/DOMURL.h:
17:10 Changeset [98786] by dino@apple.com

Remove this horribly outdated file. It was showing up in
Google searches and shouldn't be used as official
documentation.

Rubber-stamped by Simon Fraser.

  • specs/MediaQueriesExtensions.html: Removed.
17:03 Changeset [98785] by commit-queue@webkit.org

webkit.py gdb visualizer is broken after change to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=71154

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

r98624 changed StringImpl m_data to m_data32. This changes updates
webkit.py to match.

  • gdb/webkit.py:
16:57 Changeset [98784] by abarth@webkit.org

Factor ContextDestructionObserver out of ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=71153

Reviewed by Sam Weinig.

This patch paves the way to make more objects observe the destruction
of ScriptExecutioContext without needing to add ifdefs to
ScriptExecutionContext.h/cpp. (As an example, see DOMURL.)

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(WebCore::ContextDestructionObserver::scriptExecutionContext):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
(WebCore::didCreateDestructionObserver):
(WebCore::willDestroyDestructionObserver):

  • dom/ScriptExecutionContext.h:
16:51 Changeset [98783] by joepeck@webkit.org

<http://webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names

Reviewed by Dan Bernstein.

  • Scripts/check-for-inappropriate-objc-class-names:
16:44 Changeset [98782] by commit-queue@webkit.org

Add support for sending scroll-update events from EventSender.
https://bugs.webkit.org/show_bug.cgi?id=66272

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-10-28
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::reset):
(EventSender::gestureScrollUpdate):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests:

  • fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
  • fast/events/touch/gesture/gesture-scroll.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
  • platform/qt/Skipped:
16:35 Changeset [98781] by jeffm@apple.com

More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

16:31 Changeset [98780] by eric@webkit.org

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

16:31 Changeset [98779] by timothy_horton@apple.com

One more unreviewed build fix due to r98775.

No new tests.

  • WebCore.vcproj/WebCore.vcproj:
16:30 Changeset [98778] by jamesr@google.com

[chromium] Track wheel event handler registration and pass to input filter
https://bugs.webkit.org/show_bug.cgi?id=71078

Reviewed by Kenneth Russell.

Source/WebCore:

This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
registered, which includes JS handlers and scrollable areas other than the main view, the input filter will pass
mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
wheel events into root layer scrolling.

Only changes behavior with an off-by-default flag enabled, so no tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCScrollController.h:

Source/WebKit/chromium:

Pushes mouse wheel event handler notifications to CCLayerTreeHost when compositing.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
16:27 Changeset [98777] by timothy_horton@apple.com

Unreviewed build fix due to r98775.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
16:18 Changeset [98776] by simon.fraser@apple.com

If visibility changes while an accelerated animation is running, element jumps around
https://bugs.webkit.org/show_bug.cgi?id=29984

Source/WebCore:

Reviewed by Chris Marrin.

Compositing now affects whether RenderLayers for visibility:hidden elements
are included in z-order lists. So we have to dirty those lists when we enter
compopsiting mode.

Test: compositing/visibility/animation-visibility.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitespace.
(WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(), which doesn't have
to ping the compositor.
(WebCore::RenderLayer::dirtyZOrderListsInternal):
(WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursively dirty z-order
lists.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
dirty all z-order lists.

LayoutTests:

Reviewed by Chris Marrin.

Add testcase for visibility changing in the middle of an accelerated animation.

  • animations/resources/animation-test-helpers.js: Add some constants for readability.

(checkExpectedValue): Add support for testing 'visibility'.

  • compositing/visibility/animation-visibility-expected.png: Added.
  • compositing/visibility/animation-visibility-expected.txt: Added.
  • compositing/visibility/animation-visibility.html: Added.
16:08 Changeset [98775] by timothy_horton@apple.com

Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Parse -webkit-cross-fade according to the CSS3 Images Values specification.

Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
instead of the global one. This allows - for example - cross-fade to pass each of its arguments back into
parseFillImage and to successfully parse image functions in this fashion.

Test: fast/css/getComputedStyle/computed-style-cross-fade.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCrossfadeValue.cpp: Added.

(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::cssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):

  • css/CSSCrossfadeValue.h: Added.

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isFixedSize):
(WebCore::CSSCrossfadeValue::setFromImage):
(WebCore::CSSCrossfadeValue::setToImage):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCanvas):

  • css/CSSParser.h:

Add tests to ensure that -webkit-cross-fade is parsed correctly.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-cross-fade.html: Added.
16:06 Changeset [98774] by mitz@apple.com

Attempted build fix after r98765.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph):

15:55 Changeset [98773] by cmarrin@apple.com

CSS grammar doesn't support functions with no parameters
https://bugs.webkit.org/show_bug.cgi?id=69110

Reviewed by Dean Jackson.

Source/WebCore:

Add rule to grammar to accept functions with 0 args and return
this case with a CSSParserValueList with 0 values. Also fixed
filter creation function to properly handle filters with 0
arguments.

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Updated tests to include tests for allowing 0 argument functions and for
disallowing functions with trailing commas (to pickup a couple of theses
cases not in the current tests). Also fixed one typo.

  • css3/filters/filter-property-computed-style-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt:
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-computed-style.js:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:

(testFilterRule):

15:35 Changeset [98772] by leviw@chromium.org

Fixing fast/flexbox/flex-hang. Had used an int instead of a LayoutUnit.

15:34 Changeset [98771] by johnnyg@google.com

Unreviewed, rolling out r98757.
http://trac.webkit.org/changeset/98757
https://bugs.webkit.org/show_bug.cgi?id=71150

crashes webkit_unit_tests on chromium windows (Requested by
johnny_g on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

15:21 Changeset [98770] by abarth@webkit.org

Rubber-stamped by Eric Seidel.

Fix namespace indent in ScriptExecutionContext.h.

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isDocument):
(WebCore::ScriptExecutionContext::isWorkerContext):
(WebCore::ScriptExecutionContext::setHasOpenDatabases):
(WebCore::ScriptExecutionContext::hasOpenDatabases):
(WebCore::ScriptExecutionContext::url):
(WebCore::ScriptExecutionContext::completeURL):
(WebCore::ScriptExecutionContext::securityOrigin):
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
(WebCore::ScriptExecutionContext::activeDOMObjects):
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::messagePorts):
(WebCore::ScriptExecutionContext::domUrls):
(WebCore::ScriptExecutionContext::ref):
(WebCore::ScriptExecutionContext::deref):
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):

15:07 Changeset [98769] by sullivan@apple.com

Source/WebCore: WebCore part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):
Bail out if backspace navigation is not enabled.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
Initialize m_backspaceKeyNavigationEnabled to true to match current behavior.

  • page/Settings.h:

Declared m_backspaceKeyNavigationEnabled.
(WebCore::Settings::setBackspaceKeyNavigationEnabled):
New function, simple setter.
(WebCore::Settings::backspaceKeyNavigationEnabled):
New function, simple getter.

Source/WebKit/mac: WebKit part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • WebView/WebFrameView.mm:

(-[WebFrameView keyDown:]):
Honor the new preference.

  • WebView/WebPreferenceKeysPrivate.h:

Added #define for WebKitBackspaceKeyNavigationEnabledKey

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Initialize new pref to YES, to match current behavior.
(-[WebPreferences setBackspaceKeyNavigationEnabled:]):
New method, standard prefs setter.
(-[WebPreferences backspaceKeyNavigationEnabled]):
New method, standard prefs getter.

  • WebView/WebPreferencesPrivate.h:

Declared new methods.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • Shared/WebPreferencesStore.h:

Declared backspaceKeyNavigationEnabled property using macro. This initializes
it to true, to match current behavior.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBackspaceKeyNavigationEnabled):
New function, pass value to impl.
(WKPreferencesGetBackspaceKeyNavigationEnabled):
New function, returns result from impl.

  • UIProcess/API/C/WKPreferences.h:

Declared API functions for new preference.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Updates WebCore settings from WebKit2 prefs.

14:55 Changeset [98768] by johnnyg@google.com

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/dom: Removed.
  • platform/chromium-cg-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/hixie/perf: Removed.
  • platform/chromium-cg-mac/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/visibility: Added.
  • platform/chromium-gpu-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-gpu-win/compositing/visibility: Added.
  • platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom: Removed.
  • platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:55 Changeset [98767] by eae@chromium.org

Overridden clippedOverflowRectForRepaint() still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71046

Reviewed by Simon Fraser.

Change all virtual clippedOverflowRectForRepaint functions to use the
same signature.

No new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):

  • rendering/RenderText.h:
14:46 Changeset [98766] by adamk@chromium.org

Remove unused parsers for 'exception' and 'alias' IDL keywords
https://bugs.webkit.org/show_bug.cgi?id=71140

Reviewed by Adam Barth.

  • bindings/scripts/IDLParser.pm:

(ParseInterface):
(DetermineParseMode):
(ProcessSection):

  • bindings/scripts/IDLStructure.pm:
14:41 Changeset [98765] by mitz@apple.com

<rdar://problem/10288006> Emoji characters are too close to each other in small font size

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
-[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances().

LayoutTests:

  • platform/mac/fast/css/font-family-pictograph-expected.txt:
14:30 Changeset [98764] by abarth@webkit.org

Remove unused default constructor
https://bugs.webkit.org/show_bug.cgi?id=71136

Reviewed by Eric Seidel.

No one is calling this constructor anymore now that we've fixed the
callers.

  • dom/make_exception_code_description.pl:

(generateHeader):

14:28 Changeset [98763] by commit-queue@webkit.org

Crash when splitting inline flows with generated floats
https://bugs.webkit.org/show_bug.cgi?id=70458

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-28
Reviewed by David Hyatt.

Source/WebCore:

When lineBoxes on a RenderBlock are being deleted, we now check the floating object list to
ensure references to them are being cleared.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them

LayoutTests:

Added test for crash condition when splitting inline flows on an object with generated floats.

  • fast/css-generated-content/inline-splitting-with-after-float-crash.html: Added
  • fast/css-generated-content/inline-splitting-with-after-float-crash-expected.txt: Added
14:26 Changeset [98762] by simon.fraser@apple.com

Remove Leopard-only code from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=71141

Reviewed by Chris Marrin.

Remove !HAVE_MODERN_QUARTZCORE code, which was only
used on Leopard. updateContentsTransform() became a no-op,
so could be removed.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:
14:17 Changeset [98761] by lforschler@apple.com

New tag.

14:10 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Added one more adjective to the list of good properties for a test (diff)
14:00 Changeset [98760] by lforschler@apple.com

Rollout 98610.

13:51 Changeset [98759] by timothy@apple.com

Support using a different front-end for the Web Inspector in WebKit2.

rdar://problem/10318665
https://webkit.org/b/71089

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Added webInspectorBasePath and webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetOverrideWebInspectorBaseDirectory): Added. Calls through to WebContext.
(WKContextSetOverrideWebInspectorPagePath): Ditto.
(WKContextSetOverrideWebInspectorLocalizedStringsPath): Ditto.

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Set webInspectorBasePath and webInspectorLocalizedStringsPath.

  • UIProcess/WebContext.h:

(WebKit::WebContext::overrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::setOverrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::overrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorLocalizedStringsPath): Added.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL): Use WebContext::overrideWebInspectorPagePath if set.
(WebKit::WebInspectorProxy::inspectorBaseURL): Use WebContext::overrideWebInspectorBaseDirectory if set.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::globalInspectorLocalizedStringsURL): Added. Static storage for the setting.
(WebKit::WebInspector::setLocalizedStringsPath): Added. Set globalInspectorLocalizedStringsURL.
(WebKit::WebInspector::localizedStringsURL): Return globalInspectorLocalizedStringsURL.

  • WebProcess/com.apple.WebProcess.sb: Added read-only subpath for WEBKIT_WEB_INSPECTOR_DIR.
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendReadonlySandboxDirectory): Check path for empty to prevent an exception when
calling through to fileSystemRepresentation.
(WebKit::initializeSandbox): Added WEBKIT_WEB_INSPECTOR_DIR parameter.
(WebKit::WebProcess::platformInitializeWebProcess): Call WebInspector::setLocalizedStringsPath.

13:46 Changeset [98758] by eric@webkit.org

NRWT crashes when parsing leaks output due to UTF-8 decoding error
https://bugs.webkit.org/show_bug.cgi?id=71112

Reviewed by Adam Barth.

Use read_binary_file instead of read_text_file and add a test
case with some non-utf8 data to make sure we don't break this in the future.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
13:44 Changeset [98757] by enne@google.com

[chromium] Implicitly skip render surfaces that won't be drawn
https://bugs.webkit.org/show_bug.cgi?id=71038

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

13:27 Changeset [98756] by ap@apple.com

Clean up BuiltInPDFView a little
https://bugs.webkit.org/show_bug.cgi?id=71133

Reviewed by Daniel Bates.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):

Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
to subframes, and thus shouldn't apply to PDFs.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

Moved to a correct location. This is not a Plugin method, but a ScrollView one.

13:20 Changeset [98755] by abarth@webkit.org

Autogenerate Exception-downcast code in bindings
https://bugs.webkit.org/show_bug.cgi?id=71108

Reviewed by Eric Seidel.

This patch uses the same generated code style as we're using for Events
to generate the downcasts for the Exception types in the bindings.
This cause me to refactor more code from make_event_factory.pl into
InFilesCompiler.pm.

After this patch, some of these files and scripts are misnamed. I'll
rename them in a followup patch.

  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • bindings/scripts/InFilesCompiler.pm:

(initializeFromCommandLine):
(compile):
(interfaceForItem):
(toMacroStyle):
(generateInterfacesHeader):
(generateHeadersHeader):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCodeDescription.in:
  • dom/make_event_factory.pl:

(generateCode):
(generateImplementation):

  • dom/make_exception_code_description.pl:

(defaultItemFactory):
(generateCode):

13:10 Changeset [98754] by leviw@chromium.org

Build fixes for Chromium-Mac.

12:58 Changeset [98753] by levin@chromium.org

watchlist should not CC the bug reporter
https://bugs.webkit.org/show_bug.cgi?id=71079

Reviewed by Adam Barth.

Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.

  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
  • Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
  • Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
12:42 Changeset [98752] by simon.fraser@apple.com

Fix builds which have ACCELERATED_COMPOSITING disabled.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists):

12:36 Changeset [98751] by johnnyg@google.com

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/hixie: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/perf: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/002-expected.txt: Removed.
  • platform/chromium-win-vista/svg/batik/text: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium/fast/js/array-prototype-properties-expected.txt: Replaced.
  • platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:29 Changeset [98750] by arv@chromium.org

Remove LegacyDefaultOptionalArguments flag from inspector IDLs
https://bugs.webkit.org/show_bug.cgi?id=65748

Reviewed by Adam Barth.

Covered by existing tests.

  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorFrontendHost.idl:
  • inspector/JavaScriptCallFrame.idl:
12:22 Changeset [98749] by commit-queue@webkit.org

IndexedDB: Database metadata changes should be tied to transaction
https://bugs.webkit.org/show_bug.cgi?id=70974

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

Source/WebCore:

Database metadata (that is, the version string) was rolled back
on abort by an abort task. If the abort task didn't run e.g.
due to a crash, the metadata would not be reverted. All of the
other store/index/data changes were written into the transaction
itself, so the metadata now is too. Refactored the metadata
get/create/update methods for clarity as well.

Note that the new tests don't actually verify that the code handles
this case; that will need to be done with persistence tests
that span multiple runs of the browser and induce crashes.
The new tests do verify that these changes don't cause regressions
not caught by other tests.

Tests: storage/indexeddb/open-during-transaction.html

storage/indexeddb/version-change-abort.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):

  • storage/IDBLevelDBBackingStore.h:

LayoutTests:

  • storage/indexeddb/open-during-transaction-expected.txt: Added.
  • storage/indexeddb/open-during-transaction.html: Added.
  • storage/indexeddb/version-change-abort-expected.txt: Added.
  • storage/indexeddb/version-change-abort.html: Added.
12:15 Changeset [98748] by macpherson@chromium.org

Use enum instead of bool to represent -webkit-column-span property.
https://bugs.webkit.org/show_bug.cgi?id=70867

Reviewed by Darin Adler.

Covered by existing tests.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousColumnSpanBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleMultiColData.h:
12:08 Changeset [98747] by mhahnenberg@apple.com

De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
https://bugs.webkit.org/show_bug.cgi?id=70968

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • API/JSCallbackObject.cpp: Added two specializations for createStructure that use different JSTypes in their

TypeInfo. Had to also create a specialization for JSNonFinalObject, even JSGlobalObject was the only that
needed it because Windows wouldn't build without it.
(JSC::::createStructure):

  • API/JSCallbackObject.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ErrorInstance.h: Removed virtual function and changed JSType provided to TypeInfo in createStructure.

(JSC::ErrorInstance::createStructure):

  • runtime/ErrorPrototype.h: Ditto

(JSC::ErrorPrototype::createStructure):

  • runtime/JSActivation.h: Ditto

(JSC::JSActivation::createStructure):

  • runtime/JSGlobalObject.h: Ditto

(JSC::JSGlobalObject::createStructure):

  • runtime/JSObject.h: De-virtualized functions. They now check the JSType of the object for the corresponding type.

(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):

  • runtime/JSType.h: Added new types for GlobalObject, VariableObject, ActivationObject, and ErrorInstance.
  • runtime/JSVariableObject.cpp: Removed virtual function.
  • runtime/JSVariableObject.h: Changed JSType provided to TypeInfo in createStructure.

(JSC::JSVariableObject::createStructure):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo in createStructure since this

class inherits from JSGlobalObject.
(WebCore::JSDOMGlobalObject::createStructure):

  • bindings/js/JSDOMWindowBase.h: Ditto

(WebCore::JSDOMWindowBase::createStructure):

  • bindings/js/JSWorkerContextBase.h: Ditto

(WebCore::JSWorkerContextBase::createStructure):

  • bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure subclasses of JSGlobalObject,

namely JSDOMWindow and JSWorkerContext, get their special JSType in their createStructure function.
(GenerateHeader):

11:57 Changeset [98746] by simon.fraser@apple.com

Added some missing results for compositing visibilty tests.

  • platform/mac/compositing/visibility/visibility-composited-expected.txt: Added.
  • platform/mac/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
  • platform/mac/compositing/visibility/visibility-image-layers-expected.txt: Added.
11:43 Changeset [98745] by commit-queue@webkit.org

Unreviewed, rolling out r98736.
http://trac.webkit.org/changeset/98736
https://bugs.webkit.org/show_bug.cgi?id=71125

This patch broke perf/array-binary-search.html test (Requested
by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::addTrack):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Removed.
  • media/track/track-load-error-readyState.html: Removed.
  • media/track/track-load-from-element-readyState-expected.txt: Removed.
  • media/track/track-load-from-element-readyState.html: Removed.
  • media/track/track-load-from-src-readyState-expected.txt: Removed.
  • media/track/track-load-from-src-readyState.html: Removed.
11:40 Changeset [98744] by zherczeg@webkit.org

Testing allowed identifier chars which are greater than 126
https://bugs.webkit.org/show_bug.cgi?id=71097

Reviewed by Darin Adler.

  • fast/css/parsing-css-nonascii-expected.txt: Added.
  • fast/css/parsing-css-nonascii.html: Added.
11:29 Changeset [98743] by inferno@chromium.org

Merge 98411 - Made Table tests for Bug 70678 Platform Independent
BUG=101540
Review URL: http://codereview.chromium.org/8416045

11:28 Changeset [98742] by eae@chromium.org

Fix PluginView rect calculation

11:28 Changeset [98741] by inferno@chromium.org

Merge 98411 - Made Table tests for Bug 70678 Platform Independent
BUG=101540
Review URL: http://codereview.chromium.org/8343064

11:25 Changeset [98740] by inferno@chromium.org

Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure
BUG=101540
Review URL: http://codereview.chromium.org/8417039

11:23 Changeset [98739] by inferno@chromium.org

Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure
BUG=101540
Review URL: http://codereview.chromium.org/8343063

11:06 WinCE edited by patricke@bsquare.com
(diff)
11:04 Changeset [98738] by jchaffraix@webkit.org

RenderTableSection::recalcCells should not free its grid
https://bugs.webkit.org/show_bug.cgi?id=71056

Reviewed by Darin Adler.

Refactoring only, no change in behavior.

r98614 had the bad side effect of clearing the row vector (m_grid) on
the RenderTableSection when doing a recalcCells. This change removes the
unneeded free and inline the |row| field into the RowStruct as it made
no sense to have it as a pointer.

  • rendering/RenderTableSection.cpp:

(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Mechanical changes now that |row| is a member of RowStruct.

(WebCore::RenderTableSection::~RenderTableSection): Clear our row vector.

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::recalcCells):
Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPosition.

(WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition):
Factored the code to fill the RowStruct structure with default values.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
More mechanical change after the |row| field change.

11:00 Changeset [98737] by rniwa@webkit.org

Unskip tables/mozilla_expected_failures/bugs/bug14007-2.html
since the test was rebaselined in r98691.

Also enable platform/mac/editing/deleting/backward-delete.html on Chromium Mac
and skip it again on Chromium Windows and Linux.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:54 Changeset [98736] by annacc@chromium.org

Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html

media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::loadNextTextTrack):
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Added.
  • media/track/track-load-error-readyState.html: Added.
  • media/track/track-load-from-element-readyState-expected.txt: Added.
  • media/track/track-load-from-element-readyState.html: Added.
  • media/track/track-load-from-src-readyState-expected.txt: Added.
  • media/track/track-load-from-src-readyState.html: Added.
10:46 Changeset [98735] by simon.fraser@apple.com

Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html

compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.

  • platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,

added ContentsVisibilityChanged flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.

  • rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

  • compositing/visibility/visibility-composited-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms.html: Added.
  • compositing/visibility/visibility-composited.html: Added.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • compositing/visibility/visibility-image-layers-dynamic.html: Added.
  • compositing/visibility/visibility-image-layers-expected.png: Added.
  • compositing/visibility/visibility-image-layers.html: Added.
10:42 Changeset [98734] by leviw@chromium.org

Adding Mac fixed classes to chromium gypi.

10:35 Changeset [98733] by arv@chromium.org

JS Test Harness: Remove js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=70959

Reviewed by Ojan Vafai.

This moves isSuccessfullyParsed to js-test-pre.js and removes js-test-post-function.js and all references to it.

  • fast/js/resources/js-test-post-function.js: Removed.
  • fast/js/resources/js-test-pre.js:

(isSuccessfullyParsed): Moved here from js-test-post-function.js

09:58 Changeset [98732] by japhet@chromium.org

empty-urls.html needs to stop being flaky.
Because it was in http/tests/loading, it output
frame load callbacks, and it was unpredictable whether
the callback for onload or for the load completing would
be called first. Ergo, move the test to http/tests/misc,
and remove the logic which failed to enforce a frame load
callback ordering.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

  • http/tests/loading/empty-urls-expected.txt: Removed.
  • http/tests/loading/empty-urls.html: Removed.
  • http/tests/misc/empty-urls-expected.txt: Copied from LayoutTests/http/tests/loading/empty-urls-expected.txt.
  • http/tests/misc/empty-urls.html: Copied from LayoutTests/http/tests/loading/empty-urls.html.
  • platform/chromium/test_expectations.txt:
09:50 WebKitGTK/1.6.x edited by plaes@plaes.org
Added .xz tarball creation patch (diff)
09:47 Changeset [98731] by philn@webkit.org

[GTK] Build fixes for glib 2.31 (current master)
https://bugs.webkit.org/show_bug.cgi?id=70679

Reviewed by Martin Robinson.

g_cond_new and g_mutex_new have been replaced by _init
functions. Same for _free, replaced by _clear.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkit_video_sink_dispose):

09:29 Changeset [98730] by jochen@chromium.org

Rename a number of methods mentioning JavaScript to just Script instead
https://bugs.webkit.org/show_bug.cgi?id=71105

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowScript):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setScriptEnabled):

  • page/Settings.h:

(WebCore::Settings::isScriptEnabled):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScript):

  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::collectGarbage):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setJavaScriptEnabled):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_enable_scripts_set):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

  • WebView.cpp:

(WebView::WebView):

Source/WebKit/wx:

  • WebSettings.cpp:

(wxWebSettings::SetJavaScriptEnabled):
(wxWebSettings::IsJavaScriptEnabled):

  • WebView.cpp:

(wxWebView::Create):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

09:22 Changeset [98729] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Remove fast/replaced/table-percent-height.html that has been passing for at least
a week. Also tighten some tests that have not been passing (but occasionally timing
out) on the flakyness dashboard for some time.

08:22 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
08:17 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
07:57 Changeset [98728] by vsevik@chromium.org

Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html.

  • platform/mac/Skipped:
07:52 Changeset [98727] by zoltan@webkit.org

Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
https://bugs.webkit.org/show_bug.cgi?id=71116

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
07:42 Changeset [98726] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
06:59 Changeset [98725] by ossy@webkit.org

[Qt][WK2] Unreviewed gardening.

REGRESSION: 5 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=71117

  • platform/qt-wk2/Skipped: Skip failing tests.
06:27 Changeset [98724] by pfeldman@chromium.org

Reset line numbers for scripts generated with document.write.
https://bugs.webkit.org/show_bug.cgi?id=71099

Reviewed by Yury Semikhatsky.

Source/JavaScriptCore:

  • wtf/text/TextPosition.h:

(WTF::OrdinalNumber::OrdinalNumber):

Source/WebCore:

Test: http/tests/inspector-enabled/document-write.html

  • dom/Document.h:

(WebCore::Document::isInDocumentWrite):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

LayoutTests:

  • http/tests/inspector-enabled/document-write-expected.txt: Added.
  • http/tests/inspector-enabled/document-write.html: Added.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt:
06:10 Changeset [98723] by yurys@chromium.org

2011-10-28 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Unsupress css3/font-feature-settings-rendering.html as it should
pass on Linux after r98716.

  • platform/chromium/test_expectations.txt:
06:06 Changeset [98722] by ossy@webkit.org

[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
https://bugs.webkit.org/show_bug.cgi?id=70494

One more buildfix. (unreviewed)

  • UIProcess/API/qt/qtouchwebpage.cpp:

(computeEffectiveOpacity):
(QTouchWebPage::itemChange):

06:06 Changeset [98721] by ossy@webkit.org

[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
https://bugs.webkit.org/show_bug.cgi?id=70494

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-10-28
Reviewed by Kenneth Christiansen.

Use QQuick* instead of QSG* as well as QStandardPaths
instead of QDesktopLocation.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Source/WebKit2:

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::event):
(QDesktopWebViewPrivate::engine):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
(QTouchWebView::touchEvent):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):
(TestWindow::resizeEvent):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/QtSGUpdateQueue.cpp:

(WebKit::QtSGUpdateQueue::QtSGUpdateQueue):

  • UIProcess/qt/QtSGUpdateQueue.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::engine):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDataLocation):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h:

(WebKit::WebPopupMenuProxyQtDesktop::create):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::setDiskCache):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

05:37 Changeset [98720] by aroben@apple.com

Mac build fix after r98711

  • WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h private so WebKit can

find it.

05:28 Changeset [98719] by jocelyn.turcotte@nokia.com

[Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=71106

Reviewed by Simon Hausmann.

Holding Ctrl allows multiple touch points to be held on the screen using
mouse buttons. It would previously only prevent TouchReleased to be sent
and would require another MouseButtonRelease to be sent without holding Ctrl.

This patch makes sure that all held touch points are released when Ctrl
is released if MouseButtonRelease was received.
It also removes the touch QEvent::Type logic since it's currently handled
by QtGui by observing the modified touch points.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:
05:20 Changeset [98718] by kenneth@webkit.org

[Qt] MiniBrowser needs a -window-size option
https://bugs.webkit.org/show_bug.cgi?id=70999

Reviewed by Simon Hausmann.

Add an -window-size option useful for testing the viewport handling.
Also clean up the option handling.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setRequestedWindowSize):
(WindowOptions::requestedWindowSize):

  • MiniBrowser/qt/utils.cpp:

(takeOptionValue):

  • MiniBrowser/qt/utils.h:
05:18 Changeset [98717] by kenneth@webkit.org

[Qt] Make the kinetic engine use the same curve and constants as on the N9
https://bugs.webkit.org/show_bug.cgi?id=71102

Reviewed by Simon Hausmann.

Now that we are using the QScroller for kinetic scrolling and page
interaction, we need to make sure it uses the same curve (exponential)
and the same values as the MeeGo Touch physics engine used on the N9.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):

04:47 Changeset [98716] by antti@apple.com

[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
https://bugs.webkit.org/show_bug.cgi?id=71019

Source/WebCore:

Reviewed by Andreas Kling.

These properties need to be marked inherited too.

Note that the new test case doesn't fail even without the patch. If I understand correctly
the image test in the title is pretty much the only way to see this. However the
new test improves code coverage and protects against future regressions.

Test: fast/css/inherited-properties-rare-text.html

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/inherited-properties-rare-text-expected.txt: Added.
  • fast/css/inherited-properties-rare-text.html: Added.
02:52 Changeset [98715] by abarth@webkit.org

Remove getExceptionCodeDescription()
https://bugs.webkit.org/show_bug.cgi?id=71103

Reviewed by Eric Seidel.

Source/WebCore:

This function serves no purpose.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCode.cpp:
  • dom/ExceptionCode.h:

Source/WebKit/chromium:

Migrate to new API.

  • src/StorageInfoChromium.cpp:
  • src/WebStorageQuotaCallbacksImpl.cpp:

(WebKit::WebStorageQuotaCallbacksImpl::didFail):

02:43 Changeset [98714] by apavlov@chromium.org

Web Inspector: CSS background-image applied inline shows a warning, but still works.
https://bugs.webkit.org/show_bug.cgi?id=70325

Reviewed by Antti Koivisto.

Source/WebCore:

This change eliminates the "non-parsed property" warning displayed next to any
"background-image" property of an element's inline style.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeclaration):

  • css/CSSParser.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
02:36 Changeset [98713] by abarth@webkit.org

Attempt to fixenate Qt.

  • CodeGenerators.pri:
  • dom/make_event_factory.pl:

(toMacroStyle):

02:27 Changeset [98712] by hans@chromium.org

IndexedDB: Clean-up unused functions in WebIDBFactory
https://bugs.webkit.org/show_bug.cgi?id=71011

Reviewed by Tony Chang.

This is a clean-up after r97453. Since Chromium was updated,
these functions are no longer used.

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

02:11 Changeset [98711] by abarth@webkit.org

ExceptionCode.cpp shouldn't need to know about every feature that throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=70890

Reviewed by Eric Seidel.

.:

Add a code generation step.

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Generate the feature-specific parts of ExceptionCode.cpp from a ".in"
file. This is an incremental step towards inlining
getExceptionCodeDescription into its callers and replacing the switch
statements at those locations with autogenerated code.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/DOMCoreException.cpp:

(WebCore::DOMCoreException::initializeDescription):

  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • dom/ExceptionCodeDescription.in: Added.
  • dom/make_exception_code_description.pl: Added.

(defaultItemFactory):
(generateCode):
(generateHeader):
(generateImplementation):

02:09 Changeset [98710] by yurys@chromium.org

Web Inspector: CallStackSidebarPane should remove discarded Placards from RawSourceCode listeners list
https://bugs.webkit.org/show_bug.cgi?id=70996

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/callstack-placards-discarded.html

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):

  • inspector/front-end/Placard.js:

(WebInspector.Placard.prototype.toggleSelected):
(WebInspector.Placard.prototype.discard):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt: Added.
  • inspector/debugger/callstack-placards-discarded.html: Added.
01:48 Changeset [98709] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

  • DEPS:
01:31 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
01:16 Changeset [98708] by jochen@chromium.org

Add allowScriptFromSource callback to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=71013

Reviewed by Darin Fisher.

Source/WebCore:

Test: platform/chromium/permissionclient/script-permissions.html

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowScriptFromSource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

Source/WebKit/chromium:

  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowScriptFromSource):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScriptFromSource):

  • src/FrameLoaderClientImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setScriptsAllowed):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:

(WebPermissions::allowScriptFromSource):
(WebPermissions::setScriptsAllowed):
(WebPermissions::reset):

  • DumpRenderTree/chromium/WebPermissions.h:

LayoutTests:

  • platform/chromium/permissionclient/resources/script.js: Added.
  • platform/chromium/permissionclient/script-permissions-expected.txt: Added.
  • platform/chromium/permissionclient/script-permissions.html: Added.
01:12 Changeset [98707] by carlosgc@webkit.org

[GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=70814

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didStartProvisionalLoadForFrame): Update WebView URI to make sure
it's updated to provisional URL.
(didReceiveServerRedirectForProvisionalLoadForFrame): Update
WebView URI if there's a server redirection.
(didCommitLoadForFrame): Update WebView URI to make sure it
contains the final one.
(didSameDocumentNavigationForFrame): Update WebView URI when a
navigation action within the same document is performed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didSameDocumentNavigationForFrame callback.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Add URI property.
(webkitWebViewUpdateURI): Check whether current active URI has
changed to updated it and emit ::notify signal if it changes.
(webkit_web_view_load_uri): Call webkitWebViewUpdateURI() to make
sure the active URI is updated when load operation is started.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_get_uri): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Add

webkitWebViewUpdateURI().

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(provisionalLoadStartedCallback): Check provisional URL is the
requested URI.
(provisionalLoadReceivedServerRedirectCallback): Check provisional
URL after server redirection is the expected redirected URI.
(provisionalLoadFailedCallback): Check active URI.
(loadCommittedCallback): Ditto.
(loadFinishedCallback): Ditto.
(loadFailedCallback): Ditto
(LoadTrackingTest::LoadTrackingTest): Check active URI is NULL
before any loading operation has started.

  • UIProcess/API/gtk/tests/LoadTrackingTest.h:

(LoadTrackingTest::setRedirectURI): Set the redirect URI to check
it after a server redirection.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(testBackForwardListNavigation): Use WebViewTest methods for
navigation actions instead of using WebKitWebView API directly.
(testBackForwardListLimitAndCache): Ditto.

  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadingStatus): Ditto.
(testLoadingError): Ditto.
(testLoadAlternateContent): Ditto.
(testLoadCancelled): Ditto.
(testWebViewReload): Ditto.
(testLoadProgress): Ditto.
(testWebViewActiveURI): Add a test to check that notify signal is
emitted when active URI changes and it's correctly updated when
loader client signals are emitted.
(beforeAll): Add active-uri test.

  • UIProcess/API/gtk/tests/WebViewTest.cpp: Add custom load methods

wrapping the WebKitWebView ones, to initialize the active URI to
the requested one, so that it can be checked by the loader client
test.
(WebViewTest::loadURI):
(WebViewTest::loadAlternateHTML):
(WebViewTest::goBack):
(WebViewTest::goForward):
(WebViewTest::goToBackForwardListItem):

  • UIProcess/API/gtk/tests/WebViewTest.h:
00:59 Changeset [98706] by hausmann@webkit.org

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2011-10-21
Reviewed by Simon Hausmann.

Make QTouchWebView always render with accelerated compositing.
At first, the web content would only render after the rest of the scene has rendered. In a
future patch we'll enable rendering the web content via an FBO, which would cover all other
cases as well.

Right now this only works for QTouchWebView, and thus accelerated compositing is disabled
for desktop web-views. This required adding some settings enablers in Q
WebPreferencesPrivate. Those are not exposed to the public API, as they are an implementation
detail.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::initSceneGraphConnections):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPage):
(computeEffectiveOpacity):
(QTouchWebPagePrivate::paintToCurrentGLContext):
(QTouchWebPagePrivate::_q_onAfterSceneRender):
(QTouchWebPagePrivate::_q_onSceneGraphInitialized):
(QTouchWebPage::itemChange):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::get):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::renderNextFrame):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::QtDesktopWebPageProxy):

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::setViewNeedsDisplay):

  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::createDrawingAreaProxy):
(QtTouchWebPageProxy::renderToCurrentGLContext):
(QtTouchWebPageProxy::setVisibleContentRectAndScale):
(QtTouchWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/QtTouchWebPageProxy.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHost::supportsAcceleratedCompositing):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

00:39 Changeset [98705] by yutak@chromium.org

Unreviewed, update Chromium test expectation.

  • platform/chromium/test_expectations.txt:

Mark http/tests/websocket/tests/hybi/reserved-bits.html as flaky.

00:20 Changeset [98704] by abarth@webkit.org

Refactor make_event_factory.pl to use InFilesCompiler.pm
https://bugs.webkit.org/show_bug.cgi?id=71094

Reviewed by Eric Seidel.

This refactoring helps share code with
make_exception_code_descriptions.pl, which is coming in a future patch.
I have a dream of refactoring make_names.pl to use this module as well.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/scripts/action_makenames.py:
  • bindings/scripts/InFilesCompiler.pm: Added.

(itemHandler):
(parameterHandler):
(new):
(compile):
(license):

  • dom/make_event_factory.pl:

(defaultItemFactory):
(interfaceForEvent):
(generateCode):
(printFactoryFile):
(printMacroFile):
(printHeadersFile):

00:19 Changeset [98703] by apavlov@chromium.org

Merge 98489 - Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):

  • inspector/front-end/inspector.js:

(WebInspector._updateErrorAndWarningCounts):

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/8343053

00:18 Changeset [98702] by achicu@adobe.com

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
00:01 Changeset [98701] by abarth@webkit.org

Remove WinCairo from the set of core builders. WinCairo rarely builds
and is never green.

Rubber-stamped by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
Note: See TracTimeline for information about the timeline view.