Timeline


and

11/03/11:

21:53 Changeset [99263] by eric.carlson@apple.com

Unreviewed, forgot to skip a new test in r99261.

  • platform/qt/Skipped:
21:52 Changeset [99262] by rniwa@webkit.org

REGRESSION (r99076): Pasting into password fields is broken
https://bugs.webkit.org/show_bug.cgi?id=71483

Reviewed by Darin Adler.

The bug was caused by plainText serializing secured (instead of original) text.
Fixed the bug by adding new TextIterator behavior that serializes the original text
and using it in ReplacementFragment::ReplacementFragment.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::emitText):

  • editing/TextIterator.h:
21:18 Changeset [99261] by eric.carlson@apple.com

Add TrackEvent
https://bugs.webkit.org/show_bug.cgi?id=71178

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/track-event-constructor.html

  • CMakeLists.txt: Add new files for TrackEvent.
  • CodeGenerators.pri: Ditto.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • GNUmakefile.am: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/generic/EventConstructors.h: Ditto.
  • bindings/gobject/GNUmakefile.am: Ditto.
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add method to convert to a Track.

  • bindings/js/JSDictionary.h:
  • bindings/js/JSEventConstructors.cpp: Add new files for TrackEvent.
  • bindings/js/JSTrackCustom.cpp: Added.

(WebCore::toTrack): New, convert from a JSValue to a Track.
(WebCore::toJS): New, return a JS wrapper for a Track.

  • bindings/js/JSTrackCustom.h: Added.
  • bindings/js/JSTrackEventCustom.cpp: Added.

(WebCore::JSTrackEvent::track): New, returns a TextEvent's 'track' attribute.

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get): Returns RefPtr<TrackBase>.

  • bindings/v8/custom/V8EventConstructors.cpp: Add Track initializing constructor.
  • bindings/v8/custom/V8TrackEventCustom.cpp: Added.

(WebCore::V8TrackEvent::trackAccessorGetter): New, returns a TextEvent's 'track' attribute.

  • dom/EventFactory.in: Add TrackEvent.
  • dom/EventNames.h: Add 'addtrack' event.
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Call new base class constructor.

  • html/TextTrack.h: Now derive from BaseTrack for the day we implement VideoTrack and AudioTrack.
  • html/track/TrackBase.cpp: Added.

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::~TrackBase):

  • html/track/TrackBase.h: Added.

(WebCore::TrackBase::type): Return the track type.

  • html/track/TrackEvent.cpp: Added.

(WebCore::TrackEventInit::TrackEventInit):
(WebCore::TrackEvent::TrackEvent):
(WebCore::TrackEvent::~TrackEvent):
(WebCore::TrackEvent::interfaceName):

  • html/track/TrackEvent.h: Added.

(WebCore::TrackEvent::create):
(WebCore::TrackEvent::isTrackEvent):
(WebCore::TrackEvent::track):

  • html/track/TrackEvent.idl: Added.
  • page/DOMWindow.idl: Add TrackEvent.

LayoutTests:

  • fast/events/constructors/track-event-constructor-expected.txt: Added.
  • fast/events/constructors/track-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
20:44 Changeset [99260] by yutak@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Apply recent expectation changes.
19:21 Changeset [99259] by eae@chromium.org

Revert platform to ints

19:16 Changeset [99258] by arv@chromium.org

JS Test Harness: Remove successfullyParsed from more tests
https://bugs.webkit.org/show_bug.cgi?id=71533

Reviewed by Ojan Vafai.

  • LayoutTests/*: Remove successfullyParsed
18:55 Changeset [99257] by commit-queue@webkit.org

Optimize canvas fills / drawImage when covering entire canvas
https://bugs.webkit.org/show_bug.cgi?id=70789

Patch by Ben Wells <benwells@chromium.org> on 2011-11-03
Reviewed by Stephen White.

If we're filling a rect or drawing an image, and it covers the entire canvas, we don't
need to worry about clearing outside the area updated by the operation if we're in
a composite mode that requires this (such as source-in, copy, etc.). In this case we
can take the simple path through the code and save a clear (for copy) or a temporary
image buffer (for the other modes).

No new tests - optimization, behaviour is unchanged and covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::rectContainsCanvas):

  • html/canvas/CanvasRenderingContext2D.h:
18:32 Changeset [99256] by mhahnenberg@apple.com

De-virtualize JSObject::getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71306

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSObjectRef.cpp:

(JSObjectCopyPropertyNames):

(JSC::DebuggerActivation::getOwnPropertyNames):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getPropertyNames):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):

  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

  • runtime/Structure.cpp:

(JSC::Structure::getPropertyNamesFromStructure):

  • runtime/Structure.h:

Source/JavaScriptGlue:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • JSUtils.cpp:

(KJSValueToCFTypeInternal):

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCopyPropertyNames):

Source/WebCore:

No new tests.

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getPropertyNames):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getPropertyNames):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariantMap):

Source/WebKit/mac:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

18:18 Changeset [99255] by xji@chromium.org

Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
https://bugs.webkit.org/show_bug.cgi?id=71163

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add m_visualWordMovementEnabled page setting, trigger visual word movement
function (instead of logical one) when it is set as true.

right|leftWordPosition() are tested in editing/selection/move-by-word-visually*
by using --webkit-visual-word flag.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::visualWordMovementEnabled):

  • editing/FrameSelection.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setVisualWordMovementEnabled):
(WebCore::Settings::visualWordMovementEnabled):

Source/WebKit/chromium:

To minimize the risk to LTR users, we enable this feature first to chromium win
by command line flag. This and corresponding changset in chromium
(http://codereview.chromium.org/8400078/)
should be removed after this feature is enabled without command line flag.

The work flow is:

  1. (chromium) adds command line flag --enable-visual-word-movement, pass it to WebCore::Settings through WebPreferences.
  2. in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings, trigger visual word movement instead of logical one.


  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setVisualWordMovementEnabled):

  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.

(WebPreferences::applyTo):

17:56 Changeset [99254] by leviw@chromium.org

Correct usage of LayoutUnits and integers in Table rendering classes
https://bugs.webkit.org/show_bug.cgi?id=71500

Reviewed by Darin Adler.

Fixing the Table layout classes to operate on integers -- sub-pixel table layout breaks
the spec. Meanwhile correcting the Table rendering classes themselves to still use
LayoutUnits.

No new tests -- no change in behavior.

  • rendering/AutoTableLayout.cpp: Reverting to operating on integers.

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/AutoTableLayout.h: Reverting to operating on integers.
  • rendering/FixedTableLayout.cpp: Ditto.

(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):

  • rendering/RenderTable.h: Switching to LayoutUnits.

(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):

  • rendering/RenderTableCell.cpp: Switching to LayoutUnits.

(WebCore::RenderTableCell::updateLogicalWidth):
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::cellBaselinePosition):
(WebCore::RenderTableCell::scrollbarsChanged):

  • rendering/RenderTableCell.h: Switching to LayoutUnits
  • rendering/RenderTableSection.cpp: Ditto.

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):

17:31 Changeset [99253] by jamesr@google.com

[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
https://bugs.webkit.org/show_bug.cgi?id=71381

Reviewed by Kenneth Russell.

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::didSwapBuffers):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):

17:27 Changeset [99252] by commit-queue@webkit.org

[EFL] Added ewk_tile_memory_size_get function
https://bugs.webkit.org/show_bug.cgi?id=71213

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-03
Reviewed by Anders Carlsson.

Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup
the code.

  • ewk/ewk_tiled_model.cpp:

(ewk_tile_memory_size_get):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):

  • ewk/ewk_tiled_model.h:
17:17 Changeset [99251] by abarth@webkit.org

Add Stub.h and Stub.cpp to Source-level WTF project
https://bugs.webkit.org/show_bug.cgi?id=71497

Reviewed by Eric Seidel.

This patch adds some stub files and a skelton GYP build file as a
starting point for the new Source-level WTF project. Other build
systems and actual code will arrive in future patches.

  • Stub.cpp: Added.
  • Stub.h: Added.
  • WTF.gyp/WTF.gyp: Added.
  • WTF.gypi: Added.
17:13 Changeset [99250] by andersca@apple.com

Get rid of NetscapePlugin::m_clipRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71521

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
17:13 Changeset [99249] by andersca@apple.com

Use convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location() where possible
https://bugs.webkit.org/show_bug.cgi?id=71520

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

17:10 Changeset [99248] by tony@chromium.org

Remove an obsolete comment.

  • platform/chromium/test_expectations.txt:
16:55 Changeset [99247] by andersca@apple.com

Add NetscapePlugin::convertToRootView
https://bugs.webkit.org/show_bug.cgi?id=71519

Reviewed by Darin Adler.

Yet another step towards eliminating uses of m_frameRectInWindowCoordinates.

Also, use the "root view" terminology, since that's really what we mean here.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
Use convertToRootView to get the plug-in location and clip rect in root view coordinates.

(WebKit::NetscapePlugin::convertToRootView):
Apply the m_pluginToRootViewTransform.mapPoint transform.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add convertToRootView.

16:42 Changeset [99246] by dbates@webkit.org

CMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl

Rubber-stamped by Martin Robinson

  • CMakeLists.txt:
16:35 Changeset [99245] by dbates@webkit.org

CMake: Only generate from WebGL IDLs when building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=71516

Reviewed by Martin Robinson.

  • CMakeLists.txt:
16:26 Changeset [99244] by arv@chromium.org

Remove support for LegacyDefaultOptionalArguments
https://bugs.webkit.org/show_bug.cgi?id=71489

Reviewed by Darin Adler.

This removes support for LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise].
[RequiresAllArguments=Raise] is now the standard behavior so it would be a no op.

No new tests. Covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Check the "RequiresAllArguments" extended attribute and generate code

that returns undefined if there are missing arguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): Add generated argument count checks.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Ditto.
(WebCore::jsTestObjPrototypeFunctionIdbKey): Ditto.
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Ditto.
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): Ditto.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): Ditto.

  • bindings/scripts/test/TestCallback.idl: Remove LegacyDefaultOptionalArguments.
  • bindings/scripts/test/TestMediaQueryListListener.idl: Ditto.
  • bindings/scripts/test/TestObj.idl: Remove LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise]
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Remove LegacyDefaultOptionalArguments.

(WebCore::TestMediaQueryListListenerInternal::methodCallback): Add generated argument count checks.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::intMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::objMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::serializedValueCallback): Ditto.
(WebCore::TestObjInternal::idbKeyCallback): Ditto.
(WebCore::TestObjInternal::optionsObjectCallback): Ditto.
(WebCore::TestObjInternal::customArgsAndExceptionCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): Ditto.
(WebCore::TestObjInternal::methodWithCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::overloadedMethod1Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod2Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod3Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod4Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod5Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod6Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod7Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): Ditto.

16:17 Changeset [99243] by andersca@apple.com

Move plug-in size and backing store checks to PluginProxy::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=71508

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...

(WebKit::PluginProxy::updateBackingStore):
...here.

16:17 Changeset [99242] by andersca@apple.com

Get rid of PluginControllerProxy::m_frameRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71506

Reviewed by Darin Adler.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):
This no longer needs to take the frame rect in window coordinates.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:

Remove frameRectInWindowCoordinates from the GeometryDidChange message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Don't pass frameRectInWindowCoordinates when sending GeometryDidChange.

16:17 Changeset [99241] by andersca@apple.com

Get rid of Plugin::wantsWindowRelativeCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=71504

Reviewed by Darin Adler.

Since all Plugin subclasses now return false for wantsWindowRelativeCoordinates,
we can go ahead and remove it.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):

16:17 Changeset [99240] by andersca@apple.com

NetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
https://bugs.webkit.org/show_bug.cgi?id=71501

Reviewed by Darin Adler.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().

(WebKit::NetscapePlugin::platformPaint):
No need to translate back and forth between window and plug-in relative coordinates anymore.

16:04 Changeset [99239] by darin@apple.com

Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422

../JavaScriptCore:

  • wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.

../WebCore:

Reviewed by Darin Fisher.

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):

  • bridge/NP_jsobject.cpp:

(_NPN_CreateScriptObject):

  • dom/QualifiedName.cpp:

(WebCore::QNameComponentsTranslator::translate):

  • history/PageCache.cpp:

(WebCore::PageCache::add):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameAtIndex):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/mac/ContextMenuMac.mm:

(WebCore::ContextMenu::releasePlatformDescription):

  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::platformResource):
Use leakRef.

../WebKit/chromium:

  • public/WebPrivatePtr.h:

(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::operator=):

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::WebDOMEvent):

  • src/WebData.cpp:

(WebKit::WebData::assign):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):

  • src/WebDragData.cpp:

(WebKit::WebDragData::initialize):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):

  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::ensureMutable):

  • src/WebNodeCollection.cpp:

(WebKit::WebNodeCollection::WebNodeCollection):

  • src/WebNodeList.cpp:

(WebKit::WebNodeList::WebNodeList):

  • src/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::operator=):

  • src/WebRange.cpp:

(WebKit::WebRange::WebRange):
(WebKit::WebRange::operator=):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::WebSecurityOrigin):
(WebKit::WebSecurityOrigin::operator=):

  • src/WebThreadSafeData.cpp:

(WebKit::WebThreadSafeData::WebThreadSafeData):
Use leakRef.

../WebKit/efl:

Reviewed by Darin Fisher.

  • ewk/ewk_history.cpp:

(ewk_history_item_new): Use leakRef.

../WebKit/gtk:

Reviewed by Darin Fisher.

  • webkit/webkitwebdatasource.cpp:

(WebKit::kitNew):

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_new):
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_copy):
(WebKit::kit):

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_new_with_core_resource):
(webkit_web_resource_init_with_core_resource):
Use leakRef.

../WebKit/mac:

Reviewed by Darin Fisher.

  • History/WebBackForwardList.mm:

(-[WebBackForwardList initWithBackForwardList:]):

  • History/WebHistoryItem.mm:

(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):

  • WebCoreSupport/WebOpenPanelResultListener.mm:
  • WebView/WebDataSource.mm:

(-[WebDataSource _initWithDocumentLoader:]):

  • WebView/WebResource.mm:

(-[WebResourcePrivate initWithCoreResource:]):
Use leakRef.

../WebKit/win:

Reviewed by Darin Fisher.

  • WebCache.cpp:

(WebCache::statistics):

  • WebDatabaseManager.cpp:

(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):

  • WebHistoryItem.cpp:

(WebHistoryItem::redirectURLs):

  • WebKitClassFactory.cpp:

(leakRefFromCreateInstance):
(WebKitClassFactory::CreateInstance):

  • WebScriptWorld.cpp:

(WebScriptWorld::standardWorld):
Use leakRef.

../WebKit2:

Reviewed by Darin Fisher.

  • Platform/mac/ModuleMac.mm:

(WebKit::Module::load):

  • Shared/API/c/WKArray.cpp:

(WKArrayCreate):

  • Shared/API/c/WKData.cpp:

(WKDataCreate):

  • Shared/API/c/WKDictionary.cpp:

(WKDictionaryCopyKeys):

  • Shared/API/c/WKGeometry.cpp:

(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):

  • Shared/API/c/WKMutableArray.cpp:

(WKMutableArrayCreate):

  • Shared/API/c/WKMutableDictionary.cpp:

(WKMutableDictionaryCreate):

  • Shared/API/c/WKNumber.cpp:

(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedAPI):
(WebKit::toCopiedURLAPI):

  • Shared/API/c/cf/WKErrorCF.cpp:

(WKErrorCreateWithCFError):

  • Shared/API/c/cf/WKURLRequestCF.cpp:

(WKURLRequestCreateWithCFURLRequest):

  • Shared/API/c/cf/WKURLResponseCF.cpp:

(WKURLResponseCreateWithCFURLResponse):

  • Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCreateWithNSURLRequest):

  • Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCreateWithNSURLResponse):

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):

  • UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListCopyBackListWithLimit):
(WKBackForwardListCopyForwardListWithLimit):

  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):

  • UIProcess/API/C/WKCredential.cpp:

(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyChildFrames):

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate):

  • UIProcess/API/C/WKGrammarDetail.cpp:

(WKGrammarDetailCreate):

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateWithIdentifier):

  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):

  • UIProcess/win/WebUndoClient.cpp:

(WebKit::WebUndoClient::registerEditCommand):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyChildFrames):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyTrackedRepaintRects):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldCreateWorld):
Use leakRef.

15:40 Changeset [99238] by mhahnenberg@apple.com

De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::hasInstance):

  • API/JSValueRef.cpp:

(JSValueIsInstanceOfConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):

  • runtime/JSBoundFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::hasInstance):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

  • runtime/JSObject.h:
15:28 Changeset [99237] by dcheng@chromium.org

[chromium] Remove unused clipboard methods
https://bugs.webkit.org/show_bug.cgi?id=71512

Reviewed by Tony Chang.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/WebClipboard.h:

(WebKit::WebClipboard::getSequenceNumber):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::writeImage):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardGetSequenceNumber):
(WebCore::PlatformSupport::clipboardReadAvailableTypes):

13:49 Changeset [99236] by japhet@chromium.org

Revert 96912 - Always call setActive() in WebViewImpl::setFocus(),
not just when enabling focus.
https://bugs.webkit.org/show_bug.cgi?id=65220

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::loadFrame):
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp: Added.

TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/8378004

13:37 Changeset [99235] by commit-queue@webkit.org

Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

At some points we didn't have any guarantee that a favicon has been loaded, so now
it stops to wait for the IconChanged signal. It also had some file paths in wrong format,
making some files to not be resolved and comparing meaningless bitmaps.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::initTestCase):
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):

13:28 Changeset [99234] by annacc@chromium.org

Source/WebCore: Implement TextTrackCueList.
https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

Test: media/track/track-text-track-cue-list.html

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable):

Update TextTrack's TextTrackCueList (m_cues) when new cues are discovered.

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

Create an empty TextTrackCueList upon TextTrack creation.

(WebCore::TextTrack::cues):

Return this TextTrack's list of cues.

Implement TextTrackCueList functionality:

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::TextTrackCueList):
(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item):
(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::add):
(WebCore::TextTrackCueList::remove):
(WebCore::TextTrackCueList::contains):

  • html/TextTrackCueList.h:

(WebCore::TextTrackCueList::~TextTrackCueList):

LayoutTests: Tests for TextTrackCueList implementation.
https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

  • media/track/track-text-track-cue-list-expected.txt: Added.
  • media/track/track-text-track-cue-list.html: Added.
13:24 Changeset [99233] by eric@webkit.org

Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Reviewed by Adam Barth.

I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
free functions in factory.py. To remove these required fixing all callsites
to use MockHost, Host, or PortFactory where appropriate. After this change
we're only left with a handfull of places where we inappropraitely use a
real Executive, FileSystem or User object during unittesting.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
    • These PortFactory overrides were from an earlier edition of my previous patch in the end, I removed MockPortFactory so all tests ended up with this same real PortFactory() with a MockHost. This was simply redundent code.
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
    • Use MockHost to get a mocked-out PortFactory.
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
    • This code has no access to a Host object, so we just use a default PortFactory for now. This will still incorrectly create real Executive/FileSystem objects durring unittesting, which is wrong. :(
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
    • Use a MockHost to get a mocked PortFactory.
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
    • Use a MockHost to get a mocked PortFactory.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
    • ditto.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
    • ditto.
  • Scripts/webkitpy/layout_tests/port/init.py:
    • factory.get no longer exists. Yay!
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
    • Use a MockHost to get a mocked PortFactory. To do this efficiently, I created a helper function and combined all these (mostly redundant) tests into one test with several calls to the helper function.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
    • Pass MockUser and MockExecutive in these port testing subclasses.
    • I also removed a bunch of unecessary uses of mocktool. namespacing.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Awesome windows hacks should only happen on win32. Once we started using MockExecutives these 'svn help' commands started printing in other tests, which is how I found this bug.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • DryRunPort has no Host, so just use a PortFactory() directly. This will do the wrong thing if we're unittesting the DryRun port but it's no worse than the existing code.
  • Scripts/webkitpy/layout_tests/port/factory.py:
    • Remove the free functions.
    • Fix argument overriding to be able to override None.
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
    • Use a mocked-out PortFactory during testing.
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
    • Pass MockExecutive and MockUser to these manual Port instantiations.
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
    • No access to a Host object here, so just using PortFactory directly. This is wrong, but no more wrong than the existing code was.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
    • Use a MockHost to get a mocked out PortFactory.
  • Scripts/webkitpy/layout_tests/port/test.py:
    • Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
  • Scripts/webkitpy/layout_tests/port/win.py:
    • Don't run cmd /c ver from WinPort.init or it shows up in unittests which have logging MockExecutive now that we're actually passing MockExecutive to most Port instantiations during testing.
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
    • Pass our new "unittesting" bool to _detect_version when actually unittesting.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Host is the future.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
    • Use a MockHost to get a mocked out PortFactory. Once we have a mocked PortFactory we don't need to pass MockUser explicitly, it does that automatically for us.
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:
    • Use a MockHost to get a mocked out PortFactory.
  • Scripts/webkitpy/style/checkers/test_expectations.py:
    • We don't have access to a Host object, so using PortFactory() directly.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
    • Remove unused variable.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
    • Host isn't accessible here, so using PortFactory() directly, which although unfortunate is no worse than before.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
    • Testing is much easier when you don't need to hack global state...
  • Scripts/webkitpy/tool/commands/expectations.py:
    • Use the port_factory on the tool.
  • Scripts/webkitpy/tool/commands/rebaseline.py:
    • ditto.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
    • This unittest was wrong. It was trying to pass the tool object, but failing to pass the arguments in the right order. Fixing that made it use a MockFileSystem (like it had been trying to), which then required us to actually populate that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
    • Get the port_factory from the tool.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
    • Ditto.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
    • Use a MockHost to get a mocked out Port object.
13:21 Changeset [99232] by fpizlo@apple.com

JIT-specific code should be able to refer to register types even on JIT-disabled builds
https://bugs.webkit.org/show_bug.cgi?id=71498

Reviewed by Gavin Barraclough.

  • assembler/MacroAssembler.h:

(MacroAssembler::MacroAssembler):

13:20 Changeset [99231] by tony@chromium.org

Mark tests as slow in chromium.

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
are already marked as timing out, but maybe they will pass in release
if we give them enough time.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [99230] by andersca@apple.com

NetscapePlugin should use plug-in relative coordinates on Mac
https://bugs.webkit.org/show_bug.cgi?id=71486

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Don't translate the graphics context when the plug-in doesn't want window relative coordinates.
This also fixed a bug I introduced in my previous commit where we'd always pass the dirty rect in
plug-in coordinates even if the plug-in wants window relative coordinates.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):
Don't do the whole translate dance if the plug-in doesn't want window relative coordinates.

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false for PLATFORM_ARCHITECTURE(MAC).

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPaint):
Simplify code now that we know that the we're always given plug-in relative coordinates.

12:41 Changeset [99229] by commit-queue@webkit.org

IndexedDB result of deleting a record should be true or false
https://bugs.webkit.org/show_bug.cgi?id=60197

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-03
Reviewed by David Levin.

Source/WebCore:

IDBObjectStore.delete() was incorrectly firing an error if there
was no record to remove. Match the spec, and return true/false
as success values instead. Bring JSC binding implementation of
SerializedScriptValue more in line with V8 version for methods
called from IDB code.

Test: storage/indexeddb/mozilla/delete-result.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/js/SerializedScriptValue.h:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/v8/SerializedScriptValue.h:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

LayoutTests:

Add tests for IDBObjectStore.delete() - should succeed if
record exists or not, and return true/false as success value.

  • storage/indexeddb/mozilla/delete-result-expected.txt: Added.
  • storage/indexeddb/mozilla/delete-result.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
12:29 Changeset [99228] by abarth@webkit.org

Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Eric Seidel.

Source/WebCore:

There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox. Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox. Hixie says he'll add it to the spec once we implement
it, so here's our implementation. (See discussion in the W3C linked in
the bug for more details.)

This patch lands most of the infrastructure for this feature, but it
doesn't actually enable the feature. I'll enable it in a follow-up
patch.

Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
http/tests/security/popup-allowed-by-sandbox-when-allowed.html

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::forceSandboxFlags):

  • loader/FrameLoaderTypes.h:
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::sandboxFlags):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

LayoutTests:

Test that the allow-popups directive works as expected. Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.

These tests currently have expected.txt results that show failures, but
they will pass once this feature is enabled.

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.
12:25 Changeset [99227] by abarth@webkit.org

Add stubs for WTF and Platform
https://bugs.webkit.org/show_bug.cgi?id=71492

Reviewed by Eric Seidel.

Source/Platform:

This patch creates the Platform directory, which begins the process of
moving Platform out of WebCore.

Source/WTF:

This patch creates the WTF directory, which begins the process of
moving WTF out of JavaScriptCore.

12:15 Changeset [99226] by commit-queue@webkit.org

[EFL] DRT: Allow choosing which backing store to use.
https://bugs.webkit.org/show_bug.cgi?id=70532

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-03
Reviewed by Antonio Gomes.

This change makes it possible to change the backing store used by DRT
from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(shouldUseSingleBackingStore):
(chooseAndInitializeAppropriateSmartClass):
(drtViewAdd):

  • DumpRenderTree/efl/DumpRenderTreeView.h:
11:48 Changeset [99225] by jchaffraix@webkit.org

Unreviewed gardening after r99212.

  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:

Rebaselined the test on Chromium Windows.

  • platform/efl/Skipped:

I forgot to check the visual baseline on EFL. The EFL port does not seem to have the
repaint result (likely due to lack of support) thus it does not need a rebaseline.

11:42 Changeset [99224] by tony@chromium.org

Correct chromium expectations for setPrinting and single-line-must-not-be-split-into-two-pages.
https://bugs.webkit.org/show_bug.cgi?id=71080

  • platform/chromium-cg-mac-leopard/printing/setPrinting-expected.png: Removed.
  • platform/chromium-mac-leopard/printing/setPrinting-expected.txt: Removed.
  • platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:20 Changeset [99223] by mhahnenberg@apple.com

De-virtualize JSObject::className
https://bugs.webkit.org/show_bug.cgi?id=71428

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::className):

(JSC::DebuggerActivation::className):

  • debugger/DebuggerActivation.h:
  • jsc.cpp:

(GlobalObject::createStructure):

  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::className):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::className):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • testRegExp.cpp:

(GlobalObject::createStructure):

Source/JavaScriptGlue:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • JSUtils.cpp:

(KJSValueToCFTypeInternal):

Source/WebCore:

No new tests.

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::internalConstructorName):

  • bridge/testqtbindings.cpp:

(Global::className):

Source/WebKit/efl:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • ewk/ewk_js.cpp:

(ewk_js_npobject_to_object):

11:05 Changeset [99222] by jer.noble@apple.com

Add Clock class and platform-specific implementations.
https://bugs.webkit.org/show_bug.cgi?id=71341

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add WTF_USE_COREAUDIO macro for use by PlatformClockCA.

  • wtf/Platform.h:

Source/WebCore:

No new tests; these classes will be used and tested by the MediaController feature.

Adds a abstract Clock class and two concrete, platform-specific subclasses.

Clock provides a basic interface for starting, stopping, and querying a generic timeline.
PlatformClockCA implements this interface using a CoreAudio CAClock object, which uses
the default audio device's hardware clock as a timing source. PlatformClockPOSIX
implements this interface using gettimeofday() as its timing source.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Clock.cpp: Added.

(Clock::create): Creates a platform-specific clock.

  • platform/Clock.h: Added.

(WebCore::Clock::~Clock):
(WebCore::Clock::Clock):

  • platform/mac/PlatformClockCA.cpp: Added.

(PlatformClockCA::PlatformClockCA):
(PlatformClockCA::~PlatformClockCA):
(PlatformClockCA::setCurrentTime):
(PlatformClockCA::currentTime):
(PlatformClockCA::setPlayRate):
(PlatformClockCA::PlatformClockCA::playRate):
(PlatformClockCA::start):
(PlatformClockCA::stop):

  • platform/mac/PlatformClockCA.h: Added.

(WebCore::PlatformClockCA::isRunning):

  • platform/posix/PlatformClockPOSIX.cpp: Added.

(timevalToFloat):
(timevalDelta):
(PlatformClockPOSIX::PlatformClockPOSIX):
(PlatformClockPOSIX::setCurrentTime):
(PlatformClockPOSIX::currentTime):
(PlatformClockPOSIX::setPlayRate):
(PlatformClockPOSIX::PlatformClockPOSIX::playRate):
(PlatformClockPOSIX::start):
(PlatformClockPOSIX::stop):
(PlatformClockPOSIX::now):

  • platform/posix/PlatformClockPOSIX.h: Added.

(WebCore::PlatformClockPOSIX::isRunning):

10:57 Changeset [99221] by caseq@chromium.org

Unreviewed. Brought back TIMEOUT for show-hide-table-rows.html

  • platform/chromium/test_expectations.txt:
10:53 Changeset [99220] by arv@chromium.org

JS Test Harness: Remove more link tags
https://bugs.webkit.org/show_bug.cgi?id=71339

Reviewed by Ojan Vafai.

Tools:

  • Scripts/make-new-script-test:

(writeTestFile): Don't output <link>

LayoutTests:

  • LayoutTest/*: Remove links to js-test-style.css.
10:50 Changeset [99219] by leviw@chromium.org

Merge 99109 - Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Source/WebCore:

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

  • rendering/svg/RenderSVGResourceContainer.h:

LayoutTests:

Fixes a stack overflow when SVG resources reference one another and share ids.

  • svg/custom/resource-invalidation-crash-expected.png: Added.
  • svg/custom/resource-invalidation-crash-expected.txt: Added.
  • svg/custom/resource-invalidation-crash.svg: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8446005

10:46 Changeset [99218] by commit-queue@webkit.org

IndexedDB: Object stores not persisting between sessions
https://bugs.webkit.org/show_bug.cgi?id=71313

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-03
Reviewed by Tony Chang.

Logic flaw introduced with r98806 skipped the loading of object stores
during subsequent sessions.

  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):

10:42 Changeset [99217] by pfeldman@chromium.org

Web Inspector: fix heap profiler rendering and resize.
https://bugs.webkit.org/show_bug.cgi?id=71484

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):

10:41 Changeset [99216] by commit-queue@webkit.org

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-11-03
Reviewed by Martin Robinson.

[GTK] arguments passed to build-jsc are not taken into account
https://bugs.webkit.org/show_bug.cgi?id=58333

  • Scripts/build-jsc:
10:37 Changeset [99215] by ossy@webkit.org

[Qt] Unreviewed evening gardening.

  • platform/qt/test_expectations.txt: Remove a useless entry.
10:34 Changeset [99214] by ossy@webkit.org

[Qt] Unreviewed evening gardening. Add platform specific expected results after r98989.

  • platform/qt/svg/filters/invalidate-on-child-layout-expected.png: Added.
  • platform/qt/svg/filters/invalidate-on-child-layout-expected.txt: Added.
10:26 Changeset [99213] by ossy@webkit.org

[Qt] Unreviewed evening gardening. Skip failing tests.

  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
10:20 Changeset [99212] by jchaffraix@webkit.org

Stop abusing RenderTableSection::needsRecalcCells logic
https://bugs.webkit.org/show_bug.cgi?id=71420

Reviewed by Darin Adler.

Source/WebCore:

Change covered by existing tests like fast/repaint/table-extra-bottom-grow.html
and fast/table/row-height-recalc* (among others).

Cell recalculation is very expensive and should only be called when the section's structure
changed in a way that requires a safe update to its structure (like removing a row as our
column split may not be appropriate anymore).

The current code would abuse cell recalculation to actually reset the logical height on the
RowStruct. This change makes it do the right thing.

  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.h:

Removed styleWillChange override as it was unneeded.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
Move the code from styleWillChange to styleDidChange.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::rowLogicalHeightChanged):
This function just reset the height on the |RowStruct| which is the
only part of recalcCells that we would need.

(WebCore::RenderTableSection::rowIndexForRenderer):
Added this function to find out which index a column has (strangely
RenderTableRow does not have this information).

  • rendering/RenderTableSection.h: Added the 2 previous functions.

LayoutTests:

  • platform/chromium-linux/fast/repaint/table-extra-bottom-grow-expected.png:

Update this test as this is a progression: we are not over-repainting the table
anymore.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/test_expectations.txt:

Skipped the test here as it needs a rebaseline.

10:16 Changeset [99211] by haraken@chromium.org

Unreviewed rebaselining. Unskipped progress-event-constructor.html in Qt-Arm
since the failure is fixed in r99161.

  • platform/qt-arm/Skipped:
10:13 Changeset [99210] by andersca@apple.com

PluginControllerProxy's dirty rect should be in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71481

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Convert the dirty rect to window coordinates before passing it to the plug-in.

(WebKit::PluginControllerProxy::invalidate):
No need to convert the dirty rect to window coordinates.

(WebKit::PluginControllerProxy::paintEntirePlugin):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.isEmpty.

10:10 Changeset [99209] by lforschler@apple.com

New tag.

10:06 Changeset [99208] by fsamuel@chromium.org

[Chromium] Refactor WebFrameImpl::createFrameView() to use Frame:createView
https://bugs.webkit.org/show_bug.cgi?id=70507

Reviewed by Darin Fisher.

No change in functionality except for fixed layout mode. Fixed layout mode has
not been fully upstreamed yet, so no new tests yet:
https://bugs.webkit.org/show_bug.cgi?id=70562 will address this.

This patch also fixes https://bugs.webkit.org/show_bug.cgi?id=70555
It was decided that fixed layout mode might need to be disabled for some content,
and so this change enables the embedder to decide whether to enable fixed layout on
navigation.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

10:06 Changeset [99207] by carlosgc@webkit.org

[GTK] Show url of history items in a status bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71474

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowSetStatusText): Set status text and show/hide the
status label.
(resetStatusText): Reset status text when history menu is hidden.
(browserWindowHistoryItemSelected): Show url of currently selected
history item.
(browserWindowCreateBackForwardMenu): Connect to hide signal of
menu to reset the status text.
(browserWindowConstructed): Use GtkOverlay if available to show
status text.

10:01 Changeset [99206] by carlosgc@webkit.org

[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71466

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowHistoryItemActivated): Go to selected back formard
list item using webkit_web_view_go_to_back_forward_list_item()
(browserWindowCreateBackForwardMenu): Create a GtkMenu for the
given GList of WebKitBackForwardListItems.
(browserWindowUpdateNavigationActions): Enable/disable back and
forward buttons depending on whether it's possible to go
back/forward. Create a menu for back and forward toolbar buttons.
(backForwadlistChanged): Call browserWindowUpdateNavigationActions().
(browserWindowConstructed): Connect to WebKitBackForwardList
changed signal.

09:54 Changeset [99205] by andersca@apple.com

Use the right function to determine whether NPWindow coordinates should be window relative
https://bugs.webkit.org/show_bug.cgi?id=71480

Reviewed by Adam Roben.

We want to use wantsWindowRelativeNPWindowCoordinates here, and not wantsWindowRelativeCoordinates
which is a temporary function that will be removed (and that returns the wrong value!)

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

09:31 Changeset [99204] by commit-queue@webkit.org

CSSRuleList: Move rule orphaning from deleteRule() out to callers.
https://bugs.webkit.org/show_bug.cgi?id=71470

Patch by Andreas Kling <kling@webkit.org> on 2011-11-03
Reviewed by Antti Koivisto.

Rule parenting is the responsibility of the owner rule (the rule containing
the rule list), so move parent clearing out of CSSRuleList::deleteRule() and
into the (two) call sites.

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::deleteRule):

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::deleteRule):

09:28 Changeset [99203] by pfeldman@chromium.org

Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):
(WebInspector.Script.prototype.isInlineScript):

09:16 Changeset [99202] by hausmann@webkit.org

[Qt] Remove Maemo specific code paths
https://bugs.webkit.org/show_bug.cgi?id=71476

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/WebKit.pri:

Source/WebCore:

  • WebCore.pri:
  • features.pri:
  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

  • plugins/PluginView.cpp:

(WebCore::PluginView::setValue):

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformGetValueStatic):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

  • Api/qwebview.cpp:

(QWebView::QWebView):

  • QtWebKit.pro:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createSelectPopup):

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin):

  • WebCoreSupport/QtMaemoWebPopup.cpp: Removed.
  • WebCoreSupport/QtMaemoWebPopup.h: Removed.
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::focusInputTypes):

  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::focusInputTypes):

Tools:

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::~LauncherWindow):
(LauncherWindow::init):
(LauncherWindow::showLinkHover):
(LauncherWindow::selectElements):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/locationedit.cpp:
  • QtTestBrowser/locationedit.h:
09:13 Changeset [99201] by carlosgc@webkit.org

[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71461

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(resetEntryProgress): Reset the entry progress after a while when
load has been completed.
(webViewLoadProgressChanged): Update location entry progress.
(browserWindowConstructed): Connect to WebView
notify::estimated-load-progress signal.

09:10 Changeset [99200] by carlosgc@webkit.org

[GTK] Remove WebKit2 C API from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71459

Reviewed by Martin Robinson.

Use the GTK+ API instead to add minimum functionality. The other
features will be ported to GTK+ API in following patches.

  • MiniBrowser/gtk/BrowserWindow.c:

(activateUriEntryCallback): Use webkit_web_view_load_uri().
(goBackCallback): Use webkit_web_view_go_back().
(goForwardCallback): Use webkit_web_view_go_forward().
(webViewURIChanged): Update location entry with current uri using
webkit_web_view_get_uri().
(browserWindowFinalize):
(browserWindowGetProperty):
(browserWindowSetProperty):
(browser_window_init):
(browserWindowConstructed): Connect to notify::uri signal of
WebView to be notified when the URI changes.
(browser_window_class_init):
(browser_window_new): Use WebKitWebView.
(browser_window_get_view): Use WebKitWebView

  • MiniBrowser/gtk/BrowserWindow.h:
  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
  • MiniBrowser/gtk/main.c:

(loadURI): Use webkit_web_view_new().
(main):

09:07 Changeset [99199] by hausmann@webkit.org

Unreviewed build fix after r99195.

The right name is restrictMinimumScaleFactorToViewportSize.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

09:04 Changeset [99198] by carlosgc@webkit.org

[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=71457

Reviewed by Martin Robinson.

  • GNUmakefile.am:
08:40 Changeset [99197] by kenneth@webkit.org

[Qt] Bounce back limits are wrong in some situations
https://bugs.webkit.org/show_bug.cgi?id=71471

Reviewed by Simon Hausmann.

The valid position points were in viewport coordinates, but we were
requiring valid position points in content coordinates.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):

08:31 Changeset [99196] by hausmann@webkit.org

Patch by Jesus Sanchez-Palencia <jesus@webkit.org> on 2011-11-03
Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebKit should have documentation clarifying its mobile features usage
https://bugs.webkit.org/show_bug.cgi?id=41465

Add "QtWebKit Goes Mobile" documentation

  • docs/qtwebkit-goes-mobile.qdoc: Added.
  • docs/qtwebkit.qdoc: Linked to qtwebkit-goes-mobile documentation
  • docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Added.
08:22 Changeset [99195] by fsamuel@chromium.org

Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Operations in computeViewportAttributes that are not a part of the spec:

http://www.w3.org/TR/2011/WD-css-device-adapt-20110915/#constraining-viewport-property-values

were moved into the functions restrictMinimumScaleFactorToViewportSize and
restrictScaleFactorToInitialScaleIfNotUserScalable.

  • WebCore.exp.in:
  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore::restrictMinimumScaleFactorToViewportSize):
(WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable):

  • dom/ViewportArguments.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):

  • webkit/webkitviewportattributes.cpp:

(webkitViewportAttributesRecompute):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewportConfigurationAsText):

08:21 Changeset [99194] by abecsi@webkit.org

[Qt][WK2] Fix the signal signature of the loadFailed API test.

Rubber-stamped by Simon Hausmann.

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

08:05 Changeset [99193] by hausmann@webkit.org

[Qt] Unable to start MiniBrowser after run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71469

Reviewed by Csaba Osztrogonác.

  • Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped

from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
line arguments.

07:49 Changeset [99192] by jocelyn.turcotte@nokia.com

[Qt] Fix an assertion under WebPage::setViewportSize.
https://bugs.webkit.org/show_bug.cgi?id=71473

Reviewed by Simon Hausmann.

The web view can have an empty size and it causes the assert in computeViewportAttributes.
Don't notify the web page of such a size change in this case.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportSize):

07:44 Changeset [99191] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
07:42 Changeset [99190] by andreas.kling@nokia.com

Unreviewed build fix, sigh.

  • css/CSSFontFaceRule.h:
  • css/CSSMutableStyleDeclaration.h:
07:39 Changeset [99189] by philn@webkit.org

Unreviewed, skipping 3 new svg tests presenting pixel differences
between the 32-bits and 64-bits bots.

  • platform/gtk/Skipped:
07:32 Changeset [99188] by commit-queue@webkit.org

[WK2] State variable name refactor in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=71467

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Andreas Kling.

Renaming m_inDecidePolicyForMIMEType to m_inDecidePolicyForResponse after
https://bugs.webkit.org/show_bug.cgi?id=55827 .

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):

  • UIProcess/WebPageProxy.h:
07:27 Changeset [99187] by andreas.kling@nokia.com

Unreviewed build fix, out-of-line StyleSheet::parentStyleSheet()
again since there's a cycle in the includes between CSSRule/StyleSheet.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::parentStyleSheet):

  • css/StyleSheet.h:
07:12 Changeset [99186] by andreas.kling@nokia.com

Unreviewed build fix after r99185, removing forward-declaration
of CSSRule since CSSRule.h is already included.

  • css/StyleSheet.h:
07:01 Changeset [99185] by andreas.kling@nokia.com

CSSOM: Inline some trivial methods.
https://bugs.webkit.org/show_bug.cgi?id=71468

Reviewed by Antti Koivisto.

  • css/CSSFontFaceRule.cpp:
  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::setDeclaration):

  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::setDeclaration):

  • css/CSSStyleSheet.cpp:
  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::ownerRule):

  • css/StyleSheet.cpp:
  • css/StyleSheet.h:

(WebCore::StyleSheet::parentStyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:
  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::name):
(WebCore::WebKitCSSKeyframesRule::length):

06:53 Changeset [99184] by andreas.kling@nokia.com

Devirtualize MediaList.
https://bugs.webkit.org/show_bug.cgi?id=71464

Reviewed by Antti Koivisto.

  • css/MediaList.h: Make the destructor non-virtual.
06:48 Changeset [99183] by zherczeg@webkit.org

Optimizing arithmetic composite filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=65522

Reviewed by Dirk Schulze.

This patch continues the work of Felician Marton.

The arithmetic operation of feComposite SVG filter can be greatly enhanced
by the ARM-NEON instruction set since we are able to calculate the pixel data
for all four RGBA channels at the same time.

It won't affect the general behavior and existing tests will cover the changes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Added.
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Added.

(WebCore::FEComposite::platformArithmeticNeon):

06:40 Changeset [99182] by hausmann@webkit.org

[Qt] Add pageScaleFactor to the serialized history item
https://bugs.webkit.org/show_bug.cgi?id=71463

Reviewed by Tor Arne Vestbø.

r75758 added the pageScaleFactor member, which we need to
serialize.

  • history/qt/HistoryItemQt.cpp:

(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):

06:33 Changeset [99181] by mikelawther@chromium.org

Use createPrimitiveNumericValue function
https://bugs.webkit.org/show_bug.cgi?id=71432

Reviewed by Andreas Kling.

No new tests - no change in functionality.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):

06:28 Changeset [99180] by philn@webkit.org

Unreviewed, skip
http/tests/security/xssAuditor/script-tag-with-callbacks.html on
GTK, relying on an unimplemented feature.

  • platform/gtk/Skipped:
06:26 Changeset [99179] by commit-queue@webkit.org

[GTK][WEBKIT2] Add support for title property in WebKitWebView.
https://bugs.webkit.org/show_bug.cgi?id=68074

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.

Support for 'title' property is added in WebKitWebView.
Functions to get the value of this property is provided.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didReceiveTitleForFrame): LoaderClient titleRecieve callback.
(webkitWebLoaderClientAttachLoaderClientToPage): Register didReceiveTitleForFrame callback.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewGetProperty): 'title' property get function.
(webkit_web_view_class_init): Register new property.
(webkitWebViewSetTitle): Notify WebKitWebView about title receive.
(webkit_web_view_get_title): API to get main frame title.

  • UIProcess/API/gtk/WebKitWebView.h: webkit_web_view_get_title API expose.
  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Added private API.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testWebViewTitle): Test webkit_web_view_get_title API.
(beforeAll): Add testWebViewTitle test.

06:05 Changeset [99178] by commit-queue@webkit.org

[Qt][WK2] Download support and API in UIProcess
https://bugs.webkit.org/show_bug.cgi?id=68962

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

Source/WebKit/qt:

Registering new qml type QWebDownloadItem.

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We implement our WkContextDownloadClient and the needed callbacks.
We also add APIs by exposing QWebDownloadItem. Objects from this type
have their ownership handled by QDesktopWebView and will be created or
destroyed as needed. Classes implementing ViewInterface (QDesktopWebViewPrivate
and TouchViewInterface) will receive a signal (downloadRequested) with a pointer
to the recently created QWebDownloadItem. With that they can connect the proper
signals and slots, set the download destination path and then call start().
Objects of this type will provide the progress of a download, a slot to cancel it,
and signals for getting finished or failure status.
QWebDownloadItem was also exposed in QML.
Qt needed an asynchronous way for UIProcess to return a destination path to WebProcess,
therefore the startTransfer API was added to WebKit2's Download handlers.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Add encoding and decoding of suggestedFilename for ResourceResponse.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qbasewebview.h: Add signal downloadRequested.
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::downloadRequested):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qwebdownloaditem.cpp: Added.

(QWebDownloadItemPrivate::QWebDownloadItemPrivate):
(QWebDownloadItem::QWebDownloadItem):
(QWebDownloadItem::~QWebDownloadItem):
(QWebDownloadItem::url):
(QWebDownloadItem::destinationPath):
(QWebDownloadItem::setDestinationPath):
(QWebDownloadItem::suggestedFilename):
(QWebDownloadItem::mimeType):
(QWebDownloadItem::expectedContentLength):
(QWebDownloadItem::totalBytesReceived):
(QWebDownloadItem::cancel):
(QWebDownloadItem::start):

  • UIProcess/API/qt/qwebdownloaditem.h: Added.
  • UIProcess/API/qt/qwebdownloaditem_p.h: Added.

(QWebDownloadItemPrivate::didReceiveResponse):

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/download.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/download.zip: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::startTransfer): Qt only function added.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/PageClient.h: Added Qt specific function to call handleDownloadRequest from QtWebPageProxy.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download):
Using WebPageProxy::handleDownloadRequest to bootstrap a download through PageClient.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Using handleDownloadRequest() to bootstrap a download through PageClient.
(WebKit::WebPageProxy::handleDownloadRequest): Calls PageClient::handleDownloadRequest().

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtDownloadManager.cpp: Added.

(WebKit::toQtDownloadManager):
(WebKit::qt_wk_didReceiveResponse):
(WebKit::qt_wk_didCreateDestination):
(WebKit::qt_wk_didFinishDownload):
(WebKit::qt_wk_didFailDownload):
(WebKit::qt_wk_didReceiveDataForDownload):
(QtDownloadManager::downloadReceivedResponse): Will reach QtWebPageProxy::didReceiveDownloadResponse.
(QtDownloadManager::downloadCreatedDestination):
(QtDownloadManager::downloadFinished):
(QtDownloadManager::downloadFailed):
(QtDownloadManager::downloadDataReceived):

  • UIProcess/qt/QtDownloadManager.h: Added.

Bootstrap our WKContextDownloadClient and set its callbacks.
This entity will also handle all downloads and keep a map of them.
It will be kept alive together with the WebContext as a static member
of QtWebPageProxy, so we can keep it across several WebPages and, therefore,
WebViews.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::handleDownloadRequest):
(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:

From now on it will keep a static QtDownloadManager to live together
with the default WebContext. It implements PageClient::handleDownloadRequest.
QtWebPageProxy::didReceiveDownloadResponse will emit the view's signal downloadRequested.

  • UIProcess/qt/QtTouchViewInterface.h:

(WebKit::QtTouchViewInterface::downloadRequested):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/qweberror.cpp:

(QWebError::description):

  • UIProcess/qt/qweberror.h:

(QWebError::errorCodeAsDownloadError):
Add Download error handling to QWebError and a new API
to retrieve the error description from the original ResourceError.
Also, it now has QWebDownloadItem::DownloadError errorCodeAsDownloadError()
that returns the error code as a DownloadError.

  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startTransfer):

  • WebProcess/Downloads/DownloadManager.h:

Adding Qt specific startTransfer function.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::startTransfer):

  • WebProcess/Downloads/qt/QtFileDownloader.cpp:

(WebKit::QtFileDownloader::init): start() was renamed to init().
(WebKit::QtFileDownloader::determineFilename):
Calling onReadyRead() here was unnecessary and it was triggering the overall
download process even before DownloadManager finished startDownload(). This
was leading to a DownloadManager with an empty list of downloads.
(WebKit::QtFileDownloader::startTransfer): decidedDestination() became startTransfer().
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::handleDownloadResponse):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::cancel):

  • WebProcess/Downloads/qt/QtFileDownloader.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startTransfer):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Adding Qt specific message StartTransfer and handling function.

06:04 Changeset [99177] by pfeldman@chromium.org

2011-11-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing win build. step2.

05:52 Changeset [99176] by commit-queue@webkit.org

Add webkit_web_view_load_html and webkit_web_view_load_plain_text APIs.
https://bugs.webkit.org/show_bug.cgi?id=69249

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.

This patch adds support for 2 more load APIs, namely
webkit_web_view_load_html and webkit_web_view_load_plain_text.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_html): New API to load html string.
(webkit_web_view_load_plain_text): New API to load plain text.

  • UIProcess/API/gtk/WebKitWebView.h: Public API addition.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadHtml): Test webkit_web_view_load_html API.
(testLoadPlainText): Test webkit_web_view_load_plain_text API.
(beforeAll): Add new tests.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadHtml): Test webkit_web_view_load_html API.
(WebViewTest::loadPlainText): Test webkit_web_view_load_plain_text API.

  • UIProcess/API/gtk/tests/WebViewTest.h:
05:49 Changeset [99175] by pfeldman@chromium.org

2011-11-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: win build fix. Assign autoDPI at all cases (breakage introduced in r99173).

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
05:33 Changeset [99174] by pfeldman@chromium.org

2011-11-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix windows build, step1

05:21 Changeset [99173] by kenneth@webkit.org

Differentiate implicit viewport from that of the meta tag
https://bugs.webkit.org/show_bug.cgi?id=71453

Reviewed by Simon Hausmann.

This is needed because of DPI adjustment taking place with the meta
tag. This is to be avoided when no viewport meta tag is present.

  • dom/Document.cpp:

(WebCore::Document::processViewport):

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):

05:16 Changeset [99172] by caseq@chromium.org

Unreviewed. Another batch of expectations clean-up.

  • platform/chromium/test_expectations.txt:
05:14 Changeset [99171] by andreas.kling@nokia.com

Devirtualize CSSRule.
https://bugs.webkit.org/show_bug.cgi?id=71382

Reviewed by Antti Koivisto.

Remove the virtual destructor from CSSRule, and reimplement RefCounted's deref()
to invoke operator delete on the appropriate subclass type.

This removes the CSSRule vtable and shrinks each instance by one CPU word.

  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.h:
  • css/CSSMediaRule.h:
  • css/CSSPageRule.h:
  • css/CSSRegionStyleRule.h:
  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::deref):
(WebCore::CSSRule::~CSSRule):

  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.h:

Devirtualize!

  • css/CSSRule.cpp:

(WebCore::CSSRule::destroy):

Added, invokes operator delete on the right subclass type.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::requestStyleSheet):

  • css/CSSImportRule.h:

(WebCore::CSSImportRule::ImportedStyleSheetClient::ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::~ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::setCSSStyleSheet):

Break out the inheritance from CachedStyleSheetClient into a member variable
that simply redirects the setCSSStyleSheet() callback to the CSSImportRule.

05:09 Changeset [99170] by hausmann@webkit.org

[Qt][WK2] Failing assertion with desktop webview when touch mocking in MinBrowser
https://bugs.webkit.org/show_bug.cgi?id=71452

Reviewed by Andreas Kling.

Don't re-implement touchEvent(), we don't intend to support touch events as we
receive them from the QQuickCanvas at this point.

  • UIProcess/API/qt/qdesktopwebview.cpp:
  • UIProcess/API/qt/qdesktopwebview.h:
05:03 Changeset [99169] by hans@chromium.org

IndexedDB: Recycle cursor objects when calling continue()
https://bugs.webkit.org/show_bug.cgi?id=71115

Reviewed by Darin Fisher.

Source/WebCore:

The IndexedDB spec says that cursors should be recycled when calling
continue(). Let the IDBRequest keep track of which cursor to return
upon success, and have the cursor use a new callback:
onSuccessWithContinuation() to signal that the continue was successful.

When we start using the new callback, the
storage/indexeddb/cursor-inconsistency.html layout test will start
passing.

  • storage/IDBCallbacks.h:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunctionInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):

  • storage/IDBRequest.h:

Source/WebKit/chromium:

Add the new onSuccessWithContinuation() callback to IDB wrappers.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccessWithContinuation):

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccessWithContinuation):

  • src/IDBCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccessWithContinuation):

  • src/WebIDBCallbacksImpl.h:
05:03 Changeset [99168] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip failing tests.
05:02 Changeset [99167] by pfeldman@chromium.org

Web Inspector: preserve script location for inline handlers.
https://bugs.webkit.org/show_bug.cgi?id=71367

Source/JavaScriptCore:

Makes SourceCode factories receive TextPosition instead of the line number;
Stores consistent position values in SourceCode and SourceProvider;

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):

  • parser/SourceCode.h:

(JSC::makeSource):

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::startPosition):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionConstructor.h:

Source/WebCore:

Makes eventHandler report position, not line number;

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::StringSourceProvider):
(WebCore::makeSource):

LayoutTests:

Linkifier test reimplemented for simplisity.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • inspector/debugger/debugger-scripts-expected.txt:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier-expected.txt:
  • inspector/debugger/linkifier.html:
  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-scripts-expected.txt.
04:52 Changeset [99166] by caseq@chromium.org

Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
04:20 Changeset [99165] by hausmann@webkit.org

[Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build.
https://bugs.webkit.org/show_bug.cgi?id=71196

Reviewed by Kenneth Rohde Christiansen.

Ensure AC is turned off for the desktop view before we launch the process.
This avoids "accidential" enterAc/exitAc calls that cause failing assertions
because we don't really support AC in this setup.

The touch side works the same way, i.e. enable the preference before calling
init().

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::QtDesktopWebPageProxy):

04:09 Changeset [99164] by apavlov@chromium.org

Web Inspector: [Styles] Do not check isEditingAnyField in StylesSidebarPane._createNewRule
https://bugs.webkit.org/show_bug.cgi?id=71217

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.set _createNewRule):

03:37 Changeset [99163] by kbalazs@webkit.org

[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

Source/WebCore:

Disable X11 plugins with Qt5.

  • features.pri:

Source/WebKit2:

Disable X11 plugins.

  • config.h:

LayoutTests:

Disable plugin tests with Qt5.

  • platform/qt-5.0/Skipped:
03:33 Changeset [99162] by commit-queue@webkit.org

Unreviewed, rolling out r99138.
http://trac.webkit.org/changeset/99138
https://bugs.webkit.org/show_bug.cgi?id=71455

It made 200+ tests flakey on SL and on Qt (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-03

Source/WebCore:

  • html/HTMLIFrameElement.cpp:

(WebCore::parseSandboxAttribute):
(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::setForcedSandboxFlags):

  • loader/FrameLoaderTypes.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

LayoutTests:

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Removed.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Removed.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Removed.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Removed.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Removed.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Removed.
03:23 Changeset [99161] by haraken@chromium.org

Fixed wrong implementation of doubleValue % 2{64}.
https://bugs.webkit.org/show_bug.cgi?id=67980

Reviewed by Hajime Morita.

Source/JavaScriptCore:

fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.

  • wtf/MathExtras.h:

(doubleToInteger): Implemented the spec correctly.

Source/WebCore:

fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Uses doubleToInteger().

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyValue): Ditto.

LayoutTests:

Enabled progress-event-constructor.html on Chromium-Mac.

  • fast/events/constructors/progress-event-constructor-expected.txt:
  • fast/events/constructors/progress-event-constructor.html: The change from "12345678901234567168" to "12345678901234567890" is not related to this patch. Just to fix typo. The reason for whether "12345678901234567168" or "12345678901234567890" does not matter is that both values are toStringed to the same value "12345678901234567000".
  • platform/chromium/test_expectations.txt:
03:21 Changeset [99160] by philn@webkit.org

Unreviewed, skip fast/css/webkit-mask-crash-table.html crasher on
GTK.

  • platform/gtk/Skipped:
03:08 Changeset [99159] by apavlov@chromium.org

Web Inspector: Introduce SuggestBox for TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=71288

Reviewed by Pavel Feldman.

Drive-by fix for a regression where clicking in the Database query view did not focus the prompt.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype.afterShow):
(WebInspector.DatabaseQueryView.prototype.completions):
(WebInspector.DatabaseQueryView.prototype._selectStart.moveBackIfOutside):
(WebInspector.DatabaseQueryView.prototype._selectStart):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype._positionElement):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestForceable):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBoxConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.get hasSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype._onboxmousedown):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._applySuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestionsSoon):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):
(WebInspector.TextPrompt.SuggestBox.prototype._createItemElement):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._updateSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.spaceKeyPressed):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.search-view .search-panel):
(#search-results-pane-file-based .search-match .search-match-content):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar, .custom-popup-vertical-scroll ::-webkit-scrollbar):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-corner, .custom-popup-vertical-scroll ::-webkit-scrollbar-corner):
(.custom-popup-horizontal-scroll ::-webkit-resizer, .custom-popup-vertical-scroll ::-webkit-resizer):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-button, .custom-popup-vertical-scroll ::-webkit-scrollbar-button):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar:horizontal:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:hover):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:active):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:start):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:decrement):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:increment):
(.custom-popup-vertical-scroll ::-webkit-scrollbar:vertical:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:hover):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:active):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:start):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:decrement):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):

  • inspector/front-end/popover.css:

(.popover.right-bottom-arrow .arrow):

  • inspector/front-end/textPrompt.css: Added.

(.suggest-box):
(.suggest-box.visible):
(.suggest-box .container):
(.suggest-box-content-item):
(.suggest-box-content-item .prefix):
(.suggest-box-content-item.selected):
(.suggest-box-content-item:hover:not(.selected)):

  • inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.boxInWindow):

03:07 Changeset [99158] by philn@webkit.org

[GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
https://bugs.webkit.org/show_bug.cgi?id=71445

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): set directoriesDescription only when needed.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.

03:00 Changeset [99157] by commit-queue@webkit.org

Source/WebCore: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277

Patch by Devdatta Deshpande <webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.

If port is 0, SoupURI does not have an explicitly specified port. Due
to this port value is ignored in SoupURI. Hence, an extra check is
required to restore the port.

Test: LayoutTests/fast/loader/location-port.html

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessage):

LayoutTests: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277

Patch by Devdatta Deshpande <webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.

Removed LayoutTests/fast/loader/location-port.html from Skipped tests
for GTK

  • platform/gtk/Skipped:
02:59 Changeset [99156] by carlosgc@webkit.org

[GTK] Remove GtkLauncher2
https://bugs.webkit.org/show_bug.cgi?id=71449

Reviewed by Martin Robinson.

GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
made sense when we wanted to implement the exactly same wk1 API
for wk2. Now the code would require an ifdef for most the api, so
it's better to remove GtkLauncher2 and port MiniBrowser to the new
GTK+ API.

  • GNUmakefile.am:
  • GtkLauncher/main.c:

(notifyProgressCb):
(closeWebViewCb):
(createBrowser):
(addWebSettingsGroupToContext):
(main):

02:56 Changeset [99155] by commit-queue@webkit.org

[EFL] Enable the Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=69127

Patch by Dongwoo Im <dw.im@samsung.com> on 2011-11-03
Reviewed by Adam Barth.

.:

Build system changes to support ENABLE(PAGE_VISIBILITY_API) on EFL port.

  • Source/cmake/OptionsEfl.cmake: Add enabled ENABLE_PAGE_VISIBILITY_API definition.
  • Source/cmakeconfig.h.cmake: ditto.

Source/WebKit/efl:

Implement methods to enable the Page Visibility API on EFL port.
(http://www.w3.org/TR/page-visibility)

When the visibility status of the page is changed, browser could
inform the status to WebKit using the APIs below.

  • ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.

(ewk_view_visibility_state_set): Sets the page visibility status.
(ewk_view_visibility_state_get): Gets the page visibility status.

  • ewk/ewk_view.h: Add public prototypes.

LayoutTests:

  • platform/efl/Skipped: Unskip all of the test cases of page visibility.
02:27 Changeset [99154] by pfeldman@chromium.org

Web Inspector [chromium]: fix debug front-end zip generation.
https://bugs.webkit.org/show_bug.cgi?id=71376

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
02:25 Changeset [99153] by caseq@chromium.org

Unreviewed. Cleaned up obsolete suppressions.

  • platform/chromium/test_expectations.txt:
02:10 Changeset [99152] by commit-queue@webkit.org

Unreviewed, rolling out r99089.
http://trac.webkit.org/changeset/99089
https://bugs.webkit.org/show_bug.cgi?id=71448

@plt postfix for math functions cause crash on Linux 32 (the
symbol is defined but it points to NULL) (Requested by
zherczeg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-03

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:
  • jit/ThunkGenerators.cpp:
02:07 Changeset [99151] by hausmann@webkit.org

Unreviewed Qt build fix(es).

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::handleDragMoveEvent): Adapt to dragSession API change.
(QtDesktopWebPageProxy::handleDropEvent): Ditto.

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates): Implement here
also, for plugin-disabled builds.

02:07 Changeset [99150] by commit-queue@webkit.org

Web Inspector: Allow the toolbar background to be transparent on mac platforms when remote
https://bugs.webkit.org/show_bug.cgi?id=71437

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.css:

(body.detached.platform-mac-snowleopard #toolbar):

01:54 Changeset [99149] by philn@webkit.org

[GTK] Fix build-break on r99143
https://bugs.webkit.org/show_bug.cgi?id=71440

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-11-03
Reviewed by Philippe Normand.

dragOperation() should be replaced with dragSession().operation since it was removed.
And didDetectXSSForFrame of WKPageLoaderClient should be relocated.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkitWebLoaderClientAttachLoaderClientToPage):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):

01:06 Changeset [99148] by fpizlo@apple.com

Source/JavaScriptCore: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436

Reviewed by Oliver Hunt.

This makes inlined arguments retrieval use some of the same machinery as
OSR to determine where from, and how, to retrieve a value that the DFG
might have somehow squirreled away while the old JIT would put it in its
obvious location, using an obvious format.

To that end, previously DFG-internal notions such as DataFormat,
VirtualRegister, and ValueRecovery are now in bytecode/ since they are
stored as part of InlineCallFrames.

  • bytecode/CodeOrigin.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::inlineCallFrame):

  • interpreter/Register.h:

(JSC::Register::asInlineCallFrame):
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):

  • runtime/Arguments.h:

(JSC::Arguments::finishCreationAndCopyRegisters):

LayoutTests: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436

Reviewed by Oliver Hunt.

  • fast/js/dfg-inline-arguments-int32-expected.txt: Added.
  • fast/js/dfg-inline-arguments-int32.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-int32.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

00:37 Changeset [99147] by philn@webkit.org

[GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
https://bugs.webkit.org/show_bug.cgi?id=71359

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.

00:36 Changeset [99146] by mahesh.kulkarni@nokia.com

[Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
https://bugs.webkit.org/show_bug.cgi?id=71409

Reviewed by Simon Hausmann.

Build fix for building qtwebkit with latest qt5 which has removed Qt X11 headers.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
00:34 Changeset [99145] by philn@webkit.org

Unreviewed, GTK build fix after r99093...

  • PluginProcess/PluginControllerProxy.h:

11/02/11:

23:55 Changeset [99144] by fpizlo@apple.com

ValueRecovery should be moved out of the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=71439

Reviewed by Oliver Hunt.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/DataFormat.h: Added.

(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSFormat):
(JSC::isJSInteger):
(JSC::isJSDouble):
(JSC::isJSCell):
(JSC::isJSBoolean):

  • bytecode/ValueRecovery.h: Added.

(JSC::ValueRecovery::ValueRecovery):
(JSC::ValueRecovery::alreadyInRegisterFile):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::technique):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::tagGPR):
(JSC::ValueRecovery::payloadGPR):
(JSC::ValueRecovery::fpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):

  • bytecode/VirtualRegister.h: Added.
  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::isJSFormat):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGVariableAccessData.h:
23:46 Changeset [99143] by abarth@webkit.org

CSP should handle empty URLs as agreed at TPAC
https://bugs.webkit.org/show_bug.cgi?id=71426

Reviewed by Eric Seidel.

Source/WebCore:

It was somewhat unclear how CSP should treat plugins that lacked a URL
because most of the CSP rules are URL-based. At TPAC, we decided to
treat "empty" URLs as if there were the URL of the document. That
means you can use plugins with no URL if you've included 'self' in
object-src, but you can also block them by using 'none' as your
object-src.

Tests: http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html

http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::createCSPDirective):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/object-src-no-url-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html: Added.
    • Test the allow and block cases for plugins with no URL.
  • http/tests/security/contentSecurityPolicy/object-src-none-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked.html: Added.
    • Somehow these tests got deleted from the repository. This patch just re-adds them.
23:40 Changeset [99142] by caseq@chromium.org

Unerviewed gardening.

  • platform/chromium-cg-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium/test_expectations.txt: fixed qualifiers limit-layer-bounds-transformed-overflow.html
23:33 Changeset [99141] by commit-queue@webkit.org

[Qt] [WK] Debug build broken
https://bugs.webkit.org/show_bug.cgi?id=71417

Add WKNumber.h for WKBooleanGetTypeID
Replace WKGetTypeId with WKGetTypeID
Add initialization for didDetectXSSForFrame member in WKBundlePageLoaderClient
instance.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Noam Rosenthal.

  • WebProcess/qt/QtBuiltinBundle.cpp:

(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

23:16 Changeset [99140] by eric@webkit.org

Move Mocks into _mock files near their implementations
https://bugs.webkit.org/show_bug.cgi?id=71425

Reviewed by Adam Barth.

This entire change is splitting mocktool.py into separate _mock.py files
and placing them next to their real implementations.

I also deleted MockPortFactory (since it was wrong) and was just hiding
the fact that the "skipped-ports" command was broken (and has been for a long time).
So I made MockHost use a real PortFactory (passed a MockHost) and changed
the skipped-ports implementation to use modern PortFactory methods.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
  • Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
  • Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
  • Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  • Scripts/webkitpy/common/net/statusserver_unittest.py:
  • Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
  • Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  • Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
  • Scripts/webkitpy/test/main.py:
  • Scripts/webkitpy/tool/bot/botinfo_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
22:28 Changeset [99139] by commit-queue@webkit.org

Move NSRange / DOMRange conversion functions to WebFramePrivate
https://bugs.webkit.org/show_bug.cgi?id=71435

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-02
Reviewed by Sam Weinig.

Move conversion functions to WebFramePrivate,
and remove the no longer used versions.

  • WebView/WebFrame.mm:

(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
21:39 Changeset [99138] by abarth@webkit.org

Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Eric Seidel.

Source/WebCore:

There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox. Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox. Hixie says he'll add it to the spec once we implement
it, so here's our implementation. (See discussion in the W3C linked in
the bug for more details.)

Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
http/tests/security/popup-allowed-by-sandbox-when-allowed.html

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::forceSandboxFlags):

  • loader/FrameLoaderTypes.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::sandboxFlags):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

LayoutTests:

Test that the allow-popups directive works as expected. Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.
21:21 Changeset [99137] by weinig@apple.com

Remove the ability to generate custom lookupGetter/lookupSetter functions,
now that they can not be overridden

Reviewed by Adam Roben.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

21:17 Changeset [99136] by weinig@apple.com

Source/JavaScriptCore: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter
https://bugs.webkit.org/show_bug.cgi?id=71333

Reviewed by Gavin Barraclough.

Tested by fast/dom/getter-on-window-object2.html

  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setDescriptor):
The attributes returned from Structure::get do not include Getter or Setter, so
instead check if the value is a GetterSetter like we do elsewhere. If it is, update
the descriptor's attributes accordingly.

LayoutTests: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter/
https://bugs.webkit.org/show_bug.cgi?id=71333

Reviewed by Gavin Barraclough.

  • fast/dom/getter-on-window-object2-expected.txt:

Update for now correct results.

20:33 Changeset [99135] by weinig@apple.com

Fix crashing tests after r99126 (commit for https://bugs.webkit.org/show_bug.cgi?id=71307)

Reviewed by Adam Roben.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertyNames):
Since we are proxying to the window, we need to pass it as the this object,
not the shell.

20:13 Changeset [99134] by mitz@apple.com

Fixed the build and removed another copy to ColorBits.ttf.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/fonts/ColorBits.ttf: Removed.
20:13 Changeset [99133] by commit-queue@webkit.org

FunctionPtr should accept FASTCALL functions on X86
https://bugs.webkit.org/show_bug.cgi?id=71434

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.

On X86 we sometimes use FASTCALL convention functions, for example the
cti functions, and we may need the pointers to such functions, e.g.,
in current DFG register file check and arity check, though long term
we may avoid such usage of cti calls in DFG.

  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

19:58 Changeset [99132] by fpizlo@apple.com

Inlined uses of the global object should use the right global object
https://bugs.webkit.org/show_bug.cgi?id=71427

Reviewed by Oliver Hunt.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::globalObjectFor):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

19:19 Changeset [99131] by arv@chromium.org

Add new StorageInfo test to the respective skip lists.

Unreviewed.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
18:56 Changeset [99130] by arv@chromium.org

Remove LegacyDefaultOptionalArguments flag from storage IDL files
https://bugs.webkit.org/show_bug.cgi?id=65744

Reviewed by Adam Barth.

Source/WebCore:

Test: storage/domstorage/localstorage/missing-arguments.html

  • storage/DatabaseCallback.idl:
  • storage/IDBRequest.idl:
  • storage/IDBTransaction.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLStatementCallback.idl:
  • storage/SQLStatementErrorCallback.idl:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionCallback.idl:
  • storage/SQLTransactionErrorCallback.idl:
  • storage/SQLTransactionSync.idl:
  • storage/SQLTransactionSyncCallback.idl:
  • storage/Storage.idl:
  • storage/StorageInfo.idl:
  • storage/StorageInfoErrorCallback.idl:
  • storage/StorageInfoQuotaCallback.idl:
  • storage/StorageInfoUsageCallback.idl:

LayoutTests:

  • storage/domstorage/localstorage/missing-arguments-expected.txt: Added.
  • storage/domstorage/localstorage/missing-arguments.html: Added.
18:53 Changeset [99129] by commit-queue@webkit.org

Remove some unnecessary loads/stores in DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=71090

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.

In fillSpeculateCell and OSR exit, some unnecessary loads/stores can
be eliminated.

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

18:28 Changeset [99128] by adamk@chromium.org

Replace usage of StringImpl with String where possible in CharacterData and Text
https://bugs.webkit.org/show_bug.cgi?id=71383

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/text/WTFString.h:

(WTF::String::containsOnlyWhitespace): Added new method.

Source/WebCore:

Ryosuke Niwa, in http://webkit.org/b/70862, asked me to replace usages
of String with StringImpl. I've done more than what he asked in this
patch, the biggest change being that CharacterData now holds a String
instead of a RefPtr<StringImpl>.

No new tests, as this should have no effect on behavior.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setData):
(WebCore::CharacterData::substringData):
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::appendData):
(WebCore::CharacterData::insertData):
(WebCore::CharacterData::deleteData):
(WebCore::CharacterData::replaceData):
(WebCore::CharacterData::containsOnlyWhitespace):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::updateRenderer):
(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/CharacterData.h:

(WebCore::CharacterData::length):
(WebCore::CharacterData::dataImpl):
(WebCore::CharacterData::CharacterData):
(WebCore::CharacterData::setDataWithoutUpdate):

  • dom/Text.cpp:

(WebCore::Text::splitText):

17:55 Changeset [99127] by mitz@apple.com

REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=71424

Reviewed by Sam Weinig.

Tools:

Removed the ColorBits font and the code to register it in the process
running the tests. The font was only used by the aforementioned test,
which is now being removed.

  • DumpRenderTree/fonts/ColorBits-A.png: Removed.
  • DumpRenderTree/fonts/ColorBits.ttf: Removed.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
(activateTestingFonts):

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
(WTR::activateFonts):

LayoutTests:

Removed this test and its results, because it was relying on a feature
that is no longer present in any OS X version. The color bitmap font
rendering code is now covered by another test.

  • platform/mac/fonts/color-bitmap-expected.png: Removed.
  • platform/mac/fonts/color-bitmap-expected.txt: Removed.
  • platform/mac/fonts/color-bitmap.html: Removed.
17:25 Changeset [99126] by mhahnenberg@apple.com

De-virtualize JSObject::getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71307

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyNames):

(JSC::DebuggerActivation::getOwnPropertyNames):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyNames):

  • runtime/Arguments.h:
  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyNames):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertyNames):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertyNames):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertyNames):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyNames):

  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertyNames):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):

  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::~JSVariableObject):
(JSC::JSVariableObject::getOwnPropertyNames):

  • runtime/JSVariableObject.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::defineProperties):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertyNames):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

  • runtime/StringObject.h:
  • runtime/Structure.h:

Source/JavaScriptGlue:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • UserObjectImp.cpp:

(UserObjectImp::getOwnPropertyNames):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertyNames):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertyNames):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertyNames):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

  • bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyNames):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
17:16 Changeset [99125] by simon.fraser@apple.com

REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619

Skip some failing worker tests.

  • platform/mac/Skipped:
17:12 Changeset [99124] by mitz@apple.com

Fix an intermittent hang in RenderedImageFromDOMRange.

Reviewed by Anders Carlsson.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
immediately if there are no sources by passing a date in the distant past.

17:02 Changeset [99123] by aroben@apple.com

Add git-add-reviewer

I've been using this script for a while to add reviewers to git commits in my local
repository before pushing them to the Subversion repository. Basic usage is:

git-add-reviewer HEAD "Joe Schmoe"
or
git-add-reviewer -i trunk

Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
git commits

Reviewed by Sam Weinig.

  • Scripts/git-add-reviewer: Added.

(top level): Parse options, check that the working tree is clean, then run in either
interactive or non-interactive mode as appropriate.
(interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
editor exits, we check out the commit just before the earliest one we're modifying. Then
for each commit, we check it out, update the reviewer, and amend the commit to contain the
new reviewer. Finally, we update the branch that was originally checked out to point to the
last amended commit.
(nonInteractive): Check out the commit to modify, write the current commit message to the
MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
the commit, and rebase the original branch on top of the amended commit. (usage): Print out
a usage message and exit.
(requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
and index are clean.
(fail): Print out the specified error message, if any, and return false. This function is
used as a return value in various error cases throughout the script.
(cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
(addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
to .git/MERGE_MSG, which will be used as the commit message for the next commit.
(commit): Call git-commit and use .git/MERGE_MSG as the commit message.

(addReviewerToChangeLog):
(addReviewerToCommitMessage):
These just call through to addReviewerToFile.

(addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
temp file, then move the temp file over the original file and stage it for the next commit.
(head): Returns the name of the currently-checked-out branch.
(isAncestor): Returns true if the first commit is an ancestor of the second.
(toCommit): Converts a commitish to a commit ID using git-rev-parse.
(changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
(resetToCommit): Checks out the given commit, throwing away any local changes.
(writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
the specified file.
(rebaseOntoHead): Rebases the specified branch onto HEAD.
(checkout): Checks out the given commit.
(getConfigValue): Reads the specified config variable from git-config.

16:57 Changeset [99122] by andersca@apple.com

Don't call NPP_SetWindow if the plug-in size or clip rect hasn't changed if the plug-in isn't using window relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71418

Reviewed by Adam Roben.

This avoids calling into the plug-in when only the plug-in position relative to the window changes.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

16:43 Changeset [99121] by jonlee@apple.com

Fix syntax error.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

16:30 Changeset [99120] by tony@chromium.org

force inline flexitems to be wrapped in anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=71314

Reviewed by Ojan Vafai.

Source/WebCore:

If there is a mix of inline and block items, all the inline items were already getting wrapped
(see RenderBlock::addChildIgnoringAnonymousColumnBlocks). However, if there are only inline items,
we need to force them into an anonymous block.

There are still lots of bugs because we're trying to read style values from the anonymous block,
but this at least causes layout to be called on all the render objects.

Tests: css3/flexbox/anonymous-block.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox): force children into blocks

LayoutTests:

  • css3/flexbox/anonymous-block-expected.html: Added.
  • css3/flexbox/anonymous-block.html: Added.
16:22 Changeset [99119] by jonlee@apple.com

Fix build error from r99108.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

16:17 Changeset [99118] by dino@apple.com

Add ENABLE_CSS_SHADERS flag
https://bugs.webkit.org/show_bug.cgi?id=71394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
16:14 Changeset [99117] by andersca@apple.com

Allow the various plug-in ports to decide whether NPWindow coordinates should be window-relative
https://bugs.webkit.org/show_bug.cgi?id=71415

Reviewed by Darin Adler.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
Remove the PLUGIN_ARCHITECTURE(X11) ifdef and set the NPWindow members
based on the return value of wantsWindowRelativeNPWindowCoordinates.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Add platform specific implementations.

16:02 Changeset [99116] by commit-queue@webkit.org

[Qt] [WK] Debug build broken after r99065
https://bugs.webkit.org/show_bug.cgi?id=71397

Remove reference to panGestureActive becuase it is not defined anywhere.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::panGestureStarted):

16:01 Changeset [99115] by leviw@chromium.org

Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8439060

16:00 Changeset [99114] by arv@chromium.org

Remove references to non existing file; js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=71398

Reviewed by Ojan Vafai.

This js file no longer exists and the code it defined is now in js-test-pre.js.

  • fast/events/touch/gesture/gesture-scroll.html:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
15:53 Changeset [99113] by eae@chromium.org

Switch RenderText to new layout types
https://bugs.webkit.org/show_bug.cgi?id=71389

Reviewed by Eric Seidel.

Switch RenderText methods (and overriden methods in related classes) to
LayoutRect/LayoutUnit.

No new tests.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):

  • rendering/RenderText.h:

Change RenderText to expose its bounding box, selection and caret rects
as LayoutRects.

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

  • rendering/svg/RenderSVGInlineText.h:

Change localCaretRect to return a LayoutRect.

15:47 Changeset [99112] by jonlee@apple.com

Update dragging info on mac when user is dragging files into view
https://bugs.webkit.org/show_bug.cgi?id=71325
<rdar://problem/10379193>

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView draggingUpdated:]): Based on the DragSession, we update NSDraggingInfo
to update the badge and dragging formation.

15:44 Changeset [99111] by tony@chromium.org

Land chromium baselines for tests added in r94912.

  • fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt.
  • fast/borders/inline-mask-overlay-image-outset-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt.
  • fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-outset-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
  • platform/chromium/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
  • platform/mac/fast/borders/inline-mask-overlay-image-outset-expected.txt: Removed.
  • platform/mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Removed.
15:42 Changeset [99110] by annacc@chromium.org

Remove <track>-related LayoutTests that don't actually work yet.
https://bugs.webkit.org/show_bug.cgi?id=71378

Reviewed by Eric Carlson.

  • media/track/track-mutable-expected.txt: Removed.
  • media/track/track-mutable.html: Removed.
  • media/track/track-text-track-cue-list-expected.txt: Removed.
  • media/track/track-text-track-cue-list.html: Removed.
  • media/track/track-text-track-expected.txt: Removed.
  • media/track/track-text-track.html: Removed.
  • media/track/track-webvtt-tc000-empty-expected.txt: Removed.
  • media/track/track-webvtt-tc000-empty.html: Removed.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Removed.
  • media/track/track-webvtt-tc001-utf8.html: Removed.
  • media/track/track-webvtt-tc002-bom-expected.txt: Removed.
  • media/track/track-webvtt-tc002-bom.html: Removed.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Removed.
  • media/track/track-webvtt-tc003-newlines.html: Removed.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Removed.
  • media/track/track-webvtt-tc004-magic-header.html: Removed.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Removed.
  • media/track/track-webvtt-tc005-header-comment.html: Removed.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Removed.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Removed.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Removed.
  • media/track/track-webvtt-tc007-cue-no-id.html: Removed.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Removed.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Removed.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Removed.
  • media/track/track-webvtt-tc009-timings-hour.html: Removed.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Removed.
  • media/track/track-webvtt-tc010-no-timings.html: Removed.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Removed.
  • media/track/track-webvtt-tc011-blank-lines.html: Removed.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
  • media/track/track-webvtt-tc012-out-of-order.html: Removed.
  • media/track/track-webvtt-tc013-settings-expected.txt: Removed.
  • media/track/track-webvtt-tc013-settings.html: Removed.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Removed.
  • media/track/track-webvtt-tc014-alignment.html: Removed.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Removed.
  • media/track/track-webvtt-tc015-positioning.html: Removed.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Removed.
  • media/track/track-webvtt-tc016-align-positioning.html: Removed.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Removed.
  • media/track/track-webvtt-tc017-line-position.html: Removed.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Removed.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Removed.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Removed.
  • media/track/track-webvtt-tc019-cue-size.html: Removed.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Removed.
  • media/track/track-webvtt-tc020-cue-size-align.html: Removed.
  • media/track/track-webvtt-tc021-valign-expected.txt: Removed.
  • media/track/track-webvtt-tc021-valign.html: Removed.
  • media/track/track-webvtt-tc022-entities-expected.txt: Removed.
  • media/track/track-webvtt-tc022-entities.html: Removed.
  • media/track/track-webvtt-tc023-markup-expected.txt: Removed.
  • media/track/track-webvtt-tc023-markup.html: Removed.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Removed.
  • media/track/track-webvtt-tc024-timestamp.html: Removed.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Removed.
  • media/track/track-webvtt-tc025-class-markup.html: Removed.
  • media/track/track-webvtt-tc026-voice-expected.txt: Removed.
  • media/track/track-webvtt-tc026-voice.html: Removed.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Removed.
  • media/track/track-webvtt-tc027-empty-cue.html: Removed.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Removed.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Removed.
  • platform/chromium/test_expectations.txt: Remove all, remaining tests currently pass.
  • platform/gtk/Skipped: Remove all, remaining tests currently pass.
  • platform/mac/Skipped: Make sure all are skipped, <track> not enabled.
  • platform/qt/Skipped: Remove all, remaining tests currently pass.
  • platform/win/Skipped: Make sure all are skipped, <track> not enabled.
  • platform/wk2/Skipped: Remove all, remaining tests currently pass.
15:35 Changeset [99109] by leviw@chromium.org

Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Source/WebCore:

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

  • rendering/svg/RenderSVGResourceContainer.h:

LayoutTests:

Fixes a stack overflow when SVG resources reference one another and share ids.

  • svg/custom/resource-invalidation-crash-expected.png: Added.
  • svg/custom/resource-invalidation-crash-expected.txt: Added.
  • svg/custom/resource-invalidation-crash.svg: Added.
15:32 Changeset [99108] by jonlee@apple.com

Expand DragController to provide more information about the dragging session
https://bugs.webkit.org/show_bug.cgi?id=71324
<rdar://problem/10379175>

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp:

(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag): In addition to determining the
drag operation, DragSession is updated with data regarding whether the mouse
is over a file input, and the number of items that would be accepted based on
the mouse's location.

  • page/DragController.h:
  • page/DragSession.h: Added.

(WebCore::DragSession::DragSession): Keep track of current operation, whether
the mouse is over a file input element, and how many files would be accepted if
dropped.

  • platform/DragData.h: Added numberOfFiles()
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::numberOfFiles):

  • platform/efl/DragDataEfl.cpp:

(WebCore::DragData::numberOfFiles):

  • platform/gtk/DragDataGtk.cpp:

(WebCore::DragData::numberOfFiles):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::numberOfFiles):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::numberOfFiles):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::numberOfFiles):

  • platform/wince/DragDataWinCE.cpp:

(WebCore::DragData::numberOfFiles):

  • platform/wx/DragDataWx.cpp:

(WebCore::DragData::numberOfFiles):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::dragTargetDragEnterOrOver): The drag operation is contained
within the new DragSession struct. Minor refactor.

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_drag_motion): Minor refactoring.
(webkit_web_view_drag_data_received): Minor refactoring.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
(-[WebView draggingUpdated:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::dragEnterEvent): Minor refactoring because operation is stored in
new DragSession struct.
(QWebPagePrivate::dragMoveEvent): Ditto.

Source/WebKit/win:

  • WebView.cpp:

(WebView::DragEnter): Minor refactoring because operation is stored in
new DragSession struct.
(WebView::DragOver): Ditto.

Source/WebKit2:

We now pass the DragSession struct from the Web to the UI process, instead of the
DragOperation enum.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView draggingUpdated:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): We now cache the last known DragSession state
(WebKit::WebPageProxy::didPerformDragControllerAction):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::dragSession):
(WebKit::WebPageProxy::resetDragOperation):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::keyStateToDragOperation):
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

LayoutTests:

  • editing/pasteboard/script-tests/file-input-files-access.js:

(runTest): Change the expected behavior of the test-- dragging a file over a disabled
control should not load that file. Instead, the file should be ignored, and the page
remains as is.

15:26 Changeset [99107] by andersca@apple.com

Get rid of Plugin::deprecatedGeometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71411

Reviewed by Sam Weinig.

Now that all Plugin subclasses implement geometryDidChange and do all the work there
we can get rid of deprecatedGeometryDidChange.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

15:25 Changeset [99106] by eric@webkit.org

BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
https://bugs.webkit.org/show_bug.cgi?id=71237

Reviewed by Adam Barth.

Calling the static version of factory.get() with proper mocking
requires passsing an explict filesystem, executive, etc.
So instead, we use a PortFactory instance and pass it a Host pointer.
I had to add a MockHost since we'd not needed a non-host tool before now.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/mocktool.py:
15:25 Changeset [99105] by tony@chromium.org

Update chromium results for printing tests.

  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
  • platform/chromium/test_expectations.txt:
15:24 Changeset [99104] by ap@apple.com

Emedded PDFs cannot be opened from Web archives
https://bugs.webkit.org/show_bug.cgi?id=70954

Reviewed by Oliver Hunt.

BuiltInPDFPlugin doesn't have access to original ResourceResponse and has to re-create it
It doesn't seem to be possible to create an NSURLResponse with a non-null HTTP status code,
and NetscapePlugInStreamLoader becomes unhappy.

  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):

Allow 0 status code, it's not a real error to have one in response.

15:13 Changeset [99103] by andersca@apple.com

Update for the WebKit2 API fixage.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

15:06 Changeset [99102] by andersca@apple.com

Move back functions that were not added.

  • UIProcess/API/C/WKPage.h:
15:01 Changeset [99101] by andersca@apple.com

Source/WebKit2: Fix build and WebKit2 ABI.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:

Add page loader client sizes.

  • UIProcess/API/C/WKPage.h:

Move the newly added callback functions in the loader client last and bump the
WKPageLoaderClient version.

Tools: Fix build.

Add new functions to the page loader client.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

14:57 Changeset [99100] by nduca@chromium.org

[chromium] Slow down commit and draw rate based on visibility and draw completion
https://bugs.webkit.org/show_bug.cgi?id=71267

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::visible):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::visible):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::beginFrame):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::visible):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::FakeCCSchedulerClient::setVisible):
(WebKitTests::FakeCCSchedulerClient::visible):
(WebKitTests::TEST):

14:46 Changeset [99099] by mitz@apple.com

<rdar://problem/10336700> Add API to get rendered text image without having to select it
https://bugs.webkit.org/show_bug.cgi?id=71407

Reviewed by Simon Fraser.

Source/WebCore:

Test: TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm

  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:]): Added.

  • bindings/objc/DOMPrivate.h:
  • page/Frame.h:
  • page/mac/FrameMac.mm:

(WebCore::Frame::rangeImage): Added. Sets the selection in the RenderView (only) based on the
given range and gets a selection-only rendering of the view, then restores the selection.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Skip all invalidation if the repaint behavior is RepaintNothing.
(WebCore::RenderView::getSelection): Added this getter.

  • rendering/RenderView.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.

(-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

14:43 Changeset [99098] by benjamin@webkit.org

Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
https://bugs.webkit.org/show_bug.cgi?id=71351

Reviewed by Darin Adler.

Add the delimiter "/" at the end of the path instead of adding +1 when using
the path.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[NSURL _drt_descriptionSuitableForTestResult]):

14:36 Changeset [99097] by andersca@apple.com

Fix build.

  • WebProcess/Plugins/PluginView.h:
14:05 Changeset [99096] by commit-queue@webkit.org

XSSAuditor is silent
https://bugs.webkit.org/show_bug.cgi?id=70973

Patch by Tom Sepez <tsepez@chromium.org> on 2011-11-02
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-callbacks.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didDetectXSS):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didDetectXSS):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didDetectXSS):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didDetectXSS):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::didDetectXSS):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::didRunInsecureContent):
(WebFrameLoaderClient::didDetectXSS):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebFrameLoadDelegatePrivate.h:
  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::didDetectXSS):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::didDetectXSS):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::didDetectXSS):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::didDetectXSS):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkitWebLoaderClientAttachLoaderClientToPage):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didDetectXSSForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDetectXSSForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didDetectXSS):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didDetectXSS):

  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didDetectXSS:]):

  • MiniBrowser/mac/BrowserWindowController.m:

(didDetectXSSForFrame):
(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didDetectXSSForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-callbacks.html: Added.
14:02 Changeset [99095] by simon.fraser@apple.com

Assertion in FontCache::getCachedFontData() when painting into composited layer
https://bugs.webkit.org/show_bug.cgi?id=71377

Reviewed by Anders Carlsson.

Add one of the mysterious FontCachePurgePreventers on the stack when painting
compositing layers, just as FrameView::paintContents does, to fix an assertion
seen on the bots with some layout tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

14:01 Changeset [99094] by andersca@apple.com

More window relative coordinate usage removal
https://bugs.webkit.org/show_bug.cgi?id=71393

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
Just use m_clipRect instead of converting m_clipRectInWindowCoordinates to plug-in coordinates.

(WebKit::NetscapePlugin::platformPaint):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPaint):
Ditto.

13:57 Changeset [99093] by andersca@apple.com

Fix non-Mac builds and remove #if PLATFORM(MAC) around all contents scale factor functions.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::contentsScaleFactor):
(WebKit::PluginControllerProxy::geometryDidChange):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):

  • PluginProcess/PluginCreationParameters.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::contentsScaleFactor):
(WebKit::NetscapePlugin::getAuthenticationInfo):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::contentsScaleFactorChanged):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::contentsScaleFactorChanged):
(WebKit::PluginProxy::contentsScaleFactor):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::contentsScaleFactor):

13:28 Changeset [99092] by andersca@apple.com

Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in NetscapePlugin.
https://bugs.webkit.org/show_bug.cgi?id=71390

Reviewed by Adam Roben.

m_pluginSize is always equal to m_frameRectInWindowCoordinates.size() and this moves us one
sall step further towards eliminating m_frameRectInWindowCoordinates.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::snapshot):

13:12 Changeset [99091] by andersca@apple.com

Fix non-Mac builds.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

13:05 Changeset [99090] by andersca@apple.com

Plug-in snapshots are blurry in HiDPI
https://bugs.webkit.org/show_bug.cgi?id=71387
<rdar://problem/10385393>

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):
Create the backing store in the right size and apply the contents scale factor
to the newly created graphics context.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):
Pass the scale factor to ShareableBitmap::paint.

12:28 Changeset [99089] by mrobinson@webkit.org

TEXTREL in libjavascriptcoregtk-1.0.so.0.11.0 on x86 (or i586)
https://bugs.webkit.org/show_bug.cgi?id=70610

Patch by Alexey Shabalin <a.shabalin@gmail.com> on 2011-11-02
Reviewed by Martin Robinson.

Properly annotate ASM on BSD and Linux x86 systems.

  • dfg/DFGOperations.cpp: Add annotation for X86.
  • jit/JITStubs.cpp: Ditto.
  • jit/ThunkGenerators.cpp: Ditto.
12:12 Changeset [99088] by tony@chromium.org

Land chromium win/leopard baselines for printing/setPrinting.html and printing single-line-must-not-be-split-into-two-pages.html.

  • platform/chromium-cg-mac-leopard/printing/setPrinting-expected.png: Added.
  • platform/chromium-cg-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/printing/setPrinting-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/setPrinting-expected.png.
  • platform/chromium-cg-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png.
  • platform/chromium-linux/printing/setPrinting-expected.txt: Removed.
  • platform/chromium-mac-leopard/printing/setPrinting-expected.png: Added.
  • platform/chromium-mac-leopard/printing/setPrinting-expected.txt: Added.
  • platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Renamed from LayoutTests/platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt.
  • platform/chromium-mac-snowleopard/printing/setPrinting-expected.png: Renamed from LayoutTests/platform/chromium-mac/printing/setPrinting-expected.png.
  • platform/chromium-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Renamed from LayoutTests/platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png.
  • platform/chromium-mac/printing/setPrinting-expected.txt: Removed.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png:
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
  • platform/chromium/printing/setPrinting-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/setPrinting-expected.txt.
  • platform/chromium/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt.
  • platform/chromium/test_expectations.txt:
12:11 Changeset [99087] by commit-queue@webkit.org

MediaStreamRegistry should hold references to MediaStreamDescriptor rather than MediaStream
https://bugs.webkit.org/show_bug.cgi?id=70896

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-02
Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::lookupMediaStreamDescriptor):

  • mediastream/MediaStreamRegistry.h:
11:53 Changeset [99086] by zherczeg@webkit.org

Match allowed CSS string characters to Firefox and Opera browsers
https://bugs.webkit.org/show_bug.cgi?id=71000

Reviewed by Darin Adler.

Source/WebCore:

Firefox and Opera accepts any character inside a string except
newline and starting quote character. This behaviour matches to
the CSS 2.1 grammar: http://www.w3.org/TR/CSS2/grammar.html
WebKit should follow them.

Test: fast/css/parsing-css-allowed-string-characters.html

  • css/tokenizer.flex:

LayoutTests:

Add a new test case which contains various uncommon characters.

  • fast/css/parsing-css-allowed-string-characters-expected.txt: Added.
  • fast/css/parsing-css-allowed-string-characters.html: Added.
11:43 Changeset [99085] by commit-queue@webkit.org

Assert in MoveSelectionCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=70277

Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-11-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

A MoveSelectionCommand should be fired only if the selection type is
RangeSelection, since nothing is selected in other cases.

Test: fast/events/drag-link.html

  • page/DragController.cpp:

(WebCore::DragController::dragIsMove):

LayoutTests:

Test to drag-drop anchor element on an already focused editable div
element.

  • fast/events/drag-link-expected.txt: Added.
  • fast/events/drag-link.html: Added.
11:40 Changeset [99084] by tony@chromium.org

Try to deflake http/tests/multipart/policy-ignore-crash.php by
flushing the output buffer. For some reason, the <script> in the
first frame isn't running.

  • http/tests/multipart/policy-ignore-crash.php:
11:35 Changeset [99083] by jonlee@apple.com

<input=file multiple> default text uses singular instead of plural
https://bugs.webkit.org/show_bug.cgi?id=71319
<rdar://problem/10379021>

Reviewed by Darin Adler.

Source/WebCore:

Added a new method to return the label text for a file upload control that
allows multiple files. Needed to extend the RenderTheme function to pass down
a boolean representing whether multiple files are allowed in the file list.

  • English.lproj/Localizable.strings:
  • html/FileInputType.cpp:

(WebCore::FileInputType::defaultToolTip):

  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::fileButtonNoFilesSelectedLabel):

  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:

(WebCore::fileButtonNoFilesSelectedLabel):

  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::fileButtonNoFilesSelectedLabel):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::fileButtonNoFilesSelectedLabel):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth):

  • platform/gtk/RenderThemeGtk.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQt.h:
  • platform/wx/LocalizedStringsWx.cpp:

(WebCore::fileButtonNoFilesSelectedLabel):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::fileTextValue):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth):

Source/WebKit/chromium:

  • src/LocalizedStrings.cpp:

(WebCore::fileButtonNoFilesSelectedLabel):

Source/WebKit/qt:

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::fileButtonNoFilesSelectedLabel):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::fileButtonNoFilesSelectedLabel):

  • WebCoreSupport/PlatformStrategiesWinCE.h:
11:10 Changeset [99082] by mrobinson@webkit.org

[GTK] Visited links of a page group should be removed when clearing back/forward list
https://bugs.webkit.org/show_bug.cgi?id=71052

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-02
Reviewed by Martin Robinson.

Source/WebKit/gtk:

When clearing back-forward list, also remove the visited links from page's page group.

  • webkit/webkitwebbackforwardlist.cpp:

(webkit_web_back_forward_list_clear):

LayoutTests:

Rebaseline Gtk-related expectations now that links to previously loaded tests do not
appear as visited after enhancing the clearing of back-forward list that is done after
each test.

  • platform/gtk/fast/block/margin-collapse/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/020-expected.txt:
  • platform/gtk/fast/block/margin-collapse/056-expected.txt:
  • platform/gtk/fast/block/margin-collapse/059-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
11:09 Changeset [99081] by hausmann@webkit.org

[Qt] REGRESSION: 5 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=71117

Reviewed by Andreas Kling.

Tools:

Make sure that the view is properly focused, in order to get the
didBeginEditing DRT calls.

This requires activating the window (the call will result in a FocusIn
event to the window as well as setting QGuiApplication::focusWindow())
as well as enabling the focus on the view item. The signature of
setFocus has changed to take a boolean.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

LayoutTests:

  • platform/qt-5.0/Skipped: Unskip tests that now pass.
11:07 Changeset [99080] by caseq@chromium.org

Unreviewed. Brought back suppressions for setPrinting.html and printing/single-line-must-not-be-split-into-two-pages.html for
Win and 10.5.

  • platform/chromium/test_expectations.txt:
10:54 Changeset [99079] by abecsi@webkit.org

[Qt] Fix the build with NO_LISTBOX_RENDERING

Unreviewed build fix after r99035.

Patch by Michael Bruning <michael.bruning@nokia.com>

No new tests needed.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxSelectItem):

10:52 Changeset [99078] by tony@chromium.org

Cleanup chromium test_expectations.txt.

  • platform/chromium/test_expectations.txt: Remove stale commented out lines.

Mark fast/frames/calculate-fixed.html as slow for mac debug (based on flakiness dashboard).

10:49 Changeset [99077] by caio.oliveira@openbossa.org

[Qt] Implement message exchange between WebView and the web page
https://bugs.webkit.org/show_bug.cgi?id=70545

Reviewed by Noam Rosenthal.

Adds a mechanism for the WebView to send messages to the JavaScript environment
of the web page. In the WebView we have a method postMessage() and a signal
messageReceived(), while in the web page we expose a navigator.qt object with a
postMessage() method and a onmessage property. The messages are objects that
follow the same structure as MessageEvents.

The feature is disabled by default, and can be enabled by setting
QWebPreferences::navigatorQtObjectEnabled property to true. Changes take effect
after the next load(). QML tests are included.

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/ClientImpl.cpp:

(setupContextInjectedBundleClient): Helper to register the injected bundle client.
(qt_wk_didReceiveMessageFromInjectedBundle): Decode and dispatch a message received
from the WebProcess to the WebPageProxy.

  • UIProcess/PageClient.h:

(WebKit::PageClient::didReceiveMessageFromNavigatorQtObject):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessageFromNavigatorQtObject):

  • UIProcess/WebPageProxy.h:

Handle messages received from the navigator.qt object via the injected bundle. Called
from the ClientImpl.

  • UIProcess/API/qt/qbasewebview.cpp:

(QBaseWebView::postMessage):
(QBaseWebViewPrivate::setPageProxy):

  • UIProcess/API/qt/qbasewebview.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferences::navigatorQtObjectEnabled):
(QWebPreferences::setNavigatorQtObjectEnabled):

  • UIProcess/API/qt/qwebpreferences.h:

The signal, slot and the setting to enable the feature.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::defaultWKContext): setup the injected bundle client for this the
default context so we can listen to messages from it.

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didReceiveMessageFromNavigatorQtObject):
(QtWebPageProxy::setNavigatorQtObjectEnabled):
(QtWebPageProxy::postMessageToNavigatorQtObject):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::navigatorQtObjectEnabled):
Enabling and sending messages to the navigator.qt object are done by sending messages to
the injected bundle, identifying the page that we want to act on.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/messaging.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • WebProcess/qt/QtBuiltinBundle.cpp:

(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didReceiveMessage):
(WebKit::QtBuiltinBundle::handleMessageToNavigatorQtObject):
(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):

  • WebProcess/qt/QtBuiltinBundle.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::didClearWindowForFrame):
(WebKit::qt_postMessageCallback):
(WebKit::QtBuiltinBundlePage::postMessageFromNavigatorQtObject):
(WebKit::createWrappedMessage):
(WebKit::QtBuiltinBundlePage::didReceiveMessageToNavigatorQtObject):
(WebKit::QtBuiltinBundlePage::setNavigatorQtObjectEnabled):
(WebKit::QtBuiltinBundlePage::registerNavigatorQtObject):
(WebKit::QtBuiltinBundlePage::navigatorQtObjectClass):

  • WebProcess/qt/QtBuiltinBundlePage.h:

(WebKit::QtBuiltinBundlePage::navigatorQtObjectEnabled):

10:12 Changeset [99076] by rniwa@webkit.org

div { display: none; } makes pasting into text fields impossible
https://bugs.webkit.org/show_bug.cgi?id=27683

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by insertFragmentForTestRendering's always inserting a node for test rendering
into document's body.

Fixed the bug by inserting the node for test rendering into the root editable element. In addition,
remove the node before dispatching beforeTextInserted event to avoid event listeners, in particular
TextFieldInputType::handleBeforeTextInsertedEvent, from seeing the test node.

Test: editing/pasteboard/input-with-display-none-div.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):

LayoutTests:

Add a test to insert contents into an input element inside a page
with div { display: none; }

  • editing/pasteboard/input-with-display-none-div-expected.txt: Added.
  • editing/pasteboard/input-with-display-none-div.html: Added.
09:59 Changeset [99075] by tony@chromium.org

Add chromium test results for fast/reflections/reflection-masks-outset.html

  • fast/reflections/reflection-masks-outset-expected.txt: Renamed from LayoutTests/platform/gtk/fast/reflections/reflection-masks-outset-expected.txt.
  • platform/chromium-cg-mac-leopard/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/chromium-win/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/reflections/reflection-masks-outset-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Removed.
09:48 Changeset [99074] by cevans@google.com

Merge 98374
BUG=101010
Review URL: http://codereview.chromium.org/8386038

09:46 Changeset [99073] by jocelyn.turcotte@nokia.com

[Qt] Fix qmltest API test failures related to r98973.
https://bugs.webkit.org/show_bug.cgi?id=71280

Reviewed by Noam Rosenthal.

Most of the API was moved from TouchWebView.page to TouchWebView directly.
Fixed the qml tests to reflect this change.

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
09:45 Changeset [99072] by commit-queue@webkit.org

Missing Force8BitConstructor in 8-bit version of StringImpl::reallocate()
https://bugs.webkit.org/show_bug.cgi?id=71347

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-02
Reviewed by Geoffrey Garen.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::reallocate):

09:44 Changeset [99071] by commit-queue@webkit.org

[Qt] Failing test media/video-document-types.html
https://bugs.webkit.org/show_bug.cgi?id=62108

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-11-02
Reviewed by Simon Hausmann.

Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::committedLoad):
(WebCore::FrameLoaderClientQt::shouldFallBack):

09:40 Changeset [99070] by commit-queue@webkit.org

[chromium] Add per-script font preferences support in overridePreference
https://bugs.webkit.org/show_bug.cgi?id=71110

This allows a layout test to do something like:

Set standard font for Arabic to Ahem.
overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);

This should make writing a layout test for per-script fonts easier.

This change only affects the Chromium DumpRenderTree, but the other
platforms should probably also have a similar change eventually.

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-11-02
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestController.cpp: add per-script

font preferences to overridePreference
(LayoutTestController::cppVariantToWebStringArray):
(setFontMap):
(LayoutTestController::overridePreference):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPreferences.cpp:

(setStandardFontFamilyWrapper):
(setFixedFontFamilyWrapper):
(setSerifFontFamilyWrapper):
(setSansSerifFontFamilyWrapper):
(setCursiveFontFamilyWrapper):
(setFantasyFontFamilyWrapper):
(applyFontMap):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h: add per-script font

preference members
(WebPreferences::UScriptCodeHashTraits::emptyValue):
(WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
(WebPreferences::UScriptCodeHashTraits::isDeletedValue):

09:40 Changeset [99069] by rniwa@webkit.org

Fix a typo in the expected result added by r98989.

  • platform/mac/svg/filters/invalidate-on-child-layout-expected.txt:
09:27 Changeset [99068] by commit-queue@webkit.org

until use_skia=1 by default on mac, default port should be chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71312

Patch by Elliot Poger <epoger@google.com> on 2011-11-02
Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
09:22 Changeset [99067] by rniwa@webkit.org

REGRESSION(r96870): WebKit generates background: transparent on blogger.com
https://bugs.webkit.org/show_bug.cgi?id=71203

Reviewed by Ojan Vafai.

Source/WebCore:

Remove the transparent background color from inline style declarations in the pasted content.
Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style
declarations even if those properties were overridden.

Tests: editing/deleting/merge-paragraphs-with-transparent-background.html

editing/deleting/paste-with-transparent-background-color.html

  • editing/EditingStyle.cpp:

(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):

LayoutTests:

Added a test to merge paragraphs inside a document with background: transparent, and a test to
cut and paste contents with background: transparent, which is overriding a style rule background: blue.

WebKit should preserve the appearance of the pasted content but should not add a redundant
background: transparent.

  • editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added.
  • editing/deleting/merge-paragraphs-with-transparent-background.html: Added.
  • editing/deleting/paste-with-transparent-background-color-expected.txt: Added.
  • editing/deleting/paste-with-transparent-background-color.html: Added.
09:14 Changeset [99066] by commit-queue@webkit.org

printing layout test failures after r98634
https://bugs.webkit.org/show_bug.cgi?id=71080

Tools:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-02
Reviewed by Kent Tamura

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
matches that for Skia.

LayoutTests:

Added CG specific expected results.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-02
Reviewed by Kent Tamura

  • platform/chromium-cg-mac/printing/setPrinting-expected.png: Added.
  • platform/chromium-cg-mac/printing/setPrinting-expected.txt: Added.
  • platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed expectation of failure.
09:14 Changeset [99065] by kenneth@webkit.org

[Qt] Handle interruption of page interaction better
https://bugs.webkit.org/show_bug.cgi?id=71366

Reviewed by Simon Hausmann.

Touching the screen when a kinetic scrolling animation is running or
it is bouncing back because it was out of bounds, the animation is
immediately stopped and the content is immediately put into valid
bounds.

Touching the screen when the contents is bouncing back from a pinch
zoom which was out of bounds, we do not stop the animation, but
instead ignored the touch events while the animation lasts.

In the future we want to queue the events instead.

This also fixes some issues which was present before: As the bounce
back animation from pinch zoom centers the content using the contents
point which was in the center of the viewport, this animation could
not be used when stopping a pan animation, as it wouldn't position the
content at the place it was when the pan animation was interrupted.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::pinchAnimationActive):

  • UIProcess/qt/QtViewportInteractionEngine.h:
09:11 Changeset [99064] by weinig@apple.com

Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
https://bugs.webkit.org/show_bug.cgi?id=71346

Reviewed by Dan Bernstein.

  • Scripts/webkit-tools-completion.sh:

Add "-o default" which allows for completing files in addition to the word list.

08:45 Changeset [99063] by commit-queue@webkit.org

CSSStyleRule: Devirtualize selectorText()
https://bugs.webkit.org/show_bug.cgi?id=71364

Patch by Andreas Kling <kling@webkit.org> on 2011-11-02
Reviewed by Antti Koivisto.

Have CSSStyleRule::selectorText() redirect to CSSPageRule::pageSelectorText()
if type() is PAGE_RULE.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::pageSelectorText):

  • css/CSSPageRule.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::selectorText):

  • css/CSSStyleRule.h:
08:11 Changeset [99062] by sergio@webkit.org

[WK2][GTK] Skipped file cleanup
https://bugs.webkit.org/show_bug.cgi?id=71356

Added a couple of bug URLs. Moved bugs around to their proper sections.

  • platform/gtk-wk2/Skipped:
08:07 Changeset [99061] by commit-queue@webkit.org

[WK2] [GTK] WebKitWebProcess asserts in ASSERT(m_state != CLOSED)
https://bugs.webkit.org/show_bug.cgi?id=69513

Unskip passing tests.

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-02
Reviewed by Philippe Normand.

  • platform/gtk-wk2/Skipped:
08:05 Changeset [99060] by caseq@chromium.org

Unreviewed. Bring back some suppressions for media/media-document-audio-repaint.html.

  • platform/chromium/test_expectations.txt:
08:02 Changeset [99059] by commit-queue@webkit.org

CSSRule: Devirtualize cssText()
https://bugs.webkit.org/show_bug.cgi?id=71292

Patch by Andreas Kling <kling@webkit.org> on 2011-11-02
Reviewed by Antti Koivisto.

Have CSSRule::cssText() redirect to the appropriate subclass based on type().
This is one of the last steps of devirtualizing CSSRule completely, which will
allow us to get rid of its vtable, and each instance's pointer thereto.

  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.h:
  • css/CSSImportRule.h:
  • css/CSSMediaRule.h:
  • css/CSSRegionStyleRule.h:
  • css/CSSRule.cpp:

(WebCore::CSSRule::cssText):

  • css/CSSRule.h:
  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.h:
07:24 Changeset [99058] by commit-queue@webkit.org

[Qt][WK2] Move content to resize (setResizesToContentsUsingLayoutSize) from UI process to Web process
https://bugs.webkit.org/show_bug.cgi?id=71107

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-02
Reviewed by Kenneth Rohde Christiansen.

Reduce the number of IPC calls to WebProcess by moving the content to resize
calls from UI process to Web process.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportSize):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::geometryChanged):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setViewportSize):
(WebKit::WebPageProxy::preferencesDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtTouchWebPageProxy.cpp:
  • UIProcess/qt/QtTouchWebPageProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

  • WebProcess/WebPage/WebPage.messages.in:
07:21 Changeset [99057] by caryclark@google.com

Unreviewed gardening: 7th chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 616 of 624 files for brevity.]

  • platform/chromium-mac-leopard/animations: Added.
  • platform/chromium-mac-leopard/animations/state-at-end-event-expected.png: Added.
  • platform/chromium-mac-leopard/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac-leopard/css1/basic/inheritance-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png:

...

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
07:12 Changeset [99056] by paroga@webkit.org

Unreviewed build fix for !ENABLE(FILTERS) after r98989.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):

07:00 Changeset [99055] by apavlov@chromium.org

Web Inspector: [REGRESSION] Clicking in a CSS property/value being edited commits the editor
https://bugs.webkit.org/show_bug.cgi?id=71360

Reviewed by Pavel Feldman.

Selecting a selected TreeElement should be an idempotent operation.

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.select):

05:56 Changeset [99054] by hausmann@webkit.org

[Qt][WK2]: Shouldn't send unhandled TouchCancel event to gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=70333

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-10-18
Reviewed by Simon Hausmann.

Gesture recognizers should be reset for unhandled TouchCancel event.

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::doneWithTouchEvent):

04:34 Changeset [99053] by caseq@chromium.org

Unreviewed. Another rebaseline of media/media-document-audio-repaint.html

  • platform/chromium-cg-mac-snowleopard/media/media-document-audio-repaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-document-audio-repaint-expected.png.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/media-document-audio-repaint-expected.png.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-document-audio-repaint-expected.txt.
  • platform/chromium/test_expectations.txt:
03:48 Changeset [99052] by caseq@chromium.org

Unreviewed fix for build failure on chromium shared linux caused by r99020.

  • WebKit.gyp:
02:57 Changeset [99051] by hausmann@webkit.org

[Qt][WK2] Add support for touch event testing to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=71310

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEvent): Add support for m_shouldSendEventsSynchronously.

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::handleEvent): Handle plain touch events in the desktop page proxy by
forwarding them appropriately. We will receive them from WTR through ::event, but we won't
receive them from QQuickCanvas (i.e. the user) because that doesn't uses ::event but only
dedicated fooEvent() handlers, of which we don't re-implement the touch version.
(QtDesktopWebPageProxy::handleTouchEvent): Forward touch events to WebPageProxy.

  • UIProcess/qt/QtDesktopWebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::touchEventSyncForTesting): Add support for synchronous touch event testing,
similar to the way it's done for mouse events.

  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.

Tools:

  • WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS

define works in EventSendingController.idl

  • WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch

handlers.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions

required by tests.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the

ui process.
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature

defines.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
touch messages to the EventSenderProxy.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::sendTouchEvent):

  • WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.

LayoutTests:

  • platform/qt-wk2/Skipped: Unskip touch tests that are passing now.
02:36 Changeset [99050] by philn@webkit.org

Unreviewed, GTK baselines for new tests.

  • platform/gtk/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-complex-inner-expected.txt: Added.
  • platform/gtk/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
  • platform/gtk/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/gtk/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/gtk/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/gtk/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/gtk/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/gtk/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/gtk/svg/filters/feColorMatrix-default-type-expected.txt: Added.
  • platform/gtk/svg/filters/invalidate-on-child-layout-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
02:31 Changeset [99049] by hausmann@webkit.org

[WK2] Remove unused/duplicated modifiers member from WebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=71353

Reviewed by Kenneth Rohde Christiansen.

WebTouchEvent::m_[ctrl,alt,meta,shift]Key are redundant compared to
WebEvent::m_modifiers. The latter is fully populated and used, the former
can be safely removed.

  • Shared/WebEvent.h:
  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::WebTouchEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

02:09 Changeset [99048] by rgabor@webkit.org

[Qt] Unreviewed gardening. Unskip the Qt mobility tests because they are working now.

  • platform/qt-arm/Skipped:
02:00 Changeset [99047] by philn@webkit.org

Unreviewed, GTK rebaseline after r98852 and r99027.

  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/fast/block/float/015-expected.txt:
  • platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
01:43 Changeset [99046] by ryuan.choi@samsung.com

[EFL] Fix build break when DEBUG_MEM_LEAKS is enabled.
https://bugs.webkit.org/show_bug.cgi?id=71349

Unreviewed build fix.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_smart_del): remove wrong assignment

  • ewk/ewk_tiled_matrix.cpp: define STDC_FORMAT_MACROS to use PRIu64

(ewk_tile_matrix_free): s/tileMatrixm/tileMatrix
(ewk_tile_matrix_dbg): s/tm/tileMatrix

  • ewk/ewk_tiled_model.cpp: define STDC_FORMAT_MACROS to use PRIu64

(_ewk_tile_account_get): remove REALLOC_OR_OOM_RET

01:24 Changeset [99045] by philn@webkit.org

Unreviewed, skip testWebKitSettingsNewWithSettings affected by bug
70127.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsNewWithSettings):

00:57 Changeset [99044] by ossy@webkit.org

[Qt] Unreviewed gardening after r98852.

  • platform/qt-5.0/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/qt-5.0/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/qt/Skipped: Skip failing tests because of https://bugs.webkit.org/show_bug.cgi?id=52810
00:54 Changeset [99043] by commit-queue@webkit.org

Canvas filling paths or rects need to be invalidate larger rects for some compositing modes.
https://bugs.webkit.org/show_bug.cgi?id=70379

Patch by Ben Wells <benwells@chromium.org> on 2011-11-02
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-fill-repaint.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::didDrawEntireCanvas):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-fill-repaint-expected.txt: Added.
  • fast/canvas/canvas-composite-fill-repaint.html: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-linux/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium/test_expectations.txt:
00:22 Changeset [99042] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
00:21 Changeset [99041] by commit-queue@webkit.org

[EFL] Dirty area is not updated with requestAnimationFrame.
https://bugs.webkit.org/show_bug.cgi?id=70170

Some additional dirty areas caused by re-layout have ignored
since updateLayoutAndSytleIfNeedeRecursive is called after gathering dirty area to repaint.
So ewk_view_layout_if_needed_recursive is relocated before getting dirty areas.

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-11-02
Reviewed by Eric Seidel.

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

11/01/11:

23:26 Changeset [99040] by leviw@chromium.org

Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
https://bugs.webkit.org/show_bug.cgi?id=71321

Reviewed by Darin Adler.

Updating the usage of LayoutUnits in the *View classes to mirror the proper use
as derived in the subpixellayout branch.

This entails scrolling only with integers (and rounding once we've made the switch)
and using integers for window coordinates, with LayoutUnits for content coordinates.

No new tests -- no change in behavior.

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::zoomAnimatorTransformChanged):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::updateScrollCorner):

  • page/FrameView.h:

(WebCore::FrameView::trackedRepaintRects):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutWidth):
(WebCore::ScrollView::layoutHeight):
(WebCore::ScrollView::fixedLayoutSize):
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::scrollbarAtPoint):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::visibleWidth):
(WebCore::ScrollView::visibleHeight):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::adjustScrollPositionWithinRange):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):

  • rendering/RenderView.h:

(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):

22:48 Changeset [99039] by annacc@chromium.org

Small fixes for WebVTTParser.
https://bugs.webkit.org/show_bug.cgi?id=71334

Reviewed by Darin Adler.

No new tests. This is needed to enable other tests, coming soon.

  • html/track/WebVTTParser.cpp:

(WebCore::hasLongWebVTTIdentifier): changed to return true when header is

exactly "WEBVTT"

(WebCore::WebVTTParser::collectTimingsAndSettings): fix typos, position should

only progress once when checking the character after a timestamp.

20:34 Changeset [99038] by imasaki@chromium.org

2011-11-01 Kenji Imasaki <imasaki@chromium.org>

[Chromium] Unreviewed. Did rebaselines of media/media-document-audio-repaint.html.

  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
20:20 Changeset [99037] by weinig@apple.com

resolve-ChangeLogs --help should be faster.

Reviewed by Adam Roben.

  • Scripts/resolve-ChangeLogs:

(usageAndExit):
Add a call to usageAndExit() before doing work to find unmerged changelogs
if --help or something illegal is provided on the command line.

19:52 Changeset [99036] by darin@apple.com

Cut down on malloc/free a bit in the parser arena
https://bugs.webkit.org/show_bug.cgi?id=71343

Reviewed by Oliver Hunt.

  • parser/ParserArena.cpp:

(JSC::ParserArena::deallocateObjects): Call the destructors of
the deletable objects before freeing the pools. Don't call
fastFree on the deletable objects any more.

  • parser/ParserArena.h:

(JSC::ParserArena::allocateDeletable): Use allocateFreeable
instead of fastMalloc here.

19:47 Changeset [99035] by darin@apple.com

Change HTMLSelectElement::setSelectedIndex to use enums instead of bools
https://bugs.webkit.org/show_bug.cgi?id=70184

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring that does not require new tests.

  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLSelectElement _activateItemAtIndex:]): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
(-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]): Ditto.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setSelected): Replaced setSelectedIndex call with a
call to the new optionSelectionStateChanged function.
(WebCore::HTMLOptionElement::insertedIntoTree): Ditto.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement): Updated since m_userDrivenChange
was renamed to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::optionSelectedByUser): Removed deselect argument,
which was always true for all callers. Updated comment.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Updated comment.
(WebCore::HTMLSelectElement::setOption): Call the new optionSelectionStateChanged
function. The code used to explicitly ask the function it calls to deselect base
on the value of m_multiple, but that is no longer needed because the selectOption
function itself takes care of that check.
(WebCore::HTMLSelectElement::dispatchChangeEventForMenuList): Renamed this function.
Also updated for name change to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::setSelectedIndex): Moved the formerly-inlined function
here from the header and changed it to call the renamed selectOption function.
(WebCore::HTMLSelectElement::optionSelectionStateChanged): Added this function.
It is used by callers that were previously using setSelectedIndex and passing
"false" for the deselect argument. It's better now that setSelectedIndex is now a
pure DOM setter function without the multiple purposes it had before. This function
now has the logic that handles the special handling when deselecting an option,
which used to be at the top of the next function.
(WebCore::HTMLSelectElement::selectOption): Renamed this from setSelectedIndex.
Replaced boolean arguments with flags. Removed code to handle the special case
when we deselect an option; that's now handled in the optionSelectionStateChanged
function. Added an assertion to replace a comment and updated for other renaming.
(WebCore::HTMLSelectElement::dispatchBlurEvent): Updated for name change.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Changed to call the
new selectOption function and also updated for other name changes.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

  • html/HTMLSelectElement.h: Changed the setSelectedIndex to be a pure setter

function for the selectedIndex DOM property. Added a optionSelectedByUser function
for the other use of setSelectedIndex, but removed the always true "deselect"
argument from it. Added a optionSelectionStateChanged function for use in the
HTMLOptionElement implementation. Renamed menuListOnChange to
dispatchChangeEventForMenuList for clarity. Added a SelectOptionFlag and
SelectOptionFlags type for the arguments to the selectOption function, formerly
implemented as an overload of setSelectedIndex (and called setSelectedIndexInternal
before that). Renamed m_userDrivenChange to m_isProcessingUserDrivenChange.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.

Source/WebKit/chromium:

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.

19:24 Changeset [99034] by weinig@apple.com

Implement lookupGetter/lookupSetter in terms of getPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71336

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerActivation.h:

Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.

  • runtime/JSObject.cpp:

(JSC::JSObject::lookupGetter):
(JSC::JSObject::lookupSetter):

  • runtime/JSObject.h:

De-virtualize lookupGetter/lookupSetter, and implement them in terms of
getPropertyDescriptor.

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • page/DOMWindow.idl:

Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.

LayoutTests:

  • fast/dom/getter-on-window-object2-expected.txt:

Update results now that lookupGetter/lookupSetter match getOwnPropertyDescriptor.
The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.

19:18 Changeset [99033] by nduca@chromium.org

[chromium] Move resource-releasing logic into CCProxy and cleanup setNeedsCommit
https://bugs.webkit.org/show_bug.cgi?id=71269

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::setVisible):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setVisible):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::composite):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestScrollSimple::beginTest):
(CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):

19:16 Changeset [99032] by cevans@google.com

Merge 98935
BUG=101018
Review URL: http://codereview.chromium.org/8386021

19:08 Changeset [99031] by commit-queue@webkit.org

[Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
https://bugs.webkit.org/show_bug.cgi?id=71342

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-01
Reviewed by Darin Adler.

Tools:

[NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
[NSString substringFromIndex:] with an index out of the string range.

The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
from the root of the disk.
The problem was hidden because the exception are catched when calling the delegate.

This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
in a subdirectory of the main frame.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[NSURL _drt_descriptionSuitableForTestResult]):

LayoutTests:

Update the test results following the fix of _drt_descriptionSuitableForTestResult.

  • webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
19:08 Changeset [99030] by cevans@google.com

Merge 98763
BUG=99597
Review URL: http://codereview.chromium.org/8423033

19:05 Changeset [99029] by cevans@google.com

Merge 98561
BUG=100526
Review URL: http://codereview.chromium.org/8399045

18:53 Changeset [99028] by cevans@google.com

Merge 98033
BUG=99603
Review URL: http://codereview.chromium.org/8372052

18:52 Changeset [99027] by annacc@chromium.org

Makes [Reflect] work for constants.
This is needed to avoid platform-specific define conflicts, specifically
TextTrack::ERROR conflicts with a windows define.
https://bugs.webkit.org/show_bug.cgi?id=70951

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-constants.html

  • bindings/scripts/CodeGenerator.pm:

(GenerateCompileTimeCheckForEnumsIfNeeded):

Check for [Reflect] and assign name accordingly.

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Update test file.
  • bindings/scripts/test/JS/JSTestObj.cpp: Update test file.

(WebCore::jsTestObjCONST_JAVASCRIPT):

  • bindings/scripts/test/JS/JSTestObj.h: Update test file.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Update test file.
  • bindings/scripts/test/TestObj.idl: Update test file.
  • bindings/scripts/test/V8/V8TestObj.cpp: Update test file.
  • html/LoadableTextTrack.cpp: Use new DOM const name.

(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):

  • html/TextTrack.cpp: Use new DOM const name.

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):

  • html/TextTrack.h: Use new DOM const name.
  • html/TextTrack.idl: Use Reflect for ERROR, but leave other DOM const names.

LayoutTests:

  • media/track/track-constants-expected.txt: Added.
  • media/track/track-constants.html: Added.
  • media/track/track-load-error-readyState.html: Updated with new const name.
  • media/track/track-load-from-element-readyState.html: Updated with new const name.
  • media/track/track-load-from-src-readyState.html: Updated with new const name.

VIDEO_TRACK is not enabled on these ports, so skipping this test:

  • platform/mac/Skipped:
  • platform/win/Skipped:
18:51 Changeset [99026] by cevans@google.com

Merge 98010
BUG=100177
Review URL: http://codereview.chromium.org/8437038

18:42 Changeset [99025] by cevans@google.com

Merge 98344
BUG=100863
Review URL: http://codereview.chromium.org/8440026

18:33 Changeset [99024] by leviw@chromium.org

Amend missing uses of LayoutUnit in RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=71254

Reviewed by Darin Adler.

Switching relevant uses of integers in RenderBlock to LayoutUnits.

No new tests -- no changes in behavior.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintContents):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::baselinePosition):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::FloatWithRect::FloatWithRect):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):

18:32 Changeset [99023] by cevans@google.com

Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/8437036

18:23 Changeset [99022] by macpherson@chromium.org

WIP: Add CSS property to control printing of backgrounds for individual elements.
https://bugs.webkit.org/show_bug.cgi?id=64583

Reviewed by Eric Seidel.

Added test LayoutTests/fast/css/webkit-color-adjust.html,
Updated tests under LayoutTests/fast/css/getComputedStyle
Updated test under LayoutTests/svg/css

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialForceBackgroundsToWhite):

18:20 Changeset [99021] by dominicc@chromium.org

Remove initErrorEvent method
https://bugs.webkit.org/show_bug.cgi?id=71338

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/ErrorEvent.cpp: Crush.
  • dom/ErrorEvent.h: Kill.
  • dom/ErrorEvent.idl: Destroy.

LayoutTests:

  • http/tests/workers/worker-importScriptsOnError-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
18:12 Changeset [99020] by jchaffraix@webkit.org

Pack RenderTableCell bits
https://bugs.webkit.org/show_bug.cgi?id=71135

Reviewed by Darin Adler.

Source/WebCore:

Tested by RenderTableCellTest unit test.
(unfortunately Chromium specific...)

This saves another 8 bytes on RenderTableCell on x86-64.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

Changed the field order to use more strict packing.

(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::setRow):
Added overflow checks to the 2 previous methods. We
CRASH even in release to avoid potential badness
(the limit is currently above 2 billions rows or columns
which is high enough to prevent it being hit by accident)

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/RenderTableCellTest.cpp: Added.

Added some tests for the column/row index limit
that was implemented in RenderTableCell.

17:55 Changeset [99019] by eae@chromium.org

Switch background/border image back to Int
https://bugs.webkit.org/show_bug.cgi?id=71240

Reviewed by Darin Adler.

Switch background- and border-image rendering back to int to align with
device pixels.

No new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::calculateAdjustedInnerBorder):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):

17:36 Changeset [99018] by mhahnenberg@apple.com

De-virtualize JSObject::defineSetter
https://bugs.webkit.org/show_bug.cgi?id=71303

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

(JSC::DebuggerActivation::defineSetter):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineSetter):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineSetter):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::defineSetter):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineSetter):

Source/WebCore:

No new tests.

Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineSetter):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::defineSetter):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

17:34 Changeset [99017] by timothy_horton@apple.com

SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>

Reviewed by Darin Adler.

Fix svg/filters/invalidate-on-child-layout.svg to not include nonexistent onload handler.

  • svg/filters/invalidate-on-child-layout.svg:
17:15 Changeset [99016] by eae@chromium.org

Switch PopupMenuClient to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71308

Reviewed by Darin Adler.

Switch PopupMenuClient and rendering classes implementing it to layout
type abstraction.

No new tests.

  • platform/PopupMenuClient.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
Revert scroll positions and scroll offsets to ints to align with device
pixels.

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

  • rendering/RenderTextControlSingleLine.h:
17:09 Changeset [99015] by japhet@chromium.org

Source/WebCore: [chromium] As of r98380, ThreadableLoaderClients are having their
ResourceRequest::TargetType clobbered. They set their own
type, but CachedResourceRequest (through which they now flow)
sets a TargetType without bothering to see if one has already been set.
https://bugs.webkit.org/show_bug.cgi?id=70972

Reviewed by Darin Fisher.

No new tests, this is chromium-specific and only affects
behavior seen in full builds of chromium.

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):Don't setTargetType()

if the value is something other than the default already.

  • platform/network/chromium/ResourceRequest.h: Change default

TargetType to TargetIsUnspecified.

Source/WebKit/chromium: Add 2 new TargetTypes (to match ResourceRequest::TargetType)
and ensure we don't pass chromium a TargetType it doesn't
yet understand.
https://bugs.webkit.org/show_bug.cgi?id=70972

Reviewed by Darin Fisher.

  • public/WebURLRequest.h:
  • src/WebURLRequest.cpp:
17:08 Changeset [99014] by eae@chromium.org

Use IntPoint for screen coordinates in MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=71327

Reviewed by Darin Adler.

Change mouse events to use int/IntPoint for screen/window coordinates and
LayoutUnit/LayoutPoint for coordinates adjusted for zooming.

No new tests.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::computeRelativePosition):

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::screenLocation):
Revert screenLocation and windowLocation back to int.

  • page/DragController.cpp:

(WebCore::elementUnderMouse):
Change elementUnderMouse to use a LayoutPoint for hit testing.

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:

Revert m_currentMousePosition to IntPoint as it represents a
screen coordinate.

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):
Revert PlatformMouseEvent to int/IntPoint as it represents a screen
coordinate.

16:58 Changeset [99013] by tony@chromium.org

REGRESSION: -webkit-flex() should be an invalid value
https://bugs.webkit.org/show_bug.cgi?id=71320

Reviewed by Ojan Vafai.

This regressed in http://trac.webkit.org/changeset/98773 .

No new tests, covered by css3/flexbox/flex-parsing.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

16:53 Changeset [99012] by johnnyg@google.com

Rebaseline getter-on-window-object2.html after r99005.

  • platform/chromium/fast/dom/getter-on-window-object2-expected.txt: Added.
16:33 Changeset [99011] by dgrogan@chromium.org

IndexedDB: get EventQueue from ScriptExecutionContext instead of Document
https://bugs.webkit.org/show_bug.cgi?id=71147

When IDB is used from a worker thread ScriptExecutionContext will
be a WorkerContext, not a Document. This was the impetus behind
moving EventQueue into ScriptExecutionContext in r98656.

Reviewed by Nate Chapin.

No new tests. No new functionality yet.

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::enqueueEvent):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::enqueueEvent):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::enqueueEvent):

16:31 Changeset [99010] by commit-queue@webkit.org

CSS: Remove unused virtual parseString() in style and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=71300

Patch by Andreas Kling <kling@webkit.org> on 2011-11-01
Reviewed by Darin Adler.

  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.cpp:
  • css/WebKitCSSKeyframeRule.h:
16:13 Changeset [99009] by fpizlo@apple.com

DFG inlining breaks function.arguments
https://bugs.webkit.org/show_bug.cgi?id=71329

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The DFG was forgetting to store code origin mappings for inlined
call sites. Some of the fast-path optimizations for
CallFrame::trueCallerFrame() were wrong. An assertion in Arguments
was wrong.

I also took the opportunity to decrease code duplication between
DFG64 and DFG32_64, because I didn't feel like writing the same
code twice.

  • bytecode/CodeBlock.h:

(JSC::ExecState::isInlineCallFrame):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGNode.h:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:
  • runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):

LayoutTests:

Reviewed by Oliver Hunt.

Test that using bar.arguments, where bar was inlined into baz,
works correctly.

  • fast/js/dfg-inline-arguments-simple-expected.txt: Added.
  • fast/js/dfg-inline-arguments-simple.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-simple.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

16:02 Changeset [99008] by eae@chromium.org

Switch RenderObject to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71249

Switch RenderObject to LayoutRect/Size/Point abstraction.

Reviewed by Darin Adler.

No new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::viewRect):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localCaretRect):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::maximalOutlineSize):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::absoluteOutlineBounds):
(WebCore::RenderObject::outlineBoundsForRepaint):
(WebCore::adjustForAbsoluteZoom):

16:01 Changeset [99007] by tony@chromium.org

Update result to match mac repaint result. When we forced a layout on
the test (when landing the mac-sl results), it caused this result to
change slightly.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
15:53 Changeset [99006] by alokp@chromium.org

[chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71318

Reviewed by James Robinson.

Fixed a typo for --enable-hardware-gpu flag.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:36 Changeset [99005] by weinig@apple.com

Expand fast/dom/getter-on-window-object2.html to test Object.getOwnPropertyDescriptor as well
https://bugs.webkit.org/show_bug.cgi?id=71332

Reviewed by Anders Carlsson.

  • fast/dom/getter-on-window-object2-expected.txt:
  • fast/dom/getter-on-window-object2.html:

Convert to shouldBe style tests and expand test to also test Object.getOwnPropertyDescriptor,
which currently fail for getters/setters defined over window properties.

15:32 Changeset [99004] by commit-queue@webkit.org

[chromium] Media Stream API: Adding supporting classes to WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=71008

Expanding WebMediaStreamDescriptor and adding WebMediaStreamSource

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-01
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.

(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::~WebMediaStreamSource):
(WebKit::WebMediaStreamSource::isNull):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::initialize):

  • src/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.

(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::reset):
(WebKit::WebMediaStreamSource::operator PassRefPtr<MediaStreamSource>):
(WebKit::WebMediaStreamSource::operator MediaStreamSource*):
(WebKit::WebMediaStreamSource::initialize):
(WebKit::WebMediaStreamSource::id):
(WebKit::WebMediaStreamSource::type):
(WebKit::WebMediaStreamSource::name):

15:12 Changeset [99003] by johnnyg@google.com

Suppress svg/filters/invalidate-on-child-layout.svg until the fix lands.

  • platform/chromium/test_expectations.txt:
15:06 Changeset [99002] by xji@chromium.org

Refactor: change Scrollable::m_scrollOrigin from protected to private.
https://bugs.webkit.org/show_bug.cgi?id=71236

Reviewed by Darin Adler.

Only refactor, no new tests needed.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::computeScrollDimensions):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):

14:54 Changeset [99001] by lforschler@apple.com

Versioning.

14:50 Changeset [99000] by lforschler@apple.com

Merged r98824.

14:45 Changeset [98999] by lforschler@apple.com

New Tag.

14:32 Changeset [98998] by weinig@apple.com

Expand prototype setting test to test Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=71322

Reviewed by Anders Carlsson.

  • fast/js/script-tests/prototypes.js:

Also test setting proto using Object.defineProperty.

13:55 Changeset [98997] by dominicc@chromium.org

display: table-cell and box-sizing: border-box calculates content-box height
https://bugs.webkit.org/show_bug.cgi?id=69425

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/box-sizing/table-cell.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

  • fast/box-sizing/table-cell-expected.txt: Added.
  • fast/box-sizing/table-cell.html: Added.
13:52 Changeset [98996] by imasaki@chromium.org

[Chromium] Unreviewed. Remove media/audio-repaint.html from test expectaion.

  • platform/chromium/test_expectations.txt:
13:40 Changeset [98995] by lforschler@apple.com

New tag.

13:13 Changeset [98994] by nduca@chromium.org

CCSchedulerTests fail on Chromium Windows (dbg) after r98915
https://bugs.webkit.org/show_bug.cgi?id=71294

Reviewed by James Robinson.

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

12:52 Changeset [98993] by commit-queue@webkit.org

StringImpl::reallocate() should have a 8-bit version
https://bugs.webkit.org/show_bug.cgi?id=71210

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-01
Reviewed by Geoffrey Garen.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::reallocate):

  • wtf/text/StringImpl.h:
12:28 Changeset [98992] by commit-queue@webkit.org

chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71286

Patch by Elliot Poger <epoger@google.com> on 2011-11-01
Reviewed by Stephen White.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
12:24 Changeset [98991] by leandro@webkit.org

[EFL] Unreviewed. Add remaining pixel baselines.

  • platform/efl/http: Added.
  • platform/efl/http/tests: Added.
  • platform/efl/http/tests/local: Added.
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/efl/http/tests/misc: Added.
  • platform/efl/http/tests/misc/acid2-expected.png: Added.
  • platform/efl/http/tests/misc/error404-expected.png: Added.
  • platform/efl/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/efl/http/tests/misc/frame-access-during-load-expected.png: Added.
  • platform/efl/http/tests/misc/generated-content-inside-table-expected.png: Added.
  • platform/efl/http/tests/misc/iframe404-expected.png: Added.
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.png: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/efl/http/tests/navigation: Added.
  • platform/efl/http/tests/navigation/error404-basic-expected.png: Added.
  • platform/efl/http/tests/navigation/error404-goback-expected.png: Added.
  • platform/efl/http/tests/navigation/error404-subframeload-expected.png: Added.
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/efl/http/tests/navigation/postredirect-basic-expected.png: Added.
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.png: Added.
  • platform/efl/http/tests/security: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
  • platform/efl/http/tests/uri: Added.
  • platform/efl/http/tests/uri/css-href-expected.png: Added.
  • platform/efl/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/efl/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/efl/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/efl/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/efl/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/efl/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/efl/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
12:18 Changeset [98990] by alokp@chromium.org

[chromium] Add testing for --enable-accelerated-drawing
https://bugs.webkit.org/show_bug.cgi?id=70822

Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/accelerated-drawing/alpha.html

  • WebCore.exp.in:
  • page/Settings.cpp:
  • page/Settings.h:

(WebCore::Settings::setAcceleratedDrawingEnabled):

  • testing/Internals.cpp:

(WebCore::Internals::setAcceleratedDrawingEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • platform/chromium/compositing/accelerated-drawing: Added.
  • platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Added.
  • platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Added.
  • platform/chromium/compositing/accelerated-drawing/alpha.html: Added.
12:13 Changeset [98989] by timothy_horton@apple.com

SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>

Reviewed by Nikolas Zimmermann.

Call SVGResourcesCache::clientLayoutChanged whenever the element or its children need layout. Previously,
invalidation was only performed if the element itself needed layout; now we also invalidate if any child
needs layout and there is a filter applied, as the cached filter result can depend on the layout of children.

Test: svg/filters/invalidate-on-child-layout.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):

Add a test that ensures that changing the layout of a child of a filtered element invalidates the filter.

  • platform/mac/svg/filters/invalidate-on-child-layout-expected.png: Added.
  • platform/mac/svg/filters/invalidate-on-child-layout-expected.txt: Added.
  • svg/filters/invalidate-on-child-layout.svg: Added.
12:05 Changeset [98988] by jer.noble@apple.com

Four media tests failing on Lion due to incorrect cached times.
https://bugs.webkit.org/show_bug.cgi?id=69574

Reviewed by Eric Carlson.

Source/WebCore:

Do not invalidate the cached time when receiving a mediaPlayerRateChanged notification
while paused. AVFoundation in particular can return different results for currentTime()
when asked after being paused, breaking layout tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

LayoutTests:

Some media engines will cause multiple timeupdate events after pausing; so deregister
the timeupdate event listener after receiving the first one.

  • media/video-pause-immediately.html:
11:54 Changeset [98987] by gavinp@chromium.org

properly end requests when a bad status code return happens
https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.
There is a chromium test going through code review at http://codereview.chromium.org/8404001/

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

11:40 Changeset [98986] by rniwa@webkit.org

Rebaseline after r98896.

  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  • platform/chromium-win-vista/fast/forms: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
11:39 Changeset [98985] by arv@chromium.org

Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
https://bugs.webkit.org/show_bug.cgi?id=64628

Reviewed by Adam Barth.

Covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.idl:
11:37 Changeset [98984] by rniwa@webkit.org

Rebaseline after r98979.

  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  • platform/chromium-win-vista/fast/forms: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
11:30 Changeset [98983] by abecsi@webkit.org

[Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295

Reviewed by Simon Hausmann.

Suppress superfluous debug messages of Qt5.

  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
  • UIProcess/API/qt/tests/util.cpp:

(messageHandler):

  • UIProcess/API/qt/tests/util.h:
11:30 Changeset [98982] by leandro@webkit.org

[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

  • platform/efl/fast/table: [...]
  • platform/efl/fast/text: [...]
  • platform/efl/fast/tokenizer: [...]
  • platform/efl/fast/transforms: [...]
  • platform/efl/fast/writing-mode: [...]
  • platform/efl/fast/xsl: [...]
11:07 Changeset [98981] by imasaki@chromium.org

[Chromium] Unreviewed. Did rebaselines of media/audio-repaint.html

  • platform/chromium-gpu-linux/media/audio-repaint-expected.png:
11:02 Changeset [98980] by jchaffraix@webkit.org

REGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowStruct grid
https://bugs.webkit.org/show_bug.cgi?id=71246

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-empty-section-calcBorder.html

fast/table/crash-empty-section-fixed-layout-calcArray.html

The refactoring in r98738 changed the way we handle the size to avoid throwing off
the memory. The new logic would end up never shrinking the grid's size (prior to that
we would grow to the appropriate size and throw the excess capacity with shrinkToFit).
Not shrinking would mean that we would potentially read RowStruct with the default values
(for instance no |rowRenderer|).

addCell will properly grow the grid as needed to accomodate the rows and the protruding
cells with a rowspan so we introduce a variable to keep track of the size needed. At the
end, we just shrink it to this size.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::recalcCells):
Introduce a variable to keep the grid size and shrink to that size to match the old code.

LayoutTests:

Those tests checks that an empty section would not lead to reading
RowStruct without a |rowRenderer| which would crash.

  • fast/table/crash-empty-section-calcBorder-expected.txt: Added.
  • fast/table/crash-empty-section-calcBorder.html: Added.
  • fast/table/crash-empty-section-fixed-layout-calcArray-expected.txt: Added.
  • fast/table/crash-empty-section-fixed-layout-calcArray.html: Added.
10:59 Changeset [98979] by caseq@chromium.org

Unreviewed followup for the previous commit (removing another duplicate line).

  • platform/chromium/test_expectations.txt:
10:57 Changeset [98978] by caseq@chromium.org

[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
https://bugs.webkit.org/show_bug.cgi?id=71277

Reviewed by Simon Fraser.

Source/WebCore:

Disabled assert() in hasVisibleDescendant() until callers are fixed.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant):

LayoutTests:

  • platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().
10:35 Changeset [98977] by lforschler@apple.com

Merge r98936 and update Versioning.

10:31 Changeset [98976] by arv@chromium.org

Unreviewed. Fix ChangeLog which broke in r98733.

10:19 Changeset [98975] by hausmann@webkit.org

[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
https://bugs.webkit.org/show_bug.cgi?id=71299

Reviewed by Andreas Kling.

Source/WebKit/qt:

Export an overload of QtDRT::injectInternalsObjects that is used by
the WK2 injected bundle.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::injectInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt

build to enable WebCoreTestSupport::injectInternalsObject.
(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
10:11 Changeset [98974] by leandro@webkit.org

[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

  • platform/efl/fast/media: [...]
  • platform/efl/fast/multicol: [...]
  • platform/efl/fast/overflow: [...]
  • platform/efl/fast/parser: [...]
  • platform/efl/fast/reflections: [...]
  • platform/efl/fast/regions: [...]
  • platform/efl/fast/repaint: [...]
  • platform/efl/fast/replaced: [...]
  • platform/efl/fast/ruby: [...]
  • platform/efl/fast/runin: [...]
  • platform/efl/fast/selectors: [...]
10:05 Changeset [98973] by jocelyn.turcotte@nokia.com

[Qt] Merge common desktop and touch view APIs under a base class.
https://bugs.webkit.org/show_bug.cgi?id=71280

Reviewed by Andreas Kling.

Source/WebKit2:

  • Make QDesktopWebView and QTouchWebView inherit from QBaseWebView.
  • Move methods from QTouchWebPage to QTouchWebView (through the base class).

We use the same convenience macros as Qt internally by hiding QObject::d_ptr
with QBaseWebView::d_ptr instead of inheriting QBaseWebViewPrivate from
QQuickItemPrivate.
Also, QBaseWebView currently inherits from QQuickPaintedItem since QDesktopWebView
needs it, but should be changed as soon as this is not required anymore.

  • UIProcess/API/qt/qbasewebview.cpp: Added.

(QBaseWebViewPrivate::QBaseWebViewPrivate):
(QBaseWebViewPrivate::setPageProxy):
(QBaseWebView::QBaseWebView):
(QBaseWebView::~QBaseWebView):
(QBaseWebView::load):
(QBaseWebView::url):
(QBaseWebView::loadProgress):
(QBaseWebView::title):
(QBaseWebView::navigationController):
(QBaseWebView::preferences):

  • UIProcess/API/qt/qbasewebview.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
  • UIProcess/API/qt/qbasewebview_p.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.

(QBaseWebViewPrivate::~QBaseWebViewPrivate):

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
(QDesktopWebViewPrivate::webView):
(QDesktopWebViewPrivate::setViewNeedsDisplay):
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::hasFocus):
(QDesktopWebViewPrivate::isVisible):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeUrl):
(QDesktopWebViewPrivate::didChangeTitle):
(QDesktopWebViewPrivate::didChangeStatusText):
(QDesktopWebViewPrivate::loadDidBegin):
(QDesktopWebViewPrivate::loadDidSucceed):
(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebViewPrivate::init):
(QDesktopWebView::~QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
(QDesktopWebView::pageRef):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
(QDesktopWebViewPrivate::engine):
(QDesktopWebViewPrivate::chooseFiles):
(QDesktopWebViewPrivate::_q_onOpenPanelFilesSelected):
(QDesktopWebViewPrivate::_q_onOpenPanelFinished):
(QDesktopWebViewPrivate::didMouseMoveOverElement):
(QDesktopWebViewPrivate::navigationPolicyForURL):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPageProxy):
(QTouchWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:

(QTouchWebPagePrivate::touchPageProxy):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::QTouchWebView):
(QTouchWebView::~QTouchWebView):
(QTouchWebView::page):
(QTouchWebView::geometryChanged):
(QTouchWebView::onVisibleChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:

(QTouchWebViewPrivate::touchPageProxy):

  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::load):
(WebViewAbstraction::url):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationStatusAtStartup):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::didChangeViewportProperties):
(WebKit::QtTouchViewInterface::didChangeUrl):
(WebKit::QtTouchViewInterface::didChangeTitle):
(WebKit::QtTouchViewInterface::loadDidBegin):
(WebKit::QtTouchViewInterface::loadDidCommit):
(WebKit::QtTouchViewInterface::loadDidSucceed):
(WebKit::QtTouchViewInterface::loadDidFail):
(WebKit::QtTouchViewInterface::didChangeLoadProgress):

  • WebKit2API.pri:

Tools:

Remove unneded forwarding logic for TouchWebView since those properties are
now in the view just as the desktop web view.

  • MiniBrowser/qt/qml/TouchView.qml:
09:51 Changeset [98972] by andersca@apple.com

PluginProxy shouldn't use window-relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71261

Reviewed by Adam Roben.

Change PluginProxy::wantsWindowRelativeCoordinates to return false and remove
m_frameRectInWindowCoordinates and m_clipRectInWindowCoordinates. This is yet another step
towards eliminating window-relative coordinates wherever possible.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Since the dirty rect passed to paint is now in plug-in coordinates, there's no need to convert it
from window coordinates to plug-in coordinates before passing it to BackingStore::paint.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Assert that we're not calling this anymore.

(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return false.

09:45 Changeset [98971] by alokp@chromium.org

Roll chromium DEPS.

Unreviewed.

  • DEPS:
09:28 Changeset [98970] by darin@apple.com

Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
https://bugs.webkit.org/show_bug.cgi?id=71289

Reviewed by Dan Bernstein.

Just adding a null check. I don't have access to an actual PDF with
this problem but crashes from the field indicate they exist.

  • WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument): Skip the code to add the script text
to an array when the script is null.

08:59 Changeset [98969] by reed@google.com

[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
https://bugs.webkit.org/show_bug.cgi?id=71284

Reviewed by Stephen White.

No new tests. This is preparing for an API change to Skia.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):

08:56 Changeset [98968] by leandro@webkit.org

[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

  • platform/efl/fast/html: [...]
  • platform/efl/fast/images: [...]
  • platform/efl/fast/inline-block: [...]
  • platform/efl/fast/inline: [...]
  • platform/efl/fast/innerHTML: [...]
  • platform/efl/fast/inspector-support: [...]
  • platform/efl/fast/invalid: [...]
  • platform/efl/fast/layers: [...]
  • platform/efl/fast/lists: [...]
  • platform/efl/fast/loader: [...]
08:47 Changeset [98967] by andreas.kling@nokia.com

CSSStyleSheet: Operate directly on the rule vector internally.

Rubber-stamped by Antti Koivisto.

There's no need to go through the public, range-checking item() method
working on m_children. Also changed length() -> m_children.size().

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

08:44 Changeset [98966] by caseq@chromium.org

Unreviewed. Fixed conflicting entries in test expectations.

  • platform/chromium/test_expectations.txt:
08:40 Changeset [98965] by kenneth@webkit.org

The QtViewportInteractionEngine should consider DPI adjustment
https://bugs.webkit.org/show_bug.cgi?id=71283

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qtouchwebview.cpp:

Add some default values for now to make sure we are testing the
DPI adjustment / CSS-item space conversion.

(QTouchWebViewPrivate::updateViewportConstraints):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):

Clean up the guard to be more understandable.

(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):

Add methods for converting between CSS and item space.

(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):

Make it clean which methods uses which coord space.

(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemScale):

Rename calculateBoundariesForScale and change its implementation to
be correct. The new name reflects the space in which the computation
takes place and reflects similar Qt API.

(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

Make sure to consider the right coord space.

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::Constraints::Constraints):

Add the devicePixelRatio.

08:32 Changeset [98964] by caseq@chromium.org

Unreviewed. Marked inspector extensions tests as crash on win debug.

  • platform/chromium/test_expectations.txt:
08:23 Changeset [98963] by andreas.kling@nokia.com

CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285

Reviewed by Antti Koivisto.

Move addSubresourceStyleURLs() into the rules that actually implement it.
Add type checks and casts at the (only) call site.

  • css/CSSFontFaceRule.h:
  • css/CSSImportRule.h:
  • css/CSSRule.h:
  • css/CSSStyleRule.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

08:19 Changeset [98962] by cfleizach@apple.com

AX: some popup buttons not announced by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=67743

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Added.
  • platform/mac/accessibility/aria-popup-buttons-on-native-elements.html: Added.
08:16 Changeset [98961] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
08:02 Changeset [98960] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
07:41 Changeset [98959] by hausmann@webkit.org

Prospective clang build fix.

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent): Handle GestureSingleTap in the event type switch.

06:58 Changeset [98958] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix chromium interactive tests.

  • src/js/Tests.js: (.TestSuite.prototype.showPanel):
06:34 Changeset [98957] by caio.oliveira@openbossa.org

[Qt] Create infrastructure for Qt's builtin bundle in web process.
https://bugs.webkit.org/show_bug.cgi?id=71279

Reviewed by Simon Hausmann.

Create a builtin bundle for Qt port: an InjectedBundle which the code is together
with the Qt's web process instead of being in a different library. This gives us
access to many hooks at web process (using WKBundle* functions of C API) without
adding any maintenance burden to cross-port code.

Since we also use a InjectedBundle in the WebKitTestRunner, we only install our
builtin bundle if there's no other installed. This is fine because WTR won't use
the extra runtime features that we plan to provide with the builtin bundle.

  • WebKit2.pro:
  • WebProcess/qt/QtBuiltinBundle.cpp: Added.

(WebKit::QtBuiltinBundle::~QtBuiltinBundle):
(WebKit::QtBuiltinBundle::shared):
(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didCreatePage):
(WebKit::QtBuiltinBundle::willDestroyPage):
(WebKit::QtBuiltinBundle::bundlePageForPageRef):

  • WebProcess/qt/QtBuiltinBundle.h: Added.

(WebKit::QtBuiltinBundle::toRef):
Object that holds a WKBundleRef and keeps track of the pages in the current context.

  • WebProcess/qt/QtBuiltinBundlePage.cpp: Added.

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):

  • WebProcess/qt/QtBuiltinBundlePage.h: Added.

(WebKit::QtBuiltinBundlePage::page):
Our representation for pages from the bundle perspective. This will be the right
place to registering page related clients.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
If there's no bundle to be loaded, initialize Qt builtin bundle, which will register the
bundle client for this context.

06:32 Changeset [98956] by apavlov@chromium.org

Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
https://bugs.webkit.org/show_bug.cgi?id=71275

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):

LayoutTests:

  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
06:09 Changeset [98955] by caseq@chromium.org

Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
05:59 Changeset [98954] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix extensions tests.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel):
05:53 Changeset [98953] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector extensions tests.

  • inspector/extensions/extensions.html:
05:36 Changeset [98952] by pfeldman@chromium.org

Web Inspector: do not switch panels on Cmd + -> while in console.
https://bugs.webkit.org/show_bug.cgi?id=71281

Reviewed by Yury Semikhatsky.

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyDown):

05:34 Changeset [98951] by alexis.menard@openbossa.org

Unreviewed Qt documentation fix.

This signal is Qt 4.8 material.

  • Api/qwebpage.cpp:
04:36 Changeset [98950] by jocelyn.turcotte@nokia.com

check-webkit-style: Allow names starting with "_q_".
https://bugs.webkit.org/show_bug.cgi?id=70625

Reviewed by Tor Arne Vestbø.

Used by the Qt port as the standard prefix for private slots.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
03:35 Changeset [98949] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
03:29 Changeset [98948] by caseq@chromium.org

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
03:17 Changeset [98947] by commit-queue@webkit.org

[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
https://bugs.webkit.org/show_bug.cgi?id=60951

Adjust symbols visibility for WebCore.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-01
Reviewed by Simon Hausmann.

  • WebCore.pro:
03:14 Changeset [98946] by pfeldman@chromium.org

2011-11-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: add InspectorView.js entry into WebKit.qrc

  • inspector/front-end/WebKit.qrc:
03:05 Changeset [98945] by pfeldman@chromium.org

Web Inspector: introduce PanelContainer class, start moving panel management from inspector.js to the new class.
https://bugs.webkit.org/show_bug.cgi?id=71272

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.setVisible):

  • inspector/front-end/InspectorView.js: Added.

(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.currentPanel):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._canGoBackInHistory):
(WebInspector.InspectorView.prototype._goBackInHistory):
(WebInspector.InspectorView.prototype._canGoForwardInHistory):
(WebInspector.InspectorView.prototype._goForwardInHistory):
(WebInspector.InspectorView.prototype._pushToHistory):

  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.eventHasCtrlOrMeta):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.show):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createPanels):
(WebInspector._panelSelected):
(WebInspector.addPanel):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.select):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.expandElementsTree):

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):

  • inspector/debugger/debugger-expand-scope.html:
  • inspector/debugger/debugger-proto-property.html:
  • inspector/debugger/dom-breakpoints.html:
  • inspector/elements/elements-img-tooltip.html:
  • inspector/elements/elements-panel-limited-children.html:
  • inspector/storage-panel-dom-storage.html:
  • inspector/styles/styles-new-API.html:
  • inspector/view-css.html:
  • inspector/view-events.html:
03:02 Changeset [98944] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for fast/ tests.

  • platform/efl/fast/doctypes: [...]
  • platform/efl/fast/dom: [...]
  • platform/efl/fast/dynamic: [...]
  • platform/efl/fast/encoding: [...]
  • platform/efl/fast/events: [...]
  • platform/efl/fast/fast-mobile-scrolling: [...]
  • platform/efl/fast/flexbox: [...]
  • platform/efl/fast/forms: [...]
  • platform/efl/fast/frames: [...]
  • platform/efl/fast/gradients: [...]
02:54 Changeset [98943] by hausmann@webkit.org

[WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEvent::TapType
https://bugs.webkit.org/show_bug.cgi?id=71274

Reviewed by Kenneth Christiansen.

Source/WebCore:

  • features.pri: Enable GESTURE_EVENTS.

Source/WebKit2:

  • Shared/WebEvent.h: Add GestureSingleTap as gesture type.
  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Support converting
WebEven::GestureSingleTap to PlatformGestureEvent::TapType.

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::isGestureEventType): GestureSingleTap is a valid gesture event type.

  • WebKit2.pro: Add WebGestureEvent.cpp to the build.
02:54 Changeset [98942] by hausmann@webkit.org

[Qt][WK2] Fix valgrind error about uninitialized variable
https://bugs.webkit.org/show_bug.cgi?id=71273

Reviewed by Kenneth Christiansen.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify): Initialize isPrimary.

00:35 Changeset [98941] by caseq@chromium.org

Unreviewed gardening (fixed platform qualifiers for visibility-image-layers.html)

  • platform/chromium/test_expectations.txt:
00:24 Changeset [98940] by yurys@chromium.org

Unreviewed, rolling out r98847.
http://trac.webkit.org/changeset/98847
https://bugs.webkit.org/show_bug.cgi?id=71268

"Debugger test failures on multiple platforms" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-01

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

LayoutTests:

  • inspector/debugger/bind-script-to-resource-expected.txt: Removed.
  • inspector/debugger/bind-script-to-resource.html: Removed.
  • inspector/debugger/linkifier-expected.txt:
  • inspector/debugger/linkifier.html:
00:11 Changeset [98939] by yurys@chromium.org

2011-11-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline test started failing because syntax errors in inline handlers
are now reported to console.

window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991

  • fast/js/invalid-syntax-for-function-expected.txt:

10/31/11:

23:52 Changeset [98938] by caseq@chromium.org

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
23:43 Changeset [98937] by fpizlo@apple.com

The GC should be parallel
https://bugs.webkit.org/show_bug.cgi?id=70995

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added parallel tracing to the GC. This works by having local mark
stacks per thread, and a global shared one. Threads sometimes
donate cells from the mark stack to the global one if the heuristics
tell them that it's affordable to do so. Threads that have depleted
their local mark stacks try to steal some from the shared one.

Marking is now done using an atomic weak relaxed CAS (compare-and-swap).

This is a 23% speed-up on V8-splay when I use 4 marking threads,
leading to a 3.5% speed-up on V8.

It also appears that this reduces GC pause times on real websites by
more than half.

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::markRoots):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::~MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::MarkStack::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStackSegment::data):
(JSC::MarkStackSegment::capacityFromSize):
(JSC::MarkStackSegment::sizeFromCapacity):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::mergeOpaqueRootsIfNecessary):
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::canRemoveLast):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::canDonateSomeCells):
(JSC::MarkStackArray::size):
(JSC::ParallelModeEnabler::ParallelModeEnabler):
(JSC::ParallelModeEnabler::~ParallelModeEnabler):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::testAndSetMarked):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::SlotVisitor):

  • heap/WeakReferenceHarvester.h:
  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Bitmap.h:

(WTF::::Bitmap):
(WTF::::get):
(WTF::::set):
(WTF::::testAndSet):
(WTF::::testAndClear):
(WTF::::concurrentTestAndSet):
(WTF::::concurrentTestAndClear):
(WTF::::clear):
(WTF::::clearAll):
(WTF::::nextPossiblyUnset):
(WTF::::findRunOfZeros):
(WTF::::count):
(WTF::::isEmpty):
(WTF::::isFull):

  • wtf/MainThread.h:

(WTF::isMainThreadOrGCThread):

  • wtf/Platform.h:
  • wtf/ThreadSpecific.h:

(WTF::::isSet):

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeGCThreads):
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

Source/WebCore:

Reviewed by Geoff Garen.

Added parallel tracing to the GC. This required loosening some assertions,
since some code may now be called from outside the main thread.

No new tests, since no behavior was changed.

  • platform/TreeShared.h:

(WebCore::TreeShared::parent):

22:43 Changeset [98936] by aestes@apple.com

Document pointer not null-checked in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71265
<rdar://problem/10374427>

Reviewed by Dan Bernstein.

Return false in FrameView::isOnActivePage() if m_frame->document() is
null. Other calls to m_frame->document() in FrameView also have a null
check. The frame can have a null document if the FrameLoader is loading
the initial empty document.

No test possible without triggering assertions in debug builds. This is
tracked by <http://webkit.org/b/71264>.

  • page/FrameView.cpp:

(WebCore::FrameView::isOnActivePage):

21:24 Changeset [98935] by commit-queue@webkit.org

Source/WebCore: Fix a crash relating to anonymous block merging in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

Test: fullscreen/anonymous-block-merge-crash.html

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::unwrapRenderer):

LayoutTests: Test case for a crash relating to merging of anonymous blocks in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

  • fullscreen/anonymous-block-merge-crash.html: Added.
20:37 Changeset [98934] by commit-queue@webkit.org

V8MessageEvent::dataAccessorGetter does not return a reference to its caller
https://bugs.webkit.org/show_bug.cgi?id=71229

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-31
Reviewed by Adam Barth.

Test: fast/events/dispatch-message-string-data.html

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

18:47 Changeset [98933] by reni@webkit.org

[Qt] Build fix after r98853.

Rubber-stamped by Andreas Kling.

  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:

(WebCore::XSLImportRule::parentStyleSheet):

18:15 Changeset [98932] by mhahnenberg@apple.com

De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):

  • runtime/ExceptionHelpers.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defaultValue):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::defaultValue):

  • runtime/JSObject.h:

(JSC::JSObject::toPrimitive):

Source/WebCore:

No new tests.

Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.

  • WebCore.exp.in:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::defaultValue):

  • bridge/runtime_object.h:
18:09 Changeset [98931] by leviw@chromium.org

Switch RoundedRect back to integers
https://bugs.webkit.org/show_bug.cgi?id=71238

Reviewed by Darin Adler.

Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.

No new tests -- no change in behavior.

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):

  • platform/graphics/RoundedRect.h:

(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):

  • rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include
18:06 Changeset [98930] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=70666
BitmapImage::dataChanged() needs to clear all incomplete frames.

Patch by Peter Kasting <pkasting@google.com> on 2011-10-31
Reviewed by James Robinson.

No tests, as I don't know of a way to send an image to the renderer in
small pieces (with script run between pieces no less).

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::dataChanged):

18:01 Changeset [98929] by leviw@chromium.org

Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=71243

Reviewed by Eric Seidel.

Replacing remaining integer uses with LayoutUnits in the aforementioned classes.

No new tests -- no change in behavior.

  • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::intrinsicSize):
(WebCore::RenderApplet::createWidgetIfNecessary):

  • rendering/RenderApplet.h:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::controlClipRect):

  • rendering/RenderButton.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

  • rendering/RenderDeprecatedFlexibleBox.h:
17:59 Changeset [98928] by andersca@apple.com

PluginProxy::Update should pass the painted rect in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71257

Reviewed by Adam Roben.

This is one step in the process of migrating away from window relative coordinates
and use plug-in relative coordinates instead, since window relative coordinates won't work
with transforms.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Convert the dirty rect back to plug-in coordinates.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::update):
No need to convert the painted rect back to plug-in coordinates anymore.

  • WebProcess/Plugins/PluginProxy.messages.in:

Document that the painted rect is in plug-in coordinates.

17:50 Changeset [98927] by aroben@apple.com

Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT

Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
total of N bytes!").

17:43 Changeset [98926] by commit-queue@webkit.org

[Chromium] Media Stream API: add the Chromium WebKit interfaces
https://bugs.webkit.org/show_bug.cgi?id=58550

Source/WebCore:

Changes the PeerHandler platform interface so that embedders can more easily use it.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::didCompleteICEProcessing):
(WebCore::PeerConnection::didGenerateSDP):
(WebCore::PeerConnection::didReceiveDataStreamMessage):
(WebCore::PeerConnection::didAddRemoteStream):
(WebCore::PeerConnection::didRemoveRemoteStream):

  • mediastream/PeerConnection.h:
  • platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.

(WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient):

  • platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.h.
  • platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.

(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):

  • platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerHandler.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

Source/WebKit/chromium:

Adds the bridging code + the minimum amount of Web* supporting code.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • bridge/PeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/PeerHandler.cpp.

(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):

  • bridge/PeerConnectionHandlerInternal.cpp: Added.

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::~PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

  • bridge/PeerConnectionHandlerInternal.h: Added.
  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::createPeerConnectionHandler):

  • public/WebMediaStreamDescriptor.h: Added.

(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::~WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::isNull):

  • public/WebPeerConnectionHandler.h: Added.

(WebKit::WebPeerConnectionHandler::~WebPeerConnectionHandler):

  • public/WebPeerConnectionHandlerClient.h: Added.

(WebKit::WebPeerConnectionHandlerClient::~WebPeerConnectionHandlerClient):

  • src/WebMediaStreamDescriptor.cpp: Added.

(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::reset):
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStreamDescriptor::operator WebCore::MediaStreamDescriptor*):

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

17:39 Changeset [98925] by aroben@apple.com

Fix linker warnings on Windows

  • WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and

JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting
compiled via *AllInOne.cpp files.

17:29 Changeset [98924] by commit-queue@webkit.org

[GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-31
Reviewed by Martin Robinson.

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

17:29 Changeset [98923] by andersca@apple.com

PluginControllerProxy should call Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71255

Reviewed by Sam Weinig.

Pass enough information over in the GeometryDidChange message sent from
PluginProxy to PluginControllerProxy so that PluginControllerProxy can call
Plugin::geometryDidChange.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::invalidate):
(WebKit::PluginControllerProxy::paintEntirePlugin):
Update for rename from m_frameRect to m_frameRectInWindowCoordinates.

(WebKit::PluginControllerProxy::geometryDidChange):
This now takes the plug-in size and the plug-in to root view transform as well.

  • PluginProcess/PluginControllerProxy.h:

Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates.

  • PluginProcess/PluginControllerProxy.messages.in:

Update message signature.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::platformGeometryDidChange):
Use the plug-in size instead of the frame rect size.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:

Add encoder/decoder for WebCore::AffineTransform.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Compute the frame rect in window coordinates and send it over.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange.

17:27 Changeset [98922] by johnnyg@google.com

Unreviewed gardening; bind-script-to-resource.html times out on chromium mac.

  • platform/chromium/test_expectations.txt:
17:27 Changeset [98921] by commit-queue@webkit.org

[chromium] Calling methods of WebFontImpl causes assertions
https://bugs.webkit.org/show_bug.cgi?id=71232

Added FontCachePurgePreventer in several methods.

Patch by Yuzhu Shen <yzshen@google.com> on 2011-10-31
Reviewed by James Robinson.

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::calculateWidth):
(WebKit::WebFontImpl::offsetForPosition):
(WebKit::WebFontImpl::selectionRectForText):
(WebKit::WebFontImpl::estimateTextBounds):

17:21 Changeset [98920] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

  • platform/qt/Skipped: Skip failing tests.
17:18 Changeset [98919] by ossy@webkit.org

Unreviewed, rolling out r98918.
http://trac.webkit.org/changeset/98918
https://bugs.webkit.org/show_bug.cgi?id=71256

Wrong commit (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-31

  • platform/qt/Skipped:
17:10 Changeset [98918] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

  • platform/qt/Skipped: Skip failing tests.
17:01 Changeset [98917] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98673 and r98608.

  • platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
16:57 Changeset [98916] by mhahnenberg@apple.com

Interpreter build fix

Unreviewed build fix

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

16:56 Changeset [98915] by nduca@chromium.org

[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=71100

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCSchedulerFrameRateControllerClientAdapter::create):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::~CCScheduler):
(WebCore::CCScheduler::setNeedsAnimate):
(WebCore::CCScheduler::setNeedsCommit):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didSwapBuffersAbort):
(WebCore::CCScheduler::onBeginFrame):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(WebCore::CCSchedulerStateMachine::redrawPending):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::hasMoreUpdates):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::setUpdateMoreResourcesPending):
(WebCore::StateMachine::updateMoreResourcesPending):
(WebCore::TEST):

  • tests/CCSchedulerTest.cpp:
16:53 Changeset [98914] by lforschler@apple.com

New tag.

16:52 Changeset [98913] by ossy@webkit.org

[Qt] Unreviewed holiday gardening after r98852.

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

  • platform/qt/css1/text_properties/vertical_align-expected.png:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/qt/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/qt/fast/block/float/015-expected.png:
  • platform/qt/fast/block/float/015-expected.txt:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/qt/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/qt/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/qt/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
16:50 Changeset [98912] by fpizlo@apple.com

DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202

Reviewed by Oliver Hunt.

Value profiles now have an extra special slot not used by the old JIT's
profiling, which is reserved for OSR exits.

The DFG's OSR exit code now knows which register, node index, and value
profiling site was responsible for the (possibly flawed) information that
led to the OSR failure. This is somewhat opportunistic and imperfect;
if there's a lot of control flow between the value profiling site and the
OSR failure point, then this mechanism simply gives up. It also gives up
if the OSR failure is caused by either known deficiencies in the DFG
(like that we always assume that the index in a strict charCodeAt access
is within bounds) or where the OSR failure would be catalogues and
profiled through other means (like slow case counters).

This patch also adds the notion of a JSValueRegs, which is either a
single register in JSVALUE64 or a pair in JSVALUE32_64. We should
probably move the 32_64 DFG towards using this, since it often makes it
easier to share code between 64 and 32_64.

Also fixed a number of pathologies that this uncovered. op_method_check
didn't have a value profiling site on the slow path. GetById should not
always force OSR exit if it never executed in the old JIT; we may be
able to infer its type if it's a array or string length get. Finally,
these changes benefit from a slight tweak to optimization delay
heuristics (profile fullness is now 0.35 instead of 0.25).

3.8% speed-up on Kraken, mostly due to ~35% on both stanford-crypto-aes
and imaging-darkroom.

  • bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::specFailBucket):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::jsValueRegs):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):

  • dfg/DFGJITCodeGenerator.h:

(JSC::JSValueOperand::jsValueRegs):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::valueProfileFor):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_method_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_method_check):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/JSValue.h:
16:49 Changeset [98911] by japhet@chromium.org

Rename the remaining uses of Cue in WebCore/loader/
to TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=71231

Reviewed by Eric Carlson.

No new tests, strictly a renaming.

  • loader/TextTrackLoader.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cache/CachedTextTrack.cpp:
  • platform/network/chromium/ResourceRequest.h:
16:46 Changeset [98910] by adamk@chromium.org

[MutationObservers] Support characterDataOldValue for characterData mutations
https://bugs.webkit.org/show_bug.cgi?id=70862

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/CharacterData.cpp:

(WebCore::hasOldValue):
(WebCore::isOldValueRequested):
(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createCharacterData):

  • dom/MutationRecord.h:

LayoutTests:

Added oldValue test cases to existing characterData tests.

  • fast/mutation/observe-characterdata-expected.txt:
  • fast/mutation/observe-characterdata.html:
16:43 Changeset [98909] by weinig@apple.com

Remove need for virtual JSObject::unwrappedObject
https://bugs.webkit.org/show_bug.cgi?id=71034

Reviewed by Geoffrey Garen.

../JavaScriptCore:

Update exports.

Add JSGlobalThis.cpp.

  • runtime/JSGlobalThis.cpp: Added.

(JSC::JSGlobalThis::visitChildren):
(JSC::JSGlobalThis::unwrappedObject):

  • runtime/JSGlobalThis.h:

(JSC::JSGlobalThis::createStructure):
Move underlying object from JSDOMWindowShell down to JSGlobalThis
and corresponding visitChildren method.

  • runtime/JSObject.cpp:

(JSC::JSObject::unwrappedObject):
Change unwrappedObject from virtual, to just needing an if check.

  • runtime/JSObject.h:

(JSC::JSObject::isGlobalThis):

  • runtime/JSType.h:

Add isGlobalThis predicate and type.

../WebCore:

Move the member containing the global object from the JSDOMWindowShell
down to the JSGlobalThis class, and update JSDOMWindowShell to go through
an inline helper (which just casts) to get the window.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):
(WebCore::JSDOMWindowShell::lookupGetter):
(WebCore::JSDOMWindowShell::lookupSetter):
(WebCore::JSDOMWindowShell::impl):

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::createStructure):

16:40 Changeset [98908] by commit-queue@webkit.org

[EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
https://bugs.webkit.org/show_bug.cgi?id=71228

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-31
Reviewed by Antonio Gomes.

Source/WebKit/efl:

r93833 has introduced
ewk_view_setting_scripts_can_close_windows_{get,set}, but its
counterpart to allow scripts to open windows kept its weird name.

This makes the functions to allow windows to open and close windows to
have confusingly different name patterns.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_open_windows_get):
(ewk_view_setting_scripts_can_open_windows_set):

  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

16:38 Changeset [98907] by andersca@apple.com

Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
https://bugs.webkit.org/show_bug.cgi?id=71252

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::pluginBounds):

  • WebProcess/Plugins/PluginProxy.h:
16:34 Changeset [98906] by lforschler@apple.com

Versioning.

16:28 Changeset [98905] by andersca@apple.com

Implement PluginProxy::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71251

Reviewed by Sam Weinig.

Keep track of the plug-in size, the clip rect in plug-in coordinates and the
transformation matrix from the root view to the plug-in.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:
16:19 Changeset [98904] by lforschler@apple.com

Updated fix for r98470.

16:18 Changeset [98903] by commit-queue@webkit.org

WTF::StringImpl::create(const char*, unsigned) calls itself
https://bugs.webkit.org/show_bug.cgi?id=71206

The original implementation just calls itself, causing infinite recursion.
Cast the first parameter to const LChar* to fix that.

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-31
Reviewed by Ryosuke Niwa.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::create):

16:18 Changeset [98902] by johnnyg@google.com

Chromium rebaselines, unreviewed.

  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-gpu-win/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:12 Changeset [98901] by rniwa@webkit.org

Mac rebaseline after r98852.

  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
16:09 Changeset [98900] by commit-queue@webkit.org

IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-31
Reviewed by Darin Fisher.

  • public/WebIDBKey.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebIDBKey.cpp:
16:09 Changeset [98899] by rniwa@webkit.org

WebKit nests pre on copy and paste when the pre is the root editable element
https://bugs.webkit.org/show_bug.cgi?id=70800

Reviewed by Darin Adler.

Source/WebCore:

Fixed the bug by removing nested block elements in removeRedundantStylesAndKeepStyleSpanInline.

Tests: editing/pasteboard/contenteditable-pre-2.html

editing/pasteboard/contenteditable-pre.html

  • editing/ApplyStyleCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Remove block
elements if it's identical to its parent and there are no contents between the two. Also remove
contenteditable attribute from an element if the parent is already richly editable.
(WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles after removing the placeholder
br so that the above check doesn't get affected by the placeholder.

  • editing/htmlediting.cpp:

(WebCore::areIdenticalElements): Moved from ApplyStyleCommand.
(WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp.

  • editing/htmlediting.h:
  • editing/markup.cpp:

LayoutTests:

Added tests for copying and pasting contents inside pre. WebKit should not nest pre's.

  • editing/execCommand/insert-list-with-noneditable-content-expected.txt: A redundant

contenteditable attribute is removed.

  • editing/pasteboard/4930986-2-expected.txt: Trailing space in style attribute is removed.
  • editing/pasteboard/contenteditable-pre-2-expected.txt: Added.
  • editing/pasteboard/contenteditable-pre-2.html: Added.
  • editing/pasteboard/contenteditable-pre-expected.txt: Added.
  • editing/pasteboard/contenteditable-pre.html: Added.
  • editing/pasteboard/copy-null-characters-expected.txt: A redundant contenteditable attribute

is removed.

  • editing/pasteboard/paste-code-in-pre-expected.txt: Pre no longer nests itself erroneously.
  • editing/pasteboard/paste-pre-001-expected.txt: Ditto.
  • editing/pasteboard/paste-pre-002-expected.txt: Ditto.
  • editing/selection/4895428-4-expected.txt: A redundant contenteditable attribute is removed.
16:08 Changeset [98898] by andersca@apple.com

Fix the X11 build.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

16:07 Changeset [98897] by andersca@apple.com

Factor code to resize the plug-in backing store out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=71250

Reviewed by Adam Roben.

Add a PluginProxy::contentsScaleFactor helper function to get rid of a bunch of PLATFORM(MAC) #ifdefs,
and move the code to update the backing store out into a separate function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::contentsScaleFactor):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::update):

  • WebProcess/Plugins/PluginProxy.h:
16:02 Changeset [98896] by commit-queue@webkit.org

text/plain form encoding ignored and incorrectly specified in request header.
https://bugs.webkit.org/show_bug.cgi?id=20795

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-10-31
Reviewed by Darin Adler.

Source/WebCore:

This patch fixes the behaviour of forms where enctype is set to
text/plain, encoding is also text/plain.

Tests: fast/forms/form-get-textplain.html

http/tests/misc/form-post-textplain.html

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • platform/network/FormData.cpp:

(WebCore::FormData::create):
(WebCore::FormData::appendKeyValuePairItems):

  • platform/network/FormData.h:

(WebCore::FormData::parseEncodingType):

  • platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding scheme for text/plain.

  • platform/network/FormDataBuilder.h:

LayoutTests:

Added tests for GET and POST methods for text/plain enctype.
Forms submitted using GET with a content-type of text/plain actually,
send data in URL encoded in the URL.
Forms with POST method and content-type of text/plain actually send data in text/plain.
Modified expected results for mailto tests as per the new behavior.

  • fast/forms/form-get-textplain-expected.txt: Added.
  • fast/forms/form-get-textplain.html: Added.
  • fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
  • http/tests/misc/form-post-textplain-expected.txt: Added.
  • http/tests/misc/form-post-textplain.html: Added.
  • http/tests/misc/resources/form-post-textplain.php: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  • platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
16:00 Changeset [98895] by johnnyg@google.com

RenderImage.cpp calls SVGImage even if it's not defined
https://bugs.webkit.org/show_bug.cgi?id=71247

This fixes a compile error when ENABLE_SVG=0.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::embeddedContentBox):

15:55 Changeset [98894] by jeffm@apple.com

Add more APIs to WKUserContentURLPattern.h
https://bugs.webkit.org/show_bug.cgi?id=71245

Add additional WKUserContentURLPattern APIs to match what was provided by
the equivalent WebKit1 API.

Reviewed by Darin Adler.

  • Shared/API/c/WKUserContentURLPattern.cpp:

(WKUserContentURLPatternCopyHost): Added.
(WKUserContentURLPatternCopyScheme): Added.
(WKUserContentURLPatternIsValid): Added.
(WKUserContentURLPatternMatchesSubdomains): Added.

  • Shared/API/c/WKUserContentURLPattern.h: Added new APIs.


  • Shared/WebUserContentURLPattern.h:

(WebKit::WebUserContentURLPattern::host): Added.
(WebKit::WebUserContentURLPattern::scheme): Added.
(WebKit::WebUserContentURLPattern::isValid): Added.
(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.

15:52 Changeset [98893] by podivilov@chromium.org

Update XMLHttpRequest.send idl declaration to match implementation.
https://bugs.webkit.org/show_bug.cgi?id=71121

Reviewed by Adam Barth.

  • xml/XMLHttpRequest.idl:
15:51 Changeset [98892] by andersca@apple.com

More work on making plug-ins work better with transforms
https://bugs.webkit.org/show_bug.cgi?id=71241

Reviewed by Darin Adler.

Source/WebCore:

Export symbols used by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):
Implement NetscapePlugin::geometryDidChange and store the plug-in size,
the clip rect and the root view transform. Use the transform to compute the window
relative frame and clip rects.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add new member variables.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):
Always call the new Plugin::geometryDidChange.

15:38 Changeset [98891] by commit-queue@webkit.org

Fix DFG JIT compilation on Linux targets.
https://bugs.webkit.org/show_bug.cgi?id=70904

Patch by Andy Wingo <wingo@igalia.com> on 2011-10-31
Reviewed by Darin Adler.

  • jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this

macro.

  • dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the

simplified definition from jit/JITStubs.cpp.
(FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue):
Use the macro to access trampoline targets through the PLT on PIC
systems, instead of introducing a text relocation. Otherwise, the
library fails to link.

15:31 Changeset [98890] by commit-queue@webkit.org

[EFL] Make cache flush when max size of cache has been changed
https://bugs.webkit.org/show_bug.cgi?id=70805

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-31
Reviewed by Ryosuke Niwa.

Calls the ewk_tile_unused_cache_auto_flush function after changing max
size of cache when ewk_tile_unused_cache_max_set is called. Without
this change when new value is lower than the old one the cache may use
more memory than max value set. This situation is not expected by the
user.

  • ewk/ewk_tiled_model.cpp:

(ewk_tile_unused_cache_max_set):

15:24 Changeset [98889] by mhahnenberg@apple.com

De-virtualize JSObject::defineGetter
https://bugs.webkit.org/show_bug.cgi?id=71134

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.

(JSC::DebuggerActivation::defineGetter):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineGetter):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineGetter):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):

Source/WebCore:

No new tests.

Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineGetter):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::defineGetter):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineGetter):
(WebCore::JSLocationPrototype::defineGetter):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

Source/WebKit/qt:

Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.

  • Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):

15:22 Changeset [98888] by commit-queue@webkit.org

Microdata: Support for itemid attribute.
https://bugs.webkit.org/show_bug.cgi?id=71007

Patch by Arko Saha <arko@motorola.com> on 2011-10-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

itemid attribute: To give a global identifier for the Microdata items.
The itemid attribute, if specified, must have a value that is a valid URL potentially
surrounded by spaces.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid

Tests: fast/dom/MicroData/itemid-attribute-test.html

fast/dom/MicroData/itemid-must-see-resolved-url.html

  • html/HTMLElement.idl:

LayoutTests:

Added test-cases for itemid attribute.

  • fast/dom/MicroData/itemid-attribute-test-expected.txt: Added.
  • fast/dom/MicroData/itemid-attribute-test.html: Added.
  • fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Added.
  • fast/dom/MicroData/itemid-must-see-resolved-url.html: Added.
15:13 Changeset [98887] by msaboff@apple.com

Towards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=71138

Restructure and movement of Lexer and Parser code.
Moved Lexer and Parser objects out of JSGlobalData.
Added a new ParserTokens class and instance to JSGlobalData that
have JavaScript token related definitions.
Replaced JSGlobalData arguments to Node classes with lineNumber,
as that was the only use of the JSGlobalData.
Combined JSParser and Parser classes into one class,
eliminating JSParser.h and .cpp.
Various supporting #include changes.

These mostly mechanical changes are done in preparation to
making the Lexer and Parser template classes.

Reviewed by Darin Adler.

(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

  • parser/JSParser.cpp: Removed.
  • parser/JSParser.h: Removed.
  • parser/Lexer.cpp:

(JSC::Keywords::Keywords):
(JSC::Lexer::Lexer):
(JSC::Lexer::~Lexer):
(JSC::Lexer::setCode):
(JSC::Lexer::parseIdentifier):

  • parser/Lexer.h:

(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
(JSC::Keywords::~Keywords):
(JSC::Lexer::setIsReparsing):
(JSC::Lexer::isReparsing):
(JSC::Lexer::lineNumber):
(JSC::Lexer::setLastLineNumber):
(JSC::Lexer::lastLineNumber):
(JSC::Lexer::prevTerminator):
(JSC::Lexer::sawError):
(JSC::Lexer::getErrorMessage):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
(JSC::Lexer::convertHex):
(JSC::Lexer::convertUnicode):
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):

  • parser/NodeConstructors.h:

(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ElementNode::ElementNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyNode::PropertyNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::ArgumentsNode::ArgumentsNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::SourceElements::SourceElements):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::ParameterNode::ParameterNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::CaseClauseNode::CaseClauseNode):
(JSC::ClauseListNode::ClauseListNode):
(JSC::CaseBlockNode::CaseBlockNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):

  • parser/NodeInfo.h:
  • parser/Nodes.cpp:

(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

  • parser/Nodes.h:

(JSC::Node::lineNo):

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::~Parser):
(JSC::Parser::parseInner):
(JSC::Parser::allowAutomaticSemicolon):
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseVarDeclaration):
(JSC::Parser::parseConstDeclaration):
(JSC::Parser::parseDoWhileStatement):
(JSC::Parser::parseWhileStatement):
(JSC::Parser::parseVarDeclarationList):
(JSC::Parser::parseConstDeclarationList):
(JSC::Parser::parseForStatement):
(JSC::Parser::parseBreakStatement):
(JSC::Parser::parseContinueStatement):
(JSC::Parser::parseReturnStatement):
(JSC::Parser::parseThrowStatement):
(JSC::Parser::parseWithStatement):
(JSC::Parser::parseSwitchStatement):
(JSC::Parser::parseSwitchClauses):
(JSC::Parser::parseSwitchDefaultClause):
(JSC::Parser::parseTryStatement):
(JSC::Parser::parseDebuggerStatement):
(JSC::Parser::parseBlockStatement):
(JSC::Parser::parseStatement):
(JSC::Parser::parseFormalParameters):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::Parser::parseExpressionOrLabelStatement):
(JSC::Parser::parseExpressionStatement):
(JSC::Parser::parseIfStatement):
(JSC::Parser::parseExpression):
(JSC::Parser::parseAssignmentExpression):
(JSC::Parser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::Parser::isBinaryOperator):
(JSC::Parser::parseBinaryExpression):
(JSC::Parser::parseProperty):
(JSC::Parser::parseObjectLiteral):
(JSC::Parser::parseStrictObjectLiteral):
(JSC::Parser::parseArrayLiteral):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseArguments):
(JSC::Parser::parseMemberExpression):
(JSC::Parser::parseUnaryExpression):

  • parser/Parser.h:

(JSC::isEvalNode):
(JSC::EvalNode):
(JSC::DepthManager::DepthManager):
(JSC::DepthManager::~DepthManager):
(JSC::ScopeLabelInfo::ScopeLabelInfo):
(JSC::Scope::Scope):
(JSC::Scope::startSwitch):
(JSC::Scope::endSwitch):
(JSC::Scope::startLoop):
(JSC::Scope::endLoop):
(JSC::Scope::inLoop):
(JSC::Scope::breakIsValid):
(JSC::Scope::continueIsValid):
(JSC::Scope::pushLabel):
(JSC::Scope::popLabel):
(JSC::Scope::getLabel):
(JSC::Scope::setIsFunction):
(JSC::Scope::isFunction):
(JSC::Scope::isFunctionBoundary):
(JSC::Scope::declareVariable):
(JSC::Scope::declareWrite):
(JSC::Scope::preventNewDecls):
(JSC::Scope::allowsNewDecls):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::setNeedsFullActivation):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getUncapturedWrittenVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::setStrictMode):
(JSC::Scope::strictMode):
(JSC::Scope::isValidStrictMode):
(JSC::Scope::shadowsArguments):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::ScopeRef::ScopeRef):
(JSC::ScopeRef::operator->):
(JSC::ScopeRef::index):
(JSC::ScopeRef::hasContainingScope):
(JSC::ScopeRef::containingScope):
(JSC::Parser::AllowInOverride::AllowInOverride):
(JSC::Parser::AllowInOverride::~AllowInOverride):
(JSC::Parser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::setPopped):
(JSC::Parser::currentScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::declareWrite):
(JSC::Parser::findCachedFunctionInfo):
(JSC::Parser::isFunctionBodyNode):
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::nextTokenIsColon):
(JSC::Parser::consume):
(JSC::Parser::getToken):
(JSC::Parser::match):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::startLoop):
(JSC::Parser::endLoop):
(JSC::Parser::startSwitch):
(JSC::Parser::endSwitch):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::breakIsValid):
(JSC::Parser::continueIsValid):
(JSC::Parser::pushLabel):
(JSC::Parser::popLabel):
(JSC::Parser::getLabel):
(JSC::Parser::autoSemiColon):
(JSC::Parser::canRecurse):
(JSC::Parser::lastTokenEnd):
(JSC::Parser::DepthManager::DepthManager):
(JSC::Parser::DepthManager::~DepthManager):
(JSC::Parser::parse):
(JSC::parse):

  • parser/ParserTokens.h: Added.

(JSC::JSTokenInfo::JSTokenInfo):

  • parser/SourceCode.h:

(JSC::SourceCode::subExpression):

  • parser/SourceProviderCacheItem.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):

15:07 Changeset [98886] by benjamin@webkit.org

The test input-paste-undo.html needs update to work properly
https://bugs.webkit.org/show_bug.cgi?id=71091

Reviewed by David Kilzer.

Update the test to select the text that needs to be copied
so that it effectively go in the pasteboard on execCommand.

The test now dumps result as text, testing if the height does not
change with the form edition.

  • fast/forms/input-paste-undo-expected.txt: Added.
  • fast/forms/input-paste-undo.html:
  • platform/chromium-linux/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/efl/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/gtk/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/gtk/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/mac/fast/forms/input-paste-undo-expected.png: Removed.
  • platform/mac/fast/forms/input-paste-undo-expected.txt: Removed.
  • platform/qt/fast/forms/input-paste-undo-expected.txt: Removed.
15:03 Changeset [98885] by yurys@chromium.org

window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991

Source/WebCore:

Uncaught syntax errors in inline event handlers are now reported to
window.onerror handler.

Reviewed by Geoffrey Garen.

Tests: fast/events/window-onerror-exception-in-attr.html

fast/events/window-onerror-syntax-error-in-attr.html

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction): report exception as usual
if it happens during event handler compilation.

LayoutTests:

Added a couple of window.onerror tests for the cases when uncaught exception
occurs in inline event handler. Test for non-syntax errors passed before this change
as well and just extends test coverage for window.onerror functionality.

Reviewed by Geoffrey Garen.

  • fast/events/window-onerror-exception-in-attr-expected.txt: Added.
  • fast/events/window-onerror-exception-in-attr.html: Added.
  • fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
  • fast/events/window-onerror-syntax-error-in-attr.html: Added.
  • platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
14:34 Changeset [98884] by johnnyg@google.com

Unreviewed, more expectations changes for svg.

  • platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/overflow: Added.
  • platform/chromium-cg-mac-snowleopard/fast/overflow/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-cg-mac/fast/overflow: Removed.
  • platform/chromium-cg-mac/fast/overflow/003-expected.png: Removed.
  • platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page: Removed.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.txt: Removed.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-mac/fast/overflow/003-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium/svg/zoom: Added.
  • platform/chromium/svg/zoom/page: Added.
  • platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
14:33 Changeset [98883] by eae@chromium.org

Overridden LayoutRect method still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71166

Reviewed by Eric Seidel.

Change all virtual controlClipRect, windowResizerRect, windowClipRect,
visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
localCaretRect functions to have the same signature.

  • page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::windowResizerRect):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderButton.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::visibleContentRect):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localCaretRect):

  • rendering/RenderObject.h:

(WebCore::RenderObject::outlineBoundsForRepaint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):

  • rendering/RenderText.h:
  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

  • rendering/svg/RenderSVGInlineText.h:
14:31 Changeset [98882] by lforschler@apple.com

New tag.

14:24 Changeset [98881] by imasaki@chromium.org

[Chromium] Did rebaselines of media/audio-repaint.html.

Unreviewed.

  • platform/chromium-gpu-linux/media/audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
14:23 Changeset [98880] by lforschler@apple.com

Versioning.

14:07 Changeset [98879] by dslomov@google.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Transfer of MessagePorts implemented.

Reviewed by David Levin.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Some 'FAIL's remain in expected test results. These are due to the fact that
JSC bindings chose not to throw type error exception for non-serializable values -
non-serializable values are serialized as null.

Reviewed by David Levin.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/events/message-port-multi-expected.txt:
14:03 Changeset [98878] by fpizlo@apple.com

REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
https://bugs.webkit.org/show_bug.cgi?id=71227

Reviewed by Oliver Hunt.

No new tests, since while I can see exactly where the DFG went wrong on the
site in question from looking at the generated machine code, and while I can
certainly believe that such a scenario would happen, I cannot visualize how
to make it happen reproducibly. It requires an odd combination of double
values getting spilled and then refilled, but then reboxed at just the right
time so that the spilled value is an unboxed double while the in-register
value is a boxed double.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

13:50 Changeset [98877] by eric@webkit.org

webkitpy tests depend too much on the user's environment
https://bugs.webkit.org/show_bug.cgi?id=71234

Reviewed by Dirk Pranke.

This change just makes a bunch of our older tests use
more modern mocking to avoid trying to launch processes
or read from the user's filesystem during unittesting.

I found many of these by adding an assert in Executive.run_command
that we were not unittesting. I can't add that assert always
as there are some valid uses of Executive during unittesting.
Once I fix more of these, I may find a way to add such an assert conditionally.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
13:31 Changeset [98876] by eae@chromium.org

Change WebKit/WebKit2 to use explicit conversion between FixedRect/Point/Size and the int equivalents. Follow up to change 98869.

13:29 Changeset [98875] by johnnyg@google.com

Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847

  • platform/chromium/test_expectations.txt:
13:25 Changeset [98874] by lforschler@apple.com

Merged r98389.

13:22 Changeset [98873] by andersca@apple.com

Rename a couple of NetscapePlugin and PluginProxy member variables
https://bugs.webkit.org/show_bug.cgi?id=71086

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::deprecatedGeometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::deprecatedGeometryDidChange):
(WebKit::PluginProxy::update):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

12:51 Changeset [98872] by eae@chromium.org

Merging trunk changes up until 98861 into subpixel branch.

12:27 Changeset [98871] by imasaki@chromium.org

Did rebaselines for failing tests for fullscreen layout tests.
https://bugs.webkit.org/show_bug.cgi?id=70512

Reviewed by David Levin.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:
12:09 Changeset [98870] by caseq@chromium.org

Unreviewed. Fixed duplicate lines in test expectations.

  • platform/chromium/test_expectations.txt:
12:06 Changeset [98869] by leviw@chromium.org

Adding explicit FixedRect constructors to IntRect. Previously, FixedRect->IntRect went through FloatRect, which lost precision and caused overflow in some cases. Fixing some scrollbar paint issues on Mac.

11:54 Changeset [98868] by caseq@chromium.org

Unreviewed. More rebaselines after r98852.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png.
  • platform/chromium-cg-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-mac/fast/block/float/015-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png.
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Removed.
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Removed.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Removed.
11:16 Changeset [98867] by leandro@webkit.org

[EFL] Unreviewed. Update Skipped list.

  • platform/efl/Skipped: Reorder test groups so that they appear in a

more logical manner. Add some other tests that are failing since
recent updates.

10:54 Changeset [98866] by caseq@chromium.org

Unreviewed. Marked tests as failing after r98852.

  • platform/chromium/test_expectations.txt:
10:46 Changeset [98865] by johnnyg@google.com

Unreviewed, expectations for fast/js tests.

  • platform/chromium/fast/js/regexp-caching-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:43 Changeset [98864] by carlosgc@webkit.org

[GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball
https://bugs.webkit.org/show_bug.cgi?id=71224

Reviewed by Martin Robinson.

  • GNUmakefile.gtk-doc.am: Copy html and tmpl dirs to

$(distdir)/$(DOC_MODULE).

10:38 Changeset [98863] by caseq@chromium.org

Unreviewed tests rebaseline following r98852.

  • fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-leopard/fast/block/float/015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-cg-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-linux/fast/block/float/015-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-linux/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/015-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png.
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/chromium-win/fast/block/float/015-expected.png:
  • platform/chromium-win/fast/block/float/015-expected.txt:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/chromium-win/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
  • svg/as-background-image/svg-as-background-4-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt.
  • svg/as-image/svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-image/svg-as-relative-image-expected.txt.
  • svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Renamed from LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt.
10:30 Changeset [98862] by leandro@webkit.org

[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.

  • platform/efl/fast/backgrounds: [...]
  • platform/efl/fast/block: [...]
  • platform/efl/fast/body-propagation: [...]
  • platform/efl/fast/borders: [...]
  • platform/efl/fast/box-shadow: [...]
  • platform/efl/fast/canvas: [...]
  • platform/efl/fast/clip: [...]
  • platform/efl/fast/compact: [...]
  • platform/efl/fast/css-generated-content: [...]
  • platform/efl/fast/css: [...]
10:02 Changeset [98861] by andreas.kling@nokia.com

CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223

Reviewed by Antti Koivisto.

Moved insertedIntoParent() down into CSSImportRule and renamed it to
requestStyleSheet(). CSSImportRule is the only user of this function.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::requestStyleSheet):

  • css/CSSImportRule.h:
  • css/CSSRule.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insertRule):

09:35 Changeset [98860] by annacc@chromium.org

Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html

media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Added.
  • media/track/track-load-error-readyState.html: Added.
  • media/track/track-load-from-element-readyState-expected.txt: Added.
  • media/track/track-load-from-element-readyState.html: Added.
  • media/track/track-load-from-src-readyState-expected.txt: Added.
  • media/track/track-load-from-src-readyState.html: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:
09:04 clutter edited by kov@webkit.org
My suggestions (diff)
08:53 Changeset [98859] by andreas.kling@nokia.com

CSSRule: Devirtualize type() and isFooRule()
https://bugs.webkit.org/show_bug.cgi?id=71221

Reviewed by Antti Koivisto.

Store the rule type in a CSSRule member (packed with the parent-is-rule flag)
and let the isFooRule() functions return type() == FOO_TYPE.

CSSPageRule will no longer return true for isStyleRule(), tweaked call sites
accordingly.

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::CSSCharsetRule):

  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):

  • css/CSSFontFaceRule.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):

  • css/CSSImportRule.h:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):

  • css/CSSMediaRule.h:
  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):

  • css/CSSPageRule.h:
  • css/CSSRegionStyleRule.cpp:

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):

  • css/CSSRegionStyleRule.h:
  • css/CSSRule.h:

(WebCore::CSSRule::type):
(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::isImportRule):
(WebCore::CSSRule::CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):

  • css/CSSStyleRule.h:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::CSSUnknownRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):

  • css/WebKitCSSKeyframesRule.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asCSSStyleRule):

08:49 Changeset [98858] by abecsi@webkit.org

[Qt][WK2] Fix qmltests after r98460 added widgets dependency.

Reviewed by Simon Hausmann.

Use QApplication and QtWidgets until we get rid of the widgets dependency of QScroller.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

08:30 clutter edited by tomeu.vizoso@collabora.com
(diff)
08:29 Changeset [98857] by pfeldman@chromium.org

2011-10-31 Pavel Feldman <pfeldman@google.com>

Not reviewed: reorder inspector js files to fix remote mode.

  • inspector/front-end/inspector.html:
08:09 Changeset [98856] by apavlov@chromium.org

Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
https://bugs.webkit.org/show_bug.cgi?id=70936

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.event):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.context.event):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.get proxyElement):
(WebInspector.TextPrompt.prototype.attach):
(WebInspector.TextPrompt.prototype.attachAndStartEditing):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):
(WebInspector.TextPrompt.prototype.get text):
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype._onKeyDown):
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretInsidePrompt):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.isCaretOnFirstLine):
(WebInspector.TextPrompt.prototype.isCaretOnLastLine):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPromptConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.get historyData):
(WebInspector.TextPromptWithHistory.prototype.setHistoryData):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype._pushCurrentText):
(WebInspector.TextPromptWithHistory.prototype._previous):
(WebInspector.TextPromptWithHistory.prototype._next):
(WebInspector.TextPromptWithHistory.prototype._currentHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):

07:32 Changeset [98855] by pfeldman@chromium.org

Web Inspector: move localization support into UIUtil.js, reduce externs.
https://bugs.webkit.org/show_bug.cgi?id=71220

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/compile-front-end.sh:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype.focus):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.afterShow):

  • inspector/front-end/Drawer.js:
  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog.prototype._hide):

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
(WebInspector.HelpScreen.prototype._onBlur):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut._keyName):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._onSearchFieldManualFocus):
(WebInspector.SearchController.prototype._onKeyDown):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype._toolbarDragStart):

  • inspector/front-end/UIUtils.js:

(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.var):
(WebInspector.startEditing):
(WebInspector.UIString):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.platform):
(WebInspector.isMac):
(WebInspector.platformFlavor):
(WebInspector.port):
(WebInspector.installPortStyles):
(WebInspector._windowFocused):
(WebInspector._windowBlurred):
(WebInspector.previousFocusElement):
(WebInspector.currentFocusElement):
(WebInspector._focusChanged):
(WebInspector.setCurrentFocusElement):

  • inspector/front-end/externs.js:

(Event.prototype.initWebKitWheelEvent):
(window.getComputedStyle):
(InspectorBackend.runAfterPendingDispatches):

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):
(WebInspector.addMainEventListeners):

Source/WebKit/chromium:

  • src/js/DevTools.js:
07:15 Changeset [98854] by kenneth@webkit.org

[Qt] MiniBrowser doesn't resize as the size is always overridden
https://bugs.webkit.org/show_bug.cgi?id=71212

Reviewed by Simon Hausmann.

Remove call overriden the size.

  • MiniBrowser/qt/main.cpp:

(main):

07:13 Changeset [98853] by andreas.kling@nokia.com

Kill StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=71218

Reviewed by Antti Koivisto.

Remove the StyleBase class and make all subclasses stand alone. CSSRule and StyleSheet
now inherit from RefCounted<T> instead, and XSLImportRule doesn't even need that,
so StyleBase is replaced by nothing.

  • css/StyleBase.cpp:
  • css/StyleBase.h:

Removed.

  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::~CSSRule):
(WebCore::CSSRule::useStrictParsing):
(WebCore::CSSRule::setParentStyleSheet):
(WebCore::CSSRule::setParentRule):
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
(WebCore::CSSRule::baseURL):
(WebCore::CSSRule::CSSRule):

CSSRule now inherits directly from RefCounted, and has either a CSSRule or a
CSSStyleSheet as its parent. Made these getters/setters inline since they are
trivial now.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Purge StyleBase.* from the build systems.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

New root() functions for CSSRule and StyleSheet.

  • bindings/js/JSNodeCustom.h:

Remove StyleBase.h include.

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::parentStyleSheet):

Added CSS-specific parentStyleSheet() so we don't have to cast it to a
CSSStyleSheet* at the call sites.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):

  • css/StyleSheet.h:

(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):
(WebCore::StyleSheet::isCSSStyleSheet):
(WebCore::StyleSheet::isXSLStyleSheet):

StyleSheet now inherits directly from RefCounted and always has a parent CSSRule
though it can be null. parentStyleSheet() returns that rule's parent style sheet.
Moved the relevant guts from StyleBase down here.

  • loader/cache/CachedStyleSheetClient.h:

Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedResourceClient.

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::parentStyleSheet):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):

  • xml/XSLImportRule.h:

(WebCore::XSLImportRule::create):
(WebCore::XSLImportRule::setParentStyleSheet):

Remove inheritance from StyleBase, and have create() return a PassOwnPtr instead.
This is fine, since XSLStyleSheet is the only object that ever manages these rules.

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedIntoDocument):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore::CSSStyleSheet::document):
(WebCore::CSSStyleSheet::styleSheetChanged):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::insertedIntoParent):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):

  • css/CSSRegionStyleRule.cpp:

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

  • css/CSSStyleDeclaration.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::append):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::parentStyleSheet):

  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::checkLoaded):
(WebCore::XSLStyleSheet::loadChildSheet):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

Use the new, more explicit, parenting functions of StyleSheet.

07:07 Changeset [98852] by zimmermann@webkit.org

2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

Reviewed by Antti Koivisto.

Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

  • css2.1/20110323/background-intrinsic-001.htm: Added.
  • css2.1/20110323/background-intrinsic-002.htm: Added.
  • css2.1/20110323/background-intrinsic-003.htm: Added.
  • css2.1/20110323/background-intrinsic-004.htm: Added.
  • css2.1/20110323/background-intrinsic-005.htm: Added.
  • css2.1/20110323/background-intrinsic-006.htm: Added.
  • css2.1/20110323/background-intrinsic-007.htm: Added.
  • css2.1/20110323/background-intrinsic-008.htm: Added.
  • css2.1/20110323/background-intrinsic-009.htm: Added.
  • css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width.svg: Added.
  • fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
  • fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
  • fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
  • platform/mac/fast/block/float/015-expected.txt: Ditto.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
  • svg/as-background-image/background-image-tiled.html: Added.
  • svg/as-background-image/resources/construction-tape.svg: Added.
  • svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
  • svg/as-background-image/same-image-two-instances-background-image.html: Added.
  • svg/as-image/img-preserveAspectRatio-support-1.html: Added.
  • svg/as-image/resources/circle-default-meet.svg: Added.
  • svg/as-image/resources/circle-default-none.svg: Added.
  • svg/as-image/resources/circle-default-slice.svg: Added.
  • svg/as-image/resources/circle-nosize.svg: Added.
  • svg/as-image/resources/circle-viewbox-default.svg: Added.
  • svg/as-image/resources/circle-viewbox-meet.svg: Added.
  • svg/as-image/resources/circle-viewbox-none.svg: Added.
  • svg/as-image/resources/circle-viewbox-slice.svg: Added.
  • svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
  • svg/as-image/same-image-two-instances.html: Added.
  • svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
  • svg/as-image/svg-image-change-content-size.xhtml: Added.
  • svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
  • svg/zoom/page/zoom-background-image-tiled.html: Added.
  • svg/zoom/page/zoom-background-images.html: Added.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.
  • svg/zoom/page/zoom-svg-as-image.html: Added.
  • svg/zoom/page/zoom-svg-as-relative-image.html: Added.

2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

SVGs do not work as tiled background images
https://bugs.webkit.org/show_bug.cgi?id=16281

Apply preserveAspectRatio and synthesize viewboxes in <img>
https://bugs.webkit.org/show_bug.cgi?id=34521

SVG background doesn't resize properly when dimensions are changed
https://bugs.webkit.org/show_bug.cgi?id=42944

Images with percent height inside a floated div should use intrinsic height.
https://bugs.webkit.org/show_bug.cgi?id=45439

SVG image in HTML changes size as the window is resized
https://bugs.webkit.org/show_bug.cgi?id=52045

Reviewed by Antti Koivisto.

Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

Tests: css2.1/20110323/background-intrinsic-001.htm

css2.1/20110323/background-intrinsic-002.htm
css2.1/20110323/background-intrinsic-003.htm
css2.1/20110323/background-intrinsic-004.htm
css2.1/20110323/background-intrinsic-005.htm
css2.1/20110323/background-intrinsic-006.htm
css2.1/20110323/background-intrinsic-007.htm
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
svg/as-image/same-image-two-instances.html
svg/as-image/svg-as-relative-image-with-explicit-size.html
svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
svg/zoom/page/zoom-svg-as-image.html
svg/zoom/page/zoom-svg-as-relative-image.html

  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor. (WebCore::CSSImageGeneratorValue::getImage): Ditto.
  • loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed. (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize(). (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache. (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer. (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter.
  • loader/cache/CachedImage.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
  • platform/graphics/Image.h: (WebCore::Image::setImageObserver): Add helper.
  • rendering/ImageBySizeCache.cpp: Cleanup code. (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid. (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage. (WebCore::ImageBySizeCache::getImage): Add zoom parameter. (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get requested size from cache, instead of actual cached sizes. (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting. (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
  • rendering/ImageBySizeCache.h: Cleaup code, introduce struct that replaces the std::pair<IntSize, int>. (WebCore::SizeZoomAndCount::SizeZoomAndCount):
  • rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images. (WebCore::resolveWidthForRatio): New inline helper function used by calculateImageIntrinsicDimensions. (WebCore::resolveHeightForRatio): Ditto. (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. (WebCore::resolveAgainstIntrinsicRatio): Ditto. (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec. (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer(). (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
  • rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0). (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged(). (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded(). (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct. (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages. (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null. (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
  • rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
  • rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
  • rendering/RenderImageResourceStyleImage.cpp: (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending. (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed. (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter.
  • rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
  • rendering/style/StyleImage.h: Ditto.
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
  • rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages). (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now. (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
  • rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::containerSize): (WebCore::RenderSVGRoot::setContainerSize):
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
  • svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement. (WebCore::SVGSVGElement::SVGSVGElement): Ditto. (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
  • svg/SVGSVGElement.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage. (WebCore::SVGImage::createWithDataAndSize): Add new helper function. (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor. (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size. (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement. (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs. (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document. (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation. (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
  • svg/graphics/SVGImage.h:
07:04 QtWebKitForQt5 edited by hausmann@webkit.org
(diff)
06:51 Changeset [98851] by caio.oliveira@openbossa.org

[Qt] Make QWebPreferences hold a QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=71219

Reviewed by Andreas Kling.

Change QWebPreferences to keep a pointer to QtWebPageProxy. The reason is that
some features we want to control (like the messaging exchange between WebView and
the web process) are not available via WKPreferencesRef.

QtWebPageProxy now uses an OwnPtr to keep the QWebPreferences to clarify the
ownership relationship. Before this change the QWebPreferences created was leaking.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferencesRef):

  • UIProcess/API/qt/qwebpreferences.h:
  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::preferences):

  • UIProcess/qt/QtWebPageProxy.h:
05:45 Changeset [98850] by yurys@chromium.org

2011-10-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end
files on Qt.

  • inspector/front-end/WebKit.qrc:
05:28 Changeset [98849] by vsevik@chromium.org

Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT.

  • platform/qt/Skipped:
05:00 Changeset [98848] by caseq@chromium.org

Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.

  • platform/chromium/test_expectations.txt:
04:55 Changeset [98847] by pfeldman@chromium.org

Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/bind-script-to-resource.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Script.js:

LayoutTests:

  • inspector/debugger/bind-script-to-resource-expected.txt: Added.
  • inspector/debugger/bind-script-to-resource.html: Added.
  • inspector/debugger/linkifier.html:
04:55 Changeset [98846] by carlosgc@webkit.org

[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71111

Reviewed by Martin Robinson.

Convenient method to create a WebKitSettings object with initial
settings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_new_with_settings):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsNewWithSettings):
(beforeAll):

04:45 Changeset [98845] by carlosgc@webkit.org

[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add WebKitSettingsPrivate.h.
  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkitSettingsAttachSettingsToPage): Set the preferences of the
given WebKitSettings object to the page group of the given WKPage.

  • UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Create the default WebKitSettings for
the view.
(webkit_web_view_set_settings):
(webkit_web_view_get_settings):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSettings):
(beforeAll):

04:23 Changeset [98844] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71012
Use StringHasher to generate the matched declaration cache hash

Reviewed by Sam Weinig.

Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):

  • css/CSSStyleSelector.h:
03:28 Changeset [98843] by caseq@chromium.org

Unreviewed.
Removed Mac10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
03:26 Changeset [98842] by carlosgc@webkit.org

Unreviewed. Fix make distcheck build.

Source/WebCore:

  • GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and

EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST.

Source/WebKit2:

  • GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST,

since its generation was removed from configure.ac in r98498.

02:35 Changeset [98841] by caseq@chromium.org

Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.

  • platform/chromium/test_expectations.txt:
02:18 Changeset [98840] by pfeldman@chromium.org

Web Inspector: factor out ResourceUtils, clean up externs.
https://bugs.webkit.org/show_bug.cgi?id=71192

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-31
Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:

(WebInspector.Resource.displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._createResource):

  • inspector/front-end/ResourceUtils.js: Added.

(WebInspector.resourceForURL):
(WebInspector.forAllResources):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.registerLinkifierPlugin):
(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyURL):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
(WebInspector.populateHrefContextMenu):
(WebInspector.completeURL):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.selectElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.networkResourceById):

  • inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.selectionLeftOffset):

01:37 Changeset [98839] by apavlov@chromium.org

Web Inspector: Using keyboard to increment/decrement units is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=71119

Reviewed by Pavel Feldman.

Source/WebCore:

This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.prototype._attributesModified):

LayoutTests:

  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:
01:28 Changeset [98838] by caseq@chromium.org

Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.

  • platform/chromium/test_expectations.txt:
00:48 Changeset [98837] by abarth@webkit.org

[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed
https://bugs.webkit.org/show_bug.cgi?id=71205

Reviewed by Ryosuke Niwa.

WebKit style is to use the implicit Boolean conversions rather than
calling get() on these pointer types. This patch cleans up most (all?)
of these style issues in the Chromium port in the hopes that they'll be
copy/pasted less in the future.

  • src/ApplicationCacheHostInternal.h:

(WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::setMainDocumentError):
(WebKit::FrameLoaderClientImpl::committedLoad):
(WebKit::FrameLoaderClientImpl::finishedLoading):
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::postMessageToRemote):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::hitTest):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::characterIndexForPoint):
(WebKit::WebFrameImpl::selectionAsText):
(WebKit::WebFrameImpl::selectionAsMarkup):
(WebKit::WebFrameImpl::getPrintPageShrink):
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printEnd):
(WebKit::WebFrameImpl::scopeStringMatches):

  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::type):

  • src/WebIDBKeyRange.cpp:

(WebKit::WebIDBKeyRange::lower):
(WebKit::WebIDBKeyRange::upper):
(WebKit::WebIDBKeyRange::lowerOpen):
(WebKit::WebIDBKeyRange::upperOpen):

  • src/WebImageCG.cpp:

(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::cancelLoad):
(WebKit::WebMediaPlayerClientImpl::play):
(WebKit::WebMediaPlayerClientImpl::pause):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
(WebKit::WebMediaPlayerClientImpl::naturalSize):
(WebKit::WebMediaPlayerClientImpl::hasVideo):
(WebKit::WebMediaPlayerClientImpl::hasAudio):
(WebKit::WebMediaPlayerClientImpl::setVisible):
(WebKit::WebMediaPlayerClientImpl::duration):
(WebKit::WebMediaPlayerClientImpl::currentTime):
(WebKit::WebMediaPlayerClientImpl::seek):
(WebKit::WebMediaPlayerClientImpl::seeking):
(WebKit::WebMediaPlayerClientImpl::setEndTime):
(WebKit::WebMediaPlayerClientImpl::setRate):
(WebKit::WebMediaPlayerClientImpl::paused):
(WebKit::WebMediaPlayerClientImpl::supportsFullscreen):
(WebKit::WebMediaPlayerClientImpl::supportsSave):
(WebKit::WebMediaPlayerClientImpl::setVolume):
(WebKit::WebMediaPlayerClientImpl::networkState):
(WebKit::WebMediaPlayerClientImpl::readyState):
(WebKit::WebMediaPlayerClientImpl::maxTimeSeekable):
(WebKit::WebMediaPlayerClientImpl::buffered):
(WebKit::WebMediaPlayerClientImpl::dataRate):
(WebKit::WebMediaPlayerClientImpl::totalBytesKnown):
(WebKit::WebMediaPlayerClientImpl::totalBytes):
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
(WebKit::WebMediaPlayerClientImpl::setSize):
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
(WebKit::WebMediaPlayerClientImpl::setPreload):
(WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin):
(WebKit::WebMediaPlayerClientImpl::movieLoadType):
(WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
(WebKit::WebMediaPlayerClientImpl::decodedFrameCount):
(WebKit::WebMediaPlayerClientImpl::droppedFrameCount):
(WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::startDelayedLoad):

  • src/WebURLRequest.cpp:

(WebKit::WebURLRequest::extraData):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::theme):
(WebKit::WebViewImpl::mainFrameImpl):
(WebKit::WebViewImpl::tabKeyCyclesThroughElements):
(WebKit::WebViewImpl::hideSelectPopup):
(WebKit::WebViewImpl::popupClosed):
(WebKit::WebViewImpl::focusedWebCoreFrame):
(WebKit::WebViewImpl::close):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::caretOrSelectionRange):
(WebKit::WebViewImpl::settings):
(WebKit::WebViewImpl::pageEncoding):
(WebKit::WebViewImpl::setPageEncoding):
(WebKit::WebViewImpl::setInitialFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::copyImageAt):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragLeave):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
(WebKit::WebViewImpl::inspectElementAt):
(WebKit::WebViewImpl::applyAutofillSuggestions):

  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::postMessageTask):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

00:10 Changeset [98836] by vangelis@chromium.org

Add missing declaration in WebSettings.h
https://bugs.webkit.org/show_bug.cgi?id=71165

Reviewed by Darin Fisher.

  • public/WebSettings.h:

10/30/11:

19:50 Changeset [98835] by yutak@chromium.org

WebSocket: iframe in reload-crash.html reloads forever
https://bugs.webkit.org/show_bug.cgi?id=71098

Reviewed by Kent Tamura.

iframe in this test should not get reloaded more than once.

  • http/tests/websocket/tests/hixie76/reload-crash.html:

Provide the value of reloadCount to the script in iframe.

  • http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html:

Call location.reload() only if reloadCount is zero.

  • http/tests/websocket/tests/hybi/reload-crash.html:
  • http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html:
18:50 Changeset [98834] by fpizlo@apple.com

JSParser::parsePrimaryExpression should have an overflow check
https://bugs.webkit.org/show_bug.cgi?id=71197

Reviewed by Geoff Garen.

  • parser/JSParser.cpp:

(JSC::JSParser::parsePrimaryExpression):

18:43 Changeset [98833] by commit-queue@webkit.org

Unreviewed, rolling out r98819, r98823, r98825, and r98830.
http://trac.webkit.org/changeset/98819
http://trac.webkit.org/changeset/98823
http://trac.webkit.org/changeset/98825
http://trac.webkit.org/changeset/98830
https://bugs.webkit.org/show_bug.cgi?id=71199

Broke Chromium Windows bot (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
17:21 Changeset [98832] by fpizlo@apple.com

DFG ValueAdd(string, int) should not fail speculation
https://bugs.webkit.org/show_bug.cgi?id=71195

Reviewed by Geoff Garen.

1% speed-up on V8.

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):

15:47 Changeset [98831] by fpizlo@apple.com

The DFG inliner should not flush the callee
https://bugs.webkit.org/show_bug.cgi?id=71191

Reviewed by Oliver Hunt.

0.6% speed-up on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeOrigin.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrameSlow):

15:42 Changeset [98830] by eric@webkit.org

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
15:06 Changeset [98829] by rik@webkit.org

Add Peter Beverloo's feed to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

  • config.ini:
12:34 Changeset [98828] by rniwa@webkit.org

Remove crash expectations from tests that have not been crashing on Chromium.

  • platform/chromium/test_expectations.txt:
09:29 Changeset [98827] by mrobinson@webkit.org

[GTK] Switch to a backing store approach for painting WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

  • platform/cairo/WidgetBackingStore.h:

(WebCore::WidgetBackingStore::size): Added this getter for the size.

  • platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.

  • platform/graphics/cairo/CairoUtilities.h:
  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.

  • WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use

the WebCore namespace to avoid lots of uses of "WebCore::".

  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.

  • webkit/webkitwebviewprivate.h: Add the backing store member.
09:03 Changeset [98826] by commit-queue@webkit.org

Unreviewed, rolling out r98803.
http://trac.webkit.org/changeset/98803
https://bugs.webkit.org/show_bug.cgi?id=71186

Causing test and assertion failures on some platforms
(Requested by anttik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyMatchedDeclarations):

00:57 Changeset [98825] by eric@webkit.org

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed. I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.

This was a regression from moving to a clean environment.
ChromiumWin (and possibly other ports), need the "PATH"
environment copied over. This wasn't caught in my testing
because although we had unittests to cover this, they
weren't being run on anything but windows. The vast majority
of this change is just fixing the unittests to use our
modern MockFileSystem/MockUser/MockExecutive so they can
be run on any system (and removing the platform checks from
the unittests so they are run everywhere).

The actual fix is the single line "PATH" string added to base.py.
The rest of this change is just fixing the Chromium port unittests
to run on all systems (including changing the Chromium port to
use FileSystem.path_to_module instead of file).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
Note: See TracTimeline for information about the timeline view.