Timeline


and

11/08/11:

23:58 Changeset [99659] by abarth@webkit.org

Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
https://bugs.webkit.org/show_bug.cgi?id=71755

Reviewed by Eric Seidel.

Source/WebCore:

The SecurityOrigin class should be focused on representing a web
security origin rather than being a dumping ground for all
security-related state. This patch moves a bunch of static "policy"
state into its own SecurityPolicy class.

  • WebCore.exp.in:
  • WebCore.gypi:
  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canRequest):
(WebCore::SecurityOrigin::canDisplay):
(WebCore::SecurityOrigin::grantLoadLocalResources):

  • page/SecurityOrigin.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setReferrerForRequest):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::addOriginAccessWhitelistEntry):
(WebKit::WebSecurityPolicy::removeOriginAccessWhitelistEntry):
(WebKit::WebSecurityPolicy::resetOriginAccessWhitelists):
(WebKit::WebSecurityPolicy::shouldHideReferrer):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::initializeMainFrame):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::whiteListAccessFromOrigin):
(DumpRenderTreeSupportGtk::resetOriginAccessWhiteLists):

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::removeWhiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):

Source/WebKit/win:

  • WebView.cpp:

(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::removeOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::resetOriginAccessWhitelists):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

23:55 Changeset [99658] by yutak@chromium.org

[Chromium] Unreviewed, land correct expectations for Kusa-Makura-background-canvas.html.
The background color of this test should be white, not transparent.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
23:41 Changeset [99657] by yutak@chromium.org

[Chromium] Unreviewed, fix expectation conflict in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
23:23 Changeset [99656] by ossy@webkit.org

[Qt] Unreviewed morning gardening. Update platform specific expected results.

  • platform/qt/fast/forms/listbox-clip-expected.png:
  • platform/qt/test_expectations.txt:
23:22 Changeset [99655] by philn@webkit.org

Unreviewed, GTK rebaseline after r99539.

  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
23:18 Changeset [99654] by ossy@webkit.org

[Qt] Unreviewed morning gardening. Update platform specific expected results.

  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
23:11 Changeset [99653] by commit-queue@webkit.org

Default <select multiple> expands up to 10 items instead of showing 4.
https://bugs.webkit.org/show_bug.cgi?id=70765

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-08
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/forms/select-clientheight-large-size.html

fast/forms/select-clientheight-with-multiple-attr.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::size):

LayoutTests:

  • fast/forms/select-clientheight-large-size-expected.txt: Added.
  • fast/forms/select-clientheight-large-size.html: Added.
  • fast/forms/select-clientheight-with-multiple-attr-expected.txt: Added.
  • fast/forms/select-clientheight-with-multiple-attr.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/forms/listbox-clip-expected.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
22:41 Changeset [99652] by ossy@webkit.org

Unreviewed, rolling out r99647.
http://trac.webkit.org/changeset/99647
https://bugs.webkit.org/show_bug.cgi?id=71876

It broke jsc and layout tests on all bot (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-08

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsDoubleBitops):
(JSC::MacroAssemblerARM::andnotDouble):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsDoubleBitops):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::andnotDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsDoubleBitops):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsDoubleBitops):
(JSC::MacroAssemblerSH4::andnotDouble):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::MacroAssemblerX86):
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsDoubleBitops):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::andnotDouble):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsDoubleBitops):

  • assembler/X86Assembler.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

  • runtime/JSGlobalData.cpp:
21:47 Core Builders edited by abarth@webkit.org
(diff)
21:46 Core Builders edited by abarth@webkit.org
(diff)
21:46 Core Builders edited by abarth@webkit.org
(diff)
21:44 Changeset [99651] by hayato@chromium.org

[NRWT] Make single_test_runner aware of reference filename of test_input.
https://bugs.webkit.org/show_bug.cgi?id=71567

Reviewed by Ryosuke Niwa.

Make single_test_runner honor a reference filename of given test_input so that
we can use any file as reference html, instead of depending on implicit naming convention.
The typical use case is to support w3c reftests.

No tests since no functional changes until there is a client.
Test should be easily written with future clients.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/models/test_failures.py:
  • Scripts/webkitpy/layout_tests/models/test_input.py:
21:44 Core Builders edited by abarth@webkit.org
(diff)
21:44 Core Builders created by abarth@webkit.org
20:20 Changeset [99650] by mrobinson@webkit.org

Take another stab at fixing the GTK+ build.

  • Source/autotools/symbols.filter: The symbols.filter file was missing a semicolon.
20:17 Changeset [99649] by cevans@google.com

Crash accessing font fact rule parent
https://bugs.webkit.org/show_bug.cgi?id=71860

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/css-fontface-rule-crash.html

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule): tell our child rule when we are going away.

LayoutTests:

  • fast/css/css-fontface-rule-crash-expected.txt: Added.
  • fast/css/css-fontface-rule-crash.html: Added.
  • resources/gc.js: Added. Add a re-usable best-of-breed gc().
20:03 Changeset [99648] by nduca@chromium.org

[chromium] When GC3DPrivate::initializExtensions fails, dont keep retrying
https://bugs.webkit.org/show_bug.cgi?id=71637

Reviewed by Kenneth Russell.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::initializeExtensions):

19:02 Changeset [99647] by barraclough@apple.com

Better abstract 'abs' operation through the MacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Currently the x86 specific instruction sequence to perform a double abs
is duplicated throughout the JITs / thunk generators.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):
(JSC::MacroAssemblerARM::absDouble):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::absDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
(JSC::MacroAssemblerSH4::absDouble):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::absDouble):
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):

  • Made supports* methods static so that we can check the JIT's capabilites before we begin compilation. Added absDouble.
  • assembler/MacroAssemblerX86Common.h:
    • Removed andnotDouble, added s_maskSignBit.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::absDouble):
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):

  • Made supports* methods static so that we can check the JIT's capabilites before we begin compilation. Added absDouble.
  • assembler/X86Assembler.h:

(JSC::X86Assembler::andpd_rr):
(JSC::X86Assembler::andpd_mr):

  • Added support for andpd instruction.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • Added checks for supportsFloatingPointAbs, supportsFloatingPointSqrt.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Switched to use doubleAbs, we can now also reuse the operand register for the result.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Switched to use doubleAbs, we can now also reuse the operand register for the result.
  • jit/ThunkGenerators.cpp:
    • Switched to use doubleAbs.

(JSC::absThunkGenerator):

  • runtime/JSGlobalData.cpp:
    • Declared MacroAssemblerX86Common::s_maskSignBit here. This is a little ugly, but it doesn't seem worth adding a whole extra .cpp to the compile for just one constant.
18:50 Changeset [99646] by dbates@webkit.org

Attempt to fix the GTK build after <http://trac.webkit.org/changeset/99613>
(https://bugs.webkit.org/show_bug.cgi?id=71840)

  • Source/autotools/symbols.filter: Add symbol _ZN7WebCore4Page13setPaginationERKNS0_10PaginationE.
17:51 Changeset [99645] by adamk@chromium.org

Use a typedef for ExceptionCode in all header files instead of including ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=71845

Reviewed by Adam Barth.

Source/WebCore:

Some headers in WebCore include ExceptionCode.h to get the ExceptionCode typedef,
while others provide the typedef themselves. Per Darin, the latter is preferred,
so this patch updates all references, and fixes up .cpp files that
need the include in order to access the enum.

  • bindings/js/JSSVGLengthCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): #include ExceptionCode.h when needed for SVG.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation): #include ExceptionCode.h when needed for SVG.

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • css/WebKitCSSMatrix.h:
  • fileapi/DirectoryReaderSync.h:
  • fileapi/EntrySync.h:
  • fileapi/FileReader.h:
  • fileapi/FileReaderSync.h:
  • fileapi/SyncCallbackHelper.h:
  • html/ClassList.h:
  • html/DOMSettableTokenList.h:
  • html/DOMTokenList.cpp:
  • html/DOMTokenList.h:
  • html/TextTrack.cpp:
  • html/TextTrack.h:
  • html/TimeRanges.cpp:
  • html/TimeRanges.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.h:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.h:
  • html/canvas/OESVertexArrayObject.h:
  • html/canvas/WebGLDebugShaders.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • mediastream/MediaStreamFrameController.cpp:
  • mediastream/MediaStreamFrameController.h:
  • notifications/Notification.h:
  • notifications/NotificationCenter.h:
  • storage/AbstractDatabase.cpp:
  • storage/AbstractDatabase.h:
  • storage/Database.h:
  • storage/DatabaseSync.h:
  • storage/DatabaseTask.h:
  • storage/IDBCursor.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/SQLResultSet.cpp:
  • storage/SQLResultSet.h:
  • storage/SQLStatementSync.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.h:
  • svg/ElementTimeControl.h:
  • svg/SVGAngle.cpp:
  • svg/SVGAngle.h:
  • svg/SVGLength.cpp:
  • svg/SVGLength.h:
  • svg/SVGLengthContext.cpp:
  • svg/SVGLengthContext.h:
  • svg/SVGLocatable.h:
  • svg/SVGMatrix.h:
  • svg/SVGPreserveAspectRatio.cpp:
  • svg/SVGPreserveAspectRatio.h:
  • testing/Internals.h:
  • webaudio/AudioContext.cpp:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:
17:50 Changeset [99644] by lforschler@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71839
Update the leaks bot OS to Lion.
Update the config.json to reflect the update.

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
17:40 Changeset [99643] by barraclough@apple.com

Move duplicates of SYMBOL_STRING* macros to the single location
https://bugs.webkit.org/show_bug.cgi?id=71456

Reviewed by Sam Weinig.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:
  • wtf/InlineASM.h: Added.
    • Moved asm related macros.
17:15 Changeset [99642] by bfulgham@webkit.org

[WinCairo] Unreviewed skiplist update to match main Windows
build, and to skip a few failures.

  • platform/wincairo/Skipped: Updated.
17:14 Changeset [99641] by haraken@chromium.org

CodeGeneratorV8.pm can generate a NamedConstructor
https://bugs.webkit.org/show_bug.cgi?id=71756

Reviewed by Adam Barth.

  • IDLParser.pm can parse [NamedConstructor] IDL.
  • CodeGeneratorV8.pm can generate a NamedConstructor

and a template getter for the NamedConstructor.

  • Added a new binding test named TestNamedConstructor.idl.

Tests: WebCore/bindings/scripts/test/TestNamedConstructor.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Generates a header for a NamedConstructor.
(GenerateNamedConstructorCallback): Generates the NamedConstructor and a template getter for the NamedConstructor.
(GenerateSingleBatchedAttribute): If an IDL type is "XXXXConstructorConstructor", then we do not add a header file of XXXXConstructor, because the XXXXConstructor declaration is written in the header file of class XXXX.

  • bindings/scripts/IDLParser.pm:

(parseExtendedAttributes): Parses 'NamedConstructor' '=' name '(' parameters ')' ','?
(ParseInterface): Creates the signature of a NamedConstructor.

  • bindings/scripts/test/TestNamedConstructor.idl: Added a new test for the [NamedConstructor] IDL.
  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp: Added a run-binding-test result of TestNamedConstructor.idl.

(WebDOMTestNamedConstructor::WebDOMTestNamedConstructorPrivate::WebDOMTestNamedConstructorPrivate):
(WebDOMTestNamedConstructor::WebDOMTestNamedConstructor):
(WebDOMTestNamedConstructor::operator=):
(WebDOMTestNamedConstructor::impl):
(WebDOMTestNamedConstructor::~WebDOMTestNamedConstructor):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp: Ditto.

(WebKit::kit):
(WebKit::core):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_set_property):
(webkit_dom_test_named_constructor_get_property):
(webkit_dom_test_named_constructor_constructed):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):
(WebKit::wrapTestNamedConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.

(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructorPrototype::self):
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::createPrototype):
(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):
(WebCore::toJS):
(WebCore::toTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h: Ditto.

(WebCore::JSTestNamedConstructor::create):
(WebCore::JSTestNamedConstructor::createStructure):
(WebCore::JSTestNamedConstructor::impl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::JSTestNamedConstructorPrototype::create):
(WebCore::JSTestNamedConstructorPrototype::createStructure):
(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.mm: Ditto.

(-[DOMTestNamedConstructor dealloc]):
(-[DOMTestNamedConstructor finalize]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h: Ditto.
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.

(WebCore::TestNamedConstructorInternal::V8_USE):
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
(WebCore::V8TestNamedConstructor::toActiveDOMObject):
(WebCore::V8TestNamedConstructor::wrapSlow):
(WebCore::V8TestNamedConstructor::derefObject):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h: Ditto.

(WebCore::V8TestNamedConstructor::toNative):
(WebCore::V8TestNamedConstructor::existingWrapper):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • page/DOMWindow.idl: Added [CustomConstructor] IDL to HTMLAudioElement, HTMLImageElement and HTMLOptionElement.
17:11 Changeset [99640] by barraclough@apple.com

Move code to handle 8bit regs from X86Assembler to MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=71867

Reviewed by Oliver Hunt.

This code is fine, but is in the wrong place really. X86 assembler should
basically just format up exactly the instruction you request - not expand
out to a set of instructions (that is what the macro assembler layer is
for!). For other 8-bit ops, on X86 we don't guard against clients accessing
the XH registers.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movb_rm):

  • moved some code.
17:05 Changeset [99639] by commit-queue@webkit.org

Unreviewed, rolling out r99626.
http://trac.webkit.org/changeset/99626
https://bugs.webkit.org/show_bug.cgi?id=71866

"C++ exceptions cannot be disabled without influencing the
Objective-C exceptions" (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-08

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
17:02 Changeset [99638] by commit-queue@webkit.org

fix REGRESSION: SVG feColorMatrix causes crash
https://bugs.webkit.org/show_bug.cgi?id=71287

Patch by Philip Rogers <pdr@google.com> on 2011-11-08
Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/filters/feColorMatrix-invalid-animation.svg

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

LayoutTests:

  • svg/filters/feColorMatrix-invalid-animation-expected.png: Added.
  • svg/filters/feColorMatrix-invalid-animation-expected.txt: Added.
  • svg/filters/feColorMatrix-invalid-animation.svg: Added.
17:01 Changeset [99637] by fpizlo@apple.com

Unreviewed build fix for GTK.

  • GNUmakefile.list.am:
16:58 Changeset [99636] by barraclough@apple.com

Build fix.

  • assembler/X86Assembler.h:
16:56 Changeset [99635] by barraclough@apple.com

Errrk, failed to commit this in last change.

  • assembler/X86Assembler.h:
16:47 Changeset [99634] by barraclough@apple.com

Remove an unused method.

Rubber stamped by Geoff Garen.

  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBuffer.h:
    • removed rewindToLabel.
16:43 Changeset [99633] by barraclough@apple.com

Fix OSR entry points to calculate offsets correctly WRT to branch compaction.
https://bugs.webkit.org/show_bug.cgi?id=71864

Reviewed by Filip Pizlo.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::offsetOf):

  • We use this to return the offsets into the code of the entry points.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • Move the construction of the speculative JIT outside of compileBody, such that it is still available to link the OSR entry points at the point we are linking.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • Pass the label of the block & linkbuffer into noticeOSREntry.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • Moved call to noticeOSREntry until we we linking.
  • dfg/DFGSpeculativeJIT.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • Moved calculation of entries until we we linking.
  • jit/JIT.h:
    • Removed some members.
16:43 Changeset [99632] by commit-queue@webkit.org

Add support for arrays of numbers to IDL bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=71763

Adds support for float[] and double[] to IDL. Support for other types
appears to be more complicated (or at least more copy-paste) so not
doing that for now for lack of need.

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-08
Reviewed by Adam Barth.

Tests added to TestObj.idl.

  • bindings/scripts/CodeGeneratorV8.pm:

(IsRefPtrType):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::floatArrayAttrGetter):
(WebCore::TestObjInternal::floatArrayAttrSetter):
(WebCore::TestObjInternal::doubleArrayAttrGetter):
(WebCore::TestObjInternal::doubleArrayAttrSetter):

  • bindings/v8/V8Binding.h:

(WebCore::v8NumberArray):
(WebCore::v8NumberArrayToVector):

16:27 Changeset [99631] by ojan@chromium.org

Update the expectations. This test appears to also fail on the chromium mac bots.

  • platform/chromium/test_expectations.txt:
16:24 Changeset [99630] by mitz@apple.com

REGRESSION (r99613): Incomplete painting of the root element background in flipped blocks writing mode
https://bugs.webkit.org/show_bug.cgi?id=71863

Reviewed by Anders Carlsson.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers): Instead of unconditionally flipping the background
rect here...

  • rendering/RenderView.cpp:

(WebCore::RenderView::backgroundRect): ...flip it only in column mode here.

  • rendering/RenderView.h:
16:21 Changeset [99629] by fpizlo@apple.com

DFG OSR exit code should be generated by a separate compiler, not
related to DFG::JITCompiler
https://bugs.webkit.org/show_bug.cgi?id=71787

Reviewed by Gavin Barraclough.

Moves the exitSpeculativeWithOSR() method from JITCompiler to
OSRExitCompiler::compileExit().

  • CMakeListsEfl.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):

  • dfg/DFGJITCompiler32_64.cpp: Removed.
  • dfg/DFGOSRExitCompiler.h: Added.

(JSC::DFG::OSRExitCompiler::OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp: Added.

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp: Added.

(JSC::DFG::OSRExitCompiler::compileExit):

  • runtime/JSValue.h:
16:13 Changeset [99628] by commit-queue@webkit.org

Move NSRange / DOMRange functions back to WebFrameInternal
https://bugs.webkit.org/show_bug.cgi?id=71844

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-08
Reviewed by Alexey Proskuryakov.

  • WebView/WebFrame.mm:

(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
16:12 Changeset [99627] by fpizlo@apple.com

Basic DFG definitions should be moved out of DFGNode.h
https://bugs.webkit.org/show_bug.cgi?id=71861

Rubber-stamped by Gavin Barraclough.

(JSC::DFG::NodeIndexTraits::defaultValue):

  • dfg/DFGNode.h:
  • dfg/DFGOSRExit.h:
  • dfg/DFGRegisterBank.h:
15:57 Changeset [99626] by commit-queue@webkit.org

[Mac] Disable C++ exceptions from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=71834

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-08
Reviewed by Darin Adler.

DumpRenderTree Mac does not handle C++ exceptions. When such exception
happens, it tends to cause the AutoReleasePool stack to be corrupted,
which leads to crashes long after the exception was raised.

This patch disabled C++ exceptions in order to catch the problems where
they happen when a C++ exception is raised.

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
15:52 Changeset [99625] by bfulgham@webkit.org

[WinCairo] Unreviewed build fix after r99613.

  • win/WebKit2CFLite.def: Add missing export.
15:49 Changeset [99624] by fsamuel@chromium.org

Delete WebViewimpl::scalePage
https://bugs.webkit.org/show_bug.cgi?id=71711

Reviewed by Darin Fisher.

Once this patch lands: http://codereview.chromium.org/8477033

WebViewImpl::scalePage will no longer be used in Chromium and
can safely be deleted.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
15:48 Changeset [99623] by ojan@chromium.org

Rebaseline test failing due to subtle antialiasing differences.
Garden-o-matic claims it broke at r99613.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
15:45 Changeset [99622] by barraclough@apple.com

Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761

Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.

Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.

To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.

Patch by Michael Saboff <msaboff@apple.com> on 2011-11-08
Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError):

  • parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::sourceCode):

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

  • parser/Parser.h:

(JSC::::parse):
(JSC::parse):

  • parser/SourceCode.h:

(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):

15:44 Changeset [99621] by ojan@chromium.org

Rebaselines and expectations after r99609 and r99616 and r99613.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:42 Changeset [99620] by jchaffraix@webkit.org

Moved myself to the reviewer list (yay!).

  • Scripts/webkitpy/common/config/committers.py:
15:17 Changeset [99619] by bfulgham@webkit.org

[WinCairo] Unreviewed build fix after r98624 and r99613.

  • win/WebKit2CFLite.def: Add missing exports.
14:49 Changeset [99618] by msaboff@apple.com

Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761

Source/JavaScriptCore:

Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.

Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.

To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.

Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError):

  • parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::sourceCode):

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

  • parser/Parser.h:

(JSC::::parse):
(JSC::parse):

  • parser/SourceCode.h:

(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):

Source/WebCore:

Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.

No tests added - refactored base class SourceCode and its subclasses.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::data):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::data):

Source/WebKit/mac:

Changed WKPCEvaluate() to use emptyString() when the source is
zero length.

Reviewed by Gavin Barraclough.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCEvaluate):

14:44 Changeset [99617] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71856
WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
old NSWindowDidChangeResolutionNotification
-and corresponding-
<rdar://problem/10317253>

Reviewed by Tim Hatcher.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):

We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WebView _windowDidChangeBackingProperties:]):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):

We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WKView _windowDidChangeBackingProperties:]):

14:22 Changeset [99616] by xji@chromium.org

REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
https://bugs.webkit.org/show_bug.cgi?id=70395

Reviewed by Tony Chang.

Source/WebCore:

Change the condition to perform immediate scolling inside ScrollView::updateScrollbars()
to be correct for RTL page as well, which is checking either the scroll position change or
the m_scrollOrigin changes (such as in window resize in which scroll position might remain the same).

And remove condition checking inside ScrollableArea::scrollToOffsetWithoutAnimation() since
the pass-in offset is adjusted within the current scroll range, it could be the same as
m_currentPos when m_currentPos is (0, 0) and current scroll range is smaller than old
scroll range, but scolling is still needed when page resize and scroll range changes.

Test: fast/dom/rtl-scroll-to-leftmost-and-resize.html

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Remove condition checking.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Change condition to perform immediate scrolling to be
correct for RTL pages as well.

  • platform/ScrollableArea.cpp: Update m_scrollOriginChanged.

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):

  • platform/ScrollableArea.h: Add m_scrollOriginChanged.

(WebCore::ScrollableArea::scrollOriginChanged):
(WebCore::ScrollableArea::resetScrollOriginChanged):

LayoutTests:

  • fast/dom/rtl-scroll-to-leftmost-and-resize.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
14:01 Changeset [99615] by andersca@apple.com

Add a basic layer hierarchy to the Core Animation drawing area
https://bugs.webkit.org/show_bug.cgi?id=71838

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):
Return early if we're using a tiled drawing area.

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
If we're using a tiled drawing area, make the WKView layer backed and set its layer
to a simple CALayer with a white background and set the view's content redraw policy
to never to avoid ever calling drawRect.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didUpdateGeometry):

  • UIProcess/DrawingAreaProxy.messages.in:

Add a new didUpdateGeometry message.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
Initialize m_isWaitingForDidUpdateGeometry.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
Send an UpdateGeometry message to the web process and wait for a reply.

(WebKit::TiledCoreAnimationDrawingAreaProxy::enterAcceleratedCompositingMode):
Tell the web page proxy to enter accelerated compositing mode.

(WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode):
Assert that this function is never called.

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Send another UpdateGeometry message if needed.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
Add helper function to actually send the UpdateGeometry message.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateGeometry):

  • WebProcess/WebPage/DrawingArea.messages.in:

Add UpdateGeometry message.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Create a red root layer and a remote layer client that hosts it.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the root layer and tell the UI process that we've updated the geometry.

13:57 Changeset [99614] by barraclough@apple.com

DFG JIT calculation of OSR entry points is not THUMB2 safe
https://bugs.webkit.org/show_bug.cgi?id=71852

Reviewed by Oliver Hunt.

Executable addresses are tagged with a low bit set to distinguish
between THUMB2 and traditional ARM.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • jit/JITCode.h:

(JSC::JITCode::executableAddressAtOffset):
(JSC::JITCode::start):
(JSC::JITCode::size):

13:14 Changeset [99613] by mitz@apple.com

<rdar://problem/10262225> Allow RenderView to have columns
https://bugs.webkit.org/show_bug.cgi?id=71840

Source/WebCore:

Reviewed by Simon Fraser.

Tests: fast/multicol/pagination-h-horizontal-bt.html

fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-h-vertical-lr.html
fast/multicol/pagination-h-vertical-rl.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html
fast/multicol/pagination-v-vertical-lr.html
fast/multicol/pagination-v-vertical-rl.html

  • WebCore.exp.in: Export Page::setPagination() for WebCoreTestSupport.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument): Set the column axis and the column gap in the
document style if the view is paginated.

  • page/Page.cpp:

(WebCore::Page::setPagination): Added this setter.

  • page/Page.h:

(WebCore::Page::Pagination::Pagination):
(WebCore::Page::pagination): Added this getter.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::requiresColumns): Added and moved some logic to here from...
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): ...here.

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers): Changed to use the new RenderView::backgroundRect()
instead of unscaledDocumentRect().

  • rendering/RenderView.cpp:

(WebCore::RenderView::requiresColumns): Added this override that always returns true if the view
is paginated.
(WebCore::RenderView::backgroundRect): Added. In the paginated case, returns a rectangle stretching
across all columns.

  • rendering/RenderView.h:
  • testing/Internals.cpp:

(WebCore::Internals::reset): Also reset pagination.
(WebCore::Internals::setPagination): Added this setter for testing.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def: Export Page::setPagination() for WebCoreTestSupport.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/multicol/pagination-h-horizontal-bt.html: Added.
  • fast/multicol/pagination-h-horizontal-tb.html: Added.
  • fast/multicol/pagination-h-vertical-lr.html: Added.
  • fast/multicol/pagination-h-vertical-rl.html: Added.
  • fast/multicol/pagination-v-horizontal-bt.html: Added.
  • fast/multicol/pagination-v-horizontal-tb.html: Added.
  • fast/multicol/pagination-v-vertical-lr.html: Added.
  • fast/multicol/pagination-v-vertical-rl.html: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
13:02 Changeset [99612] by commit-queue@webkit.org

Document.importNode's 'deep' argument should default to true.
https://bugs.webkit.org/show_bug.cgi?id=71190

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-08
Reviewed by Adam Barth.

Source/WebCore:

As new specification says deep argument of importNode should be default to true.

Test: fast/dom/document-importNode-arguments.html

  • dom/Document.h: Added supportive method.

(WebCore::Document::importNode):

  • dom/Document.idl: Modified deep argument as optional.

LayoutTests:

Added test to check document.importNode with No deep argument,
deep argument true and false.

  • fast/dom/document-importNode-arguments-expected.txt: Added.
  • fast/dom/document-importNode-arguments.html: Added.
12:59 Changeset [99611] by adamk@chromium.org

WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
https://bugs.webkit.org/show_bug.cgi?id=71596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds two cases where WebKitMutationObserver.observe throws an exception:

  • When passed a null Node*.
  • When passed options that don't make sense, e.g., 'attributeOldValue' but not 'attributes'.
  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::validateOptions):
(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:
  • dom/WebKitMutationObserver.idl:

LayoutTests:

  • fast/mutation/observe-exceptions-expected.txt:
  • fast/mutation/observe-exceptions.html:
12:53 Changeset [99610] by hyatt@apple.com

Revert check-in. My mistake.

12:51 Changeset [99609] by commit-queue@webkit.org

IndexedDB: implement compound (array) key support
https://bugs.webkit.org/show_bug.cgi?id=62284

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-08
Reviewed by Tony Chang.

Source/WebCore:

Add support for Array values as IDBKeys. (Multirow indexes are still
not yet supported.)

Tests: storage/indexeddb/cursor-key-order.html

storage/indexeddb/key-type-array.html

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • storage/IDBKey.cpp:

(WebCore::IDBKey::compare):

  • storage/IDBKey.h:

(WebCore::IDBKey::createArray):
(WebCore::IDBKey::valid):
(WebCore::IDBKey::array):
(WebCore::IDBKey::compareTypes):

  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):

  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Extend WebKit API to support Array values as IDBKeys.

  • public/WebIDBKey.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::createArray):
(WebKit::convertFromWebIDBKeyArray):
(WebKit::convertToWebIDBKeyArray):
(WebKit::WebIDBKey::assignArray):
(WebKit::WebIDBKey::array):

  • tests/IDBBindingUtilitiesTest.cpp:

(WebCore::TEST):

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::createArrayIDBKey):
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding::compareStrings):

LayoutTests:

  • storage/indexeddb/cursor-key-order-expected.txt: Added.
  • storage/indexeddb/cursor-key-order.html: Added.
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/key-type-array-expected.txt: Added.
  • storage/indexeddb/key-type-array.html: Added.
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
12:37 Changeset [99608] by msaboff@apple.com

JSC::Parser::Parser leaks Lexer member
https://bugs.webkit.org/show_bug.cgi?id=71847

Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.

Reviewed by Oliver Hunt.

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::parseFunctionBody):

  • parser/Parser.h:
12:33 Changeset [99607] by dbates@webkit.org

Remove get() defined in CredentialStorageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=71829

Reviewed by Andreas Kling.

CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageQt.cpp.

  • Target.pri: Add files CredentialStorage.{cpp, h}.
  • platform/network/qt/CredentialStorageQt.cpp:
12:31 Changeset [99606] by jonlee@apple.com

[WK2] Expose acceptMIMETypes for file inputs
https://bugs.webkit.org/show_bug.cgi?id=71836
<rdar://problem/10407367>

Reviewed by Anders Carlsson.

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):

  • Shared/WebOpenPanelParameters.h:
  • UIProcess/API/C/WKOpenPanelParameters.cpp:

(WKOpenPanelParametersCopyAcceptedMIMETypes):

  • UIProcess/API/C/WKOpenPanelParameters.h:
12:20 Changeset [99605] by hyatt@apple.com

Fix more build bustage.

12:14 Changeset [99604] by hyatt@apple.com

Fix build bustage.

12:10 Changeset [99603] by commit-queue@webkit.org

[WK2][GTK] The default database & local storage directory names should note they exist for Gtk port's needs
https://bugs.webkit.org/show_bug.cgi?id=71837

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.

Ensure that directories for databases and local storage are in a 'webkitgtk'
directory in current user's data directory, noting they originate from the Gtk port.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

12:08 Changeset [99602] by lforschler@apple.com

New tag.

12:02 Changeset [99601] by lforschler@apple.com

Versioning.

12:00 Changeset [99600] by lforschler@apple.com

Merged r99508.

11:41 Changeset [99599] by commit-queue@webkit.org

IndexedDB: reference cycle between IDBDatabase and IDBTransaction
https://bugs.webkit.org/show_bug.cgi?id=71749

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-08
Reviewed by Tony Chang.

Source/WebCore:

Break a cyclic reference leak following a setVersion call.

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersionChangeTransaction):
(WebCore::IDBDatabase::clearVersionChangeTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):

  • storage/IDBDatabase.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

LayoutTests:

Add test case to verify that creating/deleting a store outside
a transaction throws same error if store exists. Also fix
the test to actually try removing stores.

  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
11:29 Changeset [99598] by zeno.albisser@nokia.com

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
11:19 Changeset [99597] by ojan@chromium.org

Fix expectations mixup.

  • platform/chromium/test_expectations.txt:
11:13 Changeset [99596] by dbates@webkit.org

Remove get() defined in CredentialStorageSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=71825

Reviewed by Martin Robinson.

CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageSoup.cpp.

  • GNUmakefile.list.am: Add source file CredentialStorage.cpp.
  • platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().

CredentialStorage::get() is defined in CredentialStorage.cpp.

11:04 Changeset [99595] by rolandsteiner@chromium.org

Rename CSS document() -> findDocument(), to indicate tree climbing
https://bugs.webkit.org/show_bug.cgi?id=71764

Renamed document() to findDocument(), styleSheetOwnerNode() to findStyleSheetOwnerNode().

Reviewed by Darin Adler.

No new tests. (simple refactoring)

  • css/CSSGrammar.y:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::requestStyleSheet):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::findDocument):
(WebCore::CSSParser::parseAttr):

  • css/CSSParser.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::findStyleSheetOwnerNode):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::styleSheetChanged):

  • css/CSSStyleSheet.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::bindStyleSheet):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ownerDocument):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

10:39 Changeset [99594] by rniwa@webkit.org

Indent command can insert block quote in non editable content
https://bugs.webkit.org/show_bug.cgi?id=71754

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by IndentOutdentCommand's incorrectly using deprecatedNode to determine the outer block,
not updating the start after inserting the targetBlockquote, and cloneParagraphUnderNewElement's cloning
outerNode even if it was body. Fixed those bugs.

Test: editing/execCommand/indent-images.html

editing/execCommand/indent-images-2.html
editing/execCommand/indent-images-3.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentIntoBlockquote):

LayoutTests:

Add tests to indent two images in a document.

  • editing/execCommand/indent-images-expected.txt: Added.
  • editing/execCommand/indent-images.html: Added.
  • editing/execCommand/indent-images-2-expected.txt: Added.
  • editing/execCommand/indent-images-2.html: Added.
  • editing/execCommand/indent-images-3-expected.txt: Added.
  • editing/execCommand/indent-images-3.html: Added.
10:29 Changeset [99593] by adamk@chromium.org

Only walk up the tree in search of MutationObservers if one has been added
https://bugs.webkit.org/show_bug.cgi?id=71499

Reviewed by Ojan Vafai.

Source/WebCore:

Analogous to m_listenerTypes, added an m_subtreeMutationObserverTypes field
to Document that keeps track of which observer types have been added.
This allows us to avoid doing any extra work if MutationObservers are
not attached to a document.

This could be improved upon to keep a count of each type, as removing
an observer currently has no effect on m_subtreeMutationObserverTypes.
But that would require a more complex implementation: one counter per
mutation type. And it would be easier to get wrong: if the counter
gets out of sync with the actual state of the DOM, we could start
dropping mutation notifications.

Test: fast/mutation/cross-document.html

  • dom/Document.h:

(WebCore::Document::hasSubtreeMutationObserverOfType):
(WebCore::Document::hasSubtreeMutationObserver):
(WebCore::Document::addSubtreeMutationObserverTypes):

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):

  • dom/Node.cpp:

(WebCore::Node::didMoveToNewOwnerDocument): Update mutationObserverTypes when a Node is moved to a new document.
(WebCore::Node::getRegisteredMutationObserversOfType): Exit early if it's known that no observers of |type| are registered.
(WebCore::Node::notifyMutationObserversNodeWillDetach): Exit early if it's known no subtree observers of any type are registered.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe): Update mutationObserverTypes when an observation occurs.

  • dom/WebKitMutationObserver.h: Add WebKitMutationObserver::AllMutationTypes to enum

LayoutTests:

Created a basic test showing that MutationObservers
are preserved when a Node switches documents.

  • fast/mutation/cross-document-expected.txt: Added.
  • fast/mutation/cross-document.html: Added.
10:27 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
10:27 Changeset [99592] by andreas.kling@nokia.com

Devirtualize CSSValue.
<http://webkit.org/b/71666>

Reviewed by Antti Koivisto.

Make the CSSValue destructor non-virtual (along with all the subclasses.)
This removes the vtables, and the pointers thereto in each value instance,
shrinking each object by one CPU word (4 or 8 bytes.)

We use the same trick as CSSRule to implement destruction; providing our
own deref() instead of RefCounted's, and performing a statically typed
delete in a destroy() method called when the ref count reaches 0.

Also made all the empty subclass destructors inline.

  • css/CSSAspectRatioValue.cpp:
  • css/CSSAspectRatioValue.h:

(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):

  • css/CSSBorderImageSliceValue.cpp:
  • css/CSSBorderImageSliceValue.h:

(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):

  • css/CSSBorderImageValue.cpp:
  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::~CSSBorderImageValue):

  • css/CSSCanvasValue.h:
  • css/CSSCrossfadeValue.cpp:
  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):

  • css/CSSCursorImageValue.h:
  • css/CSSFlexValue.cpp:
  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::~CSSFlexValue):

  • css/CSSFontFaceSrcValue.cpp:
  • css/CSSFontFaceSrcValue.h:

(WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:
  • css/CSSFunctionValue.h:

(WebCore::CSSFunctionValue::~CSSFunctionValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.h:
  • css/CSSMutableValue.h:

(WebCore::CSSMutableValue::~CSSMutableValue):

  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSUnicodeRangeValue.cpp:
  • css/CSSUnicodeRangeValue.h:

(WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::deref):
(WebCore::CSSValue::~CSSValue):

  • css/CSSValueList.cpp:
  • css/CSSValueList.h:

(WebCore::CSSValueList::~CSSValueList):

  • css/WebKitCSSFilterValue.cpp:
  • css/WebKitCSSFilterValue.h:

(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:
  • css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::~WebKitCSSTransformValue):

10:26 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
10:25 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
10:25 Changeset [99591] by darin@apple.com

Speculative fix for crashes seen in DocumentWriter::deprecatedFrameEncoding
https://bugs.webkit.org/show_bug.cgi?id=71828

Reviewed by Nate Chapin.

No new tests; not sure how to reproduce this, but crash traces indicate it
is an otherwise-harmless null dereference.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::deprecatedFrameEncoding):
Handle null document the same as a document without a URL.

10:24 Changeset [99590] by ojan@chromium.org

Move regressions from V8 roll to from the downstream expectations file.
Add regressions from http://trac.webkit.org/changeset/99561.

  • platform/chromium/test_expectations.txt:
10:23 Changeset [99589] by commit-queue@webkit.org

Unreviewed, rolling out r95720.
http://trac.webkit.org/changeset/95720
https://bugs.webkit.org/show_bug.cgi?id=71831

This has made the menulists on WebKit patch reviews much less
usable (Requested by mrobinson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-08

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::menuPositionFunction):

10:20 Changeset [99588] by thakis@chromium.org

[chromium] Remove 6 exit time destructors and 6 static initializers
https://bugs.webkit.org/show_bug.cgi?id=71760

Reviewed by Nate Chapin.

Do this by moving global statics into function-local statics, and using
DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
thread, this is a safe change to make.

No behavior change, so no new tests.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::sEventListeners):
(WebCore::ScriptGCEvent::addEventListener):
(WebCore::ScriptGCEvent::removeEventListener):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/ScriptGCEvent.h:
  • bindings/v8/V8NPObject.cpp:

(WebCore::staticTemplateMap):
(WebCore::weakTemplateCallback):
(WebCore::npObjectGetProperty):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):

  • bindings/v8/V8Proxy.cpp:

(WebCore::staticExtensionsList):
(WebCore::V8Proxy::registeredExtensionWithV8):
(WebCore::V8Proxy::registerExtension):
(WebCore::V8Proxy::extensions):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/npruntime.cpp:
  • plugins/chromium/PluginDataChromium.cpp:

(WebCore::pluginCache):
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::refresh):
(WebCore::getPluginMimeTypeFromExtension):

10:17 Changeset [99587] by tony@chromium.org

[chromium] broaden test failure for zoom-animator-scale-test2.html to include cg-gpu.

  • platform/chromium/test_expectations.txt:
10:13 Changeset [99586] by lforschler@apple.com

New tag.

10:13 Changeset [99585] by lforschler@apple.com

Versioning.

10:10 Changeset [99584] by lforschler@apple.com

Merged r99508.

10:10 Changeset [99583] by ojan@chromium.org

New tests results after r99539.

zoom-replaced-intrinsic-ratio-001-expected.png is just minor antialiasing differences.
The rest are all changing to a size that matched the pngs in platform/mac.

  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
10:04 Changeset [99582] by commit-queue@webkit.org

Autofocus inputs don't always honor selector input:focus.
https://bugs.webkit.org/show_bug.cgi?id=24093

Already fixed and works on TOT. Adding layout test case for the same.

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-08
Reviewed by Kent Tamura.

  • fast/forms/autofocus-input-css-style-change-expected.txt: Added.
  • fast/forms/autofocus-input-css-style-change.html: Added.
09:51 Changeset [99581] by hans@chromium.org

IndexedDB: Start using the onSuccessWithContinuation() callback
https://bugs.webkit.org/show_bug.cgi?id=71565

Reviewed by Tony Chang.

Source/WebCore:

This is a follow-up to r99169 where we start using this new
callback for cursors.

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunctionInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::setCursor):

LayoutTests:

The cursor-inconsistency.html test now passes completely.

  • storage/indexeddb/cursor-inconsistency-expected.txt:
09:49 Changeset [99580] by commit-queue@webkit.org

Skip some ECMAScript tests that fail on Linux in some time zones.
https://bugs.webkit.org/show_bug.cgi?id=71371

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.

  • Scripts/run-javascriptcore-tests: Skip some more tests.
09:42 Changeset [99579] by jschuh@chromium.org

Document::loader should use documentLoader(), not activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=65895

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/loader/stateobjects/replacestate-in-onunload.html

  • dom/Document.cpp:

(WebCore::Document::loader):

LayoutTests:

  • fast/loader/stateobjects/replacestate-in-onunload-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-in-onunload.html: Added.
09:36 Changeset [99578] by commit-queue@webkit.org

[WK][GTK] Application cache directory is incorrectly set
https://bugs.webkit.org/show_bug.cgi?id=71769

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.

Set the application cache directory to be placed in current user's
cache directory and update documentation for
webkit_application_cache_get_database_directory_path after these
changes and changes in r80715;

  • webkit/webkitapplicationcache.cpp:
  • webkit/webkitglobals.cpp:

(webkitInit): Switch one string formation to use GOwnPtr<gchar>.

09:33 Changeset [99577] by andreas.kling@nokia.com

CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
<http://webkit.org/b/71824>

Reviewed by Darin Adler.

Redirect the calls to the appropriate subclass in CSSImageGeneratorValue.cpp.

  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::isFixedSize):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::isFixedSize):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isFixedSize):
(WebCore::CSSGradientValue::fixedSize):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):

  • css/CSSImageGeneratorValue.h:
09:09 Changeset [99576] by commit-queue@webkit.org

[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71774

Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.

  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:

Trigger the test when the iframe loaded to avoid potential
flakyness.

09:06 Changeset [99575] by caseq@chromium.org

Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
https://bugs.webkit.org/show_bug.cgi?id=71822

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js:

(buildExtensionAPIInjectedScript):

08:46 Changeset [99574] by andreas.kling@nokia.com

CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
<http://webkit.org/b/71814>

Reviewed by Antti Koivisto.

Defer to CSSCursorImageValue (the only CSSImageValue subclass)
when appropriate in CSSImageValue::cachedImage(CachedResourceLoader*).

  • css/CSSCursorImageValue.h:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/CSSImageValue.h:
08:38 Changeset [99573] by caseq@chromium.org

Web Inspector: add "Evaluate in console" as a shortcut and context menu items to scripts panel
https://bugs.webkit.org/show_bug.cgi?id=71817

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evaluate):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._evaluateSelectionInConsole):

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):

  • inspector/front-end/externs.js:

(WebInspector.evaluateInConsole):

  • inspector/front-end/inspector.js:

(WebInspector.evaluateInConsole):

08:26 Changeset [99572] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline qt results after the recent SVGImage changes.

  • platform/qt/Skipped:
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
08:22 Changeset [99571] by vestbo@webkit.org

[Qt] Use qmake's builtin rules for copying framework headers on Mac OS

Now that we generate the forwarding headers eiher as part of QtWebKit.pro
(for Qt 4.8), or as part of the root project file (for Qt 5), we can assume
that the files are there and use $$files() to list the files to be copied.

Reviewed by Csaba Osztrogonác.

08:21 Changeset [99570] by caio.oliveira@openbossa.org

[Qt] Workaround some problems in QML API tests
https://bugs.webkit.org/show_bug.cgi?id=71818

Reviewed by Tor Arne Vestbø.

This commit workaround the issue of QML's QtTest crashing when we run tests after
"windowShown". We delay to the next run of the mainloop. This workaround is not
pretty but shouldn't affect the semantics of the tests. And we benefit more from
having working tests right now.

This patch also improves Download to: wait for the load before emitting click, and
properly identifying the "succeeded" signal of the downloadItem object.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
07:40 Changeset [99569] by ossy@webkit.org

[Qt] Unreviewed trivial fix after build system refactoring.

  • Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
07:34 Changeset [99568] by kenneth@webkit.org

Clean up QtViewportInteractionEngine

Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):

Rename the method to make it more obvious what it does. Avoid implicit
conversion to/from QVariant.

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):

Only call this method on item size changes, and not for every interaction
with the viewport item. Before this change it was even being called during
animations.

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):

Rename to make it clean that this is called from the animator.

07:29 Changeset [99567] by andreas.kling@nokia.com

CSSValue: Devirtualize cssText().
<http://webkit.org/b/71813>

Reviewed by Antti Koivisto.

Rename all subclass implementations to customCssText() and add
a CSSValue::cssText() that defers to the appropriate subclass
based on the type info.

The rename is both for clarity, and to ensure that calling
cssText() will always end up in the correct method.

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCssText):

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::customCssText):

  • css/CSSBorderImageSliceValue.h:
  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::customCssText):

  • css/CSSBorderImageValue.h:
  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::customCssText):

  • css/CSSCanvasValue.h:
  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::customCssText):

  • css/CSSCrossfadeValue.h:
  • css/CSSFlexValue.cpp:

(WebCore::CSSFlexValue::customCssText):

  • css/CSSFlexValue.h:
  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::customCssText):

  • css/CSSFontFaceSrcValue.h:
  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::customCssText):

  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::customCssText):

  • css/CSSGradientValue.h:
  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::customCssText):

  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::customCssText):

  • css/CSSInitialValue.h:
  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::customCssText):

  • css/CSSLineBoxContainValue.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::customCssText):

  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::customCssText):

  • css/CSSReflectValue.h:
  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSLinearTimingFunctionValue::customCssText):
(WebCore::CSSCubicBezierTimingFunctionValue::customCssText):
(WebCore::CSSStepsTimingFunctionValue::customCssText):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::customCssText):

  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):

  • css/CSSValue.h:
  • css/CSSValueList.cpp:

(WebCore::CSSValueList::customCssText):

  • css/CSSValueList.h:
  • css/FontFamilyValue.cpp:

(WebCore::FontFamilyValue::customCssText):

  • css/FontFamilyValue.h:
  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::customCssText):

  • css/FontFeatureValue.h:
  • css/FontValue.cpp:

(WebCore::FontValue::customCssText):

  • css/FontValue.h:
  • css/ShadowValue.cpp:

(WebCore::ShadowValue::customCssText):

  • css/ShadowValue.h:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::customCssText):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::customCssText):

  • css/WebKitCSSTransformValue.h:
  • svg/SVGColor.cpp:

(WebCore::SVGColor::customCssText):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::customCssText):

  • svg/SVGPaint.h:
07:16 Changeset [99566] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Rob Buis.

Address some problems seen on Qt/Chromium:

  • Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
  • Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f. Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
  • svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
  • svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
  • svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
06:42 Changeset [99565] by gavinp@chromium.org

Fix width of m_type in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=71727

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/dom/HTMLLinkElement/cachedresource-types.html

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

LayoutTests:

  • fast/dom/HTMLLinkElement/cachedresource-types-expected.txt: Added.
  • fast/dom/HTMLLinkElement/cachedresource-types.html: Added.
06:40 Changeset [99564] by vestbo@webkit.org

[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre

If a pro file needs to access the OBJECTS_DIR it should use the
form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
after defaults_post has been processed.

Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
the command line will override whatever we set in defaults_pre.

Reviewed by Simon Hausmann.

06:36 Changeset [99563] by pfeldman@chromium.org

Web Inspector: add JavaScript keywords to the autocomplete.
https://bugs.webkit.org/show_bug.cgi?id=71782

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):

06:19 Changeset [99562] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

[Chromium] SVG test failures after r99539
https://bugs.webkit.org/show_bug.cgi?id=71793

Reviewed by Zoltan Herczeg.

It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
That cries for problems if the machine is slow or loaded.

I left the 400ms sample snapshot for now, we can still relax it later.

  • fast/backgrounds/resources/animated-rect-relative-size.svg:
  • svg/as-background-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-fixed-size.svg:
  • svg/as-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-same-image.svg:
06:14 Changeset [99561] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Introduce SVGLengthContext, to allow to resolve relative units to arbitary viewports
https://bugs.webkit.org/show_bug.cgi?id=71780

Reviewed by Zoltan Herczeg.

Introduce SVGLengthContext to cleanup SVGLength, by moving all conversion of relative units that depend on style or viewport
out of SVGLength, into SVGLengthContext. Pass SVGLengthContext& to SVGLength::value/setValue/... functions instead of a pure
"const SVGElement* context", which was previously used to determine the viewport when resolving percentage units.
SVGLengthContext carries an additional FloatRect of the custom viewport, to which percentages are resolved, if specified.

This allows us to kill several duplicates of the same code, which handles objectBoundingBox mode for gradients/patterns/masks/etc..
A follow-up patch will convert filters to use the new SVGLengthContext::resolveRectangle code as well.

This is a preparation for bug 10430, to fix feImage + objectBoundingBox support when rendering referenced elements, instead of files.

Doesn't affect any tests yet.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h: (WebCore::RenderSVGResourceLinearGradient::gradientUnits):
  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::calculatePatternBoundaries): (WebCore::RenderSVGResourcePattern::buildTileImageTransform): (WebCore::RenderSVGResourcePattern::createTileImage):
  • rendering/svg/RenderSVGResourceRadialGradient.h: (WebCore::RenderSVGResourceRadialGradient::gradientUnits):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeCommonGradientProperties): (WebCore::writeSVGResourceContainer):
  • svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::gradientUnits): (WebCore::GradientAttributes::setGradientUnits): (WebCore::GradientAttributes::hasGradientUnits):
  • svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::patternUnits): (WebCore::PatternAttributes::patternContentUnits): (WebCore::PatternAttributes::setPatternUnits): (WebCore::PatternAttributes::setPatternContentUnits): (WebCore::PatternAttributes::hasPatternUnits): (WebCore::PatternAttributes::hasPatternContentUnits):
  • svg/SVGAllInOne.cpp:
  • svg/SVGElement.h: (WebCore::SVGElement::operator SVGLengthContext):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterBoundingBox):
  • svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::unitMode): (WebCore::SVGLength::value): (WebCore::SVGLength::setValue): (WebCore::SVGLength::convertToSpecifiedUnits):
  • svg/SVGLength.h: (WebCore::SVGLength::blend):
  • svg/SVGLengthContext.cpp: Added. (WebCore::SVGLengthContext::SVGLengthContext): (WebCore::SVGLengthContext::resolveRectangle): (WebCore::SVGLengthContext::resolvePoint): (WebCore::SVGLengthContext::resolveLength): (WebCore::SVGLengthContext::convertValueToUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage): (WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS): (WebCore::SVGLengthContext::convertValueFromEMSToUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS): (WebCore::SVGLengthContext::convertValueFromEXSToUserUnits): (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h: Added. (WebCore::SVGLengthContext::resolveRectangle):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::maskBoundingBox):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
06:01 Changeset [99560] by andreas.kling@nokia.com

CSSValue: Devirtualize addSubresourceStyleURLs().
<http://webkit.org/b/71805>

Reviewed by Antti Koivisto.

Make addSubresourceStyleURLs() non-virtual and call the appropriate
subclass implementation based on the subclass type info.

  • css/CSSBorderImageValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValueList.h:
05:46 Changeset [99559] by yuqiang.xian@intel.com

Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686

Reviewed by Filip Pizlo.

.:

Remove the DFG cmake option for Efl port as we'll determine whether to
switch on DFG or not based on build target platforms.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

We can get 9% on SunSpider, 89% on Kraken and 37% on V8, on Linux X86.

  • wtf/Platform.h:
05:43 UsingIcecreamWithQtWebKit created by alexander.faeroy@nokia.com
05:38 Changeset [99558] by caseq@chromium.org

Web Inspector: do not show object popover when selection is active
https://bugs.webkit.org/show_bug.cgi?id=71804

Reviewed by Yury Semikhatsky.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._shouldShowPopover):

05:34 Changeset [99557] by apavlov@chromium.org

Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
https://bugs.webkit.org/show_bug.cgi?id=71797

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.complete):

05:23 Changeset [99556] by andreas.kling@nokia.com

CSSGradientValue: Devirtualize createGradient().
<http://webkit.org/b/71800>

Reviewed by Antti Koivisto.

Make createGradient() non-virtual and call the appropriate subclass
implementation in image() based on is{Linear,Radial}Gradient().

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

  • css/CSSGradientValue.h:
05:22 Changeset [99555] by andreas.kling@nokia.com

CSSCanvasValue: Remove inheritance from CanvasObserver.
<http://webkit.org/b/71796>

Reviewed by Antti Koivisto.

To completely devirtualize all the CSSValues, we need to remove
CSSCanvasValue's inheritance from CanvasObserver, as that is forcing
a vptr into the class.

Use the same approach as CSSImportRule and make a simple proxying
CanvasObserver subclass and put that as a member variable of the value.

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::~CSSCanvasValue):
(WebCore::CSSCanvasValue::element):

  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::CSSCanvasValue):
(WebCore::CSSCanvasValue::CanvasObserverProxy::CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::~CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasChanged):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasResized):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasDestroyed):

05:06 Changeset [99554] by yurys@chromium.org

Web Inspector: display notification in the front-end when inspected worker terminates
https://bugs.webkit.org/show_bug.cgi?id=71770

Source/WebCore:

When inspected worker terminates we will show a notification similar to the help
screen. The notification disappears when the worker restarts or the user closes it
manually.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.showWorkerTerminatedScreen):
(WebInspector.WorkerTerminatedScreen):

  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromBackend):
(WebInspector.frontendReused):

Source/WebKit/chromium:

Exposed an API for the browser to notify inspector front-end when inspeced instance
terminates. It is used now for tracking shared workers termination.

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::createFrontendDisconnectedEvent):

05:03 Changeset [99553] by yutak@chromium.org

[Chromium] Unreviewed, add three more CG-only failures.

  • platform/chromium/test_expectations.txt:
04:48 Changeset [99552] by yutak@chromium.org

[Chromium] Mark fast/backgrounds/svg-as-mask.html as IMAGE on MAC.

  • platform/chromium/test_expectations.txt:
04:40 Changeset [99551] by kenneth@webkit.org

[Qt] Improve the animation time constant
https://bugs.webkit.org/show_bug.cgi?id=71790

Reviewed by Simon Hausmann.

Use 250 milliseconds instead of 400, which feels a lot more natural
and makes the mini browser feel more responsive.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:
04:37 Changeset [99550] by yutak@chromium.org

[Chromium] Unreviewed fix of expectation conflict in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
04:29 Changeset [99549] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Fold ImageBySizeCache again into CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=71785

Reviewed by Zoltan Herczeg.

Remove ImageBySizeCache, and fold it into CSSImageGeneratorValue, as it used to be.
CachedImage has switched to SVGImageCache and no longer needs it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::removeClient): (WebCore::CSSImageGeneratorValue::getImage): (WebCore::CSSImageGeneratorValue::putImage):
  • css/CSSImageGeneratorValue.h: (WebCore::SizeAndCount::SizeAndCount): (WebCore::CSSImageGeneratorValue::clients):
  • rendering/ImageBySizeCache.cpp: Removed.
  • rendering/ImageBySizeCache.h: Removed.
04:22 Changeset [99548] by apavlov@chromium.org

Web Inspector: Avoid automatic Console suggestions with empty expression
https://bugs.webkit.org/show_bug.cgi?id=71783

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:
04:14 Changeset [99547] by vestbo@webkit.org

[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES

Reviewed by Simon Hausmann.

04:00 Changeset [99546] by yurys@chromium.org

[Chromium] Web Inspector: add sanity test for automatic reattach to a page which is reloaded after crash
https://bugs.webkit.org/show_bug.cgi?id=71786

Added a test function that checks if console evaluation works after crashed tab reloading.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testReattachAfterCrash):

03:58 Changeset [99545] by yutak@chromium.org

[Chromium] Unreviewed, trying to update test_expectations.txt for the tests which
started to fail after r99539.

  • platform/chromium/test_expectations.txt:
03:54 Changeset [99544] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix build, by removing an unused variable.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): (WebCore::CanvasRenderingContext2D::createPattern):
03:46 Changeset [99543] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Zoltan Herczeg.

When determining whether the canvas would be tainted, we need access to the SVGImage, not its cached BitmapImage.
Otherwhise wrong assumptions are mode, leading to regressions.

Fixes http/tests/security/canvas-remote-read-svg-image.html and related tests on the bots.

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): Forgot to switch them back to use cachedImage->image().
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): Ditto.
03:30 Changeset [99542] by vestbo@webkit.org

[Qt] Ensure forwarding headers are generated before generating install rules

The install rule for headers depends on qmake being able to walk the list of
headers in the $build_root/include/QtWebKit directory, but this directory is
empty until we've generated the forwarding headers. So we need to make sure
the forwarding headers are generated _before_ we run qmake on the api project
file. This applies to Qt 4.8 only, as Qt 5 will run synqt as part of the
root project file (due to the sync.profile file).

https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

03:22 Changeset [99541] by vsevik@chromium.org

Web Inspector: Console should be scrolled to bottom when shown for the first time.
https://bugs.webkit.org/show_bug.cgi?id=71781

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:
01:34 Changeset [99540] by hausmann@webkit.org

[Qt] Merge QtDesktopWebPageProxy and QtTouchWebPageProxy into QtWebPageProxy. https://bugs.webkit.org/show_bug.cgi?id=71355

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-11-08
Reviewed by Simon Hausmann.

As we try to unify our public API offer we need to merge our double
WebPageProxy implementations first into a common class. That will help
to merge our TouchWebView and DesktopWebView views into one class later.
This commit just merge stuff around and doesn't contain any functional changes.

  • Target.pri:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::init):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/QtDesktopWebPageProxy.cpp: Removed.
  • UIProcess/qt/QtDesktopWebPageProxy.h: Removed.
  • UIProcess/qt/QtTouchWebPageProxy.cpp: Removed.
  • UIProcess/qt/QtTouchWebPageProxy.h: Removed.
  • UIProcess/qt/QtWebPageProxy.cpp:

(dragOperationToDropAction):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleEvent):
(QtWebPageProxy::handleMouseMoveEvent):
(QtWebPageProxy::handleMousePressEvent):
(QtWebPageProxy::handleMouseReleaseEvent):
(QtWebPageProxy::handleMouseDoubleClickEvent):
(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::handleHoverLeaveEvent):
(QtWebPageProxy::handleHoverMoveEvent):
(QtWebPageProxy::handleDragEnterEvent):
(QtWebPageProxy::handleDragLeaveEvent):
(QtWebPageProxy::handleDragMoveEvent):
(QtWebPageProxy::handleDropEvent):
(QtWebPageProxy::timerEvent):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::didReceiveDownloadResponse):
(QtWebPageProxy::paintContent):
(QtWebPageProxy::createDrawingAreaProxy):
(QtWebPageProxy::renderToCurrentGLContext):
(QtWebPageProxy::doneWithTouchEvent):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtWebPageProxy::touchEvent):
(QtWebPageProxy::findZoomableAreaForPoint):

  • UIProcess/qt/QtWebPageProxy.h:
01:32 Changeset [99539] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Antti Koivisto.

Add some layout tests covering repainting of embedded SVG documents triggered by SMIL animations.

  • platform/chromium/test_expectations.txt: Fix test expectations, as described in bug 71226.
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html: Added.
  • svg/as-image/animated-svg-as-image-same-image.html: Added.
  • svg/as-image/resources/animated-rect-same-image.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg.
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg: Add comment, why scrollbars shouldn't appear anymore here.

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Antti Koivisto.

Fix regressions/races introduced by r98852. SVGImage repainting didn't work under certain circumstances.
The problem was hard to reproduce on Mac ports, but easily visible on Chromium, when opening two files
that shared the same animated SVG image. The problem of sharing a single ImageObserver across multiple
instances of the same SVGImage, leads to nasty problems, that are timing dependant. changedInRect() calls
that should only by received in one document, are received in the other as well, due the shared nature
of CachedImage. To avoid these problems alltogether, a new approach is needed, that was initially suggested
by Antti.

Avoid creating multiple SVGImages and caching them for different sizes/zoom levels. Introduce SVGImageCache
which holds rendered versions of the SVGImage at certain sizes/zoom levels. It holds (ImageBuffer, Image) pairs
for each renderer, associated with a size and zoom level.

This is a major change to the cache as introduced some weeks ago. Instead of holding multiple SVGImages, each containing
a whole DOM/render tree, we now create bitmap images rendered at the requested sizes/zoom levels and cache them.

Revert ImageBySizeCache changes that were needed to make it usable wih SVGImage. Its now used only in CSSImageGeneratorValue and
thus the extra information that CSSImageGeneratorValue doesn't need can be removed again (desired/actual size differentations, and the zoom level).

Tests: svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html

svg/as-image/animated-svg-as-image-same-image.html

  • CMakeLists.txt: Add svg/graphics/SVGImageCache.* to build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from svg/graphics, as SVGImageCache is needed by CachedImage in SVG enabled builds.
  • WebCore.xcodeproj/project.pbxproj: Add svg/graphics/SVGImageCache.* to build.
  • css/CSSImageGeneratorValue.cpp: Remove zoom parameter from addClient/getImage, no need to pass 1 default values anymore. (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::getImage):
  • loader/cache/CachedImage.cpp: Stop using ImageBySizeCache, and switch to the new SVGImageCache. (WebCore::CachedImage::removeClientForRenderer): (WebCore::CachedImage::lookupOrCreateImageForRenderer): (WebCore::CachedImage::setContainerSizeForRenderer): (WebCore::CachedImage::imageSizeForRenderer): (WebCore::CachedImage::clear): (WebCore::CachedImage::createImage): (WebCore::CachedImage::destroyDecodedData): (WebCore::CachedImage::decodedSizeChanged): (WebCore::CachedImage::didDraw): (WebCore::CachedImage::shouldPauseAnimation): (WebCore::CachedImage::animationAdvanced): (WebCore::CachedImage::changedInRect):
  • loader/cache/CachedImage.h:
  • page/DragController.cpp: Stop using imageForRenderer(), as it may return cached BitmapImages, that don't carry a filename extension anymore, which is required here. (WebCore::getImage):
  • rendering/ImageBySizeCache.cpp: Revert changes to ImageBySizeCache, which were needed to make it usable for SVGImages. CSSImageGenerator doesn't need it. (WebCore::ImageBySizeCache::addClient): (WebCore::ImageBySizeCache::removeClient): (WebCore::ImageBySizeCache::getImage):
  • rendering/ImageBySizeCache.h: Ditto. (WebCore::SizeAndCount::SizeAndCount):
  • rendering/RenderImage.cpp: Stop using imageForRenderer(), use cachedImage()->image(), which is guaranteed to be a SVGImage for svg images, and not a cached bitmap copy. (WebCore::RenderImage::embeddedContentBox):
  • rendering/RenderReplaced.cpp: Simplify logic to figure out the intrinsic size - the special logic for the old SVGImage cache can go away now. (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): (WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
  • rendering/style/StyleCachedImage.cpp: Call removeClientForRenderer(), which takes care of clearing SVGImageCache entries as well. (WebCore::StyleCachedImage::removeClient): This change is needed, as we don't want to make removeClient() virtual in CachedResource.
  • rendering/svg/RenderSVGRoot.cpp: Rename isEmbeddedThroughImageElement to isEmbeddedThroughSVGImage, as this is what it actually checks. (WebCore::RenderSVGRoot::isEmbeddedThroughSVGImage):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGSVGElement.cpp: Fix bug that's visible now with the SVGImageCache, which was already there before, but hard to trigger. (WebCore::SVGSVGElement::currentViewBoxRect): The viewBox depends on who's asking for it: the host document or the embedded document? Take that into account.
  • svg/SVGSVGElement.h:
  • svg/graphics/SVGImage.cpp: Cleanup some code. Add new logic that draws a SVGImage into an ImageBuffer at a desired size & zoom. (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::size): (WebCore::SVGImage::drawSVGToImageBuffer):
  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp: Added. SVGImageCache caches Image/ImageBuffer pairs for each _renderer_ and size/zoom level. The ImageBySizeCache only cared about size. (WebCore::SVGImageCache::SVGImageCache): (WebCore::SVGImageCache::~SVGImageCache): (WebCore::SVGImageCache::removeRendererFromCache): (WebCore::SVGImageCache::setRequestedSizeAndZoom): (WebCore::SVGImageCache::getRequestedSizeAndZoom): (WebCore::SVGImageCache::imageContentChanged): (WebCore::SVGImageCache::redrawTimerFired): (WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
  • svg/graphics/SVGImageCache.h: Added. (WebCore::SVGImageCache::create): (WebCore::SVGImageCache::CachedSizeAndZoom::CachedSizeAndZoom): (WebCore::SVGImageCache::CachedImageData::CachedImageData):

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Antti Koivisto.

  • CMakeLists.txt: Add svg/graphics include, for SVGImageCache.h.
01:13 Changeset [99538] by philn@webkit.org

Unreviewed, skip flaky crasher on GTK.

  • platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-fieldset-legend.html
01:07 Changeset [99537] by commit-queue@webkit.org

[WK2][GTK] Application cache directory is incorrectly set
https://bugs.webkit.org/show_bug.cgi?id=70680

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Philippe Normand.

Correctly set application cache directory to be in current
user's default cache directory.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::applicationCacheDirectory):

01:04 Changeset [99536] by ossy@webkit.org

[Qt] Some tests are flaky with NRWT
https://bugs.webkit.org/show_bug.cgi?id=64002
There can be found the skipped tests:
https://bugs.webkit.org/show_bug.cgi?id=71693
https://bugs.webkit.org/show_bug.cgi?id=71695

These 2 tests caused 7 tests timeouting.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2011-11-08
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip culprit tests
  • http/tests/notifications/icon-does-not-exist.html
  • http/tests/xmlhttprequest/workers/abort-exception-assert.html
  • platform/qt/test_expectations.txt: Unskip passing tests.
01:01 Changeset [99535] by commit-queue@webkit.org

[Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
https://bugs.webkit.org/show_bug.cgi?id=71759

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-08
Reviewed by Simon Hausmann.

qwebkitplatformplugin.h must not depend on qwebkitglobal.h.

  • Api/qwebkitplatformplugin.h:

Updating the copy of qwebkitplatformplugin.h that is used by the example plugin. The previous
one was very outdated.

  • examples/platformplugin/qwebkitplatformplugin.h:
00:57 Changeset [99534] by ossy@webkit.org

[Qt] Unreivewed gardening. Reset test results.

Patch by Fehér Zsolt <feherzs@inf.u-szeged.hu> on 2011-11-08

  • platform/qt-5.0/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
  • platform/qt-5.0/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/svg-image-change-content-size-expected.txt: Added.
00:55 Changeset [99533] by yurys@chromium.org

Web Inspector: refactor shortcuts and settings screens
https://bugs.webkit.org/show_bug.cgi?id=71773

Keep pointer to the visible screen and hide it automatically when new one is going
to be displayed.

Reviewed by Pavel Feldman.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen): ShortcutsScreen is now a descendant of HelpScreen.
(WebInspector.ShortcutsScreen.prototype.show):

  • inspector/front-end/inspector.js:

(WebInspector._hideSettingsScreen):
(WebInspector.documentKeyDown):

00:52 Changeset [99532] by yuqiang.xian@intel.com

DFG 32_64 - update make lists for efl, gtk, and Qt ports with DFG change r99519
https://bugs.webkit.org/show_bug.cgi?id=71768

Reviewed by Geoffrey Garen.

Also includes a fix to make the newly introduced AssemblyHelpers
friend of JSValue as we need the Tag definitions.

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • runtime/JSValue.h:
00:52 Changeset [99531] by philn@webkit.org

Unreviewed, mark 2 tests flaky in GTK.

  • platform/gtk/test_expectations.txt:

fast/forms/password-placeholder-text-security.html and
fast/lists/inlineBoxWrapperNullCheck.html are flaky.

00:43 Changeset [99530] by zimmermann@webkit.org

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix Snow Leopard 32bit builds.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseAspectRatio): CSSParserValue::fValue is a double, use narrowPrecisionToFloat() to convert double->float.
  • platform/ClockGeneric.cpp: Remove unneeded variable out of 32bit integer value range.
  • webaudio/BiquadDSPKernel.cpp: (WebCore::BiquadDSPKernel::getFrequencyResponse): Use narrowPrecisionTofloat() to convert double->float.
00:14 Changeset [99529] by yutak@chromium.org

[Chromium] Unreviewed gardening.

Rebaseline tests after r99454. Mark one SVG test as flaky.

  • platform/chromium-cg-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png.
  • platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.png: Added.
  • platform/chromium-mac/fast/borders/outline-alpha-block-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png: Removed.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.png:
  • platform/chromium/test_expectations.txt:
00:10 Changeset [99528] by hausmann@webkit.org

Touch the pro file to trigger a proper (re)build of the Makefile on
the bot (removed redundant line)

11/07/11:

23:49 Changeset [99527] by hausmann@webkit.org

[Qt][WK2] MiniBrowser should use urlFromUserInput()
https://bugs.webkit.org/show_bug.cgi?id=71680

Use urlFromUserInput() / QUrl::fromUserInput() to automatically
complete urls in MiniBrowser.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-07
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::load):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/utils.cpp:

(Utils::urlFromUserInput):

  • MiniBrowser/qt/utils.h:

(Utils::Utils):

23:32 Changeset [99526] by yuqiang.xian@intel.com

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
22:51 Changeset [99525] by yuqiang.xian@intel.com

Fix gcc 4.4 compilation warnings in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71762

Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::registersMatched):

22:49 Changeset [99524] by bashi@chromium.org

[Chromium] Layout Test platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71653

Reviewed by Kent Tamura.

  • platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html: Calls doTest() after iframe is loaded.
22:40 Changeset [99523] by dbates@webkit.org

Add CredentialStorage.cpp to WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=71748

Reviewed by Martin Robinson.

Adds CredentialStorage.cpp to WebCore/CMakeLists.txt since its provides a
base implementation of this feature.

Also adds a stub implementation of CredentialStorage to the WinCE port.

  • CMakeLists.txt: Added source file CredentialStorage.cpp.
  • CMakeListsEfl.txt: Added source file CredentialStorageCurl.cpp when building with the Curl networking backend.
  • CMakeListsWinCE.txt: Added source file CredentialStorageWin.cpp.
  • platform/network/win/CredentialStorageWin.cpp: Added.

(WebCore::Credential::getFromPersistentStorage): Stub implementation.

22:27 Changeset [99522] by ossy@webkit.org

[Qt] Unreviewed morning gardening, skip a failing new test: svg/custom/getBBox-path.svg.
https://bugs.webkit.org/show_bug.cgi?id=71766

  • platform/qt/Skipped:
22:12 Changeset [99521] by ravi.kasibhatla@motorola.com

Adding myself to the committer script.

22:03 Changeset [99520] by ossy@webkit.org

Unreviewed webkitpy test fix after r99512.

  • Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:

Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.

21:48 Changeset [99519] by fpizlo@apple.com

DFG code base should allow for classes not related to DFG::JITCompiler
to use DFG idioms
https://bugs.webkit.org/show_bug.cgi?id=71746

Reviewed by Gavin Barraclough.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAssemblyHelpers.cpp: Added.

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):

  • dfg/DFGAssemblyHelpers.h: Added.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::graph):

  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGOSRExit.h: Added.

(JSC::DFG::SpeculationRecovery::SpeculationRecovery):
(JSC::DFG::SpeculationRecovery::type):
(JSC::DFG::SpeculationRecovery::dest):
(JSC::DFG::SpeculationRecovery::src):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::isVariable):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):

  • dfg/DFGSpeculativeJIT.h:
20:44 Changeset [99518] by gyuyoung.kim@samsung.com

[EFL] Need to replace api's object parameter with proper name.
https://bugs.webkit.org/show_bug.cgi?id=71553

Fix wrong parameter names in tiled backing store functions and ewk_view_xxx files.

Reviewed by Filip Pizlo.

  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
20:31 Changeset [99517] by commit-queue@webkit.org

Add layout test for locale-based font selection
https://bugs.webkit.org/show_bug.cgi?id=67019

This test relies on overridePreference("WebKit*FontMap"...) which is
implemented only on Chromium DumpRenderTree so far.

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-11-07
Reviewed by Kent Tamura.

  • fast/text/international/locale-sensitive-fonts.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped: Added skip for non-Chromium ports.
  • platform/gtk-wk2/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
19:02 Changeset [99516] by fpizlo@apple.com

Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
but it appears to help on other benchmarks.

Rubber stamped by Oliver Hunt.

  • bytecode/ValueProfile.h:
18:41 Changeset [99515] by haraken@chromium.org

Remove [CustomGetter] IDL for window.Image of V8
https://bugs.webkit.org/show_bug.cgi?id=71739

Reviewed by Adam Barth.

Currently, window.Image uses a custom getter to get the template
of 'HTMLImageElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

fast/dom/image-object.html
fast/dom/gc-image-element.html
fast/dom/Window/custom-constructors.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
18:25 Changeset [99514] by cfleizach@apple.com

REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=71421

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectOption):

LayoutTests:

Re-enable test after removing an erroneous assert.

  • platform/mac/test_expectations.txt:
18:25 Changeset [99513] by ariya@webkit.org

"use strict" can not contain escape sequences or line continuation
https://bugs.webkit.org/show_bug.cgi?id=71532

Reviewed by Darin Adler.

Source/JavaScriptCore:

Store the actual literal length (before the escapes and line
continuation are encoded) while parsing the directive and use it
for the directive comparison.

  • parser/Parser.cpp:

(JSC::Parser::parseSourceElements):
(JSC::Parser::parseStatement):

  • parser/Parser.h:

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

(testLineContinuation): Added.
(testEscapeSequence): Added.

18:14 Changeset [99512] by wangxianzhu@chromium.org

Add myself as a committer.

18:11 Changeset [99511] by eae@chromium.org

Revert platform and scrolling to ints
https://bugs.webkit.org/show_bug.cgi?id=71585

Reviewed by Eric Seidel.

Replace all uses of LayoutUnit and related types with ints in platform
and scrolling code.

Source/WebCore:

No new tests.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/PopupMenuClient.h:
  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollAnimatorNone.h:
  • platform/ScrollView.cpp:
  • platform/ScrollView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::invalidateScrollbarRect):
(WebKit::BuiltInPDFView::visibleHeight):
(WebKit::BuiltInPDFView::visibleWidth):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
18:08 Changeset [99510] by haraken@chromium.org

Fixed wrong test results of fast/js/custom-constructors.html
https://bugs.webkit.org/show_bug.cgi?id=71669

Reviewed by Darin Adler.

According to the HTMLOptionElement spec
(http://dev.w3.org/html5/spec/the-button-element.html#the-option-element),
'text', 'label' and 'value' have neither [TreatUndefinedAs=EmptyString]
nor [TreatNullAs=EmptyString]. Thus, an undefined value should be
converted to a string "undefined" and a null value should be
converted to a string "null", following the step 3 of the IDL
conversion spec (http://dev.w3.org/2006/webapi/WebIDL/#es-DOMString).

Source/WebCore:

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement): Removed isUndefined() check from 'text' and 'value' since the spec does not have [TreatUndefinedAs=EmptyString].

  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:

(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.

  • html/HTMLOptionElement.idl: Removed [ConvertNullToNullString] from 'text', 'label' and 'value' since the spec does not have [TreatNullAs=EmptyString].

LayoutTests:

  • fast/dom/element-attribute-js-null-expected.txt: Fixed the test result.
  • fast/dom/element-attribute-js-null.html: Ditto.
  • fast/js/custom-constructors-expected.txt: Ditto.
  • fast/js/script-tests/custom-constructors.js: Ditto.
17:40 WebKit Team edited by yuqiang.xian@intel.com
add me to the committer list (diff)
17:37 Changeset [99509] by abarth@webkit.org

Move DomainRelaxationForbidden scheme registry to SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=71750

Reviewed by Eric Seidel.

Source/WebCore:

As stated in the FIXME, scheme registries belong in SchemeRegistry, not
in SecurityOrigin.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::setDomain):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
  • platform/SchemeRegistry.cpp:

(WebCore::schemesForbiddenFromDomainRelaxation):
(WebCore::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme):
(WebCore::SchemeRegistry::isDomainRelaxationForbiddenForURLScheme):

  • platform/SchemeRegistry.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDomainRelaxationForbidden):

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit/win:

  • WebView.cpp:

(WebView::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):

17:16 Changeset [99508] by mitz@apple.com

<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71743

Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.

16:59 Changeset [99507] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.

Reviewed by David Levin.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.h:
  • html/canvas/Float32Array.h:
  • html/canvas/Float64Array.h:
  • html/canvas/Int16Array.h:
  • html/canvas/Int32Array.h:
  • html/canvas/Int8Array.h:
  • html/canvas/TypedArrayBase.h:
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint8Array.h:
16:57 Changeset [99506] by abarth@webkit.org

addMessage's last few arguments should be optional
https://bugs.webkit.org/show_bug.cgi?id=70946

Reviewed by Darin Adler.

As requested by Darin Adler. I wanted to call this method addMessage,
but the compiler was unhappy locating the overload on
ScriptExecutionContext when Document had an override too. Changing the
name to addConsoleMessage made all the code happier.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addMessage):

  • dom/ScriptExecutionContext.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logUnrecognizedDirective):

  • page/EventSource.cpp:

(WebCore::EventSource::didReceiveResponse):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createLowPass2Filter):
(WebCore::AudioContext::createHighPass2Filter):

  • xml/XMLHttpRequest.cpp:

(WebCore::reportUnsafeUsage):

16:51 Changeset [99505] by abarth@webkit.org

WebWorkers fail with document.domain set when accessing from subdomain
https://bugs.webkit.org/show_bug.cgi?id=67978

Reviewed by Sam Weinig.

Source/WebCore:

Workers should ignore document.domain when deciding which URLs a
document can request, just like XMLHttpRequest and every other API.

Test: http/tests/workers/worker-document-domain-security.html

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Test that a document can still create same-origin workers after setting
document.domain.

  • http/tests/workers/worker-document-domain-security-expected.txt: Added.
  • http/tests/workers/worker-document-domain-security.html: Added.
16:44 Changeset [99504] by vangelis@chromium.org

Merge 98392 - LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/8491030

16:42 Changeset [99503] by vangelis@chromium.org

Merge 98185 - [chromium] Make setVisibility extension- and thread-correct
https://bugs.webkit.org/show_bug.cgi?id=70635

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

TBR=nduca@chromium.org
Review URL: http://codereview.chromium.org/8479052

16:37 Changeset [99502] by fpizlo@apple.com

DFG operationCreateThis slow path may get the wrong callee in case of inlining
https://bugs.webkit.org/show_bug.cgi?id=71647

Reviewed by Oliver Hunt.

No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:33 Changeset [99501] by tony@chromium.org

Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html

  • platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.
16:27 Changeset [99500] by commit-queue@webkit.org

Allow gamepad API to be enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=71736

Part of full patch, found at
https://bugs.webkit.org/show_bug.cgi?id=69451

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

No new tests. No new functionality.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):

16:21 Changeset [99499] by lforschler@apple.com

New tag.

16:10 Changeset [99498] by haraken@chromium.org

Remove [CustomGetter] IDL for window.Option of V8
https://bugs.webkit.org/show_bug.cgi?id=71735

Reviewed by Nate Chapin.

Currently, window.Option uses a custom getter to get the template
of 'HTMLOptionElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
15:57 Changeset [99497] by mhahnenberg@apple.com

De-virtualize JSObject::putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSObjectRef.cpp:

(JSObjectSetProperty):

(JSC::DebuggerActivation::putWithAttributes):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):

  • runtime/JSActivation.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putWithAttributes):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putWithAttributes):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putWithAttributes):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::putWithAttributes):

  • runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putWithAttributes):

  • bindings/js/JSDOMWindowShell.h:
15:53 Changeset [99496] by tony@chromium.org

[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html

  • platform/chromium/test_expectations.txt:
15:49 Changeset [99495] by dslomov@google.com

Unreviewed. Release build fix.

  • parser/Lexer.cpp:

(JSC::assertCharIsIn8BitRange):

15:46 Changeset [99494] by commit-queue@webkit.org

Unreviewed, rolling out r99470.
http://trac.webkit.org/changeset/99470
https://bugs.webkit.org/show_bug.cgi?id=71740

"Broke test-webkitpy" (Requested by eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

  • Scripts/webkitpy/common/config/watchlist:
15:45 Changeset [99493] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71490
Support uiStateTransitionProgress for scrollbars
-and corresponding-
<rdar://problem/9849612>

Reviewed by Sam Weinig.

Source/WebCore:

Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has
entered or exited a scrollbar. These changes to Scrollbar pass that information
on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a
PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not
always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if
the mouse has exited the scrollbar.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):

  • platform/Scrollbar.h:

These changes are required now that Scrollbar::mouseUp() takes a parameter.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::handleMouseReleaseEvent):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::wndProc):

ScrollAnimator passes the information on to AppKit.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::mouseEnteredScrollbar):
(WebCore::ScrollAnimator::mouseExitedScrollbar):

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

There are several new pieces of AppKit api we must call into.

  • platform/mac/NSScrollerImpDetails.h:

This is a temporary function that is needed for the time being since there is new
AppKit api required for this to work.

  • platform/mac/ScrollAnimatorMac.mm:

(supportsUIStateTransitionProgress):

I refactored WebScrollbarPartAnimation so that it can handle the
uiStateTransitionProgress animation as well as the alpha animations it already
handled. This mostly involved re-naming things and making use of a new enum called
FeatureToAnimate which keeps track of what the instance of
WebScrollbarPartAnimation is animating.
(-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation setScrollbarPainter:]):
(-[WebScrollbarPartAnimation setStartValue:]):
(-[WebScrollbarPartAnimation setEndValue:]):
(-[WebScrollbarPartAnimation setCurrentProgress:]):

WebScrollbarPainterDelegate has two new animations,
_verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It
also responds to a few new delegate calls.
(-[WebScrollbarPainterDelegate cancelAnimations]):

This is a new delegate call needed for uiStateTransitionProgress.
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things
that are specific to the alpha animation and I chose not to re-use it for
uiStateTransition.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

New delegate call for the uiStateTransition animation that sets up that animation
and kicks it off.
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

Source/WebKit/chromium:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::onMouseUp):

Source/WebKit/win:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • WebScrollBar.cpp:

(WebScrollBar::handleMouseEvent):

Source/WebKit2:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::onLButtonUp):

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::handleMouseEvent):

15:43 Changeset [99492] by aboxhall@chromium.org

Remove unnecessary use of function pointer in FrameSelection::modify()
https://bugs.webkit.org/show_bug.cgi?id=71646

Reviewed by Ryosuke Niwa.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modify):

15:39 Changeset [99491] by andreas.kling@nokia.com

Unreviewed Windows build fix after r99468.

  • css/CSSPrimitiveValue.h: Unmark single-argument constructors

as explicit, since this conflicts with the template constructors
in CSSPrimitiveValueMappings.h.

15:25 Changeset [99490] by jer.noble@apple.com

Build fix due to a erroneous search-and-replace.

Unreviewed build fix.

Replace all instances of GenericClock with ClockGeneric.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):

15:20 Changeset [99489] by abarth@webkit.org

Move parseSandboxPolicy to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=71732

Reviewed by Eric Seidel.

As requested by Eric, this patch resolves a layering inversion. Now
that we have SecurityContext to hold the sandbox bits and the origin,
it's a logical place to put the parser for sandbox policies.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

  • dom/SecurityContext.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::applySandboxPolicy):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
15:17 Changeset [99488] by jer.noble@apple.com

Rename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing source.
https://bugs.webkit.org/show_bug.cgi?id=71702

Reviewed by Sam Weinig.

No new tests; covered by existing tests.

  • platform/Clock.cpp:

(Clock::create):

  • platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp.

(ClockGeneric::GenericClock):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):

  • platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h.

(WebCore::ClockGeneric::playRate):
(WebCore::ClockGeneric::isRunning):

Boilerplate project file changes:

  • CMakeLists.txt:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
15:16 Changeset [99487] by tony@chromium.org

[chromium] disable 2 tests that are slow in debug

  • platform/chromium/test_expectations.txt: only run

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
in release builds

15:08 Changeset [99486] by fpizlo@apple.com

Switch the value profiler back to 8 buckets, because we suspect that while this
is more expensive it's also more stable.

Rubber stamped by Geoff Garen.

  • bytecode/ValueProfile.h:
15:03 Changeset [99485] by vangelis@chromium.org

Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
https://bugs.webkit.org/show_bug.cgi?id=71714

Reviewed by James Robinson.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForScrollableFrames):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
https://bugs.webkit.org/show_bug.cgi?id=71714

Adjust the force-compositing-mode layout tests to explicitly set the new flag.

Reviewed by James Robinson.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
14:55 Changeset [99484] by commit-queue@webkit.org

[MutationObservers] Fix mac build (with mutation_observers enabled)
https://bugs.webkit.org/show_bug.cgi?id=71728

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

Errant forward declaration of MutationObserverRegistration removed from
Node.h this would have broken a port that tried to build with mutation_observers=1.

  • dom/Node.h:
14:51 Changeset [99483] by ap@apple.com

The Full Keyboard Access preference should be read in the UI process
https://bugs.webkit.org/show_bug.cgi?id=71734
<rdar://problem/9237619>

Reviewed by Darin Adler.

This is consistent with how other global preferences (like language) are handled, and lets
us tighten up the sandbox a little.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: Added fullKeyboardAccessEnabled, so that newly started processes have the right preference value.
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::fullKeyboardAccessModeChanged): If preference changes while a web process is already running, tell it. (WebKit::WebContext::ensureWebProcess): Set parameters.fullKeyboardAccessEnabled from current preference.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
  • UIProcess/WebProcessProxy.h: Proxy it to Objective-C code. WebProcessProxy is as good place to have the static function as any. One day, we will make code more consistent with language and other global preferences.
  • UIProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.h.
  • UIProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.mm.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.h: Removed.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Removed. (-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): Once retrieved, push the preference value.
  • WebKit2.xcodeproj/project.pbxproj: WKFullKeyboardAccessWatcher is now in UI process.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::fullKeyboardAccessModeChanged): (WebKit::WebProcess::fullKeyboardAccessEnabled):
  • WebProcess/mac/WebProcessMac.mm: WebCprocess now holds the preference value in a mamber value, which UI process pushes updates to.
  • WebProcess/WebProcess.messages.in: Added a message for changes preference value.
  • WebProcess/com.apple.WebProcess.sb: We no longer need read access to com.apple.universalaccess.plist.
14:46 Changeset [99482] by tony@chromium.org

Update chromium test_expectations.txt.

  • platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png:

Fix result that was attempted to be fixed in r99457.

  • platform/chromium/test_expectations.txt: Tests that need a baseline

after 99454.

14:39 Changeset [99481] by haraken@chromium.org

Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
https://bugs.webkit.org/show_bug.cgi?id=71660

Reviewed by Adam Barth.

Currently, "new Audio()" uses a custom getter to get the template
of 'HTMLAudioElementConstructor'. However, this getter does not need to
be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): If an IDL type is 'XXXXConstructorConstructor', then we do not add a header file 'XXXXConstructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class XXXX 'XXXX.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'XXXXConstructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8.

14:38 Changeset [99480] by commit-queue@webkit.org

[EFL] Emit the "frame,created" signal earlier.
https://bugs.webkit.org/show_bug.cgi?id=71696

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-07
Reviewed by Kenneth Rohde Christiansen.

FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
emitting the "frame,created" signal after that, applications would connect to
it after some other frame signals had already been emitted. Should help tests
such as http/tests/loading/empty-subframe.html pass.

  • ewk/ewk_frame.cpp:

(ewk_frame_child_add):

  • ewk/ewk_view.cpp:

(ewk_view_frame_create):

14:35 Changeset [99479] by tony@chromium.org

Layout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing
https://bugs.webkit.org/show_bug.cgi?id=71606

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt: Remove the expected failure.
14:31 Changeset [99478] by tony@chromium.org

[chromium] update flakiness dashboard to reflect current bots

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js: Remove (deps) debug

bots and merged linux debug bots into a single bot.

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(setupExpectationsTest):

14:20 Changeset [99477] by commit-queue@webkit.org

Uninitialized Heap member var
https://bugs.webkit.org/show_bug.cgi?id=71722

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-11-07
Reviewed by Filip Pizlo.

  • heap/Heap.cpp:

(JSC::Heap::Heap): Initialize m_blockFreeingThreadShouldQuit

14:13 Changeset [99476] by yuqiang.xian@intel.com

DFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible
https://bugs.webkit.org/show_bug.cgi?id=71684

Reviewed by Filip Pizlo.

Currently in DFG JIT, we try to reuse the physical register of an
operand for temporary usage if the current use of the operand is the
last use. But sometimes this can be wrong, for example if there are
possible speculation failures and we need to fallback to baseline JIT,
the value of the operand which is supposed to be hold in the physical
register can be modified by register reusing. The fixes the last
inspector failures in layout test on Mac 32-bit if switching on DFG.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

14:13 Changeset [99475] by lforschler@apple.com

Versioning.

14:10 Changeset [99474] by rniwa@webkit.org

REGRESSION(r99436): Broke Snow Leopard debug build
https://bugs.webkit.org/show_bug.cgi?id=71713

Reviewed by Darin Adler.

Put the assertion in a template and use template specialization
to avoid warning when instantiated with UChar or LChar.

In the long term, we should have traits for unsigned integral types
and use that to specialize template instead of specializing it for UChar and LChar.

  • parser/Lexer.cpp:

(JSC::assertCharIsIn8BitRange):
(JSC::::append8):

14:09 Changeset [99473] by andersca@apple.com

Add TiledCoreAnimationDrawingArea stub classes
https://bugs.webkit.org/show_bug.cgi?id=71729

Reviewed by Sam Weinig.

  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _shouldUseTiledDrawingArea]):
(-[WKView WebKit::]):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.

(WebKit::TiledCoreAnimationDrawingAreaProxy::create):
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::~TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.

(WebKit::TiledCoreAnimationDrawingArea::create):
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):

14:03 Changeset [99472] by commit-queue@webkit.org

[chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs
https://bugs.webkit.org/show_bug.cgi?id=71694

Patch by Robert Sesek <rsesek@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
13:59 Changeset [99471] by dominicc@chromium.org

Remove initPopStateEvent method
https://bugs.webkit.org/show_bug.cgi?id=71691

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/PopStateEvent.cpp:
  • dom/PopStateEvent.h:
  • dom/PopStateEvent.idl:

LayoutTests:

  • fast/events/fire-popstate-event.html: use 'new PopStateEvent' now
13:30 Changeset [99470] by commit-queue@webkit.org

Add cc-bugs group to watch changes in chromium graphics
https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-07
Reviewed by James Robinson.

  • Scripts/webkitpy/common/config/watchlist:
13:20 Changeset [99469] by commit-queue@webkit.org

[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
https://bugs.webkit.org/show_bug.cgi?id=70912

Patch by Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu> on 2011-11-07
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
13:19 Changeset [99468] by andreas.kling@nokia.com

CSSValue: Devirtualize isFooType().
<http://webkit.org/b/71668>

Reviewed by Darin Adler.

Add a member to CSSValue to determine which subclass a given
value object is, along with 5 bits to tell us whether the
value is primitive/mutable/initial/inherited/a list.

All non-private subclass constructors now take CSSValue::ClassType
as their first argument. A few constructors were duplicated as
private members to allow calling them from ::create() methods
without passing an explicit ClassType.

Furthermore, since CSSValue::cssValueType() can be inferred from
the subclass type, we compute it instead of storing it in a member.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Adding CSSValue.cpp.

  • css/CSSValue.cpp: Added.

(WebCore::CSSValue::cssValueType):

Out-of-line implementation of this method. Only used by CSSOM.

  • css/CSSValue.h:

(WebCore::CSSValue::isMutableValue):
(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isBorderImageValue):
(WebCore::CSSValue::isBorderImageSliceValue):
(WebCore::CSSValue::isCursorImageValue):
(WebCore::CSSValue::isFontFamilyValue):
(WebCore::CSSValue::isFontFeatureValue):
(WebCore::CSSValue::isFontValue):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isReflectValue):
(WebCore::CSSValue::isShadowValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::isWebKitCSSTransformValue):
(WebCore::CSSValue::isCSSLineBoxContainValue):
(WebCore::CSSValue::isFlexValue):
(WebCore::CSSValue::isWebKitCSSFilterValue):
(WebCore::CSSValue::isSVGColor):
(WebCore::CSSValue::isSVGPaint):
(WebCore::CSSValue::classType):
(WebCore::CSSValue::CSSValue):
(WebCore::CSSValue::isPrimitiveType):
(WebCore::CSSValue::isListType):
(WebCore::CSSValue::isMutableType):
(WebCore::CSSValue::isInheritedType):
(WebCore::CSSValue::isInitialType):

Store subclass type information into a member variable and
made all the isFooValue() functions non-virtual and inline.
Some subclass type lookups (primitive values, notably) are
cached in a bool member on construction.

  • css/CSSAspectRatioValue.h:

(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):

  • css/CSSBorderImageSliceValue.h:
  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):

  • css/CSSBorderImageValue.h:
  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::CSSCanvasValue):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::CSSCursorImageValue):

  • css/CSSCursorImageValue.h:
  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::CSSFlexValue):

  • css/CSSFontFaceSrcValue.h:

(WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::CSSFunctionValue):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isLinearGradient):
(WebCore::CSSGradientValue::isRadialGradient):
(WebCore::CSSGradientValue::CSSGradientValue):
(WebCore::CSSLinearGradientValue::CSSLinearGradientValue):
(WebCore::CSSRadialGradientValue::CSSRadialGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):

  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::CSSInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):
(WebCore::CSSInitialValue::create):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):

  • css/CSSLineBoxContainValue.h:
  • css/CSSMutableValue.h:

(WebCore::CSSMutableValue::CSSMutableValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSReflectValue.h:

(WebCore::CSSReflectValue::CSSReflectValue):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSTimingFunctionValue::isLinearTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isStepsTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue):
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):

  • css/CSSUnicodeRangeValue.h:

(WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:
  • css/FontFamilyValue.cpp:

(WebCore::FontFamilyValue::FontFamilyValue):

  • css/FontFamilyValue.h:
  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::FontFeatureValue):

  • css/FontFeatureValue.h:
  • css/FontValue.h:

(WebCore::FontValue::FontValue):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::ShadowValue):

  • css/ShadowValue.h:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

  • css/WebKitCSSTransformValue.h:
  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::SVGPaint):

  • svg/SVGPaint.h:

Propagate subclass type information and kill isFooType() virtuals.

13:14 Changeset [99467] by mihnea@adobe.com

Leaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=71259

Reviewed by Darin Adler.

Leak fixes covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
The RenderBoxRegionInfo taken out of RenderRegion must be deleted on all code paths.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::removeRenderBoxRegionInfo):
The RenderBoxRegionInfo map owns the values, therefore, when values are removed from map
they must also be deleted.

13:07 WebKit Team edited by haraken@chromium.org
(diff)
13:05 Changeset [99466] by abarth@webkit.org

iframe sandbox treats vertical tab as a valid delimiter
https://bugs.webkit.org/show_bug.cgi?id=71704

Reviewed by Eric Seidel.

Source/WebCore:

This patch adjusts our parser slightly to match the HTML5 spec. The
only difference is in how we handle vertical tabs. Previously, we
treated them as a delimiter, but we're not supposed to do that.

Test: fast/frames/sandboxed-iframe-parsing-space-characters.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

LayoutTests:

Test which space-like charaters are treating as delimiters.

  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt: Added.
  • fast/frames/sandboxed-iframe-parsing-space-characters.html: Added.
13:01 Changeset [99465] by andersca@apple.com

Follow-up build fix.

  • WebProcess/WebPage/DrawingAreaImpl.h:
13:01 Changeset [99464] by abarth@webkit.org

Factor SecurityContext out of ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=71721

Reviewed by Eric Seidel.

The new SecurityContext object lets us tightly scope control of
the security-critical information in ScriptExecutionContext.
Originally I had hoped to put all this state on SecurityOrigin, but
SecurityOrigin gets shared between documents in some corner cases, so
it's not a good fit for state like the sandbox flags and the CSP policy
that really needs to be per-document.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • page/SecurityOrigin.h:
12:50 Changeset [99463] by haraken@chromium.org

Refactor CodeGeneratorV8.pm before making a core change for bug 71093.
https://bugs.webkit.org/show_bug.cgi?id=71659

Reviewed by Adam Barth.

Just refactor CodeGeneratorV8.pm without any change in behavior,
as the first step for fixing bug 71093.

Tests: WebCore/bindings/scripts/test/TestObj.idl

WebCore/bindings/scripts/test/TestInterface.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new TestXXXX.idl is added.
(GenerateConstructorCallback): Renamed variables to clarify their roles.
(WriteData): Removed an unused array @implHeaderContent.

  • bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result.
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
12:48 Changeset [99462] by commit-queue@webkit.org

Crash due to mixed direction text runs
https://bugs.webkit.org/show_bug.cgi?id=66015

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-07
Reviewed by David Hyatt.

Source/WebCore:

Test for bug fix.

  • fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added
  • fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added

LayoutTests:

In some cases extra bidi runs were being added because appendRun() was being called
after the last run of the line was already appended.

This converts a previous fix for this bug to an ASSERT, because the check is
unnecessary, though it is a symptom that text runs have somehow gotten messed up.

  • rendering/InlineIterator.h:

(WebCore::InlineBidiResolver::appendRun): Abort append if we've already appended the last
run of the line

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Revert the previous patch, change to an assert

12:42 Changeset [99461] by eric@webkit.org

new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=62199

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12:40 Changeset [99460] by timothy_horton@apple.com

getBBox() on a SVGPathElement with curves incorrectly includes control points
https://bugs.webkit.org/show_bug.cgi?id=53512
<rdar://problem/9861154>

Reviewed by Oliver Hunt.

Split Path::boundingRect() into two, adding Path::fastBoundingRect()
for a rough estimate of the bounding rect (always equal to or larger
than boundingRect()). fastBoundingRect() currently falls back to
boundingRect() for all ports besides CG, though in most cases
(on a port-by-port basis) the current implementation of boundingRect()
will need to become fastBoundingRect(), and a new, more accurate method will
be implemented for boundingRect().

All previous callers of boundingRect() are transitioned to using fastBoundingRect()
except SVGPathElement::getBBox, which wants an accurate bounding box.

The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.

Test: svg/custom/getBBox-path.svg

  • html/HTMLAreaElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGPath.cpp:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:

Add a test that ensures that getBBox does not include control points in the rect it returns.

  • platform/chromium/test_expectations.txt:
  • svg/custom/getBBox-path-expected.txt: Added.
  • svg/custom/getBBox-path.svg: Added.
12:37 Changeset [99459] by vsevik@chromium.org

Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
https://bugs.webkit.org/show_bug.cgi?id=71710

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):

12:35 Changeset [99458] by vsevik@chromium.org

Web Inspector: Suggest box should consume enter key pressed event.
https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.evaluateInConsole):

12:29 Changeset [99457] by robert@webkit.org

[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=71214

Reviewed by Adam Barth.

  • platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
12:26 Changeset [99456] by vestbo@webkit.org

[Qt] Build all libraries in both debug and release on Mac OS X

We were already building the final shared library in debug and release,
but were missing the static JavaScriptCore and WebCore libraries, which
then broke the build.

Reviewed-by Andreas Kling.

12:21 Changeset [99455] by andersca@apple.com

Remove unused DrawingArea::syncCompositingLayers
https://bugs.webkit.org/show_bug.cgi?id=71717

Reviewed by John Sullivan.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
12:18 Changeset [99454] by commit-queue@webkit.org

Optimize outline rendering to avoid transparency layers
https://bugs.webkit.org/show_bug.cgi?id=60750

Source/WebCore:

Add fast path for solid block outlines with alpha.
Improve readability of piecewise path while at it.

Patch by David Barr <davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

Rebaseline pixel tests to accommodate subtle change in rounding.

Patch by David Barr <davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

  • platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Added.
12:09 Changeset [99453] by vsevik@chromium.org

Web Inspector: Suggest box should not accept suggestion on space key pressed.
https://bugs.webkit.org/show_bug.cgi?id=71706

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):

11:46 Changeset [99452] by japhet@chromium.org

Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:

TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/8493015

11:32 Changeset [99451] by tony@chromium.org

[chromium] Mark perf/documnet-contians.html as slow.

  • platform/chromium/test_expectations.txt:
11:20 Changeset [99450] by andreas.kling@nokia.com

Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
<http://webkit.org/b/71679>

Reviewed by Darin Adler.

Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue()
and isInheritedValue() to increase code clarity.

The plan is to turn cssValueType() into a computed value based on the
CSSValue subclass (coming soon to <http://webkit.org/b/71668>.)
This is a clean-up in preparation for that.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):

  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::isInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::isInitialValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillAttachment):
(WebCore::CSSStyleSelector::mapFillClip):
(WebCore::CSSStyleSelector::mapFillComposite):
(WebCore::CSSStyleSelector::mapFillOrigin):
(WebCore::CSSStyleSelector::mapFillImage):
(WebCore::CSSStyleSelector::mapFillRepeatX):
(WebCore::CSSStyleSelector::mapFillRepeatY):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::mapAnimationDelay):
(WebCore::CSSStyleSelector::mapAnimationDirection):
(WebCore::CSSStyleSelector::mapAnimationDuration):
(WebCore::CSSStyleSelector::mapAnimationFillMode):
(WebCore::CSSStyleSelector::mapAnimationIterationCount):
(WebCore::CSSStyleSelector::mapAnimationName):
(WebCore::CSSStyleSelector::mapAnimationPlayState):
(WebCore::CSSStyleSelector::mapAnimationProperty):
(WebCore::CSSStyleSelector::mapAnimationTimingFunction):

  • css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isInitialValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

11:20 Changeset [99449] by andersca@apple.com

Rename NetscapePlugin::wantsWindowRelativeNPWindowCoordinates to NetscapePlugin::wantsPluginRelativeNPWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71708

Reviewed by Sam Weinig.

The name wantsPluginRelativeNPWindowCoordinates is more clear than wantsWindowRelativeNPWindowCoordinates. Rename the functions
everywhere and, since the meaning is now inverted, invert the checks and return values.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

11:20 Changeset [99448] by andersca@apple.com

NetscapePlugin::wantsWindowRelativeNPWindowCoordinates should return false on Mac
https://bugs.webkit.org/show_bug.cgi?id=71707

Reviewed by Sam Weinig.

This changes the way the fake Carbon plug-in window is positioned, so that it's always the same size
and location as the plug-in (relative to the screen).

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformGeometryDidChange):
Call updateFakeWindowBounds.

(WebKit::NetscapePlugin::updateFakeWindowBounds):
Convert the plug-in position to screen coordinates and set the window bounds to be the location and
size of the plug-in, where the location is relative to the screen.

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Return false.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Call updateFakeWindowBounds.

11:12 Changeset [99447] by ossy@webkit.org

Unreviewed, rolling out r99432.
http://trac.webkit.org/changeset/99432
https://bugs.webkit.org/show_bug.cgi?id=71709

It made layout tests extra slow on all bots (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

11:10 Changeset [99446] by lforschler@apple.com

New Branch.

11:10 Changeset [99445] by lforschler@apple.com

New Branch.

11:09 Changeset [99444] by andreas.kling@nokia.com

REGRESSION(r99409): Broke transitions/clip-transition.html
<http://webkit.org/b/71692>

Reviewed by Darin Adler.

Add missing base class initializers to CSSPrimitiveValue constructors.
This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

10:46 Changeset [99443] by weinig@apple.com

WKPage.h should be in PrivateHeaders.

Rubber-stamped by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Mark WKPage.h private.

10:28 Changeset [99442] by commit-queue@webkit.org

[EFL] Support requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=67112

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-11-07
Reviewed by Andreas Kling.

.:

Add build-option for requestAnimationFrame feature.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.

  • wtf/Platform.h:

Source/WebCore:

Add some files to build-target when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • CMakeLists.txt:
  • UseJSC.cmake:
10:26 Changeset [99441] by weinig@apple.com

Add missing .in and .pl files to the Xcode project for easy access.

Reviewed by Eric Carlson.

  • WebCore.xcodeproj/project.pbxproj:

Add some missing files to the Xcode project.

10:24 Changeset [99440] by fsamuel@chromium.org

[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=71485

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Created new method setPageScaleFactor to replace scalePage to match
renamed method in WebCore. This change will happen in three stages:

  1. A new method is created called setPageScaleFactor with the same functionality as scalePage.
  2. All call sites of scalePage are changed to setPageScaleFactor in the Chromium repository.
  3. scalePage is deleted from WebView/WebViewImpl
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):
(WebKit::WebViewImpl::scalePage):
(WebKit::WebViewImpl::setPageScaleFactor):

  • src/WebViewImpl.h:

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

10:16 Changeset [99439] by jberlin@webkit.org

Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
enabled.
https://bugs.webkit.org/show_bug.cgi?id=71631

Reviewed by Jon Honeycutt.

Source/WebCore:

Check the SchemeRegistry before preventing read/write access to Local Storage and Databases
in Private Browsing.

  • WebCore.exp.in:

Export the symbols for registering the schemes as allowing Local Storage and Database access
in Private Browsing.

  • dom/Document.cpp:

(WebCore::Document::allowDatabaseAccess):
Check if the scheme allows Database access in Private Browsing.

  • platform/SchemeRegistry.cpp:

(WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing):

  • platform/SchemeRegistry.h:
  • storage/Storage.cpp:

(WebCore::Storage::length):
Ask the storage area if it is disabled by Private Browsing in the frame instead of just
checking if Private Browsing is enabled for that frame because the answer might depend on
what type of storage that storage area is.
(WebCore::Storage::key):
Ditto.
(WebCore::Storage::getItem):
Ditto.
(WebCore::Storage::contains):
Ditto.

  • storage/StorageArea.h:

Make it possible to query a StorageArea for whether it is disabled by Private Browsing in a
Frame.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
Renamed from privateBrowsingEnabled.
Check not only if Private Browsing is enabled for the Frame, but also if the storage type is
Local Storage and if there is an exception for the scheme of the resource currently loaded
into the Frame.
(WebCore::StorageAreaImpl::setItem):
Renamed privateBrowsingEnabled -> disabledByPrivateBrowsingInFrame.
(WebCore::StorageAreaImpl::removeItem):
Ditto.
(WebCore::StorageAreaImpl::clear):
Ditto.

  • storage/StorageAreaImpl.h:

Source/WebKit/chromium:

  • src/StorageAreaProxy.h:

(WebCore::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Chromium uses a different method to track its icognito mode, so always return false.

Source/WebKit/mac:

Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
Databases.

  • WebView/WebView.mm:

(+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
Call through to the SchemeRegistry function.
(+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
Ditto.

  • WebView/WebViewPrivate.h:
10:04 Changeset [99438] by dominicc@chromium.org

Remove initCloseEvent method
https://bugs.webkit.org/show_bug.cgi?id=71374

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

  • websockets/CloseEvent.h:

(WebCore::CloseEvent::initCloseEvent):

  • websockets/CloseEvent.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
10:00 Changeset [99437] by andersca@apple.com

Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=71699

Reviewed by Sam Weinig.

Source/WebCore:

Export AffineTransform symbols used by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Add a getScreenTransform function which given a coordinate space returns a transform that converts a
point from that coordinate space to the screen coordinate space. We then get the source -> screen transform
and the destination -> screen transform. We invert the destination -> screen transform, multiply it with the
source -> screen transform and use mapPoint to get a complete affine transform from the source to the destination space
and use mapPoint to map the source point and return the destination point.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::getScreenTransform):
(WebKit::NetscapePlugin::convertPoint):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
Call windowAndViewFramesChanged before viewGeometryDidChange so that the window and view frames will be up to date by
the time NPP_SetWindow is called in the plug-in.

09:54 Changeset [99436] by msaboff@apple.com

Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
https://bugs.webkit.org/show_bug.cgi?id=71331

Source/JavaScriptCore:

Change the Lexer class to be a template class based on the character
type of the source. In the process updated the parseIdentifier()
and parseString() methods to create 8 bit strings where possible.
Also added some helper methods for accumulating temporary string
data in the 8 and 16 bit vectors.

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.

Updated the KeywordLookup generator to create code to match keywords
for both 8 and 16 bit source strings.

Due to a compiler bug (<rdar://problem/10194295>) moved enum
definition outside of Lexer class declaration. Remove second enum
no longer needed.

Reviewed by Darin Adler.

  • KeywordLookupGenerator.py:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

  • parser/Lexer.cpp:

(JSC::::Lexer):
(JSC::::~Lexer):
(JSC::::getInvalidCharMessage):
(JSC::::currentCharacter):
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::peek):
(JSC::::getUnicodeCharacter):
(JSC::::shiftLineTerminator):
(JSC::::lastTokenWasRestrKeyword):
(JSC::::record8):
(JSC::::append8):
(JSC::::append16):
(JSC::::record16):
(JSC::::parseIdentifier):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::parseHex):
(JSC::::parseOctal):
(JSC::::parseDecimal):
(JSC::::parseNumberAfterDecimalPoint):
(JSC::::parseNumberAfterExponentIndicator):
(JSC::::parseMultilineComment):
(JSC::::nextTokenIsColon):
(JSC::::lex):
(JSC::::scanRegExp):
(JSC::::skipRegExp):
(JSC::::clear):
(JSC::::sourceCode):

  • parser/Lexer.h:

(JSC::Lexer::append16):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffsetFromCharOffset):
(JSC::::isWhiteSpace):
(JSC::::isLineTerminator):
(JSC::::convertHex):
(JSC::::convertUnicode):
(JSC::::makeIdentifier):
(JSC::::setCodeStart):
(JSC::::makeIdentifierLCharFromUChar):
(JSC::::lexExpectIdentifier):

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::parseProperty):
(JSC::Parser::parseMemberExpression):

  • parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):

  • parser/SourceCode.h:

(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::stringData):

  • parser/SourceProviderCache.h:
  • parser/SyntaxChecker.h:
  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::add):
(JSC::IdentifierLCharFromUCharTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::equal):
(JSC::IdentifierLCharFromUCharTranslator::translate):
(JSC::Identifier::add8):

  • runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::createLCharFromUChar):
(JSC::Identifier::canUseSingleCharacterString):
(JSC::IdentifierCharBufferTranslator::hash):
(JSC::IdentifierCharBufferTranslator::equal):
(JSC::IdentifierCharBufferTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::equal):
(JSC::IdentifierTable::add):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseIntOverflow):
(JSC::globalFuncUnescape):

  • runtime/JSGlobalObjectFunctions.h:

(JSC::parseIntOverflow):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lexString):

  • wtf/text/StringImpl.h:

Source/WebCore:

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.
Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

No new tests - refactored SourceProvider class and sub-classes.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::stringData):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::stringData):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

Source/WebKit/qt:

Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

09:51 Changeset [99435] by dominicc@chromium.org

Remove initOverflowEvent from JavaScript bindings
https://bugs.webkit.org/show_bug.cgi?id=71687

Reviewed by Ojan Vafai.

Source/WebCore:

Now that OverflowEvent has a constructor, we don't need the
initOverflowEvent method. It has to remain in the Objective C
binding because it is part of the Objective C public API.

  • dom/OverflowEvent.idl:

LayoutTests:

OverflowEvent initialization is tested in
fast/events/constructors/overflow-event-constructor.html

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
09:48 Changeset [99434] by noel.gordon@gmail.com

Refactor canvas encoding mimeType validation
https://bugs.webkit.org/show_bug.cgi?id=71651

Reviewed by Andreas Kling.

No new tests, refactoring only, covered by existing canvas tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toEncodingMimeType): move encoder mimeType
validation logic into a helper routine.
(WebCore::HTMLCanvasElement::toDataURL):

  • html/HTMLCanvasElement.h:
09:43 Changeset [99433] by philn@webkit.org

[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71655

Reviewed by Martin Robinson.

  • fast/frames/flattening/frameset-flattening-simple.html: Trigger

the test only after the embedded frame has been loaded.

09:36 Changeset [99432] by vsevik@chromium.org

Web Inspector: Suggest box should consume enter key pressed event.
https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

09:16 Changeset [99431] by dominicc@chromium.org

Remove initPageTransitionEvent method
https://bugs.webkit.org/show_bug.cgi?id=71689

Reviewed by Ojan Vafai.

initPageTransitionEvent was removed from the HTML spec; it has
been replaced by new PageTransitionEvent(...).

Removing a method, so no new tests.

  • dom/PageTransitionEvent.cpp:
  • dom/PageTransitionEvent.h:
  • dom/PageTransitionEvent.idl:
09:15 Changeset [99430] by apavlov@chromium.org

Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place
https://bugs.webkit.org/show_bug.cgi?id=71676

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):

  • inspector/front-end/inspectorCommon.css:

(body): Revert inadvertent style change from a preceding commit.

08:51 Changeset [99429] by vestbo@webkit.org

Fix the Qt build on Mac OS X when using the QuickTime media backend

When QtWebKit is built on Mac OS X using the QuickTime media backend
we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so
we have to guard the potentially duplicate symbol createCFURL with
more than just !PLATFORM(MAC).

Reviewed by Andreas Kling.

08:51 Changeset [99428] by vestbo@webkit.org

[Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree

Allows us to not package up the whole Source/JavaScriptCore directory for the
buildbots.

Reviewed-by Simon Hausmann.

08:48 Changeset [99427] by pfeldman@chromium.org

2011-11-07 Pavel Feldman <pfeldman@google.com>

Not reviewed: follow up to r99407. Style the suggest box.
https://bugs.webkit.org/show_bug.cgi?id=65511

  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/inspector.css:
  • inspector/front-end/textPrompt.css:
08:31 Changeset [99426] by rolandsteiner@chromium.org

https://bugs.webkit.org/show_bug.cgi?id=70223
CSSStyleSheet: finding the owner node should be in its own method

Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0.

Reviewed by Dimitri Glazkov.

No new tests. (refactoring)

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::styleSheetOwnerNode):
(WebCore::CSSStyleSheet::document):

  • css/CSSStyleSheet.h:
08:24 Changeset [99425] by kenneth@webkit.org

[Qt] Put handling of gestures and their interaction in one place
https://bugs.webkit.org/show_bug.cgi?id=71682

Reviewed by Simon Hausmann.

Before this patch, the interaction (ie. cancelling animations, events)
was handled in the respective recognizers which then knew about each
others.

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit::QtGestureRecognizer::isRecognized):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtTouchWebPageProxy.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScrollAnimation):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::scaleAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScaleAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):

  • UIProcess/qt/QtViewportInteractionEngine.h:
07:58 Changeset [99424] by hausmann@webkit.org

[Qt] Make it possible to include qdesktopwebview.h from apps

Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qdesktopwebview.h: Don't include C API headers, forward

declare the structs manually.

07:43 Changeset [99423] by hausmann@webkit.org

[Qt] More gardening. Skip keygen related tests.

Rubber-stamped by Ossy.

  • platform/qt/Skipped: We don't support <keygen>, so group

the keygen failures and add a comment.

07:22 Changeset [99422] by hausmann@webkit.org

[Qt] Gardening, unskip tests that appear to pass now.

Rubber-stamped by Ossy.

  • platform/qt/Skipped:
06:43 Changeset [99421] by vestbo@webkit.org

[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit

Reviewed-by Simon Hausmann.

06:43 Changeset [99420] by vestbo@webkit.org

[Qt] Sanitize qmake paths correctly before comparing

The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
which caused us to always generate derived webcore sources, but never build
them. The bug has been fixed, and we now also sanitize paths for the injected
bundle derived sources.

Reviewed-by Simon Husmann.

06:42 Changeset [99419] by vestbo@webkit.org

[Qt] Print right order for changing feature defines

Reviewed by Simon Hausmann.

06:32 Changeset [99418] by hausmann@webkit.org

[Qt] Fix failing inspector tests after build system changes https://bugs.webkit.org/show_bug.cgi?id=71677

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

  • Api/qwebpage.cpp:

(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(initResources):
(WebKit::WebPage::platformInitialize):

LayoutTests:

  • platform/qt/Skipped: Unskip previously failing tests.
06:30 Changeset [99417] by yurys@chromium.org

[Chromium] Web Inspector: use native worker inspector instead of fake workers
https://bugs.webkit.org/show_bug.cgi?id=71670

Source/WebCore:

Removed context menu option for switching between native and "fake" workers
debugger. Native debugger is used by default on platforms that support it.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):

  • inspector/front-end/scriptsPanel.css:

(#shared-workers-list):

Source/WebKit/chromium:

chrome://workers link is replaced with instructions on discovering shared workers
in Task Manager.

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

():

06:20 Changeset [99416] by vsevik@chromium.org

Web Inspector: Add advanced search shortcut to ShortcutsScreen.
https://bugs.webkit.org/show_bug.cgi?id=71302

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.createShortcut):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

06:10 Changeset [99415] by andreas.kling@nokia.com

CSSImageValue: Remove inheritance from CachedImageClient.
<http://webkit.org/b/71675>

Reviewed by Antti Koivisto.

CSSImageValue doesn't actually use any of the CachedImageClient
functionality, and holds a reference to the resource via the
CachedResourceHandle in StyleCachedImage.

So we can safely remove the multiple inheritance and simplify
the class.

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::~CSSImageValue):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::clearCachedImage):

  • css/CSSImageValue.h:
06:09 Changeset [99414] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

  • DEPS:
06:04 Changeset [99413] by ossy@webkit.org

[Qt] Skip a new failing test on Qt
https://bugs.webkit.org/show_bug.cgi?id=70893

Patch by Ben Wells <benwells@chromium.org> on 2011-11-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
05:46 Changeset [99412] by andreas.kling@nokia.com

CSSPrimitiveValue: Remove unused virtual function parseString().
<http://webkit.org/b/71671>

Reviewed by Antti Koivisto.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:
05:43 Changeset [99411] by caseq@chromium.org

Web Inspector: use toString as the Date object description.
https://bugs.webkit.org/show_bug.cgi?id=71605

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/remote-object.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/remote-object-expected.txt: Added.
  • inspector/remote-object.html: Added.
05:40 Changeset [99410] by caseq@chromium.org

Web Inspector: [refactoring] get JS-specific methods out of SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=70885

Reviewed by Pavel Feldman.

No new tests, as there's no new functionality.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.contentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadonly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.cancelEditing):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._mouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype._createConditionElement):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrameDelegate):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.requestContent):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.continueToLine):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.addToWatch):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.SourceFrameDelegateForScriptsPanel):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.get textViewer):
(WebInspector.SourceFrame.prototype.requestContent):
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.canEditSource):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.didEditContent):
(WebInspector.SourceFrame.prototype.editContent):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.SourceFrame.prototype.setReadOnly):

  • inspector/front-end/inspector.html:
05:31 Changeset [99409] by andreas.kling@nokia.com

CSSValue: Devirtualize cssValueType().
<http://webkit.org/b/71667>

Reviewed by Antti Koivisto.

Keep the cssValueType in a CSSValue member instead of using
virtual functions.

This is part of a project to completely devirtualize CSSValue
<http://webkit.org/b/71666> and will incur a temporary object
size regression for CSSValue while the work is ongoing.

  • css/CSSInheritedValue.cpp:
  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::CSSInheritedValue):

  • css/CSSInitialValue.cpp:
  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:
  • css/CSSValue.h:

(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:
05:22 Changeset [99408] by pfeldman@chromium.org

Web Inspector: introduce UserAgent override setting.
https://bugs.webkit.org/show_bug.cgi?id=71627

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::setUserAgentOverride):

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen):
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype._onBlur):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkManager.prototype._userAgentSettingChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get for):
(WebInspector.SettingsScreen.prototype._createCustomSetting):
(WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged):

  • inspector/front-end/helpScreen.css:

(.help-table td):
(.help-content fieldset label):

04:50 Changeset [99407] by apavlov@chromium.org

Web Inspector: autocomplete combobox for Styles sidebar and Console.
https://bugs.webkit.org/show_bug.cgi?id=65511

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestBoxEnabled):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPromptWithHistory):

  • inspector/front-end/inspector.css:

(.suggest-box.generic-suggest):
(.suggest-box.generic-suggest.above-anchor):
(.suggest-box.generic-suggest .content):

04:44 Changeset [99406] by philn@webkit.org

Unreviewed, GTK flaky tests clean-up. Moved most of them to
test_expectations.

  • platform/gtk/Skipped:
  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/gtk/test_expectations.txt:
04:19 Changeset [99405] by pfeldman@chromium.org

Web Inspector: split script-formatter test into multiple tests.
https://bugs.webkit.org/show_bug.cgi?id=71607

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/debugger/script-formatter-breakpoints.html

inspector/debugger/script-formatter-console.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints-expected.txt: Added.
  • inspector/debugger/script-formatter-breakpoints.html: Added.
  • inspector/debugger/script-formatter-console-expected.txt: Added.
  • inspector/debugger/script-formatter-console.html: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
03:46 Changeset [99404] by philn@webkit.org

Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems.

  • platform/gtk/Skipped:
03:39 Changeset [99403] by keishi@webkit.org

Change ColorChooser from singleton to ordinary object
https://bugs.webkit.org/show_bug.cgi?id=71644

Reviewed by Kent Tamura.

Source/WebCore:

Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface.

  • WebCore.exp.in:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser
(WebCore::ColorInputType::handleDOMActivateEvent):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::didCleanup): Called after cleanup is complete.
(WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient.

  • html/ColorInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectColorInColorChooser):

  • html/HTMLInputElement.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto.

  • page/Chrome.cpp:

(WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::Chrome::setSelectedColorInColorChooser): Ditto.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp:

(WebCore::ColorChooserClient::~ColorChooserClient):
(WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself.
(WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser.
(WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted.
(WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient.
(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor
(WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup

  • platform/ColorChooser.h:

(WebCore::ColorChooserClient::chooser): Returns the current ColorChooser.
(WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient.

  • testing/Internals.cpp:

(WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element.

  • testing/Internals.h:
  • testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser.

LayoutTests:

  • fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object
02:51 Changeset [99402] by yutak@chromium.org

Web Inspector: Cannot edit elements commented with <!--
https://bugs.webkit.org/show_bug.cgi?id=71357

Patch by Alexander Pavlov <apavlov@chromium.org> on 2011-11-07
Reviewed by Pavel Feldman.

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
02:03 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
01:59 Changeset [99401] by apavlov@chromium.org

Web Inspector: Cannot edit elements commented with <!--
https://bugs.webkit.org/show_bug.cgi?id=71357

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
01:26 Changeset [99400] by philn@webkit.org

Unreviewed, unkip a working test and reclassify the wheelevent missing DRT features.

  • platform/gtk/Skipped:
00:48 Changeset [99399] by yutak@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark two tests as flaky. Remove some obsolete expectations.

00:09 Changeset [99398] by philn@webkit.org

Unreviewed, skip fast/events/platform-wheelevent-paging on GTK
because this platform does not support a paging mouse wheel event.

  • platform/gtk/Skipped:

11/06/11:

23:18 Changeset [99397] by noel.gordon@gmail.com

Fix some style issues in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=71649

Reviewed by Kent Tamura.

No new tests. Style change only.

  • platform/graphics/ImageBuffer.h:
22:48 Changeset [99396] by commit-queue@webkit.org

[GTK] Skip new failing test.
https://bugs.webkit.org/show_bug.cgi?id=71022

Patch by Ben Wells <benwells@chromium.org> on 2011-11-06
Reviewed by Martin Robinson.

  • platform/gtk/Skipped:
22:27 Changeset [99395] by keishi@webkit.org

InputType::fallbackValue and defaultValue should be const
https://bugs.webkit.org/show_bug.cgi?id=71641

Reviewed by Kent Tamura.

Changing InputType::fallbackValue and defaultValue to const. Also adding OVERRIDE.

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::fallbackValue):

  • html/BaseCheckableInputType.h:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::fallbackValue):

  • html/ColorInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::fallbackValue):
(WebCore::InputType::defaultValue):

  • html/InputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::fallbackValue):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::defaultValue):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::defaultValue):

  • html/SubmitInputType.h:
19:17 Changeset [99394] by yutak@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

fast/events/platform-wheelevent-paging-{x,y,xy}-in-scrolling-page.html fails on chromium-cg-mac.

19:13 Changeset [99393] by rniwa@webkit.org

Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com
https://bugs.webkit.org/show_bug.cgi?id=71203

Reviewed by Ojan Vafai.

Source/WebCore:

Remove the transparent background color from inline style declarations in the pasted content.
Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style
declarations even if those properties were overridden.

Tests: editing/deleting/merge-paragraphs-with-transparent-background.html

editing/deleting/paste-with-transparent-background-color.html

  • editing/EditingStyle.cpp:

(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):

LayoutTests:

Added a test to merge paragraphs inside a document with background: transparent, and a test to
cut and paste contents with background: transparent, which is overriding a style rule background: blue.

WebKit should preserve the appearance of the pasted content but should not add a redundant
background: transparent.

  • editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added.
  • editing/deleting/merge-paragraphs-with-transparent-background.html: Added.
  • editing/deleting/paste-with-transparent-background-color-expected.txt: Added.
  • editing/deleting/paste-with-transparent-background-color.html: Added.

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/8493001

18:51 Changeset [99392] by fpizlo@apple.com

REGRESSION(r99374): GTK+ build of the jsc binary doesn't like the call
to initializeMainThread, and crashes
https://bugs.webkit.org/show_bug.cgi?id=71643

Reviewed by Sam Weinig.

  • jsc.cpp:

(main):

18:34 Changeset [99391] by keishi@webkit.org

Remove ColorInputType::handleClickEvent
https://bugs.webkit.org/show_bug.cgi?id=71640

Reviewed by Kent Tamura.

When you click the input color element, both ColorInputType::handleClickEvent and
ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
to be called too many times.

  • html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
  • html/ColorInputType.h: Removed ColorInputType::handleClickEvent
18:25 Changeset [99390] by keishi@webkit.org

Remove extra semicolon in ColorInputType
https://bugs.webkit.org/show_bug.cgi?id=71639

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::setValue):

18:07 Changeset [99389] by dominicc@chromium.org

Remove initBeforeLoadEvent method
https://bugs.webkit.org/show_bug.cgi?id=71636

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

  • dom/BeforeLoadEvent.h:
  • dom/BeforeLoadEvent.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
16:42 Changeset [99388] by rniwa@webkit.org

Skip tests for autocorrection panel on Chromium port since
Chromium Mac port doesn't support autocorrection panel.

The failure was tracked by the Chromium issue 58254 (http://crbug.com/58254).

  • platform/chromium/test_expectations.txt:
16:34 Changeset [99387] by rniwa@webkit.org

editing/input/scroll-viewport-page-up-down.html is very flaky on chromium win release
https://bugs.webkit.org/show_bug.cgi?id=59642

Unreviewed; remove the failing test expectation since we can no longer observe the said failure.

  • platform/chromium/test_expectations.txt:
14:52 Changeset [99386] by abarth@webkit.org

Don't crash when a context hasn't been created. This fixed a
testing-only crash on the bots in the Chromium port.

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

14:45 Changeset [99385] by ossy@webkit.org

[Qt] Unreviewed trivial fix after build system refactoring.

  • Scripts/run-qtwebkit-tests: Fix qml_import_path.
14:27 Changeset [99384] by darin@apple.com

Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=71260

Reviewed by Mark Rowe.

Memory leak fix covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Instead of calling remove, call take and then delete, since the
values of the map are owned and need to be deleted when removed.

13:31 Changeset [99383] by abarth@webkit.org

Implement the sandbox directive for CSP
https://bugs.webkit.org/show_bug.cgi?id=71604

Reviewed by Sam Weinig.

Source/WebCore:

At TPAC, Microsoft was pushing pretty hard to add the sandbox directive
to CSP. There's a question about whether it's going to be in CSP 1.0
or CSP 1.1, but it seems to be clearly headed into the spec.

This patch implements the sandbox directive for CSP. It's built on the
same machinery we use for the sandbox attribute for iframe. Now that
I've done the implementation, I'm going to write up some concrete text
for the spec.

Tests: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html
http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html
http/tests/security/contentSecurityPolicy/sandbox-empty.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
(WebCore::ContentSecurityPolicy::addDirective):

  • page/ContentSecurityPolicy.h:

LayoutTests:

Test that the sandbox directive correctly wires up to the sandbox
flags. Also, test that the policy inherits into subframes. These are
essentially integration tests between the CSP and sandbox subsystems,
which is why they don't cover all the permutations of the sandbox
flags. Those are covered in more detail via tests of the sandbox
attribute.

  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty.html: Added.
13:29 Changeset [99382] by weinig@apple.com

Add space missing from some class declarations
https://bugs.webkit.org/show_bug.cgi?id=71632

Reviewed by Anders Carlsson.

  • assembler/AssemblerBufferWithConstantPool.h:
  • bytecode/CodeBlock.h:
  • dfg/DFGVariableAccessData.h:
  • heap/VTableSpectrum.h:
  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • wtf/MetaAllocatorHandle.h:
  • wtf/UnionFind.h:
13:01 Changeset [99381] by eric@webkit.org

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
https://bugs.webkit.org/show_bug.cgi?id=66078

Unreviewed. Add an assert about the type of "args"
to our Executive Mocks and fix a piece of code
from this patch which was hitting that assert
when executing for real.

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
13:00 Changeset [99380] by rniwa@webkit.org

Add a crash expectation for platform/mac/accessibility/select-element-selection-with-optgroups.html on Mac.
The failure is tracked by the bug 71421.

  • platform/mac/test_expectations.txt:
12:49 Changeset [99379] by eric@webkit.org

Split chunk handling out of prepare_lists_and_print_output to make it more readable
https://bugs.webkit.org/show_bug.cgi?id=71629

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
12:38 Changeset [99378] by weinig@apple.com

Allow use of FINAL in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71630

Reviewed by Anders Carlsson.

  • Configurations/Base.xcconfig:

Don't warn about C++11 extensions used in C++98 mode.

11:48 Changeset [99377] by eric@webkit.org

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
https://bugs.webkit.org/show_bug.cgi?id=66078

Reviewed by Adam Barth.

The runtime feature detection was fixed to work in bug 64472.
In this bug I moved the symbol-based feature detection from
popen() to Executive.run_command and cleaned up the callers
and unittests to make sure that we're correctly parsing the
nm output correctly. The old code happened to work even though
the runtime-features path was using "str in list" and the
symbol features path was using "str in str" and it just happened
to do what we wanted to. Now runtime features and symbol feature
blacklists are computed separately (and with better documentation).

This system remains confusing, partially because these are black-lists
which are amended to whatever static blacklist may exist for the
port as part of a Skipped list file.

For example, notice how the runtime feature list only has directory
blacklists for a couple features. If all features are off,
how do we skip enough tests with only 2 entries in the blacklist map?
The answer is that Windows is the only port to use runtime feature
detection, and the win/Skipped file turns off all the other features
statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
which use symbol-based feature detection turn of mathml, wcss, etc
using the blacklists found in _missing_symbol_to_skipped_tests.

I also noticed a couple places where we still referenced xhtmlmp
even though support for such has been removed from WebKit. Removed those.

This should result in no functional change.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
    • Use self._filesystem instead of os.path
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
09:22 Changeset [99376] by mitz@apple.com

Made show-pretty-diff work when the input path contains spaces.

Reviewed by Anders Carlsson.

  • Scripts/show-pretty-diff:
03:54 Changeset [99375] by fpizlo@apple.com

Value profiling should just use two buckets
https://bugs.webkit.org/show_bug.cgi?id=71619

Reviewed by Gavin Barraclough.

Added one more configuration options (like Heuristics::minimumOptimizationDelay),
improved debugging in JIT optimization support, changed the number of buckets
in the value profile from 9 to 2, and wrote a more optimal value profiling path
in the old JIT to take advantage of this. It's still possible to play around with
larger numbers of buckets, and we should probably keep this for a little while
until we convince ourselves that using just two buckets is the right call.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/ValueProfile.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
03:39 Changeset [99374] by fpizlo@apple.com

JSC should be able to sample itself in a more flexible way than just sampling flags
https://bugs.webkit.org/show_bug.cgi?id=71522

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Added a construct that looks like SamplingRegion samplingRegion("name").

(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
(JSC::SamplingRegion::sample):
(JSC::SamplingRegion::dump):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingThread::threadStartFunc):

  • bytecode/SamplingTool.h:

(JSC::SamplingRegion::SamplingRegion):
(JSC::SamplingRegion::~SamplingRegion):
(JSC::SamplingRegion::exchangeCurrent):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/VTableSpectrum.cpp:

(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h:
  • jsc.cpp:

(main):
(runWithScripts):

  • parser/Parser.h:

(JSC::parse):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Platform.h:
  • wtf/Spectrum.h: Added.

(WTF::Spectrum::Spectrum):
(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::begin):
(WTF::Spectrum::end):
(WTF::Spectrum::KeyAndCount::KeyAndCount):
(WTF::Spectrum::KeyAndCount::operator<):
(WTF::Spectrum::buildList):

  • wtf/wtf.pri:

Source/JavaScriptGlue:

Reviewed by Gavin Barraclough.

  • ForwardingHeaders/wtf/Spectrum.h: Added.

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, since no functionality changed.

  • ForwardingHeaders/wtf/Spectrum.h: Added.
03:04 Changeset [99373] by hausmann@webkit.org

[Qt] Unreviewed gardening.

Skip paged wheel events for Qt, as we don't support them yet.

  • platform/qt/Skipped:
00:23 Changeset [99372] by commit-queue@webkit.org

Web Inspector: Unindent edited text by pressing Shift + Tab
https://bugs.webkit.org/show_bug.cgi?id=70181

Indent and unindent text in all selected lines.

Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-11-06
Reviewed by Pavel Feldman.

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype.unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype.unindentLines):

11/05/11:

23:10 Changeset [99371] by mrobinson@webkit.org

Skip a newly failing test and reclassify some missing DRT features.

  • platform/gtk/Skipped: Update skipped list.
22:33 Changeset [99370] by mrobinson@webkit.org

Remove ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=71617

Reviewed by Ariya Hidayat.

No new tests. This patch does not change behavior.

Completely remove ContextShadow. It's unused, unmaintained, and
replaced by ShadowBlur.

  • WebCore.gypi: Remove references to deleted files.
  • WebCore.vcproj/WebCore.vcproj: Remove references to deleted files.
  • platform/graphics/ContextShadow.cpp: Removed.
  • platform/graphics/ContextShadow.h: Removed.
  • platform/gtk/WidgetRenderingContext.cpp: Remove now-inaccurate TODO.
21:27 Changeset [99369] by jonlee@apple.com

Dragging a file onto <input type="file"> should give distinct visual feedback
https://bugs.webkit.org/show_bug.cgi?id=13897
<rdar://problem/5232483>

Reviewed by Dan Bernstein.

When hovering over a file input element, we set the button's state to active
to differentiate dragging one file over the input element (which populates that
element) versus over the document (which would load the file into the view).

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::canReceiveDroppedFiles):
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): If set, the element
is updated, which sets the active state on the button control.

  • html/HTMLInputElement.h: Add a boolean member representing whether the file

input can receive dropped files.

  • page/DragController.cpp:

(WebCore::DragController::DragController): Update/set the file input that
can receive dropped files.
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

  • page/DragController.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement): Sets the button active
state if the input can receive dropped files.

21:14 Changeset [99368] by dcheng@chromium.org

[chromium] Use the security origin instead of the URL when checking notification permissions
https://bugs.webkit.org/show_bug.cgi?id=71590

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::checkPermission):

Tools:

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::checkPermission):

  • DumpRenderTree/chromium/NotificationPresenter.h:
19:26 Changeset [99367] by darin@apple.com

Improve pending resource hash table code, including fixing a memory leak
https://bugs.webkit.org/show_bug.cgi?id=71616

Reviewed by Adam Roben.

Memory leak fix and refactoring covered by existing tests.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource): Replace the combination
of contains, get, and add with just add, removing an extra unneeded hash table
lookup each time this function is called.
(WebCore::SVGDocumentExtensions::isElementInPendingResources): Added a comment
about the performance of this function. Removed unnecessary check for an empty
map; the code already efficiently exits doing nothing without the check.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources): Removed
unnecessary check for an empty map; the code already efficiently does nothing
without the check. Use removePendingResource rather than calling remove to
avoid leaking the SVGPendingElements set.
(WebCore::SVGDocumentExtensions::removePendingResource): Replace the
combination of get and remove with a call to take, removing an extra
unneeded hash table lookup each time this function is called

18:07 Changeset [99366] by darin@apple.com

Fix a small leak in Mac version of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=71615

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
(LayoutTestController::localStorageDiskUsageForOrigin): Ditto.

17:56 Changeset [99365] by mrobinson@webkit.org

Unskip some tests on GTK+ that seem to be passing.

  • platform/gtk/Skipped: Unskip tests.
17:50 Changeset [99364] by commit-queue@webkit.org

[GTK] Actually use the user_data arguments to gio async functions
instead of using g_object_set_data() to basically reinvent them.
https://bugs.webkit.org/show_bug.cgi?id=71614

Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startNonHTTPRequest):

17:39 Changeset [99363] by commit-queue@webkit.org

[GTK] Don't unnecessarily 0-initialize read buffers.
https://bugs.webkit.org/show_bug.cgi?id=71612

Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):

17:37 Changeset [99362] by commit-queue@webkit.org

[GTK] Remove a bit of dead code
https://bugs.webkit.org/show_bug.cgi?id=71613

Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::readCallback): the caller that needed the convertToUTF16
code was removed in r77408, but the code was accidentally left
behind.

17:34 Changeset [99361] by mrobinson@webkit.org

[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576

Reviewed by Antonio Gomes.

Instead of waiting until <body onload> to toggle the frame flattening
setting. Toggle is as soon as possible. This fixes an issue where
layouts that happen before the onload event lead to flaky results.

  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-crash.html:
  • fast/frames/flattening/iframe-flattening-fixed-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width.html:
  • fast/frames/flattening/iframe-flattening-nested.html:
  • fast/frames/flattening/iframe-flattening-offscreen.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
  • fast/frames/flattening/iframe-flattening-out-of-view.html:
  • fast/frames/flattening/iframe-flattening-selection-crash.html:
  • fast/frames/flattening/iframe-flattening-simple.html:
  • platform/gtk/Skipped: Unskip tests which are no longer flaky.
16:45 Changeset [99360] by mrobinson@webkit.org

[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-05
Reviewed by Martin Robinson.

Skip frame flattening tests. These became flaky after backing store for
painting was introduced for the GTK port in r98827.

  • platform/gtk/Skipped:
14:55 Changeset [99359] by abarth@webkit.org

Refactor sandbox flag calculation to make implementing CSP sandbox directive easier
https://bugs.webkit.org/show_bug.cgi?id=71603

Reviewed by Sam Weinig.

This patch changes the way we compute sandbox bits. Instead of caching
the result on Frame, we always compute the sandbox bits for a new
document fresh from the inputs to the process (the sandbox attribute
and the forced sandbox flags).

This patch is just refactoring. It shouldn't have an observable
effects. This patch makes it easier to implement CSP's sandbox
directive in a subsequent patch.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::setSandboxFlags):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::effectiveSandboxFlags):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::forceSandboxFlags):

13:37 Changeset [99358] by weinig@apple.com

Fix windows build.

13:29 Changeset [99357] by weinig@apple.com

Reduce the number of putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71597

Reviewed by Adam Roben.

Remove exports of removed functions.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):
Calling the overload without the extra parameters does the same thing.

  • runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):

  • runtime/JSObject.h:

Remove four unused JSObject::putWithAttributes overloads and make one of the remaining
two overloads not virtual, since no one overrides it.

11:16 Changeset [99356] by mrobinson@webkit.org

Unskip a test on GTK+ that doesn't seem to be failing on the bots
or locally.

  • platform/gtk/Skipped: Unskip a test.
09:28 Changeset [99355] by andreas.kling@nokia.com

CSSStyleDeclaration: Devirtualize isMutableStyleDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=71609

Reviewed by Anders Carlsson.

Add a bool member to CSSStyleDeclaration that determines whether
it's a CSSMutableDeclaration.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::isMutableStyleDeclaration):

09:25 Changeset [99354] by andreas.kling@nokia.com

Web Inspector: Simplify InspectorCSSAgent::inlineStyleElement().
https://bugs.webkit.org/show_bug.cgi?id=71608

Reviewed by Pavel Feldman.

Use CSSMutableStyleDeclaration::isInlineStyleDeclaration() instead
of doing the same checks manually.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

07:50 Changeset [99353] by hausmann@webkit.org

Reviewed by Andreas Kling.

Removed duplicated npruntime_internal.h from bindings/v8
in favour of the one from bridge/, which has a few more

https://bugs.webkit.org/show_bug.cgi?id=45617

  • bindings/v8/npruntime_internal.h: Removed.
  • Target.pri: Removed strange occurence here.
05:15 Changeset [99352] by hausmann@webkit.org

Remove empty and unused dom/PositionCreationFunctions.h header file
https://bugs.webkit.org/show_bug.cgi?id=71552

Reviewed by Kenneth Rohde Christiansen.

The file is empty (0 bytes) and not used anywhere. It was added in
2009 in r48234 but hasn't been touched since then.

  • WebCore.gypi:
  • dom/PositionCreationFunctions.h: Removed.
00:00 Changeset [99351] by abarth@webkit.org

Fix assert after running tests in dumpAsText folders. See
https://bugs.webkit.org/show_bug.cgi?id=71599 for discussion. This
patch reverts part of a slightly over-agressive refactoring in
http://trac.webkit.org/changeset/99347.

  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):

11/04/11:

22:50 Changeset [99350] by tony@chromium.org

Update a timing out gpu test.

  • platform/chromium/test_expectations.txt:
18:59 Changeset [99349] by commit-queue@webkit.org

Canvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=71537

Patch by Ben Wells <benwells@chromium.org> on 2011-11-04
Reviewed by Stephen White.

Source/WebCore:

drawImage(canvas) now uses the same approach as drawImage(image) to fix these errors.

Test: fast/canvas/canvas-composite-canvas.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-canvas-expected.txt: Added.
  • fast/canvas/canvas-composite-canvas.html: Added.
  • fast/canvas/canvas-composite-image.html:
  • fast/canvas/resources/canvas-composite-image-common.js: Added.
18:35 Changeset [99348] by cevans@google.com

Merge 98763
BUG=99597
Review URL: http://codereview.chromium.org/8478022

18:32 Changeset [99347] by abarth@webkit.org

JavaScript URLs execute in sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=71599

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes the intentional regression I introduced earlier today
by moving the sandbox bits from SecurityOrigin to Document. In the
process, I renamed SecurityOrigin::createEmpty to
SecurityOrigin::createUnique to better align with HTML5 terminology.

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::sandboxFlags):
(WebCore::ScriptExecutionContext::enforceSandboxFlags):
(WebCore::ScriptExecutionContext::isSandboxed):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::canEmbedJava):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::isDocumentSandboxed):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):

  • page/SecurityOrigin.h:

LayoutTests:

Update results to show progression.

  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • fast/frames/sandboxed-iframe-scripting.html:
18:30 Changeset [99346] by cevans@google.com

Merge 98561
BUG=100526
Review URL: http://codereview.chromium.org/8480023

18:26 Changeset [99345] by cevans@google.com

Merge 98033
BUG=99603
Review URL: http://codereview.chromium.org/8477022

18:26 Changeset [99344] by commit-queue@webkit.org

Potential Unused Param Build Issue
https://bugs.webkit.org/show_bug.cgi?id=71598

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-04
Reviewed by Kent Tamura.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

18:20 Changeset [99343] by cevans@google.com

Merge 98010
BUG=100177
Review URL: http://codereview.chromium.org/8474016

18:00 Changeset [99342] by cevans@google.com

Merge 98935
BUG=101018
Review URL: http://codereview.chromium.org/8479023

17:58 Changeset [99341] by eric@webkit.org

Upgrade to the latest Mechanize
https://bugs.webkit.org/show_bug.cgi?id=71594

Reviewed by Adam Barth.

I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
Mechanize is no longer two separate libraries, so importing it is much simpler.

  • Scripts/webkitpy/thirdparty/init.py:
17:58 Changeset [99340] by cevans@google.com

Merge 98796
BUG=102242
Review URL: http://codereview.chromium.org/8479022

17:51 Changeset [99339] by commit-queue@webkit.org

Crash in ScrollAnimator.cpp
https://bugs.webkit.org/show_bug.cgi?id=69865

The code in ScrollAnimator assumes that horizontal per-page mouse
wheel events cannot happen, which is not true. This patch adds layout
tests for all paging wheel event situations and fixes the broken
horizontal case.

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

Tests: fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html

fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html
fast/events/platform-wheelevent-paging-x-in-scrolling-div.html
fast/events/platform-wheelevent-paging-x-in-scrolling-page.html
fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html
fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html
fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html
fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

  • platform/PlatformWheelEvent.h: Modify the comment to reflect the new

reality.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Modified the code to handle the
horizontal per-page wheel event case.

Tools:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::handleMouseWheel): Added the ability to specify that a
mouse wheel event should be paging.

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-page.html: Added.
  • platform/chromium-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
  • platform/chromium-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
  • platform/chromium-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
  • platform/mac/Skipped: Added skip for the new tests, as the platform

does not support it.

  • platform/win/Skipped: Added skip for the new tests, as the platform

does not support it.

17:44 Changeset [99338] by commit-queue@webkit.org

[MutationObservers] Refactor MutationObserverRegistration into its own class that is
referenced by registration points

https://bugs.webkit.org/show_bug.cgi?id=71577

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-04
Reviewed by Ojan Vafai.

MutationObserverRegistration is now owned by the node which is observed. If transient
registrations are created, they hold a reference to this object.

The ownership relationship between Node, MutationObserverRegistration &
WebKitMutationObserver now goes like this: WebKitMutationObserver is RefCounted -
and only script and MutationObserverRegistration take references to it. Exactly
one MutationObserverRegistration can exist for any given tuple of
<Node, WebKitMutationObserver>. This represents an observer observing at a given
Node. Further observation by the same observer has the effect of *resetting*
the existing observation. The Node owns the MutationObserverRegistration.
Transient registrations are only pointers to the registration. The registration
keeps a RefPtr to its registration node and all of its transient registration nodes
as long as *any* transient registrations exist. This ensures the registration
and all registration nodes stay alive at least until the end of the microtask.

No tests required - refactor only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CharacterData.cpp:

(WebCore::enqueueCharacterDataMutationRecord):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/MutationObserverRegistration.cpp: Added.

(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::~MutationObserverRegistration):
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::unregister):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h: Copied from Source/WebCore/dom/WebKitMutationObserver.h.

(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):

  • dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::addObserverToDeliverySet):
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeRareData::mutationObserverRegistry):
(WebCore::NodeRareData::ensureMutationObserverRegistry):
(WebCore::NodeRareData::transientMutationObserverRegistry):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::observationStarted):
(WebCore::WebKitMutationObserver::observationEnded):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:
17:34 Changeset [99337] by commit-queue@webkit.org

Add methods to compute magnitude and phase response for biquads
https://bugs.webkit.org/show_bug.cgi?id=71055

Reviewed by Kenneth Russell.

Patch by Raymond Toy <rtoy@google.com> on 2011-11-04

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::getFrequencyResponse):
Computes the magnitude and phase (radians) response for the given
biquad at the specified set of (normalized) frequencies.

  • platform/audio/Biquad.h:

Declare getFrequencyResponse.

  • webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
Factor out the code that updates filter coefficients. Allow the
caller to specify whether the smoothed values are used or not and
whether we do the update even if the coefficients are not dirty.
(WebCore::BiquadDSPKernel::process):
Use updateCoefficientsIfNecessary to update.
(WebCore::BiquadDSPKernel::getFrequencyResponse):
Implmentation of getFrequencyResponse.

  • webaudio/BiquadDSPKernel.h:

Declare getFrequencyResponse.

  • webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::getFrequencyResponse):
Implementation of getFrequencyResponse

  • webaudio/BiquadFilterNode.h:

Declare getFrequencyResponse.

  • webaudio/BiquadFilterNode.idl:

Define interface to getFrequencyResponse.

  • webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::checkForDirtyCoefficients):
Factor out code for checking for dirty coefficients.
(WebCore::BiquadProcessor::process):
Use checkForDirtyCoefficients.
(WebCore::BiquadProcessor::getFrequencyResponse):
Implementation of getFrequencyResponse

  • webaudio/BiquadProcessor.h:

Declare getFrequencyResponse.

17:29 Changeset [99336] by commit-queue@webkit.org

Baselines for new test introduced in r99043
https://bugs.webkit.org/show_bug.cgi?id=71528

Patch by Ben Wells <benwells@chromium.org> on 2011-11-04
Reviewed by Kenneth Russell.

  • platform/chromium-cg-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
  • platform/chromium/test_expectations.txt:
17:27 Changeset [99335] by eric@webkit.org

Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed. Fix exception when running new-run-webkit-httpd.

  • Scripts/new-run-webkit-httpd:
17:02 Changeset [99334] by commit-queue@webkit.org

[Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs with CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=71539

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-04
Reviewed by David Kilzer.

In order to have CFURL and NSURL to be consistent when both are used on Mac,
KURL::createCFURL() is changed to support empty URL values.

  • platform/cf/KURLCFNet.cpp:

(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):

16:51 Changeset [99333] by psolanki@apple.com

sqrtDouble and andnotDouble should be declared noreturn
https://bugs.webkit.org/show_bug.cgi?id=71592

Reviewed by Sam Weinig.

  • assembler/MacroAssemblerARMv7.h:
16:07 Changeset [99332] by fsamuel@chromium.org

CSS Aspect Ratio Property Parsing Stage
https://bugs.webkit.org/show_bug.cgi?id=70707

Reviewed by Ojan Vafai.

Source/WebCore:

Added parsing support for -webkit-aspect-ratio CSS property.
The spec can be found here: http://www.xanthir.com/blog/b4810

Test: fast/css/aspect-ratio-parsing-tests.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAspectRatioValue.cpp: Added.

(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
(WebCore::CSSAspectRatioValue::cssText):

  • css/CSSAspectRatioValue.h: Added.

(WebCore::CSSAspectRatioValue::create):
(WebCore::CSSAspectRatioValue::numeratorValue):
(WebCore::CSSAspectRatioValue::denominatorValue):
(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAspectRatio):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/aspect-ratio-parsing-tests-expected.txt: Added.
  • fast/css/aspect-ratio-parsing-tests.html: Added.
15:52 Changeset [99331] by aroben@apple.com

Remove Leopard-specific code from build.webkit.org

We don't have any Leopard bots anymore.

Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer

and StopATSServer steps.
(unitTestsSupported): Removed check for mac-leopard.
(TestFactory.init): Removed Leopard-specific steps.

15:50 Changeset [99330] by abarth@webkit.org

Delete FrameLoader::isSandboxed
https://bugs.webkit.org/show_bug.cgi?id=71591

Reviewed by Eric Seidel.

Source/WebCore:

We should always use document->securityOrigin()->isSandboxed because
that picks up the sandbox bits that are frozen on the document rather
than the ones that could change on the Frame.

This patch starts preparing us to implement the CSP sandbox directive,
which will cause use to have document sandbox bits without any attribute.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • This call site was the only functional site left where these two could be different. This patch causes one progression and one regression. The progression is that we now correctly freeze the allow-scripts bit when a document is created, but the regression is we now allow the execution of JavaScript URLs, as noted in fast/frames/sandboxed-iframe-scripting.html. That's even more of an edge case, so I think it's a win overall.
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • I don't think this part of the change is testable. There's no time to execute script between when the bits get copied off the Frame and when they're checked, so there's no time to change them.
  • loader/FrameLoader.cpp:
    • Update FIXME comment that is now fixed.
  • loader/FrameLoader.h:
    • Remove wrong API.

LayoutTests:

This patch updates this test to check a few more cases and notes a bug
in our current implementation.

  • fast/frames/resources/sandboxed-iframe-script-dynamic.html:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • fast/frames/sandboxed-iframe-scripting.html:
15:32 Changeset [99329] by abarth@webkit.org

When CSP blocks mixed content, we shouldn't also warn about mixed content
https://bugs.webkit.org/show_bug.cgi?id=71588

Reviewed by Eric Seidel.

Source/WebCore:

Getting both warnings confused some early adopters. They thought the
insecure loads were happening even though they blocked them with CSP.
This patch restricts the mixed content warnings to show only when the
load isn't already blocked by CSP or by the embedder.

Test: http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

These tests check what kinds of warnings we generate when blocking insecure scripts with CSP.

  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/alert-fail.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/mixed-content-with-csp.html: Added.
15:24 Changeset [99328] by commit-queue@webkit.org

Allow ScriptExecutionContext::addMessage to be called from background threads.
https://bugs.webkit.org/show_bug.cgi?id=71575

Patch by Michael Nordman <michaeln@google.coom> on 2011-11-04
Reviewed by Nate Chapin.

No new tests.

  • dom/Document.cpp:

(WebCore::Document::addMessage):

  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addMessage):

15:16 Changeset [99327] by commit-queue@webkit.org

[chromium] Re-named the original scissorRect to clipRect
https://bugs.webkit.org/show_bug.cgi?id=71580

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-04
Reviewed by James Robinson.

Source/WebCore:

Existing tests are updated appropriately; and no new behavior is
introduced by this patch.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setUsesLayerClipping):
(WebCore::LayerChromium::usesLayerClipping):
(WebCore::LayerChromium::clipRect):
(WebCore::LayerChromium::setClipRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::clipRect):
(WebCore::RenderSurfaceChromium::setClipRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setUsesLayerClipping):
(WebCore::CCLayerImpl::usesLayerClipping):
(WebCore::CCLayerImpl::clipRect):
(WebCore::CCLayerImpl::setClipRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::clipRect):

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

  • tests/LayerChromiumTest.cpp:
15:09 Changeset [99326] by eric@webkit.org

new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=71549

Reviewed by Adam Barth.

Several members of Host didn't really belong there
and were instead specific to WebKitPatch, so I've moved
them up onto that class.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
15:01 Changeset [99325] by tony@chromium.org

garden-o-matic: bring back party time!
https://bugs.webkit.org/show_bug.cgi?id=71582

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
14:43 Changeset [99324] by dslomov@google.com

Add the ability to transfer ArrayBuffer and "neuter" it.
https://bugs.webkit.org/show_bug.cgi?id=71535

Reviewed by David Levin.

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::transfer):
(WebCore::ArrayBufferContents::~ArrayBufferContents):
(WebCore::ArrayBufferContents::tryAllocate):
(WebCore::ArrayBuffer::addView):
(WebCore::ArrayBuffer::removeView):

  • html/canvas/ArrayBuffer.h:

(WebCore::ArrayBufferContents::ArrayBufferContents):
(WebCore::ArrayBufferContents::data):
(WebCore::ArrayBufferContents::sizeInBytes):
(WebCore::ArrayBufferContents::release):
(WebCore::ArrayBuffer::~ArrayBuffer):

  • html/canvas/ArrayBufferView.cpp:

(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/DataView.cpp:

(WebCore::DataView::neuter):
(WebCore::DataView::neuterBinding):

  • html/canvas/DataView.h:
  • html/canvas/TypedArrayBase.h:

(WebCore::TypedArrayBase::neuter):
(WebCore::TypedArrayBase::neuterBinding):

14:42 Changeset [99323] by commit-queue@webkit.org

Unreviewed, rolling out r99315.
http://trac.webkit.org/changeset/99315
https://bugs.webkit.org/show_bug.cgi?id=71589

baselines still broken after running rebaseline script
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-04

  • platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:39 Changeset [99322] by philn@webkit.org

Unreviewed, GTK rebaseline after r99285.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
14:32 Changeset [99321] by abarth@webkit.org

Add a test for how CSP interacts with about:blank iframes
https://bugs.webkit.org/show_bug.cgi?id=71578

Reviewed by Dimitri Glazkov.

This issue came up in the discussion on
http://code.google.com/p/chromium/issues/detail?id=103038. This patch
just adds a test to make sure we don't regress.

  • http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme.html: Added.
14:27 Changeset [99320] by tony@chromium.org

stop running perf LayoutTests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=71513

Reviewed by Ojan Vafai.

This allows us to get rid of SLOW on some perf tests.

  • platform/chromium/test_expectations.txt:
14:14 Changeset [99319] by noel.gordon@gmail.com

[Chromium] Implement canvas.toDataURL("image/webp")
https://bugs.webkit.org/show_bug.cgi?id=70172

Reviewed by Adam Barth.

Source/WebCore:

Add a webp image encoder for the chromium skia ports, add it to the canvas
element toDataURL() flow with support for an optional quality [0.0-1.0].
Use a webp compression method (3) that provides good speed and compression
performance for this image format, and works well for various input image
types: line-art, screen-shots, and photographic images.

Test: fast/canvas/canvas-toDataURL-webp.html

  • WebCore.gypi:
  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageToDataURL):

  • platform/image-encoders/skia/WEBPImageEncoder.cpp: Added.

(WebCore::writeOutput):
(WebCore::importPicture):
(WebCore::importPictureBGRA):
(WebCore::importPictureRGBA):
(WebCore::encodePixels):
(WebCore::WEBPImageEncoder::encode):

  • platform/image-encoders/skia/WEBPImageEncoder.h: Added.

LayoutTests:

  • fast/canvas/canvas-toDataURL-webp-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-webp.html: Added.
  • platform/chromium/test_expectations.txt: skip test on MAC CPU-CG (CoreGraphics)
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
14:04 Changeset [99318] by commit-queue@webkit.org

[EFL] DRT: Fix the order of the items in the dumped history list.
https://bugs.webkit.org/show_bug.cgi?id=71562

It did not make much sense to hold the history list in a map, as we do not need
the keys. And the printed items must be sorted by target, which is more easily
done with a vector.

Should make tests such as http/tests/navigation/error404-frames.html pass.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::childHistoryItems):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpHistoryItem.cpp:

(compareHistoryItemsByTarget):
(dumpHistoryItem):

14:00 Changeset [99317] by paroga@webkit.org

[Qt] Remove ENABLE_SQLITE from qmake files
https://bugs.webkit.org/show_bug.cgi?id=71546

Reviewed by Simon Hausmann.

Source/WebCore:

ENABLE_SQLITE is required to build WebCore, so remove conditions.

  • Target.pri:

Tools:

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/webcore.prf:
13:58 Changeset [99316] by arv@chromium.org

Layout Test storage/indexeddb/exception-in-event-aborts.html is failing
https://bugs.webkit.org/show_bug.cgi?id=71536

Unreviewed. Updated test and expectations.

  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
13:55 Changeset [99315] by enne@google.com

[chromium] Unreviewed expectation rebaseline from r99286.

  • platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png.
  • platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png.
  • platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium/test_expectations.txt:
13:48 Changeset [99314] by abarth@webkit.org

watchlist for WebIDL shouldn't trigger on Internals.idl
https://bugs.webkit.org/show_bug.cgi?id=70657

Reviewed by David Levin.

Internals.idl isn't part of the Web-facing IDL in the project.

  • Scripts/webkitpy/common/config/watchlist:
13:43 Changeset [99313] by tony@chromium.org

[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale-test2.html
https://bugs.webkit.org/show_bug.cgi?id=71587

  • platform/chromium/test_expectations.txt:
13:37 Changeset [99312] by mhahnenberg@apple.com

De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::hasInstance):

  • API/JSValueRef.cpp:

(JSValueIsInstanceOfConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):

  • runtime/JSBoundFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::hasInstance):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

  • runtime/JSObject.h:
13:24 Changeset [99311] by japhet@chromium.org

[V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:
12:53 Changeset [99310] by commit-queue@webkit.org

Send the submissions character encoding in hidden _charset_ field.
https://bugs.webkit.org/show_bug.cgi?id=19079

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.

Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html

http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
http/tests/misc/char-encoding-in-text-charset-field-with-value.html
http/tests/misc/char-encoding-without-charset-field.html

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::isHiddenType):
(WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.

  • html/HiddenInputType.h: Override appendFormData for hidden control types.

LayoutTests:

Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Added test cases to check this behavior.

  • http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
  • http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
  • http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
  • http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
  • http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
  • http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.
12:29 Changeset [99309] by pfeldman@chromium.org

2011-11-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: marked inspector/debugger/script-formatter.html
as skipped for now - sorting it out.

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:12 Changeset [99308] by commit-queue@webkit.org

[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
https://bugs.webkit.org/show_bug.cgi?id=71563

Patch by Robert Sesek <rsesek@chromium.org> on 2011-11-04
Reviewed by Adam Barth.

Source/WebCore:

Use libWebKitSystemInterfaceLeopard.a that's in the Chromium port,
rather in WebKitLibraries/.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Roll Chromium DEPS r108107:108476 to pull in
libWebKitSystemInterfaceLeopard.a.

  • DEPS:
11:52 Changeset [99307] by jchaffraix@webkit.org

RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
https://bugs.webkit.org/show_bug.cgi?id=71517

Reviewed by Simon Fraser.

Unused code removal covered by existing tests.

The current code is invalidating the whole RenderLayerBacking as part of
a style change. However this is redundant with the repainting logic which
would invalidate only the necessary bits.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):
Remove the invalidation code as it duplicates and defeats the repaint logic.

11:38 Changeset [99306] by mihnea@adobe.com

Correct parsing of incomplete @-webkit-region rules.
https://bugs.webkit.org/show_bug.cgi?id=71514

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/regions/parse-incomplete-region-rule.html

Make sure to set the region rule to 0 on the fail branch.

  • css/CSSGrammar.y:

LayoutTests:

  • fast/regions/parse-incomplete-region-rule-expected.txt: Added.
  • fast/regions/parse-incomplete-region-rule.html: Added.
11:34 Changeset [99305] by adamk@chromium.org

Reduce refcount churn in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=71527

Reviewed by Ryosuke Niwa.

Only the ChildListMutationAccumulator needs to hold a reference to the
target node, and the added/removed children only need be ref'd if a
ChildListMutationAccumulator exists (i.e., if there are interested
observers).

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):

  • dom/ChildListMutationScope.h:
  • dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

11:28 Changeset [99304] by hausmann@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Forgot to skip this test also in r99296.
11:27 Changeset [99303] by leviw@chromium.org

Correct usage of LayoutUnits in RenderImage and SVGImage
https://bugs.webkit.org/show_bug.cgi?id=71525

Reviewed by Darin Adler.

Correcting incorrect usage of LayoutUnits for image sizes that should be integers and fixing overloaded functions that
should be using LayoutUnits.

No new tests -- no change in behavior.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::nodeAtPoint):
(WebCore::RenderImage::computeReplacedLogicalWidth):

  • rendering/RenderImage.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

11:20 Changeset [99302] by andersca@apple.com

Fix WKTR crash when running NPN_ConvertPoint test.

Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:

(ConvertPoint::NPP_SetWindow):

11:14 Changeset [99301] by abarth@webkit.org

Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Darin Adler.

Source/WebCore:

Enable allow-popups sandbox bit. My previous patch attempted to
forward the sandbox bits during setOpener, but that interacted poorly
with out (internal) sandboxing of the initial document. This patch
forwards the bits during createWindow, which is more targeted to the
case when a sandbox frame actually creates a new window.

  • loader/FrameLoader.cpp:

(WebCore::createWindow):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

Update test results to show that we now pass.

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt:
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html:
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html:
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt:
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html:
11:12 Changeset [99300] by andersca@apple.com

NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=71570

Reviewed by Simon Fraser.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetWindow):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

Remove the NPP parameter from NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:

(NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:

(ConvertPoint::NPP_SetWindow):
Run the test from NPP_SetWindow and call notifyDone() when done.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):
Remove unnecessary parameter.

LayoutTests:

Add a call to layoutTestController.waitUntilDone(); the plug-in will call notifyDone() when it's done.

  • platform/mac/plugins/convert-point.html:
11:11 Changeset [99299] by commit-queue@webkit.org

Remove initMediaStreamEvent method
https://bugs.webkit.org/show_bug.cgi?id=71344

This method has been removed from the spec draft.
http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-04
Reviewed by Adam Barth.

No new tests. Removed method.

  • mediastream/MediaStreamEvent.cpp:
  • mediastream/MediaStreamEvent.h:
  • mediastream/MediaStreamEvent.idl:
11:09 Changeset [99298] by abarth@webkit.org

Anonymous CORS fetch for WebGL texture fails when there is no appropriate server response even for the same origin requests
https://bugs.webkit.org/show_bug.cgi?id=71053

Reviewed by Darin Adler.

Source/WebCore:

The crossorigin attribute should behave like XMLHttpRequest:
same-origin images pass without and CORS headers, but CORS checks are
performed for cross-origin loads. This patch better aligns our
behavior with Firefox, as discussed in the bug.

Test: http/tests/security/img-crossorigin-loads-same-origin.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that we succeed in loading a same-origin image without the help of
CORS even if the image has the crossorigin attribute.

  • http/tests/security/img-crossorigin-loads-same-origin-expected.txt: Added.
  • http/tests/security/img-crossorigin-loads-same-origin.html: Added.
10:55 Changeset [99297] by commit-queue@webkit.org

HTMLKeygenElement: Fix "keytype" handling in appendFormData.
https://bugs.webkit.org/show_bug.cgi?id=70617

This fixes a bug introduced by http://trac.webkit.org/changeset/97658
which causes all HTML Keygen elements with a keytype optional attribute
to be considered as unsupported.

A regression test is included.

Patch by Gaurav Shah <gauravsh@chromium.org> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/misc/submit-post-keygen.html

  • html/HTMLKeygenElement.cpp:

LayoutTests:

  • http/tests/misc/resources/check-keygen-post.php: Added.
  • http/tests/misc/submit-post-keygen-expected.txt: Added.
  • http/tests/misc/submit-post-keygen.html: Added.
10:51 Changeset [99296] by hausmann@webkit.org

[Qt] Temporarily skip failing tests after the build system refactoring.

Rubber-stamped by Ossy.

Bug #71571 tracks the failure so we can look into it next week.

  • platform/qt/Skipped:
10:45 Changeset [99295] by enne@google.com

[chromium] Implement checkerboarding for missing layer tiles
https://bugs.webkit.org/show_bug.cgi?id=69585

Reviewed by James Robinson.

Source/WebCore:

For tiles that have no texture or haven't even been created yet,
draw using the background color of the layer.

The only background color set is currently the non-composited content,
and all other layers use transparent black by default.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setBackgroundColor):

  • platform/graphics/chromium/NonCompositedContentHost.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBackgroundColor):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::backgroundColor):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::drawTiles):

Source/WebKit/chromium:

To pipe the background color of the document to the non-composited
host, set it during paint. This may be more frequent than necessary,
but it'll catch all style changes.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::nonCompositedContentHost):
(WebKit::WebViewImplContentPainter::paint):

  • src/WebViewImpl.h:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

10:41 Changeset [99294] by hausmann@webkit.org

[Qt] Fix run-qtwebkit-tests execution on the build bot(s).

Rubber-stamped by Tor Arne Vestbø.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests

changed slightly after the refactoring.

10:37 Changeset [99293] by thakis@chromium.org

[chromium] Remove most exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=71524

Do this by using the DEFINE_STATIC_LOCAL macro, which allocates things on the heaps and then leaks them.

Reviewed by Dimitri Glazkov.

No behavior change, so no new tests.

  • platform/chromium/CursorChromium.cpp:

(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::aliasCursor):
(WebCore::progressCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):

  • platform/chromium/LanguageChromium.cpp:

(WebCore::platformDefaultLanguage):

  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::dummyHashSet):

10:29 Changeset [99292] by enne@google.com

[chromium] Unreviewed expectations update.

Temporarily mark a few tests as failing from r99286 due to tiny
differences on scrollbars. Can be rebaselined once all bots cycle.

  • platform/chromium/test_expectations.txt:
10:10 Changeset [99291] by fsamuel@chromium.org

[Chromium] Expose deviceScaleFactor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=70614

Reviewed by Darin Fisher.

This exposes the device scale factor to the Chromium-WebKit API.
This scale factor is the ratio between the current device's DPI
and the target device's DPI.

For details on how this can be accessed from CSS and javascript, please
see here:

http://developer.android.com/guide/webapps/targeting.html#DensityCSS

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::deviceScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):

  • src/WebViewImpl.h:
10:06 Changeset [99290] by vestbo@webkit.org

[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_pre.prf:
10:04 Changeset [99289] by andersca@apple.com

Add NetscapePlugin::convertFromRootView
https://bugs.webkit.org/show_bug.cgi?id=71526

Reviewed by Sam Weinig.

Source/WebCore:

Export some symbols that WebKit2 needs.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::convertFromRootView):
New function that converts a point from root view coordinates to plug-in coordinates.
Returns false if the conversion can't be done.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::fillInCocoaEventFromMouseEvent):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Use convertFromRootView instead of subtracting m_frameRectInWindowCoordinates.location() from the
event position (which is in root view coordinates).

10:00 Changeset [99288] by tony@chromium.org

Fix svn properties on layout test result files I checked in.

  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
  • platform/chromium-win/printing/setPrinting-expected.txt: Added property svn:eol-style.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
  • platform/mac/printing/setPrinting-expected.txt: Added property svn:eol-style.
  • platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
09:55 Changeset [99287] by vestbo@webkit.org

[Qt] Don't error out on wrong Qt version when qmake does recursive includes

Reviewed by Simmon Hausmann.

09:41 Changeset [99286] by enne@google.com

[chromium] Fix incorrect visibility/scissor rect for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70962

Reviewed by James Robinson.

Source/WebCore:

In order to properly scroll independent of layout on the compositor
thread, we have to apply the scroll to the right layer. Previously,
the NonCompositedContentHost was the root of the graphics layer tree
with all other layers underneath it. However, applying a scroll to
that layer would also scroll the clip layer for the main frame
underneath it, causing visibility issues.

This patch moves the NonCompositedHost to be a child of the
RenderLayerCompositor's scroll layer. This was exposed on
RenderLayerCompositor, because there's no other way to get to this
layer in a way that doesn't make assumptions about the structure of
the layers on a frame.

This also removes the hacks in calculateVisibleLayerRect and
tilingTransform for scroll position.

Partially tested by existing compositor tests. Manually tested
threaded compositing scrolling.

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setScrollLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::scrollLayer):

  • platform/graphics/chromium/NonCompositedContentHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::applyScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::tilingTransform):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scrollLayer):

  • rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):

09:09 Changeset [99285] by philn@webkit.org

[GTK] Disable VIDEO_TRACK for now
https://bugs.webkit.org/show_bug.cgi?id=71547

Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac: VIDEO_TRACK is still a moving target, it's best to

disable it for now.

LayoutTests:

Skip media/track tests and rebaseline involved fast/dom test results.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
08:48 Changeset [99284] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Disable inspector tests temporarily because of a bug near build system refactoring.
08:31 Changeset [99283] by caryclark@google.com

Unreviewed gardening: 8th chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 602 of 608 files for brevity.]

  • platform/chromium-mac-leopard/css3/bdi-element-expected.png: Added.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.

...

  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac-leopard/transitions/move-after-transition-expected.png: Added.
08:29 Changeset [99282] by vestbo@webkit.org

[Qt] Disable STDIN check before cleaning build dir

It didn't work on the bots.

Reviewed by Ossy.

  • Scripts/webkitdirs.pm:
08:20 Changeset [99281] by vestbo@webkit.org

[Qt] Don't build all of webkit when running build-jsc

In case the whole webkit project was built, but we then subsequently
want to build only JSC, we need to run make in the proper subdirectory.

This also means the incremental target needs to be added to all
makefiles.

Reviewed by Simon Hausmann.

08:20 Changeset [99280] by vestbo@webkit.org

[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir

Reviewed by Ossy.

07:54 Changeset [99279] by hausmann@webkit.org

Fix run-javascriptcore-tests for Qt when it's executed by the bot.

Reviewed by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(jscProductDir): jsc path changed.

07:03 Changeset [99278] by vestbo@webkit.org

[Qt] Error out early if trying to build against Qt < 4.8

Reviewed by Simon Hausmann.

06:47 Changeset [99277] by hausmann@webkit.org

Fix run-launcher for Qt and Gtk.

Rubber-stamped by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(isWK2): Re-add isWK2(), as it's used in run-launcher.

06:39 Changeset [99276] by vestbo@webkit.org

[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.

Reviewed by Simon Hausmann.

06:37 Changeset [99275] by carlosgc@webkit.org

[GTK] Use web view title as window title in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71544

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewURIChanged): Removed extra space.
(webViewTitleChanged): Set window title using
webkit_web_view_get_title().
(browser_window_init): Set initial default window title.
(browserWindowConstructed): Connect to WebView notify::title
signal.

06:19 Changeset [99274] by vestbo@webkit.org

[Qt] Refactor and clean up the qmake build system

The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.

This is a short-list of the changes:

  • The rules for how to build targets are now mostly contained as prf-files in Tools/qmake/mkspecs/features. Using mkspecs also allows us to do pre- and post-processing of each project file, which helps to clean up the actual project files.
  • Derived sources are no longer generated as a separate make-step but is part of each target's project file as a subdir. Makefile rules are used to ensure that we run make on the derived sources before running qmake on the actual target makefile. This makes it easier to keep a proper dependency between derived sources and the target.
  • We use GNU make and the compiler to generate dependencies on UNIX-based systems running Qt 5. This allows us to lessen the need to run qmake, which should reduce compile time.
  • WebKit2 is now build by default if building with Qt 5. It can be disabled by passing --no-webkit2 to build-webkit.

The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.

https://bugs.webkit.org/show_bug.cgi?id=71222

Reviewed by Simon Hausmann.

05:28 Changeset [99273] by kenneth@webkit.org

[Qt] Support programmatic scrolling with the QTouchWebView

Reviewed by Simon Hausmann.

As more code can be shared between the programmatic scrolling and the
method for ensuring that the contents are within valid bounds, this
patch includes a bit of refactoring as well.

  • UIProcess/API/qt/qdesktopwebview_p.h:

(QDesktopWebViewPrivate::scrollPositionRequested):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scrollPositionRequested):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::scrollPositionRequested):

  • UIProcess/qt/QtTouchViewInterface.h:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::event):
(WebKit::boundPosition):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::pageDidRequestScroll):

  • UIProcess/qt/QtWebPageProxy.h:
04:23 Changeset [99272] by commit-queue@webkit.org

[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=71548

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-04
Reviewed by Tony Gentilcore.

  • WebCore.gypi:
02:20 Changeset [99271] by eric@webkit.org

Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed. Fixing exception seen when running test-webkitpy.

Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
unittest, since that script is nearly ready to be deleted. But I added
it back at the last second and failed to run the tests. :(
This fixes the exception the bots were seeing.

  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
02:13 Changeset [99270] by paroga@webkit.org

[WINCE] Use default LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=71495

Reviewed by Adam Roben.

Use LocalizationStrategy from WebCore instead of using a copy of the strings in WebKit.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:
  • WebCoreSupport/PlatformStrategiesWinCE.h:
02:04 Changeset [99269] by philn@webkit.org

Unreviewed, skip some fast/viewport failing tests on GTK after r99195.

  • platform/gtk/Skipped:
01:53 Changeset [99268] by gyuyoung.kim@samsung.com

[EFL] Use standard booleand data type.
https://bugs.webkit.org/show_bug.cgi?id=71433

This is a fourth step in order to be more compliant with WebKit coding style.
Use standard boolean data type instead of efl boolean data type. It makes efl port
is more close to webkit coding style.

Reviewed by Zoltan Herczeg.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_js.cpp:
  • ewk/ewk_main.cpp:
  • ewk/ewk_network.cpp:
  • ewk/ewk_private.h:
  • ewk/ewk_protocol_handler.cpp:
  • ewk/ewk_protocol_handler_soup.cpp:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_model.cpp:
  • ewk/ewk_util.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
01:20 Changeset [99267] by paroga@webkit.org

Unreviewed CMake build fix for !ENABLE(SQL_DATABASE).

  • CMakeLists.txt: Always compile the SQLite source files, since they are required for build.
01:06 Changeset [99266] by yutak@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Add more expectations for recent test flakinesses.
Note: See TracTimeline for information about the timeline view.