Timeline


and

11/13/11:

23:57 Changeset [100103] by ossy@webkit.org

[Qt] Unreviewed gardening after r100036.

  • platform/qt/svg/foreignObject/clip-expected.png: Added.
  • platform/qt/svg/foreignObject/clip-expected.txt: Added.
  • platform/qt/svg/foreignObject/filter-expected.png: Added.
  • platform/qt/svg/foreignObject/filter-expected.txt: Added.
  • platform/qt/svg/foreignObject/mask-expected.png: Added.
  • platform/qt/svg/foreignObject/mask-expected.txt: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.
23:57 Changeset [100102] by abarth@webkit.org

Document::initSecurityOrigin should return earlier more often
https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

23:53 Changeset [100101] by abarth@webkit.org

SecurityPolicy should refer to isUnique rather than isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time. Previously, this code checked
for empty origins, which are technically a subset of unique origins. I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

23:50 Changeset [100100] by abarth@webkit.org

Move isSecureTransitionTo from SecurityOrigin to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

  • dom/SecurityContext.h:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
21:14 Changeset [100099] by nduca@chromium.org

[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

19:06 Changeset [100098] by tkent@chromium.org

[Chromium] Remove WebFileChooserParams::acceptTypes
https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h: Remove acceptTypes.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

16:02 Changeset [100097] by commit-queue@webkit.org

[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

  • ewk/ewk_view.h:
15:03 Changeset [100096] by commit-queue@webkit.org

[EFL] Simplify eina_stringshare usage in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

14:44 Changeset [100095] by yuqiang.xian@intel.com

Fix silent spilling/filling GPRs in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

13:30 Changeset [100094] by gavinp@chromium.org

command line control of webcore log channels in chromium DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

13:05 Changeset [100093] by scheib@chromium.org

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

09:43 Changeset [100092] by jchaffraix@webkit.org

REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

  • css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

  • fast/media/update-media-query-css-parser-expected.txt: Added.
  • fast/media/update-media-query-css-parser.html: Added.
07:26 Changeset [100091] by scheib@chromium.org

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
06:53 Changeset [100090] by andreas.kling@nokia.com

Only HTMLAllCollection needs stateful named item traversal.
<http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

  • html/HTMLCollection.h:

Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
Promoted itemAfter() and checkForNameMatch() to protected methods so
they can be called from HTMLAllCollection.

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):

  • html/HTMLFormCollection.h:
01:28 Changeset [100089] by mrowe@apple.com

Fix the 32-bit build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

00:09 Changeset [100088] by caio.oliveira@openbossa.org

Update binding generator tests to use jsCast
https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

11/12/11:

23:40 Changeset [100087] by commit-queue@webkit.org

Unreviewed, rolling out r100038.
http://trac.webkit.org/changeset/100038
https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

  • platform/qt/ScrollbarThemeQt.h:
20:37 Changeset [100086] by laszlo.1.gombos@nokia.com

[Qt][Symbian] Remove support for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

  • API/JSStringRef.h:
  • create_hash_table: Revert r45553.
  • runtime/JSGlobalData.cpp: Revert r45553.
  • runtime/LiteralParser.cpp: Remove WINSCW comment.

(JSC::LiteralParser::Lexer::lexString):

  • runtime/Lookup.h: Revert r45553.
  • runtime/Structure.h: Revert r48461.
  • wtf/Alignment.h:
  • wtf/Assertions.h: Revert r52337.
  • wtf/Compiler.h:
  • wtf/ListRefPtr.h: Revert r48988.

(WTF::ListRefPtr::~ListRefPtr):

  • wtf/OwnArrayPtr.h: Revert r45911.

(WTF::OwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassOwnArrayPtr.h:

(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassRefPtr.h:
  • wtf/StaticConstructors.h:
  • wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

(WebCore::CachedResourceHandle::CachedResourceHandle):

  • rendering/style/RenderStyle.h: Revert r52733.

(compareEqual):

  • bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

  • Shared/API/c/WKString.h:
16:47 Changeset [100085] by annacc@chromium.org

Add WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html

media/track/track-webvtt-tc001-utf8.html
media/track/track-webvtt-tc002-bom.html
media/track/track-webvtt-tc003-newlines.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc010-no-timings.html
media/track/track-webvtt-tc011-blank-lines.html
media/track/track-webvtt-tc012-out-of-order.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc014-alignment.html
media/track/track-webvtt-tc015-positioning.html
media/track/track-webvtt-tc016-align-positioning.html
media/track/track-webvtt-tc017-line-position.html
media/track/track-webvtt-tc018-align-text-line-position.html
media/track/track-webvtt-tc019-cue-size.html
media/track/track-webvtt-tc020-cue-size-align.html
media/track/track-webvtt-tc021-valign.html
media/track/track-webvtt-tc022-entities.html
media/track/track-webvtt-tc023-markup.html
media/track/track-webvtt-tc024-timestamp.html
media/track/track-webvtt-tc025-class-markup.html
media/track/track-webvtt-tc026-voice.html
media/track/track-webvtt-tc027-empty-cue.html
media/track/track-webvtt-tc028-unsupported-markup.html

  • html/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.

  • html/TextTrack.h: The cues() function can no longer be const.
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after

all other startTimes in the list.

LayoutTests:

  • media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
15:27 Changeset [100084] by nduca@chromium.org

Fixes to GraphicsContext3D::makeCurrent on gtk and mac
https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

14:13 Changeset [100083] by mitz@apple.com

<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

10:43 Changeset [100082] by paroga@webkit.org

Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

  • dfg/DFGCorrectableJumpPoint.cpp:
  • dfg/DFGCorrectableJumpPoint.h:
09:30 Changeset [100081] by paroga@webkit.org

[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
08:14 Changeset [100080] by paroga@webkit.org

Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

05:51 Changeset [100079] by paroga@webkit.org

Add stub implementation for SVGResources::filter()
https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::selfWillPaint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::selfWillPaint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

05:33 Changeset [100078] by antti@apple.com

REGRESSION(r98542): Rendering error on Google maps
https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

  • fast/css/vertical-align-length-copy-bug-expected.txt: Added.
  • fast/css/vertical-align-length-copy-bug.html: Added.
04:01 Changeset [100077] by commit-queue@webkit.org

[Qt] Fix minor config typo in the build tool documentation
https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

  • qmake/README:
03:09 Changeset [100076] by commit-queue@webkit.org

Unreviewed, rolling out r100013.
http://trac.webkit.org/changeset/100013
https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLTextAreaElement.idl:

LayoutTests:

  • fast/forms/access-key-for-all-elements-expected.txt: Removed.
  • fast/forms/access-key-for-all-elements.html: Removed.
02:39 Changeset [100075] by zimmermann@webkit.org

2011-11-12 Nikolas Zimmermann <nzimmermann@rim.com>

Finish SVGLengthContext conversion in svg/
https://bugs.webkit.org/show_bug.cgi?id=72105

Reviewed by Antti Koivisto.

Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
Now that this process is finished, SVGLengthContext can be shared across renders,
so that its possible to override the length context in a single place. This will
be done in future patches.

Doesn't affect any tests yet.

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::containerTranslation):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • svg/SVGElement.h:
  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::currentViewBoxRect):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
00:52 Changeset [100074] by paroga@webkit.org

[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

  • Source/cmake/WebKitMacros.cmake:
00:40 Changeset [100073] by paroga@webkit.org

Unreviewed build fix for !ENABLE(FILTERS) after r100036.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

11/11/11:

23:57 Changeset [100072] by paroga@webkit.org

[WIN] Fix build without precompiled header.
https://bugs.webkit.org/show_bug.cgi?id=72115

Unreviewed. Add missing includes to fix build without precompiled header.

  • platform/ContextMenu.h:
  • platform/graphics/win/DIBPixelData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/network/cf/ResourceError.h:
  • platform/win/LanguageWin.cpp:
  • platform/win/LocalizedStringsWin.cpp:
  • platform/win/LoggingWin.cpp:
23:11 Changeset [100071] by joepeck@webkit.org

<http://webkit.org/b/72205> Remove Duplicate Symbol Exports

Reviewed by Dan Bernstein.

  • WebCore.exp.in: Remove duplicate symbols listed.

Each dup in this case was already always exported.

21:24 Changeset [100070] by thakis@chromium.org

[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/DebuggerAgentManager.cpp:

(WebKit::DebuggerAgentManager::debugHostDispatchHandler):
(WebKit::DebuggerAgentManager::onWebViewClosed):

  • src/DebuggerAgentManager.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

  • src/WebViewImpl.cpp:

(WebKit::pageGroupLoadDeferrerStack):
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):

20:48 Changeset [100069] by ojan@chromium.org

Chromium layout test rebaselines after http://trac.webkit.org/changeset/100045
and http://trac.webkit.org/changeset/100036.

Also add line for failing text test after http://trac.webkit.org/changeset/99963.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/clip-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/filter-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/mask-expected.txt: Added.
  • platform/chromium-win/svg/repaint/filter-child-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png.
  • platform/chromium/svg/foreignObject/clip-expected.txt: Added.
  • platform/chromium/svg/foreignObject/filter-expected.txt: Added.
  • platform/chromium/svg/foreignObject/mask-expected.txt: Added.
  • platform/chromium/svg/repaint/filter-child-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt.
  • platform/chromium/test_expectations.txt:
20:45 Changeset [100068] by nduca@chromium.org

Since GraphicsContext3D::makeContextCurrent can fail, return bool.

https://bugs.webkit.org/show_bug.cgi?id=72101

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:
20:40 Changeset [100067] by ojan@chromium.org

Source/WebCore: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::appendColumn):

LayoutTests: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

  • fast/table/crash-splitColumn-2-expected.txt: Removed.
  • fast/table/crash-splitColumn-2.html: Removed.
  • fast/table/crash-splitColumn-3-expected.txt: Removed.
  • fast/table/crash-splitColumn-3.html: Removed.
  • fast/table/crash-splitColumn-expected.txt: Removed.
  • fast/table/crash-splitColumn.html: Removed.
20:28 Changeset [100066] by commit-queue@webkit.org

[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
https://bugs.webkit.org/show_bug.cgi?id=72200

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

How did I get here I am not good with computers.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionCommit):

20:23 Changeset [100065] by dmazzoni@google.com

Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

  • accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
  • accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.
19:37 Changeset [100064] by annacc@chromium.org

Storage and retrieval of TextTrackCues during video playback, including
cuechange, enter, and exit events.
https://bugs.webkit.org/show_bug.cgi?id=70452

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-cues-cuechange.html

media/track/track-cues-enter-exit.html
media/track/track-cues-seeking.html

Add cuechange, enter, and exit events and make TextTrack and
TextTrackCue EventTargets:

  • dom/EventNames.h:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTimerFired):

Use scheduleLoad() instead of configureTextTracks() to start an async load.

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Updates the list of currently active cues during playback.

(WebCore::HTMLMediaElement::textTrackAddCues):

Adds cues to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCues):

Removes cues from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::textTrackAddCue):

Adds a cue to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCue):

Removes a cue from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::playbackProgressTimerFired):

Update the active TextTrackCues when playbackProgressTimerFired.

(WebCore::HTMLMediaElement::addTrack):

Pass along a ScriptExecutionContext to TextTrack::create().

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

Update the active TextTrackCues when the media player time changes.

  • html/HTMLMediaElement.h:

Use a PodIntervalTree cueTree to store and retrieve TextTrackCues
during playback.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::LoadableTextTrack::fireCueChangeEvent):

Fire a cue change event on this TextTrack's <track>

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):

Return a TextTrackCueList that represents the currently active cues.

(WebCore::TextTrack::fireCueChangeEvent):

Fires a cue change event.

  • html/TextTrack.h:

(WebCore::TextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/TextTrack.idl:

Makes TextTrack extend EventTarget interface and add oncuechange.

  • html/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):

TextTrackCue should extend EventTarget, not ActiveDOMObject.

(WebCore::TextTrackCue::isActive):
(WebCore::TextTrackCue::setIsActive):

Dispatch an enter or exit event depending on active state and notify
the corresponding track to fire a cuechange event.

The following are needed for EventTarget interface:
(WebCore::TextTrackCue::interfaceName):
(WebCore::TextTrackCue::scriptExecutionContext):
(WebCore::TextTrackCue::eventTargetData):
(WebCore::TextTrackCue::ensureEventTargetData):

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::refEventTarget):
(WebCore::TextTrackCue::derefEventTarget):

  • html/TextTrackCue.idl:

Extend EventTarget and add onenter and onexit.

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::activeCues):

Update and return the list of currently active cues.

(WebCore::TextTrackCueList::clear):

Clear the cues from list (needed to return same object each time).

  • html/TextTrackCueList.h:

The following are needed for EventTarget interface:

  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::interfaceName):
(WebCore::TrackBase::scriptExecutionContext):
(WebCore::TrackBase::eventTargetData):
(WebCore::TrackBase::ensureEventTargetData):

  • html/track/TrackBase.h:

(WebCore::TrackBase::refEventTarget):
(WebCore::TrackBase::derefEventTarget):

LayoutTests:

  • media/track/captions-webvtt/cues-chrono-order.vtt: Added.
  • media/track/captions-webvtt/cues-overlapping.vtt: Added.
  • media/track/track-cues-cuechange-expected.txt: Added.
  • media/track/track-cues-cuechange.html: Added.
  • media/track/track-cues-enter-exit-expected.txt: Added.
  • media/track/track-cues-enter-exit.html: Added.
  • media/track/track-cues-seeking-expected.txt: Added.
  • media/track/track-cues-seeking.html: Added.
19:29 Changeset [100063] by commit-queue@webkit.org

[Chromium] Remove unused variable added by r99813.
https://bugs.webkit.org/show_bug.cgi?id=72199

Patch by David Reveman <reveman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

19:15 Changeset [100062] by ojan@chromium.org

Unreviewed. Rolled DEPS.
https://bugs.webkit.org/show_bug.cgi?id=72174

  • DEPS:
18:58 Changeset [100061] by commit-queue@webkit.org

[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

18:56 Changeset [100060] by jamesr@google.com

Rollout http://trac.webkit.org/changeset/99844
Solution is more complicated than the problem it was intended to solve.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

18:53 Changeset [100059] by leviw@chromium.org

Revert Page to operate on integers
https://bugs.webkit.org/show_bug.cgi?id=72185

Reviewed by Eric Seidel.

Reverting the page classes to integers from LayoutUnits. It's not necessary to expose
LayoutUnits in these classes, so we'll avoid doing so.

No new tests, no change in behavior.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):

  • page/EventHandler.h:
  • page/Frame.cpp:

(WebCore::Frame::documentAtPoint):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::create):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • page/Page.h:
  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

18:24 Changeset [100058] by commit-queue@webkit.org

Updating the expected value, missed in r81312
https://bugs.webkit.org/show_bug.cgi?id=72170

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2011-11-11
Reviewed by Daniel Bates.

  • fast/viewport/viewport-128-expected.txt:
18:23 Changeset [100057] by dmazzoni@google.com

New iframe content may not be reflected in the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=72100

Reviewed by Chris Fleizach.

Source/WebCore:

The core issue was that when childrenChanged was called on a
web area from an iframe that was just detached, it wasn't calling
childrenChanged on its parent scroll area, or that scroll area's
parent iframe element. To fix this, now AccessibilityScrollView
implements setNeedsToUpdateChildren and parentObjectIfExists,
and childrenChanged calls setNeedsToUpdateChildren on every object
in the parent chain, not just AccessibilityRenderObjects.

Test: accessibility/loading-iframe-updates-axtree.html

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::setNeedsToUpdateChildren):

LayoutTests:

Add new test that makes sure that if you explore the accessibility
tree of an iframe and that iframe subsequently loads new content,
the iframe AccessibilityObject's descendants are updated to point
to the new content, not the old content.

  • accessibility/loading-iframe-updates-axtree-expected.txt: Added.
  • accessibility/loading-iframe-updates-axtree.html: Added.
18:10 Changeset [100056] by commit-queue@webkit.org

[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-11
Reviewed by Martin Robinson.

Provision to query and set the font related properties (such as
font-family, font-size) and charset properties (such as default-
charset) is added.

  • UIProcess/API/gtk/WebKitSettings.cpp: Added font and encoding properties.

(webKitSettingsSetProperty): GObject set property function.
(webKitSettingsGetProperty): GObject get property function.
(webkit_settings_class_init): Few more signals installed.
(webkit_settings_init): Initialization of instance variables.
(webkit_web_settings_get_default_font_family): Get 'default-font-family'.
(webkit_web_settings_set_default_font_family): Set 'default-font-family'.
(webkit_web_settings_get_monospace_font_family): Get 'monospace-font-family'.
(webkit_web_settings_set_monospace_font_family): Set 'monospace-font-family'.
(webkit_web_settings_get_serif_font_family): Get 'serif-font-family'.
(webkit_web_settings_set_serif_font_family): Set 'serif-font-family'.
(webkit_web_settings_get_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_set_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_get_cursive_font_family): Get 'cursive-font-family'.
(webkit_web_settings_set_cursive_font_family): Set 'cursive-font-family'.
(webkit_web_settings_get_fantasy_font_family): Get 'fantasy-font-family'.
(webkit_web_settings_set_fantasy_font_family): Set 'fantasy-font-family'.
(webkit_web_settings_get_pictograph_font_family): Get 'pictograph-font-family'.
(webkit_web_settings_set_pictograph_font_family): Set 'pictograph-font-family'.
(webkit_web_settings_get_default_font_size): Get 'default-font-size'.
(webkit_web_settings_set_default_font_size): Set 'default-font-size'.
(webkit_web_settings_get_default_monospace_font_size): Get 'default-monospace-font-size'.
(webkit_web_settings_set_default_monospace_font_size): Set 'default-monospace-font-size'.
(webkit_web_settings_get_minimum_font_size): Get 'minimum-font-size'.
(webkit_web_settings_set_minimum_font_size): Set 'minimum-font-size'.
(webkit_web_settings_get_default_charset): Get 'default-charset'.
(webkit_web_settings_set_default_charset): Set 'default-charset'.

  • UIProcess/API/gtk/WebKitSettings.h: Add new sections for gtk-doc generation.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Expose new public APIs.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

18:05 Changeset [100055] by commit-queue@webkit.org

[chromium] Fix CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

The behavior is different depending on whether we're showing
or hiding the compositor. This patch fixes both code paths.

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCCompletionEvent.h:

(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setVisible):

17:52 Changeset [100054] by commit-queue@webkit.org

[chromium] CCThreadProxy::finishAllRendering hangs if !visible
https://bugs.webkit.org/show_bug.cgi?id=71920

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedRedraw):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedRedraw):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

17:38 Changeset [100053] by commit-queue@webkit.org

[Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2011-11-11
Reviewed by Simon Hausmann.

Some benchmark tests requires network connection (they fetch data from
external URL's) and so they fail if no network is present. These tests
should be skipped instead.

  • tests/benchmarks/loading/tst_loading.cpp:

(tst_Loading::load): Skip test if no network is present.

  • tests/benchmarks/painting/tst_painting.cpp:

(tst_Painting::paint): Skip test if no network is present.

17:37 Changeset [100052] by jknotten@chromium.org

[Chromium] Enable building without shared workers.
https://bugs.webkit.org/show_bug.cgi?id=72122

Reviewed by Yury Semikhatsky.

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::retrieveWorkerContext):

17:26 Changeset [100051] by jchaffraix@webkit.org

Crash in styleDidChange when changing a table cell's height.
<http://webkit.org/b/72004>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-table-cell-change-height.html

fast/table/table-cell-change-height-with-needsCellRecalc-section.html
fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html
fast/table/table-row-change-height-with-needsCellRecalc-section.html

r99212 removed our call to recalcCells when the logical height changed. This
means that we could end up with a cells without having set its row() properly
which would crash.

The change exposes the was-the-row-properly-set information so that we don't
try to access a bogus index. This should work properly even if the section
needs a cell recalc as the current section's row structure would still be
accurate in this case.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): Check that our row index
was properly set before calling

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::rowWasSet): Helper function to detect
if we have set up our a row.
(WebCore::RenderTableCell::row): Use the previous function in the
ASSERT.

LayoutTests:

  • fast/table/crash-table-cell-change-height-expected.txt: Added.
  • fast/table/crash-table-cell-change-height.html: Added.
  • fast/table/table-cell-change-height-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-cell-change-height-with-needsCellRecalc-section.html: Added.
  • fast/table/table-cell-change-last-row-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html: Added.
  • fast/table/table-row-change-height-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-row-change-height-with-needsCellRecalc-section.html: Added.

Those tests checks that we don't try to access bad rows when the section needs a recalc.

17:21 Changeset [100050] by commit-queue@webkit.org

Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-11
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

  • editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):

Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.

  • testing/Internals.cpp:

(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

  • editing/spelling/spelling-unified-emulation-expected.txt: Added.
  • editing/spelling/spelling-unified-emulation.html: Added.
17:15 Changeset [100049] by gyuyoung.kim@samsung.com

[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=72092

Unreviewed. Fix build break when using curl.

ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built
when EFL port uses curl as network backend.

  • PlatformEfl.cmake: Add missing ProxyServerCurl.cpp.
17:12 Changeset [100048] by eae@chromium.org

Switch remaining RenderBlock/Box methods to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=72075

Reviewed by Eric Seidel.

Move margins, floats and line layout block logic to layout abstraction.

No new tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
(WebCore::setStaticPositions):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::checkLinesForTextOverflow):
(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

16:57 Changeset [100047] by commit-queue@webkit.org

[chromium] Add translation/scaling to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=72087

Patch by Antoine Labour <piman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

Covered by WebLayerTest.

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setUVRect):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::uvRect):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexStretch::VertexShaderPosTexStretch):
(WebCore::VertexShaderPosTexStretch::init):
(WebCore::VertexShaderPosTexStretch::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderPosTexStretch::matrixLocation):
(WebCore::VertexShaderPosTexStretch::offsetLocation):
(WebCore::VertexShaderPosTexStretch::scaleLocation):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setUVRect):

Source/WebKit/chromium:

  • public/WebExternalTextureLayer.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):

16:34 Changeset [100046] by commit-queue@webkit.org

Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Second attempt, with a fix to handle JS garbage collection.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/element-instance-held-by-js-crash.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance): Added call to detach() to clear

anything not yet cleared.

(WebCore::SVGElementInstance::detach): New method to replace old clear methods. This one

clears all the pointers it can, and removes the instance from the corresponding elements
instance list.

  • svg/SVGElementInstance.h: Removed clear methods and replaced with detach.
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance): Modified calls to clean up an SVGElementInstance.

LayoutTests:

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
  • svg/custom/element-instance-held-by-js-crash.svg: Added.
16:30 Changeset [100045] by commit-queue@webkit.org

clipPath does not work on foreignObject
https://bugs.webkit.org/show_bug.cgi?id=68251

Patch by Florin Malita <fmalita@google.com> on 2011-11-11
Reviewed by Dirk Schulze.

Source/WebCore:

Add ForeignObject clipping, filtering and masking support using the SVGRenderSupport helpers
(prepareToRenderSVGContent, finishRenderSVGContent) on RenderSVGForeignObject's paint path.
This also allows us to remove explicit transparency handling, since the helpers already cover it.

Tests: svg/foreignObject/clip.html

svg/foreignObject/filter.html
svg/foreignObject/mask.html

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

  • rendering/svg/SVGResources.cpp:

(WebCore::clipperFilterMaskerTags):

LayoutTests:

  • svg/foreignObject/clip-expected.png: Added.
  • svg/foreignObject/clip-expected.txt: Added.
  • svg/foreignObject/clip.html: Added.
  • svg/foreignObject/filter-expected.png: Added.
  • svg/foreignObject/filter-expected.txt: Added.
  • svg/foreignObject/filter.html: Added.
  • svg/foreignObject/mask-expected.png: Added.
  • svg/foreignObject/mask-expected.txt: Added.
  • svg/foreignObject/mask.html: Added.
16:07 Changeset [100044] by ojan@chromium.org

Revert http://trac.webkit.org/changeset/100008.
Caused hundreds of failures on the Chromium Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=68270

  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium/test_expectations.txt:
16:02 Changeset [100043] by ojan@chromium.org

Update expectations for failing test.

  • platform/chromium/test_expectations.txt:
15:54 Changeset [100042] by eae@chromium.org

Round offsetWidth/Height/Top/Left and client* before returning instead of flooring the values in the binding code

15:54 Changeset [100041] by adamk@chromium.org

Remove no-op StorageNamespace::unlock method
https://bugs.webkit.org/show_bug.cgi?id=72181

Reviewed by Darin Adler.

Source/WebCore:

The method was meant to support the localStorage mutex,
but the approach of using a mutex for localStorage has never been
implemented (and almost certainly won't be). Even if it were implemented,
it's not being called at the right time, due to bugs in the V8 bindings'
use of V8Proxy (see http://webkit.org/b/72063 for details).

If, in the future, some replacement for a mutex is used to synchronize
localStorage access, it can easily be re-added to the (hopefully
fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().

  • page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.

  • page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:

Source/WebKit/chromium:

  • src/StorageNamespaceProxy.cpp:
  • src/StorageNamespaceProxy.h:
15:52 Changeset [100040] by commit-queue@webkit.org

[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=49257

Source/WebKit/chromium:

Add the WebFrame::getPageProperty method for Chromium.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::getPageProperty):

  • src/WebFrameImpl.h:

Tools:

Adds the remaining missing layout test functionality for printing.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Add bindings for new JS methods
(parsePageNumber): Method to parse JS arguments for a page number
(parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
(LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
(LayoutTestController::isPageBoxVisible): get the visibility status for printing
(LayoutTestController::pageProperty): get a specific CSS property when in printing mode

  • DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • platform/chromium/test_expectations.txt: Removed expected fails for

printing tests that were using missing functionality in LayoutTestController.

15:50 Changeset [100039] by barraclough@apple.com

Update iOS compiler version.

Reviewed by David Kilzer.

  • Configurations/CompilerVersion.xcconfig:
    • Update compiler version.
15:44 Changeset [100038] by alexis.menard@openbossa.org

[Qt][WK2] Make sure Scrollbars are in their own layer.
https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

  • platform/qt/ScrollbarThemeQt.h:

(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

15:43 Changeset [100037] by barraclough@apple.com

Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187

Reviewed by David Kilzer.

  • interpreter/Interpreter.h:
    • Lower the reentry depth.
  • runtime/DatePrototype.cpp:
    • iOS also uses CF.
  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

  • Update fastmalloc configuration for iOS.
  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

  • Added flag.
  • wtf/Platform.h:
    • Update platform configuration for iOS.
15:40 Changeset [100036] by commit-queue@webkit.org

Repaint broken when children of filtered SVG elements are updated
https://bugs.webkit.org/show_bug.cgi?id=71733

Patch by Joel Webber <jgw@google.com> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/filter-child-repaint.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::setNeedsLayoutForFilteredContainer):

LayoutTests:

  • platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt: Added.
  • svg/repaint/filter-child-repaint.svg: Added.
15:19 Changeset [100035] by timothy@apple.com

Don't remove InspectorBackendStub.js in Release builds after it has been
combined into inspector.js. Also remove any *.qrc file on Mac.

https://webkit.org/b/72186

Reviewed by Joseph Pecoraro.

  • WebCore.xcodeproj/project.pbxproj:
15:15 Changeset [100034] by leviw@chromium.org

<svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
15:06 Changeset [100033] by ap@apple.com

WebProcess should use AppSandbox style quarantine
https://bugs.webkit.org/show_bug.cgi?id=72168
<rdar://problem/10434292>

Reviewed by Darin Adler.

  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.
14:55 Changeset [100032] by commit-queue@webkit.org

[chromium] Patch that implementing the changes required to allow WebGL
to share its backing store directly with the compositor.
WebGL rendering contexts create and render to FBOs managed by a
DrawingBuffer instance. All PlatformLayer lifetime management is
performed by the DrawingBuffer.
Changes are only relevant to Chromium ports. Functionality is
unchanged for other ports.
https://bugs.webkit.org/show_bug.cgi?id=53201

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-11
Reviewed by Stephen White.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Construct a DrawingBuffer

during initialization, and forward all framebuffer management calls to
it.
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::platformLayer):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h: WebGLLayerChromium instances

are no longer tracked by GraphicsContext3D. Callers can now pass a
DrawingBuffer instance to provide access to the WebGLLayerChromium data.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::framebuffer):
(WebCore::DrawingBuffer::markContextChanged):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::contentChanged):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
(WebCore::WebGLLayerChromium::context):

  • platform/graphics/chromium/WebGLLayerChromium.h: WebGLLayerChromium instances

have a raw reference to their owning DrawingBuffer. This reference is set to NULL on
destruction of the DrawingBuffer. This follows the old code, which had the WebGLLayerChromium
refer rawly to a GraphicsContext3D instance, which was also revoked during tear-down of the
GraphicsContext3D.
(WebCore::WebGLLayerChromium::drawingBuffer):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/graphics/gpu/DrawingBuffer.cpp: The DrawingBuffer is now the

central point between the GraphicsContext3D, WebGLRenderingContext, and
WebGLLayerChromium classes. GraphicsContext3D, and WebGLLayerChromium only
depend on the DrawingBuffer interface.
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::commit):
(WebCore::DrawingBuffer::multisample):
(WebCore::DrawingBuffer::paintRenderingResultsToImageData):
(WebCore::DrawingBuffer::discardResources):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setScissorEnabled):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp: GraphicsContext3DPrivate no longer caches

the WebGLLayerChromium instance. Instead, it is accessed via DrawingBuffer instances
passed as arguments to the necessary routines.
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • src/GraphicsContext3DPrivate.h:
14:54 Changeset [100031] by ddkilzer@apple.com

Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
<http://webkit.org/b/72175>

Reviewed by Joseph Pecoraro.

  • wtf/Platform.h: Move the definition of the BUILDING_ON_* and

TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds. Also include
Availability.h, which is needed on iOS builds.

14:51 Changeset [100030] by darin@apple.com

Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423

Reviewed by Julien Chaffraix.

Source/JavaScriptCore:

  • API/JSRetainPtr.h: Removed releaseRef.
  • wtf/PassRefPtr.h: Removed releaseRef.

Source/WebCore:

  • platform/win/COMPtr.h: Removed releaseRef.

Tools:

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.

14:50 Changeset [100029] by darin@apple.com
  • WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:41 Changeset [100028] by ojan@chromium.org

Unreviewed, rolling out r99953.
Caused 4 tests to hit an assert.
https://bugs.webkit.org/show_bug.cgi?id=72163

Source/WebCore:

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Removed.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Removed.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Removed.
  • platform/chromium/test_expectations.txt:
14:37 Changeset [100027] by scheib@chromium.org

Unreviewed, rolling out r100024.
http://trac.webkit.org/changeset/100024
https://bugs.webkit.org/show_bug.cgi?id=72158

Broke chromium build

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
14:35 Changeset [100026] by ojan@chromium.org

Fixup wrong expectations from http://trac.webkit.org/changeset/100008.
Pull in expectations from downstream expectations due to V8 roll.
Add new expectation for failure.

  • platform/chromium/test_expectations.txt:
14:30 Changeset [100025] by commit-queue@webkit.org

[EFL] Remove unused flags in pre-render implementation
https://bugs.webkit.org/show_bug.cgi?id=65504

The high priority pre-render flag was not used anywhere,
so we can get rid of the whole concept and always consider the requests have low priority

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-11-11
Reviewed by Daniel Bates.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_pre_render_request_add):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

14:29 Changeset [100024] by scheib@chromium.org

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

14:20 Changeset [100023] by ojan@chromium.org

Unreviewed, rolling out r99990.
http://trac.webkit.org/changeset/99990
https://bugs.webkit.org/show_bug.cgi?id=72134

Caused worker tests to fail on the chromium bots.

  • fast/workers/resources/worker-replace-self.js:

(worker.onmessage):

  • fast/workers/worker-call.html:
  • fast/workers/worker-close.html:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-replace-self.html:
14:19 Changeset [100022] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=72167
REGRESSION: Scroll position not restored on back after scroll
-and corresponding-
<rdar://problem/10410684>

Reviewed by Simon Fraser.

We can't just return early if we are not on an active page.
notifyPositionChanged() is called when a page is going into the page cache (and
therefore when not on an active page). We should not notify AppKit that the page
has scrolled in that case, but we still need to call
ScrollAnimator::notifyPositionChanged();. So this patch removes the early return,
and replaces it with a conditional around the relevant code.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyPositionChanged):

14:18 Changeset [100021] by commit-queue@webkit.org

Added TileCairo and TiledBackingStoreBackendCairo files
https://bugs.webkit.org/show_bug.cgi?id=71350

Patch by Julien Chaffraix <jchaffraix@codeaurora.org>, Zaheer Ahmad <zahimad@codeaurora.org>, Joone Hur <joone.hur@collabora.co.uk>, Tomasz Morawski <t.morawski@samsung.com> on 2011-11-11
Reviewed by Martin Robinson.

Added TileCairo and TiledBackingStoreBackend files needed by Tiled Backing Store implementation that uses cairo
library eg. EFL and Gtk WebKit port.

This patch contains some parts of rebased and updated code from 45423 bug. Originals authors of the code are:

  • platform/graphics/cairo/RefPtrCairo.cpp: Added support of RefPtr for cairo_region object.

(WTF::refIfNotNull): New refIfNotNull function for cairo_region object.
(WTF::derefIfNotNull): New derefIfNotNull function for cairo_region object.

  • platform/graphics/cairo/RefPtrCairo.h: Added support of RefPtr for cairo_region object.
  • platform/graphics/cairo/TileCairo.cpp: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::TileCairo):
(WebCore::TileCairo::~TileCairo):
(WebCore::TileCairo::isDirty):
(WebCore::TileCairo::isReadyToPaint):
(WebCore::TileCairo::invalidate):
(WebCore::TileCairo::updateBackBuffer):
(WebCore::TileCairo::swapBackBufferToFront):
(WebCore::TileCairo::paint):
(WebCore::TileCairo::resize):

  • platform/graphics/cairo/TileCairo.h: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::create):
(WebCore::TileCairo::coordinate):
(WebCore::TileCairo::rect):

  • platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp: Added a new file. Implementation of

TiledBackingStoreBackend methods.
(WebCore::TiledBackingStoreBackend::createTile):
(WebCore::checkeredSurface): Helper function that creates checkered surface (see below function)
(WebCore::TiledBackingStoreBackend::paintCheckerPattern): Function is used to draw a place holder when tile no
exist or it is not ready to paint yet. The checkered surface is used here.

14:15 Changeset [100020] by darin@apple.com
  • JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:15 Changeset [100019] by darin@apple.com
  • ANGLE.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:15 Changeset [100018] by darin@apple.com
  • WebKit2.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:14 Changeset [100017] by darin@apple.com
  • WebKit.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:07 Changeset [100016] by leviw@chromium.org

Reverting Page to integers

14:02 Changeset [100015] by commit-queue@webkit.org

Update expected results for composited canvas operations
https://bugs.webkit.org/show_bug.cgi?id=71995

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

  • canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
14:01 Changeset [100014] by jchaffraix@webkit.org

Remove unneeded frame check in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=71980

Reviewed by Anders Carlsson.

Change covered by the existing tests in scrollbars/.

  • page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Remove the leftover check that was forgotten by the different refactoring.

13:58 Changeset [100013] by commit-queue@webkit.org

Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-11
Reviewed by Adam Barth.

Source/WebCore:

As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
attribute idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLButtonElement.idl: Ditto.
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLabelElement.idl: Ditto.
  • html/HTMLLegendElement.idl: Ditto.
  • html/HTMLTextAreaElement.idl: Ditto.

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
13:42 Changeset [100012] by commit-queue@webkit.org

Remove color space information from canvas composited drawImage tests
https://bugs.webkit.org/show_bug.cgi?id=71970

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Stephen White.

  • fast/canvas/canvas-composite-canvas.html:
  • fast/canvas/canvas-composite-image.html:
13:25 Changeset [100011] by ojan@chromium.org

Unreviewed, rolling out r100010.
http://trac.webkit.org/changeset/100010
https://bugs.webkit.org/show_bug.cgi?id=72172

"Broke gclient syncing on the chromium bots." (Requested by
ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

  • DEPS:
13:05 Changeset [100010] by ojan@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
12:52 Changeset [100009] by commit-queue@webkit.org

Assertion failed if text field is cleared while drag&drop.
https://bugs.webkit.org/show_bug.cgi?id=61008

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-11
Reviewed by Ryosuke Niwa.

Test to drag-drop text from one input element to another clearing the first input
element. Fixed in Change set - http://trac.webkit.org/changeset/99085

  • fast/events/drag-text-with-clear-expected.txt: Added.
  • fast/events/drag-text-with-clear.html: Added.
12:51 Changeset [100008] by commit-queue@webkit.org

Re-enable layout test comparisons on chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=68270

Patch by Elliot Poger <epoger@google.com> on 2011-11-11
Reviewed by Adam Barth.

  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium/test_expectations.txt:
12:48 Changeset [100007] by jochen@chromium.org

Removing the 4th test in factory-deletedatabase-interactions.html
https://bugs.webkit.org/show_bug.cgi?id=72037

Reviewed by Ojan Vafai.

Removing the test since it's testing not-yet-written code. Once the new
code is written it will obviously come with the appropriate tests.

  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
12:40 Changeset [100006] by mhahnenberg@apple.com

Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):

  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):

  • runtime/JSCell.h:

(JSC::JSCell::visitChildren):
(JSC::jsCast):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):

  • runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::visitChildren):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSObject.cpp:

(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):

  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

Source/JavaScriptGlue:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • UserObjectImp.cpp:

(UserObjectImp::getCallData):
(UserObjectImp::getOwnPropertyNames):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::visitChildren):

Source/WebCore:

No new tests.

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::toThisObject):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineGetter):
(WebCore::JSDOMWindow::defineSetter):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getCallData):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getCallData):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getCallData):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

  • bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

  • bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

  • bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::JSTestObj::put):
(WebCore::JSTestObj::visitChildren):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallData):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildren):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Source/WebKit2:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::deletePropertyByIndex):
(WebKit::JSNPObject::getOwnPropertyNames):

12:31 Changeset [100005] by barraclough@apple.com

Enable DFG JIT for ARMv7/iOS.

Rubber stamped by Oliver Hunt.

  • wtf/Platform.h:
    • enable DFG JIT for ARMv7/iOS.
12:24 Changeset [100004] by scheib@chromium.org

Unreviewed, rolling out r99994.
http://trac.webkit.org/changeset/99994
https://bugs.webkit.org/show_bug.cgi?id=72150

Broke chromium windows build

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):

  • page/MouseLockable.cpp: Removed.
  • page/MouseLockable.h: Removed.
  • page/MouseLockable.idl: Removed.
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
11:49 Changeset [100003] by adamk@chromium.org

[v8] Remove unused V8Proxy::executingScript method
https://bugs.webkit.org/show_bug.cgi?id=72160

Reviewed by Nate Chapin.

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
11:47 Changeset [100002] by rniwa@webkit.org

Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
https://bugs.webkit.org/show_bug.cgi?id=72090

Reviewed by Eric Seidel.

Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

yay! r100002.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
11:45 Changeset [100001] by beidson@apple.com

Rubberstamped by Andy Estes

100,000!
Congratulations WebKit, and here's to hundreds of thousands more!

  • ChangeLog: Point out revision 100,000.
11:45 Changeset [100000] by ossy@webkit.org

100,000 !!!

Reviewed by Zoltan Herczeg.

  • ChangeLog: Point out revision 100,000.
11:45 Changeset [99999] by ddkilzer@apple.com

<http://webkit.org/b/71921> Remove use of strcpy in KURL

Reviewed by Antti Koivisto.

  • platform/KURL.cpp:

(WebCore::KURL::init): Replace strcpy() with strncpy().

11:41 Changeset [99998] by tony@chromium.org

Remove --force from gclient sync. The bots seem to have made it past
the update step.

  • Scripts/update-webkit:
11:32 Changeset [99997] by mhahnenberg@apple.com

De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=72035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.

(JSC::BytecodeGenerator::BytecodeGenerator):

  • interpreter/Interpreter.cpp: Ditto.

(JSC::Interpreter::execute):

  • runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
  • runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.

  • runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.

(JSC::TimeoutChecker::didTimeOut):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMGlobalObject.cpp: Changed constructor to support passing new GlobalObjectMethodTable pointer to parent class.

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp: Added static const GlobalObjectMethodTable and filled it in with the proper function pointers.

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::supportsProfiling): Changed to static to put in the method table.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Ditto.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Ditto.

  • bindings/js/JSDOMWindowBase.h:
11:28 Changeset [99996] by tony@chromium.org

Add --force to gclient sync. Once the cq bots cycle, we can remove
this since it slows down the normal sync.

  • Scripts/update-webkit:
11:14 Changeset [99995] by ojan@chromium.org

Unreviewed, rolling out r99869.
http://trac.webkit.org/changeset/99869
https://bugs.webkit.org/show_bug.cgi?id=72157

"Caused a ~400% perf regression on the Chromium intl1 page
cyclers" (Requested by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):

  • dom/Document.h:
  • html/CollectionType.h:

LayoutTests:

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
11:09 Changeset [99994] by scheib@chromium.org

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
11:07 Changeset [99993] by mhahnenberg@apple.com

De-virtualize JSGlobalObject::allowsAccessFrom
https://bugs.webkit.org/show_bug.cgi?id=71969

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to

JSDOMWindowBase and WebScriptObject.

Source/WebCore:

No new tests.

Since allowsAccessFrom is only used by WebScriptObject, we know that we'll always have a
JSDOMWindowBase, so we can simply have allowsAccessFrom to live in JSDOMWindowBase rather
than JSGlobalObject.

  • bindings/js/JSDOMWindowBase.h: De-virtualized allowsAccessFrom.
  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]): Added a cast from a JSGlobalObject to a JSDOMWindowBase in
order to call the allowsAccessFrom method.

10:56 Changeset [99992] by adamk@chromium.org

[MutationObservers] Support attributeFilter for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70860

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch adds an attributeFilter to the MutationObserverRegistration and
adds support for only observing attributes whose name are in the provided
filter set (array of strings).

Test: fast/mutation/observe-attributes.html.

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):

  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
(WebCore::MutationObserverRegistration::caseInsensitiveAttributeFilter):

  • dom/MutationObserverRegistration.h:
  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:
  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
10:40 Changeset [99991] by tony@chromium.org

When --force is used, also use --reset
https://bugs.webkit.org/show_bug.cgi?id=72129

Patch by Marc-Antoine Ruel <maruel@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

  • Scripts/update-webkit-chromium:
10:35 Changeset [99990] by tony@chromium.org

Speculative fix for a few worker tests.
https://bugs.webkit.org/show_bug.cgi?id=72134

Looking at the recent failures, it looks like the test starts and completes
before the page is done loading completely (the test output is correct except
for the HTML on top of the files). So start the tests from an onload callback so
that the plain HTML text also gets printed correctly.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-11-11
Reviewed by Tony Chang.

  • fast/workers/resources/worker-replace-self.js:

(startTest.worker.onmessage):
(startTest):

  • fast/workers/worker-call.html:
  • fast/workers/worker-close.html:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-replace-self.html:
10:30 Changeset [99989] by tony@chromium.org

allow two chromium drivers to run at the same time in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72067

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on

posix prevents the subprocesses from sharing the same fd for stdin.
Sharing the same fd prevents us from closing the files unless all references
to the fd are closed.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition

to adding a test for this, speed up a test (from 3sec to 0) by fixing
the timeout override. It looks like it regressed in r95875.

10:28 Changeset [99988] by vsevik@chromium.org

Application cache status indicator gets stuck at DOWNLOADING after a failure
https://bugs.webkit.org/show_bug.cgi?id=60793

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):

LayoutTests:

  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt:
  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html: Added.
  • http/tests/inspector/resource-tree/appcache-test.js: Added.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameManifestStatusEventReceived):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/resource-tree/resources/manifest.php:
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
10:20 Changeset [99987] by tonyg@chromium.org

[chromium] failing media/track/tracklist-is-reachable
https://bugs.webkit.org/show_bug.cgi?id=72149

  • platform/chromium/test_expectations.txt: Expect test to fail for now.
10:03 Changeset [99986] by timothy@apple.com

Only use the textured window style mask when there is no override inspector page.

https://webkit.org/b/72142

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen): Don't set NSTexturedBackgroundWindowMask if
there is an override inspector page. Make setAutorecalculatesContentBorderThickness:,
setContentBorderThickness: and WKNSWindowMakeBottomCornersSquare conditional.

09:58 Changeset [99985] by tonyg@chromium.org

Expect chromium to pass this test after r99958.

  • platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
09:33 Changeset [99984] by eric.carlson@apple.com

Implement TextTrackList and the textTracks attribute of HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=71123

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-add-track.html

media/track/tracklist-is-reachable.html

  • CMakeLists.txt: Add new files for TextTrackList.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSTextTrackListCustom.cpp: Added.

(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

  • dom/EventTargetFactory.in: Add TextTrackList, conditional on VIDEO_TRACK.
  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForJSConstructor): Update for scheduleLoad change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::insertedIntoDocument): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::scheduleLoad): Add a parameter so caller can specify if

the main resource or a text track should be loaded.

(WebCore::HTMLMediaElement::loadTimerFired): Update to allow text track loading.
(WebCore::HTMLMediaElement::loadInternal): Don't call loadTextTracks.
(WebCore::HTMLMediaElement::isSafeToLoadURL): Log when CSP denies load.
(WebCore::HTMLMediaElement::playInternal): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::addTrack): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::addTextTrack): New, add track to m_textTracks and configure.
(WebCore::HTMLMediaElement::configureTextTracks): New, add comments about what this should

do eventually.

(WebCore::HTMLMediaElement::textTracks): New, return TextTrackList.
(WebCore::HTMLMediaElement::trackWasAdded): Bail if runtime feature is not enabled, schedule

asynchronous text track load.

(WebCore::HTMLMediaElement::trackWillBeRemoved): Minor cleanup.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Update for scheduleLoad change.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl: Add textTracks attribute.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree): Use new mediaElement() method.
(WebCore::HTMLTrackElement::willRemove): Ditto.
(WebCore::HTMLTrackElement::attributeChanged): When 'src' is changed, call scheduleLoad

instead of HTMLMediaElement

(WebCore::HTMLTrackElement::isDefault): hasAttribute -> fastHasAttribute.
(WebCore::HTMLTrackElement::track): Allocate track if necessary.
(WebCore::HTMLTrackElement::scheduleLoad): New, tell the track to schedule a load.
(WebCore::HTMLTrackElement::canLoadUrl): New, check security policy to see if it is OK

to load a text track. If so, dispatch 'beforeload' event to give it a chance to disallow
load.

(WebCore::HTMLTrackElement::loadingCompleted): Renamed from textTrackLoadingCompleted.
(WebCore::HTMLTrackElement::textTrackReadyStateChanged): New, TextTrackLoadingClient interface

used to inform parent of TextTrack state changes.

(WebCore::HTMLTrackElement::textTrackModeChanged): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCues): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCues): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCue): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCue): Ditto.
(WebCore::HTMLTrackElement::mediaElement): New, return parent element.

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize new instance variables.
(WebCore::LoadableTextTrack::scheduleLoad): New, prime a timer to kick off loading.
(WebCore::LoadableTextTrack::loadTimerFired): Cancel current load, if any, check to see if

new url is allowed to load, and start new load.

(WebCore::LoadableTextTrack::cueLoadingCompleted):

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrackClient::~LoadableTextTrackClient): TextTrackLoadingClient -> LoadableTextTrackClient
(WebCore::LoadableTextTrackClient::canLoadUrl):
(WebCore::LoadableTextTrackClient::loadingCompleted):
(WebCore::LoadableTextTrack::create):

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): setClient(0) -> clearClient().

  • html/TextTrack.h:

(WebCore::TextTrack::clearClient): Renamed from setClient, because it is only used to clear the client pointer.

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Get rid of a compiler warning that breaks the OS X build.

  • html/track/TextTrackList.cpp: Added. Implement the TextTrackList object.

(TextTrackList::TextTrackList):
(TextTrackList::~TextTrackList):
(TextTrackList::length):
(TextTrackList::item):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::interfaceName):
(TextTrackList::scheduleAddTrackEvent):
(TextTrackList::asyncEventTimerFired):

  • html/track/TextTrackList.h: Added.

(WebCore::TextTrackList::create):
(WebCore::TextTrackList::scriptExecutionContext):
(WebCore::TextTrackList::clearOwner):
(WebCore::TextTrackList::owner):
(WebCore::TextTrackList::refEventTarget):
(WebCore::TextTrackList::derefEventTarget):
(WebCore::TextTrackList::eventTargetData):
(WebCore::TextTrackList::ensureEventTargetData):

  • html/track/TextTrackList.idl: Added.
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::cancelLoad): New, cancel pending or in progress load and delete loader.
(WebCore::TextTrackLoader::notifyFinished): Call cancelLoad.
(WebCore::TextTrackLoader::load): Ditto.

  • loader/TextTrackLoader.h:
  • page/DOMWindow.idl: Add TextTrackList.

LayoutTests:

  • media/track/track-add-track-expected.txt: Added.
  • media/track/track-add-track.html: Added.
  • media/track/tracklist-is-reachable-expected.txt: Added.
  • media/track/tracklist-is-reachable.html: Added.
09:18 Changeset [99983] by pfeldman@chromium.org

Web Inspector: reimplement DOM search using no XPath.
https://bugs.webkit.org/show_bug.cgi?id=72125

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorDOMAgent.h:
08:55 Changeset [99982] by gavinp@chromium.org

Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

LayoutTests:

  • http/tests/misc/resources/xslt-bad-import-uri.xml: Added.
  • http/tests/misc/resources/xslt-bad-import-uri.xsl: Added.
  • http/tests/misc/xslt-bad-import-expected.txt: Added.
  • http/tests/misc/xslt-bad-import.html: Added.
08:53 Changeset [99981] by gavinp@chromium.org

Unreviewed, rolling out r99979.
http://trac.webkit.org/changeset/99979
https://bugs.webkit.org/show_bug.cgi?id=72136

bad commit message (Requested by gavinp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

08:50 Changeset [99980] by yurys@chromium.org

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Fixed overlapping expectations.

  • platform/chromium/test_expectations.txt:
08:47 Changeset [99979] by gavinp@chromium.org

Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by NOBODY (OOPS!).

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

08:43 Changeset [99978] by yurys@chromium.org

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark http/tests/inspector-enabled/dedicated-workers-list.html as timing out on Mac.

  • platform/chromium/test_expectations.txt:
08:35 Changeset [99977] by philn@webkit.org

[GStreamer] GstCaps and GstPad RefPtr implementation
https://bugs.webkit.org/show_bug.cgi?id=72023

Reviewed by Martin Robinson.

Smart pointer implementations for GstCaps and GstPad and them
in the media player code.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstPad):
(WTF::GstCaps):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(StreamingClient::didReceiveResponse):

08:33 Changeset [99976] by ossy@webkit.org

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
08:31 Changeset [99975] by gavinp@chromium.org

Unreviewed, rilling out 99971,99972.

They were landed in error in using git-svn by gavinp@chromium.org.

08:28 Changeset [99974] by ossy@webkit.org

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
08:27 Changeset [99973] by philn@webkit.org

Unreviewed, skip 2 failing pasteboard tests after r99924.

  • platform/gtk/Skipped:
08:25 Changeset [99972] by gavinp@chromium.org

Moar

08:25 Changeset [99971] by gavinp@chromium.org

first shot yo

08:22 Changeset [99970] by ossy@webkit.org

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
08:14 Changeset [99969] by tonyg@chromium.org

Another baseline for contain-and-cover-zoomed that I didn't catch earlier.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
07:52 Changeset [99968] by hausmann@webkit.org

Unreviewed, rolling out r99964.
http://trac.webkit.org/changeset/99964
https://bugs.webkit.org/show_bug.cgi?id=72124

Broke too many Qt tests (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • Target.pri:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::usesMenuList):

  • platform/qt/QtMobileWebStyle.cpp: Added.

(QtMobileWebStyle::QtMobileWebStyle):
(drawRectangularControlBackground):
(QtMobileWebStyle::drawChecker):
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::drawRadio):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawMultipleComboButton):
(QtMobileWebStyle::drawSimpleComboButton):
(QtMobileWebStyle::getButtonImageSize):
(QtMobileWebStyle::findComboButton):
(QtMobileWebStyle::drawComplexControl):

  • platform/qt/QtMobileWebStyle.h: Added.
  • platform/qt/QtStyleOptionWebComboBox.h:

(WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
(WebCore::QtStyleOptionWebComboBox::checkMultiple):

  • platform/qt/RenderThemeQStyle.cpp: Removed.
  • platform/qt/RenderThemeQStyle.h: Removed.
  • platform/qt/RenderThemeQt.cpp:

(WebCore::initStyleOption):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
(WebCore::RenderThemeQt::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::popupInternalPaddingBottom):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::findFrameLineWidth):
(WebCore::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::animationDurationForProgressBar):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):
(WebCore::RenderThemeQt::paintSliderThumb):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintInnerSpinButton):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQt.h:

(WebCore::StylePainter::isValid):
(WebCore::StylePainter::drawPrimitive):
(WebCore::StylePainter::drawControl):
(WebCore::StylePainter::drawComplexControl):

  • platform/qt/RenderThemeQtMobile.cpp: Removed.
  • platform/qt/RenderThemeQtMobile.h: Removed.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/webcore.prf:
07:42 Changeset [99967] by pfeldman@chromium.org

Not reviewed: fix Snow Leopard build.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

07:35 Changeset [99966] by hausmann@webkit.org

[Qt] Remove dead MeeGoTouch code.

Reviewed by Tor Arne Vestbø.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

07:22 Changeset [99965] by pfeldman@chromium.org

Web Inspector: make search in DOM panel scale.
https://bugs.webkit.org/show_bug.cgi?id=72118

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.performSearch.callback):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.searchResult.mycallback):
(WebInspector.DOMAgent.prototype.searchResult):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch.resultCountCallback):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult.):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
07:16 Changeset [99964] by hausmann@webkit.org

[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
07:14 Changeset [99963] by apavlov@chromium.org

Web Inspector: Option to configure indentation of pretty-printed Javascript
https://bugs.webkit.org/show_bug.cgi?id=72119

Reviewed by Pavel Feldman.

Source/WebCore:

Drive-by fix for field names and added indent caching, as suggested by Pavel Podivilov.

  • inspector/front-end/JavaScriptFormatter.js:

(FormattedContentBuilder):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype._addIndent):

  • inspector/front-end/ScriptFormatter.js:
  • inspector/front-end/ScriptFormatterWorker.js:

(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.scriptEnded):

LayoutTests:

  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
07:08 Changeset [99962] by andreas.kling@nokia.com

Unreviewed Chromium build fix after r99958.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationCustomCall):o

Remove hack that forced HTMLOptionsCollection to have a custom
callAsFunctionCallback().

06:55 Changeset [99961] by alexis.menard@openbossa.org

[Qt] Build fix of the private QML module with --no-webkit2.
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Tor Arne Vestbø.

  • Source/QtWebKit.pro:
06:50 Changeset [99960] by loislo@chromium.org

Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
https://bugs.webkit.org/show_bug.cgi?id=72096

JSON.parse doesn't garantee the order of keys.
We have to explicitly order the results according to Inspector.json spec.

Patch by Mike Lewis <mikelikespie@gmail.com> on 2011-11-11
Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.py:
06:50 Changeset [99959] by philn@webkit.org

Unreviewed, skip a svg test and GTK rebaseline after r99941.

  • platform/gtk/Skipped:
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
06:37 Changeset [99958] by andreas.kling@nokia.com

Remove ability to call HTMLCollections in V8 bindings as well.
<http://webkit.org/b/72045>

Reviewed by Anders Carlsson.

Source/WebCore:

Follow the JSC bindings and remove the ability to call HTMLCollections
in the V8 bindings (excluding HTMLAllCollection.)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderCustomCall):
(GenerateImplementationCustomCall):

  • dom/NodeList.idl:
  • html/HTMLCollection.idl:

Remove the V8CustomCall attribute as it's no longer needed.

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:

LayoutTests:

Add a test verifying that calling collections other than document.all
will now throw.

  • fast/dom/collection-calling-expected.txt: Added.
  • fast/dom/collection-calling.html: Added.
  • fast/dom/script-tests/collection-calling.js: Added.
06:22 Changeset [99957] by apavlov@chromium.org

Web Inspector: Interactive color box for gradients in CSS property values
https://bugs.webkit.org/show_bug.cgi?id=72112

Reviewed by Yury Semikhatsky.

Add "background-image" to the list of color-aware properties (may contain gradient definition).

  • inspector/front-end/CSSKeywordCompletions.js:
05:47 Changeset [99956] by vestbo@webkit.org

[Qt] Add missing include to PlatformWebViewQt

Reviewed by Simon Hausmann.

05:40 Changeset [99955] by yurys@chromium.org

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Correct test_expectations.

  • platform/chromium/test_expectations.txt:
05:34 Changeset [99954] by tonyg@chromium.org

Update chromium baselines after r99941.

That patch changed the number of zooms performed, so it seems to make sense that the
baseline would show a different sized image.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
05:20 Changeset [99953] by yurys@chromium.org

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

05:19 Changeset [99952] by alexis.menard@openbossa.org

[Qt] Add a way to have experimental features in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

.:

Add the new private QML module in the build.

  • Source/QtWebKit.pro:

Source/WebKit/qt:

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

  • declarative/private/plugin.cpp: Added.

(WebKitQmlPluginPrivate::registerTypes):

  • declarative/private/private.pro: Added.
  • declarative/private/qmldir: Added.

Source/WebKit2:

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.

(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):

  • UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.
05:12 Changeset [99951] by yurys@chromium.org

Unreviewed, rolling out r99950.
http://trac.webkit.org/changeset/99950
https://bugs.webkit.org/show_bug.cgi?id=72117

"Landed wrong patch by mistake" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/JavaScriptCore:

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

  • inspector/debugger/function-location-expected.txt: Removed.
  • inspector/debugger/function-location.html: Removed.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Removed.
05:05 Changeset [99950] by yurys@chromium.org

Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
04:47 Changeset [99949] by vestbo@webkit.org

[Qt] Fix incremental builds on Windows after buildsystem refactor

The qmake rules to ensure that we run make on the derived sources
before running qmake on the target were inside a unix-scope, which
resulted in flakey builds on Windows.

We now generate a rule on all platforms that ensures that "make qmake"
will always run make on the derived sources. In addition, on platforms
that have GNU make (where "make incremental" does not run "make qmake",
but only "make"), we add a similar rule that ensures that any time the
target makefile is regenerated we first run qmake and make on the derived
sources. This rule relies on GNU make's order-only-prerequisites to
not trigger a qmake-run of the target every time we run make.

https://bugs.webkit.org/show_bug.cgi?id=71778

Reviewed by Simon Hausmann.

04:46 Changeset [99948] by pfeldman@chromium.org

Not reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::MatchJob::MatchJob):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):

04:44 Changeset [99947] by apavlov@chromium.org

Web Inspector: [Metrics] Editor is committed when scrolling a content box dimension up/down for the first time
https://bugs.webkit.org/show_bug.cgi?id=72108

Reviewed by Pavel Feldman.

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

04:40 Changeset [99946] by hausmann@webkit.org

[Qt][WK2] Remove QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72113

Reviewed by Andreas Kling.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

Source/WebKit2:

Fold the functions and properties of QWebNavigationController into
QQuickWebView.

  • Target.pri:
  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage.h:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::canStop):
(QQuickWebView::canReload):
(QQuickWebView::title):

  • UIProcess/API/qt/qquickwebview.h:
  • UIProcess/API/qt/qwebnavigationcontroller.cpp: Removed.
  • UIProcess/API/qt/qwebnavigationcontroller.h: Removed.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):

Tools:

Adapt to the move of the QWebNavigationController functions/properties to
QQuickWebView.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
04:33 Changeset [99945] by hausmann@webkit.org

[Qt] Build system tweak

Reviewed by Tor Arne Vestbø.

Be a good qmake citizen, return true from our linkStaticLibrary
"test" function.

  • qmake/mkspecs/features/functions.prf:
04:33 Changeset [99944] by tonyg@chromium.org

Chromium expectations for new test in r99937.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
04:17 Changeset [99943] by hclam@chromium.org

[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=72081

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

LayerChromium and CCLayerTreeHosts hold RefPtr<>s to each other, so if
you do not clear out the layerTreeHost pointer on the LayerChromium
the layer tree is leaked. The real code does this in WebViewImpl but
this test was not.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

04:16 Changeset [99942] by hclam@chromium.org

[chromium] scrolling is broken with compositor thread
https://bugs.webkit.org/show_bug.cgi?id=72059

Reviewed by James Robinson.

No new test. Existing test CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls checks scroll deltas are applied
on the right layer.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::scrollLayer):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Instead of calling on the root layer which doesn't have scroll delta applied. Change this to scrollLayer()
which actually has scroll delta.

03:49 Changeset [99941] by zimmermann@webkit.org

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Zoltan Herczeg.

Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
This is the same fix I applied to the svg/zoom/page tests, I forgot this one.

  • fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
  • fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
  • platform/qt/Skipped: Unskip last regression from bug 7153.
03:47 Changeset [99940] by tonyg@chromium.org

Unreviewed, rolling out r99826.
http://trac.webkit.org/changeset/99826
https://bugs.webkit.org/show_bug.cgi?id=72109

"Likely causing test flakiness" (Requested by tonyg-cr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):

  • tests/data/page_with_image.mht: Removed.
03:37 Changeset [99939] by hausmann@webkit.org

[Qt] Add support for QT += webkit-private

Reviewed by Tor Arne Vestbø.

  • qmake/qt_webkit.pri: Declare private headers.
03:02 Changeset [99938] by tonyg@chromium.org

Fixing media/video-frame-accurate-seek.html expectation after r99887.

  • platform/chromium-cg-mac-leopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium-gpu-mac/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png.
02:31 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
01:52 Changeset [99937] by zimmermann@webkit.org

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

Add another minimal testcase using <object> embedding SVGs + zooming.

  • platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
  • svg/zoom/page/zoom-svg-as-object.html: Added.

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.

If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the
visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.

If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
"visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().

If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.

The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
as overflow "hidden" already.

The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.

That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
All svg/overflow tests, still work as expected.

Test: svg/zoom/page/zoom-svg-as-object.html

  • page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.

Otherwise scrollbars will appear, even though the contents would fit without them.

(WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has

an effect though, when the FrameView of the SVG is embedded through <object>/etc.

(WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before! (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
  • rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.
01:44 Changeset [99936] by zimmermann@webkit.org

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Unbreak my 32bit SL build.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateOrRemoveFilterEffect): Use narrowPrecisionToFloat() to convert float -> double.
01:03 Changeset [99935] by philn@webkit.org

Unreviewed, build fix attempt after r99907. Since that revision
GTK layout tests were not running at all...

  • Scripts/webkitpy/layout_tests/port/gtk.py:
00:40 Changeset [99934] by philn@webkit.org

HRTF Database consolidation
https://bugs.webkit.org/show_bug.cgi?id=69703

Reviewed by Kenneth Russell.

Access to the consolidated parts of the HRTF database by segmented
chunks. A concatenated Composite HRTF database is provided in
Composite.wav. Additionnally a new build step that concatenates
the platform/audio/resources/ files into one (sox can be used for
this) can be configured for specific ports.

  • platform/audio/HRTFDatabase.h:
  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

  • platform/audio/resources/Composite.wav: Added.
00:37 Changeset [99933] by pfeldman@chromium.org

Web Inspector: provide an id to the root inspector element for third party UA styling.
https://bugs.webkit.org/show_bug.cgi?id=72094

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.html:
00:11 Changeset [99932] by paroga@webkit.org

Unreviewed. Build fix for !ENABLE(JIT) after r99898.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

11/10/11:

23:39 Changeset [99931] by yutak@chromium.org

[Chromium] Unreviewed, add Linux baselines I forgot to commit in the last rebaseline.

  • platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
23:23 Changeset [99930] by aestes@apple.com

WebKitCSSShaderValue.h is not a member of the WebCore target
https://bugs.webkit.org/show_bug.cgi?id=72093

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Make WebKitCSSShaderValue.h a

member of the WebCore target, and make it a project header.

23:08 Changeset [99929] by mitz@apple.com

Disabling assertions breaks the debug build
https://bugs.webkit.org/show_bug.cgi?id=72091

Reviewed by Geoff Garen.

Source/JavaScriptCore:

  • dfg/DFGNode.h: Made hasIdentifier() available when assertions are

disabled. It is used in Graph::dump().

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): Update m_isCheckingForDefaultMarkViolation
only if assertions are enabled.

  • wtf/Deque.h:

(WTF::::checkIndexValidity): Changed ASSERT to ASSERT_UNUSED.

  • wtf/ThreadRestrictionVerifier.h:

(WTF::ThreadRestrictionVerifier::setShared): Guarded the definition of
a local variable that is only used in an assertion.

Source/WebCore:

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::didDecodeProperties): Guarded the definition of local variables that are
only used in an assertion correctly.

  • platform/graphics/gpu/TilingData.h: Changed ASSERT to ASSERT_UNUSED.

(WebCore::TilingData::assertTile):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed): Guarded the definition of a local variable that is
only used in an assertion correctly.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyResource): Changed ASSERT to ASSERT_UNUSED.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource): Changed ASSERT to ASSERT_UNUSED.
(WebCore::RenderSVGResourceFilter::postApplyResource): Changed ASSERT to ASSERT_UNUSED.

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource): Changed ASSERT to ASSERT_UNUSED.

22:53 Changeset [99928] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 7, the final)

  • platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-cg-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
  • platform/chromium-cg-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium/test_expectations.txt:
22:39 Changeset [99927] by fpizlo@apple.com

JSString forgets to clear m_fibers when resolving ropes
https://bugs.webkit.org/show_bug.cgi?id=72089

Reviewed by Geoff Garen.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRopeSlowCase):

22:28 Changeset [99926] by ossy@webkit.org

[Qt] Unreviewed morning gardening after r99862.

  • platform/qt/svg/foreignObject/background-render-phase-expected.png: Added.
  • platform/qt/svg/foreignObject/background-render-phase-expected.txt: Added.
20:13 Changeset [99925] by dcheng@chromium.org

[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
https://bugs.webkit.org/show_bug.cgi?id=71414

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no new functionality enabled yet.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/WebClipboard.h:

(WebKit::WebClipboard::writeDataObject):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardWriteDataObject):

20:12 Changeset [99924] by dcheng@chromium.org

Atomically update the system clipboard for copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=40515

Reviewed by David Levin.

This change consolidates the system pasteboard mutation logic into dispatchCPPEvent() rather
than having it scattered throughout tryDHTMLCopy/tryDHTMLCut and the various Clipboard*
classes. This allows us to ensure that the system pasteboard remains in a consistent state
even if there's an exception thrown during event handling, and it also lays the ground work
for allowing pages to prevent copy/cut without causing the system pasteboard to be cleared.

No new tests, since any layout test would be flaky since it would depend on and affect
global system state.

  • editing/Editor.cpp:

(WebCore::Editor::tryDHTMLCopy): Move Pasteboard::clear() call to dispatchCPPEvent().
(WebCore::Editor::tryDHTMLCut): Ditto.
(WebCore::Editor::dispatchCPPEvent):
Only persist Clipboard mutations to the system pasteboard if the event was dispatched
successfully and default processing was prevented.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard):
When creating a Clipboard for copy/cut, back it with a unique instance of NSPasteboard to
buffer pasteboard mutations.

  • platform/Pasteboard.h:
  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardGtk.

(WebCore::ClipboardGtk::setData):

  • platform/gtk/ClipboardGtk.h:

(WebCore::ClipboardGtk::clipboard):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeClipboard):
Implement logic to flush data from temporary NSPasteboard to system pasteboard.

  • platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardQt.

(WebCore::ClipboardGtk::setData):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::writeClipboard):

18:15 Changeset [99923] by ojan@chromium.org

Chromium rebaselines after r99902.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
18:10 Changeset [99922] by hayato@chromium.org

Unreviewed, rolling out r99916.
http://trac.webkit.org/changeset/99916
https://bugs.webkit.org/show_bug.cgi?id=72077

fast/harness/result.html seems platform dependent (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

  • platform/chromium/fast/harness/results-expected.txt: Added.
17:56 Changeset [99921] by eae@chromium.org

Revert Scrollbar::convertFromContainingView to int to avoid unnecessary type conversion

17:45 Changeset [99920] by scherkus@chromium.org

[Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=72001

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
17:41 Changeset [99919] by jchaffraix@webkit.org

RenderTableSection's recalcCell logic is doing too much work
https://bugs.webkit.org/show_bug.cgi?id=71986

Reviewed by Darin Adler.

No change in behavior expected so no test.

r98738 and r98980 missed the point that Vector::clear() does not touch
the internal buffer. Thus calling clear() would keep the memory and properly
reset the size().

Due to how the code worked, after r98980 the code would end up resetting some
of RowStruct field twice: once when growing and the other one when calling
fillRowsWithDefaultStartingAtPosition.

This change make the code use Vector::clear and simplified the recalcCells
logic knowing that growing the Vector will properly initialize most of the
RowStruct fields (with RowStruct constructor).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::addCell):
Updated after ensureRows signature change.

(WebCore::RenderTableSection::ensureRows):
Removed the overflow check as it was making some assumption as to how the
Vector worked. If we want to implement a limit, we may do it differently.
Also inlined the part of fillRowsWithDefaultStartingAtPosition that grows
the columns to match our current representation. The rest of the function's
initialization is handled by the constructor already.

(WebCore::RenderTableSection::recalcCells):
Use clear() as it keeps the buffer and just resets the size. Also shrinkToFit
at the end as we may have lost some rows.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::CellStruct::CellStruct):
Fixed the style of the constructor.

(WebCore::RenderTableSection::RowStruct::RowStruct):
Added an explicit constructor (which is equivalent to the default one)
but underlines what we expect.

17:26 Changeset [99918] by enrica@apple.com

ASSERT when outdenting styled line break.
https://bugs.webkit.org/show_bug.cgi?id=72069
<rdar://problem/10429739>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When outdenting a line break that has some inline style, we don't consider
the enclosing elements that provide the style.
This causes the splitting to occur in the wrong position,
triggering the assert.

Test: editing/execCommand/outdent-break-with-style.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph): The fix consists
in choosing the highest inline ancestor as splitting point.

  • editing/htmlediting.cpp:

(WebCore::isInline): Added.

  • editing/htmlediting.h: Added isInline.

LayoutTests:

  • editing/execCommand/outdent-break-with-style-expected.txt: Added.
  • editing/execCommand/outdent-break-with-style.html: Added.
17:07 Changeset [99917] by fpizlo@apple.com

DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

LayoutTests:

Reviewed by Oliver Hunt.

Added a test for byte arrays, and fixed a small bug in dfg-min-max.js.

  • fast/js/dfg-byte-array-put-expected.txt: Added.
  • fast/js/dfg-byte-array-put.html: Added.
  • fast/js/script-tests/dfg-byte-array-put.js: Added.

(doPut):
(doGet):

  • fast/js/script-tests/dfg-min-max.js:
16:50 Changeset [99916] by hayato@chromium.org

Unreviewed, revert a misplaced expected text in r99819.
A results-expected is platform independent. r99828 fixed this.

  • platform/chromium/fast/harness/results-expected.txt: Removed.
16:36 Changeset [99915] by bdakin@apple.com

Once more for the QT build.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setFindIndicator):

  • UIProcess/qt/QtWebPageProxy.h:
16:33 Changeset [99914] by bdakin@apple.com

More attempted build fix.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setFindIndicator):

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setFindIndicator):

  • UIProcess/API/gtk/PageClientImpl.h:
16:32 Changeset [99913] by andersca@apple.com

Fix 32-bit build.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(-[WKContentLayer drawInContext:]):

16:28 Changeset [99912] by bdakin@apple.com

Speculative build fix.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setFindIndicator):

  • UIProcess/win/WebView.h:
16:06 Changeset [99911] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66584
WebKit2's find bouncy looks blurry after dragging window onto >1.0 scale factor
display
-and corresponding-
<rdar://problem/9987559>

Reviewed by Anders Carlsson.

The setFindIndicator message and various functions of the same name must all take
an additional parameter indicating whether or not setting the find indicator
should result in a bounce animation. This is because when the device scale factor
changes, if there is currently a find indicator, it must be re-set to a higher or
lower resolution version, but we don't want the bounce animation to happen again.

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setFindIndicator:fadeOut:animate:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

New function FindController::isShowingOverlay() is used to determine if
FindController::deviceScaleFactorDidChange() needs to be called.

  • WebProcess/WebPage/FindController.h:

(WebKit::FindController::isShowingOverlay):

FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re-
generate the bitmap at the appropriate scale factor, but tells it not to animate
this time.
(WebKit::FindController::deviceScaleFactorDidChange):

updateFindIndicator() takes a new parameter indicating whether or not the
FindIndicator should animate. It defaults to true since the deviceScaleFactor
changing is the only case currently where we do not want it to animate.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

Calls into FindController::deviceScaleFactorDidChange() when the scale factor has
changed and the find overlay is showing.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):

15:59 Changeset [99910] by fpizlo@apple.com

ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065

Reviewed by Gavin Barraclough and Geoff Garen.

Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC::isFunctionPrediction):

  • bytecode/ValueProfile.cpp:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

15:47 Changeset [99909] by fpizlo@apple.com

bencher script should support remote benchmarking
https://bugs.webkit.org/show_bug.cgi?id=71618

Rubber-stamped by Geoff Garen.

Added the following features:

  • Benchmark report tells you the hostname and machine model (according to 'sysctl hw.model') of the machine you did the run on, and svn revision number (according to 'svn info') of the VMs you're testing.


  • The --remote option. You give this an ssh-style hostname (i.e. user@host is acceptable, in addition to just host, in which case your username is used) and it automatically packages the build directories of the VMs you're testing, sends them to the remote machine along with your copy of the bencher script and all of the options you passed. This pretty much seamlessly allows you to run a set of benchmarks on any machine that is sufficiently compatible with yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which must now include a tempPath setting that tells bencher where to put files when that machine is used as a slave in a remote benchmarking run.


  • Added yet another way of specifying which benchmarks to run. This was sort of necessary for --remote to work as expected. Previously, you either said what suites to exclude (for example --exclude-sunspider) or that you only wanted to run one suite to the exclusion of others (--sunspider-only). But it's often better to just be able to specify the list of suites you want. This is now supported. You can say, for example, --v8 --sunspider, which means, just run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is still supported.
  • Scripts/bencher:
15:32 Changeset [99908] by leviw@chromium.org

Adding a pixelSnappedIntRect method and using it throughout WebCore where enclosingIntRect wasn't actually appropriate.

15:31 Changeset [99907] by tony@chromium.org

Lazily start DRT instances in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72038

Reviewed by Eric Seidel.

Just a refactoring, no new tests.

  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:31 Changeset [99906] by ddkilzer@apple.com

<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR

Reviewed by Joseph Pecoraro.

script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation. Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.

15:11 Changeset [99905] by dino@apple.com

Remove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi?id=72058

Reviewed by Simon Fraser.

As suggested by Nikolas, we don't need this virtual method any more.

  • rendering/FilterEffectRenderer.h:
15:02 Changeset [99904] by barraclough@apple.com

Add ARMv7 support to the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72061

Reviewed by Geoff Garen.

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):

  • Add CPU(ARM) copies of these functions.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::spill):

  • Fix matching of '}' re #if blocks, makes some tools happy.

(JSC::DFG::JITCodeGenerator::setupArguments):
(JSC::DFG::JITCodeGenerator::setupArgumentsWithExecState):
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheckSetResult):
(JSC::DFG::JITCodeGenerator::appendCallSetResult):

  • Add CPU(ARM) / 4 argument register copies of these functions.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

  • Should use callOperation to plant a call to a DFG_OPERATION.

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • These methods need to plant a relinkable jump; we currently do so using beginUninterruptedSequence() / endUninterruptedSequence().
  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

  • Should use callOperation to plant a call to a DFG_OPERATION.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):

  • This method needs to plant a relinkable jump; we currently do so using beginUninterruptedSequence() / endUninterruptedSequence().

(JSC::DFG::JITCompiler::compileBody):

  • Add abstraction to retrieve the pc after a call.
  • dfg/DFGOSRExitCompiler.cpp:
    • Fix a bug - CodeLocationLabel needs a data address rather than an executable one, but can just take a MacroAssemblerCodePtr instead!
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::compileClampDoubleToByte):

  • Add FIXME comment to come back to! - bug#72054.
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

  • Add missing method (ooops, required by bug#72047)
  • dfg/DFGSpeculativeJIT32_64.cpp:
    • Need to wrap fmod on ARMv7.
15:01 Changeset [99903] by luiz@webkit.org

[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
https://bugs.webkit.org/show_bug.cgi?id=71530

Reviewed by Simon Hausmann.

Adding methods setGeometry and setFont so that users of platform plugin may show the
popup menus in proper position and using proper font.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

  • examples/platformplugin/WebPlugin.h:

(WebPopup::setGeometry):
(WebPopup::setFont):

  • examples/platformplugin/qwebkitplatformplugin.h:
14:59 Changeset [99902] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060

[CSS Line Grid] Add support for the line-grid-snap property to control snapping to the nearest
enclosing grid.

Reviewed by Dan Bernstein.

Added fast/line-grid/line-grid-snap-parsing.html.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineGridSnap):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineGridSnap):
(WebCore::InheritedFlags::setLineGridSnap):
(WebCore::InheritedFlags::initialLineGridSnap):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=72060

Add tests for line-grid-snap parsing.

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/line-grid/line-grid-snap-parsing-expected.txt: Added.
  • fast/line-grid/line-grid-snap-parsing.html: Added.
  • fast/line-grid/script-tests/line-grid-snap-parsing.js: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
14:52 Changeset [99901] by rniwa@webkit.org

ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
https://bugs.webkit.org/show_bug.cgi?id=72057

Reviewed by Eric Seidel.

Make the regular expression more explicit.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
14:43 Changeset [99900] by haraken@chromium.org

CodeGeneratorV8.pm can generate Event constructors
https://bugs.webkit.org/show_bug.cgi?id=72055

Reviewed by Adam Barth.

This patch makes CodeGeneratorV8.pm generate Event constructors
and replaces a custom constructor of Event with the generated one.
After this patch is landed without regression,
I will replace custom constructors of all other Events.
This patch introduces two new IDLs:

  • [ConstructorTemplate=Event] IDL indicates that CodeGenerator should

generate an Event constructor.

  • [InitializedByConstructor] IDL on an attribute indicates that

the attribute can be initialized by the constructor.

Tests: fast/events/constructors/event-constructors.html

fast/events/constructors/custom-event-constructor.html
fast/events/constructors/progress-event-constructor.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Added a header for fillXXXXEventInit(...).
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].
(GenerateEventConstructorCallback): Generates an Event constructor. The generated code is the same as the code that had been written in V8EventConstructors.cpp.
(GenerateImplementation): Generates an Event constructor if [ConstructorTemplate=Event] is specified.

  • dom/Event.idl: Added [ConstructorTemplate=Event] IDL. Added [InitializedByConstructor] IDL to attributes that can be initialized by a constructor.
  • bindings/scripts/test/TestEventConstructor.idl: Added a new run-bindings-test.
  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp: Updated a run-bindings-tests result.

(WebDOMTestEventConstructor::WebDOMTestEventConstructorPrivate::WebDOMTestEventConstructorPrivate):
(WebDOMTestEventConstructor::WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::operator=):
(WebDOMTestEventConstructor::impl):
(WebDOMTestEventConstructor::~WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::attr1):
(WebDOMTestEventConstructor::attr2):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp: Ditto.

(WebKit::kit):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):
(WebKit::core):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_set_property):
(webkit_dom_test_event_constructor_get_property):
(webkit_dom_test_event_constructor_constructed):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):
(WebKit::wrapTestEventConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.

(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::getConstructData):
(WebCore::JSTestEventConstructorPrototype::self):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype):
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::toJS):
(WebCore::toTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.

(WebCore::JSTestEventConstructor::create):
(WebCore::JSTestEventConstructor::createStructure):
(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructorPrototype::create):
(WebCore::JSTestEventConstructorPrototype::createStructure):
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestEventConstructor.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.mm: Ditto.

(-[DOMTestEventConstructor dealloc]):
(-[DOMTestEventConstructor finalize]):
(-[DOMTestEventConstructor attr1]):
(-[DOMTestEventConstructor attr2]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: Ditto.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.

(WebCore::TestEventConstructorInternal::V8_USE):
(WebCore::TestEventConstructorInternal::attr1AttrGetter):
(WebCore::TestEventConstructorInternal::attr2AttrGetter):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore::V8TestEventConstructor::wrapSlow):
(WebCore::V8TestEventConstructor::derefObject):

  • bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.

(WebCore::V8TestEventConstructor::toNative):
(WebCore::V8TestEventConstructor::existingWrapper):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h: Ditto.
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/V8/V8TestNamedConstructor.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
  • bindings/v8/custom/V8EventConstructors.cpp: Removed a custom constructor of Event.
14:27 Changeset [99899] by senorblanco@chromium.org

[chromium] Pre-emptively mark a canvas test as failing for next Skia roll.

  • platform/chromium/test_expectations.txt:
13:59 Changeset [99898] by fpizlo@apple.com

DFG should not reparse code that was just parsed
https://bugs.webkit.org/show_bug.cgi?id=71977

Reviewed by Geoff Garen.

The instruction stream of a code block is now kept around until
the next GC. When doing either an optimizing compilation of an
executable, or inlining of an executable, we now try to find the
already preexisting bytecode. If we find it, we don't have to parse.
If we don't find it, we parse as before. Inlining takes the extra
step of caching code blocks, so if the same executable gets inlined
multiple times into the same caller, then we parse it at most once
even if prior to inlining that executable did not have any code
blocks with an instruction stream.

Also fixed a silly bug where the strict mode for various operations
was being determined by looking at the machine code block rather
than the inlinee.

To enable the delete-on-next-GC policy, I introduced the notion
of an ultra weak finalizer, which anyone can register during
tracing. This is thread-safe (for parallel GC) and
stop-the-world-safe (so calls to free() are postponed until the
world is resumed). This required reusing some facilities previously
created for WeakReferenceHarvester, so I created a common utility
class. I also retweaked the handling of WeakReferenceHarvesters,
since they should be executed during stop-the-world since in the
future we may want to allow them to call drain().

2% win on SunSpider. 2% win on V8, when run in my harness. Neutral
elsewhere.

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::copyPostParseDataFrom):
(JSC::CodeBlock::copyPostParseDataFromAlternative):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::canProduceCopyWithBytecode):
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::handleBytecodeDiscardingOpportunity):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::BytecodeDestructionBlocker::BytecodeDestructionBlocker):
(JSC::BytecodeDestructionBlocker::~BytecodeDestructionBlocker):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::strictModeFor):

  • dfg/DFGByteCodeCache.h: Added.

(JSC::DFG::CodeBlockKey::CodeBlockKey):
(JSC::DFG::CodeBlockKey::operator==):
(JSC::DFG::CodeBlockKey::hash):
(JSC::DFG::CodeBlockKey::executable):
(JSC::DFG::CodeBlockKey::kind):
(JSC::DFG::CodeBlockKey::isHashTableDeletedValue):
(JSC::DFG::CodeBlockKeyHash::hash):
(JSC::DFG::CodeBlockKeyHash::equal):
(JSC::DFG::ByteCodeCache::ByteCodeCache):
(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionally):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/ListableHandler.h: Added.

(JSC::ListableHandler::ListableHandler):
(JSC::ListableHandler::~ListableHandler):
(JSC::ListableHandler::List::List):
(JSC::ListableHandler::List::addNotThreadSafe):
(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::hasNext):
(JSC::ListableHandler::List::removeNext):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionally):

  • heap/MarkStack.h:

(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):

  • heap/SlotVisitor.h:
  • heap/UnconditionalFinalizer.h: Added.

(JSC::UnconditionalFinalizer::~UnconditionalFinalizer):

  • heap/WeakReferenceHarvester.h:

(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::profiledCodeBlockFor):

13:55 Changeset [99897] by ojan@chromium.org

Add a couple tests that have started hitting asserts on the mac bots.

  • platform/chromium/test_expectations.txt:
13:44 Changeset [99896] by benjamin@webkit.org

Do not share CSS style for MediaElement backed by a plugin
https://bugs.webkit.org/show_bug.cgi?id=72005

Reviewed by Simon Fraser.

With PLUGIN_PROXY_FOR_VIDEO, the RenderMedia elements are rendered through RenderBoxModelObject.
Like the embedded element, the proxied media element can gain a layer outside a change of style.

This patch prevents style sharing for the Audio and Video elements when PLUGIN_PROXY_FOR_VIDEO
is enabled.

This path is covered by exising tests. In particular, http/tests/misc/empty-urls.html
ASSERT() because of this.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):

13:41 Changeset [99895] by barraclough@apple.com

Add ARMv7 register info for the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72050

Reviewed by Geoff Garen.

  • dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

13:34 Changeset [99894] by timothy@apple.com

Make WKViews in NSPopovers render as they would in active windows.

The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WKView
needs to update the active state during order on/off screen notifications.

https://webkit.org/b/68435

Reviewed by John Sullivan.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidOrderOffScreen:]): Call viewStateDidChange with WebPageProxy::ViewWindowIsActive.
(-[WKView _windowDidOrderOnScreen:]): Ditto.

13:31 Changeset [99893] by dino@apple.com

Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Implement an extremely simple version of the filter
chain. Only a single hue-rotate filter is supported
at the moment. The change in this commit was to insert a new
step in RenderLayer's painting to capture the content to an
offscreen ImageBuffer, apply a filter operation on that buffer,
and then draw the result in place of the original element. The full
implementation will need something like the SVGFilterBuilder
but this is a good prototype of effects on HTML content.
It's an open question at the moment as to when the filter
effect should apply: after masking, after overflow, after outline,
etc. Currently the filter applies at the end of the paintLayer code.
This will likely change.

Added a FilterEffectRenderer class that is the root of the filter
tree. At the moment it holds the offscreen context and
the existing paint context.

Other than rendering, the rest of this patch adds tests
to make sure any element with a filter style will become
a RenderLayer. In order to avoid a lot of duplicated code
around the more complex logic tests, RenderStyle::hasFilter
is available outside ENABLE(CSS_FILTERS), but returns false
in those situations.

Tests: css3/filters/add-filter-rendering.html

css3/filters/remove-filter-rendering.html
css3/filters/simple-filter-rendering.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • rendering/FilterEffectRenderer.cpp: Added.

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):

  • rendering/FilterEffectRenderer.h: Added.

(WebCore::FilterEffectRenderer::create):
(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::sourceImageRect):
(WebCore::FilterEffectRenderer::setFilterRegion):
(WebCore::FilterEffectRenderer::filterRegion):
(WebCore::FilterEffectRenderer::effectBoundingBoxMode):
(WebCore::FilterEffectRenderer::setEffect):
(WebCore::FilterEffectRenderer::effect):
(WebCore::FilterEffectRenderer::setSourceGraphic):
(WebCore::FilterEffectRenderer::sourceGraphic):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::styleChanged):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasFilter):

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasFilter):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::requiresLayer):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasFilter):

Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Three new tests that exercise the (simple) filter
implementation.

  • css3/filters/add-filter-rendering-expected.png: Added.
  • css3/filters/add-filter-rendering-expected.txt: Added.
  • css3/filters/add-filter-rendering.html: Added.
  • css3/filters/remove-filter-rendering-expected.png: Added.
  • css3/filters/remove-filter-rendering-expected.txt: Added.
  • css3/filters/remove-filter-rendering.html: Added.
  • css3/filters/simple-filter-rendering-expected.png: Added.
  • css3/filters/simple-filter-rendering-expected.txt: Added.
  • css3/filters/simple-filter-rendering.html: Added.

+

13:08 Changeset [99892] by barraclough@apple.com

#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
https://bugs.webkit.org/show_bug.cgi?id=72047

Reviewed by Geoff Garen.

We currently don't attempt to abstract divide through the macro assembler,
due to these instructions commonly having specific requirements. This means
there is architecture specific code in the JIT - #ifdef it, and provide a
common implementation.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compile):

13:06 Changeset [99891] by andersca@apple.com

Add a simple content layer to TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=72044

Reviewed by Darin Adler.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Add a content layer member variable.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(-[WKContentLayer _initWithWebPage:WebKit::]):
Add initializer.

(-[WKContentLayer drawInContext:]):
Lay out and draw the web page.

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add the content layer as a sublayer of the root layer.

(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Tell the content layer to paint.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the content layer as well.

13:06 Changeset [99890] by andersca@apple.com

The WKView layer hosting subview needs to be flipped
https://bugs.webkit.org/show_bug.cgi?id=72042

Reviewed by Darin Adler.

In order to match the Core Animation layer hierarchy, the layer hosting WKView
subview needs to be flipped.

  • UIProcess/API/mac/WKView.mm:

(-[WKFlippedView isFlipped]):
Add a NSView subview whose sole purpose is to be flipped.

(-[WKView _enterAcceleratedCompositingMode:]):
Create a WKFlippedView instead of a regular NSView.

12:38 Changeset [99889] by barraclough@apple.com

Add ENABLE_VALUE_PROFILER support for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=72043

Reviewed by Geoff Garen.

This requires us to make a bucketCounterRegister available; to do so we'll need to spill more registers on entry to JIT code.

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_mod):

  • cleanup location of UNUSED_PARAM
  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):

  • jit/JITStubs.h:
    • Update JITStackFrame structure & asm code to spill more registers.
  • jit/JSInterfaceJIT.h:
    • Assign a bucketCounterRegister.
12:24 Changeset [99888] by barraclough@apple.com

Fix sampling counters on ARMv7, move add64 functionality to macro assembler
https://bugs.webkit.org/show_bug.cgi?id=72040

Reviewed by Geoff Garen.

The ability to add an integer to a uint64_t in memory is poorly copied in
multiple places & ifdef'ed on architecture, addWithCarry32 is also a badly
designed interface since add32 is not required to set flags (we have no
concept of flags in the macro assembler interface).

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::add64):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add64):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add64):

  • dfg/DFGAssemblyHelpers.cpp:
  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitCount):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::writeBarrier):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitCount):

12:04 Changeset [99887] by scherkus@chromium.org

2011-11-10 Andrew Scherkus <scherkus@chromium.org>

Update expectations for media/video-frame-accurate-seek.html.

It's passing consistently.

  • platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium/test_expectations.txt:
11:51 Changeset [99886] by xji@chromium.org

Source/WebCore: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

Inside textarea, the shadowed text node's previous leaf node could be the
shadowRoot node, which cause assert exception in creating legacy position based
on such node. Exit previousRootInlineBox() when reach shadowRoot node.

It does not cause problem when looking for text node's next leaf node. Adding
the same checking in nextRootInlineBox just to be safe.

Test: editing/selection/move-by-word-visually-crash-test-textarea.html

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

  • editing/selection/move-by-word-visually-crash-test-textarea-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-textarea.html: Added.
11:36 Changeset [99885] by leviw@chromium.org

Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

  • rendering/svg/RenderSVGResourceContainer.h:
11:27 Changeset [99884] by ojan@chromium.org

Add line for very flaky test storage/indexeddb/factory-deletedatabase-interactions.html.

  • platform/chromium/test_expectations.txt:
11:26 Changeset [99883] by dino@apple.com

Parse drop-shadow() filter syntax https://bugs.webkit.org/show_bug.cgi?id=69108

Reviewed by Simon Fraser.

Source/WebCore:

Support parsing of the shadow syntax inside drop-shadow
and returning the correct computed style for a filter that
has such a function.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

Move this from a static function (computedFilter) to a method on
CSSComputedStyleDeclaration, which allows us to call the
existing method for shadow styles.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):

Previously parseShadow expected to be called with the entire
value of a property, not just to look at a restricted subset.
Change parseShadow to take a CSSParserValueList as parameter,
allowing it to be used to parse the arguments to the drop-shadow
function. Also, return the CSSValueList rather than injecting
it directly into the property value.

(WebCore::filterInfoForName):
(WebCore::CSSParser::parseFilter):

Support for the drop-shadow() function.

  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

Updated to use the new arguments for parseShadow.

LayoutTests:

Extend existing tests to exercise parsing of valid
and invalid drop-shadow filters, as well as the computed
style.

  • css3/filters/filter-property-computed-style-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt:
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-computed-style.js:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:
11:22 Changeset [99882] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline Gtk/Win results after r99854.

  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/gtk/svg/custom/text-filter-expected.txt:
  • platform/gtk/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
11:09 Changeset [99881] by scherkus@chromium.org

2011-11-10 Andrew Scherkus <scherkus@chromium.org>

Rebaseline fast/layers/video-layer.html due to r98596.

  • platform/chromium-cg-mac-snowleopard/fast/layers/video-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.png.
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.png: Removed.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt: Removed.
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.txt.
  • platform/chromium/test_expectations.txt:
10:47 Changeset [99880] by ojan@chromium.org

Rebaselines after http://trac.webkit.org/changeset/99854.
The new results were all updated in r99854, but there are sizing differences
on the chromium bots.

  • platform/chromium-cg-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/filters/filter-on-tspan-expected.png.
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/text-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/text-filter-expected.png.
  • platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png.
  • platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filter-on-tspan-expected.png.
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
10:39 Changeset [99879] by adamk@chromium.org

[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
https://bugs.webkit.org/show_bug.cgi?id=71939

Reviewed by Ojan Vafai.

These benchmarks time both the DOM mutations themselves and the time taken
to call the MutationCallback. This measurement is achieved by
executing the code entirely within the MutationCallback itself.

  • Mutation/append-child-deep.html: Added. Covers appendChild in a 200-node-deep tree with subtree observation.
  • Mutation/append-child.html: Added. Covers appendChild in a flat tree.
  • Mutation/inner-html.html: Added. Covers innerHTML adding and removing many nodes at a time.
  • Mutation/remove-child-deep.html: Added. Covers removeChild in a 200-node-deep tree with subtree observation.
  • Mutation/remove-child.html: Added. Covers removeChild in a flat tree.
10:36 Changeset [99878] by vsevik@chromium.org

Web Inspector: ApplicationCache UI is confusing and incorrect.
https://bugs.webkit.org/show_bug.cgi?id=64581

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed resources panel application cache UI.
Manifest urls are now shown under application cache tree element.
Under each manifest url tree element frames using relevant application
cache are listed. Application cache detailed views could be opened for each
frame.

Test: http/tests/inspector/resource-tree/appcache-iframe-manifests.html

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
(WebCore::InspectorApplicationCacheAgent::enable):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
(WebCore::InspectorApplicationCacheAgent::getManifestForFrame):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
(WebInspector.ApplicationCacheModel.prototype._mainFrameNavigated):
(WebInspector.ApplicationCacheModel.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheModel.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheModel.prototype._frameManifestUpdated):
(WebInspector.ApplicationCacheModel.prototype._frameManifestRemoved):
(WebInspector.ApplicationCacheModel.prototype.frameManifestURL):
(WebInspector.ApplicationCacheModel.prototype.frameManifestStatus):
(WebInspector.ApplicationCacheModel.prototype._statusUpdated):
(WebInspector.ApplicationCacheModel.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.frameForId):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype.addDocumentURL):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._populateApplicationCacheTree):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestAdded):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestRemoved):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestStatusChanged):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get frameId):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):

LayoutTests:

  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html: Added.
  • http/tests/inspector/resource-tree/resources/manifest.php: Added.
  • http/tests/inspector/resource-tree/resources/page-with-manifest.php: Added.
10:26 Changeset [99877] by tonyg@chromium.org

Chromium expectations for r99854.

  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
10:23 Changeset [99876] by scherkus@chromium.org

2011-11-10 Andrew Scherkus <scherkus@chromium.org>

Few more rebaselines for media/video-frame-accurate-seek-expected.html.

  • platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png:
10:16 Changeset [99875] by ojan@chromium.org

Fixup expectations for bots that finished cycling after r99760 was committed.

  • platform/chromium/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
  • platform/chromium/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
  • platform/chromium/fast/repaint/scroll-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png.
  • platform/chromium/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
  • platform/chromium/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
  • platform/chromium/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
  • platform/chromium/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.
10:11 Changeset [99874] by tonyg@chromium.org

Chromium expectations for r99862.

  • platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Added.
  • platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Added.
09:46 Changeset [99873] by andreas.kling@nokia.com

Shrink CSSMutableStyleDeclaration.
<http://webkit.org/b/72032>

Reviewed by Antti Koivisto.

Move m_strictParsing and m_iteratorCount (debug only) up into
CSSStyleDeclaration, effectively shaving one CPU word (4/8 bytes)
off of every CSSMutableStyleDeclaration.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:
09:32 Changeset [99872] by kbalazs@webkit.org

[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

.:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

  • Source/api.pri: Link to xlib if necessary.

Source/WebCore:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

No new tests. Existing plugin test are sufficient.

  • Target.pri:
  • bridge/npruntime_internal.h: Added yet another undef

to fix build with Qt5 + X11 headers.

  • plugins/qt/QtX11ImageConversion.cpp: Added.

(WebCore::qimageFromXImage):

  • plugins/qt/QtX11ImageConversion.h: Added.

Added a helper function to create a QImage from an XImage.
Put it in a new file into WebCore to avoid copyright issues - as
the code has been taken directly from Qt - and to be able to resuse
it for the WK1 plugin support in the future.

Source/WebKit2:

  • Target.pri:
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::pluginsDirectories):
Kill the last dependency from the WebKit1 plugin system.
This is necessary because currently we don't build the WebKit1
plugin code. The function is equivalent with the XP_UNIX part of
PluginDatabase::defaultPluginDirectories.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::initializeXEvent):
Rework plugin initialization and drawing model.

Tools:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

  • qmake/mkspecs/features/features.prf: Enable X11

plugins if Qt is built with the xcb-xlib backend.

09:25 Changeset [99871] by andreas.kling@nokia.com

fast/dom/htmlcollection-detectability.html has strange failure output.
<http://webkit.org/b/71946>

Reviewed by Darin Adler.

When a collection should be detectable, but isn't, the test would
say "Failed: document.foo is detectable." It should say that it's
undetectable.

  • fast/dom/htmlcollection-detectability.html:
09:12 Changeset [99870] by vsevik@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
09:09 Changeset [99869] by andreas.kling@nokia.com

Cache and reuse HTMLCollections exposed by Document.
<http://webkit.org/b/71956>

Reviewed by Antti Koivisto.

Source/WebCore:

Let Document cache the various HTMLCollection objects it exposes.
They're created on-demand and stored in a tight Vector.
This is a behavior change, since the lifetime of returned collections
is now tied to the lifetime of the Document. However, this matches the
current behavior of Firefox and Opera.

This reduces memory consumption by ~800 kB (on 64-bit) when loading
the full HTML5 spec. document.links was called 34001 times, yielding
34001 separate HTMLCollections, and now we only need 1.

The document.all collection retains the old behavior, as caching it
would be a bit more complicated.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::collection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):

  • dom/Document.h:
  • html/CollectionType.h:

LayoutTests:

Update fast/dom/gc-9.html to document the new lifetime behavior of
HTMLCollection objects returned by document.

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
09:07 Changeset [99868] by tonyg@chromium.org

Chromium layout test rebaseline.

  • platform/chromium-win/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png.
09:07 Changeset [99867] by apavlov@chromium.org

Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix.
https://bugs.webkit.org/show_bug.cgi?id=72022

Reviewed by Pavel Feldman.

On any suggest box position update (updateSuggestions invocation) an anchor is created at the beginning
of the user-entered word, and its box is ultimately passed into _updateBoxPosition to be used as the
actual anchor box (instead of the input element box).

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._boxForAnchorAtStart):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

  • inspector/front-end/utilities.js:

(AnchorBox):
(Element.prototype.offsetRelativeToWindow):

09:05 Changeset [99866] by ryuan.choi@samsung.com

[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
https://bugs.webkit.org/show_bug.cgi?id=56705

Reviewed by Adam Roben.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • PlatformEfl.cmake: Renamed from Source/JavaScriptCore/CMakeListsEfl.txt.
  • PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/CMakeListsWinCE.txt.
  • shell/CMakeLists.txt:
  • shell/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsEfl.txt.
  • shell/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsWinCE.txt.
  • wtf/CMakeLists.txt:
  • wtf/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsEfl.txt.
  • wtf/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsWinCE.txt.

Source/WebCore:

No new tests, just renaming CMakeLists*.txt to Platform*.cmake.

  • CMakeLists.txt:
  • PlatformEfl.cmake: Renamed from Source/WebCore/CMakeListsEfl.txt.
  • PlatformWinCE.cmake: Renamed from Source/WebCore/CMakeListsWinCE.txt.
09:03 Changeset [99865] by commit-queue@webkit.org

[Chromium] Fix CCLayerTreeHostImplTest::scrollRootCallsCommitAndRedraw
https://bugs.webkit.org/show_bug.cgi?id=72027

We weren't calling setScrollable(true) when setting up the test, so
scroll events were being ignored. Test failed in debug builds, but passed
in release because we were using ASSERT instead of ASSERT_TRUE.

Patch by Iain Merrick <husky@google.com> on 2011-11-10
Reviewed by Tony Gentilcore.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

08:49 Changeset [99864] by caseq@chromium.org

Web Inspector: wrong JSON.stringify used in webInspector.inspectedWindow.eval() backend
https://bugs.webkit.org/show_bug.cgi?id=63083

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.InspectedWindow.prototype.eval):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

LayoutTests:

  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/extensions/extensions-eval.html:
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
08:47 Changeset [99863] by commit-queue@webkit.org

[GTK] [WebKit2] Fix remaining gtkdoc errors
https://bugs.webkit.org/show_bug.cgi?id=71990

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitWebView.cpp: Update add the phrase "property" to

references to properties, because the gtkdoc stylesheet does not differeniate
between properties and signals. Standardize the way we talk about property
notifications.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add an include to silence

warnings about GIR annotations.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the decorators the private section.
08:47 Changeset [99862] by commit-queue@webkit.org

SVG object covers CSS background in HTML foreignObject
https://bugs.webkit.org/show_bug.cgi?id=58417

Patch by Florin Malita <fmalita@google.com> on 2011-11-10
Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/foreignObject/background-render-phase.html

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

Paint SVG foreign objects atomically, following the same pattern as
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/InlineBox.cpp#L209.

LayoutTests:

  • svg/foreignObject/background-render-phase-expected.png: Added.
  • svg/foreignObject/background-render-phase-expected.txt: Added.
  • svg/foreignObject/background-render-phase.html: Added.
08:31 Changeset [99861] by commit-queue@webkit.org

Unreviewed, rolling out r99851.
http://trac.webkit.org/changeset/99851
https://bugs.webkit.org/show_bug.cgi?id=72029

Patch breaks Qt tests (Requested by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::clearUseElements):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance):

LayoutTests:

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Removed.
  • svg/custom/element-instance-held-by-js-crash.svg: Removed.
08:27 Changeset [99860] by kenneth@webkit.org

[Qt] Clean up how singe / double taps are handled
https://bugs.webkit.org/show_bug.cgi?id=72024

Reviewed by Simon Hausmann.

Move all decision making to the QtWebPageProxy.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleSingleTapEvent):
(QtWebPageProxy::handleDoubleTapEvent):

  • UIProcess/qt/QtWebPageProxy.h:
08:15 Changeset [99859] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline one test on Mac, to turn SL bots green again.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
08:09 Changeset [99858] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline Qt results after r99854.

  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/custom/text-filter-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
08:03 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Add links for the QtWebKit2.2 productization branch buildbots (diff)
07:58 Changeset [99857] by pfeldman@chromium.org

Not reviewed: fixed new inspector media-query CSS test on Qt.

  • inspector/styles/media-queries.html:
07:42 Changeset [99856] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

[GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
https://bugs.webkit.org/show_bug.cgi?id=71932

Reviewed by Philippe Normand.

  • platform/gtk/Skipped: Unskip test.

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

[GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
https://bugs.webkit.org/show_bug.cgi?id=71932

Reviewed by Philippe Normand.

Null check m_page in drawSVGToImageBuffer(), just like all others methods do.
As drawSVGToImageBuffer() is fired from a timer, it may get into this state under certain conditions, as seen on the 64bit gtk bot.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::drawSVGToImageBuffer):
07:40 Changeset [99855] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rolling out part of r99854, which didn't belong there.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::drawSVGToImageBuffer):
07:33 Changeset [99854] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Move unit resolving for all resources to rendering/
https://bugs.webkit.org/show_bug.cgi?id=72011

Reviewed by Andreas Kling.

Update expected results for some filters tests, now that their bounding box is correctly dumped.

  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Move unit resolving for all resources to rendering/
https://bugs.webkit.org/show_bug.cgi?id=72011

Reviewed by Andreas Kling.

Remove maskBoundingBox()/filterBoundingBox(), to avoid doing length resolution in svg/.
RenderSVGResource* now uses SVGLengthContext::resolveRectangle, to do this while laying out.

Move linear gradient start/end point, radial gradient focal/center point, radius calculations into
their RenderSVGResource classes, cleanup code a bit.

Convert filters to use SVGLengthContext. Fix DRT dumps for filters, while I'm at it, to give
meaningful values, when objectBoundingBox is used as primitive units, when applying to <text>/<tspan>s.

Several tests results need rebaselines on all platforms.

  • platform/graphics/filters/Filter.h:
  • rendering/svg/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::objectBoundingBox):
  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::startPoint): (WebCore::RenderSVGResourceLinearGradient::endPoint): (WebCore::RenderSVGResourceLinearGradient::buildGradient):
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::centerPoint): (WebCore::RenderSVGResourceRadialGradient::focalPoint): (WebCore::RenderSVGResourceRadialGradient::radius): (WebCore::RenderSVGResourceRadialGradient::adjustFocalPointIfNeeded): (WebCore::RenderSVGResourceRadialGradient::buildGradient):
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer):
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGLinearGradientElement.cpp:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h:
  • svg/SVGRadialGradientElement.cpp:
  • svg/SVGRadialGradientElement.h:
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::filterRegionInUserSpace):
07:32 Changeset [99853] by hausmann@webkit.org

[Qt] Fix keyboard related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Send key events to the handling page item, not the view.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):

07:23 Changeset [99852] by commit-queue@webkit.org

[GTK] Make the ENABLE(FEATURE) macro work in DRT
https://bugs.webkit.org/show_bug.cgi?id=71940

Patch by Alexandre Mazari <amazari@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

  • GNUmakefile.am:

Add webcore_cppflags to Programs_DumpRenderTree_CPP so
ENABLE_* variables are part of the environment.

07:23 Changeset [99851] by commit-queue@webkit.org

Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Source/WebCore:

Cleans up the object when it is detached from the shadow DOM tree,
rather than leaving it in a half-clean state with some nulled
references but not others.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

Test: svg/custom/element-instance-held-by-js-crash.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance): Added a call to
detach to clean up if deletion happens without a prior detach call (as
when an entire tree is removed).
(WebCore::SVGElementInstance::detach): New method that replaces other
clean-up methods when the instance is removed from the shadow DOM.

  • svg/SVGElementInstance.h: Added new detach method and removed

unnecessary clear methods.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance): Changed calls to clear to
instead detach.

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
  • svg/custom/element-instance-held-by-js-crash.svg: Added.
07:14 WebKit Team edited by andreas.kling@nokia.com
(diff)
07:12 Changeset [99850] by hausmann@webkit.org

[Qt] Fix focus related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Make sure the focus is set on the page now, not on the view
(which doesn't actually handle the focus).

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

06:56 Changeset [99849] by apavlov@chromium.org

Web Inspector: Show media queries associated with specific CSS rules
https://bugs.webkit.org/show_bug.cgi?id=65626

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/media-queries.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::updateLastMediaLine):

  • css/CSSParser.h:
  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):

  • css/MediaList.h:

(WebCore::MediaList::lastLine):
(WebCore::MediaList::setLastLine):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::documentURLString):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::buildObjectForRule):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule):
(WebInspector.CSSMedia):
(WebInspector.CSSMedia.parsePayload):
(WebInspector.CSSMedia.parseMediaArrayPayload):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyResourceAsNode):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):

  • inspector/front-end/elementsPanel.css:

(.styles-section .header .title .media, .styles-section .header .title .media .subtitle):
(.styles-section .header .subtitle):

LayoutTests:

  • inspector/styles/media-queries-expected.txt: Added.
  • inspector/styles/media-queries.html: Added.
  • inspector/styles/resources/media-queries-1.css: Added.

(body):
(#main):

  • inspector/styles/resources/media-queries.css: Added.

(#main):

  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-source-lines-expected.txt:
06:52 Changeset [99848] by apavlov@chromium.org

Web Inspector: [SuggestBox] Do not display suggest box if editing in the middle of prompt unless a stop character follows
https://bugs.webkit.org/show_bug.cgi?id=72018

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

06:49 Changeset [99847] by pfeldman@chromium.org

Web Inspector: do not highlight files larger than 10KLOC.
https://bugs.webkit.org/show_bug.cgi?id=72025

This is a temporary measure while I am improving the highlighter
footprint. Otherwise, highlighting pretty printed Gmail takes ~1.3G of RAM.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._didRequestContent):

06:32 Changeset [99846] by hausmann@webkit.org

[Qt] Clean up build system

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate use of WebKit2.pri.

Source/WebKit2:

Now that we use whole-archive linking we can fold the files that contain exported
symbols back into the WebKit2 static library.

  • Target.pri: Fold in sources from WebKit2.pri.
  • WebKit2.pri: Removed.
06:09 Changeset [99845] by alexis.menard@openbossa.org

[Qt] Merge QTouchWebView and QDesktopWebView into one class
https://bugs.webkit.org/show_bug.cgi?id=71355

Reviewed by Kenneth Rohde Christiansen.

.:

Remove old tests and merge them into the new QQuickWebView directory.

  • Source/tests.pri:

Source/WebKit/qt:

Register only QQuickWebView and QQuickWebPage in the plugin.

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Merge QTouchWebView and QDesktopWebView into one class called
QQuickWebView and its attached page QQuickWebPage. You can switch to the
traditional desktop use case with the private header. Also now on desktop
platforms AC is turn on by default. I also merged our two
subclasses of QtViewInterface into one as the split doesn't make
that much sense anymore. In the future we want to be able to enable the
traditional desktop use case depending the platform the code is running.
API tests and QML tests have been updated.

  • Target.pri:
  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qbasewebview.cpp: Removed.
  • UIProcess/API/qt/qbasewebview_p.h: Removed.
  • UIProcess/API/qt/qdesktopwebview.cpp: Removed.
  • UIProcess/API/qt/qdesktopwebview.h: Removed.
  • UIProcess/API/qt/qdesktopwebview_p.h: Removed.
  • UIProcess/API/qt/qquickwebpage.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp.

(QQuickWebPage::QQuickWebPage):
(QQuickWebPage::~QQuickWebPage):
(QQuickWebPage::keyPressEvent):
(QQuickWebPage::keyReleaseEvent):
(QQuickWebPage::inputMethodEvent):
(QQuickWebPage::focusInEvent):
(QQuickWebPage::focusOutEvent):
(QQuickWebPage::mousePressEvent):
(QQuickWebPage::mouseMoveEvent):
(QQuickWebPage::mouseReleaseEvent):
(QQuickWebPage::mouseDoubleClickEvent):
(QQuickWebPage::wheelEvent):
(QQuickWebPage::hoverEnterEvent):
(QQuickWebPage::hoverMoveEvent):
(QQuickWebPage::hoverLeaveEvent):
(QQuickWebPage::dragMoveEvent):
(QQuickWebPage::dragEnterEvent):
(QQuickWebPage::dragLeaveEvent):
(QQuickWebPage::dropEvent):
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPage::touchEvent):
(QQuickWebPage::itemChange):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::initializeSceneGraphConnections):
(QQuickWebPagePrivate::setPageProxy):
(computeEffectiveOpacity):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPagePrivate::_q_onAfterSceneRender):
(QQuickWebPagePrivate::_q_onSceneGraphInitialized):

  • UIProcess/API/qt/qquickwebpage.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
  • UIProcess/API/qt/qquickwebpage_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
  • UIProcess/API/qt/qquickwebview.cpp: Added.

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::contentSizeChanged):
(QQuickWebViewPrivate::scrollPositionRequested):
(QQuickWebViewPrivate::_q_viewportUpdated):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::_q_onVisibleChanged):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::updateViewportConstraints):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewPrivate::_q_onOpenPanelFilesSelected):
(QQuickWebViewPrivate::_q_onOpenPanelFinished):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(toPolicyAction):
(hasMetaMethod):
(QQuickWebViewPrivate::navigationPolicyForURL):
(QQuickWebViewPrivate::setPageProxy):
(QQuickWebView::QQuickWebView):
(QQuickWebView::~QQuickWebView):
(QQuickWebView::page):
(QQuickWebView::load):
(QQuickWebView::postMessage):
(QQuickWebView::url):
(QQuickWebView::loadProgress):
(QQuickWebView::title):
(QQuickWebView::navigationController):
(QQuickWebView::preferences):
(QQuickWebView::geometryChanged):
(QQuickWebView::touchEvent):
(QQuickWebView::pageRef):

  • UIProcess/API/qt/qquickwebview.h: Renamed from Source/WebKit2/UIProcess/API/qt/qbasewebview.h.
  • UIProcess/API/qt/qquickwebview_p.h: Added.
  • UIProcess/API/qt/qtouchwebview.cpp: Removed.
  • UIProcess/API/qt/qtouchwebview.h: Removed.
  • UIProcess/API/qt/qtouchwebview_p.h: Removed.
  • UIProcess/API/qt/tests/commonviewtests/commonviewtests.pro: Removed.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp: Removed.
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: Removed.
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h: Removed.
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(DesktopWebView::DesktopWebView):
(main):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/qdesktopwebview.pro.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Added.

(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::cleanup):
(tst_QQuickWebView::webView):
(tst_QQuickWebView::accessPage):
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::baseUrl):
(tst_QQuickWebView::loadEmptyUrl):
(tst_QQuickWebView::loadEmptyPageViewVisible):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::show):

  • UIProcess/API/qt/tests/qtouchwebview/qtouchwebview.pro: Removed.
  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: Removed.
  • UIProcess/API/qt/tests/testwindow.h:
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):
(WebKit::QtGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::setViewportInteractionEngine):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):
(WebKit::QtPinchGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTouchViewInterface.cpp: Removed.
  • UIProcess/qt/QtTouchViewInterface.h: Removed.
  • UIProcess/qt/QtViewInterface.cpp: Added.

(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::didFindZoomableArea):
(WebKit::QtViewInterface::sceneGraphUpdateQueue):
(WebKit::QtViewInterface::setViewNeedsDisplay):
(WebKit::QtViewInterface::drawingAreaSize):
(WebKit::QtViewInterface::contentSizeChanged):
(WebKit::QtViewInterface::scrollPositionRequested):
(WebKit::QtViewInterface::isActive):
(WebKit::QtViewInterface::hasFocus):
(WebKit::QtViewInterface::isVisible):
(WebKit::QtViewInterface::startDrag):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::didChangeUrl):
(WebKit::QtViewInterface::didChangeTitle):
(WebKit::QtViewInterface::didChangeToolTip):
(WebKit::QtViewInterface::didChangeStatusText):
(WebKit::QtViewInterface::didChangeCursor):
(WebKit::QtViewInterface::loadDidBegin):
(WebKit::QtViewInterface::loadDidCommit):
(WebKit::QtViewInterface::loadDidSucceed):
(WebKit::QtViewInterface::loadDidFail):
(WebKit::QtViewInterface::didChangeLoadProgress):
(WebKit::QtViewInterface::didMouseMoveOverElement):
(WebKit::QtViewInterface::showContextMenu):
(WebKit::QtViewInterface::hideContextMenu):
(WebKit::QtViewInterface::runJavaScriptAlert):
(WebKit::QtViewInterface::runJavaScriptConfirm):
(WebKit::QtViewInterface::runJavaScriptPrompt):
(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):
(WebKit::QtViewInterface::engine):
(WebKit::QtViewInterface::downloadRequested):
(WebKit::QtViewInterface::chooseFiles):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::setViewportInteractionEngine):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
  • WebKit2.pri:

Tools:

Make MiniBrowser and WebKitTestRunner work again after the
merge.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:
  • MiniBrowser/qt/main.cpp:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/DesktopView.qml: Removed.
  • MiniBrowser/qt/qml/TouchView.qml: Removed.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

06:08 Changeset [99844] by hclam@chromium.org

[chromium] Scroll deltas are cleared during commit to the main thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

The patch keeps the scroll deltas and scroll position unchanged when
committing to the main thread. After commit has completed on the main
thread the submitted scroll deltas are then subtracted from the current
scroll deltas on the impl thread.

Doing so allow scroll deltas to be available at all time which enables
proper positioning for layers that are fixed-positioned to the
container layer.

This patch is tested by the following unit tests:

  • CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls This test is modified to verify that scroll deltas and scroll position are unchanged during commit. And then after commit scroll deltas are subtracted correctly.
  • CCLayerTreeHostTestScrollSimple.runMultiThread and CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread These tests verifies that scroll deltas made on impl thread are committed to the main thread. The scroll deltas is eventually delegated to CCLayerTreeHostClient. When commit has completed the scroll deltas are subtracted correctly. There's no change to these two tests but they verify this patch maintains the overall behavior of scrolling.
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::applyScrollAndScale):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::applyScrollAndScaleInternal):
(WebCore::CCLayerTreeHostCommon::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls
This test is modified to verify that CCLayerTreeHostImpl::processScrollDeltas()
maintain the current scroll deltas and scroll positions.
It also verifies that scroll deltas are subtracted correctly by calling
CCLayerTreeHostCommon::applyScrollAndScale().

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
call setLayerTreeHost() on the root layer.

05:59 Changeset [99843] by vestbo@webkit.org

[Qt] Change semantics of the haveQt() function to match API promises

Having Qt 5 does not imply that we have Qt 4, from an API point of
view, as a major version can in theory break BC/SC. Our minimum
version of Qt 4 will always be the latest released version of Qt 4,
so the only place we should use haveQt(4, x) is when checking for
the minimum requirements.

Reviewed-by Simon Hausmann.

05:59 Changeset [99842] by carlosgc@webkit.org

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.am: Add missing files.
  • GNUmakefile.list.am: Ditto.

Source/WebKit2:

  • GNUmakefile.am: Fix typos in gtk-doc files and scripts.
05:26 Changeset [99841] by ossy@webkit.org

[Qt] Unreviewed trivial fix after r99721.

  • platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt.
04:57 Changeset [99840] by tonyg@chromium.org

Correct editing/spelling/markers.html expecations
https://bugs.webkit.org/show_bug.cgi?id=72015

This test was added in http://trac.webkit.org/changeset/99814 with no expectations so
it needs to be marked MISSING instead of FAIL.

  • platform/chromium/test_expectations.txt:
04:38 Changeset [99839] by sergio@webkit.org

[WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=69411

Reviewed by Martin Robinson.

Tools:

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
use the EventSender instead of WebProcess Event Simulation.

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::WTREventQueueItem::WTREventQueueItem):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButtonModifiers):
(WTR::eventSenderButtonToGDKButton):
(WTR::EventSenderProxy::createMouseButtonEvent):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::webkitModifiersToGDKModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Unskip tests that were previously failing due to the lack of
MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward. Also
moved around some other tests to their proper section.

  • platform/gtk-wk2/Skipped:
04:26 Changeset [99838] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Deploy SVGLengthContext in more places
https://bugs.webkit.org/show_bug.cgi?id=72012

Reviewed by Simon Hausmann.

Doesn't affect any tests.

  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
  • svg/SVGAnimatedLengthList.cpp: (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
04:23 Changeset [99837] by hausmann@webkit.org

Unreviewed Mac build fix: Remove TapAndHold gesture type.

It broke the build because it's unhandled. Remove it since it's not
supported at the moment anyway. (looks like an accidental addition?)

  • Shared/WebEvent.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):

04:02 WebKit Team edited by zeno.albisser@nokia.com
(diff)
03:43 Changeset [99836] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix build.

  • WebCore.gypi: Need to add rendering/svg/SVGPathData.* in another place as well, cr-bots are not compiling it and thus fail linking.
03:42 Changeset [99835] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 6)

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/embedding-external-svgs-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/embedding-external-svgs-expected.png.
  • platform/chromium/test_expectations.txt:
03:41 Changeset [99834] by hausmann@webkit.org

Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf: Use --whole-archive and their

mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

03:17 Changeset [99833] by zimmermann@webkit.org

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Remove virtual toPathData() method from all graphics elements
https://bugs.webkit.org/show_bug.cgi?id=72009

Reviewed by Zoltan Herczeg.

In bug 71780, SVGLengthContext was introduced, to allow to resolve SVGLengths against arbitary viewports.
SVGLength::value(), which needs a SVGLengthContext, is still used all over svg/ - that should be changed, as rendering/
should resolve these lengths, as HTML does it using Length & RenderStyles for CSS.

As first step, move the #1 client of the SVGLength::value() methods - toPathData() out of svg/ into rendering/svg/SVGPathData
as free-function, replacing the virtual toPathData() function from SVGStyledTransformableElement.

Doesn't affect any tests.

  • CMakeLists.txt: Add rendering/svg/SVGPathData.* to build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/svg/RenderSVGAllInOne.cpp: Ditto.
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout): Use "updatePathFromGraphicsElement(element, m_path)" instead of "element->toPathData(m_path)", avoiding a virtual call.
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath): Ditto.
  • rendering/svg/SVGPathData.cpp: Added. (WebCore::updatePathFromCircleElement): (WebCore::updatePathFromEllipseElement): (WebCore::updatePathFromLineElement): (WebCore::updatePathFromPathElement): (WebCore::updatePathFromPolygonElement): (WebCore::updatePathFromPolylineElement): (WebCore::updatePathFromRectElement): (WebCore::updatePathFromGraphicsElement):
  • rendering/svg/SVGPathData.h: Added.
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath): Use updatePathFromGraphicsElement instead of toPathData.
  • svg/SVGCircleElement.cpp: Remove toPathData() virtual method.
  • svg/SVGCircleElement.h: Ditto.
  • svg/SVGEllipseElement.cpp: Ditto.
  • svg/SVGEllipseElement.h: Ditto.
  • svg/SVGLineElement.cpp: Ditto.
  • svg/SVGLineElement.h: Ditto.
  • svg/SVGPathElement.cpp: Ditto.
  • svg/SVGPathElement.h: Ditto.
  • svg/SVGPolygonElement.cpp: Ditto.
  • svg/SVGPolygonElement.h: Ditto.
  • svg/SVGPolylineElement.cpp: Ditto.
  • svg/SVGPolylineElement.h: Ditto.
  • svg/SVGRectElement.cpp: Ditto.
  • svg/SVGRectElement.h: Ditto.
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::toClipPath): Use updatePathFromGraphicsElement instead of toPathData.
  • svg/SVGStyledTransformableElement.h: Remove toPathData() virtual method.
03:11 Changeset [99832] by vestbo@webkit.org

[Qt] Make sure headers.pri has the right relative paths for install

The install rules are generated from api.pri which lives in Source,
which means the paths in headers.pri, which is the basis for the
install rules, needs to be relative to Source as well.

We were also installing the headers from the forwarding headers
directory, which was wrong, as those headers contained relative paths.

We now install the actual headers, by using headers.pri as a basis.

https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

02:46 Changeset [99831] by zeno.albisser@nokia.com

[Qt][WK2] Add Tap Gesture recognition to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=71841

Add a Tap gesture recognizer that delivers GestureSingleTap
and GestureTapAndHold events through the WebPageProxy.
Add a GestureTapAndHold to WebEvent.
Add a DoubleTap gesture for zooming in and out.

This patch is based on work of Benjamin Poulain.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-10
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:
  • Target.pri:
  • UIProcess/qt/QtTapGestureRecognizer.cpp: Added.

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::setWebPageProxy):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):

  • UIProcess/qt/QtTapGestureRecognizer.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageProxy.h:
02:41 Changeset [99830] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 5)

  • platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/animated-svg-as-mask-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/animated-svg-as-background-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium/test_expectations.txt:
02:09 Changeset [99829] by caseq@chromium.org

Web Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71922

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.activateBreakpoints):
(WebInspector.ScriptsPanel.prototype.folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.addToWatch):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

02:03 Changeset [99828] by zherczeg@webkit.org

Unreviewed gardening.

  • fast/harness/results-expected.txt: Update after r99818.
01:46 Changeset [99827] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 4)

  • platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/svg-as-mask-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
01:39 Changeset [99826] by jcivelli@chromium.org

Fix progress load reporting for MHTML documents.

MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859

Reviewed by Adam Barth.

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):

  • tests/data/page_with_image.mht: Added.
01:37 Changeset [99825] by hausmann@webkit.org

[Qt] Fix linking with --whole-archive

Reviewed by Zoltan Herczeg.

Compile XMLTreeViewer and related files when XSLT is enabled, not
when XSLT _and_ USE_LIBXML2. The files do not depend on libxml2, they
are #ifdeffed with ENABLE(XSLT) only, and they are referenced from for
example NewXMLDocumentParser.cpp from within XSLT blocks.

  • DerivedSources.pri:
  • Target.pri:
01:22 Changeset [99824] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 3)

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/chromium-cg-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
01:19 Changeset [99823] by podivilov@chromium.org

Web Inspector: load source maps via front-end host.
https://bugs.webkit.org/show_bug.cgi?id=71301

Reviewed by Yury Semikhatsky.

Source/WebCore:

Currently we use an auxiliary iframe hack to load source map files from inspector page. This approach has several drawbacks:

  • in addition to source map url we need to know auxiliary iframe url
  • we need a protocol to communicate with iframe
  • source map provider needs to provide auxiliary document to make our hack work

Loading source maps from front-end host solves all problems.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::loadResourceSynchronously):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.load):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappingPayload):

  • inspector/front-end/CompilerSourceMappingProvider.js: Removed.
  • inspector/front-end/ContentProviders.js:

(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype.setCompilerSourceMapping):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.installSourceMappingForTest):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-provider-expected.txt: Removed.
  • http/tests/inspector/compiler-source-mapping-provider.html: Removed.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Removed.
  • http/tests/inspector/resources/source-map.json: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.
  • http/tests/inspector/resources/source1.js: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app.js.

(window.onload):
(handleClick):

  • http/tests/inspector/resources/source2.js: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/foo.js.

(ClickHandler):
(ClickHandler.prototype.handle):

  • inspector/debugger/compiler-source-mapping.html: Removed.
00:28 Changeset [99822] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 2)

  • platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium/test_expectations.txt:
00:17 Changeset [99821] by loislo@chromium.org

Unreviewed, rolling out r99816.
http://trac.webkit.org/changeset/99816
https://bugs.webkit.org/show_bug.cgi?id=72003

compilation failed on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):

  • html/HTMLTextAreaElement.idl:
  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:
  • html/TextFieldInputType.h:

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Removed.
  • fast/forms/form-dirname-attribute.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute.html: Removed.
00:08 Changeset [99820] by yutak@chromium.org

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 1)

  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium/test_expectations.txt:

11/09/11:

23:59 Changeset [99819] by pfeldman@chromium.org

Web Inspector: console does not work after switching panel while editing.
https://bugs.webkit.org/show_bug.cgi?id=71918

Reviewed by Yury Semikhatsky.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):

23:39 Changeset [99818] by hayato@chromium.org

[NRWT] Make results.html aware of reference filename in reftests.
https://bugs.webkit.org/show_bug.cgi?id=71574

Reviewed by Ryosuke Niwa.

If a reference filename is different from the default one, include that in result summary
so results.html can link to the correct reference file.

Tools:

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

LayoutTests:

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
  • platform/chromium/fast/harness/results-expected.txt:
23:12 Changeset [99817] by scherkus@chromium.org

2011-11-09 Andrew Scherkus <scherkus@chromium.org>

Rebaselining media/video-frame-accurate-seek-expected.html now that it passes consistently.

  • platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-linux/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png: Added.
22:50 Changeset [99816] by commit-queue@webkit.org

Need support for dirname attribute
https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html

fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
fast/forms/submit-form-with-dirname-attribute.html

  • html/HTMLAttributeNames.in:

Added "dirname" attribute.

  • html/HTMLInputElement.idl:

Add "dirName" property to HTMLInputElement interface.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.

  • html/HTMLTextAreaElement.idl:

Add "dirName" property to HTMLTextAreaElement interface.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.

  • html/HTMLTextFormControlElement.h:

Helper function for finding directionality of the Element.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.

  • html/TextFieldInputType.h:

Append dirname form data.

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Added.
  • fast/forms/form-dirname-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
  • fast/forms/submit-form-with-dirname-attribute.html: Added.
22:28 Changeset [99815] by scherkus@chromium.org

2011-11-09 Andrew Scherkus <scherkus@chromium.org>

chromium-gpu-linux media rebaselines due to r98596.

  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-empty-source-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
22:10 Changeset [99814] by commit-queue@webkit.org

Internals.markerRangeForNode should be able to take markers by specifying a marker type.
https://bugs.webkit.org/show_bug.cgi?id=71792

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-09
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

Test: editing/spelling/markers.html

  • WebCore.exp.in:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markersFor):

Takes marker types to get only necessary markers.

  • dom/DocumentMarkerController.h:
  • testing/Internals.cpp:

(WebCore::markerTypesFrom): Added.
(WebCore::Internals::markerCountForNode):

Takes marker types to get only necessary markers.

(WebCore::Internals::markerRangeForNode): ditto.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def: Exposed necessary references.
  • win/WebKit2CFLite.def: ditto.

LayoutTests:

  • editing/spelling/markers.html: Added.
  • editing/spelling/spelling-insert-html.html: Fixed function usage.
  • platform/chromium/test_expectations.txt: Skipped chromium test.
  • platform/gtk/Skipped: Skipped gtk test.
  • platform/qt/Skipped: Skipped qt test.
  • platform/win/Skipped: Skeipped win test.
21:45 Changeset [99813] by commit-queue@webkit.org

[Chromium] Add support for painting into an SkPicture and then rasterizing into tile-sized chunks.
https://bugs.webkit.org/show_bug.cgi?id=71388

Patch by David Reveman <reveman@chromium.org> on 2011-11-09
Reviewed by James Robinson.

Add UpdatableTexture class, which allows texture updater to
allocate tile specific resources and paint tiles separately.
Rename texture uploader classes and move them to separate files.

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Added.

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::create):
(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::~BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp.

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::create):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::~FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::Texture):
(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::Texture::textureUpdater):
(WebCore::ImageLayerTextureUpdater::createTexture):
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::Texture::~Texture):
(WebCore::LayerTextureUpdater::Texture::texture):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::Texture::Texture):
(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore::SkPictureCanvasLayerTextureUpdater::SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::~SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::SkPictureCanvasLayerTextureUpdater::drawPicture):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::managedTexture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
20:49 Changeset [99812] by msaboff@apple.com

Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type
https://bugs.webkit.org/show_bug.cgi?id=71862

Changed LiteralParser to be templatized of character type.

Moved five enums out of class definition to work around a clang compiler defect.

Added lexIdentifier templated method to break out character specific versions.
Added static setParserTokenString templated method to handle setting approriately
sized string pointer.

To keep code in LiteralParser.cpp and keep LiteralParser.h small, the two
flavors of LiteralParser are explicitly instantiated at the end of
LiteralParser.cpp.

Reviewed by Oliver Hunt.

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::isJSONWhiteSpace):
(JSC::::tryJSONPParse):
(JSC::::makeIdentifier):
(JSC::::Lexer::lex):
(JSC::::Lexer::lexIdentifier):
(JSC::::Lexer::next):
(JSC::LChar):
(JSC::UChar):
(JSC::isSafeStringCharacter):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
(JSC::LiteralParser::Lexer::currentToken):
(JSC::LiteralParser::Lexer::getErrorMessage):

  • runtime/UString.h:

(JSC::LChar):
(JSC::UChar):

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::append):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):

20:40 Changeset [99811] by kevino@webkit.org

[wx] Unreviewed build fix. Update project files and add LTC stubs for new methods.

20:37 Changeset [99810] by fpizlo@apple.com

Multiple CodeBlock should be able to share the same instruction
stream without copying
https://bugs.webkit.org/show_bug.cgi?id=71978

Reviewed by Oliver Hunt.

This refactors CodeBlock::m_instructions to be a Vector boxed in a
ref-counted object, but otherwise does not take advantage of this.

This is performance neutral.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasInstructions):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):

  • jit/JIT.cpp:

(JSC::JIT::JIT):

20:35 Changeset [99809] by kevino@webkit.org

[wx] Unreviewed build fix. Add stub for new method.

20:33 Changeset [99808] by kevino@webkit.org

[wx] Unreviewed build fix. wx should not be excluded from building ScopedFramePaintingState code.

20:28 Changeset [99807] by kevino@webkit.org

[wx] Unreviewed build fix. Don't run fontDataForCombiningCharacterSequence on wx as we don't support it yet.

20:21 Changeset [99806] by kevino@webkit.org

[wx] Unreviewed build fix. Update how we hash the font after changes to the StringHasher APIs.

20:17 Changeset [99805] by kevino@webkit.org

[wx] Unreviewed build fix. Support XCode 4 when building deps.

20:13 Changeset [99804] by kevino@webkit.org

[wx] Unreviewed build fix. Remove from WebDOMEventTarget bindings methods that have been removed from EventTarget.

19:10 Changeset [99803] by mrobinson@webkit.org

[Cairo] Avoid clipping when painting more often
https://bugs.webkit.org/show_bug.cgi?id=71179

Reviewed by Xan Lopez.

No new tests. These changes are covered by existing tests.

  • platform/graphics/Gradient.h: Add a Cairo-specific method

that gets the platform gradient with a particular alpha value.

  • platform/graphics/cairo/GradientCairo.cpp: Now cache the alpha

value of the last created platform gradient.
(WebCore::Gradient::platformGradient): If the cached platform gradient
has a different alpha value than the one requested, destroy it and start
over.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::drawPathShadow): Adjust the source to avoid calling
cairo_clip/cairo_paint_with_alpha and just do a fill.
(WebCore::shadowAndFillCurrentCairoPath): No need to clip here. Just
call cairo_fill.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::drawPatternToCairoContext): If we have a >= 1 alpha value
we can simply fill and avoid calling cairo_clip here.
(WebCore::prepareCairoContextSource): Remove TODO about recreating the
gradient. No longer need to reduce the gradient source.

19:00 Changeset [99802] by mrobinson@webkit.org

[GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible
https://bugs.webkit.org/show_bug.cgi?id=70877

Reviewed by Philippe Normand.

Add a script that runs gtkdoc manually instead of using the autotools
magic. Remove now unused gtkdoc files.

  • GNUmakefile.am: Remove references to removed gtkdoc files.
  • UIProcess/API/gtk/docs/GNUmakefile.am: Removed.
  • UIProcess/API/gtk/docs/build-gtkdoc: Added.
  • UIProcess/API/gtk/docs/gtkdoc.py: Added.
  • UIProcess/API/gtk/docs/version.xml.in: Removed.
18:56 Changeset [99801] by scherkus@chromium.org

2011-11-09 Andrew Scherkus <scherkus@chromium.org>

More media rebaselines due to r98596.

  • media/controls-without-preload-expected.txt: Removed.
  • platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
  • platform/mac/media/controls-strict-expected.txt: Removed.
  • platform/win-wk2/media/controls-without-preload-expected.txt: Removed.
  • platform/win-xp/media/controls-without-preload-expected.txt: Removed.
  • platform/win/media/controls-without-preload-expected.txt:
18:48 Changeset [99800] by ap@apple.com

<rdar://problem/10423024> WebProcess doesn't use AuthBrokerAgent for proxy credentials
https://bugs.webkit.org/show_bug.cgi?id=71964

Reviewed by Darin Adler.

Source/WebCore:

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):

Don't ask the client for proxy credentials. CFNetwork results are authoritative, and proxy
credentials are system-wide.

Source/WebKit2:

  • WebProcess/com.apple.WebProcess.sb: Allow mach-lookup of com.apple.cfnetwork.AuthBrokerAgent.
18:40 Changeset [99799] by commit-queue@webkit.org

[chromium] Fix typo in checkerboarding code
https://bugs.webkit.org/show_bug.cgi?id=71981

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-09
Reviewed by James Robinson.

No new tests.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::drawTiles):

18:32 Changeset [99798] by barraclough@apple.com

Renovate ARMv7 assembler/macro-assembler
https://bugs.webkit.org/show_bug.cgi?id=71982

Reviewed by Geoff Garen.

ARMv7Assembler:

  • add support for strb (byte stores)
  • rename the VMOV_CtoS opcodes (there are currently backwards!)
  • add support for adc (add with carry)
  • add support for vsqrt, vabs
  • add support for vmov (between FPRs, and to/from GPR pairs).
  • remove '_F64' postfixes from instructions (these aren't helpful, functions can already be distinguished by their signatures).
  • rename vcvt_F64_S32 to vcvt_signedToFloatingPoint, the prior postfix was unhelpful in failing to distinguish the types (S32 indicates a single precision register, but the type could be float, int32, or uint32).
  • rename vcvtr_S32_F64 to vcvt_floatingPointToSigned, as for previous, also vcvtr was the incorrect name for the operation (the emitted instruction truncates).

MacroAssemblerARMv7:

  • add 3-operand versions of and32, lshift32, or32, rshift32, urshift32, sub32, xor32,
  • add store8, and store32 imm to base-index.
  • fix load32WithCompactAddressOffsetPatch to work for all gprs (the fix is a little kludgy but functional; to do better we'll have to also fix the repatching code).
  • Update supportsFloating* flags (all features now supported).
  • add moveDouble, storeDouble to absolute address, addDouble to absolute address
  • add 3-operand double operations.
  • implement sqrtDouble/absDouble
  • add branchTruncateDoubleToInt32, implement truncateDoubleToInt32
  • move should do nothing if src == dest
  • branchTest8-on-memory can be implemented in terms of branchTest32-on-register (branchTest8-on-register has been removed).
  • add 3-operand branchAdd32, branchSub32, also branchAdd32 absolute address.
18:27 Changeset [99797] by tkent@chromium.org

[Chromium] Add expectation files for locale-sensitive-fonts.html
https://bugs.webkit.org/show_bug.cgi?id=67019

  • platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Added.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Added.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:25 Changeset [99796] by commit-queue@webkit.org

[chromium] MediaStream API: Add WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=71458

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-09
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamRegistry.h: Added.
  • src/WebMediaStreamRegistry.cpp: Added.

(WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):

18:05 Changeset [99795] by bfulgham@webkit.org

[WinCairo] Further exclusions for unsupported features.

  • platform/wincairo/Skipped: Turn off mathml and webgl tests.
17:53 Changeset [99794] by commit-queue@webkit.org

Unreviewed, rolling out r99782.
http://trac.webkit.org/changeset/99782
https://bugs.webkit.org/show_bug.cgi?id=71979

broke most of the feImage tests (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-09

Source/WebCore:

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

LayoutTests:

  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Removed.
  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Removed.
  • svg/filters/feImage-reference-svg-primitive.svg: Removed.
  • svg/filters/feImage-zero-size-crash-expected.txt: Removed.
  • svg/filters/feImage-zero-size-crash.svg: Removed.
17:41 Changeset [99793] by haraken@chromium.org

Remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm
https://bugs.webkit.org/show_bug.cgi?id=71938

Reviewed by Darin Adler.

Now no IDL files are using [CanBeConstructed] IDL.
We can safely remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm: Removed [CanBeConstructed]-related code.

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateImplementation):

  • bindings/scripts/test/TestInterface.idl: Removed [CanBeConstructed].
  • bindings/v8/V8Proxy.h: Removed V8Proxy::constructDOMObject and V8Proxy::constructDOMObjectWithScriptExecutionContext, which had been used only by [CanBeConstructed].
17:33 Changeset [99792] by eae@chromium.org

Remove unnecessary type conversion for unscaledDocumentRect

17:21 Changeset [99791] by eric@webkit.org

Remove the concept of platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71963

Unreviewed. Fix test-webkitpy on cygwin.

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
17:16 Changeset [99790] by ojan@chromium.org

Fix up expected results after http://trac.webkit.org/changeset/99772.
The chromium mac results match the platform/mac results.

  • platform/chromium/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
17:15 Changeset [99789] by scherkus@chromium.org

2011-11-09 Andrew Scherkus <scherkus@chromium.org>

Rebaseline media layout tests due to r98596.

  • platform/chromium-cg-mac-snowleopard/media/audio-controls-rendering-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-styling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-without-preload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/media-controls-clone-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-empty-source-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-empty-source-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-no-audio-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.png.
  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-empty-source-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.txt.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.txt.
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.txt.
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Added.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-without-preload-expected.txt.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.png.
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.png.
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.png.
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-volume-slider-expected.png.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png: Removed.
  • platform/chromium-mac/media/controls-styling-expected.png: Removed.
  • platform/chromium-mac/media/controls-styling-expected.txt: Removed.
  • platform/chromium-mac/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-mac/media/media-controls-clone-expected.png: Removed.
  • platform/chromium-mac/media/media-controls-clone-expected.txt: Removed.
  • platform/chromium-mac/media/video-display-toggle-expected.txt: Removed.
  • platform/chromium-mac/media/video-empty-source-expected.png: Removed.
  • platform/chromium-mac/media/video-no-audio-expected.png: Removed.
  • platform/chromium-mac/media/video-no-audio-expected.txt: Removed.
  • platform/chromium-mac/media/video-volume-slider-expected.txt: Removed.
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.txt.
  • platform/chromium/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.txt.
  • platform/chromium/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.txt.
  • platform/chromium/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.txt.
  • platform/chromium/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.txt.
  • platform/chromium/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.txt.
  • platform/chromium/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.txt.
  • platform/chromium/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.txt.
  • platform/chromium/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.txt.
  • platform/chromium/test_expectations.txt:
17:10 Changeset [99788] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

17:08 Changeset [99787] by fpizlo@apple.com

DFG OSR exit code should be lazily generated
https://bugs.webkit.org/show_bug.cgi?id=71744

Reviewed by Gavin Barraclough.

The OSR exit code is now generated the first time it is executed,
rather than right after speculative compilation. Because most OSR
exits are never taken, this should greatly reduce both code size
and compilation time.

This is a 1% win on SunSpider, and a 1% win on V8 when running in
my harness. No change in V8 in V8's harness (due to the long runs,
so compile time is not an issue) and no change in Kraken (again,
long runs of small code so compile time has no measurable effect).

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::jump):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::jump):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::jmp_m):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::createDFGDataIfNecessary):
(JSC::CodeBlock::appendDFGOSREntryData):
(JSC::CodeBlock::numberOfDFGOSREntries):
(JSC::CodeBlock::dfgOSREntryData):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(JSC::CodeBlock::numberOfOSRExits):
(JSC::CodeBlock::numberOfSpeculationRecoveries):
(JSC::CodeBlock::osrExit):
(JSC::CodeBlock::speculationRecovery):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGCorrectableJumpPoint.cpp: Added.

(JSC::DFG::CorrectableJumpPoint::codeLocationForRepatch):

  • dfg/DFGCorrectableJumpPoint.h: Added.

(JSC::DFG::CorrectableJumpPoint::CorrectableJumpPoint):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
(JSC::DFG::CorrectableJumpPoint::correctInitialJump):
(JSC::DFG::CorrectableJumpPoint::correctLateJump):
(JSC::DFG::CorrectableJumpPoint::initialJump):
(JSC::DFG::CorrectableJumpPoint::lateJump):
(JSC::DFG::CorrectableJumpPoint::correctJump):
(JSC::DFG::CorrectableJumpPoint::getJump):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSRExit.cpp: Added.

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler.cpp: Added.
  • dfg/DFGOSRExitCompiler.h:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

  • dfg/DFGThunks.cpp: Added.

(JSC::DFG::osrExitGenerationThunkGenerator):

  • dfg/DFGThunks.h: Added.
  • jit/JITCode.h:

(JSC::JITCode::dataAddressAtOffset):

  • runtime/JSGlobalData.h:
17:07 Changeset [99786] by commit-queue@webkit.org

Add cc-bugs group to watch changes in chromium graphics
https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-09
Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
  • Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
  • Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
17:04 Changeset [99785] by eric@webkit.org

Remove more platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71971

Reviewed by Adam Barth.

Tests which only run on a couple platforms will break.
All tests should run on all platforms where possible.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
17:03 Changeset [99784] by eae@chromium.org

Merging trunk changes up until 99750 into subpixel branch.

16:49 Changeset [99783] by ojan@chromium.org

Merge in results to the test results server even if build numbers conflict
https://bugs.webkit.org/show_bug.cgi?id=71967

Reviewed by Tony Chang.

This was initially meant to be a sanity check that we don't
enter duplicate runs, but it turns out that we can reasonably get
in these situations when a builder is clobbered (e.g. the build
numbers start over again from 0).

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
16:39 Changeset [99782] by timothy_horton@apple.com

feImage referencing a primitive draws incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71731
<rdar://problem/10408178>

Reviewed by Simon Fraser.

Don't attempt to resolve an <feImage>'s referenced element until it's used, as it
may not exist at the time the attribute is set on the <feImage>.

Don't attempt to render an <feImage> if the referenced element is of size 0x0.

Tests: svg/filters/feImage-reference-svg-primitive.svg

svg/filters/feImage-zero-size-crash.svg

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

Add a test (feImage-reference-svg-primitive) that ensures that having
an <feImage> referencing an SVG primitive which is declared after it
successfully paints the referenced object.

Add a test (feImage-zero-size-crash) to see if we crash when <feImage>
references an object with 0x0 size.

  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Added.
  • svg/filters/feImage-reference-svg-primitive.svg: Added.
  • svg/filters/feImage-zero-size-crash-expected.txt: Added.
  • svg/filters/feImage-zero-size-crash.svg: Added.
16:24 Changeset [99781] by eric@webkit.org

Remove the concept of platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71963

Reviewed by Adam Barth.

These have been the source of never-ending sadness.
We'd change behavior and forget to update results in
some unittests because they were only run on certain platforms.
This change removes a large source of these platform-dependent
unittests, which was caused by the port_maker stuff.

It's possible that this change will break test-webkitpy
on some platforms, but that will be a one-time cost.
I will fix the breakage by removing the platform-dependantness
of any such broken tests.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
16:11 Changeset [99780] by dominicc@chromium.org

Remove WebGLContextEvent.initEvent method
https://bugs.webkit.org/show_bug.cgi?id=71720

Reviewed by Adam Barth.

The WebGL spec calls this method initWebGLContextEvent, but it may
adopt a constructor instead. Deleting the initEvent method for now
since it is definitely wrong and we don't want people to come to
depend on it.

No new tests--removing untested code.

  • html/canvas/WebGLContextEvent.cpp:
  • html/canvas/WebGLContextEvent.h:
  • html/canvas/WebGLContextEvent.idl:
16:04 Changeset [99779] by mhahnenberg@apple.com

Fixing build breakage

Unreviewed build fix

15:59 Changeset [99778] by andersca@apple.com

Element::boundsInWindowSpace should be Element::boundsInRootViewSpace
https://bugs.webkit.org/show_bug.cgi?id=71955

Reviewed by Sam Weinig.

Source/WebCore:

Element::boundsInWindowSpace is only used by WebKit2, where the window coordinate space is the
same as the root view coordinate space. This lets us get rid of another use of contentsToWindow.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::boundsInRootViewSpace):

  • dom/Element.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):
Call Element::boundsInRootViewSpace.

15:56 Changeset [99777] by lforschler@apple.com

Fix file formatting.

15:55 Changeset [99776] by haraken@chromium.org

Unreviewed, rebaseline run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
15:55 Changeset [99775] by lforschler@apple.com

Fix break after r99644.

15:47 Changeset [99774] by commit-queue@webkit.org

[chromium] Add draw-time scale delta to compositor thread
https://bugs.webkit.org/show_bug.cgi?id=71595

Patch by Alexandre Elias <aelias@google.com> on 2011-11-09
Reviewed by James Robinson.

There are two magnify values:

  1. The WebKit-side pageScale value corresponding to the resolution of the painted content.
  2. The Impl-side-only scaleDelta value representing the additional degree of current magnification, applied as a draw transform. WebKit is never explicitly aware of this value and the only way to change it currently is via pinch events (and in the future, double-tap/etc events). At the end of a pinch zoom, we multiply pageScale * scaleDelta and tell WebKit to use it as the new pageScale.

Scroll offsets and max-extents are maintained in pageScale space.
When the scale changes, we need to take care to convert them to the
new scale and avoid getting them clamped to the extents at the wrong
scale.

I removed maxScrollPosition on the non-impl side because it makes no
sense to precompute it in the presence of an impl-side zoom. Replaced
with a simple 'bool m_scrollable'.

zoomAnimatorTransform is not used because it currently isn't in the
branch, and mostly doesn't behave the way we want anyway (it does most
things in WebKit thread). We will need to unify these later.

Also introduce deviceOrPageScaleFactorChanged() call which invalidates
layers.

Source/WebCore:

No new tests (filed 71529 to remember to do it later).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::pageScaleChanged):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setPageMagnifyTransform):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setViewport):

  • platform/graphics/chromium/NonCompositedContentHost.h:

(WebCore::NonCompositedContentHost::topLevelRootLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scrollable):
(WebCore::CCLayerImpl::setScrollable):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScale):
(WebCore::CCLayerTreeHost::setPageScaleFactorLimits):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::pageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setViewport):
(WebCore::CCLayerTreeHostImpl::setPageScale):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorLimits):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::pinchGestureEnd):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::pageScale):

  • platform/graphics/chromium/cc/CCScrollController.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebLayerTreeViewClient.h:
  • public/WebView.h:
  • src/WebCompositorImpl.cpp:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::expectContains):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::applyScrollAndScale):
(WTF::MockLayerTreeHostClient::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollAndScale):

15:40 Changeset [99773] by eric@webkit.org

Make the Port object have a Host
https://bugs.webkit.org/show_bug.cgi?id=71961

Reviewed by Adam Barth.

This has been a long time coming.
Now that Port has a Host object, it's very easy
to write unittests which use a properly mocked Port.
Soon we will remove the executive, filesystem and user
members of Port and get everything through the Host.

Note how in many callsites we're actually removing
explicit mocks, since we're now always going to get the
correct Executive/User/FileSystem from the
Host and callsites don't need to be careful to pass each one.

This is prep-work for adding a new Environment member to
Host and needing to be able to access the Environment
member from Port functions w/o needing to pass an Environment
object (or appropriate Mock) every place we create a Port object.
Now that we have a single Host object to reach out through, its
simple to add additional functionality (like Environment) while
keeping our unittests properly mocked.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/apple.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
15:40 Changeset [99772] by haraken@chromium.org

Use dumpAsText() to avoid an image result being generated
https://bugs.webkit.org/show_bug.cgi?id=71386

Reviewed by Tony Chang.

single-line-must-not-be-split-into-two-pages.html had been producing
a huge image result. What we need is a way by which we can generate a
DumpRenderTree result but do not generate an image even if
--pixel-test option is specified for ./Tools/Scripts/new-run-webkit-tests.
This patch realizes it using dumpAsText() and
window.internals.elementRenderTreeAsText.

  • printing/single-line-must-not-be-split-into-two-pages.html: Used dumpAsText() and window.internals.elementRenderTreeAsText.
  • platform/chromium-cg-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Updated a test result.
  • platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Ditto.
15:32 Changeset [99771] by scherkus@chromium.org

2011-11-09 Andrew Scherkus <scherkus@chromium.org>

Clean up a few media test expectations.

  • platform/chromium/test_expectations.txt:
15:28 Changeset [99770] by dmazzoni@google.com

Source/WebKit/chromium: Fix crash by handling case when AccessibilityObject::lineForPosition
returns -1.
https://bugs.webkit.org/show_bug.cgi?id=71561

Adds layout test: platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html

Reviewed by Dimitri Glazkov.

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::lineBreaks):

Tools: [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
https://bugs.webkit.org/show_bug.cgi?id=71561

Reviewed by Dimitri Glazkov.

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::insertionPointLineNumberGetterCallback):

LayoutTests: [Chromium] Add new test for crash in WebAccessibilityObject::lineBreaks
https://bugs.webkit.org/show_bug.cgi?id=71561

Reviewed by Dimitri Glazkov.

  • platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt: Added.
  • platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html: Added.
15:27 Changeset [99769] by alexis.menard@openbossa.org

WebGraphicsLayer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=71959

Reviewed by Noam Rosenthal.

The contentsScale needs to get a default value just like
TiledBackingStore in case no value is explicitely set.

It is covered by existing tests.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):

15:21 Changeset [99768] by mhahnenberg@apple.com

De-virtualize JSVariableObject::isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=71933

Reviewed by Geoffrey Garen.

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h: Inlined and de-virtualized isDynamicScope

(JSC::JSActivation::isDynamicScope):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h: Inlined and de-virtualized isDynamicScope

(JSC::JSGlobalObject::isDynamicScope):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h: Inlined and de-virtualized isDynamicScope

(JSC::JSStaticScopeObject::createStructure): Changed createStructure to use new JSType
(JSC::JSStaticScopeObject::isDynamicScope):

  • runtime/JSType.h: Added new type for JSStaticScopeObject
  • runtime/JSVariableObject.cpp: De-virtualized and added an implementation that checks the

object's type and calls the corresponding implementation.
(JSC::JSVariableObject::isDynamicScope):

  • runtime/JSVariableObject.h:
15:14 Changeset [99767] by mhahnenberg@apple.com

De-virtualize JSGlobalObject::hasOwnPropertyForWrite
https://bugs.webkit.org/show_bug.cgi?id=71934

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalObject.h: Removed the virtual-ness of hasOwnPropertyForWrite since nobody overrides it.
15:13 Changeset [99766] by jcivelli@chromium.org

Fix MHTML generation to use the QuotedPrintable encoding for text resources.
This was regressed when we added binary encoding support.
https://bugs.webkit.org/show_bug.cgi?id=71857

Reviewed by Adam Barth.

Source/WebCore:

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

Source/WebKit/chromium:

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::LineReader::LineReader):
(WebKit::LineReader::getNextLine):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::TEST_F):

15:05 Changeset [99765] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::absDouble):

  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::absDouble):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::absDouble):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::absDouble):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::absDouble):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

14:58 Changeset [99764] by haraken@chromium.org

Replace [CanBeConstructed] IDL with [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71927

Reviewed by Adam Barth.

With respect to the IDL files that have [CanBeConstructed]
but do not have [Constructor] nor [CustomConstructor],
[CanBeConstructed] is now equivalent to [Constructor].
Thus, this patch replaces [CanBeConstructed] with [Constructor].

No tests. No change in behavior.

  • fileapi/FileReaderSync.idl: As I described above.
  • fileapi/WebKitBlobBuilder.idl: Ditto.
  • fileapi/WebKitFlags.idl: Ditto.
  • xml/DOMParser.idl: Ditto.
  • xml/XMLSerializer.idl: Ditto.
  • xml/XPathEvaluator.idl: Ditto.
14:53 Changeset [99763] by noel.gordon@gmail.com

[chromium] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=71846

Reviewed by Adam Barth.

Remove the implicit assumption that a dataURL is the only desired output format of the
the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::encodeImage): Output the encoded image to a Vector.
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType encoded
image Vector here. Move the mimeType encoding debug check here to better align this
code with the CG (CoreGraphics) ImageBuffer.cpp implementation.
(WebCore::ImageDataToDataURL): ditto.

14:43 Changeset [99762] by commit-queue@webkit.org

Implement dumpProgressFinishedCallback() for Mac layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=66772

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-09
Reviewed by Simon Fraser.

Tools:

When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
"postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().

On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
in the FrameLoadDelegate and print the output in response to the notification.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate init]):
(-[FrameLoadDelegate dealloc]):
(-[FrameLoadDelegate webViewProgressFinishedNotification:]):

LayoutTests:

Unskip the skipped test.

  • platform/mac/Skipped:
14:29 Changeset [99761] by commit-queue@webkit.org

Chromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom scrollbar css.
https://bugs.webkit.org/show_bug.cgi?id=71719

Source/WebCore:

This was caused by the overhang calculation logic not being consistent when subtracting the scrollbar sizes from the overhang areas. This resulted in for e.g. a horizontal overhang that didn't overlap with the scrollbar while the vertical overhang overlapped with it. This fix makes the logic consistent so that the overhang areas do not overlap with the scrollbars (when scrollbars are opaque).

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

Tests: platform/chromium/rubberbanding/custom-scrollbars-ne.html

platform/chromium/rubberbanding/custom-scrollbars-nw.html
platform/chromium/rubberbanding/custom-scrollbars-se.html
platform/chromium/rubberbanding/custom-scrollbars-sw.html

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

LayoutTests:

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

  • platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-ne.html: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-nw.html: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-se.html: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-sw.html: Added.
14:20 Changeset [99760] by jchaffraix@webkit.org

Unreviewed rebaseline after r99752.

  • platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
  • platform/chromium-win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
14:16 Changeset [99759] by ojan@chromium.org

[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=71880

Reviewed by Tony Chang.

Makes the test run ~10x faster by making the second select element only have 16
option elements. As best I can tell, that covers all the edge cases from r99653.

Also, cleaned up the test to make it a more normal js test:
-Gave it a doctype so it's in standards-mode.
-Moved the description to a description call.
-Generated both select element in script instead of just one of them.

  • fast/forms/select-clientheight-large-size-expected.txt:
  • fast/forms/select-clientheight-large-size.html:
  • platform/chromium/test_expectations.txt:
14:09 Changeset [99758] by vangelis@chromium.org

Merge 99485 - Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
https://bugs.webkit.org/show_bug.cgi?id=71714

Reviewed by James Robinson.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForScrollableFrames):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
https://bugs.webkit.org/show_bug.cgi?id=71714

Adjust the force-compositing-mode layout tests to explicitly set the new flag.

Reviewed by James Robinson.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/8506028

13:59 Changeset [99757] by antti@apple.com

Update test description.

Not reviewed.

  • svg/dom/rgb-color-parser-expected.txt:
13:25 Changeset [99756] by commit-queue@webkit.org

Source/WebCore: Indentation error in RenderObject::container
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

A conditional block was indented too far; correcting.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::container):

LayoutTests: Rebaselining gtk and qt results for foreign object overflow
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

Fix for 64780 changed results for one layoutTest. This is the rebaseline for gtk and qt platforms.

  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
13:18 Changeset [99755] by andersca@apple.com

Use contentsToRootView/rootViewToContents when converting between frame coordinate systems
https://bugs.webkit.org/show_bug.cgi?id=71947

Reviewed by Sam Weinig.

This gets rid of a few calls to contentsToWindow and windowToContents.

  • inspector/DOMNodeHighlighter.cpp:
  • page/DragController.cpp:

(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

13:09 Changeset [99754] by mhahnenberg@apple.com

De-virtualize JSObject::getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71523

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

(JSC::DebuggerActivation::getOwnPropertyDescriptor):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyDescriptor):

  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.h:
  • runtime/ClassInfo.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/DatePrototype.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertyDescriptor):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertyDescriptor):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertyDescriptor):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertyDescriptor):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::vtableAnchor):
(JSC::JSObject::propertyIsEnumerable):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSString.cpp: Removed getOwnPropertyDescriptor, since this seems to be a relic from a

bygone era when getOwnPropertyDescriptor was rooted in JSCell rather than JSObject. There were
no call sites for this version of getOwnPropertyDescriptor in the entire project.

  • runtime/JSString.h:
  • runtime/Lookup.h:

(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/MathObject.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptor):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertyDescriptor):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertyDescriptor):

  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::vtableAnchor): Added to prevent a weak vtable.
(JSC::StringObject::getOwnPropertyDescriptor):

  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/StringPrototype.h:

Source/WebCore:

No new tests.

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyDescriptor):

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::vtableAnchor): Added to prevent a weak vtable.
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_method.h: Changed getOwnPropertyDescriptor from private to protected to allow

subclasses to use it in their MethodTables.

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):

  • bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyDescriptor):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
12:49 Changeset [99753] by xji@chromium.org

Rebaseline after r99616 and r99736.
Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
so that cr-mac failed for text too.

  • platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
12:35 Changeset [99752] by jchaffraix@webkit.org

REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html

fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
fast/repaint/scroll-inside-table-cell.html
fast/repaint/scroll-relative-table-inside-table-cell.html
fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

  • rendering/RenderLayer.h:

Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

  • fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • fast/repaint/scroll-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-inside-table-cell.html: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
12:28 Changeset [99751] by scherkus@chromium.org

Tests depending on video-paint-test.js can run non-deterministically
https://bugs.webkit.org/show_bug.cgi?id=71878

Reviewed by Darin Adler.

  • media/video-frame-accurate-seek.html: changed init() to initAndSeeked()
  • media/video-paint-test.js:
12:22 Changeset [99750] by haraken@chromium.org

Generate the HTMLAudioElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71924

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLAudioElement
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • Target.pri: Removed V8HTMLAudioElementConstructor.{h,cpp}
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Removed.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h: Removed.
  • html/HTMLAudioElement.idl: Added [NamedConstructor] IDL.
  • page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
12:13 Changeset [99749] by antti@apple.com

Eliminate CSSMutableValue
https://bugs.webkit.org/show_bug.cgi?id=71811

Source/WebCore:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

Remove the implementations of setter functions in SVGColor and SVGPaint. These interfaces are
deprecated in SVG 1.1 (2nd edition) and are not really used by anybody. This allows
removal of CSSMutableValue and the associated (rather broken) code.

The setters now throw NO_MODIFICATION_ALLOWED_ERR.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):

  • css/CSSMutableValue.h: Removed.
  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::getPropertyCSSValue):

  • css/CSSValue.h:

(WebCore::CSSValue::CSSValue):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::setPaint):

  • svg/SVGPaint.h:

LayoutTests:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

SVGColor and SVGPaint setter function are deprecated and throw exception.

  • Remove (mostly render tree dump based) tests for SVGColor mutations that have little useful coverage otherwise.
  • Fix some other tests to work without the feature.
  • Update rgb-color-parser.html to also cover the cases from rgbcolor-syntax.svg (which is removed). They test the same thing but the former uses a better mechanism.
  • Update the test results to capture the new behavior.
  • fast/css/parse-color-int-or-percent-crash.html:
  • platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
  • platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
  • platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
  • platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
  • platform/gtk/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/gtk/svg/custom/rgbcolor-syntax-expected.txt: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
  • platform/mac/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/mac/svg/custom/rgbcolor-syntax-expected.txt: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
  • platform/qt/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/qt/svg/custom/rgbcolor-syntax-expected.txt: Removed.
  • svg/custom/SVGPaint-mutate-attribute.svg: Removed.
  • svg/custom/SVGPaint-mutate-inline-style.svg: Removed.
  • svg/custom/fill-SVGPaint-interface.svg:
  • svg/custom/getPresentationAttribute-modify-expected.txt: Removed.
  • svg/custom/getPresentationAttribute-modify.svg: Removed.
  • svg/custom/getPresentationAttribute.svg:
  • svg/custom/rgbcolor-syntax.svg: Removed.
  • svg/dom/SVGColor-expected.txt:
  • svg/dom/SVGPaint-expected.txt:
  • svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Removed.
  • svg/dom/getPresentationAttribute-cache-corruption.svg: Removed.
  • svg/dom/rgb-color-parser-expected.txt:
  • svg/dom/rgb-color-parser.html:
  • svg/dom/script-tests/SVGColor.js:
  • svg/dom/script-tests/SVGPaint.js:
12:10 Changeset [99748] by philn@webkit.org

[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Martin Robinson.

.:

  • Source/autotools/symbols.filter: Revert un-needed symbol.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic

calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

Call WebCoreTestSupport::resetInternalsObject without going
through DumpRenderTreeSupport.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

12:05 Changeset [99747] by haraken@chromium.org

Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71925

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLOptionElement,
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
  • html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
  • page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
12:04 Changeset [99746] by bdakin@apple.com

Build fix.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementAttributeValue):

12:01 Changeset [99745] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):

  • jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

11:57 Changeset [99744] by jchaffraix@webkit.org

Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

  • fast/table/crash-splitColumn-2-expected.txt: Added.
  • fast/table/crash-splitColumn-2.html: Added.
  • fast/table/crash-splitColumn-3-expected.txt: Added.
  • fast/table/crash-splitColumn-3.html: Added.
  • fast/table/crash-splitColumn-expected.txt: Added.
  • fast/table/crash-splitColumn.html: Added.
11:45 Changeset [99743] by bdakin@apple.com

Speculative build fix.

  • DumpRenderTree/AccessibilityUIElement.h:
11:35 Changeset [99742] by commit-queue@webkit.org

Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute().
https://bugs.webkit.org/show_bug.cgi?id=71510

Patch by Arko Saha <arko@motorola.com> on 2011-11-09
Reviewed by Darin Adler.

Source/WebCore:

Override isURLAttribute() for HTMLElement and return true if attribute is itemidAttr.
All the classes derived from HTMLElement overrides this function should return true if attribute is itemidAttr.
Removed HTMLIFrameElement::isURLAttribute() method as HTMLFrameElementBase already takes care of it.

Test: fast/dom/MicroData/itemid-attribute-test-001.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isURLAttribute):

  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::isURLAttribute):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isURLAttribute):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isURLAttribute):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isURLAttribute):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::isURLAttribute):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAttribute):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::isURLAttribute):

  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isURLAttribute):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isURLAttribute):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isURLAttribute):

  • html/HTMLModElement.cpp:

(WebCore::HTMLModElement::isURLAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isURLAttribute):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::isURLAttribute):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::isURLAttribute):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isURLAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isURLAttribute):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::isURLAttribute):

LayoutTests:

  • fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added.
  • fast/dom/MicroData/itemid-attribute-test-001.html: Added.
11:28 Changeset [99741] by jchaffraix@webkit.org

Unreviewed build fix.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::makeJSAccessibilityUIElement):
A bad merge added this check that is making the bots sad.

11:08 Changeset [99740] by cfleizach@apple.com

AX: crash when accessing selectedTab in a tab list
https://bugs.webkit.org/show_bug.cgi?id=70938

Reviewed by Beth Dakin.

Source/WebCore:

There were a few methods accessing m_children directly without first validating that those elements
needed to be updated (because the layout changed). Changing those to call children() ensures
that they will have the correct children.

Test: platform/mac/accessibility/selected-tab-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isChecked):
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):

Tools:

Add the ability to retrieve an element through an arbitrary attribute.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementAttributeValueCallback):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementAttributeValue):

LayoutTests:

  • platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
  • platform/mac/accessibility/selected-tab-crash.html: Added.
11:03 Changeset [99739] by ojan@chromium.org

Remove failures fixed with r99630.

  • platform/chromium/test_expectations.txt:
10:57 Changeset [99738] by japhet@chromium.org

Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:

TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/8511019

10:46 Changeset [99737] by philn@webkit.org

Unreviewed, GTK new baselines for 2 svg tests and skip a crashing
test that needs investigation.

  • platform/gtk/Skipped:
  • platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
10:44 Changeset [99736] by xji@chromium.org

Rebaseline after r99616.

  • platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:41 Changeset [99735] by achicu@adobe.com

Fixing build on MacOSX SL after 71838
https://bugs.webkit.org/show_bug.cgi?id=71912

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

10:14 Changeset [99734] by andreas.kling@nokia.com

Shrink HTMLCollection.
<http://webkit.org/b/71928>

Reviewed by Darin Adler.

Rearrange the members of HTMLCollection, effectively shrinking
it by 16 bytes on 64-bit. This reduces memory consumption
by 531 kB when loading the full HTML5 spec.

On 32-bit it shrinks by 8 bytes, saving 265 kB.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::type):

10:11 Changeset [99733] by darin@apple.com

Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
https://bugs.webkit.org/show_bug.cgi?id=71875

Reviewed by Anders Carlsson.

This is a step along the path of making OwnPtr work as HashMap value types.

  • wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.

Also fixed include style. To include other WTF headers inside WTF, we use "" includes.
I did not change the code to fix style checker complaints.

  • wtf/HashTable.h: Added includes as needed and fixed include style.

(WTF::doubleHash): Removed the uneeeded and inappropriate "static" in this function, which
gave it internal linkage for no good reason.
(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
construction/destruction problems instead of doing the trick where we construct and destroy
an empty value twice. It's cleaner and simpler and avoids copying the empty value.
(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
empty value is zero rather than copying an empty value.

  • wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.
10:07 Changeset [99732] by haraken@chromium.org

Remove redundant [CanBeConstructed] IDLs
https://bugs.webkit.org/show_bug.cgi?id=71868

Reviewed by Adam Barth.

If a class has [Constructor] or [CustomConstructor],
then [CanBeConstructed] is not necessary.
This patch just removes [CanBeConstructed] from all the classes
that already have [Constructor] or [CustomConstructor].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.

(WebCore::ConfigureV8TestObjTemplate):

  • css/WebKitCSSMatrix.idl:
  • dom/BeforeLoadEvent.idl:
  • dom/CustomEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitMutationObserver.idl:
  • dom/WebKitTransitionEvent.idl:
  • fileapi/FileReader.idl:
  • html/DOMFormData.idl:
  • html/TextTrackCue.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/track/TrackEvent.idl:
  • mediastream/PeerConnection.idl:
  • page/EventSource.idl:
  • page/WebKitPoint.idl:
  • webaudio/AudioContext.idl:
  • websockets/CloseEvent.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XSLTProcessor.idl:
10:02 Changeset [99731] by commit-queue@webkit.org

SVG foreignObject wrong container
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Simon Fraser.

Source/WebCore:

Resubmitting a patch originally by scottmg@chromium.org.
In determining where to add to m_positionedObjects during a repaint,
containingBlock is used, which adds the absolute positioned object to
the containing foreignObject. But, when the contained object is
dirtied, container() was used to dirty up the tree, which skipped over
the foreignObject causing the wrong parent to needsLayout(). This fix
makes container() and containingBlock() handle svg foreignObject's in
the same way.

This patch will cause svg/overflow/overflow-on-foreignObject.svg to
require rebaselined results on qt and gtk ports.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::container):

LayoutTests:

Added layout test for 64780 fix, rebaselined a test that it broke.
This will cause gtk and qt ports to also need rebaseline.

  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
  • svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
  • svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added
10:01 Changeset [99730] by andreas.kling@nokia.com

Shrink StyleSheet on 64-bit.
<http://webkit.org/b/71923>

Reviewed by Darin Adler.

Move m_disabled to the top so it folds into the padding at
the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):

  • css/StyleSheet.h:
09:40 Changeset [99729] by commit-queue@webkit.org

Add webkitdirs.pm:getArchitecture implementation for GTK
https://bugs.webkit.org/show_bug.cgi?id=71370

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Xan Lopez.

  • Scripts/webkitdirs.pm (determineArchitecture): Add an

implementation for ports using autotools, so that a vanilla
`run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
to build-jsc on x86-64 machines.

09:32 Changeset [99728] by commit-queue@webkit.org

[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=71891

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-09
Reviewed by Antonio Gomes.

This is C++ code, there is no need to cast the new objects to their
parents when creating them.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

09:32 Changeset [99727] by philn@webkit.org

Unreviewed, attempt to fix GTK 32-bits Release build after r99691.

  • Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject.
09:15 BuildingQtOnLinux edited by laszlo.1.gombos@nokia.com
(diff)
09:10 QtWebKitBuildBots edited by ossy@webkit.org
Reorder bots (diff)
09:10 QtWebKitBuildBots edited by ossy@webkit.org
Add new buildbots (diff)
09:07 Changeset [99726] by commit-queue@webkit.org

Adding missing implementation of WebMediaStreamDescriptor::label().

[Chromium] Missing WebMediaStreamDescriptor::label() implementation
https://bugs.webkit.org/show_bug.cgi?id=71657

Patch by Henrik Grunell <grunell@chromium.org> on 2011-11-09
Reviewed by Adam Barth.

  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::label):

09:07 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt versions on the bots (diff)
09:06 BuildingQtOnLinux edited by laszlo.1.gombos@nokia.com
(diff)
09:01 Changeset [99725] by kenneth@webkit.org

[WebKit2] Prepare viewport meta handling for desktop usage
https://bugs.webkit.org/show_bug.cgi?id=71907

Reviewed by Simon Hausmann.

This is only used by Qt so far. Now we don't always layout pages
without the viewport meta tag, using 980 as the layout width, but
instead we use that value (it is a setting) as a minimum value, or
else we use the viewport width.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportSize):
(QTouchWebViewPrivate::updateViewportConstraints):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewportSize):

08:31 Changeset [99724] by pfeldman@chromium.org

2011-11-09 Pavel Feldman <pfeldman@google.com>

Not reviewed: make new inspector test pass on Qt.

  • http/tests/inspector-enabled/injected-script-discard.html:
08:29 Changeset [99723] by commit-queue@webkit.org

Esperanto-translation
https://bugs.webkit.org/show_bug.cgi?id=69760

Unreviewed.
Patch by Kristjan SCHMIDT <kristjan.schmidt@googlemail.com>

Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-09

  • eo.po: Added.
08:19 Changeset [99722] by andreas.kling@nokia.com

StyleSheet: Devirtualize styleSheetChanged().
<http://webkit.org/b/71913>

Reviewed by Antti Koivisto.

Since this mechanism is only used by CSSStyleSheet, move it there.
Out-of-lined StyleSheet::setDisabled() so we can do a type check
before invoking it from there.

  • css/CSSStyleSheet.h:
  • css/StyleSheet.cpp:

(WebCore::StyleSheet::setDisabled):

  • css/StyleSheet.h:
08:12 Changeset [99721] by kbalazs@webkit.org

[Qt] Unreviewed gardening.

Add platform results for Qt5.

  • platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.
07:58 Changeset [99720] by hausmann@webkit.org

Unreviewed, rolling out r99707.
http://trac.webkit.org/changeset/99707

Re-enable until we can disable it together with tests in one
shot.

  • qmake/mkspecs/features/features.prf:
07:52 Changeset [99719] by vestbo@webkit.org

[Qt] Disable use of QtUiTools if the library/module is not found

We rely on the lookup order of prf files to inject our own uitools.prf
that will verify that QtUiTools is in fact present before allowing the
CONFIG += uitools to have any effect.

Reviewed by Simon Hausmann.

07:46 Changeset [99718] by hausmann@webkit.org

[Qt] Unreviewed, adding missing files to the build.

  • Target.pri: Add ContentTypeParser.cpp/h
07:40 Changeset [99717] by caseq@chromium.org

Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71826

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):

  • inspector/front-end/ScriptsPanel.js:

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

07:35 Changeset [99716] by pfeldman@chromium.org

2011-11-09 Pavel Feldman <pfeldman@google.com>

Not reviewed: annotate inspector front-end javascript so that it compiled again.

  • inspector/front-end/ShortcutsScreen.js:
  • inspector/front-end/WorkerManager.js:
07:31 Changeset [99715] by andreas.kling@nokia.com

Unreviewed build fix after r99711. (Signed/unsigned compare.)

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getDoubleValueInternal):

07:30 Changeset [99714] by pfeldman@chromium.org

Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=71842

These are the only WebKit-side changes needed. The rest will be done on the Chromium side.

Chromium bug: http://crbug.com/44350

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Pavel Feldman.

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::moveWindowBy):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::moveWindowBy):

07:27 Changeset [99713] by apavlov@chromium.org

Web Inspector: Provisionally change StylesSidebarPane section DOM layout to allow media queries
https://bugs.webkit.org/show_bug.cgi?id=71902

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

  • inspector/elements/elements-delete-inline-style-expected.txt:
  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/commit-selector-expected.txt:
  • inspector/styles/css-live-edit-expected.txt:
  • inspector/styles/metrics-box-sizing-expected.txt:
  • inspector/styles/metrics-box-sizing.html:
  • inspector/styles/parse-utf8-bom-expected.txt:
  • inspector/styles/parse-utf8-bom.html:
  • inspector/styles/show-user-agent-styles-expected.txt:
  • inspector/styles/show-user-agent-styles.html:
  • inspector/styles/styles-add-blank-property-expected.txt:
  • inspector/styles/styles-add-invalid-property-expected.txt:
  • inspector/styles/styles-add-new-rule-expected.txt:
  • inspector/styles/styles-cancel-editing-expected.txt:
  • inspector/styles/styles-change-node-while-editing-expected.txt:
  • inspector/styles/styles-commit-editing-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-disable-inherited-expected.txt:
  • inspector/styles/styles-disable-then-change-expected.txt:
  • inspector/styles/styles-disable-then-delete-expected.txt:
  • inspector/styles/styles-formatting-expected.txt:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-source-lines-inline-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:
07:12 Changeset [99712] by hausmann@webkit.org

Unreviewed, rolling out r99701.
http://trac.webkit.org/changeset/99701

Breaks Qt mac build

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(initResources):
(WebKit::WebPage::platformInitialize):

Tools:

  • qmake/mkspecs/features/functions.prf:
07:10 Changeset [99711] by andreas.kling@nokia.com

CSSPrimitiveValue: Fix up bitfield member types.
<http://webkit.org/b/71751>

Reviewed by Antti Koivisto.

The primitive unit type doesn't need to be a signed value,
and by making it unsigned, we can shave one bit off of it.
Furthermore, m_hasCachedCSSText and m_isQuirkValue should be
bool, not unsigned.

  • css/CSSValue.h:
07:09 Changeset [99710] by philn@webkit.org

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/focus-rings-expected.txt: Added.
  • platform/gtk/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
07:04 Changeset [99709] by pfeldman@chromium.org

Web Inspector: discard injected scripts upon front-end disconnect.
https://bugs.webkit.org/show_bug.cgi?id=71823

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector-enabled/injected-script-discard.html

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::clearFrontend):

LayoutTests:

  • http/tests/inspector-enabled/injected-script-discard-expected.txt: Added.
  • http/tests/inspector-enabled/injected-script-discard.html: Added.
07:03 Changeset [99708] by andreas.kling@nokia.com

CSS: Remove empty value and rule destructors.
<http://webkit.org/b/71901>

Reviewed by Antti Koivisto.

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.h:

(WebCore::CSSBorderImageSliceValue::create):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):

  • css/CSSCharsetRule.cpp:
  • css/CSSCharsetRule.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSFlexValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSPageRule.cpp:
  • css/CSSPageRule.h:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSValueList.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.h:
07:02 Changeset [99707] by hausmann@webkit.org

[Qt] Prospective build fix for Win32/Mac with xmlpatterns

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf: Disable XSLT support initially.

We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
is not up to the task of full XSLT support, so we should disable it.

07:00 Changeset [99706] by andreas.kling@nokia.com

CSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
<http://webkit.org/b/71897>

Reviewed by Antti Koivisto.

Everything that inherits from RefCounted<T> is already fast-allocated,
so we don't need this in subclasses.

  • css/CSSImageValue.h:
  • css/CSSImportRule.h:
  • css/WebKitCSSShaderValue.h:
06:58 Changeset [99705] by philn@webkit.org

Unreviewed, GTK rebaseline and skip a crashing test.

  • platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-table.html
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
06:51 Changeset [99704] by kbalazs@webkit.org

[Qt] failures in http/tests/security/contentSecurityPolicy with Qt5
https://bugs.webkit.org/show_bug.cgi?id=71906

Unreviewed gardening. Skip failing tests.

  • platform/qt-5.0/Skipped:
06:45 Changeset [99703] by igor.oliveira@openbossa.org

[TextureMapper] Clean up TextureMapperAnimation constructor
https://bugs.webkit.org/show_bug.cgi?id=71892

Remove copyAnimationValue and copyTimingFunction static functions. KeyframeList has
a copy constructor and it does not need anymore these copy functions.

Reviewed by Simon Hausmann.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperAnimation::TextureMapperAnimation):

06:40 Changeset [99702] by kbalazs@webkit.org

[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html fails
https://bugs.webkit.org/show_bug.cgi?id=71896

Unreviewed gardening.

  • platform/wk2/Skipped:
06:40 Changeset [99701] by hausmann@webkit.org

Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf: Use --whole-archive and their

mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

06:07 Changeset [99700] by rgabor@webkit.org

Buildfix for 32bit debug mode.

Reviewed by Csaba Osztrogonác.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

06:00 Changeset [99699] by commit-queue@webkit.org

[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
https://bugs.webkit.org/show_bug.cgi?id=71554

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-11-09
Reviewed by Simon Hausmann.

Source/WebKit/qt:

We should check the error domain when checking the error code in shouldFallBack()

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::shouldFallBack): added error domain check

LayoutTests:

Un-skip the 4 failing layout test, we now check the error domain along with the error code in shouldFallBack()

  • platform/qt/Skipped:
05:59 Changeset [99698] by kbalazs@webkit.org

WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42331

Unreviewed. Skip dependent test.

  • platform/wk2/Skipped: Skip http/tests/security/xssAuditor/script-tag-with-callbacks-actual.txt
05:58 Changeset [99697] by ossy@webkit.org

[Qt] Some passing tests removed from Skipped list
https://bugs.webkit.org/show_bug.cgi?id=45598
https://bugs.webkit.org/show_bug.cgi?id=32961
http://bugreports.qt.nokia.com/browse/QTBUG-15566

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
05:55 Changeset [99696] by ossy@webkit.org

Enable the DFG JIT on X86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Csaba Osztrogonác.

  • wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the

x86-64 GNU/Linux platform.

  • CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.
05:55 Changeset [99695] by achicu@adobe.com

[Part 1] Parse the custom() function in -webkit-filter
https://bugs.webkit.org/show_bug.cgi?id=71441

Source/WebCore:

Added code that parses the custom() function. There's no code
for the CSSStyleSelector yet, so the only way to test this was to
check the "styleSheets" rules.

Reviewed by Dean Jackson.

Tests: css3/filters/custom-filter-property-parsing-invalid.html

css3/filters/custom-filter-property-parsing.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedFilter):

  • css/CSSParser.cpp:

(WebCore::filterInfoForName):
(WebCore::acceptCommaOperator):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):

  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp:

(WebCore::filterOperationForType):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSShaderValue):

  • css/CSSValueKeywords.in:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::typeUsesSpaceSeparator):
(WebCore::WebKitCSSFilterValue::customCssText):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSShaderValue.h: Added.

(WebCore::WebKitCSSShaderValue::create):
(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):

  • platform/graphics/filters/FilterOperation.h:

LayoutTests:

Reviewed by Dean Jackson.

  • css3/filters/custom-filter-property-parsing-expected.txt: Added.
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt: Added.
  • css3/filters/custom-filter-property-parsing-invalid.html: Added.
  • css3/filters/custom-filter-property-parsing.html: Added.
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • css3/filters/script-tests/custom-filter-property-parsing.js: Added.

(jsWrapperClass):
(expression):
(description):

05:41 Changeset [99694] by hausmann@webkit.org

[Qt] Fix geolocation enabled build.

Reviewed by Tor Arne Vestbø.

  • Target.pri: Add QT += location to get the right module includes.
  • UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file with the right name (GeoLocation -> Geolocation)
  • UIProcess/qt/WebGeolocationProviderQt.h: Removed the ENABLE(GEOLOCATION) guards, otherwise moc doesn't generate

code, because it can't interpret the ENABLE() macro.

05:31 Changeset [99693] by ossy@webkit.org

Enable the DFG JIT on x86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373

Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686

Buildfix for stricter compilers: -Werror=unused-but-set-variable

Reviewed by Zoltan Herczeg.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

05:19 Changeset [99692] by yurys@chromium.org

Web Inspector: exception in remote front-end load handler due to undefined reference to workerManager
https://bugs.webkit.org/show_bug.cgi?id=71889

Move calls to WorkerManager load handlers into doLoadedDone method which is
called in case of remote front-end too.

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector.loaded):

05:14 Changeset [99691] by philn@webkit.org

[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Xan Lopez.

Source/WebKit/gtk:

DRTSupport infrastructure to reset the Internals object, like in Qt.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest): reset the Internals object after each test.

05:03 Changeset [99690] by vestbo@webkit.org

[Qt] Detect presence of QtUiTools and enable it only when available

The disable_uitools option was a workaround for missing detection.

Reviewed by Simon Hausmann.

05:02 Changeset [99689] by vsevik@chromium.org

Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
https://bugs.webkit.org/show_bug.cgi?id=71850

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):

  • inspector/front-end/ApplicationCacheModel.js: Added.

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.getApplicationCachesAsync):
(WebInspector.ApplicationCacheDispatcher):
(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._initializeApplicationCacheModel):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
05:01 Changeset [99688] by commit-queue@webkit.org

[EFL] Removed unused variable
https://bugs.webkit.org/show_bug.cgi?id=71877

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-09
Reviewed by Andreas Kling.

Removed unused rect variable declaration and renamed rect1 variable to rect.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_smart_calculate):

04:42 Changeset [99687] by loki@webkit.org

[WK2] nrwt pixeltests crash while test
https://bugs.webkit.org/show_bug.cgi?id=71688

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2011-11-09
Reviewed by Zoltan Herczeg.

  • platform/qt-5.0/Skipped:

'editing/pasteboard/data-transfer-items-image-png.html' is skipped, because it caused an nrwt pixel test crash.

03:58 Changeset [99686] by vsevik@chromium.org

Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=71848

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.BaseStorageTreeElement.prototype.onattach):
(WebInspector.BaseStorageTreeElement.prototype.get displayName):
(WebInspector.BaseStorageTreeElement.prototype._updateDisplayName):
(WebInspector.BaseStorageTreeElement.prototype._updateTitle):
(WebInspector.BaseStorageTreeElement.prototype._updateSubtitle):
(WebInspector.BaseStorageTreeElement.prototype.set titleText):
(WebInspector.BaseStorageTreeElement.prototype.get subtitleText):
(WebInspector.BaseStorageTreeElement.prototype.set subtitleText):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.FrameTreeElement.prototype.get itemURL):
(WebInspector.FrameTreeElement.prototype.onselect):

03:56 Changeset [99685] by vestbo@webkit.org

[Qt] Don't override config for the build_pass of debug_and_release

Qmake will parse the profile once for each configuration (debug and
release), with the build_pass option set. In that situation we don't
want to override what qmake is setting explicitly, otherwise the
debug-step will end up hitting all the release-scopes.

Reviewed by Simon Hausmann.

03:55 Changeset [99684] by vestbo@webkit.org

[Qt] Only copy framework headers once when debug_and_release is enabled

Otherwise we might end up in a race condition where we try to symlink
the headers directory in the makefile for debug and release at the same
time.

Reviewed by Simon Hausmann.

03:49 Changeset [99683] by pfeldman@chromium.org

Web Inspector: crash upon InspectorValue serialization that has 0 value / array entry.
https://bugs.webkit.org/show_bug.cgi?id=71806

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/resolve-alien-node.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::resolveNode):

  • inspector/InspectorValues.h:

(WebCore::InspectorObject::setValue):
(WebCore::InspectorObject::setObject):
(WebCore::InspectorObject::setArray):
(WebCore::InspectorArray::pushValue):
(WebCore::InspectorArray::pushObject):
(WebCore::InspectorArray::pushArray):

LayoutTests:

  • inspector/elements/resolve-alien-node-expected.txt: Added.
  • inspector/elements/resolve-alien-node.html: Added.
03:47 Changeset [99682] by sergio@webkit.org

Unreviewed. HiDPI is supported after r97407.

  • platform/gtk/Skipped: unskipped fast/hidpi
  • platform/gtk-wk2/Skipped: unskipped fast/hidpi
03:26 Changeset [99681] by hausmann@webkit.org

Unreviewed, rolling out r99678.
http://trac.webkit.org/changeset/99678
https://bugs.webkit.org/show_bug.cgi?id=71882

broke the build with -Werror=unused-but-set-variable
(Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-09

  • CMakeListsEfl.txt:
  • wtf/Platform.h:
03:19 Changeset [99680] by hausmann@webkit.org

[Qt] Unbreak the Qt build (copy & paste mistake - oops)

  • qmake/mkspecs/features/functions.prf:
03:12 Changeset [99679] by andreas.kling@nokia.com

Move CSSPrimitiveValue bitfields up into CSSValue.
<http://webkit.org/b/71835>

Reviewed by Darin Adler.

Move m_type (and rename it to m_primitiveUnitType),
m_hasCachedCSSText and m_isQuirkValue from CSSPrimitiveValue
up into CSSValue to share the space.

This, together with the devirtualization of CSSValue that
happened on <http://webkit.org/b/71666>, reduces the size
of CSSPrimitiveValue by one CPU word.

More specifically, we go from 16 to 12 bytes on 32-bit,
and from 24 to 16 bytes on 64-bit.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::getRGBColorValue):
(WebCore::CSSPrimitiveValue::getPairValue):
(WebCore::CSSPrimitiveValue::getIdent):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::setPrimitiveType):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::getRGBA32Value):
(WebCore::CSSPrimitiveValue::getPairValue):
(WebCore::CSSPrimitiveValue::getDashboardRegionValue):
(WebCore::CSSPrimitiveValue::getShapeValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):

  • css/CSSValue.h:

(WebCore::CSSValue::CSSValue):

03:03 Changeset [99678] by commit-queue@webkit.org

Enable the DFG JIT on X86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Filip Pizlo.

  • wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the

x86-64 GNU/Linux platform.

  • CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.
02:46 Changeset [99677] by rgabor@webkit.org

[Qt] Unreviewed. Update platform specific expected results again.

  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
02:37 Changeset [99676] by hausmann@webkit.org

[Qt] Centralize duplicated code for linking the static libs

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf:
  • qmake/mkspecs/features/javascriptcore.prf:
  • qmake/mkspecs/features/webcore.prf:
  • qmake/mkspecs/features/webkit2.prf:
02:18 Changeset [99675] by mhahnenberg@apple.com

De-virtualize JSObject::defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=71429

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineOwnProperty):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorDefineProperty):
(JSC::defineProperties):

Source/WebCore:

No new tests.

Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

02:11 Changeset [99674] by yutak@chromium.org

[Chromium] Unreviewed, remove incorrect pixel image for relative-sized-document-scrollbars.svg.

  • platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
01:56 Changeset [99673] by haraken@chromium.org

Make [CanBeConstructed] IDL redundant
https://bugs.webkit.org/show_bug.cgi?id=71871

Reviewed by Adam Barth.

As the first step to remove [CanBeConstructed] IDL completely,
we need to make [CanBeConstructed] IDL redundant.
This patch replaces '[CanBeConstructed]' in CodeGeneratorV8.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]',
and replaces '[CanBeConstructed]' in CodeGeneratorJS.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [JSCustomConstructor]'

An example:

before: '[CanBeConstructed] and ![V8CustomConstructor]'
after: '([CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]) and ![V8CustomConstructor]' <==> '([CanBeConstructed] or [Constructor] or [CustomConstructor]) and ![V8CustomConstructor]'

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified as I described above.

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Updated a run-bindings-tests result.

(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::JSTestObjConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::V8TestObj::constructorCallback):

01:50 Changeset [99672] by yutak@chromium.org

[Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT.

  • platform/chromium/test_expectations.txt:
01:42 Changeset [99671] by rgabor@webkit.org

[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected.

  • platform/qt/fast/forms/listbox-clip-expected.png:
  • platform/qt/fast/forms/listbox-clip-expected.txt:
01:25 Changeset [99670] by yutak@chromium.org

[Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac.

  • platform/chromium/test_expectations.txt:
01:15 Changeset [99669] by zimmermann@webkit.org

2011-11-09 Nikolas Zimmermann <nzimmermann@rim.com>

svg failures after r99561
https://bugs.webkit.org/show_bug.cgi?id=71830

Reviewed by Antti Koivisto.

Fix regressions in svg/zoom/page/relative-sized-document-scrollbars.svg and svg/zoom/page/zoom-svg-as-relative-image.html.
Fix merging problem in r99561, bug 71780. It moved several methods from SVGLength to SVGLengthContext, and unfortunately
the SVGLength changes part of r98852, bug 47156, got reverted again, making these two tests fail.

  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
01:14 Changeset [99668] by yutak@chromium.org

[Chromium] Rebaseline tests added in r99613. Check in correct baselines for
the Mac Skia bots.

  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
  • platform/chromium/fast/multicol/pagination-h-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png.
  • platform/chromium/fast/multicol/pagination-h-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png.
  • platform/chromium/fast/multicol/pagination-h-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png.
  • platform/chromium/fast/multicol/pagination-h-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png.
  • platform/chromium/fast/multicol/pagination-v-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png.
  • platform/chromium/fast/multicol/pagination-v-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png.
  • platform/chromium/fast/multicol/pagination-v-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png.
  • platform/chromium/fast/multicol/pagination-v-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png.
00:56 Changeset [99667] by commit-queue@webkit.org

Select multiple options with mouse drag in Select element.
https://bugs.webkit.org/show_bug.cgi?id=71128

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Ryosuke Niwa.

Multiple selection of option elements in select element with an mouse drag.
Other browsers(IE, Firefox, Opera) support this feature.

Source/WebCore:

Test: fast/forms/select-multiple-elements-with-mouse-drag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
Allow auto scroll to be fired if current node(option) under mouse does not have renderer
but its container node(select) can autoscroll and has renderer for specific case of ListBox

LayoutTests:

  • fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
  • fast/forms/select-multiple-elements-with-mouse-drag.html: Added.
00:52 Changeset [99666] by hausmann@webkit.org

[Qt] Build system cleanup
https://bugs.webkit.org/show_bug.cgi?id=71815

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

  • wtf/wtf.pri: Moved the glib dependency to javascriptcore.prf.

Source/WebCore:

  • Target.pri: Removed CodeGenHSL.cpp from the angle build. In the angle build the back-end has to

be either GLSL or HSL, it can't be both. Make a choice for GLSL as that's what it seems to be used for
at the moment.

Source/WebKit2:

  • Target.pri: Removed duplicated sources that are compiled also into QtWebKit.so through api.pri.
  • UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file here, as it should only be compiled

if geolocation is enabled.

  • UIProcess/qt/WebGeolocationProviderQt.h: Provide ENABLE(GEOLOCATION) guards around class definition.

Tools:

  • WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2

static library.

  • qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency

(ownPtr functions for glib types). Propagate that to everyone using javascriptcore.

00:51 Changeset [99665] by mrowe@apple.com

Fix the build.

  • WebCore.exp.in: Export the right symbol names.
  • WebCore.xcodeproj/project.pbxproj: Make the header file available outside of WebCore.
00:42 Changeset [99664] by hausmann@webkit.org

[Qt] Replace use of QApplication with QGuiApplication
https://bugs.webkit.org/show_bug.cgi?id=71794

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Add compat headers for use when building with Qt 4: QGuiApplication
is typedef'ed to QApplication.

  • wtf/qt/compat/QGuiApplication: Added.
  • wtf/qt/compat/qguiapplication.h: Added.

Source/WebCore:

  • Target.pri: Add compat include dir when compiling with Qt 4.
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::closeEvent): Replace use of QApplication with QGuiApplication.
(FullScreenVideoWindow::hideCursor): Ditto.
(FullScreenVideoWindow::showCursor): Ditto.

  • platform/graphics/qt/TileQt.cpp: Remove unnecessary inclusion of QApplication.
  • platform/qt/ClipboardQt.cpp: Replace use of QApplication with QGuiApplication.

(WebCore::ClipboardQt::ClipboardQt):
(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::declareAndWriteDragImage):
(WebCore::ClipboardQt::writeURL):
(WebCore::ClipboardQt::writeRange):
(WebCore::ClipboardQt::writePlainText):

  • platform/qt/PasteboardQt.cpp: Ditto.

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):

Source/WebKit/qt:

  • WebCoreSupport/QtWebComboBox.cpp:

(WebCore::QtWebComboBox::showPopupAtCursorPosition): Replace use of QApplication
with QCoreApplication.

Source/WebKit2:

  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove unnecessary QApplication inclusion.
  • Platform/qt/RunLoopQt.cpp: Replace QApplication include with QCoreApplication.
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Ditto.
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Remove unnecessary QApplication inclusion.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleMousePressEvent): Replace QApplication usage with QStyleHints.
(QtWebPageProxy::handleMouseDoubleClickEvent): Ditto.

00:29 Changeset [99663] by hausmann@webkit.org

Mac Build fix part 2: Oops, use the correct wtf/ prefix for the WTF include.

  • page/SecurityPolicy.cpp:
00:19 Changeset [99662] by hausmann@webkit.org

Prospective build fix for Windows: Include MainThread.h for ASSERT(isMainThread())
to compile.

  • page/SecurityPolicy.cpp:
00:06 Changeset [99661] by jcivelli@chromium.org

Fixes and reenables the WebPageSerializer tests.
https://bugs.webkit.org/show_bug.cgi?id=71874

Reviewed by Adam Barth.

  • WebKit.gypi:
  • tests/WebPageNewSerializerTest.cpp:

(WebKit::TestWebFrameClient::~TestWebFrameClient):
(WebKit::WebPageNewSerializeTest::SetUp):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):

  • tests/WebPageSerializerTest.cpp:

(WebKit::WebPageSerializerTest::WebPageSerializerTest):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):

00:00 Changeset [99660] by yutak@chromium.org

[Chromium] Unreviewed, update test expectation of listbox-clip.html.

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.