Timeline


and

11/14/11:

23:10 Changeset [100245] by pkasting@chromium.org
  • 1 edit
    7 moves in trunk/LayoutTests

r100237 moved some pixel baselines into platform/chromium without also
moving the text baselines. As a result all the Chromium Mac "not 10.6
CG" bots were still failing due to MISSING expectations.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt.
23:04 Changeset [100244] by fpizlo@apple.com
  • 12 edits
    4 deletes in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined
https://bugs.webkit.org/show_bug.cgi?id=72348

Reviewed by Gavin Barraclough.

Moved all of JITCodeGenerator into SpeculativeJIT.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGJITCodeGenerator.cpp: Removed.
  • dfg/DFGJITCodeGenerator.h: Removed.
  • dfg/DFGJITCodeGenerator32_64.cpp: Removed.
  • dfg/DFGJITCodeGenerator64.cpp: Removed.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::clearGenerationInfo):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownBoolean):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::markCellCard):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::dataFormatString):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::GPRTemporary::adopt):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::lock):
(JSC::DFG::SpeculativeJIT::unlock):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::reuse):
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::tryAllocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
(JSC::DFG::SpeculativeJIT::silentSpillGPR):
(JSC::DFG::SpeculativeJIT::silentSpillFPR):
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::silentFillFPR):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::unboxDouble):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::identifier):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImmPtr):
(JSC::DFG::SpeculativeJIT::bitOp):
(JSC::DFG::SpeculativeJIT::shiftOp):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::addressOfCallData):
(JSC::DFG::SpeculativeJIT::tagOfCallData):
(JSC::DFG::SpeculativeJIT::payloadOfCallData):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument):
(JSC::DFG::SpeculativeJIT::setupArguments):
(JSC::DFG::SpeculativeJIT::setupArgumentsExecState):
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::setupTwoStubArgs):
(JSC::DFG::SpeculativeJIT::setupStubArguments):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::setupResults):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::block):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::~IntegerOperand):
(JSC::DFG::IntegerOperand::index):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::~DoubleOperand):
(JSC::DFG::DoubleOperand::index):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::~JSValueOperand):
(JSC::DFG::JSValueOperand::index):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::jsValueRegs):
(JSC::DFG::JSValueOperand::isDouble):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::tagGPR):
(JSC::DFG::JSValueOperand::payloadGPR):
(JSC::DFG::JSValueOperand::fpr):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::GPRTemporary::~GPRTemporary):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::~FPRTemporary):
(JSC::DFG::FPRTemporary::fpr):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::GPRResult::GPRResult):
(JSC::DFG::GPRResult2::GPRResult2):
(JSC::DFG::FPRResult::FPRResult):
(JSC::DFG::FPRResult::lockedResult):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • runtime/JSFunction.h:
23:01 Changeset [100243] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the change log entry for r59190.

  • ChangeLog-2010-05-24:
22:58 Changeset [100242] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Weak reference harvesters should run to fixpoint
https://bugs.webkit.org/show_bug.cgi?id=72346

Reviewed by Oliver Hunt.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/ListableHandler.h:

(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::isEmpty):

22:43 Changeset [100241] by dbates@webkit.org
  • 3 edits in trunk/Tools

build-webkit: Accept --cmakearg to pass additional arguments to CMake.
https://bugs.webkit.org/show_bug.cgi?id=72156

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-14
Reviewed by Daniel Bates.

Similar to --makearg and --qmakearg, --cmakearg lets one pass
additional arguments to CMake (eg. --cmakearg="-DFOO=bar").

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

22:29 Changeset [100240] by pkasting@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

r100196 needed to also rebaseline Windows, not just Linux.

Unreviewed, gardening.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.png:
22:14 Changeset [100239] by dslomov@google.com
  • 4 edits
    2 adds in trunk

Source/WebCore: [V8][Chromium]Serialize dense arrays densly
https://bugs.webkit.org/show_bug.cgi?id=72198
This patch ensures that:

  • Dense arrays are serialized densly, and not as name-value pairs
  • Sparse arrays are allocated as sparse on deserialization.

The criteria to choose whether to serialize densly or sparsely is the size
of a resulting serialized stream.

Reviewed by David Levin.

Test: fast/dom/Window/window-postmessage-arrays.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeDenseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
(WebCore::V8ObjectMap::Serializer::writeDenseArray):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
(WebCore::V8ObjectMap::Serializer::ObjectState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::serializeDensely):
(WebCore::V8ObjectMap::Serializer::startArrayState):
(WebCore::V8ObjectMap::Serializer::startObjectState):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::newSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeDenseArray):

LayoutTests: [V8][Chromium]Serialize dense arrays densly.
https://bugs.webkit.org/show_bug.cgi?id=72198

Reviewed by David Levin.

  • fast/dom/Window/script-tests/postmessage-clone.js:
  • fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
  • fast/dom/Window/window-postmessage-arrays.html: Added.
22:07 Changeset [100238] by pkasting@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Removed.
  • platform/chromium/fast/table/prepend-in-anonymous-table-expected.txt: Added.
21:39 Changeset [100237] by pkasting@chromium.org
  • 11 edits
    24 adds
    8 deletes in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
20:27 Changeset [100236] by pkasting@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline svg/foreignObject/multiple-foreign-objects.html on Snow
Leopard and earlier.

Unreviewed, gardening.

  • platform/mac-snowleopard/svg/foreignObject: Added.
  • platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
20:08 Changeset [100235] by commit-queue@webkit.org
  • 11 edits
    10 deletes in trunk

[chromium] Fix scaleDelta zoom-out visibility rect bug
https://bugs.webkit.org/show_bug.cgi?id=72208

Since the scroll is no longer applied at the top layer of the layer
tree, the scaleDelta transformation needs to be moved down to the
same level.

Also fix zoomAnimator to be applied the same way. I removed zoom
animator layout tests, as they aren't testing the actual impl-side
codepath, and are hard to continue supporting -- we should cover zoom
features with unit tests in the future.

Patch by Alexandre Elias <aelias@google.com> on 2011-11-14
Reviewed by James Robinson.

No new tests (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scaleDelta):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setScaleDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scaleDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

19:14 Changeset [100234] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix the build after moving some arrays to WTF
https://bugs.webkit.org/show_bug.cgi?id=72345

Reviewed by Dirk Pranke.

  • public/WebArrayBufferView.h: s/WebCore/WTF/g.
19:08 Changeset [100233] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Improve ChangeLogEntry's reviewer parsing algorithm part 2
https://bugs.webkit.org/show_bug.cgi?id=72340

Reviewed by Eric Seidel.

This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
18:46 Changeset [100232] by cfleizach@apple.com
  • 2 edits in trunk/Source/WebCore

WebProcess crashes when trying to display your "uploaded videos" page on Facebook
https://bugs.webkit.org/show_bug.cgi?id=72334

Reviewed by Beth Dakin.

Protect against documents without frames.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):

18:33 Changeset [100231] by eric@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

The TestExpectationsChecker was using a generic try/except block
which caught all exceptions, so we didn't notice that failing
to pass a Host to PortFactory was causing an exception in port instantiation.
I've factored out the "lookup the port" logic into a separate function
which I've now unittested. This should fix the bug and prevent
others like it from occuring the the future.

  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
18:18 Changeset [100230] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

More V8 build fixes.

18:06 Changeset [100229] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fix V8 build again.

17:58 Changeset [100228] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fix V8 build

17:52 Changeset [100227] by oliver@apple.com
  • 46 edits
    4 copies
    9 adds in trunk/Source

Start migrating typed array impl types to WTF
https://bugs.webkit.org/show_bug.cgi?id=72336

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add typed array impls to WTF forwarding header.

  • wtf/Forward.h:

Source/WebCore:

Move typed arrays from WebCore namespace to WTF, and
start reducing dependencies on WebCore types.

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayHelper):

  • bindings/scripts/CodeGeneratorJS.pm:

(IsTypedArrayType):
(AddClassForwardIfNeeded):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(IsTypedArrayType):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Added.

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.h: Added.

(WebDOMFloat64Array::~WebDOMFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp: Added.

(WebKit::kit):
(WebKit::core):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_set_property):
(webkit_dom_float64array_get_property):
(webkit_dom_float64array_constructed):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
(WebKit::wrapFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h: Added.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Added.

(WebCore::JSFloat64ArrayConstructor::JSFloat64ArrayConstructor):
(WebCore::JSFloat64ArrayConstructor::finishCreation):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::getJSFloat64ArrayPrototypeTable):
(WebCore::JSFloat64ArrayPrototype::self):
(WebCore::getJSFloat64ArrayTable):
(WebCore::JSFloat64Array::JSFloat64Array):
(WebCore::JSFloat64Array::finishCreation):
(WebCore::JSFloat64Array::createPrototype):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::put):
(WebCore::JSFloat64Array::putByIndex):
(WebCore::JSFloat64Array::getOwnPropertyNames):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::JSFloat64Array::getByIndex):
(WebCore::toFloat64Array):
(WTF::Float64Array::neuterBinding):

  • bindings/scripts/test/JS/JSFloat64Array.h: Added.

(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64Array::createStructure):
(WebCore::JSFloat64Array::impl):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayPrototype::createStructure):
(WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
(WebCore::JSFloat64ArrayConstructor::create):
(WebCore::JSFloat64ArrayConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMFloat64Array.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm: Copied from Source/WebCore/html/canvas/Float32Array.cpp.

(core):
(kit):

  • bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/TestTypedArray.idl: Copied from Source/WebCore/html/canvas/Float64Array.cpp.
  • bindings/scripts/test/V8/V8Float64Array.cpp: Added.

(WebCore::Float64ArrayInternal::V8_USE):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore::V8Float64Array::wrapSlow):
(WTF::Float64Array::neuterBinding):
(WebCore::V8Float64Array::derefObject):

  • bindings/scripts/test/V8/V8Float64Array.h: Added.

(WebCore::V8Float64Array::toNative):
(WebCore::V8Float64Array::existingWrapper):
(WebCore::V8Float64Array::wrap):
(WebCore::toV8):

  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.h:
  • fileapi/WebKitBlobBuilder.h:
  • html/HTMLMediaElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.h:

(WTF::Float32Array::set):

  • html/canvas/Float64Array.cpp:
  • html/canvas/Float64Array.h:

(WTF::Float64Array::set):

  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.h:

(WTF::Int16Array::set):

  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.h:

(WTF::Int32Array::set):

  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.h:

(WTF::Int8Array::set):

  • html/canvas/IntegralTypedArrayBase.h:
  • html/canvas/TypedArrayBase.h:

(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):

  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.h:

(WTF::Uint16Array::set):

  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.h:

(WTF::Uint32Array::set):

  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.h:

(WTF::Uint8Array::set):

  • html/canvas/WebGLBuffer.h:
  • page/Crypto.h:
  • webaudio/AsyncAudioDecoder.h:
  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::zero):

  • webaudio/AudioContext.h:
  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperNode.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • xml/XMLHttpRequest.h:
17:48 Changeset [100226] by jchaffraix@webkit.org
  • 13 edits in trunk

Add --css-grid-layout to build-webkit and the build systems
https://bugs.webkit.org/show_bug.cgi?id=72320

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

Added the option.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
17:43 Changeset [100225] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
https://bugs.webkit.org/show_bug.cgi?id=72335

Patch by Daniel Bates <dbates@rim.com> on 2011-11-14
Reviewed by Eric Seidel.

It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.

  • rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
  • rendering/svg/RenderSVGContainer.cpp: Ditto.
  • rendering/svg/RenderSVGForeignObject.cpp: Ditto.
  • rendering/svg/RenderSVGImage.cpp: Ditto.
  • rendering/svg/RenderSVGInline.cpp: Ditto.
  • rendering/svg/RenderSVGModelObject.cpp: Ditto.
  • rendering/svg/RenderSVGPath.cpp: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto.
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
  • rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
  • rendering/svg/RenderSVGRoot.cpp: Ditto.
  • rendering/svg/RenderSVGText.cpp: Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Ditto.
  • rendering/svg/SVGRenderSupport.cpp: Ditto.
  • svg/SVGDocumentExtensions.cpp: Ditto.
  • svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
17:39 Changeset [100224] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

A little bit of arguments / activation cleanup
https://bugs.webkit.org/show_bug.cgi?id=72339

Reviewed by Gavin Barraclough.

Renamed copyRegisters => tearOff to match bytecode and other terminology.

Renamed setActivation => didTearOffActivation to indicate that this is a
notification the object may choose to ignore. Moved "Should I ignore?"
code into the arguments object to avoid duplication elsewhere.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::createAndTearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::finishCreationButDontTearOff):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndTearOff):
(JSC::Arguments::tearOff):

  • runtime/JSActivation.h:

(JSC::JSActivation::tearOff): Moved Activation's code into its own header
because that's where it belongs.

17:32 Changeset [100223] by barraclough@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Should sign the jsc binary
https://bugs.webkit.org/show_bug.cgi?id=72332

Reviewed by David Kilzer.

  • Configurations/JSC.xcconfig:
  • entitlements.plist: Added.
17:23 Changeset [100222] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] Add histogram collection for usage of DOM Mutation Events
https://bugs.webkit.org/show_bug.cgi?id=72316

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-14
Reviewed by Ryosuke Niwa.

This patch adds six calls in ~Document() which simply pipe-out to the embedder
the (already-collected) bits of whether varous DOM Mutation Events were registered
on the document.

No tests needed. No functional changes.

  • dom/Document.cpp:

(WebCore::histogramMutationEventUsage):
(WebCore::Document::~Document):

17:22 Changeset [100221] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG's inline references to objects should be tracked
https://bugs.webkit.org/show_bug.cgi?id=72313

Reviewed by Gavin Barraclough.

Added a pinCell() method in the parser that currently creates a
dummy constant in CodeBlock. Added calls to pinCell() wherever the
DFG would inline a constant reference that the original code would
not have referred to.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getCellConstantIndex):
(JSC::DFG::ByteCodeParser::pinCell):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

17:13 Changeset [100220] by noel.gordon@gmail.com
  • 1 edit
    5 adds in trunk/LayoutTests

Test JPEG image decoding RGB pixel endianess
https://bugs.webkit.org/show_bug.cgi?id=72234

Reviewed by Kent Tamura.

JPEG image RGB pixels should render without color corruption and in strict
order, regardless of the underlying machine pixel buffer endianess.

  • fast/images/resources/rgb-jpeg-blue.jpg: Added.
  • fast/images/resources/rgb-jpeg-green.jpg: Added.
  • fast/images/resources/rgb-jpeg-red.jpg: Added.
  • fast/images/rgb-jpeg-endian-pixels-expected.txt: Added.
  • fast/images/rgb-jpeg-endian-pixels.html: Added.
17:04 Changeset [100219] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

16:57 Changeset [100218] by gavinp@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/loader/cache/CachedResourceRequest.cpp

MERGE 71122 and 72068 simultaniously.

71122:

properly end requests when a bad status code return happens

https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.

There is a chromium test going through code review at http://codereview.chromium.org/8404001/

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

72068:

Protect Document during error responses

https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

16:51 Changeset [100217] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Expose compositeAndReadback in WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=72188

Patch by Ian Vollick <vollick@chromium.org> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebLayerTreeView.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::compositeAndReadback):

16:47 Changeset [100216] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r100192.
http://trac.webkit.org/changeset/100192
https://bugs.webkit.org/show_bug.cgi?id=72328

Caused infinite tests to fail (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
16:39 Changeset [100215] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore/rendering

Remove FixedRect stream operator and move FloatRect version back to svg/

16:34 Changeset [100214] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

div with webkit-transform + webkit-box-reflect disappears when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=53355

Reviewed by Dean Jackson.

Tickle Core Animation into updating the layer's content property when
switching back to a tab which has composited reflections. This hack is
needed becuase reflections involve sharing layer contents between layers.

  • platform/graphics/mac/WebLayer.mm:

(-[WebLayer actionForKey:]):

16:24 Changeset [100213] by abarth@webkit.org
  • 19 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.
  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

  • Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
    • Update test results to show that we no longer leak the scheme in storage identifiers.
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
    • Inline script because the sandbox iframe isn't allowed to load local resources.
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
    • Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.
16:21 Changeset [100212] by mrowe@apple.com
  • 3 edits
    5 adds in trunk/Websites/webkit.org

Upgrade WordPress's Akismet plug-in to the latest version.

  • blog/wp-content/plugins/akismet:
16:20 Changeset [100211] by jchaffraix@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
https://bugs.webkit.org/show_bug.cgi?id=72318

Reviewed by Tony Chang.

Test that covers the change for bug 72296 and also increase our flexbox coverage.

  • css3/flexbox/display-flexbox-set-get-expected.txt: Added.
  • css3/flexbox/display-flexbox-set-get.html: Added.
  • css3/flexbox/resources/display-flexbox-set-get.js: Added.
16:18 Changeset [100210] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add buffering to handle mismatch between hardware buffer size and webaudio render size
https://bugs.webkit.org/show_bug.cgi?id=71949

Patch by Raymond Toy <rtoy@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Create the FIFO for buffering.
(WebCore::AudioDestinationChromium::render): Get rid of
m_renderCountPerCallback and let the FIFO consume function produce
the appropriate nubmer of calls to the webaudio producer. Also
remove the rounding of the callback size so we use whatever the
hardware returns. Removed maximumCallbackBufferSize and use
fifoSize to set the FIFO size.
(WebCore::AudioDestinationChromium::FIFO::FIFO):
(WebCore::AudioDestinationChromium::FIFO::consume):
(WebCore::AudioDestinationChromium::FIFO::findWrapLengths):
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
Implementation of new FIFO class.

  • src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::FIFO::updateIndex):
Define new FIFO class.

16:16 Changeset [100209] by mrowe@apple.com
  • 2 edits in trunk/Websites/webkit.org

Update one file that was missed.

  • blog/wp-settings.php:
16:16 Changeset [100208] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Further changes and cleanup to JSString.h and cpp.

Reviewed by Darin Adler.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr. Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.

  • runtime/JSString.h:
16:12 Changeset [100207] by mrowe@apple.com
  • 397 edits
    21 copies
    7 moves
    230 adds
    106 deletes in trunk/Websites/webkit.org

Upgrade WordPress to v3.2.1.

  • blog:
16:05 Changeset [100206] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/AutoTableLayout.cpp

Correcting usage of intMaxForLength in AutoTableLayout.

16:04 Changeset [100205] by abarth@webkit.org
  • 15 edits
    1 copy
    1 add in trunk/Source/JavaScriptCore

DateMath.cpp should not depend on JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71747

Reviewed by Darin Adler.

This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore. There shouldn't be any behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • runtime/DateConstructor.cpp:
  • runtime/DateConversion.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DateInstanceCache.h:
  • runtime/DatePrototype.cpp:
  • runtime/InitializeThreading.cpp:
  • runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.

(JSC::timeToMS):
(JSC::msToSeconds):

  • runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
  • wtf/DateMath.cpp:

(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):

  • wtf/DateMath.h:
16:01 Changeset [100204] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Update ewk_frame_script_execute to return the result for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=65972

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-14
Reviewed by Antonio Gomes.

It executes the javascript and converts the result to a string using toString.
And it returns the memory-allocated pointer for the value.

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

  • ewk/ewk_frame.h:
16:00 Changeset [100203] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

Source/WebCore: Don't special-case "data" URLs in drag-and-drop logic
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

See the bug for more details.

Test: editing/pasteboard/drag-drop-to-data-url.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canReceiveDragData):

LayoutTests: Cross-origin drag-and-drop prevention ineffective
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

Split drag-drop-dead-frame.html into two tests: one that tests for the
previous crash and one that tests out data URL drag-and-drop behavior.

  • editing/pasteboard/drag-drop-dead-frame.html:
  • editing/pasteboard/drag-drop-to-data-url-expected.txt: Added.
  • editing/pasteboard/drag-drop-to-data-url.html: Added.
15:51 Changeset [100202] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit handling to JSString Ropes
https://bugs.webkit.org/show_bug.cgi?id=72317

Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.

Reviewed by Oliver Hunt.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):

15:33 Changeset [100201] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Round width and height when computing the scroll size (as opposed to flooring).

15:16 Changeset [100200] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

A little bit of function call cleanup
https://bugs.webkit.org/show_bug.cgi?id=72314

Reviewed by Oliver Hunt.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.

(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.

(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.

(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.

  • bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because

16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.

15:10 Changeset [100199] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Pipe compositor commit/swap up to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=72041

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didCommitAndDrawCompositorFrame):
(WebKit::WebWidgetClient::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitAndDrawFrame):
(WebKit::WebViewImpl::didCompleteSwapBuffers):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::didCommitAndDrawFrame):
(WTF::MockLayerTreeHostClient::didCompleteSwapBuffers):

14:51 Changeset [100198] by tony@chromium.org
  • 45 edits in trunk

Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSFlexValue.cpp:
  • css/CSSFlexValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:
  • rendering/style/StyleFlexibleBoxData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:47 Changeset [100197] by mrowe@apple.com
  • 3 edits
    2 copies in trunk/Source/JavaScriptCore

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
14:47 Changeset [100196] by fsamuel@chromium.org
  • 6 edits
    1 copy
    2 adds in trunk

[Chromium] setPageScaleFactor and associated methods should take scaling limits into account
https://bugs.webkit.org/show_bug.cgi?id=72176

Source/WebKit/chromium:

Reviewed by Darin Fisher.

A couple of changes:

  1. setPageScaleFactorLimits now affects the behavior of other scaling methods including setPageScaleFactor.
  2. setPageScaleFactorPreservingScrollOffset introduced that scales the scroll offset along with the page, preserving the scroll position within the page bounds.
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::computePageScaleFactorWithinLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

LayoutTests:

Reviewed by Darin Fisher.

Rebaselined some tests that broke because we now clamp pageScaleFactor to 0.25 (these test at 0.2).

Since this is a Chromium only change, the new baselines are only for Chromium.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png:
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png.
  • platform/chromium/fast/repaint/background-scaling-expected.txt: Added.
14:42 Changeset [100195] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit paths to StringImpl methods
https://bugs.webkit.org/show_bug.cgi?id=72290

Added 8 bit patchs to StringImpl to number and find methods.

Reviewed by Oliver Hunt.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

  • wtf/text/WTFString.cpp:

(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):

  • wtf/text/WTFString.h:

(WTF::find):
(WTF::reverseFind):

14:39 Changeset [100194] by scheib@chromium.org
  • 11 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPointerLockEnabled):

  • src/WebSettingsImpl.h:
14:32 Changeset [100193] by robert@webkit.org
  • 12 edits
    13 copies
    11 moves
    31 adds
    1 delete in trunk/LayoutTests

Platform-specific results for r100177

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Copied from LayoutTests/platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/multiple-captions-display-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-win/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/gtk/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/gtk/fast/table/multiple-captions-display-expected.txt:
  • platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/qt/fast/table/multiple-captions-display-expected.txt:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
14:29 Changeset [100192] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/base.py:
14:25 Changeset [100191] by commit-queue@webkit.org
  • 20 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r100176.
http://trac.webkit.org/changeset/100176
https://bugs.webkit.org/show_bug.cgi?id=72309

it broke the Mac builds (missing symbols) in a non-obvious way
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:
14:22 Changeset [100190] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Intermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
https://bugs.webkit.org/show_bug.cgi?id=72299

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-14
Reviewed by Noam Rosenthal.

Added check that clipping rect is valid.
Clear GL error that might remain from QT GL operations.
Added GL error assert for scissor test operations.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):

14:19 Changeset [100189] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Reverting lengths to being stored as pixel values for the specified zoom level and adopting an enclosingIntRect model for reporting sizes in RenderTreeAsText. This vastly lowers the number of failing layout tests on our branch.

13:56 Changeset [100188] by eae@chromium.org
  • 1569 edits
    513 copies
    162 deletes in branches/subpixellayout

Merging trunk changes up until 100042 into subpixel branch.

13:55 Changeset [100187] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

remove -wap-marquee css propery value
https://bugs.webkit.org/show_bug.cgi?id=72296

Reviewed by Adam Barth.

This css value is no longer used.

  • css/CSSValueKeywords.in:
13:49 Changeset [100186] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

JS Test Harness: Remove one more reference to non existing js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=72307

Reviewed by Ojan Vafai.

  • storage/indexeddb/mozilla/delete-result.html:
13:48 Changeset [100185] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Only send progress notifications for the main frame
https://bugs.webkit.org/show_bug.cgi?id=72302

Reviewed by Sam Weinig.

Since it's impossible in the API to tell which frame the progress notifications are for, just send them to the main frame for now.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

13:45 Changeset [100184] by jchaffraix@webkit.org
  • 2 edits in trunk/Tools

[Chromium] build-webkit silently drops the features flags
https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

  • Scripts/build-webkit: Check if one of the features is different

from the default and print a warning in this case.

13:21 Changeset [100183] by jchaffraix@webkit.org
  • 4 edits
    6 adds in trunk

Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

  • fast/table/crash-splitColumn-2-expected.txt: Added.
  • fast/table/crash-splitColumn-2.html: Added.
  • fast/table/crash-splitColumn-3-expected.txt: Added.
  • fast/table/crash-splitColumn-3.html: Added.
  • fast/table/crash-splitColumn-expected.txt: Added.
  • fast/table/crash-splitColumn.html: Added.
12:58 Changeset [100182] by abarth@webkit.org
  • 6 edits in trunk/Source

Remove the concept of an empty SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72287

Reviewed by Eric Seidel.

Source/WebCore:

This concept is fragile and doesn't exist in the specs. Previous
patches have removed most of the code relying upon this function. This
patch removes a couple stragglers.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

  • This check should really be about unique origins because it doesn't make sense to target postMessages at unique origins, as explained in the comment.
  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:

Source/WebKit/chromium:

I'll rename the API in a subsequent patch.

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isEmpty):

12:56 Changeset [100181] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityContext::isSecureTransitionTo should not refer to empty security origins
https://bugs.webkit.org/show_bug.cgi?id=72277

Reviewed by Eric Seidel.

Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

12:50 Changeset [100180] by scheib@chromium.org
  • 19 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
  • page/MouseLockable.cpp:
  • page/MouseLockable.h:
  • page/MouseLockable.idl:
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMouseLockEnabled):

12:48 Changeset [100179] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; skipping newly failing tests which need rebaselining.

Added skipped tests; tracked by https://bugs.webkit.org/show_bug.cgi?id=72297.

  • platform/gtk/Skipped:
12:46 Changeset [100178] by annacc@chromium.org
  • 6 edits
    2 deletes in trunk/Source/WebCore

Remove TextTrackCueIndex and TextTrackCueSet. No longer needed.
https://bugs.webkit.org/show_bug.cgi?id=72216

Reviewed by Sam Weinig.

No new tests. No new functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCueIndex.cpp: Removed.
  • html/TextTrackCueIndex.h: Removed.
12:41 Changeset [100177] by robert@webkit.org
  • 15 edits
    21 adds in trunk

CSS 2.1 failure: border-spacing-applies-to-015.htm
https://bugs.webkit.org/show_bug.cgi?id=69773

Reviewed by David Hyatt.

Source/WebCore:

The CSS test suite expects UAs to allow multiple captions per table.
Replace m_caption with a Vector called m_captions.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
(WebCore::RenderTable::adjustLogicalHeightForCaption):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::subtractCaptionRect):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::nextColElement):
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::recalcCaption):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTable.h:

LayoutTests:

  • css2.1/20110323/border-spacing-applies-to-015.htm: Added. Now passes!
  • css2.1/20110323/table-caption-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-002.htm: Added. Now passes!
  • css2.1/20110323/table-caption-horizontal-alignment-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-margins-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-002.htm: Added. Passed anyway.
  • fast/table/dynamic-caption-add-before-child.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • fast/table/multiple-captions-crash-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-crash2-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-display.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Result reflects extra captions.
  • platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Result reflects extra captions.
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png: Result reflects extra caption.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt: Result reflects extra caption.
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt: Result reflects extra caption.
12:24 Changeset [100176] by commit-queue@webkit.org
  • 20 edits
    1 copy
    2 adds in trunk/Source

Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <gman@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.

(WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::getName):
(WebCore::WebGLExperimentalCompressedTextures::create):
(WebCore::WebGLExperimentalCompressedTextures::supported):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):

  • html/canvas/WebGLExperimentalCompressedTextures.h: Added.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

12:23 Changeset [100175] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=72280

Rubber stamped by Geoff Garen.

Fix 32-bit Lion.

(WTF::OSAllocator::reserveAndCommit):

12:08 Changeset [100174] by ddkilzer@apple.com
  • 2 edits
    4 adds in trunk/Tools

run-leaks does not work on Lion?
<http://webkit.org/b/71059>
<rdar://problem/10428527>

Reviewed by Adam Roben.

The output of leaks(1) changed again in Lion to move the
"leaks Report Version: 2.0" line from the first line of the
output to just above the "Process " lines that run-leaks is
interested in parsing. This required using a more generic
algorithm to find the start of the "Process " lines.

  • Scripts/run-leaks:

(parseLeaksOutput): Make the code to skip headers more generic.

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
12:04 Changeset [100173] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=72116

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamSource.h:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):

  • src/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::operator=):

11:46 Changeset [100172] by michaeln@google.com
  • 32 edits in trunk

Source/WebCore: Return more complete error and exception messages when a
WebSQLDatabase function fails. Produce console logging
for openDatabase() errors and vacuum errors. Add a lastErrorMessage
accessor to the DatabaseSync interface.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

Yes, see LayoutTests/ChangeLog in this patch.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastError):
(WebCore::SQLiteDatabase::lastErrorMsg):
(WebCore::SQLiteDatabase:: runVacuumCommand):
(WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
Reflect errors in the open() method in lastError() and lastErrorMsg().
Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().

  • platform/sql/SQLiteDatabase.h:
  • storage/AbstractDatabase.cpp:

(WebCore::formatErrorMessage):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::logErrorMessage):
During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
and the sqlite error message. Add a helper to log message to the console.

  • storage/AbstractDatabase.h:
  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:

(WebCore::DatabaseSync::lastErrorMessage):
(WebCore::DatabaseSync::setLastErrorMessage):

  • storage/DatabaseSync.idl:

Add a lastErrorMessage attribute so javascript callers can
retrieve more detailed information about what went wrong.

  • storage/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
Return an errorMessage in addition to the exception code.

  • storage/SQLError.h:

(WebCore::SQLError::create):
Add helpers to produced formatted error messages.

  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatementSync.cpp:

(WebCore::SQLStatementSync::execute):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):

LayoutTests: Update layout tests for new websql error messages and console logging.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync.html:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt:
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt:
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
  • fast/workers/storage/test-authorizer-expected.txt:
  • fast/workers/storage/transaction-in-transaction-sync.html:
  • fast/workers/storage/transaction-in-transaction-sync-expected.txt:
  • storage/change-version-handle-reuse-expected.txt:
  • storage/open-database-creation-callback-expected.txt:
  • storage/open-database-set-empty-version-expected.txt:
  • storage/private-browsing-noread-nowrite-expected.txt:
  • storage/test-authorizer-expected.txt:
11:44 Changeset [100171] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.

For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.

  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

11:39 Changeset [100170] by abarth@webkit.org
  • 1 edit in trunk/Source/WebCore/dom/Document.cpp

Fix typo.

11:33 Changeset [100169] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72283

Reviewed by Sam Weinig.

This change aligns our implementation more closely with the spec. I
don't think this change has an observable effects, but it moves us
closer to removing the concept of an empty security origin.

  • dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):
(WebCore::Document::initSecurityContext):

11:26 Changeset [100168] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unused m_data member from UStringSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=72289

Removed unused m_data member from UStringSourceProvider.

Reviewed by Oliver Hunt.

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::UStringSourceProvider):

11:25 Changeset [100167] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Towards 8 Bit Strings: Templatize YARR Parser
https://bugs.webkit.org/show_bug.cgi?id=72288

Changed Yarr::Parser to be a template based on character type.

Reviewed by Oliver Hunt.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

11:23 Changeset [100166] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit build fix: Removed unused declaration.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

11:21 Changeset [100165] by ggaren@apple.com
  • 31 edits in trunk/Source/JavaScriptCore

Standardized the JS calling convention
https://bugs.webkit.org/show_bug.cgi?id=72221

Reviewed by Oliver Hunt.

This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.

This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):

(1) 1% benchmark speedup across the board.

(2) 50% code size reduction in baseline JIT function calls.

(3) 1.5x speedup for single-dispatch .apply forwarding.

(4) 1.1x speedup for multi-dispatch .apply forwarding.

This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.

(JSC::CallLinkInfo::unlink):

  • bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows

us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.
  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.

Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.

  • dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before

doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.

  • interpreter/Interpreter.cpp: Let the true code bomb begin!

(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.

(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.

(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.

(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)

op_call_eval: Updated for new, standard eval calling convention.

op_load_varargs: Merged op_load_varargs into op_call_varargs.

op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.

  • interpreter/Interpreter.h:

(JSC::Interpreter::execute): Headers are fun and educational!

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.

(JSC::JIT::linkFor): Link even if we miss on argument count, as above.

  • jit/JIT.h:
  • jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)

(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.

This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.

Added a shared path for calling out to CTI helper functions for non-JS
calls.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)

(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.

  • runtime/Arguments.h:

(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)

11:14 Changeset [100164] by arv@chromium.org
  • 16 edits
    6 deletes in trunk

Remove getParameter from HTMLAnchorElement and Location
https://bugs.webkit.org/show_bug.cgi?id=71966

Reviewed by Adam Barth.

Source/WebCore:

  • html/HTMLAnchorElement.cpp: Removed getParameter.
  • html/HTMLAnchorElement.h: Ditto.
  • html/HTMLAnchorElement.idl: Ditto.
  • page/Location.cpp: Ditto.
  • page/Location.h: Ditto.
  • page/Location.idl: Ditto.

LayoutTests:

  • fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
  • fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/anchor-getParameter-expected.txt: Removed.
  • fast/dom/anchor-getParameter.html: Removed.
  • http/tests/misc/location-getParameter-expected.txt: Removed.
  • http/tests/misc/location-getParameter.html: Removed.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
11:11 Changeset [100163] by arv@chromium.org
  • 22 edits
    2 adds in trunk

Remove RequiresAllArguments
https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Remove RequiresAllArguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
  • page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
  • websockets/WebSocket.idl: Comment changes only.

LayoutTests:

  • fast/dom/Window/window-resize-and-move-arguments-expected.txt:
  • fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
  • fast/dom/Window/window-scroll-arguments-expected.txt:
  • fast/dom/Window/window-scroll-arguments.html: Ditto.
  • fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
  • fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.
10:06 Changeset [100162] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=72114

Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler
to PeerConnectionHandlerInternal.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Adam Barth.

  • bridge/PeerConnectionHandlerInternal.cpp:

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

  • public/WebKitPlatformSupport.h:
09:59 Changeset [100161] by lforschler@apple.com
  • 1 copy in tags/Safari-534.52.11

New tag.

09:56 Changeset [100160] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
https://bugs.webkit.org/show_bug.cgi?id=72088

Patch by Lei Zhang <thestig@chromium.org> on 2011-11-14
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
09:55 Changeset [100159] by jer.noble@apple.com
  • 32 edits
    3 copies
    7 adds in trunk

Implement MediaController.
https://bugs.webkit.org/show_bug.cgi?id=71408

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.

  • wtf/Platform.h:

Source/WebCore:

Tests: media/media-controller-playback.html

media/media-controller.html

Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
HTMLMediaElement attributes.

MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
either be created by a page script and assigned to a HTMLMediaElement using the controller property,
or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned
automatically.

Add an abstract interface implemented by both MediaController and HTMLMediaElement.

  • html/MediaControllerInterface.h: Added.

(WebCore::MediaControllerInterface::~MediaControllerInterface):

Add the MediaController object and IDL.

  • html/MediaController.cpp: Added.

(mediaGroupToMediaControllerMap):
(MediaController::mediaControllerForMediaGroup):
(MediaController::create):
(MediaController::MediaController):
(MediaController::~MediaController):
(MediaController::addMediaElement):
(MediaController::removeMediaElement):
(MediaController::containsMediaElement):
(MediaController::buffered):
(MediaController::seekable):
(MediaController::played):
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::pause):
(MediaController::setDefaultPlaybackRate):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(MediaController::reportControllerState):
(MediaController::updateReadyState):
(MediaController::updatePlaybackState):
(MediaController::updateMediaElements):
(MediaController::scheduleEvent):
(MediaController::asyncEventTimerFired):
(MediaController::scriptExecutionContext):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasSource):
(MediaController::returnToRealtime):
(MediaController::isBlocked):
(MediaController::hasEnded):

  • html/MediaController.h: Added.

(WebCore::MediaController::mediaGroup):
(WebCore::MediaController::paused):
(WebCore::MediaController::defaultPlaybackRate):
(WebCore::MediaController::playbackRate):
(WebCore::MediaController::volume):
(WebCore::MediaController::muted):
(WebCore::MediaController::readyState):
(WebCore::MediaController::playbackState):
(WebCore::MediaController::supportsFullscreen):
(WebCore::MediaController::isFullscreen):
(WebCore::MediaController::enterFullscreen):
(WebCore::MediaController::closedCaptionsVisible):
(WebCore::MediaController::refEventTarget):
(WebCore::MediaController::derefEventTarget):
(WebCore::MediaController::toMediaController):
(WebCore::MediaController::eventTargetData):
(WebCore::MediaController::ensureEventTargetData):

  • html/MediaController.idl: Added.

Add convenience functions to TimeRanges which can calculate intersections and
unions between TimeRanges objects.

  • html/TimeRanges.cpp:

(TimeRanges::copy):
(TimeRanges::invert):
(TimeRanges::intersectWith):
(TimeRanges::unionWith):

  • html/TimeRanges.h:

Add MediaControllerConstructor to the Window object.

  • page/DOMWindow.idl:

Add the two new attribute names, mediagroup and controller.

  • html/HTMLAttributeNames.in:

Add support for the new attributes, and add overridden behavior when a media element
has a current media controller:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setCurrentTime):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::potentiallyPlaying):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::mediaGroup):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::controller):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::updateMediaController):
(WebCore::HTMLMediaElement::isBlockedOnMediaController):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hasSource):
(WebCore::HTMLMediaElement::isLiveStream):

  • html/HTMLMediaElement.idl:
  • bindings/js/JSHTMLMediaElementCustom.cpp: Added.

(WebCore::JSHTMLMediaElement::setMediaController):

Add convenience functions to store a mapping of media-elements-per-document to allow
a quick lookup of media elements with the same media group within a given document:

  • html/HTMLMediaElement.cpp:

(WebCore::documentToElementSetMap):
(WebCore::addElementToDocumentMap):
(WebCore::removeElementFromDocumentMap):

Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
in a media element. By default this is a single range of [0, maxTimeSeekable].

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::seekable):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable):

Support functions to cast between MediaController and EventTarget.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toMediaController):

  • dom/EventTarget.h:

Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
ClockGeneric::currentTime:

  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
(ClockGeneric::now):

  • platform/ClockGeneric.h:

Boilerplate to support creating the derived sources for MediaController and adding new sources
to the project:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • media/media-controller-expected.txt: Added.
  • media/media-controller-playback-expected.txt: Added.
  • media/media-controller-playback.html: Added.
  • media/media-controller.html: Added.
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
09:44 Changeset [100158] by scherkus@chromium.org
  • 4 edits in trunk

[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
https://bugs.webkit.org/show_bug.cgi?id=72147

Reviewed by Adam Barth.

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
09:31 Changeset [100157] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Multiple foreign objects not rendered
https://bugs.webkit.org/show_bug.cgi?id=72151

Patch by Florin Malita <fmalita@google.com> on 2011-11-14
Reviewed by Adam Barth.

Source/WebCore:

SVG end tags need to be case-adjusted (just like their start counterparts).

Test: svg/foreignObject/multiple-foreign-objects.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/runner-expected.txt: Rebaselined.
  • platform/chromium/html5lib/runner-expected.txt: Rebaselined.
  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Rebaselined.
  • svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
  • svg/foreignObject/multiple-foreign-objects.html: Added.
09:29 Changeset [100156] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Flaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
https://bugs.webkit.org/show_bug.cgi?id=59771

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
09:16 Changeset [100155] by alexis.menard@openbossa.org
  • 2 edits
    10 moves
    2 adds
    7 deletes in trunk/Source/WebKit2

[Qt][WK2] Cleanup QML tests.
https://bugs.webkit.org/show_bug.cgi?id=72259

Reviewed by Simon Hausmann.

Cleanup QML tests. This patch removes the duplicates after the merge of both views.
I also isolated the desktop specific bits into its own directory.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
09:10 Changeset [100154] by lforschler@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merge r100022.

09:05 Changeset [100153] by mario@webkit.org
  • 7 edits in trunk/Source

Add support for the caretBrowsingEnabled preference in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72266

Reviewed by Chris Fleizach.

Source/WebCore:

  • WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.

Source/WebKit2:

  • Shared/WebPreferencesStore.h: Add caretBrowsingEnabled getter

and setter macro.

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCaretBrowsingEnabled): Added.
(WKPreferencesGetCaretBrowsingEnabled): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the
caretBrowsingEnabledKey preference.

09:01 Changeset [100152] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Remove dependency on pthread from FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=72098

Reviewed by Adam Roben.

All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.

  • wtf/FastMalloc.cpp:
08:59 Changeset [100151] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
08:56 Changeset [100150] by lforschler@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

08:52 Changeset [100149] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
08:45 Changeset [100148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove expected crashes for skia-gpu canvas from test expectations
https://bugs.webkit.org/show_bug.cgi?id=72183

Patch by Brian Salomon <bsalomon@google.com> on 2011-11-14
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
08:41 Changeset [100147] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
08:30 Changeset [100146] by fsamuel@chromium.org
  • 10 edits in trunk/Source

[chromium] Plumb through partial swap
https://bugs.webkit.org/show_bug.cgi?id=72028

Patch by Jonathan Backer <backer@chromium.org> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):

08:29 Changeset [100145] by caseq@chromium.org
  • 16 edits
    1 delete in trunk

Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
https://bugs.webkit.org/show_bug.cgi?id=72268

Reviewed by Pavel Feldman.

Source/WebCore:

  • replace IFrameView with ExtensionView;
  • inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
  • move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
  • expose iframe's window object in the onShow event handler.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI):
(injectedExtensionAPI.PanelWithSidebarImpl):
(injectedExtensionAPI.ExtensionPanelImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionView.prototype.wasShown):
(WebInspector.ExtensionView.prototype.willHide):
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.notifyViewShown):
(WebInspector.ExtensionServer.prototype.notifyViewHidden):
(WebInspector.ExtensionServer.prototype._onCreatePanel):

  • inspector/front-end/IFrameView.js: Removed.
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt:
08:22 Changeset [100144] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Try to make the bot green.

07:56 Changeset [100143] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: add 'Show function definition' context menu item for function values
https://bugs.webkit.org/show_bug.cgi?id=72265

Allow navigating to JavaScript function definition using context menu.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):

  • inspector/front-end/inspector.js:

(WebInspector.showPanelForAnchorNavigation):

07:44 Changeset [100142] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: update platform/gtk/Skipped because a newly-added
failing test is due to general accessibility testing issues
on GTK, not due to this particular test.
https://bugs.webkit.org/show_bug.cgi?id=72249

07:33 Changeset [100141] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] security/crypto-random-values-types.html is flaky on win
https://bugs.webkit.org/show_bug.cgi?id=72272

  • platform/chromium/test_expectations.txt: Mark test as flaky.
07:17 Changeset [100140] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=72271

  • platform/chromium/test_expectations.txt: Expect test to crash sometimes.
06:58 UsingGitWithWebKit edited by aroben@apple.com
Added some tips for breaking up large patches (diff)
06:53 Changeset [100139] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-cues-cuechange.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72269

  • platform/chromium/test_expectations.txt: Mark test as flaky.
06:29 Changeset [100138] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping passing test.

  • platform/chromium/test_expectations.txt:
06:14 Changeset [100137] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: console's protocol payload does not have url and line properties.
https://bugs.webkit.org/show_bug.cgi?id=72256

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-url-and-line.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):

LayoutTests:

  • inspector/console/console-url-and-line-expected.txt: Added.
  • inspector/console/console-url-and-line.html: Added.
  • inspector/protocol/console-agent-expected.txt:
06:06 Changeset [100136] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Two inspector tests timeout on mac
https://bugs.webkit.org/show_bug.cgi?id=72264

  • platform/chromium/test_expectations.txt: Expect appcache-iframe-manifests and script-formatter to timeout on mac.
06:03 Changeset [100135] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [regression r99960] null callback access.
https://bugs.webkit.org/show_bug.cgi?id=72263

Reviewed by Yury Semikhatsky.

  • inspector/CodeGeneratorInspector.py:
05:19 Changeset [100134] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Unbreak the build on Mac OS X

QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
that's been fixed in Qt we have to use the same guards in WebKit, not
Q_OS_MAC.

05:19 Changeset [100133] by vestbo@webkit.org
  • 4 edits
    1 move
    1 add in trunk

[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

05:06 Changeset [100132] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

  • qmake/mkspecs/features/features.prf:
05:01 Changeset [100131] by hausmann@webkit.org
  • 4 edits in trunk/Source

[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • wtf/qt/compat/qguiapplication.h:

(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

04:58 Changeset [100130] by vestbo@webkit.org
  • 4 edits
    2 adds in trunk/Tools

[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

04:46 Changeset [100129] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove reference to QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p.h:
04:44 Changeset [100128] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.
04:41 Changeset [100127] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

04:20 Changeset [100126] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

  • UseV8.cmake: Added.
03:55 Changeset [100125] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] the QQuickWebView should support double-tap to zoom
https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

03:52 Changeset [100124] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-test.js:

(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • platform/chromium/test_expectations.txt:
03:49 Changeset [100123] by hausmann@webkit.org
  • 14 edits
    4 adds
    2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
03:49 Changeset [100122] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
03:24 Changeset [100121] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Possible crash when destroying after called widgetSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::chromeDestroyed):

03:15 Changeset [100120] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

  • platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.
02:53 Changeset [100119] by tonyg@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r100116.
http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

  • Scripts/run-bindings-tests:
02:48 Changeset [100118] by tonyg@chromium.org
  • 18 edits in trunk/Tools

Unreviewed, rolling out r100104.
http://trac.webkit.org/changeset/100104
https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
02:26 Changeset [100117] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

SecurityContext should track whether the SecurityOrigin has been initialized
https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized. In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):

  • dom/SecurityContext.h:

(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

02:00 Changeset [100116] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, build fix after r100104. run-binding-tests broke.

  • Scripts/run-bindings-tests: Explicitely use scm.detection.
01:50 Changeset [100115] by carlosgc@webkit.org
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
01:40 Changeset [100114] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Give HTML ContextMenu a more Native look
https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-14
Reviewed by Pavel Feldman.

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

  • inspector/front-end/inspector.css:

(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

01:27 Changeset [100113] by yurys@chromium.org
  • 16 edits
    3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

(JSC::JSFunction::sourceCode):

  • runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
01:25 Changeset [100112] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r100050
https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-11-14

  • platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html
01:18 Changeset [100111] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.
01:16 Changeset [100110] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

01:14 Changeset [100109] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Build breaks with --no-javascript-debugger --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

  • workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

00:27 Changeset [100108] by haraken@chromium.org
  • 16 edits
    1 delete in trunk/Source/WebCore

Remove all custom constructors of Events in V8
https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

  • Target.pri: Removed V8EventConstructors.cpp.
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/OverflowEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • dom/WebKitTransitionEvent.idl: Ditto.
  • html/track/TrackEvent.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
00:23 BuildingQtOnLinux edited by ossy@webkit.org
(diff)
00:20 Changeset [100107] by philn@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 2 new svg tests.

  • platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
00:16 Changeset [100106] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

[WX] Make FontPlatformData::m_size private
https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

  • platform/graphics/wx/FontPlatformData.h:
00:15 Changeset [100105] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 tests failing on GTK and 2 flaky crashers.

  • platform/gtk/Skipped:
00:07 Changeset [100104] by eric@webkit.org
  • 18 edits in trunk/Tools

Add SCMDetector object to make scm detection mockable
https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

11/13/11:

23:57 Changeset [100103] by ossy@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r100036.

  • platform/qt/svg/foreignObject/clip-expected.png: Added.
  • platform/qt/svg/foreignObject/clip-expected.txt: Added.
  • platform/qt/svg/foreignObject/filter-expected.png: Added.
  • platform/qt/svg/foreignObject/filter-expected.txt: Added.
  • platform/qt/svg/foreignObject/mask-expected.png: Added.
  • platform/qt/svg/foreignObject/mask-expected.txt: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.
23:57 Changeset [100102] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Document::initSecurityOrigin should return earlier more often
https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

23:53 Changeset [100101] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityPolicy should refer to isUnique rather than isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time. Previously, this code checked
for empty origins, which are technically a subset of unique origins. I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

23:50 Changeset [100100] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Move isSecureTransitionTo from SecurityOrigin to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

  • dom/SecurityContext.h:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
21:14 Changeset [100099] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

19:06 Changeset [100098] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebFileChooserParams::acceptTypes
https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h: Remove acceptTypes.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

16:02 Changeset [100097] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

  • ewk/ewk_view.h:
15:03 Changeset [100096] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Simplify eina_stringshare usage in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

14:44 Changeset [100095] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix silent spilling/filling GPRs in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

13:30 Changeset [100094] by gavinp@chromium.org
  • 2 edits in trunk/Tools

command line control of webcore log channels in chromium DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

13:05 Changeset [100093] by scheib@chromium.org
  • 3 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

09:43 Changeset [100092] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

  • css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

  • fast/media/update-media-query-css-parser-expected.txt: Added.
  • fast/media/update-media-query-css-parser.html: Added.
07:26 Changeset [100091] by scheib@chromium.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
06:53 Changeset [100090] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebCore

Only HTMLAllCollection needs stateful named item traversal.
<http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

  • html/HTMLCollection.h:

Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
Promoted itemAfter() and checkForNameMatch() to protected methods so
they can be called from HTMLAllCollection.

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):

  • html/HTMLFormCollection.h:
01:28 Changeset [100089] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

00:09 Changeset [100088] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Update binding generator tests to use jsCast
https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

11/12/11:

23:40 Changeset [100087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r100038.
http://trac.webkit.org/changeset/100038
https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

  • platform/qt/ScrollbarThemeQt.h:
20:37 Changeset [100086] by laszlo.1.gombos@nokia.com
  • 29 edits in trunk/Source

[Qt][Symbian] Remove support for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

  • API/JSStringRef.h:
  • create_hash_table: Revert r45553.
  • runtime/JSGlobalData.cpp: Revert r45553.
  • runtime/LiteralParser.cpp: Remove WINSCW comment.

(JSC::LiteralParser::Lexer::lexString):

  • runtime/Lookup.h: Revert r45553.
  • runtime/Structure.h: Revert r48461.
  • wtf/Alignment.h:
  • wtf/Assertions.h: Revert r52337.
  • wtf/Compiler.h:
  • wtf/ListRefPtr.h: Revert r48988.

(WTF::ListRefPtr::~ListRefPtr):

  • wtf/OwnArrayPtr.h: Revert r45911.

(WTF::OwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassOwnArrayPtr.h:

(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassRefPtr.h:
  • wtf/StaticConstructors.h:
  • wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

(WebCore::CachedResourceHandle::CachedResourceHandle):

  • rendering/style/RenderStyle.h: Revert r52733.

(compareEqual):

  • bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

  • Shared/API/c/WKString.h:
16:47 Changeset [100085] by annacc@chromium.org
  • 6 edits
    58 adds in trunk

Add WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html

media/track/track-webvtt-tc001-utf8.html
media/track/track-webvtt-tc002-bom.html
media/track/track-webvtt-tc003-newlines.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc010-no-timings.html
media/track/track-webvtt-tc011-blank-lines.html
media/track/track-webvtt-tc012-out-of-order.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc014-alignment.html
media/track/track-webvtt-tc015-positioning.html
media/track/track-webvtt-tc016-align-positioning.html
media/track/track-webvtt-tc017-line-position.html
media/track/track-webvtt-tc018-align-text-line-position.html
media/track/track-webvtt-tc019-cue-size.html
media/track/track-webvtt-tc020-cue-size-align.html
media/track/track-webvtt-tc021-valign.html
media/track/track-webvtt-tc022-entities.html
media/track/track-webvtt-tc023-markup.html
media/track/track-webvtt-tc024-timestamp.html
media/track/track-webvtt-tc025-class-markup.html
media/track/track-webvtt-tc026-voice.html
media/track/track-webvtt-tc027-empty-cue.html
media/track/track-webvtt-tc028-unsupported-markup.html

  • html/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.

  • html/TextTrack.h: The cues() function can no longer be const.
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after

all other startTimes in the list.

LayoutTests:

  • media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
15:27 Changeset [100084] by nduca@chromium.org
  • 4 edits in trunk/Source/WebCore

Fixes to GraphicsContext3D::makeCurrent on gtk and mac
https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

14:13 Changeset [100083] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

10:43 Changeset [100082] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

  • dfg/DFGCorrectableJumpPoint.cpp:
  • dfg/DFGCorrectableJumpPoint.h:
09:30 Changeset [100081] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
08:14 Changeset [100080] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

05:51 Changeset [100079] by paroga@webkit.org
  • 6 edits in trunk/Source/WebCore

Add stub implementation for SVGResources::filter()
https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::selfWillPaint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::selfWillPaint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

05:33 Changeset [100078] by antti@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r98542): Rendering error on Google maps
https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

  • fast/css/vertical-align-length-copy-bug-expected.txt: Added.
  • fast/css/vertical-align-length-copy-bug.html: Added.
04:01 Changeset [100077] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix minor config typo in the build tool documentation
https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

  • qmake/README:
03:09 Changeset [100076] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r100013.
http://trac.webkit.org/changeset/100013
https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLTextAreaElement.idl:

LayoutTests:

  • fast/forms/access-key-for-all-elements-expected.txt: Removed.
  • fast/forms/access-key-for-all-elements.html: Removed.
02:39 Changeset [100075] by zimmermann@webkit.org
  • 24 edits in trunk/Source/WebCore

2011-11-12 Nikolas Zimmermann <nzimmermann@rim.com>

Finish SVGLengthContext conversion in svg/
https://bugs.webkit.org/show_bug.cgi?id=72105

Reviewed by Antti Koivisto.

Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
Now that this process is finished, SVGLengthContext can be shared across renders,
so that its possible to override the length context in a single place. This will
be done in future patches.

Doesn't affect any tests yet.

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::containerTranslation):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • svg/SVGElement.h:
  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::currentViewBoxRect):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
00:52 Changeset [100074] by paroga@webkit.org
  • 2 edits in trunk

[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

  • Source/cmake/WebKitMacros.cmake:
00:40 Changeset [100073] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(FILTERS) after r100036.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

11/11/11:

23:57 Changeset [100072] by paroga@webkit.org
  • 8 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header.
https://bugs.webkit.org/show_bug.cgi?id=72115

Unreviewed. Add missing includes to fix build without precompiled header.

  • platform/ContextMenu.h:
  • platform/graphics/win/DIBPixelData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/network/cf/ResourceError.h:
  • platform/win/LanguageWin.cpp:
  • platform/win/LocalizedStringsWin.cpp:
  • platform/win/LoggingWin.cpp:
23:11 Changeset [100071] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/72205> Remove Duplicate Symbol Exports

Reviewed by Dan Bernstein.

  • WebCore.exp.in: Remove duplicate symbols listed.

Each dup in this case was already always exported.

21:24 Changeset [100070] by thakis@chromium.org
  • 11 edits in trunk/Source

[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/DebuggerAgentManager.cpp:

(WebKit::DebuggerAgentManager::debugHostDispatchHandler):
(WebKit::DebuggerAgentManager::onWebViewClosed):

  • src/DebuggerAgentManager.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

  • src/WebViewImpl.cpp:

(WebKit::pageGroupLoadDeferrerStack):
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):

20:48 Changeset [100069] by ojan@chromium.org
  • 2 edits
    2 moves
    16 adds in trunk/LayoutTests

Chromium layout test rebaselines after http://trac.webkit.org/changeset/100045
and http://trac.webkit.org/changeset/100036.

Also add line for failing text test after http://trac.webkit.org/changeset/99963.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/clip-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/filter-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/mask-expected.txt: Added.
  • platform/chromium-win/svg/repaint/filter-child-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png.
  • platform/chromium/svg/foreignObject/clip-expected.txt: Added.
  • platform/chromium/svg/foreignObject/filter-expected.txt: Added.
  • platform/chromium/svg/foreignObject/mask-expected.txt: Added.
  • platform/chromium/svg/repaint/filter-child-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt.
  • platform/chromium/test_expectations.txt:
20:45 Changeset [100068] by nduca@chromium.org
  • 10 edits in trunk/Source

Since GraphicsContext3D::makeContextCurrent can fail, return bool.

https://bugs.webkit.org/show_bug.cgi?id=72101

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:
20:40 Changeset [100067] by ojan@chromium.org
  • 4 edits
    6 deletes in trunk

Source/WebCore: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::appendColumn):

LayoutTests: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

  • fast/table/crash-splitColumn-2-expected.txt: Removed.
  • fast/table/crash-splitColumn-2.html: Removed.
  • fast/table/crash-splitColumn-3-expected.txt: Removed.
  • fast/table/crash-splitColumn-3.html: Removed.
  • fast/table/crash-splitColumn-expected.txt: Removed.
  • fast/table/crash-splitColumn.html: Removed.
20:28 Changeset [100066] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
https://bugs.webkit.org/show_bug.cgi?id=72200

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

How did I get here I am not good with computers.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionCommit):

20:23 Changeset [100065] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

  • accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
  • accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.
19:37 Changeset [100064] by annacc@chromium.org
  • 19 edits
    8 adds in trunk

Storage and retrieval of TextTrackCues during video playback, including
cuechange, enter, and exit events.
https://bugs.webkit.org/show_bug.cgi?id=70452

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-cues-cuechange.html

media/track/track-cues-enter-exit.html
media/track/track-cues-seeking.html

Add cuechange, enter, and exit events and make TextTrack and
TextTrackCue EventTargets:

  • dom/EventNames.h:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTimerFired):

Use scheduleLoad() instead of configureTextTracks() to start an async load.

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Updates the list of currently active cues during playback.

(WebCore::HTMLMediaElement::textTrackAddCues):

Adds cues to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCues):

Removes cues from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::textTrackAddCue):

Adds a cue to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCue):

Removes a cue from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::playbackProgressTimerFired):

Update the active TextTrackCues when playbackProgressTimerFired.

(WebCore::HTMLMediaElement::addTrack):

Pass along a ScriptExecutionContext to TextTrack::create().

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

Update the active TextTrackCues when the media player time changes.

  • html/HTMLMediaElement.h:

Use a PodIntervalTree cueTree to store and retrieve TextTrackCues
during playback.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::LoadableTextTrack::fireCueChangeEvent):

Fire a cue change event on this TextTrack's <track>

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):

Return a TextTrackCueList that represents the currently active cues.

(WebCore::TextTrack::fireCueChangeEvent):

Fires a cue change event.

  • html/TextTrack.h:

(WebCore::TextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/TextTrack.idl:

Makes TextTrack extend EventTarget interface and add oncuechange.

  • html/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):

TextTrackCue should extend EventTarget, not ActiveDOMObject.

(WebCore::TextTrackCue::isActive):
(WebCore::TextTrackCue::setIsActive):

Dispatch an enter or exit event depending on active state and notify
the corresponding track to fire a cuechange event.

The following are needed for EventTarget interface:
(WebCore::TextTrackCue::interfaceName):
(WebCore::TextTrackCue::scriptExecutionContext):
(WebCore::TextTrackCue::eventTargetData):
(WebCore::TextTrackCue::ensureEventTargetData):

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::refEventTarget):
(WebCore::TextTrackCue::derefEventTarget):

  • html/TextTrackCue.idl:

Extend EventTarget and add onenter and onexit.

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::activeCues):

Update and return the list of currently active cues.

(WebCore::TextTrackCueList::clear):

Clear the cues from list (needed to return same object each time).

  • html/TextTrackCueList.h:

The following are needed for EventTarget interface:

  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::interfaceName):
(WebCore::TrackBase::scriptExecutionContext):
(WebCore::TrackBase::eventTargetData):
(WebCore::TrackBase::ensureEventTargetData):

  • html/track/TrackBase.h:

(WebCore::TrackBase::refEventTarget):
(WebCore::TrackBase::derefEventTarget):

LayoutTests:

  • media/track/captions-webvtt/cues-chrono-order.vtt: Added.
  • media/track/captions-webvtt/cues-overlapping.vtt: Added.
  • media/track/track-cues-cuechange-expected.txt: Added.
  • media/track/track-cues-cuechange.html: Added.
  • media/track/track-cues-enter-exit-expected.txt: Added.
  • media/track/track-cues-enter-exit.html: Added.
  • media/track/track-cues-seeking-expected.txt: Added.
  • media/track/track-cues-seeking.html: Added.
19:29 Changeset [100063] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused variable added by r99813.
https://bugs.webkit.org/show_bug.cgi?id=72199

Patch by David Reveman <reveman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

19:15 Changeset [100062] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.
https://bugs.webkit.org/show_bug.cgi?id=72174

  • DEPS:
18:58 Changeset [100061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

18:56 Changeset [100060] by jamesr@google.com
  • 14 edits in trunk/Source

Rollout http://trac.webkit.org/changeset/99844
Solution is more complicated than the problem it was intended to solve.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

18:53 Changeset [100059] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

Revert Page to operate on integers
https://bugs.webkit.org/show_bug.cgi?id=72185

Reviewed by Eric Seidel.

Reverting the page classes to integers from LayoutUnits. It's not necessary to expose
LayoutUnits in these classes, so we'll avoid doing so.

No new tests, no change in behavior.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):

  • page/EventHandler.h:
  • page/Frame.cpp:

(WebCore::Frame::documentAtPoint):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::create):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • page/Page.h:
  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

18:24 Changeset [100058] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Updating the expected value, missed in r81312
https://bugs.webkit.org/show_bug.cgi?id=72170

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2011-11-11
Reviewed by Daniel Bates.

  • fast/viewport/viewport-128-expected.txt:
18:23 Changeset [100057] by dmazzoni@google.com
  • 8 edits
    2 adds in trunk

New iframe content may not be reflected in the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=72100

Reviewed by Chris Fleizach.

Source/WebCore:

The core issue was that when childrenChanged was called on a
web area from an iframe that was just detached, it wasn't calling
childrenChanged on its parent scroll area, or that scroll area's
parent iframe element. To fix this, now AccessibilityScrollView
implements setNeedsToUpdateChildren and parentObjectIfExists,
and childrenChanged calls setNeedsToUpdateChildren on every object
in the parent chain, not just AccessibilityRenderObjects.

Test: accessibility/loading-iframe-updates-axtree.html

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::setNeedsToUpdateChildren):

LayoutTests:

Add new test that makes sure that if you explore the accessibility
tree of an iframe and that iframe subsequently loads new content,
the iframe AccessibilityObject's descendants are updated to point
to the new content, not the old content.

  • accessibility/loading-iframe-updates-axtree-expected.txt: Added.
  • accessibility/loading-iframe-updates-axtree.html: Added.
18:10 Changeset [100056] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-11
Reviewed by Martin Robinson.

Provision to query and set the font related properties (such as
font-family, font-size) and charset properties (such as default-
charset) is added.

  • UIProcess/API/gtk/WebKitSettings.cpp: Added font and encoding properties.

(webKitSettingsSetProperty): GObject set property function.
(webKitSettingsGetProperty): GObject get property function.
(webkit_settings_class_init): Few more signals installed.
(webkit_settings_init): Initialization of instance variables.
(webkit_web_settings_get_default_font_family): Get 'default-font-family'.
(webkit_web_settings_set_default_font_family): Set 'default-font-family'.
(webkit_web_settings_get_monospace_font_family): Get 'monospace-font-family'.
(webkit_web_settings_set_monospace_font_family): Set 'monospace-font-family'.
(webkit_web_settings_get_serif_font_family): Get 'serif-font-family'.
(webkit_web_settings_set_serif_font_family): Set 'serif-font-family'.
(webkit_web_settings_get_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_set_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_get_cursive_font_family): Get 'cursive-font-family'.
(webkit_web_settings_set_cursive_font_family): Set 'cursive-font-family'.
(webkit_web_settings_get_fantasy_font_family): Get 'fantasy-font-family'.
(webkit_web_settings_set_fantasy_font_family): Set 'fantasy-font-family'.
(webkit_web_settings_get_pictograph_font_family): Get 'pictograph-font-family'.
(webkit_web_settings_set_pictograph_font_family): Set 'pictograph-font-family'.
(webkit_web_settings_get_default_font_size): Get 'default-font-size'.
(webkit_web_settings_set_default_font_size): Set 'default-font-size'.
(webkit_web_settings_get_default_monospace_font_size): Get 'default-monospace-font-size'.
(webkit_web_settings_set_default_monospace_font_size): Set 'default-monospace-font-size'.
(webkit_web_settings_get_minimum_font_size): Get 'minimum-font-size'.
(webkit_web_settings_set_minimum_font_size): Set 'minimum-font-size'.
(webkit_web_settings_get_default_charset): Get 'default-charset'.
(webkit_web_settings_set_default_charset): Set 'default-charset'.

  • UIProcess/API/gtk/WebKitSettings.h: Add new sections for gtk-doc generation.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Expose new public APIs.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

18:05 Changeset [100055] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Fix CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

The behavior is different depending on whether we're showing
or hiding the compositor. This patch fixes both code paths.

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCCompletionEvent.h:

(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setVisible):

17:52 Changeset [100054] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] CCThreadProxy::finishAllRendering hangs if !visible
https://bugs.webkit.org/show_bug.cgi?id=71920

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedRedraw):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedRedraw):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

17:38 Changeset [100053] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2011-11-11
Reviewed by Simon Hausmann.

Some benchmark tests requires network connection (they fetch data from
external URL's) and so they fail if no network is present. These tests
should be skipped instead.

  • tests/benchmarks/loading/tst_loading.cpp:

(tst_Loading::load): Skip test if no network is present.

  • tests/benchmarks/painting/tst_painting.cpp:

(tst_Painting::paint): Skip test if no network is present.

17:37 Changeset [100052] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Enable building without shared workers.
https://bugs.webkit.org/show_bug.cgi?id=72122

Reviewed by Yury Semikhatsky.

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::retrieveWorkerContext):

17:26 Changeset [100051] by jchaffraix@webkit.org
  • 4 edits
    8 adds in trunk

Crash in styleDidChange when changing a table cell's height.
<http://webkit.org/b/72004>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-table-cell-change-height.html

fast/table/table-cell-change-height-with-needsCellRecalc-section.html
fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html
fast/table/table-row-change-height-with-needsCellRecalc-section.html

r99212 removed our call to recalcCells when the logical height changed. This
means that we could end up with a cells without having set its row() properly
which would crash.

The change exposes the was-the-row-properly-set information so that we don't
try to access a bogus index. This should work properly even if the section
needs a cell recalc as the current section's row structure would still be
accurate in this case.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): Check that our row index
was properly set before calling

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::rowWasSet): Helper function to detect
if we have set up our a row.
(WebCore::RenderTableCell::row): Use the previous function in the
ASSERT.

LayoutTests:

  • fast/table/crash-table-cell-change-height-expected.txt: Added.
  • fast/table/crash-table-cell-change-height.html: Added.
  • fast/table/table-cell-change-height-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-cell-change-height-with-needsCellRecalc-section.html: Added.
  • fast/table/table-cell-change-last-row-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html: Added.
  • fast/table/table-row-change-height-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-row-change-height-with-needsCellRecalc-section.html: Added.

Those tests checks that we don't try to access bad rows when the section needs a recalc.

17:21 Changeset [100050] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-11
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

  • editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):

Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.

  • testing/Internals.cpp:

(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

  • editing/spelling/spelling-unified-emulation-expected.txt: Added.
  • editing/spelling/spelling-unified-emulation.html: Added.
17:15 Changeset [100049] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=72092

Unreviewed. Fix build break when using curl.

ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built
when EFL port uses curl as network backend.

  • PlatformEfl.cmake: Add missing ProxyServerCurl.cpp.
17:12 Changeset [100048] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Switch remaining RenderBlock/Box methods to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=72075

Reviewed by Eric Seidel.

Move margins, floats and line layout block logic to layout abstraction.

No new tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
(WebCore::setStaticPositions):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::checkLinesForTextOverflow):
(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

16:57 Changeset [100047] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[chromium] Add translation/scaling to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=72087

Patch by Antoine Labour <piman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

Covered by WebLayerTest.

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setUVRect):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::uvRect):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexStretch::VertexShaderPosTexStretch):
(WebCore::VertexShaderPosTexStretch::init):
(WebCore::VertexShaderPosTexStretch::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderPosTexStretch::matrixLocation):
(WebCore::VertexShaderPosTexStretch::offsetLocation):
(WebCore::VertexShaderPosTexStretch::scaleLocation):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setUVRect):

Source/WebKit/chromium:

  • public/WebExternalTextureLayer.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):

16:34 Changeset [100046] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Second attempt, with a fix to handle JS garbage collection.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/element-instance-held-by-js-crash.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance): Added call to detach() to clear

anything not yet cleared.

(WebCore::SVGElementInstance::detach): New method to replace old clear methods. This one

clears all the pointers it can, and removes the instance from the corresponding elements
instance list.

  • svg/SVGElementInstance.h: Removed clear methods and replaced with detach.
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance): Modified calls to clean up an SVGElementInstance.

LayoutTests:

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
  • svg/custom/element-instance-held-by-js-crash.svg: Added.
16:30 Changeset [100045] by commit-queue@webkit.org
  • 4 edits
    9 adds in trunk

clipPath does not work on foreignObject
https://bugs.webkit.org/show_bug.cgi?id=68251

Patch by Florin Malita <fmalita@google.com> on 2011-11-11
Reviewed by Dirk Schulze.

Source/WebCore:

Add ForeignObject clipping, filtering and masking support using the SVGRenderSupport helpers
(prepareToRenderSVGContent, finishRenderSVGContent) on RenderSVGForeignObject's paint path.
This also allows us to remove explicit transparency handling, since the helpers already cover it.

Tests: svg/foreignObject/clip.html

svg/foreignObject/filter.html
svg/foreignObject/mask.html

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

  • rendering/svg/SVGResources.cpp:

(WebCore::clipperFilterMaskerTags):

LayoutTests:

  • svg/foreignObject/clip-expected.png: Added.
  • svg/foreignObject/clip-expected.txt: Added.
  • svg/foreignObject/clip.html: Added.
  • svg/foreignObject/filter-expected.png: Added.
  • svg/foreignObject/filter-expected.txt: Added.
  • svg/foreignObject/filter.html: Added.
  • svg/foreignObject/mask-expected.png: Added.
  • svg/foreignObject/mask-expected.txt: Added.
  • svg/foreignObject/mask.html: Added.
16:07 Changeset [100044] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

Revert http://trac.webkit.org/changeset/100008.
Caused hundreds of failures on the Chromium Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=68270

  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium/test_expectations.txt:
16:02 Changeset [100043] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectations for failing test.

  • platform/chromium/test_expectations.txt:
15:54 Changeset [100042] by eae@chromium.org
  • 10 edits in branches/subpixellayout/Source/WebCore

Round offsetWidth/Height/Top/Left and client* before returning instead of flooring the values in the binding code

15:54 Changeset [100041] by adamk@chromium.org
  • 10 edits in trunk/Source

Remove no-op StorageNamespace::unlock method
https://bugs.webkit.org/show_bug.cgi?id=72181

Reviewed by Darin Adler.

Source/WebCore:

The method was meant to support the localStorage mutex,
but the approach of using a mutex for localStorage has never been
implemented (and almost certainly won't be). Even if it were implemented,
it's not being called at the right time, due to bugs in the V8 bindings'
use of V8Proxy (see http://webkit.org/b/72063 for details).

If, in the future, some replacement for a mutex is used to synchronize
localStorage access, it can easily be re-added to the (hopefully
fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().

  • page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.

  • page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:

Source/WebKit/chromium:

  • src/StorageNamespaceProxy.cpp:
  • src/StorageNamespaceProxy.h:
15:52 Changeset [100040] by commit-queue@webkit.org
  • 9 edits in trunk

[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=49257

Source/WebKit/chromium:

Add the WebFrame::getPageProperty method for Chromium.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::getPageProperty):

  • src/WebFrameImpl.h:

Tools:

Adds the remaining missing layout test functionality for printing.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Add bindings for new JS methods
(parsePageNumber): Method to parse JS arguments for a page number
(parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
(LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
(LayoutTestController::isPageBoxVisible): get the visibility status for printing
(LayoutTestController::pageProperty): get a specific CSS property when in printing mode

  • DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • platform/chromium/test_expectations.txt: Removed expected fails for

printing tests that were using missing functionality in LayoutTestController.

15:50 Changeset [100039] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update iOS compiler version.

Reviewed by David Kilzer.

  • Configurations/CompilerVersion.xcconfig:
    • Update compiler version.
15:44 Changeset [100038] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Make sure Scrollbars are in their own layer.
https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

  • platform/qt/ScrollbarThemeQt.h:

(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

15:43 Changeset [100037] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187

Reviewed by David Kilzer.

  • interpreter/Interpreter.h:
    • Lower the reentry depth.
  • runtime/DatePrototype.cpp:
    • iOS also uses CF.
  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

  • Update fastmalloc configuration for iOS.
  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

  • Added flag.
  • wtf/Platform.h:
    • Update platform configuration for iOS.
15:40 Changeset [100036] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Repaint broken when children of filtered SVG elements are updated
https://bugs.webkit.org/show_bug.cgi?id=71733

Patch by Joel Webber <jgw@google.com> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/filter-child-repaint.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::setNeedsLayoutForFilteredContainer):

LayoutTests:

  • platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt: Added.
  • svg/repaint/filter-child-repaint.svg: Added.
15:19 Changeset [100035] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Don't remove InspectorBackendStub.js in Release builds after it has been
combined into inspector.js. Also remove any *.qrc file on Mac.

https://webkit.org/b/72186

Reviewed by Joseph Pecoraro.

  • WebCore.xcodeproj/project.pbxproj:
15:15 Changeset [100034] by leviw@chromium.org
  • 6 edits in branches/chromium/874

<svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
15:06 Changeset [100033] by ap@apple.com
  • 7 edits in trunk

WebProcess should use AppSandbox style quarantine
https://bugs.webkit.org/show_bug.cgi?id=72168
<rdar://problem/10434292>

Reviewed by Darin Adler.

  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.
14:55 Changeset [100032] by commit-queue@webkit.org
  • 19 edits in trunk/Source

[chromium] Patch that implementing the changes required to allow WebGL
to share its backing store directly with the compositor.
WebGL rendering contexts create and render to FBOs managed by a
DrawingBuffer instance. All PlatformLayer lifetime management is
performed by the DrawingBuffer.
Changes are only relevant to Chromium ports. Functionality is
unchanged for other ports.
https://bugs.webkit.org/show_bug.cgi?id=53201

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-11
Reviewed by Stephen White.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Construct a DrawingBuffer

during initialization, and forward all framebuffer management calls to
it.
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::platformLayer):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h: WebGLLayerChromium instances

are no longer tracked by GraphicsContext3D. Callers can now pass a
DrawingBuffer instance to provide access to the WebGLLayerChromium data.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::framebuffer):
(WebCore::DrawingBuffer::markContextChanged):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::contentChanged):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
(WebCore::WebGLLayerChromium::context):

  • platform/graphics/chromium/WebGLLayerChromium.h: WebGLLayerChromium instances

have a raw reference to their owning DrawingBuffer. This reference is set to NULL on
destruction of the DrawingBuffer. This follows the old code, which had the WebGLLayerChromium
refer rawly to a GraphicsContext3D instance, which was also revoked during tear-down of the
GraphicsContext3D.
(WebCore::WebGLLayerChromium::drawingBuffer):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/graphics/gpu/DrawingBuffer.cpp: The DrawingBuffer is now the

central point between the GraphicsContext3D, WebGLRenderingContext, and
WebGLLayerChromium classes. GraphicsContext3D, and WebGLLayerChromium only
depend on the DrawingBuffer interface.
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::commit):
(WebCore::DrawingBuffer::multisample):
(WebCore::DrawingBuffer::paintRenderingResultsToImageData):
(WebCore::DrawingBuffer::discardResources):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setScissorEnabled):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp: GraphicsContext3DPrivate no longer caches

the WebGLLayerChromium instance. Instead, it is accessed via DrawingBuffer instances
passed as arguments to the necessary routines.
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • src/GraphicsContext3DPrivate.h:
14:54 Changeset [100031] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
<http://webkit.org/b/72175>

Reviewed by Joseph Pecoraro.

  • wtf/Platform.h: Move the definition of the BUILDING_ON_* and

TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds. Also include
Availability.h, which is needed on iOS builds.

14:51 Changeset [100030] by darin@apple.com
  • 7 edits in trunk

Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423

Reviewed by Julien Chaffraix.

Source/JavaScriptCore:

  • API/JSRetainPtr.h: Removed releaseRef.
  • wtf/PassRefPtr.h: Removed releaseRef.

Source/WebCore:

  • platform/win/COMPtr.h: Removed releaseRef.

Tools:

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.

14:50 Changeset [100029] by darin@apple.com
  • 2 edits in trunk/Source/WebCore
  • WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:41 Changeset [100028] by ojan@chromium.org
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r99953.
Caused 4 tests to hit an assert.
https://bugs.webkit.org/show_bug.cgi?id=72163

Source/WebCore:

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Removed.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Removed.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Removed.
  • platform/chromium/test_expectations.txt:
14:37 Changeset [100027] by scheib@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r100024.
http://trac.webkit.org/changeset/100024
https://bugs.webkit.org/show_bug.cgi?id=72158

Broke chromium build

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
14:35 Changeset [100026] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fixup wrong expectations from http://trac.webkit.org/changeset/100008.
Pull in expectations from downstream expectations due to V8 roll.
Add new expectation for failure.

  • platform/chromium/test_expectations.txt:
14:30 Changeset [100025] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unused flags in pre-render implementation
https://bugs.webkit.org/show_bug.cgi?id=65504

The high priority pre-render flag was not used anywhere,
so we can get rid of the whole concept and always consider the requests have low priority

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-11-11
Reviewed by Daniel Bates.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_pre_render_request_add):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

14:29 Changeset [100024] by scheib@chromium.org
  • 5 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

14:20 Changeset [100023] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed, rolling out r99990.
http://trac.webkit.org/changeset/99990
https://bugs.webkit.org/show_bug.cgi?id=72134

Caused worker tests to fail on the chromium bots.

  • fast/workers/resources/worker-replace-self.js:

(worker.onmessage):

  • fast/workers/worker-call.html:
  • fast/workers/worker-close.html:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-replace-self.html:
14:19 Changeset [100022] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=72167
REGRESSION: Scroll position not restored on back after scroll
-and corresponding-
<rdar://problem/10410684>

Reviewed by Simon Fraser.

We can't just return early if we are not on an active page.
notifyPositionChanged() is called when a page is going into the page cache (and
therefore when not on an active page). We should not notify AppKit that the page
has scrolled in that case, but we still need to call
ScrollAnimator::notifyPositionChanged();. So this patch removes the early return,
and replaces it with a conditional around the relevant code.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyPositionChanged):

14:18 Changeset [100021] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/Source/WebCore

Added TileCairo and TiledBackingStoreBackendCairo files
https://bugs.webkit.org/show_bug.cgi?id=71350

Patch by Julien Chaffraix <jchaffraix@codeaurora.org>, Zaheer Ahmad <zahimad@codeaurora.org>, Joone Hur <joone.hur@collabora.co.uk>, Tomasz Morawski <t.morawski@samsung.com> on 2011-11-11
Reviewed by Martin Robinson.

Added TileCairo and TiledBackingStoreBackend files needed by Tiled Backing Store implementation that uses cairo
library eg. EFL and Gtk WebKit port.

This patch contains some parts of rebased and updated code from 45423 bug. Originals authors of the code are:

  • platform/graphics/cairo/RefPtrCairo.cpp: Added support of RefPtr for cairo_region object.

(WTF::refIfNotNull): New refIfNotNull function for cairo_region object.
(WTF::derefIfNotNull): New derefIfNotNull function for cairo_region object.

  • platform/graphics/cairo/RefPtrCairo.h: Added support of RefPtr for cairo_region object.
  • platform/graphics/cairo/TileCairo.cpp: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::TileCairo):
(WebCore::TileCairo::~TileCairo):
(WebCore::TileCairo::isDirty):
(WebCore::TileCairo::isReadyToPaint):
(WebCore::TileCairo::invalidate):
(WebCore::TileCairo::updateBackBuffer):
(WebCore::TileCairo::swapBackBufferToFront):
(WebCore::TileCairo::paint):
(WebCore::TileCairo::resize):

  • platform/graphics/cairo/TileCairo.h: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::create):
(WebCore::TileCairo::coordinate):
(WebCore::TileCairo::rect):

  • platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp: Added a new file. Implementation of

TiledBackingStoreBackend methods.
(WebCore::TiledBackingStoreBackend::createTile):
(WebCore::checkeredSurface): Helper function that creates checkered surface (see below function)
(WebCore::TiledBackingStoreBackend::paintCheckerPattern): Function is used to draw a place holder when tile no
exist or it is not ready to paint yet. The checkered surface is used here.

14:15 Changeset [100020] by darin@apple.com
  • 2 edits in trunk/Source/JavaScriptCore
  • JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:15 Changeset [100019] by darin@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE
  • ANGLE.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:15 Changeset [100018] by darin@apple.com
  • 2 edits in trunk/Source/WebKit2
  • WebKit2.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:14 Changeset [100017] by darin@apple.com
  • 2 edits in trunk/Source/WebKit
  • WebKit.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

14:07 Changeset [100016] by leviw@chromium.org
  • 19 edits in branches/subpixellayout/Source

Reverting Page to integers

14:02 Changeset [100015] by commit-queue@webkit.org
  • 11 edits in trunk/LayoutTests

Update expected results for composited canvas operations
https://bugs.webkit.org/show_bug.cgi?id=71995

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

  • canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
14:01 Changeset [100014] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded frame check in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=71980

Reviewed by Anders Carlsson.

Change covered by the existing tests in scrollbars/.

  • page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Remove the leftover check that was forgotten by the different refactoring.

13:58 Changeset [100013] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-11
Reviewed by Adam Barth.

Source/WebCore:

As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
attribute idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLButtonElement.idl: Ditto.
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLabelElement.idl: Ditto.
  • html/HTMLLegendElement.idl: Ditto.
  • html/HTMLTextAreaElement.idl: Ditto.

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
13:42 Changeset [100012] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Remove color space information from canvas composited drawImage tests
https://bugs.webkit.org/show_bug.cgi?id=71970

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Stephen White.

  • fast/canvas/canvas-composite-canvas.html:
  • fast/canvas/canvas-composite-image.html:
13:25 Changeset [100011] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r100010.
http://trac.webkit.org/changeset/100010
https://bugs.webkit.org/show_bug.cgi?id=72172

"Broke gclient syncing on the chromium bots." (Requested by
ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

  • DEPS:
13:05 Changeset [100010] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
12:52 Changeset [100009] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Assertion failed if text field is cleared while drag&drop.
https://bugs.webkit.org/show_bug.cgi?id=61008

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-11
Reviewed by Ryosuke Niwa.

Test to drag-drop text from one input element to another clearing the first input
element. Fixed in Change set - http://trac.webkit.org/changeset/99085

  • fast/events/drag-text-with-clear-expected.txt: Added.
  • fast/events/drag-text-with-clear.html: Added.
12:51 Changeset [100008] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Re-enable layout test comparisons on chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=68270

Patch by Elliot Poger <epoger@google.com> on 2011-11-11
Reviewed by Adam Barth.

  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium/test_expectations.txt:
12:48 Changeset [100007] by jochen@chromium.org
  • 3 edits in trunk/LayoutTests

Removing the 4th test in factory-deletedatabase-interactions.html
https://bugs.webkit.org/show_bug.cgi?id=72037

Reviewed by Ojan Vafai.

Removing the test since it's testing not-yet-written code. Once the new
code is written it will obviously come with the appropriate tests.

  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
12:40 Changeset [100006] by mhahnenberg@apple.com
  • 96 edits in trunk/Source

Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):

  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):

  • runtime/JSCell.h:

(JSC::JSCell::visitChildren):
(JSC::jsCast):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):

  • runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::visitChildren):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSObject.cpp:

(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):

  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

Source/JavaScriptGlue:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • UserObjectImp.cpp:

(UserObjectImp::getCallData):
(UserObjectImp::getOwnPropertyNames):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::visitChildren):

Source/WebCore:

No new tests.

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::toThisObject):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineGetter):
(WebCore::JSDOMWindow::defineSetter):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getCallData):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getCallData):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getCallData):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

  • bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

  • bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

  • bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::JSTestObj::put):
(WebCore::JSTestObj::visitChildren):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallData):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildren):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Source/WebKit2:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::deletePropertyByIndex):
(WebKit::JSNPObject::getOwnPropertyNames):

12:31 Changeset [100005] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Enable DFG JIT for ARMv7/iOS.

Rubber stamped by Oliver Hunt.

  • wtf/Platform.h:
    • enable DFG JIT for ARMv7/iOS.
12:24 Changeset [100004] by scheib@chromium.org
  • 6 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r99994.
http://trac.webkit.org/changeset/99994
https://bugs.webkit.org/show_bug.cgi?id=72150

Broke chromium windows build

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):

  • page/MouseLockable.cpp: Removed.
  • page/MouseLockable.h: Removed.
  • page/MouseLockable.idl: Removed.
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
11:49 Changeset [100003] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[v8] Remove unused V8Proxy::executingScript method
https://bugs.webkit.org/show_bug.cgi?id=72160

Reviewed by Nate Chapin.

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
11:47 Changeset [100002] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
https://bugs.webkit.org/show_bug.cgi?id=72090

Reviewed by Eric Seidel.

Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

yay! r100002.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
11:45 Changeset [100001] by beidson@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Rubberstamped by Andy Estes

100,000!
Congratulations WebKit, and here's to hundreds of thousands more!

  • ChangeLog: Point out revision 100,000.
11:45 Changeset [100000] by ossy@webkit.org
  • 1 edit in trunk/Source/ThirdParty/ChangeLog

100,000 !!!

Reviewed by Zoltan Herczeg.

  • ChangeLog: Point out revision 100,000.
11:45 Changeset [99999] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/71921> Remove use of strcpy in KURL

Reviewed by Antti Koivisto.

  • platform/KURL.cpp:

(WebCore::KURL::init): Replace strcpy() with strncpy().

11:41 Changeset [99998] by tony@chromium.org
  • 2 edits in trunk/Tools

Remove --force from gclient sync. The bots seem to have made it past
the update step.

  • Scripts/update-webkit:
11:32 Changeset [99997] by mhahnenberg@apple.com
  • 13 edits in trunk/Source

De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=72035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.

(JSC::BytecodeGenerator::BytecodeGenerator):

  • interpreter/Interpreter.cpp: Ditto.

(JSC::Interpreter::execute):

  • runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
  • runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.

  • runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.

(JSC::TimeoutChecker::didTimeOut):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMGlobalObject.cpp: Changed constructor to support passing new GlobalObjectMethodTable pointer to parent class.

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp: Added static const GlobalObjectMethodTable and filled it in with the proper function pointers.

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::supportsProfiling): Changed to static to put in the method table.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Ditto.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Ditto.

  • bindings/js/JSDOMWindowBase.h:
11:28 Changeset [99996] by tony@chromium.org
  • 2 edits in trunk/Tools

Add --force to gclient sync. Once the cq bots cycle, we can remove
this since it slows down the normal sync.

  • Scripts/update-webkit:
11:14 Changeset [99995] by ojan@chromium.org
  • 7 edits in trunk

Unreviewed, rolling out r99869.
http://trac.webkit.org/changeset/99869
https://bugs.webkit.org/show_bug.cgi?id=72157

"Caused a ~400% perf regression on the Chromium intl1 page
cyclers" (Requested by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):

  • dom/Document.h:
  • html/CollectionType.h:

LayoutTests:

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
11:09 Changeset [99994] by scheib@chromium.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
11:07 Changeset [99993] by mhahnenberg@apple.com
  • 5 edits in trunk/Source

De-virtualize JSGlobalObject::allowsAccessFrom
https://bugs.webkit.org/show_bug.cgi?id=71969

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to

JSDOMWindowBase and WebScriptObject.

Source/WebCore:

No new tests.

Since allowsAccessFrom is only used by WebScriptObject, we know that we'll always have a
JSDOMWindowBase, so we can simply have allowsAccessFrom to live in JSDOMWindowBase rather
than JSGlobalObject.

  • bindings/js/JSDOMWindowBase.h: De-virtualized allowsAccessFrom.
  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]): Added a cast from a JSGlobalObject to a JSDOMWindowBase in
order to call the allowsAccessFrom method.

10:56 Changeset [99992] by adamk@chromium.org
  • 17 edits in trunk

[MutationObservers] Support attributeFilter for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70860

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch adds an attributeFilter to the MutationObserverRegistration and
adds support for only observing attributes whose name are in the provided
filter set (array of strings).

Test: fast/mutation/observe-attributes.html.

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):

  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
(WebCore::MutationObserverRegistration::caseInsensitiveAttributeFilter):

  • dom/MutationObserverRegistration.h:
  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:
  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
10:40 Changeset [99991] by tony@chromium.org
  • 2 edits in trunk/Tools

When --force is used, also use --reset
https://bugs.webkit.org/show_bug.cgi?id=72129

Patch by Marc-Antoine Ruel <maruel@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

  • Scripts/update-webkit-chromium:
10:35 Changeset [99990] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

Speculative fix for a few worker tests.
https://bugs.webkit.org/show_bug.cgi?id=72134

Looking at the recent failures, it looks like the test starts and completes
before the page is done loading completely (the test output is correct except
for the HTML on top of the files). So start the tests from an onload callback so
that the plain HTML text also gets printed correctly.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-11-11
Reviewed by Tony Chang.

  • fast/workers/resources/worker-replace-self.js:

(startTest.worker.onmessage):
(startTest):

  • fast/workers/worker-call.html:
  • fast/workers/worker-close.html:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-replace-self.html:
10:30 Changeset [99989] by tony@chromium.org
  • 3 edits in trunk/Tools

allow two chromium drivers to run at the same time in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72067

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on

posix prevents the subprocesses from sharing the same fd for stdin.
Sharing the same fd prevents us from closing the files unless all references
to the fd are closed.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition

to adding a test for this, speed up a test (from 3sec to 0) by fixing
the timeout override. It looks like it regressed in r95875.

10:28 Changeset [99988] by vsevik@chromium.org
  • 9 edits
    6 adds in trunk

Application cache status indicator gets stuck at DOWNLOADING after a failure
https://bugs.webkit.org/show_bug.cgi?id=60793

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):

LayoutTests:

  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt:
  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html: Added.
  • http/tests/inspector/resource-tree/appcache-test.js: Added.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameManifestStatusEventReceived):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/resource-tree/resources/manifest.php:
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
10:20 Changeset [99987] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] failing media/track/tracklist-is-reachable
https://bugs.webkit.org/show_bug.cgi?id=72149

  • platform/chromium/test_expectations.txt: Expect test to fail for now.
10:03 Changeset [99986] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Only use the textured window style mask when there is no override inspector page.

https://webkit.org/b/72142

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen): Don't set NSTexturedBackgroundWindowMask if
there is an override inspector page. Make setAutorecalculatesContentBorderThickness:,
setContentBorderThickness: and WKNSWindowMakeBottomCornersSquare conditional.

09:58 Changeset [99985] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Expect chromium to pass this test after r99958.

  • platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
09:33 Changeset [99984] by eric.carlson@apple.com
  • 28 edits
    8 adds in trunk

Implement TextTrackList and the textTracks attribute of HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=71123

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-add-track.html

media/track/tracklist-is-reachable.html

  • CMakeLists.txt: Add new files for TextTrackList.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSTextTrackListCustom.cpp: Added.

(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

  • dom/EventTargetFactory.in: Add TextTrackList, conditional on VIDEO_TRACK.
  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForJSConstructor): Update for scheduleLoad change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::insertedIntoDocument): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::scheduleLoad): Add a parameter so caller can specify if

the main resource or a text track should be loaded.

(WebCore::HTMLMediaElement::loadTimerFired): Update to allow text track loading.
(WebCore::HTMLMediaElement::loadInternal): Don't call loadTextTracks.
(WebCore::HTMLMediaElement::isSafeToLoadURL): Log when CSP denies load.
(WebCore::HTMLMediaElement::playInternal): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::addTrack): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::addTextTrack): New, add track to m_textTracks and configure.
(WebCore::HTMLMediaElement::configureTextTracks): New, add comments about what this should

do eventually.

(WebCore::HTMLMediaElement::textTracks): New, return TextTrackList.
(WebCore::HTMLMediaElement::trackWasAdded): Bail if runtime feature is not enabled, schedule

asynchronous text track load.

(WebCore::HTMLMediaElement::trackWillBeRemoved): Minor cleanup.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Update for scheduleLoad change.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl: Add textTracks attribute.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree): Use new mediaElement() method.
(WebCore::HTMLTrackElement::willRemove): Ditto.
(WebCore::HTMLTrackElement::attributeChanged): When 'src' is changed, call scheduleLoad

instead of HTMLMediaElement

(WebCore::HTMLTrackElement::isDefault): hasAttribute -> fastHasAttribute.
(WebCore::HTMLTrackElement::track): Allocate track if necessary.
(WebCore::HTMLTrackElement::scheduleLoad): New, tell the track to schedule a load.
(WebCore::HTMLTrackElement::canLoadUrl): New, check security policy to see if it is OK

to load a text track. If so, dispatch 'beforeload' event to give it a chance to disallow
load.

(WebCore::HTMLTrackElement::loadingCompleted): Renamed from textTrackLoadingCompleted.
(WebCore::HTMLTrackElement::textTrackReadyStateChanged): New, TextTrackLoadingClient interface

used to inform parent of TextTrack state changes.

(WebCore::HTMLTrackElement::textTrackModeChanged): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCues): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCues): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCue): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCue): Ditto.
(WebCore::HTMLTrackElement::mediaElement): New, return parent element.

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize new instance variables.
(WebCore::LoadableTextTrack::scheduleLoad): New, prime a timer to kick off loading.
(WebCore::LoadableTextTrack::loadTimerFired): Cancel current load, if any, check to see if

new url is allowed to load, and start new load.

(WebCore::LoadableTextTrack::cueLoadingCompleted):

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrackClient::~LoadableTextTrackClient): TextTrackLoadingClient -> LoadableTextTrackClient
(WebCore::LoadableTextTrackClient::canLoadUrl):
(WebCore::LoadableTextTrackClient::loadingCompleted):
(WebCore::LoadableTextTrack::create):

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): setClient(0) -> clearClient().

  • html/TextTrack.h:

(WebCore::TextTrack::clearClient): Renamed from setClient, because it is only used to clear the client pointer.

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Get rid of a compiler warning that breaks the OS X build.

  • html/track/TextTrackList.cpp: Added. Implement the TextTrackList object.

(TextTrackList::TextTrackList):
(TextTrackList::~TextTrackList):
(TextTrackList::length):
(TextTrackList::item):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::interfaceName):
(TextTrackList::scheduleAddTrackEvent):
(TextTrackList::asyncEventTimerFired):

  • html/track/TextTrackList.h: Added.

(WebCore::TextTrackList::create):
(WebCore::TextTrackList::scriptExecutionContext):
(WebCore::TextTrackList::clearOwner):
(WebCore::TextTrackList::owner):
(WebCore::TextTrackList::refEventTarget):
(WebCore::TextTrackList::derefEventTarget):
(WebCore::TextTrackList::eventTargetData):
(WebCore::TextTrackList::ensureEventTargetData):

  • html/track/TextTrackList.idl: Added.
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::cancelLoad): New, cancel pending or in progress load and delete loader.
(WebCore::TextTrackLoader::notifyFinished): Call cancelLoad.
(WebCore::TextTrackLoader::load): Ditto.

  • loader/TextTrackLoader.h:
  • page/DOMWindow.idl: Add TextTrackList.

LayoutTests:

  • media/track/track-add-track-expected.txt: Added.
  • media/track/track-add-track.html: Added.
  • media/track/tracklist-is-reachable-expected.txt: Added.
  • media/track/tracklist-is-reachable.html: Added.
09:18 Changeset [99983] by pfeldman@chromium.org
  • 4 edits in trunk

Web Inspector: reimplement DOM search using no XPath.
https://bugs.webkit.org/show_bug.cgi?id=72125

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorDOMAgent.h:
08:55 Changeset [99982] by gavinp@chromium.org
  • 3 edits
    3 adds in trunk

Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

LayoutTests:

  • http/tests/misc/resources/xslt-bad-import-uri.xml: Added.
  • http/tests/misc/resources/xslt-bad-import-uri.xsl: Added.
  • http/tests/misc/xslt-bad-import-expected.txt: Added.
  • http/tests/misc/xslt-bad-import.html: Added.
08:53 Changeset [99981] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r99979.
http://trac.webkit.org/changeset/99979
https://bugs.webkit.org/show_bug.cgi?id=72136

bad commit message (Requested by gavinp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

08:50 Changeset [99980] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Fixed overlapping expectations.

  • platform/chromium/test_expectations.txt:
08:47 Changeset [99979] by gavinp@chromium.org
  • 3 edits in trunk

Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by NOBODY (OOPS!).

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

08:43 Changeset [99978] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark http/tests/inspector-enabled/dedicated-workers-list.html as timing out on Mac.

  • platform/chromium/test_expectations.txt:
08:35 Changeset [99977] by philn@webkit.org
  • 6 edits in trunk/Source/WebCore

[GStreamer] GstCaps and GstPad RefPtr implementation
https://bugs.webkit.org/show_bug.cgi?id=72023

Reviewed by Martin Robinson.

Smart pointer implementations for GstCaps and GstPad and them
in the media player code.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstPad):
(WTF::GstCaps):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(StreamingClient::didReceiveResponse):

08:33 Changeset [99976] by ossy@webkit.org
  • 1 edit
    16 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
08:31 Changeset [99975] by gavinp@chromium.org
  • 3 deletes in trunk/LayoutTests/http/tests/misc

Unreviewed, rilling out 99971,99972.

They were landed in error in using git-svn by gavinp@chromium.org.

08:28 Changeset [99974] by ossy@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
08:27 Changeset [99973] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 failing pasteboard tests after r99924.

  • platform/gtk/Skipped:
08:25 Changeset [99972] by gavinp@chromium.org
  • 1 add in trunk/LayoutTests/http/tests/misc/xslt-bad-import-expected.txt

Moar

08:25 Changeset [99971] by gavinp@chromium.org
  • 3 adds in trunk/LayoutTests/http/tests/misc

first shot yo

08:22 Changeset [99970] by ossy@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
08:14 Changeset [99969] by tonyg@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Another baseline for contain-and-cover-zoomed that I didn't catch earlier.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
07:52 Changeset [99968] by hausmann@webkit.org
  • 14 edits
    2 adds
    4 deletes in trunk

Unreviewed, rolling out r99964.
http://trac.webkit.org/changeset/99964
https://bugs.webkit.org/show_bug.cgi?id=72124

Broke too many Qt tests (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • Target.pri:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::usesMenuList):

  • platform/qt/QtMobileWebStyle.cpp: Added.

(QtMobileWebStyle::QtMobileWebStyle):
(drawRectangularControlBackground):
(QtMobileWebStyle::drawChecker):
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::drawRadio):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawMultipleComboButton):
(QtMobileWebStyle::drawSimpleComboButton):
(QtMobileWebStyle::getButtonImageSize):
(QtMobileWebStyle::findComboButton):
(QtMobileWebStyle::drawComplexControl):

  • platform/qt/QtMobileWebStyle.h: Added.
  • platform/qt/QtStyleOptionWebComboBox.h:

(WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
(WebCore::QtStyleOptionWebComboBox::checkMultiple):

  • platform/qt/RenderThemeQStyle.cpp: Removed.
  • platform/qt/RenderThemeQStyle.h: Removed.
  • platform/qt/RenderThemeQt.cpp:

(WebCore::initStyleOption):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
(WebCore::RenderThemeQt::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::popupInternalPaddingBottom):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::findFrameLineWidth):
(WebCore::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::animationDurationForProgressBar):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):
(WebCore::RenderThemeQt::paintSliderThumb):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintInnerSpinButton):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQt.h:

(WebCore::StylePainter::isValid):
(WebCore::StylePainter::drawPrimitive):
(WebCore::StylePainter::drawControl):
(WebCore::StylePainter::drawComplexControl):

  • platform/qt/RenderThemeQtMobile.cpp: Removed.
  • platform/qt/RenderThemeQtMobile.h: Removed.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/webcore.prf:
07:42 Changeset [99967] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fix Snow Leopard build.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

07:35 Changeset [99966] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove dead MeeGoTouch code.

Reviewed by Tor Arne Vestbø.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

07:22 Changeset [99965] by pfeldman@chromium.org
  • 13 edits in trunk

Web Inspector: make search in DOM panel scale.
https://bugs.webkit.org/show_bug.cgi?id=72118

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.performSearch.callback):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.searchResult.mycallback):
(WebInspector.DOMAgent.prototype.searchResult):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch.resultCountCallback):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult.):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
07:16 Changeset [99964] by hausmann@webkit.org
  • 14 edits
    4 adds
    2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
07:14 Changeset [99963] by apavlov@chromium.org
  • 7 edits in trunk

Web Inspector: Option to configure indentation of pretty-printed Javascript
https://bugs.webkit.org/show_bug.cgi?id=72119

Reviewed by Pavel Feldman.

Source/WebCore:

Drive-by fix for field names and added indent caching, as suggested by Pavel Podivilov.

  • inspector/front-end/JavaScriptFormatter.js:

(FormattedContentBuilder):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype._addIndent):

  • inspector/front-end/ScriptFormatter.js:
  • inspector/front-end/ScriptFormatterWorker.js:

(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.scriptEnded):

LayoutTests:

  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
07:08 Changeset [99962] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix after r99958.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationCustomCall):o

Remove hack that forced HTMLOptionsCollection to have a custom
callAsFunctionCallback().

06:55 Changeset [99961] by alexis.menard@openbossa.org
  • 2 edits in trunk

[Qt] Build fix of the private QML module with --no-webkit2.
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Tor Arne Vestbø.

  • Source/QtWebKit.pro:
06:50 Changeset [99960] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
https://bugs.webkit.org/show_bug.cgi?id=72096

JSON.parse doesn't garantee the order of keys.
We have to explicitly order the results according to Inspector.json spec.

Patch by Mike Lewis <mikelikespie@gmail.com> on 2011-11-11
Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.py:
06:50 Changeset [99959] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip a svg test and GTK rebaseline after r99941.

  • platform/gtk/Skipped:
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
06:37 Changeset [99958] by andreas.kling@nokia.com
  • 7 edits in trunk

Remove ability to call HTMLCollections in V8 bindings as well.
<http://webkit.org/b/72045>

Reviewed by Anders Carlsson.

Source/WebCore:

Follow the JSC bindings and remove the ability to call HTMLCollections
in the V8 bindings (excluding HTMLAllCollection.)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderCustomCall):
(GenerateImplementationCustomCall):

  • dom/NodeList.idl:
  • html/HTMLCollection.idl:

Remove the V8CustomCall attribute as it's no longer needed.

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:

LayoutTests:

Add a test verifying that calling collections other than document.all
will now throw.

  • fast/dom/collection-calling-expected.txt: Added.
  • fast/dom/collection-calling.html: Added.
  • fast/dom/script-tests/collection-calling.js: Added.
06:22 Changeset [99957] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Interactive color box for gradients in CSS property values
https://bugs.webkit.org/show_bug.cgi?id=72112

Reviewed by Yury Semikhatsky.

Add "background-image" to the list of color-aware properties (may contain gradient definition).

  • inspector/front-end/CSSKeywordCompletions.js:
05:47 Changeset [99956] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Add missing include to PlatformWebViewQt

Reviewed by Simon Hausmann.

05:40 Changeset [99955] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Correct test_expectations.

  • platform/chromium/test_expectations.txt:
05:34 Changeset [99954] by tonyg@chromium.org
  • 6 edits
    1 delete in trunk/LayoutTests

Update chromium baselines after r99941.

That patch changed the number of zooms performed, so it seems to make sense that the
baseline would show a different sized image.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
05:20 Changeset [99953] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

05:19 Changeset [99952] by alexis.menard@openbossa.org
  • 7 edits
    6 adds in trunk

[Qt] Add a way to have experimental features in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

.:

Add the new private QML module in the build.

  • Source/QtWebKit.pro:

Source/WebKit/qt:

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

  • declarative/private/plugin.cpp: Added.

(WebKitQmlPluginPrivate::registerTypes):

  • declarative/private/private.pro: Added.
  • declarative/private/qmldir: Added.

Source/WebKit2:

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.

(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):

  • UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.
05:12 Changeset [99951] by yurys@chromium.org
  • 15 edits
    3 deletes in trunk

Unreviewed, rolling out r99950.
http://trac.webkit.org/changeset/99950
https://bugs.webkit.org/show_bug.cgi?id=72117

"Landed wrong patch by mistake" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/JavaScriptCore:

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

  • inspector/debugger/function-location-expected.txt: Removed.
  • inspector/debugger/function-location.html: Removed.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Removed.
05:05 Changeset [99950] by yurys@chromium.org
  • 14 edits
    3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
04:47 Changeset [99949] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix incremental builds on Windows after buildsystem refactor

The qmake rules to ensure that we run make on the derived sources
before running qmake on the target were inside a unix-scope, which
resulted in flakey builds on Windows.

We now generate a rule on all platforms that ensures that "make qmake"
will always run make on the derived sources. In addition, on platforms
that have GNU make (where "make incremental" does not run "make qmake",
but only "make"), we add a similar rule that ensures that any time the
target makefile is regenerated we first run qmake and make on the derived
sources. This rule relies on GNU make's order-only-prerequisites to
not trigger a qmake-run of the target every time we run make.

https://bugs.webkit.org/show_bug.cgi?id=71778

Reviewed by Simon Hausmann.

04:46 Changeset [99948] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::MatchJob::MatchJob):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):

04:44 Changeset [99947] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Metrics] Editor is committed when scrolling a content box dimension up/down for the first time
https://bugs.webkit.org/show_bug.cgi?id=72108

Reviewed by Pavel Feldman.

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

04:40 Changeset [99946] by hausmann@webkit.org
  • 14 edits
    2 deletes in trunk

[Qt][WK2] Remove QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72113

Reviewed by Andreas Kling.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

Source/WebKit2:

Fold the functions and properties of QWebNavigationController into
QQuickWebView.

  • Target.pri:
  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage.h:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::canStop):
(QQuickWebView::canReload):
(QQuickWebView::title):

  • UIProcess/API/qt/qquickwebview.h:
  • UIProcess/API/qt/qwebnavigationcontroller.cpp: Removed.
  • UIProcess/API/qt/qwebnavigationcontroller.h: Removed.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):

Tools:

Adapt to the move of the QWebNavigationController functions/properties to
QQuickWebView.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
04:33 Changeset [99945] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] Build system tweak

Reviewed by Tor Arne Vestbø.

Be a good qmake citizen, return true from our linkStaticLibrary
"test" function.

  • qmake/mkspecs/features/functions.prf:
04:33 Changeset [99944] by tonyg@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Chromium expectations for new test in r99937.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
04:17 Changeset [99943] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=72081

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

LayerChromium and CCLayerTreeHosts hold RefPtr<>s to each other, so if
you do not clear out the layerTreeHost pointer on the LayerChromium
the layer tree is leaked. The real code does this in WebViewImpl but
this test was not.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

04:16 Changeset [99942] by hclam@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] scrolling is broken with compositor thread
https://bugs.webkit.org/show_bug.cgi?id=72059

Reviewed by James Robinson.

No new test. Existing test CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls checks scroll deltas are applied
on the right layer.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::scrollLayer):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Instead of calling on the root layer which doesn't have scroll delta applied. Change this to scrollLayer()
which actually has scroll delta.

03:49 Changeset [99941] by zimmermann@webkit.org
  • 4 edits in trunk/LayoutTests

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Zoltan Herczeg.

Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
This is the same fix I applied to the svg/zoom/page tests, I forgot this one.

  • fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
  • fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
  • platform/qt/Skipped: Unskip last regression from bug 7153.
03:47 Changeset [99940] by tonyg@chromium.org
  • 7 edits
    1 delete in trunk/Source

Unreviewed, rolling out r99826.
http://trac.webkit.org/changeset/99826
https://bugs.webkit.org/show_bug.cgi?id=72109

"Likely causing test flakiness" (Requested by tonyg-cr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):

  • tests/data/page_with_image.mht: Removed.
03:37 Changeset [99939] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] Add support for QT += webkit-private

Reviewed by Tor Arne Vestbø.

  • qmake/qt_webkit.pri: Declare private headers.
03:02 Changeset [99938] by tonyg@chromium.org
  • 1 edit
    3 moves
    2 deletes in trunk/LayoutTests

Fixing media/video-frame-accurate-seek.html expectation after r99887.

  • platform/chromium-cg-mac-leopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium-gpu-mac/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png.
02:31 BuildingQt5OnHarmattan edited by hausmann@webkit.org
(diff)
01:52 Changeset [99937] by zimmermann@webkit.org
  • 7 edits
    4 adds in trunk

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

Add another minimal testcase using <object> embedding SVGs + zooming.

  • platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
  • svg/zoom/page/zoom-svg-as-object.html: Added.

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.

If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the
visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.

If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
"visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().

If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.

The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
as overflow "hidden" already.

The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.

That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
All svg/overflow tests, still work as expected.

Test: svg/zoom/page/zoom-svg-as-object.html

  • page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.

Otherwise scrollbars will appear, even though the contents would fit without them.

(WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has

an effect though, when the FrameView of the SVG is embedded through <object>/etc.

(WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before! (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
  • rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.
01:44 Changeset [99936] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Unbreak my 32bit SL build.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateOrRemoveFilterEffect): Use narrowPrecisionToFloat() to convert float -> double.
01:03 Changeset [99935] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, build fix attempt after r99907. Since that revision
GTK layout tests were not running at all...

  • Scripts/webkitpy/layout_tests/port/gtk.py:
00:40 Changeset [99934] by philn@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

HRTF Database consolidation
https://bugs.webkit.org/show_bug.cgi?id=69703

Reviewed by Kenneth Russell.

Access to the consolidated parts of the HRTF database by segmented
chunks. A concatenated Composite HRTF database is provided in
Composite.wav. Additionnally a new build step that concatenates
the platform/audio/resources/ files into one (sox can be used for
this) can be configured for specific ports.

  • platform/audio/HRTFDatabase.h:
  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

  • platform/audio/resources/Composite.wav: Added.
00:37 Changeset [99933] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: provide an id to the root inspector element for third party UA styling.
https://bugs.webkit.org/show_bug.cgi?id=72094

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.html:
00:11 Changeset [99932] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r99898.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

11/10/11:

23:39 Changeset [99931] by yutak@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Unreviewed, add Linux baselines I forgot to commit in the last rebaseline.

  • platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
23:23 Changeset [99930] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

WebKitCSSShaderValue.h is not a member of the WebCore target
https://bugs.webkit.org/show_bug.cgi?id=72093

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Make WebKitCSSShaderValue.h a

member of the WebCore target, and make it a project header.

23:08 Changeset [99929] by mitz@apple.com
  • 12 edits in trunk/Source

Disabling assertions breaks the debug build
https://bugs.webkit.org/show_bug.cgi?id=72091

Reviewed by Geoff Garen.

Source/JavaScriptCore:

  • dfg/DFGNode.h: Made hasIdentifier() available when assertions are

disabled. It is used in Graph::dump().

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): Update m_isCheckingForDefaultMarkViolation
only if assertions are enabled.

  • wtf/Deque.h:

(WTF::::checkIndexValidity): Changed ASSERT to ASSERT_UNUSED.

  • wtf/ThreadRestrictionVerifier.h:

(WTF::ThreadRestrictionVerifier::setShared): Guarded the definition of
a local variable that is only used in an assertion.

Source/WebCore:

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::didDecodeProperties): Guarded the definition of local variables that are
only used in an assertion correctly.

  • platform/graphics/gpu/TilingData.h: Changed ASSERT to ASSERT_UNUSED.

(WebCore::TilingData::assertTile):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed): Guarded the definition of a local variable that is
only used in an assertion correctly.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyResource): Changed ASSERT to ASSERT_UNUSED.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource): Changed ASSERT to ASSERT_UNUSED.
(WebCore::RenderSVGResourceFilter::postApplyResource): Changed ASSERT to ASSERT_UNUSED.

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource): Changed ASSERT to ASSERT_UNUSED.

22:53 Changeset [99928] by yutak@chromium.org
  • 8 edits
    10 adds
    6 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 7, the final)

  • platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-cg-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
  • platform/chromium-cg-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium/test_expectations.txt:
22:39 Changeset [99927] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSString forgets to clear m_fibers when resolving ropes
https://bugs.webkit.org/show_bug.cgi?id=72089

Reviewed by Geoff Garen.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRopeSlowCase):

22:28 Changeset [99926] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r99862.

  • platform/qt/svg/foreignObject/background-render-phase-expected.png: Added.
  • platform/qt/svg/foreignObject/background-render-phase-expected.txt: Added.
20:13 Changeset [99925] by dcheng@chromium.org
  • 6 edits in trunk/Source

[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
https://bugs.webkit.org/show_bug.cgi?id=71414

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no new functionality enabled yet.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/WebClipboard.h:

(WebKit::WebClipboard::writeDataObject):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardWriteDataObject):

20:12 Changeset [99924] by dcheng@chromium.org
  • 15 edits in trunk/Source/WebCore

Atomically update the system clipboard for copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=40515

Reviewed by David Levin.

This change consolidates the system pasteboard mutation logic into dispatchCPPEvent() rather
than having it scattered throughout tryDHTMLCopy/tryDHTMLCut and the various Clipboard*
classes. This allows us to ensure that the system pasteboard remains in a consistent state
even if there's an exception thrown during event handling, and it also lays the ground work
for allowing pages to prevent copy/cut without causing the system pasteboard to be cleared.

No new tests, since any layout test would be flaky since it would depend on and affect
global system state.

  • editing/Editor.cpp:

(WebCore::Editor::tryDHTMLCopy): Move Pasteboard::clear() call to dispatchCPPEvent().
(WebCore::Editor::tryDHTMLCut): Ditto.
(WebCore::Editor::dispatchCPPEvent):
Only persist Clipboard mutations to the system pasteboard if the event was dispatched
successfully and default processing was prevented.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard):
When creating a Clipboard for copy/cut, back it with a unique instance of NSPasteboard to
buffer pasteboard mutations.

  • platform/Pasteboard.h:
  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardGtk.

(WebCore::ClipboardGtk::setData):

  • platform/gtk/ClipboardGtk.h:

(WebCore::ClipboardGtk::clipboard):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeClipboard):
Implement logic to flush data from temporary NSPasteboard to system pasteboard.

  • platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardQt.

(WebCore::ClipboardGtk::setData):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeClipboard):

  • platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::writeClipboard):

18:15 Changeset [99923] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

Chromium rebaselines after r99902.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
18:10 Changeset [99922] by hayato@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, rolling out r99916.
http://trac.webkit.org/changeset/99916
https://bugs.webkit.org/show_bug.cgi?id=72077

fast/harness/result.html seems platform dependent (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

  • platform/chromium/fast/harness/results-expected.txt: Added.
17:56 Changeset [99921] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore/platform

Revert Scrollbar::convertFromContainingView to int to avoid unnecessary type conversion

17:45 Changeset [99920] by scherkus@chromium.org
  • 2 edits in trunk/Tools

[Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=72001

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
17:41 Changeset [99919] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderTableSection's recalcCell logic is doing too much work
https://bugs.webkit.org/show_bug.cgi?id=71986

Reviewed by Darin Adler.

No change in behavior expected so no test.

r98738 and r98980 missed the point that Vector::clear() does not touch
the internal buffer. Thus calling clear() would keep the memory and properly
reset the size().

Due to how the code worked, after r98980 the code would end up resetting some
of RowStruct field twice: once when growing and the other one when calling
fillRowsWithDefaultStartingAtPosition.

This change make the code use Vector::clear and simplified the recalcCells
logic knowing that growing the Vector will properly initialize most of the
RowStruct fields (with RowStruct constructor).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::addCell):
Updated after ensureRows signature change.

(WebCore::RenderTableSection::ensureRows):
Removed the overflow check as it was making some assumption as to how the
Vector worked. If we want to implement a limit, we may do it differently.
Also inlined the part of fillRowsWithDefaultStartingAtPosition that grows
the columns to match our current representation. The rest of the function's
initialization is handled by the constructor already.

(WebCore::RenderTableSection::recalcCells):
Use clear() as it keeps the buffer and just resets the size. Also shrinkToFit
at the end as we may have lost some rows.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::CellStruct::CellStruct):
Fixed the style of the constructor.

(WebCore::RenderTableSection::RowStruct::RowStruct):
Added an explicit constructor (which is equivalent to the default one)
but underlines what we expect.

17:26 Changeset [99918] by enrica@apple.com
  • 5 edits
    2 adds in trunk

ASSERT when outdenting styled line break.
https://bugs.webkit.org/show_bug.cgi?id=72069
<rdar://problem/10429739>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When outdenting a line break that has some inline style, we don't consider
the enclosing elements that provide the style.
This causes the splitting to occur in the wrong position,
triggering the assert.

Test: editing/execCommand/outdent-break-with-style.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph): The fix consists
in choosing the highest inline ancestor as splitting point.

  • editing/htmlediting.cpp:

(WebCore::isInline): Added.

  • editing/htmlediting.h: Added isInline.

LayoutTests:

  • editing/execCommand/outdent-break-with-style-expected.txt: Added.
  • editing/execCommand/outdent-break-with-style.html: Added.
17:07 Changeset [99917] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

LayoutTests:

Reviewed by Oliver Hunt.

Added a test for byte arrays, and fixed a small bug in dfg-min-max.js.

  • fast/js/dfg-byte-array-put-expected.txt: Added.
  • fast/js/dfg-byte-array-put.html: Added.
  • fast/js/script-tests/dfg-byte-array-put.js: Added.

(doPut):
(doGet):

  • fast/js/script-tests/dfg-min-max.js:
16:50 Changeset [99916] by hayato@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, revert a misplaced expected text in r99819.
A results-expected is platform independent. r99828 fixed this.

  • platform/chromium/fast/harness/results-expected.txt: Removed.
16:36 Changeset [99915] by bdakin@apple.com
  • 3 edits in trunk/Source/WebKit2

Once more for the QT build.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setFindIndicator):

  • UIProcess/qt/QtWebPageProxy.h:
16:33 Changeset [99914] by bdakin@apple.com
  • 5 edits in trunk/Source/WebKit2

More attempted build fix.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setFindIndicator):

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setFindIndicator):

  • UIProcess/API/gtk/PageClientImpl.h:
16:32 Changeset [99913] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(-[WKContentLayer drawInContext:]):

16:28 Changeset [99912] by bdakin@apple.com
  • 3 edits in trunk/Source/WebKit2

Speculative build fix.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setFindIndicator):

  • UIProcess/win/WebView.h:
16:06 Changeset [99911] by bdakin@apple.com
  • 14 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=66584
WebKit2's find bouncy looks blurry after dragging window onto >1.0 scale factor
display
-and corresponding-
<rdar://problem/9987559>

Reviewed by Anders Carlsson.

The setFindIndicator message and various functions of the same name must all take
an additional parameter indicating whether or not setting the find indicator
should result in a bounce animation. This is because when the device scale factor
changes, if there is currently a find indicator, it must be re-set to a higher or
lower resolution version, but we don't want the bounce animation to happen again.

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setFindIndicator:fadeOut:animate:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

New function FindController::isShowingOverlay() is used to determine if
FindController::deviceScaleFactorDidChange() needs to be called.

  • WebProcess/WebPage/FindController.h:

(WebKit::FindController::isShowingOverlay):

FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re-
generate the bitmap at the appropriate scale factor, but tells it not to animate
this time.
(WebKit::FindController::deviceScaleFactorDidChange):

updateFindIndicator() takes a new parameter indicating whether or not the
FindIndicator should animate. It defaults to true since the deviceScaleFactor
changing is the only case currently where we do not want it to animate.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

Calls into FindController::deviceScaleFactorDidChange() when the scale factor has
changed and the find overlay is showing.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):

15:59 Changeset [99910] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065

Reviewed by Gavin Barraclough and Geoff Garen.

Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC::isFunctionPrediction):

  • bytecode/ValueProfile.cpp:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

15:47 Changeset [99909] by fpizlo@apple.com
  • 2 edits in trunk/Tools

bencher script should support remote benchmarking
https://bugs.webkit.org/show_bug.cgi?id=71618

Rubber-stamped by Geoff Garen.

Added the following features:

  • Benchmark report tells you the hostname and machine model (according to 'sysctl hw.model') of the machine you did the run on, and svn revision number (according to 'svn info') of the VMs you're testing.


  • The --remote option. You give this an ssh-style hostname (i.e. user@host is acceptable, in addition to just host, in which case your username is used) and it automatically packages the build directories of the VMs you're testing, sends them to the remote machine along with your copy of the bencher script and all of the options you passed. This pretty much seamlessly allows you to run a set of benchmarks on any machine that is sufficiently compatible with yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which must now include a tempPath setting that tells bencher where to put files when that machine is used as a slave in a remote benchmarking run.


  • Added yet another way of specifying which benchmarks to run. This was sort of necessary for --remote to work as expected. Previously, you either said what suites to exclude (for example --exclude-sunspider) or that you only wanted to run one suite to the exclusion of others (--sunspider-only). But it's often better to just be able to specify the list of suites you want. This is now supported. You can say, for example, --v8 --sunspider, which means, just run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is still supported.
  • Scripts/bencher:
15:32 Changeset [99908] by leviw@chromium.org
  • 25 edits in branches/subpixellayout/Source/WebCore

Adding a pixelSnappedIntRect method and using it throughout WebCore where enclosingIntRect wasn't actually appropriate.

15:31 Changeset [99907] by tony@chromium.org
  • 6 edits in trunk/Tools

Lazily start DRT instances in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72038

Reviewed by Eric Seidel.

Just a refactoring, no new tests.

  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:31 Changeset [99906] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR

Reviewed by Joseph Pecoraro.

script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation. Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.

15:11 Changeset [99905] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Remove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi?id=72058

Reviewed by Simon Fraser.

As suggested by Nikolas, we don't need this virtual method any more.

  • rendering/FilterEffectRenderer.h:
15:02 Changeset [99904] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Add ARMv7 support to the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72061

Reviewed by Geoff Garen.

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):

  • Add CPU(ARM) copies of these functions.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::spill):

  • Fix matching of '}' re #if blocks, makes some tools happy.

(JSC::DFG::JITCodeGenerator::setupArguments):
(JSC::DFG::JITCodeGenerator::setupArgumentsWithExecState):
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheckSetResult):
(JSC::DFG::JITCodeGenerator::appendCallSetResult):

  • Add CPU(ARM) / 4 argument register copies of these functions.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

  • Should use callOperation to plant a call to a DFG_OPERATION.

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • These methods need to plant a relinkable jump; we currently do so using beginUninterruptedSequence() / endUninterruptedSequence().
  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

  • Should use callOperation to plant a call to a DFG_OPERATION.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):

  • This method needs to plant a relinkable jump; we currently do so using beginUninterruptedSequence() / endUninterruptedSequence().

(JSC::DFG::JITCompiler::compileBody):

  • Add abstraction to retrieve the pc after a call.
  • dfg/DFGOSRExitCompiler.cpp:
    • Fix a bug - CodeLocationLabel needs a data address rather than an executable one, but can just take a MacroAssemblerCodePtr instead!
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::compileClampDoubleToByte):

  • Add FIXME comment to come back to! - bug#72054.
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

  • Add missing method (ooops, required by bug#72047)
  • dfg/DFGSpeculativeJIT32_64.cpp:
    • Need to wrap fmod on ARMv7.
15:01 Changeset [99903] by luiz@webkit.org
  • 5 edits in trunk/Source/WebKit/qt

[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
https://bugs.webkit.org/show_bug.cgi?id=71530

Reviewed by Simon Hausmann.

Adding methods setGeometry and setFont so that users of platform plugin may show the
popup menus in proper position and using proper font.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

  • examples/platformplugin/WebPlugin.h:

(WebPopup::setGeometry):
(WebPopup::setFont):

  • examples/platformplugin/qwebkitplatformplugin.h:
14:59 Changeset [99902] by hyatt@apple.com
  • 17 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060

[CSS Line Grid] Add support for the line-grid-snap property to control snapping to the nearest
enclosing grid.

Reviewed by Dan Bernstein.

Added fast/line-grid/line-grid-snap-parsing.html.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineGridSnap):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineGridSnap):
(WebCore::InheritedFlags::setLineGridSnap):
(WebCore::InheritedFlags::initialLineGridSnap):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=72060

Add tests for line-grid-snap parsing.

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/line-grid/line-grid-snap-parsing-expected.txt: Added.
  • fast/line-grid/line-grid-snap-parsing.html: Added.
  • fast/line-grid/script-tests/line-grid-snap-parsing.js: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
14:52 Changeset [99901] by rniwa@webkit.org
  • 3 edits in trunk/Tools

ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
https://bugs.webkit.org/show_bug.cgi?id=72057

Reviewed by Eric Seidel.

Make the regular expression more explicit.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
14:43 Changeset [99900] by haraken@chromium.org
  • 9 edits
    1 copy
    12 adds in trunk/Source/WebCore

CodeGeneratorV8.pm can generate Event constructors
https://bugs.webkit.org/show_bug.cgi?id=72055

Reviewed by Adam Barth.

This patch makes CodeGeneratorV8.pm generate Event constructors
and replaces a custom constructor of Event with the generated one.
After this patch is landed without regression,
I will replace custom constructors of all other Events.
This patch introduces two new IDLs:

  • [ConstructorTemplate=Event] IDL indicates that CodeGenerator should

generate an Event constructor.

  • [InitializedByConstructor] IDL on an attribute indicates that

the attribute can be initialized by the constructor.

Tests: fast/events/constructors/event-constructors.html

fast/events/constructors/custom-event-constructor.html
fast/events/constructors/progress-event-constructor.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Added a header for fillXXXXEventInit(...).
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].
(GenerateEventConstructorCallback): Generates an Event constructor. The generated code is the same as the code that had been written in V8EventConstructors.cpp.
(GenerateImplementation): Generates an Event constructor if [ConstructorTemplate=Event] is specified.

  • dom/Event.idl: Added [ConstructorTemplate=Event] IDL. Added [InitializedByConstructor] IDL to attributes that can be initialized by a constructor.
  • bindings/scripts/test/TestEventConstructor.idl: Added a new run-bindings-test.
  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp: Updated a run-bindings-tests result.

(WebDOMTestEventConstructor::WebDOMTestEventConstructorPrivate::WebDOMTestEventConstructorPrivate):
(WebDOMTestEventConstructor::WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::operator=):
(WebDOMTestEventConstructor::impl):
(WebDOMTestEventConstructor::~WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::attr1):
(WebDOMTestEventConstructor::attr2):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp: Ditto.

(WebKit::kit):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):
(WebKit::core):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_set_property):
(webkit_dom_test_event_constructor_get_property):
(webkit_dom_test_event_constructor_constructed):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):
(WebKit::wrapTestEventConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.

(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::getConstructData):
(WebCore::JSTestEventConstructorPrototype::self):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype):
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::toJS):
(WebCore::toTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.

(WebCore::JSTestEventConstructor::create):
(WebCore::JSTestEventConstructor::createStructure):
(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructorPrototype::create):
(WebCore::JSTestEventConstructorPrototype::createStructure):
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestEventConstructor.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.mm: Ditto.

(-[DOMTestEventConstructor dealloc]):
(-[DOMTestEventConstructor finalize]):
(-[DOMTestEventConstructor attr1]):
(-[DOMTestEventConstructor attr2]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: Ditto.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.

(WebCore::TestEventConstructorInternal::V8_USE):
(WebCore::TestEventConstructorInternal::attr1AttrGetter):
(WebCore::TestEventConstructorInternal::attr2AttrGetter):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore::V8TestEventConstructor::wrapSlow):
(WebCore::V8TestEventConstructor::derefObject):

  • bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.

(WebCore::V8TestEventConstructor::toNative):
(WebCore::V8TestEventConstructor::existingWrapper):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h: Ditto.
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/V8/V8TestNamedConstructor.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
  • bindings/v8/custom/V8EventConstructors.cpp: Removed a custom constructor of Event.
14:27 Changeset [99899] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Pre-emptively mark a canvas test as failing for next Skia roll.

  • platform/chromium/test_expectations.txt:
13:59 Changeset [99898] by fpizlo@apple.com
  • 17 edits
    3 adds in trunk/Source/JavaScriptCore

DFG should not reparse code that was just parsed
https://bugs.webkit.org/show_bug.cgi?id=71977

Reviewed by Geoff Garen.

The instruction stream of a code block is now kept around until
the next GC. When doing either an optimizing compilation of an
executable, or inlining of an executable, we now try to find the
already preexisting bytecode. If we find it, we don't have to parse.
If we don't find it, we parse as before. Inlining takes the extra
step of caching code blocks, so if the same executable gets inlined
multiple times into the same caller, then we parse it at most once
even if prior to inlining that executable did not have any code
blocks with an instruction stream.

Also fixed a silly bug where the strict mode for various operations
was being determined by looking at the machine code block rather
than the inlinee.

To enable the delete-on-next-GC policy, I introduced the notion
of an ultra weak finalizer, which anyone can register during
tracing. This is thread-safe (for parallel GC) and
stop-the-world-safe (so calls to free() are postponed until the
world is resumed). This required reusing some facilities previously
created for WeakReferenceHarvester, so I created a common utility
class. I also retweaked the handling of WeakReferenceHarvesters,
since they should be executed during stop-the-world since in the
future we may want to allow them to call drain().

2% win on SunSpider. 2% win on V8, when run in my harness. Neutral
elsewhere.

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::copyPostParseDataFrom):
(JSC::CodeBlock::copyPostParseDataFromAlternative):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::canProduceCopyWithBytecode):
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::handleBytecodeDiscardingOpportunity):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::BytecodeDestructionBlocker::BytecodeDestructionBlocker):
(JSC::BytecodeDestructionBlocker::~BytecodeDestructionBlocker):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::strictModeFor):

  • dfg/DFGByteCodeCache.h: Added.

(JSC::DFG::CodeBlockKey::CodeBlockKey):
(JSC::DFG::CodeBlockKey::operator==):
(JSC::DFG::CodeBlockKey::hash):
(JSC::DFG::CodeBlockKey::executable):
(JSC::DFG::CodeBlockKey::kind):
(JSC::DFG::CodeBlockKey::isHashTableDeletedValue):
(JSC::DFG::CodeBlockKeyHash::hash):
(JSC::DFG::CodeBlockKeyHash::equal):
(JSC::DFG::ByteCodeCache::ByteCodeCache):
(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionally):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/ListableHandler.h: Added.

(JSC::ListableHandler::ListableHandler):
(JSC::ListableHandler::~ListableHandler):
(JSC::ListableHandler::List::List):
(JSC::ListableHandler::List::addNotThreadSafe):
(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::hasNext):
(JSC::ListableHandler::List::removeNext):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionally):

  • heap/MarkStack.h:

(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):

  • heap/SlotVisitor.h:
  • heap/UnconditionalFinalizer.h: Added.

(JSC::UnconditionalFinalizer::~UnconditionalFinalizer):

  • heap/WeakReferenceHarvester.h:

(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::profiledCodeBlockFor):

13:55 Changeset [99897] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add a couple tests that have started hitting asserts on the mac bots.

  • platform/chromium/test_expectations.txt:
13:44 Changeset [99896] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not share CSS style for MediaElement backed by a plugin
https://bugs.webkit.org/show_bug.cgi?id=72005

Reviewed by Simon Fraser.

With PLUGIN_PROXY_FOR_VIDEO, the RenderMedia elements are rendered through RenderBoxModelObject.
Like the embedded element, the proxied media element can gain a layer outside a change of style.

This patch prevents style sharing for the Audio and Video elements when PLUGIN_PROXY_FOR_VIDEO
is enabled.

This path is covered by exising tests. In particular, http/tests/misc/empty-urls.html
ASSERT() because of this.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):

13:41 Changeset [99895] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add ARMv7 register info for the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72050

Reviewed by Geoff Garen.

  • dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

13:34 Changeset [99894] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Make WKViews in NSPopovers render as they would in active windows.

The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WKView
needs to update the active state during order on/off screen notifications.

https://webkit.org/b/68435

Reviewed by John Sullivan.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidOrderOffScreen:]): Call viewStateDidChange with WebPageProxy::ViewWindowIsActive.
(-[WKView _windowDidOrderOnScreen:]): Ditto.

13:31 Changeset [99893] by dino@apple.com
  • 16 edits
    11 adds in trunk

Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Implement an extremely simple version of the filter
chain. Only a single hue-rotate filter is supported
at the moment. The change in this commit was to insert a new
step in RenderLayer's painting to capture the content to an
offscreen ImageBuffer, apply a filter operation on that buffer,
and then draw the result in place of the original element. The full
implementation will need something like the SVGFilterBuilder
but this is a good prototype of effects on HTML content.
It's an open question at the moment as to when the filter
effect should apply: after masking, after overflow, after outline,
etc. Currently the filter applies at the end of the paintLayer code.
This will likely change.

Added a FilterEffectRenderer class that is the root of the filter
tree. At the moment it holds the offscreen context and
the existing paint context.

Other than rendering, the rest of this patch adds tests
to make sure any element with a filter style will become
a RenderLayer. In order to avoid a lot of duplicated code
around the more complex logic tests, RenderStyle::hasFilter
is available outside ENABLE(CSS_FILTERS), but returns false
in those situations.

Tests: css3/filters/add-filter-rendering.html

css3/filters/remove-filter-rendering.html
css3/filters/simple-filter-rendering.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • rendering/FilterEffectRenderer.cpp: Added.

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):

  • rendering/FilterEffectRenderer.h: Added.

(WebCore::FilterEffectRenderer::create):
(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::sourceImageRect):
(WebCore::FilterEffectRenderer::setFilterRegion):
(WebCore::FilterEffectRenderer::filterRegion):
(WebCore::FilterEffectRenderer::effectBoundingBoxMode):
(WebCore::FilterEffectRenderer::setEffect):
(WebCore::FilterEffectRenderer::effect):
(WebCore::FilterEffectRenderer::setSourceGraphic):
(WebCore::FilterEffectRenderer::sourceGraphic):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::styleChanged):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasFilter):

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasFilter):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::requiresLayer):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasFilter):

Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Three new tests that exercise the (simple) filter
implementation.

  • css3/filters/add-filter-rendering-expected.png: Added.
  • css3/filters/add-filter-rendering-expected.txt: Added.
  • css3/filters/add-filter-rendering.html: Added.
  • css3/filters/remove-filter-rendering-expected.png: Added.
  • css3/filters/remove-filter-rendering-expected.txt: Added.
  • css3/filters/remove-filter-rendering.html: Added.
  • css3/filters/simple-filter-rendering-expected.png: Added.
  • css3/filters/simple-filter-rendering-expected.txt: Added.
  • css3/filters/simple-filter-rendering.html: Added.

+

13:08 Changeset [99892] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
https://bugs.webkit.org/show_bug.cgi?id=72047

Reviewed by Geoff Garen.

We currently don't attempt to abstract divide through the macro assembler,
due to these instructions commonly having specific requirements. This means
there is architecture specific code in the JIT - #ifdef it, and provide a
common implementation.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compile):

13:06 Changeset [99891] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add a simple content layer to TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=72044

Reviewed by Darin Adler.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Add a content layer member variable.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(-[WKContentLayer _initWithWebPage:WebKit::]):
Add initializer.

(-[WKContentLayer drawInContext:]):
Lay out and draw the web page.

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add the content layer as a sublayer of the root layer.

(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Tell the content layer to paint.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the content layer as well.

13:06 Changeset [99890] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

The WKView layer hosting subview needs to be flipped
https://bugs.webkit.org/show_bug.cgi?id=72042

Reviewed by Darin Adler.

In order to match the Core Animation layer hierarchy, the layer hosting WKView
subview needs to be flipped.

  • UIProcess/API/mac/WKView.mm:

(-[WKFlippedView isFlipped]):
Add a NSView subview whose sole purpose is to be flipped.

(-[WKView _enterAcceleratedCompositingMode:]):
Create a WKFlippedView instead of a regular NSView.

12:38 Changeset [99889] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Add ENABLE_VALUE_PROFILER support for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=72043

Reviewed by Geoff Garen.

This requires us to make a bucketCounterRegister available; to do so we'll need to spill more registers on entry to JIT code.

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_mod):

  • cleanup location of UNUSED_PARAM
  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):

  • jit/JITStubs.h:
    • Update JITStackFrame structure & asm code to spill more registers.
  • jit/JSInterfaceJIT.h:
    • Assign a bucketCounterRegister.
12:24 Changeset [99888] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Fix sampling counters on ARMv7, move add64 functionality to macro assembler
https://bugs.webkit.org/show_bug.cgi?id=72040

Reviewed by Geoff Garen.

The ability to add an integer to a uint64_t in memory is poorly copied in
multiple places & ifdef'ed on architecture, addWithCarry32 is also a badly
designed interface since add32 is not required to set flags (we have no
concept of flags in the macro assembler interface).

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::add64):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add64):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add64):

  • dfg/DFGAssemblyHelpers.cpp:
  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitCount):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::writeBarrier):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitCount):

12:04 Changeset [99887] by scherkus@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2011-11-10 Andrew Scherkus <scherkus@chromium.org>

Update expectations for media/video-frame-accurate-seek.html.

It's passing consistently.

  • platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium/test_expectations.txt:
11:51 Changeset [99886] by xji@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

Inside textarea, the shadowed text node's previous leaf node could be the
shadowRoot node, which cause assert exception in creating legacy position based
on such node. Exit previousRootInlineBox() when reach shadowRoot node.

It does not cause problem when looking for text node's next leaf node. Adding
the same checking in nextRootInlineBox just to be safe.

Test: editing/selection/move-by-word-visually-crash-test-textarea.html

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

  • editing/selection/move-by-word-visually-crash-test-textarea-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-textarea.html: Added.
11:36 Changeset [99885] by leviw@chromium.org
  • 3 edits in branches/chromium/912/Source/WebCore

Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

  • rendering/svg/RenderSVGResourceContainer.h:
11:27 Changeset [99884] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add line for very flaky test storage/indexeddb/factory-deletedatabase-interactions.html.

  • platform/chromium/test_expectations.txt:
11:26 Changeset [99883] by dino@apple.com
  • 14 edits in trunk

Parse drop-shadow() filter syntax https://bugs.webkit.org/show_bug.cgi?id=69108

Reviewed by Simon Fraser.

Source/WebCore:

Support parsing of the shadow syntax inside drop-shadow
and returning the correct computed style for a filter that
has such a function.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

Move this from a static function (computedFilter) to a method on
CSSComputedStyleDeclaration, which allows us to call the
existing method for shadow styles.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):

Previously parseShadow expected to be called with the entire
value of a property, not just to look at a restricted subset.
Change parseShadow to take a CSSParserValueList as parameter,
allowing it to be used to parse the arguments to the drop-shadow
function. Also, return the CSSValueList rather than injecting
it directly into the property value.

(WebCore::filterInfoForName):
(WebCore::CSSParser::parseFilter):

Support for the drop-shadow() function.

  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

Updated to use the new arguments for parseShadow.

LayoutTests:

Extend existing tests to exercise parsing of valid
and invalid drop-shadow filters, as well as the computed
style.

  • css3/filters/filter-property-computed-style-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt:
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-computed-style.js:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:
11:22 Changeset [99882] by zimmermann@webkit.org
  • 9 edits in trunk/LayoutTests

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline Gtk/Win results after r99854.

  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/gtk/svg/custom/text-filter-expected.txt:
  • platform/gtk/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
11:09 Changeset [99881] by scherkus@chromium.org
  • 5 edits
    2 moves
    3 adds
    2 deletes in trunk/LayoutTests

2011-11-10 Andrew Scherkus <scherkus@chromium.org>

Rebaseline fast/layers/video-layer.html due to r98596.

  • platform/chromium-cg-mac-snowleopard/fast/layers/video-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.png.
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.png: Removed.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt: Removed.
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.txt.
  • platform/chromium/test_expectations.txt:
10:47 Changeset [99880] by ojan@chromium.org
  • 5 edits
    4 moves in trunk/LayoutTests

Rebaselines after http://trac.webkit.org/changeset/99854.
The new results were all updated in r99854, but there are sizing differences
on the chromium bots.

  • platform/chromium-cg-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/filters/filter-on-tspan-expected.png.
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/text-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/text-filter-expected.png.
  • platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png.
  • platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filter-on-tspan-expected.png.
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
10:39 Changeset [99879] by adamk@chromium.org
  • 1 edit
    6 adds in trunk/PerformanceTests

[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
https://bugs.webkit.org/show_bug.cgi?id=71939

Reviewed by Ojan Vafai.

These benchmarks time both the DOM mutations themselves and the time taken
to call the MutationCallback. This measurement is achieved by
executing the code entirely within the MutationCallback itself.

  • Mutation/append-child-deep.html: Added. Covers appendChild in a 200-node-deep tree with subtree observation.
  • Mutation/append-child.html: Added. Covers appendChild in a flat tree.
  • Mutation/inner-html.html: Added. Covers innerHTML adding and removing many nodes at a time.
  • Mutation/remove-child-deep.html: Added. Covers removeChild in a 200-node-deep tree with subtree observation.
  • Mutation/remove-child.html: Added. Covers removeChild in a flat tree.
10:36 Changeset [99878] by vsevik@chromium.org
  • 14 edits
    4 adds in trunk

Web Inspector: ApplicationCache UI is confusing and incorrect.
https://bugs.webkit.org/show_bug.cgi?id=64581

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed resources panel application cache UI.
Manifest urls are now shown under application cache tree element.
Under each manifest url tree element frames using relevant application
cache are listed. Application cache detailed views could be opened for each
frame.

Test: http/tests/inspector/resource-tree/appcache-iframe-manifests.html

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
(WebCore::InspectorApplicationCacheAgent::enable):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
(WebCore::InspectorApplicationCacheAgent::getManifestForFrame):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
(WebInspector.ApplicationCacheModel.prototype._mainFrameNavigated):
(WebInspector.ApplicationCacheModel.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheModel.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheModel.prototype._frameManifestUpdated):
(WebInspector.ApplicationCacheModel.prototype._frameManifestRemoved):
(WebInspector.ApplicationCacheModel.prototype.frameManifestURL):
(WebInspector.ApplicationCacheModel.prototype.frameManifestStatus):
(WebInspector.ApplicationCacheModel.prototype._statusUpdated):
(WebInspector.ApplicationCacheModel.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.frameForId):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype.addDocumentURL):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._populateApplicationCacheTree):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestAdded):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestRemoved):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestStatusChanged):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get frameId):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):

LayoutTests:

  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html: Added.
  • http/tests/inspector/resource-tree/resources/manifest.php: Added.
  • http/tests/inspector/resource-tree/resources/page-with-manifest.php: Added.
10:26 Changeset [99877] by tonyg@chromium.org
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

Chromium expectations for r99854.

  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
10:23 Changeset [99876] by scherkus@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-11-10 Andrew Scherkus <scherkus@chromium.org>

Few more rebaselines for media/video-frame-accurate-seek-expected.html.

  • platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png:
10:16 Changeset [99875] by ojan@chromium.org
  • 1 edit
    7 moves in trunk/LayoutTests

Fixup expectations for bots that finished cycling after r99760 was committed.

  • platform/chromium/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
  • platform/chromium/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
  • platform/chromium/fast/repaint/scroll-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png.
  • platform/chromium/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
  • platform/chromium/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
  • platform/chromium/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
  • platform/chromium/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.
10:11 Changeset [99874] by tonyg@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Chromium expectations for r99862.

  • platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Added.
  • platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Added.
09:46 Changeset [99873] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebCore

Shrink CSSMutableStyleDeclaration.
<http://webkit.org/b/72032>

Reviewed by Antti Koivisto.

Move m_strictParsing and m_iteratorCount (debug only) up into
CSSStyleDeclaration, effectively shaving one CPU word (4/8 bytes)
off of every CSSMutableStyleDeclaration.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:
09:32 Changeset [99872] by kbalazs@webkit.org
  • 13 edits
    2 adds in trunk

[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

.:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

  • Source/api.pri: Link to xlib if necessary.

Source/WebCore:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

No new tests. Existing plugin test are sufficient.

  • Target.pri:
  • bridge/npruntime_internal.h: Added yet another undef

to fix build with Qt5 + X11 headers.

  • plugins/qt/QtX11ImageConversion.cpp: Added.

(WebCore::qimageFromXImage):

  • plugins/qt/QtX11ImageConversion.h: Added.

Added a helper function to create a QImage from an XImage.
Put it in a new file into WebCore to avoid copyright issues - as
the code has been taken directly from Qt - and to be able to resuse
it for the WK1 plugin support in the future.

Source/WebKit2:

  • Target.pri:
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::pluginsDirectories):
Kill the last dependency from the WebKit1 plugin system.
This is necessary because currently we don't build the WebKit1
plugin code. The function is equivalent with the XP_UNIX part of
PluginDatabase::defaultPluginDirectories.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::initializeXEvent):
Rework plugin initialization and drawing model.

Tools:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

  • qmake/mkspecs/features/features.prf: Enable X11

plugins if Qt is built with the xcb-xlib backend.

09:25 Changeset [99871] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

fast/dom/htmlcollection-detectability.html has strange failure output.
<http://webkit.org/b/71946>

Reviewed by Darin Adler.

When a collection should be detectable, but isn't, the test would
say "Failed: document.foo is detectable." It should say that it's
undetectable.

  • fast/dom/htmlcollection-detectability.html:
09:12 Changeset [99870] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
09:09 Changeset [99869] by andreas.kling@nokia.com
  • 7 edits in trunk

Cache and reuse HTMLCollections exposed by Document.
<http://webkit.org/b/71956>

Reviewed by Antti Koivisto.

Source/WebCore:

Let Document cache the various HTMLCollection objects it exposes.
They're created on-demand and stored in a tight Vector.
This is a behavior change, since the lifetime of returned collections
is now tied to the lifetime of the Document. However, this matches the
current behavior of Firefox and Opera.

This reduces memory consumption by ~800 kB (on 64-bit) when loading
the full HTML5 spec. document.links was called 34001 times, yielding
34001 separate HTMLCollections, and now we only need 1.

The document.all collection retains the old behavior, as caching it
would be a bit more complicated.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::collection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):

  • dom/Document.h:
  • html/CollectionType.h:

LayoutTests:

Update fast/dom/gc-9.html to document the new lifetime behavior of
HTMLCollection objects returned by document.

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
09:07 Changeset [99868] by tonyg@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Chromium layout test rebaseline.

  • platform/chromium-win/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png.
09:07 Changeset [99867] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix.
https://bugs.webkit.org/show_bug.cgi?id=72022

Reviewed by Pavel Feldman.

On any suggest box position update (updateSuggestions invocation) an anchor is created at the beginning
of the user-entered word, and its box is ultimately passed into _updateBoxPosition to be used as the
actual anchor box (instead of the input element box).

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._boxForAnchorAtStart):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

  • inspector/front-end/utilities.js:

(AnchorBox):
(Element.prototype.offsetRelativeToWindow):

09:05 Changeset [99866] by ryuan.choi@samsung.com
  • 6 edits
    8 moves in trunk/Source

[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
https://bugs.webkit.org/show_bug.cgi?id=56705

Reviewed by Adam Roben.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • PlatformEfl.cmake: Renamed from Source/JavaScriptCore/CMakeListsEfl.txt.
  • PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/CMakeListsWinCE.txt.
  • shell/CMakeLists.txt:
  • shell/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsEfl.txt.
  • shell/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsWinCE.txt.
  • wtf/CMakeLists.txt:
  • wtf/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsEfl.txt.
  • wtf/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsWinCE.txt.

Source/WebCore:

No new tests, just renaming CMakeLists*.txt to Platform*.cmake.

  • CMakeLists.txt:
  • PlatformEfl.cmake: Renamed from Source/WebCore/CMakeListsEfl.txt.
  • PlatformWinCE.cmake: Renamed from Source/WebCore/CMakeListsWinCE.txt.
09:03 Changeset [99865] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix CCLayerTreeHostImplTest::scrollRootCallsCommitAndRedraw
https://bugs.webkit.org/show_bug.cgi?id=72027

We weren't calling setScrollable(true) when setting up the test, so
scroll events were being ignored. Test failed in debug builds, but passed
in release because we were using ASSERT instead of ASSERT_TRUE.

Patch by Iain Merrick <husky@google.com> on 2011-11-10
Reviewed by Tony Gentilcore.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

08:49 Changeset [99864] by caseq@chromium.org
  • 6 edits
    1 delete in trunk

Web Inspector: wrong JSON.stringify used in webInspector.inspectedWindow.eval() backend
https://bugs.webkit.org/show_bug.cgi?id=63083

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.InspectedWindow.prototype.eval):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

LayoutTests:

  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/extensions/extensions-eval.html:
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
08:47 Changeset [99863] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Fix remaining gtkdoc errors
https://bugs.webkit.org/show_bug.cgi?id=71990

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitWebView.cpp: Update add the phrase "property" to

references to properties, because the gtkdoc stylesheet does not differeniate
between properties and signals. Standardize the way we talk about property
notifications.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add an include to silence

warnings about GIR annotations.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the decorators the private section.
08:47 Changeset [99862] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

SVG object covers CSS background in HTML foreignObject
https://bugs.webkit.org/show_bug.cgi?id=58417

Patch by Florin Malita <fmalita@google.com> on 2011-11-10
Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/foreignObject/background-render-phase.html

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

Paint SVG foreign objects atomically, following the same pattern as
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/InlineBox.cpp#L209.

LayoutTests:

  • svg/foreignObject/background-render-phase-expected.png: Added.
  • svg/foreignObject/background-render-phase-expected.txt: Added.
  • svg/foreignObject/background-render-phase.html: Added.
08:31 Changeset [99861] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r99851.
http://trac.webkit.org/changeset/99851
https://bugs.webkit.org/show_bug.cgi?id=72029

Patch breaks Qt tests (Requested by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::clearUseElements):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance):

LayoutTests:

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Removed.
  • svg/custom/element-instance-held-by-js-crash.svg: Removed.
08:27 Changeset [99860] by kenneth@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt] Clean up how singe / double taps are handled
https://bugs.webkit.org/show_bug.cgi?id=72024

Reviewed by Simon Hausmann.

Move all decision making to the QtWebPageProxy.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleSingleTapEvent):
(QtWebPageProxy::handleDoubleTapEvent):

  • UIProcess/qt/QtWebPageProxy.h:
08:15 Changeset [99859] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline one test on Mac, to turn SL bots green again.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
08:09 Changeset [99858] by zimmermann@webkit.org
  • 7 edits in trunk/LayoutTests

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline Qt results after r99854.

  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/custom/text-filter-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
08:03 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Add links for the QtWebKit2.2 productization branch buildbots (diff)
07:58 Changeset [99857] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: fixed new inspector media-query CSS test on Qt.

  • inspector/styles/media-queries.html:
07:42 Changeset [99856] by zimmermann@webkit.org
  • 4 edits in trunk

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

[GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
https://bugs.webkit.org/show_bug.cgi?id=71932

Reviewed by Philippe Normand.

  • platform/gtk/Skipped: Unskip test.

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

[GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
https://bugs.webkit.org/show_bug.cgi?id=71932

Reviewed by Philippe Normand.

Null check m_page in drawSVGToImageBuffer(), just like all others methods do.
As drawSVGToImageBuffer() is fired from a timer, it may get into this state under certain conditions, as seen on the 64bit gtk bot.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::drawSVGToImageBuffer):
07:40 Changeset [99855] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rolling out part of r99854, which didn't belong there.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::drawSVGToImageBuffer):
07:33 Changeset [99854] by zimmermann@webkit.org
  • 34 edits in trunk

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Move unit resolving for all resources to rendering/
https://bugs.webkit.org/show_bug.cgi?id=72011

Reviewed by Andreas Kling.

Update expected results for some filters tests, now that their bounding box is correctly dumped.

  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Move unit resolving for all resources to rendering/
https://bugs.webkit.org/show_bug.cgi?id=72011

Reviewed by Andreas Kling.

Remove maskBoundingBox()/filterBoundingBox(), to avoid doing length resolution in svg/.
RenderSVGResource* now uses SVGLengthContext::resolveRectangle, to do this while laying out.

Move linear gradient start/end point, radial gradient focal/center point, radius calculations into
their RenderSVGResource classes, cleanup code a bit.

Convert filters to use SVGLengthContext. Fix DRT dumps for filters, while I'm at it, to give
meaningful values, when objectBoundingBox is used as primitive units, when applying to <text>/<tspan>s.

Several tests results need rebaselines on all platforms.

  • platform/graphics/filters/Filter.h:
  • rendering/svg/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::objectBoundingBox):
  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::startPoint): (WebCore::RenderSVGResourceLinearGradient::endPoint): (WebCore::RenderSVGResourceLinearGradient::buildGradient):
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::centerPoint): (WebCore::RenderSVGResourceRadialGradient::focalPoint): (WebCore::RenderSVGResourceRadialGradient::radius): (WebCore::RenderSVGResourceRadialGradient::adjustFocalPointIfNeeded): (WebCore::RenderSVGResourceRadialGradient::buildGradient):
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer):
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGLinearGradientElement.cpp:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h:
  • svg/SVGRadialGradientElement.cpp:
  • svg/SVGRadialGradientElement.h:
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::filterRegionInUserSpace):
07:32 Changeset [99853] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix keyboard related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Send key events to the handling page item, not the view.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):

07:23 Changeset [99852] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Make the ENABLE(FEATURE) macro work in DRT
https://bugs.webkit.org/show_bug.cgi?id=71940

Patch by Alexandre Mazari <amazari@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

  • GNUmakefile.am:

Add webcore_cppflags to Programs_DumpRenderTree_CPP so
ENABLE_* variables are part of the environment.

07:23 Changeset [99851] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Source/WebCore:

Cleans up the object when it is detached from the shadow DOM tree,
rather than leaving it in a half-clean state with some nulled
references but not others.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

Test: svg/custom/element-instance-held-by-js-crash.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance): Added a call to
detach to clean up if deletion happens without a prior detach call (as
when an entire tree is removed).
(WebCore::SVGElementInstance::detach): New method that replaces other
clean-up methods when the instance is removed from the shadow DOM.

  • svg/SVGElementInstance.h: Added new detach method and removed

unnecessary clear methods.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance): Changed calls to clear to
instead detach.

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
  • svg/custom/element-instance-held-by-js-crash.svg: Added.
07:14 WebKit Team edited by andreas.kling@nokia.com
(diff)
07:12 Changeset [99850] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix focus related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Make sure the focus is set on the page now, not on the view
(which doesn't actually handle the focus).

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

06:56 Changeset [99849] by apavlov@chromium.org
  • 18 edits
    4 adds in trunk

Web Inspector: Show media queries associated with specific CSS rules
https://bugs.webkit.org/show_bug.cgi?id=65626

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/media-queries.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::updateLastMediaLine):

  • css/CSSParser.h:
  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):

  • css/MediaList.h:

(WebCore::MediaList::lastLine):
(WebCore::MediaList::setLastLine):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::documentURLString):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::buildObjectForRule):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule):
(WebInspector.CSSMedia):
(WebInspector.CSSMedia.parsePayload):
(WebInspector.CSSMedia.parseMediaArrayPayload):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyResourceAsNode):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):

  • inspector/front-end/elementsPanel.css:

(.styles-section .header .title .media, .styles-section .header .title .media .subtitle):
(.styles-section .header .subtitle):

LayoutTests:

  • inspector/styles/media-queries-expected.txt: Added.
  • inspector/styles/media-queries.html: Added.
  • inspector/styles/resources/media-queries-1.css: Added.

(body):
(#main):

  • inspector/styles/resources/media-queries.css: Added.

(#main):

  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-source-lines-expected.txt:
06:52 Changeset [99848] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] Do not display suggest box if editing in the middle of prompt unless a stop character follows
https://bugs.webkit.org/show_bug.cgi?id=72018

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

06:49 Changeset [99847] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: do not highlight files larger than 10KLOC.
https://bugs.webkit.org/show_bug.cgi?id=72025

This is a temporary measure while I am improving the highlighter
footprint. Otherwise, highlighting pretty printed Gmail takes ~1.3G of RAM.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._didRequestContent):

06:32 Changeset [99846] by hausmann@webkit.org
  • 4 edits
    1 delete in trunk

[Qt] Clean up build system

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate use of WebKit2.pri.

Source/WebKit2:

Now that we use whole-archive linking we can fold the files that contain exported
symbols back into the WebKit2 static library.

  • Target.pri: Fold in sources from WebKit2.pri.
  • WebKit2.pri: Removed.
06:09 Changeset [99845] by alexis.menard@openbossa.org
  • 47 edits
    10 adds
    19 deletes in trunk

[Qt] Merge QTouchWebView and QDesktopWebView into one class
https://bugs.webkit.org/show_bug.cgi?id=71355

Reviewed by Kenneth Rohde Christiansen.

.:

Remove old tests and merge them into the new QQuickWebView directory.

  • Source/tests.pri:

Source/WebKit/qt:

Register only QQuickWebView and QQuickWebPage in the plugin.

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Merge QTouchWebView and QDesktopWebView into one class called
QQuickWebView and its attached page QQuickWebPage. You can switch to the
traditional desktop use case with the private header. Also now on desktop
platforms AC is turn on by default. I also merged our two
subclasses of QtViewInterface into one as the split doesn't make
that much sense anymore. In the future we want to be able to enable the
traditional desktop use case depending the platform the code is running.
API tests and QML tests have been updated.

  • Target.pri:
  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qbasewebview.cpp: Removed.
  • UIProcess/API/qt/qbasewebview_p.h: Removed.
  • UIProcess/API/qt/qdesktopwebview.cpp: Removed.
  • UIProcess/API/qt/qdesktopwebview.h: Removed.
  • UIProcess/API/qt/qdesktopwebview_p.h: Removed.
  • UIProcess/API/qt/qquickwebpage.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp.

(QQuickWebPage::QQuickWebPage):
(QQuickWebPage::~QQuickWebPage):
(QQuickWebPage::keyPressEvent):
(QQuickWebPage::keyReleaseEvent):
(QQuickWebPage::inputMethodEvent):
(QQuickWebPage::focusInEvent):
(QQuickWebPage::focusOutEvent):
(QQuickWebPage::mousePressEvent):
(QQuickWebPage::mouseMoveEvent):
(QQuickWebPage::mouseReleaseEvent):
(QQuickWebPage::mouseDoubleClickEvent):
(QQuickWebPage::wheelEvent):
(QQuickWebPage::hoverEnterEvent):
(QQuickWebPage::hoverMoveEvent):
(QQuickWebPage::hoverLeaveEvent):
(QQuickWebPage::dragMoveEvent):
(QQuickWebPage::dragEnterEvent):
(QQuickWebPage::dragLeaveEvent):
(QQuickWebPage::dropEvent):
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPage::touchEvent):
(QQuickWebPage::itemChange):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::initializeSceneGraphConnections):
(QQuickWebPagePrivate::setPageProxy):
(computeEffectiveOpacity):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPagePrivate::_q_onAfterSceneRender):
(QQuickWebPagePrivate::_q_onSceneGraphInitialized):

  • UIProcess/API/qt/qquickwebpage.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
  • UIProcess/API/qt/qquickwebpage_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
  • UIProcess/API/qt/qquickwebview.cpp: Added.

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::contentSizeChanged):
(QQuickWebViewPrivate::scrollPositionRequested):
(QQuickWebViewPrivate::_q_viewportUpdated):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::_q_onVisibleChanged):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::updateViewportConstraints):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewPrivate::_q_onOpenPanelFilesSelected):
(QQuickWebViewPrivate::_q_onOpenPanelFinished):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(toPolicyAction):
(hasMetaMethod):
(QQuickWebViewPrivate::navigationPolicyForURL):
(QQuickWebViewPrivate::setPageProxy):
(QQuickWebView::QQuickWebView):
(QQuickWebView::~QQuickWebView):
(QQuickWebView::page):
(QQuickWebView::load):
(QQuickWebView::postMessage):
(QQuickWebView::url):
(QQuickWebView::loadProgress):
(QQuickWebView::title):
(QQuickWebView::navigationController):
(QQuickWebView::preferences):
(QQuickWebView::geometryChanged):
(QQuickWebView::touchEvent):
(QQuickWebView::pageRef):

  • UIProcess/API/qt/qquickwebview.h: Renamed from Source/WebKit2/UIProcess/API/qt/qbasewebview.h.
  • UIProcess/API/qt/qquickwebview_p.h: Added.
  • UIProcess/API/qt/qtouchwebview.cpp: Removed.
  • UIProcess/API/qt/qtouchwebview.h: Removed.
  • UIProcess/API/qt/qtouchwebview_p.h: Removed.
  • UIProcess/API/qt/tests/commonviewtests/commonviewtests.pro: Removed.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp: Removed.
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: Removed.
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h: Removed.
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(DesktopWebView::DesktopWebView):
(main):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/qdesktopwebview.pro.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Added.

(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::cleanup):
(tst_QQuickWebView::webView):
(tst_QQuickWebView::accessPage):
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::baseUrl):
(tst_QQuickWebView::loadEmptyUrl):
(tst_QQuickWebView::loadEmptyPageViewVisible):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::show):

  • UIProcess/API/qt/tests/qtouchwebview/qtouchwebview.pro: Removed.
  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: Removed.
  • UIProcess/API/qt/tests/testwindow.h:
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):
(WebKit::QtGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::setViewportInteractionEngine):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):
(WebKit::QtPinchGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTouchViewInterface.cpp: Removed.
  • UIProcess/qt/QtTouchViewInterface.h: Removed.
  • UIProcess/qt/QtViewInterface.cpp: Added.

(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::didFindZoomableArea):
(WebKit::QtViewInterface::sceneGraphUpdateQueue):
(WebKit::QtViewInterface::setViewNeedsDisplay):
(WebKit::QtViewInterface::drawingAreaSize):
(WebKit::QtViewInterface::contentSizeChanged):
(WebKit::QtViewInterface::scrollPositionRequested):
(WebKit::QtViewInterface::isActive):
(WebKit::QtViewInterface::hasFocus):
(WebKit::QtViewInterface::isVisible):
(WebKit::QtViewInterface::startDrag):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::didChangeUrl):
(WebKit::QtViewInterface::didChangeTitle):
(WebKit::QtViewInterface::didChangeToolTip):
(WebKit::QtViewInterface::didChangeStatusText):
(WebKit::QtViewInterface::didChangeCursor):
(WebKit::QtViewInterface::loadDidBegin):
(WebKit::QtViewInterface::loadDidCommit):
(WebKit::QtViewInterface::loadDidSucceed):
(WebKit::QtViewInterface::loadDidFail):
(WebKit::QtViewInterface::didChangeLoadProgress):
(WebKit::QtViewInterface::didMouseMoveOverElement):
(WebKit::QtViewInterface::showContextMenu):
(WebKit::QtViewInterface::hideContextMenu):
(WebKit::QtViewInterface::runJavaScriptAlert):
(WebKit::QtViewInterface::runJavaScriptConfirm):
(WebKit::QtViewInterface::runJavaScriptPrompt):
(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):
(WebKit::QtViewInterface::engine):
(WebKit::QtViewInterface::downloadRequested):
(WebKit::QtViewInterface::chooseFiles):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::setViewportInteractionEngine):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
  • WebKit2.pri:

Tools:

Make MiniBrowser and WebKitTestRunner work again after the
merge.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:
  • MiniBrowser/qt/main.cpp:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/DesktopView.qml: Removed.
  • MiniBrowser/qt/qml/TouchView.qml: Removed.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

06:08 Changeset [99844] by hclam@chromium.org
  • 15 edits in trunk/Source

[chromium] Scroll deltas are cleared during commit to the main thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

The patch keeps the scroll deltas and scroll position unchanged when
committing to the main thread. After commit has completed on the main
thread the submitted scroll deltas are then subtracted from the current
scroll deltas on the impl thread.

Doing so allow scroll deltas to be available at all time which enables
proper positioning for layers that are fixed-positioned to the
container layer.

This patch is tested by the following unit tests:

  • CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls This test is modified to verify that scroll deltas and scroll position are unchanged during commit. And then after commit scroll deltas are subtracted correctly.
  • CCLayerTreeHostTestScrollSimple.runMultiThread and CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread These tests verifies that scroll deltas made on impl thread are committed to the main thread. The scroll deltas is eventually delegated to CCLayerTreeHostClient. When commit has completed the scroll deltas are subtracted correctly. There's no change to these two tests but they verify this patch maintains the overall behavior of scrolling.
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::applyScrollAndScale):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::applyScrollAndScaleInternal):
(WebCore::CCLayerTreeHostCommon::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls
This test is modified to verify that CCLayerTreeHostImpl::processScrollDeltas()
maintain the current scroll deltas and scroll positions.
It also verifies that scroll deltas are subtracted correctly by calling
CCLayerTreeHostCommon::applyScrollAndScale().

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
call setLayerTreeHost() on the root layer.

05:59 Changeset [99843] by vestbo@webkit.org
  • 6 edits in trunk

[Qt] Change semantics of the haveQt() function to match API promises

Having Qt 5 does not imply that we have Qt 4, from an API point of
view, as a major version can in theory break BC/SC. Our minimum
version of Qt 4 will always be the latest released version of Qt 4,
so the only place we should use haveQt(4, x) is when checking for
the minimum requirements.

Reviewed-by Simon Hausmann.

05:59 Changeset [99842] by carlosgc@webkit.org
  • 7 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.am: Add missing files.
  • GNUmakefile.list.am: Ditto.

Source/WebKit2:

  • GNUmakefile.am: Fix typos in gtk-doc files and scripts.
05:26 Changeset [99841] by ossy@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

[Qt] Unreviewed trivial fix after r99721.

  • platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt.
04:57 Changeset [99840] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Correct editing/spelling/markers.html expecations
https://bugs.webkit.org/show_bug.cgi?id=72015

This test was added in http://trac.webkit.org/changeset/99814 with no expectations so
it needs to be marked MISSING instead of FAIL.

  • platform/chromium/test_expectations.txt:
04:38 Changeset [99839] by sergio@webkit.org
  • 7 edits in trunk

[WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=69411

Reviewed by Martin Robinson.

Tools:

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
use the EventSender instead of WebProcess Event Simulation.

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::WTREventQueueItem::WTREventQueueItem):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButtonModifiers):
(WTR::eventSenderButtonToGDKButton):
(WTR::EventSenderProxy::createMouseButtonEvent):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::webkitModifiersToGDKModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Unskip tests that were previously failing due to the lack of
MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward. Also
moved around some other tests to their proper section.

  • platform/gtk-wk2/Skipped:
04:26 Changeset [99838] by zimmermann@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Deploy SVGLengthContext in more places
https://bugs.webkit.org/show_bug.cgi?id=72012

Reviewed by Simon Hausmann.

Doesn't affect any tests.

  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
  • svg/SVGAnimatedLengthList.cpp: (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
04:23 Changeset [99837] by hausmann@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed Mac build fix: Remove TapAndHold gesture type.

It broke the build because it's unhandled. Remove it since it's not
supported at the moment anyway. (looks like an accidental addition?)

  • Shared/WebEvent.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):

04:02 WebKit Team edited by zeno.albisser@nokia.com
(diff)
03:43 Changeset [99836] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix build.

  • WebCore.gypi: Need to add rendering/svg/SVGPathData.* in another place as well, cr-bots are not compiling it and thus fail linking.
03:42 Changeset [99835] by yutak@chromium.org
  • 5 edits
    3 moves
    1 add in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 6)

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/embedding-external-svgs-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/embedding-external-svgs-expected.png.
  • platform/chromium/test_expectations.txt:
03:41 Changeset [99834] by hausmann@webkit.org
  • 6 edits in trunk

Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf: Use --whole-archive and their

mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

03:17 Changeset [99833] by zimmermann@webkit.org
  • 27 edits
    2 adds in trunk/Source/WebCore

2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Remove virtual toPathData() method from all graphics elements
https://bugs.webkit.org/show_bug.cgi?id=72009

Reviewed by Zoltan Herczeg.

In bug 71780, SVGLengthContext was introduced, to allow to resolve SVGLengths against arbitary viewports.
SVGLength::value(), which needs a SVGLengthContext, is still used all over svg/ - that should be changed, as rendering/
should resolve these lengths, as HTML does it using Length & RenderStyles for CSS.

As first step, move the #1 client of the SVGLength::value() methods - toPathData() out of svg/ into rendering/svg/SVGPathData
as free-function, replacing the virtual toPathData() function from SVGStyledTransformableElement.

Doesn't affect any tests.

  • CMakeLists.txt: Add rendering/svg/SVGPathData.* to build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/svg/RenderSVGAllInOne.cpp: Ditto.
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout): Use "updatePathFromGraphicsElement(element, m_path)" instead of "element->toPathData(m_path)", avoiding a virtual call.
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath): Ditto.
  • rendering/svg/SVGPathData.cpp: Added. (WebCore::updatePathFromCircleElement): (WebCore::updatePathFromEllipseElement): (WebCore::updatePathFromLineElement): (WebCore::updatePathFromPathElement): (WebCore::updatePathFromPolygonElement): (WebCore::updatePathFromPolylineElement): (WebCore::updatePathFromRectElement): (WebCore::updatePathFromGraphicsElement):
  • rendering/svg/SVGPathData.h: Added.
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath): Use updatePathFromGraphicsElement instead of toPathData.
  • svg/SVGCircleElement.cpp: Remove toPathData() virtual method.
  • svg/SVGCircleElement.h: Ditto.
  • svg/SVGEllipseElement.cpp: Ditto.
  • svg/SVGEllipseElement.h: Ditto.
  • svg/SVGLineElement.cpp: Ditto.
  • svg/SVGLineElement.h: Ditto.
  • svg/SVGPathElement.cpp: Ditto.
  • svg/SVGPathElement.h: Ditto.
  • svg/SVGPolygonElement.cpp: Ditto.
  • svg/SVGPolygonElement.h: Ditto.
  • svg/SVGPolylineElement.cpp: Ditto.
  • svg/SVGPolylineElement.h: Ditto.
  • svg/SVGRectElement.cpp: Ditto.
  • svg/SVGRectElement.h: Ditto.
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::toClipPath): Use updatePathFromGraphicsElement instead of toPathData.
  • svg/SVGStyledTransformableElement.h: Remove toPathData() virtual method.
03:11 Changeset [99832] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Make sure headers.pri has the right relative paths for install

The install rules are generated from api.pri which lives in Source,
which means the paths in headers.pri, which is the basis for the
install rules, needs to be relative to Source as well.

We were also installing the headers from the forwarding headers
directory, which was wrong, as those headers contained relative paths.

We now install the actual headers, by using headers.pri as a basis.

https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

02:46 Changeset [99831] by zeno.albisser@nokia.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Add Tap Gesture recognition to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=71841

Add a Tap gesture recognizer that delivers GestureSingleTap
and GestureTapAndHold events through the WebPageProxy.
Add a GestureTapAndHold to WebEvent.
Add a DoubleTap gesture for zooming in and out.

This patch is based on work of Benjamin Poulain.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-10
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:
  • Target.pri:
  • UIProcess/qt/QtTapGestureRecognizer.cpp: Added.

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::setWebPageProxy):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):

  • UIProcess/qt/QtTapGestureRecognizer.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageProxy.h:
02:41 Changeset [99830] by yutak@chromium.org
  • 7 edits
    2 moves
    7 adds
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 5)

  • platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/animated-svg-as-mask-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/animated-svg-as-background-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium/test_expectations.txt:
02:09 Changeset [99829] by caseq@chromium.org
  • 6 edits in trunk

Web Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71922

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.activateBreakpoints):
(WebInspector.ScriptsPanel.prototype.folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.addToWatch):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

02:03 Changeset [99828] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • fast/harness/results-expected.txt: Update after r99818.
01:46 Changeset [99827] by yutak@chromium.org
  • 6 edits
    1 move
    18 adds
    5 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 4)

  • platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/svg-as-mask-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
01:39 Changeset [99826] by jcivelli@chromium.org
  • 7 edits
    1 add in trunk/Source

Fix progress load reporting for MHTML documents.

MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859

Reviewed by Adam Barth.

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):

  • tests/data/page_with_image.mht: Added.
01:37 Changeset [99825] by hausmann@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Fix linking with --whole-archive

Reviewed by Zoltan Herczeg.

Compile XMLTreeViewer and related files when XSLT is enabled, not
when XSLT _and_ USE_LIBXML2. The files do not depend on libxml2, they
are #ifdeffed with ENABLE(XSLT) only, and they are referenced from for
example NewXMLDocumentParser.cpp from within XSLT blocks.

  • DerivedSources.pri:
  • Target.pri:
01:22 Changeset [99824] by yutak@chromium.org
  • 11 edits
    14 adds
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 3)

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/chromium-cg-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
01:19 Changeset [99823] by podivilov@chromium.org
  • 16 edits
    3 moves
    5 deletes in trunk

Web Inspector: load source maps via front-end host.
https://bugs.webkit.org/show_bug.cgi?id=71301

Reviewed by Yury Semikhatsky.

Source/WebCore:

Currently we use an auxiliary iframe hack to load source map files from inspector page. This approach has several drawbacks:

  • in addition to source map url we need to know auxiliary iframe url
  • we need a protocol to communicate with iframe
  • source map provider needs to provide auxiliary document to make our hack work

Loading source maps from front-end host solves all problems.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::loadResourceSynchronously):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.load):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappingPayload):

  • inspector/front-end/CompilerSourceMappingProvider.js: Removed.
  • inspector/front-end/ContentProviders.js:

(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype.setCompilerSourceMapping):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.installSourceMappingForTest):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-provider-expected.txt: Removed.
  • http/tests/inspector/compiler-source-mapping-provider.html: Removed.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Removed.
  • http/tests/inspector/resources/source-map.json: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.
  • http/tests/inspector/resources/source1.js: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app.js.

(window.onload):
(handleClick):

  • http/tests/inspector/resources/source2.js: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/foo.js.

(ClickHandler):
(ClickHandler.prototype.handle):

  • inspector/debugger/compiler-source-mapping.html: Removed.
00:28 Changeset [99822] by yutak@chromium.org
  • 23 edits
    1 move
    8 adds
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 2)

  • platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium/test_expectations.txt:
00:17 Changeset [99821] by loislo@chromium.org
  • 10 edits
    8 deletes in trunk

Unreviewed, rolling out r99816.
http://trac.webkit.org/changeset/99816
https://bugs.webkit.org/show_bug.cgi?id=72003

compilation failed on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):

  • html/HTMLTextAreaElement.idl:
  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:
  • html/TextFieldInputType.h:

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Removed.
  • fast/forms/form-dirname-attribute.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute.html: Removed.
00:08 Changeset [99820] by yutak@chromium.org
  • 23 edits
    1 move
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 1)

  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.