Timeline


and

11/16/11:

23:59 Changeset [100569] by carlosgc@webkit.org

[GTK] Use a URI instead of local path to create download destination in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72500

Reviewed by Philippe Normand.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Use
g_file_new_for_uri() instad of g_file_new_for_path(). Also use
adoptGRef to fix a memory leak.

23:50 Changeset [100568] by cevans@google.com

Merge 99731
BUG=89493
Review URL: http://codereview.chromium.org/8591014

23:46 Changeset [100567] by cevans@google.com

Merge 99565
BUG=102810
Review URL: http://codereview.chromium.org/8588025

23:42 Changeset [100566] by cevans@google.com

Merge 99649
BUG=102037
Review URL: http://codereview.chromium.org/8591013

23:24 Changeset [100565] by dino@apple.com

Implement filter function shorthands
https://bugs.webkit.org/show_bug.cgi?id=68475

Reviewed by Simon Fraser.

Source/WebCore:

Implement the shorthand functions for filter effects.
This includes grayscale, sepia, invert, hue-rotate, saturate,
opacity, gamma, drop-shadow and blur. At the moment sharpen
and url are not supported.

CSSParser needed to be updated because it was mistakenly
clamping saturation values to [0,1]. Any positive number
is allowed so you can produce super-saturated images.

The biggest change was the API to FilterEffectRenderer. It now
builds a list of effects and applies the filter itself.

Note that the drop-shadow and blur operations don't yet
provide accurate results because they produce an output image
that is larger than the input. See
https://bugs.webkit.org/show_bug.cgi?id=71929
https://bugs.webkit.org/show_bug.cgi?id=71930

While I was there, I fixed a small style issue in
CustomFilterOperation.

Tests: css3/filters/effect-blur.html

css3/filters/effect-combined.html
css3/filters/effect-drop-shadow.html
css3/filters/effect-gamma.html
css3/filters/effect-grayscale.html
css3/filters/effect-hue-rotate.html
css3/filters/effect-invert.html
css3/filters/effect-opacity.html
css3/filters/effect-saturate.html
css3/filters/effect-sepia.html

  • WebCore.xcodeproj/project.pbxproj: Add StyleShader.h to

the project (missing from earlier commit).

  • css/CSSParser.cpp:

(WebCore::CSSParser::isValidFilterArgument): Don't clamp
saturate to [0,1]

  • platform/graphics/filters/CustomFilterOperation.h:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::endMatrixRow):
(WebCore::lastMatrixRow):
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::inputContext):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):
(WebCore::FilterEffectRenderer::apply):

  • rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::output):
(WebCore::FilterEffectRenderer::setMaxEffectRects):
(WebCore::FilterEffectRenderer::lastEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):

LayoutTests:

Test the shorthand functions for filter effects.
This includes grayscale, sepia, invert, hue-rotate, saturate,
opacity, gamma, drop-shadow and blur. At the moment sharpen
and url are not supported.

Note that the drop-shadow and blur operations don't yet
provide accurate results because they produce an output image
that is larger than the input. See
https://bugs.webkit.org/show_bug.cgi?id=71929
https://bugs.webkit.org/show_bug.cgi?id=71930

  • css3/filters/effect-blur-expected.png: Added.
  • css3/filters/effect-blur-expected.txt: Added.
  • css3/filters/effect-blur.html: Added.
  • css3/filters/effect-combined-expected.png: Added.
  • css3/filters/effect-combined-expected.txt: Added.
  • css3/filters/effect-combined.html: Added.
  • css3/filters/effect-drop-shadow-expected.png: Added.
  • css3/filters/effect-drop-shadow-expected.txt: Added.
  • css3/filters/effect-drop-shadow.html: Added.
  • css3/filters/effect-gamma-expected.png: Added.
  • css3/filters/effect-gamma-expected.txt: Added.
  • css3/filters/effect-gamma.html: Added.
  • css3/filters/effect-grayscale-expected.png: Added.
  • css3/filters/effect-grayscale-expected.txt: Added.
  • css3/filters/effect-grayscale.html: Added.
  • css3/filters/effect-hue-rotate-expected.png: Added.
  • css3/filters/effect-hue-rotate-expected.txt: Added.
  • css3/filters/effect-hue-rotate.html: Added.
  • css3/filters/effect-invert-expected.png: Added.
  • css3/filters/effect-invert-expected.txt: Added.
  • css3/filters/effect-invert.html: Added.
  • css3/filters/effect-opacity-expected.png: Added.
  • css3/filters/effect-opacity-expected.txt: Added.
  • css3/filters/effect-opacity.html: Added.
  • css3/filters/effect-saturate-expected.png: Added.
  • css3/filters/effect-saturate-expected.txt: Added.
  • css3/filters/effect-saturate.html: Added.
  • css3/filters/effect-sepia-expected.png: Added.
  • css3/filters/effect-sepia-expected.txt: Added.
  • css3/filters/effect-sepia.html: Added.
  • css3/filters/resources/reference.png: Added.
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:
23:11 Changeset [100564] by haraken@chromium.org

Remove all custom constructors of Events from JSC
https://bugs.webkit.org/show_bug.cgi?id=72577

Reviewed by Adam Barth.

  • Makes CodeGeneratorJS.pm generate Event constructors

if [ConstructorTemplate=Event] IDL is specified.

  • Removes EventConstructors.h and JSEventConstructors.cpp.
  • Replaces all JSC custom constructors of Events

with the generated code by [ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

  • bindings/generic/EventConstructors.h: Removed. This is what we wanted to do in this patch.
  • bindings/js/JSEventConstructors.cpp: Ditto.
  • GNUmakefile.list.am: Removed EventConstructors.h and JSEventConstructors.cpp.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Added JSDictionary.h.
(GenerateConstructorDeclaration): Added a header for fillXXXXEventInit(...).
(GenerateConstructorDefinition): Generates an Event constructor. The generated code is the same as the code that had been written in JSEventConstructors.cpp.
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].

  • bindings/scripts/test/TestEventConstructor.idl: Changed 'CustomConstructor=Event' to 'ConstructorTemplate=Event'. We should have changed this in r100108.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Updated a run-bindings-tests result.

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.
  • dom/BeforeLoadEvent.idl: In essence, replaced [JSCustomConstructor] IDL with [JSConstructorTemplate=Event] IDL.
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/Event.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/OverflowEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • dom/WebKitTransitionEvent.idl: Ditto.
  • html/track/TrackEvent.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
22:33 Changeset [100563] by dino@apple.com

Build fix for Apple WebKit due to r100560.
When I removed the violating header file it lost the
reference to Color.

No review.

  • platform/graphics/filters/FilterOperation.h:
22:22 Changeset [100562] by rniwa@webkit.org

Add a list of contribution areas
https://bugs.webkit.org/show_bug.cgi?id=72566

Reviewed by Eric Seidel.

Added ContributionAreas class.

  • Scripts/webkitpy/common/config/contributionareas.py: Added.
  • Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
22:20 Changeset [100561] by rniwa@webkit.org

Refactor ChangeLogTest.test_parse_reviewer_text
https://bugs.webkit.org/show_bug.cgi?id=72572

Reviewed by Eric Seidel.

Refactored the test code by introduing two helper functions.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
21:24 Changeset [100560] by dino@apple.com

DropShadowFilterOperation violates platform isolation
https://bugs.webkit.org/show_bug.cgi?id=72544

Reviewed by Simon Fraser.

Move ShadowData properties into the DropShadowFilterOperation
to avoid depending on something outside platform.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::DropShadowFilterOperation::create):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::stdDeviation):
(WebCore::DropShadowFilterOperation::color):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):

21:14 Changeset [100559] by jamesr@google.com

[chromium] Update more chromium baselines and expectations

  • platform/chromium-cg-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium/test_expectations.txt:
21:08 Changeset [100558] by eric@webkit.org

Add SCMDetector object to make scm detection mockable
https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
20:51 Changeset [100557] by jamesr@google.com

[chromium] Update baselines for compositing tests with video and canvas

  • platform/chromium-cg-mac-leopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/geometry/clipped-video-controller-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/video-page-visibility-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-lion/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
19:58 Changeset [100556] by fpizlo@apple.com

Code block jettisoning should be part of the GC's transitive closure
https://bugs.webkit.org/show_bug.cgi?id=72467

Reviewed by Geoff Garen.

Replaced JettisonedCodeBlocks with DFGCodeBlocks. The latter knows about all
DFG code blocks (i.e. those that may be jettisoned, and may have inlined weak
references) and helps track what state each of those code blocks is in during
GC. The state consists of two flags; mayBeExecuting, which tells if the code block
is live from call frames; and isJettisoned, which tells if the code block is
not owned by any executable and thus should be deleted as soon as it is not
mayBeExecuting.

  • Not executing, Not jettisoned: The code block may or may not be reachable from any executables, but it is owned by an executable, and hence should be kept alive if its executable is live and if all of its weak references are live. Otherwise it should be deleted during the current GC cycle, and its outgoing references should not be scanned.


  • Not executing but jettisoned: The code block should be deleted as soon as possible and none of its outgoing references should be scanned.


  • Executing but not jettisoned: The code block should be kept alive during this GC cycle, and all of its outgoing references (including the weak ones) should be scanned and marked strongly. The mayBeExecuting bit will be cleared at the end of the GC cycle.


  • Executing and jettisoned: The code block should be kept alive during this GC cycle, and all of its outgoing references (including the weak ones) should be scanned and marked strongly. However, on the next GC cycle, it will have its mayBeExecuting bit cleared and hence it will become a candidate for immediate deletion provided it is not executing again.

This is performance-neutral.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::DFGData::DFGData):
(JSC::DFGCodeBlocks::mark):

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::add):

  • heap/ConservativeRoots.h:
  • heap/DFGCodeBlocks.cpp: Added.

(JSC::DFGCodeBlocks::DFGCodeBlocks):
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):

  • heap/DFGCodeBlocks.h: Added.
  • heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/JettisonedCodeBlocks.cpp: Removed.
  • heap/JettisonedCodeBlocks.h: Removed.
  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:
  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):

19:50 Changeset [100555] by commit-queue@webkit.org

Use a simple page client for user consent in getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=70897

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-11-16
Reviewed by Adam Barth.

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Covered by existing tests.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/MediaStreamClient.h: Removed.
  • mediastream/MediaStreamController.cpp: Removed.
  • mediastream/MediaStreamController.h: Removed.
  • mediastream/MediaStreamFrameController.cpp: Removed.
  • mediastream/MediaStreamFrameController.h: Removed.
  • mediastream/UserMediaClient.h: Added.

(WebCore::UserMediaClient::~UserMediaClient):

  • mediastream/UserMediaRequest.cpp: Added.

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::~UserMediaRequest):
(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::fail):
(WebCore::UserMediaRequest::contextDestroyed):
(WebCore::UserMediaRequest::parseOptions):

  • mediastream/UserMediaRequest.h: Added.

(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):
(WebCore::UserMediaRequest::successCallback):
(WebCore::UserMediaRequest::errorCallback):

  • page/CallbackTask.h: Removed.
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):

  • page/Frame.h:
  • page/Navigator.cpp:

(WebCore::Navigator::webkitGetUserMedia):

  • page/NavigatorUserMediaErrorCallback.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore::Page::userMediaClient):

19:42 Changeset [100554] by jamesr@google.com

[chromium] Fix duplicate expectations for chromium mac leopard

  • platform/chromium/test_expectations.txt:
19:32 Changeset [100553] by mrowe@apple.com

Fix the build.

The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
Apply the workaround that we use in other projects to WebKitTestRunner.

  • WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
  • WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
19:22 Changeset [100552] by dgrogan@chromium.org

instantiate WorkerEventQueue in WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=72528

Reviewed by David Levin.

No new tests - nothing uses it yet.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):
Instantiate WorkerEventQueue in InitializerList

  • workers/WorkerEventQueue.h:

Don't inherit from RefCounted, WorkerContext has an OwnPtr to it

19:13 Changeset [100551] by haraken@chromium.org

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructor::releaseImpl):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::impl):
(WebCore::JSTestInterface::releaseImpl):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::impl):
(WebCore::JSTestMediaQueryListListener::releaseImpl):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::impl):
(WebCore::JSTestNamedConstructor::releaseImpl):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::impl):
(WebCore::JSTestObj::releaseImpl):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::impl):
(WebCore::JSTestSerializedScriptValueInterface::releaseImpl):

19:08 Changeset [100550] by jcivelli@chromium.org

Make sure MHTML documents use the domain of the MHTML file.
https://bugs.webkit.org/show_bug.cgi?id=72445

Reviewed by Adam Barth.

Source/WebCore:

  • dom/Document.h:

(WebCore::Document::setBaseURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

LayoutTests:

  • mhtml/check_domain-expected.txt: Added.
  • mhtml/check_domain.mht: Added.
19:06 Changeset [100549] by caio.oliveira@openbossa.org

[Qt] Fix build after WTR AX support
https://bugs.webkit.org/show_bug.cgi?id=72560

Reviewed by Geoffrey Garen.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

Tools:

  • WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  • WebKitTestRunner/InjectedBundle/Target.pri:
18:58 Changeset [100548] by tony@chromium.org

repurpose the flexbox bot for grid layout
https://bugs.webkit.org/show_bug.cgi?id=72557

Reviewed by Ryosuke Niwa.

Since new flexbox is enabled everywhere, we don't need this bot
anymore. However, work on grid layout has begun, so we can use this
bot to compile with ENABLE_CSS_GRID_LAYOUT.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Just rename

the bot on the waterfall, I will change the slave config to enable
the compile flag and tests.

18:54 Changeset [100547] by gyuyoung.kim@samsung.com

[EFL] Use standard booleand data type in struct.
https://bugs.webkit.org/show_bug.cgi?id=72565

Reviewed by Martin Robinson.

Change *Eina_Bool* usages with *bool* in member variables of internal struct.

  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_view.cpp:
18:20 Changeset [100546] by jchaffraix@webkit.org

Update supported display list after -webkit-grid and -webkit-inline-grid addition
https://bugs.webkit.org/show_bug.cgi?id=72559

Reviewed by Tony Chang.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added the 2 new supported
values (forgotten in the previous change).

18:09 Changeset [100545] by enne@google.com

[chromium] Expose mock scrollbars to window.internals
https://bugs.webkit.org/show_bug.cgi?id=72195

Reviewed by James Robinson.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • testing/Internals.cpp:

(WebCore::Internals::setMockScrollbarsEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMockScrollbarsEnabled):

  • src/WebSettingsImpl.h:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Because mock scrollbars are a global setting, reset between runs.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

LayoutTests:

Change a small number of initial tests that are failing on Chromium
due to small scrollbar pixel differences to use mock scrollbars. These
tests will be rebaselined once they have run through the bots.

  • compositing/geometry/fixed-position.html:
  • compositing/geometry/horizontal-scroll-composited.html:
  • compositing/geometry/vertical-scroll-composited.html:
  • compositing/overflow/fixed-position-ancestor-clip.html:
  • compositing/resources/mock_scrollbars.js: Added.
18:00 Changeset [100544] by fpizlo@apple.com

Unreviewed, build fix for 32-bit.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:53 Changeset [100543] by lforschler@apple.com

Fix the build.

17:49 Changeset [100542] by eae@chromium.org

Update chromium/mac port

17:46 Changeset [100541] by michaeln@google.com

ApplicationCache manifest should work with any MIME type.
https://bugs.webkit.org/show_bug.cgi?id=72082

Source/WebCore:

Reviewed by Alexey Proskuryakov.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Remove the test for a particular type.

LayoutTests:

Update the wrong-content-type test to expect the appcache to succeed given a text/plain contentType.

Reviewed by Alexey Proskuryakov.

  • http/tests/appcache/wrong-content-type-expected.txt:
  • http/tests/appcache/wrong-content-type.html:
  • platform/chromium/test_expectations.txt: Temporarily skip this test in chromium.
  • platform/chromium-cg-mac/http/tests/appcache/wrong-content-type-expected.txt: Removed.
  • platform/chromium-mac/http/tests/appcache/wrong-content-type-expected.txt: Removed.
  • platform/chromium-win/http/tests/appcache/wrong-content-type-expected.txt: Removed.
17:43 Changeset [100540] by ggaren@apple.com

Some CachedCall cleanup, in preparation for reversing argument order.

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitWeakReferences): A build fix for the interpreter,
so I can test it.

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall): Renamed argCount to argumentCount because
we are not that desperate for character saving.

(JSC::CachedCall::setThis):
(JSC::CachedCall::setArgument): Adopted new 0-based argument indexing for
CallFrameClosure.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Provide 0-based argument indexing,
with an explicit setter for 'this', since that's how most clients think.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h: Change argCount to argumentCountIncludingThis,

for clarity.

17:43 Changeset [100539] by tony@chromium.org

Skip failing ref tests on gtk and mac.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
17:34 Changeset [100538] by lforschler@apple.com

Merge 94247.

17:33 Changeset [100537] by mhahnenberg@apple.com

De-virtualize ScriptExecutable::unlinkCalls
https://bugs.webkit.org/show_bug.cgi?id=72546

Reviewed by Geoffrey Garen.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable): Added an empty explicit virtual destructor to prevent a very odd compilation error
due to the fact that the compiler was trying to generate the implicit inline destructor in every translation unit, some of which
didn't have complete type information on the things that needed to be destructed in the implicit destructor.

  • runtime/Executable.h:

(JSC::EvalExecutable::createStructure): Used new type value from JSType
(JSC::ProgramExecutable::createStructure): Ditto
(JSC::FunctionExecutable::createStructure): Ditto
(JSC::ScriptExecutable::unlinkCalls): Condition upon the type value, cast and call the corresponding unlinkCalls implementation.

  • runtime/JSType.h: Added new values for EvalExecutable, ProgramExecutable, and FunctionExecutable. Remove explicit numbers, since

that just adds noise to patches and they currently have no significance.

17:29 Changeset [100536] by commit-queue@webkit.org

[Chromium] Avoid color mask operations for root layers
https://bugs.webkit.org/show_bug.cgi?id=72452

Instead of relying on the combination of clearing the surface and initializing
the alpha channel to 1.0 followed by disabling alpha in the color mask when
rendering the root layer tiles, add shaders to support writing out opaque layers
(alpha channel values written as 1.0).

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-16
Reviewed by James Robinson.

No functional change made that requires new tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgramOpaque):
(WebCore::LayerRendererChromium::tilerProgramOpaqueAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tilerProgramSwizzleOpaqueAA):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentTexOpaqueBinding::FragmentTexOpaqueBinding):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderRGBATexOpaque::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleOpaque::getShaderString):
(WebCore::FragmentTexClampOpaqueAABinding::FragmentTexClampOpaqueAABinding):
(WebCore::FragmentTexClampOpaqueAABinding::init):
(WebCore::FragmentShaderRGBATexClampOpaqueAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleOpaqueAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::FragmentTexOpaqueBinding::alphaLocation):
(WebCore::FragmentTexOpaqueBinding::samplerLocation):
(WebCore::FragmentTexClampOpaqueAABinding::alphaLocation):
(WebCore::FragmentTexClampOpaqueAABinding::samplerLocation):
(WebCore::FragmentTexClampOpaqueAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexClampOpaqueAABinding::edgeLocation):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:
17:28 Changeset [100535] by timothy_horton@apple.com

Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Render -webkit-cross-fade. Only cross-fades entirely composed of images will render for now,
cross-fades involving generated images are not yet implemented.

Reorganize GeneratedImage to be the base class for GeneratorGeneratedImage and CrossfadeGeneratedImage.

Add a pending state to CSSImageGeneratorValue, which is used to enable the pending-images loading
mechanism for -webkit-cross-fade's sub-images. Rework the logic in CSSStyleSelector to support pending
generated images.

Support parsing fractional values for the cross-fade amount (for example, 0.5 = 50%). Clamp cross-fade
amount to 0-1 range.

Tests: css3/images/cross-fade-invalidation.html

css3/images/cross-fade-simple.html
css3/images/cross-fade-sizing.html
css3/images/cross-fade-tiled.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::isPending):
(WebCore::CSSCanvasValue::loadSubimages):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::loadSubimages):
(WebCore::subimageIsPending):
(WebCore::loadSubimage):
(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeObserverProxy::CrossfadeObserverProxy):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isPending):
(WebCore::CSSGradientValue::loadSubimages):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::generatedOrPendingImage):
(WebCore::CSSImageGeneratorValue::generatedImage):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSImageGeneratorValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCrossfade):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):

  • css/CSSStyleSelector.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp: Added.

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::~CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
(WebCore::CrossfadeGeneratedImage::imageChanged):

  • platform/graphics/CrossfadeGeneratedImage.h: Added.

(WebCore::CrossfadeGeneratedImage::create):
(WebCore::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
(WebCore::CrossfadeSubimageObserverProxy::setReady):

  • platform/graphics/GeneratedImage.h:

(WebCore::GeneratedImage::GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratedImage.cpp.

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
(WebCore::GeneratedImage::computeIntrinsicDimensions):

  • platform/graphics/GeneratorGeneratedImage.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.h.

(WebCore::GeneratorGeneratedImage::create):
(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):

  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:
  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::create):
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::StylePendingImage):

Add tests of -webkit-cross-fade, ensuring that simple cross-fades between
two images work correctly.

Adjust fast/css/getComputedStyle/computed-style-cross-fade.html to test
fractional and out-of-range cross-fade percentage values.

  • css3/images/cross-fade-invalidation.html: Added.
  • css3/images/cross-fade-simple.html: Added.
  • css3/images/cross-fade-sizing.html: Added.
  • css3/images/cross-fade-tiled.html: Added.
  • css3/images/resources/blue-10.png: Added.
  • css3/images/resources/blue-100.png: Added.
  • css3/images/resources/green-10.png: Added.
  • css3/images/resources/green-100.png: Added.
  • css3/images/resources/green-circle.svg: Added.
  • css3/images/resources/red-10.png: Added.
  • css3/images/resources/red-100.png: Added.
  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
  • fast/css/getComputedStyle/computed-style-cross-fade.html:
  • platform/mac/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/mac/css3/images/cross-fade-invalidation-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-simple-expected.png: Added.
  • platform/mac/css3/images/cross-fade-simple-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/mac/css3/images/cross-fade-sizing-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-tiled-expected.png: Added.
  • platform/mac/css3/images/cross-fade-tiled-expected.txt: Added.
17:19 Changeset [100534] by mitz@apple.com

Source/WebCore: WebCore part of <rdar://problem/10262242> Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Exported Page::pageCount().
  • page/Page.cpp:

(WebCore::Page::pageCount): Added this getter.

  • page/Page.h:

Source/WebKit/mac: WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

  • WebView/WebView.mm:

(-[WebView _setPaginationMode:]): Added this accessor.
(-[WebView _paginationMode]): Ditto.
(-[WebView _setGapBetweenPages:]): Ditto.
(-[WebView _gapBetweenPages]): Ditto.
(-[WebView _pageCount]): Ditto.

  • WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.

Source/WebKit2: WebKit2 part of <rdar://problem/10262242> Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode the pagination mode and gap between pages.
(WebKit::WebPageCreationParameters::decode): Decode the pagination mode and gap between pages.

  • Shared/WebPageCreationParameters.h: Added paginationMode and gapBetweenPages members.
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationMode): Added this API wrapper.
(WKPageGetPaginationMode): Ditto.
(WKPageSetGapBetweenPages): Ditto.
(WKPageGetGapBetweenPages): Ditto.
(WKPageGetPageCount): Ditto.

  • UIProcess/API/C/WKPagePrivate.h: Added an enum and a definition of WKPaginationMode and

accessors.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPaginationMode:]): Added this API wrapper.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Added. Includes an enum and a definition

of WKBrowsingContextPaginationMode and property declarations.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Added intialization of m_paginationMode, m_gapBetweenPages,
and m_pageCount.
(WebKit::WebPageProxy::setPaginationMode): Added this accessor, which caches the value and sends
a message to the WebPage.
(WebKit::WebPageProxy::setGapBetweenPages): Ditto.
(WebKit::WebPageProxy::creationParameters): Set the pagination mode and gap between pages in the
creation parameters.
(WebKit::WebPageProxy::didChangePageCount): Added. Updates the cached page count.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::paginationMode): Added this getter that returns a cached value.
(WebKit::WebPageProxy::gapBetweenPages): Ditto.
(WebKit::WebPageProxy::pageCount): Ditto.

  • UIProcess/WebPageProxy.messages.in: Added DidChangedPageCount, sent when the page count changes

after layout.

  • WebKit2.xcodeproj/project.pbxproj: Added WKBrowsingContextControllerPrivate.h.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout): Added a call to WebPage::mainFrameDidLayout(),
allowing the page to respond to changes in the column count.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Added initializer for m_cachedPageCount.
(WebKit::WebPage::setPaginationMode): Added.
(WebKit::WebPage::setGapBetweenPages): Added.
(WebKit::WebPage::mainFrameDidLayout): Added. Sends a DidChangePageCount message to the UI process
if the page count has changed.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added SetPaginationMode and SetGapBetweenPages messages.
17:14 Changeset [100533] by commit-queue@webkit.org

[chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
https://bugs.webkit.org/show_bug.cgi?id=72562

Patch by James Robinson <jamesr@chromium.org> on 2011-11-16
Reviewed by Dirk Pranke.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

LayoutTests:

  • platform/chromium/test_expectations.txt:
17:08 Changeset [100532] by lforschler@apple.com

Merge 94122.

17:02 Changeset [100531] by lforschler@apple.com

Merged r93669.

16:59 Changeset [100530] by commit-queue@webkit.org

[chromium] Track property changes for render surfaces.
https://bugs.webkit.org/show_bug.cgi?id=72521

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-16
Reviewed by James Robinson.

Source/WebCore:

Created CCRenderSurfaceTest for testing.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::surfacePropertyChanged):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::resetPropertyChangedFlag):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCRenderSurfaceTest.cpp: Added.

(WebCore::TEST):

16:58 Changeset [100529] by lforschler@apple.com

Merge 99315.

16:57 Changeset [100528] by commit-queue@webkit.org

Seaming on border corners with mixed colour alpha borders
https://bugs.webkit.org/show_bug.cgi?id=70471

Patch by Ben Wells <benwells@chromium.org> on 2011-11-16
Reviewed by Simon Fraser.

Source/WebCore:

Seaming is fixed by antialiasing mitred corners for edges that have alpha and are joining
a side that is of a different color.

Test: fast/borders/border-mixed-alpha.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::colorNeedsAntiAliasAtCorner):
(WebCore::RenderBoxModelObject::paintOneBorderSide):

LayoutTests:

  • fast/borders/border-mixed-alpha.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/mac/fast/borders/border-mixed-alpha-expected.txt: Added.
16:49 Changeset [100527] by fpizlo@apple.com

JSC::CodeBlock should know which references generated by the DFG are weak
https://bugs.webkit.org/show_bug.cgi?id=72563

Reviewed by Geoff Garen.

CodeBlock::m_dfgData now tracks weak references and weak reference transitions
(like ephemerons) generated by the DFG. The DFG makes sure to notify the
CodeBlock of all uses of weak references and weak reference transitions.
CodeBlock currently marks them strongly, since the weak marking logic is not
in place, yet.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::stronglyVisitWeakReferences):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendWeakReference):
(JSC::CodeBlock::shrinkWeakReferencesToFit):
(JSC::CodeBlock::appendWeakReferenceTransition):
(JSC::CodeBlock::shrinkWeakReferenceTransitionsToFit):
(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::codeOriginOwner):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::addWeakReferenceTransition):
(JSC::DFG::JITCompiler::branchWeakPtr):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::compile):

16:46 Changeset [100526] by lforschler@apple.com

Merged r93052.

16:39 Changeset [100525] by lforschler@apple.com

Merge 93314.

16:35 Changeset [100524] by lforschler@apple.com

Merge 93303.

16:25 Changeset [100523] by msaboff@apple.com

LayoutTests for Debug Builds Crashes in JavaScriptCore/yarr/YarrInterpreter.cpp(185)
https://bugs.webkit.org/show_bug.cgi?id=72561

Removed #if USE(JSC) and therefore the ASSERT_NOT_REACHED().
Simplified the code in the process.

Reviewed by James Robinson.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):

16:23 Changeset [100522] by lforschler@apple.com

rollout merge of 93303, nee to fixup changelogs.

16:21 Changeset [100521] by ggaren@apple.com

Interpreter build fixes.

  • bytecode/CodeBlock.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

16:20 Changeset [100520] by pkasting@chromium.org

[chromium] Clean up some animations/ expectations.
https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselines some tests that clearly just needed that, tries to condense
a number of other flaky tests onto one bug, updates the set of bots that
are actually failing for some expectations.

Unreviewed, gardening.

  • platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-linux/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.png:
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.png:
  • platform/chromium-win/animations/opacity-transform-animation-expected.png:
  • platform/chromium/test_expectations.txt:
16:16 Changeset [100519] by lforschler@apple.com

Merge 93303.

16:04 Changeset [100518] by paroga@webkit.org

Unreviewed. Build fix for !ENABLE(JIT) after r100363.

  • bytecode/CodeBlock.h:
15:46 Changeset [100517] by weinig@apple.com

JS wrappers of DOM objects should have no-op constructors
https://bugs.webkit.org/show_bug.cgi?id=72556

Reviewed by Geoffrey Garen.

Stop using a RefPtr to hold DOM objects contained by JavaScript
wrappers and instead use a raw pointer. We were already releasing
the underlying object before the destructor ran (via the finalizer)
so the default behavior of destroying the RefPtr is always unnecessary
busy work.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):
(WebCore::JSNode::visitChildren):
Call releaseImpl() instead of clearImpl().

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch
clearImpl() to releaseImpl(), which explicitly derefs the pointer and
clear it.

(GenerateImplementation):
Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer.
Change default finalize to call releaseImpl() instead of clearImpl().

15:37 Changeset [100516] by ggaren@apple.com

Rolled back in r100375 and r100385 with 32-bit build fixed.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice):

  • runtime/ArgList.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSGlobalObject.h:

(JSC::constructArray):

15:33 Changeset [100515] by lforschler@apple.com

Merge 93058.

15:21 Changeset [100514] by fpizlo@apple.com

DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::globalObjectFor):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalObjectFor):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/cross-global-object-inline-global-var-expected.txt: Added.
  • fast/js/cross-global-object-inline-global-var.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

15:02 Changeset [100513] by dpranke@chromium.org

Revert r100509; change was committed twice (first time as r100491).
Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
14:57 Changeset [100512] by jamesr@google.com

[chromium] Update text baselines for mq-transform-0[23] tests

  • platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt:
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt:
14:53 Changeset [100511] by tony@chromium.org

[NRWT] speculative fix for multiple subprocess test on cygwin
https://bugs.webkit.org/show_bug.cgi?id=72518

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably

tries to emulate posix fd behavior.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
14:46 Changeset [100510] by msaboff@apple.com

Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71337

Source/JavaScriptCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type. This change rippled into WebCore code as well.

Reviewed by Geoffrey Garen.

(JSC::::append8): Changed to use 8 bit buffers.
(JSC::::parseIdentifier): Changed to use 8 bit buffers.
(JSC::::parseString): Changed to use 8 bit buffers.

  • runtime/Identifier.cpp:

(JSC::IdentifierCStringTranslator::translate): 8 bit version keeps data 8 bit
(JSC::Identifier::toUInt32FromCharacters): Templated helper.
(JSC::Identifier::toUInt32): Added 8 bit optimized path.

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage): Changed to be 8 bit strings

  • runtime/UString.h:

(JSC::UString::characters): Now calls StringImpl::characters()

  • wtf/Forward.h:
  • wtf/text/StringBuffer.h: Made StringBuffer a template base on character type.

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::characters):
(WTF::StringBuffer::release):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase): Fixed null terminated case.
(WTF::StringImpl::removeCharacters): Added 8 bit path.
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::simplifyWhiteSpace):
(WTF::equal): Removed bug from code copied from null terminated version.
(WTF::StringImpl::adopt): Added 8 bit path.
(WTF::StringImpl::createWithTerminatingNullCharacter): Fixed 8 bi flag propagation.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl): Added new 8 bit constructor.
(WTF::StringImpl::characters8): Removed ASSERT_NOT_REACHED().
(WTF::getCharacters<LChar>): Added templated accessor for 8 bit strings.
(WTF::getCharacters<UChar>): Added templated accessor for 16 bit strings.

  • wtf/text/WTFString.h:

(WTF::String::adopt): Changed to use StringBuffer template.

Source/WebCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type. This change riplled into WebCore code as well.

Reviewed by Geoffrey Garen.

No new tests - Changes in response to refactoring StringBuffer to
be a template on character type.

  • css/CSSParser.cpp:

(WebCore::quoteCSSString):

  • css/CSSPrimitiveValue.cpp:

(WebCore::formatNumber):

  • dom/Document.cpp:

(WebCore::canonicalizedTitle):

  • platform/Length.cpp:

(WebCore::newCoordsArray):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::writeToStringBuilder):

14:44 Changeset [100509] by dpranke@chromium.org

Run a dummy test in the gpu configurations if there's nothing to do.
https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
14:37 Changeset [100508] by commit-queue@webkit.org

[chromium] Improvements for page scale delta during commit
https://bugs.webkit.org/show_bug.cgi?id=72471

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

Page scale now follows the same commit flow as scroll position:
the delta is folded into m_pageScale at BFAC time, and a "sent" value
is preserved for temporary use until the commit finishes.

I also merged setPageScaleFactor and setPageScaleFactorLimits into one
function on the impl side. The reason is that setPageFactor must
be applied after the limits are updated, but on the other hand setting
the limits first may cause an unnecessary clamp of the scale delta.
Merging the methods avoids this bind.

No new tests. (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyScrollAndScale):

14:34 Changeset [100507] by pkasting@chromium.org

[chromium] Attempt to rebaseline a test.
https://bugs.webkit.org/show_bug.cgi?id=54322

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
  • platform/chromium/test_expectations.txt:
14:24 Changeset [100506] by commit-queue@webkit.org

Platform specific results for svg/foreignObject/{clip,filter,mask}.html
https://bugs.webkit.org/show_bug.cgi?id=72532

Patch by Florin Malita <fmalita@google.com> on 2011-11-16
Reviewed by Steve Block.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
14:24 Changeset [100505] by rniwa@webkit.org

contributors_by_fuzzy_match is super slow
https://bugs.webkit.org/show_bug.cgi?id=72540

Reviewed by Eric Seidel.

Make contributors_by_name do case insensitive search using a dictionary.

Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
because that's the most common case.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
14:21 Changeset [100504] by commit-queue@webkit.org

IndexedDB: Reduce nested key depth threshold, re-enable flaky test
https://bugs.webkit.org/show_bug.cgi?id=72529

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-16
Reviewed by Adam Barth.

Source/WebCore:

Drop maximum array key depth from 20k to 2k.

  • bindings/v8/IDBBindingUtilities.cpp:

LayoutTests:

Re-enable flaky test, and drop the maximum depth tested to avoid
crashes/timeouts on test boxes when prepping the test.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array.html:
14:10 Changeset [100503] by japhet@chromium.org

Source/WebCore: Fix incorrect multipart handling in r100311.
SubresourceLoader::didReceiveData() is getting called
twice, which has unintended side effects.
https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

http/tests/multipart/invalid-image-data.html should stop
asserting after this.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

  • loader/SubresourceLoader.h:

LayoutTests: Remove CRASH expectation for
http/tests/multipart/invalid-image-data.html.
https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
14:07 Changeset [100502] by jschuh@chromium.org

Clear SVG filter client when its node is detached
https://bugs.webkit.org/show_bug.cgi?id=71741

Reviewed by Eric Seidel.

Source/WebCore:

Test: svg/filters/reparent-animated-filter-target.html

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientDestroyed):

LayoutTests:

  • svg/filters/reparent-animated-filter-target-expected.txt: Added.
  • svg/filters/reparent-animated-filter-target.html: Added.
14:02 Changeset [100501] by pkasting@chromium.org

[chromium] Mark some CoreAnimation plugin model tests as WONTFIX on Win/
Linux, and as expected to fail for now on Mac; remove current expected
Mac baselines.
https://bugs.webkit.org/show_bug.cgi?id=47925

Unreviewed, gardening.

  • platform/chromium-mac/compositing/plugins/composited-plugin-expected.txt: Removed.
  • platform/chromium-mac/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
  • platform/chromium-win/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
  • platform/chromium-win/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
  • platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
13:54 Changeset [100500] by commit-queue@webkit.org

Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <jbates@google.com> on 2011-11-16
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
13:51 Changeset [100499] by levin@chromium.org

check-webkit-style should recognize functions even if they have OVERRIDE after them.
https://bugs.webkit.org/show_bug.cgi?id=72515

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
13:22 Changeset [100498] by jamesr@google.com

[chromium] Update chromium expectations for fast/media/mq-transform-0[23].html to reflect that chromium DRT has
2d and 3d transforms enabled

  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-linux-x86/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-linux-x86/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-linux-x86/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-linux-x86/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-linux/fast/media/mq-transform-02-expected.png:
  • platform/chromium-linux/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-linux/fast/media/mq-transform-03-expected.png:
  • platform/chromium-linux/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.png:
  • platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.png:
  • platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-win-vista/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-win-vista/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-win-vista/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-win-vista/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-win-xp/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-win-xp/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-win-xp/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-win-xp/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-win/fast/media/mq-transform-02-expected.png:
  • platform/chromium-win/fast/media/mq-transform-02-expected.txt:
  • platform/chromium-win/fast/media/mq-transform-03-expected.png:
  • platform/chromium-win/fast/media/mq-transform-03-expected.txt:
  • platform/chromium/test_expectations.txt:
13:14 Changeset [100497] by commit-queue@webkit.org

Fix up chromium API for creating events, initializing message events
https://bugs.webkit.org/show_bug.cgi?id=71478

  • Fix a mistake when checking the exception code during event creation.
  • Change WebFrame parameter to pointer so that NULL may be passed.

This is required for the following chromium CL: http://codereview.chromium.org/8437093/

Tested in Chromium by:

ui_test --gtest_filter=*PPAPITest.PostMessage*

Patch by Dave Michael <dmichael@chromium.org> on 2011-11-16
Reviewed by Darin Fisher.

  • public/WebDOMMessageEvent.h:
  • src/WebDOMMessageEvent.cpp:

(WebKit::WebDOMMessageEvent::initMessageEvent):

  • src/WebDocument.cpp:

(WebKit::WebDocument::createEvent):

13:11 Changeset [100496] by commit-queue@webkit.org

[chromium] Add null pointer check in setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=72464

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

No new tests. (Tiny fix.)

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

13:07 Changeset [100495] by commit-queue@webkit.org

Unreviewed, rolling out r100438.
http://trac.webkit.org/changeset/100438
https://bugs.webkit.org/show_bug.cgi?id=72536

Broke unit tests (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:
  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

13:03 Changeset [100494] by tony@chromium.org

[NRWT] refactor drivers to require pixel_tests param
https://bugs.webkit.org/show_bug.cgi?id=72517

Reviewed by Ojan Vafai.

No tests, just a refactoring.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:50 Changeset [100493] by mhahnenberg@apple.com

De-virtualize ExecutableBase::clearCodeVirtual
https://bugs.webkit.org/show_bug.cgi?id=72337

Reviewed by Darin Adler.

Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
and had the finalize functions call the corresponding clearCode methods.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::NativeExecutable::finalize):
(JSC::EvalExecutable::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::finalize):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::finalize):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

12:43 Changeset [100492] by aestes@apple.com

Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=72535

Reviewed by Anders Carlsson.

LayerFlushScheduler attempted to use a counter strategy for calls to
suspend() and resume(), which allowed us to assert that these calls
were balanced. Unfortunately it is hard to guarantee this in WebKit2,
where we sometimes try to call suspend() before we've entered
compositing mode (hence before we have a LayerTreeHost and a
LayerFlushScheduler). When we later call resume(), this call ends up
being unbalanced and asserts.

For now, remove the assertions and allow unbalanced calls to suspend()
and resume().

  • platform/graphics/ca/LayerFlushScheduler.cpp:

(WebCore::LayerFlushScheduler::suspend):
(WebCore::LayerFlushScheduler::resume):

  • platform/graphics/ca/LayerFlushScheduler.h:
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::LayerFlushScheduler):
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
(WebCore::LayerFlushScheduler::schedule):

12:42 Changeset [100491] by dpranke@chromium.org

Run a dummy test in the gpu configurations if there's nothing to do.
https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
12:27 Changeset [100490] by robert@webkit.org

Unreviewed, rolling out r100473.
http://trac.webkit.org/changeset/100473
https://bugs.webkit.org/show_bug.cgi?id=72534

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::addChild):

  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.cpp: Removed.
  • rendering/RenderTableCaption.h: Removed.

LayoutTests:

  • css2.1/20110323/border-collapse-offset-002.htm: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/mac/fast/repaint/table-section-repaint-expected.txt:
12:25 Changeset [100489] by robert@webkit.org

Unreviewed, rolling out r100479.
http://trac.webkit.org/changeset/100479
https://bugs.webkit.org/show_bug.cgi?id=72533

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderingAllInOne.cpp:
12:17 Changeset [100488] by cfleizach@apple.com

WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

Tools:

Reviewed by Beth Dakin.

Port the AX code in DRT to WKTestRunner by using IDL.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(horizontalScrollbarCallback):
(verticalScrollbarCallback):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.

(WTR::AccessibilityController::create):
(WTR::AccessibilityController::AccessibilityController):
(WTR::AccessibilityController::~AccessibilityController):
(WTR::AccessibilityController::makeWindowObject):
(WTR::AccessibilityController::wrapperClass):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::elementAtPoint):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.

(WTR::AccessibilityController::logFocusEvents):
(WTR::AccessibilityController::logValueChangeEvents):
(WTR::AccessibilityController::logScrollingStartEvents):
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::notificationReceived):
(WTR::AccessibilityController::resetToConsistentState):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.

(WTR::AccessibilityTextMarker::create):
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::platformTextMarker):
(WTR::AccessibilityTextMarker::wrapperClass):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.

(WTR::AccessibilityTextMarker::isEqual):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.

(WTR::AccessibilityTextMarkerRange::create):
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::wrapperClass):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.

(WTR::AccessibilityTextMarkerRange::isEqual):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.

(WTR::AccessibilityUIElement::create):
(WTR::AccessibilityUIElement::wrapperClass):
(WTR::AccessibilityUIElement::isValid):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.

(WTR::AccessibilityUIElement::platformUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::accessibilityController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.

(WTR::AccessibilityTextMarker::isEqual):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.

(WTR::AccessibilityTextMarkerRange::isEqual):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.

(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler initWithPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
(-[AccessibilityNotificationHandler setCallback:]):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::descriptionOfValue):
(WTR::attributesOfElement):
(WTR::concatenateAttributeAndValue):
(WTR::convertNSArrayToVector):
(WTR::descriptionOfElements):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):

  • WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Cleanup tests and skip lists so that accessibility tests can run
in WK2. This mostly involved handling returned elements that might be nil,
something that did not happen in DRT.

Reviewed by Beth Dakin.

  • accessibility/aria-labelledby-overrides-label-expected.txt:
  • accessibility/aria-labelledby-overrides-label.html:
  • accessibility/non-data-table-cell-title-ui-element.html:
  • accessibility/th-as-title-ui.html:

Make sure a nil titleUIElement is accounted for in these tests.

  • platform/gtk-wk2/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt:
  • platform/mac/accessibility/aria-expanded-notifications.html:
  • platform/mac/accessibility/aria-invalid-expected.txt:
  • platform/mac/accessibility/aria-invalid.html:
  • platform/mac/accessibility/aria-liveregions-addedelement-expected.txt:
  • platform/mac/accessibility/aria-liveregions-addedelement.html:
  • platform/mac/accessibility/aria-liveregions-changedalt-expected.txt:
  • platform/mac/accessibility/aria-liveregions-changedalt.html:
  • platform/mac/accessibility/aria-liveregions-changedtext-expected.txt:
  • platform/mac/accessibility/aria-liveregions-changedtext.html:
  • platform/mac/accessibility/aria-liveregions-removedelement-expected.txt:
  • platform/mac/accessibility/aria-liveregions-removedelement.html:

All the preceeding layout tests use alert() to output the results of notifications. This
is causing re-ordering issues on WK2, so I've moved them all to output that notification
data to a separate element from "console".

  • platform/mac/accessibility/html-section-elements-expected.txt:
  • platform/mac/accessibility/html-section-elements.html:

Remove nil element access that is unnecessary.

  • platform/mac/accessibility/html-slider-indicator-expected.txt:
  • platform/mac/accessibility/html-slider-indicator.html:
  • platform/mac/accessibility/search-predicate.html:

Add an alt tag to <img> so that it always shows up in the AX tree.

  • platform/mac/accessibility/selection-value-changes-for-aria-textbox.html:
  • platform/mac/accessibility/textbox-role-reports-notifications-expected.txt:

Remove the notification listener properly (was causing flakiness).

  • platform/mac/accessibility/textbox-role-reports-notifications.html:
  • platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt:
  • platform/mac/accessibility/update-children-when-aria-role-changes.html:

Account for when element's returned are nil.

  • platform/win-wk2/Skipped:

Skip all accessibility tests on win.

  • platform/wk2/Skipped:

Skip all accessibility tests on gtk.

12:14 Changeset [100487] by cfleizach@apple.com

WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

../WebCore:

Minor changes needed to support AX testing in WKTestRunner.

Reviewed by Beth Dakin.

  • WebCore.exp.in:

Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(accessibilitySearchKeyForString):

Remove an unncessary assert that was causing issues with the WK2 test run.

../WebKit2:

Allow the injected bundle to retrieve the focused and root accessibility
objects.

Reviewed by Beth Dakin.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
12:12 Changeset [100486] by sergio@webkit.org

[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
https://bugs.webkit.org/show_bug.cgi?id=69219

Reviewed by Martin Robinson.

Source/WebCore:

Do not stop appending data to the request body if any of the blob
items to upload is not accesible.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::addEncodedBlobToSoupMessageBody):

LayoutTests:

Unskipped a test that now pass.

  • platform/gtk/Skipped: unskipped http/tests/local/blob/send-hybrid-blob.html
11:59 Changeset [100485] by steveblock@google.com

fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg
https://bugs.webkit.org/show_bug.cgi?id=72530

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
11:58 Changeset [100484] by lforschler@apple.com

Merged r93043.

11:53 Changeset [100483] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=72400
Scrollbar uiStateTransitionProgress requires tracking the mouse all the time
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This patch makes it so we track the mouse all the time when we have legacy
scrollbars (rather than only tracking the mouse when the window is key). When
we're in that mode, we want to do as little work as possible when handling the
mouseMoved event so that this extra tracking has little to no performance impact.
Also, we don't want to change basic behaviors by having normal web content hover
effects start happening when a window is in the background. So this patch also
introduces a way to handle a mouseMoved event that will only affect scrollbars.

EventHandler::mouseMoved() and EventHandler::handleMouseEvent() both now take a
boolean parameter that indicates if we are only updating scrollbars. If that is
the case, then we make our HitTestRequest ReadOnly, and we return early once
updateLastScrollbarUnderMouse() is called.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):

In addition to calling Scrollbar::mouseExited() when appropriate, this function
now calls a new function, Scrollbar::mouseEntered() when appropriate.
(WebCore::EventHandler::updateLastScrollbarUnderMouse):

  • page/EventHandler.h:

Scrollbar::mouseMoved() used to be responsible for calling
ScrollAnimator::mouseEnteredScrollbar(), but now Scrollbar::mouseEntered() takes
care of that instead, much like how Scrollbar::mouseExited() takes care of calling
the animator's exit function.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseEntered):

  • platform/Scrollbar.h:

Source/WebKit2:

Set up our initial tracking area based on the currently recommended scrollbar
style. Track the mouse all the time if the style is legacy.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

Now that we might be getting mouseMoved events all the time even when the window
is not key, make sure we opt into the new 'onlyUpdateScrollbars' mode for
EventHandler::mouseMoved() when the window is not focused.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

11:47 Changeset [100482] by lforschler@apple.com

Merge 93040.

11:42 Changeset [100481] by commit-queue@webkit.org

CSSValue: isInheritedValue() doesn't need a dedicated bit.
<http://webkit.org/b/72514>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Remove CSSValue::m_isInherited and have isInheritedValue() check the
class type instead. There's no compelling reason for CSSInheritedValue
to have a dedicated bit, since nobody subclasses it anyway.

  • css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::CSSValue):

11:42 Changeset [100480] by lforschler@apple.com

Merge 91161.

11:39 Changeset [100479] by robert@webkit.org

Fix build on Windows and Mac after r100473

Unreviewed, fix build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderingAllInOne.cpp:
11:34 Changeset [100478] by abarth@webkit.org

Unskip these tests now that they should pass again.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
11:31 Changeset [100477] by lforschler@apple.com

Merge 89441.

11:29 Changeset [100476] by abarth@webkit.org

Update test results after tightening up SecurityOrigin logic in
http://trac.webkit.org/changeset/100182. These new results are (minor)
progressions on these tests.

  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
11:16 Changeset [100475] by commit-queue@webkit.org

Remove extra GraphicsContextStateSaver restore() call.
https://bugs.webkit.org/show_bug.cgi?id=72497

Patch by Philip Rogers <pdr@google.com> on 2011-11-16
Reviewed by Andreas Kling.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

11:13 Changeset [100474] by commit-queue@webkit.org

[chromium] Add minimum/maximumPageScaleFactor API and clamp fixes
https://bugs.webkit.org/show_bug.cgi?id=72463

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by Darin Fisher.

We need a way to read back the computed min/max page scale factor in
order to support the software path, and for some application logic
such as zooming in/out when tapping form fields.

I also added a few clamp calls that are needed in some corner cases.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::minimumPageScaleFactor):
(WebKit::WebViewImpl::maximumPageScaleFactor):

  • src/WebViewImpl.h:
11:11 Changeset [100473] by robert@webkit.org

CSS 2.1 failure: border-collapse-offset-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=71705

Source/WebCore:

Table captions are implemented as children of the table but have a special
requirement to expand to the full width of the table rather than just the 'available'
width, i.e. the full width minus padding and borders.

To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
to return the full width of the containing block (i.e. the table) rather than the available width.

Reviewed by Antti Koivisto.

  • CMakeLists.txt: Add RenderTableCaption.[cpp|h]
  • GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
  • Target.pri: Add RenderTableCaption.[cpp|h]
  • WebCore.gypi: Add RenderTableCaption.[cpp|h]
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
(WebCore::RenderObject::addChild): ditto

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.cpp: Added.

(WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
(WebCore::RenderTableCaption::~RenderTableCaption):
(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.

  • rendering/RenderTableCaption.h: Added.

(WebCore::RenderTableCaption::isTableCaption):
(WebCore::toRenderTableCaption):

LayoutTests:

Table captions now use the width of the table rather than the width of the table minus
the borders. This allows captions to center accurately but unfortunately a lot of mozilla
table tests need to be rebaselined as many of them use captions for explaining the purpose
of individual test files!

Add border-collapse-offset-002.htm which now renders correctly.

Affected tables/mozilla tests are rebaselined in a follow-up patch.

Reviewed by Antti Koivisto.

  • css2.1/20110323/border-collapse-offset-002.htm: Added.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/mac/fast/repaint/table-section-repaint-expected.txt:
11:03 Changeset [100472] by commit-queue@webkit.org

[EFL] Add ewk_settings_memory_cache_clear().
https://bugs.webkit.org/show_bug.cgi?id=72141

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

This is the same as Qt's QWebSettings::clearMemoryCaches() and is
responsible for clearing, among others, the page, memory and font
caches.

  • ewk/ewk_settings.cpp:

(ewk_settings_memory_cache_clear):

  • ewk/ewk_settings.h:
11:03 Changeset [100471] by commit-queue@webkit.org

ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-11-16
Reviewed by Adam Barth.

  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Added.
  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Added.
10:56 Changeset [100470] by commit-queue@webkit.org

[Gtk] display:none has no effect on <option> element.
https://bugs.webkit.org/show_bug.cgi?id=72370

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Martin Robinson.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::appendItem):

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem):

10:44 Changeset [100469] by commit-queue@webkit.org

String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
https://bugs.webkit.org/show_bug.cgi?id=71572

Patch by Yusuke Suzuki <utatane.tea@gmail.com> on 2011-11-16
Reviewed by Gavin Barraclough and Darin Adler.

Source/JavaScriptCore:

  • runtime/RegExpObject.cpp:

(JSC::regExpObjectSource):

LayoutTests:

  • fast/regex/script-tests/toString.js:

(testLineTerminator):

  • fast/regex/toString-expected.txt:
10:32 Changeset [100468] by commit-queue@webkit.org

[GTK][WEBKIT2] Link error running gtkdoc-scangobj
https://bugs.webkit.org/show_bug.cgi?id=72365

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-16
Reviewed by Xan Lopez.

  • webkit2gtk.pc.in: Add a libjavascriptcore requirement to the WebKit2 pkgconfig

file so that the compiler links to it.

10:30 Changeset [100467] by lforschler@apple.com

Versioning.

10:20 Changeset [100466] by commit-queue@webkit.org

[GTK] Fix platformDefersLoading to handle non-http requests, and
to not use broken-ish libsoup APIs.
https://bugs.webkit.org/show_bug.cgi?id=72227

Patch by Dan Winship <danw@gnome.org> on 2011-11-16
Reviewed by Martin Robinson.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::hasBeenSent):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback): rather than deferring by using
soup_session_pause_message(), let the read complete, but just don't
process the result until we're no longer deferred.
(WebCore::startNonHTTPRequest): Don't start the request if
it's deferred.

10:16 Changeset [100465] by commit-queue@webkit.org

Recent svg/foreignObject tests failing on Mac & Win
https://bugs.webkit.org/show_bug.cgi?id=72386

Patch by Florin Malita <fmalita@google.com> on 2011-11-16
Reviewed by Simon Fraser.

Drop unnecessary text elements from the svg/FO tests to avoid platform font size variance.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Removed.
  • platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Removed.
  • platform/chromium-win/svg/foreignObject/clip-expected.txt: Removed.
  • platform/chromium-win/svg/foreignObject/filter-expected.txt: Removed.
  • platform/chromium-win/svg/foreignObject/mask-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/clip-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/filter-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/mask-expected.txt: Removed.
  • platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
  • platform/qt/svg/foreignObject/background-render-phase-expected.png: Removed.
  • platform/qt/svg/foreignObject/background-render-phase-expected.txt: Removed.
  • platform/qt/svg/foreignObject/clip-expected.png: Removed.
  • platform/qt/svg/foreignObject/clip-expected.txt: Removed.
  • platform/qt/svg/foreignObject/filter-expected.png: Removed.
  • platform/qt/svg/foreignObject/filter-expected.txt: Removed.
  • platform/qt/svg/foreignObject/mask-expected.png: Removed.
  • platform/qt/svg/foreignObject/mask-expected.txt: Removed.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Removed.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
  • svg/foreignObject/background-render-phase-expected.txt:
  • svg/foreignObject/background-render-phase.html:
  • svg/foreignObject/clip-expected.png:
  • svg/foreignObject/clip-expected.txt:
  • svg/foreignObject/clip.html:
  • svg/foreignObject/filter-expected.png:
  • svg/foreignObject/filter-expected.txt:
  • svg/foreignObject/filter.html:
  • svg/foreignObject/mask-expected.png:
  • svg/foreignObject/mask-expected.txt:
  • svg/foreignObject/mask.html:
  • svg/foreignObject/multiple-foreign-objects-expected.txt:
  • svg/foreignObject/multiple-foreign-objects.html:
10:05 Changeset [100464] by kbalazs@webkit.org

[WK2][X11] Don't leak the colormap we created for the plugin
https://bugs.webkit.org/show_bug.cgi?id=72144

Reviewed by Xan Lopez.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformDestroy):

09:33 Changeset [100463] by commit-queue@webkit.org

[EFL] Clean up the web database-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72139

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
more standard naming scheme for the related static variables.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):

  • ewk/ewk_settings.h: Document the default web database path on disk.
09:29 Changeset [100462] by darin@apple.com

Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
https://bugs.webkit.org/show_bug.cgi?id=72475

Reviewed by Adam Roben.

  • wtf/HashTraits.h: Specialize HashTraits for OwnPtr.

Do overloads so we can pass a nullptr and also be sure to get the
raw pointer type from the OwnPtr template so we handle both forms
of OwnPtr: OwnPtr<T> and OwnPtr<T*>.

09:27 Changeset [100461] by vestbo@webkit.org

[Qt] Fix use of config.tests

We were checking @buildArgs to determine if the optional argument was
passed or not, but this is not the right way to do that in Perl. The
right way is to not use a prototype for the function, and to pass
the list as a reference (to avoid list expansion). That way we can
check the number of arguments, and choose the right code path based
on that.

We were also missing a default-value of 0 for any feature that's not
set in features.prf.

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(qtFeatureDefaults):
(buildQMakeProject):

09:20 Changeset [100460] by vestbo@webkit.org

[Qt] Prospective fix for broken plugin tests

Don't hide symbols for the NPAPI test plugin

Rubber-stamped by Andreas Kling.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
08:57 Changeset [100459] by jesus@webkit.org

Unreviewed, rolling out r100448.
http://trac.webkit.org/changeset/100448
https://bugs.webkit.org/show_bug.cgi?id=72512

It caused a regression breaking LayoutTests/http/tests/loading
/text-content-type-with-binary-extension.html (Requested by
jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType):

08:55 Changeset [100458] by steveblock@google.com

Web Inspector: Application cache status should be updated after swapCache().
https://bugs.webkit.org/show_bug.cgi?id=72123

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2011-11-16
Reviewed by Pavel Feldman.

  • http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
  • http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-swap.html: Added.
  • http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
  • http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
  • http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
  • http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.
08:50 Changeset [100457] by aroben@apple.com

Move filenames/line numbers off to the right edge in Leaks Viewer

Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
because filenames/line numbers are right next to function names

Reviewed by Andreas Kling.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:

(LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
function name. Use the filename as the profile node's URL (we don't have enough info to
compute a real URL currently) and the line number as the profile node's line number so the
Inspector code will put them on the right side of the callstack graph.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
passed here, just filenames.

(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyResourceAsNode):
Copied and slightly modified from inspector.js.

08:50 Changeset [100456] by aroben@apple.com

Make Leaks Viewer load builds from the new Lion Leaks bot

Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds

Reviewed by Andreas Kling.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
SnowLeopard one.

08:37 Changeset [100455] by commit-queue@webkit.org

[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
https://bugs.webkit.org/show_bug.cgi?id=72392

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-16
Reviewed by Simon Hausmann.

Add QWeakPointer to SocketNotifierResourceGuard::m_socketNotifier to track
deallocation of referenced object.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::SocketNotifierResourceGuard::SocketNotifierResourceGuard):
(CoreIPC::SocketNotifierResourceGuard::~SocketNotifierResourceGuard):

08:09 Changeset [100454] by vsevik@chromium.org

Web Inspector: Application cache status should be updated after swapCache().
https://bugs.webkit.org/show_bug.cgi?id=72123

Reviewed by Pavel Feldman.

Source/WebCore:

Application cache view resources and status are now updated after swapCache() call.
Refresh button removed from application cache view.
Application cache inspector tests are moved to their own folder.

Tests: http/tests/inspector/appcache/appcache-iframe-manifests.html

http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/appcache/appcache-swap.html

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
(WebInspector.ApplicationCacheItemsView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheItemsView.prototype._markDirty):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._deleteCallback):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::setNewestCache):
(WebCore::ApplicationCacheGroup::makeObsolete):
(WebCore::ApplicationCacheGroup::setUpdateStatus):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::swapCache):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::swapCache):

LayoutTests:

  • http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
  • http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-swap.html: Added.
  • http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
  • http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
  • http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
  • http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.
08:05 Changeset [100453] by eric.carlson@apple.com

addTrack() must throw an exception if 'kind' is unknown
https://bugs.webkit.org/show_bug.cgi?id=71915

Reviewed by Philippe Normand.

Source/WebCore:

Tests: media/track/track-addtrack-kind.html

media/track/track-kind.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackKindChanged): New. Will be implemented for 62885.
(WebCore::HTMLMediaElement::addTrack): Throw if 'kind' is not a known value.
(WebCore::HTMLMediaElement::addTextTrack): Call textTracks(), it will allocate the track

list object if necessary.

(WebCore::HTMLMediaElement::textTracks): Never return NULL, a TextTrackList with no tracks

is allowed.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::addTrack): Add variants to deal with optional parameters plus

a mandatory ExceptionCode parameter.

  • html/HTMLMediaElement.idl: addTrack can generate an exception.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged): kind, label, and srclang attribute changes should

percolate down the the TextTrack.

(WebCore::HTMLTrackElement::kind): Return the TextTrack kind because it is not necessarily the

same as the attribute value.

(WebCore::HTMLTrackElement::ensureTrack): Only pass legal 'kind' keywords to create a TextTrack.
(WebCore::HTMLTrackElement::textTrackKindChanged): Notify parent element, if any.

  • html/HTMLTrackElement.h:
  • html/TextTrack.cpp:

(WebCore::TextTrack::subtitlesKeyword): New, return legal kind attribute value.
(WebCore::TextTrack::captionsKeyword): Ditto.
(WebCore::TextTrack::descriptionsKeyword): Ditto.
(WebCore::TextTrack::chaptersKeyword): Ditto.
(WebCore::TextTrack::metadataKeyword): Ditto.
(WebCore::TextTrack::TextTrack): Call setKind to make sure m_kind is always set to legal value.
(WebCore::TextTrack::isValidKindKeyword): New, validate 'kind' value.
(WebCore::TextTrack::setKind): Only allow legal values.

  • html/TextTrack.h:

(WebCore::TextTrack::kind):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):
(WebCore::TextTrack::readyState):
(WebCore::TextTrack::mode):

LayoutTests:

  • media/track/track-addtrack-kind-expected.txt: Added.
  • media/track/track-addtrack-kind.html: Added.
  • media/track/track-kind-expected.txt: Added.
  • media/track/track-kind.html: Added.
08:01 QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
07:58 Changeset [100452] by commit-queue@webkit.org

[EFL] Clean up the offline apps-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72132

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

ewk_settings_cache' and ewk_view_setting_cache' are too common
prefixes for code that is related only to the HTML5 app cache
features.

Use `ewk_settings_application_cache' and
`ewk_view_setting_application_cache' instead.

Source/WebKit/efl:

While here, improve the documentation and use a more common naming
scheme for the static variable which holds the cache path.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_application_cache_path_set):
(ewk_settings_application_cache_path_get):

  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp:

(ewk_view_setting_application_cache_get):
(ewk_view_setting_application_cache_set):

  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

07:57 Changeset [100451] by apavlov@chromium.org

Unreviewed, test fix after http://trac.webkit.org/changeset/100273.

"font" property is no longer mapped to DOMCSSValue, so use "font-family" mapped to DOMCSSValueList instead.

  • platform/mac/plugins/jsobjc-dom-wrappers-expected.txt:
  • platform/mac/plugins/jsobjc-dom-wrappers.html:
07:52 Changeset [100450] by kbalazs@webkit.org

[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing
https://bugs.webkit.org/show_bug.cgi?id=72504

Unreviewed gardening. Skip crashing test.

  • platform/qt/Skipped:
07:49 Changeset [100449] by commit-queue@webkit.org

CSSValue: Clean up initial value construction.
<http://webkit.org/b/72502>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Instead of determining whether a given CSSInitialValue is 'implicit' or not by
querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
add a protected CSSValue member and set it from the CSSInitialValue constructor.

Also get rid of the CSSValue::m_isInitial bit since we can now replace the
checks by classType() == InitialClass.

No new tests, this is a cleanup.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

Poke 'implicit' constructor argument into CSSValue::m_isImplicit.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

Remove ImplicitInitialClass cases.

  • css/CSSValue.h:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::CSSValue):

07:12 Changeset [100448] by commit-queue@webkit.org

[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
https://bugs.webkit.org/show_bug.cgi?id=72169

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-16
Reviewed by Simon Hausmann.

Currently FrameLoaderClientQt::canShowMIMEType is called after
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
PolicyUse and canShowMIMEType returns false, then we have a bug.
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
return true, following the implemenation of WebKit2.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType):

07:07 Rebaseline edited by epoger@google.com
(diff)
07:05 Rebaseline edited by epoger@google.com
(diff)
07:04 Changeset [100447] by commit-queue@webkit.org

Remove unnecessary if check from RenderListBox::paintItemForeground.
https://bugs.webkit.org/show_bug.cgi?id=72488

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Andreas Kling.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

07:04 Rebaseline edited by epoger@google.com
(diff)
07:00 Changeset [100446] by steveblock@google.com

Layout Test inspector/styles/svg-style.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
06:56 Changeset [100445] by zeno.albisser@nokia.com

[Qt][WK2][Mac] MiniBrowser cannot create socketpair.
https://bugs.webkit.org/show_bug.cgi?id=72389

Use SOCK_DGRAM on mac instead of SOCK_SEQPACKET.

Reviewed by Tor Arne Vestbø.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
06:54 Changeset [100444] by rgabor@webkit.org

[Qt] Skip new failing tests.

Unreviewed gardening.

  • platform/qt-mac/Skipped:
06:42 Changeset [100443] by rgabor@webkit.org

[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
https://bugs.webkit.org/show_bug.cgi?id=72493

[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311
https://bugs.webkit.org/show_bug.cgi?id=72491

Unreviewed gardening.

  • platform/qt/Skipped:
06:28 Changeset [100442] by ossy@webkit.org

Unreviewed, rolling out r100281 and r100437.
http://trac.webkit.org/changeset/100281
http://trac.webkit.org/changeset/100437
https://bugs.webkit.org/show_bug.cgi?id=72496

It made all plugin tests fail with paralel NRWT (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

  • platform/qt/Skipped:
06:20 Changeset [100441] by hausmann@webkit.org

[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

  • qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions

magic here where we handle all TEMPLATE = lib .pro files.

06:17 Changeset [100440] by vestbo@webkit.org

Fix path to module file in root project file

Reviewed by Simon Hausmann.

  • WebKit.pro:
06:08 Changeset [100439] by caseq@chromium.org

Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Reviewed by Yury Semikhatsky.

  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • platform/chromium/test_expectations.txt:
06:04 Changeset [100438] by commit-queue@webkit.org

[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-16
Reviewed by Tony Gentilcore.

Source/WebCore:

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRefreshRate):

  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRefreshRate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

06:03 Changeset [100437] by ossy@webkit.org

[Qt] Unreviewed gardening after r100281.

  • platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html

again, because it makes all plugin related tests fail intermittently.

05:51 Changeset [100436] by steveblock@google.com

LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=72494

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
05:28 EFLWebKit edited by rakuco@FreeBSD.org
Update the port information (diff)
05:13 Changeset [100435] by steveblock@google.com

Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
05:09 Changeset [100434] by rgabor@webkit.org

[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490

Unreviewed gardening.

  • platform/qt/Skipped:
04:56 Changeset [100433] by caseq@chromium.org

Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
https://bugs.webkit.org/show_bug.cgi?id=72388

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/extensions/extensions-panel.html

inspector/extensions/extensions-sidebar.html

  • fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
  • drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
  • fix an exception when a page is replaced with object/expression.

inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionSidebarPaneImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionNotifierView):
(WebInspector.ExtensionNotifierView.prototype.wasShown):
(WebInspector.ExtensionNotifierView.prototype.willHide):
(WebInspector.ExtensionSidebarPane.prototype.setObject):
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
(WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
(WebInspector.ExtensionSidebarPane.prototype._setObject):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
(WebInspector.ExtensionServer.prototype._dispatchCallback):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.detach):

LayoutTests:

  • split LayoutTests/inspector/extensions.html into extensions-panel.html & extensions-sidebar.html.
  • inspector/extensions/extensions-panel-expected.txt: Added.
  • inspector/extensions/extensions-panel.html: Added.
  • inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
  • inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.
04:52 Changeset [100432] by commit-queue@webkit.org

Explicitly include unistd.h in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=72385

This is needed for the sleep() call in the indicateTestFailure method,
which seems to be implicitly available for other platforms. This is not
the case on Android.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
04:48 Changeset [100431] by rgabor@webkit.org

[Qt] Update Qt specific expected results.

Unreviewed gardening.

  • platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
  • platform/qt/fast/loader/file-protocol-fragment-expected.txt:
  • platform/qt/inspector: Added.
  • platform/qt/inspector/console: Added.
  • platform/qt/inspector/console/console-format-expected.png: Added.
  • platform/qt/inspector/console/console-format-expected.txt: Added.
04:33 Changeset [100430] by steveblock@google.com

Compositing LayoutTests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=72487

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
03:57 Changeset [100429] by steveblock@google.com

LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
https://bugs.webkit.org/show_bug.cgi?id=72485

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
03:49 Changeset [100428] by commit-queue@webkit.org

[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=72384

Update to Android NDK r7, which was released last Friday. This adds
support for RTTI and the -mimplicit-it gcc flag, which are required to
respectively build ICU and Skia.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):

02:56 Changeset [100427] by hausmann@webkit.org

Unreviewed, rolling out r100266.
http://trac.webkit.org/changeset/100266

Broke WTR.

.:

  • Source/api.pri:

Source/JavaScriptCore:

  • Target.pri:

Source/WebCore:

  • Target.pri:

Tools:

  • qmake/mkspecs/features/default_post.prf:
02:51 Changeset [100426] by rgabor@webkit.org

[Qt][ARMv5] Websocket tests are fail, skip until fix

Unreviewed, gardening.

  • platform/qt-arm/Skipped:
02:35 Changeset [100425] by commit-queue@webkit.org

[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=70720

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-11-16
Reviewed by Philippe Normand.

Source/WebCore:

Added missing overriding of Event::interfaceName()

  • mediastream/MediaStreamEvent.cpp:

(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.

  • mediastream/MediaStreamEvent.h:
  • mediastream/MediaStreamEvent.idl: Changed module name to "events".

LayoutTests:

  • platform/gtk/Skipped: Unskipped fast/events/event-creation.html
01:46 Changeset [100424] by mario@webkit.org

[GTK] Do not hide accessibility root object from AT's
https://bugs.webkit.org/show_bug.cgi?id=72390

Reviewed by Martin Robinson.

  • tests/testatk.c:

(getWebAreaObject): New helper function, to bypass the new root
object in the accessibility hierarchy, since it's not usually
needed for the unit tests.
(testWebkitAtkCaretOffsets): Use getWebAreaObject().
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
(testWebkitAtkComboBox): Ditto.
(testWebkitAtkEmbeddedObjects): Ditto.
(testWebkitAtkGetTextAtOffsetForms): Ditto.
(testWebkitAtkGetTextAtOffset): Ditto.
(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
(testWebkitAtkGetTextInTable): Ditto.
(testWebkitAtkGetHeadersInTable): Ditto.
(testWebkitAtkTextAttributes): Ditto.
(testWebkitAtkTextSelections): Ditto.
(testWebkitAtkGetExtents): Ditto.
(testWebkitAtkLayoutAndDataTables): Ditto.
(testWebkitAtkLinksWithInlineImages): Ditto.
(testWebkitAtkHypertextAndHyperlinks): Ditto.
(testWebkitAtkListsOfItems): Ditto.
(testWebkitAtkTextChangedNotifications): Ditto.
(testWebkitAtkParentForRootObject): New test, to make sure that
both top-down and bottom-up navigation among GTK and WebKit worlds
matches accordingly.
(main): Added new test.

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible): Remove the hack introduced
because of bug 51932, to bypass the root object here.

01:06 Changeset [100423] by eric@webkit.org

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

I will continue engaging hacks, until windows improves.

  • Scripts/webkitpy/common/host.py:
    • Host uses self.executive instead of self._executive like Port does.
    • I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
00:48 Changeset [100422] by jamesr@google.com

[chromium] Update chromium expectations for compositing tests

  • platform/chromium/test_expectations.txt:
00:41 Changeset [100421] by eric@webkit.org

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

Engage windows hacks harder.

This is a speculative fix for ChromiumWin. We're now
creating an SCM object much earlier, so we need to
engage our "awesome" windows hacks earlier.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
00:16 Changeset [100420] by jamesr@google.com

[chromium] Update chromium win and linux compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png.
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png.
  • platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/chromium-mac/compositing/self-painting-layers-expected.png: Removed.
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png.
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png.
  • platform/chromium/compositing/self-painting-layers-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png.
  • platform/chromium/test_expectations.txt:
00:16 Changeset [100419] by mario@webkit.org

[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
https://bugs.webkit.org/show_bug.cgi?id=72394

Reviewed by Martin Robinson.

No new functionality, no new tests needed.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_class_init): Initialize GQuarks.
(getGailTextUtilForAtk): Use gailTextUtilQuark.
(getPangoLayoutForAtk): Remove unused call to
g_object_set_data_full, since that data is no used anywhere.
(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.

00:06 Changeset [100418] by darin@apple.com

Add a "pass type" and "peek type" concept to HashTraits
https://bugs.webkit.org/show_bug.cgi?id=72473

Reviewed by Filip Pizlo.

  • wtf/HashTraits.h: Added the pass type and peek type.

For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.

00:05 Changeset [100417] by darin@apple.com

Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470

Reviewed by Filip Pizlo.

Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.

  • runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from

HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.

  • runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive

from HashTraits<SymbolTableEntry> and removed redundant members.

11/15/11:

23:51 Changeset [100416] by achicu@adobe.com

[CSSShaders] Implement the style cached resources and computed style for the shader urls
https://bugs.webkit.org/show_bug.cgi?id=72378

Reviewed by Dean Jackson.

Source/WebCore:

Test: css3/filters/custom-filter-property-computed-style.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
(WebCore::CSSStyleSelector::styleShader):
(WebCore::CSSStyleSelector::cachedOrPendingStyleShaderFromValue):
(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSStyleSelector.h:
  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::~WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::cachedOrPendingShader):

  • css/WebKitCSSShaderValue.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::CachedShader):
(WebCore::CachedShader::~CachedShader):

  • loader/cache/CachedShader.h:
  • platform/graphics/filters/CustomFilterOperation.h:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::filter):

  • rendering/style/StyleCachedShader.cpp:

(WebCore::StyleCachedShader::StyleCachedShader):
(WebCore::StyleCachedShader::cssValue):

  • rendering/style/StyleCachedShader.h:

(WebCore::StyleCachedShader::create):

  • rendering/style/StylePendingShader.h:

(WebCore::StylePendingShader::create):
(WebCore::StylePendingShader::cssValue):
(WebCore::StylePendingShader::cssShaderValue):
(WebCore::StylePendingShader::StylePendingShader):

  • rendering/style/StyleShader.h:

(WebCore::StyleShader::~StyleShader):
(WebCore::StyleShader::isCachedShader):
(WebCore::StyleShader::isPendingShader):
(WebCore::StyleShader::StyleShader):

LayoutTests:

  • css3/filters/custom-filter-property-computed-style-expected.txt: Added.
  • css3/filters/custom-filter-property-computed-style.html: Added.
  • css3/filters/script-tests/custom-filter-property-computed-style.js: Added.

(jsWrapperClass):
(expression):
(description):

23:48 Changeset [100415] by jamesr@google.com

[chromium] Update chromium mac compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac/animations/3d/matrix-transform-type-animation-expected.png: Removed.
  • platform/chromium-cg-mac/animations/3d/state-at-end-event-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png.
  • platform/chromium-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
  • platform/chromium/animations/3d/replace-filling-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/replace-filling-transform-expected.png.
  • platform/chromium/animations/3d/state-at-end-event-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt.
  • platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
  • platform/chromium/test_expectations.txt:
23:47 Changeset [100414] by carlosgc@webkit.org

[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72380

Reviewed by Martin Robinson.

It adds an initial implementation of WebKitNetworkRequest
class that only contains a URI for now.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.

(webkitNetworkRequestFinalize):
(webkitNetworkRequestGetProperty):
(webkitNetworkRequestSetProperty):
(webkit_network_request_class_init):
(webkit_network_request_init):
(webkit_network_request_new):
(webkit_network_request_get_uri):

  • UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
the given WebKitNetworkRequest.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadRequest):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadRequest):

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2.h:
23:24 Changeset [100413] by sergio@webkit.org

[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
https://bugs.webkit.org/show_bug.cgi?id=69510

Reviewed by Simon Fraser.

Source/WebCore:

End the current transparency layer before early returning from
paintMask() when there is a maskBoxImage which is still being
loaded. This will balance the previous call to
beginTransparencyLayer().

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintMask):

LayoutTests:

Unskipped tests that are now passing.

  • platform/gtk/Skipped:
  • platform/gtk-wk2/Skipped:
23:23 Changeset [100412] by ossy@webkit.org

Unreviewed, rolling out r100375 and r100385.
http://trac.webkit.org/changeset/100375
http://trac.webkit.org/changeset/100385
https://bugs.webkit.org/show_bug.cgi?id=72465

They broke 32 bit builds on Qt (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice):

  • runtime/ArgList.h:

(JSC::ArgList::ArgList):

  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSGlobalObject.h:
23:19 Changeset [100411] by jamesr@google.com

[chromium] Land specific expectations for compositing tests
https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium/test_expectations.txt:
23:09 Changeset [100410] by commit-queue@webkit.org

[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
is inactive.
https://bugs.webkit.org/show_bug.cgi?id=70407

Make sure we only activate the synchronization timer in
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
otherwise syncLayers may be called redundantly.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-11-15
Reviewed by Noam Rosenthal.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::markForSync):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::markForSync):

  • WebCoreSupport/PageClientQt.h:

(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

22:46 Changeset [100409] by darin@apple.com

DRT's uiElementAttributeValueCallback function is leaky
https://bugs.webkit.org/show_bug.cgi?id=72453

Reviewed by Dan Bernstein.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.

22:46 Changeset [100408] by darin@apple.com

Incorrect type checks in RenderTheme media code
https://bugs.webkit.org/show_bug.cgi?id=72184

Reviewed by Eric Carlson.

No tests added. Ideally this patch should be revised to add tests!

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
(WebCore::AccessibilityMediaControl::controlType): Ditto.
(WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
rather than an assertion to check type of input element.

  • html/shadow/MediaControlElements.cpp:

(WebCore::mediaControlElementType): Added. A type-safe way to get the
media control element type after checking isMediaControlElement but with
no other assumptions.

  • html/shadow/MediaControlElements.h: Added mediaControlElementType.
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
use mediaControlElementType.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
redundant null check.
(WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.

22:41 Changeset [100407] by rniwa@webkit.org

Implement edit-distance based reviewer recognition algorithm
https://bugs.webkit.org/show_bug.cgi?id=72351

Reviewed by Eric Seidel.

Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
"build fix" to a reviewer's name (e.g. with with edit distance 9).

This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
the edit distance is implemented in edit_distance.py.

Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/common/editdistance.py: Added.
  • Scripts/webkitpy/common/editdistance_unittest.py: Added.
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
22:21 Changeset [100406] by staikos@webkit.org

Remove the guard page from the addressable stack region on QNX.
https://bugs.webkit.org/show_bug.cgi?id=72455

Reviewed by Daniel Bates.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

22:06 Changeset [100405] by msaboff@apple.com

Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=72323

Added 8 bit optimized paths for String and UString ascii() and utf8() methods.

Added String::characters8(), characters16() and is8Bit() helper methods.

Added an new Unicode::convertLatin1ToUTF8() method that works on
LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().

Reviewed by Geoff Garen.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/UString.cpp:

(JSC::UString::utf8):

  • wtf/text/WTFString.cpp:

(WTF::String::ascii):
(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::characters8):
(WTF::String::characters16):
(WTF::String::is8Bit):
(WTF::LChar):
(WTF::UChar):

  • wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertLatin1ToUTF8):

  • wtf/unicode/UTF8.h:
  • wtf/unicode/Unicode.h:
21:46 Changeset [100404] by jamesr@google.com

[chromium] Remove expected PASS expectations for compositing tests.

This will result in a temporary spike in the number of unexpected
PASSes reported by the bots, but will allow me to add specific
expectations for all the compositing tests instead of the current
blanket PASS FAIL line.

  • platform/chromium/test_expectations.txt:
21:40 Changeset [100403] by jamesr@google.com

[chromium] Remove failing expectations from various JS tests that now pass.

  • platform/chromium/test_expectations.txt:
21:33 Changeset [100402] by annacc@chromium.org

Make sure both the video and the track are ready to be tested before testing.
https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Eric Carlson.

  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit.html:
  • platform/chromium/test_expectations.txt:
21:12 Changeset [100401] by commit-queue@webkit.org

[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
https://bugs.webkit.org/show_bug.cgi?id=72423

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::setDrawingBuffer):

21:10 Changeset [100400] by mhahnenberg@apple.com

Rebaseline generated WebCore bindings

Unreviewed build fix

No new tests.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::isObservable):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::clearImpl):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::isObservable):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::clearImpl):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::isObservable):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::isObservable):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

20:47 Changeset [100399] by commit-queue@webkit.org

Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

20:29 Changeset [100398] by mhahnenberg@apple.com

JS DOM wrappers depend on destructor to deref impl RefPtrs
https://bugs.webkit.org/show_bug.cgi?id=72341

Reviewed by Sam Weinig.

No new tests.

Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default
wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

20:28 Changeset [100397] by tony@chromium.org

Skip a failing webkitpy test on cygwin.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
20:17 Changeset [100396] by tony@chromium.org

[chromium] fix overlapping expectations
https://bugs.webkit.org/show_bug.cgi?id=72458

  • platform/chromium/test_expectations.txt:
19:54 Changeset [100395] by commit-queue@webkit.org

Web Inspector: Share Highlight Code for Drawing Outlined Quad
https://bugs.webkit.org/show_bug.cgi?id=72451

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-15
Reviewed by Timothy Hatcher.

  • inspector/DOMNodeHighlighter.cpp:
19:18 Changeset [100394] by commit-queue@webkit.org

Unreviewed, rolling out r100308.
http://trac.webkit.org/changeset/100308
https://bugs.webkit.org/show_bug.cgi?id=72450

Introduces WebGL conformance test regressions. (Requested by
twiz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

19:06 Changeset [100393] by pkasting@chromium.org

Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
19:01 Changeset [100392] by jamesr@google.com

Rollout http://trac.webkit.org/changeset/99813, caused some crashes in
TiledLayerChromium::updateCompositorResources()

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp.

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.

(WebCore::LayerTextureUpdaterCanvas::contentRect):
(WebCore::LayerTextureUpdaterBitmap::orientation):
(WebCore::LayerTextureUpdaterSkPicture::orientation):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
18:53 Changeset [100391] by darin@apple.com

REGRESSION (r98887): ParserArena and Keywords leaking
https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

  • parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

  • parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

  • runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
18:51 Changeset [100390] by jamesr@google.com

[chromium] Fix overlapping expectations on chromium mac

  • platform/chromium/test_expectations.txt:
18:49 Changeset [100389] by jchaffraix@webkit.org

Add the needed plumbing to parse display: -webkit-inline-grid
https://bugs.webkit.org/show_bug.cgi?id=72438

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added the needed constants and plugged everything together.
Again we treat display: -webkit-inline-grid like display: none
for the moment.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Integrated testing for display: -webkit-inline-grid into the existing test.

  • fast/css-grid-layout/display-grid-set-get-expected.txt:
  • fast/css-grid-layout/display-grid-set-get.html:
  • fast/css-grid-layout/resources/display-grid-set-get.js:
18:38 Changeset [100388] by wjmaclean@chromium.org

[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
https://bugs.webkit.org/show_bug.cgi?id=72162

Reviewed by Kenneth Russell.

Refactoring of existing functionality, so uses existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

18:13 Changeset [100387] by pkasting@chromium.org

Unreviewed, rolling out r100340.
http://trac.webkit.org/changeset/100340
https://bugs.webkit.org/show_bug.cgi?id=72448

Caused assertion failure in Win dbg canary. (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
18:03 Changeset [100386] by jchaffraix@webkit.org

Switch table indexing to unsigned
https://bugs.webkit.org/show_bug.cgi?id=72083

Reviewed by Darin Adler.

No expected change in behavior.

All of the code is now using unsigned for indexing!

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::colElement):
(WebCore::RenderTable::cellAbove):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):
Added some ASSERTs to make sure we don't underflow. Looking at how
the different variables are populated, they should not be reached.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Those 2 functions promotes HTMLTableCellElement's int to unsigned
which should be fine as we make sure their are positive. Also HTML5
makes those 2 fields "unsigned long" which goes in the same direction.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):
Rewrote a couple of reverse iterating to be able to use unsigned
without overflowing.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::insertSpanCell):

  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
(WebCore::RenderTable::recalcSections):

  • rendering/RenderTable.h:

(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::spanOfEffCol):
(WebCore::RenderTable::effColToCol):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::CollapsedBorders::nextBorder):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::updateFromElement):

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::span):
(WebCore::RenderTableCol::setSpan):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::appendColumn):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
(WebCore::RenderTableSection::getBaseline):
Mechanical change int -> unsigned.

17:53 Changeset [100385] by ggaren@apple.com

Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.

  • runtime/ArgList.h: Removed!
17:52 Changeset [100384] by aestes@apple.com

Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
https://bugs.webkit.org/show_bug.cgi?id=72106

Reviewed by Anders Carlsson.

Source/WebCore:

Add a class that encapsulates the logic of scheduling, enabling and
invalidating a run loop observer that fires before Core Animation's
commit observer. Clients can subclass LayerFlushSchedulerClient and
implement flushLayers(), which will be called by the observer.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/LayerFlushScheduler.cpp: Added.

(WebCore::LayerFlushScheduler::suspend): Suspend scheduling by
invalidating the run loop observer. Keep a count of calls to suspend()
in m_suspendCount.
(WebCore::LayerFlushScheduler::resume): Decrement m_suspendCount.
Install the run loop observer when it reaches 0.

  • platform/graphics/ca/LayerFlushSchedulerClient.h: Added.

(WebCore::LayerFlushSchedulerClient::~LayerFlushSchedulerClient):

  • platform/graphics/ca/LayerFlushScheduler.h: Added.
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: Added.

(LayerFlushScheduler::LayerFlushScheduler):
(LayerFlushScheduler::~LayerFlushScheduler):
(LayerFlushScheduler::runLoopObserverCallback): Call flushLayers() on
the LayerFlushSchedulerClient.
(LayerFlushScheduler::schedule): Install the run loop observer.
(LayerFlushScheduler::invalidate): Remove the run loop
observer if it is installed.

Source/WebKit/mac:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

  • WebView/WebView.mm:

(-[WebView _close]): Invalidate the run loop observer and destroy the
LayerFlushController.
(LayerFlushController::flushLayers): Perform the work that
layerSyncRunLoopObserverCallBack used to do.
(-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
yet to be created, create it, then schedule a layer flush.

  • WebView/WebViewData.h:

(LayerFlushController::create): Create a LayerFlushController that
implements the LayerFlushSchedulerClient interface and contains a
LayerFlushScheduler with itself as the client.

  • WebView/WebViewData.mm:

(LayerFlushController::scheduleLayerFlush):
(LayerFlushController::invalidateObserver):
(LayerFlushController::LayerFlushController):

Source/WebKit2:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Replace

m_flushPendingLayerChangesRunLoopObserver with m_layerFlushScheduler
and implement the LayerFlushSchedulerClient interface.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Instantiate
m_layerFlushScheduler with the LayerTreeHost as the client.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Call LayerFlushScheduler::schedule().
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Call
LayerFlushScheduler::suspend() or LayerFlushScheduler::resume().
(WebKit::LayerTreeHostCAMac::invalidate): Call LayerFlushScheduler::invalidate().
(WebKit::LayerTreeHostCAMac::flushLayers): Do the work that
flushPendingLayerChangesRunLoopObserverCallback() used to do.
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush): Call LayerFlushScheduler::invalidate().

17:51 Changeset [100383] by pkasting@chromium.org

Maybe the reason we're fiddling with line endings is that this file
didn't set svn:eol-style. Set it.

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
17:47 Changeset [100382] by pkasting@chromium.org

Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
17:43 Changeset [100381] by dslomov@google.com

Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
until https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed.

  • platform/mac/Skipped:
  • platform/win/Skipped:
17:41 Changeset [100380] by weinig@apple.com

TestWebKitAPI should not put its resources in the root products directory
https://bugs.webkit.org/show_bug.cgi?id=72446

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Change the copy resources phase to place the resources in a TestWebKitAPI.resources
directory.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(TEST_F):

  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:

(TestWebKitAPI::DeviceScaleFactorOnBack::url):

  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:

(TestWebKitAPI::DynamicDeviceScaleFactor::url):

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::createURLForResource):
Update calls to retrieve files from the bundle to look in the newly
created subdirectory.

17:36 Changeset [100379] by arv@chromium.org

Rebaseline after r100289

Unreviewed.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt: Fix line endings
17:35 Changeset [100378] by weinig@apple.com

Add a connection client to the WKContext, to notify when new connections to the WebProcess are established
https://bugs.webkit.org/show_bug.cgi?id=72433

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetConnectionClient):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeConnectionClient):

  • UIProcess/WebContext.h:

Add connection client API.

  • UIProcess/WebContextConnectionClient.cpp: Added.

(WebKit::WebContextConnectionClient::didCreateConnection):

  • UIProcess/WebContextConnectionClient.h: Added.

Add basic implementation of the client. It is currently never triggered.

17:29 Changeset [100377] by tony@chromium.org

Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
17:27 Changeset [100376] by adamk@chromium.org

[v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
https://bugs.webkit.org/show_bug.cgi?id=72432

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):

LayoutTests:

Updated test that depends on the error message. The new message is a
strict improvement, as it includes the line number at which the
too-deep call was triggered. Also, we only expect a single error
message; it's not clear why the previous version generated a dup.

Also consolidate expectations, as the test does not differ per platform.

  • platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
17:25 Changeset [100375] by ggaren@apple.com

Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use new API.

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
getSlice can do the right thing by using its rights to private data.

  • runtime/ArgList.h: Removed constructor that took a forward-contiguous

set of arguments.

  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSGlobalObject.h:

(JSC::constructArray): Added explicit support for creating an array from
a pre-allocated set of values, so we could stop relying on the ArgList
API we want to remove.

17:23 Changeset [100374] by tony@chromium.org

Unreviewed, fix test-webkitpy tests. Move the check for image results
earlier.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
17:06 Changeset [100373] by scheib@chromium.org

Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
https://bugs.webkit.org/show_bug.cgi?id=72431

Reviewed by Adam Barth.

  • page/PointerLock.cpp:

(WebCore::PointerLock::lock):
(WebCore::PointerLock::unlock):
(WebCore::PointerLock::isLocked):

  • page/PointerLock.h:
  • page/PointerLock.idl:
17:03 Changeset [100372] by leviw@chromium.org

Converting table row height calculations back to ints and avoiding enclosingIntRect when outputting test expectations for table parts.

17:03 Changeset [100371] by oliver@apple.com

2011-11-15 Oliver Hunt <oliver@apple.com>

Merged JavaScriptCore r92804-r99898.

Disabled thread verification on RefPtr, so as to minimise
changes needed by WebCore.

16:56 Changeset [100370] by nduca@chromium.org

[chromium] Fuse MainThread and CCThread
https://bugs.webkit.org/show_bug.cgi?id=72426

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCMainThread.cpp: Removed.
  • platform/graphics/chromium/cc/CCMainThread.h: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h: Removed.
  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::setMainThread):
(WebCore::CCProxy::mainThread):
(WebCore::CCProxy::setImplThread):
(WebCore::CCProxy::implThread):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::~CCProxy):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScopedThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCScopedMainThreadProxy.h.

(WebCore::CCScopedThreadProxy::create):
(WebCore::CCScopedThreadProxy::postTask):
(WebCore::CCScopedThreadProxy::shutdown):
(WebCore::CCScopedThreadProxy::CCScopedThreadProxy):
(WebCore::CCScopedThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • src/CCMainThreadImpl.cpp: Removed.
  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::CCThreadImpl):

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::setThread):

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):
(WebKit::shutdown):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::endTest):

  • tests/CCThreadTest.cpp: Removed.
16:45 Changeset [100369] by arv@chromium.org

JS Test Harness: Remove need to load external css file to reduce flakiness
https://bugs.webkit.org/show_bug.cgi?id=72295

Reviewed by Ojan Vafai.

Before this patch we pulled in the external CSS file using a link tag. Since this was created dynamically
it might not be loaded and applied when we dump the text for the test. Since the CSS contains white-space
pre-wrap the output was therefore different depending on this race condition. By changing this to use a
style element with the CSS inline there is no longer a race condition.

  • css3/font-feature-settings-parsing.html: Change the order of script and stylesheets so that the injected style element does not affect the test.
  • fast/css/counters/counter-cssText.html: Ditto.
  • fast/css/counters/getCounterValue.html: Ditto.
  • fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml: Ditto.
  • traversal/script-tests/exception-forwarding.js: Ditto.
  • fast/dom/script-tests/domListEnumeration.js: Update the tests to use the right style elements.
  • fast/js/resources/js-test-pre.js: Insert a style element with the css instead of a link element pointing to an external css file.
16:43 Changeset [100368] by jamesr@google.com

[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
https://bugs.webkit.org/show_bug.cgi?id=72444

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:
16:40 Changeset [100367] by pkasting@chromium.org

Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72269

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
16:34 Changeset [100366] by scheib@chromium.org

Pointer Lock: Refactor: MouseEvent.idl movementX/Y
https://bugs.webkit.org/show_bug.cgi?id=72427

  • [Conditional...] vs #if defined
  • Runtime enabled
  • .movementX/Y prefixed with 'webkit'

Reviewed by Adam Barth.

No new tests.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::webkitMovementX):
(WebCore::MouseRelatedEvent::webkitMovementY):

16:29 Changeset [100365] by ojan@chromium.org

implement flex-align for flex-flow: column
https://bugs.webkit.org/show_bug.cgi?id=70754

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-column.html

css3/flexbox/line-wrapping.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
When flexitems are column, they should size to the intrinsic width unless flex-flow is stretch.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
This was just using the wrong, non-flow-aware method.

LayoutTests:

  • css3/flexbox/flex-align-column-expected.txt: Added.
  • css3/flexbox/flex-align-column.html: Added.

Tests the basic flex-align cases with column.

  • css3/flexbox/line-wrapping-expected.txt: Added.
  • css3/flexbox/line-wrapping.html: Added.

This tests that wrapping inside flexitems uses the correct width.
Notably, auto-sizing properly falls back on the initial containing block.

16:27 Changeset [100364] by pkasting@chromium.org

Mark another test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
16:26 Changeset [100363] by fpizlo@apple.com

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

16:26 Changeset [100362] by commit-queue@webkit.org

[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
https://bugs.webkit.org/show_bug.cgi?id=72235

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-15
Reviewed by Gustavo Noronha Silva.

Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy.
It's required when using the soup network backend.
Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and
EFL port use soup network backend without a network backend of their own.

  • GNUmakefile.am:
  • WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed.
  • WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed.
  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

16:24 Changeset [100361] by pkasting@chromium.org

r100331 did not seem to commit precisely the right expectation.
https://bugs.webkit.org/show_bug.cgi?id=72391

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
16:23 Changeset [100360] by jamesr@google.com

[chromium] Unreviewed expectations update for compositing tests
https://bugs.webkit.org/show_bug.cgi?id=72402

Remove now-unnecessary expectations for compositing tests in chromium-gpu* directories and update
test_expectations.txt to un-SKIP compositing tests. Compositing tests are still marked as PASS FAIL
in order to ensure they pass on all bots before turning them on.

File list removed due to length.

16:20 Changeset [100359] by tony@chromium.org

Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that
don't currently support DataTransferItems.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
16:17 Changeset [100358] by pkasting@chromium.org

Mark a test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=72436

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
16:09 Changeset [100357] by ojan@chromium.org

Chromium baselines after http://trac.webkit.org/changeset/100324.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png:
16:04 Changeset [100356] by tony@chromium.org

Unreviewed, better fix for ref tests failures on SL Intel bot.
Revert the previous change and return None if pixel results from
either the test page or the expected page is missing.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
16:02 Changeset [100355] by jamesr@google.com

[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
https://bugs.webkit.org/show_bug.cgi?id=72402

Reviewed by Dirk Pranke.

Tools:

Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
the normal compositing triggers since we currently run the compositing tests in only one configuration - with
compositing enabled.

Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
patch should not impact any tests.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAcceleratedCompositingForVideoEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:54 Changeset [100354] by pkasting@chromium.org

Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
15:52 Changeset [100353] by jochen@chromium.org

Rename ReferrerPolicy to clarify its meaning
https://bugs.webkit.org/show_bug.cgi?id=72420

Reviewed by Nate Chapin.

Source/WebCore:

On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
referrer wasn't necessarily send. On the other hand, I want to use the
name ReferrerPolicy when implementing the meta referrer tag.

No change in behavior expected so no test.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):
(WebCore::handleLinkClick):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadFrameRequest):

  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):

  • WebCore.exp.in: updated.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::loadFrameRequest):

Source/WebKit/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(openNewWindow):
(QWebPage::triggerAction):

Source/WebKit/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::linkClicked):

15:50 Changeset [100352] by tony@chromium.org

Unreviewed, try to fix ref tests failures on SL Intel bot.
It looks like ImageDiff isn't returning an image diff.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
15:46 Changeset [100351] by jchaffraix@webkit.org

Merge 99752 - REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html

fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
fast/repaint/scroll-inside-table-cell.html
fast/repaint/scroll-relative-table-inside-table-cell.html
fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

  • rendering/RenderLayer.h:

Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

  • fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • fast/repaint/scroll-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-inside-table-cell.html: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/8520027

15:41 Changeset [100350] by tony@chromium.org

Unreviewed fix of ref-tests on GTK+.
If a driver is never started, _xvfb_process is never set.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
15:40 Changeset [100349] by tony@chromium.org

set a max-width on the codereview overall comments textarea
https://bugs.webkit.org/show_bug.cgi?id=72415

Reviewed by Ojan Vafai.

Otherwise, when resizing the textarea you can end up making wider, but
are no longer able to click the resize gripper to make it smaller
(it's under another div).

  • PrettyPatch/PrettyPatch.rb:
15:36 Changeset [100348] by lforschler@apple.com

rollout unneeded merge of 91147.

15:34 Changeset [100347] by adamk@chromium.org

Factor out V8Proxy's max recursion depth handling code
https://bugs.webkit.org/show_bug.cgi?id=72422

Reviewed by Nate Chapin.

Previously, V8Proxy used slightly different code to handle stack limit
violations depending on whether they occured in runScript or
callFunction. As described in http://webkit.org/b/72063, I intend to
expand the usage of m_recursion when calling into script. This patch
is intended to unify the existing handling code, making it easier to
move elsewhere without causing unintended side-effects.

No tests changed, as the only change in behavior is the string passed
to RangeError in the runScript case, and it's not mentioned anywhere
in the LayoutTests.

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.

15:29 Changeset [100346] by tony@chromium.org

Skip failing ref tests on Qt.

  • platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and

fast/forms/file/file-input-reset.html are failing. See bugs.

15:27 Changeset [100345] by weinig@apple.com

Fix windows build.

  • win/WebKit2Generated.make:
15:23 Changeset [100344] by pkasting@chromium.org

Mark another test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
15:21 Changeset [100343] by jberlin@webkit.org

NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
https://bugs.webkit.org/show_bug.cgi?id=72419

Reviewed by Adam Roben.

Adopt the copied NSURLRequest.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::setStorageSession):

15:09 Changeset [100342] by lforschler@apple.com

Merged r91147.

15:08 Changeset [100341] by lforschler@apple.com

Merged r91145.

15:07 Changeset [100340] by commit-queue@webkit.org

Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <jbates@google.com> on 2011-11-15
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
15:07 Changeset [100339] by lforschler@apple.com

Merged r91140.

15:05 Changeset [100338] by jchaffraix@webkit.org

Add the needed plumbing to parse display: -webkit-grid
https://bugs.webkit.org/show_bug.cgi?id=72331

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:

Added the new CSS value and plumbed the parsing and style application of
the new value.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.

LayoutTests:

  • fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
  • fast/css-grid-layout/display-grid-set-get.html: Added.
  • fast/css-grid-layout/resources/display-grid-set-get.js: Added.

Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:

SKIP the css-grid-layout tests on all platforms for now.

15:01 Changeset [100337] by jamesr@google.com

https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectations shuffle.

Copy compositing expectations for chromium-win into their correct locations.

File list omitted due to length.

15:01 Changeset [100336] by weinig@apple.com

Add WebKit2 API object to represent a connection
https://bugs.webkit.org/show_bug.cgi?id=72421

Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • Shared/API/c/WKBase.h:

Add type.

  • Shared/API/c/WKConnectionRef.cpp: Added.

(WKConnectionGetTypeID):
(WKConnectionSetConnectionClient):
(WKConnectionPostMessage):

  • Shared/API/c/WKConnectionRef.h: Added.

Expose interface. Currently no support for synchronous messages.

  • Shared/API/c/WKSharedAPICast.h:

Define relationship between WebConnection <-> WKConnectionRef.

  • Shared/APIObject.h:

Add API type.

  • Shared/WebConnection.cpp: Added.

(WebKit::WebConnection::~WebConnection):
(WebKit::WebConnection::initializeConnectionClient):

  • Shared/WebConnection.h: Added.

(WebKit::WebConnection::type):
Sketch out the connection object. It is currently abstract
to allow different implementations for the UI and WebProcess sides
while retaining the same interface.

  • Shared/WebConnectionClient.cpp: Added.

(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):

  • Shared/WebConnectionClient.h: Added.

Add simple client.

  • UIProcess/API/C/WebKit2.h:

Add new file.

15:00 Changeset [100335] by lforschler@apple.com

Merged r91138.

14:59 Changeset [100334] by lforschler@apple.com

Merged r91137.

14:53 Changeset [100333] by jamesr@google.com

https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectations shuffle.

Copy compositing expectations for chromium-linux and chromium-mac into their correct locations.

File list omitted due to length.

14:52 Changeset [100332] by lforschler@apple.com

Merged r90954.

14:48 Changeset [100331] by pkasting@chromium.org

Fix expectations after r100289.
https://bugs.webkit.org/show_bug.cgi?id=72391

fast/dom/Orientation/create-event-orientationchange.html was updated but
the expected text was not.

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
14:46 Changeset [100330] by ojan@chromium.org

Pixel result accidentally left out of http://trac.webkit.org/changeset/100324.

  • platform/mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png:
14:43 Changeset [100329] by jamesr@google.com

https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectation shuffle.

Copy compositing expectations for chromium/ and chromium-cg-mac/ into their correct locations.

  • platform/chromium-cg-mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/chromium-cg-mac/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/chromium-cg-mac/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-cg-mac/compositing/generated-content-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/geometry/outline-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-cg-mac/compositing/images/direct-svg-image-expected.png: Added.
  • platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/zero-size-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/load-video-in-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-cg-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-cg-mac/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac/compositing/sibling-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-img-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-cg-mac/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/chromium-cg-mac/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-cg-mac/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
  • platform/chromium/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium/compositing/iframes/resizer-expected.txt: Added.
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/chromium/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/chromium/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w.html: Added.
  • platform/chromium/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/chromium/compositing/webgl/webgl-no-alpha-expected.txt: Added.
  • platform/chromium/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added.
  • platform/chromium/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
14:38 Changeset [100328] by scheib@chromium.org

Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
https://bugs.webkit.org/show_bug.cgi?id=72315

Reviewed by Dimitri Glazkov.

  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
  • page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp.

(WebCore::PointerLock::PointerLock):
(WebCore::PointerLock::~PointerLock):
(WebCore::PointerLock::webkitLock):
(WebCore::PointerLock::webkitUnlock):
(WebCore::PointerLock::webkitIsLocked):

  • page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h.

(WebCore::PointerLock::create):

  • page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl.
14:36 Changeset [100327] by commit-queue@webkit.org

Rebaseline mac pixel results for complex inner border change
https://bugs.webkit.org/show_bug.cgi?id=72355

Patch by Ben Wells <benwells@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

  • platform/mac/fast/borders/border-radius-complex-inner-expected.png: Added.
  • platform/mac/fast/borders/border-radius-different-width-001-expected.png:
14:30 Changeset [100326] by tony@chromium.org

[NRWT] Reftests should run even when pixel tests are disabled.
https://bugs.webkit.org/show_bug.cgi?id=60605

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.

Also add an assert to make sure we get image hashes back when running ref tests.

  • Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
  • Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work

of starting a pixel driver if needed. It handles the logic of sending the test
to the correct driver. Also renamed Driver.poll() to Driver.has_crashed().

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
14:29 Changeset [100325] by pkasting@chromium.org

Fix expectations after r100283.
https://bugs.webkit.org/show_bug.cgi?id=72137

We don't have a LION modifier, and I'm not sure why one test was only
skipped for SNOWLEOPARD RELEASE as it fails on Debug also.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
14:25 Changeset [100324] by ojan@chromium.org

Overflow and relayout are broken in the new flexboxes
https://bugs.webkit.org/show_bug.cgi?id=71161

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/auto-height-dynamic.html

css3/flexbox/flex-item-child-overflow-expected.html
css3/flexbox/flex-item-child-overflow.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
-Always set the logical height to 0 to start with to ensure we don't
use the height from the previous layout when we are computing the
intrinsic size of the flexbox.
-Call computeOverflow after computeLogicalHeight so that flex-item's children's
overflow is properly rendered.

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
-Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
-Refactor flipping code. The behavior is the same, but the variable names are just
more correct.

LayoutTests:

  • css3/flexbox/auto-height-dynamic-expected.txt: Added.
  • css3/flexbox/auto-height-dynamic.html: Added.
  • css3/flexbox/flex-item-child-overflow-expected.html: Added.
  • css3/flexbox/flex-item-child-overflow.html: Added.
14:23 Changeset [100323] by cfleizach@apple.com

AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue:
https://bugs.webkit.org/show_bug.cgi?id=72344

Reviewed by Beth Dakin.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

14:22 Changeset [100322] by leviw@chromium.org

Properly bounding CSS lengths to AppUnit's bounds. Rounding instead of truncating offset values.

14:21 Changeset [100321] by lforschler@apple.com

Merged r90925. needed for 93040.

14:19 Changeset [100320] by ggaren@apple.com

Use MarkedArgumentBuffer to avoid making assumptions about argument order
https://bugs.webkit.org/show_bug.cgi?id=72418

Reviewed by Sam Weinig.

A step toward reversing the argument order.

  • runtime/JSONObject.cpp:

(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::callReviver): Don't assume that ArgList wants to point
at arguments in forward order. Instead, use MarkedArgumentBuffer, which
will make the decision for us.

14:17 Changeset [100319] by pkasting@chromium.org

Fix expectations after r100276.
https://bugs.webkit.org/show_bug.cgi?id=72270

Some lines were commented out to avoid expectation conflicts but this
erroneously removed an expectation that some tests would fail on the
Leopard (CG) bots.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
14:12 Changeset [100318] by commit-queue@webkit.org

Move plugins/invalidate_rect.html to the compositing directory since it is a compositor test
https://bugs.webkit.org/show_bug.cgi?id=72410

Patch by James Robinson <jamesr@chromium.org> on 2011-11-15
Reviewed by Simon Fraser.

  • compositing/plugins/invalidate_rect-expected.txt: Renamed from LayoutTests/plugins/invalidate_rect-expected.txt.
  • compositing/plugins/invalidate_rect.html: Renamed from LayoutTests/plugins/invalidate_rect.html.
14:00 Changeset [100317] by tony@chromium.org

[chromium] enable regions and exclusions tests, the compile flag was removed a long time ago
https://bugs.webkit.org/show_bug.cgi?id=72395

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
13:54 Changeset [100316] by eae@chromium.org

Have SVGRenderTreeAsText print pixel snapped coordinates and sizes for the root and container elements.

13:54 Changeset [100315] by fpizlo@apple.com

DFG should distinguish between constants in the constant pool and weak
constants added as artifacts of code generation
https://bugs.webkit.org/show_bug.cgi?id=72367

Reviewed by Geoff Garen.

Added the notion of a WeakJSConstant, which is like a JSConstant except that
it can only refer to JSCell*. Currently all WeakJSConstants are also backed
by constants in the constant pool, since weak references originated from
machine code are not yet properly handled.

Replaced CheckMethod, and MethodCheckData, with a combination of WeakJSConstant
and CheckStructure. This results in improved CSE, leading to a 1% win on V8.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::weakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::hasIdentifier):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:38 Changeset [100314] by msaboff@apple.com

Towards 8 bit Strings - Initial JS String Tuning
https://bugs.webkit.org/show_bug.cgi?id=72326

Added 8 bit optimized paths for the methods below.

Reviewed by Geoffrey Garen.

  • runtime/JSString.h:

(JSC::jsSubstring8):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharCodeAt):

13:03 Changeset [100313] by commit-queue@webkit.org

Extend sunspider driver to be able to run kraken
https://bugs.webkit.org/show_bug.cgi?id=71799

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-15
Reviewed by Filip Pizlo.

  • resources/sunspider-standalone-driver.js: Try to load a -data

file. If that succeeds, we have a kraken-like test, so we time
the test using load'. Otherwise fall back to using run'.

12:43 Changeset [100312] by commit-queue@webkit.org

Unreviewed, rolling out r100291.
http://trac.webkit.org/changeset/100291
https://bugs.webkit.org/show_bug.cgi?id=72403

For some unexpected reason the behavior is different across
platforms, causing test failures (Requested by schenney on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

  • svg/custom/zero-path-square-cap-rendering3-expected.png: Removed.
  • svg/custom/zero-path-square-cap-rendering3-expected.txt: Removed.
  • svg/custom/zero-path-square-cap-rendering3.svg: Removed.
12:40 Changeset [100311] by japhet@chromium.org

Source/WebCore: CachedResourceRequest is now the only SubresourceLoaderClient
Merge CachedResourceRequest into SubresourceLoader and delete
the SubresourceLoaderClient interface. A few items were moved
to CachedResource instead of SubresourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=71149

Reviewed by Adam Barth.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
(WebCore::SubresourceLoader::init): Do work that had previously been

done in SubresourceLoader::create() after the constructor.

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didSendData):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::didReceiveCachedMetadata):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::releaseResources): Do the cleanup work that was

duplicated throughout the various terminal CachedResourceRequest callbacks.

  • loader/SubresourceLoader.h: Fix indentation style issues.
  • loader/SubresourceLoaderClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load): Do the work that had been done in

CachedResourceRequest::load().

(WebCore::CachedResource::finish):
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::stopLoading):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::canDelete):

  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceRequest.cpp: Removed.
  • loader/cache/CachedResourceRequest.h: Removed.
  • loader/cf/SubresourceLoaderCF.cpp:
  • loader/chromium/CachedResourceRequestChromium.cpp: Removed.
  • loader/chromium/SubresourceLoaderChromium.cpp:

LayoutTests: Test udpates for https://bugs.webkit.org/show_bug.cgi?id=71149.
The changes to SubresourceLoader slightly change the timings of
certain resource load callbacks.
https://bugs.webkit.org/show_bug.cgi?id=71149

Reviewed by Adam Barth.

  • fast/loader/file-protocol-fragment-expected.txt:
  • platform/chromium-cg-mac/security/block-test-expected.txt:
  • platform/chromium-mac/security/block-test-expected.txt:
  • platform/chromium-win/security/block-test-expected.txt:
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
12:34 Changeset [100310] by barraclough@apple.com

Result of Error.prototype.toString not ES5 conformant
https://bugs.webkit.org/show_bug.cgi?id=70889

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

LayoutTests:

  • fast/js/native-error-prototype-expected.txt:
  • fast/js/script-tests/native-error-prototype.js:
  • fast/js/script-tests/toString-recursion.js:
  • fast/js/toString-recursion-expected.txt:
12:25 Changeset [100309] by andersca@apple.com

HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
https://bugs.webkit.org/show_bug.cgi?id=72397

Reviewed by Dan Bernstein.

Source/WebCore:

screenToWindow and windowToScreen already use root view coordinates everywhere, with the
exception of Mac WebKit1 which doesn't even implement the functions.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper position]):

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::screenToRootView):
(WebCore::Chrome::rootViewToScreen):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::refresh):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenToRootView):
(WebKit::ChromeClientImpl::rootViewToScreen):

  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::screenToRootView):
(WebKit::WebPopupMenuImpl::rootViewToScreen):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::rootViewToScreen):
(WebCore::ChromeClientEfl::screenToRootView):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::rootViewToScreen):
(WebKit::ChromeClient::screenToRootView):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::screenToRootView):
(WebChromeClient::rootViewToScreen):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::rootViewToScreen):
(WebCore::ChromeClientQt::screenToRootView):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::rootViewToScreen):
(WebChromeClient::screenToRootView):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::rootViewToScreen):
(WebKit::ChromeClientWinCE::screenToRootView):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::rootViewToScreen):
(WebCore::ChromeClientWx::screenToRootView):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::screenToRootView):
(WebKit::WebChromeClient::rootViewToScreen):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:21 Changeset [100308] by commit-queue@webkit.org

Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

12:13 Changeset [100307] by commit-queue@webkit.org

Source/WebCore: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
https://bugs.webkit.org/show_bug.cgi?id=70421

Patch by Eugene Nalimov <enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

Problem demonstrated itself when HTMLAudioElement was changed to become active DOM object.
Before that there were no DOM objects that simultaneously were nodes and active objects.
DOM object could be held in one of 3 maps -- node map, active objects map, and all other
objects map, and HTMLAudioElement should be in 2 maps simultaneously. When it was in the
active DOM objects map only, its event listener could be garbage collected, because special
code that groups listeners with wrappers could handle only wrappers for objects in the node
map. If we put HTMLAudioElement into nodes map, it would not be active DOM node, and can be
garbage collected prematurely itself (see https://bugs.webkit.org/show_bug.cgi?id=66878).
Fix is to introduce 4th map -- active nodes map, and change the code accordingly.

Test: media/audio-garbage-collect.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GetDomMapFunction):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
(WebCore::DOMDataStore::weakNodeCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::activeDomNodeMap):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:

(WebCore::getActiveDOMNodeMap):
(WebCore::removeAllDOMObjects):
(WebCore::visitActiveDOMNodes):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8GCController.cpp:

(WebCore::GCPrologueSpecialCase):
(WebCore::void):
(WebCore::Node):
(WebCore::GCPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::GCEpilogueHelper::GCEpilogueSpecialCase):
(WebCore::GCEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcEpilogue):

  • dom/Node.h:

(WebCore::Node::isActiveNode):

  • html/HTMLAudioElement.h:

(WebCore::HTMLAudioElement::isActiveNode):

LayoutTests: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
https://bugs.webkit.org/show_bug.cgi?id=70421 and https://bugs.webkit.org/show_bug.cgi?id=66878

Patch by Eugene Nalimov <enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

  • media/audio-garbage-collect-expected.txt: Added.
  • media/audio-garbage-collect.html: Added.
12:05 Changeset [100306] by commit-queue@webkit.org

[Chromium] gamepad changes to the public interface of Chromium port
https://bugs.webkit.org/show_bug.cgi?id=71518

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-15
Reviewed by Darin Fisher.

Adds stubs for Chromium port, and defines shared memory structure to
be used between browser and WebKit.

Includes just the parts that touch the public interface so they can be
reviewed separately. See also:
https://bugs.webkit.org/show_bug.cgi?id=69451 and
http://codereview.chromium.org/8345027

  • WebKit.gyp:
  • public/WebGamepad.h: Added.

(WebKit::WebGamepad::WebGamepad):

  • public/WebGamepads.h: Added.

(WebKit::WebGamepads::WebGamepads):

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::sampleGamepads):

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

11:58 Changeset [100305] by robert@webkit.org

Mac results for r100177

Unreviewed gardening.

  • platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/mac/fast/table/multiple-captions-display-expected.txt:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
11:54 Changeset [100304] by ossy@webkit.org

[Qt] Unreviewed evening gardening after r100289.

  • platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt:
11:49 Changeset [100303] by annacc@chromium.org

Make sure both the video and the track are ready to be tested before testing.
https://bugs.webkit.org/show_bug.cgi?id=72399

Reviewed by Eric Carlson.

  • media/track/track-cues-seeking.html:
11:48 Changeset [100302] by leviw@chromium.org

Fixing overloaded scrollbar painting methods on Mac

11:47 Changeset [100301] by tony@chromium.org

Land chromium win results for flexbox repaint tests.
Still waiting on mac results.

  • platform/chromium-win/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:37 Changeset [100300] by annacc@chromium.org

Guarantee tests run in order.
https://bugs.webkit.org/show_bug.cgi?id=72398

Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc013-settings.html:
11:29 Changeset [100299] by annacc@chromium.org

Guarantee tests run in order.
https://bugs.webkit.org/show_bug.cgi?id=72369

Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc003-newlines.html:
  • platform/chromium/test_expectations.txt:
11:16 Changeset [100298] by ddkilzer@apple.com

Remove useless const modifier from KURL::init
<http://webkit.org/b/72387>

Reviewed by Darin Adler.

  • platform/KURL.cpp:

(WebCore::KURL::init): Remove useless const.

11:16 Changeset [100297] by tonyg@chromium.org

editing/pasteboard/drag-drop-dead-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72379

Reviewed by Adam Barth.

  • editing/pasteboard/drag-drop-dead-frame.html: Wait for iframe to load before running test.
  • platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt: Rebaseline.
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
  • platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
  • platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
11:14 Changeset [100296] by annacc@chromium.org

Change layout tests for cuechange, enter, and exit events to check the order
rather than the timing of the events (since actual timing can not be guaranteed).
https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Tony Gentilcore.

  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-enter-exit.html:
  • platform/chromium/test_expectations.txt:
10:58 Changeset [100295] by lforschler@apple.com

New tag.

10:56 Changeset [100294] by lforschler@apple.com

Versioning.

10:51 Changeset [100293] by lforschler@apple.com

Merge 100022.

10:25 Changeset [100292] by tony@chromium.org

enable new flexbox tests everywhere
https://bugs.webkit.org/show_bug.cgi?id=72325

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:21 Changeset [100291] by commit-queue@webkit.org

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

This adds test to ensure that the bug does not reappear unnoticed.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-15
Reviewed by Nikolas Zimmermann.

  • svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
  • svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
  • svg/custom/zero-path-square-cap-rendering3.svg: Added.
09:54 Changeset [100290] by andersca@apple.com

HostWindow invalidation functions should use root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72338

Reviewed by Dan Bernstein.

Source/WebCore:

Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
are in root view coordinates by changing contentsToWindow calls to contentsToRootView.

In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStorePaintEnd):

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):

  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

  • platform/chromium/FramelessScrollView.cpp:

(WebCore::FramelessScrollView::invalidateRect):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndRootView):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateRootView):
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):

  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::invalidateRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):

  • src/WebPopupMenuImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateRootView):
(WebCore::ChromeClientQt::invalidateContentsAndRootView):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::invalidateRootView):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndRootView):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateRootView):
(WebKit::WebChromeClient::invalidateContentsAndRootView):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
09:52 Changeset [100289] by arv@chromium.org

Fix invalid markup in some tests
https://bugs.webkit.org/show_bug.cgi?id=72391

Reviewed by Ojan Vafai.

These tests had <div id="console"></p> in them which causes a lot of extra whitespace.

  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-text.html:
  • fast/dom/HTMLElement/attr-dir-auto-children-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-children.html:
  • fast/dom/HTMLElement/attr-dir-auto-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control.html:
  • fast/dom/HTMLElement/attr-dir-auto.html:
  • fast/dom/HTMLElement/attr-dir-value-change-expected.txt:
  • fast/dom/HTMLElement/attr-dir-value-change.html:
  • fast/dom/HTMLElement/attr-empty-string-expected.txt:
  • fast/dom/HTMLElement/attr-empty-string.html:
  • fast/dom/HTMLElement/attr-false-string-expected.txt:
  • fast/dom/HTMLElement/attr-false-string.html:
  • fast/dom/HTMLElement/attr-invalid-string-expected.txt:
  • fast/dom/HTMLElement/attr-invalid-string.html:
  • fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt:
  • fast/dom/HTMLElement/attr-missing-ancestor-false.html:
  • fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt:
  • fast/dom/HTMLElement/attr-missing-ancestor-true.html:
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html:
  • fast/dom/HTMLElement/attr-missing-parent-false-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-false.html:
  • fast/dom/HTMLElement/attr-missing-parent-true-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-true.html:
  • fast/dom/HTMLElement/attr-true-string-expected.txt:
  • fast/dom/HTMLElement/attr-true-string.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon.html:
  • fast/dom/HTMLElement/set-false-expected.txt:
  • fast/dom/HTMLElement/set-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-true.html:
  • fast/dom/HTMLElement/set-invalid-value-expected.txt:
  • fast/dom/HTMLElement/set-invalid-value.html:
  • fast/dom/HTMLElement/set-true-expected.txt:
  • fast/dom/HTMLElement/set-true.html:
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive.html:
  • fast/dom/Orientation/create-event-orientationchange.html:
09:30 Changeset [100288] by philn@webkit.org

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
09:25 Changeset [100287] by ddkilzer@apple.com

Don't use File::Slurp for run-leaks unit tests
<http://webkit.org/b/72356>

Reviewed by Daniel Bates.

  • Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:

Extracted common package logic into RunLeaks.pm. Fixed call to
RunLeaks::parseLeaksOutput().

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
08:37 Changeset [100286] by commit-queue@webkit.org

Handle svn 1.7 when detecting whether a directory is in an svn checkout.
https://bugs.webkit.org/show_bug.cgi?id=72349

Patch by Peter Kasting <pkasting@google.com> on 2011-11-15
Reviewed by Adam Roben.

  • Scripts/VCSUtils.pm:

(isSVNDirectory):

08:32 Changeset [100285] by commit-queue@webkit.org

Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
https://bugs.webkit.org/show_bug.cgi?id=61528

Patch by Philip Rogers <pdr@google.com> on 2011-11-15
Reviewed by Stephen White.

Source/WebCore:

Tests: fast/canvas/2d.text.draw.fill.maxWidth.gradient.html

fast/canvas/2d.text.draw.fill.maxWidth.negative.html
fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html
fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

  • fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.gradient.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.negative-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.negative.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.veryLarge-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.verySmall-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • platform/qt/Skipped:
  • resources/Ahem.ttf: Added.
08:24 Changeset [100284] by carlosgc@webkit.org

[GTK] Implement download support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72258

Reviewed by Martin Robinson.

Source/WebCore:

Add common download errors to ErrorsGtk.

  • platform/gtk/ErrorsGtk.cpp:

(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):

  • platform/gtk/ErrorsGtk.h:

Source/WebKit/gtk:

Use errors from WebCore to emit the error signals.

  • webkit/webkitdownload.cpp:

(webkitDownloadEmitError): Helper function that emits the error
signal for the given ResourceError.
(webkit_download_open_stream_for_uri): Use webkitDownloadEmitError().
(webkit_download_cancel): Ditto.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Ditto.
(webkit_download_error): Ditto.

Source/WebKit2:

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::downloadFailed):
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::wasBlocked):
(WebKit::DownloadClient::cannotShowURL):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):

08:17 Changeset [100283] by caryclark@google.com

[chromium-mac] Enable vertical text using Skia
https://bugs.webkit.org/show_bug.cgi?id=72137

Source/WebCore:

Use Skia to draw vertical text. This is much
faster and has higher fidelity than the old method
of drawing text on a path.

The graphics context passed to Skia has been
rotated 90 degrees but the character advances
have not, so it is necessary to unrotate the canvas,
and re-rotate the positions.

This generates correct output (or, at least,
consistent with Chromium CG on Mac) for all vertical
text tests, one of which is mentioned below.

Reviewed by Stephen White.

Test: fast/writing-mode/text-orientation-basic.html

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

LayoutTests:

Ignore vertical text tests on Skia on Mac for now.

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
08:14 Changeset [100282] by eric.carlson@apple.com

media-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72381

Reviewed by Tony Gentilcore.

  • media/media-blocked-by-willsendrequest.html:

Don't assume the media events will be dispatched before the window 'load' event.

  • platform/chromium/test_expectations.txt:

Don't skip media/media-blocked-by-willsendrequest.html.

07:59 Changeset [100281] by ossy@webkit.org

[Qt] Enable skipped but now passing tests (http/tests)
https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip 24 tests.
07:38 Changeset [100280] by commit-queue@webkit.org

Fix SVG hit testing when padding is present
https://bugs.webkit.org/show_bug.cgi?id=37325

Patch by Philip Rogers <pdr@google.com> on 2011-11-15
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/svg-padding.xhtml

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

  • svg/hittest/svg-padding-expected.txt: Added.
  • svg/hittest/svg-padding.xhtml: Added.
07:11 Changeset [100279] by philn@webkit.org

Unreviewed, marked
fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK.

  • platform/gtk/test_expectations.txt:
06:58 Changeset [100278] by tonyg@chromium.org

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing.
06:52 Changeset [100277] by pfeldman@chromium.org

Web Inspector: move generic code from DevTools.js into the WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72377

re-landing r100269.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.setInspectedTabId):

06:51 Changeset [100276] by reed@google.com

[skia] mark to rebaseline aft cr104128 lands (colorfilter optimization)
https://bugs.webkit.org/show_bug.cgi?id=72270

Reviewed by NOBODY.

  • platform/chromium/test_expectations.txt:
06:43 Changeset [100275] by tonyg@chromium.org

media-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72381

  • platform/chromium/test_expectations.txt: Mark test as flaky.
06:43 QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
06:40 QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
06:39 QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
06:31 QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
06:30 Changeset [100274] by commit-queue@webkit.org

Unreviewed, rolling out r100269.
http://trac.webkit.org/changeset/100269
https://bugs.webkit.org/show_bug.cgi?id=72383

"Broke dozens of tests due to exception in loadingFinished"
(Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:
  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

():
(devtools.domContentLoaded):
(WebInspector.UIString):
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

06:14 QtWebKitLayoutInteraction created by kenneth@webkit.org
06:12 Changeset [100273] by apavlov@chromium.org

font property does not show up as "shorthand" in inspector
https://bugs.webkit.org/show_bug.cgi?id=15598

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The "font" CSS property is turned into a real shorthand, as its longhands used to float around
in the resulting style declaration without any reference to their underlying "font" property.

Test: fast/css/font-shorthand.html

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the "font" value building into fontValue().
(WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added
(WebCore::CSSMutableStyleDeclaration::fontValue): Build the "font" value from longhands.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::addProperty): Added optional "implicit" parameter.
(WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand "font" property.

  • css/CSSParser.h: Added optional "implicit" parameter to addProperty().
  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap): Added "font" shorthand map entry.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup.
(WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added.

  • css/CSSStyleSelector.h: Made updateFont() public.
  • css/FontValue.cpp:

(WebCore::FontValue::customCssText): Made use of StringBuilder.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont): Apply "font" longhands rather than the (non-existent) "font" property.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for "font" not being a shorthand.

  • page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties): Removed a workaround for "font" not being a shorthand.

LayoutTests:

  • fast/css/font-shorthand-expected.txt: Added.
  • fast/css/font-shorthand.html: Added.
  • fast/inspector-support/style-expected.txt:
  • fast/inspector-support/style.html:
06:06 Changeset [100272] by philn@webkit.org

REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug
https://bugs.webkit.org/show_bug.cgi?id=72297

Unreviewed, GTK rebaseline after r100159.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
05:48 Changeset [100271] by philn@webkit.org

Unreviewed, skipping some new GTK test failures.

  • platform/gtk/Skipped:
05:43 Changeset [100270] by commit-queue@webkit.org

[Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
https://bugs.webkit.org/show_bug.cgi?id=72262

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-15
Reviewed by Antonio Gomes.

No new tests needed, this is purely cosmetic.

  • platform/qt/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):

  • platform/qt/RenderThemeQStyle.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
since the mobile theme actually didn't do this.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustMenuListStyle):

05:38 Changeset [100269] by pfeldman@chromium.org

Web Inspector: move generic code from DevTools.js into the WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72377

This includes support for themed toolbar, remote debugging routines,
removes a couple of obsolete overrides from the DevTools.js

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.setInspectedTabId):

05:02 Changeset [100268] by ossy@webkit.org

REGRESSION(r100182): It broke 2 http/tests/security tests
https://bugs.webkit.org/show_bug.cgi?id=72364

  • platform/qt/Skipped: Skip failing tests until fix.
04:35 Changeset [100267] by tonyg@chromium.org

[chromium] fast/forms/file/input-file-label.html is flaky on win
https://bugs.webkit.org/show_bug.cgi?id=72376

  • platform/chromium/test_expectations.txt: Mark test flaky on win.
04:02 Changeset [100266] by hausmann@webkit.org

[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

  • qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions

magic here where we handle all TEMPLATE = lib .pro files.

03:33 Changeset [100265] by hausmann@webkit.org

[Qt] Unreviewed prospective --minimal build fix.

  • DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0

and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.

03:30 Changeset [100264] by noel.gordon@gmail.com

Rebaseline gray-scale-jpeg-with-color-profile.html
https://bugs.webkit.org/show_bug.cgi?id=72240

Reviewed by Eric Seidel.

  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
03:24 Changeset [100263] by tonyg@chromium.org

[chromium] perf/document-contains.html is flaky on win
https://bugs.webkit.org/show_bug.cgi?id=72372

  • platform/chromium/test_expectations.txt: Marking flaky on WIN.
03:14 Changeset [100262] by commit-queue@webkit.org

Unreviewed, rolling out r100213.
http://trac.webkit.org/changeset/100213
https://bugs.webkit.org/show_bug.cgi?id=72371

"Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
03:03 Changeset [100261] by commit-queue@webkit.org

[EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
https://bugs.webkit.org/show_bug.cgi?id=70091

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-11-15
Reviewed by Filip Pizlo.

Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
with WebKit-EFL functions.

  • ewk/ewk_frame.cpp:

(ewk_frame_contents_set):
(ewk_frame_contents_alternate_set):

03:01 Changeset [100260] by yuqiang.xian@intel.com

Remove DFGJITCompilerInlineMethods
https://bugs.webkit.org/show_bug.cgi?id=72366

Reviewed by Filip Pizlo.

Those methods are actually seldom used. Modify the few such places and
remove DFGJITCompilerInlineMethods stuffs totally.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addressOfDoubleConstant):

  • dfg/DFGJITCompilerInlineMethods.h: Removed.
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFillFPR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):

02:59 Changeset [100259] by ossy@webkit.org

[Qt] Unviewed fix after r100254, because committed results was incorrect.

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.png: Added.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
02:52 Changeset [100258] by hclam@chromium.org

[chromium] scroll deltas are cleared during commit to the main thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

Patch is covered by unit test.

Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
sent to the main thread during commit. This gives a simpler approach to keep tracking of a
layer's scroll delta in impl thread.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::sentScrollDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::sentScrollDelta):
(WebCore::CCLayerImpl::setSentScrollDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Modify test to verify sentScrollDeltas() values of CCLayerImpl during commit.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

02:37 Changeset [100257] by tonyg@chromium.org

media/track/track-webvtt-tc003-newlines.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72369

  • platform/chromium/test_expectations.txt: Marked test flaky.
02:34 Changeset [100256] by hausmann@webkit.org

[Qt] REGRESSION(100123): It made inspector tests crash https://bugs.webkit.org/show_bug.cgi?id=72274

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated

m_page member that should really come from RenderThemeQt.

LayoutTests:

  • platform/qt/Skipped: Unskip passing tests.
01:56 Changeset [100255] by gyuyoung.kim@samsung.com

Unreviewed. Fix build breaks when EFL port is built.

  • CMakeLists.txt:
  • UseJSC.cmake:
01:47 Changeset [100254] by reni@webkit.org

Unviewed gardening after r100159.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-11-15

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
01:37 Changeset [100253] by hausmann@webkit.org

[Qt] Unreviewed --minimal build fix.

  • Scripts/build-webkit: Add to DEFINES+= from @options only if there is

a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
to make moc's preprocessor abort.

01:36 Changeset [100252] by noel.gordon@gmail.com

Make ImageFrame member getAddr() public
https://bugs.webkit.org/show_bug.cgi?id=72321

Reviewed by Adam Barth.

Make ImageFrame member getAddr() public to allow ImageFrame users access to the
underlying frame pixels if needed. Image decoders, for example, could with care
use this service to write decoded pixels direct to the ImageFrame pixel buffer,
avoiding intermeadiate data copies from temporary decoded pixel row buffers and
the decoding performance loss that that entails.

No new tests, refactoring only.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):

01:32 Changeset [100251] by apavlov@chromium.org

Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
https://bugs.webkit.org/show_bug.cgi?id=72261

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/svg-style.xhtml

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

LayoutTests:

  • inspector/styles/svg-style-expected.txt: Added.
  • inspector/styles/svg-style.xhtml: Added.
01:24 Changeset [100250] by reni@webkit.org

[Qt] Platform-specific result for r100157.

Unreviewed, gardening.

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2011-11-15

  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
01:13 Changeset [100249] by reni@webkit.org

[Qt] Two tests are skipped after r100182 and r100239.

Unreviewed gardening.

  • platform/qt/Skipped:
01:05 Changeset [100248] by mario@webkit.org

[GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72267

Reviewed by Martin Robinson.

Allow getting and setting the 'enable-caret-browsing' property
through WebKitSettings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Added property setter.
(webKitSettingsGetProperty): Added propery getter.
(webkit_settings_class_init): Install property.
(webkit_settings_get_enable_caret_browsing): Added.
(webkit_settings_set_enable_caret_browsing): Added.

  • UIProcess/API/gtk/WebKitSettings.h: Expose new public APIs.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new sections for gtk-doc generation.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Added new API test.

00:36 Changeset [100247] by tkent@chromium.org

[V8] Fix incorrect handling of JavaScript properties in DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=53578

Reviewed by Adam Barth.

Source/WebCore:

Follows a JSC behavior change by r96893.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):
Propagate to the JavaScript object if the DOMStringMap object
doesn't have the requested item.
(WebCore::V8DOMStringMap::namedPropertyDeleter): ditto.
(WebCore::V8DOMStringMap::namedPropertySetter):
Try to set a property to only a DOMStringMap object.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Remove failure expectations of fast/dom/dataset.html and
fast/dom/dataset-xhtml.xhtml.

00:08 Changeset [100246] by pfeldman@chromium.org

Web Inspector: Command line $x fails for 3 of 4 types of XPath query
https://bugs.webkit.org/show_bug.cgi?id=72276

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/console/console-xpath.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/console/console-xpath-expected.txt: Added.
  • inspector/console/console-xpath.html: Added.

11/14/11:

23:10 Changeset [100245] by pkasting@chromium.org

r100237 moved some pixel baselines into platform/chromium without also
moving the text baselines. As a result all the Chromium Mac "not 10.6
CG" bots were still failing due to MISSING expectations.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt.
23:04 Changeset [100244] by fpizlo@apple.com

DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined
https://bugs.webkit.org/show_bug.cgi?id=72348

Reviewed by Gavin Barraclough.

Moved all of JITCodeGenerator into SpeculativeJIT.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGJITCodeGenerator.cpp: Removed.
  • dfg/DFGJITCodeGenerator.h: Removed.
  • dfg/DFGJITCodeGenerator32_64.cpp: Removed.
  • dfg/DFGJITCodeGenerator64.cpp: Removed.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::clearGenerationInfo):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownBoolean):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::markCellCard):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::dataFormatString):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::GPRTemporary::adopt):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::lock):
(JSC::DFG::SpeculativeJIT::unlock):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::reuse):
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::tryAllocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
(JSC::DFG::SpeculativeJIT::silentSpillGPR):
(JSC::DFG::SpeculativeJIT::silentSpillFPR):
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::silentFillFPR):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::unboxDouble):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::identifier):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImmPtr):
(JSC::DFG::SpeculativeJIT::bitOp):
(JSC::DFG::SpeculativeJIT::shiftOp):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::addressOfCallData):
(JSC::DFG::SpeculativeJIT::tagOfCallData):
(JSC::DFG::SpeculativeJIT::payloadOfCallData):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument):
(JSC::DFG::SpeculativeJIT::setupArguments):
(JSC::DFG::SpeculativeJIT::setupArgumentsExecState):
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::setupTwoStubArgs):
(JSC::DFG::SpeculativeJIT::setupStubArguments):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::setupResults):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::block):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::~IntegerOperand):
(JSC::DFG::IntegerOperand::index):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::~DoubleOperand):
(JSC::DFG::DoubleOperand::index):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::~JSValueOperand):
(JSC::DFG::JSValueOperand::index):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::jsValueRegs):
(JSC::DFG::JSValueOperand::isDouble):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::tagGPR):
(JSC::DFG::JSValueOperand::payloadGPR):
(JSC::DFG::JSValueOperand::fpr):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::GPRTemporary::~GPRTemporary):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::~FPRTemporary):
(JSC::DFG::FPRTemporary::fpr):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::GPRResult::GPRResult):
(JSC::DFG::GPRResult2::GPRResult2):
(JSC::DFG::FPRResult::FPRResult):
(JSC::DFG::FPRResult::lockedResult):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • runtime/JSFunction.h:
23:01 Changeset [100243] by rniwa@webkit.org

Fix the change log entry for r59190.

  • ChangeLog-2010-05-24:
22:58 Changeset [100242] by fpizlo@apple.com

Weak reference harvesters should run to fixpoint
https://bugs.webkit.org/show_bug.cgi?id=72346

Reviewed by Oliver Hunt.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/ListableHandler.h:

(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::isEmpty):

22:43 Changeset [100241] by dbates@webkit.org

build-webkit: Accept --cmakearg to pass additional arguments to CMake.
https://bugs.webkit.org/show_bug.cgi?id=72156

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-14
Reviewed by Daniel Bates.

Similar to --makearg and --qmakearg, --cmakearg lets one pass
additional arguments to CMake (eg. --cmakearg="-DFOO=bar").

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

22:29 Changeset [100240] by pkasting@chromium.org

r100196 needed to also rebaseline Windows, not just Linux.

Unreviewed, gardening.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.png:
22:14 Changeset [100239] by dslomov@google.com

Source/WebCore: [V8][Chromium]Serialize dense arrays densly
https://bugs.webkit.org/show_bug.cgi?id=72198
This patch ensures that:

  • Dense arrays are serialized densly, and not as name-value pairs
  • Sparse arrays are allocated as sparse on deserialization.

The criteria to choose whether to serialize densly or sparsely is the size
of a resulting serialized stream.

Reviewed by David Levin.

Test: fast/dom/Window/window-postmessage-arrays.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeDenseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
(WebCore::V8ObjectMap::Serializer::writeDenseArray):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
(WebCore::V8ObjectMap::Serializer::ObjectState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::serializeDensely):
(WebCore::V8ObjectMap::Serializer::startArrayState):
(WebCore::V8ObjectMap::Serializer::startObjectState):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::newSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeDenseArray):

LayoutTests: [V8][Chromium]Serialize dense arrays densly.
https://bugs.webkit.org/show_bug.cgi?id=72198

Reviewed by David Levin.

  • fast/dom/Window/script-tests/postmessage-clone.js:
  • fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
  • fast/dom/Window/window-postmessage-arrays.html: Added.
22:07 Changeset [100238] by pkasting@chromium.org

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Removed.
  • platform/chromium/fast/table/prepend-in-anonymous-table-expected.txt: Added.
21:39 Changeset [100237] by pkasting@chromium.org

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
20:27 Changeset [100236] by pkasting@chromium.org

Rebaseline svg/foreignObject/multiple-foreign-objects.html on Snow
Leopard and earlier.

Unreviewed, gardening.

  • platform/mac-snowleopard/svg/foreignObject: Added.
  • platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
20:08 Changeset [100235] by commit-queue@webkit.org

[chromium] Fix scaleDelta zoom-out visibility rect bug
https://bugs.webkit.org/show_bug.cgi?id=72208

Since the scroll is no longer applied at the top layer of the layer
tree, the scaleDelta transformation needs to be moved down to the
same level.

Also fix zoomAnimator to be applied the same way. I removed zoom
animator layout tests, as they aren't testing the actual impl-side
codepath, and are hard to continue supporting -- we should cover zoom
features with unit tests in the future.

Patch by Alexandre Elias <aelias@google.com> on 2011-11-14
Reviewed by James Robinson.

No new tests (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scaleDelta):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setScaleDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scaleDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

19:14 Changeset [100234] by jchaffraix@webkit.org

[chromium] Fix the build after moving some arrays to WTF
https://bugs.webkit.org/show_bug.cgi?id=72345

Reviewed by Dirk Pranke.

  • public/WebArrayBufferView.h: s/WebCore/WTF/g.
19:08 Changeset [100233] by rniwa@webkit.org

Improve ChangeLogEntry's reviewer parsing algorithm part 2
https://bugs.webkit.org/show_bug.cgi?id=72340

Reviewed by Eric Seidel.

This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
18:46 Changeset [100232] by cfleizach@apple.com

WebProcess crashes when trying to display your "uploaded videos" page on Facebook
https://bugs.webkit.org/show_bug.cgi?id=72334

Reviewed by Beth Dakin.

Protect against documents without frames.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):

18:33 Changeset [100231] by eric@webkit.org

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

The TestExpectationsChecker was using a generic try/except block
which caught all exceptions, so we didn't notice that failing
to pass a Host to PortFactory was causing an exception in port instantiation.
I've factored out the "lookup the port" logic into a separate function
which I've now unittested. This should fix the bug and prevent
others like it from occuring the the future.

  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
18:18 Changeset [100230] by oliver@apple.com

More V8 build fixes.

18:06 Changeset [100229] by oliver@apple.com

Fix V8 build again.

17:58 Changeset [100228] by oliver@apple.com

Fix V8 build

17:52 Changeset [100227] by oliver@apple.com

Start migrating typed array impl types to WTF
https://bugs.webkit.org/show_bug.cgi?id=72336

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add typed array impls to WTF forwarding header.

  • wtf/Forward.h:

Source/WebCore:

Move typed arrays from WebCore namespace to WTF, and
start reducing dependencies on WebCore types.

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayHelper):

  • bindings/scripts/CodeGeneratorJS.pm:

(IsTypedArrayType):
(AddClassForwardIfNeeded):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(IsTypedArrayType):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Added.

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.h: Added.

(WebDOMFloat64Array::~WebDOMFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp: Added.

(WebKit::kit):
(WebKit::core):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_set_property):
(webkit_dom_float64array_get_property):
(webkit_dom_float64array_constructed):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
(WebKit::wrapFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h: Added.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Added.

(WebCore::JSFloat64ArrayConstructor::JSFloat64ArrayConstructor):
(WebCore::JSFloat64ArrayConstructor::finishCreation):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::getJSFloat64ArrayPrototypeTable):
(WebCore::JSFloat64ArrayPrototype::self):
(WebCore::getJSFloat64ArrayTable):
(WebCore::JSFloat64Array::JSFloat64Array):
(WebCore::JSFloat64Array::finishCreation):
(WebCore::JSFloat64Array::createPrototype):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::put):
(WebCore::JSFloat64Array::putByIndex):
(WebCore::JSFloat64Array::getOwnPropertyNames):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::JSFloat64Array::getByIndex):
(WebCore::toFloat64Array):
(WTF::Float64Array::neuterBinding):

  • bindings/scripts/test/JS/JSFloat64Array.h: Added.

(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64Array::createStructure):
(WebCore::JSFloat64Array::impl):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayPrototype::createStructure):
(WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
(WebCore::JSFloat64ArrayConstructor::create):
(WebCore::JSFloat64ArrayConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMFloat64Array.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm: Copied from Source/WebCore/html/canvas/Float32Array.cpp.

(core):
(kit):

  • bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/TestTypedArray.idl: Copied from Source/WebCore/html/canvas/Float64Array.cpp.
  • bindings/scripts/test/V8/V8Float64Array.cpp: Added.

(WebCore::Float64ArrayInternal::V8_USE):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore::V8Float64Array::wrapSlow):
(WTF::Float64Array::neuterBinding):
(WebCore::V8Float64Array::derefObject):

  • bindings/scripts/test/V8/V8Float64Array.h: Added.

(WebCore::V8Float64Array::toNative):
(WebCore::V8Float64Array::existingWrapper):
(WebCore::V8Float64Array::wrap):
(WebCore::toV8):

  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.h:
  • fileapi/WebKitBlobBuilder.h:
  • html/HTMLMediaElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.h:

(WTF::Float32Array::set):

  • html/canvas/Float64Array.cpp:
  • html/canvas/Float64Array.h:

(WTF::Float64Array::set):

  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.h:

(WTF::Int16Array::set):

  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.h:

(WTF::Int32Array::set):

  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.h:

(WTF::Int8Array::set):

  • html/canvas/IntegralTypedArrayBase.h:
  • html/canvas/TypedArrayBase.h:

(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):

  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.h:

(WTF::Uint16Array::set):

  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.h:

(WTF::Uint32Array::set):

  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.h:

(WTF::Uint8Array::set):

  • html/canvas/WebGLBuffer.h:
  • page/Crypto.h:
  • webaudio/AsyncAudioDecoder.h:
  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::zero):

  • webaudio/AudioContext.h:
  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperNode.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • xml/XMLHttpRequest.h:
17:48 Changeset [100226] by jchaffraix@webkit.org

Add --css-grid-layout to build-webkit and the build systems
https://bugs.webkit.org/show_bug.cgi?id=72320

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

Added the option.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
17:43 Changeset [100225] by commit-queue@webkit.org

Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
https://bugs.webkit.org/show_bug.cgi?id=72335

Patch by Daniel Bates <dbates@rim.com> on 2011-11-14
Reviewed by Eric Seidel.

It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.

  • rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
  • rendering/svg/RenderSVGContainer.cpp: Ditto.
  • rendering/svg/RenderSVGForeignObject.cpp: Ditto.
  • rendering/svg/RenderSVGImage.cpp: Ditto.
  • rendering/svg/RenderSVGInline.cpp: Ditto.
  • rendering/svg/RenderSVGModelObject.cpp: Ditto.
  • rendering/svg/RenderSVGPath.cpp: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto.
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
  • rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
  • rendering/svg/RenderSVGRoot.cpp: Ditto.
  • rendering/svg/RenderSVGText.cpp: Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Ditto.
  • rendering/svg/SVGRenderSupport.cpp: Ditto.
  • svg/SVGDocumentExtensions.cpp: Ditto.
  • svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
17:39 Changeset [100224] by ggaren@apple.com

A little bit of arguments / activation cleanup
https://bugs.webkit.org/show_bug.cgi?id=72339

Reviewed by Gavin Barraclough.

Renamed copyRegisters => tearOff to match bytecode and other terminology.

Renamed setActivation => didTearOffActivation to indicate that this is a
notification the object may choose to ignore. Moved "Should I ignore?"
code into the arguments object to avoid duplication elsewhere.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::createAndTearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::finishCreationButDontTearOff):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndTearOff):
(JSC::Arguments::tearOff):

  • runtime/JSActivation.h:

(JSC::JSActivation::tearOff): Moved Activation's code into its own header
because that's where it belongs.

17:32 Changeset [100223] by barraclough@apple.com

Should sign the jsc binary
https://bugs.webkit.org/show_bug.cgi?id=72332

Reviewed by David Kilzer.

  • Configurations/JSC.xcconfig:
  • entitlements.plist: Added.
17:23 Changeset [100222] by commit-queue@webkit.org

[MutationObservers] Add histogram collection for usage of DOM Mutation Events
https://bugs.webkit.org/show_bug.cgi?id=72316

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-14
Reviewed by Ryosuke Niwa.

This patch adds six calls in ~Document() which simply pipe-out to the embedder
the (already-collected) bits of whether varous DOM Mutation Events were registered
on the document.

No tests needed. No functional changes.

  • dom/Document.cpp:

(WebCore::histogramMutationEventUsage):
(WebCore::Document::~Document):

17:22 Changeset [100221] by fpizlo@apple.com

DFG's inline references to objects should be tracked
https://bugs.webkit.org/show_bug.cgi?id=72313

Reviewed by Gavin Barraclough.

Added a pinCell() method in the parser that currently creates a
dummy constant in CodeBlock. Added calls to pinCell() wherever the
DFG would inline a constant reference that the original code would
not have referred to.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getCellConstantIndex):
(JSC::DFG::ByteCodeParser::pinCell):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

17:13 Changeset [100220] by noel.gordon@gmail.com

Test JPEG image decoding RGB pixel endianess
https://bugs.webkit.org/show_bug.cgi?id=72234

Reviewed by Kent Tamura.

JPEG image RGB pixels should render without color corruption and in strict
order, regardless of the underlying machine pixel buffer endianess.

  • fast/images/resources/rgb-jpeg-blue.jpg: Added.
  • fast/images/resources/rgb-jpeg-green.jpg: Added.
  • fast/images/resources/rgb-jpeg-red.jpg: Added.
  • fast/images/rgb-jpeg-endian-pixels-expected.txt: Added.
  • fast/images/rgb-jpeg-endian-pixels.html: Added.
17:04 Changeset [100219] by fpizlo@apple.com

DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

16:57 Changeset [100218] by gavinp@chromium.org

MERGE 71122 and 72068 simultaniously.

71122:

properly end requests when a bad status code return happens

https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.

There is a chromium test going through code review at http://codereview.chromium.org/8404001/

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

72068:

Protect Document during error responses

https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

16:51 Changeset [100217] by commit-queue@webkit.org

Expose compositeAndReadback in WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=72188

Patch by Ian Vollick <vollick@chromium.org> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebLayerTreeView.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::compositeAndReadback):

16:47 Changeset [100216] by commit-queue@webkit.org

Unreviewed, rolling out r100192.
http://trac.webkit.org/changeset/100192
https://bugs.webkit.org/show_bug.cgi?id=72328

Caused infinite tests to fail (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
16:39 Changeset [100215] by eae@chromium.org

Remove FixedRect stream operator and move FloatRect version back to svg/

16:34 Changeset [100214] by simon.fraser@apple.com

div with webkit-transform + webkit-box-reflect disappears when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=53355

Reviewed by Dean Jackson.

Tickle Core Animation into updating the layer's content property when
switching back to a tab which has composited reflections. This hack is
needed becuase reflections involve sharing layer contents between layers.

  • platform/graphics/mac/WebLayer.mm:

(-[WebLayer actionForKey:]):

16:24 Changeset [100213] by abarth@webkit.org

Unique origins shouldn't remember their scheme, host, or port
https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.
  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

  • Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
    • Update test results to show that we no longer leak the scheme in storage identifiers.
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
    • Inline script because the sandbox iframe isn't allowed to load local resources.
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
    • Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.
16:21 Changeset [100212] by mrowe@apple.com

Upgrade WordPress's Akismet plug-in to the latest version.

  • blog/wp-content/plugins/akismet:
16:20 Changeset [100211] by jchaffraix@webkit.org

Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
https://bugs.webkit.org/show_bug.cgi?id=72318

Reviewed by Tony Chang.

Test that covers the change for bug 72296 and also increase our flexbox coverage.

  • css3/flexbox/display-flexbox-set-get-expected.txt: Added.
  • css3/flexbox/display-flexbox-set-get.html: Added.
  • css3/flexbox/resources/display-flexbox-set-get.js: Added.
16:18 Changeset [100210] by commit-queue@webkit.org

Add buffering to handle mismatch between hardware buffer size and webaudio render size
https://bugs.webkit.org/show_bug.cgi?id=71949

Patch by Raymond Toy <rtoy@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Create the FIFO for buffering.
(WebCore::AudioDestinationChromium::render): Get rid of
m_renderCountPerCallback and let the FIFO consume function produce
the appropriate nubmer of calls to the webaudio producer. Also
remove the rounding of the callback size so we use whatever the
hardware returns. Removed maximumCallbackBufferSize and use
fifoSize to set the FIFO size.
(WebCore::AudioDestinationChromium::FIFO::FIFO):
(WebCore::AudioDestinationChromium::FIFO::consume):
(WebCore::AudioDestinationChromium::FIFO::findWrapLengths):
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
Implementation of new FIFO class.

  • src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::FIFO::updateIndex):
Define new FIFO class.

16:16 Changeset [100209] by mrowe@apple.com

Update one file that was missed.

  • blog/wp-settings.php:
16:16 Changeset [100208] by msaboff@apple.com

Further changes and cleanup to JSString.h and cpp.

Reviewed by Darin Adler.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr. Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.

  • runtime/JSString.h:
16:12 Changeset [100207] by mrowe@apple.com

Upgrade WordPress to v3.2.1.

  • blog:
16:05 Changeset [100206] by leviw@chromium.org

Correcting usage of intMaxForLength in AutoTableLayout.

16:04 Changeset [100205] by abarth@webkit.org

DateMath.cpp should not depend on JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71747

Reviewed by Darin Adler.

This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore. There shouldn't be any behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • runtime/DateConstructor.cpp:
  • runtime/DateConversion.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DateInstanceCache.h:
  • runtime/DatePrototype.cpp:
  • runtime/InitializeThreading.cpp:
  • runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.

(JSC::timeToMS):
(JSC::msToSeconds):

  • runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
  • wtf/DateMath.cpp:

(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):

  • wtf/DateMath.h:
16:01 Changeset [100204] by commit-queue@webkit.org

[EFL] Update ewk_frame_script_execute to return the result for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=65972

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-14
Reviewed by Antonio Gomes.

It executes the javascript and converts the result to a string using toString.
And it returns the memory-allocated pointer for the value.

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

  • ewk/ewk_frame.h:
16:00 Changeset [100203] by abarth@webkit.org

Source/WebCore: Don't special-case "data" URLs in drag-and-drop logic
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

See the bug for more details.

Test: editing/pasteboard/drag-drop-to-data-url.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canReceiveDragData):

LayoutTests: Cross-origin drag-and-drop prevention ineffective
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

Split drag-drop-dead-frame.html into two tests: one that tests for the
previous crash and one that tests out data URL drag-and-drop behavior.

  • editing/pasteboard/drag-drop-dead-frame.html:
  • editing/pasteboard/drag-drop-to-data-url-expected.txt: Added.
  • editing/pasteboard/drag-drop-to-data-url.html: Added.
15:51 Changeset [100202] by msaboff@apple.com

Towards 8 bit strings - Add 8 bit handling to JSString Ropes
https://bugs.webkit.org/show_bug.cgi?id=72317

Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.

Reviewed by Oliver Hunt.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):

15:33 Changeset [100201] by eae@chromium.org

Round width and height when computing the scroll size (as opposed to flooring).

15:16 Changeset [100200] by ggaren@apple.com

A little bit of function call cleanup
https://bugs.webkit.org/show_bug.cgi?id=72314

Reviewed by Oliver Hunt.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.

(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.

(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.

(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.

  • bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because

16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.

15:10 Changeset [100199] by enne@google.com

[chromium] Pipe compositor commit/swap up to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=72041

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didCommitAndDrawCompositorFrame):
(WebKit::WebWidgetClient::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitAndDrawFrame):
(WebKit::WebViewImpl::didCompleteSwapBuffers):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::didCommitAndDrawFrame):
(WTF::MockLayerTreeHostClient::didCompleteSwapBuffers):

14:51 Changeset [100198] by tony@chromium.org

Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSFlexValue.cpp:
  • css/CSSFlexValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:
  • rendering/style/StyleFlexibleBoxData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:47 Changeset [100197] by mrowe@apple.com

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
14:47 Changeset [100196] by fsamuel@chromium.org

[Chromium] setPageScaleFactor and associated methods should take scaling limits into account
https://bugs.webkit.org/show_bug.cgi?id=72176

Source/WebKit/chromium:

Reviewed by Darin Fisher.

A couple of changes:

  1. setPageScaleFactorLimits now affects the behavior of other scaling methods including setPageScaleFactor.
  2. setPageScaleFactorPreservingScrollOffset introduced that scales the scroll offset along with the page, preserving the scroll position within the page bounds.
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::computePageScaleFactorWithinLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

LayoutTests:

Reviewed by Darin Fisher.

Rebaselined some tests that broke because we now clamp pageScaleFactor to 0.25 (these test at 0.2).

Since this is a Chromium only change, the new baselines are only for Chromium.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png:
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png.
  • platform/chromium/fast/repaint/background-scaling-expected.txt: Added.
14:42 Changeset [100195] by msaboff@apple.com

Towards 8 bit strings - Add 8 bit paths to StringImpl methods
https://bugs.webkit.org/show_bug.cgi?id=72290

Added 8 bit patchs to StringImpl to number and find methods.

Reviewed by Oliver Hunt.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

  • wtf/text/WTFString.cpp:

(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):

  • wtf/text/WTFString.h:

(WTF::find):
(WTF::reverseFind):

14:39 Changeset [100194] by scheib@chromium.org

Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPointerLockEnabled):

  • src/WebSettingsImpl.h:
14:32 Changeset [100193] by robert@webkit.org

Platform-specific results for r100177

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Copied from LayoutTests/platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/multiple-captions-display-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-win/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/gtk/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/gtk/fast/table/multiple-captions-display-expected.txt:
  • platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/qt/fast/table/multiple-captions-display-expected.txt:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
14:29 Changeset [100192] by commit-queue@webkit.org

new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/base.py:
14:25 Changeset [100191] by commit-queue@webkit.org

Unreviewed, rolling out r100176.
http://trac.webkit.org/changeset/100176
https://bugs.webkit.org/show_bug.cgi?id=72309

it broke the Mac builds (missing symbols) in a non-obvious way
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:
14:22 Changeset [100190] by commit-queue@webkit.org

Intermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
https://bugs.webkit.org/show_bug.cgi?id=72299

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-14
Reviewed by Noam Rosenthal.

Added check that clipping rect is valid.
Clear GL error that might remain from QT GL operations.
Added GL error assert for scissor test operations.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):

14:19 Changeset [100189] by leviw@chromium.org

Reverting lengths to being stored as pixel values for the specified zoom level and adopting an enclosingIntRect model for reporting sizes in RenderTreeAsText. This vastly lowers the number of failing layout tests on our branch.

13:56 Changeset [100188] by eae@chromium.org

Merging trunk changes up until 100042 into subpixel branch.

13:55 Changeset [100187] by tony@chromium.org

remove -wap-marquee css propery value
https://bugs.webkit.org/show_bug.cgi?id=72296

Reviewed by Adam Barth.

This css value is no longer used.

  • css/CSSValueKeywords.in:
13:49 Changeset [100186] by arv@chromium.org

JS Test Harness: Remove one more reference to non existing js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=72307

Reviewed by Ojan Vafai.

  • storage/indexeddb/mozilla/delete-result.html:
13:48 Changeset [100185] by andersca@apple.com

Only send progress notifications for the main frame
https://bugs.webkit.org/show_bug.cgi?id=72302

Reviewed by Sam Weinig.

Since it's impossible in the API to tell which frame the progress notifications are for, just send them to the main frame for now.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

13:45 Changeset [100184] by jchaffraix@webkit.org

[Chromium] build-webkit silently drops the features flags
https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

  • Scripts/build-webkit: Check if one of the features is different

from the default and print a warning in this case.

13:21 Changeset [100183] by jchaffraix@webkit.org

Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

  • fast/table/crash-splitColumn-2-expected.txt: Added.
  • fast/table/crash-splitColumn-2.html: Added.
  • fast/table/crash-splitColumn-3-expected.txt: Added.
  • fast/table/crash-splitColumn-3.html: Added.
  • fast/table/crash-splitColumn-expected.txt: Added.
  • fast/table/crash-splitColumn.html: Added.
12:58 Changeset [100182] by abarth@webkit.org

Remove the concept of an empty SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72287

Reviewed by Eric Seidel.

Source/WebCore:

This concept is fragile and doesn't exist in the specs. Previous
patches have removed most of the code relying upon this function. This
patch removes a couple stragglers.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

  • This check should really be about unique origins because it doesn't make sense to target postMessages at unique origins, as explained in the comment.
  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:

Source/WebKit/chromium:

I'll rename the API in a subsequent patch.

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isEmpty):

12:56 Changeset [100181] by abarth@webkit.org

SecurityContext::isSecureTransitionTo should not refer to empty security origins
https://bugs.webkit.org/show_bug.cgi?id=72277

Reviewed by Eric Seidel.

Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

12:50 Changeset [100180] by scheib@chromium.org

Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
  • page/MouseLockable.cpp:
  • page/MouseLockable.h:
  • page/MouseLockable.idl:
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMouseLockEnabled):

12:48 Changeset [100179] by jer.noble@apple.com

Unreviewed; skipping newly failing tests which need rebaselining.

Added skipped tests; tracked by https://bugs.webkit.org/show_bug.cgi?id=72297.

  • platform/gtk/Skipped:
12:46 Changeset [100178] by annacc@chromium.org

Remove TextTrackCueIndex and TextTrackCueSet. No longer needed.
https://bugs.webkit.org/show_bug.cgi?id=72216

Reviewed by Sam Weinig.

No new tests. No new functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCueIndex.cpp: Removed.
  • html/TextTrackCueIndex.h: Removed.
12:41 Changeset [100177] by robert@webkit.org

CSS 2.1 failure: border-spacing-applies-to-015.htm
https://bugs.webkit.org/show_bug.cgi?id=69773

Reviewed by David Hyatt.

Source/WebCore:

The CSS test suite expects UAs to allow multiple captions per table.
Replace m_caption with a Vector called m_captions.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
(WebCore::RenderTable::adjustLogicalHeightForCaption):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::subtractCaptionRect):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::nextColElement):
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::recalcCaption):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTable.h:

LayoutTests:

  • css2.1/20110323/border-spacing-applies-to-015.htm: Added. Now passes!
  • css2.1/20110323/table-caption-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-002.htm: Added. Now passes!
  • css2.1/20110323/table-caption-horizontal-alignment-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-margins-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-002.htm: Added. Passed anyway.
  • fast/table/dynamic-caption-add-before-child.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • fast/table/multiple-captions-crash-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-crash2-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-display.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Result reflects extra captions.
  • platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Result reflects extra captions.
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png: Result reflects extra caption.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt: Result reflects extra caption.
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt: Result reflects extra caption.
12:24 Changeset [100176] by commit-queue@webkit.org

Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <gman@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.

(WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::getName):
(WebCore::WebGLExperimentalCompressedTextures::create):
(WebCore::WebGLExperimentalCompressedTextures::supported):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):

  • html/canvas/WebGLExperimentalCompressedTextures.h: Added.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

12:23 Changeset [100175] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=72280

Rubber stamped by Geoff Garen.

Fix 32-bit Lion.

(WTF::OSAllocator::reserveAndCommit):

12:08 Changeset [100174] by ddkilzer@apple.com

run-leaks does not work on Lion?
<http://webkit.org/b/71059>
<rdar://problem/10428527>

Reviewed by Adam Roben.

The output of leaks(1) changed again in Lion to move the
"leaks Report Version: 2.0" line from the first line of the
output to just above the "Process " lines that run-leaks is
interested in parsing. This required using a more generic
algorithm to find the start of the "Process " lines.

  • Scripts/run-leaks:

(parseLeaksOutput): Make the code to skip headers more generic.

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
12:04 Changeset [100173] by commit-queue@webkit.org

[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=72116

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamSource.h:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):

  • src/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::operator=):

11:46 Changeset [100172] by michaeln@google.com

Source/WebCore: Return more complete error and exception messages when a
WebSQLDatabase function fails. Produce console logging
for openDatabase() errors and vacuum errors. Add a lastErrorMessage
accessor to the DatabaseSync interface.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

Yes, see LayoutTests/ChangeLog in this patch.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastError):
(WebCore::SQLiteDatabase::lastErrorMsg):
(WebCore::SQLiteDatabase:: runVacuumCommand):
(WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
Reflect errors in the open() method in lastError() and lastErrorMsg().
Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().

  • platform/sql/SQLiteDatabase.h:
  • storage/AbstractDatabase.cpp:

(WebCore::formatErrorMessage):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::logErrorMessage):
During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
and the sqlite error message. Add a helper to log message to the console.

  • storage/AbstractDatabase.h:
  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:

(WebCore::DatabaseSync::lastErrorMessage):
(WebCore::DatabaseSync::setLastErrorMessage):

  • storage/DatabaseSync.idl:

Add a lastErrorMessage attribute so javascript callers can
retrieve more detailed information about what went wrong.

  • storage/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
Return an errorMessage in addition to the exception code.

  • storage/SQLError.h:

(WebCore::SQLError::create):
Add helpers to produced formatted error messages.

  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatementSync.cpp:

(WebCore::SQLStatementSync::execute):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):

LayoutTests: Update layout tests for new websql error messages and console logging.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync.html:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt:
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt:
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
  • fast/workers/storage/test-authorizer-expected.txt:
  • fast/workers/storage/transaction-in-transaction-sync.html:
  • fast/workers/storage/transaction-in-transaction-sync-expected.txt:
  • storage/change-version-handle-reuse-expected.txt:
  • storage/open-database-creation-callback-expected.txt:
  • storage/open-database-set-empty-version-expected.txt:
  • storage/private-browsing-noread-nowrite-expected.txt:
  • storage/test-authorizer-expected.txt:
11:44 Changeset [100171] by ggaren@apple.com

32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.

For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.

  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

11:39 Changeset [100170] by abarth@webkit.org

Fix typo.

11:33 Changeset [100169] by abarth@webkit.org

SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72283

Reviewed by Sam Weinig.

This change aligns our implementation more closely with the spec. I
don't think this change has an observable effects, but it moves us
closer to removing the concept of an empty security origin.

  • dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):
(WebCore::Document::initSecurityContext):

11:26 Changeset [100168] by msaboff@apple.com

Remove unused m_data member from UStringSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=72289

Removed unused m_data member from UStringSourceProvider.

Reviewed by Oliver Hunt.

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::UStringSourceProvider):

11:25 Changeset [100167] by msaboff@apple.com

Towards 8 Bit Strings: Templatize YARR Parser
https://bugs.webkit.org/show_bug.cgi?id=72288

Changed Yarr::Parser to be a template based on character type.

Reviewed by Oliver Hunt.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

11:23 Changeset [100166] by ggaren@apple.com

32-bit build fix: Removed unused declaration.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

11:21 Changeset [100165] by ggaren@apple.com

Standardized the JS calling convention
https://bugs.webkit.org/show_bug.cgi?id=72221

Reviewed by Oliver Hunt.

This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.

This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):

(1) 1% benchmark speedup across the board.

(2) 50% code size reduction in baseline JIT function calls.

(3) 1.5x speedup for single-dispatch .apply forwarding.

(4) 1.1x speedup for multi-dispatch .apply forwarding.

This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.

(JSC::CallLinkInfo::unlink):

  • bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows

us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.
  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.

Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.

  • dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before

doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.

  • interpreter/Interpreter.cpp: Let the true code bomb begin!

(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.

(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.

(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.

(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)

op_call_eval: Updated for new, standard eval calling convention.

op_load_varargs: Merged op_load_varargs into op_call_varargs.

op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.

  • interpreter/Interpreter.h:

(JSC::Interpreter::execute): Headers are fun and educational!

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.

(JSC::JIT::linkFor): Link even if we miss on argument count, as above.

  • jit/JIT.h:
  • jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)

(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.

This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.

Added a shared path for calling out to CTI helper functions for non-JS
calls.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)

(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.

  • runtime/Arguments.h:

(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)

11:14 Changeset [100164] by arv@chromium.org

Remove getParameter from HTMLAnchorElement and Location
https://bugs.webkit.org/show_bug.cgi?id=71966

Reviewed by Adam Barth.

Source/WebCore:

  • html/HTMLAnchorElement.cpp: Removed getParameter.
  • html/HTMLAnchorElement.h: Ditto.
  • html/HTMLAnchorElement.idl: Ditto.
  • page/Location.cpp: Ditto.
  • page/Location.h: Ditto.
  • page/Location.idl: Ditto.

LayoutTests:

  • fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
  • fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/anchor-getParameter-expected.txt: Removed.
  • fast/dom/anchor-getParameter.html: Removed.
  • http/tests/misc/location-getParameter-expected.txt: Removed.
  • http/tests/misc/location-getParameter.html: Removed.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
11:11 Changeset [100163] by arv@chromium.org

Remove RequiresAllArguments
https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Remove RequiresAllArguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
  • page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
  • websockets/WebSocket.idl: Comment changes only.

LayoutTests:

  • fast/dom/Window/window-resize-and-move-arguments-expected.txt:
  • fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
  • fast/dom/Window/window-scroll-arguments-expected.txt:
  • fast/dom/Window/window-scroll-arguments.html: Ditto.
  • fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
  • fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.
10:06 Changeset [100162] by commit-queue@webkit.org

[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=72114

Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler
to PeerConnectionHandlerInternal.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Adam Barth.

  • bridge/PeerConnectionHandlerInternal.cpp:

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

  • public/WebKitPlatformSupport.h:
09:59 Changeset [100161] by lforschler@apple.com

New tag.

09:56 Changeset [100160] by commit-queue@webkit.org

Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
https://bugs.webkit.org/show_bug.cgi?id=72088

Patch by Lei Zhang <thestig@chromium.org> on 2011-11-14
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
09:55 Changeset [100159] by jer.noble@apple.com

Implement MediaController.
https://bugs.webkit.org/show_bug.cgi?id=71408

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.

  • wtf/Platform.h:

Source/WebCore:

Tests: media/media-controller-playback.html

media/media-controller.html

Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
HTMLMediaElement attributes.

MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
either be created by a page script and assigned to a HTMLMediaElement using the controller property,
or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned
automatically.

Add an abstract interface implemented by both MediaController and HTMLMediaElement.

  • html/MediaControllerInterface.h: Added.

(WebCore::MediaControllerInterface::~MediaControllerInterface):

Add the MediaController object and IDL.

  • html/MediaController.cpp: Added.

(mediaGroupToMediaControllerMap):
(MediaController::mediaControllerForMediaGroup):
(MediaController::create):
(MediaController::MediaController):
(MediaController::~MediaController):
(MediaController::addMediaElement):
(MediaController::removeMediaElement):
(MediaController::containsMediaElement):
(MediaController::buffered):
(MediaController::seekable):
(MediaController::played):
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::pause):
(MediaController::setDefaultPlaybackRate):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(MediaController::reportControllerState):
(MediaController::updateReadyState):
(MediaController::updatePlaybackState):
(MediaController::updateMediaElements):
(MediaController::scheduleEvent):
(MediaController::asyncEventTimerFired):
(MediaController::scriptExecutionContext):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasSource):
(MediaController::returnToRealtime):
(MediaController::isBlocked):
(MediaController::hasEnded):

  • html/MediaController.h: Added.

(WebCore::MediaController::mediaGroup):
(WebCore::MediaController::paused):
(WebCore::MediaController::defaultPlaybackRate):
(WebCore::MediaController::playbackRate):
(WebCore::MediaController::volume):
(WebCore::MediaController::muted):
(WebCore::MediaController::readyState):
(WebCore::MediaController::playbackState):
(WebCore::MediaController::supportsFullscreen):
(WebCore::MediaController::isFullscreen):
(WebCore::MediaController::enterFullscreen):
(WebCore::MediaController::closedCaptionsVisible):
(WebCore::MediaController::refEventTarget):
(WebCore::MediaController::derefEventTarget):
(WebCore::MediaController::toMediaController):
(WebCore::MediaController::eventTargetData):
(WebCore::MediaController::ensureEventTargetData):

  • html/MediaController.idl: Added.

Add convenience functions to TimeRanges which can calculate intersections and
unions between TimeRanges objects.

  • html/TimeRanges.cpp:

(TimeRanges::copy):
(TimeRanges::invert):
(TimeRanges::intersectWith):
(TimeRanges::unionWith):

  • html/TimeRanges.h:

Add MediaControllerConstructor to the Window object.

  • page/DOMWindow.idl:

Add the two new attribute names, mediagroup and controller.

  • html/HTMLAttributeNames.in:

Add support for the new attributes, and add overridden behavior when a media element
has a current media controller:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setCurrentTime):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::potentiallyPlaying):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::mediaGroup):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::controller):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::updateMediaController):
(WebCore::HTMLMediaElement::isBlockedOnMediaController):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hasSource):
(WebCore::HTMLMediaElement::isLiveStream):

  • html/HTMLMediaElement.idl:
  • bindings/js/JSHTMLMediaElementCustom.cpp: Added.

(WebCore::JSHTMLMediaElement::setMediaController):

Add convenience functions to store a mapping of media-elements-per-document to allow
a quick lookup of media elements with the same media group within a given document:

  • html/HTMLMediaElement.cpp:

(WebCore::documentToElementSetMap):
(WebCore::addElementToDocumentMap):
(WebCore::removeElementFromDocumentMap):

Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
in a media element. By default this is a single range of [0, maxTimeSeekable].

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::seekable):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable):

Support functions to cast between MediaController and EventTarget.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toMediaController):

  • dom/EventTarget.h:

Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
ClockGeneric::currentTime:

  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
(ClockGeneric::now):

  • platform/ClockGeneric.h:

Boilerplate to support creating the derived sources for MediaController and adding new sources
to the project:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • media/media-controller-expected.txt: Added.
  • media/media-controller-playback-expected.txt: Added.
  • media/media-controller-playback.html: Added.
  • media/media-controller.html: Added.
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
09:44 Changeset [100158] by scherkus@chromium.org

[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
https://bugs.webkit.org/show_bug.cgi?id=72147

Reviewed by Adam Barth.

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
09:31 Changeset [100157] by commit-queue@webkit.org

Multiple foreign objects not rendered
https://bugs.webkit.org/show_bug.cgi?id=72151

Patch by Florin Malita <fmalita@google.com> on 2011-11-14
Reviewed by Adam Barth.

Source/WebCore:

SVG end tags need to be case-adjusted (just like their start counterparts).

Test: svg/foreignObject/multiple-foreign-objects.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/runner-expected.txt: Rebaselined.
  • platform/chromium/html5lib/runner-expected.txt: Rebaselined.
  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Rebaselined.
  • svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
  • svg/foreignObject/multiple-foreign-objects.html: Added.
09:29 Changeset [100156] by tonyg@chromium.org

Flaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
https://bugs.webkit.org/show_bug.cgi?id=59771

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
09:16 Changeset [100155] by alexis.menard@openbossa.org

[Qt][WK2] Cleanup QML tests.
https://bugs.webkit.org/show_bug.cgi?id=72259

Reviewed by Simon Hausmann.

Cleanup QML tests. This patch removes the duplicates after the merge of both views.
I also isolated the desktop specific bits into its own directory.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
09:10 Changeset [100154] by lforschler@apple.com

Merge r100022.

09:05 Changeset [100153] by mario@webkit.org

Add support for the caretBrowsingEnabled preference in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72266

Reviewed by Chris Fleizach.

Source/WebCore:

  • WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.

Source/WebKit2:

  • Shared/WebPreferencesStore.h: Add caretBrowsingEnabled getter

and setter macro.

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCaretBrowsingEnabled): Added.
(WKPreferencesGetCaretBrowsingEnabled): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the
caretBrowsingEnabledKey preference.

09:01 Changeset [100152] by paroga@webkit.org

[WIN] Remove dependency on pthread from FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=72098

Reviewed by Adam Roben.

All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.

  • wtf/FastMalloc.cpp:
08:59 Changeset [100151] by tonyg@chromium.org

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
08:56 Changeset [100150] by lforschler@apple.com

Versioning.

08:52 Changeset [100149] by tonyg@chromium.org

media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
08:45 Changeset [100148] by commit-queue@webkit.org

Remove expected crashes for skia-gpu canvas from test expectations
https://bugs.webkit.org/show_bug.cgi?id=72183

Patch by Brian Salomon <bsalomon@google.com> on 2011-11-14
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
08:41 Changeset [100147] by tonyg@chromium.org

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
08:30 Changeset [100146] by fsamuel@chromium.org

[chromium] Plumb through partial swap
https://bugs.webkit.org/show_bug.cgi?id=72028

Patch by Jonathan Backer <backer@chromium.org> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):

08:29 Changeset [100145] by caseq@chromium.org

Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
https://bugs.webkit.org/show_bug.cgi?id=72268

Reviewed by Pavel Feldman.

Source/WebCore:

  • replace IFrameView with ExtensionView;
  • inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
  • move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
  • expose iframe's window object in the onShow event handler.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI):
(injectedExtensionAPI.PanelWithSidebarImpl):
(injectedExtensionAPI.ExtensionPanelImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionView.prototype.wasShown):
(WebInspector.ExtensionView.prototype.willHide):
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.notifyViewShown):
(WebInspector.ExtensionServer.prototype.notifyViewHidden):
(WebInspector.ExtensionServer.prototype._onCreatePanel):

  • inspector/front-end/IFrameView.js: Removed.
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt:
08:22 Changeset [100144] by ossy@webkit.org

[Qt] Unreviewed evening gardening. Try to make the bot green.

07:56 Changeset [100143] by yurys@chromium.org

Web Inspector: add 'Show function definition' context menu item for function values
https://bugs.webkit.org/show_bug.cgi?id=72265

Allow navigating to JavaScript function definition using context menu.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):

  • inspector/front-end/inspector.js:

(WebInspector.showPanelForAnchorNavigation):

07:44 Changeset [100142] by dmazzoni@google.com

Unreviewed: update platform/gtk/Skipped because a newly-added
failing test is due to general accessibility testing issues
on GTK, not due to this particular test.
https://bugs.webkit.org/show_bug.cgi?id=72249

07:33 Changeset [100141] by tonyg@chromium.org

[chromium] security/crypto-random-values-types.html is flaky on win
https://bugs.webkit.org/show_bug.cgi?id=72272

  • platform/chromium/test_expectations.txt: Mark test as flaky.
07:17 Changeset [100140] by tonyg@chromium.org

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=72271

  • platform/chromium/test_expectations.txt: Expect test to crash sometimes.
06:58 UsingGitWithWebKit edited by aroben@apple.com
Added some tips for breaking up large patches (diff)
06:53 Changeset [100139] by tonyg@chromium.org

media/track/track-cues-cuechange.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72269

  • platform/chromium/test_expectations.txt: Mark test as flaky.
06:29 Changeset [100138] by vsevik@chromium.org

Unreviewed, unskipping passing test.

  • platform/chromium/test_expectations.txt:
06:14 Changeset [100137] by pfeldman@chromium.org

Web Inspector: console's protocol payload does not have url and line properties.
https://bugs.webkit.org/show_bug.cgi?id=72256

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-url-and-line.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):

LayoutTests:

  • inspector/console/console-url-and-line-expected.txt: Added.
  • inspector/console/console-url-and-line.html: Added.
  • inspector/protocol/console-agent-expected.txt:
06:06 Changeset [100136] by tonyg@chromium.org

[chromium] Two inspector tests timeout on mac
https://bugs.webkit.org/show_bug.cgi?id=72264

  • platform/chromium/test_expectations.txt: Expect appcache-iframe-manifests and script-formatter to timeout on mac.
06:03 Changeset [100135] by pfeldman@chromium.org

Web Inspector: [regression r99960] null callback access.
https://bugs.webkit.org/show_bug.cgi?id=72263

Reviewed by Yury Semikhatsky.

  • inspector/CodeGeneratorInspector.py:
05:19 Changeset [100134] by vestbo@webkit.org

[Qt] Unbreak the build on Mac OS X

QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
that's been fixed in Qt we have to use the same guards in WebKit, not
Q_OS_MAC.

05:19 Changeset [100133] by vestbo@webkit.org

[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

05:06 Changeset [100132] by hausmann@webkit.org

[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

  • qmake/mkspecs/features/features.prf:
05:01 Changeset [100131] by hausmann@webkit.org

[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • wtf/qt/compat/qguiapplication.h:

(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

04:58 Changeset [100130] by vestbo@webkit.org

[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

04:46 Changeset [100129] by caio.oliveira@openbossa.org

[Qt] Remove reference to QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p.h:
04:44 Changeset [100128] by tonyg@chromium.org

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.
04:41 Changeset [100127] by commit-queue@webkit.org

[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

04:20 Changeset [100126] by commit-queue@webkit.org

[CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

  • UseV8.cmake: Added.
03:55 Changeset [100125] by kenneth@webkit.org

[Qt] the QQuickWebView should support double-tap to zoom
https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

03:52 Changeset [100124] by vsevik@chromium.org

http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-test.js:

(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • platform/chromium/test_expectations.txt:
03:49 Changeset [100123] by hausmann@webkit.org

[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
03:49 Changeset [100122] by apavlov@chromium.org

[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
03:24 Changeset [100121] by ryuan.choi@samsung.com

[GTK] Possible crash when destroying after called widgetSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::chromeDestroyed):

03:15 Changeset [100120] by tonyg@chromium.org

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

  • platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.
02:53 Changeset [100119] by tonyg@chromium.org

Unreviewed, rolling out r100116.
http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

  • Scripts/run-bindings-tests:
02:48 Changeset [100118] by tonyg@chromium.org

Unreviewed, rolling out r100104.
http://trac.webkit.org/changeset/100104
https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
02:26 Changeset [100117] by abarth@webkit.org

SecurityContext should track whether the SecurityOrigin has been initialized
https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized. In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):

  • dom/SecurityContext.h:

(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

02:00 Changeset [100116] by philn@webkit.org

Unreviewed, build fix after r100104. run-binding-tests broke.

  • Scripts/run-bindings-tests: Explicitely use scm.detection.
01:50 Changeset [100115] by carlosgc@webkit.org

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
01:40 Changeset [100114] by commit-queue@webkit.org

Web Inspector: Give HTML ContextMenu a more Native look
https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-14
Reviewed by Pavel Feldman.

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

  • inspector/front-end/inspector.css:

(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

01:27 Changeset [100113] by yurys@chromium.org

Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

(JSC::JSFunction::sourceCode):

  • runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
01:25 Changeset [100112] by ossy@webkit.org

[Qt] Unreviewed gardening after r100050
https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-11-14

  • platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html
01:18 Changeset [100111] by commit-queue@webkit.org

Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.
01:16 Changeset [100110] by yurys@chromium.org

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

01:14 Changeset [100109] by commit-queue@webkit.org

Build breaks with --no-javascript-debugger --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

  • workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

00:27 Changeset [100108] by haraken@chromium.org

Remove all custom constructors of Events in V8
https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

  • Target.pri: Removed V8EventConstructors.cpp.
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/OverflowEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • dom/WebKitTransitionEvent.idl: Ditto.
  • html/track/TrackEvent.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
00:23 BuildingQtOnLinux edited by ossy@webkit.org
(diff)
00:20 Changeset [100107] by philn@webkit.org

Unreviewed, GTK baselines for 2 new svg tests.

  • platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
00:16 Changeset [100106] by paroga@webkit.org

[WX] Make FontPlatformData::m_size private
https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

  • platform/graphics/wx/FontPlatformData.h:
00:15 Changeset [100105] by philn@webkit.org

Unreviewed, skip 2 tests failing on GTK and 2 flaky crashers.

  • platform/gtk/Skipped:
00:07 Changeset [100104] by eric@webkit.org

Add SCMDetector object to make scm detection mockable
https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

11/13/11:

23:57 Changeset [100103] by ossy@webkit.org

[Qt] Unreviewed gardening after r100036.

  • platform/qt/svg/foreignObject/clip-expected.png: Added.
  • platform/qt/svg/foreignObject/clip-expected.txt: Added.
  • platform/qt/svg/foreignObject/filter-expected.png: Added.
  • platform/qt/svg/foreignObject/filter-expected.txt: Added.
  • platform/qt/svg/foreignObject/mask-expected.png: Added.
  • platform/qt/svg/foreignObject/mask-expected.txt: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.
23:57 Changeset [100102] by abarth@webkit.org

Document::initSecurityOrigin should return earlier more often
https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

23:53 Changeset [100101] by abarth@webkit.org

SecurityPolicy should refer to isUnique rather than isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time. Previously, this code checked
for empty origins, which are technically a subset of unique origins. I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

23:50 Changeset [100100] by abarth@webkit.org

Move isSecureTransitionTo from SecurityOrigin to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

  • dom/SecurityContext.h:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
21:14 Changeset [100099] by nduca@chromium.org

[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

19:06 Changeset [100098] by tkent@chromium.org

[Chromium] Remove WebFileChooserParams::acceptTypes
https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h: Remove acceptTypes.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

16:02 Changeset [100097] by commit-queue@webkit.org

[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

  • ewk/ewk_view.h:
15:03 Changeset [100096] by commit-queue@webkit.org

[EFL] Simplify eina_stringshare usage in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

14:44 Changeset [100095] by yuqiang.xian@intel.com

Fix silent spilling/filling GPRs in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

13:30 Changeset [100094] by gavinp@chromium.org

command line control of webcore log channels in chromium DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

13:05 Changeset [100093] by scheib@chromium.org

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

09:43 Changeset [100092] by jchaffraix@webkit.org

REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

  • css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

  • fast/media/update-media-query-css-parser-expected.txt: Added.
  • fast/media/update-media-query-css-parser.html: Added.
07:26 Changeset [100091] by scheib@chromium.org

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
06:53 Changeset [100090] by andreas.kling@nokia.com

Only HTMLAllCollection needs stateful named item traversal.
<http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

  • html/HTMLCollection.h:

Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
Promoted itemAfter() and checkForNameMatch() to protected methods so
they can be called from HTMLAllCollection.

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):

  • html/HTMLFormCollection.h:
01:28 Changeset [100089] by mrowe@apple.com

Fix the 32-bit build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

00:09 Changeset [100088] by caio.oliveira@openbossa.org

Update binding generator tests to use jsCast
https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

11/12/11:

23:40 Changeset [100087] by commit-queue@webkit.org

Unreviewed, rolling out r100038.
http://trac.webkit.org/changeset/100038
https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

  • platform/qt/ScrollbarThemeQt.h:
20:37 Changeset [100086] by laszlo.1.gombos@nokia.com

[Qt][Symbian] Remove support for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

  • API/JSStringRef.h:
  • create_hash_table: Revert r45553.
  • runtime/JSGlobalData.cpp: Revert r45553.
  • runtime/LiteralParser.cpp: Remove WINSCW comment.

(JSC::LiteralParser::Lexer::lexString):

  • runtime/Lookup.h: Revert r45553.
  • runtime/Structure.h: Revert r48461.
  • wtf/Alignment.h:
  • wtf/Assertions.h: Revert r52337.
  • wtf/Compiler.h:
  • wtf/ListRefPtr.h: Revert r48988.

(WTF::ListRefPtr::~ListRefPtr):

  • wtf/OwnArrayPtr.h: Revert r45911.

(WTF::OwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassOwnArrayPtr.h:

(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassRefPtr.h:
  • wtf/StaticConstructors.h:
  • wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

(WebCore::CachedResourceHandle::CachedResourceHandle):

  • rendering/style/RenderStyle.h: Revert r52733.

(compareEqual):

  • bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

  • Shared/API/c/WKString.h:
16:47 Changeset [100085] by annacc@chromium.org

Add WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html

media/track/track-webvtt-tc001-utf8.html
media/track/track-webvtt-tc002-bom.html
media/track/track-webvtt-tc003-newlines.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc010-no-timings.html
media/track/track-webvtt-tc011-blank-lines.html
media/track/track-webvtt-tc012-out-of-order.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc014-alignment.html
media/track/track-webvtt-tc015-positioning.html
media/track/track-webvtt-tc016-align-positioning.html
media/track/track-webvtt-tc017-line-position.html
media/track/track-webvtt-tc018-align-text-line-position.html
media/track/track-webvtt-tc019-cue-size.html
media/track/track-webvtt-tc020-cue-size-align.html
media/track/track-webvtt-tc021-valign.html
media/track/track-webvtt-tc022-entities.html
media/track/track-webvtt-tc023-markup.html
media/track/track-webvtt-tc024-timestamp.html
media/track/track-webvtt-tc025-class-markup.html
media/track/track-webvtt-tc026-voice.html
media/track/track-webvtt-tc027-empty-cue.html
media/track/track-webvtt-tc028-unsupported-markup.html

  • html/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.

  • html/TextTrack.h: The cues() function can no longer be const.
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after

all other startTimes in the list.

LayoutTests:

  • media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
15:27 Changeset [100084] by nduca@chromium.org

Fixes to GraphicsContext3D::makeCurrent on gtk and mac
https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

14:13 Changeset [100083] by mitz@apple.com

<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

10:43 Changeset [100082] by paroga@webkit.org

Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

  • dfg/DFGCorrectableJumpPoint.cpp:
  • dfg/DFGCorrectableJumpPoint.h:
09:30 Changeset [100081] by paroga@webkit.org

[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
08:14 Changeset [100080] by paroga@webkit.org

Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

05:51 Changeset [100079] by paroga@webkit.org

Add stub implementation for SVGResources::filter()
https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::selfWillPaint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::selfWillPaint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

05:33 Changeset [100078] by antti@apple.com

REGRESSION(r98542): Rendering error on Google maps
https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

  • fast/css/vertical-align-length-copy-bug-expected.txt: Added.
  • fast/css/vertical-align-length-copy-bug.html: Added.
04:01 Changeset [100077] by commit-queue@webkit.org

[Qt] Fix minor config typo in the build tool documentation
https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

  • qmake/README:
03:09 Changeset [100076] by commit-queue@webkit.org

Unreviewed, rolling out r100013.
http://trac.webkit.org/changeset/100013
https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLTextAreaElement.idl:

LayoutTests:

  • fast/forms/access-key-for-all-elements-expected.txt: Removed.
  • fast/forms/access-key-for-all-elements.html: Removed.
02:39 Changeset [100075] by zimmermann@webkit.org

2011-11-12 Nikolas Zimmermann <nzimmermann@rim.com>

Finish SVGLengthContext conversion in svg/
https://bugs.webkit.org/show_bug.cgi?id=72105

Reviewed by Antti Koivisto.

Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
Now that this process is finished, SVGLengthContext can be shared across renders,
so that its possible to override the length context in a single place. This will
be done in future patches.

Doesn't affect any tests yet.

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::containerTranslation):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • svg/SVGElement.h:
  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::currentViewBoxRect):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
00:52 Changeset [100074] by paroga@webkit.org

[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

  • Source/cmake/WebKitMacros.cmake:
00:40 Changeset [100073] by paroga@webkit.org

Unreviewed build fix for !ENABLE(FILTERS) after r100036.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

Note: See TracTimeline for information about the timeline view.