Timeline


and

11/21/11:

19:38 Changeset [100978] by yutak@chromium.org
  • 8 edits in trunk

[GTK] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72870

Reviewed by Xan Lopez.

Source/WebKit/gtk:

Change the settings value through DumpRenderTreeSupportGtk, because we do not
want to expose this as a public API.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled):
Change the value of a flag in WebCore::Settings.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):
Reset the setting value to the default value (true).

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):
Change the setting value through a function in DumpRenderTreeSupportGtk.

LayoutTests:

  • platform/gtk/Skipped:

Unskip WebSocket hybi tests. Skip two tests using FileSystem API, which is not yet
supported in GTK port.

19:19 Changeset [100977] by commit-queue@webkit.org
  • 5 edits
    5 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r100970.
http://trac.webkit.org/changeset/100970
https://bugs.webkit.org/show_bug.cgi?id=72925

Caused AssociatedURLLoaderTest.Success to fail (Requested by
koz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

  • WebKit.gyp:
  • public/WebUserMediaClient.h: Removed.
  • public/WebUserMediaRequest.h: Removed.
  • public/WebViewClient.h:
  • src/UserMediaClientImpl.cpp: Removed.
  • src/UserMediaClientImpl.h: Removed.
  • src/WebUserMediaRequest.cpp: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:
19:15 Changeset [100976] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <davidbarr@chromium.org> on 2011-11-21
Reviewed by Dimitri Glazkov.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

  • fast/css/style-tag-display-none-expected.txt: Added.
  • fast/css/style-tag-display-none.html: Added.
  • fast/css/style-tag-display-none-expected.png: Added.
19:02 Changeset [100975] by fpizlo@apple.com
  • 11 edits in trunk

DFG should have richer debug output for CFA and phi processing
https://bugs.webkit.org/show_bug.cgi?id=72922

Reviewed by Gavin Barraclough.

In the default verbose mode, we now print information about variable
state at the bottom of basic blocks in addition to the top, and we
also print local variable linking. In the verbose propagation mode,
the state of phi processing is dumped more richly and CFA merging (the
most subtle part of CFA) is traced as well.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCommon.h:

(JSC::DFG::NodeIndexTraits::dump):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.h:

(JSC::DFG::Node::dumpChildren):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperands.h:

(JSC::DFG::OperandValueTraits::dump):
(JSC::DFG::dumpOperands):

18:59 Changeset [100974] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

If an event listener is a function, it should be called and not checked for handleEvent.
This also covers callbacks, which follow the same spec but are implemented separately.
https://bugs.webkit.org/show_bug.cgi?id=62518

Patch by Rob Brackett <rob@robbrackett.com> on 2011-11-21
Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/events/dispatch-to-function-with-handle-event.html

fast/js/callback-function-with-handle-event.html

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

  • fast/events/dispatch-to-function-with-handle-event-expected.txt: Added.
  • fast/events/dispatch-to-function-with-handle-event.html: Added.
  • fast/js/callback-function-with-handle-event-expected.txt: Added.
  • fast/js/callback-function-with-handle-event.html: Added.
18:56 Changeset [100973] by fpizlo@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Should have a test for corner cases of DFG's integer optimization and CSE.
https://bugs.webkit.org/show_bug.cgi?id=72917

Reviewed by Sam Weinig.

  • fast/js/dfg-integer-optimization-expected.txt: Added.
  • fast/js/dfg-integer-optimization.html: Added.
  • fast/js/script-tests/dfg-integer-optimization.js: Added.

(doAdd):

18:15 Changeset [100972] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505

Reviewed by Gavin Barraclough.

It turns out that we were corrupting phi nodes in case of overflow. The bug is
really obvious, but producing a test case that causes the badness is hard. Even
when the phi nodes do get corrupt, there's more that has to happen before it
causes incorrect execution - and I wasn't able to reproduce in any kind of
sensible reduced case.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):

17:27 Changeset [100971] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore/rendering

Adding pixel snapped methods for clientWidth/Height and moving internal callers to LayoutUnit versions.

17:20 Changeset [100970] by commit-queue@webkit.org
  • 5 edits
    5 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-21
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebUserMediaClient.h: Added.

(WebKit::WebUserMediaClient::~WebUserMediaClient):

  • public/WebUserMediaRequest.h: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):

  • public/WebViewClient.h:

(WebKit::WebViewClient::userMediaClient):

  • src/UserMediaClientImpl.cpp: Added.

(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):

  • src/UserMediaClientImpl.h: Added.
  • src/WebUserMediaRequest.cpp: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator PassRefPtr<UserMediaRequest>):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:
17:01 Changeset [100969] by adamk@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

cr-linux rebaselines for r100949. Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-linux/fast/css/empty-inline-003-quirksmode-expected.png: Added.
  • platform/chromium-linux/fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • platform/chromium-linux/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
16:25 Changeset [100968] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r100958. Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
15:31 Changeset [100967] by adamk@chromium.org
  • 3 edits
    1 add
    3 deletes in trunk/LayoutTests

[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903

Reviewed by James Robinson.

Make this test dumpAsText(true) since what we really care about here is
pixel output.

  • compositing/geometry/clipped-video-controller-expected.txt: Added.
  • compositing/geometry/clipped-video-controller.html:
  • platform/chromium-win/compositing/geometry/clipped-video-controller-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/compositing/geometry/clipped-video-controller-expected.txt: Removed.
  • platform/mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.
15:27 Changeset [100966] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Optimistically remove expectations for a handful of no-longer-failing tests.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
15:13 Changeset [100965] by commit-queue@webkit.org
  • 10 edits
    8 adds in trunk

Need support for dirname attribute
https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-21
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html

fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
fast/forms/submit-form-with-dirname-attribute.html

  • html/HTMLAttributeNames.in:

Added "dirname" attribute.

  • html/HTMLInputElement.idl:

Add "dirName" property to HTMLInputElement interface.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.

  • html/HTMLTextAreaElement.idl:

Add "dirName" property to HTMLTextAreaElement interface.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.

  • html/HTMLTextFormControlElement.h:

Helper function for finding directionality of the Element.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.

  • html/TextFieldInputType.h:

Append dirname form data.

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Added.
  • fast/forms/form-dirname-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
  • fast/forms/submit-form-with-dirname-attribute.html: Added.
15:11 Changeset [100964] by eae@chromium.org
  • 27 edits in branches/subpixellayout/Source

Chromium/linux and qt platform fixes

15:09 Changeset [100963] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix tiler initialization in TiledLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=72915

Reviewed by Kenneth Russell.

Setting the tile size or tiling option after the tiler is created invalidates it, and by default the newly
created tiler will have border texels so the test doesn't pass. Switch things around in the test so the tiler
is created only after all the options are set, which is closer to what the real code does.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

15:06 Changeset [100962] by adamk@chromium.org
  • 7 edits
    3 copies
    15 adds in trunk/LayoutTests

Chromium rebaselines after r100949. Unreviewed.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-002-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-003-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-003-expected.txt.
  • platform/chromium-win/fast/css/empty-inline-003-quirksmode-expected.png: Added.
  • platform/chromium-win/fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • platform/chromium-win/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.png:
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.txt:
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.png:
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.txt:
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.png:
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.txt:
  • platform/chromium/fast/css/empty-inline-003-quirksmode-expected.png: Added.
  • platform/chromium/fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • platform/chromium/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
15:01 Changeset [100961] by rniwa@webkit.org
  • 4 edits in trunk/Tools

ChangeLogEntry should be able to parse entries with multiple authors
https://bugs.webkit.org/show_bug.cgi?id=72690

Reviewed by Eric Seidel.

Support multi-author change log entries in ChangeLogEntry. Split author names using
the same logic as splitting reviewer names. _authors now stores list of dictionaries
with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
accounts because some contributors are never listed in committers.py.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}

throws an exception when the argument is None.

15:00 Changeset [100960] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Fix chromium compile bustage - base interface added a parameter so my fake wasn't actually implementing it.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::prepareToUpdate):

14:34 Changeset [100959] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

IndexedDB: Close database connections, abort transactions, and terminate requests on stop()
https://bugs.webkit.org/show_bug.cgi?id=72066

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-21
Reviewed by Tony Chang.

No new tests; addresses race conditions on document navigate/script context stop.

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueEvent):

  • dom/DocumentEventQueue.h:
  • dom/EventQueue.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::stop):

  • storage/IDBDatabase.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::IDBFactory):
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

  • storage/IDBFactory.h:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):

  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):

  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerEventQueue.h:
14:22 Changeset [100958] by jamesr@google.com
  • 7 edits
    1 add in trunk/Source

[chromium] Avoid pushing dirty tiles to the impl layer
https://bugs.webkit.org/show_bug.cgi?id=72765

Reviewed by Kenneth Russell.

Source/WebCore:

If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even
if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not
displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do
decide to update the contents for that tile we can use partial results if they are still valid.

Covered by new unit test in TiledLayerChromiumTest.cpp

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::createTiler):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::setTextureFormat):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::hasTileAt):
(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

Source/WebKit/chromium:

Add unit test for TiledLayerChromium's tile pushing behavior. Requires a fair amount of fake classes. If these
fakes are useful in other tests, they should be moved to a shared location.

  • WebKit.gypi:
  • tests/TiledLayerChromiumTest.cpp: Added.

(::FakeTextureAllocator::createTexture):
(::FakeTextureAllocator::deleteTexture):
(::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::orientation):
(::FakeLayerTextureUpdater::sampledTexelFormat):
(::FakeLayerTextureUpdater::prepareToUpdate):
(::FakeLayerTextureUpdater::updateTextureRect):
(::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::hasTileAt):
(::FakeTiledLayerChromium::FakeTiledLayerChromium):
(::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(::FakeTiledLayerChromium::invalidateRect):
(::FakeTiledLayerChromium::prepareToUpdate):
(::FakeTiledLayerChromium::textureManager):
(::FakeTiledLayerChromium::createTextureUpdater):
(::FakeTiledLayerChromium::textureUpdater):
(::TEST):

14:10 Changeset [100957] by robert@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

Platform-specific results for r100949

Unreviewed gardening.

  • platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/gtk/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
  • platform/gtk/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • platform/gtk/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/qt/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
  • platform/qt/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • platform/qt/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
13:58 Changeset [100956] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix the SnowLeopard build.

  • Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was

not yet declared in a public header.

13:45 Changeset [100955] by alexis.menard@openbossa.org
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=72612

Reviewed by Kenneth Rohde Christiansen.

Make sure that when the view is focused, the page knows about it.
Also set a the view to be the focused item in the failing tests.

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::isViewFocused):

13:40 Changeset [100954] by mrowe@apple.com
  • 4 edits in trunk/Source/WebKit

<http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name

Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
File Manager APIs.

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Link against DiskArbitration.framework. It lives in the shared cache

so it should add only negligible launch time overhead.

Source/WebKit/mac:

  • Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
the volume name from its description dictionary.

13:32 Changeset [100953] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, remove expectations for no-longer-flakey media tests.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [100952] by hausmann@webkit.org
  • 12 edits
    1 add in trunk

[Qt] Speed up debug builds.
https://bugs.webkit.org/show_bug.cgi?id=72882

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • Target.pri: Make BUILDING_JavaScriptCore available earlier, so it can be

used by the build system.

Source/WebCore:

  • Target.pri: Make BUILDING_WebCore available earlier, so it can be

used by the build system.

Source/WebKit2:

  • Target.pri: Make BUILDING_WebKit2 available, so it can be

used by the build system.

Tools:

Introduce a special type of build that replaces the static jsc/wc/wk2
static libraries with shared libraries, that individually are much faster
to link and don't require relinking into the big library when changing just
one file in one module. It can be enabled with
--qmakearg="CONFIG+=force_static_libs_as_shared"

  • qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,

disable symbol visibility, static linkage and enable rpath.

  • qmake/mkspecs/features/functions.prf: Add a helper function to determine if

we need to link the convenience libraries together or not and renamed linkStaticLibrary
to just linkLibrary (because linkage is not necessarily static).

  • qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also

link against jsc/wc/wk2 when linking app code against QtWebKit.

  • qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper

function.

  • qmake/mkspecs/features/webcore.prf: Ditto.
  • qmake/mkspecs/features/webkit2.prf: Ditto.
13:15 Changeset [100951] by adamk@chromium.org
  • 2 edits in trunk/Tools

Update flakiness dashboard linkification regexps for crbug.com/100000 and above
https://bugs.webkit.org/show_bug.cgi?id=72898

Reviewed by Ojan Vafai.

Also removed a comment that was going to be more trouble to keep up to
date than seemed worthwhile (the code is now the documentation).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
13:06 Changeset [100950] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove unnecessary initialize method from QQuickWebView.
https://bugs.webkit.org/show_bug.cgi?id=72905

Reviewed by Kenneth Rohde Christiansen.

We don't need this level of indirection.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

  • UIProcess/API/qt/qquickwebview_p_p.h:
13:06 Changeset [100949] by robert@webkit.org
  • 3 edits
    18 adds in trunk

CSS 2.1 failure: empty-inline-003.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72638

Reviewed by Ryosuke Niwa.

Source/WebCore:

Empty inline elements need to share their inline height with siblings.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is
going to affect the line-height.
(WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox

LayoutTests:

  • css2.1/20110323/empty-inline-001.htm: Added.
  • css2.1/20110323/empty-inline-002.htm: Added.
  • css2.1/20110323/empty-inline-003.htm: Added.
  • fast/css/empty-inline-003-quirksmode-expected.png: Result can cover all platforms as there is no text apart from the period.
  • fast/css/empty-inline-003-quirksmode-expected.txt: ditto
  • fast/css/empty-inline-003-quirksmode.htm: empty-inline-003.htm should only pass in strict mode, this ensures it 'fails' in quirks mode.
  • fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
  • fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Result can cover all platforms as there is no text apart from the period.
  • fast/css/empty-inline-line-height-first-line-quirksmode.htm: Like empty-inline-003.htm, empty-inline-line-height-first-line.htm should also fail in quirks mode.
  • fast/css/empty-inline-line-height-first-line.htm: Like empty-inline-003.htm but ensures first-line style is respected for line-height in empty elements.
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.txt: Added.
13:04 Changeset [100948] by dmazzoni@google.com
  • 6 edits in trunk

[Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
https://bugs.webkit.org/show_bug.cgi?id=72895

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

  • public/WebAccessibilityNotification.h:
  • src/AssertMatchingEnums.cpp:
  • src/ChromeClientImpl.cpp:

(WebKit::toWebAccessibilityNotification):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

13:01 Changeset [100947] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Remove incorrect render surface layer list asserts from compositor
https://bugs.webkit.org/show_bug.cgi?id=72744

Reviewed by James Robinson.

These asserts are incorrect, because it's valid for the default render
surface to be created but to have a root layer that doesn't draw. It
won't get added to the single render surface and it'll have an empty
layer list.

Test: compositor_unittests

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

12:40 Changeset [100946] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r100874.

  • WebCoreSupport/EditorClientWinCE.h:
  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::respondToChangedSelection):

Add WebCore::Frame* parameter to respondToChangedSelection().

12:36 Changeset [100945] by adamk@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Rebaseline font-face-opentype.html on cr-mac-leopard.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-opentype-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-opentype-expected.png.
12:34 Changeset [100944] by senorblanco@chromium.org
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed gardening.

Updated baselines for two SVG tests. These tests have been passing for a while, but the expectations were either stale or completely wrong.

  • platform/chromium-cg-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/chromium/test_expectations.txt:
12:24 Changeset [100943] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, broaden expecations for inspector test.

  • platform/chromium/test_expectations.txt:
12:05 Changeset [100942] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Unreviewed gardening, marking test as PASS TEXT.

  • platform/chromium/test_expectations.txt:
11:38 Changeset [100941] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark as PASS TEXT
11:22 Changeset [100940] by adamk@chromium.org
  • 2 edits in trunk

Add GYP-generated WTF.xcodeproj to .gitignore after r100851.

  • .gitignore:
11:16 Changeset [100939] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test perf/array-push-pop.html is slow
https://bugs.webkit.org/show_bug.cgi?id=72901

Mark test as SLOW PASS.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:09 Changeset [100938] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, run-gtk-tests temporary workaround after r98500.

  • Scripts/run-gtk-tests: Try to find the build directory like in

build-gtkdoc, until webkit-build-directory --configuration gets fixed.

11:02 Changeset [100937] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for
inspector/styles/styles-disable-then-change.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:59 Changeset [100936] by vrk@chromium.org
  • 5 edits in trunk/LayoutTests

Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758

Reviewed by Eric Carlson.

  • http/tests/media/video-cookie-expected.txt:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-referer.html:
10:46 Changeset [100935] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

StyleSheet: Move completeURL() to CSSStyleSheet.
<http://webkit.org/b/72888>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Since completeURL() is only used on CSSStyleSheets, move it there (and make
it non-virtual) to make StyleSheet a little leaner.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::completeURL):

  • css/CSSStyleSheet.h:
  • css/StyleSheet.cpp:
  • css/StyleSheet.h:
10:40 Changeset [100934] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Fix image translation calculations.
https://bugs.webkit.org/show_bug.cgi?id=72892

Reviewed by Kevin Ollivier.

10:35 Changeset [100933] by kevino@webkit.org
  • 3 edits in trunk/Source/WebKit/wx

Add wxWebKit APIs for controlling WebKit caching behavior.
https://bugs.webkit.org/show_bug.cgi?id=72891

Reviewed by Kevin Ollivier.

10:31 Changeset [100932] by kevino@webkit.org
  • 6 edits in trunk/Source/WebKit/wx

Add wxWebKit API for retrieving frame and page URLs.
https://bugs.webkit.org/show_bug.cgi?id=72890

Reviewed by Kevin Ollivier.

10:17 Changeset [100931] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

copyright comment style to C from C++ for gamepad module
https://bugs.webkit.org/show_bug.cgi?id=72894

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-21
Reviewed by Sam Weinig.

Just changes comment format, no code/test changes.

  • Modules/gamepad/Gamepad.cpp:
  • Modules/gamepad/Gamepad.h:
  • Modules/gamepad/Gamepad.idl:
  • Modules/gamepad/GamepadList.cpp:
  • Modules/gamepad/GamepadList.h:
  • Modules/gamepad/GamepadList.idl:
09:55 Changeset [100930] by commit-queue@webkit.org
  • 23 edits
    2 moves
    5 deletes in trunk/LayoutTests

Consolidate the many copies of Ahem in our tests
https://bugs.webkit.org/show_bug.cgi?id=72503

Patch by Philip Rogers <pdr@google.com> on 2011-11-21
Reviewed by Andreas Kling.

  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-download-error.html:
  • fast/css/font-face-in-shadow-DOM.html-disabled:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-families.html:
  • fast/css/font-face-opentype.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-repeated-url.html:
  • fast/css/font-face-unicode-range.html:
  • fast/css/font-face-unused-source-loaded.html:
  • fast/css/font-face-woff.html:
  • fast/css/font-face-zero-hash-key.html:
  • fast/css/resources/Ahem.otf: Removed.
  • fast/css/resources/Ahem.ttf: Removed.
  • fast/css/resources/Ahem.woff: Removed.
  • inspector/audits/resources/Ahem.ttf: Removed.
  • inspector/extensions/extensions-network-expected.txt:
  • inspector/extensions/extensions-network.html:
  • inspector/extensions/resources/Ahem.ttf: Removed.
  • platform/gtk/fonts/font-face-with-complex-text.html:
  • platform/gtk/fonts/resources/Ahem.ttf: Removed.
  • platform/gtk/fonts/synthetic-oblique-positioning.html:
  • resources/Ahem.otf: Added.
  • resources/Ahem.woff: Added.
  • webarchive/resources/Ahem.ttf: Removed.
  • webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
  • webarchive/test-css-url-resources-in-stylesheets.html:
  • webarchive/test-css-url-resources-inline-styles-expected.webarchive:
  • webarchive/test-css-url-resources-inline-styles.html:
09:50 Changeset [100929] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: unskip inspector test on chromium.
https://bugs.webkit.org/show_bug.cgi?id=72887

  • platform/chromium/test_expectations.txt:
09:43 Changeset [100928] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: unskip inspector tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=70414
https://bugs.webkit.org/show_bug.cgi?id=70905
https://bugs.webkit.org/show_bug.cgi?id=72493

  • platform/qt/Skipped:
09:40 Changeset [100927] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Implement a setter for UnifiedTextCheckerEnabled.
https://bugs.webkit.org/show_bug.cgi?id=72872

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Darin Fisher.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setUnifiedTextCheckerEnabled): Added.

  • src/WebSettingsImpl.h:
09:30 Changeset [100926] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake inspector test.

  • inspector/extensions/extensions-events.html:
09:24 Changeset [100925] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

JSC/CSSOM: Merge root() for style declaration objects.
<http://webkit.org/b/72881>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*),
removing a duplicated chunk and making it a little easier on the eyes.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

09:18 Changeset [100924] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectations for
inspector/styles/styles-change-node-while-editing.html and
inspector/styles/styles-disable-inherited.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
09:15 Changeset [100923] by jesus@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Implement loadHtml API for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=72161

Reviewed by Simon Hausmann.

Implement QQuickWebView::loadHtml that calls QtWebPageProxy::loadHTMLString.
This function will use WKPageLoadHTMLString in order to load HTML from a given string.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::loadHtml):

  • UIProcess/API/qt/qquickwebview.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadHTMLString):

  • UIProcess/qt/QtWebPageProxy.h:
09:03 Changeset [100922] by igor.oliveira@openbossa.org
  • 11 edits in trunk/Source

[WK2][Qt] Move Accelerated Composite animations to UIProcess

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimationsRecursively):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::didFireViewportUpdateTimer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

08:56 Changeset [100921] by andreas.kling@nokia.com
  • 4 edits in trunk/LayoutTests

Unreviewed Mac gardening, rebaselining MediaController failures after r100159.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
08:48 Changeset [100920] by ossy@webkit.org
  • 2 edits in trunk

[Qt] [WK2] WebKitTestRunner doesn't build in debug
https://bugs.webkit.org/show_bug.cgi?id=72827

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-21
Reviewed by Andreas Kling.

Add exports to fix WebKitTestRunner debug build.

  • Source/qtwebkit-export.map:
08:21 Changeset [100919] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Add a way to skip unit tests in the bots
https://bugs.webkit.org/show_bug.cgi?id=72879

Reviewed by Philippe Normand.

Rewrite the script in python to make it easier for everybody to
change it and add support for skipping tests.

  • Scripts/run-gtk-tests:
08:19 Changeset [100918] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r100906): Broke inspector/extensions/extensions-events.html (Requested by steveblock on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=72887

Add a TIMEOUT expectation

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
08:13 Changeset [100917] by caryclark@google.com
  • 9 edits
    2 adds in trunk/LayoutTests

Unreviewed rebaselining: Re-enable most layout tests on chromium-mac-leopard.

  • platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png:
  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
  • platform/chromium/test_expectations.txt:
07:47 Changeset [100916] by kbalazs@webkit.org
  • 20 edits in trunk/Source

Unreviewed, rolling out r100913.
http://trac.webkit.org/changeset/100913
https://bugs.webkit.org/show_bug.cgi?id=72885

"Break Windows build" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

Source/JavaScriptCore:

  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:
  • wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

  • wtf/Platform.h:

Source/WebCore:

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:
  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

07:37 Changeset [100915] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] Add more appcache functions to ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72143

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Add a few more functions to make it possible to have more control over
the offline web application features.

  • ewk/ewk_settings.cpp:

(ewk_settings_application_cache_max_quota_get):
(ewk_settings_application_cache_max_quota_set):
(ewk_settings_application_cache_clear):

  • ewk/ewk_settings.h:

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setAppCacheMaximumSize): Use the right
function, this is not related to the memory cache, but rather to the
appcache.

LayoutTests:

LayoutTestController::clearAllApplicationCaches is implemented now.

  • platform/efl/Skipped:
07:19 Changeset [100914] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebKit2

Web Inspector: [WebKit2] Do not access InspectorController from the "Develop" menu code.
https://bugs.webkit.org/show_bug.cgi?id=63009

Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):

  • WebProcess/WebPage/WebInspector.h:
07:16 Changeset [100913] by kbalazs@webkit.org
  • 20 edits in trunk/Source

Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

missing for the gyp build system.

Export symbols.

  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

  • wtf/ParallelJobsGeneric.h:
  • wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

07:15 Changeset [100912] by aroben@apple.com
  • 3 edits in trunk/Tools

Make NRWT consider all lines of output from parse-malloc-history, not just the first

Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
found" even when there are more than 1 unique leaks

Reviewed by Darin Adler.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
"" will be considered to match the beginning of any line, not only the beginning of the
string.

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
fake output and updated expectations to match.

07:04 Changeset [100911] by pfeldman@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating expectations for the inspector console test (Qt -> all).

  • inspector/console/console-format-expected.txt:
  • platform/qt/inspector/console/console-format-expected.txt: Removed.
06:59 Changeset [100910] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[Qt] Clean up MiniBrowser project file after recent changes
https://bugs.webkit.org/show_bug.cgi?id=72869

Reviewed by Simon Hausmann.

Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.

  • MiniBrowser/qt/MiniBrowser.pro:
06:41 Changeset [100909] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

Remove CSSStyleSelector::m_additionalAttributeStyleDecls field
https://bugs.webkit.org/show_bug.cgi?id=72876

Reviewed by Andreas Kling.

There is no reason for this temporary to be a field.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

  • css/CSSStyleSelector.h:
06:37 Changeset [100908] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Assertion failed in ScriptsPanel.js
https://bugs.webkit.org/show_bug.cgi?id=72877

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ScriptsPanel.js:
06:13 Changeset [100907] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/show-user-agent-styles.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
05:37 Changeset [100906] by pfeldman@chromium.org
  • 19 edits in trunk/Source/WebCore

Web Inspector: get rid of Panel::reset in the front-end.
https://bugs.webkit.org/show_bug.cgi?id=72587

I'm slowly getting rid of the Inspector protocol domain. It currently
contains methods that did not find their home in the meaningful domains.
This change removes reset protocol method.

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didCommitLoad):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerDispatcher.prototype.globalObjectCleared):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._mainFrameNavigated):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext.prototype.get frameId):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._frameDetached):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._reset):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):
(WebInspector.WorkerManager.prototype._mainFrameNavigated):

  • inspector/front-end/inspector.js:
05:28 Changeset [100905] by caio.oliveira@openbossa.org
  • 8 edits in trunk

[Qt] Add WebView.view attached property support for dialogs in QML
https://bugs.webkit.org/show_bug.cgi?id=72825

Reviewed by Simon Hausmann.

.:

Export QQuickWebViewAttached.

  • Source/qtwebkit-export.map:

Source/WebKit2:

When creating new dialogs, fill their WebView.view attached property
with the WebView that's creating them. This follows the same pattern
as QtQuick's ListView, enabling the usage of the same dialog component
for different WebViews.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::setViewInAttachedProperties):
(QQuickWebViewAttached::QQuickWebViewAttached):
(QQuickWebViewAttached::setView):
(QQuickWebView::qmlAttachedProperties):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner::dialog):

05:20 Changeset [100904] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/win

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: an attempt to fix windows build.

  • WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled):
04:54 Changeset [100903] by pfeldman@chromium.org
  • 26 edits
    1 add in trunk

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Source/WebCore:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js: Added.

(InspectorFrontendAPI.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isJavaScriptProfilingEnabled):
(InspectorFrontendAPI.setJavaScriptProfilingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get profilerEnabled):
(WebInspector.ProfilesPanel.prototype.enableProfiler):
(WebInspector.ProfilesPanel.prototype.disableProfiler):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
(WebInspector.ScriptsPanel.prototype.enableDebugging):
(WebInspector.ScriptsPanel.prototype.disableDebugging):
(WebInspector.ScriptsPanel.prototype.toggleDebugging):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
(WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
(WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

Source/WebKit/mac:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController destroyInspectorView:]):

  • WebInspector/WebInspector.mm:

(-showWindow):
(-show:):
(-showConsole:):
(-isDebuggingJavaScript):
(-toggleDebuggingJavaScript:):
(-startDebuggingJavaScript:):
(-stopDebuggingJavaScript:):
(-isProfilingJavaScript):
(-toggleProfilingJavaScript:):
(-startProfilingJavaScript:):
(-stopProfilingJavaScript:):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-isTimelineProfilingEnabled):
(-setTimelineProfilingEnabled:):
(-setFrontend:):
(-releaseFrontend):
(-showWindow:):

  • WebInspector/WebInspectorFrontend.h:
  • WebInspector/WebInspectorFrontend.mm:

(-[WebInspectorFrontend isDebuggingEnabled]):
(-[WebInspectorFrontend setDebuggingEnabled:]):
(-[WebInspectorFrontend isProfilingJavaScript]):
(-[WebInspectorFrontend startProfilingJavaScript]):
(-[WebInspectorFrontend stopProfilingJavaScript]):
(-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
(-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
(-[WebInspectorFrontend isTimelineProfilingEnabled]):
(-[WebInspectorFrontend setTimelineProfilingEnabled:]):

  • WebInspector/WebInspectorPrivate.h:

Source/WebKit/win:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

LayoutTests:

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

04:48 Changeset [100902] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk

Add .dir-locals.el file for better Emacs defaults
https://bugs.webkit.org/show_bug.cgi?id=72483

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-21
Reviewed by Xan Lopez.

  • .dir-locals.el: Set appropriate directory-local variables for Emacs.
04:46 Changeset [100901] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/styles-cancel-editing.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
04:19 Changeset [100900] by apavlov@chromium.org
  • 13 edits in trunk

Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles
https://bugs.webkit.org/show_bug.cgi?id=72701

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):

  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._innerUpdate):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
04:19 Changeset [100899] by noel.gordon@gmail.com
  • 2 edits in trunk

Update .gitignore for latest WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=72851

Reviewed by Andreas Kling.

  • .gitignore: updates to silence 'git status' about WebKitLibraries files.
04:14 Changeset [100898] by carlosgc@webkit.org
  • 4 edits in trunk

[GTK] Update NEWS and configure.ac for 1.7.2 release
https://bugs.webkit.org/show_bug.cgi?id=72868

Reviewed by Xan Lopez.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.2.
04:02 Changeset [100897] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for jquery/offset.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:11 Changeset [100896] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r100856.
http://trac.webkit.org/changeset/100856
https://bugs.webkit.org/show_bug.cgi?id=72867

New test fast/css/style-tag-display-none.html fails on
Chromium (Requested by steveblock on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

Source/WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

  • fast/css/style-tag-display-none-expected.txt: Removed.
  • fast/css/style-tag-display-none.html: Removed.
02:29 Changeset [100895] by jochen@chromium.org
  • 26 edits
    25 adds in trunk

Implement Meta referrer
https://bugs.webkit.org/show_bug.cgi?id=72674

Reviewed by Adam Barth.

Source/WebCore:

http://wiki.whatwg.org/wiki/Meta_referrer

Tests: http/tests/security/referrer-policy-always.html

http/tests/security/referrer-policy-default.html
http/tests/security/referrer-policy-https-always.html
http/tests/security/referrer-policy-https-default.html
http/tests/security/referrer-policy-https-never.html
http/tests/security/referrer-policy-https-origin.html
http/tests/security/referrer-policy-never.html
http/tests/security/referrer-policy-origin.html
http/tests/security/referrer-policy-redirect.html
http/tests/security/referrer-policy-rel-noreferrer.html

  • WebCore.exp.in: updated
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):

  • dom/Document.h:

(WebCore::Document::referrerPolicy):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader):

  • page/SecurityPolicy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebReferrerPolicy.h: Added.
  • public/WebSecurityPolicy.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::referrerPolicy):
(WebKit::WebFrameImpl::setReferrerForRequest):

  • src/WebFrameImpl.h:
  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::generateReferrerHeader):

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

LayoutTests:

  • http/tests/security/referrer-policy-always-expected.txt: Added.
  • http/tests/security/referrer-policy-always.html: Added.
  • http/tests/security/referrer-policy-default-expected.txt: Added.
  • http/tests/security/referrer-policy-default.html: Added.
  • http/tests/security/referrer-policy-https-always-expected.txt: Added.
  • http/tests/security/referrer-policy-https-always.html: Added.
  • http/tests/security/referrer-policy-https-default-expected.txt: Added.
  • http/tests/security/referrer-policy-https-default.html: Added.
  • http/tests/security/referrer-policy-https-never-expected.txt: Added.
  • http/tests/security/referrer-policy-https-never.html: Added.
  • http/tests/security/referrer-policy-https-origin-expected.txt: Added.
  • http/tests/security/referrer-policy-https-origin.html: Added.
  • http/tests/security/referrer-policy-never-expected.txt: Added.
  • http/tests/security/referrer-policy-never.html: Added.
  • http/tests/security/referrer-policy-origin-expected.txt: Added.
  • http/tests/security/referrer-policy-origin.html: Added.
  • http/tests/security/referrer-policy-redirect-expected.txt: Added.
  • http/tests/security/referrer-policy-redirect.html: Added.
  • http/tests/security/referrer-policy-rel-noreferrer-expected.txt: Added.
  • http/tests/security/referrer-policy-rel-noreferrer.html: Added.
  • http/tests/security/resources/referrer-policy-log.php: Added.
  • http/tests/security/resources/referrer-policy-redirect.html: Added.
  • http/tests/security/resources/referrer-policy-start.html: Added.
  • http/tests/security/resources/rel-noreferrer.html: Added.
02:22 Changeset [100894] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: ApplicationCache view should show navigator.onLine indicator.
https://bugs.webkit.org/show_bug.cgi?id=72618

Reviewed by Pavel Feldman.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::enable):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.get onLine):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):

01:55 Changeset [100893] by carlosgc@webkit.org
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:
01:50 Changeset [100892] by dmazzoni@google.com
  • 16 edits
    2 adds in trunk

Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
https://bugs.webkit.org/show_bug.cgi?id=72479

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/multiselect-list-reports-active-option.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelectedOptionActive):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSelectedOptionActive):

Source/WebKit/chromium:

Test: accessibility/multiselect-list-reports-active-option.html

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isSelectedOptionActive):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getIsSelectedOptionActiveCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isSelectedOptionActiveGetterCallback):

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isSelectedOptionActive):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

  • accessibility/multiselect-list-reports-active-option.html: Added.
  • platform/chromium/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
01:42 Changeset [100891] by yutak@chromium.org
  • 4 edits in trunk

[Qt] WebSocket close tests are failing
https://bugs.webkit.org/show_bug.cgi?id=72865

Reviewed by Simon Hausmann.

Source/WebCore:

  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::close):
Emit didCloseSocketStream() callback even before the connection is established.
Call m_socket->abort() to prevent "connected" signal from firing.

LayoutTests:

  • platform/qt/Skipped:

Unskip five WebSocket tests. Remove "failing websocket tests" section,
as there are no tests in this section.

01:20 Changeset [100890] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=72847

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Hajime Morita.

Covered by existing test.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

Passes Range to requestCheckingFor instead of Node.

  • editing/SpellChecker.cpp: Changed argument type from Node to Range. The corresponding changes are also done in dependent methods.

(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):

Changed argument type from Node to Range.

(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:
01:12 Changeset [100889] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
https://bugs.webkit.org/show_bug.cgi?id=72859

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-21
Reviewed by Eric Seidel.

  • Scripts/new-run-webkit-websocketserver:
00:37 Changeset [100888] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Another attempt at a build fix.

  • dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

11/20/11:

22:28 Changeset [100887] by commit-queue@webkit.org
  • 5 edits in trunk

[Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=72655

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-20
Reviewed by Hajime Morita.

Tools:

Fixed the calculation of offset.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::finishLastTextCheck):

LayoutTests:

Fixed the calculation of offset, and added test cases having multiple misspelled words.

  • editing/spelling/script-tests/spellcheck-paste.js: Added test cases having multiple misspelled words.

(verifyMarker):
(tests):

  • editing/spelling/spellcheck-paste-expected.txt: Recreated.
22:10 Changeset [100886] by bashi@chromium.org
  • 10 edits in trunk

[Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs.
https://bugs.webkit.org/show_bug.cgi?id=72844

Source/WebCore:

Respects bold and italic properties that is given by fontconfig.

Reviewed by Darin Fisher.

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters): Removed #if and old logic.

Source/WebKit/chromium:

Removes old APIs for getting font family for given characters.

Reviewed by Darin Fisher.

  • public/linux/WebFontInfo.h: Removed old familyForChars().
  • public/linux/WebSandboxSupport.h: Removed old getFontFamilyForCharacters() and changed new getFontFamilyForCharacters() to be a pure virtual function.
  • src/linux/WebFontInfo.cpp: Removes old familyForChars().

LayoutTests:

Font selection mechanism of Chromium Linux port has been improved. Rebaselines affected tests.

Reviewed by Darin Fisher.

  • platform/chromium-linux/fast/text/cg-fallback-bolding-expected.png:
  • platform/chromium-linux/fast/text/cg-fallback-bolding-expected.txt:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
21:37 Changeset [100885] by commit-queue@webkit.org
  • 3 edits
    4 adds
    1 delete in trunk/LayoutTests

Rebaseline for border change in r100528
https://bugs.webkit.org/show_bug.cgi?id=72689

Patch by Ben Wells <benwells@chromium.org> on 2011-11-20
Reviewed by Stephen White.

  • platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
  • platform/chromium-mac/fast/borders/mixed-border-styles-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
  • platform/chromium/test_expectations.txt:
21:18 Changeset [100884] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove qt/QtMobileWebStyle from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72843

Reviewed by Antonio Gomes.

platform/qt/QtMobileWebStyle.{h,cpp} were removed in r100123

  • WebCore.gypi: remove platform/qt/QtMobileWebStyle.{h,cpp}
21:03 Changeset [100883] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed interpreter build fix.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

  • dfg/DFGRepatch.h:
21:01 Changeset [100882] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.h:
20:47 Changeset [100881] by yuqiang.xian@intel.com
  • 6 edits in trunk/Source/JavaScriptCore

Improve modulo operation on 32bit platforms
https://bugs.webkit.org/show_bug.cgi?id=72501

Reviewed by Filip Pizlo.

Extend softModulo to support X86 and MIPS in baseline JIT.
Apply the same optimization to 32bit DFG JIT.
1% gain on Kraken, tested on Linux Core i7 Nehalem 32bit.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::softModulo):

  • wtf/Platform.h:
20:45 Changeset [100880] by fpizlo@apple.com
  • 19 edits in trunk/Source/JavaScriptCore

Inline caches that refer to otherwise dead objects should be cleared
https://bugs.webkit.org/show_bug.cgi?id=72311

Reviewed by Geoff Garen.

DFG code blocks now participate in the weak reference harvester fixpoint
so that they only consider themselves to be live if either they are
currently executing, or their owner is live and all of their weak references
are live. If not, the relevant code blocks are jettisoned.

Inline caches in both the old JIT and the DFG are now cleared if any of
their references are not marked at the end of a GC.

This is performance-neutral on SunSpider, V8, and Kraken. With the clear-
all-code-on-GC policy that we currently have, it shows a slight reduction
in memory usage. If we turn that policy off, it's pretty easy to come up
with an example program that will cause ToT to experience linear heap
growth, while with this patch, the heap stays small and remains at a
constant size.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::readCallTarget):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::readCallTarget):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::readCallTarget):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::readCallTarget):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::MethodCallLinkInfo::reset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):

  • bytecode/Instruction.h:

(JSC::PolymorphicAccessStructureList::visitWeak):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::reset):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

  • dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::clearToMaxUnsigned):

20:35 Changeset [100879] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The bytecode generator was assuming that call_varargs never reuses the base register
(i.e. the function being called) for the result. This is no longer true.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/function-dot-apply-replace-base-expected.txt: Added.
  • fast/js/function-dot-apply-replace-base.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js:

(done):

  • fast/js/script-tests/function-dot-apply-replace-base.js: Added.

(foo):
(bar):

19:32 Changeset [100878] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 32_64 should directly store double virtual registers on SetLocal
https://bugs.webkit.org/show_bug.cgi?id=72845

Reviewed by Oliver Hunt.

2% win on Kraken.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

18:26 Changeset [100877] by abarth@webkit.org
  • 5 edits
    1 delete in trunk

REGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets
https://bugs.webkit.org/show_bug.cgi?id=72836

Reviewed by Sam Weinig.

Source/WebCore:

This patch removes a (minor) security mitigation. Previously, we tried
sequester "directory listings" into unique origins to make it more
difficult for an attacker to crawl the user's local file system.
Unfortunately, this mitigation doesn't really buy us much security
because if the attacker has access to local files, we've probably lost
anyway.

The larger problem, however, is that this condition is overly
complicated and has broken in sublte ways several times in its
(relatively short) lifetime. In the cases reported in this bug, we see
that this check affects error pages in Safari and Growl notifications,
even those have nothing to do with directory listings.

If we have our heart set on this directory listing mitigation, we'll
need a more robust way of triggering the behavior than examining URLs
and guess whether they contain directory listings. For example, if we
implement Allow-From or Access-Control-Deny-Origin, then the embedder
can supply those policies along with the directory listings. Those
seem like much better solutions than the in-engine hack this patch
removes.

  • page/SecurityOrigin.cpp:

(WebCore::shouldTreatAsUniqueOrigin):

LayoutTests:

Update test results to show that XMLHttpRequets for directory listings
aren't blocked.

  • fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html:
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
18:03 Changeset [100876] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[chromium] Remove DFG::JITCodeGenerator from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72842

Reviewed by Filip Pizlo.

dfg/DFGJITCodeGenerator.{h,cpp} were removed in r100244

17:26 Changeset [100875] by ojan@chromium.org
  • 3 edits in trunk/Tools

Change the final place where we use version 3 of the results json output
https://bugs.webkit.org/show_bug.cgi?id=72838

Reviewed by Adam Barth.

This converts the json from being a flat map of test name --> results
to being hierarchical by directory. This will make the json files
considerably smaller.

Also cleaned up some functions that were returning/checking boolean values
that were always True.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
15:55 Changeset [100874] by tonikitoo@webkit.org
  • 28 edits in trunk/Source

2011-10-17 Antonio Gomes <agomes@rim.com>

Pass a Frame* parameter in EditorClient::respondToChangedSelection
https://bugs.webkit.org/show_bug.cgi?id=70248

Reviewed by Ryosuke Niwa.

Most of the port specific implementations of EditorClient::respondToChangedSelection
(like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
method to get the Frame where the selection is happening on.

It is not right, since a selection can be easily triggered in an inner
frame that is not focused.

No new tests since it is a hard thing to test without
to hook into editor client in layout tests. We could
change the "Dumped Delegate" messages, but it would
require a rebasile of +1200 for a minor change.

No new tests since it is a hard thing to test without
to hook into editor client in layout tests. We could
change the "Dumped Delegate" messages, but it would
require a rebasile of +1200 for a minor change.

Source/WebCore:

  • editing/Editor.cpp: Pass the Frame on where the selection is changing to the client. (WebCore::Editor::respondToChangedSelection): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Ditto. (WebCore::EmptyEditorClient::respondToChangedSelection):
  • page/EditorClient.h: Pass Frame* to indicate where the selection is happening.
  • loader/EmptyClients.h: Changed signature as per base class change.

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp: Make use of the newly added Frame* parameter. (WebKit::EditorClientImpl::respondToChangedSelection):
  • src/EditorClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientEfl::respondToChangedSelection):
  • WebCoreSupport/EditorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp: Make use of the newly added Frame* parameter. (WebKit::EditorClient::respondToChangedSelection):
  • WebCoreSupport/EditorClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h: Make use of the newly added Frame* parameter.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientQt::respondToChangedSelection):
  • WebCoreSupport/EditorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter. (WebEditorClient::respondToChangedSelection):
  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientWx::respondToChangedSelection):
  • WebKitSupport/EditorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter. (WebKit::WebEditorClient::respondToChangedSelection):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
15:40 Changeset [100873] by ojan@chromium.org
  • 2 edits in trunk/Tools

Include the master name when querying the test results server.
This will soon be required since leaving the master name out mean
that multiple files could match the query.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
14:55 Changeset [100872] by mrowe@apple.com
  • 8 edits in trunk/Source

<http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/mac/WebCoreNSStringExtras.mm:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::reportErrorToClient):

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

Source/WebKit2:

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
08:40 Changeset [100871] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add WebNode::hasEventListeners for Android
https://bugs.webkit.org/show_bug.cgi?id=72817

Reviewed by Darin Fisher.

Expose this EventTarget interface in the Chromium WebKit API for use by
Android.

  • public/WebNode.h:
  • src/WebNode.cpp:

(WebKit::WebNode::hasEventListeners):

08:38 Changeset [100870] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Add GestureFlingStart and GestureFlingCancel to WebGestureEvent for Android
https://bugs.webkit.org/show_bug.cgi?id=72819

Reviewed by Darin Fisher.

These gesture types are used with FlingAnimator for scrolling.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isScrollGestureEventType):
(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

08:36 Changeset [100869] by abarth@webkit.org
  • 2 edits
    3 adds in trunk/Source/WebKit/chromium

[Chromium] Add WebInputEventFactory for Android
https://bugs.webkit.org/show_bug.cgi?id=67890

Reviewed by Darin Fisher.

Like every Chromium OS, Android needs a WebInputFactory.

  • WebKit.gyp:
  • public/android/WebInputEventFactory.h: Added.
  • src/android/WebInputEventFactory.cpp: Added.

11/19/11:

20:25 Changeset [100868] by kevino@webkit.org
  • 2 edits in trunk

[wx] Build fix after GeneratedImage refactoring.

20:19 Changeset [100867] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] C++ bindings build fix for move of array classes to WTF.

18:12 Changeset [100866] by jamesr@google.com
  • 11 edits
    1 copy
    2 moves
    26 adds
    5 deletes in trunk/LayoutTests

[chromium] Update various compositing baselines and expectations.

  • platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Copied from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/video-page-visibility-expected.png:
  • platform/chromium/test_expectations.txt:
18:09 Changeset [100865] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix jsonp callback code to add the callback if json content
is not jsonp.

  • TestResultServer/handlers/testfilehandler.py:
17:52 Changeset [100864] by ojan@chromium.org
  • 3 edits in trunk/Tools

Modify dashboard_base.js to optionally accept version 4 results json.

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-11-19
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/dashboard_base.js:

(ADD_RESULTS):
(flattenTrie):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testFlattenTrie):

17:47 Changeset [100863] by ojan@chromium.org
  • 3 edits in trunk/Tools

Stop storing results files as jsonp in the test results server
https://bugs.webkit.org/show_bug.cgi?id=72814

Reviewed by Adam Barth.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
17:13 Changeset [100862] by ojan@chromium.org
  • 6 edits in trunk/Tools

Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
https://bugs.webkit.org/show_bug.cgi?id=72813

Reviewed by Adam Barth.

Once this lands, we can start storing pure json in the test results server and then
we can delete the code with all the FIXMEs added here.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

Only add jsonp for full_results.json.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:

Accept pure json uploads.

  • TestResultServer/static-dashboards/dashboard_base.js:

(appendJSONScriptElementFor):
Use the callback parameter so that the server can start returning pure json if it's left out.

16:04 Changeset [100861] by ojan@chromium.org
  • 3 edits in trunk/Tools

Allow json NRWT downloads to be pure json and not jsonp
https://bugs.webkit.org/show_bug.cgi?id=72809

Reviewed by Adam Barth.

I'm moving the server to storing and serving up raw json instead of jsonp.
You can still get the jsonp by passing a "callback" parameter, but there's no
need for run-webkit-tests to get jsonp when all it wants is the raw json.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

Make the wrapper stripping only happen if the json is actually wrapped.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
12:51 Changeset [100860] by commit-queue@webkit.org
  • 7 edits
    6 moves
    2 adds
    1 delete in trunk

Move gamepad to Modules/ (+ some cleanup)
https://bugs.webkit.org/show_bug.cgi?id=72785

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-19
Reviewed by Adam Barth.

Source/WebCore:

Move main files from page/ to Modules/gamepad/. #include guard the
gamepad header inclusions in Navigator.cpp to avoid including for
ports that do not enable GAMEPAD.

  • Modules/gamepad/Gamepad.cpp: Renamed from Source/WebCore/page/Gamepad.cpp.

(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):

  • Modules/gamepad/Gamepad.h: Renamed from Source/WebCore/page/Gamepad.h.
  • Modules/gamepad/Gamepad.idl: Renamed from Source/WebCore/page/Gamepad.idl.
  • Modules/gamepad/GamepadList.cpp: Renamed from Source/WebCore/page/GamepadList.cpp.

(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):

  • Modules/gamepad/GamepadList.h: Renamed from Source/WebCore/page/GamepadList.h.

(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):

  • Modules/gamepad/GamepadList.idl: Renamed from Source/WebCore/page/GamepadList.idl.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • page/Navigator.cpp:

LayoutTests:

Use standard pre/post js test harness rather than custom one.

  • gamepad/gamepad-api-expected.txt:
  • gamepad/gamepad-api.html:
  • gamepad/gamepad-test.js: Removed.
12:15 Changeset [100859] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Unreviewed, rolling out r100834.
http://trac.webkit.org/changeset/100834
https://bugs.webkit.org/show_bug.cgi?id=72806

this patch makes Qt run-webkit-test exit before finishing
(Requested by igoroliveira on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-19

Source/WebCore:

  • platform/graphics/texmap/TextureMapperNode.cpp:
  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

12:08 Changeset [100858] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h because
JSObjectWithGlobalObject.h has been removed.
https://bugs.webkit.org/show_bug.cgi?id=72794

r94701 removed JSObjectWithGlobalObject.h.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-11-19
Reviewed by Oliver Hunt.

  • ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Removed.
09:32 Changeset [100857] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp
https://bugs.webkit.org/show_bug.cgi?id=72734

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json:
07:34 Changeset [100856] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <davidbarr@chromium.org> on 2011-11-19
Reviewed by Antti Koivisto.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

  • fast/css/style-tag-display-none-expected.txt: Added.
  • fast/css/style-tag-display-none.html: Added.
04:52 Changeset [100855] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r100854.
http://trac.webkit.org/changeset/100854

Rollout DEPS roll. Made chromium bots cry.

  • DEPS:
04:24 Changeset [100854] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS 109696->110838

  • DEPS:
03:28 Changeset [100853] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Add the map file symbols export as a dependency of the final qmake target.
https://bugs.webkit.org/show_bug.cgi?id=72740

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-11-19
Reviewed by Simon Hausmann.

Add the symbols file part of the target dependencies.

  • Source/api.pri:
00:45 Changeset [100852] by jcivelli@chromium.org
  • 2 edits in trunk/Source/WebCore

When loading a MHTML document, make sure we set the base URL before
we notify the frame was committed (so the document has the right base
URL when the notification happens).
https://bugs.webkit.org/show_bug.cgi?id=72788

Reviewed by Adam Barth.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

00:25 Changeset [100851] by abarth@webkit.org
  • 6 edits in trunk/Source

Integrate Source/WTF with the Chromium build system
https://bugs.webkit.org/show_bug.cgi?id=72790

Reviewed by Eric Seidel.

Source/WebCore:

Add a dependency on the new WTF.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Add a dependency on the new WTF.

  • WebKit.gyp:

Source/WTF:

Rename the target in this file to "newwtf" to avoid naming conflicts.

  • WTF.gyp/WTF.gyp:
00:09 Changeset [100850] by abarth@webkit.org
  • 1 edit
    30 copies
    5 adds in trunk/Source/WTF

WTF should have an Xcode project
https://bugs.webkit.org/show_bug.cgi?id=71752

Patch by Mark Rowe <mrowe@apple.com> on 2011-11-19
Reviewed by Adam Barth.

This adds an Xcode project that includes only Stub.cpp and Stub.h.
They’re built in to a library at the appropriate path for each
configuration (WebKitBuild/{Debug,Release}/libWTF.a and
/usr/local/lib/libWTF.a) and headers are installed in to the
appropriate location (WebKitBuild/{Debug,Release}/usr/local/include/wtf
and /usr/local/include/wtf). I tested building WTF in this project and
everything appears to build except for DateMath.cpp (due to bug 71747).
I have not yet done any work on making JavaScriptCore and other
projects use the built products of this new project.

  • Configurations: Added.
  • Configurations/Base.xcconfig: Copied from Source/JavaScriptCore/Configurations/Base.xcconfig.
  • Configurations/CompilerVersion.xcconfig: Copied from Source/JavaScriptCore/Configurations/CompilerVersion.xcconfig.
  • Configurations/DebugRelease.xcconfig: Copied from Source/JavaScriptCore/Configurations/DebugRelease.xcconfig.
  • Configurations/WTF.xcconfig: Copied from Source/WebKit2/Configurations/Shim.xcconfig.
  • WTF.xcodeproj: Added.
  • WTF.xcodeproj/project.pbxproj: Added.
  • config.h: Copied from Source/JavaScriptCore/config.h.
  • icu: Added.
  • icu/LICENSE: Copied from Source/JavaScriptCore/icu/LICENSE.
  • icu/README: Copied from Source/JavaScriptCore/icu/README.
  • icu/unicode: Added.
  • icu/unicode/parseerr.h: Copied from Source/JavaScriptCore/icu/unicode/parseerr.h.
  • icu/unicode/platform.h: Copied from Source/JavaScriptCore/icu/unicode/platform.h.
  • icu/unicode/putil.h: Copied from Source/JavaScriptCore/icu/unicode/putil.h.
  • icu/unicode/uchar.h: Copied from Source/JavaScriptCore/icu/unicode/uchar.h.
  • icu/unicode/ucnv.h: Copied from Source/JavaScriptCore/icu/unicode/ucnv.h.
  • icu/unicode/ucnv_err.h: Copied from Source/JavaScriptCore/icu/unicode/ucnv_err.h.
  • icu/unicode/ucol.h: Copied from Source/JavaScriptCore/icu/unicode/ucol.h.
  • icu/unicode/uconfig.h: Copied from Source/JavaScriptCore/icu/unicode/uconfig.h.
  • icu/unicode/uenum.h: Copied from Source/JavaScriptCore/icu/unicode/uenum.h.
  • icu/unicode/uiter.h: Copied from Source/JavaScriptCore/icu/unicode/uiter.h.
  • icu/unicode/uloc.h: Copied from Source/JavaScriptCore/icu/unicode/uloc.h.
  • icu/unicode/umachine.h: Copied from Source/JavaScriptCore/icu/unicode/umachine.h.
  • icu/unicode/unorm.h: Copied from Source/JavaScriptCore/icu/unicode/unorm.h.
  • icu/unicode/urename.h: Copied from Source/JavaScriptCore/icu/unicode/urename.h.
  • icu/unicode/uscript.h: Copied from Source/JavaScriptCore/icu/unicode/uscript.h.
  • icu/unicode/uset.h: Copied from Source/JavaScriptCore/icu/unicode/uset.h.
  • icu/unicode/ustring.h: Copied from Source/JavaScriptCore/icu/unicode/ustring.h.
  • icu/unicode/utf.h: Copied from Source/JavaScriptCore/icu/unicode/utf.h.
  • icu/unicode/utf16.h: Copied from Source/JavaScriptCore/icu/unicode/utf16.h.
  • icu/unicode/utf8.h: Copied from Source/JavaScriptCore/icu/unicode/utf8.h.
  • icu/unicode/utf_old.h: Copied from Source/JavaScriptCore/icu/unicode/utf_old.h.
  • icu/unicode/utypes.h: Copied from Source/JavaScriptCore/icu/unicode/utypes.h.
  • icu/unicode/uversion.h: Copied from Source/JavaScriptCore/icu/unicode/uversion.h.

11/18/11:

23:19 Changeset [100849] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk/Source

[Chromium] [WebSocket] export WebSocketChannel interface for plugins
https://bugs.webkit.org/show_bug.cgi?id=72016

Source/WebCore:

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

Add a interface to send raw binary data.
This interface is used by WebWebSocketChannel implementation
in WebKit API.

No new tests because just export a interface.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:

Source/WebKit/chromium:

Add WebSocket and WebSocketClient to WebKit API.

Currently, only WebSocketStreamHandle class is exported to WebKit API.
WebSocketStreamHandle implements bi-directional communication ports.
If plugins handles the WebSocket protocol, WebSocketChannel and
WebSocketChannelClient must be exported as WebSocket because they are
the classes which implement the WebSocket protocol stack.

Normally, we use WebWebSocketChannel and WebWebSocketChannelClient as
their class names. But here we use just WebSocket and WebSocketClient
because of avoiding WebWeb prefix and class name confliction on
header include.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebSocket.h: Added.

(WebKit::WebSocket::~WebSocket):

  • public/WebSocketClient.h: Added.

(WebKit::WebSocketClient::~WebSocketClient):

  • src/WebRuntimeFeatures.cpp: Insert websockets directory to include path in order to avoid filename confliction.

(WebKit::WebRuntimeFeatures::enableSockets): Use WebCore namespace explicitly.

  • src/WebSocket.cpp: Added.

(WebKit::WebSocket::create):

  • src/WebSocketImpl.cpp: Added.

(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::~WebSocketImpl):
(WebKit::WebSocketImpl::connect):
(WebKit::WebSocketImpl::subprotocol):
(WebKit::WebSocketImpl::sendText):
(WebKit::WebSocketImpl::sendBinary):
(WebKit::WebSocketImpl::bufferedAmount):
(WebKit::WebSocketImpl::close):
(WebKit::WebSocketImpl::fail):
(WebKit::WebSocketImpl::disconnect):
(WebKit::WebSocketImpl::didConnect):
(WebKit::WebSocketImpl::didReceiveMessage):
(WebKit::WebSocketImpl::didReceiveBinaryData):
(WebKit::WebSocketImpl::didReceiveMessageError):
(WebKit::WebSocketImpl::didStartClosingHandshake):
(WebKit::WebSocketImpl::didClose):

  • src/WebSocketImpl.h: Added.

(WebKit::WebSocketImpl::isNull):

23:11 Changeset [100848] by mihnea@adobe.com
  • 1 edit
    1 add in trunk/LayoutTests

Pixel results missing for fast/regions/render-region-custom-style-mark.html
https://bugs.webkit.org/show_bug.cgi?id=72775

Reviewed by Adam Barth.

  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Added.
22:05 Changeset [100847] by commit-queue@webkit.org
  • 7 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=72591
Remove document.width / document.height

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Darin Adler.

Source/WebCore:

Removed document.width/document.height from JS bindings,
but keeping the same for ObjC bindings. Also it should use
document.body.clientWidth and document.body.clientHeight instead.

  • html/HTMLDocument.idl:

LayoutTests:

As support for document.width / document.height has been
removed it should use document.body.clientWidth and document.body.clientHeight
respectively.

  • fast/dom/document-width-height-force-layout-expected.txt:
  • fast/dom/document-width-height-force-layout.html:

Modified test case to use document.body.clientWidth and document.body.clientHeight.

  • fullscreen/video-specified-size-expected.txt:
  • fullscreen/video-specified-size.html:

Modified test case to use document.body.clientWidth.

21:24 Changeset [100846] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the GTK+ build.

  • page/Navigator.idl: Properly disable the webkitGamepads API if gamepad

isn't enabled at compile time.

21:10 Changeset [100845] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed, add one failing test to the Skipped list.

  • platform/qt/Skipped:
19:56 Changeset [100844] by dbates@webkit.org
  • 10 edits
    7 adds in trunk

Add CMake build infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72768

.:

Reviewed by Adam Barth and Antonio Gomes.

  • Source/CMakeLists.txt: Add the BlackBerry port and support for building on QNX.
  • Source/cmake/OptionsBlackBerry.cmake: Added.
  • Source/cmake/OptionsCommon.cmake: Add QNX QCC-variant of CODE_GENERATOR_PREPROCESSOR. We may be able to fold this into the non-MSVC CODE_GENERATOR_PREPROCESSOR.

Source/JavaScriptCore:

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake: Added.
  • shell/PlatformBlackBerry.cmake: Added.
  • wtf/PlatformBlackBerry.cmake: Added.

Source/WebCore:

Reviewed by Antonio Gomes.

  • CMakeLists.txt: At this time the BlackBerry port doesn't support generating DOM bindings from the SVG IDLs. See WebKit bug #72773.
  • PlatformBlackBerry.cmake: Added.

Source/WebKit:

Reviewed by Antonio Gomes.

  • blackberry: Added.
  • blackberry/CMakeListsBlackBerry.txt: Added.

Tools:

Reviewed by Antonio Gomes.

Add optional --blackberry command line argument to build-webkit to build the
BlackBerry port.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isBlackBerry): Added.
(determineIsBlackBerry): Added.
(blackberryTargetArchitecture): Added.
(isAppleWebKit):

19:40 Changeset [100843] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Add another isfinite assertion failure for fast/borders/
https://bugs.webkit.org/show_bug.cgi?id=72053

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
19:18 Changeset [100842] by adamk@chromium.org
  • 19 edits in trunk/Source

Unreviewed, rolling out r100826.
http://trac.webkit.org/changeset/100826
https://bugs.webkit.org/show_bug.cgi?id=72786

Broke Chromium Mac build (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

  • page/ChromeClient.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
19:05 Changeset [100841] by adamk@chromium.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Rebaseline after r100819.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png.
  • platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt.
19:04 Changeset [100840] by jamesr@google.com
  • 3 edits in trunk

Fix reviewed by lines in ChangeLogs

19:02 Changeset [100839] by jamesr@google.com
  • 17 edits
    18 adds in trunk

[chromium] composited layers are blurry with a zoom-in page scale factor
https://bugs.webkit.org/show_bug.cgi?id=71225

Source/WebCore:

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

Pass contents scale factor to the compositor such that it can:

  1. Adjust contentBounds() of the compositoer layers with content scale.
  2. Apply the content scale in the painter for texture update in better resolution.
  3. Apply the content scale to the dirty rect in CanvasLayerTextureUpdater.

This change fixed blurry problem for all tiled layer types and is not limited to
position:fixed layers.

Tests: compositing/geometry/fixed-position-composited-page-scale-down.html

compositing/geometry/fixed-position-composited-page-scale.html
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
compositing/geometry/fixed-position-transform-composited-page-scale.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::contentsScale):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
(WebCore::ImageLayerChromium::needsContentsScale):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::needsContentsScale):
(WebCore::LayerChromium::contentsScale):

  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::needsContentsScale):
(WebCore::TiledLayerChromium::contentBounds):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

Implements GraphicsLayerClient to return values for pageScaleFactor and deviceScaleFactor. They are used to determine contents scale factor compositer layers.

  • src/PageOverlay.cpp:

(WebKit::OverlayGraphicsLayerClientImpl::deviceScaleFactor):
(WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):

LayoutTests:

Added test cases that has position:fixed and page scale.

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

  • compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-page-scale.html: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale.html: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:43 Changeset [100838] by abarth@webkit.org
  • 1 move in trunk/ManualTests

Move manual-tests out of WebCore.

18:40 Changeset [100837] by jamesr@google.com
  • 2 edits in trunk/Tools

Unreviewed, rolling out r100835.
http://trac.webkit.org/changeset/100835
https://bugs.webkit.org/show_bug.cgi?id=72778

Broke some page scale tests

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

18:36 Changeset [100836] by abarth@webkit.org
  • 5 edits in trunk

Prepare to move manual-tests out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=72782

Reviewed by Eric Seidel.

.:

Update these files to refer to the new location of ManualTests.

  • .gitattributes:
  • Source/cmake/WebKitPackaging.cmake:

Tools:

Update this file to refer to the new location of ManualTests.

  • Scripts/webkitpy/common/config/build.py:
18:25 Changeset [100835] by jamesr@google.com
  • 2 edits in trunk/Tools

[chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
https://bugs.webkit.org/show_bug.cgi?id=72778

Reviewed by Kenneth Russell.

Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

18:23 Changeset [100834] by igor.oliveira@openbossa.org
  • 11 edits in trunk/Source

[WK2][Qt] Move Accelerated Composite animations to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=72753

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimationsRecursively):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::updateSceneGraphUpdateTimerFired):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

18:03 Changeset [100833] by commit-queue@webkit.org
  • 18 edits
    10 adds in trunk

IDL changes for gamepad support
https://bugs.webkit.org/show_bug.cgi?id=71753

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-18
Reviewed by Adam Barth.

Source/WebCore:

IDL changes and associated plumbing to expose list of gamepad objects
on navigator object (per current spec). Full patch is
https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
test until more plumbing in future patches.

Test: gamepad/gamepad-api.html

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):

  • page/Gamepad.cpp: Added.

(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):

  • page/Gamepad.h: Added.
  • page/Gamepad.idl: Added.
  • page/GamepadList.cpp: Added.

(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):

  • page/GamepadList.h: Added.

(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):

  • page/GamepadList.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitGamepads):

  • page/Navigator.h:
  • page/Navigator.idl:

Source/WebKit/chromium:

Update to use vendor-prefixed enable.

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

Tools:

Runtime enable gamepad in chromium test shell.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Add basic api existence test.

  • gamepad/gamepad-api-expected.txt: Added.
  • gamepad/gamepad-api.html: Added.
  • gamepad/gamepad-test.js: Added.

(logConsole):
(testExpected):
(reportExpected):
(waitForEventAndEnd):
(waitForEvent._eventCallback):
(waitForEvent):
(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):
(endTest):
(logResult):
(consoleWrite):

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
17:48 Changeset [100832] by commit-queue@webkit.org
  • 4 edits
    3 deletes in trunk

Unreviewed, rolling out r100693.
http://trac.webkit.org/changeset/100693
https://bugs.webkit.org/show_bug.cgi?id=72779

This patch caused a rendering regression (see bug 72770)
(Requested by philip on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

  • fast/layers/layer-absolute-parent-opacity-expected.png: Removed.
  • fast/layers/layer-absolute-parent-opacity-expected.txt: Removed.
  • fast/layers/layer-absolute-parent-opacity.html: Removed.
17:17 Changeset [100831] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

Reflection on composited element doesn't update if the element changes to show no content
https://bugs.webkit.org/show_bug.cgi?id=72774

Source/WebCore:

Reviewed by Chris Marrin.

When a style change results in a reflected element losing its backing store,
we need to clear the backing stores on the layer clones as well.

Test: compositing/reflections/become-simple-composited-reflection.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateLayerDrawsContent):

LayoutTests:

Reviewed by Chris Marrin.

Test that removes the background-color of a reflected, composited element.

  • compositing/reflections/become-simple-composited-reflection-expected.png: Added.
  • compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
  • compositing/reflections/become-simple-composited-reflection.html: Added.
17:12 Changeset [100830] by rniwa@webkit.org
  • 1 edit in trunk/Source/JavaScriptGlue/ChangeLog

Convert the encoding of JavaScriptGlue/Change from MacRoman to UTF-8 as it should be.

17:00 Changeset [100829] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG JIT fails speculation on InstanceOf if the base is not an object
https://bugs.webkit.org/show_bug.cgi?id=72709

Reviewed by Geoff Garen.

InstanceOf already leverages the fact that we only allow the default
hasInstance implementation. So, if the base is predicted to possibly
be not an object and the CFA has not yet proven otherwise, InstanceOf
will abstain from speculating cell and instead return false if the
base is not a cell.

This appears to be a 1% speed-up on V8 on the V8 harness. 3-4% or so
speed-up in earley-boyer. Neutral according to bencher on SunSpider,
V8, and Kraken. In 32-bit, it's a 0.5% win on SunSpider and a 1.9%
win on V8 even on my harness, due to a 12.5% win on earley-boyer.

I also took this opportunity to make the code for InstanceOf common
between the two JITs. This was partially successful, in that the
"common code" has a bunch of #if's, but overall it seems like a code
size reduction.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:46 Changeset [100828] by dcheng@chromium.org
  • 10 edits in trunk

[chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
https://bugs.webkit.org/show_bug.cgi?id=72767

Source/WebCore:

Reviewed by Tony Chang.

Covered by existing tests.

  • editing/chromium/EditorChromium.cpp:

(WebCore::Editor::newGeneralClipboard):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::createDraggingClipboard):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::storageMode):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::hasData):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • src/WebDragData.cpp:

(WebKit::WebDragData::initialize):
(WebKit::WebDragData::assign):

LayoutTests:

  • platform/chromium/test_expectations.txt:
16:43 Changeset [100827] by cevans@google.com
  • 3 edits
    2 adds in trunk

Crash with ranges across a detached, reparented node tree
https://bugs.webkit.org/show_bug.cgi?id=72757

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/move-detached-child-in-range.html

  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::childBefore): protect the raw child node from getting pulled from under us.

LayoutTests:

  • fast/dom/move-detached-child-in-range-expected.txt: Added.
  • fast/dom/move-detached-child-in-range.html: Added.
16:31 Changeset [100826] by bdakin@apple.com
  • 19 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=72551
When the recommended scrollbar style changes, WKView's tracking options should
adjust accordingly
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This new ChromeClient function is called when the recommended scrollbar style
changes. This way, WebKit can respond to the change by adjusting its mouse
tracking.

  • page/ChromeClient.h:

(WebCore::ChromeClient::recommendedScrollbarStyleDidChange):

Existing ScrollableArea function scrollbarStyleChanged() now takes an int
indicating the new scrollbar style and a bool indicating whether it is necessary
to force an update. It used to be the case that this function was ONLY used to
force an update (and only called when an updated was needed), but now that it must
also call into the ChromeClient, it is necessary to include a bool tracking
whether we need to force an update. New implementation on FrameView is responsible
for calling ChromeClient, and then that calls into the pre-existing ScrollView
function for the forceUpdate part.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollbarStyleChanged):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView:: scrollbarStyleChanged):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

These new functions take care of passing along the
recommendedScrollbarStyleDidChange() message that originates in the ChromeClient.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::recommendedScrollbarStyleDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

This is where we actually respond to the recommendedScrollbarStyleDidChange
message. We remove the existing tracking area and create a new tracking area with
the appropriate tracking options.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

BuiltInPDFView inherits from WebCore::ScrollableArea, so scrollbarStyleChanged()
must now take two parameters like the one in ScrollableArea.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
16:29 Changeset [100825] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758

Allow these tests to timeout until the bug is fixed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:23 Changeset [100824] by knorton@google.com
  • 2 edits in trunk/Source/WebCore

Fixes several more void functions in RenderObject that return values.
https://bugs.webkit.org/show_bug.cgi?id=72750

Reviewed by Adam Barth.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateBeforeAfterContent):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):

16:14 Changeset [100823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Add some useful text to existing debug dump
https://bugs.webkit.org/show_bug.cgi?id=72576

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-18
Reviewed by James Robinson.

No new tests needed.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::dumpSurface):

16:12 Changeset [100822] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Forgot to completely de-virtualize isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=72763

Reviewed by Darin Adler.

  • runtime/JSActivation.h: Removed virtual keyword.
15:35 Changeset [100821] by darin@chromium.org
  • 15 edits in trunk

2011-10-24 Darin Fisher <darin@chromium.org>

[chromium] Improve fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=70477

Reviewed by Adam Barth.

Move fullscreen entry points from WebView to WebWidget since they are
just about widget geometry.

Delay webkitfullscreenchange event until we know that we have entered
fullscreen mode. This is accomplished by expanding the WebKit APIs to
differentiate will{Enter,Exit} from did{Enter,Exit} state changes.

WebViewImpl is forced to keep a reference to the requested fullscreen
element while we are requesting to enter fullscreen mode. Once in
fullscreen mode, we switch to keeping only a reference to the Frame
containing the fullscreen element, which we drop upon exiting
fullscreen mode.

  • public/WebView.h:
  • public/WebViewClient.h:
  • public/WebWidget.h: (WebKit::WebWidget::willEnterFullScreen): (WebKit::WebWidget::didEnterFullScreen): (WebKit::WebWidget::willExitFullScreen): (WebKit::WebWidget::didExitFullScreen):
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::enterFullScreen): (WebKit::WebWidgetClient::exitFullScreen):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullscreenForNode): (WebKit::ChromeClientImpl::enterFullscreenForNode): (WebKit::ChromeClientImpl::exitFullscreenForNode): (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::willEnterFullScreen): (WebKit::WebViewImpl::didEnterFullScreen): (WebKit::WebViewImpl::willExitFullScreen): (WebKit::WebViewImpl::didExitFullScreen): (WebKit::WebViewImpl::enterFullScreenForElement): (WebKit::WebViewImpl::exitFullScreenForElement):
  • src/WebViewImpl.h:
15:29 Changeset [100820] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Darin Adler.

Fix this for 32_64.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

15:22 Changeset [100819] by xji@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
https://bugs.webkit.org/show_bug.cgi?id=70395

Reviewed by Tony Chang.

Source/WebCore:

This patch fixes the problem in Mac and Chromium Mac.

The existing test fast/dom/rtl-scroll-to-leftmost-and-resize.html seems does not really work in Mac DRT
(the browswer window is not resized). It works in Chromium-Mac. And Chromium-Mac's code
is forked from Mac.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):

LayoutTests:

The test still marks as FAIL in test_expectations because cg-mac might need rebase.

  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
15:16 Changeset [100818] by eae@chromium.org
  • 1670 edits
    1310 copies
    818 deletes in branches/subpixellayout

Merging trunk changes up until 100802 into subpixel branch.

15:09 Changeset [100817] by mrobinson@webkit.org
  • 10 edits in trunk

REGRESSION (r99924): broke 2 pasteboard tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=72131

Reviewed by Tony Chang.

Source/WebCore:

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::clearData): Call clearAll now.
(WebCore::ClipboardGtk::clearAllData): Call clearAllExceptFilenames now.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::clearAllExceptFilenames): Renamed from clear.
(WebCore::DataObjectGtk::clearAll): Added this method which also clear filenames.

  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/PasteboardGtk.cpp: Call clear before setting new clipboard data.

(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::clearClipboardContentsCallback): Use the clearAll method now.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::setSelectionPrimaryClipboardIfNeeded): Use the new clearAll method.

LayoutTests:

  • platform/gtk/Skipped: Unskip passing tests.
15:01 Changeset [100816] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt][Wk2] Add an API test for scroll request from javascript
https://bugs.webkit.org/show_bug.cgi?id=72407

New API test added for QQuickWebView for javascript scroll request
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-11-18
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/tests/html/scroll.html: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

14:52 Changeset [100815] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72761

Mark test as PASS TIMEOUT as it occasionally times out on the bots.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
14:43 WebKit Team edited by michelangelo@webkit.org
(diff)
14:35 Changeset [100814] by timothy@apple.com
  • 1 copy in tags/Safari-534.52.12

New tag.

14:33 Changeset [100813] by timothy@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

14:26 Changeset [100812] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] The exclusions tests are all passing. Remove the
test_expectations.txt entry for them.

  • platform/chromium/test_expectations.txt:
14:24 Changeset [100811] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test fast/events/dropzone-002.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=61625

Test is no longer failing since the end of October.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
14:13 Changeset [100810] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

De-virtualize ExecutableBase::intrinsic
https://bugs.webkit.org/show_bug.cgi?id=72548

Reviewed by Oliver Hunt.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic): Dynamic cast to NativeExecutable. If successful, call intrinsic, otherwise return default value.

  • runtime/Executable.h:
  • runtime/JSCell.h:

(JSC::jsDynamicCast): Add jsDynamicCast that duplicates the functionality of dynamic_cast in C++ but uses ClassInfo
rather than requiring C++ RTTI.

13:52 Changeset [100809] by bdakin@apple.com
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

<rdar://problem/10466170> Regression: Scroll bars disappear and don't come back

Reviewed by Sam Weinig.

Fixing a merge issue. On TOT we use #if USE(SCROLLBAR_PAINTER), but on the branch
it is still #if USE(WK_SCROLLBAR_PAINTER). Also, on the branch, all of the
m_scrollbarPainterController functions go through WebKitSystemInterface instead of
using forward declaration. We should consider merging those changes, but in the
meantime, for this to work, we have to go back to the branch-style.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notityPositionChanged):

13:42 Changeset [100808] by adamk@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaseline chromium expectations after r100800.
Note that previous rebaseline was actually meant for r100786.

Unreviewed gardening.

  • platform/chromium-win/animations/additive-transform-animations-expected.png: Added.
  • platform/chromium-win/animations/additive-transform-animations-expected.txt: Added.
  • platform/chromium/animations/additive-transform-animations-expected.png: Added.
13:39 Changeset [100807] by adamk@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Rebaseline chromium expectations after r100800.

Unreviewed gardening.

  • platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png: Added.
13:26 Changeset [100806] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=66900

Re-adding SNOWLEOPARD flakiness on CG bots that seems to have been
erroneously removed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [100805] by commit-queue@webkit.org
  • 37 edits
    2 adds in trunk

Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

All HTML elements can have the accesskey content attribute set.
Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/BaseButtonInputType.h: Ditto
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::accessKeyAction): Ditto

  • html/BaseCheckableInputType.h: Ditto
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::accessKeyAction): Ditto

  • html/HTMLAnchorElement.h: Ditto
  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLButtonElement.h: Ditto
  • html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
If the element does not have a defined activation behavior, fire a click event at the element.

  • html/HTMLElement.h: Ditto
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLInputElement.h: Ditto
  • html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLabelElement.h: Ditto
  • html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLegendElement.h: Ditto
  • html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::accessKeyAction): Ditto

  • html/HTMLSelectElement.h: Ditto
  • html/HTMLTextAreaElement.h: Ditto
  • html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/InputType.h: Ditto
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::accessKeyAction): Ditto

  • html/RangeInputType.h: Ditto

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
  • fast/forms/access-key.html: Added more test coverage for select and textarea elements.
12:07 Changeset [100804] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72747

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:57 Changeset [100803] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Remove expectation for fast/js/delete-syntax.html, which seems to have
been fixed by http://code.google.com/p/v8/source/detail?r=9993.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:32 Changeset [100802] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Remove IMAGE suppression for css3/images/cross-fade-overflow-position.html
to let me use garden-o-matic for rebaselining.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:20 Changeset [100801] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Infinite recursion in WebCore::RenderInline::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=52144

Reviewed by Tony Chang.

The bug got fixed, landing the test. As I could not test the old test case, it is
landed as-is (apart from making it dumpAsText which was deemed safe).

  • editing/execCommand/infinite-recursion-computeRectForRepaint-expected.txt: Added.
  • editing/execCommand/infinite-recursion-computeRectForRepaint.html: Added.
11:18 Changeset [100800] by simon.fraser@apple.com
  • 4 edits
    3 adds in trunk

Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641
and
<rdar://problem/10314267>

Reviewed by Dean Jackson.

GraphicsLayerCA contains a "linked on or after" check to account for a bug in
Core Animation on SnowLeopard and earlier, which is that CA would apply the list
of animations in reverse order.

Our previous fix was incorrect, because it only adjusted the 'additive' property
of the animation list based on ordering, rather than flipping the entire list.
This change reverses the list of animations before giving them to CA, which fixes
the bug.

Test: animations/additive-transform-animations.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

  • platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Reviewed by Dean Jackson.

Pixel test for a hardware-animated tranform, where order of operations matters.

  • animations/additive-transform-animations-expected.png: Added.
  • animations/additive-transform-animations.html: Added.
  • platform/mac/animations/additive-transform-animations-expected.txt: Added.
11:15 Changeset [100799] by aroben@apple.com
  • 3 edits in trunk/Tools

Ignore an ANGLE leak that is not WebKit's fault

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added ScanFromString to the call stacks to exclude on all OS versions.

11:11 Changeset [100798] by oliver@apple.com
  • 5 edits
    3 adds in branches/safari-534.54-branch

Merge r100514

DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::globalObjectFor):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalObjectFor):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/cross-global-object-inline-global-var-expected.txt: Added.
  • fast/js/cross-global-object-inline-global-var.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

11:08 Changeset [100797] by oliver@apple.com
  • 5 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100391

REGRESSION (r98887): ParserArena and Keywords leaking
https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

  • parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

  • parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

  • runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
11:06 Changeset [100796] by oliver@apple.com
  • 6 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100363

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:03 Changeset [100795] by oliver@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100219

DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

11:02 Changeset [100794] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress IMAGE failures for css3/images/cross-fade-overflow-position.html
Needs rebaseline after r100786.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:00 Changeset [100793] by oliver@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100197

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
10:58 Changeset [100792] by adauria@apple.com
  • 2 edits in trunk/Source/WebKit/mac

bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
https://bugs.webkit.org/show_bug.cgi?id=72568

Reviewed by David Kilzer.

WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
as the return value, which was then cast to a bool and always returned true. This
patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
return value of NO.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldInterruptJavaScript):

10:55 Changeset [100791] by oliver@apple.com
  • 3 edits
    3 adds in branches/safari-534.54-branch

2011-11-18 Oliver Hunt <oliver@apple.com>

Merge r99917

2011-11-09 Filip Pizlo <fpizlo@apple.com>

DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
10:39 Changeset [100790] by aroben@apple.com
  • 3 edits in trunk/Tools

Ignore another Lion-specific leak that is not WebKit's fault

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added SecTransformExecute to the call stacks to exclude.

10:36 Changeset [100789] by igor.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit2

No'am Rosenthal <noam.rosenthal@nokia.com>

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for KeyframeValueList, and modify the TimingFunction ArgumentCoder to
allow encoding const TimingFunctions and not just RefPtr<TimingFunction>.

Reviewed by Simon Hausmann.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
10:24 Changeset [100788] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Added CRASH to expectations for fast/encoding/parser-tests-50.html.
It's only crashing on Snow Leopard, but I didn't want to split the
existing line in two.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:11 Changeset [100787] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Remove duplicate dtoa files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72711

Reviewed by Brent Fulgham.

  • wtf/CMakeLists.txt:
10:06 Changeset [100786] by timothy_horton@apple.com
  • 4 edits
    4 adds in trunk

-webkit-cross-fade rendered incorrectly in overflow divs
https://bugs.webkit.org/show_bug.cgi?id=72693
<rdar://problem/10468564>

Reviewed by Simon Fraser.

Respect the desired source rectangle when rendering the cross-fade.

Test: css3/images/cross-fade-overflow-position.html

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h:

Add a test to make sure that -webkit-cross-fade renders correctly inside overflowed areas.

  • css3/images/cross-fade-overflow-position.html: Added.
  • css3/images/resources/half-circles.svg: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.txt: Added.
09:49 Changeset [100785] by paroga@webkit.org
  • 4 edits in trunk

[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
https://bugs.webkit.org/show_bug.cgi?id=72710

Reviewed by Brent Fulgham.

.:

  • Source/CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:
09:33 Changeset [100784] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for
fast/frames/sandboxed-iframe-parsing-space-characters.html on Mac 10.6
dbg.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
09:05 Changeset [100783] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Accessibility API tests not loading Gtk's accessibility implementation
https://bugs.webkit.org/show_bug.cgi?id=72732

Reviewed by Philippe Normand.

Ensure that the GAIL module is being loaded by avoiding using
gtk_test_init() directly, but a modified version of it.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Use a normal GtkWidget (a
GtkWindow) as the parent container for the webView, instead of
using a dummy webView for that, which was hackish.
(testWebkitAtkSetParentForObject): Use normal GtkWidgets instead
of dummy webViews (a GtkWindow and a GtkButton).
(initializeTestingFramework): New function, identical to
gtk_test_init(), but loading GAIL as the only GTK module.
(main): Use initializeTestingFramework().

08:57 Changeset [100782] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; r100686 broke the EFL build when Geolocation
support is enabled.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-18

  • platform/efl/GeolocationServiceEfl.cpp: Only declare

s_factoryFunction if CLIENT_BASED_GEOLOCATION is off, otherwise it is
also declared in GeolocationService.cpp.

08:43 Changeset [100781] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

[TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperNode::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=72727

TextureMapperNode::computeAllTransforms already has a call to TextureMapperNode::computePerspectiveTransformIfNeeded,
so it does not need to be called again after TextureMapperNode::computeAllTransforms.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingState):

08:38 Changeset [100780] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72631

Add CRASH expectation for fast/filesystem/file-writer-abort.html on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
08:18 Changeset [100779] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Guard for the viewportInteractionEngine as it doesn't always exist.

Reviewed by Antonio Gomes.

The engine is non-existent when the view is configured to use desktop
behavior.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::didFindZoomableArea):

08:03 Changeset [100778] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add test for strange scrollbars with non-integer scaled SVG image
https://bugs.webkit.org/show_bug.cgi?id=43018

Patch by Philip Rogers <pdr@google.com> on 2011-11-18
Reviewed by Nikolas Zimmermann.

  • svg/as-image/resources/green-non-integer-size-rect.svg: Added.
  • svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
  • svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
  • svg/as-image/svg-non-integer-scaled-image.html: Added.
07:47 Changeset [100777] by steveblock@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

Another attempt at rebaselining fast/box-shadow for Chromium Mac 10.5.
It seems the rebaseline tool made a mess of
http://trac.webkit.org/changeset/100742.

Unreviewed gardening.

07:43 Changeset [100776] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add CRASH and TIMEOUT expectations for severla more tests.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:27 Changeset [100775] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation for canvas/philip/tests/2d.imageData.put.unchanged.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:22 Changeset [100774] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
06:58 Changeset [100773] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip another GTK crasher.

  • platform/gtk/Skipped: Skip fast/borders/inline-mask-overlay-image-outset.html
06:56 Changeset [100772] by steveblock@google.com
  • 3 edits
    2 moves
    1 add in trunk/LayoutTests

Rebaseline remaining fast/ tests for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

06:50 Changeset [100771] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Send DidCreateDestination to DownloadProxy when destination has been created
https://bugs.webkit.org/show_bug.cgi?id=72724

Reviewed by Martin Robinson.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Call
didCreateDestination() when destination URI has been successfully
created.

06:48 Changeset [100770] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Cancel current download operation before download object is deleted
https://bugs.webkit.org/show_bug.cgi?id=72721

Reviewed by Martin Robinson.

It fixes a crash in the web process when a download finishes early
due to a failure.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::cancel): Delete current ResourceHandle.
(WebKit::Download::platformInvalidate): If there's a
ResourceHandle active, cancel the download operation and delete
the handle.
(WebKit::Download::platformDidFinish): Delete current ResourceHandle.

06:45 Changeset [100769] by carlosgc@webkit.org
  • 5 edits in trunk/Source

[GTK] Downloads not started by WebView only fail for transport errors
https://bugs.webkit.org/show_bug.cgi?id=72718

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Abort the download with an error if the response contains an
error code. It adds a new test case to the download unit tests.

  • tests/testdownload.c:

(notifyDownloadStatusCallback):
(serverCallback):
(test_webkit_download_not_found):
(main):

  • webkit/webkitdownload.cpp:

(DownloadClient::didReceiveResponse): Check whether http status of
the response is an error code and emit error signal in such case.

Source/WebKit2:

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Check if the http
status of the response is an error code and finish the download
with an error in such case.

06:43 Changeset [100768] by steveblock@google.com
  • 4 edits
    8 moves
    5 adds
    1 delete in trunk/LayoutTests

Rebaseline remaining svg/ tests for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

06:33 Changeset [100767] by caio.oliveira@openbossa.org
  • 6 edits
    6 adds in trunk/Source/WebKit2

[Qt] Support customizing JS alert/confirm/prompt dialogs using QML
https://bugs.webkit.org/show_bug.cgi?id=72319

Reviewed by Simon Hausmann.

Adds alertDialog, confirmDialog and promptDialog properties to QQuickWebView's
privateObject. These are QML components that are created by the webview when the
corresponding function is called in JS.

The dialogs are created in a context that contains a model object, similar to
ListView delegates. The "message" and "defaultValue" parameters are available
in the model object, as well as slots expected to be called by the dialog.

This commit removes the old code for supporting QWidget builtin dialogs. The code
wasn't working properly (closing any dialog was closing the app after QWindow
refactoring in Qt5).

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/alert.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/confirm.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/prompt.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtDialogRunner.cpp: Added.

(QtDialogRunner::QtDialogRunner):
(QtDialogRunner::~QtDialogRunner):
(DialogContextObject::DialogContextObject):
(DialogContextObject::message):
(DialogContextObject::defaultValue):
(DialogContextObject::dismiss):
(DialogContextObject::accept):
(DialogContextObject::reject):
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::createDialog):

  • UIProcess/qt/QtDialogRunner.h: Added.

(QtDialogRunner::wasAccepted):
(QtDialogRunner::result):
(QtDialogRunner::onAccepted):

06:23 Changeset [100766] by steveblock@google.com
  • 1 edit
    6 moves
    3 adds in trunk/LayoutTests

Rebaseline fast/writing-mode for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

06:16 Changeset [100765] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

Fix compilation warning in ComplexTextControllerCoreText.mm
https://bugs.webkit.org/show_bug.cgi?id=72702

Reviewed by Andreas Kling.

No functionality changed, so no new tests.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

06:15 Changeset [100764] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Support wheel event together with resizesToContents

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleWheelEvent):

06:00 Changeset [100763] by yutak@chromium.org
  • 8 edits in trunk

[Qt] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72687

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::defaultHixie76WebSocketProtocolEnabled):
(DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled):
Call WebCore::Settings::setUseHixie76WebSocketProtocol() to switch WebSocket protocols.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • platform/qt/Skipped:

Unskip WebSocket hybi tests. Skip some of them which are known to fail probably due to
a bug in SocketStreamHandleQt implementation.

05:56 Changeset [100762] by hausmann@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Layer violation: WebPopupMenuProxyQtDesktop.cpp uses files from WebKit/qt https://bugs.webkit.org/show_bug.cgi?id=72696

Reviewed by Kenneth Rohde Christiansen.

Implement the WK2 desktop popup by simply subclassing QComboBox and doing the
same thing as QtWebComboBox from WK1 (a few lines of code).

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::eventFilter):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h:
05:52 Changeset [100761] by steveblock@google.com
  • 1 edit
    8 moves
    4 adds in trunk/LayoutTests

Rebaseline fast/repaint for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

05:48 Changeset [100760] by zeno.albisser@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer.
https://bugs.webkit.org/show_bug.cgi?id=72717

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setViewportInteractionEngine):

  • UIProcess/qt/QtWebPageProxy.h:
05:45 Changeset [100759] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Not reviewed: restore front-end compilability via updating externs and JS generator.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/externs.js:

(WebInspector.showPanelForAnchorNavigation):

  • inspector/generate-protocol-externs:
05:42 Changeset [100758] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix popups for select elements.

Reviewed by Tor Arne Vestbø.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::createPopupMenuProxy): Fall back to the "desktop" implementation
for the moment. Better than nothing :)

05:42 Changeset [100757] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed debug build fix

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy): Don't assert on a non-existant
variable.

05:29 Changeset [100756] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: dispatch messages from the front-end to the backend asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=72621

Source/WebCore:

We should align the way we dispatch messages from the front-end to backend across the environments:

  • WebKit has it synchronoulsly
  • Chromium has it asynchronously
  • Remote debugging has it asynchronously

Making it asynchronous made a number of flaky Qt tests pass.

Tests uncovered console agent problem that was also fixed.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearFrontend):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::onTimer):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
(WebCore::InspectorFrontendClientLocal::sendMessageToBackend):

  • inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::performDisconnectFromBackend):

  • src/InspectorFrontendClientImpl.h:

LayoutTests:

Now that dispatching is asynchronous, timeline test needed a fix.

Reviewed by Yury Semikhatsky.

  • inspector/timeline/timeline-script-tag-1.html:
  • platform/qt/Skipped:
05:28 Changeset [100755] by sergio@webkit.org
  • 4 edits in trunk

[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=72707

Reviewed by Philippe Normand.

Tools:

Make new-run-webkit-tests use the right path to locate the test
plugin used by WebKitTestRunner.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

LayoutTests:

Unskipped a test that is passing now.

  • platform/gtk-wk2/Skipped: unskipped plugins/get-url-notify-with-url-that-fails-to-load.html
05:16 Changeset [100754] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Unreviewed build fix: Export QQuickWebPage/Preferences private API
needed for the qml plugin.

  • Source/qtwebkit-export.map:
05:15 Changeset [100753] by steveblock@google.com
  • 3 edits
    3 copies
    11 moves
    2 adds in trunk/LayoutTests

Rebaseline svg/custom for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

04:56 Changeset [100752] by steveblock@google.com
  • 1 edit
    15 moves
    9 adds in trunk/LayoutTests

Rebaseline svg/clip-path for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

04:43 Changeset [100751] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-18
Reviewed by Tony Gentilcore.

Source/WebCore:

Covered by CCLayerTreeHostTest.

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRefreshRate):

  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRefreshRate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):

04:43 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the bots (diff)
04:42 EFLWebKit edited by rakuco@FreeBSD.org
Backout --data-transfer-items from the DRT build parameters as it seems to … (diff)
04:30 Changeset [100750] by steveblock@google.com
  • 15 edits
    14 moves
    1 add in trunk/LayoutTests

[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
https://bugs.webkit.org/show_bug.cgi?id=72478

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-11-18
Reviewed by Dean Jackson.

  • css3/filters/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
04:12 Changeset [100749] by achicu@adobe.com
  • 12 edits in trunk

[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
https://bugs.webkit.org/show_bug.cgi?id=72478

Reviewed by Dean Jackson.

Source/WebCore:

Added parsing and computed style for the mesh rows, columns, mesh box type
(filter-box, border-box, content-box and padding-box) and the detached mode.

Also fixed a case where "custom(none, 10, 10 filter-box)" was incorrectly
treated as "custom(none, 10)".

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilter): Fixed a case where invalid syntax was parsed as correct syntax.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CustomFilterOperation::MeshBoxType):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createCustomFilterOperation):

  • css/CSSValueList.h:

(WebCore::CSSValueListIterator::isPrimitiveValue):

  • platform/graphics/filters/CustomFilterOperation.h:

LayoutTests:

  • css3/filters/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
03:50 Changeset [100748] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Unreviewed build fix: Export QQuickWebViewExperimental private API
that was added since I made the export patch.

  • Source/qtwebkit-export.map:
03:46 Changeset [100747] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Accessibility API tests failing because of using non-WebKit GtkWidgets
https://bugs.webkit.org/show_bug.cgi?id=72708

Reviewed by Xan Lopez.

Do not use non-WebKit GtkWidget's in unit tests, to avoid problems
when GTK's accessibility implementation is not being loaded.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Use a dummy WebKitWebView
widget as the parent container needed for this unit test.
(testWebkitAtkSetParentForObject): Ditto.

03:41 Changeset [100746] by hausmann@webkit.org
  • 7 edits
    1 add in trunk

[Qt] WTR and InjectedBundle should not link statically against JSC/WTF https://bugs.webkit.org/show_bug.cgi?id=72697

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/api.pri: On Linux, use a GNU LD version script to manage the

symbol exports, which includes the public WK1/WK2 API as well as a bunch
of private WTF symbols needed for WTR and the Injected Bundle.

  • Source/qtwebkit-export.map: Added.

Tools:

  • Tools.pro: Make WTR linux only for the moment.
  • WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
  • WebKitTestRunner/Target.pri: Ditto.
  • qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources

with ELF visibility on Linux. Instead we're temporarily using an LD version script.

03:35 Changeset [100745] by hausmann@webkit.org
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Oops, fix ChangeLog text

03:34 Changeset [100744] by hausmann@webkit.org
  • 12 edits
    2 deletes in trunk/Source/WebKit2

[Qt] Removal of QtViewInterface part 3

Reviewed by Kenneth Rohde Christiansen.

Move the remaining forwarded calls from ClientImpl that went through
ViewInterface and then PageProxy or WebView to go straight to
QtWebPageProxy. QtViewInterface is empty now and therefore removed.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::chooseFiles):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(setupPageUiClient):

  • UIProcess/qt/QtViewInterface.cpp: Removed.
  • UIProcess/qt/QtViewInterface.h: Removed.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeStatusText):
(QtWebPageProxy::didMouseMoveOverElement):
(QtWebPageProxy::showContextMenu):
(QtWebPageProxy::hideContextMenu):
(QtWebPageProxy::runJavaScriptAlert):
(QtWebPageProxy::runJavaScriptConfirm):
(QtWebPageProxy::runJavaScriptPrompt):
(QtWebPageProxy::chooseFiles):
(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::didChangeLoadProgress):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::contextMenuItemSelected):

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::hideContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
03:33 Changeset [100743] by kenneth@webkit.org
  • 2 edits in trunk/Tools

[Qt] Change default size of the MiniBrowser

Reviewed by Simon Hausmann.

As we lay out desktop pages using the width of 980, change our default
size to 980x735 so that we are not scaling down by default.

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

03:27 Changeset [100742] by steveblock@google.com
  • 2 edits
    4 adds
    9 deletes in trunk/LayoutTests

Rebaseline fast/box-shadow for Chromium Mac 10.5 after http://crrev.com/110543

Unreviewed gardening.

03:16 Changeset [100741] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] UI process segfaults, when visiblity properties are set while the WebProcess is dead.
https://bugs.webkit.org/show_bug.cgi?id=72699

The drawing area may be null, if the web process has crashed, but not yet recovered.
Always null check against drawing area.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-18
Reviewed by Simon Hausmann.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setDrawingAreaSize):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):

03:07 Changeset [100740] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded include (and ifdef) from V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=72705

Reviewed by Eric Seidel.

Death to ifdefs!

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
03:01 Changeset [100739] by hausmann@webkit.org
  • 8 edits in trunk/Source/WebKit2

[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Move all functions that forwarded from QtWebPageProxy to QtViewInterface and then
to QQuickWebView straight into QtWebPageProxy.

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::isViewWindowActive):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::pageDidRequestScroll):
(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::toolTipChanged):
(QtWebPageProxy::didChangeUrl):
(QtWebPageProxy::didChangeTitle):
(QtWebPageProxy::loadDidBegin):
(QtWebPageProxy::loadDidCommit):
(QtWebPageProxy::loadDidSucceed):
(QtWebPageProxy::loadDidFail):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:
02:54 Changeset [100738] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Rebaseline acid3.html for Chromium Mac 10.5

The image contains the text 'YOU SHOULD NOT SEE THIS AT ALL', but so do
all other Chromium expected results for this test, so I'm guessing this
is expected.

Unreviewed gardening.

02:37 Changeset [100737] by abarth@webkit.org
  • 3 edits
    6 moves in trunk/Source/WebCore

Move some mediastream related files into the mediastream directory
https://bugs.webkit.org/show_bug.cgi?id=72695

Reviewed by Eric Seidel.

Just moving the files to the proper directory.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/NavigatorUserMediaError.h: Renamed from Source/WebCore/page/NavigatorUserMediaError.h.

(WebCore::NavigatorUserMediaError::create):
(WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
(WebCore::NavigatorUserMediaError::code):
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):

  • mediastream/NavigatorUserMediaError.idl: Renamed from Source/WebCore/page/NavigatorUserMediaError.idl.
  • mediastream/NavigatorUserMediaErrorCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.h.

(WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):

  • mediastream/NavigatorUserMediaErrorCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.idl.
  • mediastream/NavigatorUserMediaSuccessCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.h.

(WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):

  • mediastream/NavigatorUserMediaSuccessCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl.
02:27 Changeset [100736] by hausmann@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Replace functions of QtViewInterface that forward to QQuickWebPage with direct
usage of QQuickWebPage. Also removed some dead code.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::sceneGraphUpdateQueue):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::isVisible):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setViewNeedsDisplay):
(QtWebPageProxy::viewSize):
(QtWebPageProxy::isViewFocused):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::didRelaunchProcess):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::qmlWebPage):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
02:22 Changeset [100735] by caseq@chromium.org
  • 8 edits in trunk

Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon
https://bugs.webkit.org/show_bug.cgi?id=45955

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
(injectedExtensionAPI):
(injectedExtensionAPI.ButtonImpl.prototype.update):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.get statusBarItems):
(WebInspector.ExtensionPanel.prototype.addStatusBarItem):
(WebInspector.ExtensionButton):
(WebInspector.ExtensionButton.prototype.update):
(WebInspector.ExtensionButton.prototype._onClicked):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyButtonClicked):
(WebInspector.ExtensionServer.prototype._onCreateStatusBarButton):
(WebInspector.ExtensionServer.prototype._onUpdateButton):
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

  • inspector/front-end/inspector.css:

(button.status-bar-item.extension):

LayoutTests:

  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
02:05 Changeset [100734] by commit-queue@webkit.org
  • 5 edits
    1 move
    1 delete in trunk/Source/WebCore

MediaStream API: Merging the PeerConnectionHandler.h files
https://bugs.webkit.org/show_bug.cgi?id=72611

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-18
Reviewed by Adam Barth.

No actual code changes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/mediastream/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/chromium/PeerConnectionHandler.h.
  • platform/mediastream/gstreamer/PeerConnectionHandler.h: Removed.
01:04 Changeset [100733] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark media/audio-garbage-collect.html flaky on GTK.

  • platform/gtk/test_expectations.txt:
00:36 Changeset [100732] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=72694

  • platform/qt/Skipped: Skip fast/canvas/canvas-lineWidth.html until fix.
00:21 Changeset [100731] by hausmann@webkit.org
  • 18 edits in trunk/Source

[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places https://bugs.webkit.org/show_bug.cgi?id=72597

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved code that queries the third party cookie policy from QWebSettings
out of WebCore. Instead NetworkingContext has now the interface that allows
delegating the functionality into WebKit/qt.

In order to do that we need to pass the NetworkingContext around, which is used to
retrieve the cookie jar and the originating frame object pointer.

  • platform/network/NetworkingContext.h: Add interface.
  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Pass NetworkingContext to ResourceRequest::toNetworkRequest.
(WebCore::QNetworkReplyHandler::redirect): Ditto.

  • platform/network/qt/ResourceRequest.h: Replaced originatingObject parameter with NetworkingContext, which can

also provide the same plus more (cookie jar, policy callback).

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest): Ditto.

  • platform/qt/CookieJarQt.cpp: Simplify to use NetworkingContext to get cookie jar and

call new thirdPartyCookiePolicyPermits API that takes the context as parameter.
(WebCore::networkingContext):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):

  • platform/qt/ThirdPartyCookiesQt.cpp: Replace up-casting to QWebFrame and use of QWebSettings

with useage of NetworkingContext.
(WebCore::thirdPartyCookiePolicyPermits):

  • platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

Implemented NetworkingContext::thirdPartyCookiePolicyPermission, which queries
QWebSettings.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows): Adapt to the
changed thirdPartyCookiePolicyPermits WebCore API that operates on a networking context.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Pass networking
context to ResourceRequest::toNetworkRequest.
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
(WebCore::FrameLoaderClientQt::startDownload): Ditto.

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::thirdPartyCookiePolicyPermission): Implement.

  • WebCoreSupport/FrameNetworkingContextQt.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::thirdPartyCookiePolicy): Adapt to QtDRTSupport API change.

Source/WebKit2:

Stub implementation of new NetworkingContext::thirdPartyCookiePolicyPermission
API.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:

11/17/11:

23:42 Changeset [100730] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Unskip tests after the fix on Qt.

  • platform/qt/Skipped:
23:41 Changeset [100729] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Fixed StringImpl::foldCase by adding return in the case we need to handle
folding of 8 bit strings with Latin-1 characters.

Fixed case where StringImpl::replace was using a char temp instead of an
LChar temp.

Because of the second change, I changed other uses of char or
unsigned char to LChar.

Patch by Michael Saboff <msaboff@apple.com> on 2011-11-17
Reviewed by Zoltan Herczeg.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::replace):

23:27 Changeset [100728] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
https://bugs.webkit.org/show_bug.cgi?id=71997

Reviewed by Dan Bernstein.

The cause is a null dereference of a fontData that is stored in
ComplexTextRun. The fontData is initialized by using the
fontCache, but it could be null when the font is in fallback
list. The reason a font from the fallback list might not be in the
font Cache is that it may be a web font. Before looking up the
fontCache, try to see whether the font is in the fallback list.

No new tests. We don't have webfonts that can produce the problem.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): See fallback list first, then lookup cache.

22:57 Changeset [100727] by commit-queue@webkit.org
  • 13 edits in trunk

Remove initProgressEvent method
https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

  • dom/ProgressEvent.cpp:
  • dom/ProgressEvent.h:
  • dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
22:14 Changeset [100726] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

[EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the
EflKeyboardUtilities.cpp to use in the WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62451

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

The keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() were static functions
in the PlatformKeyboardEventEfl.cpp. But they are also needed in the WebKit2 EFL port, so I
moved them to the separated file - EflKeyboardUtilities.cpp.

  • PlatformEfl.cmake:
  • platform/efl/EflKeyboardUtilities.cpp: Copied from Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp.

(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):
(WebCore::keyIdentifierForEvasKeyName):
(WebCore::windowsKeyCodeForEvasKeyName):

  • platform/efl/EflKeyboardUtilities.h: Added.
  • platform/efl/PlatformKeyboardEventEfl.cpp:
22:09 Changeset [100725] by mrobinson@webkit.org
  • 7 edits in trunk/Source

[GTK] The process freezes when you right click on windowless Flash
https://bugs.webkit.org/show_bug.cgi?id=69123

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. I tried to create a layout test that exercised this
issue, but it appears that EventSender clicks do not trigger
it. This is covered by the manual tests containing Flash.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks): Always activate the
windowless Flash quirk if on x86_64 and X11.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handleMouseEvent): Avoid sending right-click
events if we have the quirk.

Source/WebKit2:

Add a new plugin quirk for dealing with right-clicking on
windowless Flash on x86_64 machines. This already exists for
WebKit1.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks): If the plugin is
Flash and we are on x86_64, then disable sending right-clicking
events while in windowless mode.

  • Shared/Plugins/PluginQuirks.h: Add the new quirk.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent): If the quirk
is active don't send right click events.

21:52 Changeset [100724] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Add matrix list to reuse tile matrix for each different zoom level.
https://bugs.webkit.org/show_bug.cgi?id=68595

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

Add matrix list to keep each tile matrix corresponding to each different zoom level when zoom level is changed.
Then backing store can reuse tile matrix by getting it from this matrix list.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_new):

  • ewk/ewk_tiled_matrix.h:
21:47 Changeset [100723] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: clear fixme in generator script
https://bugs.webkit.org/show_bug.cgi?id=71372

Remove unnecessary field name map and update license year number.

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-11-17
Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.py:
21:43 Changeset [100722] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Clean up the use of DATA_DIR in the buildsystem
https://bugs.webkit.org/show_bug.cgi?id=72681

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

.:

  • Source/cmake/OptionsEfl.cmake: Rename DATA_DIR to DATA_INSTALL_DIR

and add it to the cache; add a variable with the path of the generated
theme and remove the -DDATA_DIR definition, it was moved to
PlatformEFL.cmake in WebCore.

Source/WebCore:

Add the -DDATA_DIR definition here instead of defining it globally in
OptionsEfl.cmake, as WebCore is the only place which needs it.

No new tests, this is a buildsystem change.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Instead of messing with BUILD_DATA_DIR and PARENT_SCOPE, just use
THEME_BINARY_DIR as defined in OptionsEfl.cmake.

  • CMakeListsEfl.txt:

Tools:

Instead of adding -DDATA_DIR in all scopes, only define it in
WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
it.

We can then define DATA_DIR to the generated theme directory for
EWebLauncher, since it's what we want here.

  • CMakeListsEfl.txt:
21:41 Changeset [100721] by adamk@chromium.org
  • 6 edits
    2 adds in trunk

Move JS recursion counter from V8Proxy to V8BindingPerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=72645

Reviewed by Adam Barth.

Source/WebCore:

With the JS recursion level stored as a member of V8Proxy, it's tied
to a frame. But this is incorrect, as there's no reason that a JS call
stack need be restricted to a single frame (see my new test case for
an example of code going across frames).

In order to get the correct accounting of JS recursion level, per-Isolate
is the right granularity (per dslomov), which is what this patch accomplishes.

Test: storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::recursionLevel):
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel):
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

  • bindings/v8/V8Proxy.cpp:

(WebCore::incrementRecursionLevel):
(WebCore::decrementRecursionLevel):
(WebCore::recursionLevel):
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::didLeaveScriptContext):

  • bindings/v8/V8Proxy.h:

LayoutTests:

Added tests to exercise new timing of call to V8Proxy::didLeaveScriptContext().

  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt: Added.
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Added.
21:38 Changeset [100720] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Move platform includes last in DRT's include directories.
https://bugs.webkit.org/show_bug.cgi?id=72684

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

This is the first step in fixing the build when a platform include (in
this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
is included instead of WebKit's.

  • DumpRenderTree/efl/CMakeLists.txt:
21:30 Changeset [100719] by pkasting@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] acid3.html didn't actually get rebaselined like I wanted.

Unreviewed, gardening.

  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png:
  • platform/chromium/test_expectations.txt:
21:25 Changeset [100718] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[chromium] Font::drawComplexText can not draw a segment of text run
https://bugs.webkit.org/show_bug.cgi?id=72095

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-11-17
Reviewed by Adam Barth.

Source/WebCore:

drawComplexText() should respect the 'from' and 'to' arguments.
Drawing the whole text run may result in text overlapping.

Test: platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::glyphsForRange):

  • platform/graphics/chromium/ComplexTextControllerLinux.h:
  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::drawComplexText):

LayoutTests:

  • platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.png: Added.
  • platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html: Added.
21:02 Changeset [100717] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix broken expectation.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
20:58 Changeset [100716] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Unique SecurityOrigins shouldn't remember their old schemes and hosts
https://bugs.webkit.org/show_bug.cgi?id=71745

Reviewed by Darin Adler.

This is the final step in this series of patches.

This patch removes the forceUnique flag from SecurityOrigin::create.
Now, we create unique origins without passing in the document's URL,
preventing information from the document's URL from leaking into the
unique origin.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getOriginsWithCache):

  • Update this callsite to use createFromString, which does exactly what this code is doing manually.
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create):

  • page/SecurityOrigin.h:
20:55 Changeset [100715] by scheib@chromium.org
  • 7 edits in trunk/Source

Pointer Lock: Page Settings unecessary
https://bugs.webkit.org/show_bug.cgi?id=72662

Reviewed by Darin Fisher.

Source/WebCore:

No new tests.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
20:30 Changeset [100714] by cevans@google.com
  • 2 edits
    6 copies in branches/chromium/912

Merge 99744
BUG=99732

20:23 Changeset [100713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Don't clamp minimumPageScaleFactor when doc width is zero
https://bugs.webkit.org/show_bug.cgi?id=72679

Patch by Alexandre Elias <aelias@google.com> on 2011-11-17
Reviewed by James Robinson.

For a brief period during initialization, the document width can be
zero. In that situation, don't try to limit minimumPageScaleFactor
to the document size.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactorLimits):

20:13 Changeset [100712] by pkasting@chromium.org
  • 9 edits
    20 adds
    7 deletes in trunk/LayoutTests

[chromium] Try to rebaseline more tests.

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
20:12 Changeset [100711] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/912

Merge 100502
BUG=102359
Review URL: http://codereview.chromium.org/8598007

20:09 Changeset [100710] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Disable incremental uploading in threaded compositing path
https://bugs.webkit.org/show_bug.cgi?id=72669

Patch by James Robinson <jamesr@chromium.org> on 2011-11-17
Reviewed by Kenneth Russell.

Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
updates in an atomic fashion.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

18:51 Changeset [100709] by pkasting@chromium.org
  • 4 edits
    1 copy in trunk/LayoutTests

[chromium] Attempt to rebaseline a test after http://crrev.com/110053 .

Unreviewed, gardening.

  • platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Copied from platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium/test_expectations.txt:
18:08 Changeset [100708] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode
https://bugs.webkit.org/show_bug.cgi?id=71638

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(TestHooks::animateAndLayout):
(MockLayerTreeHostClient::animateAndLayout):
(CCLayerTreeHostTest::postSetNeedsAnimateToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::CCLayerTreeHostTestSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::beginTest):
(CCLayerTreeHostTestSetNeedsAnimate::animateAndLayout):
(CCLayerTreeHostTestSetNeedsAnimate::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsAnimate::afterTest):

17:46 Changeset [100707] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark some inspector tests as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=72651

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
17:46 Changeset [100706] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove bogus ASSERT.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

17:28 Changeset [100705] by pkasting@chromium.org
  • 3 edits
    2 copies in trunk

Unreviewed, rolling out r100698.
http://trac.webkit.org/changeset/100698
https://bugs.webkit.org/show_bug.cgi?id=72239

This change wasn't the problem either.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

  • accessibility/loading-iframe-sends-notification.html: Copied from LayoutTests/accessibility/loading-iframe-sends-notification.html.
  • platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt.
17:21 Changeset [100704] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Don't include internal GTK headers so we build with GTK_DISABLE_SINGLE_INCLUDES

https://bugs.webkit.org/show_bug.cgi?id=72653

Patch by Elliot Glaysher <erg@chromium.org> on 2011-11-17
Reviewed by James Robinson.

  • src/gtk/WebInputEventFactory.cpp:

(WebKit::gdkStateToWebEventModifiers): Remove a
GTK_CHECK_VERSION that will always be true, as the oldest
libgtk we support is 2.18.

17:18 Changeset [100703] by mrowe@apple.com
  • 8 edits in trunk/Source

Roll out r100668 until I can work out why we're using such an ancient version of Xcode on our SnowLeopard bots.

16:48 Changeset [100702] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Calls to paintContentsIfDirty() and updateCompositorResources() should be balanced.
https://bugs.webkit.org/show_bug.cgi?id=72630

Patch by David Reveman <reveman@chromium.org> on 2011-11-17
Reviewed by James Robinson.

Source/WebCore:

Layer property changes during paintContent() can leave the layer
in an invalid state as paintContentsIfDirty() has been called
without a matching updateCompositorResources() call. Removing
conditionals around these calls ensure they are balanced.

This patch is tested by the following unit test:

  • CCLayerTreeHostTestOpacityChange.runMultiThread
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Add test that check if calls to paintContentsIfDirty() and
updateCompositorResources() are balanced when layer opacity
changes during paintContent().

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::layerTreeHost):
(WTF::TestOpacityChangeLayerDelegate::TestOpacityChangeLayerDelegate):
(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::TestOpacityChangeLayerDelegate::drawsContent):
(WTF::TestOpacityChangeLayerDelegate::preserves3D):
(WTF::TestOpacityChangeLayerDelegate::notifySyncRequired):
(WTF::ContentLayerChromiumWithUpdateTracking::create):
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::updateCount):
(WTF::ContentLayerChromiumWithUpdateTracking::resetUpdateCount):
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::updateCompositorResources):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::CCLayerTreeHostTestOpacityChange):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestOpacityChange::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::TEST_F):

16:47 Changeset [100701] by paroga@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[CMake] Move FAST_MALLOC specific lines from Platform*.cmake to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72644

Reviewed by Brent Fulgham.

All ports need to do the same determination about fast malloc. Move the CMake code from
platform specific files into the generic one, so that additional ports can reuse it.

  • wtf/CMakeLists.txt:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformWinCE.cmake:
16:46 Changeset [100700] by rniwa@webkit.org
  • 3 edits in trunk/Tools

fuzzy_match doesn't recognize "Dan B" or "hyatt"
https://bugs.webkit.org/show_bug.cgi?id=72636

Reviewed by Eric Seidel.

Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
and user names of email addreses such as rniwa in rniwa@webkit.org.

Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
16:39 Changeset [100699] by eric@webkit.org
  • 3 edits in trunk/Tools

Remove support for running check-webkit-style w/o a webkit checkout
https://bugs.webkit.org/show_bug.cgi?id=72678

Reviewed by Adam Barth.

After talking to Dave Levin we've decided to remove this
code. I know of no users of check-webkit-style w/o a webkit checkout
and this needlessly adds complexity.

  • Scripts/webkitpy/style/main.py:
16:27 Changeset [100698] by pkasting@chromium.org
  • 3 edits
    2 deletes in trunk

Source/WebCore: Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
https://bugs.webkit.org/show_bug.cgi?id=72676

Patch by Adam Barth <abarth@webkit.org> on 2011-11-17
Reviewed by Eric Seidel.

It looks like this cargo-cult started with initDNSPrefetch being hacked
into setSecurityOrigin. I've removed this hack along with the
copy/paste code.

  • dom/DOMImplementation.cpp:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::open):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):

  • dom/Document.h:
  • xml/XSLTProcessor.cpp:

LayoutTests: Unreviewed, rolling out r100584.
http://trac.webkit.org/changeset/100584
https://bugs.webkit.org/show_bug.cgi?id=72239

See if this change caused Linux dbg crashes.

  • accessibility/loading-iframe-sends-notification.html: Removed.
  • platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Removed.
16:23 Changeset [100697] by eric@webkit.org
  • 7 edits in trunk/Tools

Remove more direct uses of os.path
https://bugs.webkit.org/show_bug.cgi?id=72677

Reviewed by Adam Barth.

Remove more uses of os.path, including refactoring
CommitterValidator to use a Host object instead of
manual hacks to emulate what SCM and FileSystem provide.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/config/committervalidator.py:
  • Scripts/webkitpy/common/config/committervalidator_unittest.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
    • Turns out none of our unittests actually looked at this path. now I've made it be a valid path.
  • Scripts/webkitpy/tool/bot/feeders.py:
  • Scripts/webkitpy/tool/commands/queues.py:
16:20 Changeset [100696] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
https://bugs.webkit.org/show_bug.cgi?id=72676

Reviewed by Eric Seidel.

It looks like this cargo-cult started with initDNSPrefetch being hacked
into setSecurityOrigin. I've removed this hack along with the
copy/paste code.

  • dom/DOMImplementation.cpp:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::open):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):

  • dom/Document.h:
  • xml/XSLTProcessor.cpp:
16:11 Changeset [100695] by pkasting@chromium.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r100676.
http://trac.webkit.org/changeset/100676
https://bugs.webkit.org/show_bug.cgi?id=72393

Looks like r100572 was not the source of the crashes.

Source/WebCore:

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/v8/ScriptDebugServer.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getCapabilities):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
15:55 Changeset [100694] by eric@webkit.org
  • 4 edits in trunk/Tools

Teach TextFileReader about FileSystem
https://bugs.webkit.org/show_bug.cgi?id=72673

Reviewed by Adam Barth.

Unfortunately TextFileReader doesn't use FileSystem
everywhere yet, so we can't move the unittests to
using MockFileSystem, but we're close.

  • Scripts/webkitpy/style/filereader.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
  • Scripts/webkitpy/style/main.py:
15:53 Changeset [100693] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Absolute child is not repainted when parent opacity changes
https://bugs.webkit.org/show_bug.cgi?id=68777

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-11-17
Reviewed by Simon Fraser.

Source/WebCore:

First time when we change opacity for parent we don't have layer, so
diff=StyleDifferenceRepaint is used instead of diff=StyleDifferenceRepaintLayer.
Layer is created later, in styleDidChange().
So, when we recalculate later diff, we now check for diff=StyleDifferenceRepaintLayer and
performs repaintIncludingDescendants().

Test: fast/layers/layer-absolute-parent-opacity.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle): Call repaintIncludingDescendants() instead of repaint().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Add ContextSensitivePropertyOpacity when change opacity.

LayoutTests:

  • fast/layers/layer-absolute-parent-opacity-expected.png: Added.
  • fast/layers/layer-absolute-parent-opacity-expected.txt: Added.
  • fast/layers/layer-absolute-parent-opacity.html: Added.
15:35 Changeset [100692] by japhet@chromium.org
  • 2 edits in trunk/Source/WebCore

r100311 dropped a RefPtr that is very
helpful. Add it back.
https://bugs.webkit.org/show_bug.cgi?id=72647

Reviewed by Adam Barth.

http/tests/misc/xslt-bad-import.html should
stop crashing in full chromium builds.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadDone):

15:33 Changeset [100691] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactor SecurityOrigin::create to be easier to understand
https://bugs.webkit.org/show_bug.cgi?id=72342

Reviewed by Eric Seidel.

Over time, the SecurityOrigin constructor has grown a bit out of
control. This patch attempts to separate the different concerns into
free functions. The general approach is to put more logic in the
"create" function and introduce a simple constructor for unique
origins.

This patch shouldn't change any behavior.

  • page/SecurityOrigin.cpp:

(WebCore::schemeRequiresAuthority):
(WebCore::shouldUseInnerURL):
(WebCore::extractInnerURL):
(WebCore::isDirectory):
(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):
(WebCore::SecurityOrigin::databaseIdentifier):

  • page/SecurityOrigin.h:
15:27 Changeset [100690] by enne@google.com
  • 9 edits
    4 adds
    11 deletes in trunk/LayoutTests

[chromium] Unreviewed, rebaseline tests after r100545.

  • platform/chromium-cg-mac/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:22 Changeset [100689] by eric@webkit.org
  • 5 edits in trunk/Tools

Give check-webkit-style a Host
https://bugs.webkit.org/show_bug.cgi?id=72670

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
    • We don't run these unittests, but this one was looking for the wrong exception.
  • Scripts/webkitpy/style/main.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
    • This was create a new scm object even though it already had one?
15:22 Changeset [100688] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed - skipping accessibility/loading-iframe-sends-notification.html
on Mac until bug 72624 is resolved.

15:19 Changeset [100687] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Patch by Tim Horton <hortont424@gmail.com> on 2011-11-17
Reviewed by Simon Fraser.

Fix fast/css/getComputedStyle/computed-style-cross-fade.html to use the "dummy" protocol for its
images, so that we don't have loading errors.

Unskip the test on Qt.

Remove the (now) unnecessary Gtk baselines.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
  • fast/css/getComputedStyle/computed-style-cross-fade.html:
  • platform/gtk/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Removed.
  • platform/qt/Skipped:
15:14 Changeset [100686] by paroga@webkit.org
  • 4 edits in trunk

[CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h
https://bugs.webkit.org/show_bug.cgi?id=72643

Reviewed by Brent Fulgham.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
15:05 Changeset [100685] by knorton@google.com
  • 3 edits in trunk

Several void functions in FrameView and RenderObject actually return values.
https://bugs.webkit.org/show_bug.cgi?id=72640

Reviewed by Adam Barth.

  • ../../Source/WebCore/page/FrameView.cpp:
  • ../../Source/WebCore/rendering/RenderObject.cpp:
15:02 Changeset [100684] by eric@webkit.org
  • 4 edits in trunk/Tools

Move check-webkit-style change_directory code to more modern mocks
https://bugs.webkit.org/show_bug.cgi?id=72664

Reviewed by Adam Barth.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/main.py:
  • Scripts/webkitpy/style/main_unittest.py:
15:01 Changeset [100683] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] enable ref tests
https://bugs.webkit.org/show_bug.cgi?id=72601

Re-enable ref tests. Run the driver under evenly numbered display if performing
pixel tests or under oddly numbered display otherwise. This prevents the ref tests
being run in an already used Xvfb instance if pixel tests are disabled.

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-17
Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None

after the process is killed

14:51 Changeset [100682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix minor style nit in CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=71070

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-17
Reviewed by James Robinson.

Fixes if-statements on several settors to follow WebKit
conventions. Existing CCLayerImplTest unit tests already cover
this change.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBounds):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::setAnchorPoint):
(WebCore::CCLayerImpl::setAnchorPointZ):
(WebCore::CCLayerImpl::setBackgroundColor):
(WebCore::CCLayerImpl::setMasksToBounds):
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setPosition):
(WebCore::CCLayerImpl::setPreserves3D):
(WebCore::CCLayerImpl::setZoomAnimatorTransform):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::setDebugBorderWidth):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::setScrollPosition):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::setScaleDelta):
(WebCore::CCLayerImpl::setDoubleSided):

14:49 Changeset [100681] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=72416

Added code to release _cache_event_source and _timer_event_source
after they are canceled. Also added defensive code to
clean up the _timer_event_source in uninstall().

Reviewed by Geoffrey Garen.

No new tests, fixing leaks caught by leaks bot.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOff):

14:49 Changeset [100680] by igor.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Fix TransformOperation serialization
https://bugs.webkit.org/show_bug.cgi?id=72625

SimpleArgumentCoder can encode and decode just POD types. And according the
ISO/IEC 14882, POD types does not have virtual methods, however TransformOperation
has pure virtual methods.

This patch fixes TransformOperation subclass serialization.

Reviewed by Noam Rosenthal.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
(CoreIPC::encodeOperation):
(CoreIPC::decodeOperation):

  • Shared/WebCoreArgumentCoders.h:
14:36 Changeset [100679] by leviw@chromium.org
  • 12 edits in branches/subpixellayout/Source/WebCore

Correcting MathML painting to use integers and rounding MouseRelatedEvent's offsetX and offsetY results.

14:34 Changeset [100678] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Tools

Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
https://bugs.webkit.org/show_bug.cgi?id=72620

Reviewed by David Levin.

Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
adding the suffix the cpp file. One example of false positive
https://bugs.webkit.org/show_bug.cgi?id=72319#c12.

  • Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its

basename contains the cpp's basename.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
14:34 Changeset [100677] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from positioned generated content under run-in
https://bugs.webkit.org/show_bug.cgi?id=70456

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-17
Reviewed by David Hyatt.

Source/WebCore:

Modified handling of run-in children to clear generated children
before removing the parent from the render tree. This caused problems
with absolute positioned children being not properly removed from the
positioned object list of the RenderView.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

Layout test for crash condition.

  • fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.html: Added
  • fast/css-generated-content/positioned-generated-content-under-run-in-crash.html: Added
14:32 Changeset [100676] by pkasting@chromium.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r100572.
https://bugs.webkit.org/show_bug.cgi?id=72393
https://bugs.webkit.org/show_bug.cgi?id=72651

May have caused seg faults on Chromium Linux dbg bot.

Source/WebCore:

  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):

  • bindings/v8/ScriptDebugServer.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
14:27 Changeset [100675] by eric@webkit.org
  • 3 edits in trunk/Tools

Move check-webkit-style's guts into webkitpy/style/main.py
https://bugs.webkit.org/show_bug.cgi?id=72657

Reviewed by Adam Barth.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/main.py:
14:13 Changeset [100674] by eric@webkit.org
  • 13 edits in trunk/Tools

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment, just like ORWT did.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
14:08 Changeset [100673] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
https://bugs.webkit.org/show_bug.cgi?id=72615

Reviewed by James Robinson.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
14:04 Changeset [100672] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add finalizer to JSActivation
https://bugs.webkit.org/show_bug.cgi?id=72575

Reviewed by Geoffrey Garen.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::finishCreation): Attach finalize function to objects during creation.
(JSC::JSActivation::finalize):

  • runtime/JSActivation.h: Replaced virtual destructor with static finalize function.
14:03 Changeset [100671] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

13:57 Changeset [100670] by commit-queue@webkit.org
  • 3 edits
    441 deletes in trunk

Unreviewed, rolling out r100652.
http://trac.webkit.org/changeset/100652
https://bugs.webkit.org/show_bug.cgi?id=72648

"Caused outline-offset-min-assert.html to assert on debug
builds" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-17

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

  • css2.1/20110323/outline-color-001.htm: Removed.
  • css2.1/20110323/outline-color-002.htm: Removed.
  • css2.1/20110323/outline-color-003.htm: Removed.
  • css2.1/20110323/outline-color-004.htm: Removed.
  • css2.1/20110323/outline-color-005.htm: Removed.
  • css2.1/20110323/outline-color-006.htm: Removed.
  • css2.1/20110323/outline-color-007.htm: Removed.
  • css2.1/20110323/outline-color-008.htm: Removed.
  • css2.1/20110323/outline-color-009.htm: Removed.
  • css2.1/20110323/outline-color-010.htm: Removed.
  • css2.1/20110323/outline-color-011.htm: Removed.
  • css2.1/20110323/outline-color-012.htm: Removed.
  • css2.1/20110323/outline-color-013.htm: Removed.
  • css2.1/20110323/outline-color-014.htm: Removed.
  • css2.1/20110323/outline-color-015.htm: Removed.
  • css2.1/20110323/outline-color-016.htm: Removed.
  • css2.1/20110323/outline-color-017.htm: Removed.
  • css2.1/20110323/outline-color-018.htm: Removed.
  • css2.1/20110323/outline-color-019.htm: Removed.
  • css2.1/20110323/outline-color-020.htm: Removed.
  • css2.1/20110323/outline-color-021.htm: Removed.
  • css2.1/20110323/outline-color-022.htm: Removed.
  • css2.1/20110323/outline-color-023.htm: Removed.
  • css2.1/20110323/outline-color-024.htm: Removed.
  • css2.1/20110323/outline-color-025.htm: Removed.
  • css2.1/20110323/outline-color-026.htm: Removed.
  • css2.1/20110323/outline-color-027.htm: Removed.
  • css2.1/20110323/outline-color-028.htm: Removed.
  • css2.1/20110323/outline-color-029.htm: Removed.
  • css2.1/20110323/outline-color-030.htm: Removed.
  • css2.1/20110323/outline-color-031.htm: Removed.
  • css2.1/20110323/outline-color-032.htm: Removed.
  • css2.1/20110323/outline-color-033.htm: Removed.
  • css2.1/20110323/outline-color-034.htm: Removed.
  • css2.1/20110323/outline-color-035.htm: Removed.
  • css2.1/20110323/outline-color-036.htm: Removed.
  • css2.1/20110323/outline-color-037.htm: Removed.
  • css2.1/20110323/outline-color-038.htm: Removed.
  • css2.1/20110323/outline-color-039.htm: Removed.
  • css2.1/20110323/outline-color-040.htm: Removed.
  • css2.1/20110323/outline-color-041.htm: Removed.
  • css2.1/20110323/outline-color-042.htm: Removed.
  • css2.1/20110323/outline-color-043.htm: Removed.
  • css2.1/20110323/outline-color-044.htm: Removed.
  • css2.1/20110323/outline-color-045.htm: Removed.
  • css2.1/20110323/outline-color-046.htm: Removed.
  • css2.1/20110323/outline-color-047.htm: Removed.
  • css2.1/20110323/outline-color-048.htm: Removed.
  • css2.1/20110323/outline-color-049.htm: Removed.
  • css2.1/20110323/outline-color-050.htm: Removed.
  • css2.1/20110323/outline-color-051.htm: Removed.
  • css2.1/20110323/outline-color-052.htm: Removed.
  • css2.1/20110323/outline-color-053.htm: Removed.
  • css2.1/20110323/outline-color-054.htm: Removed.
  • css2.1/20110323/outline-color-055.htm: Removed.
  • css2.1/20110323/outline-color-056.htm: Removed.
  • css2.1/20110323/outline-color-057.htm: Removed.
  • css2.1/20110323/outline-color-058.htm: Removed.
  • css2.1/20110323/outline-color-059.htm: Removed.
  • css2.1/20110323/outline-color-060.htm: Removed.
  • css2.1/20110323/outline-color-061.htm: Removed.
  • css2.1/20110323/outline-color-062.htm: Removed.
  • css2.1/20110323/outline-color-063.htm: Removed.
  • css2.1/20110323/outline-color-064.htm: Removed.
  • css2.1/20110323/outline-color-065.htm: Removed.
  • css2.1/20110323/outline-color-066.htm: Removed.
  • css2.1/20110323/outline-color-067.htm: Removed.
  • css2.1/20110323/outline-color-068.htm: Removed.
  • css2.1/20110323/outline-color-069.htm: Removed.
  • css2.1/20110323/outline-color-070.htm: Removed.
  • css2.1/20110323/outline-color-071.htm: Removed.
  • css2.1/20110323/outline-color-072.htm: Removed.
  • css2.1/20110323/outline-color-073.htm: Removed.
  • css2.1/20110323/outline-color-074.htm: Removed.
  • css2.1/20110323/outline-color-075.htm: Removed.
  • css2.1/20110323/outline-color-076.htm: Removed.
  • css2.1/20110323/outline-color-077.htm: Removed.
  • css2.1/20110323/outline-color-078.htm: Removed.
  • css2.1/20110323/outline-color-079.htm: Removed.
  • css2.1/20110323/outline-color-080.htm: Removed.
  • css2.1/20110323/outline-color-081.htm: Removed.
  • css2.1/20110323/outline-color-082.htm: Removed.
  • css2.1/20110323/outline-color-083.htm: Removed.
  • css2.1/20110323/outline-color-084.htm: Removed.
  • css2.1/20110323/outline-color-085.htm: Removed.
  • css2.1/20110323/outline-color-086.htm: Removed.
  • css2.1/20110323/outline-color-087.htm: Removed.
  • css2.1/20110323/outline-color-088.htm: Removed.
  • css2.1/20110323/outline-color-089.htm: Removed.
  • css2.1/20110323/outline-color-090.htm: Removed.
  • css2.1/20110323/outline-color-091.htm: Removed.
  • css2.1/20110323/outline-color-092.htm: Removed.
  • css2.1/20110323/outline-color-093.htm: Removed.
  • css2.1/20110323/outline-color-094.htm: Removed.
  • css2.1/20110323/outline-color-095.htm: Removed.
  • css2.1/20110323/outline-color-096.htm: Removed.
  • css2.1/20110323/outline-color-097.htm: Removed.
  • css2.1/20110323/outline-color-098.htm: Removed.
  • css2.1/20110323/outline-color-099.htm: Removed.
  • css2.1/20110323/outline-color-100.htm: Removed.
  • css2.1/20110323/outline-color-101.htm: Removed.
  • css2.1/20110323/outline-color-102.htm: Removed.
  • css2.1/20110323/outline-color-103.htm: Removed.
  • css2.1/20110323/outline-color-104.htm: Removed.
  • css2.1/20110323/outline-color-105.htm: Removed.
  • css2.1/20110323/outline-color-106.htm: Removed.
  • css2.1/20110323/outline-color-107.htm: Removed.
  • css2.1/20110323/outline-color-108.htm: Removed.
  • css2.1/20110323/outline-color-109.htm: Removed.
  • css2.1/20110323/outline-color-110.htm: Removed.
  • css2.1/20110323/outline-color-111.htm: Removed.
  • css2.1/20110323/outline-color-112.htm: Removed.
  • css2.1/20110323/outline-color-113.htm: Removed.
  • css2.1/20110323/outline-color-114.htm: Removed.
  • css2.1/20110323/outline-color-115.htm: Removed.
  • css2.1/20110323/outline-color-116.htm: Removed.
  • css2.1/20110323/outline-color-117.htm: Removed.
  • css2.1/20110323/outline-color-118.htm: Removed.
  • css2.1/20110323/outline-color-119.htm: Removed.
  • css2.1/20110323/outline-color-120.htm: Removed.
  • css2.1/20110323/outline-color-121.htm: Removed.
  • css2.1/20110323/outline-color-122.htm: Removed.
  • css2.1/20110323/outline-color-123.htm: Removed.
  • css2.1/20110323/outline-color-124.htm: Removed.
  • css2.1/20110323/outline-color-125.htm: Removed.
  • css2.1/20110323/outline-color-126.htm: Removed.
  • css2.1/20110323/outline-color-127.htm: Removed.
  • css2.1/20110323/outline-color-128.htm: Removed.
  • css2.1/20110323/outline-color-129.htm: Removed.
  • css2.1/20110323/outline-color-130.htm: Removed.
  • css2.1/20110323/outline-color-131.htm: Removed.
  • css2.1/20110323/outline-color-132.htm: Removed.
  • css2.1/20110323/outline-color-133.htm: Removed.
  • css2.1/20110323/outline-color-134.htm: Removed.
  • css2.1/20110323/outline-color-135.htm: Removed.
  • css2.1/20110323/outline-color-136.htm: Removed.
  • css2.1/20110323/outline-color-137.htm: Removed.
  • css2.1/20110323/outline-color-138.htm: Removed.
  • css2.1/20110323/outline-color-139.htm: Removed.
  • css2.1/20110323/outline-color-140.htm: Removed.
  • css2.1/20110323/outline-color-141.htm: Removed.
  • css2.1/20110323/outline-color-142.htm: Removed.
  • css2.1/20110323/outline-color-143.htm: Removed.
  • css2.1/20110323/outline-color-144.htm: Removed.
  • css2.1/20110323/outline-color-145.htm: Removed.
  • css2.1/20110323/outline-color-174.htm: Removed.
  • css2.1/20110323/outline-color-175.htm: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.txt: Removed.
13:56 Changeset [100669] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

13:51 Changeset [100668] by mrowe@apple.com
  • 8 edits in trunk/Source

<http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/mac/WebCoreNSStringExtras.mm:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::reportErrorToClient):

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

Source/WebKit2:

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
13:50 Changeset [100667] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/72637> Stop performing runtime version checks on OS versions where the check can never possibly fail.

Reviewed by Simon Fraser.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::haveVImageRoundingErrorFix): When not targeting Snow Leopard we always have the fix.

13:48 Changeset [100666] by cfleizach@apple.com
  • 6 edits
    2 adds in trunk

AX: The scrollArea is not correctly returning the scrollbars
https://bugs.webkit.org/show_bug.cgi?id=70247

Reviewed by Beth Dakin.

Source/WebCore:

A few bugs that were preventing this from working.

1) In accessibilityAttributeValue: when an element did not have a renderer() we were returning earlier than we should have
2) We were not updating and clearing the scrollbars correctly when children were cleared or when asked for.

Test: platform/mac/accessibility/scrollbars.html

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::clearChildren):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/scrollbars-expected.txt: Added.
  • platform/mac/accessibility/scrollbars.html: Added.
13:47 Changeset [100665] by paroga@webkit.org
  • 2 edits in trunk

[CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
https://bugs.webkit.org/show_bug.cgi?id=72516

Reviewed by Brent Fulgham.

On windows some code generators fail, if the path to the preprocessor contains spaces.
Use only the executable name to avoid this issue for now.

  • Source/cmake/OptionsCommon.cmake:
13:40 Changeset [100664] by commit-queue@webkit.org
  • 1 edit
    135 deletes in trunk/LayoutTests

Unreviewed, rolling out r100659.
http://trac.webkit.org/changeset/100659
https://bugs.webkit.org/show_bug.cgi?id=72649

"Caused outline-offset-min-assert.html to assert on debug
builds" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-17

  • platform/qt/css2.1/20110323/outline-color-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-006-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-007-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-008-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-009-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-010-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-011-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-012-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-013-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-014-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-015-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-016-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-017-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-018-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-019-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-020-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-021-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-024-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-025-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-026-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-027-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-028-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-029-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-030-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-031-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-032-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-033-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-034-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-035-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-036-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-037-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-038-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-039-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-040-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-041-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-042-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-045-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-046-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-047-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-048-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-049-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-050-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-051-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-052-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-053-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-054-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-055-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-056-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-057-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-058-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-059-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-060-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-061-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-062-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-063-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-066-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-067-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-068-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-069-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-070-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-071-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-072-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-073-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-074-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-075-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-076-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-077-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-078-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-079-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-080-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-081-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-082-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-083-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-084-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-087-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-088-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-089-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-090-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-091-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-092-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-093-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-094-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-095-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-096-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-097-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-098-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-099-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-100-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-101-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-102-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-103-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-104-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-105-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-108-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-109-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-110-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-111-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-112-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-113-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-114-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-115-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-116-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-117-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-118-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-119-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-120-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-121-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-122-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-123-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-124-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-125-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-126-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-129-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-130-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-131-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-132-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-133-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-134-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-135-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-136-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-137-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-138-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-139-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-140-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-141-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-142-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-143-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-144-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-145-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-174-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-175-expected.txt: Removed.
13:34 Changeset [100663] by abarth@webkit.org
  • 14 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.
  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

  • Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
    • Inline script because the sandbox iframe isn't allowed to load local resources.
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
    • Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.
13:15 Changeset [100662] by cfleizach@apple.com
  • 4 edits in trunk/Source/WebCore

AX: cleanup style and naming and code in accessibility search mechanism
https://bugs.webkit.org/show_bug.cgi?id=72570

Reviewed by Beth Dakin.

Cleanup the naming and code style within the element searching mechanism.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
(WebCore::AccessibilityObject::findMatchingObjects):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

13:06 Changeset [100661] by jchaffraix@webkit.org
  • 3 edits
    12 adds in trunk

CSS table with 100% width can overflow their containing block
https://bugs.webkit.org/show_bug.cgi?id=72180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html

fast/table/table-in-table-percent-width-collapsing-border.html
fast/table/table-in-table-percent-width-quirks-mode.html
fast/table/table-in-table-percent-width.html

After r97555, we would include the borders in a CSS table's logical width even if the 'width'
property was a percent. This does not match what Firefox and IE are doing. Thus don't apply
this behavior to percent 'width'.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

Several tests to check that we don't overflow our containing block with width: 100%.

  • fast/table/table-in-table-percent-width-collapsing-border-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width-collapsing-border.html: Added.
  • fast/table/table-in-table-percent-width-expected.png: Added.
  • fast/table/table-in-table-percent-width-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width.html: Added.
13:01 Changeset [100660] by enne@google.com
  • 6 edits in trunk/Source

[chromium] Implicitly skip render surfaces that won't be drawn
https://bugs.webkit.org/show_bug.cgi?id=71038

Source/WebCore:

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests and unit tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Update a test that depends on a layer not getting removed.

Reviewed by James Robinson.

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

12:40 Changeset [100659] by robert@webkit.org
  • 1 edit
    135 adds in trunk/LayoutTests

Qt-specific results for tests added in r100652

Unreviewed Qt gardening.

  • platform/qt/css2.1/20110323/outline-color-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-016-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-017-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-019-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-025-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-026-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-027-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-028-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-030-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-031-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-032-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-033-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-034-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-035-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-036-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-037-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-038-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-039-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-040-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-041-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-042-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-045-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-046-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-047-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-048-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-049-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-050-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-051-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-052-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-053-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-054-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-055-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-056-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-057-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-058-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-059-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-060-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-061-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-062-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-063-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-066-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-067-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-068-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-069-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-070-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-071-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-072-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-073-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-074-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-075-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-076-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-077-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-078-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-079-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-080-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-081-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-082-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-083-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-084-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-087-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-088-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-089-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-090-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-091-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-092-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-093-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-094-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-095-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-096-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-097-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-098-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-099-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-100-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-101-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-102-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-103-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-104-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-105-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-108-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-109-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-110-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-111-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-112-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-113-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-114-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-115-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-116-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-117-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-118-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-119-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-120-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-121-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-122-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-123-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-124-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-125-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-126-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-129-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-130-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-131-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-132-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-133-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-134-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-135-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-136-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-137-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-138-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-139-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-140-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-141-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-142-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-143-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-144-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-145-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-174-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-175-expected.txt: Added.
12:30 Changeset [100658] by hausmann@webkit.org
  • 15 edits
    1 add in trunk

[Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode https://bugs.webkit.org/show_bug.cgi?id=72595

Reviewed by Noam Rosenthal.

Source/WebCore:

Removed QWebElement and QtDRTNode usage that reached from WebCore into
WebKit/qt and replaced it with the ability to register custom JSValue
conversion functions. The old code has been moved to WebKit/qt.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::QtInstance): Remove unnecessary meta type registration
(now done in QtWebElementRuntime::initialize in WebKit/qt).

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::registerCustomType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime.h:

Source/WebKit:

  • WebKit.pri: Add qwebelement_p.h to HEADERS.

Source/WebKit/qt:

Move QWebElement and QtDRTNode JS bindings from WebCore to WebKit/qt.

  • Api/qwebelement.cpp: Add QWebElement to JSValue and JSValue to QWebElement

conversion through intermediate QVariant.
(QtWebElementRuntime::create):
(QtWebElementRuntime::get):
(convertJSValueToWebElementVariant):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize): Register conversion functions for QWebElement.

  • Api/qwebelement.h:
  • Api/qwebelement_p.h: Added.
  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Initialize QWebElement conversion functions for
the JS runtime.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Add QtDRTNode to JSValue and JSValue to

QtDRTNode conversion through intermediate QVariant.
(QtDRTNodeRuntime::create):
(QtDRTNodeRuntime::get):
(convertJSValueToNodeVariant):
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::initialize): Register conversion functions for QtDRTNode.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
ensure the registration of the DRTNode JS bindings.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
registration of QWebElement (now done implicitly through QWebPage ->
QtWebElementRunTime::initialize code path)

12:25 Changeset [100657] by aroben@apple.com
  • 3 edits in trunk/Tools

Fix a crash-inducing typo I introduced in r100648

Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
handling a crashing test

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test): Get the driver name from the port.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
right crashed process name.

12:09 Changeset [100656] by fsamuel@chromium.org
  • 8 edits in trunk/Source/WebCore

Pass Aspect Ratio to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=72350

Reviewed by Ojan Vafai.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyAspectRatio::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.h:

(WebCore::CSSValue::isAspectRatioValue):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasAspectRatio):
(WebCore::InheritedFlags::aspectRatio):
(WebCore::InheritedFlags::aspectRatioDenominator):
(WebCore::InheritedFlags::aspectRatioNumerator):
(WebCore::InheritedFlags::setHasAspectRatio):
(WebCore::InheritedFlags::setAspectRatioDenominator):
(WebCore::InheritedFlags::setAspectRatioNumerator):
(WebCore::InheritedFlags::initialHasAspectRatio):
(WebCore::InheritedFlags::initialAspectRatioDenominator):
(WebCore::InheritedFlags::initialAspectRatioNumerator):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
11:58 Changeset [100655] by aroben@apple.com
  • 3 edits in trunk/Tools

Fix NRWT's parsing of the number of excluded leaks

Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
leaks were excluded

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
regular expression match, not the entire matched string.

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest): Added some example output that shows how things look when leaks are
excluded.
(LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
correctly.

11:54 Changeset [100654] by lforschler@apple.com
  • 5 edits in tags/Safari-535.9/Source

Versioning.

11:46 Changeset [100653] by jesus@webkit.org
  • 7 edits
    1 delete in trunk/Source/WebKit2

[Qt][WK2] Fix zero sized views in all QML tests
https://bugs.webkit.org/show_bug.cgi?id=72633

Reviewed by Noam Rosenthal.

After r100590, zero sized WebViews are no longer supported and,
therefore, the QML API tests need to be fixed.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
11:44 Changeset [100652] by robert@webkit.org
  • 3 edits
    441 adds in trunk

CSS 2.1 failure: outline-color-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71931

Source/WebCore:

Reviewed by Julien Chaffraix.

WebKit wasn't displaying the top block in these tests because it did not paint the outline
of divs with zero size.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size

LayoutTests:

Add tests covering dynamic outlines. At first glance the result
for outline-color-174.htm looks like it might be wrong but it's
really the statement at the top of the test that's misleading,
only the outline should be black not the entire box.

Reviewed by Julien Chaffraix.

  • css2.1/20110323/outline-color-001.htm: Added.
  • css2.1/20110323/outline-color-002.htm: Added.
  • css2.1/20110323/outline-color-003.htm: Added.
  • css2.1/20110323/outline-color-004.htm: Added.
  • css2.1/20110323/outline-color-005.htm: Added.
  • css2.1/20110323/outline-color-006.htm: Added.
  • css2.1/20110323/outline-color-007.htm: Added.
  • css2.1/20110323/outline-color-008.htm: Added.
  • css2.1/20110323/outline-color-009.htm: Added.
  • css2.1/20110323/outline-color-010.htm: Added.
  • css2.1/20110323/outline-color-011.htm: Added.
  • css2.1/20110323/outline-color-012.htm: Added.
  • css2.1/20110323/outline-color-013.htm: Added.
  • css2.1/20110323/outline-color-014.htm: Added.
  • css2.1/20110323/outline-color-015.htm: Added.
  • css2.1/20110323/outline-color-016.htm: Added.
  • css2.1/20110323/outline-color-017.htm: Added.
  • css2.1/20110323/outline-color-018.htm: Added.
  • css2.1/20110323/outline-color-019.htm: Added.
  • css2.1/20110323/outline-color-020.htm: Added.
  • css2.1/20110323/outline-color-021.htm: Added.
  • css2.1/20110323/outline-color-022.htm: Added.
  • css2.1/20110323/outline-color-023.htm: Added.
  • css2.1/20110323/outline-color-024.htm: Added.
  • css2.1/20110323/outline-color-025.htm: Added.
  • css2.1/20110323/outline-color-026.htm: Added.
  • css2.1/20110323/outline-color-027.htm: Added.
  • css2.1/20110323/outline-color-028.htm: Added.
  • css2.1/20110323/outline-color-029.htm: Added.
  • css2.1/20110323/outline-color-030.htm: Added.
  • css2.1/20110323/outline-color-031.htm: Added.
  • css2.1/20110323/outline-color-032.htm: Added.
  • css2.1/20110323/outline-color-033.htm: Added.
  • css2.1/20110323/outline-color-034.htm: Added.
  • css2.1/20110323/outline-color-035.htm: Added.
  • css2.1/20110323/outline-color-036.htm: Added.
  • css2.1/20110323/outline-color-037.htm: Added.
  • css2.1/20110323/outline-color-038.htm: Added.
  • css2.1/20110323/outline-color-039.htm: Added.
  • css2.1/20110323/outline-color-040.htm: Added.
  • css2.1/20110323/outline-color-041.htm: Added.
  • css2.1/20110323/outline-color-042.htm: Added.
  • css2.1/20110323/outline-color-043.htm: Added.
  • css2.1/20110323/outline-color-044.htm: Added.
  • css2.1/20110323/outline-color-045.htm: Added.
  • css2.1/20110323/outline-color-046.htm: Added.
  • css2.1/20110323/outline-color-047.htm: Added.
  • css2.1/20110323/outline-color-048.htm: Added.
  • css2.1/20110323/outline-color-049.htm: Added.
  • css2.1/20110323/outline-color-050.htm: Added.
  • css2.1/20110323/outline-color-051.htm: Added.
  • css2.1/20110323/outline-color-052.htm: Added.
  • css2.1/20110323/outline-color-053.htm: Added.
  • css2.1/20110323/outline-color-054.htm: Added.
  • css2.1/20110323/outline-color-055.htm: Added.
  • css2.1/20110323/outline-color-056.htm: Added.
  • css2.1/20110323/outline-color-057.htm: Added.
  • css2.1/20110323/outline-color-058.htm: Added.
  • css2.1/20110323/outline-color-059.htm: Added.
  • css2.1/20110323/outline-color-060.htm: Added.
  • css2.1/20110323/outline-color-061.htm: Added.
  • css2.1/20110323/outline-color-062.htm: Added.
  • css2.1/20110323/outline-color-063.htm: Added.
  • css2.1/20110323/outline-color-064.htm: Added.
  • css2.1/20110323/outline-color-065.htm: Added.
  • css2.1/20110323/outline-color-066.htm: Added.
  • css2.1/20110323/outline-color-067.htm: Added.
  • css2.1/20110323/outline-color-068.htm: Added.
  • css2.1/20110323/outline-color-069.htm: Added.
  • css2.1/20110323/outline-color-070.htm: Added.
  • css2.1/20110323/outline-color-071.htm: Added.
  • css2.1/20110323/outline-color-072.htm: Added.
  • css2.1/20110323/outline-color-073.htm: Added.
  • css2.1/20110323/outline-color-074.htm: Added.
  • css2.1/20110323/outline-color-075.htm: Added.
  • css2.1/20110323/outline-color-076.htm: Added.
  • css2.1/20110323/outline-color-077.htm: Added.
  • css2.1/20110323/outline-color-078.htm: Added.
  • css2.1/20110323/outline-color-079.htm: Added.
  • css2.1/20110323/outline-color-080.htm: Added.
  • css2.1/20110323/outline-color-081.htm: Added.
  • css2.1/20110323/outline-color-082.htm: Added.
  • css2.1/20110323/outline-color-083.htm: Added.
  • css2.1/20110323/outline-color-084.htm: Added.
  • css2.1/20110323/outline-color-085.htm: Added.
  • css2.1/20110323/outline-color-086.htm: Added.
  • css2.1/20110323/outline-color-087.htm: Added.
  • css2.1/20110323/outline-color-088.htm: Added.
  • css2.1/20110323/outline-color-089.htm: Added.
  • css2.1/20110323/outline-color-090.htm: Added.
  • css2.1/20110323/outline-color-091.htm: Added.
  • css2.1/20110323/outline-color-092.htm: Added.
  • css2.1/20110323/outline-color-093.htm: Added.
  • css2.1/20110323/outline-color-094.htm: Added.
  • css2.1/20110323/outline-color-095.htm: Added.
  • css2.1/20110323/outline-color-096.htm: Added.
  • css2.1/20110323/outline-color-097.htm: Added.
  • css2.1/20110323/outline-color-098.htm: Added.
  • css2.1/20110323/outline-color-099.htm: Added.
  • css2.1/20110323/outline-color-100.htm: Added.
  • css2.1/20110323/outline-color-101.htm: Added.
  • css2.1/20110323/outline-color-102.htm: Added.
  • css2.1/20110323/outline-color-103.htm: Added.
  • css2.1/20110323/outline-color-104.htm: Added.
  • css2.1/20110323/outline-color-105.htm: Added.
  • css2.1/20110323/outline-color-106.htm: Added.
  • css2.1/20110323/outline-color-107.htm: Added.
  • css2.1/20110323/outline-color-108.htm: Added.
  • css2.1/20110323/outline-color-109.htm: Added.
  • css2.1/20110323/outline-color-110.htm: Added.
  • css2.1/20110323/outline-color-111.htm: Added.
  • css2.1/20110323/outline-color-112.htm: Added.
  • css2.1/20110323/outline-color-113.htm: Added.
  • css2.1/20110323/outline-color-114.htm: Added.
  • css2.1/20110323/outline-color-115.htm: Added.
  • css2.1/20110323/outline-color-116.htm: Added.
  • css2.1/20110323/outline-color-117.htm: Added.
  • css2.1/20110323/outline-color-118.htm: Added.
  • css2.1/20110323/outline-color-119.htm: Added.
  • css2.1/20110323/outline-color-120.htm: Added.
  • css2.1/20110323/outline-color-121.htm: Added.
  • css2.1/20110323/outline-color-122.htm: Added.
  • css2.1/20110323/outline-color-123.htm: Added.
  • css2.1/20110323/outline-color-124.htm: Added.
  • css2.1/20110323/outline-color-125.htm: Added.
  • css2.1/20110323/outline-color-126.htm: Added.
  • css2.1/20110323/outline-color-127.htm: Added.
  • css2.1/20110323/outline-color-128.htm: Added.
  • css2.1/20110323/outline-color-129.htm: Added.
  • css2.1/20110323/outline-color-130.htm: Added.
  • css2.1/20110323/outline-color-131.htm: Added.
  • css2.1/20110323/outline-color-132.htm: Added.
  • css2.1/20110323/outline-color-133.htm: Added.
  • css2.1/20110323/outline-color-134.htm: Added.
  • css2.1/20110323/outline-color-135.htm: Added.
  • css2.1/20110323/outline-color-136.htm: Added.
  • css2.1/20110323/outline-color-137.htm: Added.
  • css2.1/20110323/outline-color-138.htm: Added.
  • css2.1/20110323/outline-color-139.htm: Added.
  • css2.1/20110323/outline-color-140.htm: Added.
  • css2.1/20110323/outline-color-141.htm: Added.
  • css2.1/20110323/outline-color-142.htm: Added.
  • css2.1/20110323/outline-color-143.htm: Added.
  • css2.1/20110323/outline-color-144.htm: Added.
  • css2.1/20110323/outline-color-145.htm: Added.
  • css2.1/20110323/outline-color-174.htm: Added.
  • css2.1/20110323/outline-color-175.htm: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.txt: Added.
11:27 Changeset [100651] by lforschler@apple.com
  • 1 copy in tags/Safari-535.9

New Tag.

11:27 Changeset [100650] by lforschler@apple.com
  • 1 delete in tags/Safari-535.9

remove incorrect tag

11:20 Changeset [100649] by lforschler@apple.com
  • 1 copy in tags/Safari-535.9

New Tag.

11:17 Changeset [100648] by aroben@apple.com
  • 5 edits in trunk/Tools

Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process

Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
when web process crashes, but WebProcess crash log should get saved instead

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result): Simplified a little to share more code between the case where we
crashed when running the test and where we crashed when checking the expected rendering for
a reftest. Changed to pass the crashed process name down to write_crash_report.
(TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
along to CrashLogs.find_newest_log rather than always using the driver name.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
crashed.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init): Initialize new web_process_crash attribute.
(unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
test this patch adds.
(TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
specifies that the driver crashed or the web process crashed.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
which we pretend the web process crashed rather than the driver process.

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_unexpected_failures):
(EndToEndTest.test_end_to_end):
Updated magic numbers to account for new unexpected failing test added to unit_test_list.

11:16 Changeset [100647] by lforschler@apple.com
  • 5 edits in trunk/Source

Revert revision change.

11:12 Changeset [100646] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] stop spamming features warning on every build
https://bugs.webkit.org/show_bug.cgi?id=72629

Reviewed by Ojan Vafai.

We toggle $blobSupport on if $mediaStreamSupport is on. Since
$mediaStreamSupport is on by default for chromium, make the default
for $blobSupport also on.

  • Scripts/build-webkit:
11:11 Changeset [100645] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

10:55 Changeset [100644] by aroben@apple.com
  • 3 edits in trunk/Tools

Remove extra quoting of call stacks and types passed to run-leaks by NRWT

Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
that are supposed to be ignored

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
required when passing arguments via the shell (which we aren't doing here). It is not
required by Perl's option-parsing code (as the comment I removed mistakenly claimed).

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest.test_leaks_args): Updated expectations.

10:29 Changeset [100643] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72631

Add a CRASH expectation for
fast/filesystem/file-writer-abort-depth.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:24 Changeset [100642] by mrobinson@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] Remove the last remaining WebKit1 gtkdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=72627

Reviewed by Philippe Normand.

  • webkit/webkitdownload.h: Add missing enum documentation.
  • webkit/webkiterror.h: Ditto.
  • webkit/webkitwebview.h: Ditto.
10:07 Changeset [100641] by cfleizach@apple.com
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

Unreviewed layout test fix.

I hadn't realized that selection-value-changes-for-aria-textbox.html was being skipped on Lion,
so this test started failing on snow leopard on the bots.

  • platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
09:49 Changeset [100640] by sergio@webkit.org
  • 4 edits in trunk

[GTK] plugins/get-url-notify-with-url-that-fails-to-load.html on bots after r100466
https://bugs.webkit.org/show_bug.cgi?id=72613

Reviewed by Martin Robinson.

Source/WebCore:

Do not assume that a SoupRequest always exists, it is not
generated for example when the provided URL is
invalid. ResourceHandle::platformSetDefersLoading was crashing
because of that.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::platformSetDefersLoading):

LayoutTests:

Added a test that times out in WK2.

  • platform/gtk-wk2/Skipped: added plugins/get-url-notify-with-url-that-fails-to-load.html
09:40 Changeset [100639] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Added a CRASH expectation for
fast/dom/null-document-location-put-crash.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
09:31 Changeset [100638] by steveblock@google.com
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Rebaseline
fast/css-generated-content/nested-tables-with-before-after-content-crash.html
for Chromium Linux. Also remove a duplicated text expectation.

Unreviewed gardening.

  • platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed
09:17 Changeset [100637] by steveblock@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=54322

Rebaseline transforms/no_transform_hit_testing.html. It looks like the
expected results still aren't quite right after
http://trac.webkit.org/changeset/100615.

  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.
09:16 Changeset [100636] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, run-bindings-tests fix after r91028.

  • Scripts/run-bindings-tests: Use scm.detection module.
09:14 Changeset [100635] by vsevik@chromium.org
  • 5 edits in trunk/Source

Web Inspector: Remove onlineDetectionEnabled from Preferences
https://bugs.webkit.org/show_bug.cgi?id=72617

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
09:09 Changeset [100634] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] http/tests/inspector/resource-tree/resource-tree-no-xhrs.html fails occasionally
https://bugs.webkit.org/show_bug.cgi?id=72622

Add MISSING and TEXT expectations for
http/tests/inspector/resource-tree/resource-tree-no-xhrs.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
08:53 Changeset [100633] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip a failing test temporarily.
08:49 Changeset [100632] by philn@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new css3 tests and an accessibility test.

  • platform/gtk/accessibility/loading-iframe-sends-notification-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-blending-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-simple-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-sizing-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-tiled-expected.txt: Added.
  • platform/gtk/fast/borders/border-mixed-alpha-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
08:45 Changeset [100631] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Ensure the parent for the webView's a11y object is set.

This should fix some accessibility related GTK API tests.

Rubber-stamped by Philippe Normand.

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible): Always set the parent to make
navigation across GTK and WebKit worlds work properly.

08:43 Changeset [100630] by inferno@chromium.org
  • 9 edits
    5 adds in trunk

Crash from nested tables with generated content
https://bugs.webkit.org/show_bug.cgi?id=68811

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-17
Reviewed by David Hyatt.

Source/WebCore:

When adding a child to a table that has generated content, this change
ensures that we leave alone any generated content renderers that belong
to descendants in the tree. They don't need to be touched, and doing so
can create confusion about who the content belongs to.

This patch also simplifies some existing code for finding pseudoelement
renderers.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
(WebCore::RenderObject::isBeforeAfterContentGeneratedByAncestor): Added

  • rendering/RenderObject.h:

(WebCore::RenderObject::findAfterContentRenderer): Deleted
(WebCore::RenderObject::findBeforeContentRenderer): Deleted

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::beforePseudoElementRenderer):
(WebCore::RenderObjectChildList::afterPseudoElementRenderer):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

LayoutTests:

Layout test for nesting tables with generated content and forcing a
style recalculation.

  • fast/css-generated-content/nested-tables-with-before-after-content-crash.html: Added
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added
08:40 Changeset [100629] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Don't export the private QQuickView.

Reviewed by Kenneth Rohde Christiansen.

We don't need to export that class anymore as the experimental QML plugin
does not expose this object anymore.

  • UIProcess/API/qt/qquickwebview_p_p.h:
08:32 Changeset [100628] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed WinCE build fix for r94119.

MSVC throws multiply defined symbols linker error when using local class in inline function.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::IdentitySetter::identitySetter):
(WebCore::JSDictionary::tryGetProperty):

08:27 Changeset [100627] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/plugins/plugin-javascript-access-expected.txt: Updated.
08:26 Changeset [100626] by steveblock@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Several animations/ tests flakily fail due to fragile setTimeout()-based framework
https://bugs.webkit.org/show_bug.cgi?id=66953

Remove expectation for animations/missing-values-last-keyframe.html from
platform/chromium-cg-mac-snowleopard. This was incorrectly added by the
rebaseline tool in r100611.

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/animations/missing-values-last-keyframe-expected.txt: Removed.
08:15 Changeset [100625] by jochen@chromium.org
  • 2 edits in trunk/Tools

Silence a warning about control reaching the end of a non-void function
https://bugs.webkit.org/show_bug.cgi?id=72616

Reviewed by Tony Gentilcore.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::verticalScrollbar):

08:10 Changeset [100624] by jochen@chromium.org
  • 2 edits in trunk

[chromium] add gyp-mac-tool to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=72603

Reviewed by Tony Gentilcore.

This file is generated by the make-based build of the chromium/mac port

  • .: Modified property svn:ignore.
  • .gitignore:
07:50 Changeset [100623] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Expose setUseTraditionalDesktopBehaviour() in QML experimental API
https://bugs.webkit.org/show_bug.cgi?id=72610

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview_p.h:
07:42 Changeset [100622] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Enable skipped but now passing tests (http/tests)
https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-17
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip 24 tests.
07:38 Changeset [100621] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

Print warning for the Qt port when a process crashes and is relaunched
https://bugs.webkit.org/show_bug.cgi?id=72607

Reviewed by Antonio Gomes.

Make the QtViewInterface::processDidCrash take a URL string argument,
for being able to say which url was the origin of the crash.

We now additionally store the load state and url at process exit. This
is needed for printing the warning and for further crash handling.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::processDidCrash):

  • UIProcess/qt/QtWebPageProxy.h:
07:05 Changeset [100620] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add a CRASH expectation for fast/frames/frame-unload-crash.html on
SnowLeopard dbg.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
06:55 Changeset [100619] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] The experimental plugin doesn't work after being renamed.

Reviewed by Tor Arne Vestbø.

It was renamed from private to experimental but the qmldir file
was forgotten.

  • declarative/experimental/qmldir:
06:53 Changeset [100618] by aroben@apple.com
  • 5 edits in trunk/Tools

Ignore some leaks in frameworks we link against on Lion

Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
aren't WebKit's fault

Reviewed by Antti Koivisto.

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.is_lion): Added.

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
methods.

06:51 Changeset [100617] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Cleanup dead code in QtWebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=72608

Reviewed by Simon Hausmann.

Remove some dead code after we merged our views.
QQuickWebView is now using AC which means that this
path is never called now.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:
06:49 Changeset [100616] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

TextTrackList not sorted correctly
https://bugs.webkit.org/show_bug.cgi?id=72545

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-texttracks.html

  • WebCore.xcodeproj/project.pbxproj: Add TextTrack.h to WebCore private headers because

it is included by HTMLMediaElement.h.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Pass track type to base class constructor.
(WebCore::LoadableTextTrack::trackElementIndex): New, return the <track> element's tree order

for sorting.

  • html/LoadableTextTrack.h:
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Set track type.

  • html/TextTrack.h:

(WebCore::TextTrack::create): Ditto.
(WebCore::TextTrack::trackType): Ditto.

  • html/track/TextTrackList.cpp:

(TextTrackList::length): Update to deal with two TextTrack vectors.
(TextTrackList::item): Ditto.
(TextTrackList::append): Ditto.
(TextTrackList::remove): Ditto

  • html/track/TextTrackList.h: Store the two types of TextTracks in separate Vectors to make

it simpler to keep them in the correct order.

LayoutTests:

  • media/track/track-texttracks-expected.txt: Added.
  • media/track/track-texttracks.html: Added.
06:42 Changeset [100615] by steveblock@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=54322

Rebaseline transforms/no_transform_hit_testing.html. It looks like the
expected results aren't quite right after
http://trac.webkit.org/changeset/100507.

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.
06:23 Changeset [100614] by hausmann@webkit.org
  • 5 edits in trunk/Source

[Qt] Layer violation: WebCore::dnsPrefetch uses QWebSettings::globalSettings()
https://bugs.webkit.org/show_bug.cgi?id=72596

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

We don't need to use QWebSettings here, because we now propagate the DNS prefetch
setting to WebCore::Settings and the rest of WebCore checks the setting before calling
WebCore::prefetchDNS.

  • platform/network/qt/DnsPrefetchHelper.cpp:

(WebCore::prefetchDNS): Removed the use of QWebSettings.

  • platform/network/qt/DnsPrefetchHelper.h: Remove offending qwebsettings.h inclusion.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply): Propagate the DNS prefetch setting to WebCore::Settings.

06:22 Changeset [100613] by hausmann@webkit.org
  • 5 edits in trunk/Source

[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
https://bugs.webkit.org/show_bug.cgi?id=72594

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Move the cache for the resource pixmaps into ImageQt.cpp.

  • platform/graphics/Image.h: Add Qt specific setter for resource pixmaps.
  • platform/graphics/qt/ImageQt.cpp: Moved resource pixmap hash from qwebsettings.

(earlyClearGraphics):
(graphics):
(loadResourcePixmap):
(WebCore::Image::setPlatformResource):

Source/WebKit/qt:

Move resource pixmap cache into ImageQt.cpp.

  • Api/qwebsettings.cpp:

(resourceNameForWebGraphic): Helper function to translate between public API enums and
resource names.
(QWebSettings::setWebGraphic): Call the new ImageQt::setPlatformResource setter.
(QWebSettings::webGraphic): Call Image::loadPlatformResource to read from the cache
in WebCore.

06:15 Changeset [100612] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Touch/Mouse events are delivered with wrong coordinates.
https://bugs.webkit.org/show_bug.cgi?id=72604

When using the QtViewportInterationEngine for zooming/panning,
no additional scroll offset should be applied to input events
by the ScrollView.

This patch is based on work by Andreas Kling.

Reviewed by Kenneth Rohde Christiansen.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::contentsToWindow):

05:39 Changeset [100611] by steveblock@google.com
  • 1 edit
    1 copy
    5 moves
    9 deletes in trunk/LayoutTests

Several animations/ tests flakily fail due to fragile setTimeout()-based framework
https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselined missing-values-first-keyframe.html,
missing-values-last-keyframe.html and opacity-transform-animation.html.
Looks like these weren't quite right after
http://trac.webkit.org/changeset/100520.

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/animations/missing-values-last-keyframe-expected.txt: Copied from LayoutTests/animations/missing-values-last-keyframe-expected.txt.
  • platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-linux/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium/animations/missing-values-first-keyframe-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png.
  • platform/chromium/animations/missing-values-last-keyframe-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png.
  • platform/mac/animations/missing-values-first-keyframe-expected.txt: Renamed from LayoutTests/animations/missing-values-first-keyframe-expected.txt.
  • platform/mac/animations/missing-values-last-keyframe-expected.txt: Renamed from LayoutTests/animations/missing-values-last-keyframe-expected.txt.
05:22 Changeset [100610] by vestbo@webkit.org
  • 1 edit in trunk/Tools/WebKitTestRunner/qt/main.cpp

[Qt] Prospective build fix for WebKit2 on Linux

05:19 Changeset [100609] by benm@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix the Windows builds by adding WorkerEventQueue.cpp|h to the
vcproj. Build break was introduced in
https://bugs.webkit.org/show_bug.cgi?id=72528

  • WebCore.vcproj/WebCore.vcproj: Add missing files.
05:04 Changeset [100608] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore https://bugs.webkit.org/show_bug.cgi?id=72602

Unreviewed gardening after r100510.

  • platform/qt/Skipped:
05:02 Changeset [100607] by vestbo@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebKit2

[Qt] Remove forwarding header for WebKit2 C API

The Qt port of WebKit does not provide a C-API for the View classes.

Reviewed by Simon Hausmann.

05:01 Changeset [100606] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] perf/array-binary-search.html fails as MISSING
https://bugs.webkit.org/show_bug.cgi?id=63057

This is really a TEXT failure, but is reported as MISSING due to Bug

  1. Addding both MISSING and TEXT expectations to keep the tree green

working if/when Bug 63104 is fixed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
04:53 Changeset [100605] by philn@webkit.org
  • 2 edits in trunk/Tools

[GTK] Disable ref tests
https://bugs.webkit.org/show_bug.cgi?id=72599

Reviewed by Xan Lopez.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref

tests to avoid massive flakiness.

04:46 Changeset [100604] by mihnea@adobe.com
  • 18 edits
    6 adds in trunk

CSS Exclusions: parse the wrap-margin and wrap-padding properties
https://bugs.webkit.org/show_bug.cgi?id=71900

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/wrap-margin-parsing.html

fast/exclusions/wrap-padding-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::wrapPadding):
(WebCore::InheritedFlags::setWrapPadding):
(WebCore::InheritedFlags::initialWrapPadding):
(WebCore::InheritedFlags::wrapMargin):
(WebCore::InheritedFlags::setWrapMargin):
(WebCore::InheritedFlags::initialWrapMargin):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/exclusions/script-tests/wrap-margin-parsing.js: Added.
  • fast/exclusions/script-tests/wrap-padding-parsing.js: Added.
  • fast/exclusions/wrap-margin-parsing-expected.txt: Added.
  • fast/exclusions/wrap-margin-parsing.html: Added.
  • fast/exclusions/wrap-padding-parsing-expected.txt: Added.
  • fast/exclusions/wrap-padding-parsing.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
04:28 Changeset [100603] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Resolve import and web-process paths automatically for QML tests

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

04:27 Changeset [100602] by vestbo@webkit.org
  • 32 edits
    7 copies
    1 move
    2 adds
    6 deletes in trunk

[Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that

A new extension object has been added to QQuickWebView (the same approach should be used
for other API classes that need experimental APIs). The QML extension mechanism is then
built on top of the experimental object.

https://bugs.webkit.org/show_bug.cgi?id=72522

Reviewed by Simon Hausmann.

04:16 Changeset [100601] by bashi@chromium.org
  • 9 edits
    1 copy in trunk/Source

[chromium] don't call fontconfig twice in complex text path
https://bugs.webkit.org/show_bug.cgi?id=38701

Source/WebCore:

Adds a new API for getting font family. For now, FontCacheLinux calls the new API, but don't use additional properties for compatibility. The old API will be removed when Chromium is ready to use new API.

Reviewed by Tony Chang.

No new tests. No behavior changes for now.

  • platform/chromium/PlatformSupport.h: Added FontFamily struct and changed the declaration of getFontFamilyForCharacters().
  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters): Uses new PlatformSupport::getFontFamilyForCharacters().

  • platform/graphics/chromium/FontPlatformDataLinux.h:

(WebCore::FontPlatformData::setFakeBold): Added.
(WebCore::FontPlatformData::setFakeItalic): Added.

Source/WebKit/chromium:

Reviewed by Tony Chang.

Add new API for getFamilyForChars() so that keeping correct font mapping of the given characters.

  • public/linux/WebFontFamily.h: Added.
  • public/linux/WebFontInfo.h: Add a new API.
  • public/linux/WebSandboxSupport.h:

(WebKit::WebSandboxSupport::getFontFamilyForCharacters): Ditto.

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getFontFamilyForCharacters): Ditto.

  • src/linux/WebFontInfo.cpp:

(WebKit::WebFontInfo::familyForChars): Modified to get weight and italic properties of the font. Old API uses new API internally.

04:06 Changeset [100600] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

CSS3 cross-fade tests failing on Chromium after r100535
https://bugs.webkit.org/show_bug.cgi?id=72598

Update test expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:57 Changeset [100599] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

03:51 Changeset [100598] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Compositing LayoutTests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=72487

Update test expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:50 Changeset [100597] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set
https://bugs.webkit.org/show_bug.cgi?id=72525

Reviewed by Xan Lopez.

Source/WebCore:

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_parent): Call to the implementation of
atk_object_get_parent in AtkObject class to check whether a parent
AtkObject has been previously set, before trying to find one.

Source/WebKit/gtk:

  • tests/testatk.c:

(testWebkitAtkSetParentForObject): New unit test to check that
calls to atk_object_get_parent() over a WebKitGTK's accessibility
wrapper object returns its parent AtkObject if previously set.
(main): Added new test.

03:47 Changeset [100596] by mario@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] ATK API tests failing because of patch for bug 72390
https://bugs.webkit.org/show_bug.cgi?id=72592

Reviewed by Philippe Normand.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Remove the offending line in
the unit test, which is not actually required to test the new
functionality and causes problems in some scenarios, due to the
lazy creation mechanism of AtkObjects.

  • tests/testatkroles.c:

(finish_loading): Reflect that the document frame object is no
longer the root accessibility object (a scroll pane from now on),
but the only child of that one. Thus, skip that root object.

03:27 Changeset [100595] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fix IE user agents strings in the inspector.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

03:26 Changeset [100594] by kenneth@webkit.org
  • 6 edits in trunk/Source

Make use-fixed-layout work reliable
https://bugs.webkit.org/show_bug.cgi?id=72511

Reviewed by Simon Hausmann.

Source/WebCore:

Always send a viewport update per page load as we depend on that,
to reset all viewport handling before doing layout.

  • page/Page.cpp:

(WebCore::Page::updateViewportArguments):

Source/WebKit2:

The code handling use-fixed-layout wasn't 100% reliable. The code
was changed to make sure the value is always correct.

It also doesn't set the value by looking at the previous FrameView,
as that wouldn't work in cases, such as when the web process has
crashes.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::setUseFixedLayout):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::useFixedLayout):

Store the state as m_useFixedLayout so that it can be used
from the WebFrameLoaderClient.

03:13 Changeset [100593] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Support CoreAnimation plugin model on Mac
https://bugs.webkit.org/show_bug.cgi?id=47925

Update test expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:01 Changeset [100592] by abarth@webkit.org
  • 2 edits
    1 move in trunk/Tools

Move test_results_uploader.py out of layout_package
https://bugs.webkit.org/show_bug.cgi?id=72590

Reviewed by Eric Seidel.

Most of the lines of code in this file are wrong, but I've restrained
myself and only changed a few of them to generalized this class to the
common package.

This is part of a series of patches to remove layout_package.

  • Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
02:58 Changeset [100591] by abarth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Fix style nits in printing.py.

  • Scripts/webkitpy/layout_tests/views/printing.py:
02:56 Changeset [100590] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt][WK2] Do not apply new viewport properties until after the first visually non-empty layout.
https://bugs.webkit.org/show_bug.cgi?id=72508

Delay applying viewport properties on the viewport item until after the first visually non-empty
layout finished. It enables the viewport to be intact until the new page is ready to be rendered.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::computeViewportConstraints):

  • UIProcess/API/qt/qquickwebview_p.h:

(PostTransitionState::isTransitioningToNewPage):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(setupPageLoaderClient):

  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::didFinishFirstNonEmptyLayout):
(WebKit::QtViewInterface::didChangeContentsSize):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::startDrag):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::startDrag):

  • UIProcess/qt/QtWebPageProxy.h:
02:12 Changeset [100589] by abarth@webkit.org
  • 2 edits in trunk/Tools

Minor style nits in run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=72583

Reviewed by Eric Seidel.

This patch just fixes some minor style issues as I work my way back
into this code.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
02:10 Changeset [100588] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: inspector follows javascript: hrefs as relative
https://bugs.webkit.org/show_bug.cgi?id=72373

Source/WebCore:

javascript: hrefs should never be linkified for security.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.completeURL):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:
02:09 Changeset [100587] by abarth@webkit.org
  • 3 edits
    1 move in trunk/Tools

Move test_result_writer out of layout_package
https://bugs.webkit.org/show_bug.cgi?id=72586

Rubber-stamped by Eric Seidel.

This is part of a series of patches to remove layout_package.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
  • Scripts/webkitpy/tool/commands/rebaseline.py:
02:08 Changeset [100586] by zimmermann@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-11-17 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix 32bit builds.

  • platform/ClockGeneric.cpp: (ClockGeneric::now): Use narrowPrecisionToFloat.
  • rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): Use it correctly.
02:04 Changeset [100585] by abarth@webkit.org
  • 2 edits in trunk/Tools

svn-apply shouldn't magically move files into Source anymore
https://bugs.webkit.org/show_bug.cgi?id=72579

Reviewed by Eric Seidel.

The Source directory has existed for long enough that we don't need
svn-apply to magically re-write old-style patches anymore.

  • Scripts/VCSUtils.pm:

(parseGitDiffHeader):
(parseSvnDiffHeader):

01:44 Changeset [100584] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

Accessibility: Chromium requires an AX notification when an iframe loads.
https://bugs.webkit.org/show_bug.cgi?id=72239

Source/WebCore:

When a document finishes loading, we were sending an AXLoadComplete if it
was the top document. Now, if it's a document in an iframe, send an
AXLayoutComplete on the iframe.

Reviewed by Chris Fleizach.

Test: accessibility/loading-iframe-sends-notification.html

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

Reviewed by Chris Fleizach.

  • accessibility/loading-iframe-sends-notification.html: Added.
  • platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Added.
01:27 Changeset [100583] by commit-queue@webkit.org
  • 3 edits
    1 move
    1 add in trunk/Source/WebKit2

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

[WK2] Move gtk/BackingStoreGtk.cpp to cairo/BackingStoreCairo.cpp to share with EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62444

Rename gtk/BackingStoreGtk.cpp to cairo/BackingStoreCairo.cpp to share with EFL port.
The gtk/BackingStoreGtk.cpp only has cairo dependency, so it can be shared with other port
that uses cairo.

  • GNUmakefile.am:
  • UIProcess/BackingStore.h:
  • UIProcess/cairo/BackingStoreCairo.cpp: Renamed from Source/WebKit2/UIProcess/gtk/BackingStoreGtk.cpp.

(WebKit::BackingStore::paint):
(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

01:27 Changeset [100582] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Introduce WebSecurityOrigin::isUnique in preparation for removing WebSecurityOrigin::isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72580

Reviewed by Darin Fisher.

We've removed the concept of empty security origins from WebKit because
it doesn't exist in the specs. Now it's time to remove it from the API.

  • public/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::isUnique):

01:21 Changeset [100581] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

<http://webkit.org/b/72574> Remove unnecessary use of CarbonCore APIs from Audio code

Reviewed by Andy Estes.

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac): Switch from using the Carbon Component Manager
to using AudioUnit's own component interface.
(WebCore::AudioDestinationMac::~AudioDestinationMac): Ditto.

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader): Remove an unncessary trip through the Carbon File Manager
when converting a char* path to a CFURLRef representing the same.

01:10 Changeset [100580] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add few more properties to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72468

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

Add 'enable-private-browsing', 'enable-developer-extras, 'enable-resizable-text-areas'
and 'enable-tabs-to-links' properties to WebKitSettings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Add new set functions.
(webKitSettingsGetProperty): Add new get functions.
(webkit_settings_class_init): Add new properties.
(webkit_settings_get_enable_private_browsing): Get 'enable-private-browsing' property.
(webkit_settings_set_enable_private_browsing): Set 'enable-private-browsing' property.
(webkit_settings_get_enable_developer_extras): Get 'enable-developer-extras' property.
(webkit_settings_set_enable_developer_extras): Set 'enable-developer-extras' property.
(webkit_settings_get_enable_resizable_text_areas): Get 'enable-resizable-text-areas' property.
(webkit_settings_set_enable_resizable_text_areas): Set 'enable-resizable-text-areas' property.
(webkit_settings_get_enable_tabs_to_links): Get 'enable-tabs-to-links' property.
(webkit_settings_set_enable_tabs_to_links): Set 'enable-tabs-to-links' property.

  • UIProcess/API/gtk/WebKitSettings.h: New public APIs added.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New APIs added.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

01:02 Changeset [100579] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix WebKit2 GTK+ build after r100569.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):

00:53 Changeset [100578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Fix assert while running TestWebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72469

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Correct the test.

00:48 Changeset [100577] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/912

Merge 100550
BUG=104223
Review URL: http://codereview.chromium.org/8585026

00:42 Changeset [100576] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/912

Merge 99462
BUG=91911
Review URL: http://codereview.chromium.org/8586021

00:37 Changeset [100575] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/912

Merge 99579
BUG=101235
Review URL: http://codereview.chromium.org/8587027

00:25 Changeset [100574] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

CSP report-only mode doesn't work from an HTTP header
https://bugs.webkit.org/show_bug.cgi?id=71958

Reviewed by Eric Seidel.

Source/WebCore:

"It's tested or it's broken." -- Adam Leventhal

Test: http/tests/security/contentSecurityPolicy/report-only-from-header.php

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

LayoutTests:

Test that X-WebKit-CSP-Report-Only actually sends reports.

  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only-from-header.php: Added.
00:24 Changeset [100573] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/912

Merge 9964
BUG=102037
Review URL: http://codereview.chromium.org/8480029

00:16 Changeset [100572] by pfeldman@chromium.org
  • 14 edits in trunk/Source

Web Inspector: introduce Debugger domain capabilities concept.
https://bugs.webkit.org/show_bug.cgi?id=72393

Many of the Preferences that we have in Settings.js and override in DevTools.js
are really not preferences, but capabilities. Protocol clients should have a way
of figuring out whether some capability is present before using it.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/v8/ScriptDebugServer.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getCapabilities):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
00:10 Changeset [100571] by cevans@google.com
  • 1 edit
    3 deletes in branches/chromium/912

Revert 100566 - Merge 99649
BUG=102037
Review URL: http://codereview.chromium.org/8587026

00:08 Changeset [100570] by mihnea@adobe.com
  • 20 edits
    6 adds in trunk

CSS exclusions: parse the wrap-flow and wrap-through properties
https://bugs.webkit.org/show_bug.cgi?id=71904

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/wrap-flow-parsing.html

fast/exclusions/wrap-through-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::wrapFlow):
(WebCore::InheritedFlags::wrapThrough):
(WebCore::InheritedFlags::setWrapFlow):
(WebCore::InheritedFlags::setWrapThrough):
(WebCore::InheritedFlags::initialWrapFlow):
(WebCore::InheritedFlags::initialWrapThrough):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/exclusions/script-tests/wrap-flow-parsing.js: Added.
  • fast/exclusions/script-tests/wrap-through-parsing.js: Added.
  • fast/exclusions/wrap-flow-parsing-expected.txt: Added.
  • fast/exclusions/wrap-flow-parsing.html: Added.
  • fast/exclusions/wrap-through-parsing-expected.txt: Added.
  • fast/exclusions/wrap-through-parsing.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
Note: See TracTimeline for information about the timeline view.