Timeline


and

11/22/11:

23:12 Changeset [101044] by dpranke@chromium.org

Roll DEPS to r111325 to fix an issue with the linux build

https://bugs.webkit.org/show_bug.cgi?id=73004

Unreviewed, build fix.

There appears to be a bug in the Makefile generator for gyp
that is causing make to not rebuild DRT on Linux.

  • DEPS:
23:09 Changeset [101043] by ossy@webkit.org

[Qt][GTK] editing/spelling/spellcheck-async.html fails
https://bugs.webkit.org/show_bug.cgi?id=73003

Unreviewed morning gardening.

  • platform/qt/Skipped: Skip editing/spelling/spellcheck-async.html.
20:08 Changeset [101042] by yuqiang.xian@intel.com

Strength reduction for Mul and Mod operations for known constants in DFG
https://bugs.webkit.org/show_bug.cgi?id=72878

Reviewed by Filip Pizlo.

Also the code should be commonly shared by both 32_64 and 64.

  • dfg/DFGNode.h:

(JSC::DFG::nodeMayOverflow):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::isPowerOfTwo):
(JSC::DFG::logTwo):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

19:30 Changeset [101041] by dbates@webkit.org

Add WTF infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72970

Reviewed by Antonio Gomes.

  • wtf/Assertions.cpp: Added BlackBerry-specific logging directive.
  • wtf/MathExtras.h:

(abs): Added; stdlib doesn't contain abs() on QNX.

  • wtf/Platform.h: Define WTF_PLATFORM_BLACKBERRY and enable some platform features.
  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator): For the BlackBerry port, we initialize
the bad pseudo random number generator using time(3) before initializing the
Mersenne Twister random number generator.

  • wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal): Added.

  • wtf/blackberry: Added.
  • wtf/blackberry/MainThreadBlackBerry.cpp: Added.

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/text/WTFString.h: Added constructor and conversion operator for

BlackBerry WebString string object.

19:16 Changeset [101040] by cevans@google.com

Merge 100203
BUG=105143
Review URL: http://codereview.chromium.org/8673010

19:08 Changeset [101039] by cevans@google.com

Merge 100677
BUG=100958
Review URL: http://codereview.chromium.org/8674006

18:58 Changeset [101038] by alexis.menard@openbossa.org

Unreviewed : remove empty folders related to TouchWebView and DesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=72985

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-11-22

  • UIProcess/API/qt/tests/qmltests/DesktopWebView: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView: Removed.
18:51 Changeset [101037] by cevans@google.com

Merge 100630
BUG=101065
Review URL: http://codereview.chromium.org/8666016

18:15 Changeset [101036] by adamk@chromium.org

Add new WebKit/chromium/dbus directory to .gitignore.

  • .gitignore:
18:01 Changeset [101035] by kbr@google.com

[chromium] Support Core Animation plugins in compositor
https://bugs.webkit.org/show_bug.cgi?id=72921

Reviewed by Stephen White.

Source/WebCore:

Added support to PluginLayerChromium and CCPluginLayerImpl for
using an IOSurface as the backing store for a plugin. Added minimal
ARB_texture_rectangle support to Extensions3D.h and a Chromium-
specific extension for binding an IOSurface to a texture.

These changes themselves do not have any effect. A follow-on
Chromium CL will make the switch to this new code path.

Tested manually both with and without the Chromium side changes;
Chromium's DumpRenderTree port does not support Core Animation
plugins. Ran video and Stage3D in Flash, and Unity 3D content, to
verify.

  • platform/graphics/Extensions3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::pluginLayerTexRectProgram):
(WebCore::LayerRendererChromium::pluginLayerTexRectProgramFlip):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::getIOSurfaceId):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexRectFlipAlpha::getShaderString):
(WebCore::FragmentShaderRGBATexRectAlpha::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(PluginProgramBinding::TexStretchPluginProgramBinding::set):
(PluginProgramBinding::TexTransformPluginProgramBinding::set):
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):
(WebCore::CCPluginLayerImpl::setIOSurfaceProperties):
(WebCore::CCPluginLayerImpl::cleanupResources):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

Source/WebKit/chromium:

Added IOSurface support to WebPluginContainer. This code path is
used only on Mac OS X, but is defined in the header on all
platforms for simplicity.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):

  • public/WebPluginContainer.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::handleKeyboardEvent):

  • src/WebPluginContainerImpl.h:
17:58 Changeset [101034] by cevans@google.com

Merge 100827
BUG=103921
Review URL: http://codereview.chromium.org/8666014

16:44 Changeset [101033] by dcheng@chromium.org

Unreviewed. Fix ChangeLog typo in r101031.

16:44 Changeset [101032] by adamk@chromium.org

Remove some flaky expectations added by me five months ago.
Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:39 Changeset [101031] by dcheng@chromium.org

[chromium] Fix plumbing for differentiating between clipboard/selection pastes.
https://bugs.webkit.org/show_bug.cgi?id=72056

Reviewed by tony@chromium.org.

Source/WebCore:

Add a buffer parameter when retrieving the clipboard sequence number and fix several call
sites that incorrectly assume use of the standard buffer in pastes.

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):

  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::platformClipboardChanged):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::currentPasteboardBuffer):

  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add a buffer parameter when retrieving the clipboard sequence number.

  • public/WebClipboard.h:

(WebKit::WebClipboard::sequenceNumber):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardSequenceNumber):

16:24 Changeset [101030] by adamk@chromium.org

Make two accessibility tests as PASS TIMEOUT on Windows.
Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:12 Changeset [101029] by adamk@chromium.org

One more video-zoom-controls rebaseline for Linux GPU.

  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
15:09 Changeset [101028] by adamk@chromium.org

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Rebaseline these tests as they should be stable since r99937.

  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png.
  • platform/chromium-gpu-cg-mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-gpu-cg-mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-linux/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-linux/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-win-vista/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-win-vista/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-win-xp/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-win-xp/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-win-xp/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-win/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-win/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt.
  • platform/chromium/test_expectations.txt:
14:42 Changeset [101027] by adamk@chromium.org

Layout Test media/video-zoom-controls.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67913

Rebaseline video-zoom-controls: it had already been
partially-rebaselined for WinXP, so the options were to remove those
baselines and let the test fail as expected, mark it as passing on
only XP, or rebaseline with what seem to be reasonable visual changes
(along with some extra noise in the render tree).

Unreviewed gardening.

  • platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
  • platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
13:51 Changeset [101026] by adamk@chromium.org

Rebaselines and expectation-removal for now-passing Mac tests.
Unreviewed gardening.

  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/chromium/test_expectations.txt:
13:41 Changeset [101025] by scheib@chromium.org

Pointer Lock: Initial Tests for navigator.webkitPonter
https://bugs.webkit.org/show_bug.cgi?id=72659

Reviewed by Darin Fisher.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

Enabling PointerLock in TestShell

LayoutTests:

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • pointer-lock/mouse-event-api-expected.txt:
  • pointer-lock/mouse-event-api.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
12:39 Changeset [101024] by adamk@chromium.org

Unreviewed gardening, remove expectations for now-passing tests.

  • platform/chromium/test_expectations.txt:
12:30 Changeset [101023] by adamk@chromium.org

Expand slowness of dispatch-message-string-data.html to debug builds.
Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:28 Changeset [101022] by adamk@chromium.org

Ignore more gyp-generated build files in WTF.gyp.

  • .gitignore:
11:45 Changeset [101021] by commit-queue@webkit.org

Empty API for web intents
https://bugs.webkit.org/show_bug.cgi?id=69870

Patch by Greg Billock <gbillock@google.com> on 2011-11-22
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebIntent.h: Added.
  • public/WebIntentServiceInfo.h: Added.
  • public/WebFrame.h:
  • public/WebFrameClient.h:
11:39 Changeset [101020] by adamk@chromium.org

More rebaselines from Skia roll.
Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt.
11:13 Changeset [101019] by commit-queue@webkit.org

Update flakiness dashboard for new Chromium builders and tests
https://bugs.webkit.org/show_bug.cgi?id=72931

Patch by Ryan Sleevi <rsleevi@chromium.org> on 2011-11-22
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
11:10 Changeset [101018] by dpranke@chromium.org

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=72972

Add dbus in Chromium as pulled dep and update to HEAD.

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-22
Reviewed by Dirk Pranke.

  • DEPS:
11:08 Changeset [101017] by adamk@chromium.org

Expand MISSING expectation for form-associated-element-crash3.html.
Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [101016] by adamk@chromium.org

Mark file-writer-abort.html as flakily crashing on Mac Debug.
Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:55 Changeset [101015] by adamk@chromium.org

Mark some tests as passing after Skia roll in http://crrev.com/111151.

Unreviewed gardening.

  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:37 Changeset [101014] by caseq@chromium.org

Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966

Reviewed by Pavel Feldman.

  • always bind to {add,remove}EventListener() of event target, not WebInspector.Object
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):

10:35 Changeset [101013] by commit-queue@webkit.org

Fix .dir-locals.el to only apply to specific modes
https://bugs.webkit.org/show_bug.cgi?id=72963

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-22
Reviewed by Xan Lopez.

  • .dir-locals.el: Remove `nil' block, as it was causing

makefile-mode not to insert tabs.

10:33 Changeset [101012] by adamk@chromium.org

Move splitView.css (added in r100991) to the correct target.

  • WebCore.gypi:
10:30 Changeset [101011] by dpranke@chromium.org

Roll Chromium DEPS to r110960 and set the disable_nacl flag.
https://bugs.webkit.org/show_bug.cgi?id=72911

Unreviewed, build fix.

ppapi starts to depend on the NaCl gyp files as of r109739, so
we need to pass disable_nacl when running gyp to avoid pulling
in too much of NaCl.

  • DEPS:
  • gyp_webkit:
10:10 Changeset [101010] by adamk@chromium.org

Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
09:55 Changeset [101009] by adamk@chromium.org

Rebaselines after Skia roll (http://crrev.com/111151).

Unreviewed gardening.

  • platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
  • platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt.
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/chromium/test_expectations.txt:
09:42 Changeset [101008] by commit-queue@webkit.org

CSSProperty: Remove unnecessary operator overloads.
<http://webkit.org/b/72953>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-22
Reviewed by Antti Koivisto.

  • css/CSSProperty.cpp:
  • css/CSSProperty.h:

Remove operator= and operator== from CSSProperty. They were neither
implemented correctly nor used anywhere.

09:39 Changeset [101007] by commit-queue@webkit.org

CSSStyleDeclaration: Kill FIXME in setProperty().
<http://webkit.org/b/72958>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-22
Reviewed by Antonio Gomes.

Remove FIXME about possibly throwing an exception when setProperty()
is called with an invalid property name. CSSOM specifies that the
method should simply return in this case.

Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::setProperty):

09:03 Changeset [101006] by aroben@apple.com

Remove some debugging code I accidentally left in r101005

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python):

08:52 Changeset [101005] by aroben@apple.com

Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files

Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
classes/methods in Python source files

Reviewed by Dan Bates.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
or that use python as their interpreter. Modified the code that extracts the interpreter to
ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
scripts.
(get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
for class/def lines and generate ranges based on them.

08:43 Changeset [101004] by carlosgc@webkit.org

Ensure web process before starting a download
https://bugs.webkit.org/show_bug.cgi?id=72499

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download): Call ensureWebProcess().

07:40 Changeset [101003] by ossy@webkit.org

Unreviewed buildfix after r101001.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend): Use ASSERT_UNUSED instead of ASSERT.

07:39 Changeset [101002] by commit-queue@webkit.org

Source/WebCore: Spellcheck should be able to run asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=71991

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.

Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON.

When multiple asynchronous spellchecking are requested, only the first request will be processed.

Test: editing/spelling/spellcheck-async.html

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Uses asynchronous spell checker if asynchronous flag is ON.

LayoutTests: Spellcheck should be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=71991

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.

Added asynchronouse spell checking tests.
Fixed tests that fails tearing down.

  • editing/spelling/script-tests/spellcheck-paste.js: Fixed tearing down.
  • editing/spelling/spellcheck-async-expected.txt: Added.
  • editing/spelling/spellcheck-async.html: Added.
  • editing/spelling/spelling-unified-emulation.html: Fixed tearing down.
07:18 Changeset [101001] by pfeldman@chromium.org

cvel Feldman <pfeldman@google.com>

Not reviewed: moving inspector frontend creation out of assert in WebKit2.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp: (WebKit::WebInspectorClient::openInspectorFrontend):lean
06:43 Changeset [101000] by apavlov@chromium.org

Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
https://bugs.webkit.org/show_bug.cgi?id=72951

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

06:37 Changeset [100999] by pfeldman@chromium.org

2011-11-22 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector front-end compilation.

06:35 Changeset [100998] by commit-queue@webkit.org

Web Inspector: [chromium] fix internactive ui test for scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=72935

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-22
Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):

06:26 Changeset [100997] by commit-queue@webkit.org

Add WebCore platform interface needed by updated MediaStream API design
https://bugs.webkit.org/show_bug.cgi?id=70895

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-11-22
Reviewed by Adam Barth.

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Tests will be provided by http://webkit.org/b/56587

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::stopTimerFired):

  • mediastream/MediaStream.h:
  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::didRemoveRemoteStream):

  • mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):

  • mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaStreamCenter.cpp: Added.

(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenter::endLocalMediaStream):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):

  • platform/mediastream/MediaStreamCenter.h: Added.

(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptorOwner::~MediaStreamDescriptorOwner):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):

06:14 Changeset [100996] by commit-queue@webkit.org

[Qt][WK2] Fix and unskip loadHtml api test
https://bugs.webkit.org/show_bug.cgi?id=72916

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-22
Reviewed by Andreas Kling.

Now that linkHovered events are working again we can fix and unskip this
loadHtml test.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
06:11 Changeset [100995] by pfeldman@chromium.org

Web Inspector: remove Inspector::bringToFront from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=72937

Source/WebCore:

Inspector::bringToFront protocol method is currently used on the backend
in order to reveal the front-end window. We should do that by means of
the inspector client interface instead.

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::show):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::bringFrontendToFront):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::bringFrontendToFront):

  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::bringFrontendToFront):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::bringFrontendToFront):

  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::bringFrontendToFront):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):

Source/WebKit/qt:

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::bringFrontendToFront):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::bringFrontendToFront):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientWinCE.cpp:

(WebKit::InspectorClientWinCE::bringFrontendToFront):

  • WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

Reviewed by Yury Semikhatsky.

  • WebKitSupport/InspectorClientWx.cpp:

(WebCore::InspectorClientWx::bringFrontendToFront):

  • WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
05:40 Changeset [100994] by caseq@chromium.org

Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
https://bugs.webkit.org/show_bug.cgi?id=72899

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.addRevision):

  • inspector/front-end/externs.js:
05:38 Changeset [100993] by zoltan@webkit.org

[Qt] Build fix for MHTML support

  • Target.pri: Add missing includepath.
05:38 Changeset [100992] by caio.oliveira@openbossa.org

[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient
https://bugs.webkit.org/show_bug.cgi?id=72928

Reviewed by Andreas Kling.

Split PageLoadClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageLoadClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::loadProgress):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/ClientImpl.cpp:
  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageLoadClient.cpp: Added.

(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame):
(QtWebPageLoadClient::dispatchLoadSucceeded):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::setLoadProgress):
(toQtWebPageLoadClient):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFinishLoadForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(QtWebPageLoadClient::didStartProgress):
(QtWebPageLoadClient::didChangeProgress):
(QtWebPageLoadClient::didFinishProgress):

  • UIProcess/qt/QtWebPageLoadClient.h: Added.

(QtWebPageLoadClient::loadProgress):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::updateNavigationState):

  • UIProcess/qt/QtWebPageProxy.h:
05:24 Changeset [100991] by vsevik@chromium.org

Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
https://bugs.webkit.org/show_bug.cgi?id=72920

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheModel.js:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.sidebarResized):
(WebInspector.ElementsPanel.prototype.toggleSearchingForNode):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.wasShown):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.createSplitView):
(WebInspector.Panel.prototype.createSplitViewWithSidebarTree):
(WebInspector.Panel.prototype.sidebarResized):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.sidebarResized):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.sidebarResized):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.sidebarResized):

  • inspector/front-end/SplitView.js: Added.

(WebInspector.SplitView):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.sidebarResized):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refreshRecords):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/auditsPanel.css:
  • inspector/front-end/elementsPanel.css:
  • inspector/front-end/inspector.css:

(.sidebar):

  • inspector/front-end/inspector.html:
  • inspector/front-end/networkLogView.css:
  • inspector/front-end/networkPanel.css:

(#network-views):

  • inspector/front-end/profilesPanel.css:

(#profile-views):

  • inspector/front-end/resourcesPanel.css:
  • inspector/front-end/scriptsPanel.css:

(#scripts-split-view):

  • inspector/front-end/splitView.css: Added.
  • inspector/front-end/timelinePanel.css:

(.timeline .sidebar):
(.timeline-sidebar-background):
(#resources-container-content):

LayoutTests:

  • http/tests/inspector/network/network-sidebar-width.html:
05:21 Changeset [100990] by caio.oliveira@openbossa.org

[Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=72910

Reviewed by Andreas Kling.

Split PageUIClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageUIClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/ClientImpl.cpp:
  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/QtWebPageUIClient.cpp: Added.

(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::runJavaScriptAlert):
(QtWebPageUIClient::runJavaScriptConfirm):
(QtWebPageUIClient::runJavaScriptPrompt):
(QtWebPageUIClient::runOpenPanel):
(QtWebPageUIClient::setStatusText):
(QtWebPageUIClient::mouseDidMoveOverElement):
(toQtWebPageUIClient):
(createNullWKString):

  • UIProcess/qt/QtWebPageUIClient.h: Added.
04:58 Changeset [100989] by kbalazs@webkit.org

Unreviewed, rolling out r100988.
http://trac.webkit.org/changeset/100988
https://bugs.webkit.org/show_bug.cgi?id=72941

"Broke pixel tests on Chromium-Linux" (Requested by kbalazs on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-22

Source/JavaScriptCore:

  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:
  • wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

  • wtf/Platform.h:

Source/WebCore:

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:
  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

03:42 Changeset [100988] by kbalazs@webkit.org

Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

missing for the gyp build system.

Export symbols.

  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

  • wtf/ParallelJobsGeneric.h:
  • wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

03:14 Changeset [100987] by apavlov@chromium.org

Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
https://bugs.webkit.org/show_bug.cgi?id=72733

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getComputedStyleForNode):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::buildArrayForComputedStyle):

  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):

LayoutTests:

  • inspector/styles/styles-new-API.html:
01:57 Changeset [100986] by philn@webkit.org

Unreviewed, GTK rebaseline after r100979.

  • platform/gtk/accessibility/name-from-label-expected.txt:
01:52 Changeset [100985] by pfeldman@chromium.org

Web Inspector: strip unused InspectorController methods.
https://bugs.webkit.org/show_bug.cgi?id=72886

Source/WebCore:

This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009.
I am now able to remove following InspectorController methods:
::startUserInitiatedProfiling,
::isRecordingUserInitiatedProfile,
::stopUserInitiatedProfiling,
::showAndEnableDebugger,
::debuggerEnabled,
::disableDebugger,
::startTimelineProfiler,
::stopTimelineProfiler,
::timelineProfilerEnabled,
::showConsole.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • WebCore.order:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::setFrontend):

  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):

  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::resetState):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):

  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype.start):
(WebInspector.TimelineManager.prototype.stop):
(WebInspector.TimelineManager.prototype._started):
(WebInspector.TimelineManager.prototype._stopped):

  • inspector/front-end/inspector.js:

Source/WebKit/gtk:

Reviewed by Yury Semikhatsky.

  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):

01:34 Changeset [100984] by nduca@chromium.org

[chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result
https://bugs.webkit.org/show_bug.cgi?id=72688

Source/WebCore:

This allows CCInputFilter and CCLayerTreeHostImpl to
perform requestAnimationFrame-style animations. The bulk of
work here is to make the scheduler recover gracefully when you
call setNeedsRedraw inside scheduledActionDraw.

Reviewed by James Robinson.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore::CCInputHandlerTarget::CCInputHandlerTarget):
(WebCore::CCInputHandlerTarget::~CCInputHandlerTarget):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrame):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setInsideVSync):
(WebCore::CCSchedulerStateMachine::setOutsideVSync):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCScrollController.h: Removed.
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Reviewed by James Robinson.

  • src/WebCompositorImpl.cpp:

(WebCore::CCInputHandler::create):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::willDraw):

  • src/WebCompositorImpl.h:

(WebKit::WebCompositorImpl::create):

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::setScheduler):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::numDraws):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::hasMoreResourceUpdates):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionBeginFrame):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwap):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionUpdateMoreResources):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionCommit):
(WebKitTests::TEST):

01:32 Changeset [100983] by commit-queue@webkit.org

[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName().
https://bugs.webkit.org/show_bug.cgi?id=72850

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-22
Reviewed by Anders Carlsson.

The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and
windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory.

  • Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):

01:19 Changeset [100982] by reni@webkit.org

Unreviewed gardening. Reset test results.

Patch by Feher Zsolt <feherzs@inf.u-szeged.hu> on 2011-11-22

  • platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
01:18 Changeset [100981] by apavlov@chromium.org

Web Inspector: Design of the autocomplete suggest
https://bugs.webkit.org/show_bug.cgi?id=72798

Reviewed by Pavel Feldman.

Implemented a combination of grayed text for the first/only completion and hid
the suggest box for a single suggestion (the grayed text is displayed instead.)
Drive-by fix for the "trailing spaces in the prompt" issue
(got regressed when the suggest box was introduced for the first time.)

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView): Fix the "trailing spaces" issue

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.renderAsBlock): Fix the "trailing spaces" issue
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

00:50 Changeset [100980] by reni@webkit.org

[Qt] inspector/extensions/extensions-events.html crashing after r100926
https://bugs.webkit.org/show_bug.cgi?id=72932

Unreviewed gardening.

  • platform/qt/Skipped:
00:30 Changeset [100979] by mario@webkit.org

[GTK] platform/gtk/accessibility/name-from-label.html fails
https://bugs.webkit.org/show_bug.cgi?id=71665

Reviewed by Philippe Normand.

Fix layout test to properly consider 'form' accessibility objects.

  • platform/gtk/Skipped: Unskip name-from-label.html.
  • platform/gtk/accessibility/name-from-label.html: Re-write layout test to properly take into account the accessibility hierarchy.

11/21/11:

19:38 Changeset [100978] by yutak@chromium.org

[GTK] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72870

Reviewed by Xan Lopez.

Source/WebKit/gtk:

Change the settings value through DumpRenderTreeSupportGtk, because we do not
want to expose this as a public API.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled):
Change the value of a flag in WebCore::Settings.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):
Reset the setting value to the default value (true).

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):
Change the setting value through a function in DumpRenderTreeSupportGtk.

LayoutTests:

  • platform/gtk/Skipped:

Unskip WebSocket hybi tests. Skip two tests using FileSystem API, which is not yet
supported in GTK port.

19:19 Changeset [100977] by commit-queue@webkit.org

Unreviewed, rolling out r100970.
http://trac.webkit.org/changeset/100970
https://bugs.webkit.org/show_bug.cgi?id=72925

Caused AssociatedURLLoaderTest.Success to fail (Requested by
koz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

  • WebKit.gyp:
  • public/WebUserMediaClient.h: Removed.
  • public/WebUserMediaRequest.h: Removed.
  • public/WebViewClient.h:
  • src/UserMediaClientImpl.cpp: Removed.
  • src/UserMediaClientImpl.h: Removed.
  • src/WebUserMediaRequest.cpp: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:
19:15 Changeset [100976] by commit-queue@webkit.org

REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <davidbarr@chromium.org> on 2011-11-21
Reviewed by Dimitri Glazkov.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

  • fast/css/style-tag-display-none-expected.txt: Added.
  • fast/css/style-tag-display-none.html: Added.
  • fast/css/style-tag-display-none-expected.png: Added.
19:02 Changeset [100975] by fpizlo@apple.com

DFG should have richer debug output for CFA and phi processing
https://bugs.webkit.org/show_bug.cgi?id=72922

Reviewed by Gavin Barraclough.

In the default verbose mode, we now print information about variable
state at the bottom of basic blocks in addition to the top, and we
also print local variable linking. In the verbose propagation mode,
the state of phi processing is dumped more richly and CFA merging (the
most subtle part of CFA) is traced as well.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCommon.h:

(JSC::DFG::NodeIndexTraits::dump):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.h:

(JSC::DFG::Node::dumpChildren):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperands.h:

(JSC::DFG::OperandValueTraits::dump):
(JSC::DFG::dumpOperands):

18:59 Changeset [100974] by commit-queue@webkit.org

If an event listener is a function, it should be called and not checked for handleEvent.
This also covers callbacks, which follow the same spec but are implemented separately.
https://bugs.webkit.org/show_bug.cgi?id=62518

Patch by Rob Brackett <rob@robbrackett.com> on 2011-11-21
Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/events/dispatch-to-function-with-handle-event.html

fast/js/callback-function-with-handle-event.html

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

  • fast/events/dispatch-to-function-with-handle-event-expected.txt: Added.
  • fast/events/dispatch-to-function-with-handle-event.html: Added.
  • fast/js/callback-function-with-handle-event-expected.txt: Added.
  • fast/js/callback-function-with-handle-event.html: Added.
18:56 Changeset [100973] by fpizlo@apple.com

Should have a test for corner cases of DFG's integer optimization and CSE.
https://bugs.webkit.org/show_bug.cgi?id=72917

Reviewed by Sam Weinig.

  • fast/js/dfg-integer-optimization-expected.txt: Added.
  • fast/js/dfg-integer-optimization.html: Added.
  • fast/js/script-tests/dfg-integer-optimization.js: Added.

(doAdd):

18:15 Changeset [100972] by fpizlo@apple.com

Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505

Reviewed by Gavin Barraclough.

It turns out that we were corrupting phi nodes in case of overflow. The bug is
really obvious, but producing a test case that causes the badness is hard. Even
when the phi nodes do get corrupt, there's more that has to happen before it
causes incorrect execution - and I wasn't able to reproduce in any kind of
sensible reduced case.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):

17:27 Changeset [100971] by leviw@chromium.org

Adding pixel snapped methods for clientWidth/Height and moving internal callers to LayoutUnit versions.

17:20 Changeset [100970] by commit-queue@webkit.org

[chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-21
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebUserMediaClient.h: Added.

(WebKit::WebUserMediaClient::~WebUserMediaClient):

  • public/WebUserMediaRequest.h: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):

  • public/WebViewClient.h:

(WebKit::WebViewClient::userMediaClient):

  • src/UserMediaClientImpl.cpp: Added.

(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):

  • src/UserMediaClientImpl.h: Added.
  • src/WebUserMediaRequest.cpp: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator PassRefPtr<UserMediaRequest>):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:
17:01 Changeset [100969] by adamk@chromium.org

cr-linux rebaselines for r100949. Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-linux/fast/css/empty-inline-003-quirksmode-expected.png: Added.
  • platform/chromium-linux/fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • platform/chromium-linux/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
16:25 Changeset [100968] by adamk@chromium.org

Rebaseline after r100958. Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
15:31 Changeset [100967] by adamk@chromium.org

[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903

Reviewed by James Robinson.

Make this test dumpAsText(true) since what we really care about here is
pixel output.

  • compositing/geometry/clipped-video-controller-expected.txt: Added.
  • compositing/geometry/clipped-video-controller.html:
  • platform/chromium-win/compositing/geometry/clipped-video-controller-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/compositing/geometry/clipped-video-controller-expected.txt: Removed.
  • platform/mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.
15:27 Changeset [100966] by adamk@chromium.org

Optimistically remove expectations for a handful of no-longer-failing tests.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
15:13 Changeset [100965] by commit-queue@webkit.org

Need support for dirname attribute
https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-21
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html

fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
fast/forms/submit-form-with-dirname-attribute.html

  • html/HTMLAttributeNames.in:

Added "dirname" attribute.

  • html/HTMLInputElement.idl:

Add "dirName" property to HTMLInputElement interface.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.

  • html/HTMLTextAreaElement.idl:

Add "dirName" property to HTMLTextAreaElement interface.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.

  • html/HTMLTextFormControlElement.h:

Helper function for finding directionality of the Element.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.

  • html/TextFieldInputType.h:

Append dirname form data.

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Added.
  • fast/forms/form-dirname-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
  • fast/forms/submit-form-with-dirname-attribute.html: Added.
15:11 Changeset [100964] by eae@chromium.org

Chromium/linux and qt platform fixes

15:09 Changeset [100963] by jamesr@google.com

[chromium] Fix tiler initialization in TiledLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=72915

Reviewed by Kenneth Russell.

Setting the tile size or tiling option after the tiler is created invalidates it, and by default the newly
created tiler will have border texels so the test doesn't pass. Switch things around in the test so the tiler
is created only after all the options are set, which is closer to what the real code does.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

15:06 Changeset [100962] by adamk@chromium.org

Chromium rebaselines after r100949. Unreviewed.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-002-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-003-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-003-expected.txt.
  • platform/chromium-win/fast/css/empty-inline-003-quirksmode-expected.png: Added.
  • platform/chromium-win/fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • platform/chromium-win/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.png:
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.txt:
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.png:
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.txt:
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.png:
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.txt:
  • platform/chromium/fast/css/empty-inline-003-quirksmode-expected.png: Added.
  • platform/chromium/fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • platform/chromium/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
15:01 Changeset [100961] by rniwa@webkit.org

ChangeLogEntry should be able to parse entries with multiple authors
https://bugs.webkit.org/show_bug.cgi?id=72690

Reviewed by Eric Seidel.

Support multi-author change log entries in ChangeLogEntry. Split author names using
the same logic as splitting reviewer names. _authors now stores list of dictionaries
with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
accounts because some contributors are never listed in committers.py.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}

throws an exception when the argument is None.

15:00 Changeset [100960] by jamesr@google.com

Fix chromium compile bustage - base interface added a parameter so my fake wasn't actually implementing it.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::prepareToUpdate):

14:34 Changeset [100959] by commit-queue@webkit.org

IndexedDB: Close database connections, abort transactions, and terminate requests on stop()
https://bugs.webkit.org/show_bug.cgi?id=72066

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-21
Reviewed by Tony Chang.

No new tests; addresses race conditions on document navigate/script context stop.

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueEvent):

  • dom/DocumentEventQueue.h:
  • dom/EventQueue.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::stop):

  • storage/IDBDatabase.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::IDBFactory):
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

  • storage/IDBFactory.h:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):

  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):

  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerEventQueue.h:
14:22 Changeset [100958] by jamesr@google.com

[chromium] Avoid pushing dirty tiles to the impl layer
https://bugs.webkit.org/show_bug.cgi?id=72765

Reviewed by Kenneth Russell.

Source/WebCore:

If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even
if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not
displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do
decide to update the contents for that tile we can use partial results if they are still valid.

Covered by new unit test in TiledLayerChromiumTest.cpp

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::createTiler):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::setTextureFormat):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::hasTileAt):
(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

Source/WebKit/chromium:

Add unit test for TiledLayerChromium's tile pushing behavior. Requires a fair amount of fake classes. If these
fakes are useful in other tests, they should be moved to a shared location.

  • WebKit.gypi:
  • tests/TiledLayerChromiumTest.cpp: Added.

(::FakeTextureAllocator::createTexture):
(::FakeTextureAllocator::deleteTexture):
(::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::orientation):
(::FakeLayerTextureUpdater::sampledTexelFormat):
(::FakeLayerTextureUpdater::prepareToUpdate):
(::FakeLayerTextureUpdater::updateTextureRect):
(::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::hasTileAt):
(::FakeTiledLayerChromium::FakeTiledLayerChromium):
(::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(::FakeTiledLayerChromium::invalidateRect):
(::FakeTiledLayerChromium::prepareToUpdate):
(::FakeTiledLayerChromium::textureManager):
(::FakeTiledLayerChromium::createTextureUpdater):
(::FakeTiledLayerChromium::textureUpdater):
(::TEST):

14:10 Changeset [100957] by robert@webkit.org

Platform-specific results for r100949

Unreviewed gardening.

  • platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/gtk/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
  • platform/gtk/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • platform/gtk/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/qt/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
  • platform/qt/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • platform/qt/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
13:58 Changeset [100956] by mrowe@apple.com

Fix the SnowLeopard build.

  • Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was

not yet declared in a public header.

13:45 Changeset [100955] by alexis.menard@openbossa.org

[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=72612

Reviewed by Kenneth Rohde Christiansen.

Make sure that when the view is focused, the page knows about it.
Also set a the view to be the focused item in the failing tests.

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::isViewFocused):

13:40 Changeset [100954] by mrowe@apple.com

<http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name

Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
File Manager APIs.

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Link against DiskArbitration.framework. It lives in the shared cache

so it should add only negligible launch time overhead.

Source/WebKit/mac:

  • Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
the volume name from its description dictionary.

13:32 Changeset [100953] by adamk@chromium.org

Unreviewed gardening, remove expectations for no-longer-flakey media tests.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [100952] by hausmann@webkit.org

[Qt] Speed up debug builds.
https://bugs.webkit.org/show_bug.cgi?id=72882

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • Target.pri: Make BUILDING_JavaScriptCore available earlier, so it can be

used by the build system.

Source/WebCore:

  • Target.pri: Make BUILDING_WebCore available earlier, so it can be

used by the build system.

Source/WebKit2:

  • Target.pri: Make BUILDING_WebKit2 available, so it can be

used by the build system.

Tools:

Introduce a special type of build that replaces the static jsc/wc/wk2
static libraries with shared libraries, that individually are much faster
to link and don't require relinking into the big library when changing just
one file in one module. It can be enabled with
--qmakearg="CONFIG+=force_static_libs_as_shared"

  • qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,

disable symbol visibility, static linkage and enable rpath.

  • qmake/mkspecs/features/functions.prf: Add a helper function to determine if

we need to link the convenience libraries together or not and renamed linkStaticLibrary
to just linkLibrary (because linkage is not necessarily static).

  • qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also

link against jsc/wc/wk2 when linking app code against QtWebKit.

  • qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper

function.

  • qmake/mkspecs/features/webcore.prf: Ditto.
  • qmake/mkspecs/features/webkit2.prf: Ditto.
13:15 Changeset [100951] by adamk@chromium.org

Update flakiness dashboard linkification regexps for crbug.com/100000 and above
https://bugs.webkit.org/show_bug.cgi?id=72898

Reviewed by Ojan Vafai.

Also removed a comment that was going to be more trouble to keep up to
date than seemed worthwhile (the code is now the documentation).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
13:06 Changeset [100950] by alexis.menard@openbossa.org

[Qt] Remove unnecessary initialize method from QQuickWebView.
https://bugs.webkit.org/show_bug.cgi?id=72905

Reviewed by Kenneth Rohde Christiansen.

We don't need this level of indirection.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

  • UIProcess/API/qt/qquickwebview_p_p.h:
13:06 Changeset [100949] by robert@webkit.org

CSS 2.1 failure: empty-inline-003.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72638

Reviewed by Ryosuke Niwa.

Source/WebCore:

Empty inline elements need to share their inline height with siblings.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is
going to affect the line-height.
(WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox

LayoutTests:

  • css2.1/20110323/empty-inline-001.htm: Added.
  • css2.1/20110323/empty-inline-002.htm: Added.
  • css2.1/20110323/empty-inline-003.htm: Added.
  • fast/css/empty-inline-003-quirksmode-expected.png: Result can cover all platforms as there is no text apart from the period.
  • fast/css/empty-inline-003-quirksmode-expected.txt: ditto
  • fast/css/empty-inline-003-quirksmode.htm: empty-inline-003.htm should only pass in strict mode, this ensures it 'fails' in quirks mode.
  • fast/css/empty-inline-line-height-first-line-expected.png: Added.
  • fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
  • fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Result can cover all platforms as there is no text apart from the period.
  • fast/css/empty-inline-line-height-first-line-quirksmode.htm: Like empty-inline-003.htm, empty-inline-line-height-first-line.htm should also fail in quirks mode.
  • fast/css/empty-inline-line-height-first-line.htm: Like empty-inline-003.htm but ensures first-line style is respected for line-height in empty elements.
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/empty-inline-003-expected.txt: Added.
13:04 Changeset [100948] by dmazzoni@google.com

[Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
https://bugs.webkit.org/show_bug.cgi?id=72895

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

  • public/WebAccessibilityNotification.h:
  • src/AssertMatchingEnums.cpp:
  • src/ChromeClientImpl.cpp:

(WebKit::toWebAccessibilityNotification):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

13:01 Changeset [100947] by enne@google.com

[chromium] Remove incorrect render surface layer list asserts from compositor
https://bugs.webkit.org/show_bug.cgi?id=72744

Reviewed by James Robinson.

These asserts are incorrect, because it's valid for the default render
surface to be created but to have a root layer that doesn't draw. It
won't get added to the single render surface and it'll have an empty
layer list.

Test: compositor_unittests

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

12:40 Changeset [100946] by andreas.kling@nokia.com

Unreviewed WinCE build fix after r100874.

  • WebCoreSupport/EditorClientWinCE.h:
  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::respondToChangedSelection):

Add WebCore::Frame* parameter to respondToChangedSelection().

12:36 Changeset [100945] by adamk@chromium.org

Rebaseline font-face-opentype.html on cr-mac-leopard.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-opentype-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-opentype-expected.png.
12:34 Changeset [100944] by senorblanco@chromium.org

Unreviewed gardening.

Updated baselines for two SVG tests. These tests have been passing for a while, but the expectations were either stale or completely wrong.

  • platform/chromium-cg-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/chromium/test_expectations.txt:
12:24 Changeset [100943] by adamk@chromium.org

Unreviewed gardening, broaden expecations for inspector test.

  • platform/chromium/test_expectations.txt:
12:05 Changeset [100942] by adamk@chromium.org

Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Unreviewed gardening, marking test as PASS TEXT.

  • platform/chromium/test_expectations.txt:
11:38 Changeset [100941] by adamk@chromium.org

[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark as PASS TEXT
11:22 Changeset [100940] by adamk@chromium.org

Add GYP-generated WTF.xcodeproj to .gitignore after r100851.

  • .gitignore:
11:16 Changeset [100939] by adamk@chromium.org

Layout Test perf/array-push-pop.html is slow
https://bugs.webkit.org/show_bug.cgi?id=72901

Mark test as SLOW PASS.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:09 Changeset [100938] by philn@webkit.org

Unreviewed, run-gtk-tests temporary workaround after r98500.

  • Scripts/run-gtk-tests: Try to find the build directory like in

build-gtkdoc, until webkit-build-directory --configuration gets fixed.

11:02 Changeset [100937] by steveblock@google.com

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for
inspector/styles/styles-disable-then-change.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:59 Changeset [100936] by vrk@chromium.org

Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758

Reviewed by Eric Carlson.

  • http/tests/media/video-cookie-expected.txt:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-referer.html:
10:46 Changeset [100935] by commit-queue@webkit.org

StyleSheet: Move completeURL() to CSSStyleSheet.
<http://webkit.org/b/72888>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Since completeURL() is only used on CSSStyleSheets, move it there (and make
it non-virtual) to make StyleSheet a little leaner.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::completeURL):

  • css/CSSStyleSheet.h:
  • css/StyleSheet.cpp:
  • css/StyleSheet.h:
10:40 Changeset [100934] by kevino@webkit.org

[wx] Fix image translation calculations.
https://bugs.webkit.org/show_bug.cgi?id=72892

Reviewed by Kevin Ollivier.

10:35 Changeset [100933] by kevino@webkit.org

Add wxWebKit APIs for controlling WebKit caching behavior.
https://bugs.webkit.org/show_bug.cgi?id=72891

Reviewed by Kevin Ollivier.

10:31 Changeset [100932] by kevino@webkit.org

Add wxWebKit API for retrieving frame and page URLs.
https://bugs.webkit.org/show_bug.cgi?id=72890

Reviewed by Kevin Ollivier.

10:17 Changeset [100931] by commit-queue@webkit.org

copyright comment style to C from C++ for gamepad module
https://bugs.webkit.org/show_bug.cgi?id=72894

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-21
Reviewed by Sam Weinig.

Just changes comment format, no code/test changes.

  • Modules/gamepad/Gamepad.cpp:
  • Modules/gamepad/Gamepad.h:
  • Modules/gamepad/Gamepad.idl:
  • Modules/gamepad/GamepadList.cpp:
  • Modules/gamepad/GamepadList.h:
  • Modules/gamepad/GamepadList.idl:
09:55 Changeset [100930] by commit-queue@webkit.org

Consolidate the many copies of Ahem in our tests
https://bugs.webkit.org/show_bug.cgi?id=72503

Patch by Philip Rogers <pdr@google.com> on 2011-11-21
Reviewed by Andreas Kling.

  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-download-error.html:
  • fast/css/font-face-in-shadow-DOM.html-disabled:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-families.html:
  • fast/css/font-face-opentype.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-repeated-url.html:
  • fast/css/font-face-unicode-range.html:
  • fast/css/font-face-unused-source-loaded.html:
  • fast/css/font-face-woff.html:
  • fast/css/font-face-zero-hash-key.html:
  • fast/css/resources/Ahem.otf: Removed.
  • fast/css/resources/Ahem.ttf: Removed.
  • fast/css/resources/Ahem.woff: Removed.
  • inspector/audits/resources/Ahem.ttf: Removed.
  • inspector/extensions/extensions-network-expected.txt:
  • inspector/extensions/extensions-network.html:
  • inspector/extensions/resources/Ahem.ttf: Removed.
  • platform/gtk/fonts/font-face-with-complex-text.html:
  • platform/gtk/fonts/resources/Ahem.ttf: Removed.
  • platform/gtk/fonts/synthetic-oblique-positioning.html:
  • resources/Ahem.otf: Added.
  • resources/Ahem.woff: Added.
  • webarchive/resources/Ahem.ttf: Removed.
  • webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
  • webarchive/test-css-url-resources-in-stylesheets.html:
  • webarchive/test-css-url-resources-inline-styles-expected.webarchive:
  • webarchive/test-css-url-resources-inline-styles.html:
09:50 Changeset [100929] by pfeldman@chromium.org

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: unskip inspector test on chromium.
https://bugs.webkit.org/show_bug.cgi?id=72887

  • platform/chromium/test_expectations.txt:
09:43 Changeset [100928] by pfeldman@chromium.org

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: unskip inspector tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=70414
https://bugs.webkit.org/show_bug.cgi?id=70905
https://bugs.webkit.org/show_bug.cgi?id=72493

  • platform/qt/Skipped:
09:40 Changeset [100927] by commit-queue@webkit.org

Implement a setter for UnifiedTextCheckerEnabled.
https://bugs.webkit.org/show_bug.cgi?id=72872

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Darin Fisher.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setUnifiedTextCheckerEnabled): Added.

  • src/WebSettingsImpl.h:
09:30 Changeset [100926] by pfeldman@chromium.org

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake inspector test.

  • inspector/extensions/extensions-events.html:
09:24 Changeset [100925] by commit-queue@webkit.org

JSC/CSSOM: Merge root() for style declaration objects.
<http://webkit.org/b/72881>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*),
removing a duplicated chunk and making it a little easier on the eyes.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

09:18 Changeset [100924] by steveblock@google.com

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectations for
inspector/styles/styles-change-node-while-editing.html and
inspector/styles/styles-disable-inherited.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
09:15 Changeset [100923] by jesus@webkit.org

[Qt][WK2] Implement loadHtml API for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=72161

Reviewed by Simon Hausmann.

Implement QQuickWebView::loadHtml that calls QtWebPageProxy::loadHTMLString.
This function will use WKPageLoadHTMLString in order to load HTML from a given string.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::loadHtml):

  • UIProcess/API/qt/qquickwebview.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadHTMLString):

  • UIProcess/qt/QtWebPageProxy.h:
09:03 Changeset [100922] by igor.oliveira@openbossa.org

[WK2][Qt] Move Accelerated Composite animations to UIProcess

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimationsRecursively):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::didFireViewportUpdateTimer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

08:56 Changeset [100921] by andreas.kling@nokia.com

Unreviewed Mac gardening, rebaselining MediaController failures after r100159.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
08:48 Changeset [100920] by ossy@webkit.org

[Qt] [WK2] WebKitTestRunner doesn't build in debug
https://bugs.webkit.org/show_bug.cgi?id=72827

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-21
Reviewed by Andreas Kling.

Add exports to fix WebKitTestRunner debug build.

  • Source/qtwebkit-export.map:
08:21 Changeset [100919] by carlosgc@webkit.org

[GTK] Add a way to skip unit tests in the bots
https://bugs.webkit.org/show_bug.cgi?id=72879

Reviewed by Philippe Normand.

Rewrite the script in python to make it easier for everybody to
change it and add support for skipping tests.

  • Scripts/run-gtk-tests:
08:19 Changeset [100918] by steveblock@google.com

REGRESSION(r100906): Broke inspector/extensions/extensions-events.html (Requested by steveblock on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=72887

Add a TIMEOUT expectation

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
08:13 Changeset [100917] by caryclark@google.com

Unreviewed rebaselining: Re-enable most layout tests on chromium-mac-leopard.

  • platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png:
  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
  • platform/chromium/test_expectations.txt:
07:47 Changeset [100916] by kbalazs@webkit.org

Unreviewed, rolling out r100913.
http://trac.webkit.org/changeset/100913
https://bugs.webkit.org/show_bug.cgi?id=72885

"Break Windows build" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

Source/JavaScriptCore:

  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:
  • wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

  • wtf/Platform.h:

Source/WebCore:

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:
  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

07:37 Changeset [100915] by commit-queue@webkit.org

[EFL] Add more appcache functions to ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72143

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Add a few more functions to make it possible to have more control over
the offline web application features.

  • ewk/ewk_settings.cpp:

(ewk_settings_application_cache_max_quota_get):
(ewk_settings_application_cache_max_quota_set):
(ewk_settings_application_cache_clear):

  • ewk/ewk_settings.h:

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setAppCacheMaximumSize): Use the right
function, this is not related to the memory cache, but rather to the
appcache.

LayoutTests:

LayoutTestController::clearAllApplicationCaches is implemented now.

  • platform/efl/Skipped:
07:19 Changeset [100914] by pfeldman@chromium.org

Web Inspector: [WebKit2] Do not access InspectorController from the "Develop" menu code.
https://bugs.webkit.org/show_bug.cgi?id=63009

Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):

  • WebProcess/WebPage/WebInspector.h:
07:16 Changeset [100913] by kbalazs@webkit.org

Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

missing for the gyp build system.

Export symbols.

  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

  • wtf/ParallelJobsGeneric.h:
  • wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

07:15 Changeset [100912] by aroben@apple.com

Make NRWT consider all lines of output from parse-malloc-history, not just the first

Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
found" even when there are more than 1 unique leaks

Reviewed by Darin Adler.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
"" will be considered to match the beginning of any line, not only the beginning of the
string.

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
fake output and updated expectations to match.

07:04 Changeset [100911] by pfeldman@chromium.org

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating expectations for the inspector console test (Qt -> all).

  • inspector/console/console-format-expected.txt:
  • platform/qt/inspector/console/console-format-expected.txt: Removed.
06:59 Changeset [100910] by abecsi@webkit.org

[Qt] Clean up MiniBrowser project file after recent changes
https://bugs.webkit.org/show_bug.cgi?id=72869

Reviewed by Simon Hausmann.

Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.

  • MiniBrowser/qt/MiniBrowser.pro:
06:41 Changeset [100909] by antti@apple.com

Remove CSSStyleSelector::m_additionalAttributeStyleDecls field
https://bugs.webkit.org/show_bug.cgi?id=72876

Reviewed by Andreas Kling.

There is no reason for this temporary to be a field.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

  • css/CSSStyleSelector.h:
06:37 Changeset [100908] by pfeldman@chromium.org

Web Inspector: [REGRESSION] Assertion failed in ScriptsPanel.js
https://bugs.webkit.org/show_bug.cgi?id=72877

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ScriptsPanel.js:
06:13 Changeset [100907] by steveblock@google.com

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/show-user-agent-styles.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
05:37 Changeset [100906] by pfeldman@chromium.org

Web Inspector: get rid of Panel::reset in the front-end.
https://bugs.webkit.org/show_bug.cgi?id=72587

I'm slowly getting rid of the Inspector protocol domain. It currently
contains methods that did not find their home in the meaningful domains.
This change removes reset protocol method.

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didCommitLoad):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerDispatcher.prototype.globalObjectCleared):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._mainFrameNavigated):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext.prototype.get frameId):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._frameDetached):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._reset):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):
(WebInspector.WorkerManager.prototype._mainFrameNavigated):

  • inspector/front-end/inspector.js:
05:28 Changeset [100905] by caio.oliveira@openbossa.org

[Qt] Add WebView.view attached property support for dialogs in QML
https://bugs.webkit.org/show_bug.cgi?id=72825

Reviewed by Simon Hausmann.

.:

Export QQuickWebViewAttached.

  • Source/qtwebkit-export.map:

Source/WebKit2:

When creating new dialogs, fill their WebView.view attached property
with the WebView that's creating them. This follows the same pattern
as QtQuick's ListView, enabling the usage of the same dialog component
for different WebViews.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::setViewInAttachedProperties):
(QQuickWebViewAttached::QQuickWebViewAttached):
(QQuickWebViewAttached::setView):
(QQuickWebView::qmlAttachedProperties):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner::dialog):

05:20 Changeset [100904] by pfeldman@chromium.org

2011-11-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: an attempt to fix windows build.

  • WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled):
04:54 Changeset [100903] by pfeldman@chromium.org

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Source/WebCore:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js: Added.

(InspectorFrontendAPI.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isJavaScriptProfilingEnabled):
(InspectorFrontendAPI.setJavaScriptProfilingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get profilerEnabled):
(WebInspector.ProfilesPanel.prototype.enableProfiler):
(WebInspector.ProfilesPanel.prototype.disableProfiler):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
(WebInspector.ScriptsPanel.prototype.enableDebugging):
(WebInspector.ScriptsPanel.prototype.disableDebugging):
(WebInspector.ScriptsPanel.prototype.toggleDebugging):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
(WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
(WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

Source/WebKit/mac:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController destroyInspectorView:]):

  • WebInspector/WebInspector.mm:

(-showWindow):
(-show:):
(-showConsole:):
(-isDebuggingJavaScript):
(-toggleDebuggingJavaScript:):
(-startDebuggingJavaScript:):
(-stopDebuggingJavaScript:):
(-isProfilingJavaScript):
(-toggleProfilingJavaScript:):
(-startProfilingJavaScript:):
(-stopProfilingJavaScript:):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-isTimelineProfilingEnabled):
(-setTimelineProfilingEnabled:):
(-setFrontend:):
(-releaseFrontend):
(-showWindow:):

  • WebInspector/WebInspectorFrontend.h:
  • WebInspector/WebInspectorFrontend.mm:

(-[WebInspectorFrontend isDebuggingEnabled]):
(-[WebInspectorFrontend setDebuggingEnabled:]):
(-[WebInspectorFrontend isProfilingJavaScript]):
(-[WebInspectorFrontend startProfilingJavaScript]):
(-[WebInspectorFrontend stopProfilingJavaScript]):
(-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
(-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
(-[WebInspectorFrontend isTimelineProfilingEnabled]):
(-[WebInspectorFrontend setTimelineProfilingEnabled:]):

  • WebInspector/WebInspectorPrivate.h:

Source/WebKit/win:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

LayoutTests:

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

04:48 Changeset [100902] by commit-queue@webkit.org

Add .dir-locals.el file for better Emacs defaults
https://bugs.webkit.org/show_bug.cgi?id=72483

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-21
Reviewed by Xan Lopez.

  • .dir-locals.el: Set appropriate directory-local variables for Emacs.
04:46 Changeset [100901] by steveblock@google.com

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/styles-cancel-editing.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
04:19 Changeset [100900] by apavlov@chromium.org

Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles
https://bugs.webkit.org/show_bug.cgi?id=72701

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):

  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._innerUpdate):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
04:19 Changeset [100899] by noel.gordon@gmail.com

Update .gitignore for latest WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=72851

Reviewed by Andreas Kling.

  • .gitignore: updates to silence 'git status' about WebKitLibraries files.
04:14 Changeset [100898] by carlosgc@webkit.org

[GTK] Update NEWS and configure.ac for 1.7.2 release
https://bugs.webkit.org/show_bug.cgi?id=72868

Reviewed by Xan Lopez.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.2.
04:02 Changeset [100897] by steveblock@google.com

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for jquery/offset.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:11 Changeset [100896] by commit-queue@webkit.org

Unreviewed, rolling out r100856.
http://trac.webkit.org/changeset/100856
https://bugs.webkit.org/show_bug.cgi?id=72867

New test fast/css/style-tag-display-none.html fails on
Chromium (Requested by steveblock on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

Source/WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

  • fast/css/style-tag-display-none-expected.txt: Removed.
  • fast/css/style-tag-display-none.html: Removed.
02:29 Changeset [100895] by jochen@chromium.org

Implement Meta referrer
https://bugs.webkit.org/show_bug.cgi?id=72674

Reviewed by Adam Barth.

Source/WebCore:

http://wiki.whatwg.org/wiki/Meta_referrer

Tests: http/tests/security/referrer-policy-always.html

http/tests/security/referrer-policy-default.html
http/tests/security/referrer-policy-https-always.html
http/tests/security/referrer-policy-https-default.html
http/tests/security/referrer-policy-https-never.html
http/tests/security/referrer-policy-https-origin.html
http/tests/security/referrer-policy-never.html
http/tests/security/referrer-policy-origin.html
http/tests/security/referrer-policy-redirect.html
http/tests/security/referrer-policy-rel-noreferrer.html

  • WebCore.exp.in: updated
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):

  • dom/Document.h:

(WebCore::Document::referrerPolicy):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader):

  • page/SecurityPolicy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebReferrerPolicy.h: Added.
  • public/WebSecurityPolicy.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::referrerPolicy):
(WebKit::WebFrameImpl::setReferrerForRequest):

  • src/WebFrameImpl.h:
  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::generateReferrerHeader):

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

LayoutTests:

  • http/tests/security/referrer-policy-always-expected.txt: Added.
  • http/tests/security/referrer-policy-always.html: Added.
  • http/tests/security/referrer-policy-default-expected.txt: Added.
  • http/tests/security/referrer-policy-default.html: Added.
  • http/tests/security/referrer-policy-https-always-expected.txt: Added.
  • http/tests/security/referrer-policy-https-always.html: Added.
  • http/tests/security/referrer-policy-https-default-expected.txt: Added.
  • http/tests/security/referrer-policy-https-default.html: Added.
  • http/tests/security/referrer-policy-https-never-expected.txt: Added.
  • http/tests/security/referrer-policy-https-never.html: Added.
  • http/tests/security/referrer-policy-https-origin-expected.txt: Added.
  • http/tests/security/referrer-policy-https-origin.html: Added.
  • http/tests/security/referrer-policy-never-expected.txt: Added.
  • http/tests/security/referrer-policy-never.html: Added.
  • http/tests/security/referrer-policy-origin-expected.txt: Added.
  • http/tests/security/referrer-policy-origin.html: Added.
  • http/tests/security/referrer-policy-redirect-expected.txt: Added.
  • http/tests/security/referrer-policy-redirect.html: Added.
  • http/tests/security/referrer-policy-rel-noreferrer-expected.txt: Added.
  • http/tests/security/referrer-policy-rel-noreferrer.html: Added.
  • http/tests/security/resources/referrer-policy-log.php: Added.
  • http/tests/security/resources/referrer-policy-redirect.html: Added.
  • http/tests/security/resources/referrer-policy-start.html: Added.
  • http/tests/security/resources/rel-noreferrer.html: Added.
02:22 Changeset [100894] by vsevik@chromium.org

Web Inspector: ApplicationCache view should show navigator.onLine indicator.
https://bugs.webkit.org/show_bug.cgi?id=72618

Reviewed by Pavel Feldman.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::enable):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.get onLine):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):

01:55 Changeset [100893] by carlosgc@webkit.org

Unreviewed. Fix make distcheck build.

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:
01:50 Changeset [100892] by dmazzoni@google.com

Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
https://bugs.webkit.org/show_bug.cgi?id=72479

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/multiselect-list-reports-active-option.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelectedOptionActive):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSelectedOptionActive):

Source/WebKit/chromium:

Test: accessibility/multiselect-list-reports-active-option.html

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isSelectedOptionActive):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getIsSelectedOptionActiveCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isSelectedOptionActiveGetterCallback):

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isSelectedOptionActive):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

  • accessibility/multiselect-list-reports-active-option.html: Added.
  • platform/chromium/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
01:42 Changeset [100891] by yutak@chromium.org

[Qt] WebSocket close tests are failing
https://bugs.webkit.org/show_bug.cgi?id=72865

Reviewed by Simon Hausmann.

Source/WebCore:

  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::close):
Emit didCloseSocketStream() callback even before the connection is established.
Call m_socket->abort() to prevent "connected" signal from firing.

LayoutTests:

  • platform/qt/Skipped:

Unskip five WebSocket tests. Remove "failing websocket tests" section,
as there are no tests in this section.

01:20 Changeset [100890] by commit-queue@webkit.org

Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=72847

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Hajime Morita.

Covered by existing test.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

Passes Range to requestCheckingFor instead of Node.

  • editing/SpellChecker.cpp: Changed argument type from Node to Range. The corresponding changes are also done in dependent methods.

(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):

Changed argument type from Node to Range.

(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:
01:12 Changeset [100889] by commit-queue@webkit.org

Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
https://bugs.webkit.org/show_bug.cgi?id=72859

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-21
Reviewed by Eric Seidel.

  • Scripts/new-run-webkit-websocketserver:
00:37 Changeset [100888] by fpizlo@apple.com

Another attempt at a build fix.

  • dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

11/20/11:

22:28 Changeset [100887] by commit-queue@webkit.org

[Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=72655

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-20
Reviewed by Hajime Morita.

Tools:

Fixed the calculation of offset.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::finishLastTextCheck):

LayoutTests:

Fixed the calculation of offset, and added test cases having multiple misspelled words.

  • editing/spelling/script-tests/spellcheck-paste.js: Added test cases having multiple misspelled words.

(verifyMarker):
(tests):

  • editing/spelling/spellcheck-paste-expected.txt: Recreated.
22:10 Changeset [100886] by bashi@chromium.org

[Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs.
https://bugs.webkit.org/show_bug.cgi?id=72844

Source/WebCore:

Respects bold and italic properties that is given by fontconfig.

Reviewed by Darin Fisher.

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters): Removed #if and old logic.

Source/WebKit/chromium:

Removes old APIs for getting font family for given characters.

Reviewed by Darin Fisher.

  • public/linux/WebFontInfo.h: Removed old familyForChars().
  • public/linux/WebSandboxSupport.h: Removed old getFontFamilyForCharacters() and changed new getFontFamilyForCharacters() to be a pure virtual function.
  • src/linux/WebFontInfo.cpp: Removes old familyForChars().

LayoutTests:

Font selection mechanism of Chromium Linux port has been improved. Rebaselines affected tests.

Reviewed by Darin Fisher.

  • platform/chromium-linux/fast/text/cg-fallback-bolding-expected.png:
  • platform/chromium-linux/fast/text/cg-fallback-bolding-expected.txt:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
21:37 Changeset [100885] by commit-queue@webkit.org

Rebaseline for border change in r100528
https://bugs.webkit.org/show_bug.cgi?id=72689

Patch by Ben Wells <benwells@chromium.org> on 2011-11-20
Reviewed by Stephen White.

  • platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
  • platform/chromium-mac/fast/borders/mixed-border-styles-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
  • platform/chromium/test_expectations.txt:
21:18 Changeset [100884] by noel.gordon@gmail.com

[chromium] Remove qt/QtMobileWebStyle from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72843

Reviewed by Antonio Gomes.

platform/qt/QtMobileWebStyle.{h,cpp} were removed in r100123

  • WebCore.gypi: remove platform/qt/QtMobileWebStyle.{h,cpp}
21:03 Changeset [100883] by fpizlo@apple.com

Unreviewed interpreter build fix.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

  • dfg/DFGRepatch.h:
21:01 Changeset [100882] by haraken@chromium.org

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.h:
20:47 Changeset [100881] by yuqiang.xian@intel.com

Improve modulo operation on 32bit platforms
https://bugs.webkit.org/show_bug.cgi?id=72501

Reviewed by Filip Pizlo.

Extend softModulo to support X86 and MIPS in baseline JIT.
Apply the same optimization to 32bit DFG JIT.
1% gain on Kraken, tested on Linux Core i7 Nehalem 32bit.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::softModulo):

  • wtf/Platform.h:
20:45 Changeset [100880] by fpizlo@apple.com

Inline caches that refer to otherwise dead objects should be cleared
https://bugs.webkit.org/show_bug.cgi?id=72311

Reviewed by Geoff Garen.

DFG code blocks now participate in the weak reference harvester fixpoint
so that they only consider themselves to be live if either they are
currently executing, or their owner is live and all of their weak references
are live. If not, the relevant code blocks are jettisoned.

Inline caches in both the old JIT and the DFG are now cleared if any of
their references are not marked at the end of a GC.

This is performance-neutral on SunSpider, V8, and Kraken. With the clear-
all-code-on-GC policy that we currently have, it shows a slight reduction
in memory usage. If we turn that policy off, it's pretty easy to come up
with an example program that will cause ToT to experience linear heap
growth, while with this patch, the heap stays small and remains at a
constant size.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::readCallTarget):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::readCallTarget):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::readCallTarget):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::readCallTarget):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::MethodCallLinkInfo::reset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):

  • bytecode/Instruction.h:

(JSC::PolymorphicAccessStructureList::visitWeak):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::reset):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

  • dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::clearToMaxUnsigned):

20:35 Changeset [100879] by fpizlo@apple.com

Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The bytecode generator was assuming that call_varargs never reuses the base register
(i.e. the function being called) for the result. This is no longer true.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/function-dot-apply-replace-base-expected.txt: Added.
  • fast/js/function-dot-apply-replace-base.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js:

(done):

  • fast/js/script-tests/function-dot-apply-replace-base.js: Added.

(foo):
(bar):

19:32 Changeset [100878] by fpizlo@apple.com

DFG 32_64 should directly store double virtual registers on SetLocal
https://bugs.webkit.org/show_bug.cgi?id=72845

Reviewed by Oliver Hunt.

2% win on Kraken.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

18:26 Changeset [100877] by abarth@webkit.org

REGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets
https://bugs.webkit.org/show_bug.cgi?id=72836

Reviewed by Sam Weinig.

Source/WebCore:

This patch removes a (minor) security mitigation. Previously, we tried
sequester "directory listings" into unique origins to make it more
difficult for an attacker to crawl the user's local file system.
Unfortunately, this mitigation doesn't really buy us much security
because if the attacker has access to local files, we've probably lost
anyway.

The larger problem, however, is that this condition is overly
complicated and has broken in sublte ways several times in its
(relatively short) lifetime. In the cases reported in this bug, we see
that this check affects error pages in Safari and Growl notifications,
even those have nothing to do with directory listings.

If we have our heart set on this directory listing mitigation, we'll
need a more robust way of triggering the behavior than examining URLs
and guess whether they contain directory listings. For example, if we
implement Allow-From or Access-Control-Deny-Origin, then the embedder
can supply those policies along with the directory listings. Those
seem like much better solutions than the in-engine hack this patch
removes.

  • page/SecurityOrigin.cpp:

(WebCore::shouldTreatAsUniqueOrigin):

LayoutTests:

Update test results to show that XMLHttpRequets for directory listings
aren't blocked.

  • fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html:
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
18:03 Changeset [100876] by noel.gordon@gmail.com

[chromium] Remove DFG::JITCodeGenerator from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72842

Reviewed by Filip Pizlo.

dfg/DFGJITCodeGenerator.{h,cpp} were removed in r100244

17:26 Changeset [100875] by ojan@chromium.org

Change the final place where we use version 3 of the results json output
https://bugs.webkit.org/show_bug.cgi?id=72838

Reviewed by Adam Barth.

This converts the json from being a flat map of test name --> results
to being hierarchical by directory. This will make the json files
considerably smaller.

Also cleaned up some functions that were returning/checking boolean values
that were always True.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
15:55 Changeset [100874] by tonikitoo@webkit.org

2011-10-17 Antonio Gomes <agomes@rim.com>

Pass a Frame* parameter in EditorClient::respondToChangedSelection
https://bugs.webkit.org/show_bug.cgi?id=70248

Reviewed by Ryosuke Niwa.

Most of the port specific implementations of EditorClient::respondToChangedSelection
(like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
method to get the Frame where the selection is happening on.

It is not right, since a selection can be easily triggered in an inner
frame that is not focused.

No new tests since it is a hard thing to test without
to hook into editor client in layout tests. We could
change the "Dumped Delegate" messages, but it would
require a rebasile of +1200 for a minor change.

No new tests since it is a hard thing to test without
to hook into editor client in layout tests. We could
change the "Dumped Delegate" messages, but it would
require a rebasile of +1200 for a minor change.

Source/WebCore:

  • editing/Editor.cpp: Pass the Frame on where the selection is changing to the client. (WebCore::Editor::respondToChangedSelection): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Ditto. (WebCore::EmptyEditorClient::respondToChangedSelection):
  • page/EditorClient.h: Pass Frame* to indicate where the selection is happening.
  • loader/EmptyClients.h: Changed signature as per base class change.

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp: Make use of the newly added Frame* parameter. (WebKit::EditorClientImpl::respondToChangedSelection):
  • src/EditorClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientEfl::respondToChangedSelection):
  • WebCoreSupport/EditorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp: Make use of the newly added Frame* parameter. (WebKit::EditorClient::respondToChangedSelection):
  • WebCoreSupport/EditorClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h: Make use of the newly added Frame* parameter.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientQt::respondToChangedSelection):
  • WebCoreSupport/EditorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter. (WebEditorClient::respondToChangedSelection):
  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientWx::respondToChangedSelection):
  • WebKitSupport/EditorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter. (WebKit::WebEditorClient::respondToChangedSelection):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
15:40 Changeset [100873] by ojan@chromium.org

Include the master name when querying the test results server.
This will soon be required since leaving the master name out mean
that multiple files could match the query.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
14:55 Changeset [100872] by mrowe@apple.com

<http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/mac/WebCoreNSStringExtras.mm:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::reportErrorToClient):

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

Source/WebKit2:

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
08:40 Changeset [100871] by abarth@webkit.org

Add WebNode::hasEventListeners for Android
https://bugs.webkit.org/show_bug.cgi?id=72817

Reviewed by Darin Fisher.

Expose this EventTarget interface in the Chromium WebKit API for use by
Android.

  • public/WebNode.h:
  • src/WebNode.cpp:

(WebKit::WebNode::hasEventListeners):

08:38 Changeset [100870] by abarth@webkit.org

[Chromium] Add GestureFlingStart and GestureFlingCancel to WebGestureEvent for Android
https://bugs.webkit.org/show_bug.cgi?id=72819

Reviewed by Darin Fisher.

These gesture types are used with FlingAnimator for scrolling.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isScrollGestureEventType):
(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

08:36 Changeset [100869] by abarth@webkit.org

[Chromium] Add WebInputEventFactory for Android
https://bugs.webkit.org/show_bug.cgi?id=67890

Reviewed by Darin Fisher.

Like every Chromium OS, Android needs a WebInputFactory.

  • WebKit.gyp:
  • public/android/WebInputEventFactory.h: Added.
  • src/android/WebInputEventFactory.cpp: Added.

11/19/11:

20:25 Changeset [100868] by kevino@webkit.org

[wx] Build fix after GeneratedImage refactoring.

20:19 Changeset [100867] by kevino@webkit.org

[wx] C++ bindings build fix for move of array classes to WTF.

18:12 Changeset [100866] by jamesr@google.com

[chromium] Update various compositing baselines and expectations.

  • platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Copied from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/video-page-visibility-expected.png:
  • platform/chromium/test_expectations.txt:
18:09 Changeset [100865] by ojan@chromium.org

Fix jsonp callback code to add the callback if json content
is not jsonp.

  • TestResultServer/handlers/testfilehandler.py:
17:52 Changeset [100864] by ojan@chromium.org

Modify dashboard_base.js to optionally accept version 4 results json.

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-11-19
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/dashboard_base.js:

(ADD_RESULTS):
(flattenTrie):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testFlattenTrie):

17:47 Changeset [100863] by ojan@chromium.org

Stop storing results files as jsonp in the test results server
https://bugs.webkit.org/show_bug.cgi?id=72814

Reviewed by Adam Barth.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
17:13 Changeset [100862] by ojan@chromium.org

Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
https://bugs.webkit.org/show_bug.cgi?id=72813

Reviewed by Adam Barth.

Once this lands, we can start storing pure json in the test results server and then
we can delete the code with all the FIXMEs added here.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

Only add jsonp for full_results.json.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:

Accept pure json uploads.

  • TestResultServer/static-dashboards/dashboard_base.js:

(appendJSONScriptElementFor):
Use the callback parameter so that the server can start returning pure json if it's left out.

16:04 Changeset [100861] by ojan@chromium.org

Allow json NRWT downloads to be pure json and not jsonp
https://bugs.webkit.org/show_bug.cgi?id=72809

Reviewed by Adam Barth.

I'm moving the server to storing and serving up raw json instead of jsonp.
You can still get the jsonp by passing a "callback" parameter, but there's no
need for run-webkit-tests to get jsonp when all it wants is the raw json.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

Make the wrapper stripping only happen if the json is actually wrapped.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
12:51 Changeset [100860] by commit-queue@webkit.org

Move gamepad to Modules/ (+ some cleanup)
https://bugs.webkit.org/show_bug.cgi?id=72785

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-19
Reviewed by Adam Barth.

Source/WebCore:

Move main files from page/ to Modules/gamepad/. #include guard the
gamepad header inclusions in Navigator.cpp to avoid including for
ports that do not enable GAMEPAD.

  • Modules/gamepad/Gamepad.cpp: Renamed from Source/WebCore/page/Gamepad.cpp.

(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):

  • Modules/gamepad/Gamepad.h: Renamed from Source/WebCore/page/Gamepad.h.
  • Modules/gamepad/Gamepad.idl: Renamed from Source/WebCore/page/Gamepad.idl.
  • Modules/gamepad/GamepadList.cpp: Renamed from Source/WebCore/page/GamepadList.cpp.

(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):

  • Modules/gamepad/GamepadList.h: Renamed from Source/WebCore/page/GamepadList.h.

(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):

  • Modules/gamepad/GamepadList.idl: Renamed from Source/WebCore/page/GamepadList.idl.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • page/Navigator.cpp:

LayoutTests:

Use standard pre/post js test harness rather than custom one.

  • gamepad/gamepad-api-expected.txt:
  • gamepad/gamepad-api.html:
  • gamepad/gamepad-test.js: Removed.
12:15 Changeset [100859] by commit-queue@webkit.org

Unreviewed, rolling out r100834.
http://trac.webkit.org/changeset/100834
https://bugs.webkit.org/show_bug.cgi?id=72806

this patch makes Qt run-webkit-test exit before finishing
(Requested by igoroliveira on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-19

Source/WebCore:

  • platform/graphics/texmap/TextureMapperNode.cpp:
  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

12:08 Changeset [100858] by commit-queue@webkit.org

Remove WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h because
JSObjectWithGlobalObject.h has been removed.
https://bugs.webkit.org/show_bug.cgi?id=72794

r94701 removed JSObjectWithGlobalObject.h.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-11-19
Reviewed by Oliver Hunt.

  • ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Removed.
09:32 Changeset [100857] by vsevik@chromium.org

Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp
https://bugs.webkit.org/show_bug.cgi?id=72734

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json:
07:34 Changeset [100856] by commit-queue@webkit.org

REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <davidbarr@chromium.org> on 2011-11-19
Reviewed by Antti Koivisto.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

  • fast/css/style-tag-display-none-expected.txt: Added.
  • fast/css/style-tag-display-none.html: Added.
04:52 Changeset [100855] by nduca@chromium.org

Unreviewed, rolling out r100854.
http://trac.webkit.org/changeset/100854

Rollout DEPS roll. Made chromium bots cry.

  • DEPS:
04:24 Changeset [100854] by nduca@chromium.org

Unreviewed. Rolled DEPS 109696->110838

  • DEPS:
03:28 Changeset [100853] by hausmann@webkit.org

[Qt] Add the map file symbols export as a dependency of the final qmake target.
https://bugs.webkit.org/show_bug.cgi?id=72740

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-11-19
Reviewed by Simon Hausmann.

Add the symbols file part of the target dependencies.

  • Source/api.pri:
00:45 Changeset [100852] by jcivelli@chromium.org

When loading a MHTML document, make sure we set the base URL before
we notify the frame was committed (so the document has the right base
URL when the notification happens).
https://bugs.webkit.org/show_bug.cgi?id=72788

Reviewed by Adam Barth.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

00:25 Changeset [100851] by abarth@webkit.org

Integrate Source/WTF with the Chromium build system
https://bugs.webkit.org/show_bug.cgi?id=72790

Reviewed by Eric Seidel.

Source/WebCore:

Add a dependency on the new WTF.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Add a dependency on the new WTF.

  • WebKit.gyp:

Source/WTF:

Rename the target in this file to "newwtf" to avoid naming conflicts.

  • WTF.gyp/WTF.gyp:
00:09 Changeset [100850] by abarth@webkit.org

WTF should have an Xcode project
https://bugs.webkit.org/show_bug.cgi?id=71752

Patch by Mark Rowe <mrowe@apple.com> on 2011-11-19
Reviewed by Adam Barth.

This adds an Xcode project that includes only Stub.cpp and Stub.h.
They’re built in to a library at the appropriate path for each
configuration (WebKitBuild/{Debug,Release}/libWTF.a and
/usr/local/lib/libWTF.a) and headers are installed in to the
appropriate location (WebKitBuild/{Debug,Release}/usr/local/include/wtf
and /usr/local/include/wtf). I tested building WTF in this project and
everything appears to build except for DateMath.cpp (due to bug 71747).
I have not yet done any work on making JavaScriptCore and other
projects use the built products of this new project.

  • Configurations: Added.
  • Configurations/Base.xcconfig: Copied from Source/JavaScriptCore/Configurations/Base.xcconfig.
  • Configurations/CompilerVersion.xcconfig: Copied from Source/JavaScriptCore/Configurations/CompilerVersion.xcconfig.
  • Configurations/DebugRelease.xcconfig: Copied from Source/JavaScriptCore/Configurations/DebugRelease.xcconfig.
  • Configurations/WTF.xcconfig: Copied from Source/WebKit2/Configurations/Shim.xcconfig.
  • WTF.xcodeproj: Added.
  • WTF.xcodeproj/project.pbxproj: Added.
  • config.h: Copied from Source/JavaScriptCore/config.h.
  • icu: Added.
  • icu/LICENSE: Copied from Source/JavaScriptCore/icu/LICENSE.
  • icu/README: Copied from Source/JavaScriptCore/icu/README.
  • icu/unicode: Added.
  • icu/unicode/parseerr.h: Copied from Source/JavaScriptCore/icu/unicode/parseerr.h.
  • icu/unicode/platform.h: Copied from Source/JavaScriptCore/icu/unicode/platform.h.
  • icu/unicode/putil.h: Copied from Source/JavaScriptCore/icu/unicode/putil.h.
  • icu/unicode/uchar.h: Copied from Source/JavaScriptCore/icu/unicode/uchar.h.
  • icu/unicode/ucnv.h: Copied from Source/JavaScriptCore/icu/unicode/ucnv.h.
  • icu/unicode/ucnv_err.h: Copied from Source/JavaScriptCore/icu/unicode/ucnv_err.h.
  • icu/unicode/ucol.h: Copied from Source/JavaScriptCore/icu/unicode/ucol.h.
  • icu/unicode/uconfig.h: Copied from Source/JavaScriptCore/icu/unicode/uconfig.h.
  • icu/unicode/uenum.h: Copied from Source/JavaScriptCore/icu/unicode/uenum.h.
  • icu/unicode/uiter.h: Copied from Source/JavaScriptCore/icu/unicode/uiter.h.
  • icu/unicode/uloc.h: Copied from Source/JavaScriptCore/icu/unicode/uloc.h.
  • icu/unicode/umachine.h: Copied from Source/JavaScriptCore/icu/unicode/umachine.h.
  • icu/unicode/unorm.h: Copied from Source/JavaScriptCore/icu/unicode/unorm.h.
  • icu/unicode/urename.h: Copied from Source/JavaScriptCore/icu/unicode/urename.h.
  • icu/unicode/uscript.h: Copied from Source/JavaScriptCore/icu/unicode/uscript.h.
  • icu/unicode/uset.h: Copied from Source/JavaScriptCore/icu/unicode/uset.h.
  • icu/unicode/ustring.h: Copied from Source/JavaScriptCore/icu/unicode/ustring.h.
  • icu/unicode/utf.h: Copied from Source/JavaScriptCore/icu/unicode/utf.h.
  • icu/unicode/utf16.h: Copied from Source/JavaScriptCore/icu/unicode/utf16.h.
  • icu/unicode/utf8.h: Copied from Source/JavaScriptCore/icu/unicode/utf8.h.
  • icu/unicode/utf_old.h: Copied from Source/JavaScriptCore/icu/unicode/utf_old.h.
  • icu/unicode/utypes.h: Copied from Source/JavaScriptCore/icu/unicode/utypes.h.
  • icu/unicode/uversion.h: Copied from Source/JavaScriptCore/icu/unicode/uversion.h.

11/18/11:

23:19 Changeset [100849] by commit-queue@webkit.org

[Chromium] [WebSocket] export WebSocketChannel interface for plugins
https://bugs.webkit.org/show_bug.cgi?id=72016

Source/WebCore:

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

Add a interface to send raw binary data.
This interface is used by WebWebSocketChannel implementation
in WebKit API.

No new tests because just export a interface.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:

Source/WebKit/chromium:

Add WebSocket and WebSocketClient to WebKit API.

Currently, only WebSocketStreamHandle class is exported to WebKit API.
WebSocketStreamHandle implements bi-directional communication ports.
If plugins handles the WebSocket protocol, WebSocketChannel and
WebSocketChannelClient must be exported as WebSocket because they are
the classes which implement the WebSocket protocol stack.

Normally, we use WebWebSocketChannel and WebWebSocketChannelClient as
their class names. But here we use just WebSocket and WebSocketClient
because of avoiding WebWeb prefix and class name confliction on
header include.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebSocket.h: Added.

(WebKit::WebSocket::~WebSocket):

  • public/WebSocketClient.h: Added.

(WebKit::WebSocketClient::~WebSocketClient):

  • src/WebRuntimeFeatures.cpp: Insert websockets directory to include path in order to avoid filename confliction.

(WebKit::WebRuntimeFeatures::enableSockets): Use WebCore namespace explicitly.

  • src/WebSocket.cpp: Added.

(WebKit::WebSocket::create):

  • src/WebSocketImpl.cpp: Added.

(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::~WebSocketImpl):
(WebKit::WebSocketImpl::connect):
(WebKit::WebSocketImpl::subprotocol):
(WebKit::WebSocketImpl::sendText):
(WebKit::WebSocketImpl::sendBinary):
(WebKit::WebSocketImpl::bufferedAmount):
(WebKit::WebSocketImpl::close):
(WebKit::WebSocketImpl::fail):
(WebKit::WebSocketImpl::disconnect):
(WebKit::WebSocketImpl::didConnect):
(WebKit::WebSocketImpl::didReceiveMessage):
(WebKit::WebSocketImpl::didReceiveBinaryData):
(WebKit::WebSocketImpl::didReceiveMessageError):
(WebKit::WebSocketImpl::didStartClosingHandshake):
(WebKit::WebSocketImpl::didClose):

  • src/WebSocketImpl.h: Added.

(WebKit::WebSocketImpl::isNull):

23:11 Changeset [100848] by mihnea@adobe.com

Pixel results missing for fast/regions/render-region-custom-style-mark.html
https://bugs.webkit.org/show_bug.cgi?id=72775

Reviewed by Adam Barth.

  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Added.
22:05 Changeset [100847] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=72591
Remove document.width / document.height

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Darin Adler.

Source/WebCore:

Removed document.width/document.height from JS bindings,
but keeping the same for ObjC bindings. Also it should use
document.body.clientWidth and document.body.clientHeight instead.

  • html/HTMLDocument.idl:

LayoutTests:

As support for document.width / document.height has been
removed it should use document.body.clientWidth and document.body.clientHeight
respectively.

  • fast/dom/document-width-height-force-layout-expected.txt:
  • fast/dom/document-width-height-force-layout.html:

Modified test case to use document.body.clientWidth and document.body.clientHeight.

  • fullscreen/video-specified-size-expected.txt:
  • fullscreen/video-specified-size.html:

Modified test case to use document.body.clientWidth.

21:24 Changeset [100846] by mrobinson@webkit.org

Fix the GTK+ build.

  • page/Navigator.idl: Properly disable the webkitGamepads API if gamepad

isn't enabled at compile time.

21:10 Changeset [100845] by yutak@chromium.org

[Qt] Unreviewed, add one failing test to the Skipped list.

  • platform/qt/Skipped:
19:56 Changeset [100844] by dbates@webkit.org

Add CMake build infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72768

.:

Reviewed by Adam Barth and Antonio Gomes.

  • Source/CMakeLists.txt: Add the BlackBerry port and support for building on QNX.
  • Source/cmake/OptionsBlackBerry.cmake: Added.
  • Source/cmake/OptionsCommon.cmake: Add QNX QCC-variant of CODE_GENERATOR_PREPROCESSOR. We may be able to fold this into the non-MSVC CODE_GENERATOR_PREPROCESSOR.

Source/JavaScriptCore:

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake: Added.
  • shell/PlatformBlackBerry.cmake: Added.
  • wtf/PlatformBlackBerry.cmake: Added.

Source/WebCore:

Reviewed by Antonio Gomes.

  • CMakeLists.txt: At this time the BlackBerry port doesn't support generating DOM bindings from the SVG IDLs. See WebKit bug #72773.
  • PlatformBlackBerry.cmake: Added.

Source/WebKit:

Reviewed by Antonio Gomes.

  • blackberry: Added.
  • blackberry/CMakeListsBlackBerry.txt: Added.

Tools:

Reviewed by Antonio Gomes.

Add optional --blackberry command line argument to build-webkit to build the
BlackBerry port.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isBlackBerry): Added.
(determineIsBlackBerry): Added.
(blackberryTargetArchitecture): Added.
(isAppleWebKit):

19:40 Changeset [100843] by adamk@chromium.org

Add another isfinite assertion failure for fast/borders/
https://bugs.webkit.org/show_bug.cgi?id=72053

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
19:18 Changeset [100842] by adamk@chromium.org

Unreviewed, rolling out r100826.
http://trac.webkit.org/changeset/100826
https://bugs.webkit.org/show_bug.cgi?id=72786

Broke Chromium Mac build (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

  • page/ChromeClient.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
19:05 Changeset [100841] by adamk@chromium.org

Rebaseline after r100819.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png.
  • platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt.
19:04 Changeset [100840] by jamesr@google.com

Fix reviewed by lines in ChangeLogs

19:02 Changeset [100839] by jamesr@google.com

[chromium] composited layers are blurry with a zoom-in page scale factor
https://bugs.webkit.org/show_bug.cgi?id=71225

Source/WebCore:

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

Pass contents scale factor to the compositor such that it can:

  1. Adjust contentBounds() of the compositoer layers with content scale.
  2. Apply the content scale in the painter for texture update in better resolution.
  3. Apply the content scale to the dirty rect in CanvasLayerTextureUpdater.

This change fixed blurry problem for all tiled layer types and is not limited to
position:fixed layers.

Tests: compositing/geometry/fixed-position-composited-page-scale-down.html

compositing/geometry/fixed-position-composited-page-scale.html
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
compositing/geometry/fixed-position-transform-composited-page-scale.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::contentsScale):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
(WebCore::ImageLayerChromium::needsContentsScale):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::needsContentsScale):
(WebCore::LayerChromium::contentsScale):

  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::needsContentsScale):
(WebCore::TiledLayerChromium::contentBounds):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

Implements GraphicsLayerClient to return values for pageScaleFactor and deviceScaleFactor. They are used to determine contents scale factor compositer layers.

  • src/PageOverlay.cpp:

(WebKit::OverlayGraphicsLayerClientImpl::deviceScaleFactor):
(WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):

LayoutTests:

Added test cases that has position:fixed and page scale.

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

  • compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-page-scale.html: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale.html: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:43 Changeset [100838] by abarth@webkit.org

Move manual-tests out of WebCore.

18:40 Changeset [100837] by jamesr@google.com

Unreviewed, rolling out r100835.
http://trac.webkit.org/changeset/100835
https://bugs.webkit.org/show_bug.cgi?id=72778

Broke some page scale tests

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

18:36 Changeset [100836] by abarth@webkit.org

Prepare to move manual-tests out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=72782

Reviewed by Eric Seidel.

.:

Update these files to refer to the new location of ManualTests.

  • .gitattributes:
  • Source/cmake/WebKitPackaging.cmake:

Tools:

Update this file to refer to the new location of ManualTests.

  • Scripts/webkitpy/common/config/build.py:
18:25 Changeset [100835] by jamesr@google.com

[chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
https://bugs.webkit.org/show_bug.cgi?id=72778

Reviewed by Kenneth Russell.

Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

18:23 Changeset [100834] by igor.oliveira@openbossa.org

[WK2][Qt] Move Accelerated Composite animations to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=72753

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimationsRecursively):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::updateSceneGraphUpdateTimerFired):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

18:03 Changeset [100833] by commit-queue@webkit.org

IDL changes for gamepad support
https://bugs.webkit.org/show_bug.cgi?id=71753

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-18
Reviewed by Adam Barth.

Source/WebCore:

IDL changes and associated plumbing to expose list of gamepad objects
on navigator object (per current spec). Full patch is
https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
test until more plumbing in future patches.

Test: gamepad/gamepad-api.html

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):

  • page/Gamepad.cpp: Added.

(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):

  • page/Gamepad.h: Added.
  • page/Gamepad.idl: Added.
  • page/GamepadList.cpp: Added.

(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):

  • page/GamepadList.h: Added.

(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):

  • page/GamepadList.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitGamepads):

  • page/Navigator.h:
  • page/Navigator.idl:

Source/WebKit/chromium:

Update to use vendor-prefixed enable.

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

Tools:

Runtime enable gamepad in chromium test shell.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Add basic api existence test.

  • gamepad/gamepad-api-expected.txt: Added.
  • gamepad/gamepad-api.html: Added.
  • gamepad/gamepad-test.js: Added.

(logConsole):
(testExpected):
(reportExpected):
(waitForEventAndEnd):
(waitForEvent._eventCallback):
(waitForEvent):
(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):
(endTest):
(logResult):
(consoleWrite):

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
17:48 Changeset [100832] by commit-queue@webkit.org

Unreviewed, rolling out r100693.
http://trac.webkit.org/changeset/100693
https://bugs.webkit.org/show_bug.cgi?id=72779

This patch caused a rendering regression (see bug 72770)
(Requested by philip on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

  • fast/layers/layer-absolute-parent-opacity-expected.png: Removed.
  • fast/layers/layer-absolute-parent-opacity-expected.txt: Removed.
  • fast/layers/layer-absolute-parent-opacity.html: Removed.
17:17 Changeset [100831] by simon.fraser@apple.com

Reflection on composited element doesn't update if the element changes to show no content
https://bugs.webkit.org/show_bug.cgi?id=72774

Source/WebCore:

Reviewed by Chris Marrin.

When a style change results in a reflected element losing its backing store,
we need to clear the backing stores on the layer clones as well.

Test: compositing/reflections/become-simple-composited-reflection.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateLayerDrawsContent):

LayoutTests:

Reviewed by Chris Marrin.

Test that removes the background-color of a reflected, composited element.

  • compositing/reflections/become-simple-composited-reflection-expected.png: Added.
  • compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
  • compositing/reflections/become-simple-composited-reflection.html: Added.
17:12 Changeset [100830] by rniwa@webkit.org

Convert the encoding of JavaScriptGlue/Change from MacRoman to UTF-8 as it should be.

17:00 Changeset [100829] by fpizlo@apple.com

DFG JIT fails speculation on InstanceOf if the base is not an object
https://bugs.webkit.org/show_bug.cgi?id=72709

Reviewed by Geoff Garen.

InstanceOf already leverages the fact that we only allow the default
hasInstance implementation. So, if the base is predicted to possibly
be not an object and the CFA has not yet proven otherwise, InstanceOf
will abstain from speculating cell and instead return false if the
base is not a cell.

This appears to be a 1% speed-up on V8 on the V8 harness. 3-4% or so
speed-up in earley-boyer. Neutral according to bencher on SunSpider,
V8, and Kraken. In 32-bit, it's a 0.5% win on SunSpider and a 1.9%
win on V8 even on my harness, due to a 12.5% win on earley-boyer.

I also took this opportunity to make the code for InstanceOf common
between the two JITs. This was partially successful, in that the
"common code" has a bunch of #if's, but overall it seems like a code
size reduction.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:46 Changeset [100828] by dcheng@chromium.org

[chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
https://bugs.webkit.org/show_bug.cgi?id=72767

Source/WebCore:

Reviewed by Tony Chang.

Covered by existing tests.

  • editing/chromium/EditorChromium.cpp:

(WebCore::Editor::newGeneralClipboard):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::createDraggingClipboard):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::storageMode):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::hasData):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • src/WebDragData.cpp:

(WebKit::WebDragData::initialize):
(WebKit::WebDragData::assign):

LayoutTests:

  • platform/chromium/test_expectations.txt:
16:43 Changeset [100827] by cevans@google.com

Crash with ranges across a detached, reparented node tree
https://bugs.webkit.org/show_bug.cgi?id=72757

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/move-detached-child-in-range.html

  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::childBefore): protect the raw child node from getting pulled from under us.

LayoutTests:

  • fast/dom/move-detached-child-in-range-expected.txt: Added.
  • fast/dom/move-detached-child-in-range.html: Added.
16:31 Changeset [100826] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=72551
When the recommended scrollbar style changes, WKView's tracking options should
adjust accordingly
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This new ChromeClient function is called when the recommended scrollbar style
changes. This way, WebKit can respond to the change by adjusting its mouse
tracking.

  • page/ChromeClient.h:

(WebCore::ChromeClient::recommendedScrollbarStyleDidChange):

Existing ScrollableArea function scrollbarStyleChanged() now takes an int
indicating the new scrollbar style and a bool indicating whether it is necessary
to force an update. It used to be the case that this function was ONLY used to
force an update (and only called when an updated was needed), but now that it must
also call into the ChromeClient, it is necessary to include a bool tracking
whether we need to force an update. New implementation on FrameView is responsible
for calling ChromeClient, and then that calls into the pre-existing ScrollView
function for the forceUpdate part.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollbarStyleChanged):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView:: scrollbarStyleChanged):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

These new functions take care of passing along the
recommendedScrollbarStyleDidChange() message that originates in the ChromeClient.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::recommendedScrollbarStyleDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

This is where we actually respond to the recommendedScrollbarStyleDidChange
message. We remove the existing tracking area and create a new tracking area with
the appropriate tracking options.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

BuiltInPDFView inherits from WebCore::ScrollableArea, so scrollbarStyleChanged()
must now take two parameters like the one in ScrollableArea.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
16:29 Changeset [100825] by adamk@chromium.org

Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758

Allow these tests to timeout until the bug is fixed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:23 Changeset [100824] by knorton@google.com

Fixes several more void functions in RenderObject that return values.
https://bugs.webkit.org/show_bug.cgi?id=72750

Reviewed by Adam Barth.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateBeforeAfterContent):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):

16:14 Changeset [100823] by commit-queue@webkit.org

[chromium] Add some useful text to existing debug dump
https://bugs.webkit.org/show_bug.cgi?id=72576

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-18
Reviewed by James Robinson.

No new tests needed.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::dumpSurface):

16:12 Changeset [100822] by mhahnenberg@apple.com

Forgot to completely de-virtualize isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=72763

Reviewed by Darin Adler.

  • runtime/JSActivation.h: Removed virtual keyword.
15:35 Changeset [100821] by darin@chromium.org

2011-10-24 Darin Fisher <darin@chromium.org>

[chromium] Improve fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=70477

Reviewed by Adam Barth.

Move fullscreen entry points from WebView to WebWidget since they are
just about widget geometry.

Delay webkitfullscreenchange event until we know that we have entered
fullscreen mode. This is accomplished by expanding the WebKit APIs to
differentiate will{Enter,Exit} from did{Enter,Exit} state changes.

WebViewImpl is forced to keep a reference to the requested fullscreen
element while we are requesting to enter fullscreen mode. Once in
fullscreen mode, we switch to keeping only a reference to the Frame
containing the fullscreen element, which we drop upon exiting
fullscreen mode.

  • public/WebView.h:
  • public/WebViewClient.h:
  • public/WebWidget.h: (WebKit::WebWidget::willEnterFullScreen): (WebKit::WebWidget::didEnterFullScreen): (WebKit::WebWidget::willExitFullScreen): (WebKit::WebWidget::didExitFullScreen):
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::enterFullScreen): (WebKit::WebWidgetClient::exitFullScreen):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullscreenForNode): (WebKit::ChromeClientImpl::enterFullscreenForNode): (WebKit::ChromeClientImpl::exitFullscreenForNode): (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::willEnterFullScreen): (WebKit::WebViewImpl::didEnterFullScreen): (WebKit::WebViewImpl::willExitFullScreen): (WebKit::WebViewImpl::didExitFullScreen): (WebKit::WebViewImpl::enterFullScreenForElement): (WebKit::WebViewImpl::exitFullScreenForElement):
  • src/WebViewImpl.h:
15:29 Changeset [100820] by fpizlo@apple.com

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Darin Adler.

Fix this for 32_64.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

15:22 Changeset [100819] by xji@chromium.org

REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
https://bugs.webkit.org/show_bug.cgi?id=70395

Reviewed by Tony Chang.

Source/WebCore:

This patch fixes the problem in Mac and Chromium Mac.

The existing test fast/dom/rtl-scroll-to-leftmost-and-resize.html seems does not really work in Mac DRT
(the browswer window is not resized). It works in Chromium-Mac. And Chromium-Mac's code
is forked from Mac.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):

LayoutTests:

The test still marks as FAIL in test_expectations because cg-mac might need rebase.

  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
15:16 Changeset [100818] by eae@chromium.org

Merging trunk changes up until 100802 into subpixel branch.

15:09 Changeset [100817] by mrobinson@webkit.org

REGRESSION (r99924): broke 2 pasteboard tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=72131

Reviewed by Tony Chang.

Source/WebCore:

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::clearData): Call clearAll now.
(WebCore::ClipboardGtk::clearAllData): Call clearAllExceptFilenames now.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::clearAllExceptFilenames): Renamed from clear.
(WebCore::DataObjectGtk::clearAll): Added this method which also clear filenames.

  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/PasteboardGtk.cpp: Call clear before setting new clipboard data.

(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::clearClipboardContentsCallback): Use the clearAll method now.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::setSelectionPrimaryClipboardIfNeeded): Use the new clearAll method.

LayoutTests:

  • platform/gtk/Skipped: Unskip passing tests.
15:01 Changeset [100816] by commit-queue@webkit.org

[Qt][Wk2] Add an API test for scroll request from javascript
https://bugs.webkit.org/show_bug.cgi?id=72407

New API test added for QQuickWebView for javascript scroll request
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-11-18
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/tests/html/scroll.html: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

14:52 Changeset [100815] by adamk@chromium.org

Layout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72761

Mark test as PASS TIMEOUT as it occasionally times out on the bots.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
14:43 WebKit Team edited by michelangelo@webkit.org
(diff)
14:35 Changeset [100814] by timothy@apple.com

New tag.

14:33 Changeset [100813] by timothy@apple.com

Versioning.

14:26 Changeset [100812] by tony@chromium.org

[chromium] The exclusions tests are all passing. Remove the
test_expectations.txt entry for them.

  • platform/chromium/test_expectations.txt:
14:24 Changeset [100811] by adamk@chromium.org

[chromium] Test fast/events/dropzone-002.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=61625

Test is no longer failing since the end of October.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
14:13 Changeset [100810] by mhahnenberg@apple.com

De-virtualize ExecutableBase::intrinsic
https://bugs.webkit.org/show_bug.cgi?id=72548

Reviewed by Oliver Hunt.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic): Dynamic cast to NativeExecutable. If successful, call intrinsic, otherwise return default value.

  • runtime/Executable.h:
  • runtime/JSCell.h:

(JSC::jsDynamicCast): Add jsDynamicCast that duplicates the functionality of dynamic_cast in C++ but uses ClassInfo
rather than requiring C++ RTTI.

13:52 Changeset [100809] by bdakin@apple.com

<rdar://problem/10466170> Regression: Scroll bars disappear and don't come back

Reviewed by Sam Weinig.

Fixing a merge issue. On TOT we use #if USE(SCROLLBAR_PAINTER), but on the branch
it is still #if USE(WK_SCROLLBAR_PAINTER). Also, on the branch, all of the
m_scrollbarPainterController functions go through WebKitSystemInterface instead of
using forward declaration. We should consider merging those changes, but in the
meantime, for this to work, we have to go back to the branch-style.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notityPositionChanged):

13:42 Changeset [100808] by adamk@chromium.org

Rebaseline chromium expectations after r100800.
Note that previous rebaseline was actually meant for r100786.

Unreviewed gardening.

  • platform/chromium-win/animations/additive-transform-animations-expected.png: Added.
  • platform/chromium-win/animations/additive-transform-animations-expected.txt: Added.
  • platform/chromium/animations/additive-transform-animations-expected.png: Added.
13:39 Changeset [100807] by adamk@chromium.org

Rebaseline chromium expectations after r100800.

Unreviewed gardening.

  • platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png: Added.
13:26 Changeset [100806] by adamk@chromium.org

Layout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=66900

Re-adding SNOWLEOPARD flakiness on CG bots that seems to have been
erroneously removed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [100805] by commit-queue@webkit.org

Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

All HTML elements can have the accesskey content attribute set.
Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/BaseButtonInputType.h: Ditto
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::accessKeyAction): Ditto

  • html/BaseCheckableInputType.h: Ditto
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::accessKeyAction): Ditto

  • html/HTMLAnchorElement.h: Ditto
  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLButtonElement.h: Ditto
  • html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
If the element does not have a defined activation behavior, fire a click event at the element.

  • html/HTMLElement.h: Ditto
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLInputElement.h: Ditto
  • html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLabelElement.h: Ditto
  • html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLegendElement.h: Ditto
  • html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::accessKeyAction): Ditto

  • html/HTMLSelectElement.h: Ditto
  • html/HTMLTextAreaElement.h: Ditto
  • html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/InputType.h: Ditto
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::accessKeyAction): Ditto

  • html/RangeInputType.h: Ditto

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
  • fast/forms/access-key.html: Added more test coverage for select and textarea elements.
12:07 Changeset [100804] by adamk@chromium.org

Layout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72747

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:57 Changeset [100803] by adamk@chromium.org

Remove expectation for fast/js/delete-syntax.html, which seems to have
been fixed by http://code.google.com/p/v8/source/detail?r=9993.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:32 Changeset [100802] by adamk@chromium.org

Remove IMAGE suppression for css3/images/cross-fade-overflow-position.html
to let me use garden-o-matic for rebaselining.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:20 Changeset [100801] by jchaffraix@webkit.org

Infinite recursion in WebCore::RenderInline::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=52144

Reviewed by Tony Chang.

The bug got fixed, landing the test. As I could not test the old test case, it is
landed as-is (apart from making it dumpAsText which was deemed safe).

  • editing/execCommand/infinite-recursion-computeRectForRepaint-expected.txt: Added.
  • editing/execCommand/infinite-recursion-computeRectForRepaint.html: Added.
11:18 Changeset [100800] by simon.fraser@apple.com

Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641
and
<rdar://problem/10314267>

Reviewed by Dean Jackson.

GraphicsLayerCA contains a "linked on or after" check to account for a bug in
Core Animation on SnowLeopard and earlier, which is that CA would apply the list
of animations in reverse order.

Our previous fix was incorrect, because it only adjusted the 'additive' property
of the animation list based on ordering, rather than flipping the entire list.
This change reverses the list of animations before giving them to CA, which fixes
the bug.

Test: animations/additive-transform-animations.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

  • platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Reviewed by Dean Jackson.

Pixel test for a hardware-animated tranform, where order of operations matters.

  • animations/additive-transform-animations-expected.png: Added.
  • animations/additive-transform-animations.html: Added.
  • platform/mac/animations/additive-transform-animations-expected.txt: Added.
11:15 Changeset [100799] by aroben@apple.com

Ignore an ANGLE leak that is not WebKit's fault

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added ScanFromString to the call stacks to exclude on all OS versions.

11:11 Changeset [100798] by oliver@apple.com

Merge r100514

DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::globalObjectFor):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalObjectFor):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/cross-global-object-inline-global-var-expected.txt: Added.
  • fast/js/cross-global-object-inline-global-var.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

11:08 Changeset [100797] by oliver@apple.com

Merge r100391

REGRESSION (r98887): ParserArena and Keywords leaking
https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

  • parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

  • parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

  • runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
11:06 Changeset [100796] by oliver@apple.com

Merge r100363

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:03 Changeset [100795] by oliver@apple.com

Merge r100219

DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

11:02 Changeset [100794] by adamk@chromium.org

Suppress IMAGE failures for css3/images/cross-fade-overflow-position.html
Needs rebaseline after r100786.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:00 Changeset [100793] by oliver@apple.com

Merge r100197

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
10:58 Changeset [100792] by adauria@apple.com

bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
https://bugs.webkit.org/show_bug.cgi?id=72568

Reviewed by David Kilzer.

WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
as the return value, which was then cast to a bool and always returned true. This
patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
return value of NO.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldInterruptJavaScript):

10:55 Changeset [100791] by oliver@apple.com

2011-11-18 Oliver Hunt <oliver@apple.com>

Merge r99917

2011-11-09 Filip Pizlo <fpizlo@apple.com>

DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
10:39 Changeset [100790] by aroben@apple.com

Ignore another Lion-specific leak that is not WebKit's fault

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added SecTransformExecute to the call stacks to exclude.

10:36 Changeset [100789] by igor.oliveira@openbossa.org

No'am Rosenthal <noam.rosenthal@nokia.com>

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for KeyframeValueList, and modify the TimingFunction ArgumentCoder to
allow encoding const TimingFunctions and not just RefPtr<TimingFunction>.

Reviewed by Simon Hausmann.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
10:24 Changeset [100788] by adamk@chromium.org

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Added CRASH to expectations for fast/encoding/parser-tests-50.html.
It's only crashing on Snow Leopard, but I didn't want to split the
existing line in two.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:11 Changeset [100787] by paroga@webkit.org

[CMake] Remove duplicate dtoa files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72711

Reviewed by Brent Fulgham.

  • wtf/CMakeLists.txt:
10:06 Changeset [100786] by timothy_horton@apple.com

-webkit-cross-fade rendered incorrectly in overflow divs
https://bugs.webkit.org/show_bug.cgi?id=72693
<rdar://problem/10468564>

Reviewed by Simon Fraser.

Respect the desired source rectangle when rendering the cross-fade.

Test: css3/images/cross-fade-overflow-position.html

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h:

Add a test to make sure that -webkit-cross-fade renders correctly inside overflowed areas.

  • css3/images/cross-fade-overflow-position.html: Added.
  • css3/images/resources/half-circles.svg: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.txt: Added.
09:49 Changeset [100785] by paroga@webkit.org

[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
https://bugs.webkit.org/show_bug.cgi?id=72710

Reviewed by Brent Fulgham.

.:

  • Source/CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:
09:33 Changeset [100784] by steveblock@google.com

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for
fast/frames/sandboxed-iframe-parsing-space-characters.html on Mac 10.6
dbg.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
09:05 Changeset [100783] by mario@webkit.org

[GTK] Accessibility API tests not loading Gtk's accessibility implementation
https://bugs.webkit.org/show_bug.cgi?id=72732

Reviewed by Philippe Normand.

Ensure that the GAIL module is being loaded by avoiding using
gtk_test_init() directly, but a modified version of it.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Use a normal GtkWidget (a
GtkWindow) as the parent container for the webView, instead of
using a dummy webView for that, which was hackish.
(testWebkitAtkSetParentForObject): Use normal GtkWidgets instead
of dummy webViews (a GtkWindow and a GtkButton).
(initializeTestingFramework): New function, identical to
gtk_test_init(), but loading GAIL as the only GTK module.
(main): Use initializeTestingFramework().

08:57 Changeset [100782] by paroga@webkit.org

Unreviewed build fix; r100686 broke the EFL build when Geolocation
support is enabled.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-18

  • platform/efl/GeolocationServiceEfl.cpp: Only declare

s_factoryFunction if CLIENT_BASED_GEOLOCATION is off, otherwise it is
also declared in GeolocationService.cpp.

08:43 Changeset [100781] by igor.oliveira@openbossa.org

[TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperNode::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=72727

TextureMapperNode::computeAllTransforms already has a call to TextureMapperNode::computePerspectiveTransformIfNeeded,
so it does not need to be called again after TextureMapperNode::computeAllTransforms.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingState):

08:38 Changeset [100780] by steveblock@google.com

[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72631

Add CRASH expectation for fast/filesystem/file-writer-abort.html on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
08:18 Changeset [100779] by kenneth@webkit.org

[Qt] Guard for the viewportInteractionEngine as it doesn't always exist.

Reviewed by Antonio Gomes.

The engine is non-existent when the view is configured to use desktop
behavior.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::didFindZoomableArea):

08:03 Changeset [100778] by commit-queue@webkit.org

Add test for strange scrollbars with non-integer scaled SVG image
https://bugs.webkit.org/show_bug.cgi?id=43018

Patch by Philip Rogers <pdr@google.com> on 2011-11-18
Reviewed by Nikolas Zimmermann.

  • svg/as-image/resources/green-non-integer-size-rect.svg: Added.
  • svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
  • svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
  • svg/as-image/svg-non-integer-scaled-image.html: Added.
07:47 Changeset [100777] by steveblock@google.com

Another attempt at rebaselining fast/box-shadow for Chromium Mac 10.5.
It seems the rebaseline tool made a mess of
http://trac.webkit.org/changeset/100742.

Unreviewed gardening.

07:43 Changeset [100776] by steveblock@google.com

Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add CRASH and TIMEOUT expectations for severla more tests.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:27 Changeset [100775] by steveblock@google.com

[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation for canvas/philip/tests/2d.imageData.put.unchanged.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:22 Changeset [100774] by steveblock@google.com

[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
06:58 Changeset [100773] by philn@webkit.org

Unreviewed, skip another GTK crasher.

  • platform/gtk/Skipped: Skip fast/borders/inline-mask-overlay-image-outset.html
06:56 Changeset [100772] by steveblock@google.com

Rebaseline remaining fast/ tests for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

06:50 Changeset [100771] by carlosgc@webkit.org

[GTK] Send DidCreateDestination to DownloadProxy when destination has been created
https://bugs.webkit.org/show_bug.cgi?id=72724

Reviewed by Martin Robinson.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Call
didCreateDestination() when destination URI has been successfully
created.

06:48 Changeset [100770] by carlosgc@webkit.org

[GTK] Cancel current download operation before download object is deleted
https://bugs.webkit.org/show_bug.cgi?id=72721

Reviewed by Martin Robinson.

It fixes a crash in the web process when a download finishes early
due to a failure.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::cancel): Delete current ResourceHandle.
(WebKit::Download::platformInvalidate): If there's a
ResourceHandle active, cancel the download operation and delete
the handle.
(WebKit::Download::platformDidFinish): Delete current ResourceHandle.

06:45 Changeset [100769] by carlosgc@webkit.org

[GTK] Downloads not started by WebView only fail for transport errors
https://bugs.webkit.org/show_bug.cgi?id=72718

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Abort the download with an error if the response contains an
error code. It adds a new test case to the download unit tests.

  • tests/testdownload.c:

(notifyDownloadStatusCallback):
(serverCallback):
(test_webkit_download_not_found):
(main):

  • webkit/webkitdownload.cpp:

(DownloadClient::didReceiveResponse): Check whether http status of
the response is an error code and emit error signal in such case.

Source/WebKit2:

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Check if the http
status of the response is an error code and finish the download
with an error in such case.

06:43 Changeset [100768] by steveblock@google.com

Rebaseline remaining svg/ tests for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

06:33 Changeset [100767] by caio.oliveira@openbossa.org

[Qt] Support customizing JS alert/confirm/prompt dialogs using QML
https://bugs.webkit.org/show_bug.cgi?id=72319

Reviewed by Simon Hausmann.

Adds alertDialog, confirmDialog and promptDialog properties to QQuickWebView's
privateObject. These are QML components that are created by the webview when the
corresponding function is called in JS.

The dialogs are created in a context that contains a model object, similar to
ListView delegates. The "message" and "defaultValue" parameters are available
in the model object, as well as slots expected to be called by the dialog.

This commit removes the old code for supporting QWidget builtin dialogs. The code
wasn't working properly (closing any dialog was closing the app after QWindow
refactoring in Qt5).

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/alert.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/confirm.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/prompt.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtDialogRunner.cpp: Added.

(QtDialogRunner::QtDialogRunner):
(QtDialogRunner::~QtDialogRunner):
(DialogContextObject::DialogContextObject):
(DialogContextObject::message):
(DialogContextObject::defaultValue):
(DialogContextObject::dismiss):
(DialogContextObject::accept):
(DialogContextObject::reject):
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::createDialog):

  • UIProcess/qt/QtDialogRunner.h: Added.

(QtDialogRunner::wasAccepted):
(QtDialogRunner::result):
(QtDialogRunner::onAccepted):

06:23 Changeset [100766] by steveblock@google.com

Rebaseline fast/writing-mode for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

06:16 Changeset [100765] by mihnea@adobe.com

Fix compilation warning in ComplexTextControllerCoreText.mm
https://bugs.webkit.org/show_bug.cgi?id=72702

Reviewed by Andreas Kling.

No functionality changed, so no new tests.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

06:15 Changeset [100764] by kenneth@webkit.org

[Qt] Support wheel event together with resizesToContents

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleWheelEvent):

06:00 Changeset [100763] by yutak@chromium.org

[Qt] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72687

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::defaultHixie76WebSocketProtocolEnabled):
(DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled):
Call WebCore::Settings::setUseHixie76WebSocketProtocol() to switch WebSocket protocols.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • platform/qt/Skipped:

Unskip WebSocket hybi tests. Skip some of them which are known to fail probably due to
a bug in SocketStreamHandleQt implementation.

05:56 Changeset [100762] by hausmann@webkit.org

[Qt][WK2] Layer violation: WebPopupMenuProxyQtDesktop.cpp uses files from WebKit/qt https://bugs.webkit.org/show_bug.cgi?id=72696

Reviewed by Kenneth Rohde Christiansen.

Implement the WK2 desktop popup by simply subclassing QComboBox and doing the
same thing as QtWebComboBox from WK1 (a few lines of code).

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::eventFilter):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h:
05:52 Changeset [100761] by steveblock@google.com

Rebaseline fast/repaint for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

05:48 Changeset [100760] by zeno.albisser@nokia.com

[Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer.
https://bugs.webkit.org/show_bug.cgi?id=72717

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setViewportInteractionEngine):

  • UIProcess/qt/QtWebPageProxy.h:
05:45 Changeset [100759] by pfeldman@chromium.org

Not reviewed: restore front-end compilability via updating externs and JS generator.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/externs.js:

(WebInspector.showPanelForAnchorNavigation):

  • inspector/generate-protocol-externs:
05:42 Changeset [100758] by hausmann@webkit.org

[Qt][WK2] Fix popups for select elements.

Reviewed by Tor Arne Vestbø.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::createPopupMenuProxy): Fall back to the "desktop" implementation
for the moment. Better than nothing :)

05:42 Changeset [100757] by hausmann@webkit.org

[Qt] Unreviewed debug build fix

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy): Don't assert on a non-existant
variable.

05:29 Changeset [100756] by pfeldman@chromium.org

Web Inspector: dispatch messages from the front-end to the backend asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=72621

Source/WebCore:

We should align the way we dispatch messages from the front-end to backend across the environments:

  • WebKit has it synchronoulsly
  • Chromium has it asynchronously
  • Remote debugging has it asynchronously

Making it asynchronous made a number of flaky Qt tests pass.

Tests uncovered console agent problem that was also fixed.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearFrontend):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::onTimer):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
(WebCore::InspectorFrontendClientLocal::sendMessageToBackend):

  • inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::performDisconnectFromBackend):

  • src/InspectorFrontendClientImpl.h:

LayoutTests:

Now that dispatching is asynchronous, timeline test needed a fix.

Reviewed by Yury Semikhatsky.

  • inspector/timeline/timeline-script-tag-1.html:
  • platform/qt/Skipped:
05:28 Changeset [100755] by sergio@webkit.org

[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=72707

Reviewed by Philippe Normand.

Tools:

Make new-run-webkit-tests use the right path to locate the test
plugin used by WebKitTestRunner.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

LayoutTests:

Unskipped a test that is passing now.

  • platform/gtk-wk2/Skipped: unskipped plugins/get-url-notify-with-url-that-fails-to-load.html
05:16 Changeset [100754] by hausmann@webkit.org

[Qt] Unreviewed build fix: Export QQuickWebPage/Preferences private API
needed for the qml plugin.

  • Source/qtwebkit-export.map:
05:15 Changeset [100753] by steveblock@google.com

Rebaseline svg/custom for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

04:56 Changeset [100752] by steveblock@google.com

Rebaseline svg/clip-path for Chromium Mac 10.5 CG after http://crrev.com/110543

Unreviewed gardening.

04:43 Changeset [100751] by commit-queue@webkit.org

[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-18
Reviewed by Tony Gentilcore.

Source/WebCore:

Covered by CCLayerTreeHostTest.

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRefreshRate):

  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRefreshRate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):

04:43 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the bots (diff)
04:42 EFLWebKit edited by rakuco@FreeBSD.org
Backout --data-transfer-items from the DRT build parameters as it seems to … (diff)
04:30 Changeset [100750] by steveblock@google.com

[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
https://bugs.webkit.org/show_bug.cgi?id=72478

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-11-18
Reviewed by Dean Jackson.

  • css3/filters/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
04:12 Changeset [100749] by achicu@adobe.com

[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
https://bugs.webkit.org/show_bug.cgi?id=72478

Reviewed by Dean Jackson.

Source/WebCore:

Added parsing and computed style for the mesh rows, columns, mesh box type
(filter-box, border-box, content-box and padding-box) and the detached mode.

Also fixed a case where "custom(none, 10, 10 filter-box)" was incorrectly
treated as "custom(none, 10)".

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilter): Fixed a case where invalid syntax was parsed as correct syntax.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CustomFilterOperation::MeshBoxType):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createCustomFilterOperation):

  • css/CSSValueList.h:

(WebCore::CSSValueListIterator::isPrimitiveValue):

  • platform/graphics/filters/CustomFilterOperation.h:

LayoutTests:

  • css3/filters/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
03:50 Changeset [100748] by hausmann@webkit.org

[Qt] Unreviewed build fix: Export QQuickWebViewExperimental private API
that was added since I made the export patch.

  • Source/qtwebkit-export.map:
03:46 Changeset [100747] by mario@webkit.org

[GTK] Accessibility API tests failing because of using non-WebKit GtkWidgets
https://bugs.webkit.org/show_bug.cgi?id=72708

Reviewed by Xan Lopez.

Do not use non-WebKit GtkWidget's in unit tests, to avoid problems
when GTK's accessibility implementation is not being loaded.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Use a dummy WebKitWebView
widget as the parent container needed for this unit test.
(testWebkitAtkSetParentForObject): Ditto.

03:41 Changeset [100746] by hausmann@webkit.org

[Qt] WTR and InjectedBundle should not link statically against JSC/WTF https://bugs.webkit.org/show_bug.cgi?id=72697

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/api.pri: On Linux, use a GNU LD version script to manage the

symbol exports, which includes the public WK1/WK2 API as well as a bunch
of private WTF symbols needed for WTR and the Injected Bundle.

  • Source/qtwebkit-export.map: Added.

Tools:

  • Tools.pro: Make WTR linux only for the moment.
  • WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
  • WebKitTestRunner/Target.pri: Ditto.
  • qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources

with ELF visibility on Linux. Instead we're temporarily using an LD version script.

03:35 Changeset [100745] by hausmann@webkit.org

Oops, fix ChangeLog text

03:34 Changeset [100744] by hausmann@webkit.org

[Qt] Removal of QtViewInterface part 3

Reviewed by Kenneth Rohde Christiansen.

Move the remaining forwarded calls from ClientImpl that went through
ViewInterface and then PageProxy or WebView to go straight to
QtWebPageProxy. QtViewInterface is empty now and therefore removed.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::chooseFiles):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(setupPageUiClient):

  • UIProcess/qt/QtViewInterface.cpp: Removed.
  • UIProcess/qt/QtViewInterface.h: Removed.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeStatusText):
(QtWebPageProxy::didMouseMoveOverElement):
(QtWebPageProxy::showContextMenu):
(QtWebPageProxy::hideContextMenu):
(QtWebPageProxy::runJavaScriptAlert):
(QtWebPageProxy::runJavaScriptConfirm):
(QtWebPageProxy::runJavaScriptPrompt):
(QtWebPageProxy::chooseFiles):
(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::didChangeLoadProgress):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::contextMenuItemSelected):

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::hideContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
03:33 Changeset [100743] by kenneth@webkit.org

[Qt] Change default size of the MiniBrowser

Reviewed by Simon Hausmann.

As we lay out desktop pages using the width of 980, change our default
size to 980x735 so that we are not scaling down by default.

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

03:27 Changeset [100742] by steveblock@google.com

Rebaseline fast/box-shadow for Chromium Mac 10.5 after http://crrev.com/110543

Unreviewed gardening.

03:16 Changeset [100741] by commit-queue@webkit.org

[Qt][WK2] UI process segfaults, when visiblity properties are set while the WebProcess is dead.
https://bugs.webkit.org/show_bug.cgi?id=72699

The drawing area may be null, if the web process has crashed, but not yet recovered.
Always null check against drawing area.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-18
Reviewed by Simon Hausmann.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setDrawingAreaSize):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):

03:07 Changeset [100740] by abarth@webkit.org

Remove unneeded include (and ifdef) from V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=72705

Reviewed by Eric Seidel.

Death to ifdefs!

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
03:01 Changeset [100739] by hausmann@webkit.org

[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Move all functions that forwarded from QtWebPageProxy to QtViewInterface and then
to QQuickWebView straight into QtWebPageProxy.

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::isViewWindowActive):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::pageDidRequestScroll):
(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::toolTipChanged):
(QtWebPageProxy::didChangeUrl):
(QtWebPageProxy::didChangeTitle):
(QtWebPageProxy::loadDidBegin):
(QtWebPageProxy::loadDidCommit):
(QtWebPageProxy::loadDidSucceed):
(QtWebPageProxy::loadDidFail):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:
02:54 Changeset [100738] by steveblock@google.com

Rebaseline acid3.html for Chromium Mac 10.5

The image contains the text 'YOU SHOULD NOT SEE THIS AT ALL', but so do
all other Chromium expected results for this test, so I'm guessing this
is expected.

Unreviewed gardening.

02:37 Changeset [100737] by abarth@webkit.org

Move some mediastream related files into the mediastream directory
https://bugs.webkit.org/show_bug.cgi?id=72695

Reviewed by Eric Seidel.

Just moving the files to the proper directory.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/NavigatorUserMediaError.h: Renamed from Source/WebCore/page/NavigatorUserMediaError.h.

(WebCore::NavigatorUserMediaError::create):
(WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
(WebCore::NavigatorUserMediaError::code):
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):

  • mediastream/NavigatorUserMediaError.idl: Renamed from Source/WebCore/page/NavigatorUserMediaError.idl.
  • mediastream/NavigatorUserMediaErrorCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.h.

(WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):

  • mediastream/NavigatorUserMediaErrorCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.idl.
  • mediastream/NavigatorUserMediaSuccessCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.h.

(WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):

  • mediastream/NavigatorUserMediaSuccessCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl.
02:27 Changeset [100736] by hausmann@webkit.org

[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Replace functions of QtViewInterface that forward to QQuickWebPage with direct
usage of QQuickWebPage. Also removed some dead code.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::sceneGraphUpdateQueue):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::isVisible):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setViewNeedsDisplay):
(QtWebPageProxy::viewSize):
(QtWebPageProxy::isViewFocused):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::didRelaunchProcess):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::qmlWebPage):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
02:22 Changeset [100735] by caseq@chromium.org

Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon
https://bugs.webkit.org/show_bug.cgi?id=45955

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
(injectedExtensionAPI):
(injectedExtensionAPI.ButtonImpl.prototype.update):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.get statusBarItems):
(WebInspector.ExtensionPanel.prototype.addStatusBarItem):
(WebInspector.ExtensionButton):
(WebInspector.ExtensionButton.prototype.update):
(WebInspector.ExtensionButton.prototype._onClicked):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyButtonClicked):
(WebInspector.ExtensionServer.prototype._onCreateStatusBarButton):
(WebInspector.ExtensionServer.prototype._onUpdateButton):
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

  • inspector/front-end/inspector.css:

(button.status-bar-item.extension):

LayoutTests:

  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
02:05 Changeset [100734] by commit-queue@webkit.org

MediaStream API: Merging the PeerConnectionHandler.h files
https://bugs.webkit.org/show_bug.cgi?id=72611

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-18
Reviewed by Adam Barth.

No actual code changes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/mediastream/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/chromium/PeerConnectionHandler.h.
  • platform/mediastream/gstreamer/PeerConnectionHandler.h: Removed.
01:04 Changeset [100733] by philn@webkit.org

Unreviewed, mark media/audio-garbage-collect.html flaky on GTK.

  • platform/gtk/test_expectations.txt:
00:36 Changeset [100732] by ossy@webkit.org

[Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=72694

  • platform/qt/Skipped: Skip fast/canvas/canvas-lineWidth.html until fix.
00:21 Changeset [100731] by hausmann@webkit.org

[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places https://bugs.webkit.org/show_bug.cgi?id=72597

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved code that queries the third party cookie policy from QWebSettings
out of WebCore. Instead NetworkingContext has now the interface that allows
delegating the functionality into WebKit/qt.

In order to do that we need to pass the NetworkingContext around, which is used to
retrieve the cookie jar and the originating frame object pointer.

  • platform/network/NetworkingContext.h: Add interface.
  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Pass NetworkingContext to ResourceRequest::toNetworkRequest.
(WebCore::QNetworkReplyHandler::redirect): Ditto.

  • platform/network/qt/ResourceRequest.h: Replaced originatingObject parameter with NetworkingContext, which can

also provide the same plus more (cookie jar, policy callback).

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest): Ditto.

  • platform/qt/CookieJarQt.cpp: Simplify to use NetworkingContext to get cookie jar and

call new thirdPartyCookiePolicyPermits API that takes the context as parameter.
(WebCore::networkingContext):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):

  • platform/qt/ThirdPartyCookiesQt.cpp: Replace up-casting to QWebFrame and use of QWebSettings

with useage of NetworkingContext.
(WebCore::thirdPartyCookiePolicyPermits):

  • platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

Implemented NetworkingContext::thirdPartyCookiePolicyPermission, which queries
QWebSettings.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows): Adapt to the
changed thirdPartyCookiePolicyPermits WebCore API that operates on a networking context.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Pass networking
context to ResourceRequest::toNetworkRequest.
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
(WebCore::FrameLoaderClientQt::startDownload): Ditto.

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::thirdPartyCookiePolicyPermission): Implement.

  • WebCoreSupport/FrameNetworkingContextQt.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::thirdPartyCookiePolicy): Adapt to QtDRTSupport API change.

Source/WebKit2:

Stub implementation of new NetworkingContext::thirdPartyCookiePolicyPermission
API.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
Note: See TracTimeline for information about the timeline view.