Timeline
Nov 26, 2011:
- 7:05 PM Changeset in webkit [101199] by
-
- 4 edits in trunk
[wx] Unreviewed build fixes for Windows.
- 5:26 PM Changeset in webkit [101198] by
-
- 3 edits in trunk/Source/JavaScriptCore
Needs WTF_INLINE and JS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=72853
Patch by Hajime Morrita <morrita@chromium.org> on 2011-11-26
Reviewed by Kevin Ollivier.
Added WTF_HIDDEN, WTF_INLINE and JS_INLINE which
indirect attribute((visibility("hidden"))
- config.h:
- wtf/ExportMacros.h:
- 11:31 AM Changeset in webkit [101197] by
-
- 2 edits in trunk/Source/WebCore
2011-11-26 Alejandro G. Castro <alex@igalia.com>
Fix compilation after r101157.
Reviewed by Martin Robinson.
- bindings/scripts/preprocessor.pm: (applyPreprocessor): In case we have a string with double-quotations (") we replace it with the empty string.
- 10:00 AM Changeset in webkit [101196] by
-
- 2 edits in trunk/Source/WebCore
[TexMapper][WK2][Qt] Simple opacity animations are not working
https://bugs.webkit.org/show_bug.cgi?id=73157
LayerTreeHostQt needs to know what nodes in the TextureMapper are visible, to associate
a tile to it. It is done using TextureMapperNode::collectVisibleContentsRects.
However TextureMapperNode::collectVisibleContentsRects has an optimization to check if
the current tile has opacity greater than 0.01, otherwise it will not create a tile for
the current node.
For opacity animations from 0 to 1, it is a problem because the tile is never created
and the animation never happens.
This patch fixes opacity animations.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::countDescendantsWithContent):
(WebCore::TextureMapperNode::collectVisibleContentsRects):
- 8:09 AM Changeset in webkit [101195] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] [WK2] QtDownloadManager doesn't need to be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=73151
Reviewed by Kenneth Rohde Christiansen.
QtDownloadManager is owned by QtWebContext, and doesn't need to be a RefCounted
class. This commit also makes the callback handlers private -- following the similar
approach we take in other clients of the C API.
- UIProcess/qt/QtDownloadManager.cpp:
(WebKit::QtDownloadManager::QtDownloadManager):
(WebKit::QtDownloadManager::addDownload):
(WebKit::toQtDownloadManager):
(WebKit::QtDownloadManager::didReceiveResponse):
(WebKit::QtDownloadManager::didCreateDestination):
(WebKit::QtDownloadManager::didFinishDownload): remove unused failingUrl local variable.
(WebKit::QtDownloadManager::didFailDownload):
(WebKit::QtDownloadManager::didReceiveDataForDownload):
- UIProcess/qt/QtDownloadManager.h:
- UIProcess/qt/QtWebContext.cpp:
(WebKit::QtWebContext::initialize):
- UIProcess/qt/QtWebContext.h:
- 7:51 AM Changeset in webkit [101194] by
-
- 45 edits in trunk/Source
Unreviewed, rolling out r101193.
http://trac.webkit.org/changeset/101193
https://bugs.webkit.org/show_bug.cgi?id=73158
Breaks Windows and Qt minimal. (Requested by pfeldman on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-26
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::inspectedPageDestroyed):
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::close):
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::disconnectFromBackend):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
- inspector/front-end/inspector.js:
(WebInspector.disconnectFromBackend):
- loader/EmptyClients.h:
Source/WebKit/chromium:
- src/InspectorClientImpl.cpp:
- src/InspectorClientImpl.h:
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::disconnectFromBackend):
- src/InspectorFrontendClientImpl.h:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::disconnectEventAsText):
- src/WebDevToolsAgentImpl.h:
Source/WebKit/efl:
- WebCoreSupport/InspectorClientEfl.cpp:
- WebCoreSupport/InspectorClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorFrontendClient::disconnectFromBackend):
- WebCoreSupport/InspectorClientGtk.h:
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::inspectorDestroyed):
Source/WebKit/qt:
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorFrontendClientQt::disconnectFromBackend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
- WebCoreSupport/InspectorClientQt.h:
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::inspectorDestroyed):
(WebInspectorFrontendClient::disconnectFromBackend):
- WebCoreSupport/WebInspectorClient.h:
Source/WebKit/wince:
- WebCoreSupport/InspectorClientWinCE.cpp:
- WebCoreSupport/InspectorClientWinCE.h:
Source/WebKit/wx:
- WebKitSupport/InspectorClientWx.cpp:
- WebKitSupport/InspectorClientWx.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::inspectorDestroyed):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::disconnectFromBackend):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- 7:30 AM Changeset in webkit [101193] by
-
- 42 edits in trunk/Source
Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127
Source/WebCore:
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::inspectedPageDestroyed):
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::close):
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/inspector.js:
(WebInspector.disconnectFromWorker):
- loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::closeInspectorFrontend):
Source/WebKit/chromium:
We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::closeInspectorFrontend):
- src/InspectorClientImpl.h:
- src/InspectorFrontendClientImpl.cpp:
- src/InspectorFrontendClientImpl.h:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):
- src/WebDevToolsAgentImpl.h:
Source/WebKit/gtk:
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):
- WebCoreSupport/InspectorClientGtk.h:
Source/WebKit/mac:
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):
Source/WebKit/qt:
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
- WebCoreSupport/InspectorClientQt.h:
Source/WebKit/win:
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):
- WebCoreSupport/WebInspectorClient.h:
Source/WebKit2:
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::inspectorDestroyed):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- 4:48 AM Changeset in webkit [101192] by
-
- 2 edits in trunk/Source/WebCore
Fix a bug in TreeOutline which would cause parent elements to show up as expanded and empty
when removed and added back to the tree.
https://bugs.webkit.org/show_bug.cgi?id=73155
Reviewed by Pavel Feldman.
- inspector/front-end/treeoutline.js:
(TreeElement.prototype.collapse): Set _treeElementsExpandedState to false instead of true.
Only TreeElement.prototype.expand should set it to true, which it does.
- 2:47 AM Changeset in webkit [101191] by
-
- 2 edits in trunk/Source/WebKit
[CMake] Clean up Web Inspector target in Source/WebKit/blackberry/CMakeListsBlackBerry.txt
https://bugs.webkit.org/show_bug.cgi?id=72784
Patch by Jonathan Dong <Jonathan Dong> on 2011-11-26
Reviewed by Nikolas Zimmermann.
Abstracted the JavaScript file names from inspector/front-end/inspector.html
to keep them in-sync with the changes of inspector.html.
- blackberry/CMakeListsBlackBerry.txt:
- 2:16 AM Changeset in webkit [101190] by
-
- 4 edits in trunk/Source/WebCore
[GTK] Fix some warnings in WebCore GTK+
https://bugs.webkit.org/show_bug.cgi?id=73137
Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-26
Reviewed by Philippe Normand.
No new tests. This patch just fixes compilation warnings.
- platform/gtk/CursorGtk.cpp:
(WebCore::createNamedCursor): Remove unused variable.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack): ASSERT_UNUSED instead of ASSERT.
- platform/gtk/SharedTimerGtk.cpp: Ditto.
(WebCore::stopSharedTimer):
- 12:59 AM Changeset in webkit [101189] by
-
- 2 edits in trunk/Tools
Try to fix the build after r101174.
- gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
Nov 25, 2011:
- 11:17 PM Changeset in webkit [101188] by
-
- 5 edits2 adds2 deletes in trunk/Source/WebKit2
[Qt] [WK2] Remove WebContext related code from QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73150
Reviewed by Kenneth Rohde Christiansen.
Creates a QtWebContext class that abstracts away from QtWebPageProxy the
handling of creating / maintaining the default WebContext, as well as the
code for the WKContextRef clients.
Another motivation for having this entity is to have a proper place to add
objects are bound to the context, like the QtDownloadManager.
- Target.pri:
- UIProcess/qt/ClientImpl.cpp: Removed.
- UIProcess/qt/ClientImpl.h: Removed.
- UIProcess/qt/QtDownloadManager.cpp:
- UIProcess/qt/QtWebContext.cpp: Added.
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
(WebKit::QtWebContext::createWebPage):
(WebKit::QtWebContext::setNavigatorQtObjectEnabled):
(WebKit::QtWebContext::postMessageToNavigatorQtObject):
(WebKit::QtWebContext::initialize):
(WebKit::QtWebContext::initializeContextInjectedBundleClient):
(WebKit::toQtWebContext):
(WebKit::QtWebContext::didReceiveMessageFromInjectedBundle):
- UIProcess/qt/QtWebContext.h: Added.
(WebKit::QtWebContext::downloadManager):
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::setNavigatorQtObjectEnabled):
(QtWebPageProxy::postMessageToNavigatorQtObject):
(QtWebPageProxy::handleDownloadRequest):
- UIProcess/qt/QtWebPageProxy.h:
- 10:15 PM Changeset in webkit [101187] by
-
- 2 edits in trunk/Source/JavaScriptCore
String.prototype.toLower should be optimized for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=73154
Changed stringProtoFuncToLowerCase to use StringImpl::lower() which has
been optimized for 8 bit strings.
This is worth ~7% to sunspider string.tagcloud.
Reviewed by Filip Pizlo.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):
- 10:01 PM Changeset in webkit [101186] by
-
- 2 edits in trunk/Source/JavaScriptCore
Array.toString always uses StringImpl::characters()
https://bugs.webkit.org/show_bug.cgi?id=72969
If all component strings are 8 bit, create an 8 bit result string for toString().
This appears to be performance neutral to sunspider and v8.
Reviewed by Filip Pizlo.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- 8:28 PM Changeset in webkit [101185] by
-
- 11 edits2 adds2 deletes in trunk
Implement addCue and removeCue in TextTrack
https://bugs.webkit.org/show_bug.cgi?id=72554
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-add-remove-cue.html
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::ensureTrack): Go ahead and allocate a Track even if the feature
is disabled, it just won't load anything.
(WebCore::HTMLTrackElement::scheduleLoad): Early return if the featue is disabled.
(WebCore::HTMLTrackElement::canLoadUrl): Ditto.
- html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::newCuesAvailable): Add new cues one at a time because
cues->add(Vector<TextTrackCue*>&) is gone.
- html/TextTrack.cpp:
(WebCore::TextTrack::addCue): Implement.
(WebCore::TextTrack::removeCue): Ditto.
- html/TextTrack.h:
(WebCore::TextTrackCue::TextTrackCue): Initialize every member variable.
(WebCore::TextTrackCue::track): m_track is now a RefPtr.
(WebCore::TextTrackCue::setTrack): Ditto.
- html/TextTrackCue.h:
- html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Don't ignore out of order cues, the spec text is not
a conformance requirement. Return bool to indicate success or failure.
(WebCore::TextTrackCueList::remove): Return bool to indicate success or failure.
- html/TextTrackCueList.h:
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::notifyFinished): Don't change m_state once it is set to Failed.
LayoutTests:
- media/track/track-add-remove-cue-expected.txt: Added.
- media/track/track-add-remove-cue.html: Added.
- media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
- media/track/track-webvtt-tc012-out-of-order.html: Removed.
- 4:34 PM Changeset in webkit [101184] by
-
- 4 edits in trunk/Source/WebCore
Refactoring CodeGenerator*.pm for bug 72138
https://bugs.webkit.org/show_bug.cgi?id=73115
Reviewed by Adam Barth.
Tests: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
- bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.
(GenerateHeaderCustomCall):
- bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
- 3:34 PM Changeset in webkit [101183] by
-
- 6 edits2 adds in trunk
Implement the WebGLContextEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=72856
Reviewed by Adam Barth.
Source/WebCore:
This patch makes WebGLContextEvent constructable.
The spec: http://www.khronos.org/registry/webgl/specs/latest/#5.14
Test: fast/events/constructors/webgl-context-event-constructor.html
- html/canvas/WebGLContextEvent.cpp: Added an implementation of the WebGLContextEvent constructor.
(WebCore::WebGLContextEventInit::WebGLContextEventInit):
(WebCore::WebGLContextEvent::WebGLContextEvent):
- html/canvas/WebGLContextEvent.h: Added a definition of WebGLContextEventInit.
(WebCore::WebGLContextEvent::create):
- html/canvas/WebGLContextEvent.idl: Added [ConstructorTemplate=Event] IDL.
LayoutTests:
webgl-context-event-constructor.html checks the behavior of the WebGLContextEvent constructor.
- fast/dom/constructed-objects-prototypes-expected.txt: Added window.WebGLContextEvent.
- fast/events/constructors/webgl-context-event-constructor-expected.txt: Added.
- fast/events/constructors/webgl-context-event-constructor.html: Added.
- 2:59 PM Changeset in webkit [101182] by
-
- 1 edit9 adds in trunk/LayoutTests
Add missing results for Mac after r100949 and r100036.
svg/repaint/filter-child-repaint.svg is failing. The failure is tracked by the bug 73146.
- platform/mac/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Added.
- platform/mac/css2.1/20110323/empty-inline-002-expected.png: Added.
- platform/mac/css2.1/20110323/empty-inline-002-expected.txt: Added.
- platform/mac/css2.1/20110323/empty-inline-003-expected.png: Added.
- platform/mac/css2.1/20110323/empty-inline-003-expected.txt: Added.
- platform/mac/media/controls-without-preload-expected.png: Added.
- platform/mac/svg/repaint/filter-child-repaint-expected.png: Added.
- platform/mac/svg/repaint/filter-child-repaint-expected.txt: Added.
- 1:52 PM Changeset in webkit [101181] by
-
- 3 edits2 adds in trunk
[Chromium] The DrawingBuffer::bind method was incorrectly resetting the
GL viewport parameters. This was unnecessary, and resulted in the corruption
of the WebGL context's state.
https://bugs.webkit.org/show_bug.cgi?id=73091
Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-25
Reviewed by Stephen White.
Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html
Source/WebCore:
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::bind):
LayoutTests:
- fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt: Added.
- fast/canvas/webgl/webgl-viewport-parameters-preserved.html: Added.
- 12:21 PM Changeset in webkit [101180] by
-
- 3 edits2 adds in trunk
Crash in BidiRunList<Run>::replaceRunWithRuns with an empty bdi element
https://bugs.webkit.org/show_bug.cgi?id=73116
Reviewed by Eric Seidel.
Source/WebCore:
The assertion failure was caused because isolatedResolver is initialized with
null start object due to the isolated run being empty.
Fixed the failure by skipping empty isolated runs.
Test: fast/text/empty-bdi-crash.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRuns):
LayoutTests:
Added a regression test.
- fast/text/empty-bdi-crash-expected.txt: Added.
- fast/text/empty-bdi-crash.html: Added.
- 11:57 AM Changeset in webkit [101179] by
-
- 11 edits in trunk/Source/WebKit2
[Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
https://bugs.webkit.org/show_bug.cgi?id=73096
Reviewed by Kenneth Rohde Christiansen.
Move all the interaction engine usage to QtWebPageEventHandler,
making all GestureRecognizers (Tap, Pinch and Pan) use it directly.
- UIProcess/qt/QtGestureRecognizer.cpp:
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
- UIProcess/qt/QtGestureRecognizer.h:
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):
- UIProcess/qt/QtPanGestureRecognizer.h:
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):
- UIProcess/qt/QtPinchGestureRecognizer.h:
- UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
- UIProcess/qt/QtTapGestureRecognizer.h:
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::setViewportInteractionEngine):
- UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler::interactionEngine):
- 11:26 AM Changeset in webkit [101178] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Remove unneeded declaration from QQuickWebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=73141
Reviewed by Antonio Gomes.
Left-over from r101165.
- UIProcess/API/qt/qquickwebpage_p_p.h:
- 10:08 AM Changeset in webkit [101177] by
-
- 10 edits in trunk/Source/WebCore
StyleGeneratedImage should ref CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=73074
Reviewed by Andreas Kling and Nikolas Zimmermann.
RenderStyle owns a bunch of StyleImage objects. However StyleGeneratedImage does not ref the
CSSImageGeneratorValue it holds so we currently rely on the stylesheet to keep the CSSImageGeneratorValues
alive as long as RenderStyle stays alive. While this works (RenderStyles are thrown away if stylesheets
change) it is not particularly robust or nice.
- Use RefPtr<CSSImageGeneratorValue> in StyleGeneratedImage
- Remove the RefPtr<StyleGeneratedImage> from CSSImageGeneratorValue. There is no good reason to cache StyleGeneratedImage as it is a small and uncommon object. With that the whole back-reference becomes unnecessary.
- Switch more places to use (Pass)RefPtr<StyleImage> for consistency.
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):
- css/CSSImageGeneratorValue.h:
- css/CSSStyleApplyProperty.cpp:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::cachedOrPendingFromValue):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):
- css/CSSStyleSelector.h:
- rendering/style/FillLayer.h:
(WebCore::FillLayer::setImage):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::NinePieceImage):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::StyleGeneratedImage):
(WebCore::StyleGeneratedImage::cssValue):
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):
- rendering/style/StyleGeneratedImage.h:
(WebCore::StyleGeneratedImage::create):
(WebCore::StyleGeneratedImage::data):
- 9:47 AM Changeset in webkit [101176] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Web Inspector: assertion failure in InspectorController::restoreInspectorStateFromCookie
https://bugs.webkit.org/show_bug.cgi?id=73136
Don't call connectFrontend twice on reattach.
Reviewed by Pavel Feldman.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
- 8:46 AM Changeset in webkit [101175] by
-
- 3 edits in trunk/Source/WebCore
Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
<http://webkit.org/b/73134>
Reviewed by Antti Koivisto.
CSSMappedAttributeDeclarations always use non-strict parsing since they use
the argument-less CSSMutableStyleDeclaration constructor.
- dom/StyledElement.cpp:
(WebCore::StyledElement::createMappedDecl):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
- 8:19 AM Changeset in webkit [101174] by
-
- 10 edits1 move3 adds4 deletes in trunk
[GTK] Integrate build-gtkdoc into build-webkit and make
https://bugs.webkit.org/show_bug.cgi?id=72626
Reviewed by Philippe Normand.
.:
- GNUmakefile.am: Remove references to old gtkdoc files. Update
the dist-hook to include copying documentation into the distribution.
This also means that the build will fail if documentation hasn't been
generated before 'make dist.'
- configure.ac: Ditto.
Source/WebKit/gtk:
- docs/GNUmakefile.am: Removed.
- docs/version.xml.in: Removed.
Source/WebKit2:
- GNUmakefile.am: Removed references to build-gtkdoc and gtkdoc.py.
- UIProcess/API/gtk/docs/build-gtkdoc: Removed.
Tools:
- GNUmakefile.am: Added support for new scripts and "make docs".
- Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
(buildAutotoolsProject):
- gtk/generate-gtkdoc: Added.
- gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
- 7:14 AM Changeset in webkit [101173] by
-
- 2 edits in trunk/LayoutTests
2011-11-25 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark inspector/elements/remove-node.html test as crashing sometimes on Linux.
- platform/chromium/test_expectations.txt:
- 7:00 AM QtWebKitBuildBots edited by
- Update Qt5 on the bots (diff)
- 6:58 AM BuildingQt5OnHarmattan edited by
- Update Qt5 revision (diff)
- 6:44 AM Changeset in webkit [101172] by
-
- 16 edits1 add in trunk/Source/WebCore
Factor element pointer out of CSSMutableStyleDeclaration.
<http://webkit.org/b/73121>
Reviewed by Antti Koivisto.
Move the StyledElement pointer out of CSSMutableStyleDeclaration and into a subclass
for the cases where it's needed. This reduces the size of vanilla style declarations
by one CPU word (4 or 8 bytes, depending on architecture.)
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::element):
(WebCore::CSSElementStyleDeclaration::setElement):
(WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):
(WebCore::CSSElementStyleDeclaration::~CSSElementStyleDeclaration):
Added CSSElementStyleDeclaration, a common parent class for inline styles
and mapped attributes. It extends CSSMutableStyleDeclaration by adding a backpointer
to the StyledElement that owns it.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSInlineStyleDeclaration.h: Added.
(WebCore::CSSInlineStyleDeclaration::~CSSInlineStyleDeclaration):
(WebCore::CSSInlineStyleDeclaration::create):
(WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):
Added CSSInlineStyleDeclaration.
- bindings/js/JSDOMBinding.h:
(WebCore::root):
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
Only follow the associated element on CSSElementStyleDeclarations.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):
Remove comment about m_element since the field was moved to a subclass.
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
- css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::isElementStyleDeclaration):
(WebCore::CSSStyleDeclaration::isInlineStyleDeclaration):
We no longer need to track whether a style declaration is mutable or not,
so the constructors are slightly simplified.
Added two bits (isElementStyleDeclaration and isInlineStyleDeclaration) for
runtime type checking. These are protected and set by the CSSElementStyleDeclaration
constructor.
- dom/CSSMappedAttributeDeclaration.h:
(WebCore::CSSMappedAttributeDeclaration::create):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
Remove pointless CSSRule* argument to constructor since we always passed 0.
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::getInlineStyleDecl):
(WebCore::StyledElement::addSubresourceAttributeURLs):
Make the inline style on StyledElement a CSSInlineStyleDeclaration.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::inlineStyleElement):
Slightly simplified by having CSSInlineStyleDeclaration.
- 6:35 AM Changeset in webkit [101171] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
https://bugs.webkit.org/show_bug.cgi?id=73132
Reviewed by Simon Hausmann.
Make sure QWebDownloadItem is registered in the right plugin.
- declarative/experimental/plugin.cpp:
- declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
- 6:32 AM Changeset in webkit [101170] by
-
- 7 edits in trunk
Web Inspector: unflake timeline-network tests
https://bugs.webkit.org/show_bug.cgi?id=73123
Source/WebCore:
We should capture stack only when it makes sense. Otherwise loading from cache
results in different data sets (stacks) than regular load.
Reviewed by Yury Semikhatsky.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
LayoutTests:
Reviewed by Yury Semikhatsky.
- platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
- platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
- 6:19 AM Changeset in webkit [101169] by
-
- 2 edits in trunk/Tools
[Qt] Add support for using OWRT with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947
Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2011-11-25
Reviewed by Csaba Osztrogonác.
- Scripts/old-run-webkit-tests:
- 6:17 AM Changeset in webkit [101168] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-11-25 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Chromium build fix.
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded): dowsntream implementation with OVERRIDE modifier fails to compile without this stub.
- 5:56 AM WebKit Team edited by
- (diff)
- 5:53 AM Changeset in webkit [101167] by
-
- 2 edits in trunk/Source/WebKit2
Clean up code in WK2/ChromeClientClient related to viewport handling
https://bugs.webkit.org/show_bug.cgi?id=73128
Reviewed by Simon Hausmann.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
Make sure that we only call resizeToContentsIfNeeded when we are
using the tiled backing store and fixed layout as well.
Guard the scrollbar code so that it is only called when scroll
delegation is not used. Do similarily for the frameset code,
which makes no sense with frame flattening.
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
This method is only called for the main frame, so the main frame
check has been removed.
- 5:39 AM Changeset in webkit [101166] by
-
- 12 edits in trunk
[Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
https://bugs.webkit.org/show_bug.cgi?id=73126
Source/WebCore:
Notify embedder that front-end is loadded only when all dispatchers, panels and models
have been created so that it could dispatch messages synchronously in the loaded handler.
Reviewed by Pavel Feldman.
- inspector/front-end/inspector.js:
Source/WebKit/chromium:
No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.
Reviewed by Pavel Feldman.
- public/WebDevToolsFrontendClient.h:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::frontendLoaded):
- src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):
(WebKit::WebDevToolsFrontendImpl::doDispatchOnInspectorFrontend):
- src/WebDevToolsFrontendImpl.h:
Tools:
No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.
Reviewed by Pavel Feldman.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsClient.cpp:
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- 4:54 AM Changeset in webkit [101165] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Eliminate warnings about the deprecated QQuickCanvas::sceneGraphEngine() function.
Reviewed by Andreas Kling.
We use the function in question to find out if we can connect to the scene graph's
afterRendering signal. The signal has been moved into QQuickCanvas right away, so
we can connect to it as soon as we have a canvas.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::initializeSceneGraphConnections):
- UIProcess/API/qt/qquickwebpage_p.h:
- 4:48 AM Changeset in webkit [101164] by
-
- 9 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] Move event handling out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73089
Reviewed by Kenneth Rohde Christiansen.
Move all logic related to event handling, gestures and the
interaction engine out of QtWebPageProxy, creating a separate
class called QtWebPageEventHandler. This handler will be created
by the QQuickWebViewPrivate and will be registered into QtWebPageProxy.
QQuickWebPage will now call handleEvent through this entity.
- Target.pri:
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::event):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
- UIProcess/qt/QtTapGestureRecognizer.h:
- UIProcess/qt/QtWebPageEventHandler.cpp: Added.
(QtWebPageEventHandler::dragOperationToDropAction):
(QtWebPageEventHandler::dragOperationToDropActions):
(QtWebPageEventHandler::dropActionToDragOperation):
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleMouseDoubleClickEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::timerEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::setViewportInteractionEngine):
(QtWebPageEventHandler::touchEvent):
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):
(QtWebPageEventHandler::didFindZoomableArea):
- UIProcess/qt/QtWebPageEventHandler.h: Added.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::didFindZoomableArea):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::doneWithTouchEvent):
- UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::eventHandler):
- 4:12 AM Changeset in webkit [101163] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: don't send Console.messagesCleared on front-end connection if console agent is not enabled
https://bugs.webkit.org/show_bug.cgi?id=73122
Console agent should stay silent if it is not enabled.
Reviewed by Pavel Feldman.
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- 3:39 AM Changeset in webkit [101162] by
-
- 9 edits1 add in trunk/Source/WebKit2
[Qt] Cleanup in QML tests.
Reviewed by Tor Arne Vestbø.
Use a simple QML component for the "DesktopWebView" instead of a new QML type.
This will allow the use of the experimental extension in the future.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Added.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
- 2:57 AM Changeset in webkit [101161] by
-
- 1 edit2 adds in trunk/Source/WebCore
Upstream the QNX/RIM specific HistoryItemViewState
https://bugs.webkit.org/show_bug.cgi?id=73114
Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-11-25
Reviewed by Daniel Bates.
This patch is to upstream RIM/QNX specific HistoryItemViewState extension
to store some extra view state.
No new tests. It's not built yet.
- history/blackberry: Added.
- history/blackberry/HistoryItemViewState.h: Added.
(WebCore::HistoryItemViewState::HistoryItemViewState):
- 2:33 AM Changeset in webkit [101160] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Split scripts panel top status bar into debug toolbar and editor toolbar.
https://bugs.webkit.org/show_bug.cgi?id=73087
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):
- inspector/front-end/scriptsPanel.css:
(#scripts-debug-toolbar):
(#scripts-editor-toolbar):
(#scripts-debug-sidebar-resizer-widget):
(.script-view):
- 2:06 AM Changeset in webkit [101159] by
-
- 1 edit3 adds in trunk/Source/WebCore
Upstream BlackBerry porting of platform/text
https://bugs.webkit.org/show_bug.cgi?id=73117
Reviewed by Daniel Bates.
Initial upstream, can't be built yet, no test cases.
- platform/text/blackberry/StringBlackBerry.cpp: Added.
(WTF::String::String):
(WTF::String::operator WebString):
- platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp: Added.
(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):
- 1:41 AM Changeset in webkit [101158] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217
Reviewed by Yury Semikhatsky.
- platform/chromium/test_expectations.txt:
- 1:31 AM Changeset in webkit [101157] by
-
- 3 edits1 delete in trunk/Source/WebCore
Remove WebCore.gyp/scripts/rule_binding.py
https://bugs.webkit.org/show_bug.cgi?id=73109
Reviewed by Adam Barth.
rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper
of generate-bindings.pl and thus we can remove it.
No new tests. No change in behavior.
- WebCore.gyp/WebCore.gyp: Replaces rule_binding.py with generate-bindings.pl.
- WebCore.gyp/scripts/rule_binding.py: Removed.
- bindings/scripts/preprocessor.pm: When '"ENABLE_SOMETHING=1" "ENABLE_OTHERS=0"' is passed as a define macro, the string is passed to our perl scripts without the double-quotations (") omitted. We need to omit the double quatations here.
(applyPreprocessor):
- 1:29 AM Changeset in webkit [101156] by
-
- 15 edits4 deletes in trunk
[Chromium] Web Inspector: remove legacy debugger support
https://bugs.webkit.org/show_bug.cgi?id=73081
Removed classed providing access to V8 debugging protocol. Clients should
use Web Inspector protocol instead.
Reviewed by Pavel Feldman.
Source/WebCore:
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):
- bindings/v8/PageScriptDebugServer.h:
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- src/DebuggerAgentImpl.cpp: Removed.
- src/DebuggerAgentImpl.h: Removed.
- src/DebuggerAgentManager.cpp: Removed.
- src/DebuggerAgentManager.h: Removed.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::detach):
(WebKit::WebDevToolsAgentImpl::didNavigate):
(WebKit::WebDevToolsAgentImpl::didClearWindowObject):
- src/WebDevToolsAgentImpl.h:
- 1:25 AM Changeset in webkit [101155] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-11-25 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium deps revision to 111575
- DEPS:
- 1:23 AM Changeset in webkit [101154] by
-
- 26 edits in trunk
Web Inspector: refactor resource tree model and introduce explicit class for ResourceTreeFrame.
https://bugs.webkit.org/show_bug.cgi?id=73078
Otherwise we are managing frames and their resources using too many maps.
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::restore):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
- inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get displayName):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._fetchResourceTree):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype.frameForId):
(WebInspector.ResourceTreeModel.prototype.forAllResources):
(WebInspector.ResourceTreeModel.prototype.resourceForURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get id):
(WebInspector.ResourceTreeFrame.prototype.get name):
(WebInspector.ResourceTreeFrame.prototype.get url):
(WebInspector.ResourceTreeFrame.prototype.get loaderId):
(WebInspector.ResourceTreeFrame.prototype.get parentFrame):
(WebInspector.ResourceTreeFrame.prototype.get childFrames):
(WebInspector.ResourceTreeFrame.prototype.isMainFrame):
(WebInspector.ResourceTreeFrame.prototype.navigate):
(WebInspector.ResourceTreeFrame.prototype.get mainResource):
(WebInspector.ResourceTreeFrame.prototype.addChildFrame):
(WebInspector.ResourceTreeFrame.prototype.removeChildFrame):
(WebInspector.ResourceTreeFrame.prototype._addResource):
(WebInspector.ResourceTreeFrame.prototype.resources):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL.filter):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL):
(WebInspector.ResourceTreeFrame.prototype._callForFrameResources):
(WebInspector.PageDispatcher.prototype.frameNavigated):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._resetWithFrames):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._frameDetached):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.formatContent):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
LayoutTests:
- http/tests/inspector/inspector-test.js:
- http/tests/inspector/resource-tree/resource-tree-document-url.html:
- http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
- http/tests/inspector/resource-tree/resource-tree-frame-add.html:
- http/tests/inspector/resource-tree/resource-tree-mimetype.html:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap.collect):
- http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.runAfterCachedResourcesProcessed):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources.visit):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):
- inspector/debugger/source-frame.html:
- inspector/styles/css-live-edit.html:
- inspector/styles/styles-history.html:
- platform/qt/Skipped:
Nov 24, 2011:
- 11:10 PM Changeset in webkit [101153] by
-
- 2 edits in trunk/Source/WebCore
Initialize global variables during IDLParser object creation
https://bugs.webkit.org/show_bug.cgi?id=73108
Reviewed by Adam Barth.
Currently, IDLParser.pm initializes global variables in a global scope,
which means that the global variables are initialized just once at the beginning.
On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change
on generate-bindings.pl that initializes the global variables whenever a new IDLParser
object is created. Thus, this patch initializes the global variables during
the IDLParser object creation.
No new tests. No change in behavior.
- bindings/scripts/IDLParser.pm:
(InitializeGlobalData):
(new):
- 10:55 PM Changeset in webkit [101152] by
-
- 2 edits in trunk/Source/JavaScriptCore
UString methods are not character size aware
https://bugs.webkit.org/show_bug.cgi?id=72975
Changed the UString number constructors to build 8 bit strings.
Modified the other methods to check string bitness and process
with 8 bits wherre appropriate.
- runtime/UString.cpp:
(JSC::UString::number):
(JSC::operator==):
(JSC::operator<):
(JSC::UString::ascii):
- 10:47 PM Changeset in webkit [101151] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScript string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974
Change the various JS to number routines to process strings
using characters8() or characters16() as appropriate.
Implemented using static template methods.
Reviewed by Filip Pizlo.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::isInfinity):
(JSC::jsHexIntegerLiteral):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
- 10:44 PM Changeset in webkit [101150] by
-
- 2 edits in trunk/Tools
Replace subprocess.call() with subprocess.Popen()
https://bugs.webkit.org/show_bug.cgi?id=73105
Reviewed by Adam Barth.
Currently, the stdout and stderr of the child processes of run-bindings-tests
are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
between a parent process and a child process. This patch replaces subprocess.call() with
subprocess.Popen() and synchronizes the stdout and stderr between them.
This patch also makes output messages of run-bindings-tests more readable.
With this patch, the output messages of run-bindings-tests look like as follows:
PASS: (CPP) WebDOMTestObj.h
PASS: (CPP) WebDOMTestObj.cpp
FAIL: (CPP) WebDOMTestInterface.h
--- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900
+++ /tmp/tmpDAV87G/WebDOMTestInterface.h 2011-11-25 13:44:42.712946812 +0900
@@ -23,7 +23,7 @@
#ifndef WebDOMTestInterface_h
#define WebDOMTestInterface_h
-#if ENABLE(Condition1) ENABLE(Condition2) +#if ENABLE(Condition1) ENABLE(Condition3) #include <WebDOMObject.h>
#include <WebDOMString.h>
@@ -53,5 +53,5 @@
WebDOMTestInterface toWebKit(WebCore::TestInterface*);
#endif
-#endif ENABLE(Condition1) ENABLE(Condition2) +#endif ENABLE(Condition1) ENABLE(Condition3) PASS: (CPP) WebDOMFloat64Array.cpp
PASS: (CPP) WebDOMFloat64Array.h
Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
- Scripts/run-bindings-tests:
(generate_from_idl):
(detect_changes):
(run_tests):
(main):
- 10:36 PM Changeset in webkit [101149] by
-
- 2 edits in trunk/Tools
Fix the current working directory of run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73106
Reviewed by Adam Barth.
Currently, run-bindings-tests outputs the following error
(although it outputs "all tests passed!" in the end):
Testing the ObjC generator on TestObj.idl
gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
gcc: warning: '-x objective-c' after last input file has no effect
gcc: no input files
This is because CodeGeneratorObjC.pm assumes that the current working directory
is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
Thus, this patch changes it to WebKit/Source/.
- Scripts/run-bindings-tests:
(generate_from_idl):
(main):
- 10:35 PM Changeset in webkit [101148] by
-
- 2 edits in trunk/Source/JavaScriptCore
Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968
Clear m_is8Bit flag for empty strings.
Reviewed by Filip Pizlo.
- runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
- 10:23 PM Changeset in webkit [101147] by
-
- 4 edits in trunk/Source/JavaScriptCore
Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683
Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
and building continues with a 16 bit buffer.
Reviewed by Filip Pizlo.
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::upConvert):
(JSC::JSStringBuilder::build):
- runtime/UString.h:
(JSC::UString::adopt):
- wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
- 3:23 PM Changeset in webkit [101146] by
-
- 2 edits in trunk/Source/WebCore
[CMake] Build fix for NOT ENABLE_WEB_SOCKETS.
- CMakeLists.txt: Move CloseEvent.idl to the unconditional files.
- 3:16 PM Changeset in webkit [101145] by
-
- 2 edits in trunk/Source/WebCore
Build fix for C++ bindings.
- bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards.
- 12:03 PM Changeset in webkit [101144] by
-
- 23 edits23 adds in trunk
Microdata: Support for properties attribute.
https://bugs.webkit.org/show_bug.cgi?id=71050
Patch by Arko Saha <arko@motorola.com> on 2011-11-24
Reviewed by Adam Barth.
Source/WebCore:
The properties attribute returns an HTMLPropertiesCollection object with all the element's
properties. Otherwise, an empty HTMLPropertiesCollection object.
Tests: fast/dom/MicroData/itemref-refers-first-element-with-given-id.html
fast/dom/MicroData/names-property-must-be-correct.html
fast/dom/MicroData/names-property-test.html
fast/dom/MicroData/properties-collection-add-remove-itemref.html
fast/dom/MicroData/properties-collection-add-remove-property.html
fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html
fast/dom/MicroData/properties-collection-must-be-correct.html
fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html
fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html
fast/dom/MicroData/properties-collection-test.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/gobject/GNUmakefile.am:
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- dom/MicroDataItemList.cpp:
- dom/Node.cpp:
(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):
(WebCore::Node::properties):
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeRareData::itemProp):
(WebCore::NodeRareData::setItemProp):
(WebCore::NodeRareData::itemRef):
(WebCore::NodeRareData::setItemRef):
(WebCore::NodeRareData::itemType):
(WebCore::NodeRareData::setItemType):
(WebCore::NodeRareData::properties):
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::itemAfter):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setItemValueText):
- html/HTMLElement.h:
- html/HTMLElement.idl:
- html/HTMLPropertiesCollection.cpp: Added.
(WebCore::compareTreeOrder):
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::~HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::findPropetiesOfAnItem): Finds the properties of an item.
(WebCore::HTMLPropertiesCollection::length): Returns the number of elements in the properties collection.
(WebCore::HTMLPropertiesCollection::item): Returns the element with index 'index' from the collection. The items are sorted in tree order.
(WebCore::HTMLPropertiesCollection::names): Returns a DOMStringList with the property names of the elements in the collection with the order preserved but with duplicates removed.
- html/HTMLPropertiesCollection.h: Added.
- html/HTMLPropertiesCollection.idl: Added.
- page/DOMWindow.idl:
LayoutTests:
Added test for html properties collections.
- fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Added.
- fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Added.
- fast/dom/MicroData/names-property-must-be-correct-expected.txt: Added.
- fast/dom/MicroData/names-property-must-be-correct.html: Added.
- fast/dom/MicroData/names-property-test-expected.txt: Added.
- fast/dom/MicroData/names-property-test.html: Added.
- fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Added.
- fast/dom/MicroData/properties-collection-add-remove-itemref.html: Added.
- fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Added.
- fast/dom/MicroData/properties-collection-add-remove-property.html: Added.
- fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Added.
- fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Added.
- fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Added.
- fast/dom/MicroData/properties-collection-must-be-correct.html: Added.
- fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Added.
- fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Added.
- fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Added.
- fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Added.
- fast/dom/MicroData/properties-collection-test-expected.txt: Added.
- fast/dom/MicroData/properties-collection-test.html: Added.
- 10:25 AM Changeset in webkit [101143] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Removed obsolete touchui flag
https://bugs.webkit.org/show_bug.cgi?id=73067
Reviewed by Tony Chang.
- features.gypi:
- 10:10 AM Changeset in webkit [101142] by
-
- 7 edits2 adds in trunk
IndexedDB: Indexes should be secondarily sorted on primary key
https://bugs.webkit.org/show_bug.cgi?id=72567
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-24
Reviewed by Tony Chang.
Source/WebCore:
Implemented by adding the primary key (i.e. unique key in the
object store) to the IndexDataKey (i.e. the composite key used
in the index. Previously, non-unique entries in the index were
stored with a unique (and hidden) sequenceNumber, so ordering was
not predictable by scripts (or per spec). The sequenceNumber
is now deprecated but still present in the LevelDB backing store
to avoid having to do a data migration.
Test: storage/indexeddb/cursor-primary-key-order.html
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
- storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):
- storage/IDBLevelDBCoding.h:
Source/WebKit/chromium:
Updates the IndexDataKey unit tests to include primary keys. The
deprecated sequenceNumber element of IndexDataKey is still tested,
although no longer used by callers.
- tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
LayoutTests:
- storage/indexeddb/cursor-primary-key-order-expected.txt: Added.
- storage/indexeddb/cursor-primary-key-order.html: Added.
- 8:51 AM Changeset in webkit [101141] by
-
- 15 edits in trunk/Source
[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets
https://bugs.webkit.org/show_bug.cgi?id=72495
Source/JavaScriptCore:
Update defines to not use Unix Domain Sockets for platform Qt on Mac.
This enables Qt to reuse existing code for mach ports and Grand
Central Dispatch based IPC.
Reviewed by Simon Hausmann.
- wtf/Platform.h:
Source/WebKit2:
Make Qt using mach ports and Grand Central Dispatch for IPC
when building on Mac.
Reviewed by Simon Hausmann.
- Platform/CoreIPC/Attachment.cpp:
- Platform/CoreIPC/Attachment.h:
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/CoreIPCMessageKinds.h:
- Platform/SharedMemory.h:
- Platform/WorkQueue.h:
- Platform/mac/MachUtilities.cpp:
- Platform/mac/WorkQueueMac.cpp:
- Target.pri:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- 8:36 AM Changeset in webkit [101140] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: WebInspector.inspectedPageDomain is not calculated for about:blank
https://bugs.webkit.org/show_bug.cgi?id=73082
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-24
Reviewed by Timothy Hatcher.
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
- inspector/front-end/inspector.js:
(WebInspector.networkResourceById):
(WebInspector.get inspectedPageDomain):
- 8:02 AM WebKitGTK/AddingNewWebKit2API edited by
- Remove point about gobject properties (diff)
- 7:12 AM Changeset in webkit [101139] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: provide context menu items to open resources using extensions
https://bugs.webkit.org/show_bug.cgi?id=73076
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
- inspector/front-end/HandlerRegistry.js:
(get WebInspector.HandlerRegistry.prototype.set dispatch):
(get WebInspector.HandlerRegistry.prototype.dispatchToHandler):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
- inspector/front-end/externs.js:
(WebInspector.populateResourceContextMenu):
- inspector/front-end/inspector.js:
(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):
- 6:57 AM Changeset in webkit [101138] by
-
- 6 edits2 adds in trunk/Source/WebCore
[GStreamer] WebAudio AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=69835
Reviewed by Martin Robinson.
New GStreamer source element pulling data from the AudioBus and
outputing audio interleaved GstBuffers suitable for playback.
- GNUmakefile.list.am: Added the new GStreamer WebAudio element
source files to the build.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::onGStreamerWavparsePadAddedCallback): Function called
when the playback pipeline successfully parsed the audio source
into a WAV stream.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Configure the initial playback pipeline up to the WAV parser. The
audio sink is added only after the WAV parser was configured.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Reset the playback pipeline and delete it.
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady):
Method to add the audio sink to the pipeline and link it to the
WAV parser.
(WebCore::AudioDestinationGStreamer::start): Set pipeline to
PLAYING, at the first run it will trigger the WAV parser and hence
the audio-sink plugging.
(WebCore::AudioDestinationGStreamer::stop): Pause the pipeline.
- platform/audio/gstreamer/AudioDestinationGStreamer.h:
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: Added.
(getGStreamerMonoAudioCaps): Utility function to generate
GStreamer caps representing a single audio channel for a given
sample rate.
(webKitWebAudioGStreamerChannelPosition): Utility function to
convert AudioBus channel representations to GStreamer positional
audio channel values.
(webkit_web_audio_src_class_init): GObject configuration of the
GStreamer source element.
(webkit_web_audio_src_init): Initialization of the private data of
the element.
(webKitWebAudioSourceConstructed): Configure the GstBin elements
depending on the AudioBus layout.
(webKitWebAudioSourceFinalize): Clean up the GstBin and free private
data of the element.
(webKitWebAudioSourceSetProperty): GObject property setter.
(webKitWebAudioSourceGetProperty): GObject property getter.
(webKitWebAudioSourceLoop): GstTask used to pull data from the
AudioBus and push it as GstBuffers to the src pad of the element.
(webKitWebAudioSourceChangeState): Start or stop the above GstTask
depending on the asked state transition.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h: Added.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp: GstTask support in GRefPtr.
(WTF::adoptGRef):
(WTF::GstTask):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- 5:45 AM Changeset in webkit [101137] by
-
- 1 edit in branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt
Fix test expectations.
- 5:45 AM Changeset in webkit [101136] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Stop leaking memory in string QWK2 API's
https://bugs.webkit.org/show_bug.cgi?id=72558
Patch by Oleg Romashin <romaxa@gmail.com> on 2011-11-17
Reviewed by Simon Hausmann.
WKRef API pointers don't adopt the implementation pointers by default and the implementation pointers
stay alive after destroying the API pointers.
This patch adopts the implementation pointers correctly by using adoptWK that returns a WKRetainPtr
that will be around temporarily and correctly release the object.
- UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::mouseDidMoveOverElement):
- UIProcess/qt/QtDownloadManager.cpp:
(WebKit::qt_wk_didFailDownload):
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::load):
(QtWebPageProxy::url):
(QtWebPageProxy::title):
- 5:35 AM Changeset in webkit [101135] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add implementation considering ewk_tiled_backing_store's visible status.
https://bugs.webkit.org/show_bug.cgi?id=71791
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-24
Reviewed by Gustavo Noronha Silva.
In order to prevent rendering and pre-rendering while backing store is hidden,
its visibility is checked and pre-rendering is handled whenever backing store is shown or hidden.
- ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(ewk_tiled_backing_store_add):
- 5:27 AM Changeset in webkit [101134] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably
Reviewed by Andreas Kling.
We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
ways of doing that and this fix seems like the least intrusive one by simply pushing the
invoker to the gui thread if it's not there already.
- wtf/qt/MainThreadQt.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
- 5:07 AM Changeset in webkit [101133] by
-
- 13 edits in trunk
[Qt] Get rid of the buildDirForSource() function in the build system
At some point the plan was to allow for running qmake on sub-trees
of the sources, into the top level build directory, but this is no
longer possible, so no reason to keep the convenience function around.
Reviewed by Simon Hausmann.
- 5:03 AM Changeset in webkit [101132] by
-
- 4 edits in trunk/Source
[CMake] Add missing source files
https://bugs.webkit.org/show_bug.cgi?id=73052
Reviewed by Andreas Kling.
Source/WebCore:
- CMakeLists.txt:
Source/WebKit2:
Add more generic files to the sources list and remove the EFL specific stuff.
- CMakeLists.txt:
- 3:37 AM Changeset in webkit [101131] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Use QEvent for dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=72704
Reviewed by Simon Hausmann.
Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
This is the same as what invokeMethod does internally, but reduces
the dependency on some internal QThread stuff.
- wtf/qt/MainThreadQt.cpp:
(WTF::MainThreadInvoker::MainThreadInvoker):
(WTF::MainThreadInvoker::event):
(WTF::scheduleDispatchFunctionsOnMainThread):
- 1:47 AM Changeset in webkit [101130] by
-
- 2 edits in trunk/Source/WebCore
Fix ASSERTs added in r101082.
Rubber-Stamped by Martin Robinson.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Check for valid pointer before
GST_OBJECT_IS_FLOATING().
- 1:37 AM Changeset in webkit [101129] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=69738
Reviewed by Timothy Hatcher.
The source viewer is focused whenever a file name option is clicked, and is NOT focused when the script list
is traversed with the Up/Down keys.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.focus):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.focus):
- 1:10 AM Changeset in webkit [101128] by
-
- 11 edits5 adds in trunk
Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/compiler-source-mapping-debug.html
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
- http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
- http/tests/inspector/compiler-source-mapping-debug.html: Added.
- http/tests/inspector/resources/source-map.json:
- http/tests/inspector/resources/source1.js:
- http/tests/inspector/resources/source2.js:
(ClickHandler.prototype.handle):
- 12:38 AM Changeset in webkit [101127] by
-
- 2 edits in trunk/LayoutTests
2011-11-24 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update test expectations.
- platform/chromium/test_expectations.txt: Now that V8 bug 1821 is fixed the test should not crash.
- 12:17 AM EFLWebKit edited by
- (diff)
- 12:14 AM EFLWebKit edited by
- (diff)
- 12:11 AM Changeset in webkit [101126] by
-
- 22 edits in trunk
Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead.
https://bugs.webkit.org/show_bug.cgi?id=73024
Source/WebCore:
We use it for the URL mostly, no need to create artificial resource for that upon
attaching to the existing page.
Reviewed by Yury Semikhatsky.
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/HAREntry.js:
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._pageEventTime):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._exportAll):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get displayName):
(WebInspector.Resource.prototype.get displayDomain):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
- inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
- inspector/front-end/utilities.js:
(String.prototype.asParsedURL):
LayoutTests:
Reviewed by Yury Semikhatsky.
- inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger/debugger-scripts.html:
- inspector/debugger/linkifier.html:
- inspector/debugger/selected-call-frame-after-formatting-source.html:
- inspector/debugger/watch-expressions-panel-switch.html:
- inspector/extensions/extensions-events.html:
- inspector/performance/resources/first-open-resources.html:
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
- inspector/performance/resources/show-panel.html:
- inspector/styles/styles-history.html:
- 12:01 AM Changeset in webkit [101125] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: exceptions in shared workers should be logged to web inspector console
https://bugs.webkit.org/show_bug.cgi?id=73022
According to section "4.7 Runtime script errors" of Web Workers spec "For shared
workers, if the error is still not handled afterwards, or if the error occurred
while handling a previous script error, the error may be reported to the user."
This change adds uncaugh exceptions to the shared worker web inspector console.
Reviewed by Pavel Feldman.
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::restore):
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::restore):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerContext):
- inspector/InspectorInstrumentation.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
- inspector/WorkerInspectorController.h:
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.showWorkerTerminatedScreen):
- inspector/front-end/inspector.js:
- workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::logExceptionToConsole):
- workers/SharedWorkerContext.h:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::addMessage): console messages are now added to
the worker console agent.
(WebCore::WorkerContext::addMessageToWorkerConsole):
- workers/WorkerContext.h:
Nov 23, 2011:
- 11:47 PM Changeset in webkit [101124] by
-
- 2 edits in trunk/LayoutTests
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810
Unreviewed gardening.
- platform/qt/Skipped: Skip svg/dom/css-transforms.xhtml introduced in r101062, because 0.0 != -0.0.
- 11:46 PM Changeset in webkit [101123] by
-
- 4 edits2 copies in trunk/Source/WebKit/chromium
Add simple implementation for web intents chromium API data classes.
https://bugs.webkit.org/show_bug.cgi?id=73036
Patch by Greg Billock <gbillock@google.com> on 2011-11-23
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebIntent.h:
- public/WebIntentServiceInfo.h:
- src/WebIntent.cpp: Copied from Source/WebKit/chromium/public/WebIntent.h.
(WebKit::WebIntent::WebIntent):
(WebKit::WebIntent::action):
(WebKit::WebIntent::setAction):
(WebKit::WebIntent::type):
(WebKit::WebIntent::setType):
(WebKit::WebIntent::data):
(WebKit::WebIntent::setData):
(WebKit::WebIntent::identifier):
(WebKit::WebIntent::setIdentifier):
- src/WebIntentServiceInfo.cpp: Copied from Source/WebKit/chromium/public/WebIntentServiceInfo.h.
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::url):
(WebKit::WebIntentServiceInfo::setURL):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::setTitle):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::setAction):
(WebKit::WebIntentServiceInfo::type):
(WebKit::WebIntentServiceInfo::setType):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::setDisposition):
- 11:13 PM Changeset in webkit [101122] by
-
- 168 edits15 copies16 adds in trunk/Source/WebKit/chromium
[Chromium] Move WebKitPlatformSupport.h and dependencies to new public/platform directory
https://bugs.webkit.org/show_bug.cgi?id=73066
Reviewed by Darin Fisher.
This patch creates a new subdirectory in the Chromium WebKit API to
house "platform" header files. As with the other Platform directories
in WebKit, the platform directory cannot depend on headers outside of
platform, but headers outside of platform can depend on platform.
This patch moves WebKitPlatformSupport and its dependencies into this
new directory and creates forwarding headers to easy migration for
embedders of this API. Over time, we will migrate more headers into
this folder, as appropriate.
- public/WebAccessibilityObject.h:
- public/WebAccessibilityRole.h:
- public/WebAnimationController.h:
- public/WebApplicationCacheHost.h:
- public/WebApplicationCacheHostClient.h:
- public/WebArrayBufferView.h:
- public/WebAttribute.h:
- public/WebAudioBus.h: Replaced.
- public/WebAudioDevice.h: Replaced.
- public/WebAudioSourceProvider.h:
- public/WebBindings.h:
- public/WebBlob.h:
- public/WebBlobData.h:
- public/WebBlobRegistry.h:
- public/WebCString.h: Replaced.
- public/WebCache.h:
- public/WebCanvas.h:
- public/WebClipboard.h:
- public/WebColor.h:
- public/WebCommon.h: Replaced.
- public/WebCommonWorkerClient.h:
- public/WebCompositor.h:
- public/WebConsoleMessage.h:
- public/WebContentLayer.h:
- public/WebContextMenuData.h:
- public/WebCookie.h:
- public/WebCrossOriginPreflightResultCache.h:
- public/WebDOMEvent.h:
- public/WebDOMEventListener.h:
- public/WebDOMStringList.h:
- public/WebData.h: Replaced.
- public/WebDataSource.h:
- public/WebDatabase.h:
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- public/WebDevToolsFrontend.h:
- public/WebDeviceOrientationClientMock.h:
- public/WebDeviceOrientationController.h:
- public/WebDocument.h:
- public/WebDragData.h:
- public/WebExternalPopupMenuClient.h:
- public/WebExternalTextureLayer.h:
- public/WebFileChooserParams.h:
- public/WebFileInfo.h:
- public/WebFileSystem.h:
- public/WebFileSystemCallbacks.h:
- public/WebFileSystemEntry.h:
- public/WebFileUtilities.h:
- public/WebFileWriter.h:
- public/WebFileWriterClient.h:
- public/WebFindOptions.h:
- public/WebFloatPoint.h:
- public/WebFloatQuad.h:
- public/WebFloatRect.h:
- public/WebFont.h:
- public/WebFontCache.h:
- public/WebFontDescription.h:
- public/WebFormControlElement.h:
- public/WebFormElement.h:
- public/WebFrame.h:
- public/WebFrameClient.h:
- public/WebGamepad.h: Replaced.
- public/WebGamepads.h: Replaced.
- public/WebGeolocationClientMock.h:
- public/WebGeolocationController.h:
- public/WebGeolocationError.h:
- public/WebGeolocationPermissionRequest.h:
- public/WebGeolocationPermissionRequestManager.h:
- public/WebGeolocationPosition.h:
- public/WebGlyphCache.h:
- public/WebGraphicsContext3D.h:
- public/WebHTTPBody.h:
- public/WebHTTPLoadInfo.h:
- public/WebHistoryItem.h:
- public/WebIDBCallbacks.h:
- public/WebIDBCursor.h:
- public/WebIDBDatabase.h:
- public/WebIDBDatabaseCallbacks.h:
- public/WebIDBDatabaseError.h:
- public/WebIDBFactory.h:
- public/WebIDBIndex.h:
- public/WebIDBKey.h:
- public/WebIDBKeyPath.h:
- public/WebIDBKeyRange.h:
- public/WebIDBObjectStore.h:
- public/WebIDBTransaction.h:
- public/WebIDBTransactionCallbacks.h:
- public/WebIconURL.h:
- public/WebImage.h:
- public/WebInputEvent.h:
- public/WebKit.h:
- public/WebKitPlatformSupport.h: Replaced.
- public/WebLayer.h:
- public/WebLayerTreeView.h:
- public/WebLocalizedString.h: Replaced.
- public/WebMediaPlayer.h:
- public/WebMediaStreamDescriptor.h:
- public/WebMediaStreamRegistry.h:
- public/WebMediaStreamSource.h:
- public/WebMenuItemInfo.h:
- public/WebMessagePortChannel.h:
- public/WebMimeRegistry.h:
- public/WebNamedNodeMap.h:
- public/WebNetworkStateNotifier.h:
- public/WebNode.h:
- public/WebNodeCollection.h:
- public/WebNodeList.h:
- public/WebNotification.h:
- public/WebNotificationPresenter.h:
- public/WebOptionElement.h:
- public/WebPageSerializer.h:
- public/WebPasswordFormData.h:
- public/WebPeerConnectionHandler.h:
- public/WebPerformance.h:
- public/WebPlugin.h:
- public/WebPluginParams.h:
- public/WebPoint.h:
- public/WebPopupMenu.h:
- public/WebPopupMenuInfo.h:
- public/WebPrivateOwnPtr.h: Replaced.
- public/WebPrivatePtr.h: Replaced.
- public/WebRange.h:
- public/WebRect.h:
- public/WebRegularExpression.h:
- public/WebRuntimeFeatures.h:
- public/WebScriptController.h:
- public/WebScriptSource.h:
- public/WebScrollbar.h:
- public/WebSearchableFormData.h:
- public/WebSecurityOrigin.h:
- public/WebSecurityPolicy.h:
- public/WebSelectElement.h:
- public/WebSerializedScriptValue.h: Replaced.
- public/WebSettings.h:
- public/WebSharedWorker.h:
- public/WebSharedWorkerRepository.h:
- public/WebSize.h:
- public/WebSocket.h:
- public/WebSocketClient.h:
- public/WebSocketStreamError.h:
- public/WebSocketStreamHandle.h:
- public/WebSocketStreamHandleClient.h:
- public/WebSpeechInputController.h:
- public/WebSpeechInputResult.h:
- public/WebSpellCheckClient.h:
- public/WebStorageArea.h:
- public/WebStorageEventDispatcher.h:
- public/WebStorageNamespace.h:
- public/WebString.h: Replaced.
- public/WebTestingSupport.h:
- public/WebTextCheckingCompletion.h:
- public/WebTextCheckingResult.h:
- public/WebTextRun.h:
- public/WebThread.h:
- public/WebThreadSafeData.h:
- public/WebTouchPoint.h:
- public/WebURL.h: Replaced.
- public/WebURLError.h:
- public/WebURLLoadTiming.h:
- public/WebURLLoader.h:
- public/WebURLRequest.h:
- public/WebURLResponse.h:
- public/WebUserMediaRequest.h:
- public/WebVector.h: Replaced.
- public/WebView.h:
- public/WebViewClient.h:
- public/WebWidget.h:
- public/WebWidgetClient.h:
- public/WebWindowFeatures.h:
- public/android/WebInputEventFactory.h:
- public/gtk/WebInputEventFactory.h:
- public/linux/WebFontFamily.h:
- public/linux/WebFontInfo.h:
- public/linux/WebFontRenderStyle.h:
- public/linux/WebFontRendering.h:
- public/linux/WebRenderTheme.h:
- public/linux/WebSandboxSupport.h:
- public/mac/WebInputEventFactory.h:
- public/mac/WebScreenInfoFactory.h:
- public/platform: Added.
- public/platform/WebAudioBus.h: Copied from Source/WebKit/chromium/public/WebAudioBus.h.
- public/platform/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/WebAudioDevice.h.
- public/platform/WebCString.h: Copied from Source/WebKit/chromium/public/WebCString.h.
- public/platform/WebCommon.h: Copied from Source/WebKit/chromium/public/WebCommon.h.
- public/platform/WebData.h: Copied from Source/WebKit/chromium/public/WebData.h.
- public/platform/WebGamepad.h: Copied from Source/WebKit/chromium/public/WebGamepad.h.
- public/platform/WebGamepads.h: Copied from Source/WebKit/chromium/public/WebGamepads.h.
- public/platform/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitPlatformSupport.h.
- public/platform/WebLocalizedString.h: Copied from Source/WebKit/chromium/public/WebLocalizedString.h.
- public/platform/WebPrivateOwnPtr.h: Copied from Source/WebKit/chromium/public/WebPrivateOwnPtr.h.
- public/platform/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/WebPrivatePtr.h.
- public/platform/WebSerializedScriptValue.h: Copied from Source/WebKit/chromium/public/WebSerializedScriptValue.h.
- public/platform/WebString.h: Copied from Source/WebKit/chromium/public/WebString.h.
- public/platform/WebURL.h: Copied from Source/WebKit/chromium/public/WebURL.h.
- public/platform/WebVector.h: Copied from Source/WebKit/chromium/public/WebVector.h.
- public/win/WebInputEventFactory.h:
- public/win/WebScreenInfoFactory.h:
- public/x11/WebScreenInfoFactory.h:
- 11:03 PM Changeset in webkit [101121] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
https://bugs.webkit.org/show_bug.cgi?id=73065
Reviewed by Eric Seidel.
This API no longer has any callers.
- public/WebSecurityOrigin.h:
- src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::isUnique):
- 10:06 PM Changeset in webkit [101120] by
-
- 8 edits2 adds in trunk
[Chromium] Prevent DrawingBuffer instances from corrupting the active
texture state of the WebGL contexts. The DrawingBuffer now tracks the
state of texture unit 0, and the active texture unit, so that state can
be restored.
https://bugs.webkit.org/show_bug.cgi?id=73033
Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.
Test: fast/canvas/webgl/webgl-texture-binding-preserved.html
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::bindTexture):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::setTexture2DBinding):
(WebCore::DrawingBuffer::setActiveTextureUnit):
- platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/gtk/DrawingBufferGtk.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
LayoutTests:
- fast/canvas/webgl/webgl-texture-binding-preserved-expected.txt: Added.
- fast/canvas/webgl/webgl-texture-binding-preserved.html: Added.
- 10:03 PM Changeset in webkit [101119] by
-
- 3 edits in trunk/Source/WebCore
CSSValue: reorder ClassType enum to allow faster comparisons, add COMPILE_ASSERT on class size.
https://bugs.webkit.org/show_bug.cgi?id=72924
Reviewed by Andreas Kling.
Note that the change from unsigned to unsigned char is to improve bit packing when using MSVC.
Covered by existing CSS tests.
- css/CSSValue.h:
(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::CSSValue):
- 9:14 PM Changeset in webkit [101118] by
-
- 19 edits1 delete in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Reviewed by David Levin.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::serializedValueCallback):
- bindings/v8/OptionsObject.cpp:
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
- bindings/v8/SerializedScriptValue.h:
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8MessagePortCustom.h: Removed.
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Reviewed by David Levin.
- src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::serialize):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Tests rebaselined to reflect new error message.
Reviewed by David Levin.
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
- platform/chromium/fast/events/constructors/message-event-constructor-expected.txt:
- 7:24 PM Changeset in webkit [101117] by
-
- 2 edits in trunk/Source/WebCore
Cleanup #if usage in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=73060
Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.
No tests needed. Just code cleanup
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- 6:45 PM Changeset in webkit [101116] by
-
- 8 edits in trunk/Source/WebCore
Change CSSMutableStyleDeclaration::m_node to m_element (along with getter/setter)
https://bugs.webkit.org/show_bug.cgi?id=73050
Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.
No tests needed. This is just a refactor.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):
(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::setElement):
(WebCore::CSSMutableStyleDeclaration::element):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::createMappedDecl):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::inlineStyleElement):
- 6:31 PM Changeset in webkit [101115] by
-
- 12 edits in trunk/Source
Teach VideoLayerChromium how to render native texture (to support HW video decode).
https://bugs.webkit.org/show_bug.cgi?id=73043
Patch by Ami Fischman <fischman@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.
Source/WebCore:
No new tests. (depends on chromium support landing, and supporting HW being available)
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::videoLayerNativeTextureProgram):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/VideoFrameChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::determineTextureFormat):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::setNativeTexture):
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawNativeTexture):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
Source/WebKit/chromium:
- public/WebVideoFrame.h:
- src/VideoFrameChromiumImpl.cpp:
(WebKit::VideoFrameChromiumImpl::textureId):
- src/VideoFrameChromiumImpl.h:
- 6:29 PM Changeset in webkit [101114] by
-
- 4 edits in trunk/LayoutTests
IndexedDB: Remove stylesheet links from layout tests
https://bugs.webkit.org/show_bug.cgi?id=73053
Remove links to js-test-style.css that slipped in.
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.
- storage/indexeddb/cursor-key-order.html:
- storage/indexeddb/key-type-array.html:
- storage/indexeddb/mozilla/delete-result.html:
- 5:21 PM Changeset in webkit [101113] by
-
- 9 edits2 deletes in trunk/Tools
Unreviewed, rolling out r101107.
http://trac.webkit.org/changeset/101107
https://bugs.webkit.org/show_bug.cgi?id=73062
Breaks the commit-queue (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-23
- Scripts/webkitpy/common/host.py:
(Host._engage_awesome_windows_hacks):
- Scripts/webkitpy/common/host_mock.py:
(MockHost.init):
- Scripts/webkitpy/common/system/environment.py: Removed.
- Scripts/webkitpy/common/system/environment_unittest.py: Removed.
- Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output):
(Executive.run_and_throw_if_fail):
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_and_throw_if_fail):
(MockExecutive.run_command):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._driver_build_script_name):
(WebKitPort._run_script):
(WebKitPort._build_driver):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_build_driver):
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/steps/build.py:
(Build.build):
- 5:15 PM Changeset in webkit [101112] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r101110.
http://trac.webkit.org/changeset/101110
https://bugs.webkit.org/show_bug.cgi?id=73057
The bots have now cycled and this patch is no longer needed.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files):
- 4:25 PM Changeset in webkit [101111] by
-
- 11 edits in trunk/Source
Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
https://bugs.webkit.org/show_bug.cgi?id=73031
Reviewed by Dimitri Glazkov.
Source/WebCore:
No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
- dom/MouseEvent.h:
(WebCore::MouseEvent::create):
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
- dom/MouseRelatedEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
- platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::movementX):
(WebCore::PlatformMouseEvent::movementY):
Source/WebKit/chromium:
- src/WebInputEventConversion.cpp:
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
- 4:16 PM Changeset in webkit [101110] by
-
- 2 edits in trunk/Tools
Temporarily save the incremental results json in order to identify bug
https://bugs.webkit.org/show_bug.cgi?id=73057
Reviewed by Dean Jackson.
The test results server needed to be rolled back from tip of tree
due to a JSON merging bug. It's hard to identify what the bug is without
the raw data.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files):
- 4:04 PM Changeset in webkit [101109] by
-
- 3 edits in trunk/Tools
Merging two version 4 results hits an error in the test results server
https://bugs.webkit.org/show_bug.cgi?id=73042
Reviewed by Adam Barth.
The old code assumed that if the aggregate results value was not a leaf
value that the incremental results would exist, which is just totally
wrong. Added a test for that case as well.
- TestResultServer/model/jsonresults.py:
(JsonResults._merge_tests):
- TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
(JsonResultsTest.test_merge_build_directory_hierarchy):
- 3:34 PM Changeset in webkit [101108] by
-
- 2 edits in trunk/Source/WebCore
Remove one static initializer (for kTickTime)
https://bugs.webkit.org/show_bug.cgi?id=73049
Reviewed by Adam Barth.
- platform/ScrollAnimatorNone.cpp:
- 3:23 PM Changeset in webkit [101107] by
-
- 9 edits2 copies in trunk/Tools
Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=71983
Reviewed by Adam Barth.
We'll add more code to Environment overtime,
allowing us to mock out more of our direct interactions with os.environ.
This patch also makes run_command print the passed in environment.
- Scripts/webkitpy/common/host_mock.py:
- Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
- Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
- Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_mock.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/steps/build.py:
- 3:11 PM Changeset in webkit [101106] by
-
- 2 edits8 moves37 adds12 deletes in trunk/LayoutTests
More Chromium rebaselines for r101062. Unreviewed gardening.
- platform/chromium-cg-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dom/css-transforms-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
- platform/chromium-linux/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/chromium-linux/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
- platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
- platform/chromium-linux/svg/dom/css-transforms-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
- platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
- platform/chromium-mac-leopard/svg/dom/css-transforms-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dom/css-transforms-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
- platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
- platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
- platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Removed.
- platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
- platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
- platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
- platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Removed.
- platform/chromium-win/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/chromium-win/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png.
- platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt.
- platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png.
- platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt.
- platform/chromium-win/svg/dom/css-transforms-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png.
- platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt.
- platform/chromium-win/svg/transforms/svg-css-transforms-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png.
- platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt.
- platform/chromium/test_expectations.txt:
- 3:04 PM Changeset in webkit [101105] by
-
- 2 edits in trunk/LayoutTests
[skia] need to rebaseline after SK_ENABLE_FAST_SHADERMASK is enabled in skia/skia.gyp
https://bugs.webkit.org/show_bug.cgi?id=73044
unreviewed, expectations update
- platform/chromium/test_expectations.txt:
- 2:48 PM Changeset in webkit [101104] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Drop root layer tiles on platforms that cache the front buffer
https://bugs.webkit.org/show_bug.cgi?id=72956
Patch by Jonathan Backer <backer@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
- 2:03 PM Changeset in webkit [101103] by
-
- 4 edits1 move1 delete in trunk/Source/WebKit2
[Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
https://bugs.webkit.org/show_bug.cgi?id=72914
Reviewed by Andreas Kling.
Make the signal downloadRequested an experimental API from QQuickWebView
and modify the qml test to use a WebView instead of a DesktopWebView.
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml.
- UIProcess/API/qt/tests/qmltests/common/download.html: Removed.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didReceiveDownloadResponse):
- 2:03 PM Changeset in webkit [101102] by
-
- 12 edits in trunk/Source/WebCore
Binding CodeGenerators don't support Conditional= on constants
https://bugs.webkit.org/show_bug.cgi?id=67666
Reviewed by Adam Barth.
Adds support for [Conditional=LABEL] to const IDL fields.
- bindings/scripts/CodeGenerator.pm:
(GenerateConditionalStringFromAttributeValue): Moved out of CodeGenerator{CPP,JS,V8}.pm.
(GenerateCompileTimeCheckForEnumsIfNeeded): Wrap in conditional #if.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateConditionalString):
(GenerateHeader): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConditionalString):
(GenerateHeader): Ditto.
(GenerateImplementation): Ditto.
(GenerateHashTable):
(WriteData):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader): Ditto.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateConditionalString): Ditto.
(GenerateImplementation):
(WriteData):
- bindings/scripts/test/CPP/WebDOMTestObj.h: Generated code now wraps conditional const in #if.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjCONDITIONAL_CONST): Ditto
- bindings/scripts/test/JS/JSTestObj.h: Ditto
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto
- bindings/scripts/test/TestObj.idl: Added a conditional const.
- bindings/scripts/test/V8/V8TestObj.cpp: Generated code now wraps conditional const in #if.
- 1:40 PM Changeset in webkit [101101] by
-
- 8 edits in trunk
[MutationObservers] Modifications to the style property don't dispatch "attributes" Mutation Records
https://bugs.webkit.org/show_bug.cgi?id=70137
Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch adds a private AttributesMutationScope mechanism to CSSMutableStyleDeclaration (which uses
the RAII pattern similar to the public ChildListMutationScope). This manages the (sometimes conditional)
pre-change serialization of the style attribute (if an observer has requested oldValue), creation of
the mutation record, and dispatch if the declaration was actual affected.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
(WebCore::CSSMutableStyleDeclaration::parseDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperties):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::setCssText):
(WebCore::CSSMutableStyleDeclaration::merge):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- dom/Element.cpp:
(WebCore::Element::setAttribute):
LayoutTests:
Added tests asserting that changes to the style property are observable and work correctly if oldValue is requested.
- fast/mutation/observe-attributes-expected.txt:
- fast/mutation/observe-attributes.html:
- 12:18 PM Changeset in webkit [101100] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove BlackBerry OS support from RandomNumberSeed, making QNX=UNIX.
https://bugs.webkit.org/show_bug.cgi?id=73028
Reviewed by Daniel Bates.
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
- 11:58 AM Changeset in webkit [101099] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rebaseline binding tests after http://trac.webkit.org/changeset/101064.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::toFloat64Array):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- 11:40 AM Changeset in webkit [101098] by
-
- 1 edit1 delete in trunk/LayoutTests
Rebaseline Chromium after r101056. Unreviewed gardening.
- platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Removed.
- 11:33 AM Changeset in webkit [101097] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp
Initialize Lengths from float css values as opposed to the rounded int values.
- 11:30 AM Changeset in webkit [101096] by
-
- 1 edit26 adds in trunk/LayoutTests
Chromium rebaselines after r101062. Unreviewed gardening.
- platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
- platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
- platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
- platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt: Added.
- platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
- platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.png: Added.
- platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
- platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
- platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
- platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png: Added.
- platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Added.
- platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
- platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png: Added.
- platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
- platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
- platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
- platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png: Added.
- platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
- platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
- platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Added.
- 11:18 AM Changeset in webkit [101095] by
-
- 2 edits in trunk/LayoutTests
Last rebaseline (really this time) for video-zoom-controls.html.
Unreviewed gardening.
- platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png: Copied by hand from bot's zip file.
- 11:04 AM Changeset in webkit [101094] by
-
- 11 edits2 deletes in trunk
Unreviewed, rolling out r101069.
http://trac.webkit.org/changeset/101069
https://bugs.webkit.org/show_bug.cgi?id=73032
New test always times out (Requested by aklein on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-23
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
- http/tests/inspector/compiler-source-mapping-debug-expected.txt: Removed.
- http/tests/inspector/compiler-source-mapping-debug.html: Removed.
- http/tests/inspector/resources/source-map.json:
- http/tests/inspector/resources/source1.js:
(window.onload):
- http/tests/inspector/resources/source2.js:
(ClickHandler.prototype.handle):
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 10:51 AM Changeset in webkit [101093] by
-
- 2 edits in trunk/LayoutTests
[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=72271
Unreviewed gardening.
- platform/chromium/test_expectations.txt: Mark fast/dom/node-iterator-reference-node-moved-crash.html as flaky
- 10:41 AM Changeset in webkit [101092] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/loading/307-after-303-after-post.html is flaky on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=73030
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 10:33 AM Changeset in webkit [101091] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=72354
Image pointer in FillLayer not cleared correctly
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/css/fill-layer-crash.html
We should clear the image pointer too, not just the m_imageSet bit.
- rendering/style/FillLayer.h:
(WebCore::FillLayer::clearImage):
LayoutTests:
- fast/css/fill-layer-crash-expected.txt: Added.
- fast/css/fill-layer-crash.html: Added.
- 10:29 AM Changeset in webkit [101090] by
-
- 2 edits in trunk/LayoutTests
[skia] need rebaselining after skia rev. 2735 lands
https://bugs.webkit.org/show_bug.cgi?id=73023
unreviewed, expectations update
- platform/chromium/test_expectations.txt:
- 10:19 AM Changeset in webkit [101089] by
-
- 6 edits1 move in trunk
[Qt] Re-generate QtWebKit API forwarding headers when API changes
The forwarding headers are generated by syncqt, and syncqt is run by qmake,
so we need sync.profile to live in the same directory as the project file
that will be touched when adding/removing API (api.pri in our case).
Since the WebKit2 APIs live in a separate static library, we have to
add the project file for WebKit2 as a dependency of the api.pri file
as well, so that any changes to the WebKit2 API will still trigger a
run of qmake (and then syncqt).
Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
that the forwarding headers are still generated in the root build dir,
not in the Source dir along with the internal forwarding headers.
Reviewed by Andreas Kling.
- 10:12 AM Changeset in webkit [101088] by
-
- 19 edits in trunk
Unreviewed, rolling out r101057.
http://trac.webkit.org/changeset/101057
https://bugs.webkit.org/show_bug.cgi?id=73027
Broke Chromium Windows build (Requested by aklein on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-23
Source/WebCore:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::didCompleteLoad):
(WebCore::HTMLTrackElement::textTrackReadyStateChanged):
- html/HTMLTrackElement.h:
- html/HTMLTrackElement.idl:
- html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::loadTimerFired):
(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):
- html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setReadyState):
- html/TextTrack.h:
(WebCore::TextTrack::readyState):
- html/TextTrack.idl:
LayoutTests:
- media/track/track-add-track-expected.txt:
- media/track/track-add-track.html:
- media/track/track-constants-expected.txt:
- media/track/track-constants.html:
- media/track/track-load-error-readyState-expected.txt:
- media/track/track-load-error-readyState.html:
- media/track/track-load-from-element-readyState-expected.txt:
- media/track/track-load-from-element-readyState.html:
- media/track/track-load-from-src-readyState-expected.txt:
- media/track/track-load-from-src-readyState.html:
- 9:49 AM Changeset in webkit [101087] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] MediaStream API: Missing WEBKIT_EXPORT in WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=73010
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.
- public/WebMediaStreamRegistry.h:
- 8:52 AM Changeset in webkit [101086] by
-
- 7 edits1 move in trunk/Source/WebKit2
[Qt] [WK2] Expose onNavigationRequested signal instead of expecting a slot be defined from QML
https://bugs.webkit.org/show_bug.cgi?id=72976
Reviewed by Tor Arne Vestbø.
Expecting slots/methods to be implemented in QML isn't very idiomatic in
comparison with the alternative of having a signal. So we now use a signal
for handling navigation requests, and expose a 'request' object with relevant
metadata. There's also a settable property 'action' used to indicate whether
the navigation should be ignored or trigger a download.
The pattern signal with an object parameter that can keep the reply is common in QML,
and used for example for mouse signals.
- UIProcess/API/qt/qquickwebview.cpp:
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/qt/QtWebPagePolicyClient.cpp:
(NavigationRequest::NavigationRequest):
(NavigationRequest::url):
(NavigationRequest::button):
(NavigationRequest::modifiers):
(NavigationRequest::action):
(NavigationRequest::setAction):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
- UIProcess/qt/QtWebPagePolicyClient.h:
- 8:04 AM Changeset in webkit [101085] by
-
- 5 edits in trunk/Source/WebCore
2011-11-23 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix. Added missing ENABLE(WORKERS) guards.
- inspector/WorkerConsoleAgent.cpp:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- 7:53 AM Changeset in webkit [101084] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip another svg test on GTK showing signed zero issues.
- platform/gtk/Skipped: Skip svg/dom/css-transforms.xhtml.
- 7:36 AM Changeset in webkit [101083] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r101060.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 7:33 AM Changeset in webkit [101082] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] improper usage of gst_object_ref_sink
https://bugs.webkit.org/show_bug.cgi?id=73014
Reviewed by Martin Robinson.
No new tests. Existing tests cover this already.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Ensure this is called with non-floating GstObjects.
(WTF::GstElement): Replace gst_object_ref_sink with
gst_object_ref+gst_object_sink like advised in the GstObject documentation.
(WTF::GstPad): Ditto.
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- 7:28 AM Changeset in webkit [101081] by
-
- 18 edits8 copies in trunk/Source/WebCore
Web Inspector: split console agent into worker and page console agents
https://bugs.webkit.org/show_bug.cgi?id=73019
InspectorConsoleAgent now has two descendants: WorkerConsoleAgent and PageConsoleAgent
which encapsulate functionality specific for the type of inspected instance.
Reviewed by Pavel Feldman.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorStyleTextEditor.cpp:
- inspector/InspectorStyleTextEditor.h:
- inspector/PageConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.cpp.
(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):
(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):
(WebCore::PageConsoleAgent::developerExtrasEnabled):
- inspector/PageConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
(WebCore::PageRuntimeAgent::PageRuntimeAgent): PageRuntimeAgent was moved into its own file.
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::scriptStateForFrameId):
(WebCore::PageRuntimeAgent::getDefaultInspectedState):
- inspector/PageRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
- inspector/WorkerConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::~WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::addInspectedNode):
(WebCore::WorkerConsoleAgent::developerExtrasEnabled):
- inspector/WorkerConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent): WorkerRuntimeAgent was moved into its own file.
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::scriptStateForFrameId):
(WebCore::WorkerRuntimeAgent::getDefaultInspectedState):
- inspector/WorkerRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
- 6:34 AM Changeset in webkit [101080] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: warning icon for unrecognized style rule should have tooltip
https://bugs.webkit.org/show_bug.cgi?id=50638
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js: Add new tooltip strings.
- inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.prototype.keySet): Added.
- inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark.
- inspector/front-end/elementsPanel.css:
(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
- 6:25 AM Changeset in webkit [101079] by
-
- 4 edits in trunk
[EFL] Add zlib depend when freetype is used.
https://bugs.webkit.org/show_bug.cgi?id=66365
Unreviewed build fix.
When freetype is enabled, uncompress() function is used by
WOFFFileFormat.cpp. Since zlib is not required by freetype, we need to
add libz as dependency for fix linking issue.
.:
Patch by Halton Huo <halton.huo@intel.com> on 2011-11-23
- Source/cmake/OptionsEfl.cmake: search for ZLIB
Source/WebCore:
No new test because this change is only to fix linking issue.
Patch by Halton Huo <halton.huo@intel.com> on 2011-11-23
- PlatformEfl.cmake: add ZLIB as dependency when using freetype
- 6:23 AM Changeset in webkit [101078] by
-
- 10 edits3 adds in trunk
CSS Exclusions: parse the shorthand "wrap" property
https://bugs.webkit.org/show_bug.cgi?id=71905
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/exclusions/wrap-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
LayoutTests:
- fast/exclusions/script-tests/wrap-parsing.js: Added.
- fast/exclusions/wrap-parsing-expected.txt: Added.
- fast/exclusions/wrap-parsing.html: Added.
- 6:14 AM Changeset in webkit [101077] by
-
- 4 edits3 adds in trunk
[CSS Filters] WebKit crashes when changing the filter
https://bugs.webkit.org/show_bug.cgi?id=72723
Reviewed by Simon Fraser.
Source/WebCore:
There are three things fixed with this patch:
- The list of effects wasn't cleared when the FilterOperations were changed.
- The sourceImage was going to be 0, because the m_sourceGraphicBuffer.release()
was also clearing the reference to m_sourceGraphicBuffer. Next time the build() method
was called m_graphicsBufferAttached was set to false, but the m_sourceGraphicBuffer was
not regenerated, because the size was not invalidated.
- maxEffectRects were not updated when a new list of effects was built.
Test: css3/filters/crash-filter-change.html
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):
- rendering/FilterEffectRenderer.h:
(WebCore::FilterEffectRenderer::setSourceImageRect):
LayoutTests:
- css3/filters/crash-filter-change-expected.png: Added.
- css3/filters/crash-filter-change-expected.txt: Added.
- css3/filters/crash-filter-change.html: Added.
- 6:12 AM Changeset in webkit [101076] by
-
- 4 edits in trunk
Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
https://bugs.webkit.org/show_bug.cgi?id=72950
Reviewed by Tony Chang.
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::queueLoadHTMLString):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 6:09 AM Changeset in webkit [101075] by
-
- 2 edits2 deletes in trunk/LayoutTests
Unreviewed rebaselining: update incorrectly generated baseline images
that masked http://crbug.com/105025 ('Regression: WebGL content flipped
with use_skia enabled on mac.')
Marking these tests as expected to fail until we fix the underlying bug.
- platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
- platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 5:58 AM Changeset in webkit [101074] by
-
- 4 edits in trunk/Tools
garden-o-matic should display a message if it can't find results to display
https://bugs.webkit.org/show_bug.cgi?id=72991
Reviewed by Dimitri Glazkov.
Not all failures (e.g., TIMEOUT) have results that we can display.
This patch adds a short message so that the user can see that we're
done trying to load the results.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- 5:45 AM Changeset in webkit [101073] by
-
- 2 edits in trunk/Source/WebCore
[Skia] fix duplicate symbol ZN7WebCore11BitmapImage16initPlatformDataEv error
https://bugs.webkit.org/show_bug.cgi?id=72954
Patch by Elliot Poger <epoger@google.com> on 2011-11-23
Reviewed by Adam Barth.
- WebCore.gyp/WebCore.gyp:
- 5:38 AM Changeset in webkit [101072] by
-
- 5 edits in trunk/Tools
garden-o-matic should explain more clearly what the builder lists at the top of the page mean
https://bugs.webkit.org/show_bug.cgi?id=72992
Reviewed by Dimitri Glazkov.
This patch also prepares us to list other sorts of failures, like
performance and unit test.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 5:20 AM Changeset in webkit [101071] by
-
- 9 edits1 move1 add in trunk/Source/WebKit2
[Qt] [WK2] Move PagePolicyClient related code to QtWebPagePolicyClient
https://bugs.webkit.org/show_bug.cgi?id=72959
Reviewed by Andreas Kling.
Split PagePolicyClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPagePolicyClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.
QtPolicyInterface abstraction was not helping us as much as the separation of
the client code will. It was more useful when we had multiple WebViews.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(toPolicyAction):
(QQuickWebViewPrivate::navigationPolicyForURL):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/qt/ClientImpl.cpp:
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/QtWebPagePolicyClient.cpp: Added.
(QtWebPagePolicyClient::QtWebPagePolicyClient):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQtWebPagePolicyClient):
(toQtMouseButton):
(toQtKeyboardModifiers):
(QtWebPagePolicyClient::decidePolicyForResponse):
- UIProcess/qt/QtWebPagePolicyClient.h: Renamed from Source/WebKit2/UIProcess/qt/QtPolicyInterface.h.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
- UIProcess/qt/QtWebPageProxy.h:
- 5:15 AM Changeset in webkit [101070] by
-
- 2 edits in trunk/Tools
Add new Chromium tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=72997
Patch by Ryan Sleevi <rsleevi@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/dashboard_base.js:
():
- 5:10 AM Changeset in webkit [101069] by
-
- 11 edits2 adds in trunk
Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/compiler-source-mapping-debug.html
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
- http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
- http/tests/inspector/compiler-source-mapping-debug.html: Added.
- http/tests/inspector/resources/source-map.json:
- http/tests/inspector/resources/source1.js:
- http/tests/inspector/resources/source2.js:
(ClickHandler.prototype.handle):
- 5:03 AM Changeset in webkit [101068] by
-
- 3 edits in trunk/Tools
garden-o-matic should support AUDIO failures
https://bugs.webkit.org/show_bug.cgi?id=69477
Reviewed by Dimitri Glazkov.
This is a first iteration at supporting AUDIO failures in
garden-o-matic. We'll probably need to iterate a bit when we have a
real audio failure in the tree to play with. For example, we'll
probably want to add and <audio> element to the "Examine" view to hear
the differences, but that all can be done in a subsequent patch.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- 4:48 AM Changeset in webkit [101067] by
-
- 2 edits in trunk/Source/WebCore
Build fix for GTK+.
- platform/graphics/gtk/DrawingBufferGtk.cpp:
(WebCore::DrawingBuffer::DrawingBuffer): Update signature and ASSERT
for the GTK+ port.
- 4:19 AM Changeset in webkit [101066] by
-
- 6 edits in trunk/Source/WebCore
Remove notifyChange from the public interface of CSSMutableStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=72660
Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.
No tests needed. This is only a refactor.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setContentEditable):
- 4:16 AM Changeset in webkit [101065] by
-
- 13 edits6 adds in trunk
Adding gamepad support
https://bugs.webkit.org/show_bug.cgi?id=69451
Source/WebCore:
Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.
Plumb gamepad data access through platform.
Test: gamepad/gamepad-polling-access.html
- WebCore.gypi:
- page/Navigator.cpp:
(WebCore::Navigator::webkitGamepads):
- page/Navigator.h:
- platform/Gamepads.h: Added.
- platform/chromium/GamepadsChromium.cpp: Added.
(WebCore::sampleGamepads):
- platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
Add implementation of sampleGamepads in Chromium platform. Retrieves
gamepad data from Chromium port and converts to DOM format, i.e.
GamepadList.
Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::sampleGamepads):
Tools:
Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.
Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
gamepad data that will be retrieved when JS code pulls via API access.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/GamepadController.cpp: Added.
(GamepadController::GamepadController):
(GamepadController::bindToJavascript):
(GamepadController::reset):
(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):
(GamepadController::fallbackCallback):
- DumpRenderTree/chromium/GamepadController.h: Added.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::gamepadController):
LayoutTests:
Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.
- fast/dom/script-tests/prototype-inheritance.js: Exclude
gamepadController from enumeration.
- gamepad/gamepad-polling-access-expected.txt: Added.
- gamepad/gamepad-polling-access.html: Added.
- 4:06 AM Changeset in webkit [101064] by
-
- 19 edits in trunk/Source
Source/WebCore: Get rid of WebCore dependencies from TypedArray implementation types
https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.
Remove WebCore specific logic for neutering Typed Array implementations.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
- html/canvas/ArrayBuffer.cpp:
(WTF::ArrayBuffer::transfer):
- html/canvas/ArrayBuffer.h:
- html/canvas/ArrayBufferView.cpp:
(WTF::ArrayBufferView::neuter):
- html/canvas/ArrayBufferView.h:
- html/canvas/DataView.cpp:
(WebCore::DataView::neuter):
- html/canvas/DataView.h:
- html/canvas/Float32Array.h:
- html/canvas/Float64Array.h:
- html/canvas/Int16Array.h:
- html/canvas/Int32Array.h:
- html/canvas/Int8Array.h:
- html/canvas/Uint16Array.h:
- html/canvas/Uint32Array.h:
- html/canvas/Uint8Array.h:
Source/WebKit/chromium: Get rid of WebCore dependencies from TypedArray implementation types
https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.
- src/WebArrayBufferView.cpp: WebCore replaced with WTF
- 3:55 AM Changeset in webkit [101063] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-11-23 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline win results after r101052.
Win/Mac share the same results now, I suspect the same will hold true for gtk/qt/cr.
- platform/win/svg/dom: Removed.
- platform/win/svg/dom/length-list-parser-expected.txt: Removed.
- 3:34 AM Changeset in webkit [101062] by
-
- 6 edits38 adds in trunk
First step towards http://webkit.org/b/70025
Allow -webkit-transform to be have effect to SVG elements.
Currently, the CSS transform takes precedence over the SVG transform attribute
Allow SVG elements to be transformed using webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=71309
Patch by Raul Hudea <rhudea@adobe.com> on 2011-11-23
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Tests: svg/clip-path/clip-path-css-transform-1.svg
svg/clip-path/clip-path-css-transform-2.svg
svg/custom/clip-path-with-css-transform-1.svg
svg/custom/clip-path-with-css-transform-2.svg
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-text-css-transform.svg
svg/dom/css-transforms.xhtml
svg/dynamic-updates/SVG-dynamic-css-transform.html
svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html
svg/transforms/svg-css-transforms-clip-path.xhtml
svg/transforms/svg-css-transforms.xhtml
- manual-tests/svg-animation-css-transform.html: Added.
- manual-tests/svg-css-animate-compound.html: Added.
- manual-tests/svg-css-transition-compound.html: Added.
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::styleWillChange):
Set the updateTransform flag on SVG elements whenever a CSS transform is present on the style
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
Use the RenderStyle's transform (if it exists) over the SVG's transform
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::animatedLocalTransform):
Use the RenderStyle's transform (if it exists) over the SVG's transform
LayoutTests:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
- platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Added.
- platform/mac/svg/custom/clip-path-with-css-transform-1-expected.txt: Added.
- platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Added.
- platform/mac/svg/custom/clip-path-with-css-transform-2-expected.txt: Added.
- platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
- platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Added.
- platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
- platform/mac/svg/dom/css-transforms-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
- platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
- platform/mac/svg/transforms/svg-css-transforms-expected.png: Added.
- platform/mac/svg/transforms/svg-css-transforms-expected.txt: Added.
- svg/clip-path/clip-path-css-transform-1.svg: Added.
- svg/clip-path/clip-path-css-transform-2.svg: Added.
- svg/custom/clip-path-with-css-transform-1.svg: Added.
- svg/custom/clip-path-with-css-transform-2.svg: Added.
- svg/custom/pointer-events-image-css-transform.svg: Added.
- svg/custom/pointer-events-text-css-transform.svg: Added.
- svg/dom/css-transforms-expected.txt: Added.
- svg/dom/css-transforms.xhtml: Added.
- svg/dynamic-updates/SVG-dynamic-css-transform-expected.txt: Added.
- svg/dynamic-updates/SVG-dynamic-css-transform.html: Added.
- svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.txt: Added.
- svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html: Added.
- svg/dynamic-updates/script-tests/SVGClipPathElement-css-transform-influences-hitTesting.js: Added.
(executeBackgroundTest):
(executeTest):
- svg/transforms/svg-css-transforms-clip-path.xhtml: Added.
- svg/transforms/svg-css-transforms.xhtml: Added.
- 2:46 AM Changeset in webkit [101061] by
-
- 6 edits in trunk/Source/WebCore
[MutationObservers] Cleanup duplicated code in Element & CharacterData
https://bugs.webkit.org/show_bug.cgi?id=72986
Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.
This patch creates a MutationObserverInterestGroup which represents the set
of MutationObservers which should receive all mutations of a given type generated
from a specific node.
No tests needed. This patch is only a refactor.
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
- dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
- dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
- dom/WebKitMutationObserver.cpp:
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
- dom/WebKitMutationObserver.h:
(WebCore::MutationObserverInterestGroup::isEmpty):
(WebCore::MutationObserverInterestGroup::hasOldValue):
- 2:35 AM Changeset in webkit [101060] by
-
- 5 edits in trunk
[GTK] Enable WebGL by default
https://bugs.webkit.org/show_bug.cgi?id=69706
Reviewed by Xan Lopez.
.:
- configure.ac: Enable WebGL by default if the build target is X11.
LayoutTests:
- platform/gtk/Skipped: Skip all WebGL tests until we can ensure they
run properly on the bots.
- platform/platform/gtk-wk2/Skipped: Ditto.
- 2:10 AM Changeset in webkit [101059] by
-
- 3 edits in trunk/Source/WebCore
[chromium] HDC leak in Uniscribe Helper
https://bugs.webkit.org/show_bug.cgi?id=68598
Patch by Marc-Andre Decoste <mad@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.
For some reason the Script functions on Windows sometimes return
E_PENDING even with a non-NULL DC, so we must handle that case.
Also, we should not use the screen DC to select font since this
refreshes the whole desktop, so I added a cached compatible DC.
Note that this doesn't reproduce with WebKit alone, it only reproduces
within Chrome, so we can't write a WebKit test for it. A chromium
browser test will be added once this change gets rolled in the
chromium DEPS file.
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::shape):
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
(WebCore::UniscribeHelper::fillShapes):
- platform/graphics/chromium/UniscribeHelper.h:
- 2:02 AM Changeset in webkit [101058] by
-
- 5 edits5 adds in trunk/Source/WebKit/chromium
[chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678
This patch includes a fix for https://bugs.webkit.org/show_bug.cgi?id=72925.
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebUserMediaClient.h: Added.
(WebKit::WebUserMediaClient::~WebUserMediaClient):
- public/WebUserMediaRequest.h: Added.
(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):
- public/WebViewClient.h:
(WebKit::WebViewClient::userMediaClient):
- src/UserMediaClientImpl.cpp: Added.
(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):
- src/UserMediaClientImpl.h: Added.
- src/WebUserMediaRequest.cpp: Added.
(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator UserMediaRequest*):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- 1:25 AM Changeset in webkit [101057] by
-
- 19 edits in trunk
Move readyState from TextTrack to HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=72553
Reviewed by Eric Carlson.
Source/WebCore:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::HTMLTrackElement):
Set initial readyState to NONE.
(WebCore::HTMLTrackElement::didCompleteLoad):
Set readyState based on load completed status.
(WebCore::HTMLTrackElement::setReadyState):
This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).
- html/HTMLTrackElement.h:
ReadyState enum and m_readyState member variable moved from TextTrack.
(WebCore::HTMLTrackElement::readyState):
New: readyState() getter.
- html/HTMLTrackElement.idl:
Add readyState attribute and associated constants.
- html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState
to HTMLTrackElement (it can set it based on loading status).
- html/TextTrack.cpp: Remove readyState from TextTrack.
(WebCore::TextTrack::TextTrack): Ditto.
- html/TextTrack.h: Ditto.
- html/TextTrack.idl: Ditto.
LayoutTests:
- media/track/track-add-track-expected.txt:
- media/track/track-add-track.html:
- media/track/track-constants-expected.txt:
- media/track/track-constants.html:
- media/track/track-load-error-readyState-expected.txt:
- media/track/track-load-error-readyState.html:
- media/track/track-load-from-element-readyState-expected.txt:
- media/track/track-load-from-element-readyState.html:
- media/track/track-load-from-src-readyState-expected.txt:
- media/track/track-load-from-src-readyState.html:
- 1:22 AM Changeset in webkit [101056] by
-
- 11 edits in trunk
Add flags/precision arguments to String::number(double) to allow fine-grained control over the result string
https://bugs.webkit.org/show_bug.cgi?id=72793
Reviewed by Zoltan Herczeg.
Source/JavaScriptCore:
This new code will be used in follow-up patches to replace the String::format("%.2f") usage in
platform/text/TextStream.cpp, and String::format("%.6lg") usage in svg/SVGPathStringBuilder.cpp.
The String::number(double) currently calls String::format("%.6lg") in trunk. In order to replace
this by a variant that properly rounds to six significant figures, JSC code could be refactored.
JSCs Number.toPrecision/toFixed uses wtf/dtoa/double-conversion which provides all features we need,
except truncating trailing zeros, needed to mimic the "g" format, which is either f or e but with
trailing zeros removed, producing shorter results. Changed the default signature to:
"static String number(double, unsigned = ShouldRoundSignificantFigures | ShouldTruncateTrailingZeros, unsigned precision = 6);".
In WebCore we can now replace String::format() calls like this:
String::format("%.2f", f) -> String::number(f, ShouldRoundDecimalPlaces, 2)
String::format("%.6lg", f) -> String::number(f)
The default parameters for precison & flags exactly match the format of the string produced now, except that the result
is rounded according to the rounding mode / formatting mode and precision. This paves the way towards reliable results
in the d="" attribute dumps of SVG paths across platforms. The dtoa rounding code enforces a unique zero, resolving
all 0.0 vs. -0.0 issues currently seen on Windows, and some Gtk/Qt bots.
This patch needs a rebaseline of svg/dom/length-list-parser.html as we don't perfecly mimic the String::format() "lg" mode
result for exponentials, we used to return eg. "e-7" and now return "e-07" - the trailing zero truncation hasn't been
implemented for exponentials, as this really affects only this test and thus wasn't worth the trouble - in contrary the
trailing zero truncation is needed for thousands of other results in "f" notation, and thus needed to match the DRT results.
Here's a performance comparision using a JSC release build and some arbitary numbers:
Converting 123.456 using old approach took 95.527100ms. avg 0.000955ms/call.
Converting 123.456 using new approach took 28.126953ms. avg 0.000281ms/call.
Converting 123 using old approach took 85.411133ms. avg 0.000854ms/call.
Converting 123 using new approach took 24.190186ms. avg 0.000242ms/call.
Converting 0.1 using old approach took 92.622803ms. avg 0.000926ms/call.
Converting 0.1 using new approach took 23.317871ms. avg 0.000233ms/call.
Converting 1/i using old approach took 106.893066ms. avg 0.001069ms/call.
Converting 1/i using new approach took 27.164062ms. avg 0.000272ms/call.
For all numbers I've tested in RoundingSignificantFigures mode and 6 digit precision the speedup was at least 250%.
- JavaScriptCore.exp: Change String::number(double) signature.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Ditto.
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToFixed): Refactor this into numberToFixedPrecisionString(), move to wtf/dtoa.cpp.
(JSC::numberProtoFuncToPrecision): Ditto, refactor this into numberToFixedWidthString.
- wtf/dtoa.cpp: Moved fixedWidth/Precision helpers into dtoa, extend numberToFixedPrecisionString(). Add a mode which allows to truncate trailing zeros/decimal point.
to make it possible to use them to generate strings that match the output from String::format("%6.lg"), while using our dtoas rounding facilities.
- wtf/dtoa.h:
- wtf/dtoa/utils.h: Expose new helper method, which allows us to truncate the result, before generating the output const char*.
(WTF::double_conversion::StringBuilder::SetPosition):
- wtf/text/WTFString.cpp:
(WTF::String::number): Remove String::format("%6.lg") usage! Switch to rounding to six significant figures, while matching the output of String::format.
- wtf/text/WTFString.h:
LayoutTests:
Rebaseline one test result, after the String::number(double) changes. Trailing zeros are no longer removed
in the exponential form of the string: e-07 is reported instead of e-7 now. It was decided to leave it as-is
and not introduce trailing zero removal for the exponential formatting, as it only affects this test.
I'll rebaseline other platforms once results are available.
- svg/dom/length-list-parser-expected.txt:
- 1:20 AM Changeset in webkit [101055] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Expose showFPSCounter and showPlatformLayerTree in WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=72973
Patch by Antoine Labour <piman@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.
- public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
- 1:10 AM Changeset in webkit [101054] by
-
- 2 edits in trunk/Source/JavaScriptCore
WTF::String has extra WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=72858
Patch by Hajime Morrita <morrita@chromium.org> on 2011-11-23
Reviewed by Kevin Ollivier.
- wtf/text/WTFString.h:
(WTF::String::String):
- 1:09 AM Changeset in webkit [101053] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip failing accessibility test on GTK.
- platform/gtk/Skipped: Skip accessibility/multiselect-list-reports-active-option.html
- 1:08 AM Changeset in webkit [101052] by
-
- 15 edits1 copy2 moves1 add in trunk
[CMake] Move the top-level logic to the top-level directory.
https://bugs.webkit.org/show_bug.cgi?id=72685
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-23
Reviewed by Brent Fulgham.
.:
Move most of the top-level code in Source/CMakeLists.txt to
CMakeLists.txt. This allows us to replace some INCLUDE() hacks with
proper ADD_SUBDIRECTORY() calls, and actually moves non-Source related
to a non-Source directory.
- CMakeLists.txt: Copied from Source/CMakeLists.txt.
Source/JavaScriptCore:
- CMakeLists.txt: Point to the right Source/ directory.
- wtf/CMakeLists.txt: Ditto.
Source/WebCore:
No new tests, this is a buildsystem changes.
- CMakeLists.txt: Adjust the Source/ directory.
- PlatformBlackBerry.cmake: Ditto.
Source/WebKit:
- blackberry/CMakeListsBlackBerry.txt: Adjust the Source/ directory.
Source/WebKit2:
- CMakeLists.txt: Adjust Source/ directory.
Tools:
- CMakeLists.txt: Added.
- DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
- EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
- Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
- WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
- 1:00 AM Changeset in webkit [101051] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed, GTK baselines for 3 new tests.
- platform/gtk/animations/additive-transform-animations-expected.txt: Added.
- platform/gtk/css3/images/cross-fade-overflow-position-expected.txt: Added.
- platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
- 12:55 AM Changeset in webkit [101050] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip failing editing/spelling/spellcheck-async.html
test on GTK.
- platform/gtk/Skipped:
- 12:48 AM Changeset in webkit [101049] by
-
- 2 edits in trunk/Source/WebKit/gtk
Documentation fix for load-committed in webkitwebframe
https://bugs.webkit.org/show_bug.cgi?id=72927
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-23
Reviewed by Martin Robinson.
- webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
- 12:42 AM Changeset in webkit [101048] by
-
- 12 edits3 copies3 moves in trunk
CSS Exclusions: update the name of the shape CSS properties
https://bugs.webkit.org/show_bug.cgi?id=71898
Instead of a single wrap-shape property, we have wrap-shape-inside and wrap-shape-outside.
Reviewed by Dean Jackson.
Source/WebCore:
Tests: fast/exclusions/parsing-wrap-shape-inside.html
fast/exclusions/parsing-wrap-shape-outside.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShape):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setWrapShapeInside):
(WebCore::InheritedFlags::wrapShapeInside):
(WebCore::InheritedFlags::setWrapShapeOutside):
(WebCore::InheritedFlags::wrapShapeOutside):
(WebCore::InheritedFlags::initialWrapShapeInside):
(WebCore::InheritedFlags::initialWrapShapeOutside):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- fast/exclusions/parsing-wrap-shape-inside-expected.txt: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
- fast/exclusions/parsing-wrap-shape-inside.html: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
- fast/exclusions/parsing-wrap-shape-outside-expected.txt: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
- fast/exclusions/parsing-wrap-shape-outside.html: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
- fast/exclusions/script-tests/parsing-wrap-shape-inside.js: Copied from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.
- fast/exclusions/script-tests/parsing-wrap-shape-outside.js: Renamed from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.
- 12:29 AM Changeset in webkit [101047] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Extensions API] avoid exception in initExtensions() if elements panel is not present
https://bugs.webkit.org/show_bug.cgi?id=73007
Reviewed by Yury Semikhatsky.
- inspector/front-end/ExtensionServer.js:
- 12:26 AM Changeset in webkit [101046] by
-
- 2 edits in trunk/Source/WebCore
Use new name for pixel config field of GrTextureDesc
https://bugs.webkit.org/show_bug.cgi?id=72543
Patch by Brian Salomon <bsalomon@google.com> on 2011-11-23
Reviewed by Stephen White.
Tested by every canvas2d layout test.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
- 12:21 AM Changeset in webkit [101045] by
-
- 7 edits in trunk/Source/WebCore
Change remaining scrollTop/Left/Width/Height methods back to int
https://bugs.webkit.org/show_bug.cgi?id=72771
Reviewed by Eric Seidel.
Change remaining scrollTop/Left/Width/Height, setScrollLeft/Top and
verticalScrollbarWidth, horizontalScrollbarHeight methods back to int as
scrolling will remain int based to line up with device pixels.
No new tests.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::scrollbarLogicalHeight):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):
- rendering/RenderListBox.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
- rendering/RenderTextControlSingleLine.h:
Nov 22, 2011:
- 11:12 PM Changeset in webkit [101044] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll DEPS to r111325 to fix an issue with the linux build
https://bugs.webkit.org/show_bug.cgi?id=73004
Unreviewed, build fix.
There appears to be a bug in the Makefile generator for gyp
that is causing make to not rebuild DRT on Linux.
- DEPS:
- 11:09 PM Changeset in webkit [101043] by
-
- 2 edits in trunk/LayoutTests
[Qt][GTK] editing/spelling/spellcheck-async.html fails
https://bugs.webkit.org/show_bug.cgi?id=73003
Unreviewed morning gardening.
- platform/qt/Skipped: Skip editing/spelling/spellcheck-async.html.
- 8:08 PM Changeset in webkit [101042] by
-
- 6 edits in trunk/Source/JavaScriptCore
Strength reduction for Mul and Mod operations for known constants in DFG
https://bugs.webkit.org/show_bug.cgi?id=72878
Reviewed by Filip Pizlo.
Also the code should be commonly shared by both 32_64 and 64.
- dfg/DFGNode.h:
(JSC::DFG::nodeMayOverflow):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::isPowerOfTwo):
(JSC::DFG::logTwo):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 7:30 PM Changeset in webkit [101041] by
-
- 7 edits2 adds in trunk/Source/JavaScriptCore
Add WTF infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72970
Reviewed by Antonio Gomes.
- wtf/Assertions.cpp: Added BlackBerry-specific logging directive.
- wtf/MathExtras.h:
(abs): Added; stdlib doesn't contain abs() on QNX.
- wtf/Platform.h: Define WTF_PLATFORM_BLACKBERRY and enable some platform features.
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator): For the BlackBerry port, we initialize
the bad pseudo random number generator using time(3) before initializing the
Mersenne Twister random number generator.
- wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal): Added.
- wtf/blackberry: Added.
- wtf/blackberry/MainThreadBlackBerry.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
- wtf/text/WTFString.h: Added constructor and conversion operator for
BlackBerry WebString string object.
- 7:16 PM Changeset in webkit [101040] by
-
- 2 edits3 copies in branches/chromium/912
Merge 100203
BUG=105143
Review URL: http://codereview.chromium.org/8673010
- 7:08 PM Changeset in webkit [101039] by
-
- 1 edit2 copies in branches/chromium/912
Merge 100677
BUG=100958
Review URL: http://codereview.chromium.org/8674006
- 6:58 PM Changeset in webkit [101038] by
-
- 1 edit2 deletes in trunk/Source/WebKit2
Unreviewed : remove empty folders related to TouchWebView and DesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=72985
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-11-22
- UIProcess/API/qt/tests/qmltests/DesktopWebView: Removed.
- UIProcess/API/qt/tests/qmltests/TouchWebView: Removed.
- 6:51 PM Changeset in webkit [101037] by
-
- 7 edits5 copies in branches/chromium/912
Merge 100630
BUG=101065
Review URL: http://codereview.chromium.org/8666016
- 6:15 PM Changeset in webkit [101036] by
-
- 2 edits in trunk
Add new WebKit/chromium/dbus directory to .gitignore.
- .gitignore:
- 6:01 PM Changeset in webkit [101035] by
-
- 19 edits in trunk/Source
[chromium] Support Core Animation plugins in compositor
https://bugs.webkit.org/show_bug.cgi?id=72921
Reviewed by Stephen White.
Source/WebCore:
Added support to PluginLayerChromium and CCPluginLayerImpl for
using an IOSurface as the backing store for a plugin. Added minimal
ARB_texture_rectangle support to Extensions3D.h and a Chromium-
specific extension for binding an IOSurface to a texture.
These changes themselves do not have any effect. A follow-on
Chromium CL will make the switch to this new code path.
Tested manually both with and without the Chromium side changes;
Chromium's DumpRenderTree port does not support Core Animation
plugins. Ran video and Stage3D in Flash, and Unity 3D content, to
verify.
- platform/graphics/Extensions3D.h:
- platform/graphics/chromium/Extensions3DChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::pluginLayerTexRectProgram):
(WebCore::LayerRendererChromium::pluginLayerTexRectProgramFlip):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::getIOSurfaceId):
(WebCore::PluginLayerChromium::pushPropertiesTo):
- platform/graphics/chromium/PluginLayerChromium.h:
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderRGBATexRectFlipAlpha::getShaderString):
(WebCore::FragmentShaderRGBATexRectAlpha::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(PluginProgramBinding::TexStretchPluginProgramBinding::set):
(PluginProgramBinding::TexTransformPluginProgramBinding::set):
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):
(WebCore::CCPluginLayerImpl::setIOSurfaceProperties):
(WebCore::CCPluginLayerImpl::cleanupResources):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
Source/WebKit/chromium:
Added IOSurface support to WebPluginContainer. This code path is
used only on Mac OS X, but is defined in the header on all
platforms for simplicity.
- public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):
- public/WebPluginContainer.h:
- src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
- src/GraphicsContext3DChromium.cpp:
- src/GraphicsContext3DPrivate.h:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- src/WebPluginContainerImpl.h:
- 5:58 PM Changeset in webkit [101034] by
-
- 1 edit2 copies in branches/chromium/912
Merge 100827
BUG=103921
Review URL: http://codereview.chromium.org/8666014
- 4:44 PM Changeset in webkit [101033] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Unreviewed. Fix ChangeLog typo in r101031.
- 4:44 PM Changeset in webkit [101032] by
-
- 2 edits in trunk/LayoutTests
Remove some flaky expectations added by me five months ago.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 4:39 PM Changeset in webkit [101031] by
-
- 11 edits in trunk/Source
[chromium] Fix plumbing for differentiating between clipboard/selection pastes.
https://bugs.webkit.org/show_bug.cgi?id=72056
Reviewed by tony@chromium.org.
Source/WebCore:
Add a buffer parameter when retrieving the clipboard sequence number and fix several call
sites that incorrectly assume use of the standard buffer in pastes.
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::platformClipboardChanged):
- platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::currentPasteboardBuffer):
- platform/chromium/ClipboardUtilitiesChromium.h:
- platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
- platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
Add a buffer parameter when retrieving the clipboard sequence number.
- public/WebClipboard.h:
(WebKit::WebClipboard::sequenceNumber):
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardSequenceNumber):
- 4:24 PM Changeset in webkit [101030] by
-
- 2 edits in trunk/LayoutTests
Make two accessibility tests as PASS TIMEOUT on Windows.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 4:12 PM Changeset in webkit [101029] by
-
- 2 edits in trunk/LayoutTests
One more video-zoom-controls rebaseline for Linux GPU.
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
- 3:09 PM Changeset in webkit [101028] by
-
- 6 edits4 copies4 moves83 adds2 deletes in trunk/LayoutTests
svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186
Unreviewed gardening.
Rebaseline these tests as they should be stable since r99937.
- platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
- platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Removed.
- platform/chromium-gpu-cg-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png.
- platform/chromium-gpu-cg-mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-gpu-cg-mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-linux-x86/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-linux-x86/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-linux-x86/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-linux/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-linux/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-linux/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-mac-leopard/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-win-vista/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-win-vista/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-win-vista/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
- platform/chromium-win-xp/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-win-xp/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-win-xp/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-win/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-win/svg/as-object/embedded-svg-size-changes-expected.png: Added.
- platform/chromium-win/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt.
- platform/chromium/test_expectations.txt:
- 2:42 PM Changeset in webkit [101027] by
-
- 10 edits2 deletes in trunk/LayoutTests
Layout Test media/video-zoom-controls.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67913
Rebaseline video-zoom-controls: it had already been
partially-rebaselined for WinXP, so the options were to remove those
baselines and let the test fail as expected, mark it as passing on
only XP, or rebaseline with what seem to be reasonable visual changes
(along with some extra noise in the render tree).
Unreviewed gardening.
- platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
- platform/chromium-linux/media/video-zoom-controls-expected.png:
- platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
- platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-win-xp/media/video-zoom-controls-expected.txt: Removed.
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- platform/chromium/media/video-zoom-controls-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:51 PM Changeset in webkit [101026] by
-
- 5 edits in trunk/LayoutTests
Rebaselines and expectation-removal for now-passing Mac tests.
Unreviewed gardening.
- platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
- platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
- platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:
- platform/chromium/test_expectations.txt:
- 1:41 PM Changeset in webkit [101025] by
-
- 10 edits5 adds in trunk
Pointer Lock: Initial Tests for navigator.webkitPonter
https://bugs.webkit.org/show_bug.cgi?id=72659
Reviewed by Darin Fisher.
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
Enabling PointerLock in TestShell
LayoutTests:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- pointer-lock/mouse-event-api-expected.txt:
- pointer-lock/mouse-event-api.html:
- pointer-lock/pointer-lock-api-expected.txt:
- pointer-lock/pointer-lock-api.html:
- 12:39 PM Changeset in webkit [101024] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove expectations for now-passing tests.
- platform/chromium/test_expectations.txt:
- 12:30 PM Changeset in webkit [101023] by
-
- 2 edits in trunk/LayoutTests
Expand slowness of dispatch-message-string-data.html to debug builds.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 12:28 PM Changeset in webkit [101022] by
-
- 2 edits in trunk
Ignore more gyp-generated build files in WTF.gyp.
- .gitignore:
- 11:45 AM Changeset in webkit [101021] by
-
- 6 edits2 adds in trunk/Source/WebKit/chromium
Empty API for web intents
https://bugs.webkit.org/show_bug.cgi?id=69870
Patch by Greg Billock <gbillock@google.com> on 2011-11-22
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebIntent.h: Added.
- public/WebIntentServiceInfo.h: Added.
- public/WebFrame.h:
- public/WebFrameClient.h:
- 11:39 AM Changeset in webkit [101020] by
-
- 2 edits1 move3 deletes in trunk/LayoutTests
More rebaselines from Skia roll.
Unreviewed gardening.
- platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt.
- 11:13 AM Changeset in webkit [101019] by
-
- 3 edits in trunk/Tools
Update flakiness dashboard for new Chromium builders and tests
https://bugs.webkit.org/show_bug.cgi?id=72931
Patch by Ryan Sleevi <rsleevi@chromium.org> on 2011-11-22
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/dashboard_base.js:
- 11:10 AM Changeset in webkit [101018] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=72972
Add dbus in Chromium as pulled dep and update to HEAD.
Patch by Scott Graham <scottmg@chromium.org> on 2011-11-22
Reviewed by Dirk Pranke.
- DEPS:
- 11:08 AM Changeset in webkit [101017] by
-
- 2 edits in trunk/LayoutTests
Expand MISSING expectation for form-associated-element-crash3.html.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 11:02 AM Changeset in webkit [101016] by
-
- 2 edits in trunk/LayoutTests
Mark file-writer-abort.html as flakily crashing on Mac Debug.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 10:55 AM Changeset in webkit [101015] by
-
- 2 edits7 deletes in trunk/LayoutTests
Mark some tests as passing after Skia roll in http://crrev.com/111151.
Unreviewed gardening.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 10:37 AM Changeset in webkit [101014] by
-
- 3 edits in trunk
Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966
Reviewed by Pavel Feldman.
- always bind to {add,remove}EventListener() of event target, not WebInspector.Object
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):
- 10:35 AM Changeset in webkit [101013] by
-
- 2 edits in trunk
Fix .dir-locals.el to only apply to specific modes
https://bugs.webkit.org/show_bug.cgi?id=72963
Patch by Andy Wingo <wingo@igalia.com> on 2011-11-22
Reviewed by Xan Lopez.
- .dir-locals.el: Remove `nil' block, as it was causing
makefile-mode not to insert tabs.
- 10:33 AM Changeset in webkit [101012] by
-
- 2 edits in trunk/Source/WebCore
Move splitView.css (added in r100991) to the correct target.
- WebCore.gypi:
- 10:30 AM Changeset in webkit [101011] by
-
- 3 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to r110960 and set the disable_nacl flag.
https://bugs.webkit.org/show_bug.cgi?id=72911
Unreviewed, build fix.
ppapi starts to depend on the NaCl gyp files as of r109739, so
we need to pass disable_nacl when running gyp to avoid pulling
in too much of NaCl.
- DEPS:
- gyp_webkit:
- 10:10 AM Changeset in webkit [101010] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 9:55 AM Changeset in webkit [101009] by
-
- 10 edits1 copy6 deletes in trunk/LayoutTests
Rebaselines after Skia roll (http://crrev.com/111151).
Unreviewed gardening.
- platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
- platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
- platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
- platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
- platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
- platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
- platform/chromium-win-xp/fast/css/shadow-multiple-expected.png:
- platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt.
- platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
- platform/chromium-win/fast/css/shadow-multiple-expected.png:
- platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:42 AM Changeset in webkit [101008] by
-
- 3 edits in trunk/Source/WebCore
CSSProperty: Remove unnecessary operator overloads.
<http://webkit.org/b/72953>
Patch by Andreas Kling <kling@webkit.org> on 2011-11-22
Reviewed by Antti Koivisto.
- css/CSSProperty.cpp:
- css/CSSProperty.h:
Remove operator= and operator== from CSSProperty. They were neither
implemented correctly nor used anywhere.
- 9:39 AM Changeset in webkit [101007] by
-
- 2 edits in trunk/Source/WebCore
CSSStyleDeclaration: Kill FIXME in setProperty().
<http://webkit.org/b/72958>
Patch by Andreas Kling <kling@webkit.org> on 2011-11-22
Reviewed by Antonio Gomes.
Remove FIXME about possibly throwing an exception when setProperty()
is called with an invalid property name. CSSOM specifies that the
method should simply return in this case.
Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
- 9:03 AM Changeset in webkit [101006] by
-
- 2 edits in trunk/Tools
Remove some debugging code I accidentally left in r101005
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_python):
- 8:52 AM Changeset in webkit [101005] by
-
- 2 edits in trunk/Tools
Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
classes/methods in Python source files
Reviewed by Dan Bates.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
or that use python as their interpreter. Modified the code that extracts the interpreter to
ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
scripts.
(get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
for class/def lines and generate ranges based on them.
- 8:43 AM Changeset in webkit [101004] by
-
- 2 edits in trunk/Source/WebKit2
Ensure web process before starting a download
https://bugs.webkit.org/show_bug.cgi?id=72499
Reviewed by Anders Carlsson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download): Call ensureWebProcess().
- 7:40 AM Changeset in webkit [101003] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r101001.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend): Use ASSERT_UNUSED instead of ASSERT.
- 7:39 AM Changeset in webkit [101002] by
-
- 5 edits2 adds in trunk
Source/WebCore: Spellcheck should be able to run asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=71991
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.
Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON.
When multiple asynchronous spellchecking are requested, only the first request will be processed.
Test: editing/spelling/spellcheck-async.html
- editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
Uses asynchronous spell checker if asynchronous flag is ON.
LayoutTests: Spellcheck should be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=71991
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.
Added asynchronouse spell checking tests.
Fixed tests that fails tearing down.
- editing/spelling/script-tests/spellcheck-paste.js: Fixed tearing down.
- editing/spelling/spellcheck-async-expected.txt: Added.
- editing/spelling/spellcheck-async.html: Added.
- editing/spelling/spelling-unified-emulation.html: Fixed tearing down.
- 7:18 AM Changeset in webkit [101001] by
-
- 2 edits in trunk/Source/WebKit2
cvel Feldman <pfeldman@google.com>
Not reviewed: moving inspector frontend creation out of assert in WebKit2.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp: (WebKit::WebInspectorClient::openInspectorFrontend):lean
- 6:43 AM Changeset in webkit [101000] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
https://bugs.webkit.org/show_bug.cgi?id=72951
Reviewed by Pavel Feldman.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
- 6:37 AM Changeset in webkit [100999] by
-
- 2 edits in trunk/Source/WebCore
2011-11-22 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix inspector front-end compilation.
- inspector/front-end/externs.js: (WebInspector.showPanel):
- 6:35 AM Changeset in webkit [100998] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [chromium] fix internactive ui test for scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=72935
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-22
Reviewed by Yury Semikhatsky.
- src/js/Tests.js:
(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):
- 6:26 AM Changeset in webkit [100997] by
-
- 10 edits2 copies in trunk/Source/WebCore
Add WebCore platform interface needed by updated MediaStream API design
https://bugs.webkit.org/show_bug.cgi?id=70895
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-11-22
Reviewed by Adam Barth.
This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.
Tests will be provided by http://webkit.org/b/56587
- GNUmakefile.list.am:
- WebCore.gypi:
- mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::stopTimerFired):
- mediastream/MediaStream.h:
- mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::setEnabled):
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::didRemoveRemoteStream):
- mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start):
- mediastream/UserMediaRequest.h:
- platform/mediastream/MediaStreamCenter.cpp: Added.
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenter::endLocalMediaStream):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):
- platform/mediastream/MediaStreamCenter.h: Added.
(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptorOwner::~MediaStreamDescriptorOwner):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):
- 6:14 AM Changeset in webkit [100996] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix and unskip loadHtml api test
https://bugs.webkit.org/show_bug.cgi?id=72916
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-22
Reviewed by Andreas Kling.
Now that linkHovered events are working again we can fix and unskip this
loadHtml test.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
- 6:11 AM Changeset in webkit [100995] by
-
- 35 edits in trunk/Source
Web Inspector: remove Inspector::bringToFront from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=72937
Source/WebCore:
Inspector::bringToFront protocol method is currently used on the backend
in order to reveal the front-end window. We should do that by means of
the inspector client interface instead.
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::show):
- loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::bringFrontendToFront):
Source/WebKit/chromium:
Reviewed by Yury Semikhatsky.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::bringFrontendToFront):
- src/InspectorClientImpl.h:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::bringFrontendToFront):
- src/WebDevToolsAgentImpl.h:
Source/WebKit/efl:
Reviewed by Yury Semikhatsky.
- WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::bringFrontendToFront):
- WebCoreSupport/InspectorClientEfl.h:
Source/WebKit/gtk:
Reviewed by Yury Semikhatsky.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::bringFrontendToFront):
- WebCoreSupport/InspectorClientGtk.h:
Source/WebKit/mac:
Reviewed by Yury Semikhatsky.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):
Source/WebKit/qt:
Reviewed by Yury Semikhatsky.
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::bringFrontendToFront):
- WebCoreSupport/InspectorClientQt.h:
Source/WebKit/win:
Reviewed by Yury Semikhatsky.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::bringFrontendToFront):
- WebCoreSupport/WebInspectorClient.h:
Source/WebKit/wince:
Reviewed by Yury Semikhatsky.
- WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::bringFrontendToFront):
- WebCoreSupport/InspectorClientWinCE.h:
Source/WebKit/wx:
Reviewed by Yury Semikhatsky.
- WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::bringFrontendToFront):
- WebKitSupport/InspectorClientWx.h:
Source/WebKit2:
Reviewed by Yury Semikhatsky.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- 5:40 AM Changeset in webkit [100994] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
https://bugs.webkit.org/show_bug.cgi?id=72899
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):
- inspector/front-end/externs.js:
- 5:38 AM Changeset in webkit [100993] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Build fix for MHTML support
- Target.pri: Add missing includepath.
- 5:38 AM Changeset in webkit [100992] by
-
- 9 edits2 adds in trunk/Source/WebKit2
[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient
https://bugs.webkit.org/show_bug.cgi?id=72928
Reviewed by Andreas Kling.
Split PageLoadClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageLoadClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::loadProgress):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/qt/ClientImpl.cpp:
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/QtWebPageLoadClient.cpp: Added.
(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame):
(QtWebPageLoadClient::dispatchLoadSucceeded):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::setLoadProgress):
(toQtWebPageLoadClient):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFinishLoadForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(QtWebPageLoadClient::didStartProgress):
(QtWebPageLoadClient::didChangeProgress):
(QtWebPageLoadClient::didFinishProgress):
- UIProcess/qt/QtWebPageLoadClient.h: Added.
(QtWebPageLoadClient::loadProgress):
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::updateNavigationState):
- UIProcess/qt/QtWebPageProxy.h:
- 5:24 AM Changeset in webkit [100991] by
-
- 27 edits2 adds in trunk
Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
https://bugs.webkit.org/show_bug.cgi?id=72920
Reviewed by Pavel Feldman.
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/ApplicationCacheModel.js:
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.sidebarResized):
(WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.wasShown):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.createSplitView):
(WebInspector.Panel.prototype.createSplitViewWithSidebarTree):
(WebInspector.Panel.prototype.sidebarResized):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.sidebarResized):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.sidebarResized):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.sidebarResized):
- inspector/front-end/SplitView.js: Added.
(WebInspector.SplitView):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refreshRecords):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/auditsPanel.css:
- inspector/front-end/elementsPanel.css:
- inspector/front-end/inspector.css:
(.sidebar):
- inspector/front-end/inspector.html:
- inspector/front-end/networkLogView.css:
- inspector/front-end/networkPanel.css:
(#network-views):
- inspector/front-end/profilesPanel.css:
(#profile-views):
- inspector/front-end/resourcesPanel.css:
- inspector/front-end/scriptsPanel.css:
(#scripts-split-view):
- inspector/front-end/splitView.css: Added.
- inspector/front-end/timelinePanel.css:
(.timeline .sidebar):
(.timeline-sidebar-background):
(#resources-container-content):
LayoutTests:
- http/tests/inspector/network/network-sidebar-width.html:
- 5:21 AM Changeset in webkit [100990] by
-
- 9 edits2 adds in trunk/Source/WebKit2
[Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=72910
Reviewed by Andreas Kling.
Split PageUIClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageUIClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/qt/ClientImpl.cpp:
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
- UIProcess/qt/QtWebPageProxy.h:
- UIProcess/qt/QtWebPageUIClient.cpp: Added.
(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::runJavaScriptAlert):
(QtWebPageUIClient::runJavaScriptConfirm):
(QtWebPageUIClient::runJavaScriptPrompt):
(QtWebPageUIClient::runOpenPanel):
(QtWebPageUIClient::setStatusText):
(QtWebPageUIClient::mouseDidMoveOverElement):
(toQtWebPageUIClient):
(createNullWKString):
- UIProcess/qt/QtWebPageUIClient.h: Added.
- 4:58 AM Changeset in webkit [100989] by
-
- 20 edits in trunk/Source
Unreviewed, rolling out r100988.
http://trac.webkit.org/changeset/100988
https://bugs.webkit.org/show_bug.cgi?id=72941
"Broke pixel tests on Chromium-Linux" (Requested by kbalazs on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-22
Source/JavaScriptCore:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/ParallelJobs.h:
- wtf/ParallelJobsGeneric.cpp:
- wtf/ParallelJobsGeneric.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
- wtf/Platform.h:
Source/WebCore:
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApply):
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/arm/FELightingNEON.cpp:
- platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
- 3:42 AM Changeset in webkit [100988] by
-
- 20 edits in trunk/Source
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032
Reviewed by Zoltan Herczeg.
Source/JavaScriptCore:
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.
- JavaScriptCore.gypi: Add the files to the build. It was
missing for the gyp build system.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
- wtf/ParallelJobs.h:
- wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
- wtf/ParallelJobsGeneric.h:
- wtf/Platform.h:
Source/WebCore:
Covered by existing tests.
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::FELighting::platformApplyNeonWorker):
- platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
- 3:14 AM Changeset in webkit [100987] by
-
- 9 edits in trunk
Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
https://bugs.webkit.org/show_bug.cgi?id=72733
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::buildArrayForComputedStyle):
- inspector/InspectorStyleSheet.h:
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
LayoutTests:
- inspector/styles/styles-new-API.html:
- 1:57 AM Changeset in webkit [100986] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r100979.
- platform/gtk/accessibility/name-from-label-expected.txt:
- 1:52 AM Changeset in webkit [100985] by
-
- 20 edits in trunk/Source
Web Inspector: strip unused InspectorController methods.
https://bugs.webkit.org/show_bug.cgi?id=72886
Source/WebCore:
This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009.
I am now able to remove following InspectorController methods:
::startUserInitiatedProfiling,
::isRecordingUserInitiatedProfile,
::stopUserInitiatedProfiling,
::showAndEnableDebugger,
::debuggerEnabled,
::disableDebugger,
::startTimelineProfiler,
::stopTimelineProfiler,
::timelineProfilerEnabled,
::showConsole.
Reviewed by Yury Semikhatsky.
- WebCore.exp.in:
- WebCore.order:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
- inspector/InspectorController.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
- inspector/InspectorTimelineAgent.h:
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
- inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype.start):
(WebInspector.TimelineManager.prototype.stop):
(WebInspector.TimelineManager.prototype._started):
(WebInspector.TimelineManager.prototype._stopped):
- inspector/front-end/inspector.js:
Source/WebKit/gtk:
Reviewed by Yury Semikhatsky.
- webkit/webkitwebinspector.cpp:
(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):
- 1:34 AM Changeset in webkit [100984] by
-
- 16 edits1 delete in trunk/Source
[chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result
https://bugs.webkit.org/show_bug.cgi?id=72688
Source/WebCore:
This allows CCInputFilter and CCLayerTreeHostImpl to
perform requestAnimationFrame-style animations. The bulk of
work here is to make the scheduler recover gracefully when you
call setNeedsRedraw inside scheduledActionDraw.
Reviewed by James Robinson.
- WebCore.gypi:
- platform/graphics/chromium/cc/CCInputHandler.h:
(WebCore::CCInputHandlerTarget::CCInputHandlerTarget):
(WebCore::CCInputHandlerTarget::~CCInputHandlerTarget):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrame):
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setInsideVSync):
(WebCore::CCSchedulerStateMachine::setOutsideVSync):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
- platform/graphics/chromium/cc/CCScrollController.h: Removed.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
Source/WebKit/chromium:
Reviewed by James Robinson.
- src/WebCompositorImpl.cpp:
(WebCore::CCInputHandler::create):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::willDraw):
- src/WebCompositorImpl.h:
(WebKit::WebCompositorImpl::create):
- tests/CCFrameRateControllerTest.cpp:
(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
- tests/CCSchedulerTest.cpp:
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::setScheduler):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::numDraws):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::hasMoreResourceUpdates):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionBeginFrame):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwap):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionUpdateMoreResources):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionCommit):
(WebKitTests::TEST):
- 1:32 AM Changeset in webkit [100983] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName().
https://bugs.webkit.org/show_bug.cgi?id=72850
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-22
Reviewed by Anders Carlsson.
The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and
windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory.
- Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebKeyboardEvent):
- 1:19 AM Changeset in webkit [100982] by
-
- 1 edit10 adds in trunk/LayoutTests
Unreviewed gardening. Reset test results.
Patch by Feher Zsolt <feherzs@inf.u-szeged.hu> on 2011-11-22
- platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
- platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
- platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
- platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
- platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
- platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
- 1:18 AM Changeset in webkit [100981] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Design of the autocomplete suggest
https://bugs.webkit.org/show_bug.cgi?id=72798
Reviewed by Pavel Feldman.
Implemented a combination of grayed text for the first/only completion and hid
the suggest box for a single suggestion (the grayed text is displayed instead.)
Drive-by fix for the "trailing spaces in the prompt" issue
(got regressed when the suggest box was introduced for the first time.)
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView): Fix the "trailing spaces" issue
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.renderAsBlock): Fix the "trailing spaces" issue
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
- 12:50 AM Changeset in webkit [100980] by
-
- 2 edits in trunk/LayoutTests
[Qt] inspector/extensions/extensions-events.html crashing after r100926
https://bugs.webkit.org/show_bug.cgi?id=72932
Unreviewed gardening.
- platform/qt/Skipped:
- 12:30 AM Changeset in webkit [100979] by
-
- 3 edits in trunk/LayoutTests
[GTK] platform/gtk/accessibility/name-from-label.html fails
https://bugs.webkit.org/show_bug.cgi?id=71665
Reviewed by Philippe Normand.
Fix layout test to properly consider 'form' accessibility objects.
- platform/gtk/Skipped: Unskip name-from-label.html.
- platform/gtk/accessibility/name-from-label.html: Re-write layout test to properly take into account the accessibility hierarchy.