Timeline


and

11/28/11:

23:59 Changeset [101335] by dgrogan@chromium.org
  • 7 edits
    2 adds in trunk/Source

WebWorkerRunLoop wrapper around WorkerRunLoop
https://bugs.webkit.org/show_bug.cgi?id=71757

Source/WebCore:

Reviewed by Darin Fisher.

No new tests - IndexedDB tests forthcoming.

  • platform/chromium/PlatformSupport.h: Add two methods that allow

WebCore to notify chromium when workers start and stop.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread): Call into PlatformSupport when
the worker's runloop is started and stopped.

Source/WebKit/chromium:

This allows the embedder to post tasks to webcore-created worker
threads. WebWorkerRunLoop is a thin wrapper that just holds a
WorkerRunLoop*. As such, it is not heap allocated and can be copied.

Reviewed by Darin Fisher.

  • WebKit.gyp: Added WebWorkerRunLoop.{cpp,h}
  • public/WebWorkerRunLoop.h: Added. Interface the embedder will use to

post Tasks to worker threads created in WebCore.
(WebKit::WebWorkerRunLoop::Task::~Task):
(WebKit::operator==): These are the operators necessary to allow
WebWorkerRunLoop to be used as a key in a std::map using the value of
the underlying WebCore::WorkerRunLoop* for the meaningful comparisons.
(WebKit::operator<):

  • public/platform/WebKitPlatformSupport.h: Stubs for the embedder to

implement.
(WebKit::WebKitPlatformSupport::didStartWorkerRunLoop):
(WebKit::WebKitPlatformSupport::didStopWorkerRunLoop):

  • src/PlatformSupport.cpp: Wrap incoming WorkerRunLoop objects in

WebWorkerRunLoopImpl objects, forward them to WebKitPlatformSupport.
(WebCore::PlatformSupport::didStartWorkerRunLoop):
(WebCore::PlatformSupport::didStopWorkerRunLoop):

  • src/WebWorkerRunLoop.cpp: Added.

(WebKit::WebWorkerRunLoop::WebWorkerRunLoop): Store incoming
WorkerRunLoop pointer.
(WebKit::WebWorkerRunLoop::postTask): Wrap incoming Task in
ScriptExecutionContext::Task, post to stored WorkerRunLoop.
(WebKit::WebWorkerRunLoop::equals): Support for the operators mentioned
above.
(WebKit::WebWorkerRunLoop::lessThan): Ditto.

23:57 Changeset [101334] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG debugCall() mechanism only works on X86 and X86-64
https://bugs.webkit.org/show_bug.cgi?id=73282

Reviewed by Oliver Hunt.

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::debugCall):

23:55 Changeset [101333] by achicu@adobe.com
  • 3 edits
    6 adds in trunk

[CSS Filters] Filters do not render correctly when the layer has a transform
https://bugs.webkit.org/show_bug.cgi?id=73077

Reviewed by Dean Jackson.

Source/WebCore:

Corrected the root layer that was used when no transform was applied.
Using PaintLayerAppliedTransform when calling paintLayer again, to avoid
applying the transform inside the filter's graphics context. Now we apply that
on the result image.

Tests: css3/filters/filter-with-transform.html

css3/filters/nested-filter.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

LayoutTests:

  • css3/filters/filter-with-transform-expected.png: Added.
  • css3/filters/filter-with-transform-expected.txt: Added.
  • css3/filters/filter-with-transform.html: Added.
  • css3/filters/nested-filter-expected.png: Added.
  • css3/filters/nested-filter-expected.txt: Added.
  • css3/filters/nested-filter.html: Added.
23:44 Changeset [101332] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-X86 ArithDiv does speculation failure after mutating state,
without a value recovery
https://bugs.webkit.org/show_bug.cgi?id=73286

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

23:39 Changeset [101331] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/WebCore

[blackberry] Upstream BlackBerry porting of plugin framework
https://bugs.webkit.org/show_bug.cgi?id=73185

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-11-28
Reviewed by Daniel Bates.

No new tests for now.

  • plugins/blackberry: Added.
  • plugins/blackberry/PluginDataBlackBerry.cpp: Added.
  • plugins/blackberry/PluginPackageBlackBerry.cpp: Added.
23:36 Changeset [101330] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Unreviewed buildfix after r101307.

  • qmake/mkspecs/features/webkit2.prf: Add missing includepath.
22:36 Changeset [101329] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove V8MessagePortCustom.h from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=73281

Reviewed by David Levin.

V8MessagePortCustom.h was removed in r101118

  • WebCore.gypi: remove bindings\v8\custom\V8MessagePortCustom.h
22:33 Changeset [101328] by leo.yang@torchmobile.com.cn
  • 1 edit
    3 adds in trunk/Source/WebCore

Upstream the BlackBerry porting of SocketStream
https://bugs.webkit.org/show_bug.cgi?id=73283

Reviewed by Daniel Bates.

Other main contributors:
Joe Mason <jmason@rim.com>
Lyon Chen <liachen@rim.com>

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/SocketStreamError.h: Added.

(WebCore::SocketStreamError::SocketStreamError):

  • platform/network/blackberry/SocketStreamHandle.h: Added.

(WebCore::SocketStreamHandle::create):

  • platform/network/blackberry/SocketStreamHandleBlackBerry.cpp: Added.

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge):
(WebCore::SocketStreamHandle::receivedCredential):
(WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
(WebCore::SocketStreamHandle::receivedCancellation):
(WebCore::SocketStreamHandle::notifyStatusReceived):
(WebCore::SocketStreamHandle::notifyDataReceived):
(WebCore::SocketStreamHandle::notifyReadyToSendData):
(WebCore::SocketStreamHandle::notifyClose):

22:25 Changeset [101327] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Size of ResourceRequestBase could be reduced by using bitfields.
https://bugs.webkit.org/show_bug.cgi?id=73271

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2011-11-28
Reviewed by Alexey Proskuryakov.

Add bitfield for bool members in ResourceRequestBase to reduce its memory size.

  • platform/network/ResourceRequestBase.h:
22:21 Changeset [101326] by yutak@chromium.org
  • 3 edits
    3 adds in trunk

WebSocket: Split Hixie76 length-prefixed frames aren't handled correctly
https://bugs.webkit.org/show_bug.cgi?id=68522

Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hixie76/split-binary-frame-header.html

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrameHixie76):
Do not consume the data if the length field is not finished.

LayoutTests:

  • http/tests/websocket/tests/hixie76/split-binary-frame-header-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/split-binary-frame-header.html: Added.
  • http/tests/websocket/tests/hixie76/split-binary-frame-header_wsh.py:

Added. Send WebSocket frames that older WebSocketChannel implementation fails to parse.
The client should not receive an empty text message.

21:14 Changeset [101325] by senorblanco@chromium.org
  • 7 edits
    1 add in trunk

[chromium] Fix SVG filters when running in accelerated drawing mode.
https://bugs.webkit.org/show_bug.cgi?id=73249

Reviewed by Kenneth Russell.

Source/WebCore:

Test: platform/chromium/compositing/accelerated-drawing/svg-filters.html

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
When doing accelerated drawing, mark the PlatformContextSkia as
deferred.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::drawNeedsCopy):
When doing a cross-context draw, if the destination context is
deferred, copy the image. Also refactor conditions under which the
image is copied into a new function.
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
Use the refactored function for conditional copies.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::isDeferred):
(WebCore::PlatformContextSkia::setDeferred):
Add m_isDeferred flag, initializer and accessors.

LayoutTests:

  • platform/chromium/compositing/accelerated-drawing/svg-filters.html: Added.

New test to check SVG filters in accelerated drawing.

  • platform/chromium/test_expectations.txt:

Suppress test failures for new test until we get baselines.

20:59 Changeset [101324] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fixes for ARM.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::readCallTarget):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):

20:51 Changeset [101323] by rolandsteiner@chromium.org
  • 18 edits in trunk

<style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
https://bugs.webkit.org/show_bug.cgi?id=72848

.:

Add flag and description.

Reviewed by Dimitri Glazkov.

  • configure.ac:

Source/JavaScriptCore:

Add ENABLE_STYLE_SCOPED flag.

Reviewed by Dimitri Glazkov.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Dimitri Glazkov.

No new tests. (no code)

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/chromium:

Reviewed by Dimitri Glazkov.

  • features.gypi:

Source/WebKit/mac:

Reviewed by Dimitri Glazkov.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Dimitri Glazkov.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Add option to build-webkit.

Reviewed by Dimitri Glazkov.

  • Scripts/build-webkit:

WebKitLibraries:

Reviewed by Dimitri Glazkov.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
20:34 Changeset [101322] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Disable compositing for RTL pages even in forceCompositingMode
https://bugs.webkit.org/show_bug.cgi?id=73195

Reviewed by James Robinson.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

20:06 Changeset [101321] by rolandsteiner@chromium.org
  • 3 edits
    2 adds in trunk

From @keyframes rules with the same name, the last rule should be used
https://bugs.webkit.org/show_bug.cgi?id=73113

Source/WebCore:

Have later rules override previously stored rules.

Reviewed by Simon Fraser.

Test: animations/duplicated-keyframes-name.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addKeyframeStyle):

LayoutTests:

Verify that the last @keyframe rule is used.

Reviewed by Simon Fraser.

  • animations/duplicated-keyframes-name-expected.txt: Added.
  • animations/duplicated-keyframes-name.html: Added.
19:48 Changeset [101320] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

js-test-pre: don't try to load stylesheet from a web worker
https://bugs.webkit.org/show_bug.cgi?id=73269

Reviewed by Ojan Vafai.

  • fast/js/resources/js-test-pre.js:
19:39 Changeset [101319] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebCore

Upstream BlackBerry porting of page.
https://bugs.webkit.org/show_bug.cgi?id=73143

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-11-28
Reviewed by Daniel Bates.

Upstream BlackBerry porting of WebCore/page.
Define DragImageRef for BlackBerry platform.

Initial upstream, can't be built yet, no test cases.

  • page/blackberry/DragControllerBlackBerry.cpp: Added.

(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::maxDragImageSize):
(WebCore::DragController::cleanupAfterSystemDrag):
(WebCore::DragController::dragOperation):

  • page/blackberry/EventHandlerBlackBerry.cpp: Added.

(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::tabsToAllFormControls):
(WebCore::EventHandler::accessKeyModifiers):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::createDraggingClipboard):

  • page/blackberry/FrameBlackBerry.cpp: Added.

(WebCore::Frame::dragImageForSelection):

  • platform/DragImage.h:
19:33 Changeset [101318] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk/Source

[chromium] Create CCDamageTracker class to determine regions of change for a surface.
https://bugs.webkit.org/show_bug.cgi?id=72520

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-28
Reviewed by James Robinson.

Source/WebCore:

Added CCDamageTrackerTest and updated other tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp: Added.

(WebCore::CCDamageTracker::create):
(WebCore::CCDamageTracker::CCDamageTracker):
(WebCore::CCDamageTracker::~CCDamageTracker):
(WebCore::CCDamageTracker::updateDamageRectForNextFrame):
(WebCore::CCDamageTracker::removeRectFromCurrentFrame):
(WebCore::CCDamageTracker::saveRectForNextFrame):
(WebCore::CCDamageTracker::computeDamageFromActiveLayers):
(WebCore::CCDamageTracker::computeDamageFromSurfaceMask):
(WebCore::CCDamageTracker::computeDamageFromLeftoverRects):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCDamageTracker.h: Added.

(WebCore::CCDamageTracker::currentDamageRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::renderSurfaceContributesToTarget):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::dumpSurface):
(WebCore::CCRenderSurface::surfacePropertyChangedOnlyFromDescendant):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::damageTracker):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCDamageTrackerTest.cpp: Added.

(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::createAndSetUpTestTreeWithOneSurface):
(WebKitTests::createAndSetUpTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeTestCommon.h: Added.
  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):

  • tests/LayerChromiumTest.cpp:
19:24 Changeset [101317] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSSPropertySize in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73000

Reviewed by Andreas Kling.

This refactoring moves the implementation of the page size calculation into CSSStyleApplyProperty
and removes the existing code from CSSStyleSelector.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::pageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyPageSize::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
19:01 Changeset [101316] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Possible fix for test failures in r101307.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

18:34 Changeset [101315] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Add support for knowing when a TreeElement is added or changed anywhere in a TreeOutline.

Reviewed by Brian Weinstein.

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype.appendChild): Call onadd if it exists.
(TreeOutline.prototype.insertChild): Ditto.
(TreeOutline.prototype._treeElementDidChange): Added. Call onchange if it exists.
(TreeElement.prototype.set title): Call didChange.
(TreeElement.prototype.set titleHTML): Ditto.
(TreeElement.prototype.set tooltip): Ditto.
(TreeElement.prototype.set hasChildren): Ditto.
(TreeElement.prototype._fireDidChange): Added. Call TreeOutline._treeElementDidChange.
(TreeElement.prototype.didChange): Added. Schedule a timeout for _fireDidChange.
(TreeElement.prototype.expand): Move the code that sets the expanded flag to the beginning
which is before onpopulate. Since onpopulate can add elements and call onadd, this makes
sure the expanded flag is true before calling those functions.

18:34 Changeset [101314] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Skip selecting TreeElements that are hidden when keyboard navigating.

We already skipped non-selectable tree elements in the common cases, this just makes selectable
take the hidden flag into account.

Reviewed by Brian Weinstein.

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyDown): Skip non-selectable elements when pressing Left or Right,
similar to what we already do when pressing Up and Down.
(TreeElement): Set _selectable to true.
(TreeElement.prototype.get selectable): Added. Return false when hidden.
(TreeElement.prototype.set selectable): Added. Set _selectable.
(TreeElement.prototype.traverseNextTreeElement): Renamed skipHidden to skipUnrevealed to prevent confusion with
the hidden property of TreeElement.
(TreeElement.prototype.traversePreviousTreeElement): Ditto.

18:34 Changeset [101313] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Use classList instead of addStyleClass and removeStyleClass in TreeOutline.

https://webkit.org/b/72803

Reviewed by Dan Bernstein.

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype.appendChild):
(TreeOutline.prototype.insertChild):
(TreeElement.prototype.set hasChildren):
(TreeElement.prototype.set hidden):
(TreeElement.prototype._attach):
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):
(TreeElement.prototype.select):
(TreeElement.prototype.deselect):

18:17 Changeset [101312] by leo.yang@torchmobile.com.cn
  • 1 edit
    2 adds in trunk/Source/WebCore

Upstream platform/network/blackberry/AuthenticationChallenge.h
https://bugs.webkit.org/show_bug.cgi?id=73196

Reviewed by Daniel Bates.

This is the BlackBerry implementation of WebCore::AuthenticationChallenge.
Contributed by Torch Team.

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/AuthenticationChallenge.h: Added.

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::setStored):
(WebCore::AuthenticationChallenge::isStored):

17:38 Changeset [101311] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Synchronization problem in Canvas/WebGLRenderingContext when listener asks for image
https://bugs.webkit.org/show_bug.cgi?id=73228

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-28
Reviewed by Kenneth Russell.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::markContextChanged):

17:31 Changeset [101310] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[MutationObservers] Fix build breakage after CSSInlineDeclaration refactor
https://bugs.webkit.org/show_bug.cgi?id=73243

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-28
Reviewed by Ryosuke Niwa.

No tests needed. This patch only contains compile fixes.

  • css/CSSMutableStyleDeclaration.cpp:
17:25 Changeset [101309] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Chromium bot build error related to b73253.

  • WebCore.gypi: Added missing references to NotificationController.
17:11 Changeset [101308] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Suppressing a failing webgl conformance test on Mac.
https://bugs.webkit.org/show_bug.cgi?id=73148

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-28
Reviewed by Kenneth Russell.

  • platform/mac/Skipped:
17:08 Changeset [101307] by jonlee@apple.com
  • 59 edits
    21 adds in trunk/Source

Create skeleton framework for notifications support in WK2
https://bugs.webkit.org/show_bug.cgi?id=73253
<rdar://problem/10356943>

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.

Source/WebCore:

Reviewed by Sam Weinig.

Some refactoring was done to make notifications follow a similar pattern to our other clients, like
geolocation and context menu.

  • Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
  • WebCore.xcodeproj/project.pbxproj: Adding new NotificationController class, and exposing

Notification and NotificationController as private headers.

  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • notifications/NotificationContents.h: Converted class to struct. Members need to be accessible

in order to do WK2 argument encoding.
(WebCore::NotificationContents::NotificationContents):

  • notifications/Notification.cpp: Update style of entire file.

(WebCore::Notification::Notification): Added default constructor (for WK2), and minor refactoring
with NotificationContents.

  • notifications/Notification.h: Added set methods for WK2 serialization. Also, update indenting.

(WebCore::Notification::setHTML): Added.
(WebCore::Notification::setURL): Added.
(WebCore::Notification::contents): Added const version for WK2.

  • notifications/NotificationCenter.h: Update style.
  • notifications/NotificationController.cpp: Added.

(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::~NotificationController):

  • notifications/NotificationController.h: Added.

(WebCore::NotificationController::client):

  • notifications/NotificationPresenter.h: This acts like a client, and should probably be renamed as such.

Removed ifdef for exposure to WK2.
(WebCore::NotificationPresenter::~NotificationPresenter): Moved as protected instead of public.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications): We move the request for the notification client from the chrome
to the controller.

  • page/Page.cpp:

(WebCore::Page::Page): The page now owns a notification controller.
(WebCore::Page::PageClients::PageClients): Add notification client as a page client.

  • page/Page.h:

(WebCore::Page::notificationController): Retrieve the notification controller.

  • page/ChromeClient.h: We move the request for the notification client from the chrome to the controller.

Remove notificationPresenter().

  • page/Chrome.cpp: Remove notificationPresenter().
  • page/Chrome.h: Remove notificationPresenter().
  • loader/EmptyClients.h: Remove notificationPresenter().

Source/WebKit:

Reviewed by Sam Weinig.

  • WebKit.xcodeproj/project.pbxproj: Add WebNotificationClient class.

Source/WebKit/chromium:

Reviewed by Sam Weinig.

Remove notificationPresenter() from the chrome client, since it is now managed by
the notification controller.

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
  • src/WebNotification.cpp:

(WebKit::WebNotification::title): Refactoring with NotificationContents conversion to struct.
(WebKit::WebNotification::body): Ditto.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Set notification client in web view's page clients.

Source/WebKit/mac:

Reviewed by Sam Weinig.

  • Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
  • WebCoreSupport/WebNotificationClient.h: Added.

(WebNotificationClient::webView):

  • WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now.

(WebNotificationClient::WebNotificationClient):
(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::cancelRequestsForPermission):
(WebNotificationClient::checkPermission):

  • WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class.

Source/WebKit/qt:

Reviewed by Sam Weinig.

  • Api/qwebpage.cpp: Add notification client to pageClients.

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.cpp: Remove notification client from ChromeClient implementation.
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: Refactor with change of NotificationContents to struct

(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

Source/WebKit2:

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj: Added classes for notification support.
  • win/WebKit2.vcproj: Ditto.
  • Target.pri: Ditto.
  • Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
  • DerivedSources.make: Add Notifications to VPATH.
  • Platform/CoreIPC/MessageID.h: List WebNotificationManagerProxy as a class with messages.
  • Scripts/webkit2/messages.py: Mark WebCore::NotificationContents as a struct.
  • Shared/API/c/WKBase.h: Map opaque types to NotificationProvider, NotificationManager, and Notification.
  • UIProcess/API/C/WKAPICast.h: Map WK types toNotificationProvider, NotificationManager, and Notification.
  • Shared/APIObject.h: Add Notification and NotificationManager as APIObjects.
  • Shared/WebCoreArgumentCoders.cpp: Added coders for KURL.

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/WebNotification.cpp: Added.

(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::~WebNotification):
(WebKit::WebNotification::encode):
(WebKit::WebNotification::decode):

  • UIProcess/WebNotification.h: Added.

(WebKit::WebNotification::create):
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):
(WebKit::WebNotification::type):

  • UIProcess/API/C/WKNotification.cpp: Added as API.

(WKNotificationGetTypeID):
(WKNotificationCopyTitle):
(WKNotificationCopyBody):

  • UIProcess/API/C/WKNotification.h: Added as API.
  • WebProcess/Notifications/WebNotificationManager.h: Added. Contains for now show() and cancel().

The rest of the notification client methods will be added later. These two functions send messages
to the manager proxy.

  • WebProcess/Notifications/WebNotificationManager.cpp: Added.

(WebKit::WebNotificationManager::WebNotificationManager):
(WebKit::WebNotificationManager::~WebNotificationManager):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):

  • UIProcess/WebNotificationManagerProxy.cpp: Added.

(WebKit::WebNotificationManagerProxy::create):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::~WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::invalidate):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):

  • UIProcess/WebNotificationManagerProxy.h: Added.

(WebKit::WebNotificationManagerProxy::clearContext):
(WebKit::WebNotificationManagerProxy::type):

  • UIProcess/WebNotificationManagerProxy.messages.in: Added.
  • UIProcess/API/C/WKNotificationManager.cpp: Added.

(WKNotificationManagerGetTypeID):
(WKNotificationManagerSetProvider):

  • UIProcess/API/C/WKNotificationManager.h: Added.
  • UIProcess/WebContext.h: Add the notification manager to the web context.

(WebKit::WebContext::notificationManagerProxy): Access the manager.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Boilerplate for managers.
(WebKit::WebContext::~WebContext): Boilerplate for managers.
(WebKit::WebContext::disconnectProcess): Boilerplate for managers.
(WebKit::WebContext::didReceiveMessage): Forward messages to the notification manager.

  • UIProcess/API/C/WKContext.cpp: Expose as API.

(WKContextGetNotificationManager):

  • UIProcess/API/C/WKContext.h: Expose as API.
  • UIProcess/API/C/WKNotificationProvider.h: Added.
  • UIProcess/WebNotificationProvider.h: Added as APIClient.
  • UIProcess/WebNotificationProvider.cpp: Added.

(WebKit::WebNotificationProvider::show): Forward call to the client.
(WebKit::WebNotificationProvider::cancel): Forward call to the client.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Forward messages for notification manager to the context.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Remove notificationPresenter().
  • WebProcess/WebCoreSupport/WebChromeClient.h: Remove notificationPresenter().
  • WebProcess/WebCoreSupport/WebNotificationClient.h: Added. Forwards client methods to manager.
  • WebProcess/WebCoreSupport/WebNotificationClient.cpp: Added. Mostly stub implementation for now.

(WebKit::WebNotificationClient::WebNotificationClient):
(WebKit::WebNotificationClient::~WebNotificationClient):
(WebKit::WebNotificationClient::show):
(WebKit::WebNotificationClient::cancel):
(WebKit::WebNotificationClient::notificationObjectDestroyed):
(WebKit::WebNotificationClient::requestPermission):
(WebKit::WebNotificationClient::cancelRequestsForPermission):
(WebKit::WebNotificationClient::checkPermission):

  • WebProcess/WebPage/WebPage.h: Added WebNotificationClient as one of its page clients.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set the notification client to WebNotificationClient.

  • WebProcess/WebProcess.h: Added WebNotificationManager.

(WebKit::WebProcess::notificationManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Initialize notificaton manager.

17:00 Changeset [101306] by bdakin@apple.com
  • 3 edits in trunk/Source/WebKit/chromium

Speculative Chromium build fix.

  • src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::scrollbarStyleChanged):

  • src/ScrollbarGroup.h:
16:52 Changeset [101305] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

16:48 Changeset [101304] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix gyp build

16:38 Changeset [101303] by ojan@chromium.org
  • 3 edits in trunk/Tools

gtest normalization in the test results server is sometimes wrong
https://bugs.webkit.org/show_bug.cgi?id=73262

Reviewed by Tony Chang.

If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
entries in the incremental JSON, one of the entries will have the correct data
from the run and the other will have dummy no-data values. Make sure to
always pick the one with real data.

  • TestResultServer/model/jsonresults.py:

(JsonResults._remove_gtest_modifiers):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_remove_gtest_modifiers):

16:22 Changeset [101302] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

ImageDecoder setSize() should check for backing store allocation failure
https://bugs.webkit.org/show_bug.cgi?id=72864

Reviewed by Adam Barth.

The backing store of a decoded image is a Vector<PixelData> on the affected
ports. And Vector<> provides a resize capacity member that returns false if
memory allocation fails.

setSize() should be called once only during an image decode - add an ASSERT
for that. Resize the backing store capacity to the requested image size and
return false if memory allocation fails.

ImageDecoder::isOverSize(width, height) is called to check that the decoded
width and height won't overflow 'width x height x sizeof(PixelData)' before
calls to setSize(). Refer to http://webkit.org/b/48634

No new tests. Covered by fast/images/size-failure.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

16:21 Changeset [101301] by oliver@apple.com
  • 11 edits in trunk/Source/WebCore

Fix V8 bindings codegen and add yet more tests for the typed
array bindings.

16:16 Changeset [101300] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

FloatQuad::isRectilinear() returns false for 180degree rotations
https://bugs.webkit.org/show_bug.cgi?id=73040

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-28
Reviewed by James Robinson.

Source/WebCore:

Added unit test FloatQuadTest.cpp.

  • platform/graphics/FloatQuad.cpp:

(WebCore::withinEpsilon): Check two values are as close as can be represented by floats.
(WebCore::FloatQuad::isRectilinear): Use withinEpsilon().

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/FloatQuadTest.cpp: Added.

(WebCore::TEST):

16:13 Changeset [101299] by ojan@chromium.org
  • 3 edits in trunk/Tools

Some of the results.json files have results/times entries at the directory level
https://bugs.webkit.org/show_bug.cgi?id=73261

Reviewed by Tony Chang.

This is just a bug that got introduced in a temporary push of the results server.
This patch repairs the broken files. After all the bots have cycled, we can simplify
this code to just assert that results/times are not at the directory level.

Also, when catching exceptions, log the full stacktrace.

  • TestResultServer/model/jsonresults.py:

(_is_directory):
(JsonResults._load_json):
(JsonResults._merge_tests):
(JsonResults.merge):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):

15:51 Changeset [101298] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

GetById should not always speculate cell
https://bugs.webkit.org/show_bug.cgi?id=73181

Reviewed by Gavin Barraclough.

GetById will now speculate cell if the predictions of the base are cell.
Otherwise it will do like the old JIT (and like the old non-speculative
DFG JIT): if not cell, go straight to slow-path but otherwise don't OSR
out. This is a 1% speed-up on SunSpider.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

15:48 Changeset [101297] by zmo@google.com
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Webkit gardening: test expectations update.

15:42 Changeset [101296] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Speculative Chromium build-fix.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):

15:40 Changeset [101295] by oliver@apple.com
  • 71 edits
    1 copy
    13 moves
    10 adds
    9 deletes in trunk/Source

Move typed array implementations into wtf
https://bugs.webkit.org/show_bug.cgi?id=73248

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Move typed array implementation files from WebCore to wtf. Inline the
.cpp files for each of the array views to cut down on unnecessary exports
and function call overhead for trivial operations.

Added files to all the project files.

(WTF::ArrayBuffer::transfer):
(WTF::ArrayBuffer::addView):
(WTF::ArrayBuffer::removeView):

  • wtf/ArrayBuffer.h: Renamed from Source/WebCore/html/canvas/ArrayBuffer.cpp.

(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::data):
(WTF::ArrayBufferContents::sizeInBytes):
(WTF::ArrayBufferContents::transfer):
(WTF::ArrayBuffer::~ArrayBuffer):
(WTF::ArrayBuffer::clampValue):
(WTF::ArrayBuffer::create):
(WTF::ArrayBuffer::ArrayBuffer):
(WTF::ArrayBuffer::data):
(WTF::ArrayBuffer::byteLength):
(WTF::ArrayBuffer::slice):
(WTF::ArrayBuffer::sliceImpl):
(WTF::ArrayBuffer::clampIndex):
(WTF::ArrayBufferContents::tryAllocate):
(WTF::ArrayBufferContents::~ArrayBufferContents):

  • wtf/ArrayBufferView.cpp: Copied from Source/WebCore/bindings/js/JSArrayBufferCustom.cpp.

(WTF::ArrayBufferView::ArrayBufferView):
(WTF::ArrayBufferView::~ArrayBufferView):
(WTF::ArrayBufferView::neuter):

  • wtf/ArrayBufferView.h: Renamed from Source/WebCore/html/canvas/ArrayBufferView.h.

(WTF::ArrayBufferView::isByteArray):
(WTF::ArrayBufferView::isUnsignedByteArray):
(WTF::ArrayBufferView::isShortArray):
(WTF::ArrayBufferView::isUnsignedShortArray):
(WTF::ArrayBufferView::isIntArray):
(WTF::ArrayBufferView::isUnsignedIntArray):
(WTF::ArrayBufferView::isFloatArray):
(WTF::ArrayBufferView::isDoubleArray):
(WTF::ArrayBufferView::isDataView):
(WTF::ArrayBufferView::buffer):
(WTF::ArrayBufferView::baseAddress):
(WTF::ArrayBufferView::byteOffset):
(WTF::ArrayBufferView::verifySubRange):
(WTF::ArrayBufferView::clampOffsetAndNumElements):
(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::calculateOffsetAndLength):

  • wtf/CMakeLists.txt:
  • wtf/Float32Array.h: Renamed from Source/WebCore/html/canvas/Float32Array.h.

(WTF::Float32Array::set):
(WTF::Float32Array::item):
(WTF::Float32Array::isFloatArray):
(WTF::Float32Array::create):
(WTF::Float32Array::Float32Array):
(WTF::Float32Array::subarray):

  • wtf/Float64Array.h: Renamed from Source/WebCore/html/canvas/Float64Array.h.

(WTF::Float64Array::set):
(WTF::Float64Array::item):
(WTF::Float64Array::isDoubleArray):
(WTF::Float64Array::create):
(WTF::Float64Array::Float64Array):
(WTF::Float64Array::subarray):

  • wtf/Int16Array.h: Renamed from Source/WebCore/html/canvas/Int16Array.cpp.

(WTF::Int16Array::set):
(WTF::Int16Array::isShortArray):
(WTF::Int16Array::create):
(WTF::Int16Array::Int16Array):
(WTF::Int16Array::subarray):

  • wtf/Int32Array.h: Renamed from Source/WebCore/html/canvas/Int32Array.cpp.

(WTF::Int32Array::set):
(WTF::Int32Array::isIntArray):
(WTF::Int32Array::create):
(WTF::Int32Array::Int32Array):
(WTF::Int32Array::subarray):

  • wtf/Int8Array.h: Renamed from Source/WebCore/html/canvas/Int8Array.cpp.

(WTF::Int8Array::set):
(WTF::Int8Array::isByteArray):
(WTF::Int8Array::create):
(WTF::Int8Array::Int8Array):
(WTF::Int8Array::subarray):

  • wtf/IntegralTypedArrayBase.h: Renamed from Source/WebCore/html/canvas/IntegralTypedArrayBase.h.

(WTF::IntegralTypedArrayBase::set):
(WTF::IntegralTypedArrayBase::item):
(WTF::IntegralTypedArrayBase::IntegralTypedArrayBase):

  • wtf/TypedArrayBase.h: Renamed from Source/WebCore/html/canvas/TypedArrayBase.h.

(WTF::TypedArrayBase::data):
(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):
(WTF::TypedArrayBase::length):
(WTF::TypedArrayBase::byteLength):
(WTF::TypedArrayBase::TypedArrayBase):
(WTF::TypedArrayBase::create):
(WTF::TypedArrayBase::subarrayImpl):

  • wtf/Uint16Array.h: Renamed from Source/WebCore/html/canvas/Uint16Array.cpp.

(WTF::Uint16Array::set):
(WTF::Uint16Array::isUnsignedShortArray):
(WTF::Uint16Array::create):
(WTF::Uint16Array::Uint16Array):
(WTF::Uint16Array::subarray):

  • wtf/Uint32Array.h: Renamed from Source/WebCore/html/canvas/Uint32Array.cpp.

(WTF::Uint32Array::set):
(WTF::Uint32Array::isUnsignedIntArray):
(WTF::Uint32Array::create):
(WTF::Uint32Array::Uint32Array):
(WTF::Uint32Array::subarray):

  • wtf/Uint8Array.h: Renamed from Source/WebCore/html/canvas/Uint8Array.h.

(WTF::Uint8Array::set):
(WTF::Uint8Array::isUnsignedByteArray):
(WTF::Uint8Array::create):
(WTF::Uint8Array::Uint8Array):
(WTF::Uint8Array::subarray):

  • wtf/wtf.pro:

Source/WebCore:

Removed the typed array implementation files from WebCore and
added forwarding headers.

  • CMakeLists.txt:
  • ForwardingHeaders/wtf/ArrayBuffer.h: Added.
  • ForwardingHeaders/wtf/ArrayBufferView.h: Added.
  • ForwardingHeaders/wtf/Float32Array.h: Added.
  • ForwardingHeaders/wtf/Float64Array.h: Added.
  • ForwardingHeaders/wtf/Int16Array.h: Added.
  • ForwardingHeaders/wtf/Int32Array.h: Added.
  • ForwardingHeaders/wtf/Int8Array.h: Added.
  • ForwardingHeaders/wtf/Uint16Array.h: Added.
  • ForwardingHeaders/wtf/Uint32Array.h: Added.
  • ForwardingHeaders/wtf/Uint8Array.h: Added.
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSArrayBufferViewHelper.h:
  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/js/JSFileReaderCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSFloat64ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWaveShaperNodeCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateHeader):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:
  • bindings/scripts/test/JS/JSFloat64Array.h:
  • dom/MessageEvent.h:
  • fileapi/FileReader.cpp:
  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderSync.cpp:
  • fileapi/WebKitBlobBuilder.cpp:
  • html/HTMLMediaElement.cpp:
  • html/canvas/ArrayBuffer.h: Removed.
  • html/canvas/ArrayBufferView.cpp: Removed.
  • html/canvas/DataView.h:
  • html/canvas/Float64Array.cpp: Removed.
  • html/canvas/Int16Array.h: Removed.
  • html/canvas/Int32Array.h: Removed.
  • html/canvas/Int8Array.h: Removed.
  • html/canvas/Uint16Array.h: Removed.
  • html/canvas/Uint32Array.h: Removed.
  • html/canvas/Uint8Array.cpp: Removed.
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • page/Crypto.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • webaudio/AsyncAudioDecoder.cpp:
  • webaudio/AudioBuffer.h:
  • webaudio/AudioContext.cpp:
  • webaudio/AudioParam.h:
  • webaudio/AudioParamTimeline.h:
  • webaudio/JavaScriptAudioNode.cpp:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/WaveShaperProcessor.h:
  • websockets/WebSocketChannel.cpp:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • xml/XMLHttpRequest.cpp:
15:33 Changeset [101294] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, s/SyntaxError/TypeError/ in the flaky test result.

  • platform/chromium-win/fast/workers/worker-constructor-expected.txt:
15:29 Changeset [101293] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build corrections.

  • UIProcess/BackingStore.h: WinCairo doesn't need the Cairo backing for widgets.
  • win/WebKit2CFLite.def: Update to match WebKit2.def.
15:11 Changeset [101292] by robert@webkit.org
  • 74 edits
    137 deletes in trunk

Unreviewed, rolling out r101202.
http://trac.webkit.org/changeset/101202
https://bugs.webkit.org/show_bug.cgi?id=71244

Caused performance regressions when painting collapsed borders

Source/WebCore:

  • rendering/RenderTableCell.cpp:

(WebCore::compareBorders):
(WebCore::RenderTableCell::collapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::operator==):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css2.1/20110323/border-conflict-element-001.htm: Removed.
  • css2.1/20110323/border-conflict-element-001a.htm: Removed.
  • css2.1/20110323/border-conflict-element-001b.htm: Removed.
  • css2.1/20110323/border-conflict-element-001c.htm: Removed.
  • css2.1/20110323/border-conflict-element-001d.htm: Removed.
  • css2.1/20110323/border-conflict-element-003.htm: Removed.
  • css2.1/20110323/border-conflict-element-004.htm: Removed.
  • css2.1/20110323/border-conflict-element-005.htm: Removed.
  • css2.1/20110323/border-conflict-element-006.htm: Removed.
  • css2.1/20110323/border-conflict-element-007.htm: Removed.
  • css2.1/20110323/border-conflict-element-008.htm: Removed.
  • css2.1/20110323/border-conflict-element-009.htm: Removed.
  • css2.1/20110323/border-conflict-element-010.htm: Removed.
  • css2.1/20110323/border-conflict-element-011.htm: Removed.
  • css2.1/20110323/border-conflict-element-012.htm: Removed.
  • css2.1/20110323/border-conflict-element-013.htm: Removed.
  • css2.1/20110323/border-conflict-element-014.htm: Removed.
  • css2.1/20110323/border-conflict-element-015.htm: Removed.
  • css2.1/20110323/border-conflict-element-016.htm: Removed.
  • css2.1/20110323/border-conflict-element-017.htm: Removed.
  • css2.1/20110323/border-conflict-element-018.htm: Removed.
  • css2.1/20110323/border-conflict-element-019.htm: Removed.
  • css2.1/20110323/border-conflict-element-020.htm: Removed.
  • css2.1/20110323/border-conflict-element-021.htm: Removed.
  • css2.1/20110323/border-conflict-element-022.htm: Removed.
  • css2.1/20110323/border-conflict-element-023.htm: Removed.
  • css2.1/20110323/border-conflict-element-024.htm: Removed.
  • css2.1/20110323/border-conflict-element-025.htm: Removed.
  • css2.1/20110323/border-conflict-element-026.htm: Removed.
  • css2.1/20110323/border-conflict-element-027.htm: Removed.
  • css2.1/20110323/border-conflict-element-028.htm: Removed.
  • css2.1/20110323/border-conflict-element-029.htm: Removed.
  • css2.1/20110323/border-conflict-element-030.htm: Removed.
  • css2.1/20110323/border-conflict-element-031.htm: Removed.
  • css2.1/20110323/border-conflict-element-032.htm: Removed.
  • css2.1/20110323/border-conflict-element-033.htm: Removed.
  • css2.1/20110323/border-conflict-element-034.htm: Removed.
  • css2.1/20110323/border-conflict-element-035.htm: Removed.
  • css2.1/20110323/border-conflict-element-036.htm: Removed.
  • css2.1/20110323/border-conflict-element-037.htm: Removed.
  • css2.1/20110323/border-conflict-element-038.htm: Removed.
  • css2.1/20110323/border-conflict-element-039.htm: Removed.
  • css2.1/20110323/support/swatch-blue.png: Removed.
  • css2.1/20110323/support/swatch-green.png: Removed.
  • css2.1/20110323/support/swatch-lime.png: Removed.
  • css2.1/20110323/support/swatch-orange.png: Removed.
  • css2.1/20110323/support/swatch-red.png: Removed.
  • css2.1/20110323/support/swatch-teal.png: Removed.
  • css2.1/20110323/support/swatch-white.png: Removed.
  • css2.1/20110323/support/swatch-yellow.png: Removed.
  • fast/css/border-conflict-element-002.htm: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt: Removed.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png: Removed.
  • platform/chromium/fast/css/border-conflict-element-002-expected.txt: Removed.
15:07 Changeset [101291] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Don't try to optimize huge code blocks
https://bugs.webkit.org/show_bug.cgi?id=73187

Reviewed by Oliver Hunt.

This unifies the heuristics used for deciding if a code block is too big
to optimize, and sets this heuristic to 1000, which is intuitively better
than numeric_limits<unsigned>::max(). It also results in what looks like
a speed-up on both SunSpider and V8 (in Tools/Scripts/bencher).

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
15:06 Changeset [101290] by bdakin@apple.com
  • 19 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=72551
When the recommended scrollbar style changes, WKView's tracking options should
adjust accordingly
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This new ChromeClient function is called when the recommended scrollbar style
changes. This way, WebKit can respond to the change by adjusting its mouse
tracking.

  • page/ChromeClient.h:

(WebCore::ChromeClient::recommendedScrollbarStyleDidChange):

Existing ScrollableArea function scrollbarStyleChanged() now takes an int
indicating the new scrollbar style and a bool indicating whether it is necessary
to force an update. It used to be the case that this function was ONLY used to
force an update (and only called when an updated was needed), but now that it must
also call into the ChromeClient, it is necessary to include a bool tracking
whether we need to force an update. New implementation on FrameView is responsible
for calling ChromeClient, and then that calls into the pre-existing ScrollView
function for the forceUpdate part.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollbarStyleChanged):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView:: scrollbarStyleChanged):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

These new functions take care of passing along the
recommendedScrollbarStyleDidChange() message that originates in the ChromeClient.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::recommendedScrollbarStyleDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

This is where we actually respond to the recommendedScrollbarStyleDidChange
message. We remove the existing tracking area and create a new tracking area with
the appropriate tracking options.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

BuiltInPDFView inherits from WebCore::ScrollableArea, so scrollbarStyleChanged()
must now take two parameters like the one in ScrollableArea.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
15:06 Changeset [101289] by robert@webkit.org
  • 135 edits
    36 moves
    36 adds
    261 deletes in trunk/LayoutTests

Unreviewed, rolling out r101211.
http://trac.webkit.org/changeset/101211

Caused performance regressions when painting collapsed borders

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/border-conflict-element-002-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.png: Removed.
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.txt.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt: Renamed from LayoutTests/platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.txt.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Removed.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Removed.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png:
  • platform/chromium/fast/css/border-conflict-element-002-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/css/border-conflict-element-002-expected.txt.
14:59 Changeset [101288] by jchaffraix@webkit.org
  • 20 edits
    5 adds in trunk

Add limited parsing support for grid-columns and grid-rows
https://bugs.webkit.org/show_bug.cgi?id=72531

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-columns-rows-get-set.html

Added support for:
<track-list> := <length> | <percentage> | 'none' | 'auto'

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/StyleAllInOne.cpp:

Updated our build systems.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackList):
Helper function to convert our RenderStyle information to a proper CSSValue.
It doesn't do much now but it will be expanded as we add more support.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Call the previous
function.

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackList):
CSS parsing part of this change. Pretty simple for now.

  • css/CSSPropertyNames.in:

Added -webkit-grid-columns and -webkit-grid-rows.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Style application plumbing.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
This change is required for later when we add layout for our grid.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::gridColumns):
(WebCore::InheritedFlags::gridRows):
(WebCore::InheritedFlags::setGridColumns):
(WebCore::InheritedFlags::setGridRows):
(WebCore::InheritedFlags::initialGridColumns):
(WebCore::InheritedFlags::initialGridRows):
Getters / Setters and initial values.

  • rendering/style/StyleGridData.cpp: Added.

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h: Added.

(WebCore::StyleGridData::create):
(WebCore::StyleGridData::copy):
(WebCore::StyleGridData::operator==):
(WebCore::StyleGridData::operator!=):
This class holds the grid element information. For now pretty simple
shell that will be used for the rest of the support.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Added StyleGridElementData to StyleRareNonInheritedData.

LayoutTests:

Test our currently supported grammar.

  • fast/css-grid-layout/grid-columns-rows-get-set.html: Added.
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js: Added.
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt: Added.
14:57 Changeset [101287] by commit-queue@webkit.org
  • 1 edit
    106 deletes in trunk/LayoutTests

Unreviewed, rolling out r101207.
http://trac.webkit.org/changeset/101207
https://bugs.webkit.org/show_bug.cgi?id=73256

"Caused performance regressions when painting collapsed
borders" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-28

  • platform/gtk/css2.1/20110323/border-conflict-element-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-001a-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-001b-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-001c-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-001d-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-003-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-004-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-005-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-006-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-007-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-008-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-009-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-010-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-011-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-012-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-013-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-014-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-018-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-019-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-021-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-023-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-024-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-025-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-026-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-027-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-028-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-029-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-030-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-031-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-032-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-033-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-034-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-035-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/border-conflict-element-039-expected.txt: Removed.
  • platform/gtk/fast/css/border-conflict-element-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-001a-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-001b-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-001c-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-001d-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-006-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-007-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-008-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-009-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-010-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-011-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-012-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-013-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-014-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-018-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-019-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-021-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-022-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-023-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-024-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-025-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-026-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-028-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-029-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-030-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-031-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-032-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-033-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-034-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-035-expected.txt: Removed.
  • platform/mac/css2.1/20110323/border-conflict-element-039-expected.txt: Removed.
  • platform/mac/fast/css/border-conflict-element-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-001a-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-001b-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-001c-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-001d-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-006-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-007-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-008-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-009-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-010-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-011-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-012-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-013-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-014-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-015-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-018-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-020-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-021-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-023-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-024-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-025-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-026-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-027-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-028-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-029-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-030-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-031-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-032-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-033-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-034-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-035-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-036-expected.txt: Removed.
  • platform/qt/fast/css/border-conflict-element-002-expected.txt: Removed.
14:55 Changeset [101286] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Use data decoding swizzle for turbo JPEG image decoding.
https://bugs.webkit.org/show_bug.cgi?id=59670

Reviewed by Kenneth Russell.

Add a BGRX row decode data swizzle for the little-endian ports that use libjpeg-turbo
(Chromium win/linux/mac) to reduce JPEG image decoding time by ~2x.

JPEG images of type JSC_GRAYSCALE are excluded since layout regressions were observed
for grayscale images produced by older tools (XV 3.10a 12/19/94). libjpeg decodes the
images without error; libjpeg-turbo caused visible artifacts (see bug for examples).

This patch is based on the work of Hironori Bono. He provided the original patch, and
the quantitative results confirming the significant performance improvement.

No new tests. Covered by many existing tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(rgbOutputColorSpace): If JCS_EXTENSIONS is defined (libjpeg-turbo), and the port is
little-endian, define a BGRX data swizzle for use when decoding pixel rows.
(turboSwizzled):
(WebCore::JPEGImageReader::decode): Select a possibly swizzled rgbOutputColorSpace()
for JSC_RGB and JCS_YCbCr input color space images. Exclude JSC_GRAYSCALE images.
(WebCore::JPEGImageDecoder::outputScanlines): Swizzle decode, if applicable.

14:52 Changeset [101285] by tony@chromium.org
  • 6 edits
    1 copy in trunk/Tools

ews bots should pass --force to update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=73230

Reviewed by Adam Barth.

This makes it less likely for gclient changes to break the bots (e.g.,
if a DEPS repository moves or is switched to a branch).

Also pass --force when using |build-webkit --update-chromium| since this
appears to only be used by the bots.

Take 2: Add Options.non_interactive to update.py's options() method.

  • Scripts/update-webkit:
  • Scripts/webkitdirs.pm:

(determineIsChromium): Add --force-update to update-webkit --chromium.
(forceChromiumUpdate):
(buildChromium): Pass --force to update-webkit-chromium.

  • Scripts/webkitpy/tool/steps/update.py:

(Update.run): Add --force-update if non-interactive (i.e., bots).

  • Scripts/webkitpy/tool/steps/update_unittest.py:
14:49 Changeset [101284] by commit-queue@webkit.org
  • 71 edits
    86 deletes in trunk/LayoutTests

Unreviewed, rolling out r101220 and r101223.
http://trac.webkit.org/changeset/101220
http://trac.webkit.org/changeset/101223
https://bugs.webkit.org/show_bug.cgi?id=73252

"Caused performance regressions when painting collapsed
borders" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-28

  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001a-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001b-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001c-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-003-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-004-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-005-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-006-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-007-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-008-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-009-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-010-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-011-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-012-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-013-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-014-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-015-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-018-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-019-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-020-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-021-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-022-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-023-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-024-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-025-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-026-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-027-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-028-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-029-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-030-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-031-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-032-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-033-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-034-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-035-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-036-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-039-expected.png: Removed.
  • platform/chromium-linux/fast/css/border-conflict-element-002-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-leopard/fast/css/border-conflict-element-002-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
14:48 Changeset [101283] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Either remove the GetMethod node from the DFG backend, or find a use for it
https://bugs.webkit.org/show_bug.cgi?id=73178

Reviewed by Gavin Barraclough.

More testing seemed to imply that the GetMethod code was indeed not profitable
in any major test. So, it's probably best to just remove it.

  • bytecode/CodeBlock.cpp:

(JSC::MethodCallLinkInfo::reset):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGRepatch.cpp:
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

14:30 Changeset [101282] by zmo@google.com
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Webkit gardener: test expectations update

14:28 Changeset [101281] by tony@chromium.org
  • 6 edits
    1 delete in trunk/Tools

Revert r101279, broke the ews and cq bots.

  • Scripts/update-webkit:
  • Scripts/webkitdirs.pm:

(determineIsChromium):
(buildChromium):

  • Scripts/webkitpy/common/config/ports.py:

(WebKitPort.update_webkit_command):
(ChromiumPort.update_webkit_command):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.update_webkit_command):

  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
14:00 Changeset [101280] by ojan@chromium.org
  • 3 edits in trunk/Tools

testlistjson on the test results server doesn't understand hierarchical results format
https://bugs.webkit.org/show_bug.cgi?id=73246

Reviewed by Tony Chang.

  • TestResultServer/model/jsonresults.py:

(JsonResults._delete_results_and_times):
Instead of just getting the top-level keys, we now walk the tests tree and
delete the results and times values.

  • TestResultServer/model/jsonresults_unittest.py:

Simplify the test harness to take in the same JSON format for the tests
that the actual results.json uses instead of something very similar but
needlessly different. This also allows for testing the broken case of
results and times values being at non-leaf level.

13:59 Changeset [101279] by tony@chromium.org
  • 6 edits
    1 copy in trunk/Tools

ews bots should pass --force to update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=73230

Reviewed by Adam Barth.

This makes it less likely for gclient changes to break the bots (e.g.,
if a DEPS repository moves or is switched to a branch).

Also pass --force when using |build-webkit --update-chromium| since this
appears to only be used by the bots.

  • Scripts/update-webkit:
  • Scripts/webkitdirs.pm:

(determineIsChromium): Add --force-update to update-webkit --chromium.
(forceChromiumUpdate):
(buildChromium): Pass --force to update-webkit-chromium.

  • Scripts/webkitpy/tool/steps/update.py:

(Update.run): Add --force-update if non-interactive (i.e., bots).

  • Scripts/webkitpy/tool/steps/update_unittest.py:
13:42 Changeset [101278] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Change set 101187 from bug 73154 removed already lower case optimization
https://bugs.webkit.org/show_bug.cgi?id=73174

Added back the "string is already lower case" optimization.

Reviewed by Geoffrey Garen.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):

13:41 Changeset [101277] by msaboff@apple.com
  • 2 edits in trunk/Tools

Fixed help message for --exclude-kraken to say that
it excludes Kraken and not SunSpider.

Rubber-stamped by Filip Pizlo.

  • Scripts/bencher:
13:33 Changeset [101276] by commit-queue@webkit.org
  • 6 edits
    1 copy
    2 deletes in trunk

Unreviewed, rolling out r101273.
http://trac.webkit.org/changeset/101273
https://bugs.webkit.org/show_bug.cgi?id=73244

multiple test failures and timeouts (Requested by tonywork on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-28

Source/WebKit/chromium:

  • WebKit.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::keyDown):

  • DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.

(AlarmHandler):
(TestShell::waitTestFinished):
(platformInit):
(openStartupDialog):
(checkLayoutTestSystemDependencies):

  • DumpRenderTree/chromium/TestShellGtk.cpp:

(AlarmHandler):
(setupFontconfig):
(TestShell::waitTestFinished):
(platformInit):

  • DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
  • DumpRenderTree/chromium/TestShellStub.cpp: Removed.
12:55 Changeset [101275] by fsamuel@chromium.org
  • 6 edits
    2 adds in trunk

Fix Aspect Ratio Property Inheritance And Make the Computed Value Equal the Specified Value
https://bugs.webkit.org/show_bug.cgi?id=73038

Source/WebCore:

Reviewed by Ojan Vafai.

hasAspectRatio was not being set if the -webkit-aspect-ratio property was inherited from the parent.

Additionally, the computed value of -webkit-aspect-ratio was returning a number instead of a ratio.

Test: fast/css/aspect-ratio-inheritance.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAspectRatio::applyInheritValue):

LayoutTests:

Reviewed by Ojan Vafai.

Updated the parsing test to make sure that the -webkit-aspect-ratio property accepts inherit as a possible value.

Added an inheritance test that checks the computed value is correctly inherited.

  • fast/css/aspect-ratio-inheritance-expected.txt: Added.
  • fast/css/aspect-ratio-inheritance.html: Added.
  • fast/css/aspect-ratio-parsing-tests-expected.txt:
  • fast/css/aspect-ratio-parsing-tests.html:
12:48 Changeset [101274] by eric@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed and modified by Eric Seidel.

This is a simpler version of John's patch which I'm landing.
This just engages the hacks from the Host constructor on a global
basis.

Patch by John Yani <vanuan@gmail.com> on 2011-11-28

  • Scripts/webkitpy/common/host.py:

(Host.init):
(Host._engage_awesome_locale_hacks):

12:21 Changeset [101273] by fsamuel@chromium.org
  • 6 edits
    1 copy
    1 add
    1 delete in trunk

[Chromium] Fix broken DRT build for Aura Linux
https://bugs.webkit.org/show_bug.cgi?id=72667

Reviewed by Tony Chang.

Source/WebKit/chromium:

  • WebKit.gyp:

Tools:

DRT now builds for Aura Linux. This, more or less, shares the same code as Android.

The following changes have been made:

  1. Renamed TestShellAndroid to TestShellLinux.
  2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
  3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::keyDown):

  • DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
  • DumpRenderTree/chromium/TestShellGtk.cpp:
  • DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.

(AlarmHandler):
(TestShell::waitTestFinished):
(setupFontconfig):
(platformInit):

  • DumpRenderTree/chromium/TestShellStub.cpp: Added.

(checkLayoutTestSystemDependencies):
(openStartupDialog):

12:09 Changeset [101272] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash due to bidi style in isolated run
https://bugs.webkit.org/show_bug.cgi?id=72978

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-28
Reviewed by Eric Seidel.

Source/WebCore:

Prevent the UBA from changing the embedding level when inside an isolated run.

  • rendering/InlineIterator.h:

(WebCore::notifyObserverEnteredObject):
(WebCore::notifyObserverWillExitObject):

LayoutTests:

Test to verify fix for crashing bug.

  • fast/text/international/embed-bidi-style-in-isolate-crash.html: Added
  • fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt: Added
12:05 Changeset [101271] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

WebKitGTK+-1.7.2 build error due to a reference to gdk_disable_multidevice()
https://bugs.webkit.org/show_bug.cgi?id=73206

Patch by Stefan Zwanenburg <stefanhetzwaantje@gmail.com> on 2011-11-28
Reviewed by Martin Robinson.

  • tests/testatk.c:

(initializeTestingFramework): Don't use gdk_disable_multidevice()
when using GTK2.

11:31 Changeset [101270] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix 'make dist' by adding two missing files to source list.

  • GNUmakefile.list.am: Add missing files.
11:22 Changeset [101269] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix panning after r101179
https://bugs.webkit.org/show_bug.cgi?id=73224

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-28
Reviewed by Noam Rosenthal.

We were wrongly checking for interactionEngine() instead of
!interactionEngine() after the QtWebPageEventHandler refactor.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

11:19 Changeset [101268] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

dir=auto should imply unicode-bidi:isolate by default
https://bugs.webkit.org/show_bug.cgi?id=63903

Reviewed by Dan Bernstein.

Source/WebCore:

Fixed WebKit's implementation of bdo, bdi, and output elements to match HTML5 spec section 10.3.5:
http://dev.w3.org/html5/spec/Overview.html#bidirectional-text

Any element with dir=auto other than bdo, textarea, and pre should use unicode-bidi: -webkit-isolate by default.

We still don't use -webkit-isolate for non-phrasing elements by default and unicode-override -webkit-isolate for
bdo[dir=auto] so these two cases are failing in the added test.

Test: fast/css/default-bidi-css-rules.html

  • css/html.css:

(bdi, output): bdi and output should both use -webkit-isolate as the default value for unicode-bidi.
(bdo): bdo should use bidi-override as the default value for unicode-bidi.

  • dom/MappedAttributeEntry.h: Add eBDI, which is used by bdi and output elements.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::mapToEntry): Don't share the cache for dir attribute between bdi and other elements
just like we don't share the cache for dir attribute between bdo and other elements.
(WebCore::unicodeBidiAttributeForDirAuto): Don't set bidi-override for bdo element since this is done
in the UA stylesheet now. Set unicode-bidi to -webkit-isolate for elements other than pre and textarea now that
this function is called only when dir=auto.
called when dir=auto as the name implies.
(WebCore::HTMLElement::parseMappedAttribute): Don't call unicodeBidiAttributeForDirAuto when dir is not
auto. Also set unicode-bidi to embed when dir is not auto and the element is neither bdi, bdo, nor output.

  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::mapToEntry): Don't share the cache for dir between output and other elements.

  • html/HTMLOutputElement.h:
  • html/HTMLTagNames.in:

LayoutTests:

Added a test to ensure WebKit implements HTML5 bidirectional text support properly:
http://dev.w3.org/html5/spec/Overview.html#bidirectional-text

  • fast/css/default-bidi-css-rules-expected.txt: Added.
  • fast/css/default-bidi-css-rules.html: Added.
11:13 Changeset [101267] by abarth@webkit.org
  • 4 edits
    15 copies
    15 adds in trunk/Source/WebKit/chromium

[Chromium] Move "final" batch of headers into public/platform
https://bugs.webkit.org/show_bug.cgi?id=73198

Reviewed by Darin Fisher.

This patch moves another group of headers into the platform directory.
I found these headers by reading through the list of headers and
coorelating them with WebCore concepts. This patch doesn't move all
the APIs that coorespond to WebCore platform concepts because some,
such as WebFontCache, are not used to support the WebCore platform but
rather to provide the embedder access to the WebCore concept. This
patch should be the last bulk move of headers.

There are two main groups of headers that make up the bulk of this
patch:

1) URLLoader-related headers.
2) Geometry-related headers.

  • public/WebArrayBufferView.h: Replaced.
  • public/WebBlobData.h: Replaced.
  • public/WebCookie.h: Replaced.
  • public/WebExternalTextureLayer.h: Update include.
  • public/WebFloatPoint.h: Replaced.
  • public/WebFloatQuad.h: Replaced.
  • public/WebFloatRect.h: Replaced.
  • public/WebFrameClient.h: Update include.
  • public/WebHTTPBody.h: Replaced.
  • public/WebHTTPHeaderVisitor.h: Replaced.
  • public/WebHTTPLoadInfo.h: Replaced.
  • public/WebThreadSafeData.h: Replaced.
  • public/WebURLError.h: Replaced.
  • public/WebURLLoadTiming.h: Replaced.
  • public/WebURLLoaderClient.h: Replaced.
  • public/WebURLRequest.h: Replaced.
  • public/WebURLResponse.h: Replaced.
  • public/platform/WebArrayBufferView.h: Copied from Source/WebKit/chromium/public/WebArrayBufferView.h.
  • public/platform/WebBlobData.h: Copied from Source/WebKit/chromium/public/WebBlobData.h.
  • public/platform/WebCookie.h: Copied from Source/WebKit/chromium/public/WebCookie.h.
  • public/platform/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/WebFloatPoint.h.
  • public/platform/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/WebFloatQuad.h.
  • public/platform/WebFloatRect.h: Copied from Source/WebKit/chromium/public/WebFloatRect.h.
  • public/platform/WebHTTPBody.h: Copied from Source/WebKit/chromium/public/WebHTTPBody.h.
  • public/platform/WebHTTPHeaderVisitor.h: Copied from Source/WebKit/chromium/public/WebHTTPHeaderVisitor.h.
  • public/platform/WebHTTPLoadInfo.h: Copied from Source/WebKit/chromium/public/WebHTTPLoadInfo.h.
  • public/platform/WebThreadSafeData.h: Copied from Source/WebKit/chromium/public/WebThreadSafeData.h.
  • public/platform/WebURLError.h: Copied from Source/WebKit/chromium/public/WebURLError.h.
  • public/platform/WebURLLoadTiming.h: Copied from Source/WebKit/chromium/public/WebURLLoadTiming.h.
  • public/platform/WebURLLoader.h: Remove FIXME.
  • public/platform/WebURLLoaderClient.h: Copied from Source/WebKit/chromium/public/WebURLLoaderClient.h.
  • public/platform/WebURLRequest.h: Copied from Source/WebKit/chromium/public/WebURLRequest.h.
  • public/platform/WebURLResponse.h: Copied from Source/WebKit/chromium/public/WebURLResponse.h.
10:59 Changeset [101266] by eric@webkit.org
  • 9 edits
    2 copies in trunk/Tools

Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=71983

Reviewed by Adam Barth.

We'll add more code to Environment overtime,
allowing us to mock out more of our direct interactions with os.environ.

This patch also makes run_command print the passed in environment.

  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  • Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  • Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/build.py:
10:50 Changeset [101265] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

WebAudio: AudioContext::uninitialize() can caused AudioContext deletion before deleting marked nodes.
https://bugs.webkit.org/show_bug.cgi?id=72755

Reviewed by Eric Carlson.

No new tests.

Protect AudioContext from being deleted before uninitialize() returns. Fixes an assertion in ~AudioContext() and
a potential source of leaks.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::uninitialize):

10:28 Changeset [101264] by zmo@google.com
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Webkit gardener: test expectations update.

07:59 Changeset [101263] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

InspectorCSSAgent: Remove unused function inlineStyleElement().
<http://webkit.org/b/73221>

Reviewed by Pavel Feldman.

  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
07:50 Changeset [101262] by hausmann@webkit.org
  • 10 edits
    8 adds in trunk

[Qt] Build system fixes against V8.

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Get rid of old v8 cruft.
  • WebKit.pro: Don't build JavaScriptCore when configured with v8.

Source/WebCore:

  • DerivedSources.pri: Add missing binding files to the build and also added

the regexp table generation needed for Yarr, which is compiled statically into
WebCore to implement WebCore::RegularExpression.

  • Target.pri: Adapt to latest v8 binding files.

Source/WebKit/qt:

Add forwarding headers for building against Qt's v8 with
v8 include style.

  • v8/ForwardingHeaders/v8-debug.h: Added.
  • v8/ForwardingHeaders/v8-preparser.h: Added.
  • v8/ForwardingHeaders/v8-profiler.h: Added.
  • v8/ForwardingHeaders/v8-testing.h: Added.
  • v8/ForwardingHeaders/v8.h: Added.
  • v8/ForwardingHeaders/v8stdint.h: Added.

Tools:

  • qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
  • qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure

WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)

07:44 Changeset [101261] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: resource status image is mis-aligned in the network headers view
https://bugs.webkit.org/show_bug.cgi?id=73211

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView):

07:25 Changeset [101260] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: console evaluation doesn't work when navigating from a page with several frames to another one
https://bugs.webkit.org/show_bug.cgi?id=73210

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-events.html

  • inspector/Inspector.json:
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeFrame.prototype.navigate):
(WebInspector.ResourceTreeFrame.prototype.removeChildFrame):
(WebInspector.ResourceTreeFrame.prototype.removeChildFrames):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-events-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-events.html: Added.
06:45 Changeset [101259] by kenneth@webkit.org
  • 6 edits in trunk

Make sure the useFixedLayout feature is consistently handled
https://bugs.webkit.org/show_bug.cgi?id=73212

Reviewed by Simon Hausmann.

Source/WebKit2:

Set the fixed layout on the UI side so that it is part of the page
creation parameters and ensure that the page parameters are set
before creating the page.

The parameters are set to our defaults and are now altered in the
WebKitTestRunner.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebView::QQuickWebView):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setUseFixedLayout):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

On the web process side the default value for useFixedLayout
wasn't actually read from the creation parameters. As it now may
be different than that of the FrameView, we now call
setFixedLayout in the constructor so make sure the value is
propagated to the FrameView.

(WebKit::WebPage::setFixedVisibleContentRect):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::resizeToContentsIfNeeded):
(WebKit::WebPage::setViewportSize):
(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):

The methods that depends on fixed layout now have asserts to make
sure that they are used properly.

Tools:

The web page parameters are set to our Qt defaults and are now altered
in the WebKitTestRunner.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::WrapperWindow):

06:44 Changeset [101258] by reed@google.com
  • 2 edits in trunk/LayoutTests

add GPU to expectations for audio-repaint
https://bugs.webkit.org/show_bug.cgi?id=73209

unreviewed, update expectations.

  • platform/chromium/test_expectations.txt:
06:41 Changeset [101257] by pfeldman@chromium.org
  • 45 edits
    2 copies in trunk/Source/WebCore

Web Inspector: introduce InspectorBaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=73203

Now that inspector controller does not depend on concrete inspector agent
classes, we can collect agent instances using abstract type.

Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):

  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBaseAgent.cpp: Copied from Source/WebCore/inspector/InspectorFileSystemAgent.h.

(WebCore::InspectorBaseAgent::InspectorBaseAgent):
(WebCore::InspectorBaseAgent::~InspectorBaseAgent):

  • inspector/InspectorBaseAgent.h: Copied from Source/WebCore/inspector/InspectorFileSystemAgent.h.
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):

  • inspector/InspectorCSSAgent.h:

(WebCore::InspectorCSSAgent::setFrontend):
(WebCore::InspectorCSSAgent::restore):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::restore):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::restore):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enabled):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::clearFrontend):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):

  • inspector/InspectorFileSystemAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::restoreEnablement):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:
06:37 Changeset [101256] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Properly retain the OS X version string

Fixes <http://webkit.org/b/73214> REGRESSION (r101215): Crash on launch beneath +[WebView
_standardUserAgentWithApplicationName:]

Reviewed by Antti Koivisto.

  • WebView/WebView.mm:

(createMacOSXVersionString): Retain the string we're returning, since this function is
supposed to return an owning reference to the caller.

05:53 Changeset [101255] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: chromium: Unreviewed one-line fix for Summary view filter.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):

05:41 Changeset [101254] by hausmann@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed prospective build fix. Touch the file to trigger correct
rebuild on the Qt mips/sh4/sl bot.

  • wtf/unicode/qt4/UnicodeQt4.h:
05:02 Changeset [101253] by vestbo@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Remove cruft from project file

Reviewed by Simon Hausmann.

05:02 Changeset [101252] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-11-28 Pavel Feldman <pfeldman@google.com>

Not reviewed: disable filesystem instrumentation to unbreak Qt tests.

  • inspector/front-end/inspector.js:
04:44 Changeset [101251] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r101249.
http://trac.webkit.org/changeset/101249
https://bugs.webkit.org/show_bug.cgi?id=73205

it broke qt-minimal and wince builds (Requested by loislo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-28

  • inspector/CodeGeneratorInspector.py:

(Capitalizer.upper_camel_case_to_lower):
(RawTypes.get):
(RawTypes.String.get_c_param_type):
(RawTypes.Object.get_c_param_type):
(RawTypes.Object):
(ParamType):
(TypeData.init):
(TypeData.get_raw_type):
(TypeMap.init):
(InspectorFrontend_h):
(InspectorArray):
(InspectorObject):
(String):
(InspectorBackendDispatcher_h):
(Generator.process_command):

  • inspector/InspectorValues.h:
04:37 Changeset [101250] by andreas.kling@nokia.com
  • 10 edits in trunk/Source/WebCore

CSSStyleDeclaration: Remove ability to have style sheet as parent.
<http://webkit.org/b/73199>

Reviewed by Antti Koivisto.

Refactor so we don't have to support style sheets as parents of style declarations.
The users of this mechanism were mapped attributes and inline styles, which instead
now know how to find the relevant style sheet via their document().

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSElementStyleDeclaration::styleSheet):

Added CSSElementStyleDeclaration::styleSheet(). The default implementation
returns the associated element's document()->elementSheet(). It is virtual
because SVGFontFaceElement needs document()->mappedElementSheet() instead.

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::setParentRule):

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

Remove m_parentIsRule and m_parentStyleSheet, leaving only m_parentRule.

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::parentStyleSheet):

Out-of-lined so it can return the CSSElementStyleDeclaration::styleSheet() for
declarations with an associated element.

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::setDeclaration):

Use setParentRule() instead of setParentStyleSheet() on the internal
CSSMutableStyleDeclaration in keyframe rules.

  • dom/StyledElement.h:

Removed StyledElement::didMoveToNewOwnerDocument() since we no longer need to
manually keep the inline style's parent style sheet pointer up-to-date.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

Remove setParentStyleSheet() calls on mapped attributes and inline styles.
They now find the relevant style sheet by following the associated element ptr.

  • svg/SVGFontFaceElement.cpp:

(WebCore::FontFaceStyleDeclaration::FontFaceStyleDeclaration):
(WebCore::FontFaceStyleDeclaration::~FontFaceStyleDeclaration):
(WebCore::FontFaceStyleDeclaration::styleSheet):

Subclass CSSElementStyleDeclaration for SVG's font-face elment in order to
override styleSheet(). This is necessary because they operate on the document's
mappedElementSheet() rather than the elementSheet().

04:30 Changeset [101249] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-11-28
Reviewed by Pavel Feldman.

Extends python generator functionality.
Makes constructor in InspectorObject public.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InspectorValues.h:
04:26 Changeset [101248] by carlosgc@webkit.org
  • 9 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[GTK] Rename WebKitNetworkRequest to WebKitURIRequest
https://bugs.webkit.org/show_bug.cgi?id=73202

Reviewed by Martin Robinson.

Network is confusing because the request can be for a local file uri.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitNetworkRequest.h: Removed.
  • UIProcess/API/gtk/WebKitURIRequest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp.

(webkitURIRequestFinalize):
(webkitURIRequestGetProperty):
(webkitURIRequestSetProperty):
(webkit_uri_request_class_init):
(webkit_uri_request_init):
(webkit_uri_request_new):
(webkit_uri_request_get_uri):

  • UIProcess/API/gtk/WebKitURIRequest.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadRequest):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadRequest):

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2.h:
04:20 Changeset [101247] by hausmann@webkit.org
  • 19 edits
    2 adds
    1 delete in trunk

[Qt] WTF should be built as separate static library https://bugs.webkit.org/show_bug.cgi?id=73201

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Require wtf.
  • WebKit.pro: Build WTF.

Source/JavaScriptCore:

  • Target.pri: Don't claim to build WTF, as that would cause

the debug-with-shlibs build to not link in wtf.

  • jsc.pro: Require wtf.
  • wtf/wtf.pri: Removed.
  • wtf/wtf.pro: Added. Pro file to build wtf statically.

Source/WebCore:

  • Target.pri: Require wtf and don't claim to be building it

with BUILDING_WTF in DEFINES (otherwise we won't link it with
debug-shlib builds).

Source/WebKit2:

  • Target.pri: Require wtf.
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Remove unnecessary config.h

inclusion and thus wtf dependency.

Tools:

  • DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
  • MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and

thus wtf dependency.

  • WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
  • WebKitTestRunner/Target.pri: Ditto.
  • qmake/mkspecs/features/default_post.prf: When re-ordering the static libs

consider wtf, too.

  • qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,

moved into wtf.prf.

  • qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also

link in libwtf.

  • qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
04:18 Changeset [101246] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Rename abbreviated value names to cpp style names.
https://bugs.webkit.org/show_bug.cgi?id=73193

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-11-28
Reviewed by Andreas Kling.

Rename abbreviated values name to cpp style names in ewk_single/tiled_view.cpp.

  • ewk/ewk_view_single.cpp:

(_ewk_view_4b_move_region_up):
(_ewk_view_4b_move_region_down):
(_ewk_view_4b_move_line_left):
(_ewk_view_4b_move_line_right):
(_ewk_view_4b_move_region_left):
(_ewk_view_4b_move_region_right):
(_ewk_view_4b_move_region):
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_scrolls_process):
(_ewk_view_tiled_smart_repaints_process):

04:04 Changeset [101245] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix build error on Chromium/Windows.
https://bugs.webkit.org/show_bug.cgi?id=73200

Unreviewed build fix.

Patch by Taiju TSUIKI <tzik@chromium.org> on 2011-11-28

  • inspector/InspectorFileSystemAgent.cpp:
03:51 Changeset [101244] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck issues.

  • GNUmakefile.list.am: Add missing files.
  • bindings/gobject/GNUmakefile.am: Only build

WebKitDOMHTMLPropertiesCollection when microdate is enabled.

03:44 Changeset [101243] by ossy@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific results.

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2011-11-28

  • platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Added.
  • platform/qt/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/qt/css3/images/cross-fade-overflow-position-expected.txt: Added.
  • platform/qt/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/qt/fast/borders/border-mixed-alpha-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
  • platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/qt/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/qt/svg/transforms/svg-css-transforms-expected.txt: Added.
03:31 BuildingGtk edited by mrobinson@webkit.org
(diff)
03:08 BuildingQt5OnHarmattan edited by ossy@webkit.org
(diff)
03:04 Changeset [101242] by mrobinson@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[GTK] JavaScriptCore generated sources should build in the DerivedSources directory
https://bugs.webkit.org/show_bug.cgi?id=73197

Reviewed by Philippe Normand.

Build all JavaScriptCore generated sources in DerivedSources.

  • GNUmakefile.am: Update generation rules.
  • GNUmakefile.list.am: Update source lists.
03:01 Changeset [101241] by hayato@chromium.org
  • 2 edits in trunk/Source/WebKit/mac

Fix chromium canary build after r101215.
Unreviewed. Build fix.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

02:23 Changeset [101240] by haraken@chromium.org
  • 2 edits in trunk/Tools

run-bindings-tests shows diff error for a newly added binding test
https://bugs.webkit.org/show_bug.cgi?id=73179

Reviewed by Adam Barth.

Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
run-bindings-tests just shows diff error because reference files
(i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:

FAIL: (V8) V8TestSupplemental.h
diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory

Instead, this patch treats a non-existent reference file as an empty file and
shows the result of the newly added binding test, like this:

FAIL: (V8) V8TestSupplemental.h
--- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h 1970-01-01 09:00:00.000000000 +0900
+++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
@@ -0,0 +1,84 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
(omitted)

  • Scripts/run-bindings-tests:

(detect_changes): Just added an -N option to the diff command.

02:09 Changeset [101239] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r101201): Crash inside WebKit::WebInspector::didClose() when closing any tab
https://bugs.webkit.org/show_bug.cgi?id=73183

Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::closeInspectorFrontend):

02:05 Changeset [101238] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSS border image properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72846

Reviewed by Andreas Kling.

Refactoring that implements CSS border image properties in CSSStyleApplyProperty.
Part of the larger refactoring aimed at removing CSSStyleSelector::applyProperty().

Covered by existing tests in fast/css.

  • css/CSSStyleApplyProperty.cpp:

Implement property handlers based on existing code.
(WebCore::ApplyPropertyBorderImage::setValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImage::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Remove old code.
(WebCore::CSSStyleSelector::applyProperty):

02:02 Changeset [101237] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSS hyphenate-limit properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=73107

Reviewed by Andreas Kling.

Covered by existing tests under fast/css (parsing-hyphenate-limit-lines.html, parsing-hyphenate-limit.html, text/hyphenate-limit-lines.html)

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyNumber::setValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyNumber::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

02:00 Changeset [101236] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk/Source/WebCore

[Inspector][FileSystem]: Capture DOMFileSystem object.
Adding files for FileSystem support to Inspector.
Adding hooks into DOMFileSystem creation and destruction.
https://bugs.webkit.org/show_bug.cgi?id=72456

Patch by Taiju TSUIKI <tzik@chromium.org> on 2011-11-28
Reviewed by Pavel Feldman.

Tests should be added in later CL.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/DOMFileSystem.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/InspectorController.h:
  • inspector/InspectorFileSystemAgent.cpp: Added.
  • inspector/InspectorFileSystemAgent.h: Added.
  • inspector/InspectorFileSystemInstrumentation.h: Added.
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didOpenFileSystemImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorFileSystemAgent):
(WebCore::InstrumentingAgents::setInspectorFileSystemAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):

  • inspector/front-end/inspector.js:
01:51 Changeset [101235] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

[Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=73165

Reviewed by Philippe Normand.

Fix some syntax errors in this script and remove an unused variable.

  • gtk/generate-gtkdoc:

(get_webkit2_options.src_path):
(get_webkit2_options):
(get_webkit1_options.src_path):

01:46 Changeset [101234] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyWebkitFlowInto and CSSPropertyWebkitFlowFrom in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73110

Reviewed by Andreas Kling.

Covered by existing tests under fast/regions.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

01:37 Changeset [101233] by tkent@chromium.org
  • 2 edits
    12 adds
    180 deletes in trunk/LayoutTests

Convert some placeholder-related tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=71779

Reviewed by Ryosuke Niwa.

  • fast/css/pseudo-cache-stale-expected.html: Added.
  • fast/forms/input-placeholder-text-indent-expected.html: Added.
  • fast/forms/input-placeholder-visibility-2-expected.html: Added.
  • fast/forms/isindex-placeholder-expected.html: Added.
  • fast/forms/password-placeholder-text-security-expected.html: Added.
  • fast/forms/password-placeholder-text-security.html: Removed unused function.
  • fast/forms/password-placeholder.html: Removed because password-placeholder-text-security.html covers this.
  • fast/forms/placeholder-set-attribute-expected.html: Added.
  • fast/forms/placeholder-set-value-expected.html: Added.
  • fast/forms/placeholder-stripped-expected.html: Added.
  • fast/forms/search-placeholder-value-changed-expected.html: Added.
  • fast/forms/textarea-placeholder-set-attribute-expected.html: Added.
  • fast/forms/textarea-placeholder-set-value-expected.html: Added.
  • fast/forms/textarea-placeholder-wrapping-expected.html: Added.
  • platform/chromium-cg-mac-leopard/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-linux/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-linux/fast/forms/password-placeholder-expected.png: Removed.
  • platform/chromium-linux/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/chromium-linux/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-linux/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/chromium-linux/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-linux/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/chromium-linux/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-mac/fast/forms/password-placeholder-expected.png: Removed.
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/chromium-mac/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Removed.
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.txt: Removed.
  • platform/chromium-win/fast/forms/password-placeholder-expected.png: Removed.
  • platform/chromium-win/fast/forms/password-placeholder-expected.txt: Removed.
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt: Removed.
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt: Removed.
  • platform/chromium-win/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/chromium-win/fast/forms/placeholder-set-value-expected.txt: Removed.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Removed.
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/chromium-win/fast/forms/textarea-placeholder-set-value-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.txt: Removed.
  • platform/efl/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/efl/fast/css/pseudo-cache-stale-expected.txt: Removed.
  • platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/efl/fast/forms/input-placeholder-text-indent-expected.txt: Removed.
  • platform/efl/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/efl/fast/forms/isindex-placeholder-expected.txt: Removed.
  • platform/efl/fast/forms/password-placeholder-expected.png: Removed.
  • platform/efl/fast/forms/password-placeholder-expected.txt: Removed.
  • platform/efl/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/efl/fast/forms/placeholder-set-attribute-expected.txt: Removed.
  • platform/efl/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/efl/fast/forms/placeholder-set-value-expected.txt: Removed.
  • platform/efl/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/efl/fast/forms/placeholder-stripped-expected.txt: Removed.
  • platform/efl/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/efl/fast/forms/search-placeholder-value-changed-expected.txt: Removed.
  • platform/efl/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/efl/fast/forms/textarea-placeholder-set-attribute-expected.txt: Removed.
  • platform/efl/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/efl/fast/forms/textarea-placeholder-set-value-expected.txt: Removed.
  • platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/efl/fast/forms/textarea-placeholder-wrapping-expected.txt: Removed.
  • platform/gtk/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt: Removed.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt: Removed.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt: Removed.
  • platform/gtk/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt: Removed.
  • platform/gtk/fast/forms/password-placeholder-expected.png: Removed.
  • platform/gtk/fast/forms/password-placeholder-expected.txt: Removed.
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt: Removed.
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt: Removed.
  • platform/gtk/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt: Removed.
  • platform/gtk/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt: Removed.
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt: Removed.
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt: Removed.
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt: Removed.
  • platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.txt: Removed.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/mac-leopard/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/mac-leopard/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/mac-leopard/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/mac-leopard/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/mac-leopard/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/mac-leopard/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/mac/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt: Removed.
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.txt: Removed.
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt: Removed.
  • platform/mac/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/mac/fast/forms/isindex-placeholder-expected.txt: Removed.
  • platform/mac/fast/forms/password-placeholder-expected.png: Removed.
  • platform/mac/fast/forms/password-placeholder-expected.txt: Removed.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt: Removed.
  • platform/mac/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt: Removed.
  • platform/mac/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/mac/fast/forms/placeholder-set-value-expected.txt: Removed.
  • platform/mac/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/mac/fast/forms/placeholder-stripped-expected.txt: Removed.
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt: Removed.
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt: Removed.
  • platform/mac/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/mac/fast/forms/textarea-placeholder-set-value-expected.txt: Removed.
  • platform/mac/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/mac/fast/forms/textarea-placeholder-wrapping-expected.txt: Removed.
  • platform/qt-wk2/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/qt/fast/css/pseudo-cache-stale-expected.png: Removed.
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: Removed.
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.txt: Removed.
  • platform/qt/fast/forms/input-placeholder-visibility-2-expected.png: Removed.
  • platform/qt/fast/forms/input-placeholder-visibility-2-expected.txt: Removed.
  • platform/qt/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/qt/fast/forms/isindex-placeholder-expected.txt: Removed.
  • platform/qt/fast/forms/password-placeholder-expected.png: Removed.
  • platform/qt/fast/forms/password-placeholder-expected.txt: Removed.
  • platform/qt/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/qt/fast/forms/password-placeholder-text-security-expected.txt: Removed.
  • platform/qt/fast/forms/placeholder-set-attribute-expected.png: Removed.
  • platform/qt/fast/forms/placeholder-set-attribute-expected.txt: Removed.
  • platform/qt/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/qt/fast/forms/placeholder-set-value-expected.txt: Removed.
  • platform/qt/fast/forms/placeholder-stripped-expected.png: Removed.
  • platform/qt/fast/forms/placeholder-stripped-expected.txt: Removed.
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.png: Removed.
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt: Removed.
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.png: Removed.
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt: Removed.
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt: Removed.
  • platform/qt/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/qt/fast/forms/textarea-placeholder-wrapping-expected.txt: Removed.
01:11 Changeset [101232] by kbalazs@webkit.org
  • 4 edits in trunk

Source/WebKit2: Reviewed by Simon Hausmann.

[WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::manualStreamDidFail): Don't assert that m_manualStream
is not null since it is not guaranteed but instead handle the case when it is null
with early return.

LayoutTests: [WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

Reviewed by Simon Hausmann.

Unskip the test.

  • platform/qt-wk2/Skipped:
01:02 Changeset [101231] by yurys@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: delete WebDevToolsAgent::frontendLoaded
https://bugs.webkit.org/show_bug.cgi?id=73131

Now that the method is not used in Chromium we can delete it.

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
00:53 Changeset [101230] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Update some sloppy includes.

  • public/platform/linux/WebSandboxSupport.h:
  • public/platform/win/WebThemeEngine.h:
00:19 Changeset [101229] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/Source/WebKit/chromium

More forwarding headers. Turns out I forgot to svn add them. :(

  • public/android/WebSandboxSupport.h: Added.
  • public/linux/WebFontFamily.h: Added.
  • public/linux/WebSandboxSupport.h: Added.
  • public/mac/WebSandboxSupport.h: Added.
  • public/win/WebSandboxSupport.h: Added.
00:08 Changeset [101228] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit/chromium

Add missing forwaring headers.

  • public/android/WebThemeEngine.h: Added.
  • public/linux/WebThemeEngine.h: Added.
  • public/mac/WebThemeEngine.h: Added.
  • public/win/WebThemeEngine.h: Added.

11/27/11:

23:51 Changeset [101227] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r101226.

  • DEPS:
23:28 Changeset [101226] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium revision.

  • DEPS:
23:08 Changeset [101225] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Implement vertical-align property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72926

Reviewed by Andreas Kling.

Part of the ongoing refactoring of CSSStyleSelector::applyProperty.

Covered by several tests under fast/css.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isPercent):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyVerticalAlign::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setVerticalAlignLength):
Calling setVerticalAlignLength now automatically sets verticalAlign to LENGTH.

23:06 WebKit Team edited by mihnea@adobe.com
(diff)
22:59 Changeset [101224] by abarth@webkit.org
  • 25 edits
    23 copies
    9 moves
    27 adds in trunk/Source/WebKit/chromium

[Chromium] Move the next traunch of headers into public/platform
https://bugs.webkit.org/show_bug.cgi?id=73073

Reviewed by Darin Fisher.

These headers are all the forward-declared classes in
WebKitPlatformSupport (and their dependencies) that wrap concepts in
WebCore/platform.

There are a number of forward-declared classes in WebKitPlatformSupport
that coorespond to WebCore concepts outside of WebCore/platform. I've
marked these with FIXME comments. We'll need to study them in more
detail to see whether they should move into WebCore/platform or whether
we need to move them out of WebKitPlaformSupport.h. (One possible
resolution might be to introducing a WebKitClientSupport.h to hold
statics for client concepts).

  • public/WebBlobRegistry.h: Replaced.
  • public/WebCanvas.h: Replaced.
  • public/WebClipboard.h: Replaced.
  • public/WebColor.h: Replaced.
  • public/WebColorName.h: Replaced.
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebContentLayerClient.h:
  • public/WebContextMenuData.h:
  • public/WebCookieJar.h: Replaced.
  • public/WebCursorInfo.h:
  • public/WebDragData.h: Replaced.
  • public/WebFileSystem.h: Replaced.
  • public/WebFloatQuad.h:
  • public/WebFont.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGraphicsContext3D.h: Replaced.
  • public/WebHTTPBody.h:
  • public/WebImage.h: Replaced.
  • public/WebImageDecoder.h:
  • public/WebLayer.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamDescriptor.h: Replaced.
  • public/WebMediaStreamSource.h:
  • public/WebMimeRegistry.h: Replaced.
  • public/WebNonCopyable.h: Replaced.
  • public/WebPeerConnectionHandler.h: Replaced.
  • public/WebPeerConnectionHandlerClient.h: Replaced.
  • public/WebPlugin.h:
  • public/WebPoint.h: Replaced.
  • public/WebRect.h: Replaced.
  • public/WebRegularExpression.h:
  • public/WebScreenInfo.h:
  • public/WebScrollbar.h:
  • public/WebSize.h: Replaced.
  • public/WebSocketStreamError.h: Replaced.
  • public/WebSocketStreamHandle.h: Replaced.
  • public/WebSocketStreamHandleClient.h: Replaced.
  • public/WebThread.h: Replaced.
  • public/WebTouchPoint.h:
  • public/WebURLLoader.h: Replaced.
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/android/WebSandboxSupport.h: Removed.
  • public/android/WebThemeEngine.h: Removed.
  • public/linux/WebFontFamily.h: Removed.
  • public/linux/WebSandboxSupport.h: Removed.
  • public/linux/WebThemeEngine.h: Removed.
  • public/mac/WebSandboxSupport.h: Removed.
  • public/mac/WebThemeEngine.h: Removed.
  • public/platform/WebBlobRegistry.h: Copied from Source/WebKit/chromium/public/WebBlobRegistry.h.
  • public/platform/WebCanvas.h: Copied from Source/WebKit/chromium/public/WebCanvas.h.
  • public/platform/WebClipboard.h: Copied from Source/WebKit/chromium/public/WebClipboard.h.
  • public/platform/WebColor.h: Copied from Source/WebKit/chromium/public/WebColor.h.
  • public/platform/WebColorName.h: Copied from Source/WebKit/chromium/public/WebColorName.h.
  • public/platform/WebCookieJar.h: Copied from Source/WebKit/chromium/public/WebCookieJar.h.
  • public/platform/WebDragData.h: Copied from Source/WebKit/chromium/public/WebDragData.h.
  • public/platform/WebFileSystem.h: Copied from Source/WebKit/chromium/public/WebFileSystem.h.
  • public/platform/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/WebGraphicsContext3D.h.
  • public/platform/WebImage.h: Copied from Source/WebKit/chromium/public/WebImage.h.
  • public/platform/WebKitPlatformSupport.h:
  • public/platform/WebMediaStreamDescriptor.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.
  • public/platform/WebMimeRegistry.h: Copied from Source/WebKit/chromium/public/WebMimeRegistry.h.
  • public/platform/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/WebNonCopyable.h.
  • public/platform/WebPeerConnectionHandler.h: Copied from Source/WebKit/chromium/public/WebPeerConnectionHandler.h.
  • public/platform/WebPeerConnectionHandlerClient.h: Copied from Source/WebKit/chromium/public/WebPeerConnectionHandlerClient.h.
  • public/platform/WebPoint.h: Copied from Source/WebKit/chromium/public/WebPoint.h.
  • public/platform/WebRect.h: Copied from Source/WebKit/chromium/public/WebRect.h.
  • public/platform/WebSize.h: Copied from Source/WebKit/chromium/public/WebSize.h.
  • public/platform/WebSocketStreamError.h: Copied from Source/WebKit/chromium/public/WebSocketStreamError.h.
  • public/platform/WebSocketStreamHandle.h: Copied from Source/WebKit/chromium/public/WebSocketStreamHandle.h.
  • public/platform/WebSocketStreamHandleClient.h: Copied from Source/WebKit/chromium/public/WebSocketStreamHandleClient.h.
  • public/platform/WebThread.h: Copied from Source/WebKit/chromium/public/WebThread.h.
  • public/platform/WebURLLoader.h: Copied from Source/WebKit/chromium/public/WebURLLoader.h.
  • public/platform/android: Added.
  • public/platform/android/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/android/WebSandboxSupport.h.
  • public/platform/android/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/android/WebThemeEngine.h.
  • public/platform/linux: Added.
  • public/platform/linux/WebFontFamily.h: Copied from Source/WebKit/chromium/public/linux/WebFontFamily.h.
  • public/platform/linux/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/linux/WebSandboxSupport.h.
  • public/platform/linux/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/linux/WebThemeEngine.h.

(WebKit::WebThemeEngine::paint):

  • public/platform/mac: Added.
  • public/platform/mac/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/mac/WebSandboxSupport.h.
  • public/platform/mac/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/mac/WebThemeEngine.h.

(WebKit::WebThemeEngine::paintScrollbarThumb):

  • public/platform/win: Added.
  • public/platform/win/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/win/WebSandboxSupport.h.
  • public/platform/win/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/win/WebThemeEngine.h.
  • public/win/WebSandboxSupport.h: Removed.
  • public/win/WebThemeEngine.h: Removed.
22:41 Changeset [101223] by hayato@chromium.org
  • 71 edits in trunk/LayoutTests

Chromium rebaselines for r101202.
Unreviewed, rebaselined results.

  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
22:26 Changeset [101222] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Updating the licences to the correct one.
https://bugs.webkit.org/show_bug.cgi?id=73129

Replacing the incorrect ones I have submitted with the correct ones.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-27
Reviewed by Darin Fisher.

  • bridge/PeerConnectionHandler.cpp:
  • bridge/PeerConnectionHandlerInternal.cpp:
  • bridge/PeerConnectionHandlerInternal.h:
  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMediaStreamSource.h:
  • public/WebPeerConnectionHandler.h:
  • public/WebPeerConnectionHandlerClient.h:
  • src/WebMediaStreamDescriptor.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebMediaStreamSource.cpp:
22:19 Changeset [101221] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyTextAlign in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73102

Reviewed by Andreas Kling.

Covered by fast/css/text-align*.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextAlign::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

21:46 Changeset [101220] by hayato@chromium.org
  • 1 edit
    86 adds in trunk/LayoutTests

Chromium rebaselines for r101202.

Unreviewed, rebaselined results.

  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-linux/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/border-conflict-element-002-expected.png: Added.
21:15 Changeset [101219] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

[Qt][Mac-WebKit2] file-input-reset.html is failing because of no
eventSender.beginDragWithFiles().
https://bugs.webkit.org/show_bug.cgi?id=72429
https://bugs.webkit.org/show_bug.cgi?id=72571

  • platform/mac/Skipped: Move file-input-reset.html to wk/Skipped.
  • platform/qt/Skipped: Move some entries to the section for beginDragWithFiles().
  • platform/wk2/Skipped: Move file-input-reset.html from mac/Skipped.
19:50 Changeset [101218] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSSStyleRule: Pack m_sourceLine with CSSRule bits.
<http://webkit.org/b/73168>

Reviewed by Antti Koivisto.

Make CSSStyleRule::m_sourceLine a 27-bit integer and pack it with the rest
of the members in CSSRule. This shrinks CSSStyleRule by one CPU word
and reduces memory consumption by 81 kB on the GMail inbox (on 64-bit.)

  • css/CSSRule.h:

(WebCore::CSSRule::CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):

  • css/CSSStyleRule.h:
18:11 Changeset [101217] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should not emit GetMethod node
https://bugs.webkit.org/show_bug.cgi?id=73175

Reviewed by Gavin Barraclough.

Replaces all instances of the GetMethod node with GetById. This appears to
be a slight win on V8. This patch leaves GetMethod support in the code-base,
making this decision easy to reverse, for now.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

16:12 Changeset [101216] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] MiniBrowser stops displaying content after surfing a few pages.
https://bugs.webkit.org/show_bug.cgi?id=73172

Properly initialize WebLayerTreeInfo structures.

Reviewed by Andreas Kling.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerUpdateInfo::WebLayerUpdateInfo):
(WebKit::WebLayerAnimation::WebLayerAnimation):
(WebKit::WebLayerInfo::WebLayerInfo):
(WebKit::WebLayerTreeInfo::WebLayerTreeInfo):

15:47 Changeset [101215] by mrowe@apple.com
  • 10 edits in trunk/Source

<http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in: Expose the necessary symbol.
  • platform/mac/WebCoreSystemInterface.h: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.

  • WebView/WebView.mm:

(createMacOSXVersionString): Use WKGetMacOSXVersionString.

Source/WebKit2:

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::macOSXVersionString): Use WKGetMacOSXVersionString.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.

15:44 Changeset [101214] by mrobinson@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove a test baseline that does not differ on GTK+ now that
WebGL is active by default.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
15:25 Changeset [101213] by annacc@chromium.org
  • 19 edits in trunk

Move readyState from TextTrack to HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=72553

Source/WebCore:

Fix for r101057 after it was rolled out in r101088

Reviewed by Eric Carlson.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):

Set initial readyState to NONE.

(WebCore::HTMLTrackElement::didCompleteLoad):

Set readyState based on load completed status.

(WebCore::HTMLTrackElement::setReadyState):

This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).

  • html/HTMLTrackElement.h:

ReadyState enum and m_readyState member variable moved from TextTrack.

(WebCore::HTMLTrackElement::readyState):

New: readyState() getter.

  • html/HTMLTrackElement.idl:

Add readyState attribute and associated constants.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState

to HTMLTrackElement (it can set it based on loading status).

  • html/TextTrack.cpp: Remove readyState from TextTrack.

(WebCore::TextTrack::TextTrack): Ditto.

  • html/TextTrack.h: Ditto.
  • html/TextTrack.idl: Ditto.

LayoutTests:

Fix for r101057 after it was rolled out in r101088

Reviewed by Eric Carlson.

  • media/track/track-add-track-expected.txt:
  • media/track/track-add-track.html:
  • media/track/track-constants-expected.txt:
  • media/track/track-constants.html:
  • media/track/track-load-error-readyState-expected.txt:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-load-from-src-readyState.html:
15:05 Changeset [101212] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

The test compositing/layer-creation/spanOverlapsCanvas.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73159

Reviewed by Julien Chaffraix.

The test started failing after the expected file was removed in r101203. Add the file
but specifically for Snow Leopard.

  • platform/mac-snowleopard/compositing: Added.
  • platform/mac-snowleopard/compositing/layer-creation: Added.
  • platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
13:45 Changeset [101211] by robert@webkit.org
  • 135 edits
    8 copies
    35 moves
    261 adds
    37 deletes in trunk/LayoutTests

Chromium rebaselines for r101202

Unreviewed, rebaselined results.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/border-conflict-element-002-expected.txt.
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png:
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png:
13:13 Changeset [101210] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't allow attribute changes on <track> if feature is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=73046

Reviewed by Eric Carlson.

No new tests. This fixes a problem when --enable-video-track is not used,
but the tests use this flag.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

12:52 Changeset [101209] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening after r101183.

  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Updated.
12:34 Changeset [101208] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: setCssText() mostly duplicates parseDeclaration().
<http://webkit.org/b/73171>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Let setCssText() call parseDeclaration() instead of duplicating the functionality.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setCssText):

12:29 Changeset [101207] by robert@webkit.org
  • 1 edit
    106 adds in trunk/LayoutTests

Mac, Qt and Gtk results for r101202

Unreviewed, new results.

  • platform/gtk/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/gtk/fast/css/border-conflict-element-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-022-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/mac/fast/css/border-conflict-element-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-036-expected.txt: Added.
  • platform/qt/fast/css/border-conflict-element-002-expected.txt: Added.
12:20 Changeset [101206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CSS/XSLStyleSheet: checkLoaded() needn't be virtual.
<http://webkit.org/b/73169>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Devirtualize checkLoaded() in CSSStyleSheet and XSLStyleSheet as they
are not overriding anything, nor are they ever overridden.

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
12:02 Changeset [101205] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add assertions that CSSMappedAttributeDeclarations aren't using strict parsing.
<http://webkit.org/b/73167>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

11:48 Changeset [101204] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSheet: Removed unused create() overload.
<http://webkit.org/b/73170>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antonio Gomes.

Nobody was using CSSStyleSheet::create(ownerNode, originalURL, finalURL)
so remove it.

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):

11:05 Changeset [101203] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

The test compositing/layer-creation/spanOverlapsCanvas.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73159

Reviewed by Andreas Kling.

The empty file spanOverlapsCanvas-expected.txt was created in the Chromium rebaseline r100557.

On Lion, the test spanOverlapsCanvas.html generates the expected test result, this patch removes
the empty file.

The empty directories compositing/layer-creation for Snow Leopard and Lion are also removed.

  • platform/mac-lion/compositing: Removed.
  • platform/mac-lion/compositing/layer-creation: Removed.
  • platform/mac-lion/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/mac-snowleopard/compositing: Removed.
  • platform/mac-snowleopard/compositing/layer-creation: Removed.
10:32 Changeset [101202] by robert@webkit.org
  • 74 edits
    137 adds in trunk

CSS 2.1 failure: border-conflict-element-*
https://bugs.webkit.org/show_bug.cgi?id=71244

Source/WebCore:

Reviewed by Julien Chaffraix.

From http://www.w3.org/TR/CSS21/tables.html#border-conflict-resolution :

"When two adjacent cells have the same border-width and the same border-style in a
'border-collapse: collapse' table, then the color of the border from the leftmost cell wins
(if the table's 'direction' is 'ltr'; right, if it is 'rtl') and the color of the border
from the topmost cell wins."

So WebCore::compareBorders needs to account for the position of the cell when
deciding which border wins the comparison. This will ensure that the winning border is
sorted to the appropriate position in the sorted list of borders for painting.

When conflicting collapsed borders are in the same cell, the following order of
precedence is used (where 4 has highest precedence):

3

| |

4 | | 1

|_|

2

This fixes the following failing tests from the border-conflict-element-* set
in the CSS 2.1 test suite:

border-conflict-element-001d.htm
border-conflict-element-0037.htm

One test in the suite is known to be wrong, so a corrected version has been landed outside the
css2.1 folder:

border-conflict-element-002.htm

This change entails rebaselining quite a few tests, see the LayoutTests ChangeLog for a full
explanation of the rebaselines.

  • rendering/RenderTableCell.cpp:

(WebCore::compareBorders): Compare the cells' position from the left (in 'ltr') and right (in 'rtl')

of the table and the cells' position from the top of the table when nothing
else in the style, width, or grouping of the borders determines precedence.
If the conflicting borders are in the same cell, apply the same logic to the position of the borders.

(WebCore::RenderTableCell::collapsedStartBorder): Pass the cell's position and its table's direction to CollapsedBorderValue
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::collapsedAfterBorder): ditto

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue): Learn the position of the border's cell and the direction of its table
(WebCore::CollapsedBorderValue::columnOffset): the cell's offset from the top of the table
(WebCore::CollapsedBorderValue::rowOffset): the cell's offset from the start of the table
(WebCore::CollapsedBorderValue::edge): which edge of the cell the border is on
(WebCore::CollapsedBorderValue::operator==): cells with the same position in the table are equal

LayoutTests:

Add all the passing border-conflict-element* tests from the CSS 2.1 test suite.

Add a corrected version of the CSS suite test border-conflict-element-002.htm, which can sit here until

the corrected version is landed upstream. See http://lists.w3.org/Archives/Public/public-css-testsuite/2011Nov/0002.html

Rebaseline all t170602-bdr-conflct-w-* tests. The rendering of the collapsed borders in these

tests now obeys the order of precedence for the position of the cell and the precendece of the position
of the borders within the same cell.

Rebaseline tables/mozilla/collapsing_borders/bug41262-4.html: ditto

tables/mozilla/marvin/table_rules_all.html : ditto
tables/mozilla/marvin/table_rules_none.html : ditto
tables/mozilla_expected_failures/marvin/table_rules_cols.html : ditto
tables/mozilla_expected_failures/marvin/table_rules_rows.html : ditto

Rebaseline two border-conflict-style-* tests: ditto

Rebaseline fast/borders/border-antialiasing.html, the result is too small to confirm the difference but

presume it is one of the above.

Reviewed by Julien Chaffraix.

  • css2.1/20110323/border-conflict-element-001.htm: Added.
  • css2.1/20110323/border-conflict-element-001a.htm: Added.
  • css2.1/20110323/border-conflict-element-001b.htm: Added.
  • css2.1/20110323/border-conflict-element-001c.htm: Added.
  • css2.1/20110323/border-conflict-element-001d.htm: Added.
  • css2.1/20110323/border-conflict-element-003.htm: Added.
  • css2.1/20110323/border-conflict-element-004.htm: Added.
  • css2.1/20110323/border-conflict-element-005.htm: Added.
  • css2.1/20110323/border-conflict-element-006.htm: Added.
  • css2.1/20110323/border-conflict-element-007.htm: Added.
  • css2.1/20110323/border-conflict-element-008.htm: Added.
  • css2.1/20110323/border-conflict-element-009.htm: Added.
  • css2.1/20110323/border-conflict-element-010.htm: Added.
  • css2.1/20110323/border-conflict-element-011.htm: Added.
  • css2.1/20110323/border-conflict-element-012.htm: Added.
  • css2.1/20110323/border-conflict-element-013.htm: Added.
  • css2.1/20110323/border-conflict-element-014.htm: Added.
  • css2.1/20110323/border-conflict-element-015.htm: Added.
  • css2.1/20110323/border-conflict-element-016.htm: Added.
  • css2.1/20110323/border-conflict-element-017.htm: Added.
  • css2.1/20110323/border-conflict-element-018.htm: Added.
  • css2.1/20110323/border-conflict-element-019.htm: Added.
  • css2.1/20110323/border-conflict-element-020.htm: Added.
  • css2.1/20110323/border-conflict-element-021.htm: Added.
  • css2.1/20110323/border-conflict-element-022.htm: Added.
  • css2.1/20110323/border-conflict-element-023.htm: Added.
  • css2.1/20110323/border-conflict-element-024.htm: Added.
  • css2.1/20110323/border-conflict-element-025.htm: Added.
  • css2.1/20110323/border-conflict-element-026.htm: Added.
  • css2.1/20110323/border-conflict-element-027.htm: Added.
  • css2.1/20110323/border-conflict-element-028.htm: Added.
  • css2.1/20110323/border-conflict-element-029.htm: Added.
  • css2.1/20110323/border-conflict-element-030.htm: Added.
  • css2.1/20110323/border-conflict-element-031.htm: Added.
  • css2.1/20110323/border-conflict-element-032.htm: Added.
  • css2.1/20110323/border-conflict-element-033.htm: Added.
  • css2.1/20110323/border-conflict-element-034.htm: Added.
  • css2.1/20110323/border-conflict-element-035.htm: Added.
  • css2.1/20110323/border-conflict-element-036.htm: Added.
  • css2.1/20110323/border-conflict-element-037.htm: Added.
  • css2.1/20110323/border-conflict-element-038.htm: Added.
  • css2.1/20110323/border-conflict-element-039.htm: Added.
  • css2.1/20110323/support/swatch-blue.png: Added.
  • css2.1/20110323/support/swatch-green.png: Added.
  • css2.1/20110323/support/swatch-lime.png: Added.
  • css2.1/20110323/support/swatch-orange.png: Added.
  • css2.1/20110323/support/swatch-red.png: Added.
  • css2.1/20110323/support/swatch-teal.png: Added.
  • css2.1/20110323/support/swatch-white.png: Added.
  • css2.1/20110323/support/swatch-yellow.png: Added.
  • fast/css/border-conflict-element-002.htm: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Addition of support/swatch-white.png rebaselines result.
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.txt: Added.
07:54 Changeset [101201] by pfeldman@chromium.org
  • 42 edits in trunk/Source

Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127

Source/WebCore:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromWorker):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::closeInspectorFrontend):

Source/WebKit/chromium:

We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::closeInspectorFrontend):

  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/gtk:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

Source/WebKit/qt:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
05:30 Changeset [101200] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

REGRESSION(r97881): It broke fast/dom/error-to-string-stack-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=70476

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2011-11-27
Reviewed by Andreas Kling.

Removing obsolete qt-specific expected file as the base one is enough.

  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.

11/26/11:

19:05 Changeset [101199] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fixes for Windows.

17:26 Changeset [101198] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Needs WTF_INLINE and JS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=72853

Patch by Hajime Morrita <morrita@chromium.org> on 2011-11-26
Reviewed by Kevin Ollivier.

Added WTF_HIDDEN, WTF_INLINE and JS_INLINE which
indirect attribute((visibility("hidden"))

  • config.h:
  • wtf/ExportMacros.h:
11:31 Changeset [101197] by alex@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-11-26 Alejandro G. Castro <alex@igalia.com>

Fix compilation after r101157.

Reviewed by Martin Robinson.

  • bindings/scripts/preprocessor.pm: (applyPreprocessor): In case we have a string with double-quotations (") we replace it with the empty string.
10:00 Changeset [101196] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

[TexMapper][WK2][Qt] Simple opacity animations are not working
https://bugs.webkit.org/show_bug.cgi?id=73157

LayerTreeHostQt needs to know what nodes in the TextureMapper are visible, to associate
a tile to it. It is done using TextureMapperNode::collectVisibleContentsRects.

However TextureMapperNode::collectVisibleContentsRects has an optimization to check if
the current tile has opacity greater than 0.01, otherwise it will not create a tile for
the current node.

For opacity animations from 0 to 1, it is a problem because the tile is never created
and the animation never happens.

This patch fixes opacity animations.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::countDescendantsWithContent):
(WebCore::TextureMapperNode::collectVisibleContentsRects):

08:09 Changeset [101195] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebKit2

[Qt] [WK2] QtDownloadManager doesn't need to be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=73151

Reviewed by Kenneth Rohde Christiansen.

QtDownloadManager is owned by QtWebContext, and doesn't need to be a RefCounted
class. This commit also makes the callback handlers private -- following the similar
approach we take in other clients of the C API.

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::QtDownloadManager::QtDownloadManager):
(WebKit::QtDownloadManager::addDownload):
(WebKit::toQtDownloadManager):
(WebKit::QtDownloadManager::didReceiveResponse):
(WebKit::QtDownloadManager::didCreateDestination):
(WebKit::QtDownloadManager::didFinishDownload): remove unused failingUrl local variable.
(WebKit::QtDownloadManager::didFailDownload):
(WebKit::QtDownloadManager::didReceiveDataForDownload):

  • UIProcess/qt/QtDownloadManager.h:
  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:
07:51 Changeset [101194] by commit-queue@webkit.org
  • 45 edits in trunk/Source

Unreviewed, rolling out r101193.
http://trac.webkit.org/changeset/101193
https://bugs.webkit.org/show_bug.cgi?id=73158

Breaks Windows and Qt minimal. (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-26

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::disconnectFromBackend):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):

  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromBackend):

  • loader/EmptyClients.h:

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::disconnectFromBackend):

  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorFrontendClient::disconnectFromBackend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorFrontendClientQt::disconnectFromBackend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorFrontendClient::disconnectFromBackend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

  • WebCoreSupport/InspectorClientWinCE.cpp:
  • WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/InspectorClientWx.cpp:
  • WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::disconnectFromBackend):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
07:30 Changeset [101193] by pfeldman@chromium.org
  • 42 edits in trunk/Source

Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127

Source/WebCore:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromWorker):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::closeInspectorFrontend):

Source/WebKit/chromium:

We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::closeInspectorFrontend):

  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/gtk:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

Source/WebKit/qt:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
04:48 Changeset [101192] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a bug in TreeOutline which would cause parent elements to show up as expanded and empty
when removed and added back to the tree.

https://bugs.webkit.org/show_bug.cgi?id=73155

Reviewed by Pavel Feldman.

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.collapse): Set _treeElementsExpandedState to false instead of true.
Only TreeElement.prototype.expand should set it to true, which it does.

02:47 Changeset [101191] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[CMake] Clean up Web Inspector target in Source/WebKit/blackberry/CMakeListsBlackBerry.txt
https://bugs.webkit.org/show_bug.cgi?id=72784

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2011-11-26
Reviewed by Nikolas Zimmermann.

Abstracted the JavaScript file names from inspector/front-end/inspector.html
to keep them in-sync with the changes of inspector.html.

  • blackberry/CMakeListsBlackBerry.txt:
02:16 Changeset [101190] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Fix some warnings in WebCore GTK+
https://bugs.webkit.org/show_bug.cgi?id=73137

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-26
Reviewed by Philippe Normand.

No new tests. This patch just fixes compilation warnings.

  • platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor): Remove unused variable.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::paintSliderTrack): ASSERT_UNUSED instead of ASSERT.

  • platform/gtk/SharedTimerGtk.cpp: Ditto.

(WebCore::stopSharedTimer):

00:59 Changeset [101189] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Try to fix the build after r101174.

  • gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.

11/25/11:

23:17 Changeset [101188] by caio.oliveira@openbossa.org
  • 5 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[Qt] [WK2] Remove WebContext related code from QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73150

Reviewed by Kenneth Rohde Christiansen.

Creates a QtWebContext class that abstracts away from QtWebPageProxy the
handling of creating / maintaining the default WebContext, as well as the
code for the WKContextRef clients.

Another motivation for having this entity is to have a proper place to add
objects are bound to the context, like the QtDownloadManager.

  • Target.pri:
  • UIProcess/qt/ClientImpl.cpp: Removed.
  • UIProcess/qt/ClientImpl.h: Removed.
  • UIProcess/qt/QtDownloadManager.cpp:
  • UIProcess/qt/QtWebContext.cpp: Added.

(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
(WebKit::QtWebContext::createWebPage):
(WebKit::QtWebContext::setNavigatorQtObjectEnabled):
(WebKit::QtWebContext::postMessageToNavigatorQtObject):
(WebKit::QtWebContext::initialize):
(WebKit::QtWebContext::initializeContextInjectedBundleClient):
(WebKit::toQtWebContext):
(WebKit::QtWebContext::didReceiveMessageFromInjectedBundle):

  • UIProcess/qt/QtWebContext.h: Added.

(WebKit::QtWebContext::downloadManager):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::setNavigatorQtObjectEnabled):
(QtWebPageProxy::postMessageToNavigatorQtObject):
(QtWebPageProxy::handleDownloadRequest):

  • UIProcess/qt/QtWebPageProxy.h:
22:15 Changeset [101187] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String.prototype.toLower should be optimized for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=73154

Changed stringProtoFuncToLowerCase to use StringImpl::lower() which has
been optimized for 8 bit strings.

This is worth ~7% to sunspider string.tagcloud.

Reviewed by Filip Pizlo.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):

22:01 Changeset [101186] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array.toString always uses StringImpl::characters()
https://bugs.webkit.org/show_bug.cgi?id=72969

If all component strings are 8 bit, create an 8 bit result string for toString().

This appears to be performance neutral to sunspider and v8.

Reviewed by Filip Pizlo.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

20:28 Changeset [101185] by eric.carlson@apple.com
  • 11 edits
    2 adds
    2 deletes in trunk

Implement addCue and removeCue in TextTrack
https://bugs.webkit.org/show_bug.cgi?id=72554

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-add-remove-cue.html

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack): Go ahead and allocate a Track even if the feature

is disabled, it just won't load anything.

(WebCore::HTMLTrackElement::scheduleLoad): Early return if the featue is disabled.
(WebCore::HTMLTrackElement::canLoadUrl): Ditto.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable): Add new cues one at a time because

cues->add(Vector<TextTrackCue*>&) is gone.

  • html/TextTrack.cpp:

(WebCore::TextTrack::addCue): Implement.
(WebCore::TextTrack::removeCue): Ditto.

  • html/TextTrack.h:

(WebCore::TextTrackCue::TextTrackCue): Initialize every member variable.
(WebCore::TextTrackCue::track): m_track is now a RefPtr.
(WebCore::TextTrackCue::setTrack): Ditto.

  • html/TextTrackCue.h:
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Don't ignore out of order cues, the spec text is not

a conformance requirement. Return bool to indicate success or failure.

(WebCore::TextTrackCueList::remove): Return bool to indicate success or failure.

  • html/TextTrackCueList.h:
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::notifyFinished): Don't change m_state once it is set to Failed.

LayoutTests:

  • media/track/track-add-remove-cue-expected.txt: Added.
  • media/track/track-add-remove-cue.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
  • media/track/track-webvtt-tc012-out-of-order.html: Removed.
16:34 Changeset [101184] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring CodeGenerator*.pm for bug 72138
https://bugs.webkit.org/show_bug.cgi?id=73115

Reviewed by Adam Barth.

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.

(GenerateHeaderCustomCall):

  • bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
15:34 Changeset [101183] by haraken@chromium.org
  • 6 edits
    2 adds in trunk

Implement the WebGLContextEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=72856

Reviewed by Adam Barth.

Source/WebCore:

This patch makes WebGLContextEvent constructable.
The spec: http://www.khronos.org/registry/webgl/specs/latest/#5.14

Test: fast/events/constructors/webgl-context-event-constructor.html

  • html/canvas/WebGLContextEvent.cpp: Added an implementation of the WebGLContextEvent constructor.

(WebCore::WebGLContextEventInit::WebGLContextEventInit):
(WebCore::WebGLContextEvent::WebGLContextEvent):

  • html/canvas/WebGLContextEvent.h: Added a definition of WebGLContextEventInit.

(WebCore::WebGLContextEvent::create):

  • html/canvas/WebGLContextEvent.idl: Added [ConstructorTemplate=Event] IDL.

LayoutTests:

webgl-context-event-constructor.html checks the behavior of the WebGLContextEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added window.WebGLContextEvent.
  • fast/events/constructors/webgl-context-event-constructor-expected.txt: Added.
  • fast/events/constructors/webgl-context-event-constructor.html: Added.
14:59 Changeset [101182] by rniwa@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

Add missing results for Mac after r100949 and r100036.
svg/repaint/filter-child-repaint.svg is failing. The failure is tracked by the bug 73146.

  • platform/mac/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/mac/media/controls-without-preload-expected.png: Added.
  • platform/mac/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/mac/svg/repaint/filter-child-repaint-expected.txt: Added.
13:52 Changeset [101181] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Chromium] The DrawingBuffer::bind method was incorrectly resetting the
GL viewport parameters. This was unnecessary, and resulted in the corruption
of the WebGL context's state.
https://bugs.webkit.org/show_bug.cgi?id=73091

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-25
Reviewed by Stephen White.

Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html

Source/WebCore:

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::bind):

LayoutTests:

  • fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt: Added.
  • fast/canvas/webgl/webgl-viewport-parameters-preserved.html: Added.
12:21 Changeset [101180] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in BidiRunList<Run>::replaceRunWithRuns with an empty bdi element
https://bugs.webkit.org/show_bug.cgi?id=73116

Reviewed by Eric Seidel.

Source/WebCore:

The assertion failure was caused because isolatedResolver is initialized with
null start object due to the isolated run being empty.

Fixed the failure by skipping empty isolated runs.

Test: fast/text/empty-bdi-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRuns):

LayoutTests:

Added a regression test.

  • fast/text/empty-bdi-crash-expected.txt: Added.
  • fast/text/empty-bdi-crash.html: Added.
11:57 Changeset [101179] by jesus@webkit.org
  • 11 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
https://bugs.webkit.org/show_bug.cgi?id=73096

Reviewed by Kenneth Rohde Christiansen.

Move all the interaction engine usage to QtWebPageEventHandler,
making all GestureRecognizers (Tap, Pinch and Pan) use it directly.

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::setViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler::interactionEngine):

11:26 Changeset [101178] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove unneeded declaration from QQuickWebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=73141

Reviewed by Antonio Gomes.

Left-over from r101165.

  • UIProcess/API/qt/qquickwebpage_p_p.h:
10:08 Changeset [101177] by antti@apple.com
  • 10 edits in trunk/Source/WebCore

StyleGeneratedImage should ref CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=73074

Reviewed by Andreas Kling and Nikolas Zimmermann.

RenderStyle owns a bunch of StyleImage objects. However StyleGeneratedImage does not ref the
CSSImageGeneratorValue it holds so we currently rely on the stylesheet to keep the CSSImageGeneratorValues
alive as long as RenderStyle stays alive. While this works (RenderStyles are thrown away if stylesheets
change) it is not particularly robust or nice.

  • Use RefPtr<CSSImageGeneratorValue> in StyleGeneratedImage
  • Remove the RefPtr<StyleGeneratedImage> from CSSImageGeneratorValue. There is no good reason to cache StyleGeneratedImage as it is a small and uncommon object. With that the whole back-reference becomes unnecessary.
  • Switch more places to use (Pass)RefPtr<StyleImage> for consistency.
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSStyleApplyProperty.cpp:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::cachedOrPendingFromValue):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):

  • css/CSSStyleSelector.h:
  • rendering/style/FillLayer.h:

(WebCore::FillLayer::setImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::StyleGeneratedImage):
(WebCore::StyleGeneratedImage::cssValue):
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):

  • rendering/style/StyleGeneratedImage.h:

(WebCore::StyleGeneratedImage::create):
(WebCore::StyleGeneratedImage::data):

09:47 Changeset [101176] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: assertion failure in InspectorController::restoreInspectorStateFromCookie
https://bugs.webkit.org/show_bug.cgi?id=73136

Don't call connectFrontend twice on reattach.

Reviewed by Pavel Feldman.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::reattach):

08:46 Changeset [101175] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
<http://webkit.org/b/73134>

Reviewed by Antti Koivisto.

CSSMappedAttributeDeclarations always use non-strict parsing since they use
the argument-less CSSMutableStyleDeclaration constructor.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

08:19 Changeset [101174] by mrobinson@webkit.org
  • 10 edits
    1 move
    3 adds
    4 deletes in trunk

[GTK] Integrate build-gtkdoc into build-webkit and make
https://bugs.webkit.org/show_bug.cgi?id=72626

Reviewed by Philippe Normand.

.:

  • GNUmakefile.am: Remove references to old gtkdoc files. Update

the dist-hook to include copying documentation into the distribution.
This also means that the build will fail if documentation hasn't been
generated before 'make dist.'

  • configure.ac: Ditto.

Source/WebKit/gtk:

  • docs/GNUmakefile.am: Removed.
  • docs/version.xml.in: Removed.

Source/WebKit2:

  • GNUmakefile.am: Removed references to build-gtkdoc and gtkdoc.py.
  • UIProcess/API/gtk/docs/build-gtkdoc: Removed.

Tools:

  • GNUmakefile.am: Added support for new scripts and "make docs".
  • Scripts/webkitdirs.pm: Call generate-gtkdoc when building.

(buildAutotoolsProject):

  • gtk/generate-gtkdoc: Added.
  • gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
07:14 Changeset [101173] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark inspector/elements/remove-node.html test as crashing sometimes on Linux.

  • platform/chromium/test_expectations.txt:
07:00 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the bots (diff)
06:58 BuildingQt5OnHarmattan edited by ossy@webkit.org
Update Qt5 revision (diff)
06:44 Changeset [101172] by andreas.kling@nokia.com
  • 16 edits
    1 add in trunk/Source/WebCore

Factor element pointer out of CSSMutableStyleDeclaration.
<http://webkit.org/b/73121>

Reviewed by Antti Koivisto.

Move the StyledElement pointer out of CSSMutableStyleDeclaration and into a subclass
for the cases where it's needed. This reduces the size of vanilla style declarations
by one CPU word (4 or 8 bytes, depending on architecture.)

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::element):
(WebCore::CSSElementStyleDeclaration::setElement):
(WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):
(WebCore::CSSElementStyleDeclaration::~CSSElementStyleDeclaration):

Added CSSElementStyleDeclaration, a common parent class for inline styles
and mapped attributes. It extends CSSMutableStyleDeclaration by adding a backpointer
to the StyledElement that owns it.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSInlineStyleDeclaration.h: Added.

(WebCore::CSSInlineStyleDeclaration::~CSSInlineStyleDeclaration):
(WebCore::CSSInlineStyleDeclaration::create):
(WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):

Added CSSInlineStyleDeclaration.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Only follow the associated element on CSSElementStyleDeclarations.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):

Remove comment about m_element since the field was moved to a subclass.

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::isElementStyleDeclaration):
(WebCore::CSSStyleDeclaration::isInlineStyleDeclaration):

We no longer need to track whether a style declaration is mutable or not,
so the constructors are slightly simplified.
Added two bits (isElementStyleDeclaration and isInlineStyleDeclaration) for
runtime type checking. These are protected and set by the CSSElementStyleDeclaration
constructor.

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::create):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

Remove pointless CSSRule* argument to constructor since we always passed 0.

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::getInlineStyleDecl):
(WebCore::StyledElement::addSubresourceAttributeURLs):

Make the inline style on StyledElement a CSSInlineStyleDeclaration.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

Slightly simplified by having CSSInlineStyleDeclaration.

06:35 Changeset [101171] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
https://bugs.webkit.org/show_bug.cgi?id=73132

Reviewed by Simon Hausmann.

Make sure QWebDownloadItem is registered in the right plugin.

  • declarative/experimental/plugin.cpp:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

06:32 Changeset [101170] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: unflake timeline-network tests
https://bugs.webkit.org/show_bug.cgi?id=73123

Source/WebCore:

We should capture stack only when it makes sense. Otherwise loading from cache
results in different data sets (stacks) than regular load.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
  • platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
06:19 Changeset [101169] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Add support for using OWRT with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947

Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2011-11-25
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
06:17 Changeset [101168] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix.

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded): dowsntream implementation with OVERRIDE modifier fails to compile without this stub.
05:56 WebKit Team edited by achicu@adobe.com
(diff)
05:53 Changeset [101167] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Clean up code in WK2/ChromeClientClient related to viewport handling
https://bugs.webkit.org/show_bug.cgi?id=73128

Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

Make sure that we only call resizeToContentsIfNeeded when we are
using the tiled backing store and fixed layout as well.

Guard the scrollbar code so that it is only called when scroll
delegation is not used. Do similarily for the frameset code,
which makes no sense with frame flattening.

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

This method is only called for the main frame, so the main frame
check has been removed.

05:39 Changeset [101166] by yurys@chromium.org
  • 12 edits in trunk

[Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
https://bugs.webkit.org/show_bug.cgi?id=73126

Source/WebCore:

Notify embedder that front-end is loadded only when all dispatchers, panels and models
have been created so that it could dispatch messages synchronously in the loaded handler.

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.

Reviewed by Pavel Feldman.

  • public/WebDevToolsFrontendClient.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::frontendLoaded):

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):
(WebKit::WebDevToolsFrontendImpl::doDispatchOnInspectorFrontend):

  • src/WebDevToolsFrontendImpl.h:

Tools:

No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.

Reviewed by Pavel Feldman.

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
04:54 Changeset [101165] by hausmann@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Eliminate warnings about the deprecated QQuickCanvas::sceneGraphEngine() function.

Reviewed by Andreas Kling.

We use the function in question to find out if we can connect to the scene graph's
afterRendering signal. The signal has been moved into QQuickCanvas right away, so
we can connect to it as soon as we have a canvas.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::initializeSceneGraphConnections):

  • UIProcess/API/qt/qquickwebpage_p.h:
04:48 Changeset [101164] by jesus@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Move event handling out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73089

Reviewed by Kenneth Rohde Christiansen.

Move all logic related to event handling, gestures and the
interaction engine out of QtWebPageProxy, creating a separate
class called QtWebPageEventHandler. This handler will be created
by the QQuickWebViewPrivate and will be registered into QtWebPageProxy.
QQuickWebPage will now call handleEvent through this entity.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::event):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp: Added.

(QtWebPageEventHandler::dragOperationToDropAction):
(QtWebPageEventHandler::dragOperationToDropActions):
(QtWebPageEventHandler::dropActionToDragOperation):
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleMouseDoubleClickEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::timerEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::setViewportInteractionEngine):
(QtWebPageEventHandler::touchEvent):
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):
(QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::didFindZoomableArea):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::eventHandler):

04:12 Changeset [101163] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't send Console.messagesCleared on front-end connection if console agent is not enabled
https://bugs.webkit.org/show_bug.cgi?id=73122

Console agent should stay silent if it is not enabled.

Reviewed by Pavel Feldman.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

03:39 Changeset [101162] by hausmann@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit2

[Qt] Cleanup in QML tests.

Reviewed by Tor Arne Vestbø.

Use a simple QML component for the "DesktopWebView" instead of a new QML type.
This will allow the use of the experimental extension in the future.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

02:57 Changeset [101161] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

Upstream the QNX/RIM specific HistoryItemViewState
https://bugs.webkit.org/show_bug.cgi?id=73114

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-11-25
Reviewed by Daniel Bates.

This patch is to upstream RIM/QNX specific HistoryItemViewState extension
to store some extra view state.

No new tests. It's not built yet.

  • history/blackberry: Added.
  • history/blackberry/HistoryItemViewState.h: Added.

(WebCore::HistoryItemViewState::HistoryItemViewState):

02:33 Changeset [101160] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Split scripts panel top status bar into debug toolbar and editor toolbar.
https://bugs.webkit.org/show_bug.cgi?id=73087

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):

  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar):
(#scripts-editor-toolbar):
(#scripts-debug-sidebar-resizer-widget):
(.script-view):

02:06 Changeset [101159] by leo.yang@torchmobile.com.cn
  • 1 edit
    3 adds in trunk/Source/WebCore

Upstream BlackBerry porting of platform/text
https://bugs.webkit.org/show_bug.cgi?id=73117

Reviewed by Daniel Bates.

Initial upstream, can't be built yet, no test cases.

  • platform/text/blackberry/StringBlackBerry.cpp: Added.

(WTF::String::String):
(WTF::String::operator WebString):

  • platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp: Added.

(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):

01:41 Changeset [101158] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Yury Semikhatsky.

  • platform/chromium/test_expectations.txt:
01:31 Changeset [101157] by haraken@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove WebCore.gyp/scripts/rule_binding.py
https://bugs.webkit.org/show_bug.cgi?id=73109

Reviewed by Adam Barth.

rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper
of generate-bindings.pl and thus we can remove it.

No new tests. No change in behavior.

  • WebCore.gyp/WebCore.gyp: Replaces rule_binding.py with generate-bindings.pl.
  • WebCore.gyp/scripts/rule_binding.py: Removed.
  • bindings/scripts/preprocessor.pm: When '"ENABLE_SOMETHING=1" "ENABLE_OTHERS=0"' is passed as a define macro, the string is passed to our perl scripts without the double-quotations (") omitted. We need to omit the double quatations here.

(applyPreprocessor):

01:29 Changeset [101156] by yurys@chromium.org
  • 15 edits
    4 deletes in trunk

[Chromium] Web Inspector: remove legacy debugger support
https://bugs.webkit.org/show_bug.cgi?id=73081

Removed classed providing access to V8 debugging protocol. Clients should
use Web Inspector protocol instead.

Reviewed by Pavel Feldman.

Source/WebCore:

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/PageScriptDebugServer.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp: Removed.
  • src/DebuggerAgentImpl.h: Removed.
  • src/DebuggerAgentManager.cpp: Removed.
  • src/DebuggerAgentManager.h: Removed.
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::detach):
(WebKit::WebDevToolsAgentImpl::didNavigate):
(WebKit::WebDevToolsAgentImpl::didClearWindowObject):

  • src/WebDevToolsAgentImpl.h:
01:25 Changeset [101155] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium deps revision to 111575

  • DEPS:
01:23 Changeset [101154] by pfeldman@chromium.org
  • 26 edits in trunk

Web Inspector: refactor resource tree model and introduce explicit class for ResourceTreeFrame.
https://bugs.webkit.org/show_bug.cgi?id=73078

Otherwise we are managing frames and their resources using too many maps.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::restore):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._mainFrameNavigated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._fetchResourceTree):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype.frameForId):
(WebInspector.ResourceTreeModel.prototype.forAllResources):
(WebInspector.ResourceTreeModel.prototype.resourceForURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get id):
(WebInspector.ResourceTreeFrame.prototype.get name):
(WebInspector.ResourceTreeFrame.prototype.get url):
(WebInspector.ResourceTreeFrame.prototype.get loaderId):
(WebInspector.ResourceTreeFrame.prototype.get parentFrame):
(WebInspector.ResourceTreeFrame.prototype.get childFrames):
(WebInspector.ResourceTreeFrame.prototype.isMainFrame):
(WebInspector.ResourceTreeFrame.prototype.navigate):
(WebInspector.ResourceTreeFrame.prototype.get mainResource):
(WebInspector.ResourceTreeFrame.prototype.addChildFrame):
(WebInspector.ResourceTreeFrame.prototype.removeChildFrame):
(WebInspector.ResourceTreeFrame.prototype._addResource):
(WebInspector.ResourceTreeFrame.prototype.resources):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL.filter):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL):
(WebInspector.ResourceTreeFrame.prototype._callForFrameResources):
(WebInspector.PageDispatcher.prototype.frameNavigated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._resetWithFrames):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._frameDetached):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.formatContent):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resource-tree/resource-tree-document-url.html:
  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html:
  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap.collect):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterCachedResourcesProcessed):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources.visit):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):

  • inspector/debugger/source-frame.html:
  • inspector/styles/css-live-edit.html:
  • inspector/styles/styles-history.html:
  • platform/qt/Skipped:

11/24/11:

23:10 Changeset [101153] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Initialize global variables during IDLParser object creation
https://bugs.webkit.org/show_bug.cgi?id=73108

Reviewed by Adam Barth.

Currently, IDLParser.pm initializes global variables in a global scope,
which means that the global variables are initialized just once at the beginning.
On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change
on generate-bindings.pl that initializes the global variables whenever a new IDLParser
object is created. Thus, this patch initializes the global variables during
the IDLParser object creation.

No new tests. No change in behavior.

  • bindings/scripts/IDLParser.pm:

(InitializeGlobalData):
(new):

22:55 Changeset [101152] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

UString methods are not character size aware
https://bugs.webkit.org/show_bug.cgi?id=72975

Changed the UString number constructors to build 8 bit strings.
Modified the other methods to check string bitness and process
with 8 bits wherre appropriate.

  • runtime/UString.cpp:

(JSC::UString::number):
(JSC::operator==):
(JSC::operator<):
(JSC::UString::ascii):

22:47 Changeset [101151] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JavaScript string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974

Change the various JS to number routines to process strings
using characters8() or characters16() as appropriate.
Implemented using static template methods.

Reviewed by Filip Pizlo.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::isInfinity):
(JSC::jsHexIntegerLiteral):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):

22:44 Changeset [101150] by haraken@chromium.org
  • 2 edits in trunk/Tools

Replace subprocess.call() with subprocess.Popen()
https://bugs.webkit.org/show_bug.cgi?id=73105

Reviewed by Adam Barth.

Currently, the stdout and stderr of the child processes of run-bindings-tests
are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
between a parent process and a child process. This patch replaces subprocess.call() with
subprocess.Popen() and synchronizes the stdout and stderr between them.
This patch also makes output messages of run-bindings-tests more readable.

With this patch, the output messages of run-bindings-tests look like as follows:

PASS: (CPP) WebDOMTestObj.h
PASS: (CPP) WebDOMTestObj.cpp
FAIL: (CPP) WebDOMTestInterface.h
--- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900
+++ /tmp/tmpDAV87G/WebDOMTestInterface.h 2011-11-25 13:44:42.712946812 +0900
@@ -23,7 +23,7 @@

#ifndef WebDOMTestInterface_h
#define WebDOMTestInterface_h

-#if ENABLE(Condition1) +#if ENABLE(Condition1)
ENABLE(Condition2)
ENABLE(Condition3)

#include <WebDOMObject.h>
#include <WebDOMString.h>
@@ -53,5 +53,5 @@
WebDOMTestInterface toWebKit(WebCore::TestInterface*);

#endif

-#endif ENABLE(Condition1) +#endif ENABLE(Condition1)
ENABLE(Condition2)
ENABLE(Condition3)

PASS: (CPP) WebDOMFloat64Array.cpp
PASS: (CPP) WebDOMFloat64Array.h

Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")

  • Scripts/run-bindings-tests:

(generate_from_idl):
(detect_changes):
(run_tests):
(main):

22:36 Changeset [101149] by haraken@chromium.org
  • 2 edits in trunk/Tools

Fix the current working directory of run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73106

Reviewed by Adam Barth.

Currently, run-bindings-tests outputs the following error
(although it outputs "all tests passed!" in the end):

Testing the ObjC generator on TestObj.idl
gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
gcc: warning: '-x objective-c' after last input file has no effect
gcc: no input files

This is because CodeGeneratorObjC.pm assumes that the current working directory
is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
Thus, this patch changes it to WebKit/Source/.

  • Scripts/run-bindings-tests:

(generate_from_idl):
(main):

22:35 Changeset [101148] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968

Clear m_is8Bit flag for empty strings.

Reviewed by Filip Pizlo.

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):

22:23 Changeset [101147] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683

Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
and building continues with a 16 bit buffer.

Reviewed by Filip Pizlo.

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::upConvert):
(JSC::JSStringBuilder::build):

  • runtime/UString.h:

(JSC::UString::adopt):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::adopt):

15:23 Changeset [101146] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] Build fix for NOT ENABLE_WEB_SOCKETS.

  • CMakeLists.txt: Move CloseEvent.idl to the unconditional files.
15:16 Changeset [101145] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for C++ bindings.

  • bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards.
12:03 Changeset [101144] by commit-queue@webkit.org
  • 23 edits
    23 adds in trunk

Microdata: Support for properties attribute.
https://bugs.webkit.org/show_bug.cgi?id=71050

Patch by Arko Saha <arko@motorola.com> on 2011-11-24
Reviewed by Adam Barth.

Source/WebCore:

The properties attribute returns an HTMLPropertiesCollection object with all the element's
properties. Otherwise, an empty HTMLPropertiesCollection object.

Tests: fast/dom/MicroData/itemref-refers-first-element-with-given-id.html

fast/dom/MicroData/names-property-must-be-correct.html
fast/dom/MicroData/names-property-test.html
fast/dom/MicroData/properties-collection-add-remove-itemref.html
fast/dom/MicroData/properties-collection-add-remove-property.html
fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html
fast/dom/MicroData/properties-collection-must-be-correct.html
fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html
fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html
fast/dom/MicroData/properties-collection-test.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • dom/MicroDataItemList.cpp:
  • dom/Node.cpp:

(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):
(WebCore::Node::properties):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeRareData::itemProp):
(WebCore::NodeRareData::setItemProp):
(WebCore::NodeRareData::itemRef):
(WebCore::NodeRareData::setItemRef):
(WebCore::NodeRareData::itemType):
(WebCore::NodeRareData::setItemType):
(WebCore::NodeRareData::properties):

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::itemAfter):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setItemValueText):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLPropertiesCollection.cpp: Added.

(WebCore::compareTreeOrder):
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::~HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::findPropetiesOfAnItem): Finds the properties of an item.
(WebCore::HTMLPropertiesCollection::length): Returns the number of elements in the properties collection.
(WebCore::HTMLPropertiesCollection::item): Returns the element with index 'index' from the collection. The items are sorted in tree order.
(WebCore::HTMLPropertiesCollection::names): Returns a DOMStringList with the property names of the elements in the collection with the order preserved but with duplicates removed.

  • html/HTMLPropertiesCollection.h: Added.
  • html/HTMLPropertiesCollection.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Added test for html properties collections.

  • fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Added.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Added.
  • fast/dom/MicroData/names-property-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/names-property-must-be-correct.html: Added.
  • fast/dom/MicroData/names-property-test-expected.txt: Added.
  • fast/dom/MicroData/names-property-test.html: Added.
  • fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-add-remove-itemref.html: Added.
  • fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-add-remove-property.html: Added.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Added.
  • fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-be-correct.html: Added.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Added.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Added.
  • fast/dom/MicroData/properties-collection-test-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-test.html: Added.
10:25 Changeset [101143] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Removed obsolete touchui flag
https://bugs.webkit.org/show_bug.cgi?id=73067

Reviewed by Tony Chang.

  • features.gypi:
10:10 Changeset [101142] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

IndexedDB: Indexes should be secondarily sorted on primary key
https://bugs.webkit.org/show_bug.cgi?id=72567

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented by adding the primary key (i.e. unique key in the
object store) to the IndexDataKey (i.e. the composite key used
in the index. Previously, non-unique entries in the index were
stored with a unique (and hidden) sequenceNumber, so ordering was
not predictable by scripts (or per spec). The sequenceNumber
is now deprecated but still present in the LevelDB backing store
to avoid having to do a data migration.

Test: storage/indexeddb/cursor-primary-key-order.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):

  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):

  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Updates the IndexDataKey unit tests to include primary keys. The
deprecated sequenceNumber element of IndexDataKey is still tested,
although no longer used by callers.

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

LayoutTests:

  • storage/indexeddb/cursor-primary-key-order-expected.txt: Added.
  • storage/indexeddb/cursor-primary-key-order.html: Added.
08:51 Changeset [101141] by zeno.albisser@nokia.com
  • 15 edits in trunk/Source

[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets
https://bugs.webkit.org/show_bug.cgi?id=72495

Source/JavaScriptCore:

Update defines to not use Unix Domain Sockets for platform Qt on Mac.
This enables Qt to reuse existing code for mach ports and Grand
Central Dispatch based IPC.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:

Source/WebKit2:

Make Qt using mach ports and Grand Central Dispatch for IPC
when building on Mac.

Reviewed by Simon Hausmann.

  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/CoreIPCMessageKinds.h:
  • Platform/SharedMemory.h:
  • Platform/WorkQueue.h:
  • Platform/mac/MachUtilities.cpp:
  • Platform/mac/WorkQueueMac.cpp:
  • Target.pri:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

08:36 Changeset [101140] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: WebInspector.inspectedPageDomain is not calculated for about:blank
https://bugs.webkit.org/show_bug.cgi?id=73082

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/inspector.js:

(WebInspector.networkResourceById):
(WebInspector.get inspectedPageDomain):

08:02 WebKitGTK/AddingNewWebKit2API edited by carlosgc@webkit.org
Remove point about gobject properties (diff)
07:12 Changeset [101139] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: provide context menu items to open resources using extensions
https://bugs.webkit.org/show_bug.cgi?id=73076

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):
(WebInspector.ExtensionServer.prototype._handleOpenURL):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.set dispatch):
(get WebInspector.HandlerRegistry.prototype.dispatchToHandler):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/externs.js:

(WebInspector.populateResourceContextMenu):

  • inspector/front-end/inspector.js:

(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):

06:57 Changeset [101138] by philn@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebCore

[GStreamer] WebAudio AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=69835

Reviewed by Martin Robinson.

New GStreamer source element pulling data from the AudioBus and
outputing audio interleaved GstBuffers suitable for playback.

  • GNUmakefile.list.am: Added the new GStreamer WebAudio element

source files to the build.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::onGStreamerWavparsePadAddedCallback): Function called
when the playback pipeline successfully parsed the audio source
into a WAV stream.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Configure the initial playback pipeline up to the WAV parser. The
audio sink is added only after the WAV parser was configured.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Reset the playback pipeline and delete it.
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady):
Method to add the audio sink to the pipeline and link it to the
WAV parser.
(WebCore::AudioDestinationGStreamer::start): Set pipeline to
PLAYING, at the first run it will trigger the WAV parser and hence
the audio-sink plugging.
(WebCore::AudioDestinationGStreamer::stop): Pause the pipeline.

  • platform/audio/gstreamer/AudioDestinationGStreamer.h:
  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: Added.

(getGStreamerMonoAudioCaps): Utility function to generate
GStreamer caps representing a single audio channel for a given
sample rate.
(webKitWebAudioGStreamerChannelPosition): Utility function to
convert AudioBus channel representations to GStreamer positional
audio channel values.
(webkit_web_audio_src_class_init): GObject configuration of the
GStreamer source element.
(webkit_web_audio_src_init): Initialization of the private data of
the element.
(webKitWebAudioSourceConstructed): Configure the GstBin elements
depending on the AudioBus layout.
(webKitWebAudioSourceFinalize): Clean up the GstBin and free private
data of the element.
(webKitWebAudioSourceSetProperty): GObject property setter.
(webKitWebAudioSourceGetProperty): GObject property getter.
(webKitWebAudioSourceLoop): GstTask used to pull data from the
AudioBus and push it as GstBuffers to the src pad of the element.
(webKitWebAudioSourceChangeState): Start or stop the above GstTask
depending on the asked state transition.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h: Added.
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: GstTask support in GRefPtr.

(WTF::adoptGRef):
(WTF::GstTask):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
05:45 Changeset [101137] by jknotten@chromium.org
  • 1 edit in branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt

Fix test expectations.

http://codereview.chromium.org/8682014/

05:45 Changeset [101136] by hausmann@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Stop leaking memory in string QWK2 API's
https://bugs.webkit.org/show_bug.cgi?id=72558

Patch by Oleg Romashin <romaxa@gmail.com> on 2011-11-17
Reviewed by Simon Hausmann.

WKRef API pointers don't adopt the implementation pointers by default and the implementation pointers
stay alive after destroying the API pointers.
This patch adopts the implementation pointers correctly by using adoptWK that returns a WKRetainPtr
that will be around temporarily and correctly release the object.

  • UIProcess/qt/QtWebPageUIClient.cpp:

(QtWebPageUIClient::mouseDidMoveOverElement):

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::qt_wk_didFailDownload):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::load):
(QtWebPageProxy::url):
(QtWebPageProxy::title):

05:35 Changeset [101135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add implementation considering ewk_tiled_backing_store's visible status.
https://bugs.webkit.org/show_bug.cgi?id=71791

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-24
Reviewed by Gustavo Noronha Silva.

In order to prevent rendering and pre-rendering while backing store is hidden,
its visibility is checked and pre-rendering is handled whenever backing store is shown or hidden.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(ewk_tiled_backing_store_add):

05:27 Changeset [101134] by hausmann@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably

Reviewed by Andreas Kling.

We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
ways of doing that and this fix seems like the least intrusive one by simply pushing the
invoker to the gui thread if it's not there already.

  • wtf/qt/MainThreadQt.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

05:07 Changeset [101133] by vestbo@webkit.org
  • 13 edits in trunk

[Qt] Get rid of the buildDirForSource() function in the build system

At some point the plan was to allow for running qmake on sub-trees
of the sources, into the top level build directory, but this is no
longer possible, so no reason to keep the convenience function around.

Reviewed by Simon Hausmann.

05:03 Changeset [101132] by paroga@webkit.org
  • 4 edits in trunk/Source

[CMake] Add missing source files
https://bugs.webkit.org/show_bug.cgi?id=73052

Reviewed by Andreas Kling.

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit2:

Add more generic files to the sources list and remove the EFL specific stuff.

  • CMakeLists.txt:
03:37 Changeset [101131] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Use QEvent for dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=72704

Reviewed by Simon Hausmann.

Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
This is the same as what invokeMethod does internally, but reduces
the dependency on some internal QThread stuff.

  • wtf/qt/MainThreadQt.cpp:

(WTF::MainThreadInvoker::MainThreadInvoker):
(WTF::MainThreadInvoker::event):
(WTF::scheduleDispatchFunctionsOnMainThread):

01:47 Changeset [101130] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix ASSERTs added in r101082.

Rubber-Stamped by Martin Robinson.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef): Check for valid pointer before
GST_OBJECT_IS_FLOATING().

01:37 Changeset [101129] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=69738

Reviewed by Timothy Hatcher.

The source viewer is focused whenever a file name option is clicked, and is NOT focused when the script list
is traversed with the Up/Down keys.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._filesSelectChanged):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.focus):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.focus):

01:10 Changeset [101128] by podivilov@chromium.org
  • 11 edits
    5 adds in trunk

Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/compiler-source-mapping-debug.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
  • http/tests/inspector/compiler-source-mapping-debug.html: Added.
  • http/tests/inspector/resources/source-map.json:
  • http/tests/inspector/resources/source1.js:
  • http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

00:38 Changeset [101127] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations.

  • platform/chromium/test_expectations.txt: Now that V8 bug 1821 is fixed the test should not crash.
00:17 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
00:14 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
00:11 Changeset [101126] by pfeldman@chromium.org
  • 22 edits in trunk

Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead.
https://bugs.webkit.org/show_bug.cgi?id=73024

Source/WebCore:

We use it for the URL mostly, no need to create artificial resource for that upon
attaching to the existing page.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/HAREntry.js:

(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._pageEventTime):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._exportAll):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get displayName):
(WebInspector.Resource.prototype.get displayDomain):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._initDefaultSelection):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._addRecordToTimeline):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/selected-call-frame-after-formatting-source.html:
  • inspector/debugger/watch-expressions-panel-switch.html:
  • inspector/extensions/extensions-events.html:
  • inspector/performance/resources/first-open-resources.html:
  • inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

  • inspector/performance/resources/show-panel.html:
  • inspector/styles/styles-history.html:
00:01 Changeset [101125] by yurys@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: exceptions in shared workers should be logged to web inspector console
https://bugs.webkit.org/show_bug.cgi?id=73022

According to section "4.7 Runtime script errors" of Web Workers spec "For shared
workers, if the error is still not handled afterwards, or if the error occurred
while handling a previous script error, the error may be reported to the user."

This change adds uncaugh exceptions to the shared worker web inspector console.

Reviewed by Pavel Feldman.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::restore):

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::restore):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerContext):

  • inspector/InspectorInstrumentation.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

  • inspector/WorkerInspectorController.h:
  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.showWorkerTerminatedScreen):

  • inspector/front-end/inspector.js:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/SharedWorkerContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addMessage): console messages are now added to
the worker console agent.
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:
Note: See TracTimeline for information about the timeline view.