Timeline


and

12/10/11:

22:32 Changeset [102536] by haraken@chromium.org

[Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
https://bugs.webkit.org/show_bug.cgi?id=74175

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

  • Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().

(findChangeLogs):

22:20 Changeset [102535] by commit-queue@webkit.org

#ifdef the parts of the Mac platform which should not be used on iOS
https://bugs.webkit.org/show_bug.cgi?id=74246

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-10
Reviewed by David Kilzer.

  • Configurations/WebCore.xcconfig:
  • platform/FileSystem.cpp:
  • platform/mac/FileSystemMac.mm:
  • platform/mac/Language.mm:

(+[WebLanguageChangeObserver _webkit_languagePreferencesDidChange]):
(WebCore::createHTTPStyleLanguageCode):
(WebCore::platformDefaultLanguage):

  • platform/mac/LocalizedStringsMac.mm:

(WebCore::localizedString):
(+[WebCoreSharedBufferData initialize]):

  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreNSStringExtras.mm:
  • platform/mac/WebFontCache.mm:
  • platform/mac/WebNSAttributedStringExtras.mm: The value NSAttachmentCharacter is

not defined in the iOS SDK so we add it here.

17:23 Changeset [102534] by mhahnenberg@apple.com

JSC testapi is crashing on Windows
https://bugs.webkit.org/show_bug.cgi?id=74233

Reviewed by Sam Weinig.

Same error we've encountered before where we are calling the wrong version of
visitChildren and objects that are still reachable aren't getting marked.
This problem will go away soon with the removal of vptrs for these sorts of
optimizations in favor of using the ClassInfo, but for now we can simply give
JSFinalObject a bogus virtual method that Visual Studio can't optimize away to
ensure that JSFinalObject will always have a unique vptr. We don't have to worry
about JSString or JSArray right now, which are the other two special cases for
visitChildren, since they already have their own virtual functions.

(JSC::JSFinalObject::vtableAnchor):

  • runtime/JSObject.h:
16:09 Changeset [102533] by weinig@apple.com

Try to fix the windows build.

  • win/WebKit2.vcproj:
15:54 Changeset [102532] by rniwa@webkit.org

The previous fix broke Lion release build. Fix that.

  • editing/SpellingCorrectionCommand.cpp:
15:46 Changeset [102531] by rniwa@webkit.org

Lion build fix attempt after r102527.

  • editing/SpellingCorrectionCommand.cpp:
15:30 Changeset [102530] by kevino@webkit.org

[wx] Unreviewed build fixes. Add missing header for CPP
DOM bindings and add stubs for new DPI methods.

13:48 Changeset [102529] by rniwa@webkit.org

Mac build fix. Remove an erroneous OVERRIDE.

  • editing/CompositeEditCommand.h:
13:40 Changeset [102528] by robert@webkit.org

CSS 2.1 failure: numerous counter-increment-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=73360

Source/WebCore:

Reviewed by Julien Chaffraix.

Allow counter-increment to handle integer underflow and overflow.
Also allow 'counter' to inherit.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):

LayoutTests:

WebKit dumpAsText() versions of the CSS test suite's counter-increment-001 and 002 are already present in
fast/css/counters, so add a dumpAsText version of tests 003 to 056.

Reviewed by Julien Chaffraix.

  • fast/css/counters/counter-increment-inherit-expected.txt: Added.
  • fast/css/counters/counter-increment-inherit.htm: Added.
  • fast/css/counters/counter-increment-tests-expected.txt: Added.
  • fast/css/counters/counter-increment-tests.htm: Added.
13:35 Changeset [102527] by rniwa@webkit.org

There should be a way to count the number of nodes held by undo stack
https://bugs.webkit.org/show_bug.cgi?id=74099

Reviewed by Enrica Casucci.

Add getNodesInCommand to all SimpleEditCommands and EditCommandComposition in debug builds.
We can easily aggregate the number of nodes held by the undo stack by calling
this function on each item in the undo stack.

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::getNodesInCommand):

  • editing/AppendNodeCommand.h:
  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::getNodesInCommand):

  • editing/CompositeEditCommand.h:
  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::getNodesInCommand):

  • editing/DeleteFromTextNodeCommand.h:
  • editing/EditCommand.cpp:

(WebCore::SimpleEditCommand::addNodeAndDescedents):

  • editing/EditCommand.h:
  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::getNodesInCommand):

  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::getNodesInCommand):

  • editing/InsertNodeBeforeCommand.h:
  • editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::getNodesInCommand):

  • editing/MergeIdenticalElementsCommand.h:
  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::getNodesInCommand):

  • editing/RemoveCSSPropertyCommand.h:
  • editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::getNodesInCommand):

  • editing/RemoveNodeCommand.h:
  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::ReplaceNodeWithSpanCommand::getNodesInCommand):

  • editing/ReplaceNodeWithSpanCommand.h:
  • editing/SetNodeAttributeCommand.cpp:

(WebCore::SetNodeAttributeCommand::getNodesInCommand):

  • editing/SetNodeAttributeCommand.h:
  • editing/SetSelectionCommand.h:
  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::getNodesInCommand):

  • editing/SplitElementCommand.h:
  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::getNodesInCommand):

  • editing/SplitTextNodeCommand.h:
  • editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::getNodesInCommand):

  • editing/WrapContentsInDummySpanCommand.h:
12:30 Changeset [102526] by robert@webkit.org

CSS 2.1 failure: outline-color-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71931

Source/WebCore:

Reviewed by Julien Chaffraix.

Test: css2.1/20110323/outline-color-001.html

WebKit didn't paint the top block in this series of tests because it ignored the outline
of objects with a zero size. Fix this by taking account of both offset and width of the
outline when deciding whether to paint it.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size

LayoutTests:

Add outline-color-001.htm to catch regressions against displaying outlines
on objects with zero size. The rest of the outline-color-* test series will
be landed separately.

Reviewed by Julien Chaffraix.

  • css2.1/20110323/outline-color-001-expected.html: Added.
  • css2.1/20110323/outline-color-001.htm: Added.
11:45 Changeset [102525] by kling@webkit.org

Add my Apple e-mail to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
11:33 Changeset [102524] by commit-queue@webkit.org

Update test_expectations for chromium
https://bugs.webkit.org/show_bug.cgi?id=74137

Patch by Alan Stearns <stearns@adobe.com> on 2011-12-10
Reviewed by Ryosuke Niwa.

  • platform/chromium/test_expectations.txt:
10:46 Changeset [102523] by commit-queue@webkit.org

Microdata: Fix compilation error in MICRODATA enabled build.
https://bugs.webkit.org/show_bug.cgi?id=74235

Patch by Arko Saha <arko@motorola.com> on 2011-12-10
Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::getItems):

09:13 Changeset [102522] by alexis.menard@openbossa.org

Unused variable in YarrJIT.cpp.
https://bugs.webkit.org/show_bug.cgi?id=74237

Reviewed by Andreas Kling.

Variable is set but not used so we can remove it.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

06:50 Changeset [102521] by jarred@sencha.com

[V8] Remove old ArrayBuffer guards from V8XMLHttpRequestCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=74234

Reviewed by Adam Barth.

No new tests are necessary.

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

05:55 Changeset [102520] by alexis.menard@openbossa.org

Unreviewed build fix for Qt.

Build error introduced by r102484.

  • Target.pri:
01:54 Changeset [102519] by noel.gordon@gmail.com

WebPImageDecoder progressive decodes fail to decode valid images
https://bugs.webkit.org/show_bug.cgi?id=74062

Reviewed by Adam Barth.

The WEBP header is followed by a so-called P0 header, then some data to
decode. If a partial P0 header is received during progressive decodes,
WebPIDecGetRGB() returns false; that makes the decoder enter the failed
state, no image appears on the page.

James Zern (webp) recommended the following via e-mail:

WebPIUpdate() validates input data, and will return an error status for
malformed data (bit-stream error, invalid data). Otherwise, it returns
OK or SUSPENDED. OK means that decoding is done/complete/no-error, and
SUSPENDED means more input data is needed to complete decoding. A NULL
return from WebPIDecGetRGB() is valid at this time due to a partial P0,
and should not be interpreted as a decoding failure.

No new tests. Not something DumpRenderTree can easily test.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode): A NULL WebPIDecGetRGB() return is
acceptable here. Return false instead of failing the decoder.

12/09/11:

21:47 Changeset [102518] by lforschler@apple.com

Versioning.

21:34 Changeset [102517] by benjamin@webkit.org

Add the FileSystem functions of iOS
https://bugs.webkit.org/show_bug.cgi?id=74164

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-09
Reviewed by David Kilzer.

Two functions are needed on iOS for temporary files and directories.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/FileSystemIOS.h: Added.
  • platform/ios/FileSystemIOS.mm: Added.

(WebCore::createTemporaryDirectory):
(WebCore::createTemporaryFile):

21:18 Changeset [102516] by lforschler@apple.com

New tag.

19:03 Changeset [102515] by commit-queue@webkit.org

Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74197

The bufferedData() was removed in r95120.

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-09
Reviewed by Rob Buis.

Trivial fix, so no new tests.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:
18:46 Changeset [102514] by commit-queue@webkit.org

Upstream BlackBerry API backing store files
https://bugs.webkit.org/show_bug.cgi?id=73668

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-09
Reviewed by Daniel Bates.

Contributed by Torch team, the main contributor is Adam Treat
<atreat@rim.com>.

Initial upstream, no new tests.

  • blackberry/Api/BackingStore.cpp: Added.
  • blackberry/Api/BackingStore.h: Added.
  • blackberry/Api/BackingStore_p.h: Added.
18:42 Changeset [102513] by lforschler@apple.com

Merge 98588.

18:35 Changeset [102512] by commit-queue@webkit.org

[chromium] Prevent ASSERT in legitimate out-of-memory case.
https://bugs.webkit.org/show_bug.cgi?id=74215

Patch by Eric Penner <epenner@google.com> on 2011-12-09
Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

18:29 Changeset [102511] by commit-queue@webkit.org

NameNodeListCache should be invalidated when name attribute changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810

Patch by Arko Saha <arko@motorola.com> on 2011-12-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/getelementsbyname-invalidation-cache.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseMappedAttribute):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseMappedAttribute):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseMappedAttribute):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::parseMappedAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::parseMappedAttribute):

LayoutTests:

  • fast/dom/getelementsbyname-invalidation-cache-expected.txt: Added.
  • fast/dom/getelementsbyname-invalidation-cache.html: Added.
18:26 Changeset [102510] by levin@chromium.org

REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619

Reviewed by Alexey Proskuryakov.

  • platform/mac/Skipped: Unskip various worker tests as they should work

now that bug 71695 is fixed.

18:15 Changeset [102509] by fpizlo@apple.com

DFG ArithMul power-of-two case does not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=74230

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Disabled power-of-2 peephole optimization for multiplication, because it was wrong,
and any attempt to fix it would likely introduce code bloat and register pressure.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMul):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-multiply-expected.txt: Added.
  • fast/js/dfg-multiply.html: Added.
  • fast/js/script-tests/dfg-multiply.js: Added.

(doMultiplyConstant2):
(doMultiplyConstant3):
(doMultiplyConstant4):

18:13 Changeset [102508] by levin@chromium.org

REGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBase::ref in FunctionCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=73886

Reviewed by Darin Adler.

  • runtime/SymbolTable.h:

(JSC::SharedSymbolTable::SharedSymbolTable): Added deprecatedTurnOffVerifier for
another JavaScriptObject, since JavaScriptCore objects allow use on multiple threads.
Bug 58091 is about changing these deprecated calls to something else but that something
else will still need to be in all of these places.

18:06 Changeset [102507] by mrowe@apple.com

Fix the Snow Leopard build some more.

Move the #if to a location where it will do some good.

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
17:59 Changeset [102506] by commit-queue@webkit.org

[Gtk] Unskip two passing Shadow DOM tests
https://bugs.webkit.org/show_bug.cgi?id=74186

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-12-09
Reviewed by Martin Robinson.

Unskip two passing tests after bug #59571 was fixed.

  • platform/gtk/Skipped:
17:57 Changeset [102505] by commit-queue@webkit.org

Remove unnecessary file DissasemblerARM.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=74184

Patch by Konrad Piascik <kpiascik@rim.com> on 2011-12-09
Reviewed by Daniel Bates.

  • PlatformBlackBerry.cmake:
17:54 Changeset [102504] by mrowe@apple.com

Fix the Snow Leopard build.

Wrap some code that is only applicable to Lion and newer in the appropriate #if's.

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

17:44 Changeset [102503] by andersca@apple.com

Fix Lion release build.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

17:41 Changeset [102502] by commit-queue@webkit.org

[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
https://bugs.webkit.org/show_bug.cgi?id=73826

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.

.:

  • Source/qtwebkit-export.map: Adding QWebNavigationRequest

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes): Registering QWebNavigationRequest

Source/WebKit2:

Adding QWebNavigationRequest by moving NavigationRequest out of QtWebPagePolicyClient.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationrequest.cpp: Added.

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate::~QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::~QWebNavigationRequest):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::url):
(QWebNavigationRequest::button):
(QWebNavigationRequest::modifiers):
(QWebNavigationRequest::action):

  • UIProcess/API/qt/qwebnavigationrequest_p.h: Added.
  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(QtWebPagePolicyClient::decidePolicyForResponse):

17:39 Changeset [102501] by commit-queue@webkit.org

[FileSystem API] Entry.remove successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69639

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-09
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-remove.html

  • fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter

LayoutTests:

  • fast/filesystem/resources/simple-required-arguments-remove.js: Added.

(errorCallback):
(successCallback):

  • fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
  • fast/filesystem/simple-required-arguments-remove.html: Added.
17:31 Changeset [102500] by jamesr@google.com

[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

  • WebKit.gyp:
  • public/WebContentLayer.h: Removed.
  • public/WebContentLayerClient.h: Removed.
  • public/WebExternalTextureLayer.h: Removed.
  • public/WebLayer.h: Removed.
  • public/WebLayerClient.h: Removed.
  • public/WebLayerTreeView.h: Removed.
  • public/WebLayerTreeViewClient.h: Removed.
17:28 Changeset [102499] by commit-queue@webkit.org

[Qt][WK2] Unskip API tests
https://bugs.webkit.org/show_bug.cgi?id=74180

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.

Unskip API tests for geolocation and javascript dialogs.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
17:26 Changeset [102498] by timothy_horton@apple.com

background-image transitions trigger between equivalent images
https://bugs.webkit.org/show_bug.cgi?id=74229
<rdar://problem/10558627>

Reviewed by Darin Adler.
Patch by Simon Fraser.

For animation property wrappers around StyleImage properties,
test the equivalence of the image itself, instead of equality of
the StyleImage pointer.

Test: transitions/equivalent-background-image-no-transition.html

  • page/animation/AnimationBase.cpp:

(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):

Add a test ensuring that background-images aren't needlessly transitioned
when they are equivalent.

  • transitions/equivalent-background-image-no-transition-expected.txt: Added.
  • transitions/equivalent-background-image-no-transition.html: Added.
17:25 Changeset [102497] by mrowe@apple.com

<http://webkit.org/b/74061> WebProcess and PluginProcess should inherit environment variables provided in LC_DYLD_ENVIRONMENT of main executable binary.

Reviewed by Darin Adler.

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Added.
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Added.

(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor):
(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Parse out the name
and value from the environment string and add an entry to our variable map if the variable
is one that dyld would respect in LC_DYLD_ENVIRONMENT.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Look for a LC_DYLD_ENVIRONMENT
load command and extract any environment string that we find within.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Iterate over each
load command in the Mach-O file.
(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Determine whether
the Mach-O file is of the correct architecture, and if so then process the load commands
found within.
(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Process each architecture of the
Mach-O file in turn.
(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Add our
extracted variables to the passed-in EnvironmentVariables object. We skip adding any
variables that already exist so as to allow variables passed in the environment to override
those that we extract from the executable file.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Extract the environment variables from the
main binary and add them to the launch environment of our subprocess.

  • WebKit2.xcodeproj/project.pbxproj:
17:18 Changeset [102496] by commit-queue@webkit.org

[chromium] add accessors to WebDOMMessageEvent
https://bugs.webkit.org/show_bug.cgi?id=73346

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-09
Reviewed by Darin Fisher.

  • public/WebDOMMessageEvent.h:
  • src/WebDOMMessageEvent.cpp:

(WebKit::WebDOMMessageEvent::data):
(WebKit::WebDOMMessageEvent::origin):

17:17 WebKit Team edited by benjamin@webkit.org
(diff)
17:15 WebKit Team edited by kling@webkit.org
(diff)
17:09 Changeset [102495] by commit-queue@webkit.org

[chromium] add event methods to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73259

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-09
Reviewed by Darin Fisher.

  • public/WebDOMEventListener.h: Use EventTarget instead of Node
  • public/WebFrame.h: Add event methods
  • src/WebDOMEventListener.cpp: Use EventTarget instead of Node

(WebKit::WebDOMEventListener::createEventListenerWrapper):
(WebKit::WebDOMEventListener::getEventListenerWrapper):

  • src/WebDOMEventListenerPrivate.cpp: Use EventTarget instead of Node

(WebKit::WebDOMEventListenerPrivate::createEventListenerWrapper):
(WebKit::WebDOMEventListenerPrivate::getEventListenerWrapper):

  • src/WebDOMEventListenerPrivate.h: Use EventTarget instead of Node

(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::addEventListener): register a listener on a WebFrame
(WebKit::WebFrameImpl::removeEventListener): remove a listener on a WebFrame
(WebKit::WebFrameImpl::dispatchEvent): dispatch an event to a WebFrame

  • src/WebFrameImpl.h: Add event methods
17:05 Changeset [102494] by weinig@apple.com

Add WKView implementation for quickLookPreviewItemsAtWindowLocation.
<rdar://problem/10472505>

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView quickLookPreviewItemsAtWindowLocation:]):

17:01 Changeset [102493] by commit-queue@webkit.org

[Qt] Open shared memory files with shm_open.
https://bugs.webkit.org/show_bug.cgi?id=74078

Original patch by Kimmo Kinnunen

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

Open shared memory files with shm_open. This uses mount point that is
intended to host shared memory files. Typically this is /dev/shm.

This fixes crashes when filesystem that hosts QDir::temp() is full.

This is also more well-defined with respect to question whether SHM
writes to temp dir would cause unintended wear if hosted on flash drives.

This also fixes performance problems regarding QDir::temp() and
mkostemp(), both of which appear to be long operations.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

17:01 Changeset [102492] by commit-queue@webkit.org

Small style fix on DragDataBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74171

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-09
Reviewed by Rob Buis.

Style fix, no function impact, no new tests.

  • platform/blackberry/DragDataBlackBerry.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

16:47 Changeset [102491] by tony@chromium.org

Fix test expectations from r102486: flex-flow returns direction and wrap now.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
16:41 Changeset [102490] by dpranke@chromium.org

chromium win build: revert build_webkit_exes_from_webkit_gyp change
https://bugs.webkit.org/show_bug.cgi?id=74225

Source/WebKit/chromium:

Reviewed by Tony Chang.

This change sets build_webkit_exes_from_webkit_gyp back to 1;
the "All.gyp" solution doesn't work on windows.

  • gyp_webkit:

Tools:

This change sets build_webkit_exes_from_webkit_gyp back to 1;
the "All.gyp" solution doesn't work on windows.

  • Scripts/webkitdirs.pm:

(buildChromium):

16:09 Changeset [102489] by fpizlo@apple.com

DFG's interpretation of rare case profiles should be frequency-based not count-based
https://bugs.webkit.org/show_bug.cgi?id=74170

Reviewed by Geoff Garen.

DFG optimizes for rare cases only when the rare case counter is above some threshold
and it also constitutes a large enough fraction of total function executions. Also
added some minor debug logic.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::executionEntryCount):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
15:53 Changeset [102488] by commit-queue@webkit.org

[Qt] Click's count is limited to three continuous clicks.
https://bugs.webkit.org/show_bug.cgi?id=45666

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Make Qt recognize "infinite" continuous mouse clicks.
handleMouseDoubleClickEvent merged into handleMousePressEvent.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::timerEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

Tools:

Update m_time at every call to leapForward, so double clicks
event are correctly sent by EventSender.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Enable fast/events/click-count.html for qt and disable for qt-wk1.

  • platform/qt-wk1/Skipped:
  • platform/qt/Skipped:
15:50 Changeset [102487] by haraken@chromium.org

[Refactoring] Reduce top-level code in prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74172

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

  • Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().

(generateFunctionLists):

15:50 Changeset [102486] by ojan@chromium.org

add css parsing for flex-flow: wrap and wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=74008

Patch by Tony Chang <tony@chromium.org> on 2011-12-09
Reviewed by Ojan Vafai.

Source/WebCore:

Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values).

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit.
(WebCore::ApplyPropertyFlexFlow::applyInitialValue):
(WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one
CSS property.
(WebCore::ApplyPropertyFlexFlow::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexWrap):
(WebCore::InheritedFlags::setFlexWrap):
(WebCore::InheritedFlags::initialFlexWrap):

  • rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values.
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values.

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js: Test call combinations of flex-flow values.
15:47 Changeset [102485] by oliver@apple.com

PutByValAlias unnecessarily clobbers GetIndexedPropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=74223

Reviewed by Geoffrey Garen.

Don't clobber GetIndexedPropertyStorage when we see PutByValAlias

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):

15:45 Changeset [102484] by weinig@apple.com

Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=74218

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WebKit2.WKConnectionTest in TestWebKitAPI

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::forwardDidReceiveMessageToClient):

  • Shared/WebConnection.h:

Add helper for connection subclasses to dispatch to the client.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::didReceiveMessage):
Handle postMessage messages from the WebProcess.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidFinishLaunching):
Dispatch the notification that a connection to the WebProcess has
been established.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGetApplicationConnection):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::webConnectionToUIProcess):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::WebProcess::webConnectionToUIProcess):
Add accessor to get the connection to the UIProcess from
the bundle.

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::didReceiveMessage):
Handle postMessage messages from the UIProcess.

  • WebProcess/WebProcess.h:

Tools:

Add a test of the WKConnectionRef API.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.

(TestWebKitAPI::didCreateConnection):
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::connectionDidClose):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.

(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::WKConnectionTest::WKConnectionTest):
(TestWebKitAPI::WKConnectionTest::initialize):

15:43 Changeset [102483] by levin@chromium.org

Hash* iterators should allow comparison between const and const versions.
https://bugs.webkit.org/show_bug.cgi?id=73370

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/HashTable.h: Add the operators needed to do this.

(WTF::HashTableConstIterator::operator==):
(WTF::HashTableConstIterator::operator!=):
(WTF::HashTableIterator::operator==):
(WTF::HashTableIterator::operator!=):
(WTF::operator==):
(WTF::operator!=):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
  • TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.

(TestWebKitAPI::TEST): Add a test for the new functionality.

15:39 Changeset [102482] by dpranke@chromium.org

chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
https://bugs.webkit.org/show_bug.cgi?id=74212

Reviewed by Tony Chang.

The change introduced in r102201 to split the executables out of
WebKit.gyp apparently doesn't work right on Windows, since
WebKit.gyp and Tools.gyp refer to dependent projects by
different relative paths (it appears gyp doesn't normalize the
paths). This change moves Tools.gyp to be in the same directory
as WebKit.gyp (and All.gyp), which should fix this and
conveniently will also solve the problem of how to add Tools.gyp
to the chromium DEPS file.

Source/WebKit/chromium:

  • All.gyp:
  • Tools.gyp: Renamed from ../../../Tools/Tools.gyp.

Tools:

  • Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
15:26 Changeset [102481] by haraken@chromium.org

[Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
https://bugs.webkit.org/show_bug.cgi?id=74173

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

  • Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().

(fetchBugDescriptionFromURL):

15:26 Changeset [102480] by commit-queue@webkit.org

[EFL] Add RefPtrEfl specialization for evas_object.
https://bugs.webkit.org/show_bug.cgi?id=73790

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-12-09
Reviewed by Ryosuke Niwa.

As evas_object is also based on reference count, RefPtr is applied for evas_object.

  • PlatformEfl.cmake:
  • platform/efl/RefPtrEfl.cpp: Added.

(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • platform/efl/RefPtrEfl.h: Added.
15:23 Changeset [102479] by tony@chromium.org

REGRESSION(102234): 2-3% layout regression
https://bugs.webkit.org/show_bug.cgi?id=74141

Reviewed by David Hyatt.

Don't allocate a RuleSet when there are no regions.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initForRegionStyling):

15:21 Changeset [102478] by andersca@apple.com

Fix assertion failure in ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74222

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
This can be called with a nil scrollerImp, just return NSZeroPoint when that happens.

14:48 Changeset [102477] by adamk@chromium.org

[MutationObservers] Add test for deliver-at-end-of-task semantics
https://bugs.webkit.org/show_bug.cgi?id=74190

Reviewed by Ojan Vafai.

The addition of eventSender.scheduleAsynchronousKeyDown in r102424
allows testing the code added in r101842 and http://crrev.com/113010.

Added a test using a contentEditable element and an onblur event
handler that asserts it fires after mutations due to editing have been
delivered.

  • fast/mutation/end-of-task-delivery-expected.txt: Added.
  • fast/mutation/end-of-task-delivery.html: Added.
14:48 Changeset [102476] by andersca@apple.com

Move the "is currently drawing into layer" flag out into ScrollbarThemeMac
https://bugs.webkit.org/show_bug.cgi?id=74217

Reviewed by Beth Dakin.

There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::paint):

14:42 Changeset [102475] by msaboff@apple.com

YARR: Multi-character read optimization for 8bit strings
https://bugs.webkit.org/show_bug.cgi?id=74191

Reviewed by Oliver Hunt.

Changed generatePatternCharacterOnce to generate
code for 1 to 4 characters in the 8 bit case.
This is worth 29% improvement on SunSpider regexp-dna test.
It provides no benefit to v8-regexp.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generate): Spelling fix in comment.

14:07 Changeset [102474] by andersca@apple.com

Minor cleanup in ScrollAnimatorMac.mm
https://bugs.webkit.org/show_bug.cgi?id=74211

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
No need to get the scrollbar from the scroll animator anymore.

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter.

14:05 Changeset [102473] by levin@chromium.org

Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
https://bugs.webkit.org/show_bug.cgi?id=71695

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

  • wtf/MessageQueue.h:

(WTF::MessageQueue::tryGetMessageIgnoringKilled): Added a way to get messages
even after the queue has been killed. This is useful when one wants to
kill a queue but then go through it to run clean up tasks from it.

Source/WebCore:

Overview: Message loops rely on the message queue being killed in order
to exit. r53595 stopped this from happening because killing a message loop
would also stop it from doing database clean up tasks. The database clean up
tasks needed to be tasks due to ordering issues. (They wanted to run after
certain order tasks were run.) This was solved by once again terminating
the message queue but then still runnning clean-up tasks from the killed
message queue.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks.
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks.
(WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks
from running after the loop has been terminated.

  • workers/WorkerRunLoop.h:

(WebCore::WorkerRunLoop::terminated): Just made it const.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask): Removed
the terminate clause since it was put back in stop.
(WebCore::WorkerThread::stop): Terminate the run loop so
that all loops will exit and clean up tasks will run. Also removed a comment
about nested workers because nested workers are no longer imminent and the
issue mentioned is one of many that should logically be investigated -- behavior correctness
in the face of different orderings of shutdown between the document and each worker --
when implementing them.

LayoutTests:

  • http/tests/workers/resources/worker-util.js: Added.

Copied from fast/workers/resources/worker-util.js

  • http/tests/xmlhttprequest/workers/abort-exception-assert.html:

Make the test wait for all workers to exit before finishing.

13:41 Changeset [102472] by tony@chromium.org

Unreviewed, rolling out r102416.
http://trac.webkit.org/changeset/102416
https://bugs.webkit.org/show_bug.cgi?id=73394

Chromium Win clobber builds are failing.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
13:32 Changeset [102471] by eric.carlson@apple.com

JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable
https://bugs.webkit.org/show_bug.cgi?id=72179

Reviewed by Geoff Garen.

Source/WebCore:

Tests: media/track/text-track-cue-is-reachable.html

media/track/text-track-is-reachable.html

  • GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSTextTrackCueCustom.cpp: Added.

(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrackCueOwner::visitChildren): New.

  • bindings/js/JSTextTrackCustom.cpp: Added.

(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrack::visitChildren): New, mark all cues.

  • bindings/js/JSTextTrackCustom.h: Added.

(WebCore::root): New.

  • bindings/js/JSTextTrackListCustom.cpp:

(WebCore::JSTextTrackList::visitChildren): New, mark all tracks.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*.

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrack::trackElement): New, return the <track>.

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialize m_mediaElement.

  • html/TextTrack.h:

(WebCore::TextTrack::setMediaElement): New.
(WebCore::TextTrack::mediaElement): Ditto.

  • html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction.
  • html/TextTrackCue.idl: Add CustomIsReachable.
  • html/track/TextTrackList.cpp:

(TextTrackList::append): Set track's media element.
(TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr.

  • html/track/TextTrackList.h:
  • html/track/TextTrackList.idl: Add CustomMarkFunction

LayoutTests:

  • media/track/text-track-cue-is-reachable-expected.txt: Added.
  • media/track/text-track-cue-is-reachable.html: Added.
  • media/track/text-track-is-reachable-expected.txt: Added.
  • media/track/text-track-is-reachable.html: Added.
  • platform/chromium/test_expectations.txt:
13:25 Changeset [102470] by cfleizach@apple.com

WebKit should ignore images with @alt matching only whitespace
https://bugs.webkit.org/show_bug.cgi?id=74189

Reviewed by Darin Adler.

Source/WebCore:

Test: accessibility/img-alt-tag-only-whitespace.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

  • accessibility/img-alt-tag-only-whitespace.html: Added.
  • platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
13:25 Changeset [102469] by andersca@apple.com

Remove NSAnimationContext calls
https://bugs.webkit.org/show_bug.cgi?id=74207

Reviewed by Sam Weinig.

NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration:
are essentially no-ops. Remove them.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

13:16 Changeset [102468] by andersca@apple.com

Rename scrollAnimatorDestroyed to invalidate
https://bugs.webkit.org/show_bug.cgi?id=74206

Reviewed by Sam Weinig.

Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is
destroyed, rename it to something more neutral.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollAnimationHelperDelegate invalidate]):
(-[WebScrollbarPartAnimation invalidate]):
(-[WebScrollbarPainterDelegate invalidate]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

13:08 Changeset [102467] by andersca@apple.com

WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74204

Reviewed by Sam Weinig.

It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since
painting has nothing to do with animation.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]):
(-[WebScrollbarPainterControllerDelegate invalidate]):
(-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

12:52 Changeset [102466] by jarred@sencha.com

[JSC] Allow cached attributes in bindings that declare a custom mark function
https://bugs.webkit.org/show_bug.cgi?id=74187

Reviewed by Oliver Hunt.

No new tests, current binding tests are sufficient.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

12:36 Changeset [102465] by tony@chromium.org

Switch the chromium mac bots to using skia test results
https://bugs.webkit.org/show_bug.cgi?id=74201

Reviewed by Ryosuke Niwa.

This is reverting http://trac.webkit.org/changeset/97781 and changing
the name in master.cfg to no longer have cg in the name.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(appendCustomBuildFlags):
(RunWebKitTests.start):

12:35 Changeset [102464] by jamesr@google.com

Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036

Reviewed by Adam Barth.

See bug for details.

Test: fast/animation/request-animation-frame-detach-element.html

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::detach):

  • dom/Document.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):

  • dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036

Reviewed by Adam Barth.

  • fast/animation/request-animation-frame-detach-element-expected.txt: Added.
  • fast/animation/request-animation-frame-detach-element.html: Added.

BUG=106672
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8899006

12:33 Changeset [102463] by jamesr@google.com

Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036

Reviewed by Adam Barth.

See bug for details.

Test: fast/animation/request-animation-frame-detach-element.html

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::detach):

  • dom/Document.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):

  • dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036

Reviewed by Adam Barth.

  • fast/animation/request-animation-frame-detach-element-expected.txt: Added.
  • fast/animation/request-animation-frame-detach-element.html: Added.

BUG=106672
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8894015

12:15 Changeset [102462] by andersca@apple.com

Remove duplicate animation ivars
https://bugs.webkit.org/show_bug.cgi?id=74194

Reviewed by Sam Weinig.

Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate
vertical/horizontal animation objects, so get rid of them.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

11:48 Changeset [102461] by tony@chromium.org

Try to deflake a repaint test on Chromium. It looks like we're
calling lTC.display() before the inital layout. Force a layout
before calling lTC.display().

Reviewed by Ojan Vafai.

  • fast/replaced/width100percent-textarea.html:
11:34 Changeset [102460] by andersca@apple.com

WebScrollbarPartAnimation should only know about the scrollbar it's animating
https://bugs.webkit.org/show_bug.cgi?id=74192

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here
so we don't have to do it in all the call sites.

(-[WebScrollbarPartAnimation startAnimation]):
Update the scrollbar painter.

(-[WebScrollbarPartAnimation setCurrentProgress:]):
Just invalidate the scrollbar we're animating.

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Update call sites to use the new designated initializer.

10:59 Changeset [102459] by enne@google.com

Fix HashMap<..., OwnPtr<...> >::add compilation errors
https://bugs.webkit.org/show_bug.cgi?id=74159

Reviewed by Darin Adler.

Add a constructor to OwnPtr that takes the empty value (nullptr_t)
from HashTraits so that this function can compile.

  • wtf/OwnPtr.h:

(WTF::OwnPtr::OwnPtr):

09:52 Changeset [102458] by tony@chromium.org

[chromium] Update test_expectations.txt to match the bots.

  • platform/chromium/test_expectations.txt:
09:40 Changeset [102457] by jocelyn.turcotte@nokia.com

[Qt] Update WebGraphicLayer's child content scale in all child binding method.
https://bugs.webkit.org/show_bug.cgi?id=74101

Reviewed by Noam Rosenthal.

setChildren is currently the only method propagating the parent layer's content
scale to its children. This need to be done for addChild* as well.

This fixes the overlay layer not being rendered with the right scale when created
until the contents scale is modified again.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):

09:38 Changeset [102456] by jocelyn.turcotte@nokia.com

Inspector: Don't translate the context when rendering the highlights on a tiled layer.
https://bugs.webkit.org/show_bug.cgi?id=74085

Reviewed by Kenneth Rohde Christiansen.

When the frame view is using fixed layouting, the page overlay is the size of the whole
page and the context shouldn't be translated. The visible rect is still used in that
case to display element titles within the visible rect.

Also:

  • Rename overlayRect to visibleRect to reduce confusion in this case.
  • Remove the superfluous boundingBox check.
  • inspector/DOMNodeHighlighter.cpp:
09:35 Changeset [102455] by jocelyn.turcotte@nokia.com

[Qt] Remove a wrongly placed ASSERT.

Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

08:50 BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Write down some way that works with current qt5 master. (diff)
08:18 Changeset [102454] by caryclark@google.com

Source/WebKit/chromium: Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118

Reviewed by Adam Barth.

  • DEPS:

Tools: layout_test update to accommodate new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(get):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_versions):
(ChromiumMacPortTest.test_graphics_type):

07:19 Changeset [102453] by commit-queue@webkit.org

[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/html/scroll.html: Corrected html and

added some coloring.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest): Corrected calculation
of expected value.

06:48 Changeset [102452] by vestbo@webkit.org

[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake

The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
this failed when moving files in the source tree, as the .d file would contain
stale dependencies on the old source file location. By keeping the object files
(and hence the depdendency files) in a proper tree structure inside the objects
directory we can prevent this failure.

A side benefit is that we can also have objects with the same name inside the
same project.

Reviewed by Simon Hausmann.

06:01 Changeset [102451] by ossy@webkit.org

Unreviewed. Update unit test after r102412.

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois):

03:59 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 revision (diff)
03:49 Changeset [102450] by vsevik@chromium.org

Unreviewed inspector utilities syntax fix.

  • inspector/front-end/utilities.js:

():

02:56 WebKit Team edited by peter@chromium.org
(diff)
02:23 Changeset [102449] by bashi@chromium.org

Unreviewed, chromium test expectation update.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-09

  • platform/chromium/test_expectations.txt:
01:40 Changeset [102448] by joone.hur@collabora.co.uk

[GTK] Initial implementation of Accelerated Compositing using Clutter
https://bugs.webkit.org/show_bug.cgi?id=73319

.:

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Export new compilation macros.
  • configure.ac: Add clutter backend for Accelerated Compositing.

Source/WebCore:

Reviewed by Gustavo Noronha Silva.

No new tests added as this feature will be able to reuse the existing
CSS3 transforms layout tests.

  • GNUmakefile.am: Include WebCore/platform/graphics/clutter path.
  • GNUmakefile.list.am: Add GraphicsLayerClutter.
  • platform/clutter/GRefPtrClutter.cpp: Added.

(WTF::adoptGRef):
(WTF::ClutterActor):

  • platform/clutter/GRefPtrClutter.h: Added.
  • platform/graphics/GraphicsLayer.h: Define PlatformLayer type, which represents ClutterActor.
  • platform/graphics/clutter/GraphicsLayerClutter.cpp: Boilerplate implementation.

(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):

  • platform/graphics/clutter/GraphicsLayerClutter.h: Boilerplate implementation.

Source/WebKit/gtk:

This patch allows to add a GtkClutterEmbed to embed Clutter Actors in WebKitWebView and
set the root GraphicsLayer to WebKitWebView when Accelerated Compositing needs to be enabled.

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am:
  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::attachRootGraphicsLayer): Set the root GraphicsLayer to WebKitWebView.
(WebKit::ChromeClient::allowedCompositingTriggers): Allow to support CSS 3D Transforms only.

  • webkit/webkitglobals.cpp:

(webkitInit): Call gtk_clutter_init().

  • webkit/webkitwebview.cpp:

(webkit_web_view_size_allocate): Set the size of GtkClutterEmbed when the view is changed.
(webkit_web_view_init)
(webViewSetRootGraphicsLayer): Add the GtkClutterEmbed to the WebKitWebView as a child.
(webViewDetachRootGraphicsLayer): Remove the GtkClutterEmbed from the WebKitWebView.
(webViewSyncLayers): Commit layer changes.
(webViewMarkForSync): Set to call webViewSyncLayers using g_timeout_add.

  • webkit/webkitwebviewprivate.h:
01:25 Changeset [102447] by vsevik@chromium.org

Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.
https://bugs.webkit.org/show_bug.cgi?id=74084

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/map.html

  • inspector/front-end/treeoutline.js:

(TreeOutline):
():
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • inspector/map-expected.txt: Added.
  • inspector/map.html: Added.
01:15 Changeset [102446] by haraken@chromium.org

REGRESSION(r102105): run-bindings-tests should output full diff results
https://bugs.webkit.org/show_bug.cgi?id=74166

Reviewed by Adam Barth.

Since r102105, the output of run-bindings-tests is truncated to 500 characters.
run-bindings-tests should output full diff results.

  • Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.

(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

01:11 Changeset [102445] by ossy@webkit.org

[Qt] Fix compilation with newly separated Qt 5 QtQuick module
https://bugs.webkit.org/show_bug.cgi?id=73990

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.

Fix QtQuick includes after move from QtDeclarative to QtQuick.

Source/WebKit2:

  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/tests.pri: Tests need symbols from QtQuick, so link library.
  • UIProcess/API/qt/tests/testwindow.h:
  • UIProcess/qt/QtDialogRunner.cpp:
  • UIProcess/qt/QtSGTileNode.cpp:
  • UIProcess/qt/QtSGTileNode.h:
  • UIProcess/qt/QtSGUpdateQueue.cpp:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:
  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

Tools:

  • MiniBrowser/qt/BrowserWindow.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:
01:02 Changeset [102444] by nayankk@motorola.com

[WebKit2][gtk] Re-enable running TestWebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=70135

Reviewed by Martin Robinson.

Re-enable running TestWebKitSettings which was skipped as part
of https://bugs.webkit.org/show_bug.cgi?id=70129 due to the
bug https://bugs.webkit.org/show_bug.cgi?id=70127.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Run testWebKitSettings.
(testWebKitSettingsNewWithSettings): Run testWebKitSettingsNewWithSettings.

00:53 Changeset [102443] by ossy@webkit.org

[Qt] Unreviewed gardening. Add Qt specific expected results.

  • platform/qt/animations/cross-fade-background-image-expected.png: Added.
  • platform/qt/animations/cross-fade-background-image-expected.txt: Added.
  • platform/qt/animations/cross-fade-border-image-source-expected.png: Added.
  • platform/qt/animations/cross-fade-border-image-source-expected.txt: Added.
  • platform/qt/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/qt/animations/cross-fade-list-style-image-expected.txt: Added.
  • platform/qt/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
  • platform/qt/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/qt/animations/cross-fade-webkit-mask-image-expected.txt: Added.
  • platform/qt/transitions/cross-fade-background-image-expected.png: Added.
  • platform/qt/transitions/cross-fade-background-image-expected.txt: Added.
  • platform/qt/transitions/cross-fade-border-image-expected.png: Added.
  • platform/qt/transitions/cross-fade-border-image-expected.txt: Added.
00:45 Changeset [102442] by oliver@apple.com

Avoid reloading storage pointer for indexed properties unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=74136

Reviewed by Filip Pizlo.

Add a node to represent loading property storage for indexed properties.
This allows us to reduce code generated for sequential access of arrays,
strings, etc. This results in up to 5% improvement in code that is
very heavy on indexed reads, such as matrix operations in typed arrays
and 20% faster on microbenchmarks.

Currently this is only supported by GetByVal and other similar indexed reads.

  • bytecode/PredictedType.h:

(JSC::isFixedIndexedStorageObjectPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

00:43 Changeset [102441] by yurys@chromium.org

Fixed reviewer name in r102432 changelog entry.

00:33 Changeset [102440] by yurys@chromium.org

Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-09
Reviewed by NOBODY.

Extends python generator functionality.
Makes constructor in InspectorObject public.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InspectorValues.h:
00:12 Changeset [102439] by yurys@chromium.org

Merge 102140 - [Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number

  • inspector/Inspector.json: removed unused parameter

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8872059

12/08/11:

23:26 Changeset [102438] by bashi@chromium.org

Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

  • platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
23:01 Changeset [102437] by lforschler@apple.com

Versioning.

22:59 Changeset [102436] by lforschler@apple.com

New Tag.

22:54 Changeset [102435] by commit-queue@webkit.org

[Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=73591

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.

Source/WebCore:

Implementation of helper function to remove all GL allocated tiles
when QQuickWebView gets removed from canvas.

Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas).

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::purgeNodeTexturesRecursive):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Implement deallocation of TextureMapper GL objects when QQuickWebPage paint node deallocated.
Also adds purging GraphicsLayer backing stores on WebProcess side in order to force repainting
when page becomes visible and painting resumes and fixes incorrect initialization of view
visibility state.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::resetPaintNode):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/html/direct-image-compositing.html: Added.
  • UIProcess/API/qt/tests/html/resources/simple_image.png: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::removeFromCanvas):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::layerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::purgeGLResources):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::purgeGLResources):

  • UIProcess/qt/QtWebPageProxy.h:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::purgeBackingStores):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit::LayerTreeHostQt::recreateBackingStoreIfNeeded):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:
22:53 Changeset [102434] by bashi@chromium.org

Unreviewed, chromium test expectation update.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

  • platform/chromium/test_expectations.txt:
22:43 Changeset [102433] by leo.yang@torchmobile.com.cn

Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73791

Reviewed by Rob Buis.

Other main contributors:
Joe Mason <jmason@rim.com>
Lianghui Chen <liachen@rim.com>
Charles Wei <charles.wei@torchmobile.com.cn>

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/DeferredData.cpp: Added.
  • platform/network/blackberry/DeferredData.h: Added.
  • platform/network/blackberry/NetworkJob.cpp: Added.
  • platform/network/blackberry/NetworkJob.h: Added.
  • platform/network/blackberry/NetworkManager.cpp: Added.
  • platform/network/blackberry/NetworkManager.h: Added.
21:36 Changeset [102432] by bashi@chromium.org

Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for
Chromium Linux.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

  • platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png: Added.
21:26 Changeset [102431] by rniwa@webkit.org

It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=74028

Reviewed by Darin Adler.

Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
to notifyNodeListsAttributeChanged at appropriate places.

Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childrenChanged):

  • dom/Document.cpp:

(WebCore::Document::updateRangesAfterNodeChanges):

  • dom/Document.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):

  • dom/Node.cpp:

(WebCore::removeNodeListCacheIfPossible):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
(WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
(WebCore::Node::dispatchSubtreeModifiedEvent):

  • dom/Node.h:
  • dom/NodeRareData.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

21:23 Changeset [102430] by bashi@chromium.org

Unreviewed, rolling out r102418.
http://trac.webkit.org/changeset/102418
https://bugs.webkit.org/show_bug.cgi?id=71870

Caused Chromium build failure.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp.

(WebCore::WebKitLoseContext::WebKitLoseContext):
(WebCore::WebKitLoseContext::~WebKitLoseContext):
(WebCore::WebKitLoseContext::getName):
(WebCore::WebKitLoseContext::create):
(WebCore::WebKitLoseContext::loseContext):
(WebCore::WebKitLoseContext::restoreContext):

  • html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h.
  • html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl.

LayoutTests:

  • fast/canvas/webgl/WebGLContextEvent.html:
  • fast/canvas/webgl/context-destroyed-crash.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
21:15 Changeset [102429] by fsamuel@chromium.org

[Chromium] Enable viewport metatag
https://bugs.webkit.org/show_bug.cgi?id=73495

Reviewed by Darin Fisher.

Source/JavaScriptCore:

  • wtf/Platform.h: Added ENABLE(VIEWPORT) tag.

Source/WebCore:

Recompute viewpot parameters on frame rect resize.

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

Source/WebKit/chromium:

Compute the appropriate fixed layout size, page, and device scale factors,
based on the viewport meta tag parameters.

See http://developer.android.com/guide/webapps/targeting.html for more information.

  • features.gypi:
  • public/WebView.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/ChromeClientImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::isPageScaleFactorSet):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::observeNewNavigation):

  • src/WebViewImpl.h:
21:00 WebKit Team edited by jchaffraix@webkit.org
Updated my (very outdated) entry (diff)
21:00 Changeset [102428] by tkent@chromium.org

Build fix for r102419.
https://bugs.webkit.org/show_bug.cgi?id=73916

  • platform/PopupMenuClient.h:

(WebCore::PopupMenuClient::listBoxSelectItem):
Remove unused argument names.

20:51 Changeset [102427] by haraken@chromium.org

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
20:37 Changeset [102426] by commit-queue@webkit.org

Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=73534

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-08
Reviewed by Rob Buis.

Other main contributors:
Mike Fenton <mifenton@rim.com>
Joe Mason <jmason@rim.com>
Max Feil <mfeil@qnx.com>
Lukas Sydorowski <lsydorowski@rim.com>
Crystal Zhang <haizhang@rim.com>

Initial upstream, no new tests.

  • platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added.

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added.

(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::toWebCorePlatformKeyboardEventType):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

20:22 Changeset [102425] by commit-queue@webkit.org

Unreviewed, rolling out r101619.
http://trac.webkit.org/changeset/101619
https://bugs.webkit.org/show_bug.cgi?id=74158

this patch produces bad behaviour on mac (Requested by
jeremya_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dragSourceEndedAt):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState):

LayoutTests:

  • fast/css/hover-active-drag-expected.txt: Removed.
  • fast/css/hover-active-drag.html: Removed.
20:19 Changeset [102424] by adamk@chromium.org

[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
https://bugs.webkit.org/show_bug.cgi?id=73492

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/mutation/inline-event-listener.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.

Tools:

Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
keypress event without any script on the stack.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::keyDown):
(KeyDownTask::KeyDownTask):
(KeyDownTask::runIfValid):
(EventSender::scheduleAsynchronousKeyDown):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests:

  • fast/mutation/inline-event-listener-expected.txt: Added.
  • fast/mutation/inline-event-listener.html: Added.
20:16 Changeset [102423] by hayato@chromium.org

Suppress rendering of light children when ShadowRoot is dynamically created.
https://bugs.webkit.org/show_bug.cgi?id=72441

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html

fast/dom/shadow/dynamically-created-shadow-root.html

  • dom/Element.cpp:

(WebCore::Element::setShadowRoot):

LayoutTests:

  • fast/dom/shadow/dynamically-created-shadow-root-expected.html: Added.
  • fast/dom/shadow/dynamically-created-shadow-root.html: Added.
20:12 Changeset [102422] by bashi@chromium.org

Unreviewed, chromium test rebaseline tests added in r102388. Updates expectations.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

  • platform/chromium-cg-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
  • platform/chromium-linux/animations/cross-fade-background-image-expected.png: Added.
  • platform/chromium-linux/animations/cross-fade-border-image-source-expected.png: Added.
  • platform/chromium-linux/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/chromium-linux/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/chromium-linux/transitions/cross-fade-background-image-expected.png: Added.
  • platform/chromium-linux/transitions/cross-fade-border-image-expected.png: Added.
  • platform/chromium-mac-leopard/animations/cross-fade-background-image-expected.png: Added.
  • platform/chromium-mac-leopard/animations/cross-fade-border-image-source-expected.png: Added.
  • platform/chromium-mac-leopard/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/chromium-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
  • platform/chromium-mac-leopard/transitions/cross-fade-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
  • platform/chromium-win/animations/cross-fade-background-image-expected.png: Added.
  • platform/chromium-win/animations/cross-fade-background-image-expected.txt: Added.
  • platform/chromium-win/animations/cross-fade-border-image-source-expected.png: Added.
  • platform/chromium-win/animations/cross-fade-border-image-source-expected.txt: Added.
  • platform/chromium-win/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/chromium-win/animations/cross-fade-list-style-image-expected.txt: Added.
  • platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
  • platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.txt: Added.
  • platform/chromium-win/transitions/cross-fade-background-image-expected.png: Added.
  • platform/chromium-win/transitions/cross-fade-background-image-expected.txt: Added.
  • platform/chromium-win/transitions/cross-fade-border-image-expected.png: Added.
  • platform/chromium-win/transitions/cross-fade-border-image-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:28 Changeset [102421] by commit-queue@webkit.org

Accessibility object searching layout tests are incomplete.
https://bugs.webkit.org/show_bug.cgi?id=74130

Patch by Sam White <samuel.white@rochester.edu> on 2011-12-08
Reviewed by Chris Fleizach.

Added a layout test to support visited link searching and removed frame searching
(which was unimplemented) as it's fully covered by the tests in:
platform/mac/accessibility/search-with-frames.html

  • platform/mac/accessibility/search-predicate-expected.txt:
  • platform/mac/accessibility/search-predicate.html:
19:24 Changeset [102420] by hayato@chromium.org

[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
https://bugs.webkit.org/show_bug.cgi?id=73980

Reviewed by Tony Chang.

  • gdb/webkit.py:

(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(LCharStringPrinter):
(LCharStringPrinter.to_string):
(WTFStringImplPrinter.get_length):
(WTFStringImplPrinter.to_string):
(WTFStringImplPrinter.is_8bit):
(WTFStringPrinter.stringimpl_ptr):
(WTFStringPrinter.get_length):
(WTFStringPrinter.to_string):
(add_pretty_printers.lookup_function):

19:22 Changeset [102419] by pierre.rossi@gmail.com

Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
https://bugs.webkit.org/show_bug.cgi?id=73916

Source/WebCore:

This was needed for Qt since the mobile theme, which can be picked
up at runtime, delegates the rendering of list boxes.

Reviewed by Kent Tamura.

No new tests, there's no functional change.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::usesMenuList):

  • html/HTMLSelectElement.h:
  • platform/PopupMenuClient.h:

(WebCore::PopupMenuClient::listBoxSelectItem):
(WebCore::PopupMenuClient::multiple):

  • platform/qt/RenderThemeQtMobile.h:

(WebCore::RenderThemeQtMobile::delegatesMenuListRendering):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::multiple):

  • rendering/RenderMenuList.h:
  • rendering/RenderTheme.h:

(WebCore::RenderTheme::delegatesMenuListRendering):

Source/WebKit/chromium:

Reviewed by Kent Tamura.

  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::didAcceptIndices):
(WebKit::ExternalPopupMenu::getPopupMenuInfo):

Source/WebKit/qt:

Reviewed by Kent Tamura.

  • WebCoreSupport/PopupMenuQt.cpp:

(SelectData::multiple):
(WebCore::PopupMenuQt::selectItem):

Tools:

Reviewed by Kent Tamura.

  • qmake/mkspecs/features/features.prf:
19:07 Changeset [102418] by kbr@google.com

Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=71870

Source/WebCore:

Reviewed by James Robinson.

Rename largely done with do-webcore-rename with a couple of
necessary manual fixups. Ran WebGL layout tests.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.

(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::~WebGLLoseContext):
(WebCore::WebGLLoseContext::getName):
(WebCore::WebGLLoseContext::create):
(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):

  • html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
  • html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebKitLoseContext.cpp: Removed.
  • html/canvas/WebKitLoseContext.h: Removed.
  • html/canvas/WebKitLoseContext.idl: Removed.

LayoutTests:

Synchronized context-lost-restored.html and context-lost.html with
Khronos repository; upstream tests must check for multiple vendor
prefixes.

Reviewed by James Robinson.

  • fast/canvas/webgl/WebGLContextEvent.html:
  • fast/canvas/webgl/context-destroyed-crash.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
18:59 Changeset [102417] by bashi@chromium.org

Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

  • platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added.
  • platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added.
18:49 Changeset [102416] by haraken@chromium.org

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
18:38 Changeset [102415] by commit-queue@webkit.org

Add test for inline style block in HTML tag
https://bugs.webkit.org/show_bug.cgi?id=72360

Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.

  • fast/css/parsing-css-block-expected.txt: Added.
  • fast/css/parsing-css-block.html: Added.
18:32 Changeset [102414] by commit-queue@webkit.org

Unreviewed, rolling out r102396.
http://trac.webkit.org/changeset/102396
https://bugs.webkit.org/show_bug.cgi?id=74153

over-active-drag test still failing. (Requested by macpherson
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08

  • fast/css/hover-active-drag.html:
  • platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
  • platform/mac/fast/css/hover-active-drag-expected.txt: Added.
18:28 Changeset [102413] by commit-queue@webkit.org

Caret keeps blinking during forward-delete
https://bugs.webkit.org/show_bug.cgi?id=38564

Patch by Van Lam <vanlam@google.com> on 2011-12-08
Reviewed by Darin Adler.

Currently updateAppearance determines if the caret should stop blinking
based on whether or not the editing operation changed the position of
the caret; so the caret stops blinking in case of typing text and
backwards delete (which always displace the caret) but does not stop
blinking in the case of forward delete (which does not displace the
caret).

Added a boolean member function shouldStopCaretBlinking in EditCommand
which will return true if the object is a TypingCommand (my
understanding here is that all TypingCommands should stop the caret
from blinking for a cycle, currently 0.5 seconds). Then used this
function to stop the caret from blinking if the last editing command
is a TypingCommand.

  • editing/EditCommand.h:

(WebCore::EditCommand::shouldStopCaretBlinking):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

  • editing/TypingCommand.h:

(WebCore::TypingCommand::shouldStopCaretBlinking):

18:00 Changeset [102412] by enne@google.com

Unreviewed contributor additions to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
17:59 Changeset [102411] by tkent@chromium.org

[Chromium] Rebaseline for r102320.

  • platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Removed.
  • platform/chromium-linux-x86/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt.
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-win-vista/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
  • platform/chromium-win-xp/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/chromium-win/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium/fast/forms/basic-inputs-expected.txt: Added.
  • platform/chromium/fast/forms/basic-textareas-expected.txt: Added.
  • platform/chromium/fast/forms/basic-textareas-quirks-expected.txt: Added.
  • platform/chromium/fast/forms/input-appearance-disabled-expected.txt: Added.
  • platform/chromium/fast/forms/input-disabled-color-expected.txt: Added.
  • platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt: Added.
  • platform/chromium/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:56 Changeset [102410] by adamk@chromium.org

Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.

Source/WebCore:

Re-landing r102267 with a fix for the clang build.

No new tests, refactoring only.

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):

17:54 Changeset [102409] by andersca@apple.com

WebScrollbarPainterDelegate should have a pointer to its Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74149

Reviewed by Darin Adler.

This is another step towards making the scroll animation code more robust.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

17:46 Changeset [102408] by commit-queue@webkit.org

keyboard event doesn't fire while moving mouse with button pressed
https://bugs.webkit.org/show_bug.cgi?id=73821

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-08
Reviewed by Alexey Proskuryakov.

Autoscroll should not stop on key press.

Source/WebCore:

Test: fast/events/autoscroll-should-not-stop-on-keypress.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent):
Removed the check for autoscroll so that autoscroll is not stopped on
key press and key event is processed.

LayoutTests:

  • fast/events/autoscroll-should-not-stop-on-keypress-expected.txt: Added.
  • fast/events/autoscroll-should-not-stop-on-keypress.html: Added.
17:46 Changeset [102407] by simon.fraser@apple.com

Forced compositing mode breaks display of full-page PDFs in WK2
https://bugs.webkit.org/show_bug.cgi?id=74122
<rdar://problem/9550059>

Reviewed by Dan Bernstein.

Full page PDFs are displayed in WK2 in a subview of the WKView. However,
when the WKView is forced to use accelerated compositing, the layer obscures
the PDF subview.

To fix this we have to drop out of compositing mode when the WKView is showing
a custom representation.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPageHasCustomRepresentation:]): Tell the drawing area that the view
gained or lost a custom representation.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::pageCustomRepresentationChanged):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::pageCustomRepresentationChanged): Send a messgae to the web process
to indicate that the custom representation changed.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::pageCustomRepresentationChanged):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::pageCustomRepresentationChanged): Enter or exit compositing mode
as appropriate when we gain or lost a custom represenetation.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):

  • WebProcess/WebPage/DrawingAreaImpl.h:
17:35 Changeset [102406] by andersca@apple.com

Add scrollAnimator getter method to WebScrollbarPainterDelegate
https://bugs.webkit.org/show_bug.cgi?id=74146

Reviewed by Beth Dakin.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

17:33 Changeset [102405] by jamesr@google.com

Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036

Reviewed by Adam Barth.

See bug for details.

Test: fast/animation/request-animation-frame-detach-element.html

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::detach):

  • dom/Document.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):

  • dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036

Reviewed by Adam Barth.

  • fast/animation/request-animation-frame-detach-element-expected.txt: Added.
  • fast/animation/request-animation-frame-detach-element.html: Added.
17:31 Changeset [102404] by commit-queue@webkit.org

Use bitfield for bool data members in BitmapImage.
https://bugs.webkit.org/show_bug.cgi?id=74102

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2011-12-08
Reviewed by Darin Adler.

Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
members to reduce the BitmapImage's memory footprint.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage):

  • platform/graphics/BitmapImage.h:

(WebCore::FrameData::FrameData):

  • platform/graphics/cairo/ImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage):

  • platform/graphics/openvg/ImageOpenVG.cpp:

(WebCore::BitmapImage::BitmapImage):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::BitmapImage):

17:16 Changeset [102403] by andersca@apple.com

Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle
https://bugs.webkit.org/show_bug.cgi?id=74145

Reviewed by Sam Weinig.

Call setHorizontalScrollerImp to set the horizontal scrollbar painter.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

17:13 Changeset [102402] by commit-queue@webkit.org

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74116

Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.

  • fast/regions/webkit-flow-renderer-expected.html: Added.
  • fast/regions/webkit-flow-renderer-layer-expected.html: Added.
  • fast/regions/webkit-flow-renderer-nested-expected.html: Added.
  • platform/efl/fast/regions/webkit-flow-renderer-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-renderer-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
  • platform/mac/fast/regions/webkit-flow-renderer-expected.png: Removed.
  • platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Removed.
  • platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
  • platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
  • platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
  • platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
17:11 Changeset [102401] by andersca@apple.com

Create one WebScrollbarPainterDelegate for each scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74142

Reviewed by Sam Weinig.

Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
This is a step towards simplifying the WebScrollbarPainterDelegate object.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):

17:04 Changeset [102400] by commit-queue@webkit.org

[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
https://bugs.webkit.org/show_bug.cgi?id=74017

Source/WebCore:

Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.

Add per-tile drawing to page settings.

No new tests.

  • page/Settings.h:

(WebCore::Settings::setPerTileDrawingEnabled):
(WebCore::Settings::perTileDrawingEnabled):

  • testing/Internals.cpp:

(WebCore::Internals::setPerTileDrawingEnabled):

  • testing/Internals.h:

Source/WebKit/chromium:

Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.

Add WebSettings::setAcceleratedPaintingEnabled to public API.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAcceleratedPaintingEnabled):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):

  • src/WebSettingsImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Tools:

Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.

Add support for command line flag enable-per-tile-painting in DumpRenderTree.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAcceleratedPaintingEnabled):
(TestShell::setPerTilePaintingEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver._wrapper_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

16:58 Changeset [102399] by jchaffraix@webkit.org

REGRESSION: Changing disabled state of a textarea does not do a repaint
https://bugs.webkit.org/show_bug.cgi?id=23789

Reviewed by Darin Adler.

The bug got fixed (I did not bisect to find out when) thus landing
the test case converted to a repaint test and made cross-platform.

  • fast/repaint/textarea-set-disabled-expected.png: Added.
  • fast/repaint/textarea-set-disabled-expected.txt: Added.
  • fast/repaint/textarea-set-disabled.html: Added.
16:52 Changeset [102398] by andersca@apple.com

Add a scrollbarPainterForScrollbar helper function
https://bugs.webkit.org/show_bug.cgi?id=74139

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.mm:

(macScrollbarTheme):
(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

16:42 Changeset [102397] by commit-queue@webkit.org

[chromium] Move NonCompositedContentHost to WebKit
https://bugs.webkit.org/show_bug.cgi?id=74047

Patch by James Robinson <jamesr@chromium.org> on 2011-12-08
Reviewed by Kenneth Russell.

Source/WebCore:

Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include
from LayerRendererChromium.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

Moves NonCompositedContentHost into WebKit/chromium/src. This class is a helper class designed to make it easier
for WebViewImpl to interface with the compositor. The compositor proper should not depend on this class, and
other clients of the compositor do not need this functionality.

Follow-up patches will transition this code from using compositor-internal interfaces directly to using
higher-level interfaces like the WebKit platform APIs. This patch simply does a file mv and updates namespaces
to keep things simpler.

Refactor only and covered by several unit tests.

  • WebKit.gyp:
  • src/NonCompositedContentHost.cpp: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp.

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::~NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
(WebKit::NonCompositedContentHost::protectVisibleTileTextures):
(WebKit::NonCompositedContentHost::invalidateRect):
(WebKit::NonCompositedContentHost::notifyAnimationStarted):
(WebKit::NonCompositedContentHost::notifySyncRequired):
(WebKit::NonCompositedContentHost::paintContents):
(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):

  • src/NonCompositedContentHost.h: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h.

(WebKit::NonCompositedContentHost::create):
(WebKit::NonCompositedContentHost::topLevelRootLayer):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::nonCompositedContentHost):

  • src/WebViewImpl.h:
  • tests/LayerChromiumTest.cpp:
16:41 Changeset [102396] by commit-queue@webkit.org

Fix fast/css/hover-active-drag.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=74046

Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-12-08
Reviewed by Darin Adler.

  • fast/css/hover-active-drag.html:
  • platform/chromium/fast/css/hover-active-drag-expected.txt: Removed.
  • platform/mac/fast/css/hover-active-drag-expected.txt: Removed.
16:37 Changeset [102395] by commit-queue@webkit.org

[chromium] Layer contents scale change should trigger invalidation

https://bugs.webkit.org/show_bug.cgi?id=74086

When the contents scale of a layer is changed, the entire contents of
the layer should be marked dirty.

Patch by Sami Kyostila <skyostil@google.com> on 2011-12-08
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setContentsScale):

Source/WebKit/chromium:

  • tests/LayerChromiumTest.cpp:
16:22 Changeset [102394] by senorblanco@chromium.org

[chromium] Add CSS_FILTERS custom binding file to WebCore.gypi.
https://bugs.webkit.org/show_bug.cgi?id=74091

Reviewed by Adam Barth.

If it builds, you're happy.

  • WebCore.gypi:
16:20 Changeset [102393] by dpranke@chromium.org

create a "SystemHost" object for webkitpy to slim down the Host object
https://bugs.webkit.org/show_bug.cgi?id=72680

Reviewed by Eric Siedel.

This creates a SystemHost object that other objects that should
only have dependencies on functionality in webkitpy.common.system
can use; this will allow them to not require a full Host.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/common/system/systemhost.py: Added.
  • Scripts/webkitpy/common/system/systemhost_mock.py: Added.
16:15 Changeset [102392] by rniwa@webkit.org

Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
https://bugs.webkit.org/show_bug.cgi?id=74126

Reviewed by Tony Chang.

The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.

Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.

  • editing/markup.cpp:

(WebCore::createFragmentFromText):

16:07 Changeset [102391] by commit-queue@webkit.org

Moving SVG elements on the page doesn't always erase element at the old position
https://bugs.webkit.org/show_bug.cgi?id=74002

Patch by Florin Malita <fmalita@google.com> on 2011-12-08
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/repaint/container-repaint.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):
Save the old repaint bounds before updating the viewport.

LayoutTests:

  • svg/repaint/container-repaint-expected.png: Added.
  • svg/repaint/container-repaint-expected.txt: Added.
  • svg/repaint/container-repaint.svg: Added.
15:38 Changeset [102390] by tony@chromium.org

Mark tests added in r102388 as failing on Chromium. Fix the cross platform
expected results for transitions/svg-transitions.html (the line number changed).

  • platform/chromium/test_expectations.txt:
  • transitions/svg-transitions-expected.txt:
15:16 Changeset [102389] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=74005
fix unaligned access memory in generatePatternCharacterOnce function
for SH4 platforms.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-12-08
Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load16Unaligned):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16Unaligned):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::load16Unaligned):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::branch8):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load16Unaligned):

  • jit/JIT.h:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

15:06 Changeset [102388] by timothy_horton@apple.com

Enable animations of CSS images using -webkit-cross-fade
https://bugs.webkit.org/show_bug.cgi?id=74049
<rdar://problem/10209303>

Reviewed by Simon Fraser.

Add support for animating CSS images in the following properties:

  • background(-image)
  • border-image(-source)
  • list-style(-image)
  • -webkit-mask-box-image(-source)
  • -webkit-mask-image(-source)

This patch only adds support for transitioning between NinePieceImages
where all of the properties except the image itself are equal, and the
size of the images are equal. Other cases will not animate.

Add animation blend functions for StyleImage and NinePieceImage.

Apply the proper compositing operation to -webkit-cross-fade, and
fix handling of the destination and source areas to support scaling.

Tests: animations/cross-fade-background-image.html

animations/cross-fade-border-image-source.html
animations/cross-fade-list-style-image.html
animations/cross-fade-webkit-mask-box-image.html
animations/cross-fade-webkit-mask-image.html

  • css/CSSCrossfadeValue.cpp:

(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):

  • css/CSSImageValue.h:

(WebCore::CSSImageValue::create):

  • page/animation/AnimationBase.cpp:

(WebCore::crossfadeBlend):
(WebCore::blendFunc):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::RefCountedPropertyWrapper::blend):
(WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
(WebCore::FillLayerRefCountedPropertyWrapper::blend):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setMaskImage):

Add tests of -webkit-animation (using -webkit-cross-fade) between:

  • background-image
  • border-image
  • list-style-image
  • -webkit-mask-box-image
  • -webkit-mask-image

Add the ability for animation tests to compare an animated element to a static element.

Add tests of -webkit-transition (using -webkit-cross-fade) between:

  • background-image
  • border-image
  • animations/cross-fade-background-image-expected.txt: Added.
  • animations/cross-fade-background-image.html: Added.
  • animations/cross-fade-border-image-source-expected.txt: Added.
  • animations/cross-fade-border-image-source.html: Added.
  • animations/cross-fade-list-style-image-expected.txt: Added.
  • animations/cross-fade-list-style-image.html: Added.
  • animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
  • animations/cross-fade-webkit-mask-box-image.html: Added.
  • animations/cross-fade-webkit-mask-image-expected.txt: Added.
  • animations/cross-fade-webkit-mask-image.html: Added.
  • animations/resources/animation-test-helpers.js:

(parseCrossFade):
(checkExpectedValue):

  • animations/resources/blue-100.png: Added.
  • animations/resources/green-100.png: Added.
  • animations/resources/stripes-100.png: Added.
  • platform/mac/animations/cross-fade-background-image-expected.png: Added.
  • platform/mac/animations/cross-fade-border-image-source-expected.png: Added.
  • platform/mac/animations/cross-fade-list-style-image-expected.png: Added.
  • platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
  • platform/mac/animations/cross-fade-webkit-mask-image-expected.png: Added.
  • platform/mac/transitions/cross-fade-background-image-expected.png: Added.
  • platform/mac/transitions/cross-fade-border-image-expected.png: Added.
  • transitions/cross-fade-background-image-expected.txt: Added.
  • transitions/cross-fade-background-image.html: Added.
  • transitions/cross-fade-border-image-expected.txt: Added.
  • transitions/cross-fade-border-image.html: Added.
  • transitions/resources/transition-test-helpers.js:

(expected):

15:00 Changeset [102387] by commit-queue@webkit.org

[chromium] Set opaque() for VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73858

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-08
Reviewed by James Robinson.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::isVideoFrameFormatOpaque):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):

14:38 Changeset [102386] by dslomov@google.com

Merge 102317 - https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.

Reviewed by David Levin.

Source/WebCore:

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:

TBR=caseq@chromium.org
ISSUE=http://code.google.com/p/chromium/issues/detail?id=106797
Review URL: http://codereview.chromium.org/8883032

14:29 Changeset [102385] by senorblanco@chromium.org

Use Skia's implementation of Gaussian blur when accelerated filters
are enabled.
https://bugs.webkit.org/show_bug.cgi?id=73949

Reviewed by Zoltan Herczeg.

In the future, this will be covered by the SVG tests run in GPU mode.

  • WebCore.gypi:

Add FEGaussianBlurSkia.cpp to the build.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):
Call out to platformApplySkia() when USE_SKIA is enabled.

  • platform/graphics/filters/FEGaussianBlur.h:

platformApplySkia() declaration.

  • platform/graphics/filters/skia: Added.
  • platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.

(WebCore::FEGaussianBlur::platformApplySkia):
On the Skia port, use SkBlurImageFilter for drawing
Gaussian blurs in accelerated mode.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage):
Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.

14:20 Changeset [102384] by lforschler@apple.com

Versioning.

14:15 Changeset [102383] by lforschler@apple.com

New tag.

14:11 Changeset [102382] by cfleizach@apple.com

Tools: AX: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093

Reviewed by Darin Adler.

Take care of the case when an incoming element is null.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093

Reviewed by Darin Adler.

Unskip the crashing test.

  • platform/mac/Skipped:
14:08 Changeset [102381] by commit-queue@webkit.org

[Qt] Visualize mock point ID's in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74098

Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-08
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/qml/MockTouchPoint.qml:
14:02 WebKit Team edited by krit@webkit.org
(diff)
13:47 Changeset [102380] by msaboff@apple.com

Add 8 bit paths for StringTypeAdapter classes
https://bugs.webkit.org/show_bug.cgi?id=73882

Reviewed by Darin Adler.

Added is8Bit() method and writeTo(LChar*) methods
to StringTypeAdapter<> classes. The writeTo(LChar*)
method can be used if is8Bit() returns true. The
non-native 8 bit classes contain ASSERT(is8Bit())
in their writeTo(LChar*).

Updated all of the various versions of tryMakeString() to
use 8 bit processing in the updated StringTypeAdapter<>
classes.

This has slight if any performance improvement on kraken.

  • runtime/UStringConcatenate.h:
  • wtf/text/StringConcatenate.h:

(WTF::tryMakeString):

  • wtf/text/StringOperators.h:

(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):

13:29 Changeset [102379] by arv@chromium.org

CodeGeneratorV8: Fix issue with overloaded static conditional methods
https://bugs.webkit.org/show_bug.cgi?id=74114

Reviewed by Adam Barth.

The code generator was missing checks for Conditional for overloaded methods.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunctionCallback): Generate needed #ifdefs.
(GenerateFunctionCallback): Ditto.

  • bindings/scripts/test/V8/V8TestObj.cpp: Wrap conditional methods with #ifdefs.

(WebCore::ConfigureV8TestObjTemplate):

13:27 Changeset [102378] by dmazzoni@google.com

Source/WebCore: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866

Changes accessibilitySetShouldRepostNotifications from an instance method
into a class method so that it can be used for global notification listeners,
not just for listeners on a particular object.

Reviewed by Chris Fleizach.

Test: accessibility/notification-listeners.html

  • accessibility/mac/WebAccessibilityObjectWrapper.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(+[WebAccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):

Tools: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866

Adds addNotificationListener and removeNotificationListener methods
to AccessibilityController, to listen to notifications on any element
rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
implementations are all contained in this change.

On Mac, refactors AccessibilityNotificationHandler into its own
source file that can be used by both AccessibilityController and
AccessibilityUIElement. (Both DRT and WKTR.)

Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityController.cpp:

(addNotificationListenerCallback):
(removeNotificationListenerCallback):
(AccessibilityController::getJSClass):

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/chromium/AccessibilityController.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::notificationReceived):
(AccessibilityController::addNotificationListenerCallback):
(AccessibilityController::removeNotificationListenerCallback):

  • DumpRenderTree/chromium/AccessibilityController.h:
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
  • DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.

(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::addNotificationListener):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(notificationListenerProc):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
(AccessibilityController::winNotificationReceived):
(AccessibilityController::winAddNotificationListener):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::addNotificationListener):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:

(WTR::AccessibilityController::logAccessibilityEvents):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:

(WTR::AccessibilityTextMarker::AccessibilityTextMarker):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:

(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.

(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.

(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

LayoutTests: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866

Previously, the Mac implementation of AccessibilityUIElement.addNotificationListener
incorrectly triggered on notifications from all elements. Now it only triggers on
notifications from the correct element, and a new addNotificationListener method
in AccessibilityController can be used to trigger on notifications from all elements.

Updates 2 tests that depended on the old incorrect behavior.

Reviewed by Chris Fleizach.

  • accessibility/notification-listeners.html: Added.
  • platform/chromium/accessibility/notification-listeners-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications.html:
  • platform/mac/accessibility/aria-listbox-selectedchildren-change.html:
  • platform/mac/accessibility/notification-listeners-expected.txt: Added.
  • platform/win/Skipped:
13:23 Changeset [102377] by jer.noble@apple.com

HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly
https://bugs.webkit.org/show_bug.cgi?id=74119
rdar://problem/10356869

Reviewed by Darin Adler.

Use the Lion-only -[NSWindow convertRectToScreen:] function to convert between window
coordinates and screen coordinates.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):

13:21 Changeset [102376] by lforschler@apple.com

Merged r96777.

13:15 Changeset [102375] by vsevik@chromium.org

Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
https://bugs.webkit.org/show_bug.cgi?id=74120

Reviewed by Pavel Feldman.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForInspector):

  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForInspector):

  • bindings/v8/ScriptCallStackFactory.h:
13:11 Changeset [102374] by lforschler@apple.com

Merged r101719.

13:07 Changeset [102373] by enne@google.com

[chromium] Remove dead code in compositor
https://bugs.webkit.org/show_bug.cgi?id=74103

Reviewed by James Robinson.

Tested via the compiler.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
13:06 Changeset [102372] by lforschler@apple.com

Merged r101532.

13:05 Changeset [102371] by commit-queue@webkit.org

[chromium] Need to adjust memory limit and viewport multipliers.
https://bugs.webkit.org/show_bug.cgi?id=74022

Patch by Eric Penner <epenner@google.com> on 2011-12-08
Reviewed by James Robinson.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes): Changing constants
(WebCore::TextureManager::reclaimLimitBytes): ditto

13:03 Changeset [102370] by lforschler@apple.com

Merged r101290.

12:59 Changeset [102369] by abarth@webkit.org

Chromium DEPS roll 112974 -> 113603
https://bugs.webkit.org/show_bug.cgi?id=74105

Patch by Elliot Poger <epoger@google.com> on 2011-12-08
Reviewed by Adam Barth.

  • DEPS:
12:53 Changeset [102368] by benjamin@webkit.org

Add a platform EventLoop for iOS
https://bugs.webkit.org/show_bug.cgi?id=74043

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-08
Reviewed by David Kilzer.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/EventLoopIOS.mm: Added.

(WebCore::EventLoop::cycle):

12:47 Changeset [102367] by lforschler@apple.com

Merged r100483.

12:41 Changeset [102366] by pfeldman@chromium.org

Web Inspector: return node counts on the document / detached root basis
https://bugs.webkit.org/show_bug.cgi?id=74104

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::domNodeCount):

  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(WebCore::InspectorMemoryAgent::create):

12:34 Changeset [102365] by tony@chromium.org

[chromium] remove headers from WebKit.gyp that moved into WebKit/chromium/public/platform
https://bugs.webkit.org/show_bug.cgi?id=74106

Reviewed by Darin Fisher.

  • WebKit.gyp:
12:29 Changeset [102364] by kling@webkit.org

RenderObject: Rename styleSlowCase() to styleInRegion().

Rubber-stamped by David Hyatt.

  • WebCore.exp.in:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleInRegion):

  • rendering/RenderObject.h:

(WebCore::RenderObject::style):

12:21 Changeset [102363] by ossy@webkit.org

[Qt][WK2] Unreviewed buildfix after r102352.

Source/WebKit2:

  • DerivedSources.pri:

Tools:

  • qmake/mkspecs/features/webkit2.prf:
12:16 Changeset [102362] by peter@chromium.org

[Chromium] Exclude the four RenderTableCellDeathTest death tests for Android
https://bugs.webkit.org/show_bug.cgi?id=73997

The ASSERT_DEATH macro is not yet available in Google Test when
building for Android, which causes compilation errors. This code
will be removed once support lands in the GTest version Chromium
uses. See https://bugs.webkit.org/show_bug.cgi?id=74089.

Reviewed by Julien Chaffraix.

  • tests/RenderTableCellTest.cpp:
12:11 Changeset [102361] by commit-queue@webkit.org

IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
https://bugs.webkit.org/show_bug.cgi?id=73685

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-08
Reviewed by Darin Fisher.

Implementation to follow - this just extends the WebKit API.

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::count):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::count):

12:01 Changeset [102360] by kling@webkit.org

Optimize RenderObject::containingBlock().
<http://webkit.org/b/74109>

Reviewed by David Hyatt.

When climbing the parent chain to locate the containing block-level element,
use !isRenderBlock() to reject renderers rather than checking against an arbitrary
list of non-block renderers and then rejecting anything that isn't a block anyway.

RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

11:39 Changeset [102359] by nayankk@motorola.com

Define DEBUG_GL_COMMANDS only in debug builds.
https://bugs.webkit.org/show_bug.cgi?id=74083

Reviewed by Noam Rosenthal.

No tests added as this change does not affect functionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:
11:35 Changeset [102358] by caseq@chromium.org

Unreviewed. Removed suppressions for inspector extensions tests following a fix in r10231.

  • platform/chromium/test_expectations.txt:
11:32 Changeset [102357] by rniwa@webkit.org

CompositeEditCommand should not be kept alive for undo and redo
https://bugs.webkit.org/show_bug.cgi?id=64414

Reviewed by Enrica Casucci.

This patch introduces EditCommandComposition that replaces CompositeEditCommand for
undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands
to unapply and reapply edit commands that composes an undoable action.

Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition,
and applyCommandToComposite adds new SimpleEditCommands to the list.

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::create):
(WebCore::EditCommandComposition::doApply): Never used.
(WebCore::EditCommandComposition::doUnapply):
(WebCore::EditCommandComposition::doReapply):
(WebCore::EditCommandComposition::append):
(WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create
a composition for CompositeEditCommands that have parents.
(WebCore::CompositeEditCommand::doUnapply): Never used.
(WebCore::CompositeEditCommand::doReapply): Never used.
(WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition.
(WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition.

  • editing/CompositeEditCommand.h:

(WebCore::EditCommandComposition::EditCommandComposition):
(WebCore::CompositeEditCommand::composition):
(WebCore::toEditCommandComposition):
(WebCore::toCompositeEditCommand):

  • editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level

commands are now required to be a CompositeEditCommand.
(WebCore::RemoveTargetCommand::create):
(WebCore::RemoveTargetCommand::RemoveTargetCommand):
(WebCore::RemoveTargetCommand::doApply):
(WebCore::DeleteButtonController::deleteTarget):

  • editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition.
(WebCore::EditCommand::apply): Create a composition for a top-level command.
(WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are
added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition
from SimpleEditCommand. Use isEditCommandComposition() instead.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::compositionIfPossible):
(WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition.
(WebCore::EditCommand::setEndingSelection): Ditto.
(WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in
m_parent inside SimpleEditCommand when CompositeEditCommand goes away.

  • editing/EditCommand.h:

(WebCore::EditCommand::isSimpleEditCommand):
(WebCore::EditCommand::isCompositeEditCommand):
(WebCore::EditCommand::isEditCommandComposition):
(WebCore::EditCommand::parent):
(WebCore::toSimpleEditCommand):

  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand
to the undo stack.
(WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition.
(WebCore::Editor::reappliedEditing):

  • editing/Editor.h:
11:25 Changeset [102356] by senorblanco@chromium.org

Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74091

Reviewed by Kenneth Russell.

Will be covered by tests in css3/filters (when enabled).

  • bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.

(WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):

11:19 Changeset [102355] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=73348
REGRESSION: Assertion when loading a page with a scrollable RenderLayer
-and corresponding-
<rdar://problem/10518918>

Reviewed by Darin Adler.

The main problem here is that certain delegate calls into AppKit for overlay
scrollbars can cause AppKit to call back into WebKit looking for more information.
The assertion happens when WebKit tells AppKit that the scroll position has
changed during a layout, and AppKit immediately asks WebKit to convert some
coordinates, and WebKit asserts that you shouldn't do that while a layout is still
happening. It's still possible for AppKit to call this delegate method while a
layout is happening, and we should guard against that. This patch, however, does
not do that.

This change instead addresses the reason this assertion started happening much
more frequently recently, which is that it recently became true that
notifyPositionChanged() can be called when the position has not changed. To fix
the assertion AND the bug that that change was intended to fix, we can just make
sure that either the position OR the scroll origin has changed before calling
notifyPositionChanged().

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):

Call resetScrollOriginChanged() after the scroll instead of before so that we know
whether or not to call notifyPositionChanged().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

11:16 Changeset [102354] by aroben@apple.com

Make finding crash logs by PID work on Snow Leopard

Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
read the first line of the crash log and pull the PID out of there.

Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
Snow Leopard

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
name and PID for the log, rather than checking the Lion-only app_description extended
attribute. We now also reject the log if the process name doesn't match what we expect.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
PID.
(CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
(CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
the new make_mock_crash_report_darwin function. Also added tests for files that can't be
read, files that actually contain a crash log for some other process, and files that are
misformatted.

  • Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now

unused.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.init): Removed xattr support, which is now unused.
(MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
ReadableTextFileObject. This function was completely broken before!
(ReadableBinaryFileObject.init): Made the data parameter non-optional to try to prevent
bugs like the above.
(ReadableTextFileObject.init): Added. Wraps the data in a StringIO object so we can do
things like readline() and seek().

(ReadableTextFileObject.close):
(ReadableTextFileObject.read):
Added. We override the superclass implementation to account for using a StringIO object.

(ReadableTextFileObject.readline):
(ReadableTextFileObject.seek):
Added. These just call through to StringIO.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
Changed to use make_mock_crash_report_darwin.

11:12 Changeset [102353] by commit-queue@webkit.org

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73866

Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.

  • fast/regions/positioned-objects-block-static-in-regions-expected.html: Added.
  • fast/regions/positioned-objects-block-static-in-rtl-regions-expected.html: Added.
  • fast/regions/positioned-objects-block-static-spanning-regions-expected.html: Added.
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html: Added.
  • platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
11:06 Changeset [102352] by jonlee@apple.com

[WK2] Add permissions support (73960)
https://bugs.webkit.org/show_bug.cgi?id=73960
<rdar://problem/10357008>

Reviewed by Darin Adler.

Source/WebKit2:

  • DerivedSources.make: Moved notification files to its own directory. Need to add that path.
  • WebKit2.xcodeproj/project.pbxproj: New header and impl files.
  • Target.pri: Ditto.
  • GNUmakefile.am: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • win/WebKit2Common.vsprops: Add path to Notifications directory.

Implement permission functions, which go through permission request manager.

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::requestPermission):
(WebKit::WebNotificationClient::cancelRequestsForPermission):
(WebKit::WebNotificationClient::checkPermission):

New NotificationPermissionRequestManager to make and cancel permission requests, and to retrieve current
policy.

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Added.

(WebKit::generateRequestID):
(WebKit::NotificationPermissionRequestManager::create):
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
(WebKit::NotificationPermissionRequestManager::startRequest): Keep track of the provided callback once
policy decision is made.
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel): Retrieve level through a synchronous
message to the proxy.
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision): Invoke the callback.

  • WebProcess/Notifications/NotificationPermissionRequestManager.h: Added.

(WebKit::isRequestIDValid): Make sure any provided request IDs are valid.

Added new NotificationPermissionRequest class.

  • UIProcess/Notifications/NotificationPermissionRequest.cpp: Added.

(WebKit::NotificationPermissionRequest::create):
(WebKit::NotificationPermissionRequest::NotificationPermissionRequest):
(WebKit::NotificationPermissionRequest::allow): Notify manager of decision.
(WebKit::NotificationPermissionRequest::deny): Ditto.
(WebKit::NotificationPermissionRequest::invalidate): Disassociate with manager.
(WebKit::NotificationPermissionRequest::type):

  • UIProcess/Notifications/NotificationPermissionRequest.h: Added.

WKAPI support for NotificationPermissionRequest:

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKNotificationPermissionRequest.cpp: Added.

(WKNotificationPermissionRequestGetTypeID):
(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):

  • UIProcess/API/C/WKNotificationPermissionRequest.h: Added.

Other additions to WK API:

  • UIProcess/API/C/WKNotificationProvider.h: Added new callback for WKNotificationProviders, to return policy

for a given security origin.

  • UIProcess/API/C/WKPage.h: Added new callback to WKPageUIClient to ask user to decide on policy.

New NotificationPermissionRequestManagerProxy to create requests.

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: Added.

(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::createRequest):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: Added.

Added new message to notification manager: NotificationPermissionLevel, to retrieve policy. The current
JS API retrieves the permission synchronously, so the message needs to be sent synchronously also.

  • UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.messages.in.
  • UIProcess/Notifications/WebNotificationProvider.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.cpp.

(WebKit::WebNotificationProvider::policyForNotificationPermissionAtOrigin): Added.

  • UIProcess/Notifications/WebNotificationProvider.h: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.h.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage): Boilerplate to forward messages to notification manager.

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.cpp.

(WebKit::WebNotificationManagerProxy::create):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::invalidate):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::didReceiveSyncMessage):
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::notificationPermissionLevel): Retrieve the policy from the provider.
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

  • UIProcess/Notifications/WebNotificationManagerProxy.h: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.h.

(WebKit::WebNotificationManagerProxy::clearContext):
(WebKit::WebNotificationManagerProxy::type):

Added NotificationPermissionRequestManagerProxy to WebPageProxy, to allow a request for permission to
go through to the UI client. Added new message to WebPageProxy, RequestNotificationPermission.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close): Invalidate pending requests.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::requestNotificationPermission): Forward request to UI client.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):

  • UIProcess/WebUIClient.h:

Added new message DidReceiveNotificationPermissionDecision. The WebPage forwards the message to the
permission request manager.

  • WebProcess/WebPage/WebPage.messages.in: Added new message DidReceiveNotificationPermissionDecision
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::notificationPermissionRequestManager): Create manager on request.
(WebKit::WebPage::didReceiveNotificationPermissionDecision):

  • WebProcess/WebPage/WebPage.h:

Moving files to Notifications/ subdirectory.

  • UIProcess/Notifications/WebNotification.cpp: Moved from Source/WebKit2/UIProcess/WebNotification.cpp.
  • UIProcess/Notifications/WebNotification.h: Moved from Source/WebKit2/UIProcess/WebNotification.h.

Tools:

Add null function item to comply with added callback to WKPageUIClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

10:55 Changeset [102351] by commit-queue@webkit.org

Fixing support for static conditional overloaded functions.
https://bugs.webkit.org/show_bug.cgi?id=74068

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-12-08
Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): Pushing "static" keyword after condition "#if".

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::overloadedMethod1): Added newly generated bindings.

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.

(webkit_dom_test_obj_overloaded_method1):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.

(-[DOMTestObj overloadedMethod1:]):

  • bindings/scripts/test/TestObj.idl: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::ConfigureV8TestObjTemplate):

10:53 Changeset [102350] by commit-queue@webkit.org

Added a test for css number types problem.
It's testing the css number types parser, where 'px' defined like escape sequences (\70\78) or uppercase / lowercase.
https://bugs.webkit.org/show_bug.cgi?id=72007

Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.

  • fast/css/parsing-css-number-types-expected.txt: Added.
  • fast/css/parsing-css-number-types.html: Added.
10:50 Changeset [102349] by kling@webkit.org

Remove EventListenerMap destructor.
<http://webkit.org/b/74096>

Reviewed by Darin Adler.

Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
was managing raw pointers.

We're losing the no-iterators assertion from clear() by doing this, but that was
superfluous to begin with - we were just using it to avoid duplicating code.

  • dom/EventListenerMap.cpp:
  • dom/EventListenerMap.h:
10:38 Changeset [102348] by commit-queue@webkit.org

[Qt] Visualize mock points in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74074

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-08
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:
  • MiniBrowser/qt/icons/touchpoint.png: Added.
  • MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
10:23 Changeset [102347] by tony@chromium.org

[chromium] Rebaseline printing/width-overflow.html on Chromium Mac Leopard.

  • platform/chromium-cg-mac-snowleopard/printing/width-overflow-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.png.
  • platform/chromium-linux/printing/width-overflow-expected.txt: Removed.
  • platform/chromium-mac-leopard/printing/width-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Removed.
  • platform/chromium/printing/width-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.txt.
09:57 Changeset [102346] by nayankk@motorola.com

[WebKit2] Initialize threading in UI process.
https://bugs.webkit.org/show_bug.cgi?id=70127

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/APIObject.cpp: Added.

(WebKit::APIObject::APIObject):

  • Shared/APIObject.h:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
09:25 Changeset [102345] by lforschler@apple.com

Merged r99912.

09:23 Changeset [102344] by lforschler@apple.com

Merged r99911.

08:36 Changeset [102343] by dmazzoni@google.com

Unreviewed, skipping failing test platform/mac/accessibility/search-with-frames.html

08:16 Changeset [102342] by commit-queue@webkit.org

[Qt] [WK2] Directly composited images doesn't render
https://bugs.webkit.org/show_bug.cgi?id=74058

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.

Attach image to WebGraphicsLayer even if layerTreeTileClient is not set
and create/assign remote image tiles later during sync.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

08:06 Changeset [102341] by hausmann@webkit.org

REGRESSION(r102334): Various Qt WK2 layout tests crash

Reviewed by Tor Arne Vestbø.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState): Add missing null pointer check for the editable
element (scope) before calling innerText.

07:46 Changeset [102340] by hausmann@webkit.org

[Qt] WebKitTestRunner crashes with debug builds https://bugs.webkit.org/show_bug.cgi?id=74090

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Export private C++ API style platformInitialize function needed
by low-level WTR.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::platformInitialize):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
to ensure WTF/JSC threading is initialized.

07:45 Changeset [102339] by commit-queue@webkit.org

Provide more specific error description for SocketStreamError.
https://bugs.webkit.org/show_bug.cgi?id=74066

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Martin Robinson.

No new tests because this change just improve error messages for unexpected failures.

  • platform/network/soup/SocketStreamError.h: Add an argument for passing error description.

(WebCore::SocketStreamError::SocketStreamError):

  • platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.

(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

07:32 Changeset [102338] by jocelyn.turcotte@nokia.com

[Qt] Fix non-animated pinch-zoom scale commit.
https://bugs.webkit.org/show_bug.cgi?id=74007

Reviewed by Kenneth Rohde Christiansen.

The update deferrer object was only destroyed at the end of the animation
and wouldn't be if the pinch-zoom was ended within legal bounds.
This patch also makes sure that the deferrer isn't destroyed and re-created
once the animation is started if it was already there.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):

  • UIProcess/qt/QtViewportInteractionEngine.h:
07:30 Changeset [102337] by hausmann@webkit.org

REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=74077

Reviewed by Kenneth Rohde Christiansen.

Replace Desktop OpenGL idiom of using gl_Vertex with a simple vertex attribute
that's tied to the same register 0 (by being the first in the array).

  • UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyMaterialShader::attributeNames): Define "vertex" attribute, which is
bound to register 0, which is the current vertex.
(PageProxyMaterialShader::vertexShader): Use the vertex attribute instead of the
built-in gl_Vertex, which is only present in Desktop GL.

07:29 Changeset [102336] by jocelyn.turcotte@nokia.com

[Qt] Fix the memory leak of AC layer update message contents on the UI process.
https://bugs.webkit.org/show_bug.cgi?id=74012

Reviewed by Noam Rosenthal.

Since the messages didn't have a virtual destructor, the destructor
of child class members wouldn't be called and would cause the all tile
update buffers, contained in a QImage, to be leaked as well.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):

06:50 Changeset [102335] by dpranke@chromium.org

fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031

Reviewed by Tony Chang.

  • Scripts/webkitdirs.pm:

(buildChromium):

06:27 Changeset [102334] by kenneth@webkit.org

Upsteam the Qt changes to the EditorState https://bugs.webkit.org/show_bug.cgi?id=74080

Reviewed by Simon Hausmann.

We are not doing the serialization manually due to it not being a POD
structure anymore in the case of Qt.

  • GNUmakefile.am:
  • Shared/EditorState.h:

(WebKit::EditorState::EditorState):

  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

  • win/WebKit2.vcproj:
06:23 Changeset [102333] by mihnea@adobe.com

[CSSRegions][CSSOM] Implement NamedFlow interface
https://bugs.webkit.org/show_bug.cgi?id=66642

Reviewed by David Hyatt.

Add WebKitNamedFlow to support the NamedFlow interface. No methods are
yet implemented on this interface. The NamedFlow object is a live object.
The first time user asks for it, it gets a valid JS object whose properties
will reflect the changes to the flow thread.

Source/WebCore:

Tests: fast/regions/webkit-named-flow-existing-flow.html

fast/regions/webkit-named-flow-flow-added.html
fast/regions/webkit-named-flow-modified-flow.html
fast/regions/webkit-named-flow-non-existing-flow.html
fast/regions/webkit-named-flow-removed-flow.html
fast/regions/webkit-named-flow-same-object.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:
  • dom/Document.idl:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • dom/WebKitNamedFlow.cpp: Added.

(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::~WebKitNamedFlow):

  • dom/WebKitNamedFlow.h: Added.

(WebCore::WebKitNamedFlow::create):

  • dom/WebKitNamedFlow.idl: Added.
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::ensureNamedFlow):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderView.cpp:

(WebCore::RenderView::ensureRenderFlowThreadWithName):

  • rendering/RenderView.h:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
  • fast/regions/webkit-named-flow-existing-flow.html: Added.
  • fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
  • fast/regions/webkit-named-flow-flow-added.html: Added.
  • fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
  • fast/regions/webkit-named-flow-modified-flow.html: Added.
  • fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
  • fast/regions/webkit-named-flow-non-existing-flow.html: Added.
  • fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
  • fast/regions/webkit-named-flow-removed-flow.html: Added.
  • fast/regions/webkit-named-flow-same-object-expected.txt: Added.
  • fast/regions/webkit-named-flow-same-object.html: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
05:04 Changeset [102332] by haraken@chromium.org

Unreviewed, rolling out r102280.
http://trac.webkit.org/changeset/102280
https://bugs.webkit.org/show_bug.cgi?id=74031

Chromium/Windows build is broken

  • Scripts/webkitdirs.pm:

(buildChromium):

03:52 Changeset [102331] by hausmann@webkit.org

2011-12-08 Gopal Raghavan <gopal.1.raghavan@nokia.com>

[Qt] cleanup qmlplugin
https://bugs.webkit.org/show_bug.cgi?id=73834

Reviewed by Tor Arne Vestbø.

Removed empty folder qmlplugin.

03:24 Changeset [102330] by commit-queue@webkit.org

Unreviewed, rolling out r102321.
http://trac.webkit.org/changeset/102321
https://bugs.webkit.org/show_bug.cgi?id=74072

"Breaks all Chromium clobbered builds" (Requested by apavlov_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
03:09 Changeset [102329] by nayankk@motorola.com

Adding myself to committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
02:46 Changeset [102328] by commit-queue@webkit.org

Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
https://bugs.webkit.org/show_bug.cgi?id=74033

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-08
Reviewed by Hajime Morita.

SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
pass necessary information to requestCheckingFor.

No new tests. Covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

Uses the new interface.

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.

  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::~SpellCheckRequest):
(WebCore::SpellCheckRequest::create):

Creates a new SpellCheckRequest object.

(WebCore::SpellChecker::requestCheckingFor):

Uses the new interface.

(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

(WebCore::SpellCheckRequest::setSequence):
(WebCore::SpellCheckRequest::sequence):
(WebCore::SpellCheckRequest::checkingRange):
(WebCore::SpellCheckRequest::paragraphRange):
(WebCore::SpellCheckRequest::text):
(WebCore::SpellCheckRequest::mask):
(WebCore::SpellCheckRequest::rootEditableElement):

02:44 Changeset [102327] by commit-queue@webkit.org

Fix failed layout test, bufferedAmount-after-close-in-busy.html
https://bugs.webkit.org/show_bug.cgi?id=73666

Originally the failed layout test use simple_wsh server side WebSocket
handler. But this handler starts closing handshake after a while and
it bring flakiness on the test.
Now the test use echo_wsh instead of simple_wsh. It never perform
server initiated closing handshake.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • platform/gtk/Skipped:
02:37 Changeset [102326] by kbalazs@webkit.org

Unreviewed gardening.

Remove duplicated entries from skipped list.

  • platform/qt-5.0/Skipped:
02:26 Changeset [102325] by ossy@webkit.org

[WK2] Unreviewed gardening.

WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689

  • platform/wk2/Skipped: Skip new failing tests.
02:12 Changeset [102324] by commit-queue@webkit.org

Unreviewed, rolling out r102323.
http://trac.webkit.org/changeset/102323
https://bugs.webkit.org/show_bug.cgi?id=74069

Caused Chromium and GTK build failure (Requested by bashi on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • testing/Internals.cpp:

(WebCore::Internals::getPageScaleFactor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/scaling/tiled-layer-recursion.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
01:18 Changeset [102323] by fsamuel@chromium.org

Move scalePageBy from eventSender to window.internals
https://bugs.webkit.org/show_bug.cgi?id=64512

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.

  • testing/Internals.cpp:

(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Updated layout tests to use window.internals.setPageScaleFactor.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/scaling/tiled-layer-recursion.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
01:01 Writing Layout Tests for DumpRenderTree edited by shinyak@google.com
(diff)
00:48 Changeset [102322] by bashi@chromium.org

Unreviewed, remove duplicate test expectations.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

  • platform/chromium/test_expectations.txt:
00:20 Changeset [102321] by haraken@chromium.org

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.

12/07/11:

23:53 Changeset [102320] by commit-queue@webkit.org

CSS color gets adjusted for disabled input elements
https://bugs.webkit.org/show_bug.cgi?id=54643

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-07
Reviewed by Kent Tamura.

Source/WebCore:

No new tests. covered by existing tests. Need rebasing some existing tests for Chromimum.

Remove automatic color adjustment for disabled text control for Chromimum.

  • css/themeChromium.css: Add CSS entries for default style for disabled input and textarea elements.
  • WebCore/rendering/RenderTextControl.cpp:

(disabledTextColor): Removed for PLATFORM(CHROMIUM)
(RenderTextControl::adjustInnerTextStyle): Don't call disabledTextColor for Chromium.

LayoutTests:

  • platform/chromium/test_expectations.txt: Add files need to be updated.
23:33 Changeset [102319] by mrowe@apple.com

Fix the 32-bit build.

Ignore some warnings that only occur in 32-bit.

Source/WebKit/mac:

  • Plugins/WebNetscapePluginPackage.mm:

Source/WebKit2:

  • PluginProcess/mac/PluginProcessShim.mm:
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

23:31 Changeset [102318] by ossy@webkit.org

[Qt] Unreviewed buildfix after r102262.

  • Api/qwebelement.cpp:

(QWebElement::setStyleProperty):

22:59 Changeset [102317] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.

Reviewed by David Levin.

Source/WebCore:

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
22:50 Changeset [102316] by bashi@chromium.org

Unreviewed, rebaseline media/controls-layout-direction.html

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07

  • platform/chromium-cg-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-win/media/controls-layout-direction-expected.png: Added.
22:29 Changeset [102315] by bashi@chromium.org

Unreviewed chromium test expectation update.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07

  • platform/chromium/test_expectations.txt:
22:01 Changeset [102314] by commit-queue@webkit.org

Upstream 4 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73541

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Antonio Gomes.

Initial upstream of BlackBerry porting of PlatformScreen/
SSLKeyGenerator/Sound/Widget, no new tests.

  • PlatformBlackBerry.cmake: Modified to remove empty file "WheelEventBlackBerry.cpp"
  • platform/blackberry/PlatformScreenBlackBerry.cpp: Added.

(WebCore::screenIsMonochrome):
(WebCore::screenDepthPerComponent):
(WebCore::screenDepth):
(WebCore::screenAvailableRect):
(WebCore::screenRect):

  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp: Added.

(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):

  • platform/blackberry/SoundBlackBerry.cpp: Added.

(WebCore::systemBeep):

  • platform/blackberry/WidgetBlackBerry.cpp: Added.

(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::hide):
(WebCore::Widget::paint):
(WebCore::Widget::setCursor):
(WebCore::Widget::setFocus):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::show):
(WebCore::Widget::frameRect):

21:38 Changeset [102313] by bashi@chromium.org

Refactor CSSParser::parseFontFaceSrc()
https://bugs.webkit.org/show_bug.cgi?id=73989

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-src-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceSrcURI): Added.
(WebCore::CSSParser::parseFontFaceSrcLocal): Added.
(WebCore::CSSParser::parseFontFaceSrc): Rewrote.

  • css/CSSParser.h:

LayoutTests:

Added a test that checks parsing result of the src descriptor of @font-face.

  • fast/css/font-face-src-parsing-expected.txt: Added.
  • fast/css/font-face-src-parsing.html: Added.
21:23 Changeset [102312] by commit-queue@webkit.org

Implement the SSE optimization in SincResampler::process()
https://bugs.webkit.org/show_bug.cgi?id=73789

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2011-12-07
Reviewed by Benjamin Poulain.

Here is about 70% performance improvement on the hot spot of sample convolving.

  • platform/audio/SincResampler.cpp:
21:08 Changeset [102311] by macpherson@chromium.org

Implement border image source properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73981

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyBorderImageSource::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

20:58 Changeset [102310] by noel.gordon@gmail.com

WebPImageDecoder should not do a full image decode if progressive decoding is active
https://bugs.webkit.org/show_bug.cgi?id=74041

Reviewed by Adam Barth.

If the decoder input data state reaches allDataReceived during a progressive image
decode, the decoder performs a full image decode.

On allDataReceived, check if we already have a decoder, and if so, continue to run
the progressive decoder.

No new tests. No change in behavior.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

20:42 Changeset [102309] by bashi@chromium.org

Unreviewed chromium expectations update.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07

  • platform/chromium/test_expectations.txt:
20:35 Changeset [102308] by commit-queue@webkit.org

[chromium] Add page-scale animation support to Impl thread
https://bugs.webkit.org/show_bug.cgi?id=72996

Patch by Alexandre Elias <aelias@google.com> on 2011-12-07
Reviewed by James Robinson.

This adds a new math helper class to compute the progress of the
animation, and code in the CCLayerTreeHostImpl to apply the animation
frame by frame.

No new tests. (https://bugs.webkit.org/show_bug.cgi?id=71529 filed.)

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Added.

(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::initialize):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::zoomElsewhere):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):
(WebCore::CCPageScaleAnimation::scrollOffsetAtRatio):
(WebCore::CCPageScaleAnimation::pageScaleAtRatio):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.h: Added.

(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):
(WebCore::CCPageScaleAnimation::finalScrollOffset):
(WebCore::CCPageScaleAnimation::finalPageScale):

Source/WebKit/chromium:

  • public/WebCompositor.h:
  • public/WebInputEvent.h:

(WebKit::WebPageScaleAnimationEvent::WebPageScaleAnimationEvent):

  • public/android/WebInputEventFactory.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handlePageScaleAnimationEvent):

  • src/WebCompositorImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::pageScaleAnimationEvent):

20:25 Changeset [102307] by commit-queue@webkit.org

Editor::markAndReplaceFor should take Range instead of TextCheckingParagraph.
https://bugs.webkit.org/show_bug.cgi?id=74035

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-07
Reviewed by Hajime Morita.

Editor::markAndReplaceFor takes chekcing range and paragraph range instead of
spelling paragraph and grammar paragraph.

No new tests. Covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::markAndReplaceFor):

  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::TextCheckingParagraph):

  • editing/TextCheckingHelper.h:
20:13 Changeset [102306] by commit-queue@webkit.org

Force LTR layout for media controls even in RTL documents.
https://bugs.webkit.org/show_bug.cgi?id=74024

Patch by Ami Fischman <fischman@chromium.org> on 2011-12-07
Reviewed by Darin Adler.

Source/WebCore:

Test: media/controls-layout-direction.html

  • css/mediaControls.css:

(::-webkit-media-controls):

LayoutTests:

  • media/controls-layout-direction-expected.txt: Added.
  • media/controls-layout-direction.html: Added.
  • platform/chromium-linux/media/controls-layout-direction-expected.png: Added.
19:55 Changeset [102305] by commit-queue@webkit.org

[FileSystem API] requestFileSystem successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69637

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-07
Reviewed by Darin Adler.

Source/WebCore:

  • page/DOMWindow.idl: remove [Optional] flag from successCallback parameter

LayoutTests:

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: fix now-broken logic testing for unrelated bug
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/not-enough-arguments.html: add checks for webkitRequestFileSystem with not enough parameters
19:43 Changeset [102304] by simonjam@chromium.org

[Chromium] Unreviewed, rebaseline width-overflow.html and fix test_expectations.txt

  • platform/chromium-cg-mac/printing/width-overflow-expected.png: Added.
  • platform/chromium-cg-mac/printing/width-overflow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/printing/width-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Added.
  • platform/chromium-win/printing/width-overflow-expected.png: Added.
  • platform/chromium-win/printing/width-overflow-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:38 Changeset [102303] by leo.yang@torchmobile.com.cn

Upstream the BlackBerry porting of network Resource
https://bugs.webkit.org/show_bug.cgi?id=73388

Reviewed by Rob Buis.

Other main contributors:
Joe Mason <jmason@rim.com>
Yong Li <yoli@rim.com>
Gary Simmons <gsimmons@rim.com>
Genevieve Mak <gmak@rim.com>
Chris Guan <chris.guan@torchmobile.com.cn>
Mike Lattanzio <mlattanzio@rim.com>

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/ResourceError.h: Added.
  • platform/network/blackberry/ResourceErrorBlackBerry.cpp: Added.
  • platform/network/blackberry/ResourceHandleBlackBerry.cpp: Added.
  • platform/network/blackberry/ResourceRequest.h: Added.
  • platform/network/blackberry/ResourceRequestBlackBerry.cpp: Added.
  • platform/network/blackberry/ResourceResponse.h: Added.
  • platform/network/blackberry/ResourceResponseBlackBerry.cpp: Added.
19:11 Changeset [102302] by fpizlo@apple.com

DFG CSE should know that CheckFunction is pure
https://bugs.webkit.org/show_bug.cgi?id=74044

Reviewed by Oliver Hunt.

Possible slight win on V8, no regressions.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::checkFunctionElimination):

19:03 Changeset [102301] by fsamuel@chromium.org

[Chromium] Plumb DPI info into PlatformScreen
https://bugs.webkit.org/show_bug.cgi?id=70556

Source/WebCore:

Reviewed by Darin Fisher.

Make DPI information accessible from WebKit through
PlatformScreen. This is useful when making scaling
computations on various devices (e.g. Viewport meta tag).

This patch adds DPI plumbing on Chromium Win/Mac/Linux
platforms.

  • page/Screen.cpp:

(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):

  • page/Screen.h:
  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/chromium/PlatformSupport.h:
  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

Source/WebKit/chromium:

Reviewed by Darin Fisher.

Make DPI information accessible from WebKit through
PlatformScreen. This is useful when making scaling
computations on various devices (e.g. Viewport meta tag).

This patch adds DPI plumbing on Chromium Win/Mac/Linux
platforms.

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenHorizontalDPI):
(WebCore::PlatformSupport::screenVerticalDPI):

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/x11/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

18:45 Changeset [102300] by commit-queue@webkit.org

Revert mixed content handling for video fix and follow-up test expectations & Skipped changes.
(r101883, r101918, r101927, r101981, r101986, r101997)
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-07
Reviewed by Adam Barth.

Source/WebCore:

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

  • http/tests/security/mixedContent/insecure-video-in-iframe-expected.txt: Removed.
  • http/tests/security/mixedContent/insecure-video-in-iframe.html: Removed.
  • http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • http/tests/security/mixedContent/insecure-video-in-main-frame.html: Removed.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html: Removed.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame-expected.txt: Removed.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html: Removed.
  • http/tests/security/mixedContent/resources/frame-with-insecure-video.html: Removed.
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html: Removed.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-video.html: Removed.
  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
18:27 Changeset [102299] by tkent@chromium.org

[Qt] Follow up of r102226.
https://bugs.webkit.org/show_bug.cgi?id=73987

  • platform/qt-5.0/Skipped: Renamed three number tests.
18:19 Changeset [102298] by msaboff@apple.com

StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
https://bugs.webkit.org/show_bug.cgi?id=73995

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Problem was that a call to characters on an StringImpl associated
with a StringBuilder that is being appended to gets stale.
Added a new m_valid16BitShadowlen that keeps the length of
the 16 bit shadow that has been upconverted or will be up converted
with the first getCharacters(). When StringBuilder::characters or
::reifyString is called, further characters are upconverted if
we have a shadow16bit copy and the m_valid16BitShadowlen is updated.

(WTF::StringBuilder::reifyString):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::characters):
(WTF::StringBuilder::clear): Cleaned up as part of the change.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upconvertCharacters):

  • wtf/text/StringImpl.h:

Tools:

Reenabled failing tests that the code part of the patch fixes.

Reviewed by Geoffrey Garen.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

18:11 Changeset [102297] by ryuan.choi@samsung.com

[EFL] Introduce AssertMatchingEnums.cpp.
https://bugs.webkit.org/show_bug.cgi?id=65238

Reviewed by Filip Pizlo.

Source/WebCore:

Remove switch statement which convert EWK_TOUCH_PointType enum values to
WebCore::PlatformTouchPoint::State enum values.
Newly added AssertMatchingEnums.cpp assure that they are equal.

No new tests, no new functionality.

  • platform/efl/PlatformTouchEventEfl.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

Source/WebKit/efl:

Add AssertMatchingEnums.cpp to assert that various WebKit API enum values
match to WebCore defined enum values.

  • CMakeListsEfl.txt: add AssertMatchingEnums.cpp.
  • WebCoreSupport/AssertMatchingEnums.cpp: Added.
  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event): remove switch statement wichi convert WebKit API enum value to WebCore defined enum values.
(ewk_frame_text_selection_type_get): Ditto.

  • ewk/ewk_view.cpp:

(ewk_view_mode_set): Ditto.
(ewk_view_mode_get): Ditto.
(ewk_view_visibility_state_set): Ditto.
(ewk_view_visibility_state_get): Ditto.

  • ewk/ewk_frame.h: fix order of enum values.
  • ewk/ewk_view.h: add missing enum value.
18:09 Changeset [102296] by morrita@google.com

[filter-build-webkit] should not emit reset color when --no-color is given
https://bugs.webkit.org/show_bug.cgi?id=73992

Reviewed by Daniel Bates.

Stop printing control sequences when --no-color is given.
After this change, the filter runs nicely even on environments
like Emacs compilation-mode which cannot understand the control sequence.

  • Scripts/filter-build-webkit:

(printLine):

18:09 Changeset [102295] by fpizlo@apple.com

Compare and Swap should be enabled on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=74023

Reviewed by Geoff Garen.

Implemented weakCompareAndSwap in terms of LDREX/STREX and enabled PARALLEL_GC.
It gives the expected speed-up on multi-core ARMv7 devices.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Platform.h:
18:02 Changeset [102294] by commit-queue@webkit.org

[chromium] Clearing root surface should happen after damage tracking
https://bugs.webkit.org/show_bug.cgi?id=73958

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-12-07
Reviewed by James Robinson.

No new semantics, covered by existing layout tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearSurfaceForDebug):
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
18:01 Changeset [102293] by fpizlo@apple.com

DFG CSE is overzealous with GetByVal
https://bugs.webkit.org/show_bug.cgi?id=74042

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Made sure that the purity of GetByVal and the limited-clobber-itude of PutByVal
is tested in all places that matter.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::byValIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-get-by-val-getter-cse-expected.txt: Added.
  • fast/js/dfg-get-by-val-getter-cse.html: Added.
  • fast/js/script-tests/dfg-get-by-val-getter-cse.js: Added.

():

17:53 Changeset [102292] by commit-queue@webkit.org

[chromium] Preserve original pageScale limits in WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=72983

Patch by Alexandre Elias <aelias@google.com> on 2011-12-07
Reviewed by Darin Fisher.

Preserve the originally viewport-tag specified page scale limits, and
compute the final ones in a new private method
computePageScaleFactorLimits(). This is then called when contents
size change (which can affect the minimum).

Also clean up several minor bugs, namely clamping issues (reorder
clampNegativeToZero to avoid negative scroll offsets, and force max to
be greater than min), and incorrect behavior in the presence of
"solid" scrollbars.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::contentsSizeChanged):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::clampPageScaleFactorToLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::didChangeContentsSize):

  • src/WebViewImpl.h:
17:50 Changeset [102291] by eric@webkit.org

Use free memory to determine if we have space for DRT instances instead of total memory
https://bugs.webkit.org/show_bug.cgi?id=74021

Reviewed by Adam Barth.

This will hopefully make the Mac buildbots behave better.

I also reduced the expected memory needed per DRT now that
we're properly accounting for the system memory in our calculations.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.total_bytes_memory):
(PlatformInfo._compute_free_bytes_from_vm_stat_output):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.total_bytes_memory):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):

17:44 Changeset [102290] by commit-queue@webkit.org

<li value="0"> behaves like <li> (the same for negative numbers)
https://bugs.webkit.org/show_bug.cgi?id=73911

Patch by Florin Malita <fmalita@google.com> on 2011-12-07
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Allow LI values <= 0 and consolidate the value processing logic.

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::parseMappedAttribute):
Delegated value parsing to parseValue().

(WebCore::HTMLLIElement::attach):
Ditto. Explicit value null testing is no longer necessary,
as parseValue's toInt() performs an equivalent check.

(WebCore::HTMLLIElement::parseValue):
Consolidated value parsing logic.

  • html/HTMLLIElement.h:

LayoutTests:

Added tests for values <= 0.

  • fast/lists/li-values-expected.txt:
  • fast/lists/li-values.html:
17:33 Changeset [102289] by commit-queue@webkit.org

IndexedDB: Replace bool args in IDBKeyRange private methods with enum
https://bugs.webkit.org/show_bug.cgi?id=70743

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.

No new tests - no functional changes.

  • storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::IDBKeyRange):
(WebCore::IDBKeyRange::bound):

  • storage/IDBKeyRange.h:

(WebCore::IDBKeyRange::create):
(WebCore::IDBKeyRange::lowerOpen):
(WebCore::IDBKeyRange::upperOpen):

17:19 Changeset [102288] by lforschler@apple.com

Fix a compiler error about implicit conversion from 64 to 32bit int.

Reviewed by Beth Dakin.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

16:52 Changeset [102287] by kerz@chromium.org

add codereview settings file

16:49 Changeset [102286] by kerz@chromium.org

Merge 102180 - [chromium] Don't crash if tile upload happens without painting first
https://bugs.webkit.org/show_bug.cgi?id=73939

Reviewed by James Robinson.

Remove at least one place (in ImageLayerChromium) where this could
happen.

Although this shouldn't happen, we should be robust to it in the
chance that other code causes it to.

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

TBR=enne@google.com

16:45 Changeset [102285] by lforschler@apple.com

Merged r99617.

16:35 Changeset [102284] by lforschler@apple.com

Merge 99493

16:32 Changeset [102283] by commit-queue@webkit.org

Exposing boundsInScreenSpace in WebElement.
https://bugs.webkit.org/show_bug.cgi?id=71579

Exposing boundsInScreenSpace through a new function,
boundsInViewportSpace, to assist in moving the Autofill UI out of
WebKit in Chromium. Renamed the exposed function to provide a better
meaning of what the function does in the Chromium code.
More information can be found at:
http://crbug.com/51644

Patch by Chris Sharp <csharp@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.

  • public/WebElement.h:
  • src/WebElement.cpp:

(WebKit::WebElement::boundsInViewportSpace):

16:28 Changeset [102282] by commit-queue@webkit.org

Unreviewed, rolling out r102267.
http://trac.webkit.org/changeset/102267
https://bugs.webkit.org/show_bug.cgi?id=74032

Breaks build on Chromium Mac Debug (Requested by aklein on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-07

Source/JavaScriptCore:

  • wtf/HashTraits.h:

Source/WebCore:

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::decrementScopingLevel):

16:25 Changeset [102281] by haraken@chromium.org

REGRESSION (r95249): Right side can be truncated when printing
https://bugs.webkit.org/show_bug.cgi?id=73868

Reviewed by Darin Adler.

Source/WebCore:

When we print a page with an overflowed width, the right side of the page
can be truncated. This is due to a wrong rendering calculation.
Since 'maximumShrinkFactor' is a ratio based on 'pageSize',
'maximumShrinkFactor' should multiply (not 'originalPageSize') but 'pageSize'.
This bug happens if all the following conditions are met:

  • pageLogicalWidth < docLogicalWidth
  • originalPageSize.width * maximumShrinkFactor < docLogicalWidth
  • docLogicalWidth < pageLogicalWidth * maximumShrinkFactor

Test: printing/width-overflow.html

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

LayoutTests:

width-overflow.html checks if the page is printed without its right side
being truncated.

  • printing/width-overflow.html: Added.
  • platform/chromium-linux/printing/width-overflow-expected.png: Added.
  • platform/chromium-linux/printing/width-overflow-expected.txt: Added.
  • platform/mac-snowleopard/printing/width-overflow-expected.png: Added.
  • platform/mac-snowleopard/printing/width-overflow-expected.txt: Added.
  • platform/efl/Skipped: Skips width-overflow.html, since layoutTestController.setPrinting() is not implemented.
  • platform/gtk/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
16:12 Changeset [102280] by dpranke@chromium.org

fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031

Reviewed by Tony Chang.

r102201 introduced a change to the chromium build that splits
the executables out of WebKit.gyp into other gyp files, and adds
a new "All.gyp" that builds everything. However, I forgot to
update the build script to use All.gyp.

  • Scripts/webkitdirs.pm:

(buildChromium):

15:43 Changeset [102279] by simonjam@chromium.org

[Chromium] Unreviewed, skip a test that may be causing Win DRT to hang.

  • platform/chromium/test_expectations.txt:
15:41 Changeset [102278] by commit-queue@webkit.org

Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
https://bugs.webkit.org/show_bug.cgi?id=49401

Patch by Yong Li <yoli@rim.com> on 2011-12-07
Reviewed by Darin Adler.

Manual test added: ManualTests/database-callback-deferred.html.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didReceiveTask):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):

  • dom/Document.h:
  • page/PageGroupLoadDeferrer.cpp:

(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

14:48 Changeset [102277] by lforschler@apple.com

Merged r99090.

14:47 Changeset [102276] by lforschler@apple.com

Merged r98892.

14:46 Changeset [102275] by adamk@chromium.org

[MutationObservers] Enable in Chromium trunk
https://bugs.webkit.org/show_bug.cgi?id=73851

Reviewed by Ojan Vafai.

Source/WebKit/chromium:

Re-landing after fixing Chromium unit test crashes in r102171
and inspector debugger crash in r102264.

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt: Stop skipping fast/mutation tests.
14:45 Changeset [102274] by lforschler@apple.com

Merged r98873.

14:43 Changeset [102273] by lforschler@apple.com

Merged r98664.

14:37 Changeset [102272] by simonjam@chromium.org

[Chromium] Unreviewed, clean out passing tests from test_expectations.txt

  • platform/chromium/test_expectations.txt:
14:36 Changeset [102271] by lforschler@apple.com

Merge 97514. needed for 98664.

13:43 Changeset [102270] by lforschler@apple.com

Merged r98646.

13:18 Changeset [102269] by commit-queue@webkit.org

IndexedDB deleteIndex should throw NOT_ALLOWED_ERR if called outside a VERSION_CHANGE transaction callback
https://bugs.webkit.org/show_bug.cgi?id=62370

Already behaves correctly, just adding tests.

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.

  • storage/indexeddb/deleteIndex-expected.txt: Added.
  • storage/indexeddb/deleteIndex.html: Added.
13:10 Changeset [102268] by kling@webkit.org

RenderObject::style(): Inline early-return condition.
<http://webkit.org/b/74019>

Reviewed by Anders Carlsson.

style() was very hot (6.1%) when scrolling around on youtube.com,
and 100% of the calls were taking the early return path.

Inlined the !isRenderFlowThread() check and renamed the function to
styleSlowCase().

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleSlowCase):

  • rendering/RenderObject.h:

(WebCore::RenderObject::style):

13:01 Changeset [102267] by adamk@chromium.org

Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

  • wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on an entry whose value is null.

Source/WebCore:

No new tests, refactoring only.

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):

12:59 Changeset [102266] by kling@webkit.org

RenderLayer::updateZOrderLists(): Inline early-return condition.
<http://webkit.org/b/74013>

Reviewed by Anders Carlsson.

updateZOrderLists() was hot (1.2%) when scrolling around on youtube.com,
and 85% of the calls were taking the early return path.

Inlined the two checks for the early return and renamed the function
to updateZOrderListsSlowCase(). Also reversed their order to avoid the
virtual call (RenderObject::isRenderView()) if possible.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderListsSlowCase):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::updateZOrderLists):

12:08 Changeset [102265] by commit-queue@webkit.org

Unreviewed, rolling out r102244.
http://trac.webkit.org/changeset/102244
https://bugs.webkit.org/show_bug.cgi?id=74016

caused debug test timeouts (Requested by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-07

Source/WebCore:

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:03 Changeset [102264] by adamk@chromium.org

Layout Test inspector/debugger/dom-breakpoints.html fails on chromium linux debug with ENABLE(MUTATION_OBSERVERS)
https://bugs.webkit.org/show_bug.cgi?id=73919

Reviewed by Ojan Vafai.

Source/WebCore:

Use StyleAttributeMutationScope to manage DOM breakpoints for style property changes.

Instead of calling InspectorInstrumentation::didInvalidateStyleAttr()
directly in setNeedsStyleRecalc, set a bool in the current
StyleAttributeMutationScope, and delay the call until the scope's
counter runs down to zero. This keeps the inspector JS from re-entering
CSSMutableStyleDeclaration until all StyleAttributeMutationScope work is done.

Also fix a small bug in StyleAttributeMutationScope, where
s_shouldDeliver wasn't getting reset properly to false.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

LayoutTests:

Added test that no-op style mutations don't create MutationRecords.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
12:01 Changeset [102263] by commit-queue@webkit.org

Crash from multicol spans with layers
https://bugs.webkit.org/show_bug.cgi?id=68030

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-12-07
Reviewed by David Hyatt.

Source/WebCore:

The layer tree diverges from the render tree when a span is being split
between columns. This patch causes the layer tree to be updated when necessary.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitFlow)
(WebCore::RenderBlock::splitBlocks)

LayoutTests:

New test for fix to crash on bug 68030.

  • fast/multicol/span/removal-of-multicol-span-crash-expected.txt: Added
  • fast/multicol/span/removal-of-multicol-span-crash.html: Added
11:53 Changeset [102262] by ap@apple.com

Handling of !important in inline style sets is broken
https://bugs.webkit.org/show_bug.cgi?id=73941

Reviewed by Dave Hyatt.

This behavior was introduced in bug 8223 to match IE and Firefox. But it doesn't appear that we're matching
any browser today, and CSSOM spec agrees with them.

  • WebCore.exp.in: Don't export CSSStyleDeclaration::setProperty(), no one is using it.
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate): Use regular setProperty(), not the incorrect version that's being removed. Properties set via IDL attributes are never important.
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::V8CSSStyleDeclaration::namedPropertySetter): Made the same fix for v8. Why did v8 bindings authors copy/paste the code?!
  • css/CSSStyleDeclaration.cpp:
  • css/CSSStyleDeclaration.h: Removed a version of setProperty() that attempted to parse the value and extract !important from it.
  • html/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::restoreImageSize): (WebCore::ImageDocument::windowSizeChanged):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): We never needed to use this version of setProperty() here, it was just unnecessarily slower.
11:52 Changeset [102261] by fpizlo@apple.com

Non-Mac devices should benefit from a larger heap
https://bugs.webkit.org/show_bug.cgi?id=74015

Reviewed by Geoff Garen.

Removed the ENABLE(LARGE_HEAP) option from Platform.h, since it was only used in
Heap.cpp, and got in the way of having more granular, per-platform control over
what the heap size should be. Bumped the heap size to 8MB on iOS (was 512KB).

  • heap/Heap.cpp:

(JSC::GCTimer::heapSizeForHint):

  • wtf/Platform.h:
11:45 Changeset [102260] by commit-queue@webkit.org

IndexedDB objectStoreNames not updated after aborted transaction
https://bugs.webkit.org/show_bug.cgi?id=58655

Already functional but there wasn't a test with these specifics.

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.

  • storage/indexeddb/mozilla/versionchange-abort-expected.txt: Added.
  • storage/indexeddb/mozilla/versionchange-abort.html: Added.
11:34 Changeset [102259] by lforschler@apple.com

Merged r98438.

11:32 Changeset [102258] by lforschler@apple.com

Merged r98437.

11:31 Changeset [102257] by lforschler@apple.com

Merged r98435.

11:29 Changeset [102256] by lforschler@apple.com

Merged r98416.

11:21 Changeset [102255] by wangxianzhu@chromium.org

In FontCacheAndroid.cpp should keep the pointer valid returned from CString::data()
https://bugs.webkit.org/show_bug.cgi?id=73849

The changed code has been covered by many existing layout tests.

Reviewed by Adam Barth.

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::createFontPlatformData):

11:19 Changeset [102254] by lforschler@apple.com

Merged r98413.

11:06 Changeset [102253] by lforschler@apple.com

Merged r98406.

11:05 Changeset [102252] by xji@chromium.org

Source/WebCore: Turn on move caret by word visually for Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=59652

Reviewed by Ryosuke Niwa.

We already support (arrow key) moving cursor by character in visual order.
This patch implements (ctrl/alt-arrow) moving cursor by word in visual order (in Windows).
It matches Firefox's default behavior.

Without this patch, ctrl(alt for mac)-arrow key or
selection.modify("move", "left"/"right", "word") moves cursor by word in logical order.

IE implements moving cursor by logical order for both arrow key and ctrl-arrow key.
Firefox implements moving cursor by visual order for both operations.
From Chromium bug report, native speakers would like moving cursor by visual order since it
is more intuitive.

The patch is only enabled for Windows (by EditingBehavior) because current implementation
matches Windows' native behavior.
For exmaple, if the logical text is "abc def hij", the cursor positions are
"|abc |def |hij|" no matter pressing ctrl-left-arrow or ctrl-right-arrow.

Mac and Linux's native behavior is slightly different. In which, when pressing
ctrl-left-arrow, the cursor positions are "|abc |def |hij|". When pressing ctrl-right-arrow,
the cursor positions are "|abc| def| hij|". We will implement it next.

Test: editing/selection/move-left-right-by-word-mac.html

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveLeftRightByWordInVisualOrder):

  • editing/FrameSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.

(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):

  • editing/TextGranularity.h: Remove experimental enum WebKitVisualWordGranularity.
  • editing/VisibleSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.

(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):

  • page/DOMSelection.cpp: Remove experimental experimental flag -webkit-visual-word.

(WebCore::DOMSelection::modify):

LayoutTests: Turn on move caret by word visually for windows platform.
https://bugs.webkit.org/show_bug.cgi?id=59652

Reviewed by Ryosuke Niwa.

  • editing/selection/caret-mode-paragraph-keys-navigation.html:
  • editing/selection/move-by-word-visually-crash-test-1.html:
  • editing/selection/move-by-word-visually-crash-test-2.html:
  • editing/selection/move-by-word-visually-crash-test-3.html:
  • editing/selection/move-by-word-visually-crash-test-4.html:
  • editing/selection/move-by-word-visually-crash-test-textarea.html:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html:
  • editing/selection/move-by-word-visually-multi-line.html:
  • editing/selection/move-by-word-visually-multi-space.html:
  • editing/selection/move-by-word-visually-null-box.html:
  • editing/selection/move-by-word-visually-single-space-inline-element.html:
  • editing/selection/move-by-word-visually-single-space-one-element.html:
  • editing/selection/move-by-word-visually-textarea.html:
  • editing/selection/move-left-right-by-word-mac-expected.txt: Added.
  • editing/selection/move-left-right-by-word-mac.html: Added.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWord):
(moveByWordOnEveryChar):

10:58 Changeset [102251] by kbalazs@webkit.org

ShareableBitmapGtk.cpp has no reason to exist
https://bugs.webkit.org/show_bug.cgi?id=74011

Reviewed by Martin Robinson.

Remove this file since the real implementation is
exists in ShareableBitmapCairo.cpp.

  • Shared/gtk/ShareableBitmapGtk.cpp: Removed.
10:45 Changeset [102250] by commit-queue@webkit.org

[chromium] Plumb damage from WebExternalTextureLayer and WebPluginContainer to CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=73485

Patch by Jonathan Backer <backer@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.

Source/WebCore:

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::updateCompositorResources):
(WebCore::PluginLayerChromium::invalidateRect):

  • platform/graphics/chromium/PluginLayerChromium.h:

Source/WebKit/chromium:

  • public/platform/WebExternalTextureLayer.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::invalidateRect):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::commitBackingTexture):

10:24 Changeset [102249] by commit-queue@webkit.org

Upstream 5 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73632

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • PlatformBlackBerry.cmake: Remove two empty files from build list.
  • platform/blackberry/PopupMenuBlackBerry.cpp: Added.

(WebCore::PopupMenuBlackBerry::PopupMenuBlackBerry):
(WebCore::PopupMenuBlackBerry::~PopupMenuBlackBerry):
(WebCore::PopupMenuBlackBerry::show):
(WebCore::PopupMenuBlackBerry::hide):
(WebCore::PopupMenuBlackBerry::updateFromElement):
(WebCore::PopupMenuBlackBerry::disconnectClient):

  • platform/blackberry/PopupMenuBlackBerry.h: Added.

(WebCore::PopupMenuBlackBerry::client):

  • platform/blackberry/ScrollbarThemeBlackBerry.cpp: Added.

(WebCore::ScrollbarTheme::nativeTheme):

  • platform/blackberry/SearchPopupMenuBlackBerry.cpp: Added.

(WebCore::SearchPopupMenuBlackBerry::SearchPopupMenuBlackBerry):
(WebCore::SearchPopupMenuBlackBerry::popupMenu):
(WebCore::SearchPopupMenuBlackBerry::enabled):
(WebCore::SearchPopupMenuBlackBerry::saveRecentSearches):
(WebCore::SearchPopupMenuBlackBerry::loadRecentSearches):

  • platform/blackberry/SearchPopupMenuBlackBerry.h: Added.
10:24 Changeset [102248] by dbates@webkit.org

ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html
https://bugs.webkit.org/show_bug.cgi?id=74006

Reviewed by Antonio Gomes.

As far I can tell, we've never had an ASSERT_UNREACHED(). We do have an
ASSERT_NOT_REACHED().

  • coding/assertion-guidelines.html:
10:21 Changeset [102247] by mitz@apple.com

Fixed the definition of BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING from r102246.

  • platform/mac/ThemeMac.mm: Added parentheses.
10:15 Changeset [102246] by mitz@apple.com

<rdar://problem/10542095> Focus rings are not drawn around push buttons, radio buttons and checkboxes

Reviewed by Darin Adler.

Instead of relying on -setShowsFirstResponder: to make -drawWithFrame:inView: draw the focus
ring, use -drawFocusRingMaskWithFrame:inView:.

  • platform/mac/ThemeMac.mm:

(-[NSCell _web_drawFocusRingWithFrame:inView:]): Added. Sets up the focus ring style and a
transparency layer, then uses -drawFocusRingMaskWithFrame:inView: to draw the focus ring.
(WebCore::updateStates): Eliminated calls to get and set showsFirstResponder.
(WebCore::paintCheckbox): Changed to use -_web_drawFocusRingWithFrame:inView:.
(WebCore::paintRadio): Ditto.
(WebCore::paintButton): Ditto.

10:12 Changeset [102245] by kbalazs@webkit.org

Unreviewed gardening.

Skip 3 more metric related tests with Qt5 until test-font fix.

  • platform/qt-5.0/Skipped:
10:08 Changeset [102244] by commit-queue@webkit.org

Source/WebCore: [CHROMIUM/SKIA] Handle put[Un/Pre]multipliedImageData conversions in Skia rather than ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=73953

Patch by Brian Salomon <bsalomon@google.com> on 2011-12-07
Reviewed by Stephen White.

Tested by existing canvas2d layout tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

LayoutTests: [CHROMIUM] Make canvas/philip/tests/2d.imageData.put.unchanged.html be expected to fail
on the GPU due to slight difference in alpha-premul computation.

https://bugs.webkit.org/show_bug.cgi?id=73953

Patch by Brian Salomon <bsalomon@google.com> on 2011-12-07
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
08:40 Changeset [102243] by kling@webkit.org

Micro-optimize ScrollView::visibleContentRect().
<http://webkit.org/b/74001>

Reviewed by Anders Carlsson.

Reorder the scrollbar exclusion code to minimize the number of virtual calls
to ScrollableArea::verticalScrollbar(), ScrollableArea::horizontalScrollbar()
and Scrollbar::isOverlayScrollbar().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):

08:16 Changeset [102242] by kling@webkit.org

ApplyPropertyBorderImage: Remove unneeded template argument for mapNinePieceImage().
<http://webkit.org/b/73998>

Reviewed by Antti Koivisto.

Have ApplyPropertyBorderImage call mapNinePieceImage() directly now that it's
public (instead of passing it as a template argument.)

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

08:12 Changeset [102241] by jberlin@webkit.org

Mac build fix after r102235.

  • WebCore.exp.in:
07:38 Changeset [102240] by tomz@codeaurora.org

Moved myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
07:32 Changeset [102239] by hausmann@webkit.org

[Qt] V8 debug build fixes.

Reviewed by Tor Arne Vestbø.

  • Target.pri: Add missing files to the build.
  • loader/SubresourceLoader.cpp: Add missing CString.h header file inclusion,

that is implicitly included with Chromium builds.

  • loader/cache/CachedResource.cpp: Ditto.
  • page/FrameTree.cpp: Ditto.
  • platform/graphics/MediaPlayer.cpp: Ditto.
07:29 Changeset [102238] by hausmann@webkit.org

[Qt] Fix debug shlib build with V8.

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/qtwebkit.prf: Don't like jscore with

v8 builds.

07:29 Changeset [102237] by hausmann@webkit.org

[Qt] V8 build fixes.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • yarr/yarr.pri: Don't rely on Source/JavaScriptCore being in

VPATH. Prefix SOURCES correctly and make sure that runtime/ is
in the include search path when building with v8.

Source/WebCore:

  • Target.pri: Don't load(javascriptcore) if we're building with v8.

Tools:

  • qmake/mkspecs/features/javascriptcore.prf: Don't add

Source/Thirdparty to the include search path here.

  • qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's

used when building WebCore as well as using it, because header files like
GraphicsContext3D.h include stuff from ThirdParty.

07:10 Changeset [102236] by kbalazs@webkit.org

[Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache
https://bugs.webkit.org/show_bug.cgi?id=73999

Unreviewed gardening. Skip failing tests.

  • platform/qt-wk2/Skipped:
06:54 Changeset [102235] by commit-queue@webkit.org

Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
https://bugs.webkit.org/show_bug.cgi?id=73986

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Just function name change, no new tests.

  • platform/Logging.h:
  • platform/efl/LoggingEfl.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/gtk/LoggingGtk.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/mac/LoggingMac.mm:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/qt/LoggingQt.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/win/LoggingWin.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/wx/LoggingWx.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

Source/WebKit/efl:

  • ewk/ewk_main.cpp:

(_ewk_init_body):

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

Source/WebKit/win:

  • WebView.cpp:

(WebView::initWithFrame):

Source/WebKit/wx:

  • WebView.cpp:

(wxWebView::Create):

Source/WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

06:51 Changeset [102234] by mihnea@adobe.com

[CSSRegions]Add support for background-color in region styling
https://bugs.webkit.org/show_bug.cgi?id=71488

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/region-style-block-background-color.html

fast/regions/region-style-block-background-color2.html
fast/regions/region-style-image-background-color.html
fast/regions/region-style-inline-background-color.html

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::regionStyleRule):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearRenderRegionRangeMap):
(WebCore::RenderFlowThread::~RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::style):

  • rendering/RenderObject.h:

(WebCore::RenderObject::canHaveRegionStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):
(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):

LayoutTests:

  • fast/regions/region-style-block-background-color.html: Added.
  • fast/regions/region-style-block-background-color2.html: Added.
  • fast/regions/region-style-image-background-color.html: Added.
  • fast/regions/region-style-inline-background-color.html: Added.
  • fast/regions/resources/transparent.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt: Added.
06:00 Changeset [102233] by vsevik@chromium.org

Web Inspector: Extract default call stack creation and check for front-end from console.
https://bugs.webkit.org/show_bug.cgi?id=73566

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/v8/ScriptCallStackFactory.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/WorkerInspectorController.h:

(WebCore::WorkerInspectorController::hasFrontend):

  • page/Console.cpp:
  • page/Console.h:
04:55 Changeset [102232] by peter@chromium.org

[Chromium] Fix project file generation for the Android bot after r102201
https://bugs.webkit.org/show_bug.cgi?id=73996

The gyp refactoring in r102201 was didn't explicitly exclude
the Android operating system in Tools/Tools.gyp, which broke
as gcc_version is not defined for that configuration.

Reviewed by Andreas Kling.

  • Tools.gyp:
04:34 Changeset [102231] by commit-queue@webkit.org

Internals should have a method to reutrn the max sequence number of spellcheck reqeust.
https://bugs.webkit.org/show_bug.cgi?id=73511

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-07
Reviewed by Hajime Morita.

Source/WebCore:

Internal state of SpellChecker should be able to be exposed for testing SpellChecker.
This patch will enable us to know asynchronous spellcheck has finished or not.

Test: editing/spelling/spellcheck-sequencenum.html

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

(WebCore::SpellChecker::lastRequestSequence):

Interface to take SpellCheck sequence numbers.

(WebCore::SpellChecker::lastProcessedSequence): ditto.

  • testing/Internals.cpp:

(WebCore::spellchecker):
(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added tests to check internals.lastSpellCheckRequestSequence and internals.lastSpellCheckProcessedSequence.

  • editing/spelling/spellcheck-sequencenum-expected.txt: Added.
  • editing/spelling/spellcheck-sequencenum.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
04:31 Changeset [102230] by vsevik@chromium.org

Unreviewed. Disabled failing tests on chromium.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

02:19 Changeset [102229] by vsevik@chromium.org

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
01:56 Changeset [102228] by commit-queue@webkit.org

[Qt][WK2] Enable page cache.
https://bugs.webkit.org/show_bug.cgi?id=73938

Enable WebCore's page cache for Qt port by setting its capacity to 20. This is temporary
and will be replaced by a computed value based on CacheMode. See bug#73918.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-12-07
Reviewed by Simon Hausmann.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):

01:43 Changeset [102227] by rniwa@webkit.org

Qt rebaseline after r102149.

  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from

LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

01:36 Changeset [102226] by tkent@chromium.org

Move <input type=number> tests to fast/forms/number/
https://bugs.webkit.org/show_bug.cgi?id=73987

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-typeMismatch-number-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-number.html: Removed.
  • fast/forms/input-appearance-number-rtl.html: Removed.
  • fast/forms/input-appearance-spinbutton-disabled-readonly.html: Removed.
  • fast/forms/input-appearance-spinbutton-layer.html: Removed.
  • fast/forms/input-appearance-spinbutton-visibility-expected.html: Removed.
  • fast/forms/input-appearance-spinbutton-visibility.html: Removed.
  • fast/forms/input-number-blur-twice-expected.txt: Removed.
  • fast/forms/input-number-blur-twice.html: Removed.
  • fast/forms/input-number-change-type-on-focus-expected.txt: Removed.
  • fast/forms/input-number-change-type-on-focus.html: Removed.
  • fast/forms/input-number-commit-valid-only-expected.txt: Removed.
  • fast/forms/input-number-commit-valid-only.html: Removed.
  • fast/forms/input-number-crash-expected.txt: Removed.
  • fast/forms/input-number-crash.html: Removed.
  • fast/forms/input-number-events-expected.txt: Removed.
  • fast/forms/input-number-events.html: Removed.
  • fast/forms/input-number-keyoperation-expected.txt: Removed.
  • fast/forms/input-number-keyoperation.html: Removed.
  • fast/forms/input-number-large-padding-expected.txt: Removed.
  • fast/forms/input-number-large-padding.html: Removed.
  • fast/forms/input-number-outofrange-expected.txt: Removed.
  • fast/forms/input-number-outofrange.html: Removed.
  • fast/forms/input-number-size-expected.txt: Removed.
  • fast/forms/input-number-size.html: Removed.
  • fast/forms/input-number-spinbutton-crash-expected.txt: Removed.
  • fast/forms/input-number-spinbutton-crash.html: Removed.
  • fast/forms/input-number-unacceptable-style-expected.txt: Removed.
  • fast/forms/input-number-unacceptable-style.html: Removed.
  • fast/forms/input-number-wheel-expected.txt: Removed.
  • fast/forms/input-number-wheel.html: Removed.
  • fast/forms/input-spinbutton-capturing-expected.txt: Removed.
  • fast/forms/input-spinbutton-capturing.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/input-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/input-valueasnumber-number-expected.txt: Removed.
  • fast/forms/input-valueasnumber-number.html: Removed.
  • fast/forms/number-input-changeevent-expected.txt: Removed.
  • fast/forms/number-input-changeevent.html: Removed.
  • fast/forms/number/ValidityState-rangeOverflow-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/number/ValidityState-rangeOverflow-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/number/ValidityState-rangeUnderflow-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/number/ValidityState-stepMismatch-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/number/ValidityState-stepMismatch-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/number/ValidityState-typeMismatch-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt.
  • fast/forms/number/ValidityState-typeMismatch-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-number.js.
  • fast/forms/number/input-appearance-number-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-number-rtl.html.
  • fast/forms/number/input-appearance-spinbutton-disabled-readonly.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-disabled-readonly.html.
  • fast/forms/number/input-appearance-spinbutton-layer.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-layer.html.
  • fast/forms/number/input-appearance-spinbutton-visibility-expected.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-visibility-expected.html.
  • fast/forms/number/input-appearance-spinbutton-visibility.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html.
  • fast/forms/number/input-number-blur-twice-expected.txt: Copied from LayoutTests/fast/forms/input-number-blur-twice-expected.txt.
  • fast/forms/number/input-number-blur-twice.html: Copied from LayoutTests/fast/forms/input-number-blur-twice.html.
  • fast/forms/number/input-number-change-type-on-focus-expected.txt: Copied from LayoutTests/fast/forms/input-number-change-type-on-focus-expected.txt.
  • fast/forms/number/input-number-change-type-on-focus.html: Copied from LayoutTests/fast/forms/input-number-change-type-on-focus.html.
  • fast/forms/number/input-number-commit-valid-only-expected.txt: Copied from LayoutTests/fast/forms/input-number-commit-valid-only-expected.txt.
  • fast/forms/number/input-number-commit-valid-only.html: Copied from LayoutTests/fast/forms/script-tests/input-number-commit-valid-only.js.
  • fast/forms/number/input-number-crash-expected.txt: Copied from LayoutTests/fast/forms/input-number-crash-expected.txt.
  • fast/forms/number/input-number-crash.html: Copied from LayoutTests/fast/forms/input-number-crash.html.
  • fast/forms/number/input-number-events-expected.txt: Copied from LayoutTests/fast/forms/input-number-events-expected.txt.
  • fast/forms/number/input-number-events.html: Copied from LayoutTests/fast/forms/script-tests/input-number-events.js.
  • fast/forms/number/input-number-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/input-number-keyoperation-expected.txt.
  • fast/forms/number/input-number-keyoperation.html: Copied from LayoutTests/fast/forms/script-tests/input-number-keyoperation.js.
  • fast/forms/number/input-number-large-padding-expected.txt: Copied from LayoutTests/fast/forms/input-number-large-padding-expected.txt.
  • fast/forms/number/input-number-large-padding.html: Copied from LayoutTests/fast/forms/input-number-large-padding.html.
  • fast/forms/number/input-number-outofrange-expected.txt: Copied from LayoutTests/fast/forms/input-number-outofrange-expected.txt.
  • fast/forms/number/input-number-outofrange.html: Copied from LayoutTests/fast/forms/script-tests/input-number-outofrange.js.
  • fast/forms/number/input-number-size-expected.txt: Copied from LayoutTests/fast/forms/input-number-size-expected.txt.
  • fast/forms/number/input-number-size.html: Copied from LayoutTests/fast/forms/input-number-size.html.
  • fast/forms/number/input-number-spinbutton-crash-expected.txt: Copied from LayoutTests/fast/forms/input-number-spinbutton-crash-expected.txt.
  • fast/forms/number/input-number-spinbutton-crash.html: Copied from LayoutTests/fast/forms/input-number-spinbutton-crash.html.
  • fast/forms/number/input-number-unacceptable-style-expected.txt: Copied from LayoutTests/fast/forms/input-number-unacceptable-style-expected.txt.
  • fast/forms/number/input-number-unacceptable-style.html: Copied from LayoutTests/fast/forms/input-number-unacceptable-style.html.
  • fast/forms/number/input-number-wheel-expected.txt: Copied from LayoutTests/fast/forms/input-number-wheel-expected.txt.
  • fast/forms/number/input-number-wheel.html: Copied from LayoutTests/fast/forms/script-tests/input-number-wheel.js.
  • fast/forms/number/input-spinbutton-capturing-expected.txt: Copied from LayoutTests/fast/forms/input-spinbutton-capturing-expected.txt.
  • fast/forms/number/input-spinbutton-capturing.html: Copied from LayoutTests/fast/forms/script-tests/input-spinbutton-capturing.js.
  • fast/forms/number/input-valueasnumber-number-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-number-expected.txt.
  • fast/forms/number/input-valueasnumber-number.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js.
  • fast/forms/number/number-input-changeevent-expected.txt: Copied from LayoutTests/fast/forms/number-input-changeevent-expected.txt.
  • fast/forms/number/number-input-changeevent.html: Copied from LayoutTests/fast/forms/number-input-changeevent.html.
  • fast/forms/number/number-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/number/number-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/number/number-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt: Copied from LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly-expected.txt.
  • fast/forms/number/spin-button-gets-disabled-or-readonly.html: Copied from LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly.html.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-number.js: Removed.
  • fast/forms/script-tests/input-number-commit-valid-only.js: Removed.
  • fast/forms/script-tests/input-number-events.js: Removed.
  • fast/forms/script-tests/input-number-keyoperation.js: Removed.
  • fast/forms/script-tests/input-number-outofrange.js: Removed.
  • fast/forms/script-tests/input-number-wheel.js: Removed.
  • fast/forms/script-tests/input-spinbutton-capturing.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/input-valueasnumber-number.js: Removed.
  • fast/forms/spin-button-gets-disabled-or-readonly-expected.txt: Removed.
  • fast/forms/spin-button-gets-disabled-or-readonly.html: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/number: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number: Added.
  • platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/number: Added.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number: Added.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number: Added.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/efl/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/efl/fast/forms/number: Added.
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/gtk/fast/forms/number: Added.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/mac/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/mac/fast/forms/number: Added.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt/fast/forms/number: Added.
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/win/Skipped:
  • platform/wk2/Skipped:
01:03 Changeset [102225] by rniwa@webkit.org

TypingCommand duplicates code to obtain the last typing command
https://bugs.webkit.org/show_bug.cgi?id=73984

Reviewed by Kent Tamura.

Extracted lastTypingCommandIfStillOpenForTyping out of isOpenForMoreTypingCommand
and a bunch of TypingCommand static member functions.

Also made more member functions of TypingCommand private.

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::closeTyping):

  • editing/TypingCommand.h:

(WebCore::TypingCommand::isOpenForMoreTyping):
(WebCore::TypingCommand::closeTyping):

00:14 Changeset [102224] by rniwa@webkit.org

Add back a file accidentally removed in r102210.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from

LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

12/06/11:

22:26 Changeset [102223] by commit-queue@webkit.org

upstream BlackBerry porting of KURL/Logging
https://bugs.webkit.org/show_bug.cgi?id=73524

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-06
Reviewed by Antonio Gomes.

  • platform/blackberry/KURLBlackBerry.cpp: Added.

(WebCore::KURL::fileSystemPath):

  • platform/blackberry/LoggingBlackBerry.cpp: Added.

(WebCore::initializeWithUserDefault):
(WebCore::InitializeLoggingChannelsIfNecessary):

21:57 Changeset [102222] by tkent@chromium.org

Correct svn:mime-type of platform/*/fast/forms/*.png.

  • platform/chromium-cg-mac-leopard/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/select-visual-hebrew-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/select-background-none-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/forms/select-background-none-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-narrow-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/003-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/004-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/005-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/006-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/007-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label01-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label02-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label03-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label04-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label05-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-default-title-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-inner-block-reuse-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-positioned-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-sizes-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-white-space-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/caret-rtl-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/control-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/control-clip-overflow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/disabled-select-change-index-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/encoding-test-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/fieldset-with-float-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/float-before-fieldset-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/form-added-to-table-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/form-hides-table-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/formmove3-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/hidden-listbox-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/image-border-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-first-letter-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-no-renderer-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-spaces-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-table-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-scrollbar-incremental-load-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-width-change-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/menulist-deselect-update-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/menulist-no-overflow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/menulist-width-change-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/negativeLineHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-index-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-script-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-strip-whitespace-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-text-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range-thumb-height-percentage-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range/slider-thumb-shared-style-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-rtl-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-background-none-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-block-background-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-change-listbox-size-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-change-listbox-to-popup-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-change-popup-to-listbox-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-dirty-parent-pref-widths-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-disabled-appearance-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-display-none-style-resolve-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-initial-position-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-item-background-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-list-box-with-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-selected-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-size-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-style-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-writing-direction-natural-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/selectlist-minsize-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/stuff-on-my-optgroup-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-setinnerhtml-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/001-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/002-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/003-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/004-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/005-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/006-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/007-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label01-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label02-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label03-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label04-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label05-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label06-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label07-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-buttons-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-inputs-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-textareas-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/blankbuttons-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/box-shadow-override-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-cannot-be-nested-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-default-title-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-generated-content-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-inner-block-reuse-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-positioned-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-sizes-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-style-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-submit-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-table-styles-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-text-transform-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-white-space-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/caret-rtl-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/checkbox-radio-onchange-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/control-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/control-clip-overflow-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/control-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/disabled-select-change-index-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/encoding-test-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/fieldset-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/fieldset-with-float-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/file/file-input-direction-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/file/file-input-disabled-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/float-before-fieldset-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/floating-textfield-relayout-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-added-to-table-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-element-geometry-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-hides-table-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-in-malformed-markup-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/formmove-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/formmove2-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/formmove3-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/hidden-listbox-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/image-border-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/indeterminate-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-focus-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-number-rtl-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-selection-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-visibility-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-baseline-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-button-sizes-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-disabled-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-field-text-truncated-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-first-letter-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-no-renderer-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-paste-undo-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-placeholder-visibility-1-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-readonly-dimmed-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-readonly-empty-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-spaces-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-table-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-click-inside-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-option-delete-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-word-wrap-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-type-text-min-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-value-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-hit-test-zoomed-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-scrollbar-incremental-load-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-width-change-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-deselect-update-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-narrow-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-no-overflow-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-option-wrap-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-separator-painting-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-width-change-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/minWidthPercent-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/negativeLineHeight-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-index-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-script-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-strip-whitespace-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-text-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/placeholder-position-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio-attr-order-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio-nested-labels-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio_checked-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio_checked_dynamic-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/input-appearance-range-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/slider-thumb-stylability-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-rtl-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-styled-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/searchfield-heights-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-background-none-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-block-background-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-change-listbox-size-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-change-listbox-to-popup-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-change-popup-to-listbox-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-disabled-appearance-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-display-none-style-resolve-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-empty-option-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-initial-position-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-item-background-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-list-box-with-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-selected-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-size-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-visual-hebrew-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-writing-direction-natural-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/selectlist-minsize-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/stuff-on-my-optgroup-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/tabbing-input-iframe-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/targeted-frame-submission-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/text-style-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textAreaLineHeight-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-scroll-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-scrolled-type-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-setinnerhtml-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-outline-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-overflow-by-value-update-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-overflow-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.png: Modified property svn:mime-type.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
  • platform/gtk/fast/forms/select-background-none-expected.png: Added property svn:mime-type.
  • platform/mac-leopard/fast/forms/caret-rtl-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/form-added-to-table-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/form-in-malformed-markup-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/image-border-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/input-field-text-truncated-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/input-type-text-min-width-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/placeholder-pseudo-style-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/search-display-none-cancel-button-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/search-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/textarea-width-expected.png: Modified property svn:mime-type.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Modified property svn:mime-type.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/input-button-sizes-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/range/slider-crash-expected.png: Added property svn:mime-type.
  • platform/win/fast/forms/input-text-drag-down-expected.png: Modified property svn:mime-type.
21:27 Changeset [102221] by leo.yang@torchmobile.com.cn

[BlackBerry] Remove redundant files in PlatformBlackBerry.cmake
https://bugs.webkit.org/show_bug.cgi?id=73976

Reviewed by Antonio Gomes.

The listing of the following files in PlatformBlackBerry.cmake are redundant. They should be removed.
platform/network/blackberry/MultipartResponseDelegate.cpp
platform/network/blackberry/NetworkManager.cpp
platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp
platform/network/blackberry/ResourceErrorBlackBerry.cpp
platform/network/blackberry/ResourceRequestBlackBerry.cpp

  • PlatformBlackBerry.cmake:
21:25 Changeset [102220] by fpizlo@apple.com

Zapping a block that is Marked leads to dead objects being mistaken for live ones
https://bugs.webkit.org/show_bug.cgi?id=73982

Reviewed by Geoff Garen.

Changed the zapping code to ignore blocks that are Marked or Zapped. Additionally,
the code asserts that:

  • If we zap a Marked or Zapped block then the free list is empty, because this can only happen if the block was never free-listed.


  • Zapping can only happen for Marked, Zapped, or FreeListed blocks, since Allocated blocks are those that cannot be referred to by SizeClass::currentBlock (since SizeClass::currentBlock only refers to blocks that are candidates for allocation, and Allocated blocks are those who have been exhausted by allocation and will not be allocated from again), and New blocks cannot be referred to by anything except during a brief window inside the allocation slow-path.
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::zapFreeList):

21:01 Changeset [102219] by rniwa@webkit.org

Copy hover-active-drag-expected.txt for Chromium.

  • platform/chromium/fast/css/hover-active-drag-expected.txt: Copied from LayoutTests/fast/css/hover-active-drag-expected.txt.
21:00 Changeset [102218] by commit-queue@webkit.org

Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.

(WebCore::Editor::markAndReplaceFor):

  • editing/Editor.h:
20:53 Changeset [102217] by jchaffraix@webkit.org

Avoid calling calculateRects in RenderLayer::paintLayer when the rectangles are not needed
https://bugs.webkit.org/show_bug.cgi?id=73754

Reviewed by Simon Fraser.

Performance change, no change in behavior.

RenderLayer::paintLayer can easily be called a million time when scrolling on a big table with
td { overflow: hidden; }. We would spend a lot of time recomputing the rectangles that we never
unused for painting as our layer was not self-painting (clipping layer only) and we did not paint
some overlay scrollbars.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
Simplified and moved the shouldPaint logic earlier in the function. Now the branches
are checking the same boolean which makes the logic more obvious. A consequence of
filling shouldPaint earlier is that we call |calculateRects| only if there is a chance
the rectangles will used. Also cached the result of isSelfPaintingLayer() in a local
variable (isSelfPaintingLayer() is fairly expensive due to several virtual calls).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):
For coherency, applied the same optimizations here too: added an early return instead
of conditionaly call |calculateRects| as we don't have to restore any clip.

20:46 Changeset [102216] by rniwa@webkit.org

Remove the leapForward accidentally added in the previous commit, and add a failing test expectation
for offsetX-offset-Y.html. The failure is tracked by the bug 73979.

  • fast/events/offsetX-offsetY-expected.txt:
  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html:
20:38 Changeset [102215] by rniwa@webkit.org

Fixed the test added by r100111.

  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html:
20:24 Changeset [102214] by benjamin@webkit.org

Simplify KURL's checkEncodedString()
https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The Macro UNUSED_PARAM is not supposed to be used for this case,
use ASSERT_UNUSED instead.

  • platform/KURL.cpp:

(WebCore::checkEncodedString):

20:14 Changeset [102213] by rniwa@webkit.org

Skip tests added by r101883 on Mac since they have been failing.
The failure is tracked by the bug 73977.

  • platform/mac/Skipped:
20:04 Changeset [102212] by eric.carlson@apple.com

Update <track> layout tests
https://bugs.webkit.org/show_bug.cgi?id=73966

<track> elements won't necessarily load automatically after https://bugs.webkit.org/show_bug.cgi?id=72547
is fixed, so update tests now.

Reviewed by Sam Weinig.

  • media/track/text-track-cue-is-reachable-expected.txt: Added.
  • media/track/text-track-cue-is-reachable.html: Added.
  • media/track/text-track-is-reachable-expected.txt: Added.
  • media/track/text-track-is-reachable.html: Added.
  • media/track/track-add-remove-cue.html:
  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit.html:
  • media/track/track-cues-seeking.html:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState.html:
  • media/track/track-text-track-cue-list.html:
  • media/track/track-webvtt-tc000-empty.html:
  • media/track/track-webvtt-tc001-utf8.html:
  • media/track/track-webvtt-tc002-bom.html:
  • media/track/track-webvtt-tc003-newlines.html:
  • media/track/track-webvtt-tc004-magic-header.html:
  • media/track/track-webvtt-tc005-header-comment.html:
  • media/track/track-webvtt-tc006-cue-identifiers.html:
  • media/track/track-webvtt-tc007-cue-no-id.html:
  • media/track/track-webvtt-tc008-timings-no-hours.html:
  • media/track/track-webvtt-tc009-timings-hour.html:
  • media/track/track-webvtt-tc010-no-timings.html:
  • media/track/track-webvtt-tc011-blank-lines.html:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment.html:
  • media/track/track-webvtt-tc015-positioning.html:
  • media/track/track-webvtt-tc016-align-positioning.html:
  • media/track/track-webvtt-tc017-line-position.html:
  • media/track/track-webvtt-tc018-align-text-line-position.html:
  • media/track/track-webvtt-tc019-cue-size.html:
  • media/track/track-webvtt-tc020-cue-size-align.html:
  • media/track/track-webvtt-tc021-valign.html:
  • media/track/track-webvtt-tc022-entities.html:
  • media/track/track-webvtt-tc023-markup.html:
  • media/track/track-webvtt-tc024-timestamp.html:
  • media/track/track-webvtt-tc025-class-markup.html:
  • media/track/track-webvtt-tc026-voice.html:
  • media/track/track-webvtt-tc027-empty-cue.html:
  • media/track/track-webvtt-tc028-unsupported-markup.html:
  • media/video-test.js:

(testTracks):
(testCues):
(allTestsEnded):
(enableAllTextTracks):

19:53 Changeset [102211] by rniwa@webkit.org

Add a failing expectation for the test added by r101619.
The failure is tracked by the bug 73975.

  • platform/mac/fast/css/hover-active-drag-expected.txt: Copied from LayoutTests/fast/css/hover-active-drag-expected.txt.
19:41 Changeset [102210] by rniwa@webkit.org

GTK rebaseline after r102149.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
19:28 Changeset [102209] by kbr@google.com

Unreviewed. Suppress failure of fast/canvas/webgl/canvas-2d-webgl-texture.html
on Mac; tracking bug https://bugs.webkit.org/show_bug.cgi?id=73974 .

  • platform/mac/Skipped:
19:17 Changeset [102208] by rniwa@webkit.org

The code to create a NodeListsNodeData is duplicated everywhere
https://bugs.webkit.org/show_bug.cgi?id=73961

Reviewed by Darin Adler.

Extracted the logic to create NodeListsNodeData as NodeRareData::ensureNodeLists.

  • dom/Document.cpp:

(WebCore::Document::getItems):

  • dom/Node.cpp:

(WebCore::Node::childNodes):
(WebCore::Node::registerDynamicNodeList):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::ensureNodeLists):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::labels):

18:37 Changeset [102207] by leo.yang@torchmobile.com.cn

Upstream about: feature in WebKit/blackberry/WebCoreSupport/
https://bugs.webkit.org/show_bug.cgi?id=73612

Reviewed by Antonio Gomes.

Source/WebCore:

  • PlatformBlackBerry.cmake: Move platform/network/blackberry/AboutData.{h, cpp}

to WebKit/blackberry/WebCoreSupport

Source/WebKit:

  • blackberry/CMakeListsBlackBerry.txt:
  • blackberry/WebCoreSupport/AboutData.cpp: Added.

(WebCore::numberToHTMLTr):
(WebCore::configPage):
(WebCore::cacheTypeStatisticToHTMLTr):
(WebCore::memoryPage):

  • blackberry/WebCoreSupport/AboutData.h: Added.
  • blackberry/WebCoreSupport/AboutDataEnableFeatures.in: Added.
  • blackberry/WebCoreSupport/AboutDataHaveFeatures.in: Added.
  • blackberry/WebCoreSupport/AboutDataUseFeatures.in: Added.
  • blackberry/WebCoreSupport/generateAboutDataFeatures.pl: Added.
18:34 Changeset [102206] by lforschler@apple.com

Merged r98403. Reverted DumpRenderTree portion of this merge, as it fails. To be merged again after investigation

18:11 Changeset [102205] by benjamin@webkit.org

WebKit Mac does not build without CONTEXT MENU
https://bugs.webkit.org/show_bug.cgi?id=73962

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-06
Reviewed by Pavel Feldman.

In the patch r100903, the symbols were exported under ENABLE(CONTEXT_MENUS)
because the feature is triggered from the menus.

The implementation has no dependency on the context menu but is necessary to build
when the inspector is enabled.
This patch moves the exported symbols from ENABLE(CONTEXT_MENUS) to ENABLE(INSPECTOR).

  • WebCore.exp.in:
18:10 Changeset [102204] by lforschler@apple.com

Merged r94598.

17:52 Changeset [102203] by lforschler@apple.com

Merged r97886.

17:48 Changeset [102202] by dpranke@chromium.org

Fix typo in WebKit.gyp introduced in previous change.

Unreviewed, build fix.

  • WebKit.gyp:
17:39 Changeset [102201] by dpranke@chromium.org

.: Add Tools/Tool.xcodeproj,
Source/WebKit/chromium/WebKitUnitTests.xcodeproj,
Source/WebKit/chromium/All.xcodeproj to .gitignore

https://bugs.webkit.org/show_bug.cgi?id=73823

Reviewed by Tony Chang.

  • .gitignore:

Source/WebKit/chromium: binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
https://bugs.webkit.org/show_bug.cgi?id=73382

Reviewed by Tony Chang.

XCode (and hence GYP) can't handle circular dependencies between
files (and projects). Accordingly, although the binaries in
WebKit.gyp depend on webkit_support and webkit_support depends
on webkit, we don't mention the latter dependency in the file.
To fix this, this change moves the binaries like DRT into a new
GYP file, and modifies gyp_webkit to build from that file
instead of WebKit.gyp.

  • WebKit.gyp:
  • All.gyp:
  • WebKitUnitTests.gyp:
  • gyp_webkit:

Tools: binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
https://bugs.webkit.org/show_bug.cgi?id=73382

Reviewed by Tony Chang.

XCode (and hence GYP) can't handle circular dependencies between
files (and projects). Accordingly, although the binaries in
WebKit.gyp depend on webkit_support and webkit_support depends
on webkit, we don't mention the latter dependency in the file.
To fix this, this change moves the binaries like DRT into a new
GYP file, and modifies gyp_webkit to build from that file
instead of WebKit.gyp.

  • Tools.gyp: Added.
17:29 Changeset [102200] by fpizlo@apple.com

DFG 32_64 call linking does not handle non-cell callees correctly
https://bugs.webkit.org/show_bug.cgi?id=73965

Reviewed by Sam Weinig.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

17:29 Changeset [102199] by lforschler@apple.com

Merged r97517.

17:23 Changeset [102198] by lforschler@apple.com

Merged r97191.

17:22 Changeset [102197] by lforschler@apple.com

Merged r92491.

17:17 Changeset [102196] by enne@google.com

[chromium] setNeedsCommit on non-composited host layers should trigger commit
https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::notifySyncRequired):

  • platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

  • tests/LayerChromiumTest.cpp:
17:03 Changeset [102195] by lforschler@apple.com

Merged r95697.

16:55 Changeset [102194] by weinig@apple.com

Remove unintentional type name shadowing in the Interpreter
https://bugs.webkit.org/show_bug.cgi?id=73963

Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::prepareForRepeatCall): Replace the parameter name FunctionExecutable,
which shadows the FunctionExecutable type name, with functionExecutable.

16:51 Changeset [102193] by lforschler@apple.com

Merged r95386.

16:45 Changeset [102192] by lforschler@apple.com

Merged r95244.

16:41 Changeset [102191] by lforschler@apple.com

Merged r95129.

16:38 Changeset [102190] by bashi@chromium.org

[Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
https://bugs.webkit.org/show_bug.cgi?id=73806

Reviewed by Tony Chang.

Source/WebCore:

Sets fMergeNeutralItems to 1 instead of merging script items based on their tags.

Tests: platform/chromium/fast/text/international/chromium-complex-text-non-printable-expected.html

platform/chromium/fast/text/international/chromium-complex-text-non-printable.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::fillRuns): Removed a block which merges script items.

LayoutTests:

Adds a test to ensure the missing glyph doesn't appear on LF in complex text.

  • fast/text/international/chromium-complex-text-non-printable-expected.html: Added.
  • fast/text/international/chromium-complex-text-non-printable.html: Added.
16:35 Changeset [102189] by lforschler@apple.com

Merge 95121.

16:26 Changeset [102188] by macpherson@chromium.org

Implement remaining border-image and webkit-maskbox-image properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73391

Reviewed by Hajime Morita.

No new tests / refacoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderImageModifier::getValue):
(WebCore::ApplyPropertyBorderImageModifier::setValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
15:49 Changeset [102187] by pfeldman@chromium.org

Web Inspector: introduce a memory agent stub.
https://bugs.webkit.org/show_bug.cgi?id=73930

Reviewed by Timothy Hatcher.

We'd like to experiment with the memory stats and hence need a
nice home for that. Adding this undocumented agent / domain for now.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptProfiler.h:

(WebCore::ScriptProfiler::nodeCount):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::nodeCount):

  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMemoryAgent.cpp: Added.

(WebCore::InspectorMemoryAgent::~InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::getNodeCounter):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h: Added.

(WebCore::InspectorMemoryAgent::create):

15:46 Changeset [102186] by jchaffraix@webkit.org

Unreviewed build fix after 102183.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialGridTrackValue):
Use DEFINE_STATIC_LOCAL to avoid having an exit-time destructor.

15:38 Changeset [102185] by jchaffraix@webkit.org

Inline RenderObject::view()
https://bugs.webkit.org/show_bug.cgi?id=73733

Reviewed by Darin Adler.

Micro-performance optimization, no change in behavior.

RenderObject::view() is super hot and is taking ~4-5% of the time in some
benchmarks as it is called several hundred thousands times. For some reason,
the compiler did not inline it even though it is very simple in release builds.

  • WebCore.exp.in: Removed RenderObject::view() as it is inlined now.
  • rendering/RenderObject.cpp: Moved the implementation from here ...
  • rendering/RenderView.h:

(WebCore::RenderObject::view): ... to here to avoid a cyclic
dependency between RenderObject and RenderView. Also marked the
function as ALWAYS_INLINE.

  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

Added #include "RenderView.h" as the code checks for view() during repaint.

15:29 Changeset [102184] by aestes@apple.com

REGRESSION (r101838): Crash in LayerTreeHostCA::initialize() when accelerated drawing is enabled
https://bugs.webkit.org/show_bug.cgi?id=73955

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize): m_webPage->drawingArea() will be
null here if we are initializing the layer tree host in DrawingArea's
ctor (as is the case when accelerated drawing is enabled), before
WebPage has set its m_drawingArea pointer. Since the layer tree cannot
have been frozen at this point, it's safe to enable layer flush
scheduling if drawingArea() is null.

15:11 Changeset [102183] by jchaffraix@webkit.org

CSS Grid Layout: Add support for parsing multiple grid-columns or grid-rows
https://bugs.webkit.org/show_bug.cgi?id=73272

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html

Updated our supported syntax to match the following:
<track-list> := [ <track-breadth> ]+ | 'none'
<track-breadth> := <length> | <percentage> | 'auto'
(the naming loosely matches the specification)

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackBreadth): Added function to handle a breadth
(extended with 'auto' that the spec puts in <track-minmax>).

(WebCore::valueForGridTrackList): Create a space seperated list of
track breadth or none.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated
to use the new functions.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList): Extended the function to
match the new syntax.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Removed our
simple implementation. Replaced by the CSSStyleSelector functions.

  • css/CSSStyleSelector.cpp:

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
Added those 2 functions to convert the CSSPrimitiveValue to a Vector
as expected by RenderStyle.

(WebCore::CSSStyleSelector::applyProperty): Added our 2 properties
now that it is not handled by CSSStyleApplyProperty.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::gridColumns):
(WebCore::InheritedFlags::gridRows):
(WebCore::InheritedFlags::setGridColumns):
(WebCore::InheritedFlags::setGridRows):
(WebCore::InheritedFlags::initialGridColumns):
(WebCore::InheritedFlags::initialGridRows):
Updated the previous methods to take a Vector of Length.

(WebCore::InheritedFlags::initialGridTrackValue):
Needed function to return a Vector with one 'none' Length (the initial
value per the specification).

  • rendering/style/StyleGridData.h: Updated to use a Vector.

LayoutTests:

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

Added more testing for the single case.

  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: Added.
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: Added.
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: Added.
14:41 Changeset [102182] by msaboff@apple.com

r102146 from 73875 broke fast/js/encode-URI-test.html
https://bugs.webkit.org/show_bug.cgi?id=73950

Reviewed by Gavin Barraclough.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncUnescape): Restructured to handle
the %uHHHH case to output the resulting character
and continue so that a failure in finding 4 hex
digits will fall through and output the '%'.
Due to style check, changed the temporary
character variable to a more descriptive name.

14:37 Changeset [102181] by commit-queue@webkit.org

[Chromium] Implement tile-sized painting using SkPicture.
https://bugs.webkit.org/show_bug.cgi?id=71869

Patch by David Reveman <reveman@chromium.org> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

Add texture uploader that paints tile-sized chunks using SkPicture
recording and playback. Expose setting which allows this texture
updater to be enabled.

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Added.

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::create):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::BitmapSkPictureCanvasLayerTextureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::~BitmapSkPictureCanvasLayerTextureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Added.

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

Source/WebKit/chromium:

Add perTilePainting setting that is used by compositor to determine
what texture uploader to use.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setPerTilePainting):

  • src/WebSettingsImpl.h:

(WebKit::WebSettingsImpl::perTilePainting):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

14:26 Changeset [102180] by enne@google.com

[chromium] Don't crash if tile upload happens without painting first
https://bugs.webkit.org/show_bug.cgi?id=73939

Reviewed by James Robinson.

Remove at least one place (in ImageLayerChromium) where this could
happen.

Although this shouldn't happen, we should be robust to it in the
chance that other code causes it to.

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

14:12 Changeset [102179] by fpizlo@apple.com

GC zapping logic could benefit from some more assertions
https://bugs.webkit.org/show_bug.cgi?id=73947

Reviewed by Gavin Barraclough.

  • If you're in a zapped block and you're zapped, then your mark bit should never be set.


  • If you're being marked, then you should never be zapped.
  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isLive):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

14:07 Changeset [102178] by commit-queue@webkit.org

Enable web audio by default on non-Mac POSIX platforms
https://bugs.webkit.org/show_bug.cgi?id=73491

Patch by Ruben <chromium@hybridsource.org> on 2011-12-06
Reviewed by Tony Chang.

No new tests, just changing gyp includes.

  • WebCore.gyp/WebCore.gyp:
14:02 Changeset [102177] by benjamin@webkit.org

Put length in its own variable in KURL copyASCII
https://bugs.webkit.org/show_bug.cgi?id=73928

Reviewed by Darin Adler.

  • platform/KURL.cpp:

(WebCore::copyASCII):

13:58 Changeset [102176] by lforschler@apple.com

Merged r95103.

13:54 Changeset [102175] by lforschler@apple.com

Merge 95099.

13:37 Changeset [102174] by commit-queue@webkit.org

[chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

Unit test in tests/ImageLayerChromiumTest.cpp.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/DragImageTest.cpp:

(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):

  • tests/ImageLayerChromiumTest.cpp: Added.

(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

13:19 Changeset [102173] by lforschler@apple.com

Merged r95096.

13:12 Changeset [102172] by lforschler@apple.com

Merged r95058.

13:06 Changeset [102171] by adamk@chromium.org

[chromium] Guard access to WebKitPlatformSupport::currentThread with a null check
https://bugs.webkit.org/show_bug.cgi?id=73937

Reviewed by Adam Barth.

Though |currentThread| is never null in production code, it is null in
unit tests (such as Chromium's unit_tests) that call WebKit::initialize()
without first constructing a MessageLoop.

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

13:00 Changeset [102170] by commit-queue@webkit.org

[chromium] Apply sent deltas on finishCommit
https://bugs.webkit.org/show_bug.cgi?id=73884

Patch by Alexandre Elias <aelias@google.com> on 2011-12-06
Reviewed by James Robinson.

This moves scroll and pageScale "sent" deltas to be applied to
the layer at the end of the commit, instead of the beginning.

This has several advantages, especially for page scale:

  • When pageScale changes, no longer any need to change the scroll's

coordinate space at beginning of commit, which is complex and prone to
bugs (this fixes a problem where we were forgetting to modify the
scrollPosition before).

  • No need for non-commit-related code to consider the "sent" values.

m_pageScale is now always the content scale factor, and
m_pageScaleDelta is the scale to be on the impl-side matrix.

  • This will make it easy to send arbitrary fake or future delta

values for example while pinch zooming out.

The scroll logic is similarly altered for consistency's sake. Note that
I also moved the tree synchronize to the beginning of finishCommit
in order to avoid having to change the pageScale coordinate space of
sentScrollDelta in adjustScrollsForPageScaleChange().

Source/WebCore:

No new tests. (Refactoring of existing code.)

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

12:48 Changeset [102169] by oliver@apple.com

Don't allocate register in typedarray control flow
https://bugs.webkit.org/show_bug.cgi?id=73944

Reviewed by Gavin Barraclough.

Move a temporary allocation outside of control flow.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

12:47 Changeset [102168] by commit-queue@webkit.org

[Qt] Fix assertion in QtViewportInteractionEngine.cpp:468
https://bugs.webkit.org/show_bug.cgi?id=73914

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

m_suspendCount should always be zero when a pinch gesture is started.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

12:46 Changeset [102167] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=68328
The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant

Reviewed by Geoff Garen.

../JavaScriptCore:

Move the instrinsic enum out of the DFG, into runtime. Add entires for all host functions
that have an intrinsic in the form of a generated thunk. Remove the thunk pointer from the
hashtable, and make Intrinsic field no longer ifdef on JIT/DFG. In getHostFunction select
a thunk genertaor to use based on the Intrinsic.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGCapabilities.h:
  • dfg/DFGIntrinsic.h: Removed.
  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):

  • runtime/Executable.h:

(JSC::ExecutableBase::intrinsicFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/Intrinsic.h: Copied from Source/JavaScriptCore/dfg/DFGIntrinsic.h.
  • runtime/JSGlobalData.cpp:

(JSC::thunkGeneratorForIntrinsic):
(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:
  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

../WebCore:

Intrinsic is no longer in the DFG namespace, is always in the
hash table. Removed ThunkGenerator.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

12:39 Changeset [102166] by abarth@webkit.org

Remove forwarding header now that downstream has been fixed to refer to
the actual location of this header.

  • public/WebRect.h: Removed.
12:27 Changeset [102165] by dglazkov@chromium.org

Unreviewed, rolling out r102091.
http://trac.webkit.org/changeset/102091
https://bugs.webkit.org/show_bug.cgi?id=73711

Caused Clang Linux compile failure.

Source/WebCore:

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::notifySyncRequired):

  • platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

  • tests/LayerChromiumTest.cpp:
12:17 Changeset [102164] by commit-queue@webkit.org

[Chromium] Make root layer always opaque
https://bugs.webkit.org/show_bug.cgi?id=70564

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::NonCompositedContentHost):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

12:04 Changeset [102163] by aroben@apple.com

Add a pid parameter to CrashLogs.find_newest_log

When a PID is passed, only crash logs corresponding to a crashed process with that PID are
considered.

Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
process whose crash log you want to find

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log): Added an optional pid parameter.
(CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
candidate log's app_description extended attribute to see if that log corresponds to a
crashed process with the specified PID.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
respected. Also fixed an erroneous use of assertTrue instead of assertEqual.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
present.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.init): Added an optional xattrs parameter. Documented other parameters.
(MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
dictionary.

  • Scripts/webkitpy/tool/commands/queries.py:

(CrashLog): Added help text. Added an optional PID parameter.
(CrashLog.execute): Pass the PID, if any, through to find_newest_log.

12:04 Changeset [102162] by aroben@apple.com

Wait for Crash Reporter to finish even when it lets the crashed process die quickly

NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
alive beyond the normal timeout limit. In cases where the crashed process was able to die
faster, NRWT would assume that Crash Reporter had finished even though it often was still
running, which would lead to an incorrect crash log being picked up.

Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess.write):
(ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
.crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
set_crashed.

(ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
.timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
we bail out of handling the failure as a timeout if we find out that the process in fact
crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
so.
(ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
finish running (unless directed otherwise) so we can be sure the crash log has been saved to
disk.

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.is_crash_reporter): Added.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
that would have partially broken crash detection on Windows, if NRWT worked on Windows.)

12:00 Changeset [102161] by abarth@webkit.org

NRWT fails on unreleased versions of Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=72748

Reviewed by Dirk Pranke.

Hopefully this patch will make NRWT work on future versions on Mac OS X.
Most of the infrastructure was already in place, but there were some
asserts that failed. I've tested this patch by haxoring the version
detection logic to simulate an unknown version. We might need to
iterate based on feedback from folks with a real future version.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init):

  • mac-future is an allowed port_name that's used internally by webkitpy to represent future versions of Mac OS X.
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_versions):

  • Test that we don't throw exceptions when dealing with future versions of Mac OS X.
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._expectations_from_skipped_files):

  • Demote this logging message to "debug". It's expected that mac-future doesn't have a Skipped file.
  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.init):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.init):

  • Re-order some code in these constructors so that self._operating_system is available to the ApplePort constructor.
11:58 Changeset [102160] by simon.fraser@apple.com

UI process crashes if the Web Process crashes on launch
https://bugs.webkit.org/show_bug.cgi?id=73943

Reviewed by Sam Weinig.

When the Web Process crashes on launch, the WebConnectionToWebProcess
object was getting deleted inside of didClose. Add a protector to
prevent this.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::didClose):

11:29 Changeset [102159] by kubo@profusion.mobi

[EFL] Do not lose message flags when converting to/from Soup Requests/Responses
https://bugs.webkit.org/show_bug.cgi?id=73924

Reviewed by Gustavo Noronha Silva.

Apply the same change added to the GTK+ port in r55086 to prevent
soup message flags from being lost by updating the request flags when
a response is received.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

11:29 Changeset [102158] by noel.gordon@gmail.com

WebPImageDecoder computes image width and height multiple times
https://bugs.webkit.org/show_bug.cgi?id=73796

Reviewed by Adam Barth.

Once sufficient image data arrives, we can compute the decoded image height
and width from the WEBP image header data.

From then on, the decoded image size is known so there's no need to re-read
it from the WEBP image header again.

No change in behavior, so no new tests.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

11:27 Changeset [102157] by reed@google.com

optimize TransformationMatrix::scale by not calling through to generic multiply
https://bugs.webkit.org/show_bug.cgi?id=73830

Reviewed by Kenneth Russell.

No new tests. Optimization only, existing tests exercise the code

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):

11:26 Changeset [102156] by jocelyn.turcotte@nokia.com

[Qt] Fix page overlay rendering with AC.
https://bugs.webkit.org/show_bug.cgi?id=73935

Reviewed by Noam Rosenthal.

The inspector node highlight would display old highlights as well
since the overlay is normally rendered right after the page on top
of the same graphics context.

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::paintContents):

11:07 Changeset [102155] by darin@apple.com

Generated some new expected results for Lion.

Discussed aspects of this with Adam Roben and Dan Bernstein.

  • platform/mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Added.
  • platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Updated.
  • platform/mac/media/controls-strict-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Updated.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Updated.
  • platform/mac/svg/text/text-intro-05-t-expected.txt: Updated.
11:01 Changeset [102154] by eric.carlson@apple.com

Revert WebCore track Settings changes made in r101977
https://bugs.webkit.org/show_bug.cgi?id=73879

Reviewed by Sam Weinig.

No new tests yet, still nothing to test.

  • page/Settings.cpp: Move the preference setters back into the .h file.
  • page/Settings.h:

(WebCore::Settings::setShouldDisplaySubtitles):
(WebCore::Settings::setShouldDisplayCaptions):
(WebCore::Settings::setShouldDisplayTextDescriptions):

10:37 Changeset [102153] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
10:19 Changeset [102152] by kling@webkit.org

MediaList: Remove constructor that takes a CSSImportRule*.
<http://webkit.org/b/73833>

Reviewed by Antti Koivisto.

  • css/MediaList.h:
  • css/MediaList.cpp:

Remove MediaList(CSSImportRule*, ...) constructor.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):

Have CSSImportRule construct its MediaList by passing the parent
style sheet, which is exactly what the old constructor accomplished.
Also assert that we're always created with a non-null parent sheet.

09:59 Changeset [102151] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-leopard/fast/table/027-expected.png: Added.
09:57 Changeset [102150] by tommyw@google.com

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
09:43 Changeset [102149] by jarred@sencha.com

getComputedStyle returns wrong value for margin-*
https://bugs.webkit.org/show_bug.cgi?id=73334

Source/WebCore:

margin-* getComputedStyle values should return the "used" absolute value when there is a renderer
and the specified value is relative (percentage, auto, etc.).
When there is no renderer, the specified value should be returned.
See http://dev.w3.org/csswg/cssom/#resolved-values.

Reviewed by Darin Adler.

Test: fast/css/getComputedStyle/getComputedStyle-resolved-values.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Modified baseline tests for getComputedStyle margin values where a "used" value is returned.

Reviewed by Darin Adler.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-resolved-values.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
09:36 Changeset [102148] by ap@apple.com

REGRESSION (WebKit2): Kill ring is not cleared when selection changes
https://bugs.webkit.org/show_bug.cgi?id=73888
<rdar://problem/10532310>

Reviewed by Mark Rowe.

Test: editing/pasteboard/emacs-ctrl-k-with-move.html

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Moved the code to clear kill ring from Mac WebKit, as it's needed in all Mac ports at least.
09:30 Changeset [102147] by darin@apple.com

Use HashMap<OwnPtr> in CollectionCache
https://bugs.webkit.org/show_bug.cgi?id=73784

Reviewed by Andreas Kling.

  • html/CollectionCache.cpp:

(WebCore::CollectionCache::copyCacheMap): Use adoptPtr.
(WebCore::CollectionCache::reset): Removed now-unneeded calls to deleteAllValues.
(WebCore::append): Added. Helper function for appending elements to the maps from
the collection cache.

  • html/CollectionCache.h: Changed mapped type in NodeCacheMap to OwnPtr.

Added append function.

  • html/HTMLCollection.cpp:

(WebCore::nameShouldBeVisibleInDocumentAll): Added, to factor out common code in
two functions below.
(WebCore::HTMLCollection::checkForNameMatch): Changed to call nameShouldBeVisibleInDocumentAll.
(WebCore::HTMLCollection::updateNameCache): Ditto. Also updated cache code to use the append
function, so it will work with OwnPtr. Also eliminated an unneeded get call before
each hash table add; we do both at once in the new append function.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::updateNameCache): More of the same.

09:21 Changeset [102146] by msaboff@apple.com

Add 8 bit paths to global object functions
https://bugs.webkit.org/show_bug.cgi?id=73875

Added 8 bit paths for converions methods.

This is worth 1.5% on kraken audio-oscillator,
1.6% on stanford-crypto-ccm and 2.5% on
stanford-crypto-sha256-iterative. See bug for
a full report.

Reviewed by Oliver Hunt.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode): Split into a templated helper.
(JSC::parseInt): Split into a templated helper.
(JSC::parseFloat): Added an 8 bit path
(JSC::globalFuncEscape): Added 8 bit path
(JSC::globalFuncUnescape): Added 8 bit path

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append): New append for LChar

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append): New append for LChar

09:20 Changeset [102145] by kerz@chromium.org

Branching webkit for Chromium

09:05 Changeset [102144] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
08:36 Changeset [102143] by peter@chromium.org

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
08:35 Changeset [102142] by commit-queue@webkit.org

[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=73907

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp: Disconnect signals from

QtViewportInteractionEngine in ~QQuickWebViewPrivate.
(QQuickWebViewPrivate::~QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p_p.h: Remove empty inline implementation of ~QQuickWebViewPrivate.
08:25 Changeset [102141] by vsevik@chromium.org

Unreviewed, rolling out r102102.
http://trac.webkit.org/changeset/102102
https://bugs.webkit.org/show_bug.cgi?id=73925

Causes segmentation fault on chromium unit_tests,
content_unittests, sync_unit_tests (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

  • features.gypi:
08:16 Changeset [102140] by yurys@chromium.org

[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number

  • inspector/Inspector.json: removed unused parameter
07:38 Changeset [102139] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
07:36 Changeset [102138] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
07:31 Changeset [102137] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
07:24 Changeset [102136] by kenneth@webkit.org

[Qt] Add initial support for focusing when entering edit mode.

Reviewed by Simon Hausmann.

Next step would be to properly upstream our EditorState code.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::focusEditableArea):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::focusEditableArea):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::itemRectFromCSS):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::focusEditableArea):

  • UIProcess/qt/QtWebPageEventHandler.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::setInputMethodState):

07:05 Changeset [102135] by ossy@webkit.org

[WK2] Unreviewed gardening. Skip a failing test because of missing layoutTestController.dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=42331

  • platform/wk2/Skipped: Skip http/tests/security/mixedContent/insecure-video-in-iframe.html.
07:04 Changeset [102134] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium-cg-mac-leopard/fast/table/027-vertical-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2947-expected.png: Added.
06:38 Changeset [102133] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
06:30 Changeset [102132] by kbalazs@webkit.org

Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

Relanding with typo fix.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

missing for the gyp build system.

Export symbols.

  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

  • wtf/ParallelJobsGeneric.h:
  • wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

06:19 Changeset [102131] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening. Paint the bot green skipping with all failing tests.

  • platform/qt-mac/Skipped:
06:17 Changeset [102130] by commit-queue@webkit.org

[Qt] Fix assertion in QtWebPageEventHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=73908

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

06:13 Changeset [102129] by ossy@webkit.org

[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

  • platform/qt-wk2/Skipped: Skip fast/forms/access-key-for-all-elements.html.
05:59 Changeset [102128] by kling@webkit.org

Unreviewed assertion fix for r102123.

  • platform/KURL.cpp:

(WebCore::checkEncodedString):

05:55 Changeset [102127] by ossy@webkit.org

[WK2] Unreviewed gardening. New tests introduced in 100895 fail
https://bugs.webkit.org/show_bug.cgi?id=73913

  • platform/wk2/Skipped: Skip failing tests.
05:49 Changeset [102126] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
05:43 Changeset [102125] by commit-queue@webkit.org

[Qt] build-jsc script doesn't work
https://bugs.webkit.org/show_bug.cgi?id=73910

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-06
Reviewed by Tor Arne Vestbø.

.:

  • WebKit.pro: Move WTF SUBDIR stuff out of here and

straight into JavaScriptCore/JavaScriptCore.pro.
Unconditionally "recurse" into JavaScriptCore now,
as we'll do the v8 scoping there to only build WTF.

Source/JavaScriptCore:

(moved from top-level WebKit.pro). Also add v8 scopes to only build
WTF during v8 builds.

05:43 Changeset [102124] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium/test_expectations.txt:
05:04 Changeset [102123] by benjamin@webkit.org

Simplify KURL's checkEncodedString()
https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The method was reimplementing String::containsOnlyASCII().
Use the method from String and we can remove the #if NDEBUG.

  • platform/KURL.cpp:

(WebCore::checkEncodedString):

04:53 Changeset [102122] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • tests/KURLTest.cpp:

(ComponentCase::TEST):

04:12 Changeset [102121] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
03:38 Changeset [102120] by vsevik@chromium.org

Unreviewed, rolling out r102111.
http://trac.webkit.org/changeset/102111
https://bugs.webkit.org/show_bug.cgi?id=73902

Breaks compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/Editor.h:
03:30 Changeset [102119] by commit-queue@webkit.org

[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-06
Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

03:24 Changeset [102118] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=73889
TextCheckingParagraph::offsetTo should not have a side effect.

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
This is likely to cause a bug when changing SpellChecker and Editor.

No new tests. Covered by existing tests.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::offsetTo):

03:20 Changeset [102117] by ossy@webkit.org

[Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag-selects-image.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=73901

  • platform/qt-wk1/Skipped: Skip the failint tests.
03:12 Changeset [102116] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png.
  • platform/chromium-mac-leopard/fast/table/027-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png:
03:05 Changeset [102115] by commit-queue@webkit.org

[chromium] Set texture limits as multiples of viewport size instead of hardcoded values
https://bugs.webkit.org/show_bug.cgi?id=72202

Patch by Eric Penner <epenner@google.com> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers): added viewport param
(WebCore::LayerRendererChromium::initializeSharedObjects): ditto

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes): calculated based on viewport
(WebCore::TextureManager::reclaimLimitBytes): ditto
(WebCore::TextureManager::lowLimitBytes): ditto
(WebCore::TextureManager::TextureManager): added viewport param
(WebCore::TextureManager::setMaxMemoryLimitBytes): changed name
(WebCore::TextureManager::setPreferredMemoryLimitBytes): added function
(WebCore::TextureManager::requestTexture): added viewport param

  • platform/graphics/chromium/TextureManager.h: ditto

(WebCore::TextureManager::create): ditto

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: ditto

(WebCore::CCLayerTreeHost::initialize): ditto
(WebCore::CCLayerTreeHost::beginCommitOnImplThread): ditto
(WebCore::CCLayerTreeHost::setViewport): ditto
(WebCore::CCLayerTreeHost::setVisible): ditto
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread): ditto

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

02:52 Changeset [102114] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-5.0/Skipped:
    • Skip one more failing tests because of missing testfont handling.
    • Remove non-existent files.
  • platform/qt-5.0/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/qt-5.0/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
02:47 Changeset [102113] by commit-queue@webkit.org

[TexMap][QT] Draw the borders of media and webgl elements in TexMap.
https://bugs.webkit.org/show_bug.cgi?id=73817

GraphicsContext3D only draws the content of the WebGL canvas, not the additional
CSS such as the borders. TextureMapper should render the content of a
media/webgl layer before drawing the actual canvas.
This makes LayoutTests/compositing/webgl/webgl-reflection.html work.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-12-06
Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

02:37 Changeset [102112] by vsevik@chromium.org

Unreviewed, rolling out r102043.
http://trac.webkit.org/changeset/102043
https://bugs.webkit.org/show_bug.cgi?id=73898

Breaks chromium mac-cg compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

Source/WebCore:

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ImageLayerChromiumTest.cpp: Removed.
02:31 Changeset [102111] by commit-queue@webkit.org

Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.

(WebCore::Editor::markAndReplaceFor):

  • editing/Editor.h:
02:06 Changeset [102110] by zeno.albisser@nokia.com

[Qt][Mac] Building debug version only fails.
https://bugs.webkit.org/show_bug.cgi?id=73895

WebKit pro/pri files should not explicitly adjust
the debug_and_release settings.

Reviewed by Kenneth Rohde Christiansen.

  • declarative/experimental/experimental.pri:
  • declarative/public.pri:
02:05 Changeset [102109] by apavlov@chromium.org

Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
https://bugs.webkit.org/show_bug.cgi?id=73626

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.terminateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
(WebInspector.AuditProgressMonitor):
(WebInspector.AuditProgressMonitor.prototype.setTotalWork):
(WebInspector.AuditProgressMonitor.prototype.worked):
(WebInspector.AuditProgressMonitor.prototype.get indeterminate):
(WebInspector.AuditProgressMonitor.prototype.done):
(WebInspector.AuditProgressMonitor.prototype.get canceled):
(WebInspector.AuditProgressMonitor.prototype.set canceled):

00:38 Changeset [102108] by rolandsteiner@chromium.org

<style scoped>: disable on Windows by default
https://bugs.webkit.org/show_bug.cgi?id=73893

Reviewed by Andreas Kling.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
00:38 Changeset [102107] by commit-queue@webkit.org

[Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
https://bugs.webkit.org/show_bug.cgi?id=73874

This change partially reverts r101713 restoring original behaviour for
KUrl creation from empty string and fixes asserts in debug build.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-06
Reviewed by Alexey Proskuryakov.

No new tests. Tests from r101713 pass.

  • platform/KURL.cpp:

(WebCore::KURL::init):
(WebCore::KURL::parse):

  • platform/KURL.h:
00:21 Changeset [102106] by kling@webkit.org

Use HashMap<OwnPtr> for EventListenerMap's internal map.
<http://webkit.org/b/73761>

Reviewed by Benjamin Poulain.

Changed the value type of EventListenerMap::m_hashMap to OwnPtr<EventListenerVector>.
This means we no longer need to manually delete the vectors when taking them out of
the map, which makes the code a little prettier.

A few tweaks were necessary; release() instead of leakPtr() when switching modes
and adoptPtr()/get() sprinkled as needed.

  • dom/EventListenerMap.h:
  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):

00:05 Changeset [102105] by haraken@chromium.org

[Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
https://bugs.webkit.org/show_bug.cgi?id=73637

Reviewed by Adam Barth.

This patch replaces subprocess.Popen() with Executive, similar to other
Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
works well for cases where no exception is raised, no exception is raised
but diff is found, and ScriptError is raised.

  • Scripts/run-bindings-tests:

(main):

  • Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.

(BindingsTests.init):
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

00:00 Changeset [102104] by ossy@webkit.org

[Qt] Unreviewed gardening.

Layout Test fast/forms/input-step-as-double.html fails after running touch event tests
https://bugs.webkit.org/show_bug.cgi?id=71181

  • platform/qt/Skipped: Skip fast/forms/input-step-as-double.html until fix.
Note: See TracTimeline for information about the timeline view.