Timeline


and

12/21/11:

23:46 Changeset [103499] by abarth@webkit.org
  • 3 edits
    54 adds
    1 delete in trunk/LayoutTests

Shard html5lib/runner.html into many separate tests
https://bugs.webkit.org/show_bug.cgi?id=74968

Reviewed by Eric Seidel.

runner.html is something of an uber test that runs many, many sub
tests. It's slow and times out in some configurations. This patch
breaks it up into a number of different subtests, along the same lines
that the upstream html5lib test suite is sharded.

  • html5lib/resources/runner.js: Added.

(window.onload):
(run.xhr.onreadystatechange):
(run):
(test.else.overview.onclick):
(test):
(run_test.else.iframe.onload):
(run_test):
(process_result.get if):
(process_result):

  • html5lib/run-test1-expected.txt: Added.
  • html5lib/run-test1.html: Added.
  • html5lib/run-test10-expected.txt: Added.
  • html5lib/run-test10.html: Added.
  • html5lib/run-test11-expected.txt: Added.
  • html5lib/run-test11.html: Added.
  • html5lib/run-test12-expected.txt: Added.
  • html5lib/run-test12.html: Added.
  • html5lib/run-test14-expected.txt: Added.
  • html5lib/run-test14.html: Added.
  • html5lib/run-test15-expected.txt: Added.
  • html5lib/run-test15.html: Added.
  • html5lib/run-test16-expected.txt: Added.
  • html5lib/run-test16.html: Added.
  • html5lib/run-test17-expected.txt: Added.
  • html5lib/run-test17.html: Added.
  • html5lib/run-test18-expected.txt: Added.
  • html5lib/run-test18.html: Added.
  • html5lib/run-test19-expected.txt: Added.
  • html5lib/run-test19.html: Added.
  • html5lib/run-test2-expected.txt: Added.
  • html5lib/run-test2.html: Added.
  • html5lib/run-test20-expected.txt: Added.
  • html5lib/run-test20.html: Added.
  • html5lib/run-test21-expected.txt: Added.
  • html5lib/run-test21.html: Added.
  • html5lib/run-test22-expected.txt: Added.
  • html5lib/run-test22.html: Added.
  • html5lib/run-test23-expected.txt: Added.
  • html5lib/run-test23.html: Added.
  • html5lib/run-test24-expected.txt: Added.
  • html5lib/run-test24.html: Added.
  • html5lib/run-test25-expected.txt: Added.
  • html5lib/run-test25.html: Added.
  • html5lib/run-test26-expected.txt: Added.
  • html5lib/run-test26.html: Added.
  • html5lib/run-test3-expected.txt: Added.
  • html5lib/run-test3.html: Added.
  • html5lib/run-test4-expected.txt: Added.
  • html5lib/run-test4.html: Added.
  • html5lib/run-test5-expected.txt: Added.
  • html5lib/run-test5.html: Added.
  • html5lib/run-test6-expected.txt: Added.
  • html5lib/run-test6.html: Added.
  • html5lib/run-test7-expected.txt: Added.
  • html5lib/run-test7.html: Added.
  • html5lib/run-test8-expected.txt: Added.
  • html5lib/run-test8.html: Added.
  • html5lib/run-test9-expected.txt: Added.
  • html5lib/run-test9.html: Added.
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
  • platform/chromium/html5lib/runner-expected.txt: Removed.
23:41 Changeset [103498] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Make ~CSSParserSelector use Vector<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73782

Reviewed by Alexey Proskuryakov.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::~CSSParserSelector): Use Vector<OwnPtr>
so we don't have to call leakPtr or deleteAllValues.

23:17 Changeset [103497] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Forms] Selection change by type-ahead doesn't fire 'change' event
https://bugs.webkit.org/show_bug.cgi?id=74590

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes when onchange event fired in select element for:
1 Fire onchange event for type ahead selection.
2 Don't fire onchange event for Enter key. We've already fired onchange event for cursor key

and type ahead selection. So, onchange for Enter key is redundant. This behavior is
compatible to IE(9.0.8112.16421) and Opera(9.80) on Windows. FF(8.01) doesn't fire onchange
by cursor key selection change and type ahead. FF requires Enter key press to fire onchange
event.

Test: fast/forms/select/menulist-type-ahead-find.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't fire onchange event for Entry key.
(WebCore::HTMLSelectElement::typeAheadFind): Add DispatchChangeEvent when
calling selectOption method.

LayoutTests:

  • fast/events/onchange-select-popup-expected.txt: Change for onchange event by type ahead.
  • fast/forms/select/menulist-type-ahead-find-expected.txt: Added.
  • fast/forms/select/menulist-type-ahead-find.html: Added.
  • platform/chromium/test_expectations.txt: Enable fast/forms/{select-double-onchange,select-script-onchange}.html for Chrome/Linux.
23:00 Changeset [103496] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Plumbs refresh rate through WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=74884

Patch by Peter Kotwicz <pkotwicz@google.com> on 2011-12-21
Reviewed by James Robinson.

  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

22:20 Changeset [103495] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] Layout Test media/media-element-play-after-eos.html is flaky
De-flakify the test by adding listeners before playback starts, so that
events are guaranteed to be received (as opposed to playback finishing
before listeners are even registered on overloaded machines).
https://bugs.webkit.org/show_bug.cgi?id=71543

Patch by Ami Fischman <fischman@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

  • media/media-element-play-after-eos.html:
  • platform/chromium/test_expectations.txt:
21:39 Changeset [103494] by darin@apple.com
  • 4 edits in trunk/Source/WebCore

Tweak and comment some transform-related code
https://bugs.webkit.org/show_bug.cgi?id=68670

Reviewed by Daniel Bates.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint): Added a FIXME about additional overhead paid here
when the scale factor is 2x.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow): Added a FIXME about this check possibly
being wrong, and also changed the local vairable name so the check need not stretch over
multiple lines.

21:22 Changeset [103493] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

OS X build fix after r103488.

21:12 Changeset [103492] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add efl port's ewk_view files
https://bugs.webkit.org/show_bug.cgi?id=61915

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-12-21
Reviewed by Eric Seidel.

This is the initial version of WebKit2 EFL port's ewk_view.
The ewk_view is Evas_Object to show the rendered web contents.

  • UIProcess/API/efl/ewk_view.cpp: Added.

(_ewk_view_smart_changed):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_calculate):
(_ewk_view_smart_show):
(_ewk_view_smart_hide):
(ewk_view_smart_class_init):
(_ewk_view_smart_class_new):
(ewk_view_add):
(ewk_view_page_get):

  • UIProcess/API/efl/ewk_view.h: Added.
20:57 Changeset [103491] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Change the item type of Document::m_formElementsWithState from Element*
to HTMLFormControlElementWithState*.
https://bugs.webkit.org/show_bug.cgi?id=74998

Reviewed by Andreas Kling.

No new tests. Just refactoring.

  • dom/Document.cpp:

(WebCore::Document::formElementsState): Use HTMLFormControlElementWithState*.

  • dom/Document.h:

(WebCore::Document::registerFormElementWithState): Change the argument type.
(WebCore::Document::unregisterFormElementWithState): ditto.
(WebCore::Document::formElements): Renamed from getFormElements().

  • dom/Element.h:

Removed shouldSaveAndRestoreFormControlState(), saveFormControlState(),
and restoreFormControlState() because they are not called for Element
anymore.

  • html/HTMLFormControlElement.h:
  • Make formControlName() and formControlType() public. They are called from Document class.
  • Make shouldSaveAndRestoreFormControlState() public, and non-virtual. This is called from Document class, and no other classes override this.

(WebCore::HTMLFormControlElementWithState::saveFormControlState):
Moved from Element.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):
Use HTMLFormControlElementWithState* instead of Element*.

20:56 Changeset [103490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Always use border texels on platforms using pageScaleDelta
https://bugs.webkit.org/show_bug.cgi?id=74226

Patch by Alexandre Elias <aelias@google.com> on 2011-12-21
Reviewed by James Robinson.

On platforms where the root layer can be zoomed in at draw time
(pageScaleDelta), we want to turn on border texels in order for
scaling to use GL_LINEAR instead of GL_NEAREST.

No new tests. (Flag flip.)

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

20:41 Changeset [103489] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[chromium] Scale audio, video tags in MediaDocument to fit in window.
https://bugs.webkit.org/show_bug.cgi?id=73948

Source/WebCore:

Add CSS max-height: 100%, max-width: 100% settings to the audio and
video tags when in MediaDocuments.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

Test: media/video-scales-in-media-document.html

  • css/mediaControlsChromium.css:

(audio:-webkit-full-page-media, video:-webkit-full-page-media):

LayoutTests:

Added new layout test to verify audio, video tags scale to fit
undersized containers.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

  • media/video-scales-in-media-document-expected.txt: Added.
  • media/video-scales-in-media-document.html: Added.
20:39 Changeset [103488] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source

Implement the JavaScriptCore bindings for eventListenerHandlerLocation
https://bugs.webkit.org/show_bug.cgi?id=74313

Patch by Konrad Piascik <kpiascik@rim.com> on 2011-12-21
Reviewed by Eric Seidel.

Source/JavaScriptCore:

Updated project files to get Windows and Mac builds working.

Source/WebCore:

Implemented the JavaScriptCore binding to allow Web Inspector to
show the function name and line number for an event listener in
the Elements panel.

Tested by opening up a page which has a registered event listener in Safari
and checking if the Elements panel script name and line number are present
and clickable.

  • ForwardingHeaders/runtime/Executable.h: Added.
  • ForwardingHeaders/wtf/SegmentedVector.h: Added.
  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):

18:50 Changeset [103487] by leo.yang@torchmobile.com.cn
  • 5 edits in trunk/Source/WebCore

Upstream the Multipart feature in Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=73533

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2011-12-21
Reviewed by Rob Buis.

I refactored Multipart code of Blackberry port. Moved Multipart into
Blackerry network layer and removed the dependence of std::string.

Initial upstream, no new test cases.

  • platform/network/blackberry/DeferredData.cpp:

(WebCore::DeferredData::deferMultipartHeaderReceived):
(WebCore::DeferredData::processHeaders):
(WebCore::DeferredData::processDeferredData):

  • platform/network/blackberry/DeferredData.h:

(WebCore::DeferredData::hasDeferredData):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyMultipartHeaderReceived):
(WebCore::NetworkJob::handleNotifyMultipartHeaderReceived):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:
18:45 Changeset [103486] by eric.carlson@apple.com
  • 6 edits in trunk

Fix text track cue font size and colors
https://bugs.webkit.org/show_bug.cgi?id=75051

Reviewed by Darin Adler.

Source/WebCore:

No new tests, updated media/track/track-cue-rendering.html for the changes.

  • css/mediaControls.css:

(video::-webkit-media-text-track-container): Match WebVTT spec.
(video::-webkit-media-text-track-display): Ditto.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Change font size from 4% of the

video height to 5% as per the spec. Don't enforce a minimum size.

LayoutTests:

  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering.html:
18:36 Changeset [103485] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations file for fast/js/global-constructors.

  • platform/mac/fast/js/global-constructors-expected.txt:
18:34 Changeset [103484] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.1

New tag.

18:33 Changeset [103483] by lforschler@apple.com
  • 1 delete in tags/Safari-534.54.1

Remove incorrect tag

18:23 Changeset [103482] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Source/JavaScriptCore: DFG ConvertThis optimizations do not honor the distinction between the global object and the global this object
https://bugs.webkit.org/show_bug.cgi?id=75058
<rdar://problem/10616612>
<rdar://problem/10617500>

Reviewed by Oliver Hunt.

Added a call to toThisObject() in the DFG when planting a direct reference to the global this object.
Instead of adding a separate toThisObject() method on JSCell which does not take ExecState*, I reascribed
a new contract: if you're calling toThisObject() on JSObject or one of its subtypes, then the ExecState*
is optional.

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalThisObjectFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSObject.h:

LayoutTests: DFG ConvertThis optimizations do not honor the distinction between the global object and the global this object
https://bugs.webkit.org/show_bug.cgi?id=75058
<rdar://problem/10616612>

Reviewed by Oliver Hunt.

  • fast/js/dfg-convert-this-dom-window-expected.txt: Added.
  • fast/js/dfg-convert-this-dom-window.html: Added.
  • fast/js/script-tests/dfg-convert-this-dom-window.js: Added.

(myObject.call):
(myFunction):
(myFunctionWithCall):
(myFunctionWithCall.call):

18:22 Changeset [103481] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.1/safari-534.54-branch

New tag.

18:21 Changeset [103480] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.1

New tag.

17:42 Changeset [103479] by jberlin@webkit.org
  • 3 edits in trunk/Source/WebKit/win

Expose to Windows the way to allow a scheme access to Local Storage and Databases while
Private Browsing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=75056

Reviewed by Sam Weinig.

Add the Windows WebKit API that corresponds to the Mac one added in r99439.

  • WebView.cpp:

(WebView::registerURLSchemeAsSecure):
(WebView::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebView::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):

  • WebView.h:
17:36 Changeset [103478] by kling@webkit.org
  • 16 edits in trunk/Source/WebCore

Unreviewed, rolling out r103473.
http://trac.webkit.org/changeset/103473
https://bugs.webkit.org/show_bug.cgi?id=74991

Overestimated my superpowers a bit here.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):

  • dom/Element.h:

(WebCore::Element::updateId):
(WebCore::Element::willModifyAttribute):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

  • dom/Node.h:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute):
(WebCore::HTMLAppletElement::insertedIntoDocument):
(WebCore::HTMLAppletElement::removedFromDocument):

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::removedFromDocument):

  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):
(WebCore::HTMLFormElement::parseMappedAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::insertedIntoDocument):
(WebCore::HTMLImageElement::removedFromDocument):

  • html/HTMLImageElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::formControlName):

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.h:
17:29 Changeset [103477] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Video format yuv422p doesn't show properly.
https://bugs.webkit.org/show_bug.cgi?id=69113

Patch by Shadi Khalek <shadi@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

  • media/video-colorspace-yuv420.html: Added.
  • media/video-colorspace-yuv422.html: Added.
17:12 Changeset [103476] by simon.fraser@apple.com
  • 5 edits
    6 adds in trunk

Source/WebCore: Clean up RenderLayer code that applies filters and transforms
https://bugs.webkit.org/show_bug.cgi?id=75032

This also fixes:

Nested filters not working as expected
https://bugs.webkit.org/show_bug.cgi?id=75029

Filter region is computed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=74889

Reviewed by James Robinson.

RenderLayer::paintLayer() had this confusing behavior where,
for transforms, it would change the CTM and then re-enter
the method with a bit set. This was partially, but incorrectly
copied for filters, so things like nested filters didn't work,
and the case of a filter + transform was confused.

Clean up by making RenderLayer::paintLayer() be a fairly simple
method that handles the re-entering with bit set, for both
transforms and filters. The bulk of the code in RenderLayer::paintLayer()
is now in RenderLayer::paintLayerContents(). There is no
behavior change for transforms.

There are two fixes for filters. First, instead of just using
the layer size to compute the bounds of the filtered region,
use transparencyClipBox() which already takes descendents, box
decorations etc into account (it's what we use for opacity).
Some cleanup of the coordinate math, and separation from transforms
code was also achieved.

Second, make sure we toggle off the PaintLayerAppliedFilters bit
(which was renamed for clarity) for sublayers, so that sublayers
paint their filters correctly.

Tests: css3/filters/filter-region.html

css3/filters/nested-filters.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updateFilterBackingStore):

  • rendering/RenderLayer.h:

LayoutTests: Clean up RenderLayer code that applies filters and transforms
https://bugs.webkit.org/show_bug.cgi?id=75032

Reviewed by James Robinson.

New tests for nested filters, and filtering an element
whose content is larger than its layer size.

  • css3/filters/filter-region-expected.png: Added.
  • css3/filters/filter-region-expected.txt: Added.
  • css3/filters/filter-region.html: Added.
  • css3/filters/nested-filter-expected.png:
  • css3/filters/nested-filters-expected.png: Added.
  • css3/filters/nested-filters-expected.txt: Added.
  • css3/filters/nested-filters.html: Added.
17:08 Changeset [103475] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/html/font-weight-bold-for-b-and-strong.html needs baselines
https://bugs.webkit.org/show_bug.cgi?id=75055

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:37 Changeset [103474] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Discard event data not followed by an empty line before eof when parsing an event-stream
https://bugs.webkit.org/show_bug.cgi?id=68833

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-12-21
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/eventsource/eventsource-eof.html

  • page/EventSource.cpp:

(WebCore::EventSource::didFinishLoading):
(WebCore::EventSource::parseEventStreamLine):

  • page/EventSource.h:

LayoutTests:

  • http/tests/eventsource/eventsource-eof-expected.txt: Added.
  • http/tests/eventsource/eventsource-eof.html: Added.
  • http/tests/eventsource/eventsource-reconnect-expected.txt: Updated.
  • http/tests/eventsource/eventsource-reconnect.html: Added lastEventId check.
  • http/tests/eventsource/resources/es-eof.php: Added.
  • http/tests/eventsource/resources/reconnect.php: Added data to be discarded.
  • http/tests/eventsource/resources/response-content-type-charset.php: Added empty line before eof.
  • http/tests/eventsource/resources/simple-event-stream.asis: Added empty line before eof.
16:25 Changeset [103473] by kling@webkit.org
  • 16 edits in trunk/Source/WebCore

Automate elements' registration as document namedItem/extraNamedItem.
<http://webkit.org/b/74991>

Reviewed by Antti Koivisto.

Remove caching of the "id" and "name" attributes on applet, embed, form,
image and object elements. We were caching them to keep the document's
map of named and "extra named" (named by id) item counts in sync.

Instead, add a hook to Element::willModifyAttribute() that detects when
the attributes are being changed and handle the registration/unregistration
automatically if the element returns true for shouldRegisterAsNamedItem()
or shouldRegisterAsExtraNamedItem() respectively.

This shrinks the elements by two AtomicStrings (8 or 16 bytes) each.

IFrame elements retain the old mechanism for now, as there are some subtle
differences to how that's handled.

  • dom/Node.h:

(WebCore::Node::hasName):
(WebCore::Node::setHasName):

Cache whether we have a "name" attribute or not (1 bit on Node.)
This is done in order to minimize the overhead added to Element's
insertedIntoDocument() and removeFromDocument().

  • dom/Element.cpp:

(WebCore::Element::updateNamedItemRegistration):
(WebCore::Element::updateExtraNamedItemRegistration):

Added. Called when the "name" and "id" attributes are changed.
Updates the document's named item maps accordingly.

(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):

Make sure updateName() is called in addition to updateId() when applicable.

(WebCore::Element::attributeChanged):

Update the Node's has-name flag as appropriate.

  • dom/Element.h:

(WebCore::Element::shouldRegisterAsNamedItem):
(WebCore::Element::shouldRegisterAsExtraNamedItem):

Added. If an element returns true for these, it will be automatically
registered with the document when the name/id attribute changes.

(WebCore::Element::updateId):
(WebCore::Element::updateName):

Register/unregister from the document's named item maps as appropriate.

(WebCore::Element::willModifyAttribute):

Add updateName() hook in addition to the existing updateId() hook.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

Make sure updateName() is called when we're cloning the attributes
from another element.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute):

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::insertedIntoDocument):

  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):
(WebCore::HTMLFormElement::parseMappedAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::insertedIntoDocument):

  • html/HTMLImageElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.h:

Remove duplicated code that is now handled by Element.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::formControlName):

Use fastGetAttribute() since we no longer cache the name.

16:25 Changeset [103472] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Patch by Scott Franklin <scottfr@google.com> on 2011-12-21
Reviewed by Eric Carlson.

Update LayoutTests/media/broken-video to test for correct error codes
https://bugs.webkit.org/show_bug.cgi?id=61573

  • media/broken-video-expected.txt:
  • media/broken-video.html:
16:23 Changeset [103471] by eric@webkit.org
  • 2 edits in trunk/Tools

Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
so that they appear in the bugzilla autocomplete CC list.
I also removed the "radar" irc nick (which I believe does not exist)
and removed the uneeded [] around the radar bugzilla email.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
16:10 Changeset [103470] by commit-queue@webkit.org
  • 1 edit
    286 adds in trunk/LayoutTests

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

Port W3C audio and video tests
https://bugs.webkit.org/show_bug.cgi?id=61541

  • media/W3C: Added.
  • media/W3C/audio: Added.
  • media/W3C/audio/canPlayType: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_2.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_bogus_type-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_bogus_type.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_method_exists-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_method_exists.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html: Added.
  • media/W3C/audio/currentSrc: Added.
  • media/W3C/audio/currentSrc/currentSrc_empty_if_no_src-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_empty_if_no_src.html: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_adding_source_child-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_adding_source_child.html: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_setting_src-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_setting_src.html: Added.
  • media/W3C/audio/currentSrc/currentSrc_property_exists-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_property_exists.html: Added.
  • media/W3C/audio/error: Added.
  • media/W3C/audio/error/error_null-expected.txt: Added.
  • media/W3C/audio/error/error_null.html: Added.
  • media/W3C/audio/error/error_onerror_called_on_bogus_source-expected.txt: Added.
  • media/W3C/audio/error/error_onerror_called_on_bogus_source.html: Added.
  • media/W3C/audio/error/error_property_exists-expected.txt: Added.
  • media/W3C/audio/error/error_property_exists.html: Added.
  • media/W3C/audio/events: Added.
  • media/W3C/audio/events/event_canplay-expected.txt: Added.
  • media/W3C/audio/events/event_canplay.html: Added.
  • media/W3C/audio/events/event_canplay_manual-expected.txt: Added.
  • media/W3C/audio/events/event_canplay_manual.html: Added.
  • media/W3C/audio/events/event_canplaythrough-expected.txt: Added.
  • media/W3C/audio/events/event_canplaythrough.html: Added.
  • media/W3C/audio/events/event_canplaythrough_manual-expected.txt: Added.
  • media/W3C/audio/events/event_canplaythrough_manual.html: Added.
  • media/W3C/audio/events/event_loadeddata-expected.txt: Added.
  • media/W3C/audio/events/event_loadeddata.html: Added.
  • media/W3C/audio/events/event_loadeddata_manual-expected.txt: Added.
  • media/W3C/audio/events/event_loadeddata_manual.html: Added.
  • media/W3C/audio/events/event_loadedmetadata-expected.txt: Added.
  • media/W3C/audio/events/event_loadedmetadata.html: Added.
  • media/W3C/audio/events/event_loadedmetadata_manual-expected.txt: Added.
  • media/W3C/audio/events/event_loadedmetadata_manual.html: Added.
  • media/W3C/audio/events/event_loadstart-expected.txt: Added.
  • media/W3C/audio/events/event_loadstart.html: Added.
  • media/W3C/audio/events/event_loadstart_manual-expected.txt: Added.
  • media/W3C/audio/events/event_loadstart_manual.html: Added.
  • media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt: Added.
  • media/W3C/audio/events/event_order_canplay_canplaythrough.html: Added.
  • media/W3C/audio/events/event_order_canplay_playing-expected.txt: Added.
  • media/W3C/audio/events/event_order_canplay_playing.html: Added.
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt: Added.
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata.html: Added.
  • media/W3C/audio/events/event_order_loadstart_progress-expected.txt: Added.
  • media/W3C/audio/events/event_order_loadstart_progress.html: Added.
  • media/W3C/audio/events/event_pause_manual-expected.txt: Added.
  • media/W3C/audio/events/event_pause_manual.html: Added.
  • media/W3C/audio/events/event_play-expected.txt: Added.
  • media/W3C/audio/events/event_play.html: Added.
  • media/W3C/audio/events/event_play_manual-expected.txt: Added.
  • media/W3C/audio/events/event_play_manual.html: Added.
  • media/W3C/audio/events/event_playing-expected.txt: Added.
  • media/W3C/audio/events/event_playing.html: Added.
  • media/W3C/audio/events/event_playing_manual-expected.txt: Added.
  • media/W3C/audio/events/event_playing_manual.html: Added.
  • media/W3C/audio/events/event_progress-expected.txt: Added.
  • media/W3C/audio/events/event_progress.html: Added.
  • media/W3C/audio/events/event_progress_manual-expected.txt: Added.
  • media/W3C/audio/events/event_progress_manual.html: Added.
  • media/W3C/audio/events/event_timeupdate-expected.txt: Added.
  • media/W3C/audio/events/event_timeupdate.html: Added.
  • media/W3C/audio/events/event_timeupdate_manual-expected.txt: Added.
  • media/W3C/audio/events/event_timeupdate_manual.html: Added.
  • media/W3C/audio/networkState: Added.
  • media/W3C/audio/networkState/networkState_during_loadstart-expected.txt: Added.
  • media/W3C/audio/networkState/networkState_during_loadstart.html: Added.
  • media/W3C/audio/networkState/networkState_initial-expected.txt: Added.
  • media/W3C/audio/networkState/networkState_initial.html: Added.
  • media/W3C/audio/networkState/networkState_property_exists-expected.txt: Added.
  • media/W3C/audio/networkState/networkState_property_exists.html: Added.
  • media/W3C/audio/paused: Added.
  • media/W3C/audio/paused/paused_false_during_play-expected.txt: Added.
  • media/W3C/audio/paused/paused_false_during_play.html: Added.
  • media/W3C/audio/paused/paused_true_during_pause-expected.txt: Added.
  • media/W3C/audio/paused/paused_true_during_pause.html: Added.
  • media/W3C/audio/preload: Added.
  • media/W3C/audio/preload/preload_property_exists-expected.txt: Added.
  • media/W3C/audio/preload/preload_property_exists.html: Added.
  • media/W3C/audio/preload/preload_reflects_auto_value-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_auto_value.html: Added.
  • media/W3C/audio/preload/preload_reflects_bogus_value-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_bogus_value.html: Added.
  • media/W3C/audio/preload/preload_reflects_empty-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_empty.html: Added.
  • media/W3C/audio/preload/preload_reflects_metadata-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_metadata.html: Added.
  • media/W3C/audio/preload/preload_reflects_no_value-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_no_value.html: Added.
  • media/W3C/audio/preload/preload_reflects_none-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_none.html: Added.
  • media/W3C/audio/preload/preload_reflects_none_autoplay-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_none_autoplay.html: Added.
  • media/W3C/audio/readyState: Added.
  • media/W3C/audio/readyState/readyState_during_canplay-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_canplay.html: Added.
  • media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_canplaythrough.html: Added.
  • media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_loadeddata.html: Added.
  • media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_loadedmetadata.html: Added.
  • media/W3C/audio/readyState/readyState_during_playing-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_playing.html: Added.
  • media/W3C/audio/readyState/readyState_initial-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_initial.html: Added.
  • media/W3C/audio/readyState/readyState_property_exists-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_property_exists.html: Added.
  • media/W3C/audio/src: Added.
  • media/W3C/audio/src/src_reflects_attribute_not_source_elements-expected.txt: Added.
  • media/W3C/audio/src/src_reflects_attribute_not_source_elements.html: Added.
  • media/W3C/audio/src/src_reflects_no_value-expected.txt: Added.
  • media/W3C/audio/src/src_reflects_no_value.html: Added.
  • media/W3C/audio/src/src_removal_does_not_trigger_loadstart-expected.txt: Added.
  • media/W3C/audio/src/src_removal_does_not_trigger_loadstart.html: Added.
  • media/W3C/video: Added.
  • media/W3C/video/canPlayType: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream.html: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_bogus_type.html: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_method_exists.html: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_4.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_5.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_6.html: Added.
  • media/W3C/video/currentSrc: Added.
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src.html: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_adding_source_child-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_adding_source_child.html: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_setting_src-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_setting_src.html: Added.
  • media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_property_exists.html: Added.
  • media/W3C/video/error: Added.
  • media/W3C/video/error/error_null-expected.txt: Added.
  • media/W3C/video/error/error_null.html: Added.
  • media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt: Added.
  • media/W3C/video/error/error_onerror_called_on_bogus_source.html: Added.
  • media/W3C/video/error/error_property_exists-expected.txt: Added.
  • media/W3C/video/error/error_property_exists.html: Added.
  • media/W3C/video/events: Added.
  • media/W3C/video/events/event_canplay-expected.txt: Added.
  • media/W3C/video/events/event_canplay.html: Added.
  • media/W3C/video/events/event_canplay_manual-expected.txt: Added.
  • media/W3C/video/events/event_canplay_manual.html: Added.
  • media/W3C/video/events/event_canplaythrough-expected.txt: Added.
  • media/W3C/video/events/event_canplaythrough.html: Added.
  • media/W3C/video/events/event_canplaythrough_manual-expected.txt: Added.
  • media/W3C/video/events/event_canplaythrough_manual.html: Added.
  • media/W3C/video/events/event_loadeddata-expected.txt: Added.
  • media/W3C/video/events/event_loadeddata.html: Added.
  • media/W3C/video/events/event_loadeddata_manual-expected.txt: Added.
  • media/W3C/video/events/event_loadeddata_manual.html: Added.
  • media/W3C/video/events/event_loadedmetadata-expected.txt: Added.
  • media/W3C/video/events/event_loadedmetadata.html: Added.
  • media/W3C/video/events/event_loadedmetadata_manual-expected.txt: Added.
  • media/W3C/video/events/event_loadedmetadata_manual.html: Added.
  • media/W3C/video/events/event_loadstart-expected.txt: Added.
  • media/W3C/video/events/event_loadstart.html: Added.
  • media/W3C/video/events/event_loadstart_manual-expected.txt: Added.
  • media/W3C/video/events/event_loadstart_manual.html: Added.
  • media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt: Added.
  • media/W3C/video/events/event_order_canplay_canplaythrough.html: Added.
  • media/W3C/video/events/event_order_canplay_playing-expected.txt: Added.
  • media/W3C/video/events/event_order_canplay_playing.html: Added.
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt: Added.
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata.html: Added.
  • media/W3C/video/events/event_order_loadstart_progress-expected.txt: Added.
  • media/W3C/video/events/event_order_loadstart_progress.html: Added.
  • media/W3C/video/events/event_pause_manual-expected.txt: Added.
  • media/W3C/video/events/event_pause_manual.html: Added.
  • media/W3C/video/events/event_play-expected.txt: Added.
  • media/W3C/video/events/event_play.html: Added.
  • media/W3C/video/events/event_play_manual-expected.txt: Added.
  • media/W3C/video/events/event_play_manual.html: Added.
  • media/W3C/video/events/event_playing-expected.txt: Added.
  • media/W3C/video/events/event_playing.html: Added.
  • media/W3C/video/events/event_playing_manual-expected.txt: Added.
  • media/W3C/video/events/event_playing_manual.html: Added.
  • media/W3C/video/events/event_progress-expected.txt: Added.
  • media/W3C/video/events/event_progress.html: Added.
  • media/W3C/video/events/event_progress_manual-expected.txt: Added.
  • media/W3C/video/events/event_progress_manual.html: Added.
  • media/W3C/video/events/event_timeupdate-expected.txt: Added.
  • media/W3C/video/events/event_timeupdate.html: Added.
  • media/W3C/video/events/event_timeupdate_manual-expected.txt: Added.
  • media/W3C/video/events/event_timeupdate_manual.html: Added.
  • media/W3C/video/networkState: Added.
  • media/W3C/video/networkState/networkState_during_loadstart-expected.txt: Added.
  • media/W3C/video/networkState/networkState_during_loadstart.html: Added.
  • media/W3C/video/networkState/networkState_during_progress-expected.txt: Added.
  • media/W3C/video/networkState/networkState_during_progress.html: Added.
  • media/W3C/video/networkState/networkState_initial-expected.txt: Added.
  • media/W3C/video/networkState/networkState_initial.html: Added.
  • media/W3C/video/networkState/networkState_property_exists-expected.txt: Added.
  • media/W3C/video/networkState/networkState_property_exists.html: Added.
  • media/W3C/video/paused: Added.
  • media/W3C/video/paused/paused_false_during_play-expected.txt: Added.
  • media/W3C/video/paused/paused_false_during_play.html: Added.
  • media/W3C/video/paused/paused_true_during_pause-expected.txt: Added.
  • media/W3C/video/paused/paused_true_during_pause.html: Added.
  • media/W3C/video/preload: Added.
  • media/W3C/video/preload/preload_property_exists-expected.txt: Added.
  • media/W3C/video/preload/preload_property_exists.html: Added.
  • media/W3C/video/preload/preload_reflects_auto_value-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_auto_value.html: Added.
  • media/W3C/video/preload/preload_reflects_bogus_value-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_bogus_value.html: Added.
  • media/W3C/video/preload/preload_reflects_empty-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_empty.html: Added.
  • media/W3C/video/preload/preload_reflects_metadata-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_metadata.html: Added.
  • media/W3C/video/preload/preload_reflects_no_value-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_no_value.html: Added.
  • media/W3C/video/preload/preload_reflects_none-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_none.html: Added.
  • media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_none_autoplay.html: Added.
  • media/W3C/video/readyState: Added.
  • media/W3C/video/readyState/readyState_during_canplay-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_canplay.html: Added.
  • media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_canplaythrough.html: Added.
  • media/W3C/video/readyState/readyState_during_loadeddata-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_loadeddata.html: Added.
  • media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_loadedmetadata.html: Added.
  • media/W3C/video/readyState/readyState_during_playing-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_playing.html: Added.
  • media/W3C/video/readyState/readyState_initial-expected.txt: Added.
  • media/W3C/video/readyState/readyState_initial.html: Added.
  • media/W3C/video/readyState/readyState_property_exists-expected.txt: Added.
  • media/W3C/video/readyState/readyState_property_exists.html: Added.
  • media/W3C/video/src: Added.
  • media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt: Added.
  • media/W3C/video/src/src_reflects_attribute_not_source_elements.html: Added.
  • media/W3C/video/src/src_reflects_no_value-expected.txt: Added.
  • media/W3C/video/src/src_reflects_no_value.html: Added.
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt: Added.
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart.html: Added.
  • media/W3C/w3cwrapper.js: Added.

(getVideoURI.bool):
(getVideoURI):
():
(test):
(async_test.t.step):
(async_test.t.done):
(async_test):
(assert_equals):
(assert_true):
(assert_false):

16:00 Changeset [103469] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r99097.

15:58 Changeset [103468] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-12-21
Reviewed by Ryosuke Niwa.

strong and b should be font-weight: bold, not bolder
https://bugs.webkit.org/show_bug.cgi?id=56400

Source/WebCore:

Test: fast/html/font-weight-bold-for-b-and-strong.html

  • css/html.css:

(strong, b):

LayoutTests:

Changed html.css to specify that strong and b are font-weight: bold,
not font-weight: bolder. Test added to confirm.

  • fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
  • fast/html/font-weight-bold-for-b-and-strong.html: Added.
  • WebCore/css/html.css:
15:39 Changeset [103467] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Implement montonicallyIncreasingClock() on Qt
https://bugs.webkit.org/show_bug.cgi?id=62159

Reviewed by Darin Adler.

  • wtf/CurrentTime.cpp:

(WTF::monotonicallyIncreasingTime):

15:38 Changeset [103466] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark use-same-database-in-page-and-workers.html as crashing
https://bugs.webkit.org/show_bug.cgi?id=75048

Unreviewed gardening.

Also, fix lint issues.

  • platform/chromium/test_expectations.txt:
15:26 Changeset [103465] by commit-queue@webkit.org
  • 42 edits
    2 adds in trunk

Improper handling of foreignobjects nested in svg groups
https://bugs.webkit.org/show_bug.cgi?id=69762

Patch by Florin Malita <fmalita@google.com> on 2011-12-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/foreignObject/repaint-rect-coordinates-expected.html

svg/foreignObject/repaint-rect-coordinates.html

  • rendering/svg/RenderSVGForeignObject.h:

(WebCore::RenderSVGForeignObject::objectBoundingBox):
(WebCore::RenderSVGForeignObject::strokeBoundingBox):
(WebCore::RenderSVGForeignObject::repaintRectInLocalCoordinates):
Return local coordinates.

LayoutTests:

Rebaseline after changing
RenderSVGForeignObject::{objectBoundingBox,strokeBoundingBox,repaintRectInLocalCoordinates}
to return local coordinates.

  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/gtk/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt:
  • svg/foreignObject/multiple-foreign-objects-expected.txt:
  • svg/foreignObject/repaint-rect-coordinates-expected.html: Added.
  • svg/foreignObject/repaint-rect-coordinates.html: Added.
15:22 Changeset [103464] by dbates@webkit.org
  • 3 edits in trunk/Tools

Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
https://bugs.webkit.org/show_bug.cgi?id=74985

Patch by Daniel Bates <dbates@rim.com> on 2011-12-21
Reviewed by Eric Seidel.

  • Scripts/build-jsc:
  • Scripts/webkitdirs.pm:

(cmakeBasedPortName): Added.

15:12 Changeset [103463] by simon.fraser@apple.com
  • 13 edits in trunk/LayoutTests

Update pixel results for CSS filters
https://bugs.webkit.org/show_bug.cgi?id=75045

Reviewed by Sam Weinig.

Update some pixel results for CSS filter tests after r103125.

  • css3/filters/effect-blur-hw-expected.png:
  • css3/filters/effect-combined-hw-expected.png:
  • css3/filters/effect-custom-expected.png:
  • css3/filters/effect-drop-shadow-hw-expected.png:
  • css3/filters/effect-grayscale-hw-expected.png:
  • css3/filters/effect-hue-rotate-hw-expected.png:
  • css3/filters/effect-invert-hw-expected.png:
  • css3/filters/effect-opacity-hw-expected.png:
  • css3/filters/effect-saturate-hw-expected.png:
  • css3/filters/effect-sepia-hw-expected.png:
  • css3/filters/filter-with-transform-expected.png:
  • css3/filters/nested-filter-expected.png:
15:02 Changeset [103462] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make it possible to use contents layers in scrollbars
https://bugs.webkit.org/show_bug.cgi?id=75044

Reviewed by Simon Fraser.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
Don't pass const GraphicsLayers to these member functions; we need to be able to mutate them.

  • platform/ScrollView.cpp:

(positionScrollbarLayer):
If the scrollbar layer has a contents layer, just update its contents rect. Otherwise,
invalidate the scrollbar layer.

14:56 Changeset [103461] by dbates@webkit.org
  • 3 edits in trunk/Tools

Extract BlackBerry CMake arguments from build-webkit into separate function
https://bugs.webkit.org/show_bug.cgi?id=74981

Patch by Daniel Bates <dbates@rim.com> on 2011-12-21
Reviewed by Rob Buis.

Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
that we can pass them to the CMake build system when building JavaScriptCore.

  • Scripts/build-webkit: Move construction of CMake argument list from here to

webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
call it from build-webkit.

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments): Added.
(cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
BlackBerry port.

14:50 Changeset [103460] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

14:48 Changeset [103459] by lforschler@apple.com
  • 1 copy in tags/Safari-535.14

New Tag.

14:47 Changeset [103458] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark color-prop-05-t.svg as failing after r103427
https://bugs.webkit.org/show_bug.cgi?id=75042

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
14:46 Changeset [103457] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Always reposition the scrollbar layers when the frame view size changes
https://bugs.webkit.org/show_bug.cgi?id=75035

Reviewed by Darin Adler.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Remove the layersChanged check and unconditionally call positionScrollbarLayers(). This only
worked by accident before because we were recreating horizontal and vertical scrollbars on every call.

14:45 Changeset [103456] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r95054.

14:43 Changeset [103455] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[EFL] Add 'Select All' option to context menus in WebKit-EFL.
https://bugs.webkit.org/show_bug.cgi?id=74920

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2011-12-21
Reviewed by Eric Seidel.

Enable 'Select All' option to context menus called on input fields in WebKit-EFL
as it is enabled in GTK and QT ports.

Source/WebCore:

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Add 'Select All' option.
(WebCore::ContextMenuController::populate): Append 'Select All' item.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Enable 'Select All' option.

  • platform/ContextMenuItem.h: Add 'Select All' option.
  • platform/LocalizationStrategy.h: Add constructor for 'Select All' option.
  • platform/LocalizedStrings.h: Add constructor for 'Select All' option.

Source/WebKit/efl:

  • ewk/ewk_contextmenu.h: Add new context menu option 'Select All'.
14:38 Changeset [103454] by lforschler@apple.com
  • 2 edits
    3 copies in branches/safari-534.54-branch

Merged r95028.

14:35 Changeset [103453] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r95010.

14:34 Changeset [103452] by adamk@chromium.org
  • 6 edits in trunk/Source/WebCore

Make calls to willModifyAttribute and attributeChanged symmetrical
https://bugs.webkit.org/show_bug.cgi?id=74987

Reviewed by Ryosuke Niwa.

Previously, calls to Element::willModifyAttribute sometimes happened
in one method while calls to Element::attributeChanged happened in
another. This change makes them symmetrical for all the cases I know
about: setAttribute, removeAttribute, setNamedItem, removeNamedItem.

To accomplish this, NamedNodeMap::addAttribute, removeAttribute, and
replaceAttribute have been reduced to their pure functionality of
manipulating m_attributes, and their callers are left responsible for
properly notifying the Element of the underlying changes.

One other bit of refactoring was done: to simplify
Element::setAttribute, it now dispatches to
Element::removeAttributeInternal if the incoming value is null.

No new tests, no change in behavior.

  • dom/Attribute.h:
  • dom/Element.cpp:

(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeInternal): Added, sharing code
between the two removeAttribute overloads.
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(WebCore::NamedNodeMap::replaceAttribute):

  • svg/properties/SVGAnimatedPropertySynchronizer.h:

Call Element::setAttribute unless the attribute is already present,
and add a comment explaining why the code looks the way it does.

14:31 Changeset [103451] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r94991.

14:29 Changeset [103450] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more Mac compositing tests as flaky
https://bugs.webkit.org/show_bug.cgi?id=47949

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
14:28 Changeset [103449] by lforschler@apple.com
  • 8 edits
    3 copies in branches/safari-534.54-branch

Merged r94905.

14:24 Changeset [103448] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r94892.

14:21 Changeset [103447] by lforschler@apple.com
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r94857.

14:12 Changeset [103446] by lforschler@apple.com
  • 14 edits in branches/safari-534.54-branch

Merged r94582.

14:08 Changeset [103445] by enne@google.com
  • 7 edits in trunk

Unreviewed, rolling out r103408.
http://trac.webkit.org/changeset/103408
https://bugs.webkit.org/show_bug.cgi?id=75017

WorkerDevToolsSanityTest.InspectSharedWorker is failing
(Requested by loislo_ on #webkit).

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
14:07 Changeset [103444] by lforschler@apple.com
  • 20 edits
    24 copies in branches/safari-534.54-branch

Merged r94543.

13:58 Changeset [103443] by lforschler@apple.com
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r94541.

13:51 Changeset [103442] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r94512.

13:49 Changeset [103441] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94511.

13:45 Changeset [103440] by lforschler@apple.com
  • 10 edits
    2 copies in branches/safari-534.54-branch

Merged r94508.

13:40 Changeset [103439] by senorblanco@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Fix CSS filters crash on zero-sized elements.
https://bugs.webkit.org/show_bug.cgi?id=75020

Reviewed by Dean Jackson.

Test: css3/filters/filter-empty-element-crash.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::inputContext):
Protect against null ImageBuffer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
Protect against null GraphicsContext.

LayoutTests: Test for CSS filters crash on zero-sized element
https://bugs.webkit.org/show_bug.cgi?id=75020

Reviewed by Dean Jackson.

  • css3/filters/filter-empty-element-crash-expected.txt: Added.
  • css3/filters/filter-empty-element-crash.html: Added.
13:21 Changeset [103438] by timothy@apple.com
  • 4 edits in trunk/Source

Web Inspector: suppress incremental rendering and use application chrome mode

https://webkit.org/b/75026

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting,
set suppress incremental rendering and use application chrome mode.

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Set suppress incremental rendering and use application chrome mode.

13:08 Changeset [103437] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94455.

13:04 Changeset [103436] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94112.

13:01 Changeset [103435] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Inform the scrolling coordinator when scrollbar layers come and go
https://bugs.webkit.org/show_bug.cgi?id=75028

Reviewed by Andreas Kling and Simon Fraser.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::setFrameViewHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinator::setFrameViewVerticalScrollbarLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

13:01 Changeset [103434] by lforschler@apple.com
  • 11 edits
    6 copies in branches/safari-534.54-branch

Merged r94109.

12:44 Changeset [103433] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r94099.

12:39 Changeset [103432] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r94095.

12:35 Changeset [103431] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94001.

12:31 Changeset [103430] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r93943.

12:27 Changeset [103429] by dslomov@google.com
  • 5 edits in trunk

Source/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
https://bugs.webkit.org/show_bug.cgi?id=74554

Reviewed by David Levin.

Covered by existing tests in fast/workers/storage.

  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::performTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::isCleanupTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):

LayoutTests: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread.
https://bugs.webkit.org/show_bug.cgi?id=74554

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
12:09 Changeset [103428] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::configureTextTrackDisplay is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=74945

Reviewed by Darin Adler.

Nothing to test, just removing redundant code. Correct behavior tested by
media/track/track-cue-rendering.html and media/track/track-cue-nothing-to-render.html.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Don't show and hide track, just call

updateTextTrackDisplay and it will do the right thing.

12:09 Changeset [103427] by zimmermann@webkit.org
  • 252 edits
    1 move in trunk/LayoutTests

2011-12-21 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline pixel test results, which have < 0.011 diffs on my 64bit SL machine.
This is a preparation, to build a new baseline with Lion.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png:
  • platform/mac-snowleopard/svg/filters/feOffset-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
  • platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/mac/svg/as-image/same-image-two-instances-expected.png:
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/text/textOnPath2-expected.png:
  • platform/mac/svg/batik/text/textOnPath3-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/button-expected.png:
  • platform/mac/svg/carto.net/colourpicker-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/slider-expected.png:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/mac/svg/css/composite-shadow-text-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/dasharrayOrigin-expected.png:
  • platform/mac/svg/custom/embedding-external-svgs-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/fill-opacity-update-expected.png:
  • platform/mac/svg/custom/fractional-rects-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/invalid-css-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/mac/svg/custom/linking-uri-01-b-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/mac/svg/custom/pattern-in-defs-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/mac/svg/custom/rounded-rects-expected.png:
  • platform/mac/svg/custom/simple-text-double-shadow-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Copied from svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/hixie/cascade/002-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/transform/001-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/selection-styles-expected.png:
  • platform/mac/svg/text/small-fonts-3-expected.png:
  • platform/mac/svg/text/text-align-03-b-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/textPathBoundsBug-expected.png:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
11:52 Changeset [103426] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

ScrollingCoordinator functions should take FrameView objects
https://bugs.webkit.org/show_bug.cgi?id=75023

Reviewed by Sam Weinig.

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::syncFrameViewGeometry):

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::setFrameViewScrollLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootLayer):

11:52 Changeset [103425] by lforschler@apple.com
  • 5 edits
    30 copies in branches/safari-534.54-branch

Merged r93794.

11:48 Changeset [103424] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/WebKit/mac

Merged r93732.

11:45 Changeset [103423] by lforschler@apple.com
  • 3 edits
    4 copies in branches/safari-534.54-branch

Merged r93521.

11:42 Changeset [103422] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r93514.

11:41 Changeset [103421] by andersca@apple.com
  • 9 edits
    1 delete in trunk/Source/WebCore

Get rid of ScrollableAreaClient
https://bugs.webkit.org/show_bug.cgi?id=75021

Reviewed by Sam Weinig.

The ScrollableAreaClient interface will just add an extra level of indirection between ScrollableArea and
ScrollAnimator, which is unnecessary. Eventually I'd like to rename ScrollAnimator to something that better reflects
all the different responsibilities it currently has.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):

  • page/ScrollingCoordinator.cpp:
  • page/ScrollingCoordinator.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):

  • platform/ScrollableArea.h:
  • platform/ScrollableAreaClient.h: Removed.
11:32 Changeset [103420] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBoxModelObject.cpp

Fixing a sub-pixel fillRect call with pixelSnappedIntRect

11:28 Changeset [103419] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Don't recreate scrollbar layers whenever the frame view size changes
https://bugs.webkit.org/show_bug.cgi?id=75018

Reviewed by Darin Adler and Simon Fraser.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

11:09 Changeset [103418] by dbates@webkit.org
  • 3 edits in trunk/Tools

Extract WinCE CMake arguments from build-webkit into separate function
https://bugs.webkit.org/show_bug.cgi?id=74983

Reviewed by Rob Buis.

Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
that we can pass it to the CMake build system when building JavaScriptCore.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(cmakeBasedPortArguments): Added.

11:05 Changeset [103417] by dbates@webkit.org
  • 4 edits in trunk

Add CMake option to only build JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=74979

Reviewed by Rob Buis.

Towards adding CMake support to script Tools/Scripts/build-jsc, add a CMake
option to only build JavaScriptCore.

  • CMakeLists.txt: Defined ENABLE_WEBCORE to build WebCore. If the option

ONLY_BUILD_JAVASCRIPTCORE is specified then don't build WebCore, WebKit, or WebKit2.

  • Source/CMakeLists.txt:
  • Source/cmake/WebKitFS.cmake:
10:56 Changeset [103416] by lforschler@apple.com
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r93347.

10:49 Changeset [103415] by lforschler@apple.com
  • 8 edits
    3 copies in branches/safari-534.54-branch

Merged r93227.

10:43 Changeset [103414] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Cleanup up clients when deallocating WebKit2 API objects
https://bugs.webkit.org/show_bug.cgi?id=75014

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):

  • UIProcess/API/mac/WKConnection.mm:

(-[WKConnection dealloc]):
Clear clients on dealloc.

10:21 Changeset [103413] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Add tests for favicon and fix icon url decoding issue
https://bugs.webkit.org/show_bug.cgi?id=74967

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-21
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qwebiconimageprovider.cpp: We already receive the url

without the percent encoding and we should access WebIconDatabase with
an encoded url. Added a test to cover this behavior.
(QWebIconImageProvider::requestImage):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/favicon.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/favicon.png: Added.
  • UIProcess/API/qt/tests/qmltests/common/favicon2.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
10:19 Changeset [103412] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Exception thrown when running WKBrowsingContextLoadDelegateTest.SimpleLoad test
https://bugs.webkit.org/show_bug.cgi?id=75012

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup dealloc]):
Clear the WKContext's connection client.

09:20 Changeset [103411] by caseq@chromium.org
  • 12 edits
    1 add
    1 delete in trunk

Web Inspector: [Extension API] refactor extension API build code, expose experimental APIs conditionally in chromium
https://bugs.webkit.org/show_bug.cgi?id=74941

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • inspector/front-end/ExtensionAPI.js:

(buildPlatformExtensionAPI.platformExtensionAPI):
(buildPlatformExtensionAPI):
(buildExtensionAPIInjectedScript):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):
(window.addExtension):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • scripts/concatenate_js_files.py:

(main):

  • scripts/generate_devtools_extension_api.py:

(write_devtools_extension_api):

  • src/js/DevTools.js:

():

LayoutTests:

  • http/tests/inspector/extensions-test.js:

(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
(initialize_ExtensionsTest):

  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
09:03 Changeset [103410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-21
Reviewed by Kenneth Rohde Christiansen.

Added a viewport meta tag so that the view is actually scrollable and
does not get scaled to not be scrollable. Corrected the style
definition for the <div> tag. Removed unneeded text in div

Rolled back changes some of the changes from the previous patch
(r102453) because they weren't necessary.

  • UIProcess/API/qt/tests/html/scroll.html:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest): Partially rolled back changes.

08:24 Changeset [103409] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

Replace all instances of "WebPropupMenuProxy" with "WebPopupMenuProxy".

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

07:48 Changeset [103408] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: fix source map url resolving.
https://bugs.webkit.org/show_bug.cgi?id=74305

Reviewed by Pavel Feldman.

Source/WebCore:

Also fix the bug with repeated source urls in mapping sections.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.installCompilerSourceMapping):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
07:28 Changeset [103407] by reni@webkit.org
  • 3729 edits in trunk

New renderer for SVGRectElement
https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Rubber-stamped by Zoltan Herczeg.

Change the return value of RenderSVGRect::renderName() from RenderSVGPath to RenderSVGRect.
This is a follow-up patch of r101517 to correct the DRT output.

  • rendering/svg/RenderSVGRect.h:

(WebCore::RenderSVGRect::renderName):

LayoutTests:

Rubber stamped by Zoltan Herczeg.

Rename the renderer of SVGRects from RenderSVGPath to RenderSVGRect.

06:38 Changeset [103406] by vsevik@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: TabbedPane should use tabElement width measuring to layout tab elements when width is too small to fit them.
https://bugs.webkit.org/show_bug.cgi?id=75005

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/tabbed-pane-max-tab-width-calculation.html

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype.wasShown):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype._createTabElement):
(WebInspector.TabbedPane.prototype.onResize):
(WebInspector.TabbedPane.prototype._maybeMeasureAndUpdate):
(WebInspector.TabbedPane.prototype._measureTab):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._calculateMaxWidth):
(WebInspector.TabbedPaneTab):

  • inspector/front-end/inspector.css:

(.tabbed-pane-header):
(.tabbed-pane-header-tabs):
(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab.measuring):
(.tabbed-pane-header-tab.selected):

  • inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .tabbed-pane-header-tabs):

LayoutTests:

  • inspector/tabbed-pane-max-tab-width-calculation-expected.txt: Added.
  • inspector/tabbed-pane-max-tab-width-calculation.html: Added.
05:52 Changeset [103405] by podivilov@chromium.org
  • 8 edits in trunk

Web Inspector: auto detect source map url.
https://bugs.webkit.org/show_bug.cgi?id=74088

Reviewed by Pavel Feldman.

Source/WebCore:

Check to see if "X-SourceMap" HTTP response header was sent with script resource.
Header value will be used as auto suggestion for source map url in UI.

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):

  • inspector/front-end/Script.js:

(WebInspector.Script):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
05:48 Changeset [103404] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Mobile theme refinements
https://bugs.webkit.org/show_bug.cgi?id=74727

Mostly to replace most of the rounded-rect-shaped
controls with squircle-shaped ones.

Reviewed by Kenneth Rohde Christiansen.

No new tests needed.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::drawControlBackground):
(WebCore::painterScale):
(WebCore::borderPen):
(WebCore::StylePainterMobile::drawCheckableBackground): Toned down the gradient a bit.
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton): increase spacing between the dots.
(WebCore::StylePainterMobile::drawSimpleComboButton): attempt to improve readability.
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::findPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::paintTextField):

  • platform/qt/RenderThemeQtMobile.h:
05:45 Changeset [103403] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CSSStyleSheet::cssRules can return 0 and InspectorStyleSheet dosen't check
https://bugs.webkit.org/show_bug.cgi?id=74938

Prevent security checks when retrieving a just-added CSS rule from the "inspector stylesheet".

Reviewed by Pavel Feldman.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

02:38 Changeset [103402] by ossy@webkit.org
  • 39 edits
    10 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected results.

  • platform/qt/Skipped: Skip fast/text/international/bdi-neutral-wrapped.html because of missing test font.
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.png: Added.
  • platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/qt/test_expectations.txt: Unskip passing tests.
02:20 Changeset [103401] by reni@webkit.org
  • 4 edits in trunk/Source/WebCore

Fulfill FIXME in HTMLLinkElement.h.
https://bugs.webkit.org/show_bug.cgi?id=74278

Rename isStyleSheetLoading() method to styleSheetIsLoading().
This new one has the correct grammar.

Reviewed by Darin Adler.

No new tests because the functionality remains the same.

  • dom/Document.cpp:

(WebCore::Document::recalcStyleSelector):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::sheetLoaded):

  • html/HTMLLinkElement.h:
01:47 Changeset [103400] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebCore

[Forms] Add OVERRIDE to WebCore/html/*InputType.h
https://bugs.webkit.org/show_bug.cgi?id=74996

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

No new tests. Changes are just for compilation.

  • html/BaseButtonInputType.h: Add OVERRIDE.
  • html/BaseCheckableInputType.h: Add OVERRIDE.
  • html/BaseDateAndTimeInputType.h: Add OVERRIDE.
  • html/BaseTextInputType.h: Add OVERRIDE.
  • html/ButtonInputType.h: Add OVERRIDE.
  • html/CheckboxInputType.h: Add OVERRIDE.
  • html/ColorInputType.h: Add OVERRIDE.
  • html/DateInputType.h: Add OVERRIDE.
  • html/DateTimeInputType.h: Add OVERRIDE.
  • html/DateTimeLocalInputType.h: Add OVERRIDE.
  • html/EmailInputType.h: Add OVERRIDE.
  • html/FileInputType.h: Add OVERRIDE.
  • html/HiddenInputType.h: Add OVERRIDE.
  • html/ImageInputType.h: Add OVERRIDE.
  • html/IsIndexInputType.h: Add OVERRIDE.
  • html/MonthInputType.h: Add OVERRIDE.
  • html/NumberInputType.h: Add OVERRIDE.
  • html/PasswordInputType.h: Add OVERRIDE.
  • html/RadioInputType.h: Add OVERRIDE.
  • html/RangeInputType.h: Add OVERRIDE.
  • html/ResetInputType.h: Add OVERRIDE.
  • html/SearchInputType.h: Add OVERRIDE.
  • html/SubmitInputType.h: Add OVERRIDE.
  • html/TelephoneInputType.h: Add OVERRIDE.
  • html/TextFieldInputType.h: Add OVERRIDE.
  • html/TextInputType.h: Add OVERRIDE.
  • html/TimeInputType.h: Add OVERRIDE.
  • html/URLInputType.h: Add OVERRIDE.
  • html/WeekInputType.h: Add OVERRIDE.
00:54 Changeset [103399] by haraken@chromium.org
  • 2 edits in trunk/Tools

In prepare-ChangeLog, replace constant global variables with "use constant"
https://bugs.webkit.org/show_bug.cgi?id=74992

Reviewed by Ryosuke Niwa.

This patch replaces the following constant global variables with "use constant"s.

  • $changeLogTimeZone
  • $SVN
  • $GIT
  • %supportedTestExtensions
  • Scripts/prepare-ChangeLog:

(changeLogNameFromArgs):
(changeLogEmailAddressFromArgs):
(resolveConflictedChangeLogs):
(generateNewChangeLogs):
(diffCommand):
(statusCommand):
(createPatchCommand):
(findOriginalFileFromSvn):
(determinePropertyChanges):
(generateFileList):
(reviewerAndDescriptionForGitCommit):

00:33 Changeset [103398] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update test expectation for svg/custom/linking-uri-01-b.svg

  • platform/chromium/test_expectations.txt:
00:19 Changeset [103397] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add all ICU languages to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=67274

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

This better mimics the behavior of LocaleToScriptMappingICU.cpp. ICU
languages from ICU 3.6 are added. Also, script suffix in locale is
handled, so for example "fa_Latn" is mapped to Latin while "fa" is mapped to
Arabic.

No new tests, there is no visible effect until default per-script fonts
are added to non-ICU ports (alternatively, we could extend DumpRenderTree
to support overridePreference for per-script fonts as in bug 71110).

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::getScriptCode): add script name to script code mapping
(WebCore::localeToScriptCodeForFontSelection): add ICU languages to map

00:11 Changeset [103396] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update test expectations for inspector's tests.

  • platform/chromium/test_expectations.txt:
00:09 Changeset [103395] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] [Gardening] Move tests to the right skip list.
https://bugs.webkit.org/show_bug.cgi?id=74958

These tests pass on Qt-5.0 both with WK1 and WK2 but fail on Qt-4.8.
Also removes comment refering to Qt-4.7 since the test fails on all
versions at the moment.

Patch by João Paulo Rechi Vita <jprvita@openbossa.org> on 2011-12-21
Reviewed by Csaba Osztrogonác.

  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
00:03 Changeset [103394] by levin@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Disable a test without a result while I figure out
how to make the results consistent for each run.
Bug 74666 basically tracks re-enabling this test
since it contains an enhanced version of it.

  • http/tests/workers/interrupt-database-sync-open-crash.html-skipped: Renamed from LayoutTests/http/tests/workers/interrupt-database-sync-open-crash.html.

12/20/11:

23:44 Changeset [103393] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

Upstream PageClientBlackBerry.h into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74169

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-20
Reviewed by Daniel Bates.

Initial upstream, no new tests.

  • platform/blackberry/PageClientBlackBerry.h: Added.
23:40 Changeset [103392] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32_64 baseline JIT should attempt to convert division results to integers, and record when that fails
https://bugs.webkit.org/show_bug.cgi?id=74997
<rdar://problem/10612389>

Reviewed by Gavin Barraclough.

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_div):

23:36 Changeset [103391] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

Upstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74383

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-20
Reviewed by Daniel Bates.

Other Main Contributors:
Rob Buis <rbuis@rim.com>
Mike Fenton <mifenton@rim.com>

Initial upstream, no new tests.

  • PlatformBlackBerry.cmake: Modified to rename Localizations.cpp to LocalizedStringsBlackBerry.cpp
  • platform/blackberry/LocalizedStringsBlackBerry.cpp: Added.
  • platform/blackberry/PlatformMouseEventBlackBerry.cpp: Added.
22:01 Changeset [103390] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JavaScriptCore should be consistent about how it reads and writes ArgumentCount
https://bugs.webkit.org/show_bug.cgi?id=74989
<rdar://problem/10612006>

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):

21:51 Changeset [103389] by loislo@chromium.org
  • 22 edits in trunk/Source/WebCore

Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
https://bugs.webkit.org/show_bug.cgi?id=69366

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-20
Reviewed by Pavel Feldman.

Generator fixed and all usages are changed manually.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType):
(RawTypes.BaseType.get_output_argument_prefix):
(RawTypes.Object.get_output_argument_prefix):
(RawTypes.Array.get_output_argument_prefix):
(RawTypes):
(Generator.process_command):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
20:36 Changeset [103388] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] m_triggerIdlePaints not reset after a compositeAndReadback
https://bugs.webkit.org/show_bug.cgi?id=74974

Patch by Eric Penner <epenner@google.com> on 2011-12-20
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):

19:26 Changeset [103387] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Move misplaced assert in SQLiteStatement.cpp
https://bugs.webkit.org/show_bug.cgi?id=74975

Reviewed by Dmitry Titov.

The test is coming with bug 74666.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::step): If a database was interrupted
before the prepare method was called, then m_isPrepared will be
false, so I moved the assert to be after the check for interrupted.

18:37 Changeset [103386] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

WebVTT cues sometimes render when they should not
https://bugs.webkit.org/show_bug.cgi?id=74873

Not reviewed: update Chromium to pass new test added in r103371.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

18:33 Changeset [103385] by lforschler@apple.com
  • 14 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r99093.

18:29 Changeset [103384] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Value Profiles for arguments should be more easily accessible to the interpreter
https://bugs.webkit.org/show_bug.cgi?id=74984
<rdar://problem/10611364>

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setArgumentValueProfileSize):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::totalNumberOfValueProfiles):
(JSC::CodeBlock::getFromAllValueProfiles):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

18:02 Changeset [103383] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLOptionsCollection: Remove incorrect FIXME about having a base class.
<http://webkit.org/b/74973>

Reviewed by Alexey Proskuryakov.

HTMLOptionsCollection should indeed inherit from HTMLCollection according to
current HTML5, so remove the comment saying we should change that.

Spec: http://www.whatwg.org/specs/web-apps/current-work/#htmloptionscollection

  • html/HTMLOptionsCollection.idl:
17:57 Changeset [103382] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r93032.

17:52 Changeset [103381] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r92966.

17:50 Changeset [103380] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC shell should accept utf8 input.

Reviewed by Filip Pizlo.

  • jsc.cpp:

(jscSource):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):

17:49 Changeset [103379] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r92798.

17:46 Changeset [103378] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r92744.

17:41 Changeset [103377] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

td element ignores zero width/height input element
https://bugs.webkit.org/show_bug.cgi?id=74636

Patch by Florin Malita <fmalita@google.com> on 2011-12-20
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-zero-width.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):
Relax the attribute test to allow setting widths == 0.

LayoutTests:

  • fast/forms/input-zero-width-expected.html: Added.
  • fast/forms/input-zero-width.html: Added.
17:40 Changeset [103376] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r92630.

17:37 Changeset [103375] by lforschler@apple.com
  • 13 edits in branches/safari-534.54-branch/Source

Merged r92347.

17:33 Changeset [103374] by lforschler@apple.com
  • 5 edits
    7 copies in branches/safari-534.54-branch

Merged r92142.

17:32 Changeset [103373] by adamk@chromium.org
  • 16 edits in trunk/Source

Avoid unnecessary work when removing attributes from an element
https://bugs.webkit.org/show_bug.cgi?id=74953

Reviewed by Ryosuke Niwa.

Source/WebCore:

Various codepaths in Element and NamedNodeMap repeatedly search
through the list of attributes during a single operation. To avoid
this, I've added new getters to NamedNodeMap that return indices
rather than Attribute*s (they return WTF::notFound if no match is
found). These new methods are now used during removeAttribute
operations, as well as setAttribute and NamedNodeMap::setNamedItem
(along with a new replaceAttribute helper method).

The other optimization here involves the creation/destruction
of never-references Attr nodes. This is now avoided by calling
NamedNodeMap::removeAttribute directly instead of going through
NamedNodeMap::removeNamedItem.

As a cleanup after the above changes, the ExceptionCode argument is
gone from Element::removeAttribute and friends (it was never set
previously). The bulk of the files mentioned below are simply updating
callers to these methods.

No new tests, no change in behavior expected.

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::deleteItem):

  • dom/Element.cpp:

(WebCore::Element::removeAttribute):
(WebCore::Element::setBooleanAttribute):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::getAttributeItemIndexSlowCase):
(WebCore::NamedNodeMap::replaceAttribute):
(WebCore::NamedNodeMap::removeAttribute):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::removeAttribute):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setType):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::removeAttribute): Updated a caller of
WebCore::Element::removeAttribute to remove ExceptionCode argument.

17:24 Changeset [103372] by lforschler@apple.com
  • 4 edits
    4 copies in branches/safari-534.54-branch

Merged r91957.

17:14 Changeset [103371] by eric.carlson@apple.com
  • 3 edits
    3 adds in trunk

WebVTT cues sometimes render when they should not
https://bugs.webkit.org/show_bug.cgi?id=74873

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-nothing-to-render.html

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::updateTextTrackDisplay): Don't return early if the current

cue is empty so the previous cue is removed.

LayoutTests:

  • media/track/captions-webvtt/captions-gaps.vtt: Added.
  • media/track/track-cue-nothing-to-render-expected.txt: Added.
  • media/track/track-cue-nothing-to-render.html: Added.
17:09 Changeset [103370] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Don't crash on the second time VideoLayerChromium::createCCVideoLayer() is called
https://bugs.webkit.org/show_bug.cgi?id=74963

Patch by Ami Fischman <fischman@chromium.org> on 2011-12-20
Reviewed by James Robinson.

Manually tested by force-dropping the layer tree in CCLayerTreeHost::didBecomeInvisibleOnImplThread().
Crashed before the fix, doesn't crash after.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/VideoLayerChromium.h:
16:51 Changeset [103369] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r90980.

16:48 Changeset [103368] by lforschler@apple.com
  • 14 edits
    16 copies in branches/safari-534.54-branch

Merged r90164.

16:44 Changeset [103367] by lforschler@apple.com
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r89982.

16:39 Changeset [103366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

wouldTaintOrigin m_cleanURLs cache grows very large when data urls used
https://bugs.webkit.org/show_bug.cgi?id=74957

Patch by Scott Graham <scottmg@chromium.org> on 2011-12-20
Reviewed by Kenneth Russell.

No new tests, but memory usage of CanvasRenderingContext::m_cleanURLs
is reduced.

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

16:23 Changeset [103365] by commit-queue@webkit.org
  • 32 edits in trunk/Source/WebCore

Change adoptPtr(new ...) to ...::create in Page.cpp
https://bugs.webkit.org/show_bug.cgi?id=74457

Patch by Greg Billock <gbillock@google.com> on 2011-12-20
Reviewed by Darin Adler.

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::create):

  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::create):

  • dom/DeviceOrientationController.h:
  • editing/FrameSelection.cpp:

(WebCore::DragCaretController::create):

  • editing/FrameSelection.h:
  • history/BackForwardController.cpp:

(WebCore::BackForwardController::create):

  • history/BackForwardController.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::create):

  • inspector/InspectorController.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::create):

  • loader/ProgressTracker.h:
  • notifications/NotificationController.cpp:

(WebCore::NotificationController::create):

  • notifications/NotificationController.h:
  • page/Chrome.cpp:

(WebCore::Chrome::create):

  • page/Chrome.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::create):

  • page/ContextMenuController.h:
  • page/DragController.cpp:

(WebCore::DragController::create):

  • page/DragController.h:
  • page/FocusController.cpp:

(WebCore::FocusController::create):

  • page/FocusController.h:
  • page/GeolocationController.cpp:

(WebCore::GeolocationController::create):

  • page/GeolocationController.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::initGroup):
(WebCore::Page::speechInput):

  • page/PageGroup.cpp:

(WebCore::PageGroup::create):

  • page/PageGroup.h:
  • page/Settings.cpp:

(WebCore::Settings::create):

  • page/Settings.h:
  • page/SpeechInput.cpp:

(WebCore::SpeechInput::create):

  • page/SpeechInput.h:
16:10 Changeset [103364] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rubber Stamped by Sam Weinig

  • runtime/JSGlobalData.cpp:
    • removed some dead code.
16:04 Changeset [103363] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r103354.

  • platform/mac/ScrollAnimatorMac.mm:

(systemUptime):

15:58 Changeset [103362] by andersca@apple.com
  • 9 edits in trunk/Source

Add ScrollableArea::contentsResized and have it call the scroll animator
https://bugs.webkit.org/show_bug.cgi?id=74966

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::contentsResized):

  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::contentsResized):

  • platform/ScrollableArea.h:

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

15:55 Changeset [103361] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

requestAnimationFrame on Mac fires at 60fps even when drawing is much slower
https://bugs.webkit.org/show_bug.cgi?id=74964

Reviewed by Chris Marrin.

On Mac requestAnimationFrame uses a CVDisplayLink, sending notifications
from the display link thread to the main thread that the display link fired.
However, there was no throttling on these notifications; if processing an event
took a long time, notifications would pile up, and then get handled after
the slow event completed.

This would cause JS animations which animate by changing style to report
60fps when their display framerate was much lower.

Fix by throttling notifications from the display link thread to the web
thread; if the previous event hasn't completed yet, don't send any new ones.

No new tests, since testing this runtime behavior is hard.

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::refreshDisplayOnMainThread):
(WebCore::DisplayRefreshMonitor::notifyClients): Factored out of the
static refreshDisplayOnMainThread method so we can use 'this'.

  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

15:50 Changeset [103360] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/WebCore

Merged r88398.

15:46 Changeset [103359] by lforschler@apple.com
  • 8 edits in branches/safari-534.54-branch

Merged r88316.

15:46 Changeset [103358] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Coverity] Fix leak in V8HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=74943

Patch by Greg Billock <gbillock@google.com> on 2011-12-20
Reviewed by Adam Barth.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

15:39 Changeset [103357] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: rename field references from _fs to _filesystem
https://bugs.webkit.org/show_bug.cgi?id=74898

Reviewed by Adam Barth.

This is a simple cleanup; most of the code uses
self._filesystem, but some used self._fs; this change renames
the latter to the former to be more consistent.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.collect_tests):
(Manager._strip_test_dir_prefix):
(Manager._split_into_chunks_if_necessary):
(Manager.results_directory):
(Manager._clobber_old_results):
(Manager._upload_json_files):
(Manager.print_config):
(Manager._copy_results_html_file):
(Manager._show_results_html_file):
(Manager._log_worker_stack):

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator._normalize_results_json):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase.generate_json_output):
(JSONResultsGeneratorBase.generate_times_ms_file):
(JSONResultsGeneratorBase.upload_json_files):
(JSONResultsGeneratorBase._get_svn_revision):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):

15:30 Changeset [103356] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Tightened up Vector<T>::append
https://bugs.webkit.org/show_bug.cgi?id=74906

Reviewed by Sam Weinig.

Not a measurable speedup, but code inspection shows better code generated,
and I believe this is a step toward turning off -fomit-frame-pointer.

  • wtf/Vector.h:

(WTF::::append):
(WTF::::appendSlowCase): Split out the slow case into a separate function
to keep unnecessary instructions off the hot path. This means the hot
path can now be inlined more often.

Removed some old MSVC7 cruft. Hopefully, we don't need to hang on to a
compiler work-around from 2007.

15:28 Changeset [103355] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Windows build.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

15:13 Changeset [103354] by commit-queue@webkit.org
  • 13 edits
    1 copy
    4 deletes in trunk/Source/WebCore

Merge ScrollAnimatorChromiumMac.mm back to ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=61144

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-12-20
Reviewed by Beth Dakin.

At a high level the main changes are:

  • replace #ifdefs in ScrollAnimatorMac and ScrollbarThemeMac with run time checks
  • delete duplicate code in ScrollbarThemeChromiumMac. Keep the paint code since it does tickmarks and SKIA stuff.
  • delete ScrollAnimatorChromiumMac since ScrollAnimatorMac does the exact same thing
  • delete ScrollbarOverlayUtilitiesChromiumMac since NSScrollerImpDetails does the same thing

No new tests. Just refactoring.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Removed.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarPainterPaintTrack):
(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/NSScrollerImpDetails.h:

(WebCore::isScrollbarOverlayAPIAvailable):

  • platform/mac/NSScrollerImpDetails.mm: Added.

(WebCore::isScrollbarOverlayAPIAvailable):
(WebCore::recommendedScrollerStyle):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setIsCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

14:37 Changeset [103353] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

sizeof(RenderStyle) is 64 instead of 56 on Windows (x86)
https://bugs.webkit.org/show_bug.cgi?id=74876

Reviewed by Ryosuke Niwa.

Move bit fields into a new class and use unsigned for all types so we
align at 4 byte bounds. Also move the initializers into the header
file (has the side benefit of not needing to duplicate the initializers
in 3 places).

Enable the compile assert on Windows.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::affectedByUncommonAttributeSelectors):
(WebCore::RenderStyleBitfields::setAffectedByUncommonAttributeSelectors):
(WebCore::RenderStyleBitfields::unique):
(WebCore::RenderStyleBitfields::setUnique):
(WebCore::RenderStyleBitfields::affectedByEmpty):
(WebCore::RenderStyleBitfields::emptyState):
(WebCore::RenderStyleBitfields::setEmptyState):
(WebCore::RenderStyleBitfields::childrenAffectedByFirstChildRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByFirstChildRules):
(WebCore::RenderStyleBitfields::childrenAffectedByLastChildRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByLastChildRules):
(WebCore::RenderStyleBitfields::childrenAffectedByDirectAdjacentRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByDirectAdjacentRules):
(WebCore::RenderStyleBitfields::childrenAffectedByForwardPositionalRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByForwardPositionalRules):
(WebCore::RenderStyleBitfields::childrenAffectedByBackwardPositionalRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByBackwardPositionalRules):
(WebCore::RenderStyleBitfields::firstChildState):
(WebCore::RenderStyleBitfields::setFirstChildState):
(WebCore::RenderStyleBitfields::lastChildState):
(WebCore::RenderStyleBitfields::setLastChildState):
(WebCore::RenderStyleBitfields::childIndex):
(WebCore::RenderStyleBitfields::setChildIndex):
(WebCore::RenderStyleBitfields::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyleBitfields::hasExplicitlyInheritedProperties):

14:33 Changeset [103352] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
is consistently passing.

  • platform/chromium/test_expectations.txt:
14:17 Changeset [103351] by japhet@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Revert code for r96912 and r101905, since they cause
regressions in mac scrollbars, caret display in
form fields, etc.
https://bugs.webkit.org/show_bug.cgi?id=74939

Reviewed by Eric Seidel.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

14:13 Changeset [103350] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
svg/css/glyph-orientation-rounding-test.xhtml is consistently passing
on all platforms.

  • platform/chromium/test_expectations.txt:
14:05 Changeset [103349] by reed@google.com
  • 2 edits in trunk/Source/WebKit/chromium

enable USE_SKIA_TEXT by default, replacing GDI for all text drawing
https://bugs.webkit.org/show_bug.cgi?id=74928

Reviewed by Stephen White.

  • features.gypi:
13:45 Changeset [103348] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] enable WPO for WebCore libs in official builds
https://bugs.webkit.org/show_bug.cgi?id=74947

Reviewed by James Robinson.

Also move enable_wexit_time_destructors to the top level variables
so we don't have to add it to all targets.

  • WebCore.gyp/WebCore.gyp:
13:44 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
13:43 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
13:40 Changeset [103347] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Remove statusBarMessageChanged
https://bugs.webkit.org/show_bug.cgi?id=74405

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-20
Reviewed by Tor Arne Vestbø.

Removing support for window.status updates from the public
QML API. See bug for details.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/qt/QtWebPageUIClient.cpp:

(QtWebPageUIClient::QtWebPageUIClient):

  • UIProcess/qt/QtWebPageUIClient.h:
13:21 Changeset [103346] by andersca@apple.com
  • 11 edits in trunk/Source

Add ScrollableArea wrappers for a bunch of ScrollAnimator member functions
https://bugs.webkit.org/show_bug.cgi?id=74951

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

  • page/FrameView.cpp:

(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::mouseEnteredScrollbar):
(WebCore::ScrollableArea::mouseExitedScrollbar):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):

  • platform/ScrollableArea.h:
  • platform/ScrollableAreaClient.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseEntered):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paint):
(WebKit::BuiltInPDFView::handleMouseEvent):
(WebKit::BuiltInPDFView::handleMouseEnterEvent):
(WebKit::BuiltInPDFView::handleMouseLeaveEvent):

13:11 Changeset [103345] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

When <bdi> content is wrapped, all hell breaks loose
https://bugs.webkit.org/show_bug.cgi?id=74396

New test case by Aharon Lanin for multi-line bidi.

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-12-20
Reviewed by Ryosuke Niwa.

  • fast/text/international/bidi-neutral-wrapped.html: Added.
  • fast/text/international/bidi-neutral-wrapped-expected.html: Added.
13:06 Changeset [103344] by jarred@sencha.com
  • 3 edits
    5 adds in trunk

Perform case insensitive matching on MIME types in XHR
https://bugs.webkit.org/show_bug.cgi?id=74800

Source/WebCore:

Perform case insensitive matching on responseMIMEType() in didReceiveData().
Workaround case sensitive matching by DOMImplementation::isXMLMIMEType() in responseIsXML().

Reviewed by Darin Adler.

Tests: http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case.html

http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::responseIsXML):

LayoutTests:

New tests that verify mixed case MIME types are properly handled in XHR for

  • user provided types via overrideMimeType()
  • server-sent Content-Type headers

Reviewed by Darin Adler.

  • http/tests/xmlhttprequest/resources/xmlhttprequest-mimetype-mixed-case.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case-expected.txt: Added.
13:02 Changeset [103343] by adamk@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove no-op DOMAttr* event dispatch methods from Element
https://bugs.webkit.org/show_bug.cgi?id=74946

Reviewed by Darin Adler.

The removed methods had their bodies #if 0'd out, so this should have
no effect on anything.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):

12:45 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:43 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:42 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:41 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:40 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:34 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:33 Changeset [103342] by andersca@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

ScrollableArea should have an optional ScrollableAreaClient
https://bugs.webkit.org/show_bug.cgi?id=74949

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::scrollableAreaClient):
(WebCore::FrameView::FrameView):

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollableAreaClientForFrame):

  • page/ScrollingCoordinator.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):

  • platform/ScrollableArea.h:
  • platform/ScrollableAreaClient.h: Added.

(WebCore::ScrollableAreaClient::~ScrollableAreaClient):
(WebCore::ScrollableAreaClient::ScrollableAreaClient):

12:30 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:29 Changeset [103341] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix.

  • win/WebKit2CFLite.def: Add missing export declaration.
12:28 AdvantagesOfJenkinsOverBuildbot edited by aroben@apple.com
(diff)
12:26 AdvantagesOfJenkinsOverBuildbot created by aroben@apple.com
12:24 WikiStart edited by aroben@apple.com
(diff)
11:40 Changeset [103340] by adamk@chromium.org
  • 6 edits in trunk/Source/WebCore

Rename Element::setAttributeMap to parserSetAttributeMap and limit its use to the parser
https://bugs.webkit.org/show_bug.cgi?id=74885

Reviewed by Ryosuke Niwa.

Element::setAttributeMap is currently used by the parser in cases
where a NamedNodeMap of attributes has already been allocated and
transfers ownership to the Element. Other uses in WebCore don't have
this ownership-transfer requirement, and so are more clearly expressed
with normal setAttribute calls.

Eliminating non-parser callers allows the code to make safe
assumptions about the state of the Element it's called on: no need to
worry about, e.g., updating the id in the document's cache or
enqueueing mutation records.

No new tests, no change in behavior expected.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributeMap): Renamed, added assertions
to make sure it's not called unexpectedly, update comments.

  • dom/Element.h:
  • html/HTMLViewSourceDocument.cpp: Use setAttribute instead of setAttributeMap.

(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):

  • html/parser/HTMLConstructionSite.cpp: Reference new name.

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken): Use setAttribute instead of setAttributeMap.
Also get rid of an unnecessary String -> AtomicString conversion.

10:12 Changeset [103339] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused parameter from RenderLayerCompositor::rebuildCompositingLayerTree
https://bugs.webkit.org/show_bug.cgi?id=74936

Patch by Iain Merrick <husky@google.com> on 2011-12-20
Reviewed by Simon Fraser.

Pure refactoring, no change in functionality.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

  • rendering/RenderLayerCompositor.h:
09:40 Changeset [103338] by haraken@chromium.org
  • 4 edits
    1 move in trunk/Tools

Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
https://bugs.webkit.org/show_bug.cgi?id=74836

Reviewed by David Kilzer.

webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
for unit-testing of other Perl scripts. We are planning to use it for unit-testing
of prepare-ChangeLog.

Using LoadAsModule.pm, you can load a Perl script as follows.
The first argument is the arbitrary package name you want to use, and the second argument
is the name of the Perl script you want to load.

use LoadAsModule qw(RunLeaks run-leaks);
RunLeaks::someFunctionDefinedInRunLeaks(...);

Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl

Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl

  • Scripts/webkitperl/LoadAsModule.pm: Added.
  • Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.

(import):
(readFile):

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
09:31 Changeset [103337] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderStyle::InheritedFlags and RenderStyle::NonInheritedFlags members should be 4 byte aligned
https://bugs.webkit.org/show_bug.cgi?id=74880

Reviewed by Ryosuke Niwa.

Use unsigned for all types so we get 4 byte boundaries (unsigned char
means we try to align to 1 byte boundaries) and add setters and
getters for bool members.

Move some members around to make sure we're aligned to 4 byte boundaries.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::copyNonInheritedFrom):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::NonInheritedFlags::affectedByHover):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByHover):
(WebCore::InheritedFlags::NonInheritedFlags::affectedByActive):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByActive):
(WebCore::InheritedFlags::NonInheritedFlags::affectedByDrag):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByDrag):
(WebCore::InheritedFlags::NonInheritedFlags::isLink):
(WebCore::InheritedFlags::NonInheritedFlags::setIsLink):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::affectedByHoverRules):
(WebCore::InheritedFlags::affectedByActiveRules):
(WebCore::InheritedFlags::affectedByDragRules):
(WebCore::InheritedFlags::setAffectedByHoverRules):
(WebCore::InheritedFlags::setAffectedByActiveRules):
(WebCore::InheritedFlags::setAffectedByDragRules):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setIsLink):

09:26 Changeset [103336] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] 2 editing tests introduced in r103073 fails
https://bugs.webkit.org/show_bug.cgi?id=74937

Unreviewed gardening, skip failing tests.

  • platform/qt-wk2/Skipped:
09:23 Changeset [103335] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Assertion hit and crash with fast/multicol/pagination-* tests
https://bugs.webkit.org/show_bug.cgi?id=74511

Unreviewed gardening, skip failing tests.

  • platform/qt-wk2/Skipped:
09:21 UsingGitWithWebKit edited by aroben@apple.com
(diff)
09:09 Changeset [103334] by loislo@chromium.org
  • 2 edits in trunk

emacs: unreviewed. add settings for editing js files.

  • .dir-locals.el:
08:32 Changeset [103333] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r103325) - injected-script-for-origin.html crashing in Chromium Linux debug
https://bugs.webkit.org/show_bug.cgi?id=74934

Unreviewed test fix.

  • http/tests/inspector/injected-script-for-origin.html:
08:27 Changeset [103332] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

chromium: unreviewed. Clean out passing tests from test_expectations.txt.

  • platform/chromium/test_expectations.txt: plugins/form-value.html: was fixed at r103147. fast/images/move-image-to-new-document.html: was fixed somewhere between r102959 and r102965. media/media-controller-playback.html: rebaselined at r103285.
07:42 Changeset [103331] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Build fix for gcc used on WK2 build bot.

  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction): Don't do case:
with values outside the range of the type. Instead switch() on the int instead.

07:35 Changeset [103330] by hausmann@webkit.org
  • 9 edits in trunk/Source

[Qt] Extend QQuickWebview::navigationRequested API
https://bugs.webkit.org/show_bug.cgi?id=73818

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • declarative/experimental/plugin.cpp:

Source/WebKit2:

Added url of the originating frame on QWebNavigationRequest,
accessible via 'request.originatingUrl' on QML. Download action
was moved to experimental, so in order to use it you should set
'request.action = WebViewExperimental.DownloadRequest' on QML.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::originatingUrl):

  • UIProcess/API/qt/qwebnavigationrequest_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:

Tests were modified a bit to reuse urls and also added a test case to check
originating url once a request is done.

  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):

  • UIProcess/qt/QtWebPagePolicyClient.h:
07:21 Changeset [103329] by kbalazs@webkit.org
  • 7 edits in trunk

[Qt] WK2 Debugging quirks need some improvement
https://bugs.webkit.org/show_bug.cgi?id=74859

Reviewed by Simon Hausmann.

Improvements added to make debugging WebKit2 more
confortable and efficient:

  1. Unify debugging quirks. From now all of them are controlled

by the QT_WEBKIT2_DEBUG environment variable.

  1. Disable crash handlers for WebKitTestRunner if debugging quirks

are used to make it possible to use postmortem debugging via core dumps
which is extremely useful for debugging bugs triggered by layout tests.

  1. Disable test timeout for WebKitTestRunner if debugging quirks

are used because that makes debugging impossible.

Source/WebKit2:

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::QtWebProcess::setupChildProcess):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

Tools:

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformRunUntil):

07:07 Changeset [103328] by loislo@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] Rebaseline fast/js/mozilla/strict/15.4.5.1.html
https://bugs.webkit.org/show_bug.cgi?id=74918

Unreviewed expectation fix.

Patch by Michael Starzinger <mstarzinger@chromium.org> on 2011-12-20

  • platform/chromium/fast/js/mozilla/strict/15.4.5.1-expected.txt: Added.
  • platform/chromium/test_
06:08 Changeset [103327] by jchaffraix@webkit.org
  • 3 edits
    6 adds in trunk

Regression(99212): table rows get incorrect height after changing some cells' height
https://bugs.webkit.org/show_bug.cgi?id=74303

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/resize-table-binding-cell.html

fast/table/resize-table-cell.html
fast/table/resize-table-row.html

r99212 wrongly implemented the row's logicalHeight recalculation.
The original code would use recalcCells which would properly recalculate a
row logicalHeight by iterating over the table's cells but throwing out the
existing result.

Our approach is just to recompute our row's logicalHeight and leave the
rest of the section untouched.

  • rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell):
Added this new helper function to update the RowStruct logicalHeight during
|addCell| and |rowLogicalHeightChanged|.

(WebCore::RenderTableSection::addCell):
Replaced the old code with a call to updateLogicalHeightForCell.
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Added a call to updateLogicalHeightForCell for each cells.

LayoutTests:

Added some tests that resize a cell or a row and check that we properly recompute the height.

  • fast/table/resize-table-binding-cell-expected.txt: Added.
  • fast/table/resize-table-binding-cell.html: Added.
  • fast/table/resize-table-cell-expected.txt: Added.
  • fast/table/resize-table-cell.html: Added.
  • fast/table/resize-table-row-expected.txt: Added.
  • fast/table/resize-table-row.html: Added.
06:04 Changeset [103326] by loislo@chromium.org
  • 22 edits in trunk/Source/WebCore

Unreviewed, rolling out r103322.
http://trac.webkit.org/changeset/103322
https://bugs.webkit.org/show_bug.cgi?id=74927

seven inspector's tests are crashing on qt (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-20

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType.is_event_param_check_optional):
(RawTypes.Object.is_event_param_check_optional):
(RawTypes.Array.is_event_param_check_optional):
(RawTypes):
(Generator.process_command):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
05:42 Changeset [103325] by caseq@chromium.org
  • 10 edits
    3 adds
    1 delete in trunk

Web Inspector: [Extensions API] allow setting extension API per extension security origin
https://bugs.webkit.org/show_bug.cgi?id=74868

Reviewed by Pavel Feldman.

This replaces InspectorExtensionAPI string within InspectorFrontendHost with a map by extension
security origin, so that we can have APIs customized by extension (in particular, this is needed
to expose experimental APIs only to certain extensions).

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setInjectedScriptForOrigin):

  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setInjectedScriptForOrigin):

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setInjectedScriptForOrigin):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):

05:36 Changeset [103324] by jesus@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]REGRESSION(r103310): It broke tst_QQuickWebView::loadNonexistentFileUrl() API test
https://bugs.webkit.org/show_bug.cgi?id=74923

Rubber-stamped by Csaba Osztrogonác.

Fixing API usage after http://trac.webkit.org/changeset/103310.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadNonexistentFileUrl):

05:31 Changeset [103323] by hausmann@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt] Favicon support should work with multiple web contexts
https://bugs.webkit.org/show_bug.cgi?id=74922

Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize): Remove unnecessary use of QtWebContext::defaultContext(). There is
already a member variable "context" which is the correct one.
(QQuickWebViewPrivate::setIcon): Ditto.

  • UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::requestImage): Extract the context id from the image id and use it to
query the correct icon database.

  • UIProcess/qt/QtWebContext.cpp: Provide a mapping from id to qtwebcontext.

(WebKit::generateContextID):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::contextByID):
(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:

(WebKit::QtWebContext::context):
(WebKit::QtWebContext::contextID):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::requestIconForPageURL): Store the context id in the icon url.

  • UIProcess/qt/QtWebIconDatabaseClient.h:
05:20 Changeset [103322] by loislo@chromium.org
  • 22 edits in trunk/Source/WebCore

Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
https://bugs.webkit.org/show_bug.cgi?id=69366

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-20
Reviewed by Pavel Feldman.

Generator fixed and all usages are changed manually.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType.is_event_param_check_optional):
(RawTypes.BaseType):
(RawTypes.BaseType.get_output_argument_prefix):
(RawTypes.Object.get_output_argument_prefix):
(RawTypes.Array.get_output_argument_prefix):
(RawTypes):
(Generator.process_command):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
05:17 Changeset [103321] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Change default WebSocket protocol to the latest one
https://bugs.webkit.org/show_bug.cgi?id=74064

Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
Use hybi WebSocket protocol by default.

04:56 Changeset [103320] by jarred@sencha.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] HTTP header injection via QWebPage::userAgentForUrl()
https://bugs.webkit.org/show_bug.cgi?id=68560

Strip out newline characters from the result of userAgentForUrl() to prevent additional
HTTP headers in HTTP requests.

New QtTest case that validates the user agent, as returned by navigator.userAgent, does not
contain any newline characters.

Reviewed by Simon Hausmann.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::userAgent):

  • tests/qwebpage/tst_qwebpage.cpp:

(CustomUserAgentWebPage::userAgentForUrl):
(tst_QWebPage::userAgentNewlineStripping):

04:49 Changeset [103319] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip failing and crashing tests to try to paint the bot green.
04:40 Changeset [103318] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

Crash in RenderTable::outerBorderAfter
http://webkit.org/b/74026
<rdar://problem/10552313>

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/table/computeLogicalWidth-table-needsSectionRecalc.html

RenderBlock can call computeLogicalWidth() before calling layout(). The code in
RenderTable::computeLogicalWidth would make the assumption that layout() was called
as layout() is responsible for recomputing our sections.

To prevent the issue, let's just recompute the section if it's needed as this situation
shouldn't be an error. Also adding more knowledge of table in RenderBlock seems bad.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Make sure we recalculate our section if it's needed.

LayoutTests:

  • fast/table/computeLogicalWidth-table-needsSectionRecalc-expected.txt: Added.
  • fast/table/computeLogicalWidth-table-needsSectionRecalc.html: Added.
03:53 Changeset [103317] by jchaffraix@webkit.org
  • 7 edits in branches/chromium/963

Revert 99212 - Stop abusing RenderTableSection::needsRecalcCells logic
https://bugs.webkit.org/show_bug.cgi?id=71420

Reviewed by Darin Adler.

Source/WebCore:

Change covered by existing tests like fast/repaint/table-extra-bottom-grow.html
and fast/table/row-height-recalc* (among others).

Cell recalculation is very expensive and should only be called when the section's structure
changed in a way that requires a safe update to its structure (like removing a row as our
column split may not be appropriate anymore).

The current code would abuse cell recalculation to actually reset the logical height on the
RowStruct. This change makes it do the right thing.

  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.h:

Removed styleWillChange override as it was unneeded.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
Move the code from styleWillChange to styleDidChange.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::rowLogicalHeightChanged):
This function just reset the height on the |RowStruct| which is the
only part of recalcCells that we would need.

(WebCore::RenderTableSection::rowIndexForRenderer):
Added this function to find out which index a column has (strangely
RenderTableRow does not have this information).

  • rendering/RenderTableSection.h: Added the 2 previous functions.

LayoutTests:

  • platform/chromium-linux/fast/repaint/table-extra-bottom-grow-expected.png:

Update this test as this is a progression: we are not over-repainting the table
anymore.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/test_expectations.txt:

Skipped the test here as it needs a rebaseline.

TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/8989014

03:52 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt versions on the bots (diff)
03:49 Changeset [103316] by hausmann@webkit.org
  • 18 edits
    5 adds in trunk

[Qt][WK2] Implement favicon support
https://bugs.webkit.org/show_bug.cgi?id=71082

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

.:

  • Source/qtwebkit-export.map: Added new classes.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::initializeEngine): Setup for the QDeclarativeImageProvider to display favicons.
Its handles the following url format: "image://webicon/<iconID>#<pageURL>".

Source/WebKit2:

Added attribute to QQuickWebView named "icon" that should be used
as source for QQuickImage in order to display it. All images
pointing to it will refresh when the icon is ready. We also use IDs
to make it possible to handle different icons for the same page URL
at different times (i.e. dynamically changing favicon).

IconDatabase storage lies on UIProcess and the synchronous call for
the icon that happens on WebIconDatabase won't need to send any message
to WebProcess. The part of IconDatabase on WebProcess handles the download
of the resource whenever it is needed. Then the content downloaded is sent
through IPC to the actual database, on UIProcess.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onIconChangedForPageURL):
(QQuickWebViewPrivate::setIcon):
(QQuickWebView::icon):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebiconimageprovider.cpp: Added.

(QWebIconImageProvider::QWebIconImageProvider):
(QWebIconImageProvider::~QWebIconImageProvider):
(QWebIconImageProvider::requestImage):

  • UIProcess/API/qt/qwebiconimageprovider_p.h: Added.
  • UIProcess/WebContext.h:
  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::synchronousIconURLForPageURL):
(WebKit::WebIconDatabase::imageForPageURL): Added iconSize parameter
and a default value for it to not break the old usage. The support for
multiple sizes of favicons is still missing on WebCore.

  • UIProcess/WebIconDatabase.h:
  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:

(WebKit::QtWebContext::iconDatabase):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp: Added.

(toQtWebIconDatabaseClient):
(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::~QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::didChangeIconForPageURL):
(QtWebIconDatabaseClient::iconImageForPageURL):
(QtWebIconDatabaseClient::iconURLHashForPageURL):
(QtWebIconDatabaseClient::requestIconForPageURL):
(QtWebIconDatabaseClient::retainIconForPageURL):
(QtWebIconDatabaseClient::releaseIconForPageURL):

  • UIProcess/qt/QtWebIconDatabaseClient.h: Added.
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didStartProgress):

Tools:

A favorite icon was added on MiniBrowser's url bar as example.
We display a default icon when the page doesn't have an icon ready.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/icons/favicon.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
03:48 clutter edited by kov@webkit.org
(diff)
03:44 Changeset [103315] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[Refactoring] Replace imp with impl in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=74901

Reviewed by Adam Barth.

As pointed out in bug 74837, the generated code by CodeGeneratorJS.pm includes
both 'imp' and 'impl'. This patch unifies them into 'impl'.
I confirmed that "perl -lne 'print if /imp[a-z]/' CodeGeneratorJS.pm" outputs nothing.

No new tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeEventListenerCall):
(GenerateEventListenerCall):
(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceStr1):
(WebCore::jsTestInterfaceStr2):
(WebCore::jsTestInterfaceStr3):
(WebCore::setJSTestInterfaceStr2):
(WebCore::setJSTestInterfaceStr3):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedNonEmptyURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjReflectedCustomNonEmptyURLAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjScriptStringAttr):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedNonEmptyURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjReflectedCustomNonEmptyURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjId):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfaceValue):

02:02 Changeset [103314] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebKit

Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
https://bugs.webkit.org/show_bug.cgi?id=74255

Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2011-12-20
Reviewed by Yury Semikhatsky.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::releaseFrontend):

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::bringFrontendToFront):
(-[WebInspectorWindowController destroyInspectorView:]):

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::~WebInspectorClient):
(WebInspectorFrontendClient::destroyInspectorView):

  • WebCoreSupport/WebInspectorClient.h:
01:45 Changeset [103313] by vsevik@chromium.org
  • 1 copy in branches/chromium/963/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt

Merge 102930 - Unreviewed chromium test rebaseline.

  • platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt: Added.

TBR=vsevik@chromium.org
BUG=106164
Review URL: http://codereview.chromium.org/9006005

01:45 Changeset [103312] by vsevik@chromium.org
  • 2 edits
    3 copies in branches/chromium/963

Merge 102898 - Web Inspector: [Regression] Network manager fails to show resource type and MIME type in incorrect MIME type console message.
https://bugs.webkit.org/show_bug.cgi?id=74516

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/script-as-text-loading.html

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

LayoutTests:

  • http/tests/inspector/network/resources/script-as-text.php: Added.
  • http/tests/inspector/network/script-as-text-loading-expected.txt: Added.
  • http/tests/inspector/network/script-as-text-loading.html: Added.

TBR=vsevik@chromium.org
BUG=106164
Review URL: http://codereview.chromium.org/9008007

01:41 Changeset [103311] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Make WebIntentServiceInfo constructor public for testing.
https://bugs.webkit.org/show_bug.cgi?id=74764

Patch by Greg Billock <gbillock@google.com> on 2011-12-20
Reviewed by Darin Fisher.

  • public/WebIntentServiceInfo.h:
00:56 Changeset [103310] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Improve QQuickWebView error handling API
https://bugs.webkit.org/show_bug.cgi?id=73815

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

Modifying loadFail signal to include the error description
and changing the ErrorType enum to ErrorDomain, to stay aligned
with ResourceError API itself.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::dispatchLoadFailed):

00:39 Changeset [103309] by alokp@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] compositing/shadows tests fail with accelerated painting
https://bugs.webkit.org/show_bug.cgi?id=74871

Reviewed by James Robinson.

Switched over to new API for creating accelerated canvas GrContext::createPlatformTexture.
It correctly binds the stencil buffer to the FBO.

Test: compositing/shadows/shadow-drawing.html (existing)

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::allocate):
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

  • platform/graphics/chromium/ManagedTexture.h:
00:00 Changeset [103308] by loislo@chromium.org
  • 13 edits
    1 copy
    3 adds
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r103291.
http://trac.webkit.org/changeset/103291
https://bugs.webkit.org/show_bug.cgi?id=74915

Looks like it broke fast/events/touch and
fast/events/touch/gesture/gesture-scroll.html
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/7010
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-20

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Copied from Source/WebCore/platform/mac/ScrollAnimatorMac.h.

(WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
(WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
(WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
(WebCore::ScrollAnimatorChromiumMac::setNeedsScrollerStyleUpdate):
(WebCore::ScrollAnimatorChromiumMac::needsScrollerStyleUpdate):

  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added.

(-[NSProcessInfo systemUptime]):
(abs):
(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate cancelAnimations]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimator::create):
(WebCore::chromiumScrollbarTheme):
(WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
(WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
(WebCore::ScrollAnimatorChromiumMac::scroll):
(WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPointForScrollAnimation):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
(WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
(WebCore::ScrollAnimatorChromiumMac::contentsResized):
(WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
(WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
(WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
(WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
(WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
(WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorChromiumMac::setIsActive):
(WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):
(WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
(WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
(WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Added.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Added.

(lookUpNSScrollerImpClass):
(lookUpNSScrollerImpPairClass):
(scrollbarControlSizeToNSControlSize):
(preferredScrollerStyle):
(wkScrollbarPainterUsesOverlayScrollers):
(wkScrollbarPainterIsHorizontal):
(wkScrollbarPainterKnobAlpha):
(wkScrollbarPainterSetOverlayState):
(wkScrollbarPainterPaint):
(wkScrollbarPainterPaintTrack):
(wkScrollbarPainterPaintKnob):
(wkScrollbarMinimumThumbLength):
(wkScrollbarPainterSetDelegate):
(wkScrollbarPainterSetEnabled):
(wkScrollbarPainterTrackAlpha):
(wkMakeScrollbarPainter):
(wkScrollbarThickness):
(wkScrollbarMinimumTotalLengthNeededForThumb):
(wkVerticalScrollbarPainterForController):
(wkHorizontalScrollbarPainterForController):
(wkScrollbarPainterControllerStyle):
(wkMakeScrollbarReplacementPainter):
(wkSetPainterForPainterController):
(wkSetScrollbarPainterControllerStyle):
(wkScrollbarPainterKnobRect):
(wkSetScrollbarPainterKnobAlpha):
(wkSetScrollbarPainterTrackAlpha):
(wkSetScrollbarPainterKnobStyle):
(wkMakeScrollbarPainterController):
(wkContentAreaScrolled):
(wkContentAreaWillPaint):
(wkMouseEnteredContentArea):
(wkMouseExitedContentArea):
(wkMouseMovedInContentArea):
(wkWillStartLiveResize):
(wkContentAreaResized):
(wkWillEndLiveResize):
(wkContentAreaDidShow):
(wkContentAreaDidHide):
(wkDidBeginScrollGesture):
(wkDidEndScrollGesture):
(wkScrollbarPainterForceFlashScrollers):
(isScrollbarOverlayAPIAvailable):

  • platform/chromium/ScrollbarThemeChromiumMac.h:

(WebCore::ScrollbarThemeChromiumMac::supportsControlTints):
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
(+[ScrollbarPrefsObserver registerAsObserver]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::preferencesChanged):
(WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::initialAutoscrollTimerDelay):
(WebCore::ScrollbarThemeChromiumMac::autoscrollTimerDelay):
(WebCore::ScrollbarThemeChromiumMac::buttonsPlacement):
(WebCore::ScrollbarThemeChromiumMac::hasButtons):
(WebCore::ScrollbarThemeChromiumMac::hasThumb):
(WebCore::buttonRepaintRect):
(WebCore::ScrollbarThemeChromiumMac::backButtonRect):
(WebCore::ScrollbarThemeChromiumMac::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumMac::trackRect):
(WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
(WebCore::ScrollbarThemeChromiumMac::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
(WebCore::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/NSScrollerImpDetails.mm: Removed.
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):

12/19/11:

23:49 Changeset [103307] by adamk@chromium.org
  • 7 edits in trunk/Source/WebCore

Make all calls to NamedNodeMap::setAttributes go through Element
https://bugs.webkit.org/show_bug.cgi?id=74895

Reviewed by Ryosuke Niwa.

There are two reasons for this change. One is an optimization: some
callers were previously always creating a NamedNodeMap even if the
source didn't have any attributes.

The other reason is forward-looking: setAttributes' behavior is subtly
wrong in the presence of MutationObservers. This doesn't matter
for most callers since the element on which setAttributesFromElement
is called is newly-created. In the editing case, however, it could
make a difference in behavior, which I hope to fix in a future change
without sacrificing the performance of cloneNode() on an Element
(which is what NamedNodeMap::setAttributes is designed for).

No new tests, no change in behavior.

  • dom/Element.cpp:

(WebCore::Element::cloneElementWithoutChildren): Call setAttributesFromElement.

  • dom/Element.h:

(WebCore::Element::setAttributesFromElement): Create new inline helper method
which conditionally forwards to NamedNodeMap::setAttribute.

  • dom/NamedNodeMap.h: Make setAttributes private (Element is already a friend).
  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren): Call setAttributesFromElement.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeName): Call setAttributesFromElement.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Call setAttributesFromElement.
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement): Call setAttributesFromElement
and make use of ASSERT_NO_EXCEPTION to make code easier to read.

23:31 Changeset [103306] by yuqiang.xian@intel.com
  • 4 edits in trunk/Source/JavaScriptCore

Temporary GPR should not be lazily allocated in DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=74908

Reviewed by Filip Pizlo.

On X86, we used to allocate a temporary GPR lazily when it's really
used rather than defined. This may cause potential issues of
allocating registers inside control flow and result in problems in
subsequent code generation, for example the DFG JIT may think an
operand already being spilled (to satisfy the allocation request) and
generate code to read the data from memory, but the allocation and
spilling are in a branch which is not taken at runtime, so the
generated code is incorrect.

Although current DFG JIT code doesn't have this problematic pattern,
it's better to cut-off the root to avoid any potential issues in the
future.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::GPRTemporary::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

22:22 Changeset [103305] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to ResourceRequestBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=74910

Reviewed by Daniel Bates.

No functionality change to the existing code, no new tests.

  • platform/network/ResourceRequestBase.cpp: The BlackBerry porting has its own

initializeMaximumHTTPConnectionCountPerHost(). Exclude the default implementation.

21:43 Changeset [103304] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to NetworkStateNotifier.h
https://bugs.webkit.org/show_bug.cgi?id=74904

Reviewed by Daniel Bates.

No functionality change to existing code, no new tests.

  • platform/network/NetworkStateNotifier.h:
21:26 Changeset [103303] by yael.aharon@nokia.com
  • 7 edits in trunk

Update dropzone implementation per spec update
https://bugs.webkit.org/show_bug.cgi?id=74834

Reviewed by Tony Chang.

Source/WebCore:

Update support for dropzone attribute to use file: and string: instead of f: and s:.
http://www.whatwg.org/specs/web-apps/current-work/#the-dropzone-attribute

No new tests. Existing tests cover this and were updated.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasDropZoneType):

LayoutTests:

Update the tests per spec change.

  • fast/events/dropzone-001.html:
  • fast/events/dropzone-002.html:
  • fast/events/dropzone-003.html:
  • fast/events/dropzone-004.html:
21:10 Changeset [103302] by weinig@apple.com
  • 6 edits
    2 adds in trunk

Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
https://bugs.webkit.org/show_bug.cgi?id=74907

Reviewed by Dan Bernstein.

Source/WebCore:

Added API test: WebKit2.ScrollByLineCommands

  • editing/EditorCommand.cpp:

(WebCore::executeScrollLineUp):
(WebCore::executeScrollLineDown):
(WebCore::createCommandMap):
Add implementations for scrollLineUp/Down. Do not expose
these to execCommand.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

Add implementations for scrollLineDown: and scrollLineUp: using our
fun macros.

Tools:

Add ScrollByLineCommands API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
  • TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
21:01 Changeset [103301] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[QT] WebGL can not make the frame buffer with the stencil buffer.
https://bugs.webkit.org/show_bug.cgi?id=74783

When initializing a framebuffer in OpenGL ES 2, we need to initialize the depth
and stencil buffers separately, as opposed to the combined depth-stencil buffer
we initialize for desktop GL.

This makes fast/canvas/webgl/context-attributes-depth-stencil-combination.html
work in OpenGL ES 2.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-12-19
Reviewed by Noam Rosenthal.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::reshape):

20:34 Changeset [103300] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Compile fix for chromium on windows due to collision of testing::NotNull from gtest and NotNull from Vector.h

  • tests/WebLayerTest.cpp:
20:33 Changeset [103299] by yuqiang.xian@intel.com
  • 4 edits in trunk/Source/JavaScriptCore

Remove unused code for non-speculative Arith operations from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=74905

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
20:27 Changeset [103298] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Source/WebCore: Teach VideoLayerChromium how to render native texture (to support HW video decode).
https://bugs.webkit.org/show_bug.cgi?id=73043

Patch by Ami Fischman <fischman@chromium.org> on 2011-12-19
Reviewed by James Robinson.

Fix the life-cycle of video frames handled by VideoLayerChromium/CCVideoLayerImpl.
VideoFrameProvider::{get,put}CurrentFrame provide lease semantics. Previously
VideoLayerChromium would acquire the lease for the duration of copying the frame,
even if that was only a texture ID, and immediately return the lease, while
CCVideoLayerImpl::draw() would come along later and use the (no-longer locked)
texture optimistically. This change makes it so that CCVideoLayerImpl holds
the frame's lease for the duration of draw(), guaranteeing the frame is valid to read.

Existing test coverage (compositing/video/, LayoutTests). HW render of
HW-decoded textures is not yet tested explicitly.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::createCCLayerImpl):
(WebCore::VideoLayerChromium::releaseProvider):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::setProvider):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::copyFrameToTextures):
(WebCore::CCVideoLayerImpl::copyPlaneToTexture):
(WebCore::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawCommon):
(WebCore::CCVideoLayerImpl::drawRGBA):
(WebCore::CCVideoLayerImpl::drawNativeTexture):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium: Teach VideoLayerChromium how to render native texture (to support HW video decode).
https://bugs.webkit.org/show_bug.cgi?id=73043

Patch by Ami Fischman <fischman@chromium.org> on 2011-12-19
Reviewed by James Robinson.

Fix the life-cycle of video frames handled by VideoLayerChromium/CCVideoLayerImpl.
VideoFrameProvider::{get,put}CurrentFrame provide lease semantics. Previously
VideoLayerChromium would acquire the lease for the duration of copying the frame,
even if that was only a texture ID, and immediately return the lease, while
CCVideoLayerImpl::draw() would come along later and use the (no-longer locked)
texture optimistically. This change makes it so that CCVideoLayerImpl holds
the frame's lease for the duration of draw(), guaranteeing the frame is valid to read.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):

20:08 Changeset [103297] by weinig@apple.com
  • 29 edits in trunk/Source

More PlatformEvent cleanup
https://bugs.webkit.org/show_bug.cgi?id=74831

Reviewed by Dan Bernstein.

../WebCore:

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::position):
Rename pos -> position(). Remove x() and y() accessors.

(WebCore::PlatformMouseEvent::globalPosition):
Added. Replaces globalX() and globalY() accessors.

(WebCore::PlatformMouseEvent::movementDelta):
Added. Replaces movementX() and movementY() accessors.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::position):
Renamed pos -> position().

(WebCore::PlatformWheelEvent::globalPosition):
Renamed globalPos -> globalPosition().

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):

  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::prepareMouseEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passMousePressEventToSubframe):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseDown):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::hitTest):

  • platform/chromium/PopupContainer.cpp:

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):

  • platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):

  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarThemeQt::hitTest):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):
Update to use new names, access style.

../WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseContextMenu):
Update to use new names, access style.

../WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_forward_context_menu_event):
(webkit_web_view_get_hit_test_result):
Update to use new names, access style.

../WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):
Update to use new names, access style.

../WebKit/win:

  • WebView.cpp:

(WebView::handleMouseEvent):
Update to use new names, access style.

../WebKit/wince:

  • WebView.cpp:

(WebView::handleMouseEvent):
Update to use new names, access style.

../WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
Update to use new names, access style.

19:42 Changeset [103296] by adamk@chromium.org
  • 12 edits in trunk/Source/WebCore

Remove unused ExceptionCode& argument from Element::setAttribute(QualifiedName)
https://bugs.webkit.org/show_bug.cgi?id=74740

Reviewed by Ryosuke Niwa.

Updated lots of callers to remove third argument. The list of changes
below only lists things other than updating callers.

  • dom/Document.cpp:

(WebCore::Document::importNode):

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeNS):
(WebCore::Element::setIntegralAttribute):
(WebCore::Element::setUnsignedIntegralAttribute):

  • dom/Element.h: Removed third arg from method, removed old two-arg

overload which now has an identical signature.

  • editing/mac/EditorMac.mm: Updated caller and used

ASSERT_NO_EXCEPTION for nearby code.
(WebCore::styleForSelectionStart):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

  • svg/SVGElement.idl: Removed 'setter raises(DOMException)'
  • svg/SVGGlyphRefElement.idl: ditto.
  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::setType):
(WebCore::SVGStyleElement::setMedia):
(WebCore::SVGStyleElement::setTitle):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processAttributes):

19:36 Changeset [103295] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.h:

(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayConstructor::create):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::create):
(WebCore::JSTestEventConstructorPrototype::create):
(WebCore::JSTestEventConstructorConstructor::create):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):
(WebCore::JSTestInterfaceConstructor::create):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):
(WebCore::JSTestMediaQueryListListenerConstructor::create):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::create):
(WebCore::JSTestNamedConstructorPrototype::create):
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::create):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):
(WebCore::JSTestObjConstructor::create):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):

19:16 Changeset [103294] by barraclough@apple.com
  • 9 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=74903
Exceptions not thrown correctly from DFG JIT on 32bit

Reviewed by Oliver Hunt.

Arguments for lookupExceptionHandler are not setup correctly.
In the case of ARMv7 we rely on lr being preserved over a call,
this in invalid. On x86 we don't should be poking the arguments onto the stack!

Source/JavaScriptCore:

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):

  • dfg/DFGGPRInfo.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:

LayoutTests:

  • fast/js/dfg-exception-expected.txt: Added.
  • fast/js/dfg-exception.html: Added.
  • fast/js/script-tests/dfg-exception.js: Added.

(doesntDFGCompile):
(test):

18:54 Changeset [103293] by jamesr@google.com
  • 28 edits
    2 moves
    2 adds in trunk/Source

[chromium] CCLayerDelegate and WebLayerClient do not need notifySyncRequired
https://bugs.webkit.org/show_bug.cgi?id=74376

Reviewed by Kenneth Russell.

Source/WebCore:

CCLayerDelegate::notifySyncRequired is an odd bit of interface that we originally cargo-culted from the
CoreAnimation compositor implementation. It is a mechanism by which a LayerChromium instance may request a new
frame via its CCLayerDelegate, which in WebCore is always a GraphicsLayerClient. In practice, all
implementations eventually ended up routing to CCLayerTreeHost::setNeedsCommit which then made the proper
scheduling decision.

This patch routes all changes that would have gone through CCLayerDelegate::notifySyncRequired directly to
CCLayerTreeHost::setNeedsCommit, which greatly simplifies the scheduling logic.

There is a large amount of unit test coverage for this change, largely in LayerChromiumTest

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::insertChild):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::setRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCScopedThreadProxy.h:

(WebCore::CCScopedThreadProxy::runTaskIfNotShutdown):

Source/WebKit/chromium:

WebLayerClient::notifyNeedsComposite() is an odd interface for the same reason that
CCLayerDelegate::notifySyncRequired() is - all scheduling decisions should route through the WebLayerTreeView,
not individual layers. In practice, all implementations of WebLayerClient::notifySyncRequired() do the exact
same thing as WebLayerTreeView::scheduleComposite(). This removes that callback, making WebLayerClient an empty
interface, and routes all calls that would go to that interface to WebLayerTreeView::scheduleComposite().

Once downstream implementations of WebLayerClient are removed, WebLayerClient.h and the constructors associated
with it can be deleted.

The bulk of the changes here are to the test harness. Many tests that were designed around notifySyncRequired()
are rewritten to check for CCLayerTreeHost::setNeedsCommit() or WebLayerTreeView::scheduleComposite() instead.
In a few instances, this required changing the setup logic around somewhat so that the layers being manipulated
were in a tree that initialized without errors.

  • WebKit.gypi:
  • public/platform/WebContentLayer.h:
  • public/platform/WebExternalTextureLayer.h:
  • public/platform/WebLayer.h:
  • public/platform/WebLayerClient.h:
  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::create):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):

  • src/WebContentLayerImpl.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::create):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):

  • src/WebExternalTextureLayerImpl.h:
  • src/WebLayer.cpp:

(WebKit::WebLayer::create):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):

  • src/WebLayerImpl.h:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):

  • src/WebLayerTreeViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::CCLayerTreeHostTestScrollSimple::animateAndLayout):

  • tests/CompositorMockGraphicsContext3D.h: Added.

(WebCore::createCompositorMockGraphicsContext3D):

  • tests/CompositorMockWebGraphicsContext3D.h: Added.

(WebKit::CompositorMockWebGraphicsContext3D::create):
(WebKit::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WebKit::CompositorMockWebGraphicsContext3D::createProgram):
(WebKit::CompositorMockWebGraphicsContext3D::createShader):
(WebKit::CompositorMockWebGraphicsContext3D::getShaderiv):
(WebKit::CompositorMockWebGraphicsContext3D::getProgramiv):
(WebKit::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):

  • tests/LayerChromiumTest.cpp:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::getContextAttributes):

  • tests/WebGLLayerChromiumTest.cpp:

(WebKit::TEST):

  • tests/WebLayerTest.cpp:

(testing::MockWebLayerTreeViewClient::animateAndLayout):
(testing::MockWebLayerTreeViewClient::applyScrollAndScale):
(testing::MockWebLayerTreeViewClient::createContext3D):
(testing::MockWebLayerTreeViewClient::didRebindGraphicsContext):
(testing::WebLayerTest::SetUp):
(testing::WebLayerTest::TearDown):
(testing::TEST_F):

18:42 Changeset [103292] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

If we detect that we can use the JIT, don't use computed opcode lookups
https://bugs.webkit.org/show_bug.cgi?id=74899
<rdar://problem/10604551>

Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

18:01 Changeset [103291] by commit-queue@webkit.org
  • 13 edits
    1 copy
    4 deletes in trunk/Source/WebCore

Merge ScrollAnimatorChromiumMac.mm back to ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=61144

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-12-19
Reviewed by Beth Dakin.

At a high level the main changes are:

  • replace #ifdefs in ScrollAnimatorMac and ScrollbarThemeMac with run time checks
  • delete duplicate code in ScrollbarThemeChromiumMac. Keep the paint code since it does tickmarks and SKIA stuff.
  • delete ScrollAnimatorChromiumMac since ScrollAnimatorMac does the exact same thing
  • delete ScrollbarOverlayUtilitiesChromiumMac since NSScrollerImpDetails does the same thing

No new tests. Just refactoring.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Removed.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarPainterPaintTrack):
(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/NSScrollerImpDetails.h:

(WebCore::isScrollbarOverlayAPIAvailable):

  • platform/mac/NSScrollerImpDetails.mm: Added.

(WebCore::isScrollbarOverlayAPIAvailable):
(WebCore::recommendedScrollerStyle):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setIsCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

17:35 Changeset [103290] by jamesr@google.com
  • 15 edits in trunk

[chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly
https://bugs.webkit.org/show_bug.cgi?id=74477

Reviewed by Kenneth Russell.

Source/WebCore:

This enforces that the m_layerTreeHost pointer on LayerChromium instances is always up to date, instead of
lazily setting it in the paintContents loop. There are two invariants:
1.) If a LayerChromium is the root layer of a CCLayerTreeHost, or is reachable via the children, mask, or
replica pointers from the root layer of a CCLayerTreeHost, then that LayerChromium's m_layerTreeHost pointer
refers to that CCLayerTreeHost
2.) If a LayerChromium is not a root layer or reachable from a root layer of any CCLayerTreeHost, its
CCLayerTreeHost pointer is nil.

Covered by several new layout tests in LayerChromiumTest

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createTile):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Add some new tests for LayerChromium::m_layerTreeHost behavior.

  • tests/CCLayerTreeHostTest.cpp:

(::MockLayerTreeHost::create):
(::MockLayerTreeHost::MockLayerTreeHost):
(::CCLayerTreeHostTestShortlived1::beginTest):
(::CCLayerTreeHostTestShortlived2::beginTest):
(::CCLayerTreeHostTestShortlived3::beginTest):

  • tests/LayerChromiumTest.cpp:

LayoutTests:

  • platform/chromium/test_expectations.txt:
17:16 Changeset [103289] by dpranke@chromium.org
  • 14 edits in trunk/Tools

webkitpy: remove port.executive, port.filesystem, port.user properties
https://bugs.webkit.org/show_bug.cgi?id=74896

Reviewed by Eric Seidel.

Following on the refactoring of the port and host objects, this
removes the public executive, filesystem, and user properties
from the Port interface (protected versions of executive and
filesystem still exist). There is still some more clean up to
make the code more consistent and rearrange some other files to
talk to Hosts directly instead of getting them off of the Port
class.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.results_directory):
(Manager._log_worker_stack):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_fallback_path_in_config):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_InlineManager.start_worker):
(_InlineWorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.safe_init):

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfiguration.from_port):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.tests):
(Port.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_layout_tests_skipping):
(PortTest.test_test_dirs):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:

(HtmlGenerator.init):
(HtmlGenerator.show_html):
(real_main):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(TestHtmlGenerator.make_generator):

17:13 Changeset [103288] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Change the behavior of ewk_view_scale_set.
https://bugs.webkit.org/show_bug.cgi?id=70078

Reviewed by Eric Seidel.

Remove center point basis zoom alignment from ewk_view_scale_set to call
Page::setPageScaleFactor without any adjustment.

  • ewk/ewk_view.cpp:

(ewk_view_scale_set):

  • ewk/ewk_view.h:
17:13 Changeset [103287] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Qt build.

Unreviewed.

  • wtf/ThreadSpecific.h: #include!
17:11 Changeset [103286] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

It should be possible to change the value of an Options variable without recompiling the world
https://bugs.webkit.org/show_bug.cgi?id=74807

Reviewed by Gavin Barraclough.

  • runtime/Options.cpp:

(JSC::Options::initializeOptions):

  • runtime/Options.h:
17:06 Changeset [103285] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline results from https://bugs.webkit.org/show_bug.cgi?id=74870

Unreviewed; rebaseline only.

  • media/media-controller-playback-expected.txt:
17:03 Changeset [103284] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark svg/filters/big-sized-filter.svg as slow in debug.

  • platform/chromium/test_expectations.txt:
16:57 Changeset [103283] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

IndexedDB multiple calls to transaction.objectStore(name) should return the same instance
https://bugs.webkit.org/show_bug.cgi?id=60208

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-19
Reviewed by Tony Chang.

Source/WebCore:

Ditto for calls to IDBObjectStore.index(). Calling these methods after the
enclosing transaction has finished now consistently throws an error, which
allows us to break reference cycles.

Test: storage/indexeddb/mozilla/object-identity.html

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::transactionFinished):

  • storage/IDBObjectStore.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreCreated):
(WebCore::IDBTransaction::dispatchEvent):

  • storage/IDBTransaction.h:

LayoutTests:

  • storage/indexeddb/mozilla/object-identity-expected.txt: Added.
  • storage/indexeddb/mozilla/object-identity.html: Added.
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/tutorial.html:
16:52 Changeset [103282] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, adding a bug number for svg/carto.net/selectionlist.svg.

  • platform/chromium/test_expectations.txt:
16:51 Changeset [103281] by jonlee@apple.com
  • 11 edits in trunk/Source/WebKit2

[WK2] Extend show notification API to include the source page
https://bugs.webkit.org/show_bug.cgi?id=74751
<rdar://problem/10514541>

Reviewed by John Sullivan.

We add the source page that dispatched the notification in the API for convenience. In order to include the page,
we move the show() message sent by WebNotificationManager from WebNotificationManagerProxy to WebPageProxy.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): We aim the message at WebPageProxy instead of WebNotificationManagerProxy.

  • UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Remove the show() message.
  • UIProcess/WebPageProxy.messages.in: Add a showNotification() message.
  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show): This function is now called from the WebPageProxy.

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/API/C/WKNotificationProvider.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):

  • UIProcess/Notifications/WebNotificationProvider.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebPageProxy.h:
16:39 Changeset [103280] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Replace accidentally removed expectation in r103270.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:31 Changeset [103279] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
fast/dom/Document/early-document-access.html consistently passes.

  • platform/chromium/test_expectations.txt:
16:12 Changeset [103278] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] QWebDownloadItems are leaking
https://bugs.webkit.org/show_bug.cgi?id=74618

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-19
Reviewed by Kenneth Rohde Christiansen.

QWebDownloadItems are leaking when WebProcess raises a
download failure before sending didReceiveResponse back to UIProcess.
This can happen when QtFileDownloader fails in determineFilename(), for instance.
It happens when QtDownloadManager::downloadFailed() is reached
and has an "empty" downloadItem, which means we never got to
QtDownloadManager::downloadReceivedResponse(). At this point
QQuickWebView::downloadRequested() signal hasn't been emitted and
the downloadItem will have null parent. Therefore, it will leak
unless we delete it ourselves.

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::QtDownloadManager::downloadFailed):

15:53 Changeset [103277] by andersca@apple.com
  • 11 edits in trunk/Source

Send gesture events through the event dispatcher and scrolling coordinator
https://bugs.webkit.org/show_bug.cgi?id=74879

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:

Export ScrollingCoordinator::handleGestureEvent.

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::handleGestureEvent):

  • page/ScrollingCoordinator.h:

Add handleGestureEvent stub.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleGestureEvent):
Use the EventDispatcher message.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::gestureEvent):
Try to send the event to the scrolling coordinator first before dispatching it on the main thread.

(WebKit::EventDispatcher::dispatchGestureEvent):
Just call through to the WebPageProxy.

  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebPage/EventDispatcher.messages.in:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Move the GestureEvent message from WebPage to EventDispatcher.

15:40 Changeset [103276] by dbates@webkit.org
  • 2 edits in trunk/Tools

Pass command line arguments to GDB when debugging a Mac WebKit application
https://bugs.webkit.org/show_bug.cgi?id=72829

Reviewed by David Kilzer.

Pass through any command line arguments given to debug-{safari, minibrowser}
to GDB so that they may influence the application instance launched by GDB.

  • Scripts/webkitdirs.pm:

(execMacWebKitAppForDebugging):

15:39 Changeset [103275] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Setting QWebPreferences affect multiple WebViews
https://bugs.webkit.org/show_bug.cgi?id=71559

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-19
Reviewed by Kenneth Rohde Christiansen.

The QWebPreferences are per WebView, but the actual implementation
in WebKit2 make them per page group. Currently we share only one
page group between all the views, so if we set preferences
to one WebView the preferences are shared between them all, generating
unexpected behavior. This patch fixes this by making each WebView have
its own page group.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
15:26 Changeset [103274] by haraken@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

Move WebAudio and WebSocket getters from JSDOMWindowCustom.cpp
to JSDOMWindow{WebAudio,WebSocket}Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=74841

Reviewed by Adam Barth.

This is the second step for bug 74599. We are planning to enable the [Supplemental]
IDL and modularize WebAudio and WebSocket on AppleWebKit. This patch moves
webkitAudioContext() and webSocket() from JSDOMWindowCustom.cpp to JSDOMWindowWebAudioCustom.cpp
and JSDOMWindowWebSocketCustom.cpp, for modularization.

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • GNUmakefile.list.am: Added JSDOMWindowWebAudioCustom.cpp and JSDOMWindowWebSocketCustom.cpp.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDOMWindowCustom.cpp: For now we do not remove settingsForWindow(),

webkitAudioContext() and webSocket(), since other build systems are still using them.
We will remove them after all build systems implement the [Supplemental] IDL.

  • bindings/js/JSDOMWindowWebAudioCustom.cpp: Added.

(WebCore::settingsForWindowWebAudio):
(WebCore::JSDOMWindow::webkitAudioContext):

  • bindings/js/JSDOMWindowWebSocketCustom.cpp: Added.

(WebCore::settingsForWindowWebSocket):
(WebCore::JSDOMWindow::webSocket):

  • bindings/scripts/CodeGeneratorJS.pm: Until we implement the [Supplemental] IDL

on all build systems, we need to temporarily allow two kinds of webkitAudioContext()
and webSocket().
(GenerateHeader):

15:10 Changeset [103273] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add more using statements to (re)fix Chromium builders.

Unreviewed gardening.

  • tests/Canvas2DLayerChromiumTest.cpp:
15:03 Changeset [103272] by zmo@google.com
  • 8 edits in trunk

Postpone deleteRenderbuffer/deleteTexture until all framebuffer attachment points are removed.
https://bugs.webkit.org/show_bug.cgi?id=74741

Reviewed by Kenneth Russell.

Source/WebCore:

Use WebGLObject's attachment count mechanism to track if a renderbuffer/texture
is still attached to framebuffers, and if its deletion should be delated or not.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::isBound):

  • html/canvas/WebGLFramebuffer.h:

LayoutTests:

  • fast/canvas/webgl/object-deletion-behaviour-expected.txt:
  • fast/canvas/webgl/object-deletion-behaviour.html: synced with khronos side.
14:51 Changeset [103271] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix win builder due to more NotNull ambiguity errors.

Unreviewed gardening.

  • tests/Canvas2DLayerChromiumTest.cpp:
14:37 Changeset [103270] by enne@google.com
  • 8 edits in trunk/LayoutTests

[chromium] Rebaseline table-cell-collapsed-border after r103251.

Unreviewed gardening.

mwenge asked for this test to be rebaselined. Also, marking a failing
border-conflict-element-001d failure on CG only as WONTFIX, as
Chromium's CG configurations are going away soon.

  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-linux/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium/test_expectations.txt:
14:31 Changeset [103269] by kerz@chromium.org
  • 2 edits in branches/chromium/963/Source/WebCore

Merge 102519 - WebPImageDecoder progressive decodes fail to decode valid images
https://bugs.webkit.org/show_bug.cgi?id=74062

Reviewed by Adam Barth.

The WEBP header is followed by a so-called P0 header, then some data to
decode. If a partial P0 header is received during progressive decodes,
WebPIDecGetRGB() returns false; that makes the decoder enter the failed
state, no image appears on the page.

James Zern (webp) recommended the following via e-mail:

WebPIUpdate() validates input data, and will return an error status for
malformed data (bit-stream error, invalid data). Otherwise, it returns
OK or SUSPENDED. OK means that decoding is done/complete/no-error, and
SUSPENDED means more input data is needed to complete decoding. A NULL
return from WebPIDecGetRGB() is valid at this time due to a partial P0,
and should not be interpreted as a decoding failure.

No new tests. Not something DumpRenderTree can easily test.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode): A NULL WebPIDecGetRGB() return is
acceptable here. Return false instead of failing the decoder.

TBR=noel.gordon@gmail.com
Review URL: http://codereview.chromium.org/8992026

14:30 BuildingQtOnLinux edited by ossy@webkit.org
(diff)
14:29 Changeset [103268] by kerz@chromium.org
  • 2 edits in branches/chromium/963/Source/WebCore

Merge 102310 - WebPImageDecoder should not do a full image decode if progressive decoding is active
https://bugs.webkit.org/show_bug.cgi?id=74041

Reviewed by Adam Barth.

If the decoder input data state reaches allDataReceived during a progressive image
decode, the decoder performs a full image decode.

On allDataReceived, check if we already have a decoder, and if so, continue to run
the progressive decoder.

No new tests. No change in behavior.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

TBR=noel.gordon@gmail.com
Review URL: http://codereview.chromium.org/8974025

14:23 Changeset [103267] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
fast/body-propagation/overflow/003-xhtml.xhtml consistently passes.

  • platform/chromium/test_expectations.txt:
14:17 Changeset [103266] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Unskip now passing tests.
14:14 Changeset [103265] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
http/tests/security/mixedContent/insecure-css-in-main-frame.html
consistently passes.

  • platform/chromium/test_expectations.txt:
13:45 Changeset [103264] by commit-queue@webkit.org
  • 11 edits
    1 add in trunk/Source

[chromium] Accelerated canvas broken in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=72738

We were flushing the Skia canvas in updateCompositorResources, which
is illegal as it runs on the wrong thread. Moved to paintContentsIfDirty
instead. For correct rendering on the compositor thread, we make a copy
of the canvas texture in updateCompositorResources.

Removed m_textureId and pushPropertiesTo from CanvasLayerChromium, as
it's no longer common between Canvas2DLayerChromium and
WebGLLayerChromium. WebGL changes do not change functionality.

Patch by Iain Merrick <husky@google.com> on 2011-12-19
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setTextureId):
(WebCore::Canvas2DLayerChromium::contentChanged):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setLayerTreeHost):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebCore::WebGLLayerChromium::textureId):
(WebCore::WebGLLayerChromium::setTextureId):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(WebCore::CCCanvasLayerImpl::textureId):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/Canvas2DLayerChromiumTest.cpp: Added.

(WebCore::Canvas2DLayerChromiumTest::setTextureManager):

13:42 Changeset [103263] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DEPS from 114686 to 115012.

  • DEPS:
13:40 Changeset [103262] by reed@google.com
  • 6 edits in trunk/Source/WebCore

[skia] cache typeface in FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=74415

Reviewed by Stephen White.

No new tests. optimization only, existing tests in play

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::Font::drawGlyphs):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::CreateTypefaceFromHFont):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:

(WebCore::FontPlatformData::typeface):
(WebCore::FontPlatformData::lfQuality):
(WebCore::FontPlatformData::hash):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

  • platform/graphics/skia/SkiaFontWin.h:
13:28 Changeset [103261] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: remove executive,filesystem,user parameters from Port constructor
https://bugs.webkit.org/show_bug.cgi?id=74878

Reviewed by Eric Seidel.

This change concludes the refactoring that makes Host a required
parameter for Port and ensures that all access to filesystem,
executives, etc. is going through the Host.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):

13:16 Changeset [103260] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark all the media-controller-playback tests as failing.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
13:06 Changeset [103259] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark unreachable-overflow-rtl-bug as failing after r103245.
https://bugs.webkit.org/show_bug.cgi?id=74881

Unreviewed gardening.

Also, make expectation file pass linting.

  • platform/chromium/test_expectations.txt:
13:01 Changeset [103258] by tommyw@google.com
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Fixing memory leak in WebMediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=74714

Reviewed by Eric Seidel.

Missed that PassRefPtr does a ref if constructed with a raw pointer.
Also removed an extra space in WebMediaStreamDescriptor.cpp.

  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):

  • src/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::operator=):

12:55 Changeset [103257] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Update suppressions for r103251

Unreviewed, expectaions update - missed suppressing a few of the border conflict tests that need rebaselining.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
12:45 Changeset [103256] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Try to fix the Chromium win builder NotNull conflict.

Unreviewed gardening.

  • tests/MockGraphicsContext3DTest.cpp:
12:22 Changeset [103255] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r103250.
http://trac.webkit.org/changeset/103250
https://bugs.webkit.org/show_bug.cgi?id=74877

it still breaks codegen (Requested by olliej on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-19

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::byValIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:22 Changeset [103254] by dpranke@chromium.org
  • 9 edits in trunk/Tools

webkitpy: finish refactoring port classes to make a host mandatory
https://bugs.webkit.org/show_bug.cgi?id=74566

Reviewed by Eric Seidel.

This change makes all Port objects take a required (System)Host
parameter, and updates the TestPort object to no longer create a
mock filesystem or add files to the existing filesystem by
default.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory.init):
(PortFactory._get_kwargs):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init):
(TestPort.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(logging_run):
(get_tests_run):
(MainTest.test_single_file):
(MainTest.test_stderr_is_saved):
(MainTest.test_test_list):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_with_stderr):
(MainTest.test_no_image_failure_with_image_diff):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_relative):
(MainTest.test_retries_directory):
(MainTest.test_tolerance.get_port_for_run):
(MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:

(Rebaseliner.init):
(main):
(real_main):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(test_host_port_and_filesystem):
(TestRebaseliner.make_rebaseliner):
(TestRealMain.test_all_platforms):
(TestHtmlGenerator.make_generator):

12:04 Changeset [103253] by dpranke@chromium.org
  • 14 edits in trunk/Tools

webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
https://bugs.webkit.org/show_bug.cgi?id=74562

Reviewed by Eric Seidel.

Apart from a minor change to style/checkers/test_expectations.py
to take a host as a parameter to a TestExpectationsChecker(),
there are only refactoring changes to unit tests here.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest.test_test_timings_trie):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.make_port):
(PortTest.test_layout_tests_skipping):
(PortTest.test_test_dirs):
(PortTest.test_additional_platform_directory):
(PortTest.test_uses_test_expectations_file):
(PortTest.test_find_no_paths_specified):
(PortTest.test_find_one_test):
(PortTest.test_find_glob):
(PortTest.test_find_with_skipped_directories):
(PortTest.test_find_with_skipped_directories_2):
(PortTest.test_parse_reftest_list):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:

(DryRunPort.init):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.setUp):
(FactoryTest.tearDown):
(FactoryTest.assert_port):
(FactoryTest.assert_platform_port):
(FactoryTest.test_unknown_specified):
(FactoryTest.test_unknown_default):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockDRTTest.assertTest):
(MockDRTTest.test_main):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(WebKitPortTest.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_layout_tests):
(test_skipped_file_search_paths):
(test_root_option):
(test_test_expectations):
(test_build_driver):
(test_linux_distro_detection):
(test_apache_config_file_name_for_platform):
(test_path_to_apache_config_file):
(WebKitDriverTest.test_read_block):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.init):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config.TestMacPort):

12:00 Changeset [103252] by kubo@profusion.mobi
  • 3 edits in trunk/Source/WebKit/efl

Unreviewed; fix the build with ENABLE(TOUCH_EVENTS) after r103167.

This partly reverts r102297: the Touch{Start,Move,End,Cancel} events
are not in a separate enum anymore (they are part of
WebCore::PlatformEvent), so the assertions in AssertMatchingEnums.cpp
always fail. Setting EWK_TOUCH_START to TouchStart feels even more
hackish, so we just convert the types manually again for now.

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

11:49 Changeset [103251] by robert@webkit.org
  • 57 edits
    88 adds in trunk

CSS 2.1 failure: border-conflict-element-*
https://bugs.webkit.org/show_bug.cgi?id=71244

Reviewed by Darin Adler.

Source/WebCore:

From http://www.w3.org/TR/CSS21/tables.html#border-conflict-resolution :

"When two adjacent cells have the same border-width and the same border-style in a

'border-collapse: collapse' table, then the color of the border from the leftmost cell wins
(if the table's 'direction' is 'ltr'; right, if it is 'rtl') and the color of the border
from the topmost cell wins."

RenderTable manages collapsed borders by first creating a list of unique border values sorted in ascending
priority. A unique border value is determined by style, width and color and cell-type precedence. For each
entry in this list RenderTableSection paints each cell in its section starting at the top-left. If a cell
is using the border RenderTable is currently iterating for, the cell will paint that border.

The problems with this approach are:

  1. Painting cells from the top-left to the bottom-right means that borders further to the right and to the bottom of the table will paint over those further to the left and the top, breaking the precedence due to cell position.
  2. It creates more unique borders in the list than necessary. Borders that differ only on color do not need to be painted in a separate iteration. Precedence in such cases is determined by cell position.

So in order to respect cell position when painting collapsed borders:

  1. RenderTableCell now treats borders with the same style, width and precedence as equal. This results in a performance improvement on tables where collapsed borders differ only in color, since RenderTable is no longer painting every cell in the table for each unique collapsed border color. It also allows color to be a function of cell position rather than border type.
  2. RenderTableSection now paints collapsed borders separately from cells and from the bottom-right to the top-left instead of top-left to bottom-right. If a collapsed border has precedence due to style, width or cell-group-type it will still be respected but precedence due to color is enforced by painting cells nearer to the top and left *after* cells nearer to the bottom and right.

The order in which collapsed borders paint over each other in the same cell has not changed. Unlike Firefox,
WebKit does not attempt render them as diagonals or attempt to give borders on the edge of the table precedence
so that grooved and ridged styles have a smooth edge all round the table.

This fixes the following failing tests from the border-conflict-element-* set
in the CSS 2.1 test suite:

border-conflict-element-001d.htm
border-conflict-element-0037.htm
border-conflict-element-0038.htm

One test in the suite is known to be wrong, so a corrected version has been landed outside the
css2.1 folder:

border-conflict-element-002.htm

This change entails rebaselining quite a few tests, see the LayoutTests ChangeLog for a full
explanation of the rebaselines.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paint):
(WebCore::addBorderStyle):
(WebCore::compareBorderValuesForQSort):
(WebCore::RenderTableCell::paintCollapsedBorders):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::paintObject):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::isSameIgnoringColor):

LayoutTests:

Add all the passing border-conflict-element* tests from the CSS 2.1 test suite.

Add a corrected version of the CSS suite test border-conflict-element-002.htm, which can sit here until

the corrected version is landed upstream. See http://lists.w3.org/Archives/Public/public-css-testsuite/2011Nov/0002.html

Rebaseline all t170602-bdr-conflct-w-* tests. The rendering of the collapsed borders in these

tests now obeys the order of precedence for the position of the cell and the precendece of the position
of the borders within the same cell.

Rebaseline two border-conflict-style-* tests: ditto

Rebaseline fast/borders/border-antialiasing.html, the result is too small to confirm the difference but

presume it is one of the above.

Rebaseline floating-replaced-height-008.html as the support file it uses is added by this patch (in order to

support border-conflict-element-001d.htm).

  • css2.1/20110323/border-conflict-element-001-expected.html: Added.
  • css2.1/20110323/border-conflict-element-001.htm: Added.
  • css2.1/20110323/border-conflict-element-001d-expected.html: Added.
  • css2.1/20110323/border-conflict-element-001d.htm: Added.
  • css2.1/20110323/border-conflict-element-003-expected.html: Added.
  • css2.1/20110323/border-conflict-element-003.htm: Added.
  • css2.1/20110323/border-conflict-element-004-expected.html: Added.
  • css2.1/20110323/border-conflict-element-004.htm: Added.
  • css2.1/20110323/border-conflict-element-005-expected.html: Added.
  • css2.1/20110323/border-conflict-element-005.htm: Added.
  • css2.1/20110323/border-conflict-element-006-expected.html: Added.
  • css2.1/20110323/border-conflict-element-006.htm: Added.
  • css2.1/20110323/border-conflict-element-007-expected.html: Added.
  • css2.1/20110323/border-conflict-element-007.htm: Added.
  • css2.1/20110323/border-conflict-element-008-expected.html: Added.
  • css2.1/20110323/border-conflict-element-008.htm: Added.
  • css2.1/20110323/border-conflict-element-009-expected.html: Added.
  • css2.1/20110323/border-conflict-element-009.htm: Added.
  • css2.1/20110323/border-conflict-element-010-expected.html: Added.
  • css2.1/20110323/border-conflict-element-010.htm: Added.
  • css2.1/20110323/border-conflict-element-011-expected.html: Added.
  • css2.1/20110323/border-conflict-element-011.htm: Added.
  • css2.1/20110323/border-conflict-element-012-expected.html: Added.
  • css2.1/20110323/border-conflict-element-012.htm: Added.
  • css2.1/20110323/border-conflict-element-013-expected.html: Added.
  • css2.1/20110323/border-conflict-element-013.htm: Added.
  • css2.1/20110323/border-conflict-element-014-expected.html: Added.
  • css2.1/20110323/border-conflict-element-014.htm: Added.
  • css2.1/20110323/border-conflict-element-015-expected.html: Added.
  • css2.1/20110323/border-conflict-element-015.htm: Added.
  • css2.1/20110323/border-conflict-element-016-expected.html: Added.
  • css2.1/20110323/border-conflict-element-016.htm: Added.
  • css2.1/20110323/border-conflict-element-017-expected.html: Added.
  • css2.1/20110323/border-conflict-element-017.htm: Added.
  • css2.1/20110323/border-conflict-element-018-expected.html: Added.
  • css2.1/20110323/border-conflict-element-018.htm: Added.
  • css2.1/20110323/border-conflict-element-019-expected.html: Added.
  • css2.1/20110323/border-conflict-element-019.htm: Added.
  • css2.1/20110323/border-conflict-element-020-expected.html: Added.
  • css2.1/20110323/border-conflict-element-020.htm: Added.
  • css2.1/20110323/border-conflict-element-021-expected.html: Added.
  • css2.1/20110323/border-conflict-element-021.htm: Added.
  • css2.1/20110323/border-conflict-element-022-expected.html: Added.
  • css2.1/20110323/border-conflict-element-022.htm: Added.
  • css2.1/20110323/border-conflict-element-023-expected.html: Added.
  • css2.1/20110323/border-conflict-element-023.htm: Added.
  • css2.1/20110323/border-conflict-element-024-expected.html: Added.
  • css2.1/20110323/border-conflict-element-024.htm: Added.
  • css2.1/20110323/border-conflict-element-025-expected.html: Added.
  • css2.1/20110323/border-conflict-element-025.htm: Added.
  • css2.1/20110323/border-conflict-element-026-expected.html: Added.
  • css2.1/20110323/border-conflict-element-026.htm: Added.
  • css2.1/20110323/border-conflict-element-027-expected.html: Added.
  • css2.1/20110323/border-conflict-element-027.htm: Added.
  • css2.1/20110323/border-conflict-element-028-expected.html: Added.
  • css2.1/20110323/border-conflict-element-028.htm: Added.
  • css2.1/20110323/border-conflict-element-029-expected.html: Added.
  • css2.1/20110323/border-conflict-element-029.htm: Added.
  • css2.1/20110323/border-conflict-element-030-expected.html: Added.
  • css2.1/20110323/border-conflict-element-030.htm: Added.
  • css2.1/20110323/border-conflict-element-031-expected.html: Added.
  • css2.1/20110323/border-conflict-element-031.htm: Added.
  • css2.1/20110323/border-conflict-element-032-expected.html: Added.
  • css2.1/20110323/border-conflict-element-032.htm: Added.
  • css2.1/20110323/border-conflict-element-033-expected.html: Added.
  • css2.1/20110323/border-conflict-element-033.htm: Added.
  • css2.1/20110323/border-conflict-element-034-expected.html: Added.
  • css2.1/20110323/border-conflict-element-034.htm: Added.
  • css2.1/20110323/border-conflict-element-035-expected.html: Added.
  • css2.1/20110323/border-conflict-element-035.htm: Added.
  • css2.1/20110323/border-conflict-element-036-expected.html: Added.
  • css2.1/20110323/border-conflict-element-036.htm: Added.
  • css2.1/20110323/border-conflict-element-037-expected.html: Added.
  • css2.1/20110323/border-conflict-element-037.htm: Added.
  • css2.1/20110323/border-conflict-element-038-expected.html: Added.
  • css2.1/20110323/border-conflict-element-038.htm: Added.
  • css2.1/20110323/border-conflict-element-039-expected.html: Added.
  • css2.1/20110323/border-conflict-element-039.htm: Added.
  • css2.1/20110323/support/swatch-blue.png: Added.
  • css2.1/20110323/support/swatch-green.png: Added.
  • css2.1/20110323/support/swatch-lime.png: Added.
  • css2.1/20110323/support/swatch-orange.png: Added.
  • css2.1/20110323/support/swatch-red.png: Added.
  • css2.1/20110323/support/swatch-teal.png: Added.
  • css2.1/20110323/support/swatch-white.png: Added.
  • css2.1/20110323/support/swatch-yellow.png: Added.
  • fast/css/border-conflict-element-002-expected.html: Added.
  • fast/css/border-conflict-element-002.htm: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
11:36 Changeset [103250] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Rolling r103120 back in with merge errors corrected.

11:15 Changeset [103249] by jer.noble@apple.com
  • 6 edits in trunk

MediaController: cannot scrub while playing.
https://bugs.webkit.org/show_bug.cgi?id=74870
rdar://problem/10602037

Reviewed by Eric Carlson.

Source/WebCore:

Updated media/media-controller-playback.html test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setController): Change order of operations; set the controllers media

element before passing controller to the controls.

  • html/MediaController.cpp:

(MediaController::updatePlaybackState): Stop the playback clock when WAITING or ENDED.
(MediaController::beginScrubbing): Stop the playback clock.
(MediaController::endScrubbing): Restart (if necessary) the playback clock.
(MediaController::canPlay): Return true if paused.

  • platform/mac/PlatformClockCA.cpp:

(PlatformClockCA::setCurrentTime): Stop the CAClock before changing the current time.

LayoutTests:

  • media/media-controller-playback.html:
10:37 Changeset [103248] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more worker tests as being flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=74746

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:35 Changeset [103247] by abarth@webkit.org
  • 6 edits in trunk

We don't pass all of the html5lib unsafe-text.dat tests
https://bugs.webkit.org/show_bug.cgi?id=74825

Reviewed by Eric Seidel.

Source/WebCore:

This patch is actually three (tiny) related patches. Together these
changes cause use to pass the plain-text-unsafe.dat tests from html5lib.

Tests: html5lib/runner.html

  • html/parser/HTMLTokenizer.cpp:

(WebCore::::shouldSkipNullCharacters):

  • We're not supposed to skip null characters in the PLAINTEXTState. This might cause compatibility problems with text/plain documents that contains NUL characters because we use the PLAINTEXTState to parse them. If we run into any trouble, it's easy to fix in TextDocumentParser.
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromToken):

  • Fix typo.

(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):

  • We're supposed to replace NUL characters if the next character token if we're in foreign content. The previous check didn't quite get this case correctly.

(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • Now that we replace NUL characters with the replacement character, we need to be more careful about the fact that replacement characters don't flip m_framesetOk to false. Note: This new check matches the check for non-foreign content.

LayoutTests:

Show test progression.

  • html5lib/runner-expected.txt:
  • platform/chromium/html5lib/runner-expected.txt:
10:30 Changeset [103246] by abarth@webkit.org
  • 14 edits in trunk

WebKit should support HTML entities that expand to more than one character
https://bugs.webkit.org/show_bug.cgi?id=74826

Reviewed by Darin Adler.

Source/WebCore:

Tests: html5lib/runner.html

  • html/parser/HTMLEntityNames.in:
    • Add missing HTML entities from HTML5 spec. I'll sort this file in a followup patch. (It's not quite sorted perfectly and sorting in this patch would introduce noise into the patch.)
  • html/parser/HTMLEntityParser.cpp:

(WebCore::decodeNamedEntity):

  • convertToUTF16 always returns true, so make it return void instead.
  • Teach the entity parse that some entities expand to two characters.
  • html/parser/HTMLEntityParser.h:
    • Add a warning that decodeNamedEntity is really a broken API.
    • This patch doesn't actually change any behavior of this API, but it does illustrate that the two callers of this API (the two XML parsers) really need to move a more sensible API.
  • html/parser/HTMLEntitySearch.cpp:

(WebCore::HTMLEntitySearch::HTMLEntitySearch):
(WebCore::HTMLEntitySearch::advance):

  • html/parser/HTMLEntitySearch.h:

(WebCore::HTMLEntitySearch::fail):

  • Remove the concept of currentValue. This isn't really used for anything and conflicts with the idea that entities can expand to more than one character.
  • html/parser/HTMLEntityTable.h:
    • Add storage for two UChar32 values per entity.
  • html/parser/create-html-entity-table:

(convert_value_to_int):

  • Teach this script to handle entities that expand to multiple Unicode characters.
  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference):

  • Update this function now that convertToUTF16 returns void.
  • xml/parser/XMLCharacterReferenceParser.cpp:
    • The XML version of convertToUTF16 also needs to return void to match the HTML signature. (It used to return true all the time as well.)
  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processHTMLEntity):

  • Update this caller use leftValue instead of value. My sense is that this code is moderately broken today because it's using HTML entities in parsing XML. I've added a FIXME. This code is disabled in all builds, so I don't feel a big need to fix this issue in this patch. We should either finish this project or delete this complexity from the project.

LayoutTests:

Show test progression.

  • html5lib/runner-expected.txt:
  • platform/chromium/html5lib/runner-expected.txt:
10:11 Changeset [103245] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid instantiating ScrollAnimators when possible.
<http://webkit.org/b/74830>

Reviewed by Beth Dakin.

Have RenderLayer::scrollToOffset() check if we're scrolling to the already
current offset. In that case, don't call down to scrollToOffsetWithoutAnimation(),
avoiding the instantiation of a ScrollAnimator.

This reduces memory consumption by 400 kB (on 32-bit) when viewing the full HTML5
spec on <http://whatwg.org/c>, since we were creating a ScrollAnimator for every
single RenderLayer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset):

10:07 Changeset [103244] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] remove one file related to multipart from the BlackBerry build system
https://bugs.webkit.org/show_bug.cgi?id=74839

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2011-12-19
Reviewed by Daniel Bates.

After refactored multipart, the code of MultipartResponseDelegate have been moved
out of WebCore, we do not need to upstream MultipartResponseDelegate any more.
So remove it from PlatformBlackBerry.cmake to update build system.

  • PlatformBlackBerry.cmake:
09:45 Changeset [103243] by ggaren@apple.com
  • 112 edits in trunk/Source

Placement new does an unnecessary NULL check
https://bugs.webkit.org/show_bug.cgi?id=74676

Reviewed by Sam Weinig.

Source/JavaScriptCore:

We can define our own version, which skips the NULL check.

Not a measurable speedup, but code inspection shows better code generated,
and I believe this is a step toward turning off -fomit-frame-pointer.

  • API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

  • API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::create): Use the NotNull version of placement
new to skip the NULL check.

  • API/JSCallbackObject.h: Removed a conflicting, unnecessaray placement new.

(JSC::JSCallbackObject::create):

  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::grow):

  • heap/HandleHeap.h:

(JSC::HandleHeap::allocate):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):
(JSC::MarkedBlock::recycle):

  • jit/JITCode.h:

(JSC::JITCode::clear):

  • jsc.cpp:

(GlobalObject::create):

  • profiler/CallIdentifier.h:
  • runtime/Arguments.h:

(JSC::Arguments::create):

  • runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::create):

  • runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::create):

  • runtime/BooleanConstructor.h:

(JSC::BooleanConstructor::create):

  • runtime/BooleanObject.h:

(JSC::BooleanObject::create):

  • runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::create):

  • runtime/DateConstructor.h:

(JSC::DateConstructor::create):

  • runtime/DateInstance.h:

(JSC::DateInstance::create):

  • runtime/DatePrototype.h:

(JSC::DatePrototype::create):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorConstructor.h:

(JSC::ErrorConstructor::create):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):

  • runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

  • runtime/ExceptionHelpers.h:

(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::create):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

  • runtime/FunctionConstructor.h:

(JSC::FunctionConstructor::create):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::create):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::create):

  • runtime/JSActivation.h:

(JSC::JSActivation::create):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::create): Use the NotNull version of placement
new to skip the NULL check.

  • runtime/JSCell.h: Removed a conflicting, unnecessaray placement new.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):

  • runtime/JSFunction.h:

(JSC::JSFunction::create):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):

  • runtime/JSGlobalThis.h:

(JSC::JSGlobalThis::create):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::create):

  • runtime/JSONObject.h:

(JSC::JSONObject::create):

  • runtime/JSObject.h:

(JSC::JSFinalObject::create):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::create):

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):

  • runtime/JSString.cpp:

(JSC::StringObject::create):

  • runtime/JSString.h:

(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):

  • runtime/MathObject.h:

(JSC::MathObject::create):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::create):

  • runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

  • runtime/NumberConstructor.h:

(JSC::NumberConstructor::create):

  • runtime/NumberObject.h:

(JSC::NumberObject::create):

  • runtime/NumberPrototype.h:

(JSC::NumberPrototype::create):

  • runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::create):

  • runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::create):

  • runtime/RegExp.cpp:

(JSC::RegExp::createWithoutCaching):

  • runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::create):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::create):

  • runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::create):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::create):

  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::create):

  • runtime/StringConstructor.h:

(JSC::StringConstructor::create):

  • runtime/StringObject.h:

(JSC::StringObject::create):

  • runtime/StringPrototype.h:

(JSC::StringPrototype::create):

  • runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::createStructure):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):

  • testRegExp.cpp:

(GlobalObject::create):

  • wtf/BitVector.cpp:

(WTF::BitVector::OutOfLineBits::create): Use the NotNull version of placement
new to skip the NULL check.

  • wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::create): Standardized spacing to make grep easier.

  • wtf/ByteArray.cpp:

(WTF::ByteArray::create):

  • wtf/Deque.h:

(WTF::::append):
(WTF::::prepend): Use NotNull, as above.

  • wtf/FastAllocBase.h: Added a placement new, since this class would otherwise

hide the name of the global placement new.

(WTF::fastNew): Standardized spacing. Most of these functions don't need
NotNull, since they check for NULL, and the optimizer can see that.

  • wtf/HashTable.h:
  • wtf/HashTraits.h:

(WTF::SimpleClassHashTraits::constructDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::allocFreeSpaceNode): NotNull, as above.

  • wtf/StdLibExtras.h:

(throw): This is our NotNull placement new. Declaring that we throw is
the C++ way to say that operator new will not return NULL.

  • wtf/ThreadSpecific.h:

(WTF::T):

  • wtf/Vector.h:

(WTF::::append):
(WTF::::tryAppend):
(WTF::::uncheckedAppend):
(WTF::::insert):

  • wtf/text/AtomicStringHash.h:
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::tryCreateUninitialized):

  • wtf/text/StringStatics.cpp:

(WTF::AtomicString::init): Use NotNull, as above.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): Standardized
spacing for easy grep.

Source/WebCore:

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateConstructorDeclaration):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::create):

  • bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

  • dom/Document.h:

(WebCore::FormElementKeyHashTraits::constructDeletedValue): Use NotNull
placement new, as in JavaScriptCore.

  • platform/PODArena.h:

(WebCore::PODArena::allocateObject): No need to check for NULL explicitly,
since that's the built-in behavior of placement new.

  • platform/graphics/FontCache.cpp:

(WebCore::FontDataCacheKeyTraits::constructDeletedValue):

  • platform/graphics/IntRectHash.h:
  • platform/graphics/IntSizeHash.h: More NotNull.
  • rendering/RenderObject.h: Declaring that we throw is the C++ way to say

that operator new will not return NULL.

09:25 Changeset [103242] by eric.carlson@apple.com
  • 15 edits
    3 adds in trunk

Render text tracks
https://bugs.webkit.org/show_bug.cgi?id=62886

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-cue-rendering.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-container):
(video::-webkit-media-text-track-display):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_haveVisibleTextTrack.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Trigger an update of the text

track display.

(WebCore::HTMLMediaElement::textTrackModeChanged): call configureTextTrackDisplay() so

the text track display is hidden or shown when necessary.

(WebCore::HTMLMediaElement::userIsInterestedInThisTrack): Minor cleanup.
(WebCore::HTMLMediaElement::createMediaControls): configureMediaControls() always called

reset after creating the controls, do it here instead.

(WebCore::HTMLMediaElement::configureMediaControls): Simplify and cleanup.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Show and hide text track display.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::currentlyVisibleCues):

  • html/shadow/MediaControlElements.cpp:

(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement): New.
(WebCore::RenderTextTrackContainerElement::layout): New. Call the display element so it can

update the position and font size.

(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): New.
(WebCore::MediaControlTextTrackContainerElement::create): Ditto.
(WebCore::MediaControlTextTrackContainerElement::createRenderer): Ditto.
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Ditto.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Keep the cue display element

positioned above the bottom of the video box, and size the font according to the video height.

(WebCore::MediaControlTextTrackDisplayElement::MediaControlTextTrackDisplayElement): New.
(WebCore::MediaControlTextTrackDisplayElement::create): Ditto.
(WebCore::MediaControlTextTrackDisplayElement::shadowPseudoId): Ditto.

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlTextTrackContainerElement::displayType):
(WebCore::MediaControlTextTrackDisplayElement::displayType):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement): New.
(WebCore::MediaControlRootElement::setMediaController): Ditto.
(WebCore::MediaControlRootElement::createTextTrackDisplay): Ditto.
(WebCore::MediaControlRootElement::showTextTrackDisplay): Ditto.
(WebCore::MediaControlRootElement::hideTextTrackDisplay): Ditto.
(WebCore::MediaControlRootElement::updateTextTrackDisplay): Ditto.

  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium): New.
(WebCore::MediaControlRootElement::createTextTrackDisplay): Ditto.
(WebCore::MediaControlRootElement::showTextTrackDisplay): Ditto.
(WebCore::MediaControlRootElement::hideTextTrackDisplay): Ditto.
(WebCore::MediaControlRootElement::updateTextTrackDisplay): Ditto.

  • html/shadow/MediaControlRootElementChromium.h:
  • html/shadow/MediaControls.h:

LayoutTests:

  • media/media-controls.js:

(mediaControlsElement): Don't always look for a controller element.
(mediaControlsButtonCoordinates):
(textTrackDisplayElement): Find the cue display element.

  • media/track/track-cue-rendering-expected.txt: Added.
  • media/track/track-cue-rendering.html: Added.
09:12 Changeset [103241] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

  • platform/qt-5.0/Skipped: Unskip now passing tests.
07:59 Changeset [103240] by eric.carlson@apple.com
  • 9 edits in trunk/Source

Enable <track> for Mac build
https://bugs.webkit.org/show_bug.cgi?id=74838

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
07:56 Changeset [103239] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

  • platform/qt-5.0/Skipped: Unskip now passing tests.
  • platform/qt-wk2/Skipped: Skip unskipped qt-5.0 tests fail on qt-wk2.
07:34 Changeset [103238] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Fix build error due to unused variables
https://bugs.webkit.org/show_bug.cgi?id=74862

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::inputMethodEvent):

07:29 Changeset [103237] by kenneth@webkit.org
  • 8 edits in trunk/Source

Source/WebCore: Make the Editor::setIgnoreCompositionSelectionChange public as it is needed by Qt

Reviewed by Simon Hausmann.

  • editing/Editor.h:

Source/WebKit2: [Qt] Add methods for setting, cancelling and confirming the composition

Reviewed by Simon Hausmann.

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::cancelComposition):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::targetFrameForEditing):
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::cancelComposition):

07:14 Changeset [103236] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Implement CSS selector profiler backend
https://bugs.webkit.org/show_bug.cgi?id=74603

Reviewed by Pavel Feldman.

No new tests, as the changed code does not result in visible effects yet.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::RuleMatchingStats::RuleMatchingStats):
(WebCore::SelectorProfile::SelectorProfile):
(WebCore::SelectorProfile::~SelectorProfile):
(WebCore::SelectorProfile::totalMatchingTimeMs):
(WebCore::SelectorProfile::startSelector):
(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::restore):
(WebCore::InspectorCSSAgent::startSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::didMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::didProcessRule):

  • inspector/InspectorCSSAgent.h:
07:04 Changeset [103235] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Status bar button glyph for the "Record" buttons broken
https://bugs.webkit.org/show_bug.cgi?id=74861

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.record-cpu-profile-status-bar-item .glyph, .record-profile-status-bar-item .glyph):
(.record-cpu-profile-status-bar-item.toggled-on .glyph, .record-profile-status-bar-item.toggled-on .glyph):

06:31 Changeset [103234] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

[Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=74854

Reviewed by Csaba Osztrogonác.

Since r101052, libewebkit.so is built in a different location, so we
need to adjust the path returned by builtDylibPathForName.

usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
port also respects Release/Debug configurations.

These changes should make run-launcher finally work correctly with
webkit-efl.

  • Scripts/webkitdirs.pm:

(usesPerConfigurationBuildDirectory):
(builtDylibPathForName):

06:27 Changeset [103233] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

First stab at upstreaming our virtual keyboard code

Reviewed by Simon Hausmann.

Add basic implementation of inputMethodEvent

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::inputMethodEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
06:01 Changeset [103232] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

[Qt] Cleanup QTM_NAMESPACE usage in DeviceOrientationProviderQt
https://bugs.webkit.org/show_bug.cgi?id=74853

Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-19
Reviewed by Simon Hausmann.

  • Api/qwebframe_p.h:
  • WebCoreSupport/DeviceOrientationProviderQt.cpp:
  • WebCoreSupport/DeviceOrientationProviderQt.h:
05:35 Changeset [103231] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: only the first @rule is highlighted in CSS
https://bugs.webkit.org/show_bug.cgi?id=74568

Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2011-12-19
Reviewed by Timothy Hatcher.

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js:
05:22 Changeset [103230] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/qt

[Qt] Cleanup DeviceMotionClientQt and friends.
https://bugs.webkit.org/show_bug.cgi?id=74849

This patch cleans up the DeviceMotionQt class and friends by applying
the following changes:

  • Remove unnecessary pointer to QWebPage. This is needed to be able to reuse the code for WebKit2.
  • Remove QObject dependencies and all signals/slots. Instead, we call didChangeDeviceMotion() on the controller directly from DeviceMotionProviderQt.

Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-19
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DeviceMotionClientQt.cpp:

(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::setController):

  • WebCoreSupport/DeviceMotionClientQt.h:
  • WebCoreSupport/DeviceMotionProviderQt.cpp:

(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::setController):
(WebCore::DeviceMotionProviderQt::filter):

  • WebCoreSupport/DeviceMotionProviderQt.h:
05:07 Changeset [103229] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Feature Request: Able to remove all breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=63055

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.removeAllBreakpoints):

04:27 Changeset [103228] by hausmann@webkit.org
  • 6 edits in trunk

[Qt][WK2] Add support for modal event loop processing for WTR https://bugs.webkit.org/show_bug.cgi?id=74852

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add support for nested event loops, used by WebPage::runModal().

  • Platform/qt/RunLoopQt.cpp:

(RunLoop::run):
(RunLoop::stop):

Tools:

Rewrote event loop processing: Instead of terminating the event loop
in notifyDone() - something no other platform does - we now respect the
"bool& condition" parameter passed to platformRunUntil. This ensures
proper termination even when the condition is changed from within a
nested event loop, because only when we _exit_ from the nested event
loop we will check the condition and terminate the test properly.

In addition this patch implements TestController::runModal by means of
a nested event loop, which is passed to the platform webview that is
supposed to be modal. It is that view's responsibility to exit the
loop, upon destruction. I believe that's similar to how it works on the Mac,
where it doesn't seem that NSApp's runModalForWindow is terminate via
abort/stopModal but simply because the window is closed.

  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::setModalEventLoop):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::TestController::runModal):

04:07 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt5 on the bots (diff)
03:15 Changeset [103227] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for ScrollingCoordinatorMac.mm when building on a case sensitive system

Unreviewed build fix for r103180. StdlibExtras.h->StdLibExtras.h to compile on case sensitive system.

  • page/mac/ScrollingCoordinatorMac.mm:
02:56 Changeset [103226] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Removing suppressions from:
https://bugs.webkit.org/show_bug.cgi?id=74726.

Tests pass on bots:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29/builds/1832/steps/webkit_tests/logs/stdio
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28CG%29%28dbg%29/builds/2097/steps/webkit_tests/logs/stdio

  • platform/chromium/test_expectations.txt:
02:37 Changeset [103225] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip a new failing test.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r103217.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r103217.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r103217.
00:48 Changeset [103224] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary [JSCCustomGetter] IDLs from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=74829

Reviewed by Adam Barth.

Now JSC has implemented the [Constructor] IDL and it generates
getDOMConstructor() automatically. This patch removes hand-written
unnecessary getDOMConstructor()s from JSDOMWindowCustom.cpp.

No new tests. No change in behavior.

  • bindings/js/JSDOMWindowCustom.cpp:
  • page/DOMWindow.idl:
00:28 Changeset [103223] by abarth@webkit.org
  • 7 edits in trunk

The HTML parser doesn't enforce the "Noah's Ark condition" from the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=74828

Reviewed by Darin Adler.

Source/WebCore:

This patch implement the "Noah's Ark condition" from the HTML5
specification. This condition limits the number of identitical
elements that can be in the list of active formatting elements. I'm not
entirely sure that enforcing this condition is worth the complexity,
but given that we've come this far in support of the HTML5 parsing
algorithm, we might as well finish it.

After this patch, we pass all but one of the html5lib parsing tests!

Tests: html5lib/runner.html

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCount):
(WebCore::HTMLFormattingElementList::append):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

  • html/parser/HTMLFormattingElementList.h:

LayoutTests:

Show test progression.

  • fast/parser/residual-style-dom-expected.txt:
    • This isn't a great test because it's hard to see how changes affect the output. However, we have good coverage of these topics in the HTML5lib tests.
  • html5lib/runner-expected.txt:
  • platform/chromium/html5lib/runner-expected.txt:
00:11 Changeset [103222] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Add support for 8 bits strings to Document::isValidName()
https://bugs.webkit.org/show_bug.cgi?id=74784

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-19
Reviewed by Darin Adler.

Source/WebCore:

Avoid the conversion to 16bits when we are in the ASCII fast path,
otherwise fallback to the Unicode testing in 16bits.

  • dom/Document.cpp:

(WebCore::isValidNameASCII):
(WebCore::Document::isValidName):

LayoutTests:

Add tests for valid and invalid names for nodes.

  • fast/dom/Document/createElement-invalid-names-expected.txt: Added.
  • fast/dom/Document/createElement-invalid-names.html: Added.
  • fast/dom/Document/createElement-valid-names-expected.txt: Added.
  • fast/dom/Document/createElement-valid-names.html: Added.

12/18/11:

23:15 Changeset [103221] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

REGRESSION(r101445): [JSC] Generated code for custom getters and setters
with the [Supplemental] IDL is wrong
https://bugs.webkit.org/show_bug.cgi?id=74837

Reviewed by Darin Adler.

In bug 73162, we implemented the [Supplemental] IDL, but the generated code
for custom getters and setters was wrong in JSC. This patch fixes CodeGeneratorJS.pm
so that the result of WebCore/bindings/scripts/test/TestInterface.idl becomes as follows:

Wrong:

JSValue jsTestInterfaceStr3(ExecState* exec, JSValue slotBase, const Identifier&)
{

JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));
return JSTestSupplemental::str3(castedThis, exec);

}

Correct:

JSValue jsTestInterfaceStr3(ExecState* exec, JSValue slotBase, const Identifier&)
{

JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));
TestInterface* imp = static_cast<TestInterface*>(castedThis->impl());
return castedThis->str3(imp, exec);

}

Tests: bindings/scripts/test/JS/TestInterface.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests result.

(WebCore::jsTestInterfaceStr3):
(WebCore::setJSTestInterfaceStr3):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
22:59 Changeset [103220] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

A test that mutation happens when asynchronous spell checking is in process.
https://bugs.webkit.org/show_bug.cgi?id=72940

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-18
Reviewed by Hajime Morita.

Added a test that mutation happens when spellchecking.
This test confirms crash won't happen, and how markers are used.

  • editing/spelling/spellcheck-async-mutation-expected.txt: Added.
  • editing/spelling/spellcheck-async-mutation.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
22:39 Changeset [103219] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix typo in comment.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

22:36 Changeset [103218] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG is too sloppy with register allocation
https://bugs.webkit.org/show_bug.cgi?id=74835

Reviewed by Gavin Barraclough.

Added assertions that at the end of a successfully generated basic block,
all use counts should be zero. This revealed a number of bugs:

  • Array length optimizations were turning a must-generate node into one that is not must-generate, but failing to change the ref count accordingly.


  • Indexed property storage optimizations were failing to deref their children, or to deref the indexed property storage node itself. Also, they used the Phantom node as a replacement. But the Phantom node is must-generate, which was causing bizarre issues. So this introduces a Nop node, which should be used in cases where you want a node that is skipped and has no children.


This does not have any significant performance effect, but it should
relieve some register pressure. The main thing this patch adds, though,
are the assertions, which should make it easier to do register allocation
related changes in the future.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::use):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGNode.h:

(JSC::DFG::Node::deref):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

22:26 Changeset [103217] by darin@apple.com
  • 6 edits
    2 copies
    8 moves
    1 add
    1 delete in trunk/LayoutTests

Fixed some test expectations the best I could using my Lion machine.
Some of these may require additional tuning.

  • fast/dom/Window/script-tests/window-property-descriptors.js: Added webkitNotifications to the list of properties

to not dump, since it's different in different configurations. Also re-sorted the list and improved comments.

  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
  • platform/mac/fast/dom/Window/window-properties-expected.txt: Updated for the change in WebKitCSSFilterValue constants.
  • platform/win/fast/dom/Window/window-properties-expected.txt: Ditto.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt: Removed.
  • platform/mac-snowleopard/printing: Removed.
  • platform/mac-snowleopard/printing/width-overflow-expected.png: Removed.
  • platform/mac-snowleopard/printing/width-overflow-expected.txt: Removed.
  • platform/mac/fast/regions/region-style-block-background-color-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png.
  • platform/mac/fast/regions/region-style-block-background-color-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt.
  • platform/mac/fast/regions/region-style-block-background-color2-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png.
  • platform/mac/fast/regions/region-style-block-background-color2-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt.
  • platform/mac/fast/regions/region-style-image-background-color-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png.
  • platform/mac/fast/regions/region-style-image-background-color-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt.
  • platform/mac/fast/regions/region-style-inline-background-color-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png.
  • platform/mac/fast/regions/region-style-inline-background-color-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt.
  • platform/mac/printing/width-overflow-expected.png: Copied from platform/mac-snowleopard/printing/width-overflow-expected.png.
  • platform/mac/printing/width-overflow-expected.txt: Copied from platform/mac-snowleopard/printing/width-overflow-expected.txt.

Moved these test results from mac-snowleopard to mac. There's no reason to assume the results are
different post-Snow-Leopard.

  • platform/mac/fast/text/unicode-variation-selector-expected.txt: Added.

Landed the result generated on my computer.

21:47 Changeset [103216] by morrita@google.com
  • 1 edit
    16 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win-xp/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug2479-4-expected.png: Added.
21:22 Changeset [103215] by keishi@webkit.org
  • 10 edits
    5 copies
    1 move in trunk/Source

Implement <input type=color> UI WebKit chromium part
https://bugs.webkit.org/show_bug.cgi?id=65897

Reviewed by Darin Fisher.

Source/WebCore:

  • GNUmakefile.list.am: Removed ColorChooser.cpp and added ColorChooserClient.h
  • WebCore.gypi: Added ColorChooser.h and ColorChooserClient.h
  • WebCore.xcodeproj/project.pbxproj: Removed ColorChooser.cpp and added ColorChooserClient.h

Source/WebKit/chromium:

  • WebKit.gyp: Added new files.
  • features.gypi: Added ENABLE_INPUT_COLOR.
  • public/WebColorChooser.h: Added. Interface for ColorChooserProxy to call.

(WebKit::WebColorChooser::~WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):

  • public/WebColorChooserClient.h: Added.

(WebKit::WebColorChooserClient::~WebColorChooserClient):
(WebKit::WebColorChooserClient::didChooseColor): Only called when user changes the color.
(WebKit::WebColorChooserClient::didEndChooser): Called when WebColorChooser::endChooser is called.

  • public/WebViewClient.h:

(WebKit::WebViewClient::createColorChooser): Creates a new color chooser. If there is an old color chooser, this will end it.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createColorChooser): Calls WebViewClient::createColorChooser.

  • src/ChromeClientImpl.h:
  • src/ColorChooserProxy.cpp: Proxies calls to WebCore::ColorChooser to WebKit::WebColorChooser.

(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):

  • src/ColorChooserProxy.h:
  • src/WebColorChooserClientImpl.cpp: Proxies calls to WebKit::WebColorChooserClient to WebCore::ColorChooserClient.

(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):

  • src/WebColorChooserClientImpl.h: Added.
21:06 Changeset [103214] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
20:25 Changeset [103213] by commit-queue@webkit.org
  • 20 edits in trunk

<msup>, <munder>, <mover>, and <munderover> baseline positions are wrong
https://bugs.webkit.org/show_bug.cgi?id=72821

Patch by David Barton <dbarton@mathscribe.com> on 2011-12-18
Reviewed by Darin Adler.

Source/WebCore:

Tested by rebaselining 8 existing tests. (Pardon the pun.)

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):
Just using the base's (these puns are not my fault) baseline did not leave room for the exponent.

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::baselinePosition):
Added a guard condition, and removed some bad lines apparently mistakenly copied from RenderMathMLSubSup.cpp.

LayoutTests:

  • platform/mac/mathml/presentation/msup-base-changed-expected.png:
  • platform/mac/mathml/presentation/msup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msup-sup-changed-expected.png:
  • platform/mac/mathml/presentation/msup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:
19:50 Changeset [103212] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSS line-height property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74561

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isNumber):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeight::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

19:27 Changeset [103211] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSS outline shorthand property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74467

Reviewed by Andreas Kling.

No new tests / refactoring only.

RenderStyle::resetOutline was removed in favor of explicity expanding to the
initial values of the shorthand expansion. This improves consistency because
the initial values to use are more clearly (and singularly) defined.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:
19:13 Changeset [103210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r103205.
http://trac.webkit.org/changeset/103205
https://bugs.webkit.org/show_bug.cgi?id=74833

There are valid characters above 0x80 when the string is
8bits (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-18

  • dom/Document.cpp:

(WebCore::isValidNameASCII):
(WebCore::Document::isValidName):

19:07 Changeset [103209] by macpherson@chromium.org
  • 9 edits in trunk/Source/WebCore

Separate box alignment and box pack values into separate enums.
https://bugs.webkit.org/show_bug.cgi?id=74580

Reviewed by Andreas Kling.

No new tests / refactoring only.

Separating these types cleans up the code by removing several assertions that
values are in the correct ranges, as this is ensured by the type system.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

  • rendering/RenderFullScreen.cpp:

(createFullScreenStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::boxPack):
(WebCore::InheritedFlags::setBoxAlign):
(WebCore::InheritedFlags::setBoxPack):
(WebCore::InheritedFlags::initialBoxPack):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleDeprecatedFlexibleBoxData.h:
19:01 Changeset [103208] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSS font-size property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74368

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontSize::largerFontSize):
(WebCore::ApplyPropertyFontSize::smallerFontSize):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontSize::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::hasParentNode):

18:59 Changeset [103207] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r103199.
http://trac.webkit.org/changeset/103199
https://bugs.webkit.org/show_bug.cgi?id=74832

Caused a bot crashiness extravaganza! (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-18

  • platform/KURL.cpp:

(WebCore::isLetterMatchIgnoringCase):
(WebCore::protocolIs):

18:51 Changeset [103206] by mitz@apple.com
  • 3 edits
    3 adds in trunk

Positioned Floats: Assertion hit in fast/block/positioning/positioned-float-layout-after-image-load.html
https://bugs.webkit.org/show_bug.cgi?id=67759

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/block/positioning/positioned-float-layout-after-image-load.html

Positioned floats are both floating and positioned. Made the following functions treat them as
positioned rather than as floats by reordering code.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

Re-added this test from r94695.

  • fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Copied from LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load-expected.txt.
  • fast/block/positioning/positioned-float-layout-after-image-load.html: Copied from LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load.html.
  • fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Copied from LayoutTests/fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html.
18:17 Changeset [103205] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Add support for 8 bits strings to Document::isValidName()
https://bugs.webkit.org/show_bug.cgi?id=74784

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-18
Reviewed by Andreas Kling.

The valid name has a fast path for ASCII, and a slow path
taking Unicode characters into account.

For 8-bit strings, we don't need to take the non-ASCII path
as it could never succeed if the ASCII path didn't.

  • dom/Document.cpp:

(WebCore::isValidNameASCII):
(WebCore::Document::isValidName):

18:13 Changeset [103204] by morrita@google.com
  • 17 edits
    3 moves
    14 deletes in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-cg-mac-snowleopard/fast/text/drawBidiText-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/text/drawBidiText-expected.png.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png.
  • platform/chromium-win-vista/fast/text/drawBidiText-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/chromium-win-vista/svg/text/bidi-tspans-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt:
  • platform/chromium-win-vista/tables/mozilla/bugs/bug2479-4-expected.png: Removed.
18:07 Changeset [103203] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove redundant m_glWidget->makeCurrent() calls in GraphicsContext3DQt.
https://bugs.webkit.org/show_bug.cgi?id=73814

It causes a performance hit.
Moved the redundant function calls to makeContextCurrent().

Patch by Huang Dongsung <luxtella@company100.net> on 2011-12-18
Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::paint):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):

18:03 Changeset [103202] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove the duplicated code from ASCIICType.h
https://bugs.webkit.org/show_bug.cgi?id=74771

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-18
Reviewed by Andreas Kling.

Use isASCIIDigit() and isASCIIAlpha() instead of copying the code.

  • wtf/ASCIICType.h:

(WTF::isASCIIDigit):
(WTF::isASCIIAlphanumeric):
(WTF::isASCIIHexDigit):

17:47 Changeset [103201] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Removing unrelated printf() that slipped into my last commit.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):

17:43 Changeset [103200] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Another attempt to fix the windows build.

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::performWorkOnRegisteredWorkThread):
(WorkQueue::dispatch):

17:40 Changeset [103199] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

KURL::protocolIs() should handle 8-bit strings.
<http://webkit.org/b/74827>

Reviewed by Antti Koivisto.

  • platform/KURL.cpp:

(WebCore::isLetterMatchIgnoringCase):

Turned this into a template method so it can be used for both UChar and LChar.

(WebCore::charactersAreProtocol):
(WebCore::protocolIs):

Handle 8/16 bit strings separately to avoid conversion.

17:27 Changeset [103198] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the windows build.

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::performWorkOnRegisteredWorkThread):

17:12 Changeset [103197] by aboxhall@chromium.org
  • 6 edits in trunk

Make AccessibilityObject::lineForPosition return the correct value for cases where the position is not within the current object.
https://bugs.webkit.org/show_bug.cgi?id=71348

Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::lineForPosition):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • accessibility/textarea-insertion-point-line-number-expected.txt:
  • accessibility/textarea-insertion-point-line-number.html:
16:42 Changeset [103196] by weinig@apple.com
  • 13 edits in trunk/Source/WebCore

Make EventHandler::handleWheelEvent take const PlatformWheelEvent&
https://bugs.webkit.org/show_bug.cgi?id=74824

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:
  • page/blackberry/EventHandlerBlackBerry.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/wx/EventHandlerWx.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::copyTurningVerticalTicksIntoHorizontalTicks):

16:37 Changeset [103195] by koz@chromium.org
  • 10 edits in trunk/Source

[chromium] Add worldId parameter to allowScriptExtension()
https://bugs.webkit.org/show_bug.cgi?id=74214

Chromium uses the worldId to determine what extension is running in a
v8 context and knowing that at the time allowScriptExtension() is
called allows us to conditionally inject extension APIs.

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):
(WebCore::V8DOMWindowShell::createNewContext):

  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::allowScriptExtension):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowScriptExtension):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScriptExtension):

  • src/FrameLoaderClientImpl.h:
16:37 Changeset [103194] by weinig@apple.com
  • 15 edits
    1 delete in trunk/Source/WebKit2

Remove now unused WorkItem.h
https://bugs.webkit.org/show_bug.cgi?id=74818

Reviewed by Andreas Kling.

  • GNUmakefile.am:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/RunLoop.cpp:
  • Platform/RunLoop.h:
  • Platform/WorkItem.h: Removed.
  • Platform/gtk/RunLoopGtk.cpp:
  • Platform/mac/RunLoopMac.mm:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::platformInvalidate):

  • Platform/qt/RunLoopQt.cpp:
  • Platform/win/RunLoopWin.cpp:
  • Target.pri:
  • UIProcess/ResponsivenessTimer.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • win/WebKit2.vcproj:
16:29 Changeset [103193] by abarth@webkit.org
  • 6 edits in trunk

Adoption agency iteration limits in HTML parser don't match HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=74822

Reviewed by Eric Seidel.

Source/WebCore:

Previously, we were using the iteration limits from the old tree
builder. Now we use the iteration limits from the HTML5 specification.

Tests: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

Show test progression.

  • fast/parser/residual-style-dom-expected.txt:
  • html5lib/runner-expected.txt:
  • platform/chromium/html5lib/runner-expected.txt:
15:47 Changeset [103192] by antti@apple.com
  • 5 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=73954
REGRESSION (r97745): Transitions don't work on links

Source/WebCore:

Reviewed by Andreas Kling.

Test: transitions/visited-link-color.html

Since visited link colors are now part of the RenderStyle, they need to be transitioned
along with the corresponding regular colors.

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::PropertyWrapperVisitedAffectedColor::equals):
(WebCore::PropertyWrapperVisitedAffectedColor::blend):
(WebCore::AnimationBase::ensurePropertyMap):

Add new wrapper class that applies both regular and visited color.


  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::visitedLinkColor):
(WebCore::InheritedFlags::visitedLinkBackgroundColor):
(WebCore::InheritedFlags::visitedLinkBorderLeftColor):
(WebCore::InheritedFlags::visitedLinkBorderRightColor):
(WebCore::InheritedFlags::visitedLinkBorderBottomColor):
(WebCore::InheritedFlags::visitedLinkBorderTopColor):
(WebCore::InheritedFlags::visitedLinkOutlineColor):
(WebCore::InheritedFlags::visitedLinkColumnRuleColor):
(WebCore::InheritedFlags::visitedLinkTextEmphasisColor):
(WebCore::InheritedFlags::visitedLinkTextFillColor):
(WebCore::InheritedFlags::visitedLinkTextStrokeColor):

Add accessors.


  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

Opportunistic fix. Don't know how to test.

LayoutTests:

Reviewed by Andreas Kling.

Unfortunately the automatic test provides code coverage only as reading back the properties
from the style always gives back non-visited values. The bug is visible running the test
manually.

  • transitions/visited-link-color-expected.txt: Added.
  • transitions/visited-link-color.html: Added.
14:28 Changeset [103191] by andersca@apple.com
  • 8 edits in trunk/Source

Set the main frame view scroll position asynchronously
https://bugs.webkit.org/show_bug.cgi?id=74823

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Source/WebCore:

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Initialize m_didDispatchDidUpdateMainFrameScrollPosition to false.

(WebCore::ScrollingCoordinator::didUpdateMainFrameScrollPosition):
Get the scroll position, reset m_didDispatchDidUpdateMainFrameScrollPosition to false and
then call FrameView::setScrollOffset to update the scroll position.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
Update the scroll position and dispatch ScrollingCoordinator::didUpdateMainFrameScrollPosition on
the main thread if needed.

Source/WebKit2:

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Don't make the background red.

14:21 Changeset [103190] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

JSC/HTMLCollection: Optimize canGetItemsForName().
<http://webkit.org/b/74806>

Reviewed by Sam Weinig.

Add HTMLCollection::hasNamedItem(name) and use that in the JSC bindings'
canGetItemsForName() instead of fetching the list of named items just to
check if it's empty or not.

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::JSHTMLAllCollection::canGetItemsForName):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::canGetItemsForName):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::hasNamedItem):

  • html/HTMLCollection.h:
13:54 Changeset [103189] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Spruce up PlatformWheelEvent a bit
https://bugs.webkit.org/show_bug.cgi?id=74821

Reviewed by Dan Bernstein.

  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::directionInvertedFromDevice):
Remove x/y getters in favor of direct access to the IntPoints, and rename
webkitDirectionInvertedFromDevice() to directionInvertedFromDevice() since
it is not an exposed API.

13:49 Changeset [103188] by hausmann@webkit.org
  • 4 edits
    2 moves in trunk

Rename EditCommandQt to UndoStepQt
https://bugs.webkit.org/show_bug.cgi?id=74754

Reviewed by Ryosuke Niwa.

.:

  • Source/api.pri:

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::registerUndoStep):

  • WebCoreSupport/UndoStepQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/EditCommandQt.cpp.

(UndoStepQt::UndoStepQt):
(UndoStepQt::~UndoStepQt):
(UndoStepQt::redo):
(UndoStepQt::undo):

  • WebCoreSupport/UndoStepQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/EditCommandQt.h.
13:41 Changeset [103187] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Scroll the main frame on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=74820

Reviewed by Andreas Kling.

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::handleWheelEvent):
Compute a scroll offset from the wheel event and tell the scrolling thread to scroll by the given offset.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
Clamp the updated position to the minimum and maximum scrollable position.

(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPositionOnScrollingThread):
Actually reposition the layer.

12:43 Changeset [103186] by kling@webkit.org
  • 7 edits
    2 adds in trunk

HTMLAllCollection: Get rid of stateful namedItem traversal.
<http://webkit.org/b/74803>

Reviewed by Sam Weinig.

Source/WebCore:

Add a namedItemWithIndex() function to HTMLAllCollection to cover the
document.all(name, index) use-case. This moves the collection traversal
into WebCore and allows us to remove some complexity.

This incidentally fixes a bug where the CollectionCache would point to
the last node returned by document.all(name, index) without the correct
associated node index (because info()->current was getting set without
updating info()->position.) Added a layout test for that.

Test: fast/dom/htmlallcollection-call-with-index-caching-bug.html

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

Replace collection traversal by calls to namedItemWithIndex().

  • html/HTMLCollection.h:

Promoted updateNameCache() to protected (for HTMLAllCollection.)
Demoted checkForNameMatch() to private.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

Added for document.all(name, index). Uses the name/id cache.

  • html/HTMLAllCollection.cpp:
  • html/HTMLAllCollection.h:

(WebCore::HTMLAllCollection::HTMLAllCollection):

Removed m_idsDone, HTMLAllCollection is now stateless.

LayoutTests:

  • fast/dom/htmlallcollection-call-with-index-caching-bug-expected.txt: Added.
  • fast/dom/htmlallcollection-call-with-index-caching-bug.html: Added.
12:27 Changeset [103185] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

The scrolling coordinator should know about the main frame scroll layer
https://bugs.webkit.org/show_bug.cgi?id=74817

Reviewed by Andreas Kling.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingThread::threadCallback):
Move the * to where it belongs.

(WebCore::ScrollingCoordinator::setFrameScrollLayer):
Keep track of the underlying CALayer of the frame scroll layer.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::ensureRootLayer):
Call ScrollingCoordinator::setFrameScrollLayer.

12:09 Changeset [103184] by kling@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Correct ChangeLog author mixup.

12:07 Changeset [103183] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Interacting with GMail message lists is sluggish.
<http://webkit.org/b/74813>

Patch by Anders Carlsson <andersca@apple.com> on 2011-12-18
Reviewed by Dan Bernstein.

Add an argument to collapsed*Border() to control whether the border
color is computed or not. This allows us to avoid expensive work when
we're only interested in the metrics.

RenderStyle::visitedDependentColor() was very hot (4.5%) when hit-testing
on GMail and this removes its usage altogether.
This should be an improvement for table rendering as well, since it was
all happening below RenderBox::overflowClipRect().

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):

Add and propagate an IncludeBorderColorOrNot argument that decides
whether we compute the CollapsedBorderValue's color.

(WebCore::RenderTableCell::collapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder):

Renamed start & end to startColorProperty & endColorProperty
for clarity. Also same modifications as the above functions.

(WebCore::RenderTableCell::collapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder):

Renamed before & after to beforeColorProperty & afterColorProperty
for clarity. Also same modifications as the above functions.

(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):

Pass DoNotIncludeBorderColor to collapsed*Border() since we only care
about the metrics here.

11:52 Changeset [103182] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

The scrolling coordinator should keep track of the main frame geometry
https://bugs.webkit.org/show_bug.cgi?id=74816

Reviewed by Andreas Kling.

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::syncFrameGeometry):
Update the frame geometry accordingly when it changes.

  • page/ScrollingCoordinator.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Call ScrollingCoordinator::syncFrameGeometry.

(WebCore::RenderLayerCompositor::scrollingCoordinator):
Add new getter.

11:45 Changeset [103181] by weinig@apple.com
  • 25 edits in trunk/Source

Move timestamp down from PlatformEvent subclasses to the base class
https://bugs.webkit.org/show_bug.cgi?id=74805

Reviewed by Anders Carlsson.

../WebCore:

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::type):
(WebCore::PlatformEvent::timestamp):
(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::clickCount):

  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/efl/PlatformMouseEventEfl.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/efl/PlatformTouchEventEfl.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/efl/PlatformWheelEventEfl.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/qt/WheelEventQt.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/win/KeyEventWin.cpp:

(WebCore::singleCharacterString):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/win/WheelEventWin.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/wx/KeyboardEventWx.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/wx/MouseEventWx.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/wx/MouseWheelEventWx.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit2:

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):

10:56 Changeset [103180] by andersca@apple.com
  • 7 edits
    1 add in trunk/Source

Add a scrolling thread to the scrolling coordinator
https://bugs.webkit.org/show_bug.cgi?id=74814

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:

Export ScrollingCoordinator::handleWheelEvent.

  • WebCore.xcodeproj/project.pbxproj:

Add ScrollingCoordinatorMac.mm

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::handleWheelEvent):
Add a stub function.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm: Added.

Add a ScrollingThread object which creates a thread and attaches a run loop source
to it, allowing for functions to be dispatched and run on said thread.

(WebCore::ScrollingCoordinator::isScrollingThread):
Call ScrollingThread::isCurrentThread.

(WebCore::ScrollingCoordinator::dispatchOnScrollingThread):
Call ScrollingThread::dispatch.

Source/WebKit2:

Check if the scrolling coordinator can handle the wheel event before dispatching it
to the main thread.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

10:01 Changeset [103179] by andersca@apple.com
  • 7 edits in trunk/Source

EventDispatcher should keep track of all scrolling coordinators
https://bugs.webkit.org/show_bug.cgi?id=74810

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingCoordinatorForPage):
Get the scrolling coordinator from the WebCore page and add it to the map.

(WebKit::EventDispatcher::removeScrollingCoordinatorForPage):
Remove the scrolling coordinator from the map.

(WebKit::EventDispatcher::sendDidHandleEvent):
Add a new helper function, currently unused.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add the scrolling coordinator.

(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
Remove the scrolling coordinator.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::eventDispatcher):
Add a getter.

09:06 Changeset [103178] by andersca@apple.com
  • 16 edits in trunk/Source/WebKit2

Move everyone off of WorkItem
https://bugs.webkit.org/show_bug.cgi?id=74773

Reviewed by Darin Adler.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::open):

  • Platform/RunLoop.cpp:

(RunLoop::performWork):
(RunLoop::dispatch):

  • Platform/RunLoop.h:
  • Platform/WorkQueue.cpp:
  • Platform/WorkQueue.h:

(WorkQueue::WorkItemWin::function):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::registerEventSourceHandler):
(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::executeFunction):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::WorkItemQt::WorkItemQt):
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

  • Platform/win/RunLoopWin.cpp:

(RunLoop::wakeUp):

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::WorkItemWin::WorkItemWin):
(WorkQueue::WorkItemWin::create):
(WorkQueue::HandleWorkItem::HandleWorkItem):
(WorkQueue::HandleWorkItem::createByAdoptingHandle):
(WorkQueue::registerHandle):
(WorkQueue::dispatch):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/mac/CoreIPCClientRunLoop.mm:

(WebKit::callOnCoreIPCClientRunLoopAndWait):

08:39 Changeset [103177] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add transform function completion to web-inspector

Web Inspector: Auto-complete transform functions for -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=74730

Patch by Raul Hudea <rhudea@adobe.com> on 2011-12-18
Reviewed by Pavel Feldman.

No new test. Trivial change.

  • inspector/front-end/CSSKeywordCompletions.js:
07:24 Changeset [103176] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: chromium profiler: change default root type for retaining paths from GC Roots to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=74697

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):

07:13 Changeset [103175] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: move heap data stats to separate tab.
https://bugs.webkit.org/show_bug.cgi?id=74704

Reviewed by Pavel Feldman.

  • inspector/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

07:05 Changeset [103174] by loislo@chromium.org
  • 9 edits in trunk

Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp, InspectorDOMAgent.cpp, InspectorDebuggerAgent.cpp, ScriptCallFrame.cpp
https://bugs.webkit.org/show_bug.cgi?id=74549

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-18
Reviewed by Pavel Feldman.

Source/WebCore:

Work with InspectorObject is replaced with type-safe generated API
usage.
Inspector.json and Inspector-0.1.json are also changed to better
reflect data types that are actually being transmitted.

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::addToFrontend):

  • inspector/Inspector-0.1.json:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resolveBreakpoint):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::buildInspectorObject):

LayoutTests:

Expected file modified as JSON properties are now in different
order.

  • inspector/protocol/console-agent-expected.txt:
06:54 Changeset [103173] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: use generated types in method parameters
https://bugs.webkit.org/show_bug.cgi?id=74661

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-18
Reviewed by Pavel Feldman.

Type binding object is added to raw_type object.

  • inspector/CodeGeneratorInspector.py:

(TypeBindings.create_for_named_type_declaration.EnumBinding.generate_type_builder):
(TypeBindings.create_for_named_type_declaration.EnumBinding.get_in_c_type_text):
(TypeBindings.create_for_named_type_declaration.EnumBinding):
(TypeBindings.create_for_named_type_declaration.EnumBinding.reduce_to_raw_type):
(TypeBindings.create_for_named_type_declaration.PlainString.generate_type_builder):
(TypeBindings.create_for_named_type_declaration.PlainString.reduce_to_raw_type):
(TypeBindings.create_for_named_type_declaration.PlainString):
(TypeBindings.create_for_named_type_declaration.PlainString.get_in_c_type_text):
(TypeBindings):
(TypeBindings.create_for_named_type_declaration.ClassBinding):
(get_in_c_type_text):
(reduce_to_raw_type):
(PlainObjectBinding.generate_type_builder):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding):
(PlainObjectBinding.reduce_to_raw_type):
(RawTypesBinding.generate_type_builder):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding):
(RawTypesBinding.reduce_to_raw_type):
(resolve_param_type.RawTypeBinding.reduce_to_raw_type):
(resolve_param_type.RawTypeBinding):
(resolve_param_type.RawTypeBinding.get_in_c_type_text):
(resolve_param_type):
(Generator.process_event):

06:46 Changeset [103172] by loislo@chromium.org
  • 8 edits
    1 move
    5 deletes in trunk/Source

Unreviewed, rolling out r103169.
http://trac.webkit.org/changeset/103169
https://bugs.webkit.org/show_bug.cgi?id=74809

it broke compilation on many platforms (Requested by loislo_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-18

Source/WebCore:

  • WebCore.gypi:
  • platform/ColorChooser.cpp: Renamed from Source/WebKit/chromium/src/ColorChooserProxy.h.

(WebCore::ColorChooserClient::~ColorChooserClient):
(WebCore::ColorChooserClient::newColorChooser):
(WebCore::ColorChooserClient::discardChooser):
(WebCore::ColorChooser::ColorChooser):
(WebCore::ColorChooser::create):
(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::didChooseColor):
(WebCore::ColorChooser::didCleanup):

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebColorChooser.h: Removed.
  • public/WebColorChooserClient.h: Removed.
  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
  • src/ColorChooserProxy.cpp: Removed.
  • src/WebColorChooserClientImpl.cpp: Removed.
  • src/WebColorChooserClientImpl.h: Removed.
06:43 Changeset [103171] by haraken@chromium.org
  • 2 edits in trunk/Tools

REGRESSION(r103149): prepare-ChangeLog outputs a warning
https://bugs.webkit.org/show_bug.cgi?id=74808

Reviewed by David Kilzer.

Added the prototype declaration of main() to avoid warning messages.
Sorted subroutine declarations in the alphabetical order.

  • Scripts/prepare-ChangeLog:
03:02 Changeset [103170] by achicu@adobe.com
  • 20 edits
    1 copy
    12 adds in trunk

[CSS Shaders] Add FECustomFilter that renders custom filters
https://bugs.webkit.org/show_bug.cgi?id=73317

Source/WebCore:

Using a GraphicsContext3D to render the shaders in GPU, read the
result back and use it in the software filters pipeline.

Reviewed by Chris Marrin.

Test: css3/filters/effect-custom.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::CachedShader):
(WebCore::CachedShader::shaderString):
(WebCore::CachedShader::data):

  • loader/cache/CachedShader.h:
  • platform/graphics/filters/CustomFilterMesh.cpp: Added.

(WebCore::MeshGenerator::MeshGenerator):
(WebCore::MeshGenerator::vertices):
(WebCore::MeshGenerator::indices):
(WebCore::MeshGenerator::points):
(WebCore::MeshGenerator::pointsCount):
(WebCore::MeshGenerator::tiles):
(WebCore::MeshGenerator::tilesCount):
(WebCore::MeshGenerator::indicesCount):
(WebCore::MeshGenerator::floatsPerVertex):
(WebCore::MeshGenerator::vertexCount):
(WebCore::MeshGenerator::addTile):
(WebCore::MeshGenerator::addAttachedMeshIndex):
(WebCore::MeshGenerator::generateAttachedMesh):
(WebCore::MeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::MeshGenerator::generateDetachedMesh):
(WebCore::MeshGenerator::addPositionAttribute):
(WebCore::MeshGenerator::addTexCoordAttribute):
(WebCore::MeshGenerator::addMeshCoordAttribute):
(WebCore::MeshGenerator::addTriangleCoordAttribute):
(WebCore::MeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::MeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::MeshGenerator::dumpBuffers):
(WebCore::CustomFilterMesh::CustomFilterMesh):
(WebCore::CustomFilterMesh::~CustomFilterMesh):

  • platform/graphics/filters/CustomFilterMesh.h: Added.

(WebCore::CustomFilterMesh::create):
(WebCore::CustomFilterMesh::verticesBufferObject):
(WebCore::CustomFilterMesh::bytesPerVertex):
(WebCore::CustomFilterMesh::elementsBufferObject):
(WebCore::CustomFilterMesh::indicesCount):
(WebCore::CustomFilterMesh::meshBox):
(WebCore::CustomFilterMesh::meshType):

  • platform/graphics/filters/CustomFilterShader.cpp: Added.

(WebCore::CustomFilterShader::defaultVertexShaderString):
(WebCore::CustomFilterShader::defaultFragmentShaderString):
(WebCore::CustomFilterShader::CustomFilterShader):
(WebCore::CustomFilterShader::~CustomFilterShader):

  • platform/graphics/filters/CustomFilterShader.h: Added.
  • platform/graphics/filters/FECustomFilter.cpp: Added.

(WebCore::orthoMatrix):
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::dump):
(WebCore::FECustomFilter::externalRepresentation):

  • platform/graphics/filters/FECustomFilter.h: Added.
  • platform/graphics/gpu/Texture.cpp:
  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::toColumnMajorFloatArray):

  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/FilterEffectObserver.h: Copied from Source/WebCore/loader/cache/CachedShader.cpp.

(WebCore::FilterEffectObserver::~FilterEffectObserver):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::isWebGLEnabled):
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::notifyFinished):

  • rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::create):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::filterNeedsRepaint):

  • rendering/RenderLayer.h:
  • rendering/style/StyleCachedShader.h:

(WebCore::StyleCachedShader::cachedShader):

  • rendering/style/StyleShader.h:

(WebCore::StyleShader::cachedShader):

LayoutTests:

WebKit2 doesn't support the WebGL flag in layoutTestController.overridePreference.
Skipping the test like all the other WebGL tests do.

Reviewed by Chris Marrin.

  • css3/filters/effect-custom-expected.png: Added.
  • css3/filters/effect-custom-expected.txt: Added.
  • css3/filters/effect-custom.html: Added.
  • css3/filters/resources/color-offset.fs: Added.
  • css3/filters/resources/vertex-explode-detached.vs: Added.
  • css3/filters/resources/vertex-offset.vs: Added.
  • platform/wk2/Skipped: Skipping the test until WebGL can be enabled from layoutTestController.
02:37 Changeset [103169] by keishi@webkit.org
  • 8 edits
    5 copies
    1 move in trunk/Source

Implement <input type=color> UI WebKit chromium part
https://bugs.webkit.org/show_bug.cgi?id=65897

Reviewed by Darin Fisher.

Source/WebCore:

  • WebCore.gypi: Added ColorChooser.h and ColorChooserClient.h

Source/WebKit/chromium:

  • WebKit.gyp: Added new files.
  • features.gypi: Added ENABLE_INPUT_COLOR.
  • public/WebColorChooser.h: Added. Interface for ColorChooserProxy to call.

(WebKit::WebColorChooser::~WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):

  • public/WebColorChooserClient.h: Added.

(WebKit::WebColorChooserClient::~WebColorChooserClient):
(WebKit::WebColorChooserClient::didChooseColor): Only called when user changes the color.
(WebKit::WebColorChooserClient::didEndChooser): Called when WebColorChooser::endChooser is called.

  • public/WebViewClient.h:

(WebKit::WebViewClient::createColorChooser): Creates a new color chooser. If there is an old color chooser, this will end it.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createColorChooser): Calls WebViewClient::createColorChooser.

  • src/ChromeClientImpl.h:
  • src/ColorChooserProxy.cpp: Proxies calls to WebCore::ColorChooser to WebKit::WebColorChooser.

(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):

  • src/ColorChooserProxy.h:
  • src/WebColorChooserClientImpl.cpp: Proxies calls to WebKit::WebColorChooserClient to WebCore::ColorChooserClient.

(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):

  • src/WebColorChooserClientImpl.h: Added.

12/17/11:

23:03 Changeset [103168] by keishi@webkit.org
  • 10 edits
    1 add in trunk/Source/WebCore

Refactor input type color WebCore part
https://bugs.webkit.org/show_bug.cgi?id=74591

Reviewed by Kent Tamura.

Changing ColorChooser to address issues raised in Bug 65897.
Chrome::createColorChooser will return a WebCore::ColorChooser instance
so the WebCore side (ColorInputType) and call the WebKit side. We pass the ColorChooserClient as an argument
to Chrome::createColorChooser so the WebKit side can call callbacks, didEndChooser and didChooseColor.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::setValue):
(WebCore::ColorInputType::handleDOMActivateEvent): Calls createColorChooser to open the color chooser.
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::didEndChooser): Release the ColorChooser object.
(WebCore::ColorInputType::endColorChooser):
(WebCore::ColorInputType::updateColorSwatch): Added argument so it will compile again.

  • html/ColorInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectColorInColorChooser):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::createColorChooser):

  • loader/FrameLoader.cpp:
  • page/Chrome.cpp:

(WebCore::Chrome::createColorChooser): Opens the color chooser. Returns a ColorChooser PassOwnPtr.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.h:

(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::setSelectedColor):
(WebCore::ColorChooser::endChooser):

  • platform/ColorChooserClient.h: Added.
22:09 Changeset [103167] by weinig@apple.com
  • 13 edits in trunk/Source

Make PlatformTouchEvent inherit from PlatformEvent
https://bugs.webkit.org/show_bug.cgi?id=74777

Reviewed by Andreas Kling.

../WebCore:

  • platform/PlatformEvent.h:

Add TouchEvent types.

  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):
Make inherit from PlatformEvent.

  • platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::touchEventType):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/efl/PlatformTouchEventEfl.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/qt/PlatformTouchEventQt.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):
Make necessary changes to work with new base class.

../WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::toPlatformTouchEventType):

  • tests/InnerGestureRecognizerTest.cpp:

(BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(SimulateAndTestFirstClick):
(TouchPointAndEvent::TouchPointAndEvent):
Add PlatformEvent prefix to enum types.

../WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):
Rename TouchEventType to PlatformEvent::Type.

../WebKit2:

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
Add PlatformEvent prefix to enum types.

19:57 Changeset [103166] by kling@webkit.org
  • 12 edits in trunk

Cache and reuse the HTMLAllCollection returned by document.all.
<http://webkit.org/b/74768>

Reviewed by Antti Koivisto.

Source/WebCore:

Let Document cache the document.all collection, just like we do for
the other collections (.links, .images, etc.)
This is primarily a memory optimization, as repeated calls to
document.all will no longer cause collection objects to stack up.

Tests: fast/dom/document-collection-idempotence.html

fast/dom/gc-9.html

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::all):

Cache the HTMLAllCollection and reuse it across calls instead of
creating a new one each time.

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):

Make the HTMLAllCollection constructor take a Document* to enforce
the fact that it's the only way it should ever be created.

  • html/HTMLAllCollection.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

Custom reachability code for JSC, same as HTMLCollection.

LayoutTests:

Update tests to document the new behavior of document.all.

  • fast/dom/document-collection-idempotence-expected.txt:
  • fast/dom/document-collection-idempotence.html:
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
19:41 Changeset [103165] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLCollection: Simplify itemAfter().
<http://webkit.org/b/74795>

Reviewed by Antti Koivisto.

Whether to do deep traversal of children depends on m_type which
doesn't change after construction, so move that decision there
by caching it in a "m_includeChildren" bit.

Also factored out the big switch statement in itemAfter() into
an isAcceptableElement() function.

Last and least, use fastHasAttribute() to check for itempropAttr
since it's not SVG animatable.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
(WebCore::HTMLCollection::itemAfter):

  • html/HTMLCollection.h:
19:35 Changeset [103164] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix QtTestBrowser compilation with QtWidgets module
https://bugs.webkit.org/show_bug.cgi?id=74791

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2011-12-17
Reviewed by Andreas Kling.

  • QtTestBrowser/QtTestBrowser.pro:
19:32 Changeset [103163] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

TagNodeList: Optimize nodeMatches() for the common case.
<http://webkit.org/b/74796>

Reviewed by Antti Koivisto.

Reject based on tag name mismatch before comparing the namespaces,
as this case is vastly more common.

nodeMatches() is very hot on the DOM Query (Dojo) test on Dromaeo.
This change takes it from 8.3% to 7.7% on my MBP.

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::nodeMatches):

19:28 Changeset [103162] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

NameNodeList: Use fastGetAttribute() in nodeMatches().
<http://webkit.org/b/74797>

Reviewed by Darin Adler.

It's safe and slightly more efficient to use fastGetAttribute()
for HTMLNames::nameAttr here.

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

19:26 Changeset [103161] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSPrimitiveValue: Inline getIdent().
<http://webkit.org/b/74793>

Reviewed by Antti Koivisto.

Inline the trivial getIdent(), the same as its getFoo() siblings.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getIdent):

19:17 Changeset [103160] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Clean up matchRules().
<http://webkit.org/b/74794>

Reviewed by Antti Koivisto.

  • Early return from the isCollectingRulesOnly() path to reduce nesting.
  • Move the creation of m_ruleList out of the loop that builds the list.
  • Removed some comments from the Captain Obvious department.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchRules):

19:06 Changeset [103159] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

RuleSet: Remove style sheet null-check in addRulesFromSheet().
<http://webkit.org/b/74792>

Reviewed by Antti Koivisto.

Replace the "sheet" null-check in addRulesFromSheet() by an assertion.
The only call-site where it could be null was when adding rules from
an @import'ed sheet, so add a check there instead.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleSet::addRulesFromSheet):

19:00 Changeset [103158] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

CSSStyleSelector: Clean up getColorFromPrimitiveValue().
<http://webkit.org/b/74789>

Reviewed by Antti Koivisto.

Rename getColorFromPrimitiveValue() to colorFromPrimitiveValue() and rework
it to be a bit more readable.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::colorFromPrimitiveValue):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSStyleSelector.h:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

15:17 Changeset [103157] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

OpaqueJSClass: Remove RVCT2 workarounds.
<http://webkit.org/b/74250>

Reviewed by Benjamin Poulain.

We no longer need workarounds for the RVCT2 compiler since it was
only used for the Symbian port of WebKit which is now defunct.

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

13:19 Changeset [103156] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark svg/W3C-SVG-1.1/animate-elem* tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=74788

Unreviewed gardening.

There are only about a dozen tests that have been seen to fail on the
bots, but the set keeps changing. Rather than just marking known
failures, mark all these tests to avoid further gardening fallout.

  • platform/chromium/test_expectations.txt:
12:23 Changeset [103155] by bashi@chromium.org
  • 3 edits
    3 adds in trunk

Text dispappear when SVG font has no latin character
https://bugs.webkit.org/show_bug.cgi?id=71765

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Initialize SVG font metrics even if the font doesn't contain latin characters.

Test: svg/custom/svg-fonts-no-latin-glyph.html

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFontData): Initializes metrics even if the zeroGlyphPage doesn't exist.

LayoutTests:

Test that text can be displayed with a SVG font which has no latin character.

  • svg/custom/svg-fonts-no-latin-glyph-expected.txt: Added.
  • svg/custom/resources/no-latin-glyph-font.svg: Added.
  • svg/custom/svg-fonts-no-latin-glyph.html: Added.
12:09 Changeset [103154] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Rebaseline huge-layer-rotated after r103129.
https://bugs.webkit.org/show_bug.cgi?id=72686

Unreviewed gardening.

I don't understand why this would have changed rendering on any test,
but there are only small diffences in the lower left, so rebaselining.
It's also possible, but far less likely, that this was from r103130.

  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
11:52 Changeset [103153] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more worker tests as flaky crashers after r103095.
https://bugs.webkit.org/show_bug.cgi?id=74746

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:47 Changeset [103152] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/js/dfg-poison-fuzz.html as slow in debug.
https://bugs.webkit.org/show_bug.cgi?id=74787

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:51 Changeset [103151] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Radical sign drawn incorrectly due to refactoring typo
https://bugs.webkit.org/show_bug.cgi?id=74780

Patch by David Barton <dbarton@mathscribe.com> on 2011-12-17
Reviewed by Dan Bernstein.

LayoutTests/mathml/presentation/roots.xhtml shows the bug, but apparently its .png
checksum is ok so run-webkit-tests can't detect the problem.

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):
In revision 88250, one paintOffset should have been adjustedPaintOffset.

10:35 Changeset [103150] by enne@google.com
  • 34 edits
    2 moves
    2 deletes in trunk

[chromium] Reverting r103011, r103135 due to Aura test failures

Unreviewed gardening.

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::~ContentLayerChromium):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::notifySyncRequired):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::setMaskLayer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setRootLayer):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/platform/WebContentLayer.h:
  • public/platform/WebExternalTextureLayer.h:
  • public/platform/WebLayer.h:
  • public/platform/WebLayerClient.h:
  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::create):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::notifySyncRequired):

  • src/WebContentLayerImpl.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::create):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::notifySyncRequired):

  • src/WebExternalTextureLayerImpl.h:
  • src/WebLayer.cpp:

(WebKit::WebLayer::create):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::notifySyncRequired):

  • src/WebLayerImpl.h:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):

  • src/WebLayerTreeViewImpl.h:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::CCLayerTreeHostTestShortlived1::beginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::beginCommitOnCCThread):
(WTF::TestOpacityChangeLayerDelegate::notifySyncRequired):

  • tests/CompositorFakeGraphicsContext3D.h: Removed.
  • tests/CompositorFakeWebGraphicsContext3D.h: Removed.
  • tests/LayerChromiumTest.cpp:
  • tests/MockGraphicsContext3DTest.cpp: Renamed from Source/WebKit/chromium/tests/FakeGraphicsContext3DTest.cpp.

(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):
(TEST):
(ContextThatCountsMakeCurrents::ContextThatCountsMakeCurrents):
(ContextThatCountsMakeCurrents::makeContextCurrent):
(ContextThatCountsMakeCurrents::makeCurrentCount):
(ContextWithMakeCurrentThatFails::ContextWithMakeCurrentThatFails):
(ContextWithMakeCurrentThatFails::makeContextCurrent):

  • tests/MockWebGraphicsContext3D.h: Renamed from Source/WebKit/chromium/tests/FakeWebGraphicsContext3D.h.

(WebKit::MockWebGraphicsContext3D::initialize):
(WebKit::MockWebGraphicsContext3D::makeContextCurrent):
(WebKit::MockWebGraphicsContext3D::width):
(WebKit::MockWebGraphicsContext3D::height):
(WebKit::MockWebGraphicsContext3D::reshape):
(WebKit::MockWebGraphicsContext3D::isGLES2Compliant):
(WebKit::MockWebGraphicsContext3D::readBackFramebuffer):
(WebKit::MockWebGraphicsContext3D::getPlatformTextureId):
(WebKit::MockWebGraphicsContext3D::prepareTexture):
(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):
(WebKit::MockWebGraphicsContext3D::synthesizeGLError):
(WebKit::MockWebGraphicsContext3D::isContextLost):
(WebKit::MockWebGraphicsContext3D::mapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::mapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::setVisibilityCHROMIUM):
(WebKit::MockWebGraphicsContext3D::getRequestableExtensionsCHROMIUM):
(WebKit::MockWebGraphicsContext3D::requestExtensionCHROMIUM):
(WebKit::MockWebGraphicsContext3D::blitFramebufferCHROMIUM):
(WebKit::MockWebGraphicsContext3D::renderbufferStorageMultisampleCHROMIUM):
(WebKit::MockWebGraphicsContext3D::activeTexture):
(WebKit::MockWebGraphicsContext3D::attachShader):
(WebKit::MockWebGraphicsContext3D::bindAttribLocation):
(WebKit::MockWebGraphicsContext3D::bindBuffer):
(WebKit::MockWebGraphicsContext3D::bindFramebuffer):
(WebKit::MockWebGraphicsContext3D::bindRenderbuffer):
(WebKit::MockWebGraphicsContext3D::bindTexture):
(WebKit::MockWebGraphicsContext3D::blendColor):
(WebKit::MockWebGraphicsContext3D::blendEquation):
(WebKit::MockWebGraphicsContext3D::blendEquationSeparate):
(WebKit::MockWebGraphicsContext3D::blendFunc):
(WebKit::MockWebGraphicsContext3D::blendFuncSeparate):
(WebKit::MockWebGraphicsContext3D::bufferData):
(WebKit::MockWebGraphicsContext3D::bufferSubData):
(WebKit::MockWebGraphicsContext3D::checkFramebufferStatus):
(WebKit::MockWebGraphicsContext3D::clear):
(WebKit::MockWebGraphicsContext3D::clearColor):
(WebKit::MockWebGraphicsContext3D::clearDepth):
(WebKit::MockWebGraphicsContext3D::clearStencil):
(WebKit::MockWebGraphicsContext3D::colorMask):
(WebKit::MockWebGraphicsContext3D::compileShader):
(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):
(WebKit::MockWebGraphicsContext3D::copyTexImage2D):
(WebKit::MockWebGraphicsContext3D::copyTexSubImage2D):
(WebKit::MockWebGraphicsContext3D::cullFace):
(WebKit::MockWebGraphicsContext3D::depthFunc):
(WebKit::MockWebGraphicsContext3D::depthMask):
(WebKit::MockWebGraphicsContext3D::depthRange):
(WebKit::MockWebGraphicsContext3D::detachShader):
(WebKit::MockWebGraphicsContext3D::disable):
(WebKit::MockWebGraphicsContext3D::disableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::drawArrays):
(WebKit::MockWebGraphicsContext3D::drawElements):
(WebKit::MockWebGraphicsContext3D::enable):
(WebKit::MockWebGraphicsContext3D::enableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::finish):
(WebKit::MockWebGraphicsContext3D::flush):
(WebKit::MockWebGraphicsContext3D::framebufferRenderbuffer):
(WebKit::MockWebGraphicsContext3D::framebufferTexture2D):
(WebKit::MockWebGraphicsContext3D::frontFace):
(WebKit::MockWebGraphicsContext3D::generateMipmap):
(WebKit::MockWebGraphicsContext3D::getActiveAttrib):
(WebKit::MockWebGraphicsContext3D::getActiveUniform):
(WebKit::MockWebGraphicsContext3D::getAttachedShaders):
(WebKit::MockWebGraphicsContext3D::getAttribLocation):
(WebKit::MockWebGraphicsContext3D::getBooleanv):
(WebKit::MockWebGraphicsContext3D::getBufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getContextAttributes):
(WebKit::MockWebGraphicsContext3D::getError):
(WebKit::MockWebGraphicsContext3D::getFloatv):
(WebKit::MockWebGraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebKit::MockWebGraphicsContext3D::getIntegerv):
(WebKit::MockWebGraphicsContext3D::getProgramiv):
(WebKit::MockWebGraphicsContext3D::getProgramInfoLog):
(WebKit::MockWebGraphicsContext3D::getRenderbufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getShaderiv):
(WebKit::MockWebGraphicsContext3D::getShaderInfoLog):
(WebKit::MockWebGraphicsContext3D::getShaderSource):
(WebKit::MockWebGraphicsContext3D::getString):
(WebKit::MockWebGraphicsContext3D::getTexParameterfv):
(WebKit::MockWebGraphicsContext3D::getTexParameteriv):
(WebKit::MockWebGraphicsContext3D::getUniformfv):
(WebKit::MockWebGraphicsContext3D::getUniformiv):
(WebKit::MockWebGraphicsContext3D::getUniformLocation):
(WebKit::MockWebGraphicsContext3D::getVertexAttribfv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribiv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribOffset):
(WebKit::MockWebGraphicsContext3D::hint):
(WebKit::MockWebGraphicsContext3D::isBuffer):
(WebKit::MockWebGraphicsContext3D::isEnabled):
(WebKit::MockWebGraphicsContext3D::isFramebuffer):
(WebKit::MockWebGraphicsContext3D::isProgram):
(WebKit::MockWebGraphicsContext3D::isRenderbuffer):
(WebKit::MockWebGraphicsContext3D::isShader):
(WebKit::MockWebGraphicsContext3D::isTexture):
(WebKit::MockWebGraphicsContext3D::lineWidth):
(WebKit::MockWebGraphicsContext3D::linkProgram):
(WebKit::MockWebGraphicsContext3D::pixelStorei):
(WebKit::MockWebGraphicsContext3D::polygonOffset):
(WebKit::MockWebGraphicsContext3D::readPixels):
(WebKit::MockWebGraphicsContext3D::releaseShaderCompiler):
(WebKit::MockWebGraphicsContext3D::renderbufferStorage):
(WebKit::MockWebGraphicsContext3D::sampleCoverage):
(WebKit::MockWebGraphicsContext3D::scissor):
(WebKit::MockWebGraphicsContext3D::shaderSource):
(WebKit::MockWebGraphicsContext3D::stencilFunc):
(WebKit::MockWebGraphicsContext3D::stencilFuncSeparate):
(WebKit::MockWebGraphicsContext3D::stencilMask):
(WebKit::MockWebGraphicsContext3D::stencilMaskSeparate):
(WebKit::MockWebGraphicsContext3D::stencilOp):
(WebKit::MockWebGraphicsContext3D::stencilOpSeparate):
(WebKit::MockWebGraphicsContext3D::texImage2D):
(WebKit::MockWebGraphicsContext3D::texParameterf):
(WebKit::MockWebGraphicsContext3D::texParameteri):
(WebKit::MockWebGraphicsContext3D::texSubImage2D):
(WebKit::MockWebGraphicsContext3D::uniform1f):
(WebKit::MockWebGraphicsContext3D::uniform1fv):
(WebKit::MockWebGraphicsContext3D::uniform1i):
(WebKit::MockWebGraphicsContext3D::uniform1iv):
(WebKit::MockWebGraphicsContext3D::uniform2f):
(WebKit::MockWebGraphicsContext3D::uniform2fv):
(WebKit::MockWebGraphicsContext3D::uniform2i):
(WebKit::MockWebGraphicsContext3D::uniform2iv):
(WebKit::MockWebGraphicsContext3D::uniform3f):
(WebKit::MockWebGraphicsContext3D::uniform3fv):
(WebKit::MockWebGraphicsContext3D::uniform3i):
(WebKit::MockWebGraphicsContext3D::uniform3iv):
(WebKit::MockWebGraphicsContext3D::uniform4f):
(WebKit::MockWebGraphicsContext3D::uniform4fv):
(WebKit::MockWebGraphicsContext3D::uniform4i):
(WebKit::MockWebGraphicsContext3D::uniform4iv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix2fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix3fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix4fv):
(WebKit::MockWebGraphicsContext3D::useProgram):
(WebKit::MockWebGraphicsContext3D::validateProgram):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4fv):
(WebKit::MockWebGraphicsContext3D::vertexAttribPointer):
(WebKit::MockWebGraphicsContext3D::viewport):
(WebKit::MockWebGraphicsContext3D::createBuffer):
(WebKit::MockWebGraphicsContext3D::createFramebuffer):
(WebKit::MockWebGraphicsContext3D::createProgram):
(WebKit::MockWebGraphicsContext3D::createRenderbuffer):
(WebKit::MockWebGraphicsContext3D::createShader):
(WebKit::MockWebGraphicsContext3D::createTexture):
(WebKit::MockWebGraphicsContext3D::deleteBuffer):
(WebKit::MockWebGraphicsContext3D::deleteFramebuffer):
(WebKit::MockWebGraphicsContext3D::deleteProgram):
(WebKit::MockWebGraphicsContext3D::deleteRenderbuffer):
(WebKit::MockWebGraphicsContext3D::deleteShader):
(WebKit::MockWebGraphicsContext3D::deleteTexture):
(WebKit::MockWebGraphicsContext3D::texStorage2DEXT):

  • tests/WebGLLayerChromiumTest.cpp:

(WebKit::CompositorMockWebGraphicsContext3D::create):
(WebKit::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WebKit::CompositorMockWebGraphicsContext3D::createProgram):
(WebKit::CompositorMockWebGraphicsContext3D::createShader):
(WebKit::CompositorMockWebGraphicsContext3D::getShaderiv):
(WebKit::CompositorMockWebGraphicsContext3D::getProgramiv):
(WebKit::CompositorMockWebGraphicsContext3D::getContextAttributes):
(WebKit::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WebKit::createGraphicsContext):
(WebKit::TEST):

  • tests/WebLayerTest.cpp:

(testing::WebLayerTest::WebLayerTest):
(testing::TEST_F):

LayoutTests:

  • platform/chromium/test_expectations.txt:
10:15 Changeset [103149] by haraken@chromium.org
  • 2 edits in trunk/Tools

Remove top-level code completely from prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74698

Reviewed by Darin Adler.

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
This patch just moves all top-level code into main().

  • Scripts/prepare-ChangeLog:

(main):

09:46 Changeset [103148] by cmarrin@apple.com
  • 14 edits
    27 adds in trunk

Hardware acceleration of W3C Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=68479

Reviewed by Simon Fraser.

Tests: css3/filters/effect-blur-hw.html

css3/filters/effect-combined-hw.html
css3/filters/effect-drop-shadow-hw.html
css3/filters/effect-grayscale-hw.html
css3/filters/effect-hue-rotate-hw.html
css3/filters/effect-invert-hw.html
css3/filters/effect-opacity-hw.html
css3/filters/effect-saturate-hw.html
css3/filters/effect-sepia-hw.html

Implement hardware acceleration of filters. If a filter is
on a RenderLayer and that layer has a GraphicsLayer, a test
is done to see if the desired filter can be rendered in hardware.
If so, skip rendering it when painting, and add the filters to the
CALayer. Currently Mac only, using CoreImage. Animation is done in
software, with the filters being recreated every frame. There are
some fidelity issues with the software renderer, but those will
be dealt with as bugs to be fixed.

09:10 Changeset [103147] by bashi@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Implement PluginViewBase::getFormValue
https://bugs.webkit.org/show_bug.cgi?id=64434

Reviewed by Darin Fisher.

This patch was landed as r102873, but reverted because of Chromium Mac build failure.
The fix was landed as Chromium r114920. The patch should be safe to land.

No new tests. No behavior change at this time. We should add a test for PPAPI after chromium supports the feature.

  • public/WebPlugin.h: Added getFormValue().
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::getFormValue): Added.

  • src/WebPluginContainerImpl.h: Added getFormValue().
05:07 Changeset [103146] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=74785

  • platform/qt-5.0/Skipped: Skip fast/canvas/2d.text.draw.fill.maxWidth.gradient.html.
00:59 Changeset [103145] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r103131.

  • GNUmakefile.list.am: Fix typo... s/.cop/.cpp
Note: See TracTimeline for information about the timeline view.