Timeline


and

12/28/11:

20:33 Changeset [103792] by yuqiang.xian@intel.com
  • 7 edits in trunk/Source/JavaScriptCore

spill unboxed values in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=75291

Reviewed by Filip Pizlo.

Currently all the values are spilled as boxed in DFG 32_64, which is
not necessary and introduces additional stores/loads. Instead we
can spill them as unboxed if feasible. It can be applied to the
Integers, Cells and Booleans in DFG 32_64. Doubles are left as is
because they don't need to be boxed at all. The modifications to the
spill/fill and the OSR exit are required, as well as a bug fix to the
"isUnknownJS" logic.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::isUnknownJS):
(JSC::DFG::GenerationInfo::spill):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::isKnownNotBoolean):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::spill):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):

19:56 Changeset [103791] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Reduce memory used by NamedNodeMap.
<http://webkit.org/b/75333>

Reviewed by Sam Weinig.

Give NamedNodeMap's attribute vector an inline capacity of 4. The vast majority
of elements have <= 4 attributes, and if they don't have any we normally don't
allocate an attribute map at all.

This reduces memory consumption by 1.2MB (on 64-bit) when loading the full HTML5
spec at <http://whatwg.org/c>.

  • dom/NamedNodeMap.h:
19:54 Changeset [103790] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Reduce memory used by SpaceSplitString.
<http://webkit.org/b/75315>

Reviewed by Sam Weinig.

Split the string upon creation instead of waiting until it's accessed.
This allows us to get rid of all data members except the substring vector.
Since we're storing AtomicStrings, this is way more memory-efficient than
the previous implementation in the majority of cases.

Also reduced the inline capcity of the vector to 2 (from 8), after testing
showed this to cover 90% of the cases on the Alexa top sites.

All in all this reduces memory consumption by 1.1MB (on 64-bit) when
loading the full HTML5 spec at <http://whatwg.org/c>. On that same page,
less than 2ms is spent (on my MBP) splitting the ~20000 strings.

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::createVector):
(WebCore::SpaceSplitStringData::containsAll):
(WebCore::SpaceSplitStringData::remove):

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitStringData::contains):
(WebCore::SpaceSplitStringData::size):
(WebCore::SpaceSplitStringData::operator[]):

18:03 Changeset [103789] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
17:25 Changeset [103788] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[GTK] Fix compilation issue when selecting opengl for Accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=75309

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-12-28
Reviewed by Martin Robinson.

.:

Replace WTF_USE_TEXTURE_MAPPER_OPENGL to WTF_USE_TEXTURE_MAPPER_GL

  • GNUmakefile.am:

Source/WebCore:

Add TextureMapperGL and TextureMapperGLCairo files.
They define new classes required to implement TextureMapperGL for GTK port.

No new tests required.

  • GNUmakefile.list.am:
  • platform/graphics/cairo/TextureMapperGLCairo.cpp: Added.

(WebCore::BGRA32PremultimpliedBufferCairo::BGRA32PremultimpliedBufferCairo):
(WebCore::BGRA32PremultimpliedBufferCairo::~BGRA32PremultimpliedBufferCairo):
(WebCore::BGRA32PremultimpliedBufferCairo::beginPaint):
(WebCore::BGRA32PremultimpliedBufferCairo::data):
(WebCore::BGRA32PremultimpliedBufferCairo::endPaint):
(WebCore::uidForImage):
(WebCore::BGRA32PremultimpliedBuffer::create):

  • platform/graphics/cairo/TextureMapperGLCairo.h: Added.
17:14 Changeset [103787] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103785.
http://trac.webkit.org/changeset/103785
https://bugs.webkit.org/show_bug.cgi?id=75332

Broke builders; looks like clobbering didnt help (Requested by
dslomov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::createWorker):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
16:09 Changeset [103786] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add an implicit block conversion operator to WTF::Function
https://bugs.webkit.org/show_bug.cgi?id=75325

Reviewed by Dan Bernstein.

  • wtf/Compiler.h:

Add a define for COMPILER_SUPPORTS(BLOCKS). It's only defined for clang, since the gcc blocks implementation
is buggy, especially when it comes to C++.

  • wtf/Functional.h:

Add a block conversion operator that creates and returns an autoreleased block that will call the function when executed.

16:00 Changeset [103785] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
15:42 Changeset [103784] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r103782.
http://trac.webkit.org/changeset/103782
https://bugs.webkit.org/show_bug.cgi?id=75328

broke origin-whitelisting-removal.html (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):

15:30 Changeset [103783] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on Qt
https://bugs.webkit.org/show_bug.cgi?id=75274

Reviewed by Adam Barth.

This patch enables the [Supplemental] IDL on Qt by changing the build
flow of Qt as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • DerivedSources.pri: Described the above build flow.
14:43 Changeset [103782] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in OriginAccessMap
https://bugs.webkit.org/show_bug.cgi?id=75327

Reviewed by Andreas Kling.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):

14:08 Changeset [103781] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for ProgressTracker's items
https://bugs.webkit.org/show_bug.cgi?id=75326

Reviewed by Andreas Kling.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::~ProgressTracker): although is empty, the destructor was
kept so in the header file we can forward declare ProgressItem and use in an OwnPtr.
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress): removed a useless assignment to item
member just before it is deleted.

  • loader/ProgressTracker.h:
13:26 Changeset [103780] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-color is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75324

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for border-color.

Test: fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html: Added.
13:12 Changeset [103779] by darin@apple.com
  • 5 edits in trunk/Source/WebCore

Use OwnPtr to handle lifetime and deletion of FontFace objects
https://bugs.webkit.org/show_bug.cgi?id=75221

Reviewed by Daniel Bates.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Use add instead of get/set to read and
then later fill a cache. Use new version of registerCustomFont that takes PassOwnPtr.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Ditto.

  • dom/Document.cpp:

(WebCore::Document::registerCustomFont): Take a PassOwnPtr instead of raw pointer.

  • dom/Document.h: Ditto.
13:10 Changeset [103778] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

"Fake" insertion mode in HTMLTreeBuilder doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=75322

Reviewed by Darin Adler.

This machinery isn't needed anymore now that we're using the new
foreign content hotness.

  • html/parser/HTMLTreeBuilder.cpp:
  • html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::setInsertionMode):

13:04 Changeset [103777] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fails fast/inline/nested-text-descendants.html
https://bugs.webkit.org/show_bug.cgi?id=75321

Unreviewed, skip reference test fast/inline/nested-text-descendants.html
on Qt for now. It is the only platform that fails it.

  • platform/qt/Skipped:
12:36 Changeset [103776] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

<math><option><option></html><option></option> used to crash the parser
https://bugs.webkit.org/show_bug.cgi?id=75317

Reviewed by Eric Seidel.

Add a test so that this case continues to not crash.

  • fast/parser/math-options-crash-expected.txt: Added.
  • fast/parser/math-options-crash.html: Added.
12:18 Changeset [103775] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75312

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for border-style.

Test: fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html: Added.
12:13 Changeset [103774] by alexis.menard@openbossa.org
  • 4 edits
    2 adds in trunk

getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74743

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-top, border-bottom, border-right, border-left.

Test: fast/css/getComputedStyle/getComputedStyle-border-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):

  • css/CSSComputedStyleDeclaration.h:

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-shorthand.html: Added.
11:47 Changeset [103773] by mitz@apple.com
  • 3 edits in trunk

Entering "make" in Source builds only JavaScriptGlue and ANGLE
https://bugs.webkit.org/show_bug.cgi?id=75318

Reviewed by Anders Carlsson.

  • Makefile: Changed to make Source and Tools.
  • Source/Makefile: Changed to make all projects in Source.
11:18 Changeset [103772] by robert@webkit.org
  • 4 edits
    2 adds in trunk

Inline flow not learning height of all text descendants
https://bugs.webkit.org/show_bug.cgi?id=75305

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/inline/nested-text-descendants-expected.html

fast/inline/nested-text-descendants.html

The root inline box would only learn it had text descendants if its first grandchild
was text. It wasn't informed of subsequent text grandchildren so could not factor them
into its calculation of the line height.
To fix this, propagate the existence of a text descendant to the root inline box
by walking up through the text child's ancestors.

  • rendering/InlineFlowBox.cpp:

(WebCore::setHasTextDescendantsOnAncestors):
(WebCore::InlineFlowBox::addToLine):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setHasTextDescendants):

LayoutTests:

  • fast/inline/nested-text-descendants-expected.html: Added.
  • fast/inline/nested-text-descendants.html: Added.
11:16 Changeset [103771] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add a new WTF::bind overload that takes 6 parameters
https://bugs.webkit.org/show_bug.cgi?id=75287

Reviewed by Sam Weinig.

  • wtf/Functional.h:
10:21 Changeset [103770] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk

Unreviewed, rolling out r103620.
http://trac.webkit.org/changeset/103620
https://bugs.webkit.org/show_bug.cgi?id=75316

Causes many crashes (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28

Source/WebCore:

  • loader/FrameLoaderClient.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

Source/WebKit/chromium:

  • public/WebDOMMessageEvent.h:
  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • platform/chromium/fast/events/intercept-postmessage-expected.txt: Removed.
  • platform/chromium/fast/events/intercept-postmessage.html: Removed.
10:08 Changeset [103769] by apavlov@chromium.org
  • 5 edits in trunk

[V8][Chromium] 'randomString' in document.body.style always returns true
https://bugs.webkit.org/show_bug.cgi?id=75313

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):

LayoutTests:

  • fast/css/style-enumerate-properties-expected.txt:
  • fast/css/style-enumerate-properties.html:
08:06 Changeset [103768] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Add domain.png to WebCore.gypi / WebKit.qrc.
https://bugs.webkit.org/show_bug.cgi?id=75310

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • inspector/front-end/WebKit.qrc:
08:02 Changeset [103767] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: ExperimentsSettings causes warning on chromium when reading localizedStrings.
https://bugs.webkit.org/show_bug.cgi?id=75299

Reviewed by Pavel Feldman.

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createExperimentCheckbox):

07:59 Changeset [103766] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel: add debug sidebar resizer to TabbedEditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=75300

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-sidebar-resizer-widget):

07:25 Changeset [103765] by apavlov@chromium.org
  • 16 edits
    1 add
    1 delete in trunk

Web Inspector: Introduce a Profiler launcher view similar to that in the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=75228

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotProfileType):
(WebInspector.DetailedHeapshotProfileType.prototype.get treeItemTitle):
(WebInspector.DetailedHeapshotProfileType.prototype.get description):

  • inspector/front-end/ProfileLauncherView.js: Added.

(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.setUpEventListeners):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.ProfileLauncherView.prototype._profileTypeChanged):
(WebInspector.ProfileLauncherView.prototype._onProfileStarted):
(WebInspector.ProfileLauncherView.prototype._onProfileFinished):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.get treeItemTitle):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._showLauncherView):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfileTypeTreeElement):
(WebInspector.ProfileTypeTreeElement.prototype.collapse):
(WebInspector.ProfilesSidebarTreeElement):
(WebInspector.ProfilesSidebarTreeElement.prototype.onattach):
(WebInspector.ProfilesSidebarTreeElement.prototype.onselect):
(WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):
(WebInspector.ProfilesSidebarTreeElement.prototype.refresh):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WelcomeView.js: Removed.
  • inspector/front-end/auditsPanel.css:

(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.panel-enabler-view.audit-launcher-view label):
(.panel-enabler-view.audit-launcher-view label.disabled):

  • inspector/front-end/inspector.html:
  • inspector/front-end/panelEnablerView.css:

(.panel-enabler-view img):
(.panel-enabler-view .flexible-space):
(.panel-enabler-view button:not(.status-bar-item)):
(body.inactive .panel-enabler-view button, .panel-enabler-view button:disabled):
(.panel-enabler-view input[type="radio"]):
(.panel-enabler-view input[type="radio"]:active:not(:disabled)):
(.panel-enabler-view input[type="radio"]:checked):
(.panel-enabler-view input[type="radio"]:checked:active):

  • inspector/front-end/profilesPanel.css:

(.profile-launcher-view-tree-item > .icon):
(.profile-launcher-view-content):
(.profile-launcher-view-content h1):
(.panel-enabler-view.profile-launcher-view form):
(.panel-enabler-view.profile-launcher-view label):
(.profile-launcher-view-content p):
(.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):
(.profile-launcher-view-content button.running:not(.status-bar-item)):
(body.inactive .profile-launcher-view-content button.running:not(.status-bar-item)):

LayoutTests:

  • inspector/profiler/profiler-test.js:

(initialize_ProfilerTest):

05:41 Changeset [103764] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r103763.
http://trac.webkit.org/changeset/103763
https://bugs.webkit.org/show_bug.cgi?id=75307

"Compilation fails on Snow Leopard" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28

  • inspector/CodeGeneratorInspector.py:

(Helper):
(create_ad_hoc_type_declaration.Helper):
(CodeGenerator.generate_type_builder):
(get_in_c_type_text):

05:29 Changeset [103763] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate enum types.
https://bugs.webkit.org/show_bug.cgi?id=74954

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-28
Reviewed by Yury Semikhatsky.

Internal map of string contants is created. C enums are created for
each JSON enum.

  • inspector/CodeGeneratorInspector.py:

(EnumConstants.add_constant):
(EnumConstants):
(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(get_in_c_type_text):
(get_setter_value_expression_pattern):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding.get_setter_value_expression_pattern):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(get_annotated_type_text):
(MethodGenerateModes.get_modes):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.StrictParameterMode):
(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode):
(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(MethodGenerateModes):
(MethodGenerateModes.CombinedMode):
(MethodGenerateModes.CombinedMode.get_setter_value_expression):

04:58 Changeset [103762] by hans@chromium.org
  • 13 edits in trunk

IndexedDB: IDBKeyRange constructor should throw when lower > upper
https://bugs.webkit.org/show_bug.cgi?id=74705

Reviewed by Tony Chang.

Source/WebCore:

Make IDBKeyRange throw an exception when lower > upper,
or lower == upper and one or both of the bounds is open.

Tested in storage/indexeddb/keyrange.html.

  • storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::bound):

LayoutTests:

Update tests to check that the IDBKeyRange constructor throws when
trying to specify illegal key ranges, and update tests that were
doing that.

  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
04:28 Changeset [103761] by apavlov@chromium.org
  • 9 edits in trunk

Web Inspector: [protocol] empty enum constant should be replaced with identifier
https://bugs.webkit.org/show_bug.cgi?id=75273

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::buildObjectForRule):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.get isRegular):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-source-offsets.html:
04:04 Changeset [103760] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Crash in ~WebGraphicsLayer when running fast/multicol/pagination-* tests
https://bugs.webkit.org/show_bug.cgi?id=75000

Reviewed by Noam Rosenthal.

Don't adopt a tile client that belongs to a parent layer.
This is unnecessary and also unsafe because we can live
through that client.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

01:31 Changeset [103759] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: complete annotating SDK component.
https://bugs.webkit.org/show_bug.cgi?id=75259

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._addScript):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkDispatcher.prototype._isNull):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
(WebInspector.ResourceTreeFrame.prototype.get name):

  • inspector/front-end/TabbedEditorContainer.js:

12/27/11:

22:07 Changeset [103758] by weinig@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Continue moving compiler feature checks to use the COMPILER_SUPPORTS() macro
https://bugs.webkit.org/show_bug.cgi?id=75268

Reviewed by Anders Carlsson.

  • wtf/Compiler.h:

Add support for COMPILER_SUPPORTS(CXX_NULLPTR) and COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).

  • wtf/Noncopyable.h:

Use COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).

  • wtf/NullPtr.cpp:
  • wtf/NullPtr.h:

Use COMPILER_SUPPORTS(CXX_NULLPTR). Remove support for HAVE(NULLPTR).

  • wtf/RefPtr.h:
  • wtf/RetainPtr.h:

Switch from HAVE(NULLPTR) to COMPILER_SUPPORTS(CXX_NULLPTR).

21:29 Changeset [103757] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in the WebKit accessibility code while attempting to retrieve the title UI element.
https://bugs.webkit.org/show_bug.cgi?id=75279

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2011-12-27
Reviewed by Ryosuke Niwa.

Fix a crash in the the WebKit accessibility code which occurs while retrieving
the title UI clement. The fix is to NULL check the RenderObject::node return value.

No test added as there is no reduction.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):

21:13 Changeset [103756] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove duplicate code and remove entry after freeing the matrix.
https://bugs.webkit.org/show_bug.cgi?id=75073

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-12-27
Reviewed by Ryosuke Niwa.

Remove duplicate ewk_tile_unused_cache_freeze code.
Entry matrix should free first before removing entry in inlist,
because in eina_matrixsparce_free callback entry pointer is referenced to decrease the reference count.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_free):

20:08 Changeset [103755] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[mac] Stop using bootstrap_look_up2
https://bugs.webkit.org/show_bug.cgi?id=75280

Reviewed by Mark Rowe.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Changed to use bootstrap_look_up() instead of
bootstrap_look_up2().

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

19:27 Changeset [103754] by eae@chromium.org
  • 16182 edits
    1921 copies
    1612 deletes in branches/subpixellayout

Merging trunk changes up until 103725 into subpixel branch.

19:16 Changeset [103753] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make the inputMethodEvent set or confirm the composition
https://bugs.webkit.org/show_bug.cgi?id=75256

Reviewed by Chang Shu.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::inputMethodEvent):

18:54 Changeset [103752] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add pass/crash expectation for svg/W3C-SVG-1.1/animate-elem-52-t.svg
on Chromium Mac and Linux debug bots per the WebKit bug 74788.

  • platform/chromium/test_expectations.txt:
18:47 Changeset [103751] by dominicc@chromium.org
  • 7 edits in trunk

Remove initWebKitAnimationEvent method
https://bugs.webkit.org/show_bug.cgi?id=71698

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitAnimationEvent has a constructor, we don't need
this
method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
tracking the change to the CSS Animations spec.

  • dom/WebKitAnimationEvent.cpp:
  • dom/WebKitAnimationEvent.h:
  • dom/WebKitAnimationEvent.idl:

LayoutTests:

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
18:43 Changeset [103750] by rniwa@webkit.org
  • 20 edits
    4 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for http://crbug.com/9768. It's hard to make sense of these failures at this point
but actual results appear to be correct.

  • platform/chromium-linux/fast/forms/select-initial-position-expected.png:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
  • platform/chromium-win-xp/fast/text/international/001-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/002-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/wrap-CJK-001-expected.png: Added.
  • platform/chromium-win/fast/forms/select-initial-position-expected.png:
  • platform/chromium-win/fast/forms/select-initial-position-expected.txt:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/text/cg-fallback-bolding-expected.png:
  • platform/chromium-win/fast/text/cg-fallback-bolding-expected.txt:
  • platform/chromium-win/fast/text/international/001-expected.png:
  • platform/chromium-win/fast/text/international/001-expected.txt:
  • platform/chromium-win/fast/text/international/002-expected.png:
  • platform/chromium-win/fast/text/international/002-expected.txt:
  • platform/chromium-win/fast/text/international/wrap-CJK-001-expected.png:
  • platform/chromium-win/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/chromium/test_expectations.txt:
18:33 Changeset [103749] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Chromium Linux rebaseline. The difference is negligible for the purpose of this test.

  • platform/chromium-linux/fast/forms/textarea-width-expected.png:
  • platform/chromium-linux/fast/forms/textarea-width-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:27 Changeset [103748] by rniwa@webkit.org
  • 7 edits
    2 adds
    1 delete in trunk/LayoutTests

Chromium Linux rebsaeline for http://crbug.com/10430. Glyphs look correct.

  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
18:16 Changeset [103747] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

Chromium rebaseline after Skia revision 105271.
fast/css/shadow-multiple.html appears to have regressed; the failure is tracked by http://crbug.com/105271.

  • platform/chromium-win-xp/fast/multicol: Removed.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
18:07 Changeset [103746] by dominicc@chromium.org
  • 7 edits in trunk

Remove initWebKitTransitionEvent method
https://bugs.webkit.org/show_bug.cgi?id=71701

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitTransitionEvent has a constructor, we don't need
this
method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
tracking the change to the CSS Transitions spec.

  • dom/WebKitTransitionEvent.cpp:
  • dom/WebKitTransitionEvent.h:
  • dom/WebKitTransitionEvent.idl:

LayoutTests:

Now that WebKitTransitionEvent has a constructor, we don't need
this method.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
17:31 Changeset [103745] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Misc fixes and cleanups in Functional.h
https://bugs.webkit.org/show_bug.cgi?id=75281

Reviewed by Andreas Kling.

  • Reformat template declarations so that the class begins on a new line.
  • Change the parameter template parameters to start at P1 instead of P0.
  • Add function wrappers and bind overloads for 4 and 5 parameter functions.
  • Change the Function call operator to be const so const functions can be called.
  • wtf/Functional.h:
17:13 Changeset [103744] by rniwa@webkit.org
  • 5 edits
    1 delete in trunk/LayoutTests

Chromium Linux CPU rebaseline after r103723.

  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
16:57 Changeset [103743] by rniwa@webkit.org
  • 34 edits
    37 adds
    67 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 6.

  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-g-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path: Removed.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-g-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Added.
  • svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
  • svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
  • svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
  • svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
  • svg/clip-path/clip-path-on-g-expected.txt: Added.
  • svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
  • svg/clip-path/clip-path-on-svg-expected.txt: Added.
  • svg/clip-path/clip-path-transform-2-expected.txt: Added.
  • svg/clip-path/clip-path-use-as-child-expected.txt: Added.
  • svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
16:49 Changeset [103742] by tony@chromium.org
  • 6 edits
    9 moves
    1 add in trunk/Source/WebCore

Move HarfBuzz files into their own directory
https://bugs.webkit.org/show_bug.cgi?id=72780

Reviewed by Daniel Bates.

FontCacheLinux.cpp got moved to platform/graphics/skia/FontCacheSkia.cpp since it wasn't HarfBuzz specific.

I used HarfBuzz in filenames since that seems to be how the name is capitalized on the project home page.

Fixed some style errors caught by the style checker.

  • PlatformBlackBerry.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp.
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h.
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontLinux.cpp.
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp.
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h.
  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp.
  • platform/graphics/harfbuzz/HarfBuzzSkia.h: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h.
  • platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp.
  • platform/graphics/skia/FontCacheSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
16:33 Changeset [103741] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103734.
http://trac.webkit.org/changeset/103734
https://bugs.webkit.org/show_bug.cgi?id=75278

Broke cr-mac (Requested by dslomov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-27

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::createWorker):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
16:26 Changeset [103740] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. According to the flakiness dashboard,
fast/forms/input-text-paste-maxlength.html,
fast/filesystem/filesystem-reference.html,
fast/filesystem/filesystem-uri-origin.html, and
fast/canvas/canvas-putImageData.html are no longer flaky.

  • platform/chromium/test_expectations.txt:
16:12 Changeset [103739] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, clean up some obsolete expecatations.

  • platform/chromium/test_expectations.txt:

svg/dom/SVGRectElement/rect-modify-rx.svg is passing according to the flakiness dashboard
and storage/close-during-stress-test.html is flaky in non-debug (very rare, less than 1% of the time).

16:11 Changeset [103738] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing incorrectly overloaded layoutBlock method in RenderFlexibleBox

16:03 Changeset [103737] by rniwa@webkit.org
  • 28 edits
    13 adds
    16 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 5.

  • platform/chromium-cg-mac-snowleopard/fast/transforms: Added.
  • platform/chromium-cg-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-cg-mac/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-cg-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: Removed.
  • platform/chromium-cg-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: Removed.
  • platform/chromium-cg-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-linux-x86/fast/transforms: Removed.
  • platform/chromium-linux-x86/fullscreen: Removed.
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-leopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-win-vista/fullscreen: Removed.
  • platform/chromium-win-xp/fast/transforms: Removed.
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-win/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
15:46 Changeset [103736] by rniwa@webkit.org
  • 34 edits
    25 adds
    18 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 4.

  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/clip: Added.
  • platform/chromium-cg-mac-snowleopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-cg-mac/fast/box-shadow/border-radius-big-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/box-shadow: Removed.
  • platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:37 Changeset [103735] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision
qualifier.
https://bugs.webkit.org/show_bug.cgi?id=75168

Patch by Huang Dongsung <luxtella@company100.net> on 2011-12-27
Reviewed by Noam Rosenthal.

No new functionality so no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::initializeShaders):

15:34 Changeset [103734] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
15:32 Changeset [103733] by rniwa@webkit.org
  • 42 edits
    37 adds
    41 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 3.

  • fast/borders/borderRadiusGroove01-expected.txt: Removed.
  • fast/borders/borderRadiusGroove02-expected.txt: Removed.
  • fast/borders/borderRadiusInset01-expected.txt: Removed.
  • fast/borders/borderRadiusOutset01-expected.txt: Removed.
  • fast/borders/borderRadiusRidge01-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-inset-outset-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-styles-split-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/mixed-border-styles-radius2-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-radius-groove-01-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-groove-03-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/chromium-linux/fast/borders/border-styles-split-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/different-color-borders-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-groove-01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-groove-02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-groove-03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius2-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-radius-groove-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-03-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/chromium-win/fast/borders/border-styles-split-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/chromium/test_expectations.txt:
15:24 Changeset [103732] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] Minor cleanup of gyp files.
https://bugs.webkit.org/show_bug.cgi?id=75269

Reviewed by Adam Barth.

Source/JavaScriptCore:

and vim/emacs specific hooks should be added by the user.

Source/WebKit/chromium:

  • WebKit.gyp: msvs_guid is no longer needed.
15:04 Changeset [103731] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add an expected result meant to be added in r103723.

  • platform/chromium/compositing/scaling: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.
14:49 Changeset [103730] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] uninitialized variable in fakeMouseMoveEventTimerFired
https://bugs.webkit.org/show_bug.cgi?id=75263

Reviewed by Tony Chang.

The failure was caused by PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp
not initializing arguments on Linux. Fixed the failure by always assigning false to the arguments.

But we should really fix this function for Linux. Not recognizing any modifier isn't great.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

14:31 Changeset [103729] by haraken@chromium.org
  • 5 edits in trunk

WIP: Enable the [Supplemental] IDL on Gtk
https://bugs.webkit.org/show_bug.cgi?id=74972

Reviewed by Adam Barth.

.:

This patch adds dom_binding_idls, which is used in Source/WebCore/GNUmakefile.list.am.

  • GNUmakefile.am:

Source/WebCore:

This patch enables the [Supplemental] IDL on Gtk by changing the build
flow of Gtk as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • GNUmakefile.am: Described the above build flow.
  • GNUmakefile.list.am: Added a list of IDL files. Instead, removed a list of JS*.h and JS*.cpp

that are generated by the IDL files.

14:09 Changeset [103728] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=75260
Null name for host function can result in dereference of uninitialize memory

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This is a recent regression in ToT, if the name passed to finishCreation of a host function is null,
we are currently skipping the putDirect, which leaves memory uninitialized. This patch reverts the
aspect of the change that introduced the issue. It might be better if functions that don't have a
name don't have this property at all, but that's change should be separate from fixing the bug.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

  • Always initialize the name property.

LayoutTests:

Added a test for String applies to the ThrowTypeError function object -
if this does not crash, it passes!

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
14:04 Changeset [103727] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] When building with clang, enable -Wglobal-constructors
https://bugs.webkit.org/show_bug.cgi?id=74365

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp: Only add it to the webkit target. I got errors when

trying to compile webkit_unit_tests.

13:39 Changeset [103726] by andersca@apple.com
  • 4 edits in trunk

Function should handle wrapping/unwrapping RefPtr and PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=75266

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add ParamStorageTraits that can be used for deciding how bound parameters should be stored
and peeked at. For RefPtr we want to use the raw pointer when "peeking" to avoid ref-churn.
For PassRefPtr, we want to use RefPtr for storage but still use the raw pointer when peeking.

  • wtf/Functional.h:

(WTF::ParamStorageTraits::wrap):
(WTF::ParamStorageTraits::unwrap):

Tools:

  • TestWebKitAPI/Tests/WTF/Functional.cpp:

(TestWebKitAPI::Number::create):
(TestWebKitAPI::Number::~Number):
(TestWebKitAPI::Number::value):
(TestWebKitAPI::Number::Number):
(TestWebKitAPI::multiplyNumberByTwo):
(TestWebKitAPI::TEST):

13:04 Changeset [103725] by rniwa@webkit.org
  • 32 edits
    32 adds
    35 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 2.

  • fast/borders/borderRadiusDotted02-expected.txt: Added.
  • fast/borders/borderRadiusDotted03-expected.txt: Added.
  • fast/borders/borderRadiusDouble01-expected.txt: Removed.
  • fast/borders/borderRadiusDouble02-expected.txt: Removed.
  • fast/borders/borderRadiusDouble03-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted05-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble05-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble07-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble08-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble09-expected.png: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble06-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble07-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble08-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble09-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted05-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble05-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble06-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble07-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble08-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble09-expected.png: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted05-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble06-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble07-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble08-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble09-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/borders/borderRadiusDotted02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted03-expected.txt: Removed.
12:49 Changeset [103724] by rniwa@webkit.org
  • 29 edits
    23 adds
    30 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 1.

  • fast/borders/border-radius-complex-inner-expected.txt: Added.
  • fast/borders/borderRadiusArcs01-expected.txt: Removed.
  • fast/borders/borderRadiusDashed01-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed05-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds: Removed.
  • platform/chromium-linux-x86/fast/borders: Removed.
  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed05-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed05-expected.png: Removed.
  • platform/chromium-win-vista/fast/borders: Removed.
  • platform/chromium-win-xp/fast/borders: Removed.
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-win/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed05-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/mac/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/qt/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed01-expected.txt: Removed.
12:27 Changeset [103723] by rniwa@webkit.org
  • 15 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium] media/video-layer-crash.html media/video-transformed.html media/video-zoom-controls.html are failing on linux and win gpu.
https://bugs.webkit.org/show_bug.cgi?id=73905

Unreviewed rebaseline.

Also rebaselined compositing/color-matching/image-color-matching.html, compositing/geometry/vertical-scroll-composited.html
and compositing/scaling/tiled-layer-recursion.html.

  • platform/chromium-cg-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.txt: Removed.
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.txt: Added.
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Replaced.
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:13 Changeset [103722] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the

value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

11:53 Changeset [103721] by rniwa@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/LayoutTests

bidi-override-in-anonymous-block.html is failing
https://bugs.webkit.org/show_bug.cgi?id=74688

Chromium rebaseline after r103719.

  • platform/chromium-cg-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:43 Changeset [103720] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] remove references to files no longer in the tree
https://bugs.webkit.org/show_bug.cgi?id=75262

Reviewed by Adam Barth.

  • WebCore.gypi: platform/mac/PlatformMouseEventMac.mm and platform/mac/WheelEventMac.mm

were removed in r103652.

11:36 Changeset [103719] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

bidi-override-in-anonymous-block.html is failing
https://bugs.webkit.org/show_bug.cgi?id=74688

Unreviewed.

This test just needs an updated expectation. The case that changed is
the last (in the HTML) Ruby case. That tests an <rt> element nested
inside an <rb> element. Previously, the <rt> element closed the <rb>
element, but the HTML5 spec changed the parser so that the <rt> does
not close the <rb>. I don't fully understand the issues, but the
discussion on the mailing list makes it sound like this is the better
way to parse Ruby.

In any case, the change in parsing behavior changed how we render this
test case. The bidi aspect are still functioning correctly.

  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/test_expectations.txt:
11:12 Changeset [103718] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed web inspector localizedStrings.js fix.

  • English.lproj/localizedStrings.js:
11:07 Changeset [103717] by leviw@chromium.org
  • 521 edits in branches/subpixellayout/LayoutTests

Adding updated test expectations for Mac for numerous LayoutTests.

11:01 Changeset [103716] by leviw@chromium.org
  • 10 edits in branches/subpixellayout/Source/WebCore

Adding an AppUnit calcValue to length, and propagating LayoutUnits to various methods still on ints.

10:35 Changeset [103715] by rniwa@webkit.org
  • 102 edits
    110 adds
    22 deletes in trunk/LayoutTests

Chromium rebaseline after r103251.

Also remove failing expectations from tables/mozilla/bugs/bug9024.html on Snow Leopard
and svg/clip-path/clip-path-text-and-stroke.svg on all but Leopard.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:23 Changeset [103714] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Introduce support for experimental settings.
https://bugs.webkit.org/show_bug.cgi?id=75250

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):
(WebInspector.ExperimentsSettings.prototype.get experiments):
(WebInspector.ExperimentsSettings.prototype.get experimentsEnabled):
(WebInspector.ExperimentsSettings.prototype._createExperiment):
(WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting.get var):
(WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting):
(set WebInspector.Experiment):
(WebInspector.Experiment.prototype.get name):
(WebInspector.Experiment.prototype.get title):
(WebInspector.Experiment.prototype.isEnabled):
(WebInspector.Experiment.prototype.setEnabled):
(set WebInspector):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createExperimentsWarningSubsection):
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox.listener):
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox):

  • inspector/front-end/helpScreen.css:

(.settings-experiments-warning-subsection-warning):
(.settings-experiments-warning-subsection-message):

09:47 Changeset [103713] by yurys@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Web Inspector: inspector/dom-statistics.html test fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=75258

Disable inspector/dom-statistics.html for now until we finalize MemoryAgent functionality.

Reviewed by Pavel Feldman.

  • inspector/dom-statistics.html-disabled: Renamed from LayoutTests/inspector/dom-statistics.html.
09:46 Changeset [103712] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception when scrolling in JavaScriptOutline dialog with empty query
https://bugs.webkit.org/show_bug.cgi?id=75255

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog.prototype._onScroll):

09:03 EFLWebKit edited by kubo@profusion.mobi
gtk is not needed to build the port (diff)
08:26 Changeset [103711] by pfeldman@chromium.org
  • 31 edits in trunk

Web Inspector: add more annotations on SDK classes.
https://bugs.webkit.org/show_bug.cgi?id=75247

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._breakpoint):

  • inspector/front-end/Color.js:

(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._rgbStringsToHex):
(WebInspector.Color.prototype._parse.this.nickname.set 2):
(WebInspector.Color.prototype._parse.this.hsla.set 1):
(WebInspector.Color.prototype._parse.this.rgba.set 0):
(WebInspector.Color.prototype._parse.set WebInspector):
(WebInspector.Color.prototype._parse):

  • inspector/front-end/CompilerSourceMapping.js:
  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.StaticContentProvider):

  • inspector/front-end/CookieParser.js:

(WebInspector.CookieParser.KeyValue):
(WebInspector.CookieParser.prototype.parseCookie):
(WebInspector.CookieParser.prototype.parseSetCookie):
(WebInspector.CookieParser.prototype._extractKeyValue):

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:

(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/HAREntry.js:
  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog.prototype._mainFrameNavigated):

  • inspector/front-end/Placard.js:
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.LocalJSONObject.prototype.get hasChildren):
(WebInspector.LocalJSONObject.prototype._children):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.restoreRevisions):
(WebInspector.Resource.prototype.get queryParameters):
(WebInspector.Resource.prototype.get formParameters):
(WebInspector.Resource.prototype.isHttpFamily):

  • inspector/front-end/ResourceCategory.js:
  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isInlineScript):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.positionToLocation):

  • inspector/front-end/WelcomeView.js:

(WebInspector.WelcomeView.prototype.addMessage):

  • inspector/front-end/externs.js:

(Array.prototype.upperBound):

LayoutTests:

  • inspector/runtime/runtime-setPropertyValue-expected.txt:
  • inspector/runtime/runtime-setPropertyValue.html:
08:23 Changeset [103710] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
https://bugs.webkit.org/show_bug.cgi?id=75245

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.selectTab):

08:21 Changeset [103709] by yurys@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: report per document JS event listener count
https://bugs.webkit.org/show_bug.cgi?id=74298

Source/WebCore:

This patch adds JS event listener count to the memory agent
report.

Reviewed by Pavel Feldman.

Test: inspector/dom-statistics.html

  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

LayoutTests:

Added a test for basic functionality of MemoryAgent.

Reviewed by Pavel Feldman.

  • inspector/dom-statistics-expected.txt: Added.
  • inspector/dom-statistics.html: Added.
  • platform/chromium/inspector/dom-statistics-expected.txt: Added.
07:29 Changeset [103708] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Go to Function dialog always has a minimal height
https://bugs.webkit.org/show_bug.cgi?id=75254

Reviewed by Yury Semikhatsky.

  • inspector/front-end/scriptsPanel.css:

(.script-view):

02:26 Changeset [103707] by vsevik@chromium.org
  • 10 edits
    1 add in trunk/Source/WebCore

Web Inspector: Create tabbed editor for scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=75230

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes.get if):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TabbedEditorContainer.js: Added.
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.get visibleView):
(WebInspector.TabbedPane.prototype.get selectedTabId):
(WebInspector.TabbedPane.prototype.closeAllTabs):
(WebInspector.TabbedPane.prototype.changeTabTitle):
(WebInspector.TabbedPane.prototype.changeTabView):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get title):
(WebInspector.TabbedPaneTab.prototype.set title):
(WebInspector.TabbedPaneTab.prototype.get view):
(WebInspector.TabbedPaneTab.prototype.set view):
(WebInspector.TabbedPaneTab.prototype._createTabElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/scriptsPanel.css:

(.scripts-views-container):
(.script-view):
(#scripts-editor-container-tabbed-pane .tabbed-pane-header):
(#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
(#scripts-editor-container-tabbed-pane .tabbed-pane-content):

02:21 Changeset [103706] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: Rolling out r103703 for breaking Canvas2DLayerChromiumTest.testFullLifecycle.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
02:16 Changeset [103705] by ossy@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed Xmas gardening after r103617, add additional console message:
CONSOLE MESSAGE: line 2: <html xmlns='http://www.w3.org/1999/xhtml/'><body><p>Running an XSL-T 1.0 stylesheet with a 2.0 processor.</p></body></html>

  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Added.
01:01 Changeset [103704] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

WK2: AX: platform/mac/accessibility/search-predicate.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75039

Patch by Sam White <samuel.white@rochester.edu> on 2011-12-27
Reviewed by Chris Fleizach.

This test is failing in WK2 because WK2 isn't correctly reporting
visited links as visited. This issue has been reported before as
bug https://bugs.webkit.org/show_bug.cgi?id=58334.

I think the most appropriate first action is to add this test to
platform/wk2/Skipped under the existing bug and note the addition
in the existing bugs comments.

WebKitTestRunner has several known bugs

  • platform/wk2/Skipped:
00:25 Changeset [103703] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Bypass the shadow texture copy for accelerated
canvas when running the compositor in single threaded mode.
https://bugs.webkit.org/show_bug.cgi?id=75146

The texture copy fails on Windows as glCopyTexImage2D() doesn't
support BGRA source textures.
This change also modified Canvas2DLayerChromium::updateCompositorResources
to call glCopyTexSubImage2D() instead of glCopyTexImage2D() so that
the copy can work with texture allocated via the glTexStorage2D
extension.

Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

12/26/11:

23:30 Changeset [103702] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

[EFL][WK2] Implement context menu for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=74995

Reviewed by Anders Carlsson.

Implement missing ContextMenuEfl class in order to support WK2's context menu.
Because WK2's context menu still needs WebCore's context menu implementation.
And of course, this patch also can be used for WK1 without CROSS_PLATFORM_CONTEXT_MENU
option.

  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h:
  • platform/PlatformMenuDescription.h:
  • platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::~ContextMenu):
(WebCore::ContextMenu::appendItem):
(WebCore::ContextMenu::insertItem):
(WebCore::ContextMenu::itemCount):
(WebCore::ContextMenu::setPlatformDescription):
(WebCore::ContextMenu::platformDescription):
(WebCore::ContextMenu::releasePlatformDescription):
(WebCore::platformMenuDescription):
(WebCore::contextMenuItemVector):

  • platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::checked):
(WebCore::ContextMenuItem::setEnabled):
(WebCore::ContextMenuItem::enabled):

23:12 Changeset [103701] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

[Refactoring] Node::setTreeScopeRecursively() doesn't need includeRoot parameter
https://bugs.webkit.org/show_bug.cgi?id=75240

Reviewed by Anders Carlsson.

No new tests. No behavior change.

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively):

  • dom/Node.h:
22:27 Changeset [103700] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<http://webkit.org/b/75196> REGRESSION(r103643): Command-clicking a link no longer opens a new tab.

r103643 contained some botched copy-paste code that caused the state of the Command key
to be lost when translating from a WebKit2 event to a WebCore event.

Reviewed by Dan Bernstein.

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Test for the correct modifier.
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): Ditto.
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): Ditto.
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Ditto.
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): Ditto.

22:14 Changeset [103699] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errk! OS X build fix.

21:09 Changeset [103698] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSObject.h:
20:56 Changeset [103697] by barraclough@apple.com
  • 11 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75231
Fail to throw in strict mode on assign to read only static properties

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

There are three bugs here:

  • symbolTablePut should throw for strict mode accesses.
  • lookupPut should throw for strict mode accesses.
  • NumberConstructor should override put to call lookupPut, to trap assignment to readonly properties.
  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::put):

  • runtime/JSActivation.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::symbolTablePut):

  • runtime/Lookup.h:

(JSC::lookupPut):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::put):

  • runtime/NumberConstructor.h:

LayoutTests:

Added test cases / updated now-passing results.

  • fast/js/mozilla/strict/15.10.7-expected.txt:
  • fast/js/script-tests/strict-readonly-statics.js: Added.

(testWindowUndefined):
(testNumberMAX_VALUE):

  • fast/js/strict-readonly-statics-expected.txt: Added.
  • fast/js/strict-readonly-statics.html: Added.
20:38 Changeset [103696] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Last parameter of ewk_view_scroll is always true.
https://bugs.webkit.org/show_bug.cgi?id=75157

Reviewed by Andreas Kling.

Remove unnecessary parameter in ewk_view_scroll and related code, because
it's always true and ewk_view_tile can scroll when it is only true.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::scroll):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_scroll_add):
(ewk_view_scroll):

  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_scrolls_process):

19:39 Changeset [103695] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
19:15 Changeset [103694] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed mac/test_expectations.txt update.

  • bidi-override-in-anonymous-block.html
  • platform/mac/test_expectations.txt:
19:07 Changeset [103693] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed mac/test_expectations.txt update.

  • platform/mac/test_expectations.txt:
13:45 Changeset [103692] by darin@apple.com
  • 10 edits in trunk/Source/WebCore

Use OwnPtr and OwnArrayPtr in a couple more places
https://bugs.webkit.org/show_bug.cgi?id=75211

Reviewed by Andreas Kling.

I had a patch with some changes from a while back from going through all sorts of
classes and changing code to use adoptPtr. Most were landed long ago, these are the
ones that still apply.

There are six pieces here that could each be landed separately.
The big one is CSSParser.

  • css/CSSGrammar.y: Update for members and functions that now

return PassOwnPtr instead of raw pointers.

  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser): Remove explicit construction
for m_valueList and m_data since OwnPtr and OwnArrayPtr initialize
to zero without it.
(WebCore::CSSParser::~CSSParser): Removed delete m_valueList and
fastFree(m_data) since OwnPtr and OwnArrayPtr handle that.
(WebCore::CSSParser::setupParser): Use adoptArrayPtr and new for
the character array instead of fastFree/fastMalloc. Added get
function calls as needed.
(WebCore::CSSParser::parseValue): Added get function calls as needed.
(WebCore::CSSParser::parseContent): Ditto.
(WebCore::CSSParser::parseFillProperty): Ditto.
(WebCore::CSSParser::parseTransformOriginShorthand): Ditto.
(WebCore::CSSParser::parseBorderImage): Ditto.
(WebCore::CSSParser::parseTransformOrigin): Ditto.
(WebCore::CSSParser::parsePerspectiveOrigin): Ditto.
(WebCore::CSSParser::sinkFloatingValueList): Changed to return PassOwnPtr.
The adoptPtr call is here.
(WebCore::CSSParser::sinkFloatingFunction): Ditto.
(WebCore::CSSParser::markSelectorListStart): Added get function calls as needed.
(WebCore::CSSParser::markSelectorListEnd): Ditto.
(WebCore::CSSParser::markRuleBodyStart): Ditto.
(WebCore::CSSParser::markRuleBodyEnd): Ditto.
(WebCore::CSSParser::markPropertyStart): Ditto.
(WebCore::CSSParser::markPropertyEnd): Ditto.

  • css/CSSParser.h: Moved conditional includes to their own paragraph.

Made sinkFloatingValueList and sinkFloatingFunction return PassOwnPtr.
Made m_valueList an OwnPtr and m_data an OwnArrayPtr.

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue): Added a call to the get function.

  • html/PluginDocument.h: Made isPluginDocument private. Also marked all the

functions that are overriding here as OVERRIDE since I was touching the header.

  • html/parser/HTMLToken.h:

(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData): Removed an unneeded line
explicitly initializing the base class.

  • page/animation/AnimationBase.cpp:

(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper): Fixed indent.

  • rendering/style/RenderStyle.h: Moved conditional includes to their own paragraph.
  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::beginDOCTYPE): Removed unneeded parentheses.

11:55 Changeset [103691] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix miss-commit of utf8 change.

Reviewed by Filip Pizlo

Eeep, patch as landed a while ago had no effect! - acidentally landed
modified version of patch used for performance testing.

(This isn't covered by layout tests because layour tests don't use jsc,
and the tests/mozilla tests use latin1, which was already supported!)

Landing changes as intended (and as originally reviewed).

  • jsc.cpp:

(jscSource):

11:47 Changeset [103690] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Extract FileEditor from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=75229

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.get visibleView):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced.get if):
(WebInspector.ScriptsPanel.EditorContainer):
(WebInspector.ScriptsPanel.EditorContainer.prototype.get currentSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.show):
(WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.isSourceFrameOpen):
(WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.EditorContainer.prototype.setSourceFrameIsDirty):
(WebInspector.ScriptsPanel.EditorContainer.prototype.reset):
(WebInspector.ScriptsPanel.SingleFileEditorContainer):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get currentSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.show):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.isSourceFrameOpen):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setSourceFrameIsDirty):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):

10:13 Changeset [103689] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for ARMv7.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):

08:40 Changeset [103688] by morrita@google.com
  • 3 edits in trunk/Source/JavaScriptCore

Rename WTF_INLINE, JS_INLINE to HIDDEN_INLINE
https://bugs.webkit.org/show_bug.cgi?id=74990

Reviewed by Kevin Ollivier.

  • runtime/JSExportMacros.h: Removed JS_INLINE
  • wtf/ExportMacros.h: Renamed WTF_INLINE to HIDDEN_INLINE
08:34 Changeset [103687] by darin@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Check in expected failures for a couple of tests.

  • platform/mac/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/mac/media/video-colorspace-yuv422-expected.txt: Added.
07:58 Changeset [103686] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix a crash in WebProcess when starting a download not initiated by a WebPage
https://bugs.webkit.org/show_bug.cgi?id=75225

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::downloadRequest): Check initiatingPage is not
NULL before using it.

07:21 Changeset [103685] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix mutation observer build after didMoveToNewDocument change
https://bugs.webkit.org/show_bug.cgi?id=75224

Reviewed by Hajime Morita.

  • dom/Node.cpp:

(WebCore::willCallDidMoveToNewDocument): Added.
(WebCore::didMoveToNewDocumentWasCalled): Added.
(WebCore::Node::setDocument): Call new debugging function.
(WebCore::Node::didMoveToNewDocument): Ditto. Also use ASSERT_UNUSED
unconditionally rather than UNUSED_PARAM inside and #if. Also added
a new assertion that checks that hte old document was passed through
properly.

06:59 Changeset [103684] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list
https://bugs.webkit.org/show_bug.cgi?id=75226

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
(WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
(WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
(WebInspector.JavaScriptOutlineDialog.prototype._onScroll):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.highlightViewportItems):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.clearHighlight):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._highlightItem):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._viewportRowRange):

  • inspector/front-end/javaScriptOutlineDialog.css:

(.js-outline-dialog > .container > div.item > span.highlight):

06:30 Changeset [103683] by vsevik@chromium.org
  • 10 edits in trunk

Web Inspector: Extract FileSelector from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=75173

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype.scriptSelected):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._showAndRevealInFileSelector):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.FileSelector):
(WebInspector.ScriptsPanel.FileSelector.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.FileSelector.prototype.show):
(WebInspector.ScriptsPanel.FileSelector.prototype.addUISourceCode):
(WebInspector.ScriptsPanel.FileSelector.prototype.isScriptSourceAdded):
(WebInspector.ScriptsPanel.FileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.FileSelector.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.show):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.showDebugSidebarResizeWidget):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.addUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.isScriptSourceAdded):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._innerRevealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addToHistory):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.get var):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._resetFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._updateBackAndForwardButtons):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):

  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
04:39 Changeset [103682] by apavlov@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Web Inspector: Implement "Go to Function" dialog for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=75092

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/JavaScriptOutlineDialog.js: Added.

(WebInspector.JavaScriptOutlineDialog.onMouseDown):
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.didAddChunk):
(WebInspector.JavaScriptOutlineDialog.install):
(WebInspector.JavaScriptOutlineDialog._show):
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.JavaScriptOutlineDialog.prototype._resizeWindow):
(WebInspector.JavaScriptOutlineDialog.prototype._appendItemElements):
(WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
(WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
(WebInspector.JavaScriptOutlineDialog.prototype._selectFirstItem):
(WebInspector.JavaScriptOutlineDialog.prototype._hide):
(WebInspector.JavaScriptOutlineDialog.prototype._onBlur):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
(WebInspector.JavaScriptOutlineDialog.prototype._scheduleFilter):
(WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
(WebInspector.JavaScriptOutlineDialog.prototype._onClick):
(WebInspector.JavaScriptOutlineDialog.prototype._onMouseMove):
(WebInspector.JavaScriptOutlineDialog.prototype._highlightFunctionLine):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.get uiSourceCode):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._didBuildOutlineChunk):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/javaScriptOutlineDialog.css: Added.

(.js-outline-dialog):
(.js-outline-dialog > input):
(.js-outline-dialog > div.progress):
(.js-outline-dialog > div.container):
(.js-outline-dialog > .container > div.item):
(.js-outline-dialog > .container > div.item.selected):

04:27 Changeset [103681] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: make SDK compilation component self-contained.
https://bugs.webkit.org/show_bug.cgi?id=75172

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.get stackTrace):
(WebInspector.ConsoleMessageImpl.prototype.clone):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype.updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.clone):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.resetToolbarColors):
(WebInspector.populateHrefContextMenu):

02:41 Changeset [103680] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed bad merge fix.

Patch by Hajime Morrita <morrita@google.com> on 2011-12-26

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::didMoveToNewDocument):

12/25/11:

23:05 Changeset [103679] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=74067
Refactoring: Unitfy willMoveToNewDocument() and didMoveToNewDocument()

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-25
Reviewed by Darin Adler.

No new tests. No behavior change.

This change combines two method Node::willMoveToNewOwnerDocument() and Node::didMoveToNewOwnerDocument()
into Node::didMoveToNewDocument(Document* oldDocument).

The intention of this change is:

  • Making upcoming refactoring (Bug 59816) possible. The refactoring will turn Node::m_document into Node::m_treeScope, and we will no longer have Node::setDocument() where we can invoke both willMoveToNewDocument() and didMoveToNewDocument() at once.
  • Killing one extra virtual method call.
  • Making the concept of "move" clearer by keeping such an operation into the single method.
  • dom/Node.cpp:

(WebCore::setWillMoveToNewDocumentWasCalled):
(WebCore::setDidMoveToNewDocumentWasCalled):
(WebCore::Node::setDocument):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::didMoveToNewDocument):

  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::didMoveToNewDocument):

  • html/HTMLFormElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::didMoveToNewDocument):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didMoveToNewDocument):

  • html/HTMLInputElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didMoveToNewDocument):

  • html/HTMLMediaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::didMoveToNewDocument):

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didMoveToNewDocument):

  • html/HTMLPlugInImageElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::didMoveToNewDocument):

  • html/HTMLVideoElement.h:
  • html/ImageDocument.cpp:

(WebCore::ImageDocumentElement::didMoveToNewDocument):

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::willMoveToNewDocument):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::elementDidMoveToNewDocument):

  • loader/ImageLoader.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::didMoveToNewDocument):

  • svg/SVGImageElement.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::didMoveToNewDocument):

  • svg/SVGSVGElement.h:
22:16 Changeset [103678] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

REGRESSION(r102987): Fix the filename prefix of the generated empty .h
and .cpp files for [Supplemental] IDLs
https://bugs.webkit.org/show_bug.cgi?id=75082

Reviewed by Darin Adler.

In bug 74481, we changed generate-bindings.pl so that it generates empty .h
and .cpp files for the [Supplemental] IDLs. However, the filename prefixes of
those .h and .cpp files are wrong. This patch fixes the prefixes as follows:

generator=JS => JS*.h, JS*.cpp
generator=V8 => V8*.h, V8*.cpp
generator=ObjC => DOM*.h, DOM*.cpp
generator=GObject => WebKitDOM*.h, WebKitDOM*.cpp
generator=CPP => WebDOM*.h, WebDOM*.cpp

No new tests. No change in behavior.
I confirmed that the names of generated .h and .cpp files are correct.

  • bindings/scripts/CodeGenerator.pm:

(FileNamePrefix): Returns the prefix of file names.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateInterface): Uses CodeGenerator::FileNamePrefix.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateInterface): Ditto.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface): Ditto.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateInterface): Ditto.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateInterface): Ditto.

  • bindings/scripts/generate-bindings.pl:

(generateEmptyHeaderAndCpp): Ditto.

21:20 Changeset [103677] by mitz@apple.com
  • 7 edits in trunk/Source

../WebCore: WebCore changes for: Find indicators overlap when a match spans multiple text boxes
https://bugs.webkit.org/show_bug.cgi?id=75220

Reviewed by Darin Adler.

  • WebCore.exp.in: Exported new unionRect(const Vector<FloatRect>&) and existing

FloatRect::intersects().

  • platform/graphics/FloatRect.cpp:

(WebCore::unionRect): Added.

  • platform/graphics/FloatRect.h:

../WebKit2: Find indicators overlap when a match spans multiple text boxes
https://bugs.webkit.org/show_bug.cgi?id=75220

Reviewed by Darin Adler.

  • UIProcess/FindIndicator.cpp:

(WebKit::findIndicatorsForTextRectsOverlap): Added this helper function that checks for
pairwise intersections between all indicator rects.
(WebKit::FindIndicator::FindIndicator): Changed to use a single rect (the union of all text
rects) if any two indicator rects would otherwise overlap. This is similar to what Safari
does, and it eliminates overlapping rects for adjacent text boxes. In rare cases (such as when
a match spans two lines and adjacent text boxes on one of those lines) it results in a find
indicator that is too large and obscures some non-match text.

  • UIProcess/FindIndicator.h:
20:46 Changeset [103676] by darin@apple.com
  • 6 edits in trunk/Source/WebCore

Use OwnPtr for CSSFontFace::m_sources
https://bugs.webkit.org/show_bug.cgi?id=75219

Reviewed by Dan Bernstein.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::isLoaded): Use the same size_t idiom here as in the rest
of the functions.
(WebCore::CSSFontFace::isValid): Ditto. Also removed unneeded empty special casing.
(WebCore::CSSFontFace::addSource): Changed to take a PassOwnPtr. Reordered so the
PassOwnPtr zeroing does not cause trouble.
(WebCore::CSSFontFace::getFontData): Added call to get.
(WebCore::CSSFontFace::hasSVGFontFaceSource): Use the same size_t idiom here as in
the rest of the functions.

  • css/CSSFontFace.h: Use PassOwnPtr for addSource argument, and Vector<OwnPtr> for

the m_sources vector.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Use OwnPtr and PassOwnPtr for font face
sources that are passed to addSource.

  • css/CSSSegmentedFontFace.cpp: Added a now-needed include.
20:02 Changeset [103675] by jarred@sencha.com
  • 3 edits
    6 adds in trunk

Allow XMLHttpRequest responseType to be set at any state up to and including HEADERS_RECEIVED
https://bugs.webkit.org/show_bug.cgi?id=75190

Source/WebCore:

XMLHttpRequest.responseType should be modifiable at any state up to and including the
HEADERS_RECEIVED state. Therefore, subsequent calls to open() should not reset responseType
to its default value, and calls to open() must follow the same spec mandate set forth in
setResponseType() for synchronous HTTP(S) requests made from the window context.

Reviewed by Alexey Proskuryakov.

Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request.html

fast/xmlhttprequest/xmlhttprequest-responsetype-before-open.html
fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setResponseType):
Prevent setting the value only when in LOADING and DONE states. No longer check if
m_loader is present, which is instantiated on a call to send(), because responseType
can be safely changed after a request is sent.
(WebCore::XMLHttpRequest::open):
Do not reset m_responseTypeCode to the default value, and prevent calls to open()
for synchronous HTTP(S) requests made from the window context when m_responseTypeCode
is not the default value.

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request.html: Added.

Validate that calls to open() for synchronous HTTP(S) requests from the window context will
properly fail when responseType has been previously set to a non-default value.

  • fast/xmlhttprequest/xmlhttprequest-responsetype-before-open.html: Added.

Validate that XMLHttpRequest.responseType can be set prior to a call to open().

  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received.html: Added.

Validate that XMLHttpRequest.responseType can be set at the HEADERS_RECEIVED state, but
no state later than that.

18:16 Changeset [103674] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

The ArgumentCount field in the CallFrame should have its tag left blank for other uses
https://bugs.webkit.org/show_bug.cgi?id=75199
<rdar://problem/10625105>
<rdar://problem/10625106>

Reviewed by Oliver Hunt.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • interpreter/CallFrame.h:

(JSC::ExecState::argumentCountIncludingThis):
(JSC::ExecState::setArgumentCountIncludingThis):

  • interpreter/Register.h:

(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):
(JSC::Register::payload):
(JSC::Register::tag):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):

13:32 Changeset [103673] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix tests failing as a result of r103643
https://bugs.webkit.org/show_bug.cgi?id=75209

Reviewed by Dan Bernstein.

Switch accidental switch of default scroll granularity from
ScrollByPageWheelEvent back to ScrollByPixelWheelEvent.

  • platform/mac/PlatformEventFactory.mm:

(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

13:21 Changeset [103672] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Yarr: Avoid copying vectors in CharacterClassConstructor.
<http://webkit.org/b/75206>

Reviewed by Darin Adler.

Yarr::CharacterClassConstructor::charClass() was hot when loading twitter
feeds (1.2%), replace the usage of Vector::append() by swap() since we're
always clearing the source vector afterwards anyway.

  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::charClass):

11:03 Changeset [103671] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Change CSS canvas code that does HashMap get/set to use the more efficient add idiom
https://bugs.webkit.org/show_bug.cgi?id=75204

Reviewed by Dan Bernstein.

  • dom/Document.cpp:

(WebCore::Document::getCSSCanvasContext): Change local variable name of element to
element; it's not the function result, so not good to name it result.
(WebCore::Document::getCSSCanvasElement): Use add instead of get/set so we only do
one hash table lookup.

09:08 Changeset [103670] by darin@apple.com
  • 2 edits in trunk/Source/ThirdParty
  • gtest/xcode/gtest.xcodeproj: Added property svn:ignore.
00:24 Changeset [103669] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the C++ parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75191

Reviewed by Ryosuke Niwa.

cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
of prepare-ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Renames get_function_line_ranges_for_c()
to get_function_line_ranges_for_cpp().

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.

(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(funcOverloaded):
(Class::func16):
(Class1::Class2::func17):
(Class2::func18):
(Class2::func19):
(Class2::func20):
(Class2::func21):
(Class2::func22):
(func23):
(func24):
(Class2::func25):
(Class1::func26):
(Class2::func27):
(Class3::func28):
(Class7::operator+):
(Class100::Class100):
(Class101::~Class101):
(Class102::Class102):
(Class103::Class103):
(Struct1::func29):
(Struct2::func30):
(NameSpace1::func30):
(NameSpace1::NameSpace2::func31):

00:15 Changeset [103668] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the Java parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75195

Reviewed by Ryosuke Niwa.

java_unittests.java is unittest cases for get_function_line_ranges_for_java()
of prepare-ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_java): Fixed a parser bug.

interface I
{

void f()
{
}

}

should be recognized as "I.f", and

class C interface I
{

void f()
{
}

}

should be recognized as "C.f".
Without this patch, both are recognized as "I.f".

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.

(Simple):
(Simple.func1):
(Simple.func2):
(Simple.func3):
(Simple.func4):
(Simple.func5):
(Simple.func6):
(Simple.func7):
(Simple.func8):
(Simple.func9):
(Simple.func10):
(Simple.funcOverloaded):
(Simple.func11):
(Simple.func12):
(Simple.func13):
(Simple.func14):
(Simple.func15):
(Simple.func16):
(Simple.func17):
(Simple.func18):
(Simple.func19):
(Simple.func20):
(Simple.func21):
(Derived1):
(Derived1.Derived1):
(Derived1.func22):
(Interface1):
(Interface2):
(Interface2.func23):
(Derived2):
(Derived2.Derived2):
(Derived2.func23):

00:09 Changeset [103667] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the Python parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75197

Reviewed by Ryosuke Niwa.

python_unittests.py is the unittest for get_function_line_ranges_for_python()
of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
This is because the current python parser is wrong, and it cannot correctly parse nested
classes and defs (even one def in a class), nor class inheritance.
We will fix it in another patch.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python): Ignores comment lines that starts from #.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.

(func1):
(func2):
(func3):
(funcInsideComment):
(func4):
(func5):
(func6):
(funcOverloaded):
(Class1):

12/24/11:

17:09 Changeset [103666] by mitz@apple.com
  • 1355 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

14:49 Changeset [103665] by darin@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Specialize HashTraits for RefPtr to use PassRefPtr as "pass type" to reduce reference count churn
https://bugs.webkit.org/show_bug.cgi?id=72476

Reviewed by Sam Weinig.

  • wtf/HashTraits.h: Defined PassInType and store function in HashTraits<RefPtr>.
14:08 Changeset [103664] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

CSSElementStyleDeclarations should never move between elements.
<http://webkit.org/b/75198>

Reviewed by Anders Carlsson.

Have the CSSElementStyleDeclaration subclasses take a StyledElement* in
the constructor and replace setElement(StyledElement*) by clearElement().

No behavior change, just enforcing the current behavior at compile-time.

  • css/CSSElementStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::clearElement):
(WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):

  • css/CSSInlineStyleDeclaration.h:

(WebCore::CSSInlineStyleDeclaration::create):
(WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):

  • svg/SVGFontFaceElement.cpp:

(WebCore::FontFaceStyleDeclaration::FontFaceStyleDeclaration):

13:24 Changeset [103663] by kling@webkit.org
  • 12 edits in trunk/Source/WebCore

Decouple CSSMappedAttributeDeclaration from element completely.
<http://webkit.org/b/75187>

Reviewed by Darin Adler.

Let CSSMappedAttributeDeclaration inherit from CSSMutableDeclaration instead
of CSSElementStyleDeclaration. Add methods to CSSMappedAttributeDeclaration
for setting properties that also take a StyledElement* and use that mechanism
instead of temporarily associating an element with the declaration.

This reduces the size of mapped attributes by 4/8 bytes, but more importantly
opens a number of ways to simplify style declarations in future patches.

  • css/CSSMutableStyleDeclaration.h:
  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::setNeedsStyleRecalc):
(WebCore::CSSMappedAttributeDeclaration::setMappedImageProperty):
(WebCore::CSSMappedAttributeDeclaration::setMappedLengthProperty):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
(WebCore::CSSMappedAttributeDeclaration::removeMappedProperty):

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

Add/move methods to CSSMappedAttributeDeclaration for setting/removing
properties that also take a StyledElement*. That element is used for
scheduling style recalc and passing the right document to CSSParser.

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseMappedAttributeValue):

Added a parsedMappedAttributeValue() alternative to parseValue() that
takes a StyledElement*.

  • dom/StyledElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

Add (and use) a StyledElement::removeCSSProperty() complement to the
addCSS*() functions.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

Use the setMapped*Property() functions to plumb the element through.

  • css/CSSElementStyleDeclaration.h:

Update comment about CSSElementStyleDeclaration's subclasses.

13:01 Changeset [103662] by mitz@apple.com
  • 2 edits in trunk/Tools

Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

12:29 Changeset [103661] by jarred@sencha.com
  • 3 edits
    2 adds in trunk

Allow XMLHttpRequest withCredentials to be set prior to a call to open()
https://bugs.webkit.org/show_bug.cgi?id=75194

Source/WebCore:

XMLHttpRequest.withCredentials attribute should be modifiable prior to the OPENED state per
the W3C spec. See http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#the-withcredentials-attribute

Reviewed by Alexey Proskuryakov.

Test: fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setWithCredentials):
Prevent setting the value only after the OPENED state.

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html: Added.

Validate that XMLHttpRequest.withCredentials can be set prior to a call to open().

12:15 Changeset [103660] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove empty inline RenderStyle destructor.
<http://webkit.org/b/75188>

Rubber-stamped by Anders "Ordvits" Carlsson.

  • rendering/style/RenderStyle.h:
11:30 Changeset [103659] by mitz@apple.com
  • 2 edits in trunk/Tools

Make build-webkit aware of additional Xcode build location defaults.

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(determineXcodeVersion): Added. This was previously in determineBaseProductDir().
(readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
(determineBaseProductDir): Changed to check for a custom build location
style specified as an absolute location.

11:26 Changeset [103658] by rniwa@webkit.org
  • 20 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103619.
http://trac.webkit.org/changeset/103619
https://bugs.webkit.org/show_bug.cgi?id=66509

Broke chromium clang build

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
10:53 Changeset [103657] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Chromium CG Mac rebaseline after r103651.

  • platform/chromium-cg-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:32 Changeset [103656] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderStyle: Inline the destructor.
<http://webkit.org/b/75188>

Reviewed by Kenneth Rohde Christiansen.

The (empty) RenderStyle destructor gets a little hot sometimes, reaching up
to 0.4% when loading the full HTML5 spec. Inline it to remove the pointless
function call.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::~RenderStyle):

07:52 Changeset [103655] by jarred@sencha.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed test result gardening.

  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Removed.

Identical to the expected result shared by all ports.

01:07 Changeset [103654] by rniwa@webkit.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

Another rebaseline for font-weight-bold-for-b-and-strong.html.
Also revert a part of r103645.

  • platform/chromium-linux-x86/fast/html: Removed.
  • platform/chromium-linux/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium/fast/html: Removed.
  • platform/chromium/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.