Timeline


and

01/06/12:

23:33 Changeset [104379] by mrowe@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

Regenerate a few files with a more appropriate version of bison.

Rubber-stamped by Dan Bernstein.

  • src/compiler/glslang.l: Tweak the input so that it generates code that compiles without warnings.
  • src/compiler/glslang_lex.cpp:
  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
22:57 Changeset [104378] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r83075): Save as PDF does not generate any links for webkit.org and others
<http://webkit.org/b/75768> <rdar://problem/10659258>

Use RenderObject::hasOutline when determining whether to always create line boxes so that
we take in to consideration whether we'll be creating PDF link rects.

Reviewed by Dan Bernstein.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):

22:57 Changeset [104377] by mrowe@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (WebKit2): Save as PDF no longer generates links to URLs
<http://webkit.org/b/65076> / <rdar://problem/9606246>

WebKit2 printing works by having the web process render the page content to a PDF. The PDF
data is then shipped to the UI process which will render it in to the printing graphics context.
Links were being lost because the API used to do the rendering of the PDF in to the printing
graphics context, CGContextDrawPDFPage, did not preserve the links that were present in the
PDF content received from the web process.

To fix this we switch to using PDFKit for drawing the PDF in to the printing graphics context.
PDFKit provides the ability for us to iterate over the links in the PDF content ourselves and
add links in to the printing graphics context.

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKPrintingView.mm:

(pdfAnnotationLinkClass): Look up the PDFAnnotationLink class from PDFKit as WebKit2 loads PDFKit lazily.
(pdfDocumentClass): Ditto.
(-[WKPrintingView _drawPDFDocument:page:atPoint:]): Switch to using the PDFKit equivalents of several types.
Iterate over the annotations present in the PDFPage, calling CGPDFContextSetURLForRect for each PDFAnnotationLink
that we find.
(-[WKPrintingView _drawPreview:]): Create an NSData to feed to PDFDocument.
(-[WKPrintingView drawRect:]): Ditto.

  • WebKit2Prefix.h: Add the usual workaround to make Objective-C exceptions compile when C++ exception handling is disabled.
22:46 Changeset [104376] by commit-queue@webkit.org
  • 35 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r104373 and r104374.
http://trac.webkit.org/changeset/104373
http://trac.webkit.org/changeset/104374
https://bugs.webkit.org/show_bug.cgi?id=75769

Too many assertion failures. (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLAllCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::detachFromNode):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLCollection.h:
  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):
(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::elements):

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLOptionsCollection.h:
  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

  • html/HTMLPropertiesCollection.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::~HTMLSelectElement):
(WebCore::HTMLSelectElement::options):

  • html/HTMLSelectElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

LayoutTests:

  • fast/dom/htmlcollection-protects-base-expected.txt: Removed.
  • fast/dom/htmlcollection-protects-base.html: Removed.
  • fast/dom/htmlcollection-zombies-expected.txt: Added.
  • fast/dom/htmlcollection-zombies.html: Added.
20:20 Changeset [104375] by jarred@sencha.com
  • 2 edits in trunk/Tools

Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.

  • Scripts/webkitdirs.pm:

(buildChromium):
Missing parentheses.

19:58 Changeset [104374] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r104373.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

19:30 Changeset [104373] by kling@webkit.org
  • 34 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
19:12 Changeset [104372] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

DOMWindow should be a FrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=75697

Reviewed by Alexey Proskuryakov.

DOMWindow plays exactly the role of a FrameDestructionObserver, just
with special-case code. It should just use the general-case code.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::~Frame):
(WebCore::Frame::clearDOMWindow):
(WebCore::Frame::setDOMWindow):

  • page/Frame.h:
19:10 Changeset [104371] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759

Implement missing accessor and make setter public.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-06
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::searchingForNodeInPage):

  • inspector/InspectorDOMAgent.h:
18:50 Changeset [104370] by ostapenko.viatcheslav@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] [WK2] Minibrowser leaks memory ~6-7Mb per reload
https://bugs.webkit.org/show_bug.cgi?id=75746

Reset WebGraphicsLayer::m_layerTreeTileClient of all dependent
layers from ~LayerTreeHostQt(). This replaces r103760 which
causes leaks of GraphicsLayerTextureMapper objects on UI side.

Reviewed by Noam Rosenthal.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::~LayerTreeHostQt):

18:43 Changeset [104369] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Roll out r104362 since it broke the build.

18:39 Changeset [104368] by wjmaclean@chromium.org
  • 9 edits
    1 copy
    2 adds in trunk/Source

[Chromium] Cull occluded tiles in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=70533

Reviewed by James Robinson.

Source/WebCore:

Unit test provided, must pass all existing GPU layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCQuadCuller.cpp: Added.

(std::swap):
(WebCore::regionContainsRect):
(WebCore::CCQuadCuller::cullOccludedQuads):

  • platform/graphics/chromium/cc/CCQuadCuller.h: Added.

(WebCore::CCQuadCuller::CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::optimizeQuads):

  • platform/graphics/chromium/cc/CCRenderPass.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCQuadCullerTest.cpp: Added.

(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
(WebCore::TEST):

17:59 Changeset [104367] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

rollout uneeded windows build fix.

17:56 Changeset [104366] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Move more rubberbanding code into ScrollAnimatorMac::smoothScrollWithEvent
https://bugs.webkit.org/show_bug.cgi?id=75750

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Move rubberbanding related code into smoothScrollWithEvent.

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
Move code here from handleWheelEvent and made the function return a boolean.

(WebCore::ScrollAnimatorMac::snapRubberBand):
Call the client.

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Ditto.

17:55 Changeset [104365] by kbr@google.com
  • 10 edits
    8 deletes in branches/chromium/963

Revert 98735 - Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property (http://crbug.com/107283)
https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html

compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.

  • platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,

added ContentsVisibilityChanged flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.

  • rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

  • compositing/visibility/visibility-composited-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms.html: Added.
  • compositing/visibility/visibility-composited.html: Added.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • compositing/visibility/visibility-image-layers-dynamic.html: Added.
  • compositing/visibility/visibility-image-layers-expected.png: Added.
  • compositing/visibility/visibility-image-layers.html: Added.

TBR=simon.fraser@apple.com
Review URL: http://codereview.chromium.org/9120020

17:40 Changeset [104364] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r91145.

17:40 Changeset [104363] by cmarrin@apple.com
  • 77 edits
    6 adds
    7 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE in WebKit tree
https://bugs.webkit.org/show_bug.cgi?id=75753

Reviewed by Simon Fraser.

Updated ANGLE to r939. Fixed a compiler error (missing case in switch statement)
and added 5 new files to xcodeproj. Other than that it is a straight copy of
the files from the ANGLE repository.

  • ANGLE.xcodeproj/project.pbxproj:
  • include/EGL/eglext.h:
  • include/EGL/eglplatform.h:
  • include/GLES2/gl2ext.h:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp:

(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):

  • src/common/version.h:
  • src/compiler/BaseTypes.h:

(getBasicString):

  • src/compiler/BuiltInFunctionEmulator.cpp: Added.

(BuiltInFunctionEmulator::BuiltInFunctionEmulator):
(BuiltInFunctionEmulator::SetFunctionCalled):
(BuiltInFunctionEmulator::OutputEmulatedFunctionDefinition):
(BuiltInFunctionEmulator::IdentifyFunction):
(BuiltInFunctionEmulator::MarkBuiltInFunctionsForEmulation):
(BuiltInFunctionEmulator::Cleanup):
(BuiltInFunctionEmulator::GetEmulatedFunctionName):

  • src/compiler/BuiltInFunctionEmulator.h: Added.
  • src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::compile):
(TCompiler::clearResults):
(TCompiler::detectRecursion):
(TCompiler::getMappedNameMaxLength):
(TCompiler::getBuiltInFunctionEmulator):

  • src/compiler/DetectRecursion.cpp: Added.

(DetectRecursion::FunctionNode::FunctionNode):
(DetectRecursion::FunctionNode::getName):
(DetectRecursion::FunctionNode::addCallee):
(DetectRecursion::FunctionNode::detectRecursion):
(DetectRecursion::DetectRecursion):
(DetectRecursion::~DetectRecursion):
(DetectRecursion::visitAggregate):
(DetectRecursion::detectRecursion):
(DetectRecursion::findFunctionByName):

  • src/compiler/DetectRecursion.h: Added.
  • src/compiler/ExtensionBehavior.h:
  • src/compiler/ForLoopUnroll.cpp:

(ForLoopUnroll::MarkForLoopsWithIntegerIndicesForUnrolling):

  • src/compiler/ForLoopUnroll.h:
  • src/compiler/Initialize.cpp:

(BuiltInFunctionsCommon):
(BuiltInFunctionsVertex):
(BuiltInFunctionsFragment):
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):

  • src/compiler/MapLongVariableNames.cpp:

(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapVaryingLongName):

  • src/compiler/MapLongVariableNames.h:
  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitUnary):
(TOutputGLSLBase::visitAggregate):

  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorate):
(sh::OutputHLSL::decorateUniform):

  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp:

(TParseContext::recover):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):

  • src/compiler/PoolAlloc.h:

(pool_allocator::pool_allocator):
(pool_allocator::operator=):
(pool_allocator::setAllocator):
(pool_allocator::getAllocator):

  • src/compiler/ShHandle.h:
  • src/compiler/ShaderLang.cpp:

(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShGetInfo):

  • src/compiler/SymbolTable.cpp:

(TType::computeDeepestStructNesting):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):
(TranslatorESSL::writeExtensionBehavior):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/Types.h:

(TType::TType):
(TType::copyType):
(TType::setStruct):
(TType::getDeepestStructNesting):

  • src/compiler/UnfoldSelect.cpp:

(sh::UnfoldSelect::traverse):
(sh::UnfoldSelect::visitSelection):
(sh::UnfoldSelect::visitLoop):
(sh::UnfoldSelect::getNextTemporaryIndex):

  • src/compiler/UnfoldSelect.h:
  • src/compiler/ValidateLimitations.cpp:
  • src/compiler/ValidateLimitations.h:
  • src/compiler/VariableInfo.cpp:

(getVariableDataType):

  • src/compiler/generate_glslang_lexer.sh: Removed.
  • src/compiler/generate_glslang_parser.sh: Removed.
  • src/compiler/generate_parser.sh: Added.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(yy_get_previous_state):
(yy_try_NUL_trans):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
  • src/compiler/intermOut.cpp:

(TOutputTraverser::visitAggregate):

  • src/compiler/intermediate.h:

(TIntermUnary::TIntermUnary):
(TIntermUnary::setUseEmulatedFunction):
(TIntermUnary::getUseEmulatedFunction):
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::setUseEmulatedFunction):
(TIntermAggregate::getUseEmulatedFunction):

  • src/compiler/osinclude.h:
  • src/compiler/ossource_posix.cpp:

(OS_AllocTLSIndex):
(OS_SetTLSValue):
(OS_FreeTLSIndex):

  • src/compiler/preprocessor/atom.c:

(GrowAtomTable):

  • src/compiler/preprocessor/length_limits.h: Added.
  • src/compiler/preprocessor/scanner.h:
  • src/libEGL/Display.cpp:

(egl::Display::getDisplay):
(egl::Display::Display):
(egl::Display::~Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::startScene):
(egl::Display::endScene):
(egl::Display::createDevice):
(egl::Display::initializeDevice):
(egl::Display::resetDevice):
(egl::Display::createWindowSurface):
(egl::Display::createOffscreenSurface):
(egl::Display::createContext):
(egl::Display::restoreLostDevice):
(egl::Display::notifyDeviceLost):
(egl::Display::isDeviceLost):
(egl::Display::testDeviceLost):
(egl::Display::testDeviceResettable):
(egl::Display::getDXT1TextureSupport):
(egl::Display::getDXT3TextureSupport):
(egl::Display::getDXT5TextureSupport):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getTexturePool):
(egl::Display::initExtensionString):

  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp:

(egl::Surface::Surface):
(egl::Surface::initialize):
(egl::Surface::resetSwapChain):
(egl::Surface::subclassWindow):
(egl::Surface::unsubclassWindow):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):
(egl::Surface::isPostSubBufferSupported):

  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libEGL/libEGL.rc:
  • src/libEGL/libEGL.vcproj:
  • src/libGLESv2/Buffer.cpp:

(gl::Buffer::bufferSubData):

  • src/libGLESv2/Context.cpp:

(gl::Context::Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::markContextLost):
(gl::Context::isContextLost):
(gl::Context::setPackReverseRowOrder):
(gl::Context::getPackReverseRowOrder):
(gl::Context::deleteProgram):
(gl::Context::getDrawFramebuffer):
(gl::Context::bindDrawFramebuffer):
(gl::Context::useProgram):
(gl::Context::setFramebufferZero):
(gl::Context::getCurrentProgram):
(gl::Context::getBooleanv):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawClosingLine):
(gl::Context::getResetStatus):
(gl::Context::isResetNotificationEnabled):
(gl::Context::supportsDXT1Textures):
(gl::Context::supportsDXT3Textures):
(gl::Context::supportsDXT5Textures):
(gl::Context::supportsFloat32Textures):
(gl::Context::supportsFloat32LinearFilter):
(gl::Context::supportsFloat32RenderableTextures):
(gl::Context::supportsFloat16Textures):
(gl::Context::supportsFloat16LinearFilter):
(gl::Context::supportsFloat16RenderableTextures):
(gl::Context::initExtensionString):
(gl::Context::initRendererString):
(gl::Context::getRendererString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):

  • src/libGLESv2/Context.h:
  • src/libGLESv2/Fence.cpp:

(gl::Fence::testFence):
(gl::Fence::getFenceiv):

  • src/libGLESv2/Framebuffer.cpp:

(gl::Framebuffer::setColorbuffer):
(gl::Framebuffer::setDepthbuffer):
(gl::Framebuffer::setStencilbuffer):
(gl::Framebuffer::getColorbuffer):
(gl::Framebuffer::getDepthbuffer):
(gl::Framebuffer::getStencilbuffer):
(gl::Framebuffer::hasStencil):
(gl::Framebuffer::completeness):
(gl::DefaultFramebuffer::DefaultFramebuffer):

  • src/libGLESv2/Framebuffer.h:
  • src/libGLESv2/IndexDataManager.cpp:

(gl::IndexDataManager::prepareIndexData):
(gl::IndexBuffer::IndexBuffer):
(gl::IndexBuffer::getSerial):
(gl::IndexBuffer::issueSerial):
(gl::StreamingIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::lookupRange):
(gl::StaticIndexBuffer::addRange):

  • src/libGLESv2/IndexDataManager.h:

(gl::StaticIndexBuffer::IndexRange::operator<):

  • src/libGLESv2/Program.cpp:

(gl::Uniform::Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::Program::Program):
(gl::Program::detachShader):
(gl::Program::getUsedSamplerRange):
(gl::Program::getSamplerMapping):
(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::transposeMatrix):
(gl::Program::setUniformMatrix2fv):
(gl::Program::setUniformMatrix3fv):
(gl::Program::setUniformMatrix4fv):
(gl::Program::getUniformfv):
(gl::Program::getUniformiv):
(gl::Program::applyUniforms):
(gl::Program::compileToBinary):
(gl::Program::linkVaryings):
(gl::Program::link):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::decorateAttribute):
(gl::Program::undecorateUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniformnfv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::applyUniformniv):
(gl::Program::appendToInfoLogSanitized):
(gl::Program::unlink):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validateSamplers):
(gl::Program::initializeConstantHandles):
(gl::Program::getDxCoordLocation):

  • src/libGLESv2/Program.h:
  • src/libGLESv2/Renderbuffer.cpp:

(gl::RenderbufferInterface::RenderbufferInterface):
(gl::RenderbufferInterface::getRedSize):
(gl::RenderbufferInterface::getGreenSize):
(gl::RenderbufferInterface::getBlueSize):
(gl::RenderbufferInterface::getAlphaSize):
(gl::RenderbufferInterface::getDepthSize):
(gl::RenderbufferInterface::getStencilSize):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::getRenderTarget):
(gl::RenderbufferTexture::getDepthStencil):
(gl::RenderbufferTexture::getWidth):
(gl::RenderbufferTexture::getHeight):
(gl::RenderbufferTexture::getInternalFormat):
(gl::RenderbufferTexture::getD3DFormat):
(gl::RenderbufferTexture::getSamples):
(gl::RenderbufferTexture::getSerial):
(gl::Renderbuffer::Renderbuffer):
(gl::Renderbuffer::~Renderbuffer):
(gl::Renderbuffer::getRenderTarget):
(gl::Renderbuffer::getDepthStencil):
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getInternalFormat):
(gl::Renderbuffer::getD3DFormat):
(gl::Renderbuffer::getRedSize):
(gl::Renderbuffer::getGreenSize):
(gl::Renderbuffer::getBlueSize):
(gl::Renderbuffer::getAlphaSize):
(gl::Renderbuffer::getDepthSize):
(gl::Renderbuffer::getStencilSize):
(gl::Renderbuffer::getSamples):
(gl::Renderbuffer::getSerial):
(gl::Renderbuffer::setStorage):
(gl::RenderbufferStorage::getD3DFormat):
(gl::RenderbufferStorage::issueCubeSerials):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::getRenderTarget):
(gl::Depthbuffer::Depthbuffer):
(gl::Stencilbuffer::Stencilbuffer):

  • src/libGLESv2/Renderbuffer.h:

(gl::RenderbufferInterface::~RenderbufferInterface):

  • src/libGLESv2/Shader.cpp:

(gl::Shader::getTranslatedSourceLength):
(gl::Shader::getSourceImpl):
(gl::Shader::getSource):
(gl::Shader::getTranslatedSource):

  • src/libGLESv2/Shader.h:
  • src/libGLESv2/Texture.cpp:

(gl::ConvertTextureFormatType):
(gl::IsTextureFormatRenderable):
(gl::Image::Image):
(gl::Image::~Image):
(gl::Image::redefine):
(gl::Image::createSurface):
(gl::Image::lock):
(gl::Image::unlock):
(gl::Image::isRenderableFormat):
(gl::Image::getD3DFormat):
(gl::Image::getSurface):
(gl::Image::setManagedSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::FlipCopyDXT1BlockFull):
(gl::FlipCopyDXT1BlockHalf):
(gl::FlipCopyDXT3BlockFull):
(gl::FlipCopyDXT3BlockHalf):
(gl::FlipCopyDXT5BlockFull):
(gl::FlipCopyDXT5BlockHalf):
(gl::Image::loadDXT1Data):
(gl::Image::loadDXT3Data):
(gl::Image::loadDXT5Data):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::~TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::isManaged):
(gl::TextureStorage::getPool):
(gl::TextureStorage::getTextureSerial):
(gl::TextureStorage::issueTextureSerial):
(gl::Texture::Texture):
(gl::Texture::~Texture):
(gl::Texture::setMinFilter):
(gl::Texture::setMagFilter):
(gl::Texture::setWrapS):
(gl::Texture::setWrapT):
(gl::Texture::setUsage):
(gl::Texture::getMinFilter):
(gl::Texture::getMagFilter):
(gl::Texture::getWrapS):
(gl::Texture::getWrapT):
(gl::Texture::getUsage):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture::getTexture):
(gl::Texture::hasDirtyParameters):
(gl::Texture::hasDirtyImages):
(gl::Texture::resetDirty):
(gl::Texture::getTextureSerial):
(gl::Texture::getRenderTargetSerial):
(gl::Texture::isImmutable):
(gl::Texture::creationLevels):
(gl::Texture::getBlitter):
(gl::Texture::copyToRenderTarget):
(gl::TextureStorage2D::TextureStorage2D):
(gl::TextureStorage2D::~TextureStorage2D):
(gl::TextureStorage2D::getSurfaceLevel):
(gl::TextureStorage2D::getBaseTexture):
(gl::TextureStorage2D::getRenderTargetSerial):
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl::Texture2D::getWidth):
(gl::Texture2D::getHeight):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getType):
(gl::Texture2D::redefineImage):
(gl::Texture2D::setImage):
(gl::Texture2D::bindTexImage):
(gl::Texture2D::releaseTexImage):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::commitRect):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isMipmapComplete):
(gl::Texture2D::getBaseTexture):
(gl::Texture2D::createTexture):
(gl::Texture2D::updateTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::generateMipmaps):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getStorage):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureStorageCubeMap::~TextureStorageCubeMap):
(gl::TextureStorageCubeMap::getCubeMapSurface):
(gl::TextureStorageCubeMap::getBaseTexture):
(gl::TextureStorageCubeMap::getRenderTargetSerial):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getType):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::commitRect):
(gl::TextureCubeMap::subImage):
(gl::TextureCubeMap::subImageCompressed):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCubeComplete):
(gl::TextureCubeMap::isMipmapCubeComplete):
(gl::TextureCubeMap::getBaseTexture):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::updateTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::setImage):
(gl::TextureCubeMap::redefineImage):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::generateMipmaps):
(gl::TextureCubeMap::getRenderbuffer):
(gl::TextureCubeMap::getRenderTarget):
(gl::TextureCubeMap::getStorage):

  • src/libGLESv2/Texture.h:

(gl::Image::markDirty):
(gl::Image::markClean):
(gl::Image::getWidth):
(gl::Image::getHeight):
(gl::Image::getFormat):
(gl::Image::getType):
(gl::Image::isDirty):

  • src/libGLESv2/VertexDataManager.cpp:

(gl::elementsInBuffer):
(gl::VertexDataManager::VertexDataManager):
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexBuffer::VertexBuffer):
(gl::VertexBuffer::getSerial):
(gl::VertexBuffer::issueSerial):
(gl::StreamingVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::map):
(gl::StaticVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::lookupAttribute):

  • src/libGLESv2/VertexDataManager.h:

(gl::ArrayVertexBuffer::size):

  • src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
  • src/libGLESv2/geometry/IndexDataManager.h: Removed.
  • src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
  • src/libGLESv2/geometry/VertexDataManager.h: Removed.
  • src/libGLESv2/geometry/vertexconversion.h: Removed.
  • src/libGLESv2/libGLESv2.cpp:

(validateSubImageParams):
(validReadFormatType):
(Extension::glBindTexImage):

  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.rc:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/main.cpp:

(gl::getNonLostContext):
(gl::checkDeviceLost):

  • src/libGLESv2/main.h:
  • src/libGLESv2/utilities.cpp:

(gl::UniformExternalComponentCount):
(gl::UniformInternalComponentCount):
(gl::UniformComponentSize):
(gl::UniformInternalSize):
(gl::UniformExternalSize):
(gl::ComputeCompressedSize):
(gl::IsCompressed):
(gl::ExtractFormat):
(gl::ExtractType):
(dx2es::IsFloat32Format):
(dx2es::IsFloat16Format):

  • src/libGLESv2/utilities.h:

(isDeviceLostError):

17:23 Changeset [104362] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
https://bugs.webkit.org/show_bug.cgi?id=75734

Reviewed by Daniel Bates.

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::addProperty): use HashMap::add() to avoid an
extra hash lookup to set a new PropertiesVector.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • svg/properties/SVGAttributeToPropertyMap.h:
17:22 Changeset [104361] by dslomov@google.com
  • 112 edits
    4 copies
    13 moves
    97 adds
    83 deletes in trunk/LayoutTests

Unreviewed: more rebaselines in chromium after r104240.

  • platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-cg-mac/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-cg-mac/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-cg-mac/fast/dom/isindex-001-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/minWidthPercent-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png.
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4895428-3-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-mac/fast/css/line-height-expected.png: Removed.
  • platform/chromium-mac/fast/dom/isindex-001-expected.png: Removed.
  • platform/chromium-mac/fast/dom/isindex-002-expected.png: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-mac/fast/forms/encoding-test-expected.png: Removed.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png: Removed.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-spaces-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-table-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Removed.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium/fast/block/float/032-expected.png: Added.
  • platform/chromium/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.txt.
  • platform/chromium/fast/forms/input-width-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png.
  • platform/chromium/fast/forms/minWidthPercent-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/fieldset-align-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-table-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt: Renamed from LayoutTests/editing/input/caret-at-the-edge-of-input-expected.txt.
17:02 Changeset [104360] by simon.fraser@apple.com
  • 2 edits in trunk/Tools

Fix DRT build on case-sensitive file systems.

Fix case of include of WebDynamicScrollBarsView.h

  • DumpRenderTree/mac/DumpRenderTree.mm:
16:54 Changeset [104359] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=75296
JSString should not have JS_EXPORTCLASS annotation

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

  • runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Added missing symbols which were hidden by JS_EXPORTCLASS.

16:53 Changeset [104358] by abarth@webkit.org
  • 13 edits
    7 adds in trunk

Source/WebCore: WebCore implementation of the Intent object
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
for draft spec.

https://bugs.webkit.org/show_bug.cgi?id=73051

Patch by Greg Billock <gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.

Test: web-intents/web-intents-api.html

  • WebCore.gypi:
  • page/DOMWindow.idl:
  • Modules/intents/Intent.cpp: Added.

(WebCore::Intent::Intent):
(WebCore::Intent::action):
(WebCore::Intent::setAction):
(WebCore::Intent::type):
(WebCore::Intent::setType):
(WebCore::Intent::data):
(WebCore::Intent::setData):
(WebCore::Intent::create):

  • Modules/intents/Intent.h: Added.
  • Modules/intents/Intent.idl: Added.

Source/WebKit/chromium: [Web Intents] Flagged-off WebCore implementation of navigator.startActivity
https://bugs.webkit.org/show_bug.cgi?id=73051

Patch by Greg Billock <gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.

  • features.gypi:
16:49 Changeset [104357] by eae@chromium.org
  • 4 edits in branches/subpixellayout

Fix overflow in SpatialNavigation::distanceDataForNode.

16:29 Changeset [104356] by timothy_horton@apple.com
  • 5 edits
    3 adds in trunk

[cg] userSpaceOnUse SVG Patterns have the wrong origin
https://bugs.webkit.org/show_bug.cgi?id=75741
<rdar://problem/9383222>

Reviewed by Simon Fraser.

The transformation from pattern space to user space should use the userToBase CTM,
not the current CTM.

Test: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::getCTM):

  • platform/graphics/cg/TransformationMatrixCG.cpp:

(WebCore::AffineTransform::AffineTransform): Add a AffineTransform(CGAffineTransform) constructor

  • platform/graphics/transforms/AffineTransform.h:

Add a test that ensures that userSpaceOnUse patterns are rendered in the
correct orientation and location in both the accelerated compositing and
regular cases, as well as with SVG translation.

  • platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml: Added.
16:27 Changeset [104355] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSArray::pop() should compare SparseArrayValueMap::find() to SparseArrayValueMap::notFound()
https://bugs.webkit.org/show_bug.cgi?id=75757

Reviewed by Gavin Barraclough.

  • runtime/JSArray.cpp:

(JSC::JSArray::pop): Changed map->end() to map->notFound().

16:14 Changeset [104354] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

[chromium] Rebaseline media/media-document-audio-repaint after 74123 goes in.
https://bugs.webkit.org/show_bug.cgi?id=75505

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Dimitri Glazkov.

  • platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-cg-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium/test_expectations.txt:
15:41 Changeset [104353] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests/platform/chromium/fast/events/intercept-postmessage.html failing
https://bugs.webkit.org/show_bug.cgi?id=75718

Patch by Charlie Reis <creis@chromium.org> on 2012-01-06
Reviewed by Adam Barth.

Removing unnecessary log messages.

  • platform/chromium/fast/events/intercept-postmessage-expected.txt:
  • platform/chromium/fast/events/intercept-postmessage.html:
15:39 Changeset [104352] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

Avoid falling into tiled layers more often when the device scale factor is > 1
<rdar://problem/10588725>

Source/WebCore:

Reviewed by John Sullivan.

Stop taking the device scale factor into account when deciding to make
tiled layers.

Test: compositing/tiled-layers-hidpi.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer):

LayoutTests:

Reviewed by John Sullivan.

Tests that a large layer with a device scale factor of 2 is not tiled.

  • compositing/tiled-layers-hidpi-expected.txt: Added.
  • compositing/tiled-layers-hidpi.html: Added.
15:34 Changeset [104351] by simon.fraser@apple.com
  • 6 edits in trunk/Tools

Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=75662

Reviewed by Dan Bernstein.

The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
of color profile issues. Fix by keeping everything in device RGB and ensuring that the
test window uses the main display's color space, so that the pixel values in the bitmap
that gets checksummed are identical to the CSS colors.

Removed the code that switches the display profile in DRT, since that is no longer required.

  • DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(crashHandler): Remove code that switches display profiles.
(prepareConsistentTestingEnvironment): Ditto.
(dumpRenderTree): Ditto.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.

(createBitmapContext): Use DeviceRGB for the bitmap colorspace.
(createBitmapContextFromWebView): Add comment about the colorspace handling.

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage): Use a RetainPtr, add comment.
(WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
(WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.

15:28 Changeset [104350] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Touch a bunch of files in an attempt to fix Mac release builds.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):

  • accessibility/AccessibilityAllInOne.cpp:
  • editing/visible_units.cpp:

(WebCore::previousBoundary):

15:20 Changeset [104349] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

JIT stub slow paths that would be identical to that of an interpreter should be factored out
https://bugs.webkit.org/show_bug.cgi?id=75743
<rdar://problem/10657024>

Reviewed by Geoff Garen.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/CommonSlowPaths.h: Added.

(JSC::CommonSlowPaths::opInstanceOfSlow):
(JSC::CommonSlowPaths::opIn):
(JSC::CommonSlowPaths::opResolve):
(JSC::CommonSlowPaths::opResolveSkip):
(JSC::CommonSlowPaths::opResolveWithBase):
(JSC::CommonSlowPaths::opResolveWithThis):

15:16 Changeset [104348] by eae@chromium.org
  • 21 edits in branches/subpixellayout

Fix scrollbar toggling to compare pixel snapped values and update relevant test expectations.

15:13 Changeset [104347] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source/WebCore

Enable a compositing trigger for filters
https://bugs.webkit.org/show_bug.cgi?id=75658

This will enable forcing the compositing code path when filters exist for a RenderObject.

Reviewed by Simon Fraser.

No new functionality so no new tests.

  • page/ChromeClient.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):

  • rendering/RenderLayerCompositor.h:
15:01 Changeset [104346] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline editing/input/caret-at-the-edge-of-input.html.

  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
14:58 Changeset [104345] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add and use ScrollElasticityControllerClient::absoluteScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=75744

Reviewed by Dan Bernstein.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::absoluteScrollPosition):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
14:54 Changeset [104344] by abarth@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Move FrameDestructionObserver to its own file
https://bugs.webkit.org/show_bug.cgi?id=75693

Reviewed by Eric Seidel.

We should have one class per file, on general principles. Also, this
make it possible to use this class in DOMWindow without introducing a
circular include dependency.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FrameDestructionObserver.cpp: Added.

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):

  • page/FrameDestructionObserver.h: Added.

(WebCore::FrameDestructionObserver::frame):

  • plugins/DOMMimeType.h:
  • plugins/DOMPlugin.h:
14:46 Changeset [104343] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

run-api-tests: specify individual suites and tests on the command-line

Reviewed by Adam Roben.

Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

The run-api-tests script will now accept a list of arguments on
the command-line that are used as prefix filters. To run all
tests in a suite that starts with "WTF" (WTF and WTF_Vector)
use:

$ run-api-tests WTF

To run only the tests in the "WTF" suite, not the "WTF_Vector"
suite, use:

$ run-api-tests WTF.

  • Scripts/run-api-tests: Filter tests if any prefix arguments

are passed on the command-line.

14:46 Changeset [104342] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings

Reviewed by Adam Roben.

Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

  • Scripts/run-api-tests:

(dumpTestsBySuite): Update to accept array of tests instead of
hash data structure.
(runTestsBySuite): Ditto.
(listAllTests): Rename from populateTests(). Update to return
an array of tests instad of the hash data structure.

14:27 Changeset [104341] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Snow Leopard build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollBy):
Move the function definition inside #if ENABLE(RUBBER_BANDING).

14:27 Changeset [104340] by dpranke@chromium.org
  • 10 edits
    1 add in trunk/Tools

webkitpy: clean up test/uri conversion routines
https://bugs.webkit.org/show_bug.cgi?id=75648

Reviewed by Eric Seidel.

This change moves test_to_uri and uri_to_test from the Port
class to the Driver class (the routines were only being
called by the drivers), and removes a bunch of stale and/or
busted logic.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/driver.py:

(is_http_test):
(test_to_uri):
(uri_to_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(run_one_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.input_line):
(input_line):
(expected_output):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(_command_from_driver_input):

14:22 Changeset [104339] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

  • wtf/TypeTraits.cpp:
14:15 Changeset [104338] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Default HashTraits for Opcode don't work for Opcode = 0
https://bugs.webkit.org/show_bug.cgi?id=75595

Reviewed by Oliver Hunt.

Removed the populating of the m_opcodeIDTable table in the
case where the OpcodeID and Opcode are the same (m_enabled is false).
Instead we just cast the one type to the other.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):

14:14 Changeset [104337] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104330.

14:13 Changeset [104336] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed https://bugs.webkit.org/show_bug.cgi?id=75742
and updated chromium-mac expectations for fast/forms/input-disabled-color.html.

  • platform/chromium/test_expectations.txt:
14:08 Changeset [104335] by andersca@apple.com
  • 2 edits in trunk/Source/ThirdParty

Make JavaScriptCore.framework a reference and put it in a Frameworks group
https://bugs.webkit.org/show_bug.cgi?id=75740

Reviewed by Mark Rowe.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
14:01 Changeset [104334] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Thread verifier assertions when printing
https://bugs.webkit.org/show_bug.cgi?id=75738

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView dealloc]): Dealloc in main thread, so that WebFrameProxy doesn't get deref'ed from a secondary one. (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): This method calls out to client, which only expects that on main thread. (-[WKPrintingView knowsPageRange:]): Call _adjustPrintingMarginsForHeaderAndFooter on main thread.
13:57 Changeset [104333] by weinig@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a DecayArray type trait as a first step towards merging OwnPtr and OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=75737

Reviewed by Anders Carlsson.

  • wtf/TypeTraits.cpp:
  • wtf/TypeTraits.h:

Added a DecayArray trait, that can convert T[] and T[3] -> T*. DecayArray
is composed of some helpers which are also exposed, Conditional<>, which
can provide one type or another based on a boolean predicate, IsArray<>
which can deduce array types, and RemoveExtent<>, which removes the extent
from an array type.

13:55 Changeset [104332] by jonlee@apple.com
  • 3 edits
    1 add in trunk

Clicking on the cancel button on readonly and disabled search fields darkens as if the search field was editable
https://bugs.webkit.org/show_bug.cgi?id=69886
<rdar://problem/10070187>

Reviewed by Adele Peterson.

.:

  • ManualTests/search-cancel-button.html: Added.

Source/WebCore:

Tests: ManualTests/search-cancel-button.html

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton): If the input is readonly and/or disabled, force the cell to
render without highlight.

13:44 Changeset [104331] by simon.fraser@apple.com
  • 8 edits in trunk

Mitigate scrollbar differences when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=67217

Source/WebCore:

Reviewed by Dan Bernstein.

Export WebCore::Settings::mockScrollbarsEnabled() for DRT.

  • WebCore.exp.in:

Source/WebKit/mac:

Reviewed by Dan Bernstein.

Make it possible to register a custom NSScroller class, which
the WebDynamicScrollBarsView will use when mock scrollbars are enabled.

Also ensure that the WebPreferences mock scrollbars preference is
migrated into Settings.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(+[WebDynamicScrollBarsView _horizontalScrollerClass]):
(+[WebDynamicScrollBarsView _verticalScrollerClass]):
(+[WebDynamicScrollBarsView setCustomScrollerClass:]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Reviewed by Dan Bernstein.

Add an NSScroller subclass that draws mock scrollbars identically
to the WebCore mock scrollbar theme, and register it with the
WebDynamicScrollbarsView.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(-[DRTMockScroller rectForPart:]):
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
(registerMockScrollbars):
(prepareConsistentTestingEnvironment):

13:19 Changeset [104330] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

GetByteArrayLength is incorrect
https://bugs.webkit.org/show_bug.cgi?id=75735

Reviewed by Filip Pizlo.

Load the byte array length from the correct location.
This stops an existing test from hanging.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:18 Changeset [104329] by tsepez@chromium.org
  • 22 edits
    10 adds in trunk

Source/WebCore: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

Tests: http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html

http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html
http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html
http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html

  • page/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::policy):
(WebCore::ContentSecurityPolicy::headerType):

  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):

  • workers/DedicatedWorkerContext.h:

(WebCore::DedicatedWorkerContext::create):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::SharedWorkerContext):

  • workers/SharedWorkerContext.h:

(WebCore::SharedWorkerContext::create):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):

  • workers/SharedWorkerThread.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

Source/WebKit/chromium: Pass Content-security-policy directive to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::startWorkerContext):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

  • http/tests/security/contentSecurityPolicy/resources/shared-worker-make-xhr.js: Added.

(onconnect):

  • http/tests/security/contentSecurityPolicy/resources/worker-make-xhr.js: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html: Added.
  • platform/chromium/test_expectations.txt:
13:15 Changeset [104328] by mihnea@adobe.com
  • 4 edits
    6 adds in trunk

[CSSRegions]Crash while collecting svg elements in render flow thread.
https://bugs.webkit.org/show_bug.cgi?id=73735

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/svg-doc-fragment-not-collected-expected.html

fast/regions/svg-doc-fragment-not-collected.html
fast/regions/svg-element-not-collected-expected.html
fast/regions/svg-element-not-collected.html
fast/regions/svg-root-element-collected.html

By allowing only svg root elements to be collected in a render flow thread,
the svg render tree is properly constructed, thus prevented a possible further crash.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

LayoutTests:

  • fast/regions/resources/region-style.css:
  • fast/regions/svg-doc-fragment-not-collected-expected.html: Added.
  • fast/regions/svg-doc-fragment-not-collected.html: Added.
  • fast/regions/svg-element-not-collected-expected.html: Added.
  • fast/regions/svg-element-not-collected.html: Added.
  • fast/regions/svg-root-element-collected-expected.txt: Added.
  • fast/regions/svg-root-element-collected.html: Added.
13:12 Changeset [104327] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

Make TextTrackCue more mutable
https://bugs.webkit.org/show_bug.cgi?id=72555

Reviewed by Anders Carlsson.

Source/WebCore:

Test: media/track/track-cue-mutable.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Do nothing if the "ignore cue updates"

flag is set

(WebCore::HTMLMediaElement::textTrackAddCues): Block cue updates until all of the new cues have

been added, then call updateActiveTextTrackCues so update the display if necessary.

(WebCore::HTMLMediaElement::textTrackRemoveCues): Block cue updates until all of the new cues have

been removed, then call updateActiveTextTrackCues so update the display if necessary.

(WebCore::HTMLMediaElement::textTrackAddCue): Call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):

  • html/TextTrack.cpp:

(WebCore::TextTrack::cueWillChange): New, remove the cue from the media element because its

position in the interval tree is based on start and end times.

(WebCore::TextTrack::cueDidChange): Add the cue to the media element.

  • html/TextTrack.h:
  • html/TextTrackCue.cpp:

(WebCore::startKeyword): New, use a static String for the constant.
(WebCore::middleKeyword): Ditto.
(WebCore::endKeyword): Ditto.
(WebCore::horizontalKeyword): Ditto.
(WebCore::verticalKeyword): Ditto.
(WebCore::verticallrKeyword): Ditto.
(WebCore::TextTrackCue::cueWillChange): New, tell the track the cue is about to change.
(WebCore::TextTrackCue::cueDidChange): New, tell the track the cue has changed.
(WebCore::TextTrackCue::setId): New, attribute is mutable.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::direction): Ditto.
(WebCore::TextTrackCue::setDirection): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLinePosition): Ditto.
(WebCore::TextTrackCue::setTextPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::alignment): Ditto.
(WebCore::TextTrackCue::setAlignment): Ditto.
(WebCore::TextTrackCue::parseSettings): Use the static strings.

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::id):
(WebCore::TextTrackCue::startTime):
(WebCore::TextTrackCue::endTime):
(WebCore::TextTrackCue::pauseOnExit):

  • html/TextTrackCue.idl:

LayoutTests:

  • media/track/track-cue-mutable-expected.txt: Added.
  • media/track/track-cue-mutable.html: Added.
12:44 Changeset [104326] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build.

12:44 Changeset [104325] by eae@chromium.org
  • 23 edits in branches/subpixellayout/LayoutTests/platform/mac/tables

Update mac test expectations for table tests

12:38 Changeset [104324] by oliver@apple.com
  • 4 edits in trunk/Source

DFG no longer optimises CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=75729

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Rename ByteArray (in its ClassInfo) to Uint8ClampedArray to match
the future name when we switch over to the new typed-array based
ImageData specification.

  • runtime/JSByteArray.cpp:

Source/WebCore:

Remove the custom ClassInfo for CanvasPixelArray as that is
defeating ByteArray optimisation, and is no longer needed
anyway as it was only there to change the visible name.

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

12:31 Changeset [104323] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

[Mac] Sort the resources of WTF.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75639

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WTF.xcodeproj/project.pbxproj:
12:30 Changeset [104322] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERT failure due to combine-text with preceding spaces
https://bugs.webkit.org/show_bug.cgi?id=65147

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-06
Reviewed by David Hyatt.

Source/WebCore:

A couple of ASSERTs were failing due to a parsing problem when
advancing an inline iterator to the next linebreak in a
RenderCombineText. skipLeadingWhitespace advances the iterator
over leading whitespace but when searching for the line break
nextLineBreak would call RenderCombineText::combineText(),
collapsing the text so that the iterator is pointing past the
end of it.

This patch causes combineText() to be called during
skipLeadingWhiteSpace before iteration over the RenderCombineText
begins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

New test with combine-text that begins with mutiple spaces,
showing ASSERT failures in bug 65147.

  • fast/text/international/spaces-combined-in-vertical-text.html: Added
  • fast/text/international/spaces-combined-in-vertical-text-expected.txt: Added
12:25 Changeset [104321] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make ScrollAnimatorMac::snapRubberBandTimerFired use m_scrollElasticityController in more places
https://bugs.webkit.org/show_bug.cgi?id=75726

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::canScrollHorizontally):
(WebCore::ScrollAnimatorMac::canScrollVertically):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
12:22 Changeset [104320] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit1 fails to compile with USE(CFNETWORK) and HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=75675

Reviewed by Oliver Hunt.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willCacheResponse):

12:21 Changeset [104319] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Need to allow SCNetworkReachability service in sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=75724
<rdar://problem/10652415>

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
12:20 Changeset [104318] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for SourceProviderCache items
https://bugs.webkit.org/show_bug.cgi?id=75346

Reviewed by Daniel Bates.

  • parser/Parser.cpp:
  • parser/SourceProviderCache.cpp:

(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):

  • parser/SourceProviderCache.h:
12:15 Changeset [104317] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash with range selection across different documents.
https://bugs.webkit.org/show_bug.cgi?id=74285

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/Range/range-selection-across-documents-crash.html

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange):

LayoutTests:

  • fast/dom/Range/range-selection-across-documents-crash-expected.txt: Added.
  • fast/dom/Range/range-selection-across-documents-crash.html: Added.
12:12 Changeset [104316] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; fixing expectation error.

  • platform/chromium/test_expectations.txt:
12:09 Changeset [104315] by weinig@apple.com
  • 11 edits
    3 deletes in trunk/Source

Remove unused OwnFastMallocPtr class.
https://bugs.webkit.org/show_bug.cgi?id=75722

Reviewed by Geoffrey Garen.

../JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/OwnFastMallocPtr.h: Removed.
  • wtf/text/StringImpl.h:
  • wtf/wtf.pro:

../JavaScriptGlue:

  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.

../WebCore:

  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
12:07 Changeset [104314] by commit-queue@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

Convert overflow-in-uniform-regions to a reftest
https://bugs.webkit.org/show_bug.cgi?id=74765

Replaced the bitmap version of the test with a "reftest" version. Use of text
has been revised a little to mitigate the possibility that small differences in
the platform's default font will change the location of line breaks.

Patch by Hans Muller <hmuller@adobe.com> on 2012-01-06
Reviewed by Anders Carlsson.

  • fast/regions/overflow-in-uniform-regions-expected.html: Added.
  • fast/regions/overflow-in-uniform-regions.html:
  • platform/efl/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
12:05 Changeset [104313] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Need to relayout when stretching the height of a flex item
https://bugs.webkit.org/show_bug.cgi?id=75661

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/flex-align-stretch.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Always clear the override size since
it may be set when aligning.
(WebCore::RenderFlexibleBox::alignChildren): Only relayout if the height changed.

LayoutTests:

  • css3/flexbox/flex-align-stretch-expected.txt: Added.
  • css3/flexbox/flex-align-stretch.html: Added.
12:01 Changeset [104312] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add ScrollElasticityControllerClient::immediateScrollBy
https://bugs.webkit.org/show_bug.cgi?id=75720

Reviewed by Andreas Kling.

Add a new ScrollElasticityControllerClient::immediateScrollBy client member function.
Also, make ScrollAnimatorMac::smoothScrollWithEvent calls go through the ScrollElasticityController
in preparation for moving that function to ScrollElasticityController.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/ScrollElasticityController.h:
12:00 Changeset [104311] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Sort the resources of WebKit2.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75636

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WebKit2.xcodeproj/project.pbxproj:
11:53 Changeset [104310] by dgrogan@chromium.org
  • 2 edits
    2 copies in branches/chromium/963

Merge 104252 - Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.

  • storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

  • storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
  • storage/indexeddb/prefetch-bugfix-108071.html: Added.

TBR=dgrogan@chromium.org
Review URL: http://codereview.chromium.org/9121008

11:52 Changeset [104309] by dslomov@google.com
  • 51 edits
    3 copies
    82 adds in trunk/LayoutTests

2012-01-06 Dmitry Lomov <dslomov@google.com>

Unreviewed: [Chromium] rebaselining IMAGE expectations after http://trac.webkit.org/changeset/104240/

  • platform/chromium-cg-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-cg-mac-leopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-cg-mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png.
11:51 Changeset [104308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
https://bugs.webkit.org/show_bug.cgi?id=75334

Patch by Wei James <james.wei@intel.com> on 2012-01-06
Reviewed by Kenneth Russell.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo):

11:47 Changeset [104307] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit

[Mac] Sort the resources of WebKit.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75634

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WebKit.xcodeproj/project.pbxproj:
11:38 Changeset [104306] by jer.noble@apple.com
  • 4 edits in trunk

Fullscreen video controller can't be dragged the first time I enter fullscreen
https://bugs.webkit.org/show_bug.cgi?id=75709

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated video-controls-drag.html.

When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaControls):

LayoutTests:

Update the test to cover the case where the controls do not yet exist when entering
fullscreen.

  • fullscreen/video-controls-drag.html:
11:30 Changeset [104305] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests

Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.

Unreviewed.

  • platform/mac/test_expectations.txt:
11:21 Changeset [104304] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
https://bugs.webkit.org/show_bug.cgi?id=75631

Patch by Benjamin Poulain <bpoulain@webkit.org> on 2012-01-06
Reviewed by Andreas Kling.

11:13 Changeset [104303] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

Media Element: scrubbing in full-screen mode breaks playback.
https://bugs.webkit.org/show_bug.cgi?id=75650

Reviewed by John Sullivan.

Source/WebCore:

Test: fullscreen/video-controls-timeline.html

Only begin scrubbing if the panel itself is the mousedown event target.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::defaultEventHandler):

LayoutTests:

  • fullscreen/video-controls-timeline-expected.txt: Added.
  • fullscreen/video-controls-timeline.html: Added.
11:03 Changeset [104302] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Add new (failing) test to Chromium test_expectations. Fix tracked by
https://bugs.webkit.org/show_bug.cgi?id=75716

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt:
10:28 Changeset [104301] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally
https://bugs.webkit.org/show_bug.cgi?id=75200

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/video-controls-drag.html

The !important rules in fullscreenQuickTime.css are overriding the styles added by the
drag operation in MediaControlElements.cpp. Give the panel a "dragged" class in setPosition
(clearing it in resetPosition) that allows the !important rules to apply only when the
panel is not dragged.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-panel:not(.dragged)):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):

LayoutTests:

  • fullscreen/video-controls-drag-expected.txt: Added.
  • fullscreen/video-controls-drag.html: Added.
10:06 Changeset [104300] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove fast/files/domurl-script-execution-context-crash.html
from test_expectations (no longer crashing).

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt:
09:50 Changeset [104299] by jonlee@apple.com
  • 54 edits
    45 copies
    47 adds in trunk

Tools: Update DRT on Mac to draw resize handles on text areas.

Reviewed by John Sullivan.

Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
between WK1 and WK2. This will require rebaselining existing textarea pixel tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests: Rebaseline fast/forms
Rebaseline pixel tests involving textarea.

Reviewed by John Sullivan.

Moved from mac to mac-snowleopard:

  • platform/mac-snowleopard/fast/forms/001
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04
  • platform/mac-snowleopard/fast/forms/basic-buttons-expected
  • platform/mac-snowleopard/fast/forms/basic-inputs-expected
  • platform/mac-snowleopard/fast/forms/basic-selects-expected
  • platform/mac-snowleopard/fast/forms/basic-textareas-expected
  • platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected
  • platform/mac-snowleopard/fast/forms/box-shadow-override
  • platform/mac-snowleopard/fast/forms/button-align
  • platform/mac-snowleopard/fast/forms/button-generated-content
  • platform/mac-snowleopard/fast/forms/button-sizes
  • platform/mac-snowleopard/fast/forms/button-style-color
  • platform/mac-snowleopard/fast/forms/button-table-styles
  • platform/mac-snowleopard/fast/forms/button-text-transform
  • platform/mac-snowleopard/fast/forms/button-white-space
  • platform/mac-snowleopard/fast/forms/control-restrict-line-height
  • platform/mac-snowleopard/fast/forms/disabled-select-change-index
  • platform/mac-snowleopard/fast/forms/fieldset-align
  • platform/mac-snowleopard/fast/forms/file/file-input-direction
  • platform/mac-snowleopard/fast/forms/form-element-geometry
  • platform/mac-snowleopard/fast/forms/form-hides-table
  • platform/mac-snowleopard/fast/forms/input-appearance-height
  • platform/mac-snowleopard/fast/forms/input-button-sizes
  • platform/mac-snowleopard/fast/forms/input-table
  • platform/mac-snowleopard/fast/forms/input-value
  • platform/mac-snowleopard/fast/forms/menulist-style-color
  • platform/mac-snowleopard/fast/forms/option-strip-whitespace
  • platform/mac-snowleopard/fast/forms/placeholder-position
  • platform/mac-snowleopard/fast/forms/radio_checked
  • platform/mac-snowleopard/fast/forms/radio_checked_dynamic
  • platform/mac-snowleopard/fast/forms/range/slider-padding
  • platform/mac-snowleopard/fast/forms/select-align
  • platform/mac-snowleopard/fast/forms/select-baseline-expected
  • platform/mac-snowleopard/fast/forms/select-disabled-appearance
  • platform/mac-snowleopard/fast/forms/select-initial-position
  • platform/mac-snowleopard/fast/forms/select-style
  • platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected
  • platform/mac-snowleopard/fast/forms/textAreaLineHeight
  • platform/mac-snowleopard/fast/forms/textarea-align
  • platform/mac-snowleopard/fast/forms/textarea-scroll-height
  • platform/mac-snowleopard/fast/forms/textarea-width
  • platform/mac-snowleopard/fast/overflow/overflow-x-y

New pixel test results:

  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/menulist-style-color-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/radio_checked-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/forms/range/slider-padding-expected.png:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-disabled-appearance-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:

Added new results:

  • platform/mac/fast/forms/selectlist-minsize-expected.png: Added. Needs Snow Leopard baseline.
  • platform/mac/fast/forms/basic-selects-expected.txt: Rebaseline since fix of bug 74270.
  • platform/mac/fast/forms/listbox-clip-expected.png: Fix was made to have default # of options in list box to 4, instead of 5. Needed

brand new baseline, and so does Snow Leopard.

  • platform/mac/fast/forms/listbox-clip-expected.txt:
  • platform/mac/test_expectations.txt: New expectations for basic-selects.html, since the fix of bug 74270.

New baselines that were not moved to mac-snowleopard because the difference was just the resize handle.

  • platform/mac/fast/table/003-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
09:34 Changeset [104298] by tony@chromium.org
  • 4 edits in branches/chromium/wpotest/Source

Merge 103722 - [chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the

value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

TBR=tony@chromium.org

09:33 Changeset [104297] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r104296.

09:19 Changeset [104296] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • Interfaces/IWebViewPrivate.idl:
09:13 Changeset [104295] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expectations for svg/carto.net/button.svg can be updated
https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed update to Chromium test_expectations

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-06

  • platform/chromium/test_expectations.txt: Removed flakiness line for carto.net/button.svg
09:03 Changeset [104294] by jknotten@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin-in-subframe.html
https://bugs.webkit.org/show_bug.cgi?id=75706

Unreviewed.

  • platform/chromium/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
07:42 Changeset [104293] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

make canvas-lineWidth test pass even if pixel values vary a tiny bit
https://bugs.webkit.org/show_bug.cgi?id=75627

Patch by Elliot Poger <epoger@google.com> on 2012-01-06
Reviewed by Stephen White.

  • fast/canvas/canvas-lineWidth.js:

(compareRows):

07:37 Changeset [104292] by jknotten@chromium.org
  • 38 edits
    3 copies
    6 moves
    43 adds
    17 deletes in trunk/LayoutTests

Rebaseline mac results after r104240.

https://bugs.webkit.org/show_bug.cgi?id=75654 changed the way
text fields are drawn on Mac.

Unreviewed.

  • platform/chromium-cg-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-cg-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-cg-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-cg-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-cg-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/table/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-cg-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-cg-mac/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-align-expected.png: Removed.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium-mac/fast/table/003-expected.png: Removed.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png: Removed.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/45621-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/inspector/network/download-expected.txt: Added.
  • platform/chromium/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium/http/tests/inspector/network/download-expected.txt: Added.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/plugins/mouse-click-plugin-clears-selection-expected.txt.
07:28 Changeset [104291] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Fix compilation of app code against QtWebKit master header file

Unreviewed trivial build fix.

  • Source/sync.profile: Exclude util.h and testwindow.h from the master header

file, because it cannot be used outside of the WebKit source tree.

06:48 Changeset [104290] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r104060): fast/forms/textarea-metrics.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75644

Reviewed by Alexey Proskuryakov.

We need to clear the style selector on doc type change as the doc type
may affect interpretation of the stylesheets. r104060 extended the life
of the style selector in some cases, exposing this problem.

  • dom/Document.cpp:

(WebCore::Document::setDocType):

06:25 Changeset [104289] by kov@webkit.org
  • 4 edits
    2 adds in trunk

Make the new WTF module build on Gtk
https://bugs.webkit.org/show_bug.cgi?id=75669

Patch by Eric Seidel <eric@webkit.org> and Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-06

Source/JavaScriptCore:

  • GNUmakefile.am:

Source/WTF:

  • GNUmakefile.am: Added.
  • GNUmakefile.list.am: Added.
06:21 Changeset [104288] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport cache client
https://bugs.webkit.org/show_bug.cgi?id=75649

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-01-06
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/CacheClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/CacheClientBlackBerry.h: Added.
05:34 Changeset [104287] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] QQuickWebView breaks when an empty url is loaded
https://bugs.webkit.org/show_bug.cgi?id=75445

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-06
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::load):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Check if a request to load

an empty url is ignored. 'about:blank' should be used instead to load an empty page.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
05:18 Changeset [104286] by vestbo@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Remove un-needed VPATHs from project includes

Reviewed by Simon Hausmann.

04:53 Changeset [104285] by vestbo@webkit.org
  • 11 edits
    4 moves
    4 adds in trunk

[Qt] Move listing of include paths and libs to pri files in sources

Includepaths are sometimes modified by non-Qt contributors so keeping
them in files inside Sources makes it more likely that they are updated
along with project files for the other ports.

Using pri files instead of prf files for this also has the benefit that
the include() from the main target file can be parsed and followed by
Qt Creator -- something that does not work with load().

Dependency from a target to a library through the WEBKIT variable are
handled through forwarding-files in Tools/qmake/mkspecs/modules, which
set the source root of the module and include the right pri file.

Ideally we'd use the variant of include() that takes an optional
namespace to read the variables into, or the fromfile() function,
but both of these add an overhead of about 40% on the total qmake
runtime, due to making a deep copy of all the variables in the
project or re-reading all the prf files from scratch.

Reviewed by Simon Hausmann.
Reviewed by Ossy.

04:44 Changeset [104284] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Add a few more files ot OTHER_FILES

Rubber-stamped by Simon Hausmann.

04:27 Changeset [104283] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

  • platform/qt/Skipped:
03:25 Changeset [104282] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebKit/efl: [EFL] Add new pre-rendering code.
https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add new pre-rendering code to pre-render the view area more efficiently.
At first find centered view position where backing store starts to queuing the render request from.
And append the request into the tiled backing store in spiral order.

  • ewk/ewk_private.h:
  • ewk/ewk_tiled_backing_store.cpp:

(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_view.cpp:

(_ewk_view_smart_pre_render_start):
(ewk_view_base_smart_set):
(ewk_view_pre_render_start):

  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_rect_collision_check):
(_ewk_view_tiled_rect_collision_resolve):
(_ewk_view_tiled_smart_pre_render_start):
(ewk_view_tiled_smart_set):

Tools: [EFL] Add pre-render handling code in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add pre-render handling code by pressing Insert key.

  • EWebLauncher/main.c:

(on_key_down):

02:55 Changeset [104281] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75698

Unreviewed.

  • platform/chromium/test_expectations.txt:
02:31 Changeset [104280] by zeno.albisser@nokia.com
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
02:28 Changeset [104279] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

FrameDestructionObserver should be more full-service
https://bugs.webkit.org/show_bug.cgi?id=75690

Reviewed by Eric Seidel.

This patch moves code common to both subclasses of
FrameDestructionObserver into FrameDestructionObserver itself. As we
add more subclasses, we don't want to keep copy/pasting this code.

  • page/Frame.cpp:

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):

  • page/Frame.h:

(WebCore::FrameDestructionObserver::frame):

  • plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):

  • plugins/DOMMimeType.h:
  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):

  • plugins/DOMPlugin.h:
01:43 Changeset [104278] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Move MediaDocument styles into CSS. Set black background for chromium.
https://bugs.webkit.org/show_bug.cgi?id=74123

Source/WebCore:

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

Test: platform/chromium/media/video-black-bg-in-media-document.html

  • css/mediaControls.css:

(body:-webkit-full-page-media):
(video:-webkit-full-page-media):

  • css/mediaControlsChromium.css:

(body:-webkit-full-page-media):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

Adds a new chromium specific test for ensuring the background is set
properly.

Rebaselines the text portions of media-document-audio-repaint.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium/media/media-document-audio-repaint-expected.txt:
  • platform/chromium/media/video-black-bg-in-media-document-expected.txt: Added.
  • platform/chromium/media/video-black-bg-in-media-document.html: Added.
  • platform/chromium/test_expectations.txt:
01:03 Changeset [104277] by ossy@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected results after r104208.

  • platform/qt/fast/table/032-expected.png:
  • platform/qt/fast/table/032-expected.txt:
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png: Added.
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/qt/tables/mozilla/bugs/bug55694-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55694-expected.txt:
00:53 Changeset [104276] by aboxhall@chromium.org
  • 13 edits
    2 adds in trunk

Report correct line number for non-native editable text elements.
https://bugs.webkit.org/show_bug.cgi?id=71263

Reviewed by Ryosuke Niwa.

Source/WebCore:

A non-native editable text element is an element with an ARIA role of "textbox", which is
set on an element which behaves like an editable text element (such as a textarea, text
input field or contenteditable text), but whose behaviour is controlled by the author rather
than the browser.

This change makes certain methods on Node, and related methods in htmlediting and
visible_units, aware of the notion that an element may be editable only from the point of
view of assistive technology (via the ARIA textbox role), via the EditableType enum added to
EditingBoundary.h.

This is so that AccessibilityObject::lineForPosition() can use previousLinePosition(), and
AccessibilityRenderObject::indexForVisiblePosition() can use highestEditableRoot(), in a way
that respects non-native editability.

Test: accessibility/textbox-role-reports-line-number.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootAXEditableElement): Returns the root element which is
editable from the point of view of assistive technology, whether natively or otherwise.
(WebCore::AXObjectCache::nodeIsTextControl): Whether the given node is considered an
editable text element by assistive technology, natively or otherwise.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::lineForPosition): Modified to request the previous line
position in an element which is editable to Accessibility.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Modified to request the
highest root element which is editable to Accessibility.

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditableToAccessibility): Whether this node is editable to
Accessibility for the given EditableLevel.
(WebCore::Node::rootEditableElement): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.

  • dom/Node.h:

(WebCore::Node::rendererIsEditable): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
(WebCore::Node::rendererIsRichlyEditable): Overloaded version of this method which takes
an EditableType enum value indicating whether non-native editability is to be respected.

  • editing/EditingBoundary.h:
  • editing/htmlediting.cpp:

(WebCore::highestEditableRoot): Added optional EditableType parameter.
(WebCore::isEditablePosition): Added optional EditableType parameter.
(WebCore::isRichlyEditablePosition): Added optional EditableType parameter.
(WebCore::editableRootForPosition): Added optional EditableType parameter.

  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::previousLinePosition): Added optional EditableType parameter.
(WebCore::nextLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::nextLinePosition): Added optional EditableType parameter.

  • editing/visible_units.h:

LayoutTests:

  • accessibility/textbox-role-reports-line-number-expected.txt: Added.
  • accessibility/textbox-role-reports-line-number.html: Added.
00:47 Changeset [104275] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix a crash by importing an element of which local name ends with ":input".
https://bugs.webkit.org/show_bug.cgi?id=75103

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/importNode-confusing-localName.html

  • dom/Document.cpp:

(WebCore::Document::importNode): Pass QualifiedName of the source elemnt
to createElement() in order to avoid unnecessary serialization and
parsing of the qualified name

LayoutTests:

  • fast/dom/importNode-confusing-localName-expected.txt: Added.
  • fast/dom/importNode-confusing-localName.html: Added.
00:33 Changeset [104274] by tkent@chromium.org
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-06
Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
00:14 Changeset [104273] by ossy@webkit.org
  • 3 edits in trunk/Tools

NRWT should use test_expectation.txt on wk2 platforms
https://bugs.webkit.org/show_bug.cgi?id=75417

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(path_to_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_path_to_test_expectations_file):

00:09 Changeset [104272] by ossy@webkit.org
  • 13 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104268.
http://trac.webkit.org/changeset/104268
https://bugs.webkit.org/show_bug.cgi?id=75689

It broke the mac build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::shouldAutocomplete):
(WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint):
(WebCore::HTMLFormControlElementWithState::saveFormControlState):
(WebCore::HTMLFormControlElementWithState::restoreFormControlState):

  • html/HTMLFormControlElementWithState.cpp: Removed.
  • html/HTMLFormControlElementWithState.h: Removed.
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
00:07 Changeset [104271] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104259 and r104261.
http://trac.webkit.org/changeset/104259
http://trac.webkit.org/changeset/104261
https://bugs.webkit.org/show_bug.cgi?id=75688

Caused assertion failures (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.cpp:
  • dom/TreeScope.h:
  • dom/TreeScopeAdopter.cpp: Removed.
  • dom/TreeScopeAdopter.h: Removed.
00:04 Changeset [104270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=75612

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

  • wtf/text/WTFString.h:

(WTF::String::findIgnoringCase):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::String::isHashTableDeletedValue):

01/05/12:

22:41 Changeset [104269] by mitz@apple.com
  • 14 edits in trunk

<rdar://problem/10633760> Update copyright strings

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Info.plist:

Source/JavaScriptGlue:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • Info.plist:
  • PluginProcess/Info.plist:
  • WebProcess/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
21:36 Changeset [104268] by alexis.menard@openbossa.org
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
21:29 Changeset [104267] by barraclough@apple.com
  • 5 edits in trunk

Date constructor handles infinite values incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=70998

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • should be checking !finite rather then isnan.

LayoutTests:

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
    • Added test cases.
20:48 Changeset [104266] by barraclough@apple.com
  • 5 edits in trunk

date.toISOString produces incorrect results for dates with ms prior to 1970
https://bugs.webkit.org/show_bug.cgi?id=75684

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

LayoutTests:

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:
    • Added test case
20:01 Changeset [104265] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
https://bugs.webkit.org/show_bug.cgi?id=74693

Patch by Wei James <james.wei@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):

19:20 Changeset [104264] by jochen@chromium.org
  • 3 edits in trunk/Tools

Don't hardcode expected file URIs in as they depend on the platform
https://bugs.webkit.org/show_bug.cgi?id=75666

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

19:14 Changeset [104263] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r104210): Dromaeo DOM test score is lower
https://bugs.webkit.org/show_bug.cgi?id=75679

Reviewed by Andreas Kling.

The regression was caused by isDomVersionConsistent not being able to obtain the tree version
inside isLengthCacheValid when m_cachedItem is null. Fix the regression by always setting
m_cachedItem to some node when caching the length so that we can obtain the tree version later.

Also address Antti's review comment to fit m_cachedLength, m_isLengthCacheValid, and
m_isItemCacheValid all in 32-bit.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):

19:10 Changeset [104262] by ojan@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

More chromium expected results after r104208.

  • platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
  • platform/chromium-win-xp/fast/table/032-expected.png:
  • platform/chromium-win-xp/fast/table/032-expected.txt: Removed.
18:46 Changeset [104261] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed bad merge fix for r104259 which dropped a line from r104210.

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

18:13 Changeset [104260] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75593
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-01-05
Reviewed by Alexey Proskuryakov.

Null-check 'page' variable before use, to follow the common usage pattern of m_frame->page()
throughout the rest of FrameView.cpp.

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

17:58 Changeset [104259] by morrita@google.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: Followed the renaming.

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: Followed te renaming.

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp: Followed te renaming.

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()

  • dom/TreeScopeAdopter.cpp: Added.

(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • dom/TreeScopeAdopter.h: Added.

(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

17:37 Changeset [104258] by barraclough@apple.com
  • 4 edits in trunk

Array.prototype.lastIndexOf ignores undefined fromIndex.
https://bugs.webkit.org/show_bug.cgi?id=75678

Reviewed by Sam Weinig.

Source/JavaScriptCore:

array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncLastIndexOf):

  • should check argumnet count, rather than checking agument value for undefined.

LayoutTests:

  • ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
    • check in passing result
17:32 Changeset [104257] by jochen@chromium.org
  • 8 edits in trunk

Source/WebCore: Disallow access to DOM storage from detached frames.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):

Source/WebKit/chromium: Check whether a WebView exists before accessing it in StorageAreaProxy. This is not necessarily the case, e.g. for detached iframes.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests: Unskip fast/storage/storage-detached-iframe.html on chromium
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • fast/storage/storage-detached-iframe-expected.txt:
  • fast/storage/storage-detached-iframe.html:
  • platform/chromium/test_expectations.txt:
17:32 Changeset [104256] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

17:29 Changeset [104255] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
https://bugs.webkit.org/show_bug.cgi?id=75598

Use VERTEX_SHADER() and FRAGMENT_SHADER() macros, instead of quoted string literals when
declaring shaders in TextureMapperGL.

We need two macros to account for the differences between OpenGL and OpenGL ES2.

Reviewed by Martin Robinson.

17:19 Changeset [104254] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

sizeof(CSSRule) is 20 instead of 12 on Windows
https://bugs.webkit.org/show_bug.cgi?id=75665

Reviewed by Darin Fisher.

Unlike gcc and clang, MSVC pads each consecutive member variables of the same type
in bitfields. e.g. if you have:

sturct AB {
unsigned m_1 : 31;
bool m_2 : 1;
}

then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang
only allocate sizeof(unsigned) * 1 for AB.

Fix the bloat by turning all bitfields in CSSRule either signed or unsigned integers.

  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::sourceLine):
(WebCore::CSSRule::setSourceLine):
(WebCore::CSSRule::hasCachedSelectorText):
(WebCore::CSSRule::setHasCachedSelectorText):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::cleanup):
(WebCore::CSSStyleRule::selectorText):
(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleRule.h:
17:17 Changeset [104253] by lforschler@apple.com
  • 1 copy in tags/Safari-535.15

New Tag.

17:15 Changeset [104252] by dgrogan@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.

  • storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

  • storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
  • storage/indexeddb/prefetch-bugfix-108071.html: Added.
17:08 Changeset [104251] by barraclough@apple.com
  • 5 edits in trunk

Date parsing is too restrictive.
https://bugs.webkit.org/show_bug.cgi?id=75671

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

ES5 date parsing currently requires all fields to be present, which does not match the spec (ES5.1 15.9.1.15).
The spec allow a date to be date only, or date + time.

The date portion on the should match: (pseudocode!:)

[(+)YY]YYYY[-MM[-DD]]

though we are slightly more liberal (permitted by the spec), allowing:

[+]Y+[-MM[-DD]]

The time portion should match:

THH:mm[:ss[.sss]][Z|(+|-)HH:mm]

again we're slightly more liberal, allowing:

THH:mm[:ss[.s+]][Z|(+|-)HH:mm]

  • wtf/DateMath.cpp:

(WTF::parseES5DatePortion):

  • Month/day fields are optional, default to 01.

(WTF::parseES5TimePortion):

  • Hours/Minutes are requires, seconds/timezone are optional.

(WTF::parseES5DateFromNullTerminatedCharacters):

  • Dates may be date only, or date + time.

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
    • Add more test cases for Date.parse.
17:05 Changeset [104250] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r100203.

17:02 Changeset [104249] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r99999.

17:01 Changeset [104248] by jamesr@google.com
  • 13 edits in trunk/Source

[chromium] Route all animate calls through CCLayerTreeHost in composited mode to simplify rate limiting logic
https://bugs.webkit.org/show_bug.cgi?id=75577

Reviewed by Darin Fisher.

Source/WebCore:

This internalizes the animation rate limiting logic to CCLayerTreeHost and removes the setters/getters for the
m_animating flag. This requires that all animation updates have to go through CCLayerTreeHost to get the right
rate limiting behavior, regardless of which proxy is being used.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::layout):
(WebCore::CCLayerTreeHost::startRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

Routes WebWidget-initiated animate() calls through the CCLayerTreeHost in composited mode. CCLayerTreeHost's
rate limiting logic needs to be aware of when requestAnimationFrame callbacks are run. In threaded mode, the
animate calls are driven from CCThreadProxy and so the CCLayerTreeHost can set whatever state it needs. This
makes the single-threaded mode where the animate calls are driven through the WebWidget interface outside of the
CCProxy's control.

This is a small step towards inverting the scheduling control from the WebWidget to the compositor.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

  • src/WebViewImpl.h:
16:54 Changeset [104247] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/dom/Element.cpp

Fix rounding for adjustForLocalZoom

16:44 Changeset [104246] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] NativeImageSkia should mark SkBitmaps as immutable
https://bugs.webkit.org/show_bug.cgi?id=74962

Removed m_isDataComplete from class NativeImageSkia. Instead, data
completeness will be tracked through SkBitmap::setImmutable/
isImmutable. The immutable state signifies that the pixel data
will no longer change for the lifetime of the bitmap, which corresponds
to the semantic of the old m_isDataComplete member. setImmutable is
also called on the cached resized bitmap, since it too is invariant for
its life time. Temporary resized bitmaps are also marked as immutable
since they technically are.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-05
Reviewed by Stephen White.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore::NativeImageSkia::setDataComplete):
(WebCore::NativeImageSkia::isDataComplete):

16:42 Changeset [104245] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark flaky test as flaky. Filed
https://bugs.webkit.org/show_bug.cgi?id=75647 about making it not
flaky.

  • platform/chromium/test_expectations.txt:
16:39 Changeset [104244] by abarth@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r104231.
http://trac.webkit.org/changeset/104231
https://bugs.webkit.org/show_bug.cgi?id=75668

Breaks the Qt build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-05

Source/WebCore:

  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::acceptNavigationRequest):

16:36 Changeset [104243] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r99756.

16:33 Changeset [104242] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r99731.

16:32 Changeset [104241] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Resize requests at the view level should be ignored when in autoresize mode.
https://bugs.webkit.org/show_bug.cgi?id=75651

Reviewed by Dmitry Titov.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize): The assert was here to catch a view that
tried to do a resize after setting autoresize. However, we found that generic
code tries to do resizes as well. Rather than special case each caller,
we'll just make this code ignore the resize call.

16:30 Changeset [104240] by bdakin@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75654
Text fields should draw using NSTextFieldCell instead of WebKitSystemInterface

Reviewed by John Sullivan.

This change should not have any affect on tests or real web sites. It just changed
the implementation under the hood to the more modern NSCell approach.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

16:29 Changeset [104239] by andersca@apple.com
  • 7 edits
    2 adds in trunk

Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
https://bugs.webkit.org/show_bug.cgi?id=75667
<rdar://problem/10389454>

Reviewed by Kevin Decker.

Source/WebKit2:

NPRuntimeObjectMap::invalidate is called whenever a plug-in view is destroyed. If invalidate is called for an object map
whose plug-in has a null frame, we'd crash.

The plug-in will have a null frame if the plug-in view is destroyed because its containing frame has been removed from the document,
and if the plug-in view is being destroyed asynchronously due to the plug-in itself calling JavaScript that will remove the frame
(see PluginView::unprotectPluginFromDestruction).

The reason NPRuntimeObjectMap::invalidate will crash when the frame is null is because we were trying to access the frame's global
object, causing a null dereference. The reason we were trying to get at the frame's global object was to create a Strong handle to
a JSNPObject so we could stick the object in a vector so we could later iterate over the vector elements and call invalidate() on
each JSNPObject which will end up releasing the underlying NPObject.

However, it turns out that we don't need to stick the JSNPObject in a vector; we can just get the underlying NPObject directly and
stick that in a vector and then iterate over the NPObjects, releasing them.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

Tools:

Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::executeScript):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:

(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):

LayoutTests:

  • plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
  • plugins/npruntime/object-from-destroyed-plugin-in-subframe.html: Added.
16:15 Changeset [104238] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r99579.

16:12 Changeset [104237] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r99462.

16:01 Changeset [104236] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Add a compile-time assertion for the size of CSSValue
https://bugs.webkit.org/show_bug.cgi?id=75635

Reviewed by Tony Chang.

Tightened the compile-time assertion.

  • css/CSSValue.cpp:
15:59 Changeset [104235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Undefined references to ICU_I18N symbols on WTF
https://bugs.webkit.org/show_bug.cgi?id=75642

Unreviewed build fix.

Add ${ICU_I18N_LIBRARIES} to WTF_LIBRARIES on wtf efl platform cmake.
Some undefined references were ucol_setAttribute_44, ucol_close_44,
ucol_getAttribute_44...

Patch by Bruno Dilly <bdilly@profusion.mobi> on 2012-01-05

  • wtf/PlatformEfl.cmake:
15:57 Changeset [104234] by eae@chromium.org
  • 6 edits in branches/subpixellayout/LayoutTests/platform/mac/fast/forms

Update mac test expectations for a couple of form tests.

15:57 Changeset [104233] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

[V8] CodeGeneration for SerializedScriptValue doesn't play nice with [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=75641

Reviewed by David Levin.

Rather than generate getters for SerializedScriptValues, we eagerly
deserialize them into JavaScript objects. However, previously, we were
only doing that for DOM wrappers created by taking an existing C++
object and wrapping it. For objects created with Constructors (e.g.,
those with the [Constructor] attribute), we need to do this eager
deserialization during the constructor as well.

This bug isn't observable yet, but it is causing the WebIntent test
being added in Bug 73051 to fail.

Test: TestSerializedScriptValueInterface.idl

webintents/web-intents-api.html (after Bug 73051 lands)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEagerDeserialization):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
15:45 Changeset [104232] by ojan@chromium.org
  • 7 edits
    1 move
    4 adds
    2 deletes in trunk/LayoutTests

New chromium expected results after r104208.

  • platform/chromium-linux/fast/table/032-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-mac-leopard/fast/table/032-expected.png:
  • platform/chromium-mac-leopard/fast/table/032-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55694-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug55694-expected.png: Removed.
  • platform/chromium-win-xp/fast/table/032-expected.png: Added.
  • platform/chromium-win-xp/fast/table/032-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/table/032-expected.txt.
  • platform/chromium-win/fast/table/032-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.txt:
15:11 Changeset [104231] by abarth@webkit.org
  • 5 edits in trunk/Source

Introduce Platform namespace for WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=75653

Reviewed by Eric Seidel.

Source/WebCore:

This patch introduces the Platform namespace for WebCore/platform.
Introducing this namespace will help us find and fix layering
violations in preparation for moving WebCore/platform to Platform.

  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::acceptNavigationRequest):

15:07 Changeset [104230] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up port factory methods
https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(_port_name_from_arguments_and_options):
(get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(_verify_baseline_path):

15:04 Changeset [104229] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r98912-r99538): Crash in WebKit::WebFrameLoaderClient::didDetectXSS
https://bugs.webkit.org/show_bug.cgi?id=75578

Reviewed by Daniel Bates.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
Check for a correct struct member existence.

14:58 Changeset [104228] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r103479.

14:55 Changeset [104227] by lforschler@apple.com
  • 14 edits in branches/safari-534.54-branch/Source

Merged r99439.

14:42 Changeset [104226] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/mac

Merged r98970.

14:39 Changeset [104225] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r98796.

14:37 Changeset [104224] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98781.

14:35 Changeset [104223] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r98763.

14:35 Changeset [104222] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Remove unused pixelSnapped methods from RenderBox.

14:33 Changeset [104221] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch

Merged r98561.

14:30 Changeset [104220] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r96294.

14:30 Changeset [104219] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Refined the fast path for StringImpl::hash()
https://bugs.webkit.org/show_bug.cgi?id=75178

Reviewed by Darin Adler.

Moved the hash calculation code into an out-of-line function to clean up
the hot path.

No measurable benchmark change, but this knocks some samples off in
Instruments, and I think this is a step toward removing -fomit-frame-pointer.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::hashSlowCase):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::hash): The patch.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::hashSlowCase): Abide by the cockamamie Windows build
scheme, which requires all out-of-line StringImpl functions used by
WebCore be defined in this file instead of StringImpl.cpp. (See http://trac.webkit.org/changeset/59187.)

14:29 Changeset [104218] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: Updating expecxtations for fast/media/viewport-media-query.
My understanding of the semantics was a bit off.

  • platform/chromium/test_expectations.txt:
14:04 Changeset [104217] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98513.

14:03 Changeset [104216] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r98374.

14:01 Changeset [104215] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98362.

14:00 Changeset [104214] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r98344.

13:58 Changeset [104213] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98186.

13:56 Changeset [104212] by barraclough@apple.com
  • 5 edits in trunk

Literal tab in JSONString fails
https://bugs.webkit.org/show_bug.cgi?id=71772

Reviewed by Oliver Hunt.

rfc4627 does not allow literal tab characters in JSON source.

Source/JavaScriptCore:

  • runtime/LiteralParser.cpp:

(JSC::isSafeStringCharacter):

  • do not allow literal tab in StrictJSON mode.

LayoutTests:

  • fast/js/JSON-parse-expected.txt:
  • fast/js/resources/JSON-parse.js:

(createTests.result):

  • Updated expected results.
13:56 Changeset [104211] by lforschler@apple.com
  • 7 edits
    5 copies in branches/safari-534.54-branch

Merge 98033.

13:48 Changeset [104210] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
https://bugs.webkit.org/show_bug.cgi?id=73853

Reviewed by Antti Koivisto.

Lazily invalidate the node list caches instead of invaliding them at the time of modification. We use
the DOM tree version to detect whether caches need to be invalidated or not. We now invalidate caches more
frequently after this patch (in particular, invalidates caches that are stored on nodes not present in
the ancestry of the modified nodes); however, our study on major Web sites such as Gmail, Facebook, Twitter,
etc... indicate that about 1% of real-world usage benefits from keeping the caches alive across different
DOM tree versions.

In order to invalidate caches lazily, this patch adds replaces the type of m_caches in DynamicSubtreeNodeList
by DynamicSubtreeNodeList::SubtreeCaches which encapsulates member variables in DynamicNodeList::Caches and
invalidates values as needed. Also this change allows m_caches to be allocated as a part of
DynamicSubtreeNodeList instead of a separate ref-counted object.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicNodeList::Caches::create):
(WebCore::DynamicNodeList::Caches::reset):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedLength): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItemOffset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::reset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent): Added.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively): Clear caches when a node moves from one document to another.
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Only clears child node list of Attr.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Only clears child node list.
(WebCore::NodeListsNodeData::invalidateCaches): Merged with invalidateCachesThatDependOnAttributes.

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:
  • html/HTMLLabelElement.h:
13:41 Changeset [104209] by wjmaclean@chromium.org
  • 3 edits
    1 copy in trunk/Source/WebKit/chromium

[chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns incorrect value, causing accelerated content to not display in Aura desktop
https://bugs.webkit.org/show_bug.cgi?id=75551

Reviewed by James Robinson.

  • WebKit.gypi:
  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):

  • tests/WebExternalTextureLayerImplTest.cpp: Copied from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
13:39 Changeset [104208] by ojan@chromium.org
  • 8 edits
    3 adds in trunk

IE quirk for percentage size on a table element doesn't work with orthogonal writing modes
https://bugs.webkit.org/show_bug.cgi?id=70195

Reviewed by Eric Seidel.

Source/WebCore:

Remove this quirk entirely. Mozilla and Opera don't implement it and IE
doesn't restrict the quirk to standards mode. As it's unlikely for
webkit-only content to hit this quirk (e.g. use tables for layout),
it should be relatively safe to match Mozilla/Opera here.

Test: fast/writing-mode/table-percent-width-quirk.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/table/032.html:
  • fast/writing-mode/table-percent-width-quirk-expected.png: Added.
  • fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • fast/writing-mode/table-percent-width-quirk.html: Added.
  • platform/mac/fast/table/032-expected.png:
  • platform/mac/fast/table/032-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55694-expected.png:
  • platform/mac/tables/mozilla/bugs/bug55694-expected.txt:
13:37 Changeset [104207] by eae@chromium.org
  • 11 edits in branches/subpixellayout/Source

Change IntrinsicSize back to an IntSize and get rid of extraneous rounding.

13:25 Changeset [104206] by jochen@chromium.org
  • 6 edits in trunk/Tools

Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
https://bugs.webkit.org/show_bug.cgi?id=75617

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.exists):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.exists):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(GenericFileSystemTests.teardown_generic_test_dir):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_results_directory_absolute):

13:22 Changeset [104205] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r98010.

13:19 Changeset [104204] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97927.

13:11 Changeset [104203] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r97786.

13:04 Changeset [104202] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r97524.

13:01 Changeset [104201] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97502.

12:57 Changeset [104200] by lforschler@apple.com
  • 10 edits in branches/safari-534.54-branch

Merged r97402.

12:53 Changeset [104199] by nduca@chromium.org
  • 4 edits
    3 adds in trunk/Source

[chromium] Add CCTimer class for the compositor
https://bugs.webkit.org/show_bug.cgi?id=74769

Patch by Tien Ren Chen <trchen@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Add a simple timer class for CCThread that the timered task can be
manually cancelled.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCTimer.cpp: Added.

(WebCore::CCTimerTask::CCTimerTask):
(WebCore::CCTimerTask::~CCTimerTask):
(WebCore::CCTimerTask::performTask):
(WebCore::CCTimer::CCTimer):
(WebCore::CCTimer::~CCTimer):
(WebCore::CCTimer::startOneShot):
(WebCore::CCTimer::stop):

  • platform/graphics/chromium/cc/CCTimer.h: Added.

(WebCore::CCTimerClient::~CCTimerClient):
(WebCore::CCTimer::isActive):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCTimerTest.cpp: Added.

(WebKitTests::CCTimerTest::CCTimerTest):
(WebKitTests::CCTimerTest::onTimerFired):
(WebKitTests::TEST_F):

12:48 Changeset [104198] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

WK2: Safari fails to open a PostScript file in Preview from context menu
https://bugs.webkit.org/show_bug.cgi?id=75643
<rdar://problem/9823430>

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData): Append ".pdf" to file name when converting data, as suggested file name is created for original MIME type.
12:44 Changeset [104197] by eric.carlson@apple.com
  • 10 edits
    24 adds in trunk

Implement temporal dimension portion of Media Fragments URI specification for video/audio
https://bugs.webkit.org/show_bug.cgi?id=65838

Reviewed by Sam Weinig.

Source/WebCore:

Tests: media/media-fragments/TC0001-TC0009.html

media/media-fragments/TC0010-TC0019.html
media/media-fragments/TC0020-TC0029.html
media/media-fragments/TC0030-TC0039.html
media/media-fragments/TC0040-TC0049.html
media/media-fragments/TC0050-TC0059.html
media/media-fragments/TC0060-TC0069.html
media/media-fragments/TC0070-TC0079.html
media/media-fragments/TC0080-TC0089.html
media/media-fragments/TC0090-TC0099.html

  • CMakeLists.txt: Add fragment parser files.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_fragmentStartTime and m_fragmentEndTime.
(WebCore::HTMLMediaElement::setReadyState): Check for and parse a media fragment once readyState

reaches HAVE_METADATA, apply it once it reaches HAVE_CURRENT_DATA.

(WebCore::HTMLMediaElement::initialTime): Return the fragment start time if possible.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Pause if the time is >= the fragment

end time.

(WebCore::HTMLMediaElement::prepareMediaFragmentURI): Look for a temporal fragment.
(WebCore::HTMLMediaElement::applyMediaFragmentURI): Apply the fragment, if any.

  • html/HTMLMediaElement.h:
  • html/MediaFragmentURIParser.cpp: Added.

(WebCore::skipWhiteSpace):
(WebCore::collectDigits):
(WebCore::collectFraction):
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseFragments):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
(WebCore::MediaFragmentURIParser::parseNPTFragment):
(WebCore::MediaFragmentURIParser::parseNPTTime):

  • html/MediaFragmentURIParser.h: Added.

(WebCore::MediaFragmentURIParser::~MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::create):

LayoutTests:

  • media/media-fragments: Added.
  • media/media-fragments/TC0001-TC0009-expected.txt: Added.
  • media/media-fragments/TC0001-TC0009.html: Added.
  • media/media-fragments/TC0010-TC0019-expected.txt: Added.
  • media/media-fragments/TC0010-TC0019.html: Added.
  • media/media-fragments/TC0020-TC0029-expected.txt: Added.
  • media/media-fragments/TC0020-TC0029.html: Added.
  • media/media-fragments/TC0030-TC0039-expected.txt: Added.
  • media/media-fragments/TC0030-TC0039.html: Added.
  • media/media-fragments/TC0040-TC0049-expected.txt: Added.
  • media/media-fragments/TC0040-TC0049.html: Added.
  • media/media-fragments/TC0050-TC0059-expected.txt: Added.
  • media/media-fragments/TC0050-TC0059.html: Added.
  • media/media-fragments/TC0060-TC0069-expected.txt: Added.
  • media/media-fragments/TC0060-TC0069.html: Added.
  • media/media-fragments/TC0070-TC0079-expected.txt: Added.
  • media/media-fragments/TC0070-TC0079.html: Added.
  • media/media-fragments/TC0080-TC0089-expected.txt: Added.
  • media/media-fragments/TC0080-TC0089.html: Added.
  • media/media-fragments/TC0090-TC0099-expected.txt: Added.
  • media/media-fragments/TC0090-TC0099.html: Added.
  • media/media-fragments/media-fragments.js: Added.

(canplaythrough):
(setupNextTest):
(nextTestName):
(start):

12:44 WebKit Team edited by aestes@apple.com
(diff)
12:41 Changeset [104196] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[v8] Null pointer exception if a typed array constructor set to a primitive value.
https://bugs.webkit.org/show_bug.cgi?id=75532

Make sure that V8ArrayBufferViewCustomScript.js does not throw exception.

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-05
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
12:28 Changeset [104195] by aroben@apple.com
  • 2 edits in trunk/Tools

Remove some unnecessary code from old-run-webkit-tests

Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
WebKitTestRunner.

Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
Windows

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:

(top level):
(openDumpTool):
Removed calls to setPathForRunningWebKitApp.

12:18 Changeset [104194] by mrobinson@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit/gtk

[GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated compositing implementations
https://bugs.webkit.org/show_bug.cgi?id=75519

Reviewed by Alejandro G. Castro.

Add an AcceleratedCompositingContext which will isolate all the different accelerated compositing
implementations from one another. For right now this just includes the Clutter version.

  • GNUmakefile.am: Add the new files to the source list.
  • WebCoreSupport/AcceleratedCompositingContext.h: Added.
  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added. Existing

clutter AC code has moved here.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::attachRootGraphicsLayer): Use the new AccleratedCompositingContext now
instead of calling into the WebView.
(WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization):Ditto.
(WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.

  • webkit/webkitwebview.cpp:

(webkit_web_view_size_allocate): Call in the ACContext.
(webkit_web_view_init): Initialize the ACContext.

  • webkit/webkitwebviewprivate.h: Add the ACContext as a private member.
12:04 Changeset [104193] by zeno.albisser@nokia.com
  • 22 edits
    13 adds in trunk

[Qt][WK2] Implement custom URL schemes defined in QML.
https://bugs.webkit.org/show_bug.cgi?id=74931

.:

Add new classes to the export map.

Reviewed by Kenneth Rohde Christiansen.

  • Source/qtwebkit-export.map:

Source/WebKit/qt:

Make classes QQuickUrlSchemeDelegate, QQuickNetworkRequest
and QQuickNetworkReply accessible from QML.

Reviewed by Kenneth Rohde Christiansen.

  • declarative/experimental/experimental.pri:
  • declarative/experimental/plugin.cpp:
  • declarative/public.pri:

Source/WebKit2:

Allow creation of custom UrlSchemeDelegates from QML.
A UrlSchemeDelegate contains a handler signal that is triggered
when a url matching the defined scheme is requested.
To allow for this a derivation of QNetworkAccessManager
is necessary.
The request is then handled in QML/JS and a reply
is sent back from the UIProcess to the WebProcess.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/qt/QtNetworkReplyData.cpp: Added.

(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h: Added.
  • Shared/qt/QtNetworkRequestData.cpp: Added.

(WebKit::QtNetworkRequestData::QtNetworkRequestData):
(WebKit::QtNetworkRequestData::encode):
(WebKit::QtNetworkRequestData::decode):

  • Shared/qt/QtNetworkRequestData.h: Added.
  • Target.pri:
  • UIProcess/API/qt/qquicknetworkreply.cpp: Added.

(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::contentType):
(QQuickNetworkReply::setContentType):
(QQuickNetworkReply::operation):
(QQuickNetworkReply::setOperation):
(QQuickNetworkReply::contentDisposition):
(QQuickNetworkReply::setContentDisposition):
(QQuickNetworkReply::location):
(QQuickNetworkReply::setLocation):
(QQuickNetworkReply::lastModified):
(QQuickNetworkReply::setLastModified):
(QQuickNetworkReply::cookie):
(QQuickNetworkReply::setCookie):
(QQuickNetworkReply::userAgent):
(QQuickNetworkReply::setUserAgent):
(QQuickNetworkReply::server):
(QQuickNetworkReply::setServer):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
(QQuickNetworkReply::networkRequestData):
(QQuickNetworkReply::setNetworkRequestData):
(QQuickNetworkReply::networkReplyData):

  • UIProcess/API/qt/qquicknetworkreply_p.h: Added.
  • UIProcess/API/qt/qquicknetworkrequest_p.h: Added.
  • UIProcess/API/qt/qquickurlschemedelegate.cpp: Added.

(QQuickUrlSchemeDelegate::QQuickUrlSchemeDelegate):
(QQuickUrlSchemeDelegate::scheme):
(QQuickUrlSchemeDelegate::setScheme):
(QQuickUrlSchemeDelegate::request):
(QQuickUrlSchemeDelegate::reply):

  • UIProcess/API/qt/qquickurlschemedelegate_p.h: Added.
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):
(QQuickWebViewExperimental::invokeApplicationSchemeHandler):
(QQuickWebViewExperimental::sendApplicationSchemeReply):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleApplicationSchemeRequest):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::registerApplicationScheme):
(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::registerApplicationScheme):
(WebKit::WebPage::receivedApplicationSchemeRequest):
(WebKit::WebPage::applicationSchemeReply):

  • WebProcess/qt/QtNetworkAccessManager.cpp: Added.

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):
(WebKit::QtNetworkAccessManager::createRequest):
(WebKit::QtNetworkAccessManager::registerApplicationScheme):

  • WebProcess/qt/QtNetworkAccessManager.h: Added.
  • WebProcess/qt/QtNetworkReply.cpp: Added.

(WebKit::QtNetworkReply::QtNetworkReply):
(WebKit::QtNetworkReply::setData):
(WebKit::QtNetworkReply::setReplyData):
(WebKit::QtNetworkReply::readData):
(WebKit::QtNetworkReply::bytesAvailable):
(WebKit::QtNetworkReply::setHeader):
(WebKit::QtNetworkReply::abort):
(WebKit::QtNetworkReply::close):
(WebKit::QtNetworkReply::setReadBufferSize):
(WebKit::QtNetworkReply::canReadLine):
(WebKit::QtNetworkReply::finalize):

  • WebProcess/qt/QtNetworkReply.h: Added.
  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

12:02 Changeset [104192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove style warning in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75466

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-01-05
Reviewed by Kenneth Russell.

Relocated some headers according to alphabetical order & modified indentation.
And used OwnArrayPtr to deal with character array.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

11:55 Changeset [104191] by aroben@apple.com
  • 3 edits in trunk/Tools

Teach NRWT to use run-safari to open results.html on Apple's Windows port

NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
better, since we always want to open results.html using the user's build of WebKit, not
whatever their default browser is.

Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
for Apple's Windows port

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
an obsolete comment.

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_show_results_html_file): Updated expected results.

11:55 Changeset [104190] by aroben@apple.com
  • 2 edits in trunk/Tools

Prepend Safari.exe's path to the command-line passed to CreateProcess

Safari expects the first argument in the command-line to be the path to Safari.exe itself.
This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
was not including the path to Safari.exe in the command-line, so Safari was ignoring the
first argument that WebKitLauncherWin was trying to pass to it.

Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari

Reviewed by Steve Falkenburg.

  • WebKitLauncherWin/WebKitLauncherWin.cpp:

(_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.

11:55 Changeset [104189] by aroben@apple.com
  • 2 edits in trunk/Tools

Stop using explicit memory management in WebKitLauncherWin

We now use stack-allocated STL objects instead.

Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
Safari

Reviewed by Steve Falkenburg.

  • WebKitLauncherWin/WebKitLauncherWin.cpp:

(getStringValue):
(applePathFromRegistry):
(safariInstallDir):
(safariBrowserExe):
(_tWinMain):
Changed to use stack-allocated STL objects instead of malloc/free.

11:54 Changeset [104188] by aroben@apple.com
  • 7 edits
    1 copy
    7 adds in trunk

Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Safari and Apple Application Support directories to PATH before
trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.

Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner

Reviewed by Steve Falkenburg.

Tools:

  • WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and

ImageDiffLauncher, which I forgot to add to this .sln when that project was created.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.

  • WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from

Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
the stub launcher.

  • WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/main.cpp:

(dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.

Source/WebKit/win:

Add WebKitTestRunnerLauncher to WebKit.sln.

It builds just after WebKitTestRunner.

  • WebKit.vcproj/WebKit.sln:
11:53 Changeset [104187] by aroben@apple.com
  • 8 edits
    8 adds in trunk

Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Safari and Apple Application Support directories to PATH before
trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.

Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner

Reviewed by Steve Falkenburg.

Tools:

  • DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,

which I forgot to add to this .sln when that project was created.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops:

Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.

  • DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
  • win/DLLLauncher/DLLLauncherMain.cpp:

(modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
Safari's directory to PATH so that SafariTheme.dll can be found.

(main):
(wWinMain):
Changed to use the new modifyPath function.

Source/WebKit/win:

Add DumpRenderTreeLauncher to WebKit.sln.

It builds just after DumpRenderTree.

  • WebKit.vcproj/WebKit.sln:
11:46 Changeset [104186] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Fix debug build.

Reviewed by Oliver Hunt.

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:35 Changeset [104185] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip file-reader-event-listener.html on qt and efl.

  • platform/efl/Skipped:
  • platform/qt/Skipped:
11:32 Changeset [104184] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

push/shift fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75610

Reviewed by Sam Weinig.

Array object commonly store data in a vector, consisting of a portion that is
in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to shift with grow the pre-capacity, and
the current algorithm for increaseVectorLength (used by push, or Put?) will
never shrink the pre-capacity, so a push/shift fifo may consume an inordinate
amount of memory, whilst having a relatively small active length.

  • runtime/JSArray.cpp:

(JSC::JSArray::increaseVectorLength):

  • If m_indexBias is non-zero, decay it over time.
11:24 Changeset [104183] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Crash due to reparenting of relpositioned object under anonymous block
https://bugs.webkit.org/show_bug.cgi?id=70848

The associated test case creates a condition where a relative
positioned renderer is a descendant of an anonymous block for a
table column. The anonymous block is the containingBlock() for the
relpositioned renderer. Removal of a div causes the anonymous blocks to
be merged, and the renderer becomes a descendant of a different block.
Since the new containingBlock() has an empty positionedObject list,
the relpositioned renderer does not get layout after being dirtied.

This patch changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous
block itself. It also adds an ASSERT to insertPositionedObject()
to flag any other cases where something is trying to create a
positioned object list on an anonymous block.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

LayoutTests: Crash due to reparenting of relpositioned object in table
https://bugs.webkit.org/show_bug.cgi?id=70848

Adding test that exercises the crash condition in bug 70848.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Added
  • fast/css/relative-position-replaced-in-table-display-crash.html: Added
11:15 Changeset [104182] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed WK75633 and updated expectations

  • platform/chromium/test_expectations.txt:
11:03 Changeset [104181] by psolanki@apple.com
  • 4 edits in trunk/Source/WebKit/mac

WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions
https://bugs.webkit.org/show_bug.cgi?id=75586

Reviewed by Alexey Proskuryakov.

We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView
userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function,
_userAgentString that returns a WTF::String to make this call faster.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::userAgent):

  • WebView/WebView.mm:

(-[WebView _userAgentString]):
(-[WebView userAgentForURL:]):

  • WebView/WebViewInternal.h:
10:59 Changeset [104180] by jianli@chromium.org
  • 3 edits
    2 adds in trunk

FileReader needs addEventListener
https://bugs.webkit.org/show_bug.cgi?id=42723

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/file-reader-event-listener.html

  • fileapi/FileReader.idl:

LayoutTests:

  • fast/files/file-reader-event-listener-expected.txt: Added.
  • fast/files/file-reader-event-listener.html: Added.
10:50 WebKit Team edited by adele@apple.com
(diff)
10:38 Changeset [104179] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove deprecated calls from CookieJarCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=68958

Reviewed by Sam Weinig.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):

10:36 Changeset [104178] by dglazkov@chromium.org
  • 5 edits
    1 delete in branches/chromium/912

Revert 91125 - 2011-07-15 Rob Buis <rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:

TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/9116011

10:28 Changeset [104177] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, tighted up the expectations for some perf tests.

  • platform/chromium/test_expectations.txt:
10:26 Changeset [104176] by enne@google.com
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Create unit tests for CCTiledLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=75557

Reviewed by James Robinson.

Add some quad generation tests for tiled layers.

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Added.

(WebCore::createLayer):
(WebCore::TEST):
(WebCore::completelyContains):
(WebCore::getQuads):
(WebCore::verifyQuadsExactlyCoverRect):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):

10:19 WebKit Team edited by dgrogan@chromium.org
(diff)
10:18 Changeset [104175] by dglazkov@chromium.org
  • 5 edits
    6 copies
    2 deletes in branches/chromium/963

Merge 101903 - REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.
(WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly
(WebCore::Path::transform) : Now uses CGPathIsEmpty directly

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/9111020

10:16 Changeset [104174] by fsamuel@chromium.org
  • 35 edits in trunk

Move scalePageBy from eventSender to window.internals
https://bugs.webkit.org/show_bug.cgi?id=64512

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.

  • testing/Internals.cpp:

(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Updated layout tests to use window.internals.setPageScaleFactor.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/scaling/tiled-layer-recursion.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
10:08 Changeset [104173] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

[Skia Mac] Rounded bezel style button needs one more local graphics context to scale
https://bugs.webkit.org/show_bug.cgi?id=75623
http://code.google.com/p/chromium/issues/detail?id=108749

In paintButton(), the local context is set up first, and later the context is
scaled if there's a zoomFactor. Skia creates the CoreGraphics context to draw the
button into without that scale factor. To fix this, another local context is added
after the parameter context scale, before the button draw. The first local context
is still required to restore the parameter context state.

Reviewed by Stephen White.

  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::paintButton):

09:52 Changeset [104172] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: Chromium expectations update.
Filed http://crbug.com/109276 and ignored appcache failure on Linux.
Failures seem intermittent in appcache so might need to ignore more tests.

  • platform/chromium/test_expectations.txt:
09:49 Changeset [104171] by mitz@apple.com
  • 4 edits in trunk/Source/ThirdParty

Made Debug/Release builds of gtest build only for the active architecture.

Reviewed by Dave Kilzer.

  • gtest/xcode/Config/DebugProject.xcconfig:
  • gtest/xcode/Config/ProductionProject.xcconfig:
  • gtest/xcode/Config/ReleaseProject.xcconfig:
09:31 Changeset [104170] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expectations for svg/carto.net/button.svg can be updated
https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed Chromium test expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-05

  • platform/chromium-linux-x86/svg/carto.net: Removed.
  • platform/chromium/test_expectations.txt:
09:29 Changeset [104169] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for background is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75539

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for background.

Test: fast/css/getComputedStyle/getComputedStyle-background-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html: Added.
09:02 Changeset [104168] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Pass WebFrame instead of WebCore::Frame to the WebKit2 specific FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=75550

Make the WebKit2 FrameNetworkingContext implementation store the
WebFrame instead of the WebCore::Frame as this is needed for the Qt
port to implement a.o. HTTP autentication and SSL support.

As the WebFrameNetworkingContext is partly shared across all WebKit2 ports,
all port specific files have been modified.

For the Qt implementation of FrameNetworkingContext, we also set a
property to the originatingObject for the page ID. We also switch to
using an OwnPtr instead of a raw C++ pointer for the
m_originatingObject member.

Based on original patch by Peter Hartmann.

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-05
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:

(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::create):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

08:45 Changeset [104167] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Never enable FontConfig on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=75616

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-05
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
08:39 Changeset [104166] by hclam@chromium.org
  • 7 edits in trunk/Tools

Unreviewed, rolling out r104159.
http://trac.webkit.org/changeset/104159
https://bugs.webkit.org/show_bug.cgi?id=75590

Chromium port GPU tests cannot be executed.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(get):
(_default_tests_paths):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.assert_port_works):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory):
(PortFactory._get_kwargs):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_google_chrome.names):
(FactoryTest.test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GetGoogleChromePort):
(GetGoogleChromePort.GoogleChromeLinux32Port):
(GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
(GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
(GetGoogleChromePort.GoogleChromeLinux64Port):
(GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
(GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
(GetGoogleChromePort.GoogleChromeMacPort):
(GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
(GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeWinPort):
(GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
(GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_baseline_path):
(GetGoogleChromePortTest._verify_expectations_overrides):

08:00 Changeset [104165] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

DOM Attribute tests on Dromaeo spends 2.7% of time in hasSelectorForAttribute
https://bugs.webkit.org/show_bug.cgi?id=75569

Reviewed by Andreas Kling.

Check needsStyleRecalc() first to avoid unnecessary hash lookups.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

07:59 Changeset [104164] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Give

media/media-blocked-by-beforeload.html another chance on the bot
after its update in r103509.

07:47 Changeset [104163] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Replace alloca to C++ new placement.
https://bugs.webkit.org/show_bug.cgi?id=72017

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-05
Reviewed by Andreas Kling.

Replaces alloca to C++ new placement as it is not very portable.
It allows to skip checking of memory allocation as new never returns NULL.
According to Edje's documentation type of val (member of Edje_Message_Float_Set)
is double so I changed it to avoid undefined behaviour.

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::updateThumbPositionAndProportion):

07:37 Changeset [104162] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r104068): editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html made the next test fail

Unreviewed gardening. One more attempt to paint the Qt-WK2 bot green.

  • platform/qt-wk2/Skipped:
07:22 Changeset [104161] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium/test_expectations.txt:
07:01 Changeset [104160] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Invalidation request for ewk_view can be discarded without rendering.
https://bugs.webkit.org/show_bug.cgi?id=71564

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-05
Reviewed by Hajime Morita.

As ewk_view discards a queue for invalidation requests
as soon as it proceeds the repaint step, the newly produced invalidation requests
from ewk_view_layout_if_needed_recursive API can be discarded
and unpainted dirty area can occur.
As this issue is just caused by use of flush API in repaint step,
(internal API) ewk_view_repaints_get is replaced with ewk_view_repaints_pop
in order to make sure that old invalidation requests are removed from queue.
And in addition to that, ewk_view_repaint_add is modified
in order to let queue of invalidation requests keep a proper size.
As a result flush API won't be used for the repaint step.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_repaint_add):
(_ewk_view_smart_calculate):
(ewk_view_repaints_pop):

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_repaints_process):

07:01 Changeset [104159] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up port factory methods
https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(_port_name_from_arguments_and_options):
(get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(_verify_baseline_path):

06:59 Changeset [104158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove duplicate file references from WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75581

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-05
Reviewed by Andreas Kling.

Many generated DOMSVG files had two references.

In platform/graphics, there was two arm directory
with the same files related to ARM Neon.

  • WebCore.xcodeproj/project.pbxproj:
06:59 Changeset [104157] by aroben@apple.com
  • 6 edits
    1 copy
    8 adds in trunk

Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found.

Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH

Reviewed by Anders Carlsson.

Tools:

  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/ImageDiffCommon.vsprops:

Changed to build ImageDiff.dll instead of ImageDiff.exe.

  • DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from

Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.

  • DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffWin.cpp: Added.

(dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
to main.

  • win/DLLLauncher/DLLLauncherMain.cpp:

(main):
(wWinMain):
Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
stub launcher acts as a console program and calls a console version of
dllLauncherEntryPoint.

Source/WebKit/win:

Add ImageDiffLauncher to WebKit.sln

It builds just after ImageDiff.

  • WebKit.vcproj/WebKit.sln:
06:58 Changeset [104156] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Implement QQuickWebView::inputMethodQuery

Reviewed by Simon Hausmann.

Implement the current Qt5 queries of inputMethodQuery.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • UIProcess/API/qt/qquickwebview_p.h:
06:57 Changeset [104155] by aroben@apple.com
  • 7 edits
    1 copy
    7 adds in trunk

Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found.

Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
double-clicked

Reviewed by Anders Carlsson.

Tools:

  • MiniBrowser/MiniBrowser.vcproj:
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops:

Changed to build MiniBrowser.dll instead of MiniBrowser.exe.

  • MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
  • MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj

but changed to build the stub launcher.

  • MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since

it needs to be compiled into the .exe instead of the .dll.
(DllMain): Added. We use this to store the DLL's HINSTANCE.
(dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
DLLLauncherMain code.

  • win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser

to here.

Source/WebKit/win:

Add MiniBrowserLauncher to WebKit.sln

It builds just after MiniBrowser.

  • WebKit.vcproj/WebKit.sln: Added MiniBrowserLauncher.
06:56 Changeset [104154] by aroben@apple.com
  • 2 edits in trunk/Tools

Make WinLauncher's window frame respond to clicks/drags again

Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
bar when Aero is disabled

Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.cpp:

(WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
Also removed an unnecessary "break" keyword.

06:52 Changeset [104153] by aroben@apple.com
  • 6 edits
    1 copy
    12 adds in trunk

Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
should use this mechanism.

Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
double-clicked

Reviewed by Anders Carlsson.

Tools:

  • WinLauncher/WinLauncher.cpp: Removed InitInstance.

(DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
done by the now-removed InitInstance function.
(dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
calls. Merged code from InitInstance into this function, and change to use the global hInst
variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
function, which corresponds to WinLauncher.exe.

  • WinLauncher/WinLauncher.vcproj:
  • WinLauncher/WinLauncherCommon.vsprops:

Changed to build WinLauncher.dll instead of WinLauncher.exe.

  • WinLauncher/WinLauncherLauncher.rc: Added.
  • WinLauncher/WinLauncherLauncherResource.h: Added.

This just references the WinLauncher.ico file to set the application icon (though it looks
like that's a default icon).

  • WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj

but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.

  • WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
  • WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
  • WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
  • WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
  • win/DLLLauncher/DLLLauncherMain.cpp: Added.

(enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
program if it detects heap corruption.
(getStringValue): Helper function to read a string value from the registry.
(applePathFromRegistry): Helper function to read the InstallDir for a given Apple
application from the registry.
(appleApplicationSupportDirectory): Helper function to return the path to the Apple
Application Support directory.
(copyEnvironmentVariable): Helper function to copy an environment variable's value.
(prependPath): Helper function to prepend a directory to the PATH.
(fatalError): Helper function to display an error to the user.
(wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
dllLauncherEntryPoint function.

Source/WebKit/win:

Add WinLauncherLauncher to WebKit.sln

It builds just after WinLauncher.

  • WebKit.vcproj/WebKit.sln: Added WinLauncherLauncher.
06:40 Changeset [104152] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Improve SelectorChecker::determineSelectorScopes
https://bugs.webkit.org/show_bug.cgi?id=75619

Reviewed by Andreas Kling.

SelectorChecker::determineSelectorScopes currently searches to the end of the selector chain and
then sees if the last one is suitable to be a scope. A better algorithm will find a scope from
anywhere in the chain.

With this patch we search the whole chain for potential scopes. We now prefer id scopes
over class scopes. Scopes can be found for rules using sibling selectors too.

On both engadget.com and nytimes.com, we can now skip one more full style recalc due to
the improved stylesheet analysis.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineSelectorScopes):

06:38 Changeset [104151] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Use the default screen in PlatformScreenGtk methods when they are called with a NULL widget
https://bugs.webkit.org/show_bug.cgi?id=75620

Reviewed by Philippe Normand.

We are currently retuning an empty rectangle for
screenRect/screenAvailableRect and 0 for getVisual.

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

06:12 Changeset [104150] by hclam@chromium.org
  • 2 edits
    6 deletes in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-win-xp/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-align-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-path-01-b-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
06:02 Changeset [104149] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebSettings::setAcceleratedDrawingEnabled from public API.
https://bugs.webkit.org/show_bug.cgi?id=74125

Patch by David Reveman <reveman@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Remove setAcceleratedDrawingEnabled method from WebSettings class.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
06:02 Changeset [104148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expected test failures after Skia is rolled to 2918
https://bugs.webkit.org/show_bug.cgi?id=75019

Fixed now that Skia has rolled past r2936.

Unreviewed Chromium port test expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-05

  • platform/chromium/test_expectations.txt:
05:38 Changeset [104147] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix.

Adding missing const_cast<> to fix compilation failures due to r104143.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

05:27 Changeset [104146] by abarth@webkit.org
  • 5 edits
    3 adds in trunk/Source/WebCore

Move Gamepad declarations from Navigator.idl into Modules/gamepad
https://bugs.webkit.org/show_bug.cgi?id=75559

Reviewed by Eric Seidel.

This patch moves the gamepad-related declarations in Navigator.idl into
Modules/gamepad. The next step is to move the state into
Modules/gamepad as well.

  • Modules/gamepad/NavigatorGamepad.cpp: Added.

(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::~NavigatorGamepad):
(WebCore::NavigatorGamepad::webkitGamepads):

  • Modules/gamepad/NavigatorGamepad.h: Added.
  • Modules/gamepad/NavigatorGamepad.idl: Added.
  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::gamepads):

  • page/Navigator.h:
  • page/Navigator.idl:
05:04 Changeset [104145] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=75248

Reviewed by Gustavo Noronha Silva.

It uses the page zoom factor unconditionally for now.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init): Add WebKitWebView:zoom-level
property.
(webkit_web_view_set_zoom_level): Set current zoom level.
(webkit_web_view_get_zoom_level): Get current zoom level.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewZoomLevel):
(beforeAll):

04:55 Changeset [104144] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle for border-image is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75347

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-color.

fast/css/getComputedStyle/computed-style-border-image.html was extended to cover the
new feature.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values for border-image.

  • fast/css/getComputedStyle/computed-style-border-image-expected.txt:
  • fast/css/getComputedStyle/computed-style-border-image.html:
04:54 Changeset [104143] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add a SSE2 optimized function zvmul in VectorMatch
https://bugs.webkit.org/show_bug.cgi?id=74842

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

Use zvmul in FFTFrameFFMPEG.cpp::multiply() and FFTFrameMac.cpp::multiply().

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

  • platform/audio/VectorMath.h:
  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:

(WebCore::FFTFrame::multiply):

  • platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::multiply):

04:51 Changeset [104142] by hclam@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed. Build fix for Chromium Mac Clang build.

Push using namespace WTF to .cpp file from .h file.

  • platform/text/TextCodecASCIIFastPath.h:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF8.cpp:
04:50 Changeset [104141] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r104068): It made editing/pasteboard/copy-in-password-field.html fail
https://bugs.webkit.org/show_bug.cgi?id=75615

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip editing/pasteboard/copy-in-password-field.html to paint the bot green.
04:42 WebKit Team edited by kubo@profusion.mobi
Add myself to the list of committers (diff)
04:23 Changeset [104140] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebKit adds vertical paddings and borders to the fixed width of CSS tables
https://bugs.webkit.org/show_bug.cgi?id=74955

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-01-05
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/css-table-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

Changed the width calculation for CSS tables to take into account horizontal
paddings and borders instead of vertical paddings and borders.

LayoutTests:

Added tests to check that the fixed width style is applied correctly to
CSS tables with respect to table paddings and borders.

  • fast/table/css-table-width-expected.txt: Added.
  • fast/table/css-table-width.html: Added.
  • fast/table/script-tests/css-table-width.js: Added.

(computeCSSTableOffsetWidth):
(computeCSSTableOffsetHeight):
(computeCSSTableProperty):

04:22 Changeset [104139] by peter@chromium.org
  • 7 edits
    4 adds in trunk/Source

[Chromium] Upstream the RenderTheme and ScrollbarTheme for Android
https://bugs.webkit.org/show_bug.cgi?id=74614

Reviewed by Adam Barth.

Source/WebCore:

Upstream the RenderTheme and ScrollbarTheme for Android. These are
mostly derived from their Linux variants.

RenderThemeChromiumAndroid inherits from RenderThemeChromiumLinux and
only overrides the three methods which have different behavior.
Scrollbars will be drawn in the threaded compositor for Android (which
will be upstreamed later), but for increased layout test parity we'll
match Chromium-Linux.

No new tests. This code will be exercised by existing layout tests, and
by manually verifying that theme parts render as expected.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp: Added.

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
(WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
(WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h: Added.
  • rendering/RenderThemeChromiumAndroid.cpp: Added.

(WebCore::RenderThemeChromiumAndroid::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumAndroid::~RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumAndroid.h: Added.
  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):

04:09 Changeset [104138] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

  • platform/qt/Skipped:
03:40 Changeset [104137] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose Fixed Position Layout to WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=75556

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::shouldLayoutFixedElementsRelativeToFrame):
(WebKit::WebViewImpl::setShouldLayoutFixedElementsRelativeToFrame):

  • src/WebViewImpl.h:
03:33 Changeset [104136] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

unshift/pop fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75588

Reviewed by Zoltan Herczeg.

Buildfix after r104120.

  • runtime/JSArray.cpp: Remove useless asserts, baecause unsigned expression >= 0 is always true

(JSC::JSArray::unshiftCount):

03:24 Changeset [104135] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed gardening after r104134.

  • wtf/Assertions.cpp:
03:06 Changeset [104134] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed gardening after r75605.

Rubber stamped by NOBODY Csaba Osztrogonác.

  • wtf/Assertions.cpp:
02:57 Changeset [104133] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Source/WebCore: Fix potential superlinear runtime of multiple indirect adjenceny combinators.
https://bugs.webkit.org/show_bug.cgi?id=75083

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-05
Reviewed by Antti Koivisto.

A sequence of indirect adjencency combinator such as "li ~ li ~ la" could with the
former algorithm potentially do an quadratic number of element matches.
The recursive matching algorithm now detects cases where all siblings have
failed one indirect sibling match and fails the entire selector.

Test: perf/nested-combined-selectors.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Return SelectorFailsAllSiblings when
all siblings have failed a selector component.

  • css/SelectorChecker.h: Add SelectorFailsAllSiblings enum value

LayoutTests: Test of styling performance of selectors with multiple indirect combinators

https://bugs.webkit.org/show_bug.cgi?id=75083

Reviewed by Antti Koivisto.

  • perf/nested-combined-selectors.html: Added.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-05

02:56 Changeset [104132] by haraken@chromium.org
  • 4 edits in trunk/Tools

prepare-ChangeLog cannot parse python code that nests classes and defs
https://bugs.webkit.org/show_bug.cgi?id=75524

Reviewed by Ryosuke Niwa.

This patch fixes the python parser of prepare-ChangeLog so that it can parse
python code that nests classes and defs, like this:

class C:

pass
def f():

pass

pass

Also, this patch fixes the python parser so that it inserts a dummy line
at the end of the file to pop out all popped scopes.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:

Added test cases that nest classes and defs.
(func7):
(func7.func8):
(func7.func8.func9):
(Class2):
(Class2.Class3):
(Class2.Class3.Class4):
(Class5):
(Class5.func10):
(Class5.func11):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
02:20 Changeset [104131] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

InspectorStyleSheet: Avoid cloning CSSRuleLists.
<http://webkit.org/b/75603>

Reviewed by Ryosuke Niwa.

Don't filter out @charset rules from CSSRuleLists. This was forcing us to clone
the stylesheet rule list, and is unnecessary since InspectorStyleSheet disregards
any rule that isn't either a style rule or a rule with an internal rule list.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):

Don't pass omitCharsetRules=true to the CSSRuleList constructor.

02:18 Changeset [104130] by kling@webkit.org
  • 13 edits in trunk/Source/WebCore

Make elements with attributes smaller by eliminating the ref count in NamedNodeMap.
<http://webkit.org/b/75068>

Reviewed by Antti Koivisto.

Remove NamedNodeMap's inheritance from RefCounted and forward the ref()/deref()
calls to its owner Element, effectively reducing the size of an element that has
attributes by 4 bytes.

This reduces memory consumption by 311 kB when viewing the full HTML5 spec.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):

Added. Forwards the operation to m_element. Only ever used by the DOM wrappers.

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create):

  • dom/DocumentType.h:
  • dom/Element.cpp:

(WebCore::Element::parserSetAttributeMap):

  • dom/Element.h:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::takeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

Store NamedNodeMap in OwnPtr/PassOwnPtr, rather than RefPtr/PassRefPtr.

02:08 Changeset [104129] by carlosgc@webkit.org
  • 10 edits in trunk

[GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=75433

Reviewed by Martin Robinson.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadFail): Use webkit_web_view_replace_content().
(webkitWebViewLoadChanged): Do not emit load-changed signal when
replacing content.
(webkitWebViewLoadFailed): Do not emit load-failed signal when
replacing content.
(webkitWebViewSetEstimatedLoadProgress): Do not emit
notify::estimated-load-progress signal when replacing content.
(webkit_web_view_replace_content):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(beforeAll):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(replaceContentTitleChangedCallback):
(replaceContentLoadCallback):
(testWebViewReplaceContent):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::replaceContent):

  • UIProcess/API/gtk/tests/WebViewTest.h:

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewLoadFailed): Reset the progress bar when load fails.
(browserWindowConstructed): Connect to load-failed signal.

02:03 Changeset [104128] by noel.gordon@gmail.com
  • 2 edits
    3 moves
    4 adds in trunk/LayoutTests

[chromium] MAC: update expectations for CSS3 linear gradient tests
https://bugs.webkit.org/show_bug.cgi?id=55745

Reviewed by Stephen White.

  • platform/chromium-cg-mac-leopard/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-leopard/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stop-units-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-color-stops-expected.png.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png.
  • platform/chromium/test_expectations.txt:
01:38 Changeset [104127] by benjamin@webkit.org
  • 12 edits
    3 adds in trunk/Source

Improve charactersAreAllASCII() to compare multiple characters at a time
https://bugs.webkit.org/show_bug.cgi?id=74063

Reviewed by Darin Adler.

Source/JavaScriptCore:

A new header ASCIIFastPath.h contains the functions related to
the detection of ASCII by using machine words. Part of it comes from
WebCore's TextCodecASCIIFastPath.h.

The function charactersAreAllASCII() is moved to TextCodecASCIIFastPath.h
and is implemented with computer word comparison.
The gain over the previous implementation of charactersAreAllASCII() is of
the order of how many comparison are avoided (4x, 8x, 16x depending on the
format and the CPU type).

(WTF::isAlignedToMachineWord):
(WTF::alignToMachineWord):
(WTF::isAllASCII):
(WTF::charactersAreAllASCII):

  • wtf/text/WTFString.h:
  • wtf/wtf.pro:

Source/JavaScriptGlue:

Add forwarding header for ASCIIFastPath.h.

  • ForwardingHeaders/wtf/text/ASCIIFastPath.h: Added.

Source/WebCore:

Move some part of TextCodecASCIIFastPath.h to WTF in ASCIIFastPath.h.
The function isAllASCII() is changed to the template version which now works
with both LChar and UChar.

  • ForwardingHeaders/wtf/text/ASCIIFastPath.h: Added.
  • platform/text/TextCodecASCIIFastPath.h:

(WebCore::copyASCIIMachineWord):

  • platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::decode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

01:29 Changeset [104126] by ericu@chromium.org
  • 19 edits
    1 delete in trunk

[fileapi] WebKitFlags should not be constructable per Directories & System spec
https://bugs.webkit.org/show_bug.cgi?id=68916

Reviewed by Eric Seidel.

Source/WebCore:

Remove IDL for the object and all DOM references to it.

  • fileapi/WebKitFlags.idl: Removed.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl: Remove references to the JSC/V8 objects compiled from the IDL.
  • bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/js/JSDirectoryEntrySyncCustom.cpp: (WebCore::getFlags):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: (WebCore::getFlags): Fix up build files.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore/CMakeLists.txt:
  • WebCore/CodeGenerators.pri:
  • WebCore/DerivedSources.cpp:
  • WebCore/DerivedSources.make:
  • WebCore/GNUmakefile.list.am:

LayoutTests:

Remove a test that constructed the object; add one that tests error-handling for non-object parameters while I'm in there.

  • fast/filesystem/flags-passing-expected.txt:
  • fast/filesystem/script-tests/flags-passing.js:

Remove a special case reference to the global WebKitFlags constructor.

  • fast/dom/script-tests/prototype-inheritance.js:
01:16 Changeset [104125] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/75606> [Mac] WTF logging functions should output to both stderr and ASL

We should always log to both ASL and stderr on platforms where this won't result in launchd
duplicating the messages.

Reviewed by Dan Bernstein.

  • wtf/Assertions.cpp:

(vprintf_stderr_common):

01:16 Changeset [104124] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/75605> WTF logging functions should call vprintf_stderr_common only once per line

Several of the WTF logging functions make multiple calls to vprintf_stderr_common to output a
single line of text. This results in strangely formatted output if vprintf_stderr_common is
retargeted to an output device that is message-oriented (such as ASL) rather than stream-oriented
like stderr.

Reviewed by Dan Bernstein.

  • wtf/Assertions.cpp:

(vprintf_stderr_with_prefix): Helper function to prepend a given prefix on to the given format
string before handing it off to vprintf_stderr_common. This requires disabling warnings about
calling a printf-like function with a non-literal format string for this piece of code. It's
safe in this particular case as vprintf_stderr_with_prefix is only ever given a literal prefix.
(vprintf_stderr_with_trailing_newline): Helper function to append a trailling newline on to the
given format string if one does not already exist. It requires the same treatment with regards
to the non-literal format string warning.
(WTFReportAssertionFailureWithMessage): Switch to using vprintf_stderr_with_prefix.
(WTFReportBacktrace): Switch from calling fprintf directly to using fprintf_stderr_common.
(WTFReportFatalError): Switch to using vprintf_stderr_with_prefix.
(WTFReportError): Ditto.
(WTFLog): Switch to using vprintf_stderr_with_trailing_newline.
(WTFLogVerbose): Ditto.

00:54 WebKit Team edited by pfeldman@chromium.org
(diff)
00:53 WebKit Team edited by pfeldman@chromium.org
(diff)
00:51 Changeset [104123] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Crash due to first-letter block processing
https://bugs.webkit.org/show_bug.cgi?id=74009

Source/WebCore:

Fixing the way updateFirstLetter() finds the remaining text fragment
for a given first-letter. Previously this was unreliable in some
circumstances.

This patch provides a reliable mechanism to identify the remaining
text by storing first-letter to remaining text associations in a
hash map, managed by methods in RenderBoxModelObject.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter)

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::setFirstLetterRemainingText): Added
(WebCore::RenderBoxModelObject::firstLetterRemainingText): Added

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::setFirstLetterRemainingText): Added
(WebCore::RenderBoxModelObject::firstLetterRemainingText): Added

LayoutTests:

Test for crashing condition in 74009.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • fast/css/first-letter-inline-flow-split-table-crash-expected.txt: Added
  • fast/css/first-letter-inline-flow-split-table-crash.html: Added
00:51 Changeset [104122] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[WK2][EFL] creating dummy functions for Download class on Efl port.
https://bugs.webkit.org/show_bug.cgi?id=75246

dummy functions for Download class on Efl port

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-01-05
Reviewed by Hajime Morita.

  • PlatformEfl.cmake: add new file to compile
  • WebProcess/Downloads/efl: Added.
  • WebProcess/Downloads/efl/DownloadEfl.cpp: Added.

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
(WebKit::Download::useCredential):
(WebKit::Download::continueWithoutCredential):
(WebKit::Download::cancelAuthenticationChallenge):

00:41 WebKit Team edited by ryuan.choi@samsung.com
(diff)
00:34 Changeset [104121] by mihnea@adobe.com
  • 6 edits
    2 adds in trunk

Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
https://bugs.webkit.org/show_bug.cgi?id=74781

Reviewed by David Hyatt.

Test: fast/regions/region-range-for-box-crash.html

This patch fixes 2 issues:

  1. When removing a region from a flow thread, we clear the region range information for boxes since

this information is accurate only after the regions are laid out.

  1. While the regions are invalidated (content of flow thread is not yet laid out in regions), the

functions that ask for properties of content in regions should bail out early.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::logicalWidthChangedInRegions):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderFlowThread.h:

LayoutTests: Crash in RenderFlowThread::getRegionRangeForBox.
https://bugs.webkit.org/show_bug.cgi?id=74781

Reviewed by David Hyatt.

  • fast/regions/region-range-for-box-crash-expected.txt: Added.
  • fast/regions/region-range-for-box-crash.html: Added.
00:00 Changeset [104120] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

unshift/pop fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75588

Reviewed by Sam Weinig.

The Array object commonly store data in a vector, consisting of a portion that
is in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to pop with grow the post-capacity, and the
current algorithm for increasePrefixVectorLength (used by unshift) will never
stink the post-capacity, so a unshift/pop fifo may consume an inordinate amount
of memory, whilst having a relatively small active length.

  • runtime/JSArray.cpp:

(JSC::storageSize):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::SparseArrayValueMap::put):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::JSArray::increaseVectorLength):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::JSArray::unshiftCountSlowCase):

  • renamed from increaseVectorPrefixLength (this was a bad name, since it also moved the ArrayStorage header), rewritten.

(JSC::JSArray::shiftCount):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned

(JSC::JSArray::unshiftCount):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned, increaseVectorPrefixLength renamed to unshiftCountSlowCase

(JSC::JSArray::sortNumeric):

  • runtime/JSArray.h:
    • Updated function declarations, m_indexBias should be unsigned.

01/04/12:

23:39 Changeset [104119] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/75604> All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments

Since JSC::Arguments has an OwnPtr for a member it needs to override destroy
to ensure that the correct destructor is invoked. This is necessary because
JSCell subclasses all intentionally have non-virtual destructors.

Reviewed by Filip Pizlo.

  • runtime/Arguments.cpp:

(JSC::Arguments::destroy):

  • runtime/Arguments.h:
23:12 Changeset [104118] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty

Remove HEADER_SEARCH_PATHS from Production configurations for gtest

Reviewed by Mark Rowe.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj: Remove

HEADER_SEARCH_PATHS from Production configurations to match
changes made for Debug and Release configurations in r104091.

22:49 Changeset [104117] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 116031 to 116459.

  • DEPS:
20:59 Changeset [104116] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r104084.
http://trac.webkit.org/changeset/104084
https://bugs.webkit.org/show_bug.cgi?id=75600

Likely kills dom-perf benchmark in chromium
http://build.chromium.org/f/chromium/perf/linux-
release/dom_perf/report.html?history=150&rev=116444 (Requested
by dslomov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-04

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicSubtreeNodeList::Caches::create):
(WebCore::DynamicSubtreeNodeList::Caches::reset):

  • dom/DynamicNodeList.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore::Node::notifyLocalNodeListsLabelChanged):
(WebCore::Node::itemTypeAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::parseMappedAttribute):

  • html/HTMLLabelElement.h:
20:19 Changeset [104115] by mitz@apple.com
  • 8 edits in trunk

Source/WebKit2: Allow WebProcess to launch a client process and become its first WebProcess.

This is the WebKit2 part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach

Reviewed by Anders Carlsson.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Added a newline to stderr output.

  • UIProcess/Launcher/mac/EnvironmentVariables.cpp:

(WebKit::EnvironmentVariables::preexistingProcessServiceNameKey): Added. Returns the name
of the environment variable that optionally tells a UI processs to look for a preexisting
web process instead of launching a new one.
(WebKit::EnvironmentVariables::preexistingProcessTypeKey): Added. Returns the name of the
environment variable that tells a UI process the type of the preexisting web process
indicated by the other variable.

  • UIProcess/Launcher/mac/EnvironmentVariables.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Changed to look for a preexisting web process if
the aforementioned environment variables are set and the preexisting process has not been
used yet.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Changed to look for the -client-executable command-line option,
and if present, launch the specified executable, setting variables in its environment that
tell it to use this preexisting web process, then wait for it to send a send right to its
listening port.

Tools: Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
start WebProcess under gdb and WebProcess will then run the client executable.

This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(shouldTargetWebProcess): Added.
(determineShouldTargetWebProcess): Added. Checks for --target-web-process.
(execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
app using the -client-executable option if targeting the web process.

19:20 Changeset [104114] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Attempt Chromium build fix.

  • src/WorkerFileSystemCallbacksBridge.h:
19:08 Changeset [104113] by levin@chromium.org
  • 2 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

[chromium] FileSystem bridge needs threadsafe fixes and other clean-up.
https://bugs.webkit.org/show_bug.cgi?id=74666

Reviewed by Dmitry Titov.

Tests for all of the fixes done in bugs related to 74666.

  • http/tests/workers/resources/open-database-sync.js: Removed.
  • http/tests/workers/resources/sync-operations.js: Added.

(removeAllInDirectorySync):
(onmessage):

  • http/tests/workers/terminate-during-sync-operation-expected.txt: Added.
  • http/tests/workers/terminate-during-sync-operation.html: Renamed from LayoutTests/http/tests/workers/interrupt-database-sync-open-crash.html-skipped.
  • platform/chromium/test_expectations.txt:
19:08 Changeset [104112] by levin@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Remove AllowCrossThreadAccess in WorkerFileSystemCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=75579

Reviewed by Dmitry Titov.

This code doesn't have lifetime issues, but this change is
about getting rid of AllowCrossThreadAccess and getting rid of a leakRef.
This allows the code to follow a more common pattern and be more easily
verified as being correct.

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::MainThreadFileSystemCallbacks::createLeakedPtr):
(WebKit::MainThreadFileSystemCallbacks::MainThreadFileSystemCallbacks):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postMoveToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postCopyToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postRemoveToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postReadMetadataToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postCreateFileToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postCreateDirectoryToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postFileExistsToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postDirectoryExistsToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postReadDirectoryToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::removeRecursivelyOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):

  • src/WorkerFileSystemCallbacksBridge.h:
19:08 Changeset [104111] by levin@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Make it safe to delete WorkerFileSystemContextObserver on any thread.
https://bugs.webkit.org/show_bug.cgi?id=75573

Reviewed by Dmitry Titov.

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemContextObserver): Move the WorkerContextObserver
out of the WorkerFileSystemCallbacksBridge since an observer should be
destroyed on the WorkerContext thread. (Actually, it could be destroyed on either
thread if you are careful to make a certain method call on it while on the WorkerContext
thread but trying that is a more fragile pattern.)
(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge):
(WebKit::WorkerFileSystemCallbacksBridge::stop): Factor out the clean up and make it
clear what the mutex is guarding.
(WebKit::WorkerFileSystemCallbacksBridge::cleanUpAfterCallback): Delete
the observer. Due to where this is called from, it is always called on the WorkerContext thread.
(WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread): Replace some code with
the cleanUpAfterCallback call.
(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):

  • src/WorkerFileSystemCallbacksBridge.h: In addition to some comment clean ups and code factoring,

I made the desctructor private since no one should call it directly.

17:50 Changeset [104110] by eae@chromium.org
  • 1 edit
    2 deletes in branches/subpixellayout/Source/WebCore

Manual merge of GNUmakefile.list.am and a couple of files deleted on trunk.

17:50 Changeset [104109] by oliver@apple.com
  • 16 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Rollout r102743

17:36 Changeset [104108] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97353.

17:22 Changeset [104107] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, accidentally turned off the JIT in previous commit. Turning
it back on.

  • wtf/Platform.h:
17:19 Changeset [104106] by jamesr@google.com
  • 12 edits in trunk/Source

[chromium] Remove chromium compositor support for unused zoomAnimatorTransform
https://bugs.webkit.org/show_bug.cgi?id=75585

Reviewed by Kenneth Russell.

Source/WebCore:

Removes compositor support for zoomAnimatorTransform property. This code is unused and never was used.
Zoom animations are handled by adjusting the page scale factor and scroll offsets.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

17:18 Changeset [104105] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Changed "return" to "break" in some macrology I introduced in
http://trac.webkit.org/changeset/104086. This is a benign change, as
"return" was technically correct for all uses of the macro.

Reviewed by Oliver Hunt.

  • dfg/DFGGraph.cpp:
  • wtf/Platform.h:
17:17 Changeset [104104] by lforschler@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebCore

Merged r97270.

17:13 Changeset [104103] by lforschler@apple.com
  • 1 edit in branches/safari-534.54-branch/LayoutTests/ChangeLog

Merged r97181.

17:12 Changeset [104102] by kbr@google.com
  • 10 edits in trunk

Fix semantics of WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=75053

Reviewed by James Robinson.

Source/WebCore:

Updated WEBGL_lose_context extension to match WebGL spec's
behavior:

  • loseContext() causes the context to be lost immediately, but the webglcontextlost event isn't dispatched until JavaScript returns.
  • restoreContext() may only be called once dispatch of the webglcontextlost event has completed, *and* if that event handler prevented the default behavior of the event.
  • restoreContext() performs its work asynchronously. The context is not restored until just before the webglcontextrestored event is dispatched.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::forceRestoreContext):
(WebCore::WebGLRenderingContext::dispatchContextLostEvent):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated context-lost and context-lost-restored tests to latest
versions in Khronos repository. Updated WebGLContextEvent.html to
match new semantics.

  • fast/canvas/webgl/WebGLContextEvent-expected.txt:
  • fast/canvas/webgl/WebGLContextEvent.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost-restored-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
17:11 Changeset [104101] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r97180.

17:04 Changeset [104100] by oliver@apple.com
  • 11 edits
    2 adds in branches/safari-534.54-branch

Merge r94457

17:01 Changeset [104099] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r97124.

17:00 Changeset [104098] by eae@chromium.org
  • 1985 edits
    835 copies
    200 deletes in branches/subpixellayout

Merging trunk changes up until 104084 into subpixel branch.

16:54 Changeset [104097] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r97114.

16:40 Changeset [104096] by lforschler@apple.com
  • 6 edits
    12 copies in branches/safari-534.54-branch

Merged r97075.

16:39 EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Update type casting. (diff)
16:35 Changeset [104095] by lforschler@apple.com
  • 5 edits
    3 copies in branches/safari-534.54-branch

Merged r97074.

16:31 Changeset [104094] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

StructureStubInfo not reset when corresponding MethodCallLinkInfo is reset
https://bugs.webkit.org/show_bug.cgi?id=75583

Reviewed by Filip Pizlo.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally): Find the corresponding
StructureStubInfo and reset the appropriate JIT and
the StructureStubInfo itself when reseting a MethodCallLinkInfo.

16:29 Changeset [104093] by lforschler@apple.com
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r96999.

16:19 Changeset [104092] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96984.

16:15 Changeset [104091] by ddkilzer@apple.com
  • 9 edits in trunk/Source/ThirdParty

TestWebKitAPI has issues due to FastMalloc incompatibility
<http://webkit.org/b/66521>
<rdar://problem/10607911>

Reviewed by David Levin.

Original patch by Dmitry Lomov <dslomov@google.com>.

This patch ensures that gtest uses the FastMalloc new and delete
operators that are defined in JavaScriptCore.

  • gtest/README.WebKit: Update with project changes.
  • gtest/include/gtest/internal/gtest-port.h: Import necessary

headers to use FastMalloc in gtest.

  • gtest/msvc/gtest-md.vcproj: Add include directories to find

WTF headers.

  • gtest/xcode/Config/DebugProject.xcconfig: Define

WEBCORE_PRIVATE_HEADERS_DIR for Debug builds.

  • gtest/xcode/Config/General.xcconfig: Define

HEADER_SEARCH_PATHS in terms of WEBCORE_PRIVATE_HEADERS_DIR.

  • gtest/xcode/Config/ProductionProject.xcconfig: Define

WEBCORE_PRIVATE_HEADERS_DIR for Production builds. This
overrides the value in ReleaseProject.xcconfig.

  • gtest/xcode/Config/ReleaseProject.xcconfig: Define

WEBCORE_PRIVATE_HEADERS_DIR for Release builds.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
  • Remove local HEADER_SEARCH_PATHS definitions.
  • Link to JavaScriptCore.framework when building gtest.framework.
16:10 Changeset [104090] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Invalid ASSERT() in DFGRepatch.cpp near line 385
https://bugs.webkit.org/show_bug.cgi?id=75584

Reviewed by Filip Pizlo.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDProtoList): Fixed ASSERT to use ==.

15:55 Changeset [104089] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Remove a line for a test that no longer fails on the bots.

  • platform/chromium/test_expectations.txt:
15:45 Changeset [104088] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96868.

15:33 Changeset [104087] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96834.

15:13 Changeset [104086] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Incorrect use of DFG node reference counts when mutating the graph
https://bugs.webkit.org/show_bug.cgi?id=75580
<rdar://problem/10644607>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Made deref(node) follow the pattern of ref(node), which it should have
to begin with.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGNode.h:

(JSC::DFG::Node::deref):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixupNode):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-array-length-dead-expected.txt: Added.
  • fast/js/dfg-array-length-dead.html: Added.
  • fast/js/script-tests/dfg-array-length-dead.js: Added.

(foo):

15:11 Changeset [104085] by eae@chromium.org
  • 18 edits in branches/subpixellayout/LayoutTests/platform/mac/editing/selection

Update selection expectations for mac to account for pixelSnapped later sizes.

15:08 Changeset [104084] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
https://bugs.webkit.org/show_bug.cgi?id=73853

Reviewed by Antti Koivisto.

Lazily invalidate the node list caches instead of invaliding them at the time of modification. We use
the DOM tree version to detect whether caches need to be invalidated or not. We now invalidate caches more
frequently after this patch (in particular, invalidates caches that are stored on nodes not present in
the ancestry of the modified nodes); however, our study on major Web sites such as Gmail, Facebook, Twitter,
etc... indicate that about 1% of real-world usage benefits from keeping the caches alive across different
DOM tree versions.

In order to invalidate caches lazily, this patch adds replaces the type of m_caches in DynamicSubtreeNodeList
by DynamicSubtreeNodeList::SubtreeCaches which encapsulates member variables in DynamicNodeList::Caches and
invalidates values as needed. Also this change allows m_caches to be allocated as a part of
DynamicSubtreeNodeList instead of a separate ref-counted object.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicNodeList::Caches::create):
(WebCore::DynamicNodeList::Caches::reset):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedLength): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItemOffset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::reset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent): Added.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively): Clear caches when a node moves from one document to another.
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Only clears child node list of Attr.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Only clears child node list.
(WebCore::NodeListsNodeData::invalidateCaches): Merged with invalidateCachesThatDependOnAttributes.

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:
  • html/HTMLLabelElement.h:
15:06 Changeset [104083] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96826.

14:59 Changeset [104082] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96632.

14:56 Changeset [104081] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Revert unintentional changes to Element.cpp in r104068.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

14:55 Changeset [104080] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r96427.

14:47 Changeset [104079] by lforschler@apple.com
  • 5 edits
    3 copies in branches/safari-534.54-branch

Merged r96260.

14:40 Changeset [104078] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r95985.

14:37 Changeset [104077] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95959.

14:34 Changeset [104076] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95926.

14:30 Changeset [104075] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r95924.

14:26 Changeset [104074] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] Compile fix, rename libplatform.a to libwebkit_platform.a to avoid collision with nacl

Source/Platform:

  • Platform.gyp/Platform.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
14:24 Changeset [104073] by enne@google.com
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r104052.
http://trac.webkit.org/changeset/104052
https://bugs.webkit.org/show_bug.cgi?id=75574

Breaks win builder (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-04

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Removed.
14:22 Changeset [104072] by eae@chromium.org
  • 53 edits in branches/subpixellayout

Add pixelSnappedIntSize function and change layer size calculation to use it instead of expandedIntSize.

14:16 Changeset [104071] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r95857.

14:13 Changeset [104070] by lforschler@apple.com
  • 8 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r95747.

14:09 Changeset [104069] by lforschler@apple.com
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r95728.

14:05 Changeset [104068] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION (r92823): Background color not preserved when copying and pasting a table row
https://bugs.webkit.org/show_bug.cgi?id=75330

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by the background color of the wrapping style overriding the background color
in a matched rule of a highest element to be serialized. Fixed the bug by removing the conflicting
background color prior to the merge.

Tests: editing/pasteboard/copy-element-with-conflicting-background-color-from-rule-expected.html

editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html

  • editing/EditingStyle.cpp:

(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):

LayoutTests:

Add a regression test.

  • editing/pasteboard/copy-element-with-conflicting-background-color-from-rule-expected.html: Added.
  • editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html: Added.
14:05 Changeset [104067] by ostapenko.viatcheslav@nokia.com
  • 2 edits in trunk/Tools

Adding myself to committers list.

Unreviewed.

14:02 Changeset [104066] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm
https://bugs.webkit.org/show_bug.cgi?id=75447

Reviewed by Brian Weinstein.

Resolve the ambiguity.

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):

14:01 Changeset [104065] by lforschler@apple.com
  • 1 edit in branches/safari-534.54-branch/Source/WebCore/svg/SVGDocumentExtensions.h

Remove executable bit from SVGDocumentExtensions.h

13:40 Changeset [104064] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed:[Chromium]Disable WebPageNewSerializeTest.CSSResources and WebPageNewSerializeTest.TestMHTMLEncoding.
https://bugs.webkit.org/show_bug.cgi?id=75567

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::TEST_F):

12:43 Changeset [104063] by lforschler@apple.com
  • 16 edits
    3 copies in branches/safari-534.54-branch

Merged r95671.

12:10 Changeset [104062] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r95497.

12:06 Changeset [104061] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r95462.

12:03 Changeset [104060] by antti@apple.com
  • 7 edits in trunk/Source/WebCore

Analyze stylesheet scope to minimize style recalcs
https://bugs.webkit.org/show_bug.cgi?id=75508

Reviewed by Dave Hyatt.

It is a relatively common pattern to use inline stylesheets in document body where all rules are scoped using descendant selector

<style>
#foo {...}
#foo div {...}
#foo .bar {...}
</style>

When this pattern is used it is also common that the rules only apply to elements that come after the style element.

When the set of active stylesheets changes we invalidate and recompute the entire document style. This is very expensive. We can
detect the case above and avoid the style recalc.

On engadget.com, this patch cuts the time spent in style recalcs to roughly half. There are further savings from reduced
relayouts. In total the engine CPU time used over the page load is reduced by ~10%.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::collectFeatures):

Refactor feature collection from constructor to a separate function.


(WebCore::CSSStyleSelector::appendAuthorStylesheets):

New function for non-destructively updating the style selector.


(WebCore::CSSStyleSelector::Features::clear):

Clear the features for another collection.


(WebCore::CSSStyleSelector::determineStylesheetSelectorScopes):

Find if all rules on a stylesheetare scoped to some set of ids and classes.


(WebCore::CSSStyleSelector::styleForDocument):

Add optional font selector argument. We updated the correct base style font on style selector construction but that is no longer sufficient
as font selector may be updated without reconstructing the style selector.


(WebCore::RuleSet::addRulesFromSheet):

Invalidate the matched declaration cache in case of new font-face rules.


  • css/CSSStyleSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineSelectorScopes):

Find if all rules on a selector list are scoped to some set of ids and classes.


  • css/SelectorChecker.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):

Pass the font selector, if exists, to styleForDocument so we always have the base font up to date.


(WebCore::Document::combineCSSFeatureFlags):
(WebCore::Document::resetCSSFeatureFlags):
(WebCore::Document::createStyleSelector):

Refactor css feature flag resetting to functions.


(WebCore::Document::removePendingSheet):

Use new PendingStylesheetCompleted flag when new stylesheets arrive.

(WebCore::Document::styleSelectorChanged):

Skip style recalc if it is not needed.

(WebCore::Document::collectActiveStylesheets):

Refactor collecting stylesheets to a separate function.


(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):

Determine the scopes and use hasElementWithId/getElementsByClassName to figure out if any scoped elements currently exist in the tree.


(WebCore::Document::analyzeStylesheetChange):

Figure out if we can update the style selector incrementally and if we can skip the style recalc.


(WebCore::Document::updateActiveStylesheets):

Renamed from recalcStyleSelector.
Invoke the new analysis functions.


  • dom/Document.h:
12:02 Changeset [104059] by lforschler@apple.com
  • 8 edits
    15 copies in branches/safari-534.54-branch

Merged r95461.

11:58 Changeset [104058] by lforschler@apple.com
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r95440.

11:51 Changeset [104057] by lforschler@apple.com
  • 4 edits in branches/safari-534.54-branch

Merged r95306.

11:47 Changeset [104056] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r95301.

11:44 Changeset [104055] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r95126.

11:42 Changeset [104054] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95074.

11:38 Changeset [104053] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95071.

11:36 Changeset [104052] by enne@google.com
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Create unit tests for CCTiledLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=75557

Reviewed by James Robinson.

Add some quad generation tests for tiled layers.

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Added.

(WebCore::createLayer):
(WebCore::TEST):
(WebCore::completelyContains):
(WebCore::getQuads):
(WebCore::verifyQuadsExactlyCoverRect):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):

11:35 Changeset [104051] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95059.

11:25 Changeset [104050] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests

This reverts commit r103546.

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):

11:24 Changeset [104049] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

First sentence is missing or clipped when printing a inline PDF
https://bugs.webkit.org/show_bug.cgi?id=75514
<rdar://problem/10640680>

Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::headerHeight): (WebKit::WebPageProxy::footerHeight): (WebKit::WebPageProxy::drawHeader): (WebKit::WebPageProxy::drawFooter): Do not ask the client about headers and footers when printing a PDF.
11:08 Changeset [104048] by jamesr@google.com
  • 11 edits
    4 copies
    2 moves
    6 adds in trunk

[chromium] Move WebMimeRegistry and dependencies to Source/Platform
https://bugs.webkit.org/show_bug.cgi?id=74583

Reviewed by Darin Fisher.

.:

Update .gitignore for Source/Platform/Platform.gyp/ generated project files.

  • .gitignore:

Source/Platform:

This creates a skeleton directory structure for the chromium WebKit platform API and moves WebMimeRegistry.h
along with its dependencies (WebString and WebCString) to their final location.

  • Platform.gyp/Platform.gyp: Added.
  • Platform.gypi: Added.
  • chromium/platform/WebCString.h: Copied from Source/WebKit/chromium/public/platform/WebCString.h.

(WebKit::WebCString::~WebCString):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::isEmpty):
(WebKit::WebCString::isNull):
(WebKit::WebCString::operator std::string):
(WebKit::WebCString::fromUTF16):
(WebKit::operator<):

  • chromium/platform/WebCommon.h: Copied from Source/WebKit/chromium/public/platform/WebCommon.h.
  • chromium/platform/WebMimeRegistry.h: Copied from Source/WebKit/chromium/public/platform/WebMimeRegistry.h.

(WebKit::WebMimeRegistry::~WebMimeRegistry):

  • chromium/platform/WebString.h: Copied from Source/WebKit/chromium/public/platform/WebString.h.

(WebKit::WebString::~WebString):
(WebKit::WebString::WebString):
(WebKit::WebString::operator=):
(WebKit::WebString::isEmpty):
(WebKit::WebString::isNull):
(WebKit::WebString::operator string16):
(WebKit::WebString::operator NullableString16):
(WebKit::WebString::fromUTF8):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/src/WebCString.cpp: Renamed from Source/WebKit/chromium/src/WebCString.cpp.

(WebKit::WebCString::compare):
(WebKit::WebCString::reset):
(WebKit::WebCString::assign):
(WebKit::WebCString::length):
(WebKit::WebCString::data):
(WebKit::WebCString::utf16):
(WebKit::WebCString::fromUTF16):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::operator WTF::CString):

  • chromium/src/WebString.cpp: Renamed from Source/WebKit/chromium/src/WebString.cpp.

(WebKit::WebString::reset):
(WebKit::WebString::assign):
(WebKit::WebString::length):
(WebKit::WebString::data):
(WebKit::WebString::utf8):
(WebKit::WebString::fromUTF8):
(WebKit::WebString::equals):
(WebKit::WebString::WebString):
(WebKit::WebString::operator=):
(WebKit::WebString::operator WTF::String):
(WebKit::WebString::operator WTF::AtomicString):

Source/WebKit/chromium:

public/platform/WebMimeRegistry.h is a temporary forwarding header to ease the transition. Once downstream
callers are updated to the new location this header can be removed.

WebString, WebCString, and WebCommon.h will remain in place as forwarding headers for users of the WebKit client
API.

  • WebKit.gyp:
  • public/platform/WebCString.h:
  • public/platform/WebCommon.h:
  • public/platform/WebMimeRegistry.h:
  • public/platform/WebString.h:

Tools:

Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):

10:21 Changeset [104047] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Share fractional time code between AnimationBase and KeyframeAnimation
https://bugs.webkit.org/show_bug.cgi?id=75549

Remove left over from changeset 104045.

Unreviewed trivial fix.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):

09:51 Changeset [104046] by hclam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-linux/svg/custom/glyph-selection-lang-attribute-expected.txt: Added.
09:50 Changeset [104045] by igor.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

Share fractional time code between AnimationBase and KeyframeAnimation
https://bugs.webkit.org/show_bug.cgi?id=75549

Share fractional time calculation between AnimationBase and KeyframeAnimation.

Reviewed by Simon Fraser.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::progress):

  • page/animation/AnimationBase.h:
  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

09:17 Changeset [104044] by vangelis@chromium.org
  • 6 edits in trunk/Source

[chromium] Bypass the shadow texture copy for accelerated
canvas when running the compositor in single threaded mode.
https://bugs.webkit.org/show_bug.cgi?id=75146

Source/WebCore:

The texture copy fails on Windows as glCopyTexImage2D() doesn't
support BGRA source textures.
This change also modifies Canvas2DLayerChromium::updateCompositorResources
to call glCopyTexSubImage2D() instead of glCopyTexImage2D() so that
the copy can work with texture allocated via the glTexStorage2D
extension.

Reviewed by James Robinson.

Tests: Canvas2DLayerChromiumTest.cpp

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

Source/WebKit/chromium:

Modified Canvas2DLayerChromium unit test to test canvas with
both threaded and non-threaded compositing.

Reviewed by James Robinson.

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCThread::threadID):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::setTextureManager):
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
(WebCore::TEST_F):

09:08 Changeset [104043] by hclam@chromium.org
  • 10 edits
    4 adds
    1 delete in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-linux/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-lang-attribute-expected.png: Added.
  • platform/chromium-mac/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/glyph-selection-lang-attribute-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/chromium-win/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-win/svg/custom/glyph-selection-lang-attribute-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
08:12 Changeset [104042] by vestbo@webkit.org
  • 1 edit in trunk/Tools/qmake/mkspecs/features/wtf.prf

[Qt] Fix windows build. WTF depends on timeEndPeriod from winmm

08:12 Changeset [104041] by hclam@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
07:55 Changeset [104040] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix test regressions after r104025
https://bugs.webkit.org/show_bug.cgi?id=75545

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-04
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

07:41 Changeset [104039] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix link order of static libraries and unbreak QtWin32

We were keeping the correct static link order between the intermediate
WebKit libraries, but not the internal dependencies for each of those
libraries. The load() will in some instances mess with LIBS, so we need
to ensure that the dependent libraries are added after the library we
are linking against.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_post.prf:
07:33 Changeset [104038] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Use one big printf command instead of many chained echo commands to generate idl_files.tmp

This works around a bug in Cygwin where sh.exe will crash if given a too-long sequence of
&&-chained commands.

Fixes <http://webkit.org/b/75546> <rdar://problem/10622193> REGRESSION (r103519): WebCore's
DerivedSources.make crashes sh.exe if path to WebKit source tree is long enough

Reviewed by Antti Koivisto.

  • DerivedSources.make: Change the '(echo foo && echo bar && echo baz && echo -n) >

./idl_files.tmp' command to 'printf "foo\nbar\nbaz\n" > ./idl_files.tmp'. We use the
patsubst function to append "\n" to each IDL filename, then use the subst function to remove
the spaces between the filenames.

07:26 Changeset [104037] by hclam@chromium.org
  • 63 edits
    3 copies
    4 moves
    5 adds
    8 deletes in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations after Skia roll.

  • platform/chromium-cg-mac-snowleopard/svg/custom/fractional-rects-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/fractional-rects-expected.png.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-linux/svg/carto.net/button-expected.png: Added.
  • platform/chromium-linux/svg/carto.net/button-expected.txt: Removed.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/custom/fractional-rects-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/button-expected.png:
  • platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/button-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/fractional-rects-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png.
  • platform/chromium-mac-snowleopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Removed.
  • platform/chromium-mac/svg/custom/fractional-rects-expected.png: Removed.
  • platform/chromium-win-xp/fast/backgrounds/animated-svg-as-mask-expected.png: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png.
  • platform/chromium-win-xp/svg/as-background-image/animated-svg-as-background-expected.png: Copied from LayoutTests/platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png.
  • platform/chromium-win-xp/svg/text/text-align-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-path-01-b-expected.png: Copied from LayoutTests/platform/chromium-win/svg/text/text-path-01-b-expected.png.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-win/svg/carto.net/button-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/fractional-rects-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-03-b-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/fractional-rects-expected.txt: Removed.
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
  • platform/qt/svg/custom/fractional-rects-expected.txt: Removed.
  • platform/qt/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
  • svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
  • svg/custom/fractional-rects-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/fractional-rects-expected.txt.
  • svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt.
06:51 Changeset [104036] by mihnea@adobe.com
  • 14 edits in trunk/Source/WebCore

[CSSRegions]Rollout support for background-color region styling
https://bugs.webkit.org/show_bug.cgi?id=75007

Reviewed by Tony Chang.

Removed functionality, therefore no new tests. Since this is a temporary rollout,
the tests for region-style with background-color are not removed in this patch, just skipped.

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:
06:34 Changeset [104035] by abecsi@webkit.org
  • 22 edits in trunk/Source/WebKit2

REGRESSION(r104028): Broke editing tests and event coordinates in desktop behaviour
https://bugs.webkit.org/show_bug.cgi?id=75542

[Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601

Unreviewed roll-out.

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-01-04

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::keyPressEvent):
(QQuickWebPage::keyReleaseEvent):
(QQuickWebPage::inputMethodEvent):
(QQuickWebPage::focusInEvent):
(QQuickWebPage::focusOutEvent):
(QQuickWebPage::mousePressEvent):
(QQuickWebPage::mouseMoveEvent):
(QQuickWebPage::mouseReleaseEvent):
(QQuickWebPage::mouseDoubleClickEvent):
(QQuickWebPage::wheelEvent):
(QQuickWebPage::hoverEnterEvent):
(QQuickWebPage::hoverMoveEvent):
(QQuickWebPage::hoverLeaveEvent):
(QQuickWebPage::dragMoveEvent):
(QQuickWebPage::dragEnterEvent):
(QQuickWebPage::dragLeaveEvent):
(QQuickWebPage::dropEvent):
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPage::touchEvent):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::geometryChanged):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
06:21 Changeset [104034] by vestbo@webkit.org
  • 27 edits in trunk

[Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies

The custom qmake variable 'WEBKIT' is used for signaling that a
target depends in some way on other subproject of the WebKit
project. For now this is limited to the set of intermediate
libraries: wtf, javascriptcore, webcore, and webkit2.

This replaces the previous convension of using load(foo) for
just include paths, and CONFIG += foo to also link against foo.

Adding a dependency results in additional include paths being
available, and potentially linking to the library. This is
decided by the build system based on conditions such as what
kind of target is being built and the general build config.

An advantage to his approach is that it simplifies the individual
foo.prf files, for example by allowing us to use INCLUDEPATH +=
and LIBS += as normal instead of prepending.

Reviewed by Simon Hausmann.

06:19 Changeset [104033] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Re-use TestShellLinux.cpp for Android
https://bugs.webkit.org/show_bug.cgi?id=75169

Reviewed by Tony Chang.

TestShellLinux.cpp can be re-used for the test-shell on the WebKit
Chromium port for Android. Most custom inclusions for the DumpRenderTree
target are done in Tools/DumpRenderTree.gypi, but since *Linux.cpp files
are being excluded by a global rule on sources it has to be later in
the project generation process.

  • WebKit.gyp:
06:04 Changeset [104032] by commit-queue@webkit.org
  • 4 edits
    2 copies in trunk/Tools

[Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75488

Patch by Alexander Færøy <ahf@0x90.dk> on 2012-01-04
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/Dialog.qml:
  • MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
  • MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
05:45 Changeset [104031] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

http/tests/appcache/interrupted-update.html is crashing on Win7, mark it so.

  • platform/chromium/test_expectations.txt:
05:36 Changeset [104030] by hclam@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-cg-mac-leopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium/test_expectations.txt:
05:27 Changeset [104029] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip a failing test.
05:26 Changeset [104028] by abecsi@webkit.org
  • 22 edits in trunk/Source/WebKit2

[Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-01-03
Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

The current implementation uses the scale property of the QQuickWebPage
to scale the page in response to pinch gestures.
However for layout and anchoring to work correctly in QML, pinching needs
to change the page size.
This patch applies the pinch scale to the page size and to the transformation
matrix of the drawing area.
Thus the page item's coordinate system is no longer a direct representation
of the WebCore::Page coordinate system and it is no longer suitable as
an inertial frame of reference for input events. The event propagation had
to be moved to the QQuickWebView and the positions translated to content
coordinates when NativeWebEvents are created.

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::geometryChanged):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::usesTraditionalDesktopBehaviour):
(QQuickWebPage::setUsesTraditionalDesktopBehaviour):
(QQuickWebPage::eventHandler):
(QQuickWebPage::setContentSize):
(QQuickWebPage::contentSize):
(QQuickWebPage::setContentScale):
(QQuickWebPage::contentScale):
(QQuickWebPage::transformFromItem):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::mapToWebContent):
(QQuickWebView::mapRectToWebContent):
(QQuickWebView::mapFromWebContent):
(QQuickWebView::mapRectFromWebContent):
(QQuickWebView::geometryChanged):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
05:09 EFLWebKit edited by caio.oliveira@openbossa.org
reordering EFL specific packages so that dependencies come first (diff)
04:55 Changeset [104027] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit

It wasn't really a problem at runtime since the right QtWebKit was
already loaded as a dependency of the web process, but the ldd output
would still be busted.

Reviewed by Simon Hausmann.

04:55 Changeset [104026] by vestbo@webkit.org
  • 11 edits in trunk

[Qt] Move use of $$qtLibraryTarget() to a single place

Reviewed by Kenneth Rohde Christiansen.

03:31 Changeset [104025] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Clean up Qt specific part of editorState()

Reviewed by Simon Hausmann.

Use unsigned instead of int.
No need to clone the range as we don't modify it.
Support selections which include a composition.
If we are not in editable content make sure to use the document element
as the scope for calculating the positions and lengths.
Remove compositionStart/Length as there cannot be a selection and
composition at the same time.

Only tested manually as we don't have everything in place yet
to properly test this.

  • Shared/EditorState.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

03:24 Changeset [104024] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/xmlhttprequest/workers/abort-exception-assert.html makes 6 fast/workers test fail
https://bugs.webkit.org/show_bug.cgi?id=71695

  • platform/qt/Skipped: Unskip http/tests/xmlhttprequest/workers/abort-exception-assert.html,

because the bug was fixed long long time ago by http://trac.webkit.org/changeset/102473.

02:23 Changeset [104023] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.
01:36 Changeset [104022] by mihnea@adobe.com
  • 7 edits in trunk/Source

[Mac]Fix build after changeset 103997
https://bugs.webkit.org/show_bug.cgi?id=75530

Reviewed by Andreas Kling.

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebView.mm:

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:
01:26 Changeset [104021] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Refactor the way using cairo in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=74993

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-04
Reviewed by Nikolas Zimmermann.

For now there are cairo related code scattered around the ewk_tiled_backing_store.
From the point of code complexity view, it doesn't look good and I couldn't notice any benefit of it.
So, this patch will let cairo related code be used only for painting operation.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_tile_new):

  • ewk/ewk_tiled_model.cpp:

(ewk_tile_new):
(ewk_tile_free):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb):

01:17 Changeset [104020] by commit-queue@webkit.org
  • 4 edits in trunk

Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=75238

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2012-01-04
Reviewed by Antonio Gomes.

.:

  • Source/cmakeconfig.h.cmake: Modified to add a new cmakedefine ENABLE_DOWNLOAD_ATTRIBUTE.

Tools:

Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that
it could initiate download directly if it has the download attribute in the link
and doesn't need to open new blank page for the target="_blank". Enabling this
feature in the BlackBerry porting also prepares for later blob feature implementation.

  • Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on

for the BlackBerry porting.

00:53 EFLWebKitCodingStyle edited by t.morawski@samsung.com
(diff)
00:48 Changeset [104019] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=75376

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-04
Reviewed by Adam Barth.

  • canvas/philip/tests/2d.pattern.image.string-expected.txt:
  • canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
  • platform/qt/Skipped:

01/03/12:

23:37 Changeset [104018] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
https://bugs.webkit.org/show_bug.cgi?id=75475

Reviewed by Martin Robinson.

The problem is that the property blurb contains <a ping> and tree
view uses gtk_tooltip_set_markup() internally, so we need to
escape the text.

  • MiniBrowser/gtk/BrowserSettingsDialog.c:

(browserSettingsDialogConstructed): Escape property blurb before
storing it in the GtkTreeModel.

23:35 Changeset [104017] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Scrollbars are drawn behind the window resize grip
https://bugs.webkit.org/show_bug.cgi?id=75384

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseNotifyResizerSizeForWindow): Get the size of the
main window resize grip and send it to the page proxy if it
overlaps with the view.
(toplevelWindowResizeGripVisibilityChanged): Call
webkitWebViewBaseNotifyResizerSizeForWindow().
(webkitWebViewBaseRealize): Get the toplevel window and connect to
notify::resize-grip-visible signal.
(webkitWebViewBaseSizeAllocate): Call
webkitWebViewBaseNotifyResizerSizeForWindow().

23:26 Changeset [104016] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG: The assertion that a double-voted variable cannot become double-unvoted is wrong
https://bugs.webkit.org/show_bug.cgi?id=75516
<rdar://problem/10640266>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Removed the offending assertion, since it was wrong. Also hardened the code to make
this case less likely by first having the propagator fixpoint converge, and then doing
double voting combined with a second fixpoint. This is neutral on benchmarks and
fixes the assertion in a fairly low-risk way (i.e. we won't vote a variable double
until we've converged to the conclusion that it really is double).

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagatePredictions):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):

LayoutTests:

Reviewed by Andy Estes.

Created a fuzzer that produces sufficiently awkward data flow that includes variables
that become either double, or integer, or mix of double and integer only after multiple
iterations of a fixpoint. This crashes the compiler prior to this patch, but works with
this patch.

  • fast/js/dfg-double-vote-fuzz-expected.txt: Added.
  • fast/js/dfg-double-vote-fuzz.html: Added.
  • fast/js/script-tests/dfg-double-vote-fuzz.js: Added.
23:05 Changeset [104015] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLConstructionSite::attach shouldn't return a value
https://bugs.webkit.org/show_bug.cgi?id=75520

Reviewed by Eric Seidel.

We used to return a value to avoid some refchurn, but now that we're
using tasks, we always need to take that reference. Removing the
return value lets us remove the template parameter, which is a boon.
This patch has no impact on the html-parser.html benchmark.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
(WebCore::HTMLConstructionSite::fosterParent):

  • html/parser/HTMLConstructionSite.h:
23:03 Changeset [104014] by abarth@webkit.org
  • 4 edits in trunk

Fix assert when foster parenting self-closing elements
https://bugs.webkit.org/show_bug.cgi?id=75527

Unreviewed.

Source/WebCore:

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::fosterParent):

  • We can't execute this task immediately because the code for self-closing elements wants to set the self-closing flag. Instead, we queue the task.

LayoutTests:

Add a test case that used to case an assert.

  • html5lib/resources/webkit02.dat:
22:43 Changeset [104013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Need to support credentials in the URL
https://bugs.webkit.org/show_bug.cgi?id=75341

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-01-03
Reviewed by George Staikos.

No new tests required.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

22:24 Changeset [104012] by jochen@chromium.org
  • 10 edits
    1 delete in trunk/LayoutTests

Replace clearLocalStorage.js with localStorage.clear() now that it's implemented
https://bugs.webkit.org/show_bug.cgi?id=75484

Reviewed by Daniel Bates.

  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/missing-arguments.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/clearLocalStorage.js: Removed.
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
22:22 Changeset [104011] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix ChangeLog

22:09 Changeset [104010] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Use data decoding swizzle for turbo JPEG grayscale images
https://bugs.webkit.org/show_bug.cgi?id=75189

Reviewed by Adam Barth.

No new tests. Covered by exiting tests, in particular for grayscale
images that were corrupted by earlier versions on libjpeg-turbo:

tables/mozilla/bugs/bug29314.html
tables/mozilla/bugs/bug13169.html
tables/mozilla/bugs/bug10565.html
tables/mozilla/bugs/bug11026.html
fast/repaint/backgroundSizeRepaint.html
fast/repaint/block-layout-inline-children-replaced.html
fast/repaint/clipped-relative.html
fast/repaint/selected-replaced.html
tables/mozilla/bugs/bug12908-1.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): Use a data decoding swizzle for
JCS_GRAYSCALE images.

21:51 Changeset [104009] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Minor speed improvement in HTML parser
https://bugs.webkit.org/show_bug.cgi?id=75517

Reviewed by Eric Seidel.

This improves the html-parser.html benchmark by 0.3%. I don't think
that's actually anything to write home about, but this patch makes me
feel better about my life.

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):

21:40 Changeset [104008] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove temporary code that we've inserted to implement the [Supplemental] IDL incrementally
https://bugs.webkit.org/show_bug.cgi?id=75510

Reviewed by Adam Barth.

Now all build systems support the [Supplemental] IDL. This patch removes all
temporary code that we've inserted to implement the [Supplemental] IDL.

No tests. No change in behavior. Confirm that all builds pass.

  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl: Removed all attributes with a temporal [Supplemented] IDL.
21:28 Changeset [104007] by noel.gordon@gmail.com
  • 3 edits
    1 add
    6 deletes in trunk/LayoutTests

Make fast/multicol/huge-column-count.html dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=75513

Reviewed by Adam Barth.

Test added in r83470: convert it to dumpAsText, update expectations.

  • fast/multicol/huge-column-count-expected.txt: Added.
  • fast/multicol/huge-column-count.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/multicol/huge-column-count-expected.png: Removed.
  • platform/efl/fast/multicol/huge-column-count-expected.txt: Removed.
  • platform/gtk/fast/multicol/huge-column-count-expected.txt: Removed.
  • platform/mac/fast/multicol/huge-column-count-expected.txt: Removed.
  • platform/qt/fast/multicol/huge-column-count-expected.png: Removed.
  • platform/qt/fast/multicol/huge-column-count-expected.txt: Removed.
20:39 Changeset [104006] by abarth@webkit.org
  • 2 edits in trunk/PerformanceTests

html-parser.html takes too long to run
https://bugs.webkit.org/show_bug.cgi?id=75515

Reviewed by Eric Seidel.

In working on runner.js, we introduced a factor of 10 increase to the
running time of this benchmark. This patch dials down the number of
iterations to something more user-friendly.

  • Parser/html-parser.html:
20:38 Changeset [104005] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Give embedders a chance to handle postMessage calls
https://bugs.webkit.org/show_bug.cgi?id=73883

Source/WebCore:

To support cross-process postMessage calls in Chromium (bug 73337), we need to intercept
postMessage calls to proxy windows. Originally we were just going to add a native event
listener on the Chromium side, but that required more changes to WebKit and was a bit of
a hack. See bug 73359 for a discuss about moving to this approach.

Patch by Karl Koscher <supersat@chromium.org> on 2012-01-03
Reviewed by Adam Barth.

Test: platform/chromium/fast/events/intercept-postmessage.html

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::willCheckAndDispatchPostMessage): new method to allow the

embedder to intercept postMessage calls

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired): add a call to

FrameLoaderClient::willCheckAndDispatchPostMessage

Source/WebKit/chromium:

Patch by Karl Koscher <supersat@chromium.org> on 2012-01-03
Reviewed by Adam Barth.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):

interface to give the embedder a chance to handle this postMessage call

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent): Call

willCheckAndDispatchMessageEvent on WebFrameClient

  • src/FrameLoaderClientImpl.h:
19:54 Changeset [104004] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

script-in-svg-in-HTML doesn't run
https://bugs.webkit.org/show_bug.cgi?id=75233

Reviewed by Daniel Bates.

Add a test to make sure that we run scripts in SVG.

  • fast/parser/script-in-svg-runs-expected.txt: Added.
  • fast/parser/script-in-svg-runs.html: Added.
19:39 Changeset [104003] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Prevent crashing due to NULL texture updater.
https://bugs.webkit.org/show_bug.cgi?id=75288

Patch by Eric Penner <epenner@google.com> on 2012-01-03
Reviewed by James Robinson.

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/ImageLayerChromium.h:
19:36 Changeset [104002] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] CCLayerSorter accidentally reverses order of some layers.
https://bugs.webkit.org/show_bug.cgi?id=75046

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-01-03
Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCLayerSorterTest.cpp

Fixes two related bugs that were causing z-ordering problems in
layers when preserves3D triggers the need for layer sorting.

The first problem was that CCLayerSorter accidentally reversed the
order of layers when there was no sorting dependency between them.

The second problem was that zDiff had numerical precision problems
that forced sorting dependencies that were sometimes incorrect,
when the dependencies should not have existed.

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::sort):

Source/WebKit/chromium:

  • tests/CCLayerSorterTest.cpp:

(WebCore::TEST):

19:34 Changeset [104001] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add support of blob form data to the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=75218

Pass FormDataElement::encodedBlob type of form data to the BlackBerry
platform request to support blob data and blob file range.

Reviewed by George Staikos.

The port can't be built now, no new tests so far.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

18:57 Changeset [104000] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

Two null crashes in Treebuilder
https://bugs.webkit.org/show_bug.cgi?id=66101

Reviewed by Eric Seidel.

Source/WebCore:

The underly issue with causing the crash is that we're re-entering the
tree builder. We've done a bunch of point fixes around tree builder
re-entrancy, but neither the implementation nor the specification are
really designed to handle re-entrancy.

Firefox avoids this problem by putting the parser on its own thread. I
don't think we're quite ready to do that yet (although we will
eventually, presumably, as computers become ever more parallel). The
approach in this patch is to queue up the DOM mutations and actually
perform them on a shallower stack. That's essentially the approach
we've used for executing <scripts>.

This patch queues up DOM modifications and executes them from a clean
call stack, stopping us from re-entering the tree builder. We might
need to experiment with exactly where to kick off the queue, but this
location seems reasonable and fixes the crash.

Test: fast/parser/re-enter-and-crash.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeTask):

  • Add a helper function for actually executing a queue DOM mutation.

(WebCore::HTMLConstructionSite::attach):

  • Instead of actually attaching the element to the DOM, this function now queues the element for attachment. In a follow-up patch, I plan to change this function to return void (and I'll probably rename it to something that makes it clear that it only queues the attachment).

(WebCore::HTMLConstructionSite::executeQueuedTasks):
(WebCore::HTMLConstructionSite::insertDoctype):

  • Setting the compatmode from the Doctype requires the doctype to actually be in the DOM, so we need to execute our queued tasks synchronously. We can likely improve this function by passing the Doctype element explicitly in a follow-up patch.

(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::fosterParent):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSiteTask::HTMLConstructionSiteTask):

  • Add a task object that holds on to the relevant elements. We define some vector traits for this object to match the traits on RefPtr (which make Vector operations faster by explaining that this type is moveable without having to churn reference counts).
  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::pushCommon):

  • We delay the "begin parsing" call until we actually attach the element to the DOM. That splits the responsibility for calling begin/finished, which is less than ideal, but I didn't see another solution.
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):

  • Kick off the queued mutations.

LayoutTests:

Test that we no longer crash on this test case.

  • fast/parser/re-enter-and-crash-expected.txt: Added.
  • fast/parser/re-enter-and-crash.html: Added.
18:41 Changeset [103999] by abarth@webkit.org
  • 10 edits in trunk

view-source doesn't colorize </script> correctly
https://bugs.webkit.org/show_bug.cgi?id=62971

Reviewed by Eric Seidel.

Source/WebCore:

The reason these tags weren't colorized correctly was because the
characters for the end tags where consumed by the tokenizer at the same
time as it consumed the text of the script tag. These characters are
buffered internally by the tokenizer because the tokenizer is searching
for "an appropriate end tag", which is "</script>" in this case.

I tried a number of different approaches to fixing this bug. The
approach in this patch adds an accessor to the tokenizer to read out
the buffered characters. This approach makes it easier for the
HTMLSourceTracker to get exactly the right value for these buffered
characters without having to do a complicated simulation of the
buffering itself.

Tests: fast/frames/viewsource-plain-text-tags.html:

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):

  • Give the HTMLSourceTracker a pointer to the tokenizer so it can ask for the buffered characters.
  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):

  • The idea here is to treat characters buffered internally by the tokenizer the same way we treat characters that were contained in a previous segment of source. We copy them into our accumulation buffer and adjust the token base offset to account for the extra characters.

(WebCore::HTMLSourceTracker::end):

  • Don't consier the character buffered by the tokenizer to be part of the token we've just finished.

(WebCore::HTMLSourceTracker::sourceForToken):

  • Remove the assumption that all of the m_previousSource is contained in the source for the current token. Because we now understand that the tokenizer can buffer some characters internally, we might not exhaust the m_previousSource.
  • html/parser/HTMLSourceTracker.h:
    • Rename m_sourceFromPreviousSegments to m_previousSource and changed to a SegementedString to avoid extra mallocs we keep appending tiny segments.
    • Rename m_source to m_currentSource to contrast nicely with m_previousSource.
  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):

  • Previously, we cleared the temporary buffer lazily when we needed to add new characters to it. Now we clear it eagerly so that it's length tells us whether we're currently using it to store characters.
  • Previously, we weren't storing the character that we used to terminate the appropriate end tag (e.g., the > in </script>) because we didn't need to "unbuffer" that character into the HTMLToken::appendToCharacter. Now, we do store that character in the temporary buffer so that the HTMLSourceTracker can see that character.

(WebCore::HTMLTokenizer::bufferedCharacters):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::numberOfBufferedCharacters):

  • Add accessor methods to copy out the buffered characters.
  • Also, unrelated to the rest of this patch, I made the constructor for HTMLTokenizer explicit because it takes only a single paramater, per the style guide.
  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::clear):

  • SegmentedString::clear wasn't clearing all of its state. I don't think this issue was actually observable, but I noticed it when working on this patch, so I fixed it.

LayoutTests:

  • fast/frames/viewsource-plain-text-tags.html:
18:28 Changeset [103998] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: fast/filesystem/workers/file-writer-events.html crash suppressed on Linux
due to BUGCR108798.

  • platform/chromium/test_expectations.txt:
18:26 Changeset [103997] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/Source/WebCore

Exclude Mac's PlatformEventFactory from iOS
https://bugs.webkit.org/show_bug.cgi?id=75493

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-03
Reviewed by Sam Weinig.

Move PlatformEventFactory.(h|cpp) to PlatformEventFactoryMac(h|cpp) and exclude the file
from iOS build.

  • Configurations/WebCore.xcconfig: Also exclude EventHandlerMac for consistency.
  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/PlatformEventFactoryMac.h: Renamed from Source/WebCore/platform/mac/PlatformEventFactory.h.
  • platform/mac/PlatformEventFactoryMac.mm: Renamed from Source/WebCore/platform/mac/PlatformEventFactory.mm.

(WebCore::globalPoint):
(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::mouseEventTypeForEvent):
(WebCore::clickCountForEvent):
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::gestureEventTypeForEvent):
(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):
(WebCore::isKeypadEvent):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::isKeyUpEvent):
(WebCore::modifiersForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformEventFactory::createPlatformMouseEvent):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformEventFactory::createPlatformWheelEvent):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformEventFactory::createPlatformKeyboardEvent):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebCore::PlatformEventFactory::createPlatformGestureEvent):

18:25 Changeset [103996] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] LocalFileSystemChromium needs some thread safety fixes.
https://bugs.webkit.org/show_bug.cgi?id=75494

Reviewed by Dmitry Titov.

This is essentially the same fix as r102894 except in slightly different code.

The important part of this fix is the removal of AllowCrossThreadAccess so
that ref counting happens appropriately.

Minor clean up throughout: Removed unnecessary WTF prefix in many
of these places and unnecessary String().

  • src/LocalFileSystemChromium.cpp: See r102894 since this

is basically the same thing.

17:45 Changeset [103995] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed CR109077 and updated expectations for http/tests/inspector/appcache/appcache-swap.html.

  • platform/chromium/test_expectations.txt:
17:28 Changeset [103994] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimize AudioBufferSourceNode process by avoiding interpolation when pitchRate==1
https://bugs.webkit.org/show_bug.cgi?id=74592

Patch by Wei James <james.wei@intel.com> on 2012-01-03
Reviewed by Kenneth Russell.

Covered by existing webaudio layout tests, especially webaudio/audiobuffersource-playbackrate.html

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

  • webaudio/AudioBufferSourceNode.h:
17:20 Changeset [103993] by leviw@chromium.org
  • 135 edits in branches/subpixellayout/LayoutTests/platform

Updating test expectations for SVG and tables.

17:18 Changeset [103992] by joepeck@webkit.org
  • 8 edits in trunk/Source/WebCore

<http://webkit.org/b/75504> Web Inspector: Access to Node Highlighting info without drawing

Provide a "getHighlight" method alongside "drawHighlight" that
gets most of the important node highlighting information. This
can be used by a port to do its own node highlighting or provide
extra content without interfering with the highlight rects.

Reviewed by Timothy Hatcher.

  • WebCore.xcodeproj/project.pbxproj:

Privately expose the Highlight struct in DOMNodeHighlighter.h.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawHighlight):
(WebCore::DOMNodeHighlighter::getHighlight):

  • inspector/DOMNodeHighlighter.h:

Reuse the existing draw code to instead populate
the Highlight struct with the information it is
about to draw, and only draw if there is a context.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::getHighlight):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getHighlight):

  • inspector/InspectorDOMAgent.h:

Get highlight information by going through getHighlight
in InspectorController. This is alongside drawHighlight.

17:10 Changeset [103991] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Clear localStorage before making assumption about its contents
https://bugs.webkit.org/show_bug.cgi?id=75469

Reviewed by Daniel Bates.

  • platform/chromium/permissionclient/storage-permission.html:
16:53 Changeset [103990] by commit-queue@webkit.org
  • 26 edits
    1 move
    9 adds
    2 deletes in trunk

[chromium] Push drawsContent and contentsVisible into accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=71209

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-01-03
Reviewed by James Robinson.

Source/WebCore:

Tests: compositing/visibility/visibility-simple-canvas2d-layer.html

compositing/visibility/visibility-simple-video-layer.html
compositing/visibility/visibility-simple-webgl-layer.html

Rebaselined compositing/visibility/visibility-image-layers.html

The CSS visibility property was not being properly obeyed by many
specialized layer types in the accelerated compositor. The root of
the problem was that drawsContent and contentsVisible flags were
not properly propagated into the compositor. This patch removes
the drawsContent() callback, and instead makes sure that
drawsContent and contentsVisible are "pushed" through the
accelerated compositor.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setDrawsContent):
(WebCore::GraphicsLayerChromium::setContentsVisible):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setIsDrawable):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::drawsContent):

  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::drawsContent):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::dumpLayerProperties):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):

  • src/WebContentLayerImpl.h:
  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::drawsContent):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::WebLayerImpl):

  • src/WebLayerImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

LayoutTests:

  • compositing/visibility/visibility-image-layers-expected.png:
  • compositing/visibility/visibility-image-layers-expected.txt: Renamed from LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-expected.txt.
  • compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
  • compositing/visibility/visibility-simple-canvas2d-layer-expected.txt: Added.
  • compositing/visibility/visibility-simple-canvas2d-layer.html: Added.
  • compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • compositing/visibility/visibility-simple-video-layer-expected.txt: Added.
  • compositing/visibility/visibility-simple-video-layer.html: Added.
  • compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
  • compositing/visibility/visibility-simple-webgl-layer-expected.txt: Added.
  • compositing/visibility/visibility-simple-webgl-layer.html: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
16:44 Changeset [103989] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 102392 - Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
https://bugs.webkit.org/show_bug.cgi?id=74126

Reviewed by Tony Chang.

The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.

Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.

  • editing/markup.cpp:

(WebCore::createFragmentFromText):
Review URL: http://codereview.chromium.org/9008054

16:34 Changeset [103988] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Make sure root damage rect gets passed to renderer
https://bugs.webkit.org/show_bug.cgi?id=74893

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-01-03
Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCLayerTreeHostImplTest.cpp

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::swapBuffers):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::swapBuffers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
(WebKit::PartialSwapTrackerContext::initialize):
(WebKit::PartialSwapTrackerContext::postSubBufferCHROMIUM):
(WebKit::PartialSwapTrackerContext::getString):
(WebKit::PartialSwapTrackerContext::partialSwapRect):

16:29 Changeset [103987] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, svg/carto.net/selectionlist.svg appears to
just need a rebaseline on Linux.

  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium/test_expectations.txt:
16:25 Changeset [103986] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: files bug CR109068 for appcache/interrupted-update.html crash.

  • platform/chromium/test_expectations.txt:
16:23 Changeset [103985] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Increment the code-review.js version number to bust browser
caches.

  • PrettyPatch/PrettyPatch.rb:
16:18 Changeset [103984] by jochen@chromium.org
  • 7 edits in trunk/Tools

When showing results.html pass a correct URL to webbrowser.open
https://bugs.webkit.org/show_bug.cgi?id=75438

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/system/filesystem.py:

(file_path_as_url):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(file_path_as_url):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(test_file_path_as_url):

  • Scripts/webkitpy/layout_tests/port/base.py:

(show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(test_show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(test_results_directory_relative):

16:16 Changeset [103983] by ojan@chromium.org
  • 2 edits in trunk/Tools

shrink the header on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=65153

Reviewed by Adam Roben.

Move some of the "show" links to be to the right of the header
instead of below the header when they content they're showing
is hidden. That way we don't waste vertical space on them.

No new tests. This code is covered by existing tests.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
16:10 Changeset [103982] by leviw@chromium.org
  • 115 edits in branches/subpixellayout

Fixing/simplifying FixedRect's TransformationMatrix::mapRect implementation. Changing clampedBoundsOfProjectedQuad to clamp to LayoutUnits. This fixes transformed hit testing and clip rects. Adding a clampToLayoutUnit method. Rebaselining more tests.

16:06 Changeset [103981] by fpizlo@apple.com
  • 3 edits
    12 adds in trunk

REGRESSION (r98196-98236): Incorrect layout of iGoogle with RSS feeds
https://bugs.webkit.org/show_bug.cgi?id=75303
<rdar://problem/10633533>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

The this argument was not being kept alive in some cases during inlining and intrinsic
optimizations.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionCheck):
(JSC::DFG::ByteCodeParser::handleInlining):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-inline-unused-this-expected.txt: Added.
  • fast/js/dfg-inline-unused-this-method-check-expected.txt: Added.
  • fast/js/dfg-inline-unused-this-method-check.html: Added.
  • fast/js/dfg-inline-unused-this.html: Added.
  • fast/js/dfg-intrinsic-unused-this-expected.txt: Added.
  • fast/js/dfg-intrinsic-unused-this-method-check-expected.txt: Added.
  • fast/js/dfg-intrinsic-unused-this-method-check.html: Added.
  • fast/js/dfg-intrinsic-unused-this.html: Added.
  • fast/js/script-tests/dfg-inline-unused-this-method-check.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-inline-unused-this.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-intrinsic-unused-this-method-check.js: Added.

(bar):
(baz):

  • fast/js/script-tests/dfg-intrinsic-unused-this.js: Added.

(bar):
(baz):

15:59 Changeset [103980] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Fix compilation with clang and the shared build
https://bugs.webkit.org/show_bug.cgi?id=75492

Reviewed by Ojan Vafai.

  • WebKit.gyp: Turn off -Wglobal-constructors because test files using

GTEST have global constructors.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F): Move global into test function.

15:40 Changeset [103979] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

v8 binding: npCreateV8ScriptObject() should not returned an existing V8NPObject if the rootObject doesn't match
https://bugs.webkit.org/show_bug.cgi?id=74515

Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-01-03
Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/plugins/create-v8-script-objects.html

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

LayoutTests:

  • http/tests/plugins/create-v8-script-objects-expected.txt: Added.
  • http/tests/plugins/create-v8-script-objects.html: Added.
  • http/tests/plugins/resources/create-v8-script-objects-iframe.html: Added.
15:39 Changeset [103978] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Revert accidentally removed chrome client compositing check
https://bugs.webkit.org/show_bug.cgi?id=75500

Reviewed by James Robinson.

This check was overzealously removed in r103968 as a part of
re-enabling compositing for RTL pages. Add it back.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::allowedCompositingTriggers):

15:31 Changeset [103977] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

15:28 Changeset [103976] by kerz@chromium.org
  • 1 copy in branches/chromium/wpotest

Branch at same point as M17 for WPO testing.

15:27 Changeset [103975] by jonlee@apple.com
  • 21 edits in trunk/Source

Leak of WebNotificationClient when page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=74980
<rdar://problem/10611231>

Reviewed by Mark Rowe.

Source/WebCore:

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::~NotificationController): Notify the client
that the controller has been destroyed.

  • notifications/NotificationPresenter.h: Add notificationControllerDestroyed()

callback to the client interface.

Source/WebKit:

  • blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationControllerDestroyed): Empty implementation, because ownership
model differs.

  • blackberry/WebCoreSupport/NotificationPresenterImpl.h:

Source/WebKit/chromium:

  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationControllerDestroyed): Empty implementation because ownership
model differs.

  • src/NotificationPresenterImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/NotificationPresenterClientEfl.cpp:

(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed): Stub implementation, because
the notification presenter is unimplemented.

  • WebCoreSupport/NotificationPresenterClientEfl.h:

Source/WebKit/mac:

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::notificationControllerDestroyed): Remove the instance.

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::notificationControllerDestroyed): Empty implementation, because
ownership model differs.

  • WebCoreSupport/NotificationPresenterClientQt.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::notificationControllerDestroyed): Delete the instance.

  • WebProcess/WebCoreSupport/WebNotificationClient.h:
15:20 Changeset [103974] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for list-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75443

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for list-style.

Test: fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.
15:13 Changeset [103973] by tony@chromium.org
  • 2 edits
    6 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, rebaseline of svg/hixie/text/003.html. It
doesn't look flaky on the flakiness dashboard.

  • platform/chromium-linux/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-mac/svg/hixie/text/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-win/svg/hixie/text/003-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:07 Changeset [103972] by enne@google.com
  • 6 edits in trunk/Source/WebCore

[chromium] Remove unneeded content vs. layer space distinction in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=75498

Reviewed by James Robinson.

Long ago, before scrollbars became their own layers, tiled layers had
a distinction between content space (what's mostly called layer space
elsewhere) and layer space (the transformed content space). It seemed
like this transform could get reused for supporting RTL pages, but as
that's not the case, it should be eradicated.

Tiled layers now deal with everything in "layer space", which is a 2d
rectangle starting at (0, 0) in the top left of the layer and
extending to contentBounds() in the bottom right.

As no code actually set the tiler position, this change should be a
no-op.

Test: LayoutTests/compositing/

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::clearDirty):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::layerRectToTileIndices):
(WebCore::CCLayerTilingData::tileRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

14:54 UsingGitWithWebKit edited by jamesr@google.com
(diff)
14:47 Changeset [103971] by eae@chromium.org
  • 10 edits in branches/subpixellayout

Fixed rounding discrepancies between clientWidth, scrollWidth and foregroundClipWidth by using representing all by app units internally and rounding using pixelSnapped at use (as opposed to compute) time.

14:33 Changeset [103970] by jamesr@google.com
  • 8 edits
    1 delete in trunk/Source/WebKit/chromium

[chromium] Remove WebLayerClient
https://bugs.webkit.org/show_bug.cgi?id=75481

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/platform/WebContentLayer.h:
  • public/platform/WebExternalTextureLayer.h:
  • public/platform/WebLayer.h:
  • public/platform/WebLayerClient.h: Removed.
  • src/WebContentLayer.cpp:
  • src/WebExternalTextureLayer.cpp:
  • src/WebLayer.cpp:
14:33 Changeset [103969] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

14:13 Changeset [103968] by enne@google.com
  • 7 edits in trunk

[chromium] Support RTL pages and elements in the compositor
https://bugs.webkit.org/show_bug.cgi?id=56591

Reviewed by James Robinson.

Source/WebKit/chromium:

As the noncomposited content host layer is created and managed by the
Chromium compositor, adjust its transform appropriately in the layer
tree and at paint time to handle the offset required due to the
initial containing block of RTL pages.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::allowedCompositingTriggers):

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::paintContents):

  • src/NonCompositedContentHost.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

LayoutTests:

Re-enable RTL tests for Chromium.

  • platform/chromium/test_expectations.txt:
13:57 Changeset [103967] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 102089 - Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
BUG=106316
Review URL: http://codereview.chromium.org/9072017

13:56 Changeset [103966] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/963

Merge 102875 - Crash due to incorrect parsing of isolates
BUG=106200
Review URL: http://codereview.chromium.org/9071024

13:50 Changeset [103965] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 103318 - Crash in RenderTable::outerBorderAfter
BUG=106340
Review URL: http://codereview.chromium.org/9073008

13:45 Changeset [103964] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=75140

Reviewed by Sam Weinig.

Rewrite JSArray::putSlowCase to be much cleaner & simpler.

This rewrite only significantly changes behaviour for sparse array, specifically
in how sparse arrays are reified back to vector form. This does not affect arrays
with less than 10000 entries (since these always use a vector). The more common
cases of sparse array behavior (though large sparse arrays are rare) - arrays that
always remain sparse, and arrays that are filled in reverse sequential order -
should be just as fast or faster (since reification is simpler & no longer
requires map lookups) after these changes.

Simplifying this code allows all cases of putByIndex that need to grow the vector
to do so via increaseVectorLength, which means that this method can encapsulate
the policy of determining how the vector should be grown.

No performance impact.

  • runtime/JSArray.cpp:

(JSC::isDenseEnoughForVector):

  • any array of length <= MIN_SPARSE_ARRAY_INDEX is dense enough for a vector.

(JSC::JSArray::putByIndex):

  • simplify & comment.

(JSC::JSArray::putByIndexBeyondVectorLength):

  • Re-written to be much clearer & simpler.

(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):

  • add explicit checks against MAX_STORAGE_VECTOR_LENGTH, so clients do not need do so.

(JSC::JSArray::push):

  • simplify & comment.
  • runtime/JSArray.h:
    • removed SparseArrayValueMap::take.
13:41 Changeset [103963] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 102263 - Crash from multicol spans with layers
BUG=96499
Review URL: http://codereview.chromium.org/9071019

13:40 Changeset [103962] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 101584 - Crash from first letter text fragments having flows split
BUG=96499
Review URL: http://codereview.chromium.org/9014025

13:37 Changeset [103961] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

13:33 Changeset [103960] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=75140

Reviewed by Sam Weinig.

Simplify JSArray creation - remove ArgsList/JSValue* create methods
(this functionality can be implemented in terms of tryCreateUninitialized).

  • JavaScriptCore.exp:
  • runtime/ArrayConstructor.cpp:
    • use constructArray/constructEmptyArray instead of calling JSArray::create directly

(JSC::constructArrayWithSizeQuirk):

  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
    • removed ArgsList/JSValue* create methods
  • runtime/JSGlobalObject.h:

(JSC::constructEmptyArray):
(JSC::constructArray):

  • changed to be implemented in terms of JSArray::tryCreateUninitialized
13:24 Changeset [103959] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk/Tools

Add a tool to analyze change logs
https://bugs.webkit.org/show_bug.cgi?id=72243

Reviewed by Eric Seidel.

Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
for visualizing json files.

Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
generates json files, and N is the number of changelogs to parse.

  • Scripts/webkitpy/common/config/contributionareas.py: Added names().
  • Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
  • Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/data/summary.html: Added.
  • Scripts/webkitpy/tool/steps/options.py:
13:05 Changeset [103958] by barraclough@apple.com
  • 13 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75429
ThrowTypeError should be a singleton object

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Per section 13.2.3 of the spec.
We could change setAccessorDescriptor to be able to share the global
GetterSetter object, rather than storing the accessor functions and
creating a new GetterSetter in defineProperty - but this won't be a
small change to PropertyDescriptors (and would probably mean making
GetterSetter objects immutable?) - so I'll leave that for another
patch.

  • JavaScriptCore.exp:
    • don't export setAccessorDescriptor
  • runtime/Arguments.cpp:

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

  • call throwTypeErrorGetterSetter instead of createTypeErrorFunction
  • runtime/Error.cpp:
  • runtime/Error.h:
    • remove createTypeErrorFunction
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
    • remove unused createDescriptorForThrowingProperty
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • removed m_strictModeTypeErrorFunctionStructure.
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::internalFunctionStructure):

  • removed m_strictModeTypeErrorFunctionStructure.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setAccessorDescriptor):

  • changed to take a GetterSetter
  • runtime/PropertyDescriptor.h:
    • changed to take a GetterSetter

LayoutTests:

Per section 13.2.3 of the spec.

  • fast/js/basic-strict-mode-expected.txt:
    • ThrowTypeError is a singleton, so cannot generate property-specific error messages.
  • fast/js/script-tests/strict-throw-type-error.js: Added.
  • fast/js/strict-throw-type-error-expected.txt: Added.
  • fast/js/strict-throw-type-error.html: Added.
    • added test case that ThrowTypeError is a singleton
12:21 Changeset [103957] by joepeck@webkit.org
  • 40 edits in trunk

<http://webkit.org/b/59951> Implement Date and Time Input Value Sanitization

Source/WebCore:

Sanitize non-parsable incoming strings to the empty string.

Reviewed by Kent Tamura.

Covered by existing tests.

  • html/BaseDateAndTimeInputType.h:
  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::sanitizeValue): check if the
incoming string is valid. If not just return the empty string.

LayoutTests:

Update ValidityState typeMismatch tests for date types, since
setting an invalid value now sanitized to the empty string.
So, what used to be an invalid value with a typeMismatch is
now a valid empty string and there is never a typeMismatch.

  • for rangeOverflow / rangeUnderflow tests update the test to point out when a value was sanitized.
  • for typeMismatch tests, typeMismatch can no longer happen for sanitized values. Change the test to output if the value was sanitized or not and ensure that we are never in a typeMismatch state. Disabled inputs are also sanitized when their value changes.

Reviewed by Kent Tamura.

  • fast/forms/date/ValidityState-rangeOverflow-date-expected.txt:
  • fast/forms/date/ValidityState-rangeOverflow-date.html:
  • fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt:
  • fast/forms/date/ValidityState-rangeUnderflow-date.html:
  • fast/forms/date/ValidityState-typeMismatch-date-expected.txt:
  • fast/forms/date/ValidityState-typeMismatch-date.html:
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime.html:
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html:
  • fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-typeMismatch-datetime.html:
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt:
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html:
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt:
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html:
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt:
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html:
  • fast/forms/month/ValidityState-rangeOverflow-month-expected.txt:
  • fast/forms/month/ValidityState-rangeOverflow-month.html:
  • fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt:
  • fast/forms/month/ValidityState-rangeUnderflow-month.html:
  • fast/forms/month/ValidityState-typeMismatch-month-expected.txt:
  • fast/forms/month/ValidityState-typeMismatch-month.html:
  • fast/forms/time/ValidityState-rangeOverflow-time-expected.txt:
  • fast/forms/time/ValidityState-rangeOverflow-time.html:
  • fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt:
  • fast/forms/time/ValidityState-rangeUnderflow-time.html:
  • fast/forms/time/ValidityState-typeMismatch-time-expected.txt:
  • fast/forms/time/ValidityState-typeMismatch-time.html:
  • fast/forms/week/ValidityState-rangeOverflow-week-expected.txt:
  • fast/forms/week/ValidityState-rangeOverflow-week.html:
  • fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt:
  • fast/forms/week/ValidityState-rangeUnderflow-week.html:
  • fast/forms/week/ValidityState-typeMismatch-week-expected.txt:
  • fast/forms/week/ValidityState-typeMismatch-week.html:
12:19 Changeset [103956] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary forward declaration of Function
https://bugs.webkit.org/show_bug.cgi?id=75485

Reviewed by Dan Bernstein.

  • Platform/WorkQueue.h:
12:08 Changeset [103955] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderLayer::backgroundClipRect should not check parent()
https://bugs.webkit.org/show_bug.cgi?id=73731

Reviewed by Simon Fraser.

Clean-up only, no expected change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::backgroundClipRectForPosition): Changed RenderObject::isPositioned() to
a check for AbsolutePosition for consistency but also as this is equivalent due to:

  • the previous check for FixedPosition.
  • RenderView, which is positioned, will never goes to this code as it has no parent().

(WebCore::RenderLayer::backgroundClipRect): Removed the parent() check. While at
it, also moved the inline initialization of |backgroundClipRect| to its own function
and removed a |view| check as the associated ASSERT seems to never have been reached.

12:02 Changeset [103954] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/10637779> REGRESSION (r102247): Focus ring is not drawn around a button

Rubber-stamped by Dan Bernstein.

  • platform/mac/ThemeMac.mm: (WebCore::updateStates): Flip an incorrect conditional, this code should run on Snow Leopard and Lion.
11:56 Changeset [103953] by alexis.menard@openbossa.org
  • 10 edits in trunk

Source/WebCore: getComputedStyle should return shorthands property with the minimum number of sides possible.
https://bugs.webkit.org/show_bug.cgi?id=75434

Reviewed by Tony Chang.

As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
return shorthands properties with the minimum number of sides possible.

Existing tests have been updated accordingly.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):

  • css/CSSComputedStyleDeclaration.h:

LayoutTests: getComputedStyle should return shorthands properties with the minimum number of sides possible.
https://bugs.webkit.org/show_bug.cgi?id=75434

Reviewed by Tony Chang.

As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
return shorthands properties with the minimum number of sides possible.

  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html:
  • fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-width.html:
11:53 Changeset [103952] by aroben@apple.com
  • 17 edits in trunk/Tools

Make Port subclasses override the operating_system method rather than setting an attribute

Without this patch, any use of Port.operating_system() within a port's init method would
return the default value ("mac"). This was confusing the version-checking logic inside
ApplePort.init on Windows.

Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
crashes on launch on Windows 7 SP1

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init): Replaced uses of self._operating_system with self.operating_system().

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init): Removed code that set the self._operating_system attribute. Subclasses
should now override the operating_system method instead.
(Port.operating_system): Changed to always return "mac". Subclasses should override to
return something else.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.init):
(ChromiumLinuxPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):
(ChromiumMacPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):
(ChromiumWinPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.init):
(MacPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.init):
(WinPort.operating_system):
Changed to override the operating_system method rather than setting the _operating_system
attribute, since setting the attribute isn't sufficient for code inside init methods.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.init):
(QtPort._path_to_webcore_library):
Changed to use self.operating_system() instead of self._operating_system, for consistency
with other Port-related code.

(QtPort.operating_system): Added this override of Port.operating_system that returns the
value we determined in our init method.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.operating_system): Added this override of Port.operating_system that returns the
value we determined in our init method.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_operating_system):
Test that all ports return the expected operating system string.

11:51 Changeset [103951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] GTK+ 3 theming code does not use the GtkOrientable style class
https://bugs.webkit.org/show_bug.cgi?id=72789

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-03
Reviewed by Philippe Normand.

No new tests. Testing GTK+ theming is quite difficult
because no two distributions have the same set of themes.
Current tests prevent regressions.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::applySliderStyleContextClasses): Added this helper that
properly handles the orientable style class.
(WebCore::RenderThemeGtk::paintSliderTrack): Use the new helper.
(WebCore::RenderThemeGtk::paintSliderThumb): Ditto.

  • platform/gtk/ScrollbarThemeGtk3.cpp:

(WebCore::applyScrollbarStyleContextClasses): Added this helper that
properly handles the orientable style class.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Use the new helper.
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
(WebCore::ScrollbarThemeGtk::paintButton): Ditto.

11:33 Changeset [103950] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform
https://bugs.webkit.org/show_bug.cgi?id=75227

Patch by Florin Malita <fmalita@google.com> on 2012-01-03
Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/custom/webkit-transform-crash.html

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
Add a null-renderer check.

LayoutTests:

  • svg/custom/webkit-transform-crash-expected.txt: Added.
  • svg/custom/webkit-transform-crash.html: Added.
11:29 Changeset [103949] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixed a typo in the change log

11:13 Changeset [103948] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle for border is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75319

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border.

fast/css/getComputedStyle/getComputedStyle-border-shorthand.html was extented.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:
11:03 Changeset [103947] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Sort the WebCore XCode project file

Reviewed by Dimitri Glazkov.

  • WebCore.xcodeproj/project.pbxproj:
10:59 Changeset [103946] by enne@google.com
  • 5 edits in trunk/Source/WebCore

[chromium] Set tiler bounds explicitly rather than growing them
https://bugs.webkit.org/show_bug.cgi?id=75331

Reviewed by James Robinson.

Rather than only growing bounds, make the bounds on the tiler be set
explicitly by TiledLayerChromium. This patch now properly invalidates
regions when the bounds change.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateBounds):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):
(WebCore::CCLayerTilingData::bounds):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
10:55 Changeset [103945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Slider thumb is not centered on the track with the unico theme
https://bugs.webkit.org/show_bug.cgi?id=72802

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-03
Reviewed by Philippe Normand.

No new tests. This only applies to certain GTK+ themes.
Existing tests cover the default GTK+ theme.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::paintSliderThumb): Do not resize the
slider thumb by the trough border.

10:48 Changeset [103944] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Make tiled layer's tiler always exist
https://bugs.webkit.org/show_bug.cgi?id=75329

Reviewed by James Robinson.

Source/WebCore:

TiledLayerChromium has some awkward code to handle lazily creating the
tiler, including lots of null checks and shadowing the tile size.
Instead, always create the tiler up front. As values change that
invalidate all tiles, reset it rather than clear the pointer.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setIsNonCompositedContent):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setBorderTexelOption):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::setTilingOption):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setIsNonCompositedContent):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBorderTexelOption):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::setHasBorderTexels):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium:

Update test due to changing API. Add a test for changing border
texel option on TilingData.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

09:00 Changeset [103943] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
https://bugs.webkit.org/show_bug.cgi?id=75474

Reviewed by Philippe Normand.

  • Scripts/run-gtk-tests: Ignore files whose name does not start

with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).

08:52 Changeset [103942] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Tools

[Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75472

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-03
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
08:25 Changeset [103941] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/Source/ThirdParty

Add Production configuration to gtest Xcode project
<http://webkit.org/b/75153>

Reviewed by Adam Roben.

  • gtest/README.WebKit: Updated.
  • gtest/xcode/Config/ProductionProject.xcconfig: Added.
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
  • Added Production configuration based on Release configuration.
  • Made Production the default configuration.
08:20 Changeset [103940] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/Tools

[Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75471

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-03
Reviewed by Tor Arne Vestbø.

Add simple UI for JavaScript Alert dialogs. This patch also adds a
simple DialogButton QML type and a Dialog QML type which will be
reusable for other JavaScript dialogs.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/AlertDialog.qml: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/Dialog.qml: Added.
  • MiniBrowser/qt/qml/DialogButton.qml: Added.
08:06 Changeset [103939] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] MiniBrowser doesn't show url bar
https://bugs.webkit.org/show_bug.cgi?id=75470

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-03
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed

on QtDeclarative (QTBUG-23422).

08:04 Changeset [103938] by carlosgc@webkit.org
  • 19 edits
    1 delete in trunk

[GTK] Simplify loader client WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=74605

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Remove WebKitWebLoaderClient from public API keeping it as a
private object. Loading API has been reduced to two signals in
WebKitWebView.

  • GNUmakefile.am: Remove WebKitWebLoaderClientPrivate.h.
  • UIProcess/API/gtk/WebKitDefines.h: Remove forward delcarations

that are no longer needed.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didStartProvisionalLoadForFrame): Emit
WebKitWebView::load-changed signal with Started event.
(didReceiveServerRedirectForProvisionalLoadForFrame): Emit
WebKitWebView::load-changed signal with Redirected event.
(didFailProvisionalLoadWithErrorForFrame): Emit
WebKitWebView::load-failed signal with Started event.
(didCommitLoadForFrame): Emit WebKitWebView::load-changed signal
with Committed event.
(didFinishLoadForFrame): Emit WebKitWebView::load-changed signal
with Finished event.
(didFailLoadWithErrorForFrame): Emit WebKitWebView::load-failed
signal with Committed event.
(webkit_web_loader_client_init):
(webkit_web_loader_client_class_init):

  • UIProcess/API/gtk/WebKitWebLoaderClient.h: Remove public API and

move private API here.

  • UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h: Removed.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadFail): Default implementation of
WebKitWebView::load-failed signal to show a custom error page.
(webkit_web_view_class_init): Add load-changed and load-failed
signals.
(webkitWebViewLoadChanged): Emit WebKitWebView::load-changed with
the given event.
(webkitWebViewLoadFailed): Emit WebKitWebView::load-failed signal
with the given event, failing uri and error.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Remove loader

client section.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Remove loader

client symbols.

  • UIProcess/API/gtk/docs/webkit2gtk.types: Remove

webkit_web_loader_client_get_type.

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(loadChangedCallback):
(loadFailedCallback):
(LoadTrackingTest::LoadTrackingTest):
(LoadTrackingTest::~LoadTrackingTest):
(LoadTrackingTest::provisionalLoadStarted):
(LoadTrackingTest::provisionalLoadReceivedServerRedirect):
(LoadTrackingTest::provisionalLoadFailed):
(LoadTrackingTest::loadCommitted):
(LoadTrackingTest::loadFinished):
(LoadTrackingTest::loadFailed):

  • UIProcess/API/gtk/tests/LoadTrackingTest.h:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadingError):
(LoadStopTrackingTest::loadCommitted):
(LoadStopTrackingTest::loadFailed):
(testLoadCancelled):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(beforeAll):

  • UIProcess/API/gtk/webkit2.h: Remove loader client header.
  • UIProcess/API/gtk/webkit2marshal.list:

Tools:

  • gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now

private API.

07:46 Changeset [103937] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::destroy):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::destroy):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::destroy):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::destroy):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::destroy):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::destroy):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):

06:15 Changeset [103936] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix scrollbars size with GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=75467

Reviewed by Xan Lopez.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStyleContext): Add the style class for the given
widget type to the GtkWidgetPath when creating GtkStyleContext
objects.

04:45 Changeset [103935] by vestbo@webkit.org
  • 7 edits in trunk

[Qt] Clean up detection of fontconfig

We decide in features.prf whether or not fontconfig is available, and
set the HAVE_FONTCONFIG define accordingly. All leaf project files
should use this define to decide whether or not to link against
fontconfig, not do their own detection.

We don't need to add link_pkgconfig to CONFIG in each project file,
as we selectivly enable that configuration in defaults_post when
needed.

Reviewed by Ossy.

04:41 WebKit Team edited by hclam@chromium.org
(diff)
04:39 Changeset [103934] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for outline is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75441

Reviewed by Antonio Gomes.

Source/WebCore:

Implement getComputedStyle for outline.

Test: fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html: Added.
04:37 Changeset [103933] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=75468
Suppress layout test failure due to a new test.

Unreviewed, build fix.

  • platform/chromium/test_expectations.txt:
03:41 Changeset [103932] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Introduce qmake replace function for the active build config

Reviewed by Ossy.

02:03 Changeset [103931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] tst_favIconLoad.qml crashes on debug mode
https://bugs.webkit.org/show_bug.cgi?id=75448

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-03
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Loads

"about:blank" instead of an empty url between tests to clean favicon.

02:02 Changeset [103930] by jchaffraix@webkit.org
  • 1 edit
    12 copies in branches/chromium/912

Merge 100661 - CSS table with 100% width can overflow their containing block
https://bugs.webkit.org/show_bug.cgi?id=72180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html

fast/table/table-in-table-percent-width-collapsing-border.html
fast/table/table-in-table-percent-width-quirks-mode.html
fast/table/table-in-table-percent-width.html

After r97555, we would include the borders in a CSS table's logical width even if the 'width'
property was a percent. This does not match what Firefox and IE are doing. Thus don't apply
this behavior to percent 'width'.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

Several tests to check that we don't overflow our containing block with width: 100%.

  • fast/table/table-in-table-percent-width-collapsing-border-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width-collapsing-border.html: Added.
  • fast/table/table-in-table-percent-width-expected.png: Added.
  • fast/table/table-in-table-percent-width-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width.html: Added.

TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/9014010

01:17 Changeset [103929] by carlosgc@webkit.org
  • 9 edits in trunk

[GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
https://bugs.webkit.org/show_bug.cgi?id=75435

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/gtk/GtkVersioning.c:

(getScreenCurrentDesktop):
(getScreenWorkArea):
(gdk_screen_get_monitor_workarea): Implement it when GTK+ < 3.3.6.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenAvailableRect): Use
gdk_screen_get_monitor_workarea() instead of our own
implementation.

Source/WebKit/gtk:

  • GNUmakefile.am: Make sure unit tests link to X11.

Tools:

  • GNUmakefile.am: Make sure DRT links to X11.
  • WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
00:10 Changeset [103928] by philn@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] WebSettings support in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=73773

Reviewed by Martin Robinson.

Patch heavily inspired from the WebKit GtkLauncher to support
command-line WebSettings. Example: --enable-fullscreen=TRUE.
The full list of options can be consulted with --help-websettings.

  • MiniBrowser/gtk/main.c:

(loadURI):
(parseOptionEntryCallback):
(isValidParameterType):
(getOptionEntriesFromWebKitSettings):
(addSettingsGroupToContext):
(main):

00:04 Changeset [103927] by philn@webkit.org
  • 2 edits in trunk/Tools

[GTK] GtkLauncher settings improvements
https://bugs.webkit.org/show_bug.cgi?id=75439

Reviewed by Martin Robinson.

  • GtkLauncher/main.c:

(filenameToURL): We can use NULL in C.
(isValidParameterType): Utility function to filter GParamTypes
that can be edited.
(getOptionEntriesFromWebKitWebSettings): Avoid handling
construct-only properties and use the isValidParameterType
function. Makes the code a bit cleaner.

01/02/12:

23:00 Changeset [103926] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Check in fixes for jsc tests following bug #75455.

  • tests/mozilla/ecma/GlobalObject/15.1.2.2-1.js:
  • tests/mozilla/ecma/GlobalObject/15.1.2.2-2.js:
22:56 Changeset [103925] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a typo I made in r103871.

Fixes <http://webkit.org/b/75450> Inline PDF doesn't preview correctly when attempting to print its frame

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToPDF): Changed USE(GC) to USE(CG).

22:56 Changeset [103924] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=75452
If argument to Error is undefined, message is not set

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Per section 15.11.1.1 of the spec.

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):
(JSC::ErrorInstance::finishCreation):

LayoutTests:

Added test case.

  • fast/js/native-error-prototype-expected.txt:
  • fast/js/script-tests/native-error-prototype.js:
21:45 Changeset [103923] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r103919): Remove resolve-supplemental.pl from the WebCore target in Xcode
https://bugs.webkit.org/show_bug.cgi?id=75458

Reviewed by Adam Barth.

At r103919, we added resolve-supplemental.pl to WebCore.framework/Resources,
but we should have added it to the project without adding it to any target.
This patch fixes it.

No tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
20:32 Changeset [103922] by barraclough@apple.com
  • 7 edits in trunk

ES5 prohibits parseInt from supporting octal
https://bugs.webkit.org/show_bug.cgi?id=75455

Reviewed by Sam Weinig.

See sections 15.1.2.2 and annex E.

Source/JavaScriptCore:

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):

LayoutTests:

  • fast/js/kde/GlobalObject-expected.txt:
  • fast/js/kde/script-tests/GlobalObject.js:
    • Change test to check for correct result.
  • sputnik/Implementation_Diagnostics/S15.1.2.2_D1.1-expected.txt:
  • sputnik/Implementation_Diagnostics/S15.1.2.2_D1.2-expected.txt:
    • One test asserts parseInt handles octal, one asserts it does not! This patch switches which one passes & which fails.
18:36 Changeset [103921] by barraclough@apple.com
  • 4 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=55343
Global JSON should be configurable but isn't

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • make JSON configurable

LayoutTests:

  • ietestcenter/Javascript/11.4.1-4.a-8-expected.txt:
    • check in passing result
17:24 Changeset [103920] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on GTK/GObject
https://bugs.webkit.org/show_bug.cgi?id=75411

Reviewed by Adam Barth.

This patch enables the [Supplemental] IDL on GObject bindings of GTK
by changing the build flow of bindings/gobject/GNUmakefile.am as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:
16:57 Changeset [103919] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Add resolve-supplemental.pl to project.pbxproj
https://bugs.webkit.org/show_bug.cgi?id=75426

Reviewed by Adam Barth.

We should have added "resolve-supplemental.pl" to build scripts of AppleWebKit
when we enabled the [Supplemental] IDL on AppleWebKit at r103519.
This is a follow-up patch for it.

No tests. Just confirm that the AppleWebKit build passes.

  • WebCore.xcodeproj/project.pbxproj:
16:44 Changeset [103918] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Add resolve-supplemental.pl to build scripts of AppleWin
https://bugs.webkit.org/show_bug.cgi?id=75412

Reviewed by Adam Barth.

We should have added "resolve-supplemental.pl" to build scripts of AppleWin
when we enabled the [Supplemental] IDL on AppleWin at r103519.
This is a follow-up patch for it.

No tests. Just confirm that the AppleWin build passes.

  • WebCore.vcproj/MigrateScripts:
  • WebCore.vcproj/WebCore.vcproj:
16:39 Changeset [103917] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Windows build (again).

  • Platform/CoreIPC/Connection.h:
15:59 Changeset [103916] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix windows build.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp:
  • Platform/RunLoop.h:

Missing declarations/includes of BinarySemaphore.

15:55 Changeset [103915] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • bindings/scripts/CodeGeneratorJS.pm:
15:41 Changeset [103914] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after r103888.

  • WebCore.vcproj/WebCore.vcproj: Remove CollectionCache.{cpp, h} from

the WebCore vcproj.

15:31 Changeset [103913] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r100517): We're leaking many, many DOM objects!
https://bugs.webkit.org/show_bug.cgi?id=75451

Reviewed by Mark Rowe.

  • bindings/scripts/CodeGeneratorJS.pm:

Add a temporary workaround to the problem of handle finalizers
not getting called by adding back the destructors (or rather
their replacement, destroy() functions).

15:08 Changeset [103912] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

Move dispatchSentMessagesUntil out of the RunLoop class.
https://bugs.webkit.org/show_bug.cgi?id=75320

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::waitWhileDispatchingSentWin32Messages):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::dispatchSentMessagesUntil):

  • Platform/win/RunLoopWin.cpp:
13:09 Changeset [103911] by gyuyoung.kim@samsung.com
  • 6 edits in trunk

[EFL] Remove whitespace/declaration style exception
https://bugs.webkit.org/show_bug.cgi?id=75424

Reviewed by David Levin.

Source/WebKit/efl:

EFL port doesn't need to avoid *whitespace/declaration* exception because of coding
style change. However, EWebLauncher and MiniBrowser need to use EFL coding style because
they are EFL application.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_invalidate):

  • ewk/ewk_view.cpp:

Tools:

Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
application. So, they still need to use EFL coding style.

  • Scripts/webkitpy/style/checker.py:
11:18 Changeset [103910] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit/mac

[mac] Remove -[WebView setHoverFeedbackSuspended:]
https://bugs.webkit.org/show_bug.cgi?id=75406

Reviewed by Tim Hatcher.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates.

  • WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged.
  • WebView/WebView.mm:

(-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of
Safari that call this.
(-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support
versions of Safari that call this.

  • WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar.
  • WebView/WebViewPrivate.h: Removed method definitions.
11:06 BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
Add extra file to remove linux-g++-maemo from. Enables Maliit keyboard. (diff)
10:04 Changeset [103909] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • Platform/mac/SharedMemoryMac.cpp:
08:26 Changeset [103908] by zimmermann@webkit.org
  • 3 edits in trunk/Source/WebKit2

2012-01-02 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix build on Lion, by including mach_error.h in two places that need it.

  • PluginProcess/mac/PluginProcessMainMac.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
07:39 Changeset [103907] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix chromium mac build after r103905
https://bugs.webkit.org/show_bug.cgi?id=75436

Reviewed by Csaba Osztrogonác.

Adding parenthesis to disambiguate because clang gives error
"expression is not assignable".

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

06:56 Changeset [103906] by carlosgc@webkit.org
  • 5 edits
    5 adds in trunk

[GTK] Add a way to change web view settings in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71568

Reviewed by Philippe Normand.

.:

  • GNUmakefile.am: Initialize minibrowser_built_sources.

Tools:

Add a preferences button to the toolbar that shows a dialog to
change settings of the current web view. It uses a GtkTreeView
with a custom cell renderer to support multiple types of values.

  • MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.

(browserCellRendererVariantFinalize):
(browserCellRendererVariantGetProperty):
(browserCellRendererVariantSetModeForValue):
(browserCellRendererVariantSetProperty):
(browserCellRendererVariantGetRendererForValue):
(browserCellRendererVariantCellRendererTextEdited):
(browserCellRendererVariantCellRendererSpinEdited):
(browserCellRendererVariantCellRendererActivate):
(browserCellRendererVariantCellRendererRender):
(browserCellRendererVariantCellRendererStartEditing):
(browserCellRendererVariantCellRendererGetPreferredWidth):
(browserCellRendererVariantCellRendererGetPreferredHeight):
(browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
(browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
(browserCellRendererVariantCellRendererGetAlignedArea):
(browser_cell_renderer_variant_init):
(browser_cell_renderer_variant_class_init):
(browser_cell_renderer_variant_new):

  • MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
  • MiniBrowser/gtk/BrowserSettingsDialog.c: Added.

(cellRendererChanged):
(browserSettingsDialogSetProperty):
(browser_settings_dialog_init):
(browserSettingsDialogConstructed):
(browser_settings_dialog_class_init):
(browser_settings_dialog_new):

  • MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
  • MiniBrowser/gtk/BrowserWindow.c:

(settingsCallback):
(browser_window_init):

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/browser-marshal.list: Added.
06:07 Changeset [103905] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in RenderSVGResourceGradient
https://bugs.webkit.org/show_bug.cgi?id=75364

Reviewed by Daniel Bates.

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::removeAllClientsFromCache):
(WebCore::RenderSVGResourceGradient::removeClientFromCache):
(WebCore::RenderSVGResourceGradient::applyResource): avoid looking
up the hash twice by using HashMap::add().

  • rendering/svg/RenderSVGResourceGradient.h: rename m_gradient to m_gradientMap.
05:39 Changeset [103904] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Implement create/ready-to-show/close signals in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74711

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewClose): Destroy the window.
(webViewReadyToShow): Use WindowProperties of the new view to
setup and show the window.
(webViewCreate): Create a new view and add it to a browser window.
(browser_window_init):
(browserWindowConstructed): Connect to WebKitWebView::create signal.

05:23 Changeset [103903] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix qmake warning about unescaped backslashes

Reviewed by Ossy.

04:30 Changeset [103902] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt-WK2 gardening.

Unskip table tests for wk2 after platform results
have been added in r103898.

  • platform/qt-wk2/Skipped:
03:22 Changeset [103901] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] fast/dom/constructed-objects-prototypes.html fails
https://bugs.webkit.org/show_bug.cgi?id=75432

Unreviewed, mark fast/dom/constructed-objects-prototypes.html as
failing in GTK test_expectations.

  • platform/gtk/test_expectations.txt:
03:09 Changeset [103900] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck issue.

  • GNUmakefile.am: Add resolve-supplemental.pl script to

EXTRA_DIST.

02:49 Changeset [103899] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

fast/dom/htmlcollection-zombies.html fails on GTK and on Qt
https://bugs.webkit.org/show_bug.cgi?id=75431

Unreviewed gardening. Skip fast/dom/htmlcollection-zombies.html until fix.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
02:07 Changeset [103898] by ossy@webkit.org
  • 188 edits
    13 adds in trunk/LayoutTests

Rebaseline table tests to reflect new width of table captions after r103875
https://bugs.webkit.org/show_bug.cgi?id=74888

Unreviewed gardening.

  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/qt/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/qt/fast/css/caption-width-absolute-position-expected.txt: Added.
  • platform/qt/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/qt/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
  • platform/qt/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/qt/fast/css/caption-width-fixed-position-expected.txt: Added.
  • platform/qt/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/qt/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
  • platform/qt/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/qt/fast/css/caption-width-relative-position-expected.txt: Added.
  • platform/qt/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/qt/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
  • platform/qt/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/qt/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/qt/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/qt/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/qt/fast/repaint/table-section-repaint-expected.png: Added.
  • platform/qt/fast/repaint/table-section-repaint-expected.txt:
  • platform/qt/fast/table/frame-and-rules-expected.png:
  • platform/qt/fast/table/frame-and-rules-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.png:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.png:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29157-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/qt/tables/mozilla/core/captions-expected.png:
  • platform/qt/tables/mozilla/core/captions-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/qt/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/qt/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/test_expectations.txt:
02:01 Changeset [103897] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip two canvas tests failing in GTK after r103849.

  • platform/gtk/Skipped: Skip canvas/philip/tests/2d.pattern.image.string.html

and canvas/philip/tests/2d.pattern.image.undefined.html that need
to be updated.

01:59 Changeset [103896] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=75430

  • platform/chromium/test_expectations.txt:
01:52 Changeset [103895] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=75376

Unreviewed gardening after r103849 to paint the bot green.

  • platform/qt/Skipped: Skip canvas/philip/tests/2d.pattern.image.string.html

and canvas/philip/tests/2d.pattern.image.undefined.html until proper fix.

01:07 Changeset [103894] by philn@webkit.org
  • 102 edits
    6 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r103251 and r103875.

  • platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-relative-position-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/gtk/fast/repaint/table-section-repaint-expected.txt:
  • platform/gtk/fast/table/frame-and-rules-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/gtk/tables/mozilla/core/captions-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
00:42 Changeset [103893] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Clear HTMLCollection's internal cache on construction.
<http://webkit.org/b/75423>

Reviewed by Antti Koivisto.

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):

00:40 Changeset [103892] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping tests needing a GTK rebaseline.

  • platform/gtk/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.