Timeline


and

01/09/12:

23:04 EFLWebKit edited by sh4.seo@samsung.com
(diff)
21:42 Changeset [104538] by commit-queue@webkit.org
  • 8 edits
    4 deletes in trunk/Source

Unreviewed, rolling out r104507.
http://trac.webkit.org/changeset/104507
https://bugs.webkit.org/show_bug.cgi?id=75936

Broke webkit_unit_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Removed.
21:39 Changeset [104537] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Touch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.

  • public/WebView.h:
20:44 Changeset [104536] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.

  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png:
20:12 Changeset [104535] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update for test_expectations.txt.

  • platform/chromium/test_expectations.txt:
20:10 Changeset [104534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 116459 to 116979.

  • DEPS:
19:00 Changeset [104533] by dimich@chromium.org
  • 216 edits
    3 copies
    11 moves
    3 adds
    9 deletes in trunk/LayoutTests

[Chromium] Rebaseline a lot of tests with input controls after r104494
https://bugs.webkit.org/show_bug.cgi?id=75924

Unreviewed.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png: Renamed from LayoutTests/platform/chromium/fast/block/float/032-expected.png.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/basic-inputs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-disabled-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-height-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/validation-message-appearance-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Renamed from LayoutTests/platform/chromium/fast/table/colspanMinWidth-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium/fast/forms/minWidthPercent-expected.png: Removed.
  • platform/chromium/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
  • platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Removed.
18:40 Changeset [104532] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-09 Rob Buis <rbuis@rim.com>

Upstream change to disable input[color] css rules for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=75719

Reviewed by Antonio Gomes.

Do not enable default css color rules for inputcolor? for BlackBerry port.

  • CMakeLists.txt:
18:29 Changeset [104531] by commit-queue@webkit.org
  • 7 edits
    7 adds in trunk

Source/WebCore: Implement navigator.startActivity; add IntentRequest object for managing web intents callbacks.
Web content will invoke navigator.startActivity to launch a new Web
Intents call. Each such call will map to an IntentRequest broker
object which is used by client code to correlate any return data to
the (optional) callbacks supplied by web content calls.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

Test: webintents/web-intents-api.html

  • Modules/intents/Intent.cpp: Added.

(WebCore::Intent::identifier):
(WebCore::Intent::setIdentifier):

  • Modules/intents/Intent.h: Added.
  • Modules/intents/Intent.idl: Added.
  • Modules/intents/IntentResultCallback.h: Added.

(WebCore::IntentResultCallback::~IntentResultCallback):

  • Modules/intents/IntentResultCallback.idl: Added.
  • Modules/intents/IntentsRequest.cpp: Added.
  • Modules/intents/IntentsRequest.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeTypeForCallbacks):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::dispatchIntent):

LayoutTests: Implement navigator.startActivity; add IntentsController for managing web intents callbacks.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

  • webintents/web-intents-api-expected.txt: Added.
  • webintents/web-intents-api.html: Added.
18:14 Changeset [104530] by mitz@apple.com
  • 4 edits in trunk

-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
https://bugs.webkit.org/show_bug.cgi?id=75920

Reviewed by Darin Adler.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm

  • page/mac/FrameMac.mm:

(WebCore::Frame::rangeImage): Removed the requirement that the start and end positions used
for setting the selection in the render tree be candidates.

Tools:

  • TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:

(TestWebKitAPI::TEST): Added a test for a range in a
-webkit-user-select: none; block.

18:12 Changeset [104529] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source

Get chromium/linux building again.

18:11 Changeset [104528] by morrita@google.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: Followed the renaming.

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: Followed te renaming.

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp: Followed te renaming.

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()

  • dom/TreeScopeAdopter.cpp: Added.

(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • dom/TreeScopeAdopter.h: Added.

(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

18:03 Changeset [104527] by barraclough@apple.com
  • 5 edits in trunk

Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

  • need to increment the string position.

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
    • added test cases.
17:56 Changeset [104526] by abarth@webkit.org
  • 18 edits
    9 copies
    30 adds in trunk/Source/WebCore

run-bindings-tests should exercise all the IDL attributes we use
https://bugs.webkit.org/show_bug.cgi?id=75900

Reviewed by Eric Seidel.

I just grepped through the code generator script for IDL attributes and
wrote tests for them.

  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetterPrivate.h: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.h: Added.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Added.
  • bindings/scripts/test/JS/JSTestEventTarget.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/JS/JSTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.h: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetterInternal.h: Added.
  • bindings/scripts/test/TestDomainSecurity.idl: Added.
  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/TestEventTarget.idl: Added.
  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestOverridingNameGetter.idl: Added.
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/V8/V8TestActiveDOMObject.h: Added.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp: Added.
  • bindings/scripts/test/V8/V8TestEventTarget.h: Added.
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/scripts/test/V8/V8TestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/V8/V8TestOverridingNameGetter.h: Added.
17:54 Changeset [104525] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

background position parsing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75823

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/background-position-parsing-expected-mismatch.html: Added.
  • css3/calc/background-position-parsing.html: Added.
  • css3/calc/resources/diamond.png: Added.
  • css3/calc/resources/ring.png: Added.
17:32 Changeset [104524] by dpranke@chromium.org
  • 6 edits in trunk/Tools

webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
https://bugs.webkit.org/show_bug.cgi?id=75884

Reviewed by Ryosuke Niwa.

Fix regression introduced (revealed?) in r104340. Chromium file
url syntax is different on win32 and the test results weren't
expecting that.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations._report_errors):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(TestRebaseliner.make_rebaseliner):
(TestRebaseliner.test_one_platform):
(TestRebaseliner.test_all_platforms):
(TestRebaseliner.test_png_file_with_comment):
(TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
(TestRebaseliner.test_png_file_with_comment_as_duplicate):
(TestRealMain.test_all_platforms):

17:24 Changeset [104523] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

http/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
https://bugs.webkit.org/show_bug.cgi?id=75186

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
17:21 Changeset [104522] by nduca@chromium.org
  • 6 edits in trunk/Source/WebCore

[chromium] Add documentation to updater classes
https://bugs.webkit.org/show_bug.cgi?id=75866

Reviewed by James Robinson.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
17:14 Changeset [104521] by jonlee@apple.com
  • 5 edits
    1 copy
    3 adds in trunk/LayoutTests

New pixel test results with r104351.

Unreviewed.

Moved from mac to mac-snowleopard:

  • platform/mac-snowleopard/fast/block/margin-collapse/103

New pixel test results:

  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
17:12 Changeset [104520] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

img size test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75893

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/img-size-expected-mismatch.html: Added.
  • css3/calc/img-size.html: Added.
  • css3/calc/resources/colorsquare.png: Added.
17:08 Changeset [104519] by mrowe@apple.com
  • 2 edits in tags/Safari-535.15.1/Source/JavaScriptCore

Merge r104510.

17:07 Changeset [104518] by mrowe@apple.com
  • 5 edits in tags/Safari-535.15.1/Source

Versioning.

17:07 Changeset [104517] by lforschler@apple.com
  • 2 edits
    3 copies in branches/safari-534.54-branch

Merged r102509.

17:05 Changeset [104516] by mrowe@apple.com
  • 1 copy in tags/Safari-535.15.1

New tag.

17:02 Changeset [104515] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r102377.

17:00 Changeset [104514] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r102263.

16:55 Changeset [104513] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r102016.

16:50 Changeset [104512] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r101584.

16:42 Changeset [104511] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused variable from CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=75895

Reviewed by Eric Seidel.

Unused variables aren't worth keeping around.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

16:41 Changeset [104510] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore framework target <http://webkit.org/b/75907> / <rdar://problem/10659862>

We'd like for it to be possible to build jsc without building JavaScriptCore.framework and the explicit
dependencies prevent this.

Reviewed by Dan Bernstein.

16:39 Changeset [104509] by jonlee@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Temporary fix for pixel result diffs from focus ring (darker color on WK2).
These results should be removed once the cause is found-- filed as bug:
https://bugs.webkit.org/show_bug.cgi?id=75909

Unreviewed.

  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt: Added.
16:33 Changeset [104508] by jonlee@apple.com
  • 72 edits
    21 copies
    21 adds in trunk/LayoutTests

Some gardening with fix for r104351.

Moving pixel test results from mac to mac-snowleopard (because of theme changes):

  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label01
  • platform/mac-snowleopard/fast/forms/button-cannot-be-nested
  • platform/mac-snowleopard/fast/forms/button-inner-block-reuse
  • platform/mac-snowleopard/fast/forms/control-clip-overflow
  • platform/mac-snowleopard/fast/forms/file/input-file-re-render
  • platform/mac-snowleopard/fast/forms/formmove
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur
  • platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed
  • platform/mac-snowleopard/fast/forms/listbox-scrollbar-incremental-load
  • platform/mac-snowleopard/fast/forms/menulist-width-change
  • platform/mac-snowleopard/fast/forms/option-text-clip
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2
  • platform/mac-snowleopard/fast/forms/range/slider-thumb-shared-style
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment
  • platform/mac-snowleopard/fast/forms/select-change-listbox-to-popup
  • platform/mac-snowleopard/fast/forms/select-item-background-clip
  • platform/mac-snowleopard/fast/forms/select-selected
  • platform/mac-snowleopard/fast/forms/select-size
  • platform/mac-snowleopard/fast/forms/select-visual-hebrew
  • platform/mac-snowleopard/fast/forms/textarea-scrollbar
  • platform/mac-snowleopard/fast/forms/textarea-scrolled

New pixel test results:

  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/006-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/mac/fast/forms/button-default-title-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-inner-block-reuse-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/control-clip-overflow-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/formmove-expected.png:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/mac/fast/forms/menulist-width-change-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/option-text-clip-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/forms/range/input-appearance-range-expected.png:
  • platform/mac/fast/forms/range/slider-padding-expected.png:
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-change-listbox-size-expected.png:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-item-background-clip-expected.png:
  • platform/mac/fast/forms/select-selected-expected.png:
  • platform/mac/fast/forms/select-size-expected.png:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
16:31 Changeset [104507] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk/Source

[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-09
Reviewed by James Robinson.

Source/WebCore:

New unit tests: CCLayerIteratorTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h: Added.

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Added.
16:13 Changeset [104506] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Throw exception if IDBCursor.continue() called with lower key than current
https://bugs.webkit.org/show_bug.cgi?id=74213

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

Source/WebCore:

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):

LayoutTests:

  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
16:12 Changeset [104505] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
https://bugs.webkit.org/show_bug.cgi?id=75783

Updated unit test to reflect desired behaviour now that tile/quad culling
is implemented.

Reviewed by James Robinson.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

16:03 Changeset [104504] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Tests for nested flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70776

Reviewed by Tony Chang.

  • css3/flexbox/orthogonal-flex-directions-expected.txt: Added.
  • css3/flexbox/orthogonal-flex-directions.html: Added.
16:01 Changeset [104503] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Windows Build Fix

15:56 Changeset [104502] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Fix potential issue in WebMediaPlayerClientImpl
https://bugs.webkit.org/show_bug.cgi?id=75899

Reviewed by Kenneth Russell.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):

15:53 Changeset [104501] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

15:43 Changeset [104500] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r101091.

15:32 Changeset [104499] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge 100809.

15:23 Changeset [104498] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r100677.

15:16 Changeset [104497] by lforschler@apple.com
  • 9 edits
    5 copies in branches/safari-534.54-branch

Merged r100630.

15:14 Changeset [104496] by leviw@chromium.org
  • 37 edits in branches/subpixellayout/LayoutTests/platform

Updated svg expectations

15:14 Changeset [104495] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.

Unreviewed, build fix.

test-webkitpy had a built-in self-test routine to verify that
deleting the .pyc files worked correctly. When I removed the
python24 directory in r104482, I broke the self-test.

I have deleted the self-test for now. Since I am reworking
test-webkitpy I will make sure the new version is adequately
tested.

  • Scripts/test-webkitpy:

(configure_logging):
(_clean_pyc_files):
(_clean_packages):
(init):

15:13 Changeset [104494] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Dimitri Glazkov.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintTextField):

15:05 Changeset [104493] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGText.cpp

Fix rounding problem in RenderSVGText::nodeAtFloatPoint

14:43 Changeset [104492] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=75692
Roll out possibly bad new test case.

Rubber stamped by Sam Weinig.

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
14:06 Changeset [104491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Log is a little to verbose for blackberry port
https://bugs.webkit.org/show_bug.cgi?id=75728

The BlackBerry::Platform::Log* functions take care of the call to vfprintf
which is resulting in unintentional noise in our logs. Add a conditional
directive to fix.

Change to using BlackBerry::Platform::logStreamV which does not insert
threading info and newlines unlike BlackBerry::Platform::log.

Finally, add log locking and unlocking which the BlackBerry platform
uses to ensure that N threads do not trample on each other's logs.

Patch by Adam Treat <atreat@rim.com> on 2012-01-09
Reviewed by Rob Buis.

  • wtf/Assertions.cpp:

(WTFLogLocker::WTFReportAssertionFailure):
(WTFLogLocker::WTFReportAssertionFailureWithMessage):
(WTFLogLocker::WTFReportArgumentAssertionFailure):
(WTFLogLocker::WTFReportFatalError):
(WTFLogLocker::WTFReportError):
(WTFLogLocker::WTFLog):
(WTFLogLocker::WTFLogVerbose):

14:02 Changeset [104490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compilation error on build-webkit --debug --no-3d-canvas on mac.
https://bugs.webkit.org/show_bug.cgi?id=75878

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-09
Reviewed by Alexey Proskuryakov.

  • html/canvas/WebGLContextEvent.cpp:
14:00 Changeset [104489] by dimich@chromium.org
  • 1 edit
    1 move
    1 add
    4 deletes in trunk/LayoutTests

[Chromium] Rebaseline media/media-document-audio-repaint.html for gpu tests.
https://bugs.webkit.org/show_bug.cgi?id=75888

Unreviewed.

  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/media-document-audio-repaint-expected.txt.
13:56 Changeset [104488] by barraclough@apple.com
  • 14 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75789
defineOwnProperty not implemented for Array objects

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Implements support for getter/setter & non-default attribute properties on arrays,
by forcing them into a dictionary-like 'SparseMode'. This fixes ~300 test-262
test failures.

  • JavaScriptCore.exp:
    • Updated exports.
  • dfg/DFGOperations.cpp:
    • JSArray::pop now requires an exec state.
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):

  • JSArray::pop now requires an exec state.
  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::add):

  • Add a potentially empty entry into the map.

(JSC::SparseArrayValueMap::put):

  • Changed to call setter.

(JSC::SparseArrayEntry::get):

  • calls getters.

(JSC::SparseArrayEntry::getNonSparseMode):

  • does not call getters.

(JSC::JSArray::enterSparseMode):

  • Convert into 'SparseMode' - removes the vectors, don't allow it to be recreated.

(JSC::JSArray::putDescriptor):

  • Create a numeric property based on a descriptor.

(JSC::sameValue):

  • See ES5.1 9.12.

(JSC::reject):

(JSC::JSArray::defineOwnNumericProperty):

  • Define an indexed property on an array object.

(JSC::JSArray::setLengthWritable):

  • Marks the length read-only, enters SparseMode as necessary.

(JSC::JSArray::defineOwnProperty):

  • Defines either an indexed property or 'length' on an array object.

(JSC::JSArray::getOwnPropertySlotByIndex):

  • Updated to correctly handle accessor descriptors & attributes.

(JSC::JSArray::getOwnPropertyDescriptor):

  • Updated to correctly handle accessor descriptors & attributes.

(JSC::JSArray::put):

  • Pass strict mode flag to setLength.

(JSC::JSArray::putByIndex):

  • putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.

(JSC::JSArray::putByIndexBeyondVectorLength):

  • Pass exec to SparseArrayValueMap::put.

(JSC::JSArray::deletePropertyByIndex):

  • Do not allow deletion of non-configurable properties.

(JSC::compareKeysForQSort):

  • used in implementation of getOwnPropertyNames.

(JSC::JSArray::getOwnPropertyNames):

  • Properties in the sparse map should be iterated in order.

(JSC::JSArray::setLength):

  • Updated to take a 'shouldThrow' flag, return a result indicating error.

(JSC::JSArray::pop):

  • pop should throw an error if length is not writable, even if the array is empty.

(JSC::JSArray::push):

  • putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.

(JSC::JSArray::sort):

  • Changed 'get' to 'getNonSparseMode' (can't be getters to call).

(JSC::JSArray::compactForSorting):

  • Changed 'get' to 'getNonSparseMode' (can't be getters to call).
  • runtime/JSArray.h:

(JSC::SparseArrayValueMap::lengthIsReadOnly):

  • Check if the length is read only.

(JSC::SparseArrayValueMap::setLengthIsReadOnly):

  • Mark the length as read only.

(JSC::SparseArrayValueMap::find):

  • Moved into header.

(JSC::JSArray::isLengthWritable):

  • Wraps SparseArrayValueMap::lengthIsReadOnly.
  • runtime/JSObject.cpp:

(JSC::JSObject::defineOwnProperty):

  • Should be returning the result of putDescriptor.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::attributesOverridingCurrent):

  • Added attributesOverridingCurrent - this should probably be merged with attributesWithOverride.
  • runtime/PropertyDescriptor.h:
    • Added attributesOverridingCurrent.

LayoutTests:

  • fast/js/array-defineOwnProperty-expected.txt: Added.
  • fast/js/array-defineOwnProperty.html: Added.
  • fast/js/script-tests/array-defineOwnProperty.js: Added.
    • Added tests for array properties with accessors & non-defulat attributes.
  • fast/js/mozilla/strict/15.4.4.6-expected.txt:
  • fast/js/mozilla/strict/8.12.5-expected.txt:
  • ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
    • Check in passing results.
13:50 Changeset [104487] by levin@chromium.org
  • 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp

Fix M17 build.

13:32 Changeset [104486] by tsepez@chromium.org
  • 3 edits
    4 adds in trunk

Treat code="" attribute in embed tags similarly to applet tags.
https://bugs.webkit.org/show_bug.cgi?id=75871

Reviewed by Daniel Bates.

Source/WebCore:

Tests: http/tests/security/xssAuditor/embed-tag-code-attribute-2.html

http/tests/security/xssAuditor/embed-tag-code-attribute.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterEmbedToken):

LayoutTests:

  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2.html: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute.html: Added.
13:25 Changeset [104485] by commit-queue@webkit.org
  • 13 edits in trunk

[Chromium] remove all references to the legacy accelerated 2d Canvas
implementation
https://bugs.webkit.org/show_bug.cgi?id=75108

Purging an old settings flag that is no longer referenced

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Darin Fisher.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAccelerated2dCanvasEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
13:16 Changeset [104484] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing SVG's initial transform to local coordinates to pixel snap. Also fixing widget alignment corner cases.

13:16 Changeset [104483] by aroben@apple.com
  • 2 edits in trunk/Tools

Convert Cygwin paths to Windows paths before passing them to DRT

Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
NRWT

I couldn't find a way to test this because I couldn't figure out how to override the
cygpath function as it is used by WebKitDriver.

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
Windows-style path before passing it to DRT.

13:10 Changeset [104482] by dpranke@chromium.org
  • 9 edits
    1 copy
    3 deletes in trunk/Tools

webkitpy: revamp version checking
https://bugs.webkit.org/show_bug.cgi?id=75765

Reviewed by Adam Barth.

The version-checking code in webkitpy/python24/versioning seems really
awkward and overdesigned, especially since we don't support python 2.4
any more.

In addition, I am tired of getting warnings about Python 2.6 being "a
newer release than what is supported" :).

I'm taking a page from the depot_tools python code and just creating a
new webkitpy.common.version_check module that will print a message on
stderr and call sys.exit() if we're running an unsupported version.

  • Scripts/check-webkit-style:
  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-tests:
  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/test-webkitpy:

(configure_logging):
(init):

  • Scripts/webkit-patch:

(main):

  • Scripts/webkitpy/common/system/executive.py:

(Executive._child_process_encoding):
(Executive._should_encode_child_process_arguments):

  • Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/python24/init.py: Removed.
  • Scripts/webkitpy/python24/versioning.py: Removed.
  • Scripts/webkitpy/python24/versioning_unittest.py: Removed.
13:08 Changeset [104481] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Make WebIDBDatabase::close() idempotent
https://bugs.webkit.org/show_bug.cgi?id=75751

Source/WebKit/chromium:

Allow Chromium's back-end to safely trigger the cleanup that occurs
when a database connection is closed, without tracking whether or not
the connection was previous closed by script.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::close):

LayoutTests:

Verify that calling IDBDatabase.close() twice from script is harmless.
Note that the tests pass without the related code change in the bug,
which is just for non-script use by the chromium port.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
12:58 Changeset [104480] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

remove reference to cg-specific test
https://bugs.webkit.org/show_bug.cgi?id=75881

Patch by Elliot Poger <epoger@google.com> on 2012-01-09
Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [104479] by eric.carlson@apple.com
  • 4 edits in trunk

Source/WebCore: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html
intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

No new tests, covered by existing tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_ignoreTrackDisplayUpdate.

LayoutTests: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

Re-enable <track> tests disabled after r104327.

  • platform/chromium/test_expectations.txt:
12:47 Changeset [104478] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r100343.

12:38 Changeset [104477] by abarth@webkit.org
  • 4 edits in trunk/Tools

Remove Chromium Mac CG from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=75873

Reviewed by Ojan Vafai.

This configuration no longer exists.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testOverrideJustBuildType):
(testPlatformAndBuildType):

12:22 Changeset [104476] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Add normalize attribute to ConvolverNode to disable normalization.
https://bugs.webkit.org/show_bug.cgi?id=75126

Patch by Raymond Toy <rtoy@google.com> on 2012-01-09
Reviewed by Kenneth Russell.

Tests added in convolution-mono-mono.html.

  • platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb): Add extra arg to indicate whether
normalization is enabled or not, and do it.

  • platform/audio/Reverb.h: Update declaration.
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode): Initialize attribute (to
true).
(WebCore::ConvolverNode::setBuffer): Call Reverb with
normalization argument.

  • webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::normalize): New method to return
normalization.
(WebCore::ConvolverNode::setNormalize): New method to set
normalization.

  • webaudio/ConvolverNode.idl: Add normalize attribute.
  • LayoutTests/webaudio/convolution-mono-mono.html:
  • LayoutTests/webaudio/convolution-mono-mono-expected.txt:
  • LayoutTests/webaudio/resources/convolution-testing.js:

Test for convolution. Tests only work when normalization is
disabled.

12:17 Changeset [104475] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224

Patch by Judy Hao <judy.liqiong-hao@nokia.com> on 2012-01-09
Reviewed by Philippe Normand.

Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.

Fixing memory leaks. So, no new test case is introduced.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):

12:15 Changeset [104474] by wangxianzhu@chromium.org
  • 14 edits
    1 add in trunk/Source

Avoid unnecessary TextureManager::reduceMemoryToLimit().
https://bugs.webkit.org/show_bug.cgi?id=75632

Source/WebCore:

Unnecessary TextureManager::reduceMemoryToLimit() will cause some tile
textures that are required soon to be unnecessarily removed/replaced,
and degrade performance, sometimes significantly.

For example, CCLayerTreeHost::setViewport will be called during
scrolling. The original code would call TextureManager::reduceMemoryToLimit(),
causing some textures unnecessarily discarded and then recreated
repeatedly during scrolling.

It's also unnecessary to call TextureManager::reduceMemoryToLimit()
from TextureManager::setPreferredMemoryLimitBytes() because the limit
is not a hard limit. The callers should call reduceMemoryToLimit()
explicitly if it wants it when setting the preferred memory limit.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::finishDrawingFrame): Call reduceMemoryToLimit() explicitly

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::setPreferredMemoryLimitBytes): Removed call to reduceMemoryToLimit().

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize): Changed name from setViewport(). Check change of viewportSize.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setViewportSize): Changed name from setViewport()

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Main part of the change is in Source/WebCore.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

  • WebKit.gypi:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setViewportSize):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::CCLayerTreeHostTestSetViewportSize):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::afterTest):
(WTF::TEST_F):

  • tests/TextureManagerTest.cpp: Added.

(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeTextureAllocator::deleteTexture):
(WTF::texturesMemorySize):
(WTF::createTextureManager):
(WTF::requestTexture):
(WTF::TEST):

12:02 Changeset [104473] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

There is no support for fastcall in Solaris Studio.
Fixes build on Solaris.
https://bugs.webkit.org/show_bug.cgi?id=75736

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

  • jit/JITStubs.h:
11:46 Changeset [104472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] JPEG RGB swizzling order should match platform pixel format
https://bugs.webkit.org/show_bug.cgi?id=75861

Choose between JCS_EXT_BGRX and JCS_EXT_RGBX channel swizzling
based on the configured Skia 32-bit pixel format.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-09
Reviewed by Kenneth Russell.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(rgbOutputColorSpace):

11:44 Changeset [104471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build failure on Solaris
https://bugs.webkit.org/show_bug.cgi?id=75733

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

  • wtf/ByteArray.h:
11:41 Changeset [104470] by levin@chromium.org
  • 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 104419 - [chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/9151009

11:26 Changeset [104469] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-radius is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75630

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-radius shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.
11:17 Changeset [104468] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Clean up some cruft from WTF's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420

Reviewed by Daniel Bates.

  • wtf/CMakeLists.txt: Remove the unused WTF_PORT_FLAGS variable; add

all needed paths to WTF_INCLUDE_DIRECTORIES in a single place.

11:16 Changeset [104467] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-gpu-cg-mac

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 Changeset [104466] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-snowleopard

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 Changeset [104465] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-leopard

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 Changeset [104464] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

10:38 Changeset [104463] by aroben@apple.com
  • 3 edits in trunk/Tools

Print an error message when NRWT can't run Apache

Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.check_httpd): Print an error message when Apache returns an error code instead of
failing silently.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
run Apache.
(PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
fails.

07:34 Changeset [104462] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75856

media/track/track-webvtt-tc026-voice.html is crashing on Chromium
Debug Mac after http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:32 Changeset [104461] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Gtk][ARM] Cross compiler buildbot is failing after r103040
https://bugs.webkit.org/show_bug.cgi?id=75846

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):

07:19 Changeset [104460] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r104418.
http://trac.webkit.org/changeset/104418
https://bugs.webkit.org/show_bug.cgi?id=75855

we still need to build against CG on Mac sometimes (Requested
by epoger on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
07:08 Changeset [104459] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] [AC] Simplify accelerated compositing build options
https://bugs.webkit.org/show_bug.cgi?id=75518

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-09
Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac: Remove the --enable-3d-rendering option. It's enabled by

default now when accelerated compositing is enabled.

  • GNUmakefile.am: Automatically enable 3D rendering when accelerated compositing

is turned on.

Source/WebCore:

  • GNUmakefile.am: Automatically enable 3D rendering when AC is available.
  • GNUmakefile.list.am: Clean up a comment.
06:59 Changeset [104458] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676

Reviewed by Andreas Kling.

Based on the stacks, CSSStyleSelector may be getting deleted from under the
CSSStyleSelector::appendAuthorStylesheets call. Protect by temporarily detaching
from the document. Also add assertions to catch the case.

No test, there is no known repro and the fix is speculative.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:
06:30 Changeset [104457] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use Vector<OwnPtr> for m_viewportDependentMediaQueryResults in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=75723

Reviewed by Andreas Kling.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):

  • css/CSSStyleSelector.h:
06:28 Changeset [104456] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75852

http/tests/inspector/network/download.html is timing out on mac, and
occasionally on other platforms too.

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:14 Changeset [104455] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Tools

[Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75807

This patch adds a new icon to navigationbar of the Qt MiniBrowser
which allows you to dynamically toggle whether touch mocking is
enabled or disabled.

Patch by Alexander Færøy <ahf@0x90.dk> on 2012-01-09
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::touchMockingEnabled):
(WindowOptions::setTouchMockingEnabled):

  • MiniBrowser/qt/icons/touch.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
06:05 Changeset [104454] by ossy@webkit.org
  • 2 edits
    1 copy in trunk/LayoutTests

Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
https://bugs.webkit.org/show_bug.cgi?id=75847

Reviewed by Philippe Normand.

  • fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add JSC specifix expected file as generic expected file.
  • platform/chromium/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add V8 specifix expected file.
06:00 Changeset [104453] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75849

We need to prevent TextTrack and TextTrackCue from being
garbage collected when the parent/owner is still reachable.
This is tracked in bug 73865.

Unreviewed.

  • platform/chromium/test_expectations.txt:
05:48 Changeset [104452] by alexis.menard@openbossa.org
  • 8 edits in trunk/Source/WebCore

Extend CSSValueList to allow slash separated lists.
https://bugs.webkit.org/show_bug.cgi?id=75841

Reviewed by Andreas Kling.

Multiple CSS properties are using slash to separate
various parts (e.g. border-radius) so having this
feature available in CSSValueList will make it easier
in the future to support these properties.

No new tests : existing ones should cover the refactor.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::isImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::isImplicitInitialValue):

  • css/CSSValue.h:

In order for CSSValue to not grow I moved m_isImplicitInitialValue
back to CSSInitialValue as this object is used only in CSSValuePool
and is allocated only twice.
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
Fix also usage of PassRefPtr.
(WebCore::CSSValueList::customCssText):
Refactor to use StringBuilder.

  • css/CSSValueList.h:

(WebCore::CSSValueList::createCommaSeparated):
(WebCore::CSSValueList::createSpaceSeparated):
(WebCore::CSSValueList::createSlashSeparated):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

05:22 Changeset [104451] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75844

media/track/track-cues-cuechange.html is failing after
http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

  • platform/chromium/test_expectations.txt:
04:35 Changeset [104450] by abecsi@webkit.org
  • 23 edits in trunk

[Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601

Reviewed by Kenneth Rohde Christiansen.

The current implementation uses the scale property of the QQuickWebPage
to scale the page in response to pinch gestures.
However for layout and anchoring to work correctly in QML, pinching needs
to change the page size.
This patch applies the pinch scale to the page size and to the transformation
matrix of the drawing area.
Thus the page item's coordinate system is no longer a direct representation
of the WebCore::Page coordinate system and it is no longer suitable as
an inertial frame of reference for input events. The event propagation had
to be moved to the QQuickWebView and the positions translated to content
coordinates when NativeWebEvents are created.
Re-landing with fixed event delivery for the test infrastructure.

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::geometryChanged):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::usesTraditionalDesktopBehaviour):
(QQuickWebPage::setUsesTraditionalDesktopBehaviour):
(QQuickWebPage::eventHandler):
(QQuickWebPage::setContentSize):
(QQuickWebPage::contentSize):
(QQuickWebPage::setContentScale):
(QQuickWebPage::contentScale):
(QQuickWebPage::transformFromItem):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::mapToWebContent):
(QQuickWebView::mapRectToWebContent):
(QQuickWebView::mapFromWebContent):
(QQuickWebView::mapRectFromWebContent):
(QQuickWebView::geometryChanged):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
04:13 Changeset [104449] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Set color_set function to the clipped smart class.
https://bugs.webkit.org/show_bug.cgi?id=75286

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-09
Reviewed by Andreas Kling.

Set _ewk_view_smart_color_set() function to the clipped smart class's color_set,
so application can set webpage's background color using evas_object_color_set() API.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_color_set):
(ewk_view_smart_class_init):

04:06 Changeset [104448] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75840

Unreviewed.

fast/filesystem/file-writer-abort.html is occasionally crashing
also on Windows.

  • platform/chromium/test_expectations.txt:
03:54 Changeset [104447] by noam.rosenthal@nokia.com
  • 7 edits
    1 add in trunk/Source/WebCore

[Texmap] Move surface management from TextureMapperNode to TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=75779

Instead of a TextureMapperSurfaceManager class inside of TextureMapperNode.cpp, we now
maintain that surface pool inside of the TextureMapper class. This will later allow us to
allocate intermediate surface from within TextureMapperGL, a functionality we need for
filters.

Also, surfaces are not automatically created with the viewport size, but rather with the
size passed as a parameter. The surface from the pool is the smallest texture that is
larger than the required size, or any texture if such texture is not yet allocated.

Reviewed by Kenneth Rohde Christiansen.

Tests in LayoutTests/compositing already cover this.

  • GNUmakefile.list.am: Added TextureMapper.cpp to the build.
  • Target.pri: Added TextureMapper.cpp to the build.
  • WebCore.gypi: Added TextureMapper.cpp to the build.
  • platform/graphics/texmap/TextureMapper.cpp: Added.
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::paintRecursive):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::TextureMapperNode):

02:16 Changeset [104446] by mario@webkit.org
  • 6 edits in trunk/Source

[Gtk] Regression: text-inserted events lack text inserted and current line
https://bugs.webkit.org/show_bug.cgi?id=72830

Reviewed by Martin Robinson.

Source/WebCore:

Fix issue getting the exposed text for an accessibility object at,
before of after a given offset, after changing it at least once.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_class_init): Don't initialize
gailTextUtilQuark, it won't be used anymore.
(getGailTextUtilForAtk): Don't cache the GailTextUtil as object
data, but create a new one each time this function is called.
(webkit_accessible_text_get_caret_offset): Simplified code by
using the new focusedObjectAndCaretOffsetUnignored function,
instead of the old objectAndOffsetUnignored function.
(focusedObjectAndCaretOffsetUnignored): Rewrite of the old
objectAndOffsetUnignored function so it now needs less
parameters than before and takes care of carefully selecting the
start and end visible positions to calculate the position of the
caret from the point of view of the accessibility object of
reference passed as the only input parameter now. Updated callers.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h:
  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Simplified code by calling to focusedObjectAndCaretOffsetUnignored
function, instead of the old objectAndOffsetUnignored function.

Source/WebKit/gtk:

Updated unit tests to check that both getting the current position
for the caret and the exposed text at, before or after a given
offset for an accessible object works as expected.

  • tests/testatk.c:

(runGetTextTests): For objects implementing AtkEditableText, try
to change the exposed text and retrieve it again as a full line.
(testWebkitAtkCaretOffsets): For a text control (a text entry),
set the caret offset to a value greater than 1 and retrieve it.

02:00 Changeset [104445] by antti@apple.com
  • 4 edits
    2 adds in trunk

Subtree invalidation on stylesheet change
https://bugs.webkit.org/show_bug.cgi?id=75834

Source/WebCore:

Reviewed by Andreas Kling.

Currently if we add a stylesheet with scoped selectors and matching scope elements exist,
we recalculate the entire document style. It is sufficient to invalidate the subtrees
matching the scope only.

This allows us to do less full style recalcs on many popular web sites (nytimes.com for example).
Subtree recalcs are typically much cheaper.

Test: fast/css/id-or-class-before-stylesheet.html

  • dom/Document.cpp:

(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/id-or-class-before-stylesheet-expected.txt: Added.
  • fast/css/id-or-class-before-stylesheet.html: Added.
01:53 Changeset [104444] by carlosgc@webkit.org
  • 4 edits in trunk

Unreviewed. Fix make distcheck issues.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
01:38 Changeset [104443] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument string
in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=75830

Reviewed by Adam Barth.

The code in CodeGeneratorJS.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):

01:09 Changeset [104442] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: Remove propertiesEqual().
<http://webkit.org/b/75829>

Reviewed by Antti Koivisto.

Remove propertiesEqual() since it was wrong (it only compared CSSValue pointers,
not the actual values.)

Skip comparing the style declarations in NamedNodeMap::mappedMapsEquivalent()
and just compare pointers instead. This is possible because the declarations
all come from the mapped attribute/declaration table.

  • css/CSSMutableStyleDeclaration.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

00:53 Changeset [104441] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

insertAdjacentHTML doesn't play nice with DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=75826

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html

Document nodes aren't the only non-Element ContainerNodes.

  • html/HTMLElement.cpp:

(WebCore::contextElementForInsertion):

LayoutTests:

  • fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Added.
  • fast/dom/insertAdjacentHTML-DocumentFragment-crash.html: Added.
00:42 Changeset [104440] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Any attribute with a decl() can be assumed to be mapped.
<http://webkit.org/b/75832>

Reviewed by Antti Koivisto.

Replace isMappedAttribute() check with an assertion. Only a mapped attribute
will have an associated style declaration.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

00:32 Changeset [104439] by philn@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104412.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.
  • platform/gtk/Skipped: Skip fast/text/international/spaces-combined-in-vertical-text.html
00:26 Changeset [104438] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument
string in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=75828

Reviewed by Darin Adler.

The code in CodeGeneratorV8.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

00:06 Changeset [104437] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r104412.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

01/08/12:

23:18 Changeset [104436] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation error about ListHashSetReverseIterator
https://bugs.webkit.org/show_bug.cgi?id=75372

Reviewed by Darin Adler.

There is a typo in class ListHashSetReverseIterator:
typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
Should be
typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;

  • wtf/ListHashSet.h:
23:15 Changeset [104435] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
https://bugs.webkit.org/show_bug.cgi?id=75827

Reviewed by Darin Adler.

Explicitly initialize the struct timeval to avoid compiler warnings.

  • platform/mac/ScrollAnimatorMac.mm:

(systemUptime):

23:09 Changeset [104434] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

23:01 Changeset [104433] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.3

New tag.

22:56 Changeset [104432] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

color tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75819

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/color-hsl-expected.txt: Added.
  • css3/calc/color-hsl.html: Added.
  • css3/calc/color-rgb-expected.txt: Added.
  • css3/calc/color-rgb.html: Added.
22:14 Changeset [104431] by mikelawther@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

font tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75818

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/font-expected.txt: Added.
  • css3/calc/font-monospace-expected.txt: Added.
  • css3/calc/font-monospace.html: Added.
  • css3/calc/font-size-expected.txt: Added.
  • css3/calc/font-size-fractional-expected.txt: Added.
  • css3/calc/font-size-fractional.html: Added.
  • css3/calc/font-size.html: Added.
  • css3/calc/font.html: Added.
22:01 Changeset [104430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75820

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-01-08
Reviewed by Darin Adler.

Dbates submitted a patch to release fastMalloc allocation
in GraphicsContext3DOpenGL.cpp properly.
See http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
But one thing similar to the above still remains mismatched.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getShaderInfoLog):

20:27 Changeset [104429] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

WinCE build fix after r104415.

  • jit/JITExceptions.cpp:
  • jit/JITExceptions.h:
18:57 Changeset [104428] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

border tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75815

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

Reviewed by Adam Barth.

  • css3/calc/border-expected.txt: Added.
  • css3/calc/border-radius-expected-mismatch.html: Added.
  • css3/calc/border-radius.html: Added.
  • css3/calc/border.html: Added.
18:50 Changeset [104427] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
https://bugs.webkit.org/show_bug.cgi?id=75611

Reviewed by Antonio Gomes.

In platform/network/blackberry/ResourceHandleBlackBerry.cpp, we were using
NetworkingContext::wrappedFrame() to access the frame associated with the
networking context. NetworkingContext::wrappedFrame() was added as a virtual
function by the BlackBerry porting internally. It's unnecessary because
FrameNetworkingContextBlackBerry inherits from FrameNetworkingContext which
has a protected frame() member which is exported as public in
FrameNetworkingContextBlackBerry. We don't want to upstream wrappedFrame()
as a specific change of the BlackBerry porting in
platform/network/NetworkingContext.h, so use the concrete networking context
FrameNetworkingContextBlackBerry to access the associated frame.

No functionalities changed, no new tests.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

18:41 Changeset [104426] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add intermittent timeout expectations to media/track/track-cues-cuechange.html and
media/track/track-cues-enter-exit.html. The failure is tracked by the bug 75817.

  • platform/chromium/test_expectations.txt:
18:33 Changeset [104425] by commit-queue@webkit.org
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104421.
http://trac.webkit.org/changeset/104421
https://bugs.webkit.org/show_bug.cgi?id=75816

Need to rebaseline some tests on Linux (Requested by noamr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
18:14 Changeset [104424] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

Another Chromium Windows and Chromium Linux rebaseline after r104240.
The expected result committed in r104361 was clearly wrong.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
17:01 Changeset [104423] by abarth@webkit.org
  • 6 edits in trunk/Tools

Remove support for Chromium Mac CG from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=75814

Reviewed by Eric Seidel.

This configuration no longer exists. This patch is mostly a matter of
updating config.js and removing the examples from the unit tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
16:49 Changeset [104422] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove Mac CG specific expectations in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=75813

Unreviewed.

This configuration no longer exists and this change is needed to stop
the bots from erroring out.

  • platform/chromium/test_expectations.txt:
16:46 Changeset [104421] by noam.rosenthal@nokia.com
  • 8 edits
    54 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
16:32 Changeset [104420] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Eric Seidel.

Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
(Chromium still comes before GTK and Qt).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
16:29 Changeset [104419] by levin@chromium.org
  • 4 edits
    5 adds in trunk

[chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.
16:27 Changeset [104418] by abarth@webkit.org
  • 5 edits in trunk/Source

[Chromium] Remove use_skia option from GYP
https://bugs.webkit.org/show_bug.cgi?id=75811

Reviewed by Ryosuke Niwa.

The CG configuration of Chromium Mac is no longer supported.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
16:12 Changeset [104417] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Remove the concept of core builders from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75809

Reviewed by Ryosuke Niwa.

Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
and remove the relevant code.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init):
(BuildBot._matches_regexps):
(BuildBot._builder_statuses_with_names_matching_regexps):
(BuildBot.builder_statuses):
(BuildBot.failure_map):
(BuildBot._latest_builds_from_builders):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_status_parsing):
(test_last_green_revision):
(test_last_green_revision.mock_builds_from_builders):

16:04 Changeset [104416] by abarth@webkit.org
  • 19 edits in trunk/Tools

Remove Chromium Mac CG concept from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75810

Reviewed by Ryosuke Niwa.

This configuration no longer exists. We can remove all the supporting
code from webkitpy.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
(BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build):

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.integration_test_chromium_gpu_mac):
(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest.test_baseline_paths):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):
(ChromiumMacPort.init):
(ChromiumMacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_graphics_type):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_mac):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockChromiumDRTTest.test_chromium_parse_options):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(test_url_fetcher):
(test_zip_factory):
(test_archive):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_expectations):

15:46 Changeset [104415] by fpizlo@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

The JIT's protocol for exception handling should be available to other parts of the system
https://bugs.webkit.org/show_bug.cgi?id=75808
<rdar://problem/10661025>

Reviewed by Oliver Hunt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • jit/JITExceptions.cpp: Added.

(JSC::genericThrow):
(JSC::jitThrow):

  • jit/JITExceptions.h: Added.
  • jit/JITStubs.cpp:
  • runtime/JSGlobalData.h:
15:44 Changeset [104414] by benjamin@webkit.org
  • 10 edits
    6 adds in trunk

Valid canonical URLs should have a lowercase hostname
https://bugs.webkit.org/show_bug.cgi?id=75771

Reviewed by Adam Barth.

Source/WebCore:

According to the RFC 3986 (and other browsers implementation), the hostname
of valid canonical URLs should be lowercase.

This patch lowercase the hostname in KURL::parse() similarily to what we
do for the scheme.

Tests: fast/url/host-lowercase-per-scheme.html

fast/url/safari-extension.html

  • platform/KURL.cpp:

(WebCore::isCanonicalHostnameLowercaseForScheme):
(WebCore::KURL::parse):

LayoutTests:

Update the test results for existing tests validating the hostname.

Added the test safari-extension.html for checking regressions of
the safari-extension:// protocol.

Added host-lowercase-per-scheme.html for testing the hostname is
set to lowercase for regognized Internet protocols.

  • fast/url/host-expected.txt:
  • fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • fast/url/host-lowercase-per-scheme.html: Added.
  • fast/url/idna2008-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/safari-extension-expected.txt: Added.
  • fast/url/safari-extension.html: Added.
  • fast/url/standard-url-expected.txt:
  • platform/chromium/fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • platform/chromium/fast/url/safari-extension-expected.txt: Added.
15:28 Changeset [104413] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Adam Barth.

Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
15:15 Changeset [104412] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Sam Weinig.

This patch contains only renames and FIXME comments. No behavior change.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::allowAccessToNode):
(WebCore::allowAccessToFrame):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::allowSettingJavascriptURL):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

14:48 Changeset [104411] by abarth@webkit.org
  • 15 edits in trunk/Source/WebCore

Remove deprecated toDynamicFrame and unused [CallWith=DynamicFrame]
https://bugs.webkit.org/show_bug.cgi?id=75795

Reviewed by Eric Seidel.

We've succeeded in removing all the callers fo this function, including
all the uses of CallWith=DynamicFrame in IDL files.

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
13:59 Changeset [104410] by abarth@webkit.org
  • 14 edits in trunk/Source/WebCore

NeedsUserGestureCheck IDL attribute is no longer used
https://bugs.webkit.org/show_bug.cgi?id=75794

Reviewed by Eric Seidel.

This IDL attribute is no longer used because we use static state to
keep track of the user gesture state. We can delete the code that
supports it.

  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
13:44 Changeset [104409] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r103859): WKViews leak
https://bugs.webkit.org/show_bug.cgi?id=75805

The flags changed event monitor added in r103859 was retaining the WKView (as it references
self in the handler block), causing it to leak.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Moved call to remove the flags changed event monitor from here...
(-[WKView viewDidMoveToWindow]): ...to here. Moved call to add the flags changed event
monitor to here from...
(-[WKView initWithFrame:contextRef:pageGroupRef:]): ...here.

13:33 Changeset [104408] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove unused security functions from V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=75797

Reviewed by Eric Seidel.

This functions have no callers. They can be removed.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
13:31 Changeset [104407] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
https://bugs.webkit.org/show_bug.cgi?id=75656

Reviewed by Darin Adler.

Update the implementation of SubresourceLoader::didReceiveDataArray() to conform to the
refactoring done as part of bug 71149 in r100311.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::errorLoadingResource):

  • loader/SubresourceLoader.h:
  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):

13:03 Changeset [104406] by steveblock@google.com
  • 6 edits
    9 deletes in trunk/Source/WebCore

Remove V8-specific Java Bridge code
https://bugs.webkit.org/show_bug.cgi?id=75801

Reviewed by Darin Adler.

Also remove superfluous JSC and V8 guards, as the code is now used only
with JSC.

No new tests, removing dead code only.

  • WebCore.gypi:
  • bridge/jni/JNIUtility.cpp:

(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):

  • bridge/jni/JavaType.h:
  • bridge/jni/jsc/JavaMethodJSC.cpp:

(appendClassName):
(JavaMethod::signature):

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Removed.
  • bridge/jni/v8/JNIUtilityPrivate.h: Removed.
  • bridge/jni/v8/JavaClassV8.h: Removed.
  • bridge/jni/v8/JavaFieldV8.h: Removed.
  • bridge/jni/v8/JavaInstanceV8.h: Removed.
  • bridge/jni/v8/JavaMethodV8.h: Removed.
  • bridge/jni/v8/JavaNPObjectV8.cpp: Removed.
  • bridge/jni/v8/JavaNPObjectV8.h: Removed.
  • bridge/jni/v8/JavaValueV8.h: Removed.
  • bridge/jsc/BridgeJSC.h:
11:35 Changeset [104405] by ossy@webkit.org
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104403.
http://trac.webkit.org/changeset/104403
https://bugs.webkit.org/show_bug.cgi?id=75803

It broke all tests on Qt5 (Requested by Ossy_weekend on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
11:22 Changeset [104404] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Don't create style selector in Element::recalcStyleIfNeededAfterAttributeChanged if it doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=75802

Rubber-stamped by Andreas Kling.

Element::recalcStyleIfNeededAfterAttributeChanged shouldn't create style selector for attribute
check if it doesn't already exist. We are going to need a full style recalc anyway in that case
and the constructed style selector may get throw out again.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

10:05 Changeset [104403] by noam.rosenthal@nokia.com
  • 8 edits
    55 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
08:46 Changeset [104402] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Rewrite the CSS parser of prepare-ChangeLog with unittests.
https://bugs.webkit.org/show_bug.cgi?id=75202

Reviewed by David Kilzer.

The current CSS parser can just parse simple CSSes like

foo bar baz {

property1: value;
property2: value;

}

, and cannot parse comments nor a CSS in which a selector and {
appears in different lines. This patch rewrites the CSS parser
(i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
shown in css_unittests.css.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css

  • Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.

(element1):
(element2):
(element3):
(element4.p):
(element5.p.q.r.s):
(element6#p):
(element7 element8):
(element9.p element10.q):
(element11#p element12#q):
(element13, element14):
(.p):
(#p):
(.p element15 #q element16.r element17#s):
(element18:target):
(element19):
(element20):
(element21):
(element22):

08:21 Changeset [104401] by haraken@chromium.org
  • 4 edits in trunk/Tools

The Perl parser of prepare-ChangeLog can parse here-documents
https://bugs.webkit.org/show_bug.cgi?id=73208

Reviewed by David Kilzer.

Currently prepare-ChangeLog cannot recognize here-documents in Perl,
which results in wrong subroutine names in ChangeLogs.
With this patch, prepare-ChangeLog can judge whether the line of "}"
is the end of a subroutine or a line inside a here-document.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_perl):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:

Added test cases for here-documents.
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(func16):

08:15 Changeset [104400] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the JavaScript parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75201

Reviewed by David Kilzer.

javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
of prepare-ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript): Before this patch, a string found was just
omitted from parsing. Thus,

str = "foo"
function func() {
}

was recognized as equivalent to

str = function func() {
}

This patch replaces a string with a dummy identifier 'string_appeared_here'
to tell the parser that a string appeared there.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.

(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(funcOverloaded):
(Func1.prototype.get x1):
(Func1.prototype.get x2):
(Func1.prototype.set x1):
(Func1.prototype.set x3):
(Func2.prototype.func13):
(Func2.prototype.func14):
(Func2.prototype.func15):
(func16.func17):
(func16.func18):
(func16.func19):
(func16):

03:45 Changeset [104399] by antti@apple.com
  • 5 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r104060): Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

If something triggers CSSStyleSelector construction very early, before documentElement is known,
it won't be able to resolve viewport-related media queries. In the included test case
the attribute on <html> element triggers the style selector creation. I can't repro
the fast/media/viewport-media-query.html failure but I suspect it is the same issue with
a different mechanism for early CSSStyleSelector construction.

  • Reset style selector on documentElement change.
  • Remove the code for lazy documentElement initialization. It is not an useful optimization, the children of Document rarely change.

Test: fast/media/viewport-media-query-synchronous.html

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::childrenChanged):

  • dom/Document.h:

(WebCore::Document::documentElement):

LayoutTests: Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

  • fast/media/viewport-media-query-synchronous-expected.txt: Added.
  • fast/media/viewport-media-query-synchronous.html: Added.
00:06 Changeset [104398] by levin@chromium.org
  • 12 edits
    3 adds in trunk

[chromium] Add layout test support for autosize code in FrameView.
https://bugs.webkit.org/show_bug.cgi?id=73631

Reviewed by Dmitry Titov.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Expose the new autoresize method.
(LayoutTestController::reset): Set the autoresize mode back to false.
(LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/autoresize/basic-expected.txt: Added.
  • fast/autoresize/basic.html: Added. Simple test to verify that autoresizing happens.
  • platform/efl/Skipped: Skipped the new directory since the layout test controller on this platform, doesn't support enableAutoResizeMode.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.

01/07/12:

19:59 Changeset [104397] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):

19:47 Changeset [104396] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to regenerate bindings on the Windows bot.

  • html/HTMLCollection.h:
19:41 Changeset [104395] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc()

Rubber-stamped by Adam Barth.

Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[]
and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice,
OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled,
it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(),
respectively. Hence, there may be a mismatch between the allocation and deallocation
routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using
operator new[].

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getProgramInfoLog):

16:45 Changeset [104394] by dslomov@google.com
  • 11 edits
    2 moves
    4 adds
    4 deletes in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104240.

  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed.
16:09 Changeset [104393] by dslomov@google.com
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed: updating expectations and rebaselining.
svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/.

  • platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
15:51 Changeset [104392] by dslomov@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed: updating expectations and rebaslining.
svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/.

  • platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:39 Changeset [104391] by philn@webkit.org
  • 6 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104386 and r104208.

  • platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/table/032-expected.txt:
  • platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
14:12 Changeset [104390] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: test expectations and filed WK75784.

  • platform/chromium/test_expectations.txt:
13:50 Changeset [104389] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed https://bugs.webkit.org/show_bug.cgi?id=75783.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

10:43 Changeset [104388] by cmarrin@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2012-01-07 Chris Marrin <cmarrin@apple.com>

Fixed a warning in GTK build of ANGLE

Unreviewed.

  • src/compiler/DetectRecursion.cpp: (DetectRecursion::~DetectRecursion):
09:46 Changeset [104387] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] Each test takes roughly half a second to load
https://bugs.webkit.org/show_bug.cgi?id=70699

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Set the XDG_CACHE_HOME environment variable when testing with
WebKitTestRunner. This way the testing is started with a non-existing
application cache. If the cache exists and is not empty, the emptying
and vacuuming that is performed before every test can consume a lot of
time.

This is just a temporary workaround until it becomes possible to set
a desired directory to be used as the application cache location through
WebKitWebContext.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

09:18 Changeset [104386] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Enable requestAnimationFrame in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=75773

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Tools:

Enable requestAnimationFrame for the Gtk port.

  • Scripts/build-webkit:

LayoutTests:

Skip the passing requestAnimationFrame-related tests and put
the remaining failing one under the tests that require modal
dialog implementation.

  • platform/gtk/Skipped:
07:22 Changeset [104385] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebCore

2012-01-07 Chris Marrin <cmarrin@apple.com>

Fixed ANGLE build for GNU and QT broken in https://trac.webkit.org/changeset/104363

Unreviewed.

  • GNUmakefile.list.am:
  • Target.pri:
02:08 Changeset [104384] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed C++ bindings build fix after r104383.

Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::impl):

  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:

(WebDOMTestEventConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:

(WebDOMTestInterface::impl):

  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:

(WebDOMTestMediaQueryListListener::impl):

  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:

(WebDOMTestNamedConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::impl):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::impl):

01:35 Changeset [104383] by kling@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

  • Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
01:14 Changeset [104382] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):

01:12 Changeset [104381] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
https://bugs.webkit.org/show_bug.cgi?id=75731

Reviewed by Andreas Kling.

Source/WebCore:

The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
DynamicSubtreeNodeList's m_node instead.

Test: fast/dom/node-list-length-after-removing-node.html

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):

LayoutTests:

Add a regression test. It reproduces the crash with a very high probability.

  • fast/dom/node-list-length-after-removing-node-expected.txt: Added.
  • fast/dom/node-list-length-after-removing-node.html: Added.
00:46 Changeset [104380] by abarth@webkit.org
  • 41 edits
    2 copies in trunk/Source/WebCore

Disconnecting DOMWindow properties is fragile and overly complicated
https://bugs.webkit.org/show_bug.cgi?id=75699

Reviewed by Alexey Proskuryakov.

Previously, we had to carefully check every object tree hanging off of
DOMWindow to make sure that every property correctly disconnected
itself and all its subobjects from the Frame when the DOMWindow
disconnected from the Frame.

This patch introduces DOMWindowProperty, which is a base class that
handles this work automagically, ensuring that we won't have any
dangling Frame pointers and removing a bunch of boilerplate code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • css/StyleMedia.cpp:

(WebCore::StyleMedia::StyleMedia):

  • css/StyleMedia.h:

(WebCore::StyleMedia::create):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::DOMApplicationCache):
(WebCore::DOMApplicationCache::disconnectFrame):

  • loader/appcache/DOMApplicationCache.h:
  • page/BarInfo.cpp:

(WebCore::BarInfo::BarInfo):

  • page/BarInfo.h:
  • page/Console.cpp:

(WebCore::Console::Console):
(WebCore::Console::memory):

  • page/Console.h:
  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):

  • page/DOMSelection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::registerProperty):
(WebCore::DOMWindow::unregisterProperty):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h:
  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):

  • page/Geolocation.h:
  • page/History.cpp:

(WebCore::History::History):

  • page/History.h:
  • page/Location.cpp:

(WebCore::Location::Location):

  • page/Location.h:
  • page/Navigator.cpp:

(WebCore::Navigator::Navigator):
(WebCore::Navigator::~Navigator):

  • page/Navigator.h:
  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::memory):

  • page/Performance.h:
  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::PerformanceNavigation):

  • page/PerformanceNavigation.h:
  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::PerformanceTiming):

  • page/PerformanceTiming.h:
  • page/Screen.cpp:

(WebCore::Screen::Screen):

  • page/Screen.h:
  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):

  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::DOMPluginArray):

  • plugins/DOMPluginArray.h:
  • storage/Storage.cpp:

(WebCore::Storage::Storage):

  • storage/Storage.h:

01/06/12:

23:33 Changeset [104379] by mrowe@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

Regenerate a few files with a more appropriate version of bison.

Rubber-stamped by Dan Bernstein.

  • src/compiler/glslang.l: Tweak the input so that it generates code that compiles without warnings.
  • src/compiler/glslang_lex.cpp:
  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
22:57 Changeset [104378] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r83075): Save as PDF does not generate any links for webkit.org and others
<http://webkit.org/b/75768> <rdar://problem/10659258>

Use RenderObject::hasOutline when determining whether to always create line boxes so that
we take in to consideration whether we'll be creating PDF link rects.

Reviewed by Dan Bernstein.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):

22:57 Changeset [104377] by mrowe@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (WebKit2): Save as PDF no longer generates links to URLs
<http://webkit.org/b/65076> / <rdar://problem/9606246>

WebKit2 printing works by having the web process render the page content to a PDF. The PDF
data is then shipped to the UI process which will render it in to the printing graphics context.
Links were being lost because the API used to do the rendering of the PDF in to the printing
graphics context, CGContextDrawPDFPage, did not preserve the links that were present in the
PDF content received from the web process.

To fix this we switch to using PDFKit for drawing the PDF in to the printing graphics context.
PDFKit provides the ability for us to iterate over the links in the PDF content ourselves and
add links in to the printing graphics context.

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKPrintingView.mm:

(pdfAnnotationLinkClass): Look up the PDFAnnotationLink class from PDFKit as WebKit2 loads PDFKit lazily.
(pdfDocumentClass): Ditto.
(-[WKPrintingView _drawPDFDocument:page:atPoint:]): Switch to using the PDFKit equivalents of several types.
Iterate over the annotations present in the PDFPage, calling CGPDFContextSetURLForRect for each PDFAnnotationLink
that we find.
(-[WKPrintingView _drawPreview:]): Create an NSData to feed to PDFDocument.
(-[WKPrintingView drawRect:]): Ditto.

  • WebKit2Prefix.h: Add the usual workaround to make Objective-C exceptions compile when C++ exception handling is disabled.
22:46 Changeset [104376] by commit-queue@webkit.org
  • 35 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r104373 and r104374.
http://trac.webkit.org/changeset/104373
http://trac.webkit.org/changeset/104374
https://bugs.webkit.org/show_bug.cgi?id=75769

Too many assertion failures. (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLAllCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::detachFromNode):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLCollection.h:
  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):
(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::elements):

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLOptionsCollection.h:
  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

  • html/HTMLPropertiesCollection.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::~HTMLSelectElement):
(WebCore::HTMLSelectElement::options):

  • html/HTMLSelectElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

LayoutTests:

  • fast/dom/htmlcollection-protects-base-expected.txt: Removed.
  • fast/dom/htmlcollection-protects-base.html: Removed.
  • fast/dom/htmlcollection-zombies-expected.txt: Added.
  • fast/dom/htmlcollection-zombies.html: Added.
20:20 Changeset [104375] by jarred@sencha.com
  • 2 edits in trunk/Tools

Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.

  • Scripts/webkitdirs.pm:

(buildChromium):
Missing parentheses.

19:58 Changeset [104374] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r104373.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

19:30 Changeset [104373] by kling@webkit.org
  • 34 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
19:12 Changeset [104372] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

DOMWindow should be a FrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=75697

Reviewed by Alexey Proskuryakov.

DOMWindow plays exactly the role of a FrameDestructionObserver, just
with special-case code. It should just use the general-case code.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::~Frame):
(WebCore::Frame::clearDOMWindow):
(WebCore::Frame::setDOMWindow):

  • page/Frame.h:
19:10 Changeset [104371] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759

Implement missing accessor and make setter public.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-06
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::searchingForNodeInPage):

  • inspector/InspectorDOMAgent.h:
18:50 Changeset [104370] by ostapenko.viatcheslav@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] [WK2] Minibrowser leaks memory ~6-7Mb per reload
https://bugs.webkit.org/show_bug.cgi?id=75746

Reset WebGraphicsLayer::m_layerTreeTileClient of all dependent
layers from ~LayerTreeHostQt(). This replaces r103760 which
causes leaks of GraphicsLayerTextureMapper objects on UI side.

Reviewed by Noam Rosenthal.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::~LayerTreeHostQt):

18:43 Changeset [104369] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Roll out r104362 since it broke the build.

18:39 Changeset [104368] by wjmaclean@chromium.org
  • 9 edits
    1 copy
    2 adds in trunk/Source

[Chromium] Cull occluded tiles in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=70533

Reviewed by James Robinson.

Source/WebCore:

Unit test provided, must pass all existing GPU layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCQuadCuller.cpp: Added.

(std::swap):
(WebCore::regionContainsRect):
(WebCore::CCQuadCuller::cullOccludedQuads):

  • platform/graphics/chromium/cc/CCQuadCuller.h: Added.

(WebCore::CCQuadCuller::CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::optimizeQuads):

  • platform/graphics/chromium/cc/CCRenderPass.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCQuadCullerTest.cpp: Added.

(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
(WebCore::TEST):

17:59 Changeset [104367] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

rollout uneeded windows build fix.

17:56 Changeset [104366] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Move more rubberbanding code into ScrollAnimatorMac::smoothScrollWithEvent
https://bugs.webkit.org/show_bug.cgi?id=75750

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Move rubberbanding related code into smoothScrollWithEvent.

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
Move code here from handleWheelEvent and made the function return a boolean.

(WebCore::ScrollAnimatorMac::snapRubberBand):
Call the client.

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Ditto.

17:55 Changeset [104365] by kbr@google.com
  • 10 edits
    8 deletes in branches/chromium/963

Revert 98735 - Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property (http://crbug.com/107283)
https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html

compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.

  • platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,

added ContentsVisibilityChanged flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.

  • rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

  • compositing/visibility/visibility-composited-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms.html: Added.
  • compositing/visibility/visibility-composited.html: Added.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • compositing/visibility/visibility-image-layers-dynamic.html: Added.
  • compositing/visibility/visibility-image-layers-expected.png: Added.
  • compositing/visibility/visibility-image-layers.html: Added.

TBR=simon.fraser@apple.com
Review URL: http://codereview.chromium.org/9120020

17:40 Changeset [104364] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r91145.

17:40 Changeset [104363] by cmarrin@apple.com
  • 77 edits
    6 adds
    7 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE in WebKit tree
https://bugs.webkit.org/show_bug.cgi?id=75753

Reviewed by Simon Fraser.

Updated ANGLE to r939. Fixed a compiler error (missing case in switch statement)
and added 5 new files to xcodeproj. Other than that it is a straight copy of
the files from the ANGLE repository.

  • ANGLE.xcodeproj/project.pbxproj:
  • include/EGL/eglext.h:
  • include/EGL/eglplatform.h:
  • include/GLES2/gl2ext.h:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp:

(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):

  • src/common/version.h:
  • src/compiler/BaseTypes.h:

(getBasicString):

  • src/compiler/BuiltInFunctionEmulator.cpp: Added.

(BuiltInFunctionEmulator::BuiltInFunctionEmulator):
(BuiltInFunctionEmulator::SetFunctionCalled):
(BuiltInFunctionEmulator::OutputEmulatedFunctionDefinition):
(BuiltInFunctionEmulator::IdentifyFunction):
(BuiltInFunctionEmulator::MarkBuiltInFunctionsForEmulation):
(BuiltInFunctionEmulator::Cleanup):
(BuiltInFunctionEmulator::GetEmulatedFunctionName):

  • src/compiler/BuiltInFunctionEmulator.h: Added.
  • src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::compile):
(TCompiler::clearResults):
(TCompiler::detectRecursion):
(TCompiler::getMappedNameMaxLength):
(TCompiler::getBuiltInFunctionEmulator):

  • src/compiler/DetectRecursion.cpp: Added.

(DetectRecursion::FunctionNode::FunctionNode):
(DetectRecursion::FunctionNode::getName):
(DetectRecursion::FunctionNode::addCallee):
(DetectRecursion::FunctionNode::detectRecursion):
(DetectRecursion::DetectRecursion):
(DetectRecursion::~DetectRecursion):
(DetectRecursion::visitAggregate):
(DetectRecursion::detectRecursion):
(DetectRecursion::findFunctionByName):

  • src/compiler/DetectRecursion.h: Added.
  • src/compiler/ExtensionBehavior.h:
  • src/compiler/ForLoopUnroll.cpp:

(ForLoopUnroll::MarkForLoopsWithIntegerIndicesForUnrolling):

  • src/compiler/ForLoopUnroll.h:
  • src/compiler/Initialize.cpp:

(BuiltInFunctionsCommon):
(BuiltInFunctionsVertex):
(BuiltInFunctionsFragment):
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):

  • src/compiler/MapLongVariableNames.cpp:

(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapVaryingLongName):

  • src/compiler/MapLongVariableNames.h:
  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitUnary):
(TOutputGLSLBase::visitAggregate):

  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorate):
(sh::OutputHLSL::decorateUniform):

  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp:

(TParseContext::recover):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):

  • src/compiler/PoolAlloc.h:

(pool_allocator::pool_allocator):
(pool_allocator::operator=):
(pool_allocator::setAllocator):
(pool_allocator::getAllocator):

  • src/compiler/ShHandle.h:
  • src/compiler/ShaderLang.cpp:

(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShGetInfo):

  • src/compiler/SymbolTable.cpp:

(TType::computeDeepestStructNesting):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):
(TranslatorESSL::writeExtensionBehavior):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/Types.h:

(TType::TType):
(TType::copyType):
(TType::setStruct):
(TType::getDeepestStructNesting):

  • src/compiler/UnfoldSelect.cpp:

(sh::UnfoldSelect::traverse):
(sh::UnfoldSelect::visitSelection):
(sh::UnfoldSelect::visitLoop):
(sh::UnfoldSelect::getNextTemporaryIndex):

  • src/compiler/UnfoldSelect.h:
  • src/compiler/ValidateLimitations.cpp:
  • src/compiler/ValidateLimitations.h:
  • src/compiler/VariableInfo.cpp:

(getVariableDataType):

  • src/compiler/generate_glslang_lexer.sh: Removed.
  • src/compiler/generate_glslang_parser.sh: Removed.
  • src/compiler/generate_parser.sh: Added.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(yy_get_previous_state):
(yy_try_NUL_trans):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
  • src/compiler/intermOut.cpp:

(TOutputTraverser::visitAggregate):

  • src/compiler/intermediate.h:

(TIntermUnary::TIntermUnary):
(TIntermUnary::setUseEmulatedFunction):
(TIntermUnary::getUseEmulatedFunction):
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::setUseEmulatedFunction):
(TIntermAggregate::getUseEmulatedFunction):

  • src/compiler/osinclude.h:
  • src/compiler/ossource_posix.cpp:

(OS_AllocTLSIndex):
(OS_SetTLSValue):
(OS_FreeTLSIndex):

  • src/compiler/preprocessor/atom.c:

(GrowAtomTable):

  • src/compiler/preprocessor/length_limits.h: Added.
  • src/compiler/preprocessor/scanner.h:
  • src/libEGL/Display.cpp:

(egl::Display::getDisplay):
(egl::Display::Display):
(egl::Display::~Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::startScene):
(egl::Display::endScene):
(egl::Display::createDevice):
(egl::Display::initializeDevice):
(egl::Display::resetDevice):
(egl::Display::createWindowSurface):
(egl::Display::createOffscreenSurface):
(egl::Display::createContext):
(egl::Display::restoreLostDevice):
(egl::Display::notifyDeviceLost):
(egl::Display::isDeviceLost):
(egl::Display::testDeviceLost):
(egl::Display::testDeviceResettable):
(egl::Display::getDXT1TextureSupport):
(egl::Display::getDXT3TextureSupport):
(egl::Display::getDXT5TextureSupport):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getTexturePool):
(egl::Display::initExtensionString):

  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp:

(egl::Surface::Surface):
(egl::Surface::initialize):
(egl::Surface::resetSwapChain):
(egl::Surface::subclassWindow):
(egl::Surface::unsubclassWindow):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):
(egl::Surface::isPostSubBufferSupported):

  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libEGL/libEGL.rc:
  • src/libEGL/libEGL.vcproj:
  • src/libGLESv2/Buffer.cpp:

(gl::Buffer::bufferSubData):

  • src/libGLESv2/Context.cpp:

(gl::Context::Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::markContextLost):
(gl::Context::isContextLost):
(gl::Context::setPackReverseRowOrder):
(gl::Context::getPackReverseRowOrder):
(gl::Context::deleteProgram):
(gl::Context::getDrawFramebuffer):
(gl::Context::bindDrawFramebuffer):
(gl::Context::useProgram):
(gl::Context::setFramebufferZero):
(gl::Context::getCurrentProgram):
(gl::Context::getBooleanv):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawClosingLine):
(gl::Context::getResetStatus):
(gl::Context::isResetNotificationEnabled):
(gl::Context::supportsDXT1Textures):
(gl::Context::supportsDXT3Textures):
(gl::Context::supportsDXT5Textures):
(gl::Context::supportsFloat32Textures):
(gl::Context::supportsFloat32LinearFilter):
(gl::Context::supportsFloat32RenderableTextures):
(gl::Context::supportsFloat16Textures):
(gl::Context::supportsFloat16LinearFilter):
(gl::Context::supportsFloat16RenderableTextures):
(gl::Context::initExtensionString):
(gl::Context::initRendererString):
(gl::Context::getRendererString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):

  • src/libGLESv2/Context.h:
  • src/libGLESv2/Fence.cpp:

(gl::Fence::testFence):
(gl::Fence::getFenceiv):

  • src/libGLESv2/Framebuffer.cpp:

(gl::Framebuffer::setColorbuffer):
(gl::Framebuffer::setDepthbuffer):
(gl::Framebuffer::setStencilbuffer):
(gl::Framebuffer::getColorbuffer):
(gl::Framebuffer::getDepthbuffer):
(gl::Framebuffer::getStencilbuffer):
(gl::Framebuffer::hasStencil):
(gl::Framebuffer::completeness):
(gl::DefaultFramebuffer::DefaultFramebuffer):

  • src/libGLESv2/Framebuffer.h:
  • src/libGLESv2/IndexDataManager.cpp:

(gl::IndexDataManager::prepareIndexData):
(gl::IndexBuffer::IndexBuffer):
(gl::IndexBuffer::getSerial):
(gl::IndexBuffer::issueSerial):
(gl::StreamingIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::lookupRange):
(gl::StaticIndexBuffer::addRange):

  • src/libGLESv2/IndexDataManager.h:

(gl::StaticIndexBuffer::IndexRange::operator<):

  • src/libGLESv2/Program.cpp:

(gl::Uniform::Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::Program::Program):
(gl::Program::detachShader):
(gl::Program::getUsedSamplerRange):
(gl::Program::getSamplerMapping):
(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::transposeMatrix):
(gl::Program::setUniformMatrix2fv):
(gl::Program::setUniformMatrix3fv):
(gl::Program::setUniformMatrix4fv):
(gl::Program::getUniformfv):
(gl::Program::getUniformiv):
(gl::Program::applyUniforms):
(gl::Program::compileToBinary):
(gl::Program::linkVaryings):
(gl::Program::link):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::decorateAttribute):
(gl::Program::undecorateUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniformnfv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::applyUniformniv):
(gl::Program::appendToInfoLogSanitized):
(gl::Program::unlink):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validateSamplers):
(gl::Program::initializeConstantHandles):
(gl::Program::getDxCoordLocation):

  • src/libGLESv2/Program.h:
  • src/libGLESv2/Renderbuffer.cpp:

(gl::RenderbufferInterface::RenderbufferInterface):
(gl::RenderbufferInterface::getRedSize):
(gl::RenderbufferInterface::getGreenSize):
(gl::RenderbufferInterface::getBlueSize):
(gl::RenderbufferInterface::getAlphaSize):
(gl::RenderbufferInterface::getDepthSize):
(gl::RenderbufferInterface::getStencilSize):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::getRenderTarget):
(gl::RenderbufferTexture::getDepthStencil):
(gl::RenderbufferTexture::getWidth):
(gl::RenderbufferTexture::getHeight):
(gl::RenderbufferTexture::getInternalFormat):
(gl::RenderbufferTexture::getD3DFormat):
(gl::RenderbufferTexture::getSamples):
(gl::RenderbufferTexture::getSerial):
(gl::Renderbuffer::Renderbuffer):
(gl::Renderbuffer::~Renderbuffer):
(gl::Renderbuffer::getRenderTarget):
(gl::Renderbuffer::getDepthStencil):
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getInternalFormat):
(gl::Renderbuffer::getD3DFormat):
(gl::Renderbuffer::getRedSize):
(gl::Renderbuffer::getGreenSize):
(gl::Renderbuffer::getBlueSize):
(gl::Renderbuffer::getAlphaSize):
(gl::Renderbuffer::getDepthSize):
(gl::Renderbuffer::getStencilSize):
(gl::Renderbuffer::getSamples):
(gl::Renderbuffer::getSerial):
(gl::Renderbuffer::setStorage):
(gl::RenderbufferStorage::getD3DFormat):
(gl::RenderbufferStorage::issueCubeSerials):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::getRenderTarget):
(gl::Depthbuffer::Depthbuffer):
(gl::Stencilbuffer::Stencilbuffer):

  • src/libGLESv2/Renderbuffer.h:

(gl::RenderbufferInterface::~RenderbufferInterface):

  • src/libGLESv2/Shader.cpp:

(gl::Shader::getTranslatedSourceLength):
(gl::Shader::getSourceImpl):
(gl::Shader::getSource):
(gl::Shader::getTranslatedSource):

  • src/libGLESv2/Shader.h:
  • src/libGLESv2/Texture.cpp:

(gl::ConvertTextureFormatType):
(gl::IsTextureFormatRenderable):
(gl::Image::Image):
(gl::Image::~Image):
(gl::Image::redefine):
(gl::Image::createSurface):
(gl::Image::lock):
(gl::Image::unlock):
(gl::Image::isRenderableFormat):
(gl::Image::getD3DFormat):
(gl::Image::getSurface):
(gl::Image::setManagedSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::FlipCopyDXT1BlockFull):
(gl::FlipCopyDXT1BlockHalf):
(gl::FlipCopyDXT3BlockFull):
(gl::FlipCopyDXT3BlockHalf):
(gl::FlipCopyDXT5BlockFull):
(gl::FlipCopyDXT5BlockHalf):
(gl::Image::loadDXT1Data):
(gl::Image::loadDXT3Data):
(gl::Image::loadDXT5Data):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::~TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::isManaged):
(gl::TextureStorage::getPool):
(gl::TextureStorage::getTextureSerial):
(gl::TextureStorage::issueTextureSerial):
(gl::Texture::Texture):
(gl::Texture::~Texture):
(gl::Texture::setMinFilter):
(gl::Texture::setMagFilter):
(gl::Texture::setWrapS):
(gl::Texture::setWrapT):
(gl::Texture::setUsage):
(gl::Texture::getMinFilter):
(gl::Texture::getMagFilter):
(gl::Texture::getWrapS):
(gl::Texture::getWrapT):
(gl::Texture::getUsage):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture::getTexture):
(gl::Texture::hasDirtyParameters):
(gl::Texture::hasDirtyImages):
(gl::Texture::resetDirty):
(gl::Texture::getTextureSerial):
(gl::Texture::getRenderTargetSerial):
(gl::Texture::isImmutable):
(gl::Texture::creationLevels):
(gl::Texture::getBlitter):
(gl::Texture::copyToRenderTarget):
(gl::TextureStorage2D::TextureStorage2D):
(gl::TextureStorage2D::~TextureStorage2D):
(gl::TextureStorage2D::getSurfaceLevel):
(gl::TextureStorage2D::getBaseTexture):
(gl::TextureStorage2D::getRenderTargetSerial):
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl::Texture2D::getWidth):
(gl::Texture2D::getHeight):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getType):
(gl::Texture2D::redefineImage):
(gl::Texture2D::setImage):
(gl::Texture2D::bindTexImage):
(gl::Texture2D::releaseTexImage):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::commitRect):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isMipmapComplete):
(gl::Texture2D::getBaseTexture):
(gl::Texture2D::createTexture):
(gl::Texture2D::updateTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::generateMipmaps):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getStorage):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureStorageCubeMap::~TextureStorageCubeMap):
(gl::TextureStorageCubeMap::getCubeMapSurface):
(gl::TextureStorageCubeMap::getBaseTexture):
(gl::TextureStorageCubeMap::getRenderTargetSerial):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getType):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::commitRect):
(gl::TextureCubeMap::subImage):
(gl::TextureCubeMap::subImageCompressed):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCubeComplete):
(gl::TextureCubeMap::isMipmapCubeComplete):
(gl::TextureCubeMap::getBaseTexture):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::updateTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::setImage):
(gl::TextureCubeMap::redefineImage):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::generateMipmaps):
(gl::TextureCubeMap::getRenderbuffer):
(gl::TextureCubeMap::getRenderTarget):
(gl::TextureCubeMap::getStorage):

  • src/libGLESv2/Texture.h:

(gl::Image::markDirty):
(gl::Image::markClean):
(gl::Image::getWidth):
(gl::Image::getHeight):
(gl::Image::getFormat):
(gl::Image::getType):
(gl::Image::isDirty):

  • src/libGLESv2/VertexDataManager.cpp:

(gl::elementsInBuffer):
(gl::VertexDataManager::VertexDataManager):
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexBuffer::VertexBuffer):
(gl::VertexBuffer::getSerial):
(gl::VertexBuffer::issueSerial):
(gl::StreamingVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::map):
(gl::StaticVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::lookupAttribute):

  • src/libGLESv2/VertexDataManager.h:

(gl::ArrayVertexBuffer::size):

  • src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
  • src/libGLESv2/geometry/IndexDataManager.h: Removed.
  • src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
  • src/libGLESv2/geometry/VertexDataManager.h: Removed.
  • src/libGLESv2/geometry/vertexconversion.h: Removed.
  • src/libGLESv2/libGLESv2.cpp:

(validateSubImageParams):
(validReadFormatType):
(Extension::glBindTexImage):

  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.rc:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/main.cpp:

(gl::getNonLostContext):
(gl::checkDeviceLost):

  • src/libGLESv2/main.h:
  • src/libGLESv2/utilities.cpp:

(gl::UniformExternalComponentCount):
(gl::UniformInternalComponentCount):
(gl::UniformComponentSize):
(gl::UniformInternalSize):
(gl::UniformExternalSize):
(gl::ComputeCompressedSize):
(gl::IsCompressed):
(gl::ExtractFormat):
(gl::ExtractType):
(dx2es::IsFloat32Format):
(dx2es::IsFloat16Format):

  • src/libGLESv2/utilities.h:

(isDeviceLostError):

17:23 Changeset [104362] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
https://bugs.webkit.org/show_bug.cgi?id=75734

Reviewed by Daniel Bates.

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::addProperty): use HashMap::add() to avoid an
extra hash lookup to set a new PropertiesVector.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • svg/properties/SVGAttributeToPropertyMap.h:
17:22 Changeset [104361] by dslomov@google.com
  • 112 edits
    4 copies
    13 moves
    97 adds
    83 deletes in trunk/LayoutTests

Unreviewed: more rebaselines in chromium after r104240.

  • platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-cg-mac/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-cg-mac/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-cg-mac/fast/dom/isindex-001-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/minWidthPercent-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png.
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4895428-3-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-mac/fast/css/line-height-expected.png: Removed.
  • platform/chromium-mac/fast/dom/isindex-001-expected.png: Removed.
  • platform/chromium-mac/fast/dom/isindex-002-expected.png: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-mac/fast/forms/encoding-test-expected.png: Removed.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png: Removed.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-spaces-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-table-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Removed.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium/fast/block/float/032-expected.png: Added.
  • platform/chromium/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.txt.
  • platform/chromium/fast/forms/input-width-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png.
  • platform/chromium/fast/forms/minWidthPercent-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/fieldset-align-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-table-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt: Renamed from LayoutTests/editing/input/caret-at-the-edge-of-input-expected.txt.
17:02 Changeset [104360] by simon.fraser@apple.com
  • 2 edits in trunk/Tools

Fix DRT build on case-sensitive file systems.

Fix case of include of WebDynamicScrollBarsView.h

  • DumpRenderTree/mac/DumpRenderTree.mm:
16:54 Changeset [104359] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=75296
JSString should not have JS_EXPORTCLASS annotation

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

  • runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Added missing symbols which were hidden by JS_EXPORTCLASS.

16:53 Changeset [104358] by abarth@webkit.org
  • 13 edits
    7 adds in trunk

Source/WebCore: WebCore implementation of the Intent object
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
for draft spec.

https://bugs.webkit.org/show_bug.cgi?id=73051

Patch by Greg Billock <gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.

Test: web-intents/web-intents-api.html

  • WebCore.gypi:
  • page/DOMWindow.idl:
  • Modules/intents/Intent.cpp: Added.

(WebCore::Intent::Intent):
(WebCore::Intent::action):
(WebCore::Intent::setAction):
(WebCore::Intent::type):
(WebCore::Intent::setType):
(WebCore::Intent::data):
(WebCore::Intent::setData):
(WebCore::Intent::create):

  • Modules/intents/Intent.h: Added.
  • Modules/intents/Intent.idl: Added.

Source/WebKit/chromium: [Web Intents] Flagged-off WebCore implementation of navigator.startActivity
https://bugs.webkit.org/show_bug.cgi?id=73051

Patch by Greg Billock <gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.

  • features.gypi:
16:49 Changeset [104357] by eae@chromium.org
  • 4 edits in branches/subpixellayout

Fix overflow in SpatialNavigation::distanceDataForNode.

16:29 Changeset [104356] by timothy_horton@apple.com
  • 5 edits
    3 adds in trunk

[cg] userSpaceOnUse SVG Patterns have the wrong origin
https://bugs.webkit.org/show_bug.cgi?id=75741
<rdar://problem/9383222>

Reviewed by Simon Fraser.

The transformation from pattern space to user space should use the userToBase CTM,
not the current CTM.

Test: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::getCTM):

  • platform/graphics/cg/TransformationMatrixCG.cpp:

(WebCore::AffineTransform::AffineTransform): Add a AffineTransform(CGAffineTransform) constructor

  • platform/graphics/transforms/AffineTransform.h:

Add a test that ensures that userSpaceOnUse patterns are rendered in the
correct orientation and location in both the accelerated compositing and
regular cases, as well as with SVG translation.

  • platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml: Added.
16:27 Changeset [104355] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSArray::pop() should compare SparseArrayValueMap::find() to SparseArrayValueMap::notFound()
https://bugs.webkit.org/show_bug.cgi?id=75757

Reviewed by Gavin Barraclough.

  • runtime/JSArray.cpp:

(JSC::JSArray::pop): Changed map->end() to map->notFound().

16:14 Changeset [104354] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

[chromium] Rebaseline media/media-document-audio-repaint after 74123 goes in.
https://bugs.webkit.org/show_bug.cgi?id=75505

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Dimitri Glazkov.

  • platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-cg-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium/test_expectations.txt:
15:41 Changeset [104353] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests/platform/chromium/fast/events/intercept-postmessage.html failing
https://bugs.webkit.org/show_bug.cgi?id=75718

Patch by Charlie Reis <creis@chromium.org> on 2012-01-06
Reviewed by Adam Barth.

Removing unnecessary log messages.

  • platform/chromium/fast/events/intercept-postmessage-expected.txt:
  • platform/chromium/fast/events/intercept-postmessage.html:
15:39 Changeset [104352] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

Avoid falling into tiled layers more often when the device scale factor is > 1
<rdar://problem/10588725>

Source/WebCore:

Reviewed by John Sullivan.

Stop taking the device scale factor into account when deciding to make
tiled layers.

Test: compositing/tiled-layers-hidpi.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer):

LayoutTests:

Reviewed by John Sullivan.

Tests that a large layer with a device scale factor of 2 is not tiled.

  • compositing/tiled-layers-hidpi-expected.txt: Added.
  • compositing/tiled-layers-hidpi.html: Added.
15:34 Changeset [104351] by simon.fraser@apple.com
  • 6 edits in trunk/Tools

Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=75662

Reviewed by Dan Bernstein.

The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
of color profile issues. Fix by keeping everything in device RGB and ensuring that the
test window uses the main display's color space, so that the pixel values in the bitmap
that gets checksummed are identical to the CSS colors.

Removed the code that switches the display profile in DRT, since that is no longer required.

  • DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(crashHandler): Remove code that switches display profiles.
(prepareConsistentTestingEnvironment): Ditto.
(dumpRenderTree): Ditto.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.

(createBitmapContext): Use DeviceRGB for the bitmap colorspace.
(createBitmapContextFromWebView): Add comment about the colorspace handling.

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage): Use a RetainPtr, add comment.
(WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
(WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.

15:28 Changeset [104350] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Touch a bunch of files in an attempt to fix Mac release builds.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):

  • accessibility/AccessibilityAllInOne.cpp:
  • editing/visible_units.cpp:

(WebCore::previousBoundary):

15:20 Changeset [104349] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

JIT stub slow paths that would be identical to that of an interpreter should be factored out
https://bugs.webkit.org/show_bug.cgi?id=75743
<rdar://problem/10657024>

Reviewed by Geoff Garen.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/CommonSlowPaths.h: Added.

(JSC::CommonSlowPaths::opInstanceOfSlow):
(JSC::CommonSlowPaths::opIn):
(JSC::CommonSlowPaths::opResolve):
(JSC::CommonSlowPaths::opResolveSkip):
(JSC::CommonSlowPaths::opResolveWithBase):
(JSC::CommonSlowPaths::opResolveWithThis):

15:16 Changeset [104348] by eae@chromium.org
  • 21 edits in branches/subpixellayout

Fix scrollbar toggling to compare pixel snapped values and update relevant test expectations.

15:13 Changeset [104347] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source/WebCore

Enable a compositing trigger for filters
https://bugs.webkit.org/show_bug.cgi?id=75658

This will enable forcing the compositing code path when filters exist for a RenderObject.

Reviewed by Simon Fraser.

No new functionality so no new tests.

  • page/ChromeClient.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):

  • rendering/RenderLayerCompositor.h:
15:01 Changeset [104346] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline editing/input/caret-at-the-edge-of-input.html.

  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
14:58 Changeset [104345] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add and use ScrollElasticityControllerClient::absoluteScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=75744

Reviewed by Dan Bernstein.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::absoluteScrollPosition):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
14:54 Changeset [104344] by abarth@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Move FrameDestructionObserver to its own file
https://bugs.webkit.org/show_bug.cgi?id=75693

Reviewed by Eric Seidel.

We should have one class per file, on general principles. Also, this
make it possible to use this class in DOMWindow without introducing a
circular include dependency.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FrameDestructionObserver.cpp: Added.

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):

  • page/FrameDestructionObserver.h: Added.

(WebCore::FrameDestructionObserver::frame):

  • plugins/DOMMimeType.h:
  • plugins/DOMPlugin.h:
14:46 Changeset [104343] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

run-api-tests: specify individual suites and tests on the command-line

Reviewed by Adam Roben.

Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

The run-api-tests script will now accept a list of arguments on
the command-line that are used as prefix filters. To run all
tests in a suite that starts with "WTF" (WTF and WTF_Vector)
use:

$ run-api-tests WTF

To run only the tests in the "WTF" suite, not the "WTF_Vector"
suite, use:

$ run-api-tests WTF.

  • Scripts/run-api-tests: Filter tests if any prefix arguments

are passed on the command-line.

14:46 Changeset [104342] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings

Reviewed by Adam Roben.

Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

  • Scripts/run-api-tests:

(dumpTestsBySuite): Update to accept array of tests instead of
hash data structure.
(runTestsBySuite): Ditto.
(listAllTests): Rename from populateTests(). Update to return
an array of tests instad of the hash data structure.

14:27 Changeset [104341] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Snow Leopard build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollBy):
Move the function definition inside #if ENABLE(RUBBER_BANDING).

14:27 Changeset [104340] by dpranke@chromium.org
  • 10 edits
    1 add in trunk/Tools

webkitpy: clean up test/uri conversion routines
https://bugs.webkit.org/show_bug.cgi?id=75648

Reviewed by Eric Seidel.

This change moves test_to_uri and uri_to_test from the Port
class to the Driver class (the routines were only being
called by the drivers), and removes a bunch of stale and/or
busted logic.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/driver.py:

(is_http_test):
(test_to_uri):
(uri_to_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(run_one_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.input_line):
(input_line):
(expected_output):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(_command_from_driver_input):

14:22 Changeset [104339] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

  • wtf/TypeTraits.cpp:
14:15 Changeset [104338] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Default HashTraits for Opcode don't work for Opcode = 0
https://bugs.webkit.org/show_bug.cgi?id=75595

Reviewed by Oliver Hunt.

Removed the populating of the m_opcodeIDTable table in the
case where the OpcodeID and Opcode are the same (m_enabled is false).
Instead we just cast the one type to the other.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):

14:14 Changeset [104337] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104330.

14:13 Changeset [104336] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed https://bugs.webkit.org/show_bug.cgi?id=75742
and updated chromium-mac expectations for fast/forms/input-disabled-color.html.

  • platform/chromium/test_expectations.txt:
14:08 Changeset [104335] by andersca@apple.com
  • 2 edits in trunk/Source/ThirdParty

Make JavaScriptCore.framework a reference and put it in a Frameworks group
https://bugs.webkit.org/show_bug.cgi?id=75740

Reviewed by Mark Rowe.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
14:01 Changeset [104334] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Thread verifier assertions when printing
https://bugs.webkit.org/show_bug.cgi?id=75738

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView dealloc]): Dealloc in main thread, so that WebFrameProxy doesn't get deref'ed from a secondary one. (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): This method calls out to client, which only expects that on main thread. (-[WKPrintingView knowsPageRange:]): Call _adjustPrintingMarginsForHeaderAndFooter on main thread.
13:57 Changeset [104333] by weinig@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a DecayArray type trait as a first step towards merging OwnPtr and OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=75737

Reviewed by Anders Carlsson.

  • wtf/TypeTraits.cpp:
  • wtf/TypeTraits.h:

Added a DecayArray trait, that can convert T[] and T[3] -> T*. DecayArray
is composed of some helpers which are also exposed, Conditional<>, which
can provide one type or another based on a boolean predicate, IsArray<>
which can deduce array types, and RemoveExtent<>, which removes the extent
from an array type.

13:55 Changeset [104332] by jonlee@apple.com
  • 3 edits
    1 add in trunk

Clicking on the cancel button on readonly and disabled search fields darkens as if the search field was editable
https://bugs.webkit.org/show_bug.cgi?id=69886
<rdar://problem/10070187>

Reviewed by Adele Peterson.

.:

  • ManualTests/search-cancel-button.html: Added.

Source/WebCore:

Tests: ManualTests/search-cancel-button.html

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton): If the input is readonly and/or disabled, force the cell to
render without highlight.

13:44 Changeset [104331] by simon.fraser@apple.com
  • 8 edits in trunk

Mitigate scrollbar differences when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=67217

Source/WebCore:

Reviewed by Dan Bernstein.

Export WebCore::Settings::mockScrollbarsEnabled() for DRT.

  • WebCore.exp.in:

Source/WebKit/mac:

Reviewed by Dan Bernstein.

Make it possible to register a custom NSScroller class, which
the WebDynamicScrollBarsView will use when mock scrollbars are enabled.

Also ensure that the WebPreferences mock scrollbars preference is
migrated into Settings.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(+[WebDynamicScrollBarsView _horizontalScrollerClass]):
(+[WebDynamicScrollBarsView _verticalScrollerClass]):
(+[WebDynamicScrollBarsView setCustomScrollerClass:]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Reviewed by Dan Bernstein.

Add an NSScroller subclass that draws mock scrollbars identically
to the WebCore mock scrollbar theme, and register it with the
WebDynamicScrollbarsView.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(-[DRTMockScroller rectForPart:]):
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
(registerMockScrollbars):
(prepareConsistentTestingEnvironment):

13:19 Changeset [104330] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

GetByteArrayLength is incorrect
https://bugs.webkit.org/show_bug.cgi?id=75735

Reviewed by Filip Pizlo.

Load the byte array length from the correct location.
This stops an existing test from hanging.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:18 Changeset [104329] by tsepez@chromium.org
  • 22 edits
    10 adds in trunk

Source/WebCore: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

Tests: http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html

http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html
http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html
http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html

  • page/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::policy):
(WebCore::ContentSecurityPolicy::headerType):

  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):

  • workers/DedicatedWorkerContext.h:

(WebCore::DedicatedWorkerContext::create):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::SharedWorkerContext):

  • workers/SharedWorkerContext.h:

(WebCore::SharedWorkerContext::create):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):

  • workers/SharedWorkerThread.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

Source/WebKit/chromium: Pass Content-security-policy directive to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::startWorkerContext):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

  • http/tests/security/contentSecurityPolicy/resources/shared-worker-make-xhr.js: Added.

(onconnect):

  • http/tests/security/contentSecurityPolicy/resources/worker-make-xhr.js: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html: Added.
  • platform/chromium/test_expectations.txt:
13:15 Changeset [104328] by mihnea@adobe.com
  • 4 edits
    6 adds in trunk

[CSSRegions]Crash while collecting svg elements in render flow thread.
https://bugs.webkit.org/show_bug.cgi?id=73735

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/svg-doc-fragment-not-collected-expected.html

fast/regions/svg-doc-fragment-not-collected.html
fast/regions/svg-element-not-collected-expected.html
fast/regions/svg-element-not-collected.html
fast/regions/svg-root-element-collected.html

By allowing only svg root elements to be collected in a render flow thread,
the svg render tree is properly constructed, thus prevented a possible further crash.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

LayoutTests:

  • fast/regions/resources/region-style.css:
  • fast/regions/svg-doc-fragment-not-collected-expected.html: Added.
  • fast/regions/svg-doc-fragment-not-collected.html: Added.
  • fast/regions/svg-element-not-collected-expected.html: Added.
  • fast/regions/svg-element-not-collected.html: Added.
  • fast/regions/svg-root-element-collected-expected.txt: Added.
  • fast/regions/svg-root-element-collected.html: Added.
13:12 Changeset [104327] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

Make TextTrackCue more mutable
https://bugs.webkit.org/show_bug.cgi?id=72555

Reviewed by Anders Carlsson.

Source/WebCore:

Test: media/track/track-cue-mutable.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Do nothing if the "ignore cue updates"

flag is set

(WebCore::HTMLMediaElement::textTrackAddCues): Block cue updates until all of the new cues have

been added, then call updateActiveTextTrackCues so update the display if necessary.

(WebCore::HTMLMediaElement::textTrackRemoveCues): Block cue updates until all of the new cues have

been removed, then call updateActiveTextTrackCues so update the display if necessary.

(WebCore::HTMLMediaElement::textTrackAddCue): Call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):

  • html/TextTrack.cpp:

(WebCore::TextTrack::cueWillChange): New, remove the cue from the media element because its

position in the interval tree is based on start and end times.

(WebCore::TextTrack::cueDidChange): Add the cue to the media element.

  • html/TextTrack.h:
  • html/TextTrackCue.cpp:

(WebCore::startKeyword): New, use a static String for the constant.
(WebCore::middleKeyword): Ditto.
(WebCore::endKeyword): Ditto.
(WebCore::horizontalKeyword): Ditto.
(WebCore::verticalKeyword): Ditto.
(WebCore::verticallrKeyword): Ditto.
(WebCore::TextTrackCue::cueWillChange): New, tell the track the cue is about to change.
(WebCore::TextTrackCue::cueDidChange): New, tell the track the cue has changed.
(WebCore::TextTrackCue::setId): New, attribute is mutable.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::direction): Ditto.
(WebCore::TextTrackCue::setDirection): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLinePosition): Ditto.
(WebCore::TextTrackCue::setTextPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::alignment): Ditto.
(WebCore::TextTrackCue::setAlignment): Ditto.
(WebCore::TextTrackCue::parseSettings): Use the static strings.

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::id):
(WebCore::TextTrackCue::startTime):
(WebCore::TextTrackCue::endTime):
(WebCore::TextTrackCue::pauseOnExit):

  • html/TextTrackCue.idl:

LayoutTests:

  • media/track/track-cue-mutable-expected.txt: Added.
  • media/track/track-cue-mutable.html: Added.
12:44 Changeset [104326] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build.

12:44 Changeset [104325] by eae@chromium.org
  • 23 edits in branches/subpixellayout/LayoutTests/platform/mac/tables

Update mac test expectations for table tests

12:38 Changeset [104324] by oliver@apple.com
  • 4 edits in trunk/Source

DFG no longer optimises CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=75729

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Rename ByteArray (in its ClassInfo) to Uint8ClampedArray to match
the future name when we switch over to the new typed-array based
ImageData specification.

  • runtime/JSByteArray.cpp:

Source/WebCore:

Remove the custom ClassInfo for CanvasPixelArray as that is
defeating ByteArray optimisation, and is no longer needed
anyway as it was only there to change the visible name.

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

12:31 Changeset [104323] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

[Mac] Sort the resources of WTF.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75639

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WTF.xcodeproj/project.pbxproj:
12:30 Changeset [104322] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERT failure due to combine-text with preceding spaces
https://bugs.webkit.org/show_bug.cgi?id=65147

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-06
Reviewed by David Hyatt.

Source/WebCore:

A couple of ASSERTs were failing due to a parsing problem when
advancing an inline iterator to the next linebreak in a
RenderCombineText. skipLeadingWhitespace advances the iterator
over leading whitespace but when searching for the line break
nextLineBreak would call RenderCombineText::combineText(),
collapsing the text so that the iterator is pointing past the
end of it.

This patch causes combineText() to be called during
skipLeadingWhiteSpace before iteration over the RenderCombineText
begins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

New test with combine-text that begins with mutiple spaces,
showing ASSERT failures in bug 65147.

  • fast/text/international/spaces-combined-in-vertical-text.html: Added
  • fast/text/international/spaces-combined-in-vertical-text-expected.txt: Added
12:25 Changeset [104321] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make ScrollAnimatorMac::snapRubberBandTimerFired use m_scrollElasticityController in more places
https://bugs.webkit.org/show_bug.cgi?id=75726

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::canScrollHorizontally):
(WebCore::ScrollAnimatorMac::canScrollVertically):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
12:22 Changeset [104320] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit1 fails to compile with USE(CFNETWORK) and HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=75675

Reviewed by Oliver Hunt.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willCacheResponse):

12:21 Changeset [104319] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Need to allow SCNetworkReachability service in sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=75724
<rdar://problem/10652415>

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
12:20 Changeset [104318] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for SourceProviderCache items
https://bugs.webkit.org/show_bug.cgi?id=75346

Reviewed by Daniel Bates.

  • parser/Parser.cpp:
  • parser/SourceProviderCache.cpp:

(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):

  • parser/SourceProviderCache.h:
12:15 Changeset [104317] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash with range selection across different documents.
https://bugs.webkit.org/show_bug.cgi?id=74285

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/Range/range-selection-across-documents-crash.html

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange):

LayoutTests:

  • fast/dom/Range/range-selection-across-documents-crash-expected.txt: Added.
  • fast/dom/Range/range-selection-across-documents-crash.html: Added.
12:12 Changeset [104316] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; fixing expectation error.

  • platform/chromium/test_expectations.txt:
12:09 Changeset [104315] by weinig@apple.com
  • 11 edits
    3 deletes in trunk/Source

Remove unused OwnFastMallocPtr class.
https://bugs.webkit.org/show_bug.cgi?id=75722

Reviewed by Geoffrey Garen.

../JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/OwnFastMallocPtr.h: Removed.
  • wtf/text/StringImpl.h:
  • wtf/wtf.pro:

../JavaScriptGlue:

  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.

../WebCore:

  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
12:07 Changeset [104314] by commit-queue@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

Convert overflow-in-uniform-regions to a reftest
https://bugs.webkit.org/show_bug.cgi?id=74765

Replaced the bitmap version of the test with a "reftest" version. Use of text
has been revised a little to mitigate the possibility that small differences in
the platform's default font will change the location of line breaks.

Patch by Hans Muller <hmuller@adobe.com> on 2012-01-06
Reviewed by Anders Carlsson.

  • fast/regions/overflow-in-uniform-regions-expected.html: Added.
  • fast/regions/overflow-in-uniform-regions.html:
  • platform/efl/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
12:05 Changeset [104313] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Need to relayout when stretching the height of a flex item
https://bugs.webkit.org/show_bug.cgi?id=75661

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/flex-align-stretch.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Always clear the override size since
it may be set when aligning.
(WebCore::RenderFlexibleBox::alignChildren): Only relayout if the height changed.

LayoutTests:

  • css3/flexbox/flex-align-stretch-expected.txt: Added.
  • css3/flexbox/flex-align-stretch.html: Added.
12:01 Changeset [104312] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add ScrollElasticityControllerClient::immediateScrollBy
https://bugs.webkit.org/show_bug.cgi?id=75720

Reviewed by Andreas Kling.

Add a new ScrollElasticityControllerClient::immediateScrollBy client member function.
Also, make ScrollAnimatorMac::smoothScrollWithEvent calls go through the ScrollElasticityController
in preparation for moving that function to ScrollElasticityController.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/ScrollElasticityController.h:
12:00 Changeset [104311] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Sort the resources of WebKit2.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75636

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WebKit2.xcodeproj/project.pbxproj:
11:53 Changeset [104310] by dgrogan@chromium.org
  • 2 edits
    2 copies in branches/chromium/963

Merge 104252 - Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.

  • storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

  • storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
  • storage/indexeddb/prefetch-bugfix-108071.html: Added.

TBR=dgrogan@chromium.org
Review URL: http://codereview.chromium.org/9121008

11:52 Changeset [104309] by dslomov@google.com
  • 51 edits
    3 copies
    82 adds in trunk/LayoutTests

2012-01-06 Dmitry Lomov <dslomov@google.com>

Unreviewed: [Chromium] rebaselining IMAGE expectations after http://trac.webkit.org/changeset/104240/

  • platform/chromium-cg-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-cg-mac-leopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-cg-mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png.
11:51 Changeset [104308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
https://bugs.webkit.org/show_bug.cgi?id=75334

Patch by Wei James <james.wei@intel.com> on 2012-01-06
Reviewed by Kenneth Russell.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo):

11:47 Changeset [104307] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit

[Mac] Sort the resources of WebKit.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75634

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WebKit.xcodeproj/project.pbxproj:
11:38 Changeset [104306] by jer.noble@apple.com
  • 4 edits in trunk

Fullscreen video controller can't be dragged the first time I enter fullscreen
https://bugs.webkit.org/show_bug.cgi?id=75709

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated video-controls-drag.html.

When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaControls):

LayoutTests:

Update the test to cover the case where the controls do not yet exist when entering
fullscreen.

  • fullscreen/video-controls-drag.html:
11:30 Changeset [104305] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests

Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.

Unreviewed.

  • platform/mac/test_expectations.txt:
11:21 Changeset [104304] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
https://bugs.webkit.org/show_bug.cgi?id=75631

Patch by Benjamin Poulain <bpoulain@webkit.org> on 2012-01-06
Reviewed by Andreas Kling.

11:13 Changeset [104303] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

Media Element: scrubbing in full-screen mode breaks playback.
https://bugs.webkit.org/show_bug.cgi?id=75650

Reviewed by John Sullivan.

Source/WebCore:

Test: fullscreen/video-controls-timeline.html

Only begin scrubbing if the panel itself is the mousedown event target.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::defaultEventHandler):

LayoutTests:

  • fullscreen/video-controls-timeline-expected.txt: Added.
  • fullscreen/video-controls-timeline.html: Added.
11:03 Changeset [104302] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Add new (failing) test to Chromium test_expectations. Fix tracked by
https://bugs.webkit.org/show_bug.cgi?id=75716

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt:
10:28 Changeset [104301] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally
https://bugs.webkit.org/show_bug.cgi?id=75200

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/video-controls-drag.html

The !important rules in fullscreenQuickTime.css are overriding the styles added by the
drag operation in MediaControlElements.cpp. Give the panel a "dragged" class in setPosition
(clearing it in resetPosition) that allows the !important rules to apply only when the
panel is not dragged.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-panel:not(.dragged)):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):

LayoutTests:

  • fullscreen/video-controls-drag-expected.txt: Added.
  • fullscreen/video-controls-drag.html: Added.
10:06 Changeset [104300] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove fast/files/domurl-script-execution-context-crash.html
from test_expectations (no longer crashing).

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt:
09:50 Changeset [104299] by jonlee@apple.com
  • 54 edits
    45 copies
    47 adds in trunk

Tools: Update DRT on Mac to draw resize handles on text areas.

Reviewed by John Sullivan.

Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
between WK1 and WK2. This will require rebaselining existing textarea pixel tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests: Rebaseline fast/forms
Rebaseline pixel tests involving textarea.

Reviewed by John Sullivan.

Moved from mac to mac-snowleopard:

  • platform/mac-snowleopard/fast/forms/001
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04
  • platform/mac-snowleopard/fast/forms/basic-buttons-expected
  • platform/mac-snowleopard/fast/forms/basic-inputs-expected
  • platform/mac-snowleopard/fast/forms/basic-selects-expected
  • platform/mac-snowleopard/fast/forms/basic-textareas-expected
  • platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected
  • platform/mac-snowleopard/fast/forms/box-shadow-override
  • platform/mac-snowleopard/fast/forms/button-align
  • platform/mac-snowleopard/fast/forms/button-generated-content
  • platform/mac-snowleopard/fast/forms/button-sizes
  • platform/mac-snowleopard/fast/forms/button-style-color
  • platform/mac-snowleopard/fast/forms/button-table-styles
  • platform/mac-snowleopard/fast/forms/button-text-transform
  • platform/mac-snowleopard/fast/forms/button-white-space
  • platform/mac-snowleopard/fast/forms/control-restrict-line-height
  • platform/mac-snowleopard/fast/forms/disabled-select-change-index
  • platform/mac-snowleopard/fast/forms/fieldset-align
  • platform/mac-snowleopard/fast/forms/file/file-input-direction
  • platform/mac-snowleopard/fast/forms/form-element-geometry
  • platform/mac-snowleopard/fast/forms/form-hides-table
  • platform/mac-snowleopard/fast/forms/input-appearance-height
  • platform/mac-snowleopard/fast/forms/input-button-sizes
  • platform/mac-snowleopard/fast/forms/input-table
  • platform/mac-snowleopard/fast/forms/input-value
  • platform/mac-snowleopard/fast/forms/menulist-style-color
  • platform/mac-snowleopard/fast/forms/option-strip-whitespace
  • platform/mac-snowleopard/fast/forms/placeholder-position
  • platform/mac-snowleopard/fast/forms/radio_checked
  • platform/mac-snowleopard/fast/forms/radio_checked_dynamic
  • platform/mac-snowleopard/fast/forms/range/slider-padding
  • platform/mac-snowleopard/fast/forms/select-align
  • platform/mac-snowleopard/fast/forms/select-baseline-expected
  • platform/mac-snowleopard/fast/forms/select-disabled-appearance
  • platform/mac-snowleopard/fast/forms/select-initial-position
  • platform/mac-snowleopard/fast/forms/select-style
  • platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected
  • platform/mac-snowleopard/fast/forms/textAreaLineHeight
  • platform/mac-snowleopard/fast/forms/textarea-align
  • platform/mac-snowleopard/fast/forms/textarea-scroll-height
  • platform/mac-snowleopard/fast/forms/textarea-width
  • platform/mac-snowleopard/fast/overflow/overflow-x-y

New pixel test results:

  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/menulist-style-color-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/radio_checked-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/forms/range/slider-padding-expected.png:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-disabled-appearance-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:

Added new results:

  • platform/mac/fast/forms/selectlist-minsize-expected.png: Added. Needs Snow Leopard baseline.
  • platform/mac/fast/forms/basic-selects-expected.txt: Rebaseline since fix of bug 74270.
  • platform/mac/fast/forms/listbox-clip-expected.png: Fix was made to have default # of options in list box to 4, instead of 5. Needed

brand new baseline, and so does Snow Leopard.

  • platform/mac/fast/forms/listbox-clip-expected.txt:
  • platform/mac/test_expectations.txt: New expectations for basic-selects.html, since the fix of bug 74270.

New baselines that were not moved to mac-snowleopard because the difference was just the resize handle.

  • platform/mac/fast/table/003-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
09:34 Changeset [104298] by tony@chromium.org
  • 4 edits in branches/chromium/wpotest/Source

Merge 103722 - [chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the

value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

TBR=tony@chromium.org

09:33 Changeset [104297] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r104296.

09:19 Changeset [104296] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • Interfaces/IWebViewPrivate.idl:
09:13 Changeset [104295] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expectations for svg/carto.net/button.svg can be updated
https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed update to Chromium test_expectations

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-06

  • platform/chromium/test_expectations.txt: Removed flakiness line for carto.net/button.svg
09:03 Changeset [104294] by jknotten@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin-in-subframe.html
https://bugs.webkit.org/show_bug.cgi?id=75706

Unreviewed.

  • platform/chromium/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
07:42 Changeset [104293] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

make canvas-lineWidth test pass even if pixel values vary a tiny bit
https://bugs.webkit.org/show_bug.cgi?id=75627

Patch by Elliot Poger <epoger@google.com> on 2012-01-06
Reviewed by Stephen White.

  • fast/canvas/canvas-lineWidth.js:

(compareRows):

07:37 Changeset [104292] by jknotten@chromium.org
  • 38 edits
    3 copies
    6 moves
    43 adds
    17 deletes in trunk/LayoutTests

Rebaseline mac results after r104240.

https://bugs.webkit.org/show_bug.cgi?id=75654 changed the way
text fields are drawn on Mac.

Unreviewed.

  • platform/chromium-cg-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-cg-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-cg-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-cg-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-cg-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/table/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-cg-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-cg-mac/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-align-expected.png: Removed.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium-mac/fast/table/003-expected.png: Removed.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png: Removed.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/45621-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/inspector/network/download-expected.txt: Added.
  • platform/chromium/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium/http/tests/inspector/network/download-expected.txt: Added.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/plugins/mouse-click-plugin-clears-selection-expected.txt.
07:28 Changeset [104291] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Fix compilation of app code against QtWebKit master header file

Unreviewed trivial build fix.

  • Source/sync.profile: Exclude util.h and testwindow.h from the master header

file, because it cannot be used outside of the WebKit source tree.

06:48 Changeset [104290] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r104060): fast/forms/textarea-metrics.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75644

Reviewed by Alexey Proskuryakov.

We need to clear the style selector on doc type change as the doc type
may affect interpretation of the stylesheets. r104060 extended the life
of the style selector in some cases, exposing this problem.

  • dom/Document.cpp:

(WebCore::Document::setDocType):

06:25 Changeset [104289] by kov@webkit.org
  • 4 edits
    2 adds in trunk

Make the new WTF module build on Gtk
https://bugs.webkit.org/show_bug.cgi?id=75669

Patch by Eric Seidel <eric@webkit.org> and Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-06

Source/JavaScriptCore:

  • GNUmakefile.am:

Source/WTF:

  • GNUmakefile.am: Added.
  • GNUmakefile.list.am: Added.
06:21 Changeset [104288] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport cache client
https://bugs.webkit.org/show_bug.cgi?id=75649

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-01-06
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/CacheClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/CacheClientBlackBerry.h: Added.
05:34 Changeset [104287] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] QQuickWebView breaks when an empty url is loaded
https://bugs.webkit.org/show_bug.cgi?id=75445

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-06
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::load):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Check if a request to load

an empty url is ignored. 'about:blank' should be used instead to load an empty page.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
05:18 Changeset [104286] by vestbo@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Remove un-needed VPATHs from project includes

Reviewed by Simon Hausmann.

04:53 Changeset [104285] by vestbo@webkit.org
  • 11 edits
    4 moves
    4 adds in trunk

[Qt] Move listing of include paths and libs to pri files in sources

Includepaths are sometimes modified by non-Qt contributors so keeping
them in files inside Sources makes it more likely that they are updated
along with project files for the other ports.

Using pri files instead of prf files for this also has the benefit that
the include() from the main target file can be parsed and followed by
Qt Creator -- something that does not work with load().

Dependency from a target to a library through the WEBKIT variable are
handled through forwarding-files in Tools/qmake/mkspecs/modules, which
set the source root of the module and include the right pri file.

Ideally we'd use the variant of include() that takes an optional
namespace to read the variables into, or the fromfile() function,
but both of these add an overhead of about 40% on the total qmake
runtime, due to making a deep copy of all the variables in the
project or re-reading all the prf files from scratch.

Reviewed by Simon Hausmann.
Reviewed by Ossy.

04:44 Changeset [104284] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Add a few more files ot OTHER_FILES

Rubber-stamped by Simon Hausmann.

04:27 Changeset [104283] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

  • platform/qt/Skipped:
03:25 Changeset [104282] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebKit/efl: [EFL] Add new pre-rendering code.
https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add new pre-rendering code to pre-render the view area more efficiently.
At first find centered view position where backing store starts to queuing the render request from.
And append the request into the tiled backing store in spiral order.

  • ewk/ewk_private.h:
  • ewk/ewk_tiled_backing_store.cpp:

(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_view.cpp:

(_ewk_view_smart_pre_render_start):
(ewk_view_base_smart_set):
(ewk_view_pre_render_start):

  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_rect_collision_check):
(_ewk_view_tiled_rect_collision_resolve):
(_ewk_view_tiled_smart_pre_render_start):
(ewk_view_tiled_smart_set):

Tools: [EFL] Add pre-render handling code in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add pre-render handling code by pressing Insert key.

  • EWebLauncher/main.c:

(on_key_down):

02:55 Changeset [104281] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75698

Unreviewed.

  • platform/chromium/test_expectations.txt:
02:31 Changeset [104280] by zeno.albisser@nokia.com
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
02:28 Changeset [104279] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

FrameDestructionObserver should be more full-service
https://bugs.webkit.org/show_bug.cgi?id=75690

Reviewed by Eric Seidel.

This patch moves code common to both subclasses of
FrameDestructionObserver into FrameDestructionObserver itself. As we
add more subclasses, we don't want to keep copy/pasting this code.

  • page/Frame.cpp:

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):

  • page/Frame.h:

(WebCore::FrameDestructionObserver::frame):

  • plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):

  • plugins/DOMMimeType.h:
  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):

  • plugins/DOMPlugin.h:
01:43 Changeset [104278] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Move MediaDocument styles into CSS. Set black background for chromium.
https://bugs.webkit.org/show_bug.cgi?id=74123

Source/WebCore:

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

Test: platform/chromium/media/video-black-bg-in-media-document.html

  • css/mediaControls.css:

(body:-webkit-full-page-media):
(video:-webkit-full-page-media):

  • css/mediaControlsChromium.css:

(body:-webkit-full-page-media):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

Adds a new chromium specific test for ensuring the background is set
properly.

Rebaselines the text portions of media-document-audio-repaint.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium/media/media-document-audio-repaint-expected.txt:
  • platform/chromium/media/video-black-bg-in-media-document-expected.txt: Added.
  • platform/chromium/media/video-black-bg-in-media-document.html: Added.
  • platform/chromium/test_expectations.txt:
01:03 Changeset [104277] by ossy@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected results after r104208.

  • platform/qt/fast/table/032-expected.png:
  • platform/qt/fast/table/032-expected.txt:
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png: Added.
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/qt/tables/mozilla/bugs/bug55694-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55694-expected.txt:
00:53 Changeset [104276] by aboxhall@chromium.org
  • 13 edits
    2 adds in trunk

Report correct line number for non-native editable text elements.
https://bugs.webkit.org/show_bug.cgi?id=71263

Reviewed by Ryosuke Niwa.

Source/WebCore:

A non-native editable text element is an element with an ARIA role of "textbox", which is
set on an element which behaves like an editable text element (such as a textarea, text
input field or contenteditable text), but whose behaviour is controlled by the author rather
than the browser.

This change makes certain methods on Node, and related methods in htmlediting and
visible_units, aware of the notion that an element may be editable only from the point of
view of assistive technology (via the ARIA textbox role), via the EditableType enum added to
EditingBoundary.h.

This is so that AccessibilityObject::lineForPosition() can use previousLinePosition(), and
AccessibilityRenderObject::indexForVisiblePosition() can use highestEditableRoot(), in a way
that respects non-native editability.

Test: accessibility/textbox-role-reports-line-number.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootAXEditableElement): Returns the root element which is
editable from the point of view of assistive technology, whether natively or otherwise.
(WebCore::AXObjectCache::nodeIsTextControl): Whether the given node is considered an
editable text element by assistive technology, natively or otherwise.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::lineForPosition): Modified to request the previous line
position in an element which is editable to Accessibility.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Modified to request the
highest root element which is editable to Accessibility.

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditableToAccessibility): Whether this node is editable to
Accessibility for the given EditableLevel.
(WebCore::Node::rootEditableElement): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.

  • dom/Node.h:

(WebCore::Node::rendererIsEditable): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
(WebCore::Node::rendererIsRichlyEditable): Overloaded version of this method which takes
an EditableType enum value indicating whether non-native editability is to be respected.

  • editing/EditingBoundary.h:
  • editing/htmlediting.cpp:

(WebCore::highestEditableRoot): Added optional EditableType parameter.
(WebCore::isEditablePosition): Added optional EditableType parameter.
(WebCore::isRichlyEditablePosition): Added optional EditableType parameter.
(WebCore::editableRootForPosition): Added optional EditableType parameter.

  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::previousLinePosition): Added optional EditableType parameter.
(WebCore::nextLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::nextLinePosition): Added optional EditableType parameter.

  • editing/visible_units.h:

LayoutTests:

  • accessibility/textbox-role-reports-line-number-expected.txt: Added.
  • accessibility/textbox-role-reports-line-number.html: Added.
00:47 Changeset [104275] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix a crash by importing an element of which local name ends with ":input".
https://bugs.webkit.org/show_bug.cgi?id=75103

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/importNode-confusing-localName.html

  • dom/Document.cpp:

(WebCore::Document::importNode): Pass QualifiedName of the source elemnt
to createElement() in order to avoid unnecessary serialization and
parsing of the qualified name

LayoutTests:

  • fast/dom/importNode-confusing-localName-expected.txt: Added.
  • fast/dom/importNode-confusing-localName.html: Added.
00:33 Changeset [104274] by tkent@chromium.org
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-06
Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
00:14 Changeset [104273] by ossy@webkit.org
  • 3 edits in trunk/Tools

NRWT should use test_expectation.txt on wk2 platforms
https://bugs.webkit.org/show_bug.cgi?id=75417

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(path_to_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_path_to_test_expectations_file):

00:09 Changeset [104272] by ossy@webkit.org
  • 13 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104268.
http://trac.webkit.org/changeset/104268
https://bugs.webkit.org/show_bug.cgi?id=75689

It broke the mac build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::shouldAutocomplete):
(WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint):
(WebCore::HTMLFormControlElementWithState::saveFormControlState):
(WebCore::HTMLFormControlElementWithState::restoreFormControlState):

  • html/HTMLFormControlElementWithState.cpp: Removed.
  • html/HTMLFormControlElementWithState.h: Removed.
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
00:07 Changeset [104271] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104259 and r104261.
http://trac.webkit.org/changeset/104259
http://trac.webkit.org/changeset/104261
https://bugs.webkit.org/show_bug.cgi?id=75688

Caused assertion failures (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.cpp:
  • dom/TreeScope.h:
  • dom/TreeScopeAdopter.cpp: Removed.
  • dom/TreeScopeAdopter.h: Removed.
00:04 Changeset [104270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=75612

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

  • wtf/text/WTFString.h:

(WTF::String::findIgnoringCase):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::String::isHashTableDeletedValue):

01/05/12:

22:41 Changeset [104269] by mitz@apple.com
  • 14 edits in trunk

<rdar://problem/10633760> Update copyright strings

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Info.plist:

Source/JavaScriptGlue:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • Info.plist:
  • PluginProcess/Info.plist:
  • WebProcess/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
21:36 Changeset [104268] by alexis.menard@openbossa.org
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
21:29 Changeset [104267] by barraclough@apple.com
  • 5 edits in trunk

Date constructor handles infinite values incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=70998

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • should be checking !finite rather then isnan.

LayoutTests:

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
    • Added test cases.
20:48 Changeset [104266] by barraclough@apple.com
  • 5 edits in trunk

date.toISOString produces incorrect results for dates with ms prior to 1970
https://bugs.webkit.org/show_bug.cgi?id=75684

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

LayoutTests:

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:
    • Added test case
20:01 Changeset [104265] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
https://bugs.webkit.org/show_bug.cgi?id=74693

Patch by Wei James <james.wei@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):

19:20 Changeset [104264] by jochen@chromium.org
  • 3 edits in trunk/Tools

Don't hardcode expected file URIs in as they depend on the platform
https://bugs.webkit.org/show_bug.cgi?id=75666

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

19:14 Changeset [104263] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r104210): Dromaeo DOM test score is lower
https://bugs.webkit.org/show_bug.cgi?id=75679

Reviewed by Andreas Kling.

The regression was caused by isDomVersionConsistent not being able to obtain the tree version
inside isLengthCacheValid when m_cachedItem is null. Fix the regression by always setting
m_cachedItem to some node when caching the length so that we can obtain the tree version later.

Also address Antti's review comment to fit m_cachedLength, m_isLengthCacheValid, and
m_isItemCacheValid all in 32-bit.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):

19:10 Changeset [104262] by ojan@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

More chromium expected results after r104208.

  • platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
  • platform/chromium-win-xp/fast/table/032-expected.png:
  • platform/chromium-win-xp/fast/table/032-expected.txt: Removed.
18:46 Changeset [104261] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed bad merge fix for r104259 which dropped a line from r104210.

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

18:13 Changeset [104260] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75593
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-01-05
Reviewed by Alexey Proskuryakov.

Null-check 'page' variable before use, to follow the common usage pattern of m_frame->page()
throughout the rest of FrameView.cpp.

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

17:58 Changeset [104259] by morrita@google.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: Followed the renaming.

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: Followed te renaming.

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp: Followed te renaming.

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()

  • dom/TreeScopeAdopter.cpp: Added.

(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • dom/TreeScopeAdopter.h: Added.

(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

17:37 Changeset [104258] by barraclough@apple.com
  • 4 edits in trunk

Array.prototype.lastIndexOf ignores undefined fromIndex.
https://bugs.webkit.org/show_bug.cgi?id=75678

Reviewed by Sam Weinig.

Source/JavaScriptCore:

array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncLastIndexOf):

  • should check argumnet count, rather than checking agument value for undefined.

LayoutTests:

  • ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
    • check in passing result
17:32 Changeset [104257] by jochen@chromium.org
  • 8 edits in trunk

Source/WebCore: Disallow access to DOM storage from detached frames.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):

Source/WebKit/chromium: Check whether a WebView exists before accessing it in StorageAreaProxy. This is not necessarily the case, e.g. for detached iframes.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests: Unskip fast/storage/storage-detached-iframe.html on chromium
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • fast/storage/storage-detached-iframe-expected.txt:
  • fast/storage/storage-detached-iframe.html:
  • platform/chromium/test_expectations.txt:
17:32 Changeset [104256] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

17:29 Changeset [104255] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
https://bugs.webkit.org/show_bug.cgi?id=75598

Use VERTEX_SHADER() and FRAGMENT_SHADER() macros, instead of quoted string literals when
declaring shaders in TextureMapperGL.

We need two macros to account for the differences between OpenGL and OpenGL ES2.

Reviewed by Martin Robinson.

17:19 Changeset [104254] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

sizeof(CSSRule) is 20 instead of 12 on Windows
https://bugs.webkit.org/show_bug.cgi?id=75665

Reviewed by Darin Fisher.

Unlike gcc and clang, MSVC pads each consecutive member variables of the same type
in bitfields. e.g. if you have:

sturct AB {
unsigned m_1 : 31;
bool m_2 : 1;
}

then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang
only allocate sizeof(unsigned) * 1 for AB.

Fix the bloat by turning all bitfields in CSSRule either signed or unsigned integers.

  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::sourceLine):
(WebCore::CSSRule::setSourceLine):
(WebCore::CSSRule::hasCachedSelectorText):
(WebCore::CSSRule::setHasCachedSelectorText):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::cleanup):
(WebCore::CSSStyleRule::selectorText):
(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleRule.h:
17:17 Changeset [104253] by lforschler@apple.com
  • 1 copy in tags/Safari-535.15

New Tag.

17:15 Changeset [104252] by dgrogan@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.

  • storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

  • storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
  • storage/indexeddb/prefetch-bugfix-108071.html: Added.
17:08 Changeset [104251] by barraclough@apple.com
  • 5 edits in trunk

Date parsing is too restrictive.
https://bugs.webkit.org/show_bug.cgi?id=75671

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

ES5 date parsing currently requires all fields to be present, which does not match the spec (ES5.1 15.9.1.15).
The spec allow a date to be date only, or date + time.

The date portion on the should match: (pseudocode!:)

[(+)YY]YYYY[-MM[-DD]]

though we are slightly more liberal (permitted by the spec), allowing:

[+]Y+[-MM[-DD]]

The time portion should match:

THH:mm[:ss[.sss]][Z|(+|-)HH:mm]

again we're slightly more liberal, allowing:

THH:mm[:ss[.s+]][Z|(+|-)HH:mm]

  • wtf/DateMath.cpp:

(WTF::parseES5DatePortion):

  • Month/day fields are optional, default to 01.

(WTF::parseES5TimePortion):

  • Hours/Minutes are requires, seconds/timezone are optional.

(WTF::parseES5DateFromNullTerminatedCharacters):

  • Dates may be date only, or date + time.

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
    • Add more test cases for Date.parse.
17:05 Changeset [104250] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r100203.

17:02 Changeset [104249] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r99999.

17:01 Changeset [104248] by jamesr@google.com
  • 13 edits in trunk/Source

[chromium] Route all animate calls through CCLayerTreeHost in composited mode to simplify rate limiting logic
https://bugs.webkit.org/show_bug.cgi?id=75577

Reviewed by Darin Fisher.

Source/WebCore:

This internalizes the animation rate limiting logic to CCLayerTreeHost and removes the setters/getters for the
m_animating flag. This requires that all animation updates have to go through CCLayerTreeHost to get the right
rate limiting behavior, regardless of which proxy is being used.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::layout):
(WebCore::CCLayerTreeHost::startRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

Routes WebWidget-initiated animate() calls through the CCLayerTreeHost in composited mode. CCLayerTreeHost's
rate limiting logic needs to be aware of when requestAnimationFrame callbacks are run. In threaded mode, the
animate calls are driven from CCThreadProxy and so the CCLayerTreeHost can set whatever state it needs. This
makes the single-threaded mode where the animate calls are driven through the WebWidget interface outside of the
CCProxy's control.

This is a small step towards inverting the scheduling control from the WebWidget to the compositor.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

  • src/WebViewImpl.h:
16:54 Changeset [104247] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/dom/Element.cpp

Fix rounding for adjustForLocalZoom

16:44 Changeset [104246] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] NativeImageSkia should mark SkBitmaps as immutable
https://bugs.webkit.org/show_bug.cgi?id=74962

Removed m_isDataComplete from class NativeImageSkia. Instead, data
completeness will be tracked through SkBitmap::setImmutable/
isImmutable. The immutable state signifies that the pixel data
will no longer change for the lifetime of the bitmap, which corresponds
to the semantic of the old m_isDataComplete member. setImmutable is
also called on the cached resized bitmap, since it too is invariant for
its life time. Temporary resized bitmaps are also marked as immutable
since they technically are.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-05
Reviewed by Stephen White.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore::NativeImageSkia::setDataComplete):
(WebCore::NativeImageSkia::isDataComplete):

16:42 Changeset [104245] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark flaky test as flaky. Filed
https://bugs.webkit.org/show_bug.cgi?id=75647 about making it not
flaky.

  • platform/chromium/test_expectations.txt:
16:39 Changeset [104244] by abarth@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r104231.
http://trac.webkit.org/changeset/104231
https://bugs.webkit.org/show_bug.cgi?id=75668

Breaks the Qt build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-05

Source/WebCore:

  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::acceptNavigationRequest):

16:36 Changeset [104243] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r99756.

16:33 Changeset [104242] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r99731.

16:32 Changeset [104241] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Resize requests at the view level should be ignored when in autoresize mode.
https://bugs.webkit.org/show_bug.cgi?id=75651

Reviewed by Dmitry Titov.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize): The assert was here to catch a view that
tried to do a resize after setting autoresize. However, we found that generic
code tries to do resizes as well. Rather than special case each caller,
we'll just make this code ignore the resize call.

16:30 Changeset [104240] by bdakin@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75654
Text fields should draw using NSTextFieldCell instead of WebKitSystemInterface

Reviewed by John Sullivan.

This change should not have any affect on tests or real web sites. It just changed
the implementation under the hood to the more modern NSCell approach.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

16:29 Changeset [104239] by andersca@apple.com
  • 7 edits
    2 adds in trunk

Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
https://bugs.webkit.org/show_bug.cgi?id=75667
<rdar://problem/10389454>

Reviewed by Kevin Decker.

Source/WebKit2:

NPRuntimeObjectMap::invalidate is called whenever a plug-in view is destroyed. If invalidate is called for an object map
whose plug-in has a null frame, we'd crash.

The plug-in will have a null frame if the plug-in view is destroyed because its containing frame has been removed from the document,
and if the plug-in view is being destroyed asynchronously due to the plug-in itself calling JavaScript that will remove the frame
(see PluginView::unprotectPluginFromDestruction).

The reason NPRuntimeObjectMap::invalidate will crash when the frame is null is because we were trying to access the frame's global
object, causing a null dereference. The reason we were trying to get at the frame's global object was to create a Strong handle to
a JSNPObject so we could stick the object in a vector so we could later iterate over the vector elements and call invalidate() on
each JSNPObject which will end up releasing the underlying NPObject.

However, it turns out that we don't need to stick the JSNPObject in a vector; we can just get the underlying NPObject directly and
stick that in a vector and then iterate over the NPObjects, releasing them.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

Tools:

Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::executeScript):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:

(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):

LayoutTests:

  • plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
  • plugins/npruntime/object-from-destroyed-plugin-in-subframe.html: Added.
16:15 Changeset [104238] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r99579.

16:12 Changeset [104237] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r99462.

16:01 Changeset [104236] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Add a compile-time assertion for the size of CSSValue
https://bugs.webkit.org/show_bug.cgi?id=75635

Reviewed by Tony Chang.

Tightened the compile-time assertion.

  • css/CSSValue.cpp:
15:59 Changeset [104235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Undefined references to ICU_I18N symbols on WTF
https://bugs.webkit.org/show_bug.cgi?id=75642

Unreviewed build fix.

Add ${ICU_I18N_LIBRARIES} to WTF_LIBRARIES on wtf efl platform cmake.
Some undefined references were ucol_setAttribute_44, ucol_close_44,
ucol_getAttribute_44...

Patch by Bruno Dilly <bdilly@profusion.mobi> on 2012-01-05

  • wtf/PlatformEfl.cmake:
15:57 Changeset [104234] by eae@chromium.org
  • 6 edits in branches/subpixellayout/LayoutTests/platform/mac/fast/forms

Update mac test expectations for a couple of form tests.

15:57 Changeset [104233] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

[V8] CodeGeneration for SerializedScriptValue doesn't play nice with [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=75641

Reviewed by David Levin.

Rather than generate getters for SerializedScriptValues, we eagerly
deserialize them into JavaScript objects. However, previously, we were
only doing that for DOM wrappers created by taking an existing C++
object and wrapping it. For objects created with Constructors (e.g.,
those with the [Constructor] attribute), we need to do this eager
deserialization during the constructor as well.

This bug isn't observable yet, but it is causing the WebIntent test
being added in Bug 73051 to fail.

Test: TestSerializedScriptValueInterface.idl

webintents/web-intents-api.html (after Bug 73051 lands)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEagerDeserialization):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
15:45 Changeset [104232] by ojan@chromium.org
  • 7 edits
    1 move
    4 adds
    2 deletes in trunk/LayoutTests

New chromium expected results after r104208.

  • platform/chromium-linux/fast/table/032-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-mac-leopard/fast/table/032-expected.png:
  • platform/chromium-mac-leopard/fast/table/032-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55694-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug55694-expected.png: Removed.
  • platform/chromium-win-xp/fast/table/032-expected.png: Added.
  • platform/chromium-win-xp/fast/table/032-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/table/032-expected.txt.
  • platform/chromium-win/fast/table/032-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.txt:
15:11 Changeset [104231] by abarth@webkit.org
  • 5 edits in trunk/Source

Introduce Platform namespace for WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=75653

Reviewed by Eric Seidel.

Source/WebCore:

This patch introduces the Platform namespace for WebCore/platform.
Introducing this namespace will help us find and fix layering
violations in preparation for moving WebCore/platform to Platform.

  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::acceptNavigationRequest):

15:07 Changeset [104230] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up port factory methods
https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(_port_name_from_arguments_and_options):
(get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(_verify_baseline_path):

15:04 Changeset [104229] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r98912-r99538): Crash in WebKit::WebFrameLoaderClient::didDetectXSS
https://bugs.webkit.org/show_bug.cgi?id=75578

Reviewed by Daniel Bates.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
Check for a correct struct member existence.

14:58 Changeset [104228] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r103479.

14:55 Changeset [104227] by lforschler@apple.com
  • 14 edits in branches/safari-534.54-branch/Source

Merged r99439.

14:42 Changeset [104226] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/mac

Merged r98970.

14:39 Changeset [104225] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r98796.

14:37 Changeset [104224] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98781.

14:35 Changeset [104223] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r98763.

14:35 Changeset [104222] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Remove unused pixelSnapped methods from RenderBox.

14:33 Changeset [104221] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch

Merged r98561.

14:30 Changeset [104220] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r96294.

14:30 Changeset [104219] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Refined the fast path for StringImpl::hash()
https://bugs.webkit.org/show_bug.cgi?id=75178

Reviewed by Darin Adler.

Moved the hash calculation code into an out-of-line function to clean up
the hot path.

No measurable benchmark change, but this knocks some samples off in
Instruments, and I think this is a step toward removing -fomit-frame-pointer.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::hashSlowCase):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::hash): The patch.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::hashSlowCase): Abide by the cockamamie Windows build
scheme, which requires all out-of-line StringImpl functions used by
WebCore be defined in this file instead of StringImpl.cpp. (See http://trac.webkit.org/changeset/59187.)

14:29 Changeset [104218] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: Updating expecxtations for fast/media/viewport-media-query.
My understanding of the semantics was a bit off.

  • platform/chromium/test_expectations.txt:
14:04 Changeset [104217] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98513.

14:03 Changeset [104216] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r98374.

14:01 Changeset [104215] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98362.

14:00 Changeset [104214] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r98344.

13:58 Changeset [104213] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98186.

13:56 Changeset [104212] by barraclough@apple.com
  • 5 edits in trunk

Literal tab in JSONString fails
https://bugs.webkit.org/show_bug.cgi?id=71772

Reviewed by Oliver Hunt.

rfc4627 does not allow literal tab characters in JSON source.

Source/JavaScriptCore:

  • runtime/LiteralParser.cpp:

(JSC::isSafeStringCharacter):

  • do not allow literal tab in StrictJSON mode.

LayoutTests:

  • fast/js/JSON-parse-expected.txt:
  • fast/js/resources/JSON-parse.js:

(createTests.result):

  • Updated expected results.
13:56 Changeset [104211] by lforschler@apple.com
  • 7 edits
    5 copies in branches/safari-534.54-branch

Merge 98033.

13:48 Changeset [104210] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
https://bugs.webkit.org/show_bug.cgi?id=73853

Reviewed by Antti Koivisto.

Lazily invalidate the node list caches instead of invaliding them at the time of modification. We use
the DOM tree version to detect whether caches need to be invalidated or not. We now invalidate caches more
frequently after this patch (in particular, invalidates caches that are stored on nodes not present in
the ancestry of the modified nodes); however, our study on major Web sites such as Gmail, Facebook, Twitter,
etc... indicate that about 1% of real-world usage benefits from keeping the caches alive across different
DOM tree versions.

In order to invalidate caches lazily, this patch adds replaces the type of m_caches in DynamicSubtreeNodeList
by DynamicSubtreeNodeList::SubtreeCaches which encapsulates member variables in DynamicNodeList::Caches and
invalidates values as needed. Also this change allows m_caches to be allocated as a part of
DynamicSubtreeNodeList instead of a separate ref-counted object.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicNodeList::Caches::create):
(WebCore::DynamicNodeList::Caches::reset):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedLength): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItemOffset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::reset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent): Added.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively): Clear caches when a node moves from one document to another.
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Only clears child node list of Attr.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Only clears child node list.
(WebCore::NodeListsNodeData::invalidateCaches): Merged with invalidateCachesThatDependOnAttributes.

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:
  • html/HTMLLabelElement.h:
13:41 Changeset [104209] by wjmaclean@chromium.org
  • 3 edits
    1 copy in trunk/Source/WebKit/chromium

[chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns incorrect value, causing accelerated content to not display in Aura desktop
https://bugs.webkit.org/show_bug.cgi?id=75551

Reviewed by James Robinson.

  • WebKit.gypi:
  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):

  • tests/WebExternalTextureLayerImplTest.cpp: Copied from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
13:39 Changeset [104208] by ojan@chromium.org
  • 8 edits
    3 adds in trunk

IE quirk for percentage size on a table element doesn't work with orthogonal writing modes
https://bugs.webkit.org/show_bug.cgi?id=70195

Reviewed by Eric Seidel.

Source/WebCore:

Remove this quirk entirely. Mozilla and Opera don't implement it and IE
doesn't restrict the quirk to standards mode. As it's unlikely for
webkit-only content to hit this quirk (e.g. use tables for layout),
it should be relatively safe to match Mozilla/Opera here.

Test: fast/writing-mode/table-percent-width-quirk.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/table/032.html:
  • fast/writing-mode/table-percent-width-quirk-expected.png: Added.
  • fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • fast/writing-mode/table-percent-width-quirk.html: Added.
  • platform/mac/fast/table/032-expected.png:
  • platform/mac/fast/table/032-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55694-expected.png:
  • platform/mac/tables/mozilla/bugs/bug55694-expected.txt:
13:37 Changeset [104207] by eae@chromium.org
  • 11 edits in branches/subpixellayout/Source

Change IntrinsicSize back to an IntSize and get rid of extraneous rounding.

13:25 Changeset [104206] by jochen@chromium.org
  • 6 edits in trunk/Tools

Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
https://bugs.webkit.org/show_bug.cgi?id=75617

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.exists):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.exists):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(GenericFileSystemTests.teardown_generic_test_dir):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_results_directory_absolute):

13:22 Changeset [104205] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r98010.

13:19 Changeset [104204] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97927.

13:11 Changeset [104203] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r97786.

13:04 Changeset [104202] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r97524.

13:01 Changeset [104201] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97502.

12:57 Changeset [104200] by lforschler@apple.com
  • 10 edits in branches/safari-534.54-branch

Merged r97402.

12:53 Changeset [104199] by nduca@chromium.org
  • 4 edits
    3 adds in trunk/Source

[chromium] Add CCTimer class for the compositor
https://bugs.webkit.org/show_bug.cgi?id=74769

Patch by Tien Ren Chen <trchen@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Add a simple timer class for CCThread that the timered task can be
manually cancelled.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCTimer.cpp: Added.

(WebCore::CCTimerTask::CCTimerTask):
(WebCore::CCTimerTask::~CCTimerTask):
(WebCore::CCTimerTask::performTask):
(WebCore::CCTimer::CCTimer):
(WebCore::CCTimer::~CCTimer):
(WebCore::CCTimer::startOneShot):
(WebCore::CCTimer::stop):

  • platform/graphics/chromium/cc/CCTimer.h: Added.

(WebCore::CCTimerClient::~CCTimerClient):
(WebCore::CCTimer::isActive):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCTimerTest.cpp: Added.

(WebKitTests::CCTimerTest::CCTimerTest):
(WebKitTests::CCTimerTest::onTimerFired):
(WebKitTests::TEST_F):

12:48 Changeset [104198] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

WK2: Safari fails to open a PostScript file in Preview from context menu
https://bugs.webkit.org/show_bug.cgi?id=75643
<rdar://problem/9823430>

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData): Append ".pdf" to file name when converting data, as suggested file name is created for original MIME type.
12:44 Changeset [104197] by eric.carlson@apple.com
  • 10 edits
    24 adds in trunk

Implement temporal dimension portion of Media Fragments URI specification for video/audio
https://bugs.webkit.org/show_bug.cgi?id=65838

Reviewed by Sam Weinig.

Source/WebCore:

Tests: media/media-fragments/TC0001-TC0009.html

media/media-fragments/TC0010-TC0019.html
media/media-fragments/TC0020-TC0029.html
media/media-fragments/TC0030-TC0039.html
media/media-fragments/TC0040-TC0049.html
media/media-fragments/TC0050-TC0059.html
media/media-fragments/TC0060-TC0069.html
media/media-fragments/TC0070-TC0079.html
media/media-fragments/TC0080-TC0089.html
media/media-fragments/TC0090-TC0099.html

  • CMakeLists.txt: Add fragment parser files.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_fragmentStartTime and m_fragmentEndTime.
(WebCore::HTMLMediaElement::setReadyState): Check for and parse a media fragment once readyState

reaches HAVE_METADATA, apply it once it reaches HAVE_CURRENT_DATA.

(WebCore::HTMLMediaElement::initialTime): Return the fragment start time if possible.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Pause if the time is >= the fragment

end time.

(WebCore::HTMLMediaElement::prepareMediaFragmentURI): Look for a temporal fragment.
(WebCore::HTMLMediaElement::applyMediaFragmentURI): Apply the fragment, if any.

  • html/HTMLMediaElement.h:
  • html/MediaFragmentURIParser.cpp: Added.

(WebCore::skipWhiteSpace):
(WebCore::collectDigits):
(WebCore::collectFraction):
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseFragments):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
(WebCore::MediaFragmentURIParser::parseNPTFragment):
(WebCore::MediaFragmentURIParser::parseNPTTime):

  • html/MediaFragmentURIParser.h: Added.

(WebCore::MediaFragmentURIParser::~MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::create):

LayoutTests:

  • media/media-fragments: Added.
  • media/media-fragments/TC0001-TC0009-expected.txt: Added.
  • media/media-fragments/TC0001-TC0009.html: Added.
  • media/media-fragments/TC0010-TC0019-expected.txt: Added.
  • media/media-fragments/TC0010-TC0019.html: Added.
  • media/media-fragments/TC0020-TC0029-expected.txt: Added.
  • media/media-fragments/TC0020-TC0029.html: Added.
  • media/media-fragments/TC0030-TC0039-expected.txt: Added.
  • media/media-fragments/TC0030-TC0039.html: Added.
  • media/media-fragments/TC0040-TC0049-expected.txt: Added.
  • media/media-fragments/TC0040-TC0049.html: Added.
  • media/media-fragments/TC0050-TC0059-expected.txt: Added.
  • media/media-fragments/TC0050-TC0059.html: Added.
  • media/media-fragments/TC0060-TC0069-expected.txt: Added.
  • media/media-fragments/TC0060-TC0069.html: Added.
  • media/media-fragments/TC0070-TC0079-expected.txt: Added.
  • media/media-fragments/TC0070-TC0079.html: Added.
  • media/media-fragments/TC0080-TC0089-expected.txt: Added.
  • media/media-fragments/TC0080-TC0089.html: Added.
  • media/media-fragments/TC0090-TC0099-expected.txt: Added.
  • media/media-fragments/TC0090-TC0099.html: Added.
  • media/media-fragments/media-fragments.js: Added.

(canplaythrough):
(setupNextTest):
(nextTestName):
(start):

12:44 WebKit Team edited by aestes@apple.com
(diff)
12:41 Changeset [104196] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[v8] Null pointer exception if a typed array constructor set to a primitive value.
https://bugs.webkit.org/show_bug.cgi?id=75532

Make sure that V8ArrayBufferViewCustomScript.js does not throw exception.

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-05
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
12:28 Changeset [104195] by aroben@apple.com
  • 2 edits in trunk/Tools

Remove some unnecessary code from old-run-webkit-tests

Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
WebKitTestRunner.

Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
Windows

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:

(top level):
(openDumpTool):
Removed calls to setPathForRunningWebKitApp.

12:18 Changeset [104194] by mrobinson@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit/gtk

[GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated compositing implementations
https://bugs.webkit.org/show_bug.cgi?id=75519

Reviewed by Alejandro G. Castro.

Add an AcceleratedCompositingContext which will isolate all the different accelerated compositing
implementations from one another. For right now this just includes the Clutter version.

  • GNUmakefile.am: Add the new files to the source list.
  • WebCoreSupport/AcceleratedCompositingContext.h: Added.
  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added. Existing

clutter AC code has moved here.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::attachRootGraphicsLayer): Use the new AccleratedCompositingContext now
instead of calling into the WebView.
(WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization):Ditto.
(WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.

  • webkit/webkitwebview.cpp:

(webkit_web_view_size_allocate): Call in the ACContext.
(webkit_web_view_init): Initialize the ACContext.

  • webkit/webkitwebviewprivate.h: Add the ACContext as a private member.
12:04 Changeset [104193] by zeno.albisser@nokia.com
  • 22 edits
    13 adds in trunk

[Qt][WK2] Implement custom URL schemes defined in QML.
https://bugs.webkit.org/show_bug.cgi?id=74931

.:

Add new classes to the export map.

Reviewed by Kenneth Rohde Christiansen.

  • Source/qtwebkit-export.map:

Source/WebKit/qt:

Make classes QQuickUrlSchemeDelegate, QQuickNetworkRequest
and QQuickNetworkReply accessible from QML.

Reviewed by Kenneth Rohde Christiansen.

  • declarative/experimental/experimental.pri:
  • declarative/experimental/plugin.cpp:
  • declarative/public.pri:

Source/WebKit2:

Allow creation of custom UrlSchemeDelegates from QML.
A UrlSchemeDelegate contains a handler signal that is triggered
when a url matching the defined scheme is requested.
To allow for this a derivation of QNetworkAccessManager
is necessary.
The request is then handled in QML/JS and a reply
is sent back from the UIProcess to the WebProcess.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/qt/QtNetworkReplyData.cpp: Added.

(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h: Added.
  • Shared/qt/QtNetworkRequestData.cpp: Added.

(WebKit::QtNetworkRequestData::QtNetworkRequestData):
(WebKit::QtNetworkRequestData::encode):
(WebKit::QtNetworkRequestData::decode):

  • Shared/qt/QtNetworkRequestData.h: Added.
  • Target.pri:
  • UIProcess/API/qt/qquicknetworkreply.cpp: Added.

(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::contentType):
(QQuickNetworkReply::setContentType):
(QQuickNetworkReply::operation):
(QQuickNetworkReply::setOperation):
(QQuickNetworkReply::contentDisposition):
(QQuickNetworkReply::setContentDisposition):
(QQuickNetworkReply::location):
(QQuickNetworkReply::setLocation):
(QQuickNetworkReply::lastModified):
(QQuickNetworkReply::setLastModified):
(QQuickNetworkReply::cookie):
(QQuickNetworkReply::setCookie):
(QQuickNetworkReply::userAgent):
(QQuickNetworkReply::setUserAgent):
(QQuickNetworkReply::server):
(QQuickNetworkReply::setServer):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
(QQuickNetworkReply::networkRequestData):
(QQuickNetworkReply::setNetworkRequestData):
(QQuickNetworkReply::networkReplyData):

  • UIProcess/API/qt/qquicknetworkreply_p.h: Added.
  • UIProcess/API/qt/qquicknetworkrequest_p.h: Added.
  • UIProcess/API/qt/qquickurlschemedelegate.cpp: Added.

(QQuickUrlSchemeDelegate::QQuickUrlSchemeDelegate):
(QQuickUrlSchemeDelegate::scheme):
(QQuickUrlSchemeDelegate::setScheme):
(QQuickUrlSchemeDelegate::request):
(QQuickUrlSchemeDelegate::reply):

  • UIProcess/API/qt/qquickurlschemedelegate_p.h: Added.
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):
(QQuickWebViewExperimental::invokeApplicationSchemeHandler):
(QQuickWebViewExperimental::sendApplicationSchemeReply):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleApplicationSchemeRequest):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::registerApplicationScheme):
(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::registerApplicationScheme):
(WebKit::WebPage::receivedApplicationSchemeRequest):
(WebKit::WebPage::applicationSchemeReply):

  • WebProcess/qt/QtNetworkAccessManager.cpp: Added.

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):
(WebKit::QtNetworkAccessManager::createRequest):
(WebKit::QtNetworkAccessManager::registerApplicationScheme):

  • WebProcess/qt/QtNetworkAccessManager.h: Added.
  • WebProcess/qt/QtNetworkReply.cpp: Added.

(WebKit::QtNetworkReply::QtNetworkReply):
(WebKit::QtNetworkReply::setData):
(WebKit::QtNetworkReply::setReplyData):
(WebKit::QtNetworkReply::readData):
(WebKit::QtNetworkReply::bytesAvailable):
(WebKit::QtNetworkReply::setHeader):
(WebKit::QtNetworkReply::abort):
(WebKit::QtNetworkReply::close):
(WebKit::QtNetworkReply::setReadBufferSize):
(WebKit::QtNetworkReply::canReadLine):
(WebKit::QtNetworkReply::finalize):

  • WebProcess/qt/QtNetworkReply.h: Added.
  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

12:02 Changeset [104192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove style warning in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75466

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-01-05
Reviewed by Kenneth Russell.

Relocated some headers according to alphabetical order & modified indentation.
And used OwnArrayPtr to deal with character array.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

11:55 Changeset [104191] by aroben@apple.com
  • 3 edits in trunk/Tools

Teach NRWT to use run-safari to open results.html on Apple's Windows port

NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
better, since we always want to open results.html using the user's build of WebKit, not
whatever their default browser is.

Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
for Apple's Windows port

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
an obsolete comment.

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_show_results_html_file): Updated expected results.

11:55 Changeset [104190] by aroben@apple.com
  • 2 edits in trunk/Tools

Prepend Safari.exe's path to the command-line passed to CreateProcess

Safari expects the first argument in the command-line to be the path to Safari.exe itself.
This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
was not including the path to Safari.exe in the command-line, so Safari was ignoring the
first argument that WebKitLauncherWin was trying to pass to it.

Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari

Reviewed by Steve Falkenburg.

  • WebKitLauncherWin/WebKitLauncherWin.cpp:

(_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.

11:55 Changeset [104189] by aroben@apple.com
  • 2 edits in trunk/Tools

Stop using explicit memory management in WebKitLauncherWin

We now use stack-allocated STL objects instead.

Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
Safari

Reviewed by Steve Falkenburg.

  • WebKitLauncherWin/WebKitLauncherWin.cpp:

(getStringValue):
(applePathFromRegistry):
(safariInstallDir):
(safariBrowserExe):
(_tWinMain):
Changed to use stack-allocated STL objects instead of malloc/free.

11:54 Changeset [104188] by aroben@apple.com
  • 7 edits
    1 copy
    7 adds in trunk

Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Safari and Apple Application Support directories to PATH before
trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.

Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner

Reviewed by Steve Falkenburg.

Tools:

  • WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and

ImageDiffLauncher, which I forgot to add to this .sln when that project was created.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.

  • WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from

Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
the stub launcher.

  • WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/main.cpp:

(dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.

Source/WebKit/win:

Add WebKitTestRunnerLauncher to WebKit.sln.

It builds just after WebKitTestRunner.

  • WebKit.vcproj/WebKit.sln:
11:53 Changeset [104187] by aroben@apple.com
  • 8 edits
    8 adds in trunk

Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Safari and Apple Application Support directories to PATH before
trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.

Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner

Reviewed by Steve Falkenburg.

Tools:

  • DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,

which I forgot to add to this .sln when that project was created.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops:

Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.

  • DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
  • win/DLLLauncher/DLLLauncherMain.cpp:

(modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
Safari's directory to PATH so that SafariTheme.dll can be found.

(main):
(wWinMain):
Changed to use the new modifyPath function.

Source/WebKit/win:

Add DumpRenderTreeLauncher to WebKit.sln.

It builds just after DumpRenderTree.

  • WebKit.vcproj/WebKit.sln:
11:46 Changeset [104186] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Fix debug build.

Reviewed by Oliver Hunt.

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:35 Changeset [104185] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip file-reader-event-listener.html on qt and efl.

  • platform/efl/Skipped:
  • platform/qt/Skipped:
11:32 Changeset [104184] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

push/shift fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75610

Reviewed by Sam Weinig.

Array object commonly store data in a vector, consisting of a portion that is
in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to shift with grow the pre-capacity, and
the current algorithm for increaseVectorLength (used by push, or Put?) will
never shrink the pre-capacity, so a push/shift fifo may consume an inordinate
amount of memory, whilst having a relatively small active length.

  • runtime/JSArray.cpp:

(JSC::JSArray::increaseVectorLength):

  • If m_indexBias is non-zero, decay it over time.
11:24 Changeset [104183] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Crash due to reparenting of relpositioned object under anonymous block
https://bugs.webkit.org/show_bug.cgi?id=70848

The associated test case creates a condition where a relative
positioned renderer is a descendant of an anonymous block for a
table column. The anonymous block is the containingBlock() for the
relpositioned renderer. Removal of a div causes the anonymous blocks to
be merged, and the renderer becomes a descendant of a different block.
Since the new containingBlock() has an empty positionedObject list,
the relpositioned renderer does not get layout after being dirtied.

This patch changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous
block itself. It also adds an ASSERT to insertPositionedObject()
to flag any other cases where something is trying to create a
positioned object list on an anonymous block.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

LayoutTests: Crash due to reparenting of relpositioned object in table
https://bugs.webkit.org/show_bug.cgi?id=70848

Adding test that exercises the crash condition in bug 70848.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Added
  • fast/css/relative-position-replaced-in-table-display-crash.html: Added
11:15 Changeset [104182] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed WK75633 and updated expectations

  • platform/chromium/test_expectations.txt:
11:03 Changeset [104181] by psolanki@apple.com
  • 4 edits in trunk/Source/WebKit/mac

WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions
https://bugs.webkit.org/show_bug.cgi?id=75586

Reviewed by Alexey Proskuryakov.

We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView
userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function,
_userAgentString that returns a WTF::String to make this call faster.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::userAgent):

  • WebView/WebView.mm:

(-[WebView _userAgentString]):
(-[WebView userAgentForURL:]):

  • WebView/WebViewInternal.h:
10:59 Changeset [104180] by jianli@chromium.org
  • 3 edits
    2 adds in trunk

FileReader needs addEventListener
https://bugs.webkit.org/show_bug.cgi?id=42723

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/file-reader-event-listener.html

  • fileapi/FileReader.idl:

LayoutTests:

  • fast/files/file-reader-event-listener-expected.txt: Added.
  • fast/files/file-reader-event-listener.html: Added.
10:50 WebKit Team edited by adele@apple.com
(diff)
10:38 Changeset [104179] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove deprecated calls from CookieJarCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=68958

Reviewed by Sam Weinig.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):

10:36 Changeset [104178] by dglazkov@chromium.org
  • 5 edits
    1 delete in branches/chromium/912

Revert 91125 - 2011-07-15 Rob Buis <rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:

TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/9116011

10:28 Changeset [104177] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, tighted up the expectations for some perf tests.

  • platform/chromium/test_expectations.txt:
10:26 Changeset [104176] by enne@google.com
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Create unit tests for CCTiledLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=75557

Reviewed by James Robinson.

Add some quad generation tests for tiled layers.

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Added.

(WebCore::createLayer):
(WebCore::TEST):
(WebCore::completelyContains):
(WebCore::getQuads):
(WebCore::verifyQuadsExactlyCoverRect):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):

10:19 WebKit Team edited by dgrogan@chromium.org
(diff)
10:18 Changeset [104175] by dglazkov@chromium.org
  • 5 edits
    6 copies
    2 deletes in branches/chromium/963

Merge 101903 - REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.
(WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly
(WebCore::Path::transform) : Now uses CGPathIsEmpty directly

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/9111020

10:16 Changeset [104174] by fsamuel@chromium.org
  • 35 edits in trunk

Move scalePageBy from eventSender to window.internals
https://bugs.webkit.org/show_bug.cgi?id=64512

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.

  • testing/Internals.cpp:

(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Updated layout tests to use window.internals.setPageScaleFactor.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/scaling/tiled-layer-recursion.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
10:08 Changeset [104173] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

[Skia Mac] Rounded bezel style button needs one more local graphics context to scale
https://bugs.webkit.org/show_bug.cgi?id=75623
http://code.google.com/p/chromium/issues/detail?id=108749

In paintButton(), the local context is set up first, and later the context is
scaled if there's a zoomFactor. Skia creates the CoreGraphics context to draw the
button into without that scale factor. To fix this, another local context is added
after the parameter context scale, before the button draw. The first local context
is still required to restore the parameter context state.

Reviewed by Stephen White.

  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::paintButton):

09:52 Changeset [104172] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: Chromium expectations update.
Filed http://crbug.com/109276 and ignored appcache failure on Linux.
Failures seem intermittent in appcache so might need to ignore more tests.

  • platform/chromium/test_expectations.txt:
09:49 Changeset [104171] by mitz@apple.com
  • 4 edits in trunk/Source/ThirdParty

Made Debug/Release builds of gtest build only for the active architecture.

Reviewed by Dave Kilzer.

  • gtest/xcode/Config/DebugProject.xcconfig:
  • gtest/xcode/Config/ProductionProject.xcconfig:
  • gtest/xcode/Config/ReleaseProject.xcconfig:
09:31 Changeset [104170] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expectations for svg/carto.net/button.svg can be updated
https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed Chromium test expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-05

  • platform/chromium-linux-x86/svg/carto.net: Removed.
  • platform/chromium/test_expectations.txt:
09:29 Changeset [104169] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for background is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75539

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for background.

Test: fast/css/getComputedStyle/getComputedStyle-background-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html: Added.
09:02 Changeset [104168] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Pass WebFrame instead of WebCore::Frame to the WebKit2 specific FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=75550

Make the WebKit2 FrameNetworkingContext implementation store the
WebFrame instead of the WebCore::Frame as this is needed for the Qt
port to implement a.o. HTTP autentication and SSL support.

As the WebFrameNetworkingContext is partly shared across all WebKit2 ports,
all port specific files have been modified.

For the Qt implementation of FrameNetworkingContext, we also set a
property to the originatingObject for the page ID. We also switch to
using an OwnPtr instead of a raw C++ pointer for the
m_originatingObject member.

Based on original patch by Peter Hartmann.

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-05
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:

(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::create):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

08:45 Changeset [104167] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Never enable FontConfig on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=75616

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-05
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
08:39 Changeset [104166] by hclam@chromium.org
  • 7 edits in trunk/Tools

Unreviewed, rolling out r104159.
http://trac.webkit.org/changeset/104159
https://bugs.webkit.org/show_bug.cgi?id=75590

Chromium port GPU tests cannot be executed.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(get):
(_default_tests_paths):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.assert_port_works):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory):
(PortFactory._get_kwargs):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_google_chrome.names):
(FactoryTest.test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GetGoogleChromePort):
(GetGoogleChromePort.GoogleChromeLinux32Port):
(GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
(GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
(GetGoogleChromePort.GoogleChromeLinux64Port):
(GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
(GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
(GetGoogleChromePort.GoogleChromeMacPort):
(GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
(GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeWinPort):
(GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
(GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_baseline_path):
(GetGoogleChromePortTest._verify_expectations_overrides):

08:00 Changeset [104165] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

DOM Attribute tests on Dromaeo spends 2.7% of time in hasSelectorForAttribute
https://bugs.webkit.org/show_bug.cgi?id=75569

Reviewed by Andreas Kling.

Check needsStyleRecalc() first to avoid unnecessary hash lookups.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

07:59 Changeset [104164] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Give

media/media-blocked-by-beforeload.html another chance on the bot
after its update in r103509.

07:47 Changeset [104163] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Replace alloca to C++ new placement.
https://bugs.webkit.org/show_bug.cgi?id=72017

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-05
Reviewed by Andreas Kling.

Replaces alloca to C++ new placement as it is not very portable.
It allows to skip checking of memory allocation as new never returns NULL.
According to Edje's documentation type of val (member of Edje_Message_Float_Set)
is double so I changed it to avoid undefined behaviour.

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::updateThumbPositionAndProportion):

07:37 Changeset [104162] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r104068): editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html made the next test fail

Unreviewed gardening. One more attempt to paint the Qt-WK2 bot green.

  • platform/qt-wk2/Skipped:
07:22 Changeset [104161] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium/test_expectations.txt:
07:01 Changeset [104160] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Invalidation request for ewk_view can be discarded without rendering.
https://bugs.webkit.org/show_bug.cgi?id=71564

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-05
Reviewed by Hajime Morita.

As ewk_view discards a queue for invalidation requests
as soon as it proceeds the repaint step, the newly produced invalidation requests
from ewk_view_layout_if_needed_recursive API can be discarded
and unpainted dirty area can occur.
As this issue is just caused by use of flush API in repaint step,
(internal API) ewk_view_repaints_get is replaced with ewk_view_repaints_pop
in order to make sure that old invalidation requests are removed from queue.
And in addition to that, ewk_view_repaint_add is modified
in order to let queue of invalidation requests keep a proper size.
As a result flush API won't be used for the repaint step.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_repaint_add):
(_ewk_view_smart_calculate):
(ewk_view_repaints_pop):

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_repaints_process):

07:01 Changeset [104159] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up port factory methods
https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(_port_name_from_arguments_and_options):
(get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(_verify_baseline_path):

06:59 Changeset [104158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove duplicate file references from WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75581

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-05
Reviewed by Andreas Kling.

Many generated DOMSVG files had two references.

In platform/graphics, there was two arm directory
with the same files related to ARM Neon.

  • WebCore.xcodeproj/project.pbxproj:
06:59 Changeset [104157] by aroben@apple.com
  • 6 edits
    1 copy
    8 adds in trunk

Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found.

Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH

Reviewed by Anders Carlsson.

Tools:

  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/ImageDiffCommon.vsprops:

Changed to build ImageDiff.dll instead of ImageDiff.exe.

  • DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from

Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.

  • DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffWin.cpp: Added.

(dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
to main.

  • win/DLLLauncher/DLLLauncherMain.cpp:

(main):
(wWinMain):
Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
stub launcher acts as a console program and calls a console version of
dllLauncherEntryPoint.

Source/WebKit/win:

Add ImageDiffLauncher to WebKit.sln

It builds just after ImageDiff.

  • WebKit.vcproj/WebKit.sln:
06:58 Changeset [104156] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Implement QQuickWebView::inputMethodQuery

Reviewed by Simon Hausmann.

Implement the current Qt5 queries of inputMethodQuery.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • UIProcess/API/qt/qquickwebview_p.h:
06:57 Changeset [104155] by aroben@apple.com
  • 7 edits
    1 copy
    7 adds in trunk

Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found.

Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
double-clicked

Reviewed by Anders Carlsson.

Tools:

  • MiniBrowser/MiniBrowser.vcproj:
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops:

Changed to build MiniBrowser.dll instead of MiniBrowser.exe.

  • MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
  • MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj

but changed to build the stub launcher.

  • MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since

it needs to be compiled into the .exe instead of the .dll.
(DllMain): Added. We use this to store the DLL's HINSTANCE.
(dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
DLLLauncherMain code.

  • win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser

to here.

Source/WebKit/win:

Add MiniBrowserLauncher to WebKit.sln

It builds just after MiniBrowser.

  • WebKit.vcproj/WebKit.sln: Added MiniBrowserLauncher.
06:56 Changeset [104154] by aroben@apple.com
  • 2 edits in trunk/Tools

Make WinLauncher's window frame respond to clicks/drags again

Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
bar when Aero is disabled

Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.cpp:

(WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
Also removed an unnecessary "break" keyword.

06:52 Changeset [104153] by aroben@apple.com
  • 6 edits
    1 copy
    12 adds in trunk

Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
should use this mechanism.

Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
double-clicked

Reviewed by Anders Carlsson.

Tools:

  • WinLauncher/WinLauncher.cpp: Removed InitInstance.

(DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
done by the now-removed InitInstance function.
(dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
calls. Merged code from InitInstance into this function, and change to use the global hInst
variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
function, which corresponds to WinLauncher.exe.

  • WinLauncher/WinLauncher.vcproj:
  • WinLauncher/WinLauncherCommon.vsprops:

Changed to build WinLauncher.dll instead of WinLauncher.exe.

  • WinLauncher/WinLauncherLauncher.rc: Added.
  • WinLauncher/WinLauncherLauncherResource.h: Added.

This just references the WinLauncher.ico file to set the application icon (though it looks
like that's a default icon).

  • WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj

but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.

  • WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
  • WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
  • WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
  • WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
  • win/DLLLauncher/DLLLauncherMain.cpp: Added.

(enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
program if it detects heap corruption.
(getStringValue): Helper function to read a string value from the registry.
(applePathFromRegistry): Helper function to read the InstallDir for a given Apple
application from the registry.
(appleApplicationSupportDirectory): Helper function to return the path to the Apple
Application Support directory.
(copyEnvironmentVariable): Helper function to copy an environment variable's value.
(prependPath): Helper function to prepend a directory to the PATH.
(fatalError): Helper function to display an error to the user.
(wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
dllLauncherEntryPoint function.

Source/WebKit/win:

Add WinLauncherLauncher to WebKit.sln

It builds just after WinLauncher.

  • WebKit.vcproj/WebKit.sln: Added WinLauncherLauncher.
06:40 Changeset [104152] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Improve SelectorChecker::determineSelectorScopes
https://bugs.webkit.org/show_bug.cgi?id=75619

Reviewed by Andreas Kling.

SelectorChecker::determineSelectorScopes currently searches to the end of the selector chain and
then sees if the last one is suitable to be a scope. A better algorithm will find a scope from
anywhere in the chain.

With this patch we search the whole chain for potential scopes. We now prefer id scopes
over class scopes. Scopes can be found for rules using sibling selectors too.

On both engadget.com and nytimes.com, we can now skip one more full style recalc due to
the improved stylesheet analysis.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineSelectorScopes):

06:38 Changeset [104151] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Use the default screen in PlatformScreenGtk methods when they are called with a NULL widget
https://bugs.webkit.org/show_bug.cgi?id=75620

Reviewed by Philippe Normand.

We are currently retuning an empty rectangle for
screenRect/screenAvailableRect and 0 for getVisual.

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

06:12 Changeset [104150] by hclam@chromium.org
  • 2 edits
    6 deletes in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-win-xp/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-align-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-path-01-b-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
06:02 Changeset [104149] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebSettings::setAcceleratedDrawingEnabled from public API.
https://bugs.webkit.org/show_bug.cgi?id=74125

Patch by David Reveman <reveman@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Remove setAcceleratedDrawingEnabled method from WebSettings class.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
06:02 Changeset [104148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expected test failures after Skia is rolled to 2918
https://bugs.webkit.org/show_bug.cgi?id=75019

Fixed now that Skia has rolled past r2936.

Unreviewed Chromium port test expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-05

  • platform/chromium/test_expectations.txt:
05:38 Changeset [104147] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix.

Adding missing const_cast<> to fix compilation failures due to r104143.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

05:27 Changeset [104146] by abarth@webkit.org
  • 5 edits
    3 adds in trunk/Source/WebCore

Move Gamepad declarations from Navigator.idl into Modules/gamepad
https://bugs.webkit.org/show_bug.cgi?id=75559

Reviewed by Eric Seidel.

This patch moves the gamepad-related declarations in Navigator.idl into
Modules/gamepad. The next step is to move the state into
Modules/gamepad as well.

  • Modules/gamepad/NavigatorGamepad.cpp: Added.

(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::~NavigatorGamepad):
(WebCore::NavigatorGamepad::webkitGamepads):

  • Modules/gamepad/NavigatorGamepad.h: Added.
  • Modules/gamepad/NavigatorGamepad.idl: Added.
  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::gamepads):

  • page/Navigator.h:
  • page/Navigator.idl:
05:04 Changeset [104145] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=75248

Reviewed by Gustavo Noronha Silva.

It uses the page zoom factor unconditionally for now.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init): Add WebKitWebView:zoom-level
property.
(webkit_web_view_set_zoom_level): Set current zoom level.
(webkit_web_view_get_zoom_level): Get current zoom level.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewZoomLevel):
(beforeAll):

04:55 Changeset [104144] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle for border-image is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75347

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-color.

fast/css/getComputedStyle/computed-style-border-image.html was extended to cover the
new feature.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values for border-image.

  • fast/css/getComputedStyle/computed-style-border-image-expected.txt:
  • fast/css/getComputedStyle/computed-style-border-image.html:
04:54 Changeset [104143] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add a SSE2 optimized function zvmul in VectorMatch
https://bugs.webkit.org/show_bug.cgi?id=74842

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

Use zvmul in FFTFrameFFMPEG.cpp::multiply() and FFTFrameMac.cpp::multiply().

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

  • platform/audio/VectorMath.h:
  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:

(WebCore::FFTFrame::multiply):

  • platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::multiply):

04:51 Changeset [104142] by hclam@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed. Build fix for Chromium Mac Clang build.

Push using namespace WTF to .cpp file from .h file.

  • platform/text/TextCodecASCIIFastPath.h:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF8.cpp:
04:50 Changeset [104141] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r104068): It made editing/pasteboard/copy-in-password-field.html fail
https://bugs.webkit.org/show_bug.cgi?id=75615

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip editing/pasteboard/copy-in-password-field.html to paint the bot green.
04:42 WebKit Team edited by kubo@profusion.mobi
Add myself to the list of committers (diff)
04:23 Changeset [104140] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebKit adds vertical paddings and borders to the fixed width of CSS tables
https://bugs.webkit.org/show_bug.cgi?id=74955

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-01-05
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/css-table-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

Changed the width calculation for CSS tables to take into account horizontal
paddings and borders instead of vertical paddings and borders.

LayoutTests:

Added tests to check that the fixed width style is applied correctly to
CSS tables with respect to table paddings and borders.

  • fast/table/css-table-width-expected.txt: Added.
  • fast/table/css-table-width.html: Added.
  • fast/table/script-tests/css-table-width.js: Added.

(computeCSSTableOffsetWidth):
(computeCSSTableOffsetHeight):
(computeCSSTableProperty):

04:22 Changeset [104139] by peter@chromium.org
  • 7 edits
    4 adds in trunk/Source

[Chromium] Upstream the RenderTheme and ScrollbarTheme for Android
https://bugs.webkit.org/show_bug.cgi?id=74614

Reviewed by Adam Barth.

Source/WebCore:

Upstream the RenderTheme and ScrollbarTheme for Android. These are
mostly derived from their Linux variants.

RenderThemeChromiumAndroid inherits from RenderThemeChromiumLinux and
only overrides the three methods which have different behavior.
Scrollbars will be drawn in the threaded compositor for Android (which
will be upstreamed later), but for increased layout test parity we'll
match Chromium-Linux.

No new tests. This code will be exercised by existing layout tests, and
by manually verifying that theme parts render as expected.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp: Added.

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
(WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
(WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h: Added.
  • rendering/RenderThemeChromiumAndroid.cpp: Added.

(WebCore::RenderThemeChromiumAndroid::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumAndroid::~RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumAndroid.h: Added.
  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):

04:09 Changeset [104138] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

  • platform/qt/Skipped:
03:40 Changeset [104137] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose Fixed Position Layout to WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=75556

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::shouldLayoutFixedElementsRelativeToFrame):
(WebKit::WebViewImpl::setShouldLayoutFixedElementsRelativeToFrame):

  • src/WebViewImpl.h:
03:33 Changeset [104136] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

unshift/pop fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75588

Reviewed by Zoltan Herczeg.

Buildfix after r104120.

  • runtime/JSArray.cpp: Remove useless asserts, baecause unsigned expression >= 0 is always true

(JSC::JSArray::unshiftCount):

03:24 Changeset [104135] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed gardening after r104134.

  • wtf/Assertions.cpp:
03:06 Changeset [104134] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed gardening after r75605.

Rubber stamped by NOBODY Csaba Osztrogonác.

  • wtf/Assertions.cpp:
02:57 Changeset [104133] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Source/WebCore: Fix potential superlinear runtime of multiple indirect adjenceny combinators.
https://bugs.webkit.org/show_bug.cgi?id=75083

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-05
Reviewed by Antti Koivisto.

A sequence of indirect adjencency combinator such as "li ~ li ~ la" could with the
former algorithm potentially do an quadratic number of element matches.
The recursive matching algorithm now detects cases where all siblings have
failed one indirect sibling match and fails the entire selector.

Test: perf/nested-combined-selectors.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Return SelectorFailsAllSiblings when
all siblings have failed a selector component.

  • css/SelectorChecker.h: Add SelectorFailsAllSiblings enum value

LayoutTests: Test of styling performance of selectors with multiple indirect combinators

https://bugs.webkit.org/show_bug.cgi?id=75083

Reviewed by Antti Koivisto.

  • perf/nested-combined-selectors.html: Added.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-05

02:56 Changeset [104132] by haraken@chromium.org
  • 4 edits in trunk/Tools

prepare-ChangeLog cannot parse python code that nests classes and defs
https://bugs.webkit.org/show_bug.cgi?id=75524

Reviewed by Ryosuke Niwa.

This patch fixes the python parser of prepare-ChangeLog so that it can parse
python code that nests classes and defs, like this:

class C:

pass
def f():

pass

pass

Also, this patch fixes the python parser so that it inserts a dummy line
at the end of the file to pop out all popped scopes.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:

Added test cases that nest classes and defs.
(func7):
(func7.func8):
(func7.func8.func9):
(Class2):
(Class2.Class3):
(Class2.Class3.Class4):
(Class5):
(Class5.func10):
(Class5.func11):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
02:20 Changeset [104131] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

InspectorStyleSheet: Avoid cloning CSSRuleLists.
<http://webkit.org/b/75603>

Reviewed by Ryosuke Niwa.

Don't filter out @charset rules from CSSRuleLists. This was forcing us to clone
the stylesheet rule list, and is unnecessary since InspectorStyleSheet disregards
any rule that isn't either a style rule or a rule with an internal rule list.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):

Don't pass omitCharsetRules=true to the CSSRuleList constructor.

02:18 Changeset [104130] by kling@webkit.org
  • 13 edits in trunk/Source/WebCore

Make elements with attributes smaller by eliminating the ref count in NamedNodeMap.
<http://webkit.org/b/75068>

Reviewed by Antti Koivisto.

Remove NamedNodeMap's inheritance from RefCounted and forward the ref()/deref()
calls to its owner Element, effectively reducing the size of an element that has
attributes by 4 bytes.

This reduces memory consumption by 311 kB when viewing the full HTML5 spec.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):

Added. Forwards the operation to m_element. Only ever used by the DOM wrappers.

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create):

  • dom/DocumentType.h:
  • dom/Element.cpp:

(WebCore::Element::parserSetAttributeMap):

  • dom/Element.h:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::takeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

Store NamedNodeMap in OwnPtr/PassOwnPtr, rather than RefPtr/PassRefPtr.

02:08 Changeset [104129] by carlosgc@webkit.org
  • 10 edits in trunk

[GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=75433

Reviewed by Martin Robinson.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadFail): Use webkit_web_view_replace_content().
(webkitWebViewLoadChanged): Do not emit load-changed signal when
replacing content.
(webkitWebViewLoadFailed): Do not emit load-failed signal when
replacing content.
(webkitWebViewSetEstimatedLoadProgress): Do not emit
notify::estimated-load-progress signal when replacing content.
(webkit_web_view_replace_content):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(beforeAll):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(replaceContentTitleChangedCallback):
(replaceContentLoadCallback):
(testWebViewReplaceContent):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::replaceContent):

  • UIProcess/API/gtk/tests/WebViewTest.h:

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewLoadFailed): Reset the progress bar when load fails.
(browserWindowConstructed): Connect to load-failed signal.

02:03 Changeset [104128] by noel.gordon@gmail.com
  • 2 edits
    3 moves
    4 adds in trunk/LayoutTests

[chromium] MAC: update expectations for CSS3 linear gradient tests
https://bugs.webkit.org/show_bug.cgi?id=55745

Reviewed by Stephen White.

  • platform/chromium-cg-mac-leopard/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-leopard/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stop-units-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-color-stops-expected.png.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png.
  • platform/chromium/test_expectations.txt:
01:38 Changeset [104127] by benjamin@webkit.org
  • 12 edits
    3 adds in trunk/Source

Improve charactersAreAllASCII() to compare multiple characters at a time
https://bugs.webkit.org/show_bug.cgi?id=74063

Reviewed by Darin Adler.

Source/JavaScriptCore:

A new header ASCIIFastPath.h contains the functions related to
the detection of ASCII by using machine words. Part of it comes from
WebCore's TextCodecASCIIFastPath.h.

The function charactersAreAllASCII() is moved to TextCodecASCIIFastPath.h
and is implemented with computer word comparison.
The gain over the previous implementation of charactersAreAllASCII() is of
the order of how many comparison are avoided (4x, 8x, 16x depending on the
format and the CPU type).

(WTF::isAlignedToMachineWord):
(WTF::alignToMachineWord):
(WTF::isAllASCII):
(WTF::charactersAreAllASCII):

  • wtf/text/WTFString.h:
  • wtf/wtf.pro:

Source/JavaScriptGlue:

Add forwarding header for ASCIIFastPath.h.

  • ForwardingHeaders/wtf/text/ASCIIFastPath.h: Added.

Source/WebCore:

Move some part of TextCodecASCIIFastPath.h to WTF in ASCIIFastPath.h.
The function isAllASCII() is changed to the template version which now works
with both LChar and UChar.

  • ForwardingHeaders/wtf/text/ASCIIFastPath.h: Added.
  • platform/text/TextCodecASCIIFastPath.h:

(WebCore::copyASCIIMachineWord):

  • platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::decode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

01:29 Changeset [104126] by ericu@chromium.org
  • 19 edits
    1 delete in trunk

[fileapi] WebKitFlags should not be constructable per Directories & System spec
https://bugs.webkit.org/show_bug.cgi?id=68916

Reviewed by Eric Seidel.

Source/WebCore:

Remove IDL for the object and all DOM references to it.

  • fileapi/WebKitFlags.idl: Removed.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl: Remove references to the JSC/V8 objects compiled from the IDL.
  • bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/js/JSDirectoryEntrySyncCustom.cpp: (WebCore::getFlags):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: (WebCore::getFlags): Fix up build files.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore/CMakeLists.txt:
  • WebCore/CodeGenerators.pri:
  • WebCore/DerivedSources.cpp:
  • WebCore/DerivedSources.make:
  • WebCore/GNUmakefile.list.am:

LayoutTests:

Remove a test that constructed the object; add one that tests error-handling for non-object parameters while I'm in there.

  • fast/filesystem/flags-passing-expected.txt:
  • fast/filesystem/script-tests/flags-passing.js:

Remove a special case reference to the global WebKitFlags constructor.

  • fast/dom/script-tests/prototype-inheritance.js:
01:16 Changeset [104125] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/75606> [Mac] WTF logging functions should output to both stderr and ASL

We should always log to both ASL and stderr on platforms where this won't result in launchd
duplicating the messages.

Reviewed by Dan Bernstein.

  • wtf/Assertions.cpp:

(vprintf_stderr_common):

01:16 Changeset [104124] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/75605> WTF logging functions should call vprintf_stderr_common only once per line

Several of the WTF logging functions make multiple calls to vprintf_stderr_common to output a
single line of text. This results in strangely formatted output if vprintf_stderr_common is
retargeted to an output device that is message-oriented (such as ASL) rather than stream-oriented
like stderr.

Reviewed by Dan Bernstein.

  • wtf/Assertions.cpp:

(vprintf_stderr_with_prefix): Helper function to prepend a given prefix on to the given format
string before handing it off to vprintf_stderr_common. This requires disabling warnings about
calling a printf-like function with a non-literal format string for this piece of code. It's
safe in this particular case as vprintf_stderr_with_prefix is only ever given a literal prefix.
(vprintf_stderr_with_trailing_newline): Helper function to append a trailling newline on to the
given format string if one does not already exist. It requires the same treatment with regards
to the non-literal format string warning.
(WTFReportAssertionFailureWithMessage): Switch to using vprintf_stderr_with_prefix.
(WTFReportBacktrace): Switch from calling fprintf directly to using fprintf_stderr_common.
(WTFReportFatalError): Switch to using vprintf_stderr_with_prefix.
(WTFReportError): Ditto.
(WTFLog): Switch to using vprintf_stderr_with_trailing_newline.
(WTFLogVerbose): Ditto.

00:54 WebKit Team edited by pfeldman@chromium.org
(diff)
00:53 WebKit Team edited by pfeldman@chromium.org
(diff)
00:51 Changeset [104123] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Crash due to first-letter block processing
https://bugs.webkit.org/show_bug.cgi?id=74009

Source/WebCore:

Fixing the way updateFirstLetter() finds the remaining text fragment
for a given first-letter. Previously this was unreliable in some
circumstances.

This patch provides a reliable mechanism to identify the remaining
text by storing first-letter to remaining text associations in a
hash map, managed by methods in RenderBoxModelObject.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter)

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::setFirstLetterRemainingText): Added
(WebCore::RenderBoxModelObject::firstLetterRemainingText): Added

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::setFirstLetterRemainingText): Added
(WebCore::RenderBoxModelObject::firstLetterRemainingText): Added

LayoutTests:

Test for crashing condition in 74009.

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • fast/css/first-letter-inline-flow-split-table-crash-expected.txt: Added
  • fast/css/first-letter-inline-flow-split-table-crash.html: Added
00:51 Changeset [104122] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[WK2][EFL] creating dummy functions for Download class on Efl port.
https://bugs.webkit.org/show_bug.cgi?id=75246

dummy functions for Download class on Efl port

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-01-05
Reviewed by Hajime Morita.

  • PlatformEfl.cmake: add new file to compile
  • WebProcess/Downloads/efl: Added.
  • WebProcess/Downloads/efl/DownloadEfl.cpp: Added.

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
(WebKit::Download::useCredential):
(WebKit::Download::continueWithoutCredential):
(WebKit::Download::cancelAuthenticationChallenge):

00:41 WebKit Team edited by ryuan.choi@samsung.com
(diff)
00:34 Changeset [104121] by mihnea@adobe.com
  • 6 edits
    2 adds in trunk

Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
https://bugs.webkit.org/show_bug.cgi?id=74781

Reviewed by David Hyatt.

Test: fast/regions/region-range-for-box-crash.html

This patch fixes 2 issues:

  1. When removing a region from a flow thread, we clear the region range information for boxes since

this information is accurate only after the regions are laid out.

  1. While the regions are invalidated (content of flow thread is not yet laid out in regions), the

functions that ask for properties of content in regions should bail out early.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::logicalWidthChangedInRegions):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderFlowThread.h:

LayoutTests: Crash in RenderFlowThread::getRegionRangeForBox.
https://bugs.webkit.org/show_bug.cgi?id=74781

Reviewed by David Hyatt.

  • fast/regions/region-range-for-box-crash-expected.txt: Added.
  • fast/regions/region-range-for-box-crash.html: Added.
00:00 Changeset [104120] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

unshift/pop fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75588

Reviewed by Sam Weinig.

The Array object commonly store data in a vector, consisting of a portion that
is in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to pop with grow the post-capacity, and the
current algorithm for increasePrefixVectorLength (used by unshift) will never
stink the post-capacity, so a unshift/pop fifo may consume an inordinate amount
of memory, whilst having a relatively small active length.

  • runtime/JSArray.cpp:

(JSC::storageSize):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::SparseArrayValueMap::put):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::JSArray::increaseVectorLength):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::JSArray::unshiftCountSlowCase):

  • renamed from increaseVectorPrefixLength (this was a bad name, since it also moved the ArrayStorage header), rewritten.

(JSC::JSArray::shiftCount):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned

(JSC::JSArray::unshiftCount):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned, increaseVectorPrefixLength renamed to unshiftCountSlowCase

(JSC::JSArray::sortNumeric):

  • runtime/JSArray.h:
    • Updated function declarations, m_indexBias should be unsigned.
Note: See TracTimeline for information about the timeline view.