Timeline


and

01/11/12:

23:56 Changeset [104796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Rename parameter and variable name 'r' to 'rect' in IntRectEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=76140

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-11
Reviewed by Andreas Kling.

No new tests : Just for change of parameter and variable name.

  • platform/graphics/efl/IntRectEfl.cpp:

(WebCore::IntRect::IntRect):
(WebCore::IntRect::operator Eina_Rectangle):

23:48 Changeset [104795] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Update skipped file for layout test of EFL port.
https://bugs.webkit.org/show_bug.cgi?id=76024

Reviewed by Andreas Kling.

test_expectations.txt for EFL port is now containing list of skipped test cases.
But, I could notice that file 'Skipped' is proper location for the skipped test case.

In addition, some additional test cases are added to Skipped file.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
23:18 Changeset [104794] by mikelawther@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896

Reviewed by Ryosuke Niwa.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
  • css3/calc/block-mask-overlay-image-outset.html: Added.
  • css3/calc/resources/mask.png: Added.
23:14 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
23:07 Changeset [104793] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

QuerySelector should not have side effect.
https://bugs.webkit.org/show_bug.cgi?id=75298

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-11
Reviewed by Antti Koivisto.

Since SelectorChecker is not collecting-rules-only mode, it may set some flags in render styles
if some pseudo types (e.g. first-of-type) are used.

No new tests. Covered by existing tests.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):

Made collecting rules only.

22:58 Changeset [104792] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Web process should use the same locale than UI process
https://bugs.webkit.org/show_bug.cgi?id=76054

Reviewed by Gustavo Noronha Silva.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::childSetupFunction): Make child process use the same
locale than its parent.

22:47 Changeset [104791] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Add WebArrayBuffer support in WebSocket to WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=75080

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-01-11
Reviewed by Darin Fisher.

  • public/WebSocket.h: Add interface to send WebArrayBuffer, and set and get receiving binary object type.
  • public/WebSocketClient.h: Add interface to receive WebArrayBuffer.

(WebKit::WebSocketClient::didReceiveArrayBuffer):

  • src/WebSocketImpl.cpp: Add various binary types handling.

(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::binaryType):
(WebKit::WebSocketImpl::setBinaryType):
(WebKit::WebSocketImpl::sendArrayBuffer):
(WebKit::WebSocketImpl::didReceiveBinaryData):

  • src/WebSocketImpl.h: Add methods to handle various binary types.
22:38 Changeset [104790] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Baseline for new test added in http://trac.webkit.org/changeset/104786

Unreviewed.

  • platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt: Added.
21:52 Changeset [104789] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

21:42 Changeset [104788] by lforschler@apple.com
  • 1 copy in tags/Safari-535.16

New Tag.

20:33 Changeset [104787] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

CodeBlock::m_executeCounter should be renamed to CodeBlock::m_jitExecuteCounter
https://bugs.webkit.org/show_bug.cgi?id=76144
<rdar://problem/10681711>

Rubber stamped by Gavin Barraclough.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

20:29 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
20:29 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
20:28 WebKitEFLLayoutTest created by gyuyoung.kim@samsung.com
20:15 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
20:10 Changeset [104786] by mitz@apple.com
  • 22 edits
    3 adds in trunk

<rdar://problem/10679035> Implement font-variant-ligatures: {no-}common-ligatures
https://bugs.webkit.org/show_bug.cgi?id=76103

Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/css/parsing-font-variant-ligatures.html

fast/text/font-variant-ligatures-expected.html
fast/text/font-variant-ligatures.html

Added support for all font-variant-ligatures values in the style system and in
FontDescription, and made the {no-}common-ligatures value keywords control basic ligatures.
The {no-}{discretionary,historical}-ligatures keywords have no effect on rendering at this
time.

font-variant-ligatures was not made part of the font shorthand property.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added code to handle
font-variant-ligatures.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added code to handle font-variant-ligatures.
(WebCore::CSSParser::parseFontVariantLigatures): Added. Parses font-variant-ligatures.

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Added font-variant-ligatures to the set of
inherited properties.

  • css/CSSPropertyNames.in: Added -webkit-font-variant-ligatures.
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): Added. Copies
{common,discretionary,historical}LigaturesState from the parent style font description.
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): Added. Sets
{common,discretionary,historical}LigaturesState to normal.
(WebCore::ApplyPropertyFontVariantLigatures::applyValue): Added.
(WebCore::ApplyPropertyFontVariantLigatures::createHandler): Added.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added a handler for
font-variant-ligatures.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration): Updated for the number of properties that
affect the font.
(WebCore::CSSStyleSelector::applyProperty): Added CSSPropertyWebkitFontVariantLigatures to
the switch statement, which needs to list all values in SVG-disabled builds.

  • css/CSSValueKeywords.in: Added the value keywords

{no-}{common,discretionary,historical}-ligatures.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Changed to enable ligatures if common ligatures are
enabled in the font description, disable them if they are disabled, and leave them to the
default (determined by the text-rendering property) if they are in the normal state.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Added initializers.
(WebCore::FontDescription::commonLigaturesState): Added this accessor.
(WebCore::FontDescription::discretionaryLigaturesState): Ditto.
(WebCore::FontDescription::historicalLigaturesState): Ditto.
(WebCore::FontDescription::setCommonLigaturesState): Ditto.
(WebCore::FontDescription::setDiscretionaryLigaturesState): Ditto.
(WebCore::FontDescription::setHistoricalLigaturesState): Ditto.
(WebCore::FontDescription::operator==): Updated to compare the ligatures state members.

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/parsing-font-variant-ligatures.html: Added.
  • fast/text/font-variant-ligatures-expected.html: Added.
  • fast/text/font-variant-ligatures.html: Added.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
19:55 Changeset [104785] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Overflow on flexitems doesn't work
https://bugs.webkit.org/show_bug.cgi?id=70979

Reviewed by Ojan Vafai.

Add test cases for flex items that overflow. There should be
non-disabled scrollbars.

  • css3/flexbox/child-overflow-expected.html: Added.
  • css3/flexbox/child-overflow.html: Added.
19:53 Changeset [104784] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Merge 'Getter'/'Setter' attributes into 'Accessor'
https://bugs.webkit.org/show_bug.cgi?id=76141

Reviewed by Filip Pizlo.

These are currently ambiguous (and used inconsistently). It would logically appear
that either being bit set implies that the corresponding type of accessor is present
but (a) we don't correctly enforce this, and (b) this means the attributes would not
be able to distinguish between a data descriptor and an accessor descriptor with
neither a getter nor setter defined (which is a descriptor permissible under the spec).
This ambiguity would lead to unsafe property caching behavior (though this does not
represent an actual current bug, since we are currently unable to create descriptors
that have neither a getter nor setter, it just prevents us from doing so).

  • runtime/Arguments.cpp:

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::JSArray::putDescriptor):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorDefineProperty):

  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
(JSC::PropertyDescriptor::setSetter):
(JSC::PropertyDescriptor::setGetter):
(JSC::PropertyDescriptor::attributesOverridingCurrent):

19:53 Changeset [104783] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

margin test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76000

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/margin-expected.txt: Added.
  • css3/calc/margin.html: Added.
19:46 Changeset [104782] by enne@google.com
  • 5 edits
    3 adds in trunk

Repaint all graphics layers when their renderer offset changes
https://bugs.webkit.org/show_bug.cgi?id=75730

Reviewed by Simon Fraser.

Source/WebCore:

In RenderLayerBacking, only the main graphics layer gets repainted
when the offset changes. If the offset on other graphics layers (e.g.
the foreground layer) changes, they should get repainted as well.

Test: compositing/geometry/foreground-offset-change.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setOffsetFromRenderer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

  • platform/graphics/GraphicsLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

  • compositing/geometry/foreground-offset-change-expected.png: Added.
  • compositing/geometry/foreground-offset-change-expected.txt: Added.
  • compositing/geometry/foreground-offset-change.html: Added.
18:30 Changeset [104781] by dimich@chromium.org
  • 12 edits in trunk/LayoutTests

[Chromium] Rebaseline test images for input controls
after http://src.chromium.org/viewvc/chrome?view=rev&revision=117217
https://bugs.webkit.org/show_bug.cgi?id=76134

Unreviewed.

  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
18:26 Changeset [104780] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] TiledLayerChromium drops invalidates that occur during
LayerTextureUpdater::prepareToUpdate
https://bugs.webkit.org/show_bug.cgi?id=76067

Patch by Scott Violet <sky@google.com> on 2012-01-11
Reviewed by James Robinson.

Source/WebCore:

Test coverage in TiledLayerChromiumTest.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::prepareCount):
(WTF::FakeLayerTextureUpdater::clearPrepareCount):
(WTF::FakeLayerTextureUpdater::lastUpdateRect):
(WTF::FakeTiledLayerChromium::fakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::setRectToInvalidate):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):

18:03 Changeset [104779] by eae@chromium.org
  • 29 edits in branches/subpixellayout/LayoutTests/platform/mac-snowleopard/fast/forms

Updated test expectations for mac for a couple of form tests.

17:57 Changeset [104778] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[JSC] Remove redundant arguments from [Supplemental] custom methods
https://bugs.webkit.org/show_bug.cgi?id=76127

Reviewed by Adam Barth.

Since in JSC a callback of custom methods is non-static, we do not need
to pass a pointer of an implementation object.

Before (JSTestInterface.cpp):

JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
{

JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));
TestInterface* impl = static_cast<TestInterface*>(castedThis->impl());
return castedThis->supplementalStr3(impl, exec);

}

After (JSTestInterface.cpp):

JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
{

JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));

return castedThis->supplementalStr3(exec); JSTestInterface knows 'impl'.

}

Tests: bindings/scripts/test/TestInterface.idl

http/tests/websocket/tests/*
webaudio/*

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Previously when we specify [CustomGetter, CustomSetter], the header for
the custom setter was not generated. This patch fixes the bug.
(GenerateImplementation):

  • bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed redundant DOMWindow* from webkitAudioContext().

(WebCore::JSDOMWindow::webkitAudioContext):

  • bindings/js/JSDOMWindowWebSocketCustom.cpp: Removed redundant DOMWindow* from webSocket().

(WebCore::JSDOMWindow::webSocket):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.

(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalStr3):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
17:30 Changeset [104777] by barraclough@apple.com
  • 5 edits in trunk

Object.defineProperty([], 'length', {}) should not make length read-only
https://bugs.webkit.org/show_bug.cgi?id=76097

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • We should be checking writablePresent().

LayoutTests:

  • fast/js/array-defineOwnProperty-expected.txt:
  • fast/js/script-tests/array-defineOwnProperty.js:
    • Added test.
17:29 Changeset [104776] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Share cairo specific codes with EFL port.
https://bugs.webkit.org/show_bug.cgi?id=75457

Reviewed by Brent Fulgham.

Change PLATFORM(GTK) to USE(CAIRO) in WebGraphicsContext{h,cpp} to share
with EFL port.

  • Shared/WebGraphicsContext.cpp:

(WebKit::WebGraphicsContext::WebGraphicsContext):

  • Shared/WebGraphicsContext.h:
17:24 Changeset [104775] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
https://bugs.webkit.org/show_bug.cgi?id=76120

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/forms/no-autofocus-in-sandbox.html

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • The HTML5 spec says that we shouldn't autofocus elements when the automatic features are sandboxed.

LayoutTests:

  • fast/forms/no-autofocus-in-sandbox-expected.txt: Added.
  • fast/forms/no-autofocus-in-sandbox.html: Added.
17:23 Changeset [104774] by fpizlo@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Code duplication for invoking the JIT and DFG should be reduced
https://bugs.webkit.org/show_bug.cgi?id=76117
<rdar://problem/10680189>

Rubber stamped by Geoff Garen.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITDriver.h: Added.

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

17:17 Changeset [104773] by bdakin@apple.com
  • 9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=75904
WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all
the time
-and corresponding-
<rdar://problem/10498816>

Reviewed by Darin Adler.

Source/WebCore:

This patch gets rid of the optional parameter called onlyUpdateScrollbars for
mouseMoved() and instead moves that functionality into its own function
called passMouseMovedEventToScrollbars().

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::passMouseMovedEventToScrollbars):

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseMovedEventToScrollbars):

Source/WebKit/mac:

New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we
have one.

  • WebView/WebHTMLView.mm:

(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLViewPrivate clear]):

When we know that mouse movements won't affect anything other than
scrollbars, call our new function passMouseMovedEventToScrollbars(),
otherwise we'll call the old mouseMoved().
(mouseEventIsPartOfClickOrDrag):
(-[WebHTMLView _updateMouseoverWithEvent:]):

Make sure not to remove the mouse observer when there are legacy scrollbars.
(-[WebHTMLView removeMouseMovedObserver]):

Set up a tracking area when the window is not key to ensure that the WebView
gets the relevant events. Remove it when the window is key again so that we
rely on the existing mechanism.
(-[WebHTMLView windowDidBecomeKey:]):
(-[WebHTMLView windowDidResignKey:]):

Source/WebKit2:

This patch gets rid of the optional parameter called onlyUpdateScrollbars for
WebCore::EventHandler::mouseMoved() and instead moves that functionality into
its own function called passMouseMovedEventToScrollbars().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

17:17 WebKit Team edited by haraken@chromium.org
(diff)
17:15 Changeset [104772] by kbr@google.com
  • 2 edits
    2 copies in branches/chromium/963

Merge 104736 - [v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-11
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/9186030

17:02 Changeset [104771] by commit-queue@webkit.org
  • 18 edits in trunk

IndexedDB: Methods should throw TRANSACTION_INACTIVE_ERR when transaction is completed/aborted
https://bugs.webkit.org/show_bug.cgi?id=76108

Source/WebCore:

Updated IDBDatabaseException error codes to match spec (the pre-DOM4 version),
including updated description strings, and changed relevant store and index
methods to raise the expected exception type now that it is detailed in the spec.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-11
Reviewed by Tony Chang.

Tests: storage/indexeddb/transaction-basics.html

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):

  • storage/IDBDatabaseException.cpp:
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::count):

LayoutTests:

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-11
Reviewed by Tony Chang.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
17:00 Changeset [104770] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Bytecode dumping is broken for call opcodes (due to two new operands)
https://bugs.webkit.org/show_bug.cgi?id=75886

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp): Made a helper function, so I wouldn't have
to fix this more than once. The helper function skips the extra two operands
at the end of the opcode, used for optimization.

(JSC::CodeBlock::dump): Used the helper function.

  • bytecode/CodeBlock.h: Declared the helper function.
17:00 Changeset [104769] by kbr@google.com
  • 1 edit
    3 copies in branches/chromium/963

Merge 104732 - [chromium] Color profiles are incorrect for images without premultiplied alpha
https://bugs.webkit.org/show_bug.cgi?id=75999

Reviewed by Stephen White.

Source/WebCore:

Don't apply the color profile if the user has requested separate alpha.

Test: fast/canvas/webgl/texture-color-profile.html

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::setStatus):

LayoutTests:

Verify that the image's contents don't get destroyed if using both
separate alpha as well as the browser's colorspace conversion.

  • fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
  • fast/canvas/webgl/texture-color-profile-expected.txt: Added.
  • fast/canvas/webgl/texture-color-profile.html: Added.

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/9187038

16:58 Changeset [104768] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: push more logic into webkitpy.test.main, clean up code
https://bugs.webkit.org/show_bug.cgi?id=76021

Reviewed by Eric Seidel.

I plan to add more functionality to test-webkitpy, but it is
difficult to hack on now; this patch is the first of two that
brings test-webkitpy more inline with current coding style by
pushing more logic into the webkitpy.test.main.Tester class (so
that it will be testable itself).

There should be no functional changes in this patch.

  • Scripts/test-webkitpy:

(_path_from_webkit_root):

  • Scripts/webkitpy/test/main.py:

(Tester):
(Tester.init):
(Tester.configure_logging):
(Tester.configure_logging.filter):
(Tester.clean_packages):
(Tester.run_tests):

16:56 Changeset [104767] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

Implement the [Supplemental] IDL for custom methods
https://bugs.webkit.org/show_bug.cgi?id=76036

Reviewed by Adam Barth.

We have implemented the [Supplemental] IDL for non-custom methods in bug 75944.
This patch implements it for custom methods. This patch modifies only CodeGeneratorV8.pm,
since CodeGeneratorJS.pm requires no change and other code generators
do not support custom methods.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/TestSupplemental.idl: Added a custom method with the [Supplemental] IDL.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.

(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface supplementalMethod3]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
16:51 Changeset [104766] by leviw@chromium.org
  • 8 edits in branches/subpixellayout/LayoutTests

Updating and rebaselining remaining failing fast/dom tests.

16:48 Changeset [104765] by kbr@google.com
  • 1 edit in branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

Merge 104636 - [chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912

Patch by John Bauman <jbauman@chromium.org> on 2012-01-10
Reviewed by Kenneth Russell.

Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.

No new tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::maybeRestoreContext):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/9148050

16:26 Changeset [104764] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

implement layout tests for <video> with media stream
https://bugs.webkit.org/show_bug.cgi?id=74882

Patch by Wei Jia <wjia@chromium.org> on 2012-01-11
Reviewed by Kent Tamura.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.

(WebKit::WebUserMediaClientMock::create):
(WebKit::WebUserMediaClientMock::IsMockStream):
(WebKit::WebUserMediaClientMock::requestUserMedia):
(WebKit::WebUserMediaClientMock::cancelUserMediaRequest):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.

(WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebKit::WebUserMediaClientMock::WebUserMediaClientMock):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::userMediaClient):
(WebViewHost::userMediaClientMock):
(WebViewHost::createMediaPlayer):
(WebViewHost::mediaStreamUtil):
(WebViewHost::testMediaStreamClient):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • platform/chromium/media/video-capture-preview-expected.txt: Added.
  • platform/chromium/media/video-capture-preview.html: Added.
16:24 Changeset [104763] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, build fix.

Fix chromium-win's version remapping to work correctly on Win 7 SP1.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):

16:14 Changeset [104762] by ggaren@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
https://bugs.webkit.org/show_bug.cgi?id=75911

Source/JavaScriptCore:

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNodeForLeftHandSide): Cleanup: No need to
explicitly cast to our return type in C++.

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode): Make sure to copy our function
into a temporary register before evaluating our arguments, since argument
evaluation might include function calls or assignments that overwrite our callee by name.

LayoutTests:

Reviewed by Filip Pizlo.

  • fast/js/function-argument-evaluation-expected.txt: Added.
  • fast/js/function-argument-evaluation.html: Added.
16:08 Changeset [104761] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable
https://bugs.webkit.org/show_bug.cgi?id=76085

Reviewed by Eric Seidel.

As far as I can tell, the IETC test of this feature is wrong.
NETWORK_NO_SOURCE should be immutable on the interface object and on
the interface prototype object, but JavaScript should be able to shadow
the property on an instance.

  • media/network-no-source-const-shadow-expected.txt: Added.
  • media/network-no-source-const-shadow.html: Added.
16:07 Changeset [104760] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Sheriffbot build fix. Don't emit empty lines on IRC.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(LastGreenRevision.execute):

16:02 Changeset [104759] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r88479.

15:57 Changeset [104758] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix build issue on Windows when Qt is configured with -ltcg

https://bugs.webkit.org/show_bug.cgi?id=75003

Patch by Shaw Andy <andy.shaw@digia.com> on 2011-12-21
Rubber-stamped by Simon Hausmann.

  • WebCore.pri:
15:56 Changeset [104757] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Eric Seidel.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintTextField):

LayoutTests: iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
https://bugs.webkit.org/show_bug.cgi?id=76111

Reviewed by Eric Seidel.

Test based on video-no-autoplay.html.

  • media/no-auto-play-in-sandbox-expected.txt: Added.
  • media/no-auto-play-in-sandbox.html: Added.
  • media/resources/no-auto-play-in-sandbox-iframe.html: Added.
15:54 Changeset [104756] by japhet@chromium.org
  • 6 edits in trunk/Source/WebCore

SubresourceLoader cleanup post r100311.

  1. Simplify matching incrementRequestCount()/decrementRequestCount() calls.
  2. Remove CachedImage custom code from SubresourceLoader.
  3. Add a bunch of ASSERTs.
  4. Remove the multipart-only call to didReceiveData() from didReceiveResponse(), since didReceiveData() would get called immediately after anyway.

https://bugs.webkit.org/show_bug.cgi?id=75887

Reviewed by Adam Barth.

No new tests, refactor only.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Remove multipart special case, handle it in didReceiveData().
(WebCore::SubresourceLoader::didReceiveData): Handle multipart state here, since we will receive only one

didReceiveData() call per multipart segment, but no didFinishLoading() call.

  • loader/SubresourceLoader.h: Add a RequestCountTracker subclass to reduce complexity of ensuring we don't

decrement request count twice on CachedResourceLoader.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::setResponse): Move CachedImage::clear() call out of SubresourceLoader, since it's

kind of a layering violation as is.

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
15:51 Changeset [104755] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

IndexedDB: Version change transaction should abort if constraints fail during createIndex
https://bugs.webkit.org/show_bug.cgi?id=76094

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-11
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/index-population.html

  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):

  • storage/IDBObjectStoreBackendImpl.cpp:

LayoutTests:

  • storage/indexeddb/index-population-expected.txt: Added.
  • storage/indexeddb/index-population.html: Added.
15:46 Changeset [104754] by rniwa@webkit.org
  • 7 edits in trunk/Tools

last-green-revision should report the revision that succeeded on all bots
https://bugs.webkit.org/show_bug.cgi?id=76109

Reviewed by Adam Barth.

Add an algorithm to find the last known good revision among the specified bots. For a revision to be
considered green by this algorithm, all matching builders must have a successful run at the revision
or two consecutive successful runs before and after the revision.

Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
that resulted in an exception when the user didn't pass BUILDER_NAME argument.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._revisions_for_builder):
(BuildBot):
(BuildBot._find_green_revision):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_revisions_for_builder):
(test_find_green_revision):
(test_last_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(LastGreenRevision.execute):

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_lgr):

  • Scripts/webkitpy/tool/commands/queries.py:

(LastGreenRevision):

15:42 Changeset [104753] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, fix build bustage on win32 introduced by r104725.

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockChromiumDRTTest.test_pixeltestfails):

15:27 Changeset [104752] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

line height test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75998

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/line-height-expected.txt: Added.
  • css3/calc/line-height.html: Added.
15:27 Changeset [104751] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

v8-regexp spends 35% of its time allocating and copying internal regexp results data
https://bugs.webkit.org/show_bug.cgi?id=76079

Reviewed by Geoffrey Garen.

Added a new RegExpResults struct that has the input string, the number of
subexpressions and the output vector. Changed RegExpConstructor to
include a RegExpConstructorPrivate instead of having a reference to one.
Changed RegExpMatchesArray to include a RegExpResults instead of a
reference to a RegExpConstructorPrivate. Created an overloaded assignment
operator to assign a RegExpConstructorPrivate to a RegExpResults.
Collectively this change is worth 24% performance improvement to v8-regexp.

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpResult::operator=):
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):
(JSC::RegExpMatchesArray::~RegExpMatchesArray):
(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::arrayOfMatches):
(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):
(JSC::RegExpConstructor::setInput):
(JSC::RegExpConstructor::input):
(JSC::RegExpConstructor::setMultiline):
(JSC::RegExpConstructor::multiline):

  • runtime/RegExpConstructor.h:

(JSC::RegExpResult::RegExpResult):
(JSC::RegExpConstructor::performMatch):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):

15:15 Changeset [104750] by commit-queue@webkit.org
  • 4 edits in trunk

Typo in error message: Unexpected token 'defualt'
https://bugs.webkit.org/show_bug.cgi?id=75105

Patch by Eugene Girard <girard@google.com> on 2012-01-11
Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • parser/Parser.h:

(JSC::Parser::getTokenName):

LayoutTests:

  • fast/js/reserved-words-as-property-expected.txt:
15:04 Changeset [104749] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix duplicate expectations from r104715.
This was causing the Chromium Windows tests not to run.

  • platform/chromium/test_expectations.txt:
14:44 Changeset [104748] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

Switch web intents to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76092

Patch by Greg Billock <gbillock@google.com> on 2012-01-11
Reviewed by Adam Barth.

  • Modules/intents/DOMWindowIntents.idl: Added.
  • WebCore.gypi:
  • page/DOMWindow.idl:
14:35 Changeset [104747] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

Rename HTMLInputElement::setDefaultName to setInitialName.
https://bugs.webkit.org/show_bug.cgi?id=76039

Reviewed by Darin Adler.

Source/WebCore:

Rename setDefaultName to setInitialName, make it protected, and add two
assertions.

This change should not change any behavior.

Test: fast/forms/isindex-name.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setInitialName):

  • Renamed from setDefaultName.
  • Add assertions.
  • html/HTMLInputElement.h:

Rename setDefaultName to setInitialName, and move it to protected.

  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
Update a setDefaultName callsite.
(WebCore::HTMLIsIndexElement::parseMappedAttribute):
A style fix.

LayoutTests:

  • fast/forms/isindex-name-expected.txt: Added.
  • fast/forms/isindex-name.html: Added.
14:13 Changeset [104746] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=76088
The common case of content type = text/plain is not optimized and the plugin database is initialized instead

In the dom/DOMImplementation.cpp file you can find the comment that text/plain is
optimized so that the plugin database is not loaded. Unfortunately, this has been
regressed since the patch for http://bugs.webkit.org/show_bug.cgi?id=16815 which
refactored a bunch of the plugin code. Now, the plugin database is initialized
before we handle text/plain. This line in DOMImplementation.cpp triggers
the plugin initialization:

pluginData = frame->page()->pluginData();

The case of image types != PDF and the case of HTML5 video content type are also
not optimized to be handled before plugin initialization.

The solution is to refactor so all of these content types are handled before
we initialize the plugin database.

Patch by Adam Treat <atreat@rim.com> on 2012-01-11
Reviewed by Adam Treat.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

14:10 Changeset [104745] by jochen@chromium.org
  • 2 edits in trunk/Tools

[Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
https://bugs.webkit.org/show_bug.cgi?id=75618

Eventually, we should get away from setting the display's color profile, as the mac port is doing now.

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestHelper.mm:

(installLayoutTestColorProfile):
(restoreUserColorProfile):
(main):

14:01 Changeset [104744] by andersca@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Assertion failure in JSC::allocateCell trying to allocate a JSString
https://bugs.webkit.org/show_bug.cgi?id=76101

Reviewed by Adam Roben.

Remove the ExecutableBase::s_info and JSString::s_info static member variables from the .def file and
export them explicitly using the JS_EXPORTDATA macro.

member variables explicitly using

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Executable.h:
  • runtime/JSString.h:
13:52 Changeset [104743] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build correction.

  • UIProcess/WebPageProxy.h: Don't define viewWidget for WinCairo port.
13:52 Changeset [104742] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[chromium] Make Skia canvas opaque for root layer tiles
https://bugs.webkit.org/show_bug.cgi?id=75939

Patch by Alexandre Elias <aelias@google.com> on 2012-01-11
Reviewed by James Robinson.

Skia has extra optimizations if a bitmap has the "opaque" flag -- in
particular, it doesn't do an unnecessary memset at creation time.
Pass down the LayerChromium's opaque flag to Skia.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::setIsNonCompositedContent):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::setIsNonCompositedContent):

  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::PlatformCanvas):
(WebCore::PlatformCanvas::resize):

  • platform/graphics/chromium/PlatformCanvas.h:

(WebCore::PlatformCanvas::setOpaque):
(WebCore::PlatformCanvas::opaque):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setIsNonCompositedContent):

13:43 Changeset [104741] by eae@chromium.org
  • 1713 edits
    790 copies
    182 deletes in branches/subpixellayout

Merging trunk changes up until 104725 into subpixel branch.

13:42 Changeset [104740] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy: fix -v and eliminate some spurious warnings
https://bugs.webkit.org/show_bug.cgi?id=76099

Reviewed by Adam Barth.

when we added support for --xml output, we broke the -v flag.

Also, fix the code to swallow a harmless warning from
VCSUtils.pm and fix a deprecated warning in jsonchecker.py.

test-webkitpy is now silent again except for the one known
logging issue.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit):

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(test_commit_message_for_this_commit):

  • Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONChecker.check):
(JSONChecker.line_number_from_json_exception):

  • Scripts/webkitpy/test/main.py:

(Tester.run_tests):

13:36 Changeset [104739] by dpranke@chromium.org
  • 8 edits in trunk/Tools

webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
https://bugs.webkit.org/show_bug.cgi?id=76084

Reviewed by Adam Barth.

This will help make it easier to catch layering violations. This
change just refactors test code; there are no changes to
production code.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.make_port):
(PortTest.test_find_no_paths_specified):
(PortTest.test_find_one_test):
(PortTest.test_find_glob):
(PortTest.test_find_with_skipped_directories):
(PortTest.test_find_with_skipped_directories_2):
(PortTest.test_parse_reftest_list):
(PortTest.test_httpd_returns_error_code):
(PortTest.test_virtual_methods):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest._assert_baseline_path):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths.test_paths):
(ChromiumGpuTest.test_test_files):
(ChromiumGpuTest.test_test_files.test_paths):
(ChromiumGpuTest):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_check_illegal_port_names):
(ChromiumLinuxPortTest.test_determine_architecture_fails):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.make_port):
(DriverTest):
(DriverTest.assertVirtual):
(DriverTest._assert_wrapper):
(DriverTest.test_virtual_driver_methods):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockDRTPortTest.test_port_name_in_constructor):
(MockDRTTest.assertTest):
(MockDRTTest.test_main):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(WebKitPortUnitTests.test_default_options):
(test_runtime_feature_list):
(test_test_expectations):

13:23 Changeset [104738] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[BlackBerry] ASSERT failure in BackingStorePrivate::blitVisibleContents()
https://bugs.webkit.org/show_bug.cgi?id=76096

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-01-11
Reviewed by Rob Buis.

We shouldn't blit visible contents for direct rendering. Guard it from
call sites.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):

13:12 Changeset [104737] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Webaudio layout tests need to override the WebKitWebAudioEnabled
https://bugs.webkit.org/show_bug.cgi?id=76066

Patch by Raymond Toy <rtoy@google.com> on 2012-01-11
Reviewed by Tony Chang.

  • webaudio/convolution-mono-mono.html:

Load audio-testing.js to add override for WebKitWebAudioEnabled.

13:06 Changeset [104736] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-11
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
12:55 Changeset [104735] by ojan@chromium.org
  • 3 edits in trunk/Tools

Style skipped tests in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=76091

Reviewed by Tony Chang.

  • TestResultServer/static-dashboards/dashboard_base.js:

Removed "FLAKY" from this list since we don't ever mark individual runs
as flaky. Also deleted an outdated line.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
12:41 Changeset [104734] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Coverity] Address some uninit constructor issues in WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=74977

Patch by Greg Billock <gbillock@google.com> on 2012-01-11
Reviewed by Ryosuke Niwa.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):

  • dom/DeviceMotionData.cpp:

(WebCore::DeviceMotionData::DeviceMotionData):

  • dom/DeviceOrientation.cpp:

(WebCore::DeviceOrientation::DeviceOrientation):

12:38 Changeset [104733] by ojan@chromium.org
  • 3 edits in trunk/Tools

Remove gtest normalization code from the test results server
https://bugs.webkit.org/show_bug.cgi?id=76089

Reviewed by Tony Chang.

The normalization now happens on the gtest side.

  • TestResultServer/model/jsonresults.py:

(JsonResults.merge):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_gtest):

12:17 Changeset [104732] by kbr@google.com
  • 3 edits
    3 adds in trunk

[chromium] Color profiles are incorrect for images without premultiplied alpha
https://bugs.webkit.org/show_bug.cgi?id=75999

Reviewed by Stephen White.

Source/WebCore:

Don't apply the color profile if the user has requested separate alpha.

Test: fast/canvas/webgl/texture-color-profile.html

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::setStatus):

LayoutTests:

Verify that the image's contents don't get destroyed if using both
separate alpha as well as the browser's colorspace conversion.

  • fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
  • fast/canvas/webgl/texture-color-profile-expected.txt: Added.
  • fast/canvas/webgl/texture-color-profile.html: Added.
12:01 Changeset [104731] by ojan@chromium.org
  • 3 edits in trunk/Tools

Be more aggressive about deleting unnecessary results from the test-results-server json files
https://bugs.webkit.org/show_bug.cgi?id=76086

Reviewed by Tony Chang.

Remove any tests that only contain skip/pass/nodata values whose runtime
is less than 5 seconds.

  • TestResultServer/model/jsonresults.py:

(JsonResults._normalize_results_json):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_remove_test):
(JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):

11:57 Changeset [104730] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

Rounding accumulatedOffset in nodeAtPoint when entering an SVG context to properly align to the root's actual rendering area

11:53 Changeset [104729] by rniwa@webkit.org
  • 7 edits in trunk/Tools

last-green-revision should give us per-bot information
https://bugs.webkit.org/show_bug.cgi?id=76011

Reviewed by Adam Barth.

Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
we report the latest green run on each bot from the last 100 runs.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._fetch_builder_page):
(BuildBot):
(BuildBot._green_revision_for_builder):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_green_revision_for_builder):
(test_last_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(LastGreenRevision.execute):

  • Scripts/webkitpy/tool/commands/queries.py:

(LastGreenRevision.execute):

11:49 Changeset [104728] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][Texmap] LayoutTests/compositing/masks/masked-ancestor does not render correctly.
https://bugs.webkit.org/show_bug.cgi?id=75910

Reviewed by Simon Hausmann.

Handle the mask surface correctly when drawing in two passes. Also, improve the readability
of the code that decides whether to draw in two passes.

LayoutTests/compositing/masks/masked-ancestor.html tests this.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::hasMoreThanOneTile):
(WebCore::TextureMapperNode::paintRecursive):

  • platform/graphics/texmap/TextureMapperNode.h:
11:38 Changeset [104727] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Webpages flash white when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=76080
<rdar://problem/9893565>

Reviewed by Dan Bernstein.

Introduce a _windowHasValidBackingStore boolean and only paint the background (white or clear)
if it's false.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
Set _windowHasValidBackingStore to false if the new size is different from the old size.

(-[WKView viewDidMoveToWindow]):
Set _windowHasValidBackingStore to false.

(-[WKView _windowDidMiniaturize:]):
Set _windowHasValidBackingStore to false.

(-[WKView _windowDidChangeBackingProperties:]):
Set _windowHasValidBackingStore to false.

(-[WKView drawRect:]):
Only call drawPageBackground if _windowHasValidBackingStore is false. Set it to true after painting.

11:37 Changeset [104726] by dimich@chromium.org
  • 2 edits in trunk/Source/WebCore

Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to fix compile error.
https://bugs.webkit.org/show_bug.cgi?id=76081

Reviewed by David Levin.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

11:26 Changeset [104725] by dpranke@chromium.org
  • 18 edits in trunk/Tools

webkitpy: clean up version detection in webkitpy.layout_tests.port
https://bugs.webkit.org/show_bug.cgi?id=76016

Reviewed by Adam Barth.

This change updates the code in webkitpy.layout_tests.port to
use the new os_name and os_version fields on host.platform. This
gets layout_tests.port out of the version parsing business. Most
of the diffs are just cleaning up test code to accomodate the
changes.

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive):
(MockExecutive.ignore_error):
(MockExecutive2):
(MockExecutive2.ignore_error):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_mac):
(MockPlatformInfo.is_linux):
(MockPlatformInfo.is_win):

  • Scripts/webkitpy/common/system/systemhost_mock.py:

(MockSystemHost.init):

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):
(ChromiumMacPort.check_wdiff):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest):
(ChromiumMacPortTest.assert_name):
(ChromiumMacPortTest.test_versions):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):
(ChromiumPortTest.TestMacPort.init):
(ChromiumPortTest.TestLinuxPort.init):
(ChromiumPortTest.TestWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest):
(ChromiumWinTest.assert_name):
(ChromiumWinTest.test_versions):
(ChromiumWinTest.test_baseline_path):
(ChromiumWinTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest):
(FactoryTest.setUp):
(FactoryTest.assert_port):
(FactoryTest.test_mac):
(FactoryTest.test_win):
(FactoryTest.test_google_chrome):
(FactoryTest.test_gtk):
(FactoryTest.test_qt):
(FactoryTest.test_chromium_gpu):
(FactoryTest.test_chromium_gpu_linux):
(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_gpu_win):
(FactoryTest.test_chromium_mac):
(FactoryTest.test_chromium_linux):
(FactoryTest.test_chromium_win):
(FactoryTest.test_unknown_specified):
(FactoryTest.test_unknown_default):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(TestGoogleChromePort):
(TestGoogleChromePort._verify_baseline_path):
(TestGoogleChromePort._verify_expectations_overrides):
(TestGoogleChromePort.test_get_google_chrome_port):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest):
(assert_name):
(test_tests_for_other_platforms):
(test_version):
(test_versions):
(test_is_version_methods):
(test_setup_environ_for_server):
(_assert_search_path):
(test_show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest):
(WinPortTest.test_show_results_html_file):
(WinPortTest._assert_search_path):
(WinPortTest._assert_version):

10:59 Changeset [104724] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Mac GCC build.

Work around the fact that GCC doesn't work very well with Blocks and C++ objets.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::dispatchFunctionOnQueue):
(WebKit::WebProcessProxy::secItemRequest):
(WebKit::WebProcessProxy::secKeychainItemRequest):

10:36 Changeset [104723] by ap@apple.com
  • 6 edits in trunk/Source/WebCore

Reviewed by Darin Adler. Prepared by Sheriff Bot. Rolling out r94902.
http://trac.webkit.org/changeset/94902
https://bugs.webkit.org/show_bug.cgi?id=75905

Disagrees with general direction for WebKit, and makes
refactoring harder (Requested by ap on #webkit).

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::deprecatedFrameEncoding):
  • loader/DocumentWriter.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
  • platform/network/ResourceRequestBase.h:
10:32 Changeset [104722] by efidler@rim.com
  • 6 edits in trunk

Fix OpenGL dependency in CMake build system
https://bugs.webkit.org/show_bug.cgi?id=73559

Reviewed by Daniel Bates.

.:

Apparently the EFL port uses desktop OpenGL to implement WebGL, but
other ports such as BlackBerry use other libraries like OpenGL ES 2.0 or
ANGLE.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformEfl.cmake:
10:17 Changeset [104721] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for RenderBoxRegionInfo map in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=75348

Reviewed by Darin Adler.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegions): use OwnPtr.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo): use HashMap::add() instead of
get() potentially followed by set().
(WebCore::RenderRegion::takeRenderBoxRegionInfo): change to return PassOwnPtr.
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo):

  • rendering/RenderRegion.h:
10:06 Changeset [104720] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Directly-composited images sometimes appear with a wrong geometry
https://bugs.webkit.org/show_bug.cgi?id=75882

Reviewed by Simon Hausmann.

When assigning a directly composited image to a TextureMapperNode in WebKit2, we take
contentsRect() onto account. However, contentsRect() might be changed after the image
is already assigned.
We have to reassign the image when contentsRect() changes. This is a pretty cheap
operation, since the image is already converted to a texture and we simply change the
geometric values.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

09:54 Changeset [104719] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Implement setCurrentTime() and pauseAnimations() on SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=12073

Patch by Joel Webber <jgw@google.com> on 2012-01-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adds the ability to reset an SVGSMILElement internally. SVGSMILElements are no longer removed
from their containers when they become inactive, because they sometimes have to be reactivated
when the container's current time is changed.

Test: svg/animations/animate-setcurrenttime.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentTime):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::pause):
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::reset):

  • svg/animation/SVGSMILElement.h:

LayoutTests:

  • platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.png: Added.
  • platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.txt: Added.
  • svg/animations/animate-setcurrenttime.svg: Added.
09:49 Changeset [104718] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Remove workaround introduced into bug 75470
https://bugs.webkit.org/show_bug.cgi?id=75889

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-01-11
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
09:40 Changeset [104717] by dslomov@google.com
  • 6 edits
    1 delete in trunk

[Chromium] Remove obsolete references to WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76020

Reviewed by David Levin.

Source/WebKit/chromium:

  • public/WebFrameClient.h:
  • public/WebSharedWorkerClient.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h: Removed.
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
09:36 Changeset [104716] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
https://bugs.webkit.org/show_bug.cgi?id=76062

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-11
Reviewed by Yury Semikhatsky.

This only changes how constants are named in generated .h file.

  • inspector/CodeGeneratorInspector.py:
09:19 Changeset [104715] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r103130) - svg/W3C-SVG-1.1/animate-elem-*-t.svg asserting
https://bugs.webkit.org/show_bug.cgi?id=74788

Unreviewed chromium expectations update, pending a real fix.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-11

  • platform/chromium/test_expectations.txt: Added animate-elem-60-t.svg linux debug flakey crash
08:35 Changeset [104714] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: "undefined" instead of error message in the SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=76060

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.get message):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • inspector/debugger/source-frame-expected.txt:
08:18 Changeset [104713] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: make setOuterHTML use new DOMEditor, cover it with tests.
https://bugs.webkit.org/show_bug.cgi?id=76056

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::Digest::Digest):
(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchHTMLElement):
(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::createDigest):

  • inspector/DOMEditor.h:
  • inspector/Inspector-0.1.json:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype._renumber):

  • inspector/front-end/ElementsTreeOutline.js:

():

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/set-outer-html-expected.txt: Added.
  • inspector/elements/set-outer-html.html: Added.
07:49 Changeset [104712] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] css3/filters/should-not-have-compositing-layer.html is failing since added in 104622
https://bugs.webkit.org/show_bug.cgi?id=76061

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failig test.
07:16 Changeset [104711] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=42197

Unreviewed gardening.

Skip new dependent tests.

  • platform/wk2/Skipped:
07:14 Changeset [104710] by apavlov@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: introduce "source" column in the CSS profiler.
https://bugs.webkit.org/show_bug.cgi?id=75378

Reviewed by Pavel Feldman.

Rules are no longer merged by their selectors but are shown one per profile entry, with a link to
their selector in the source whenever the latter is available.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::RuleMatchingStats::RuleMatchingStats):
(WebCore::SelectorProfile::makeKey):
(WebCore::SelectorProfile::startSelector):
(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::finalURL):
(WebCore::InspectorStyleSheet::setRuleSelector):

  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
(WebInspector.CSSSelectorDataGridNode.prototype.createCell):
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.sourceComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.sidebarResized):

  • inspector/front-end/dataGrid.css:

(.data-grid:focus tr.selected a):

06:58 Changeset [104709] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Add the editor rect to the EditorState https://bugs.webkit.org/show_bug.cgi?id=76053

Reviewed by Simon Hausmann.

Also rename some members to match the new Qt naming scheme.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

06:33 Changeset [104708] by ossy@webkit.org
  • 4 edits in trunk

[Qt] Some css3 filter tests are failing after r104698
https://bugs.webkit.org/show_bug.cgi?id=76055

Reviewed by Simon Hausmann.

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.

LayoutTests:

  • platform/qt/Skipped: Unskip now passing tests.
06:17 Changeset [104707] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate enum types.
https://bugs.webkit.org/show_bug.cgi?id=74954

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-11
Reviewed by Yury Semikhatsky.

Internal map of string contants is created. C enums are created for
each JSON enum.

  • inspector/CodeGeneratorInspector.py:

(EnumConstants.add_constant):
(EnumConstants):
(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(get_in_c_type_text):
(get_setter_value_expression_pattern):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding.get_setter_value_expression_pattern):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(get_annotated_type_text):
(MethodGenerateModes.get_modes):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.StrictParameterMode):
(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode):
(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(MethodGenerateModes):
(MethodGenerateModes.CombinedMode):
(MethodGenerateModes.CombinedMode.get_setter_value_expression):

05:54 Changeset [104706] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Linking of big binaries should be serialized to avoid thrashing
https://bugs.webkit.org/show_bug.cgi?id=75977

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-11
Reviewed by Martin Robinson.

Added artificial dependencies so that libwebkitgtk is always
linked first, libwebkit2gtk second, and WebKitPluginProcess
last. Automake unfortunately replaces the whole rule used to build
the libraries if the actual name is used to add the dependency, so
we use helper variables to work around that.

  • GNUmakefile.am:
05:50 Changeset [104705] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=75908

Reviewed by Darin Adler.

There's no benefit in explicit allocating RenderRegionRange in the heap. So this
patch changes the RenderRegionRangeMap to use the value type directly instead of
the pointer.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderFlowThread.h: add default constructor to act as emptyValue()

for HashMap.

05:47 Changeset [104704] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Some css3 filter tests are failing after r104698
https://bugs.webkit.org/show_bug.cgi?id=76055

Unreviewed gardening.

  • platform/qt/Skipped:
05:38 Changeset [104703] by achicu@adobe.com
  • 1 edit in trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp

2012-01-11 Alexandru Chiculita <achicu@adobe.com>

Unreviewd build fix after http://trac.webkit.org/changeset/104702.

Moving the FilterEffectRenderer::updateBackingStore outside the ENABLE(CSS_SHADERS) block.

  • rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::notifyCustomFilterProgramLoaded):
05:24 Changeset [104702] by achicu@adobe.com
  • 14 edits
    1 move
    10 adds in trunk

[CSS Shaders] Move CustomFilterOperation to the platform layer
https://bugs.webkit.org/show_bug.cgi?id=74652

Reviewed by Chris Marrin.

Source/WebCore:

FilterOperations are now part of the platform code and cannot reference style classes directly, but
CustomFilterOperation requires to link to the CachedShader for the vertex and the fragment shader.

The fix is to introduce another object that will actually keep a link to the cached resources, so in this patch
I'm adding a new class called CustomFilterProgram that will sit in the
platform/graphics/filters directory and will be referenced from CustomFilterOperation.

CustomFilterProgram is the base class of StyleCustomFilterProgram that is created from
CSSStyleSelector when a new CustomFilterOperation is created. StyleCustomFilterProgram is responsible
with loading and keeping references to the StyleCachedShaders and the CachedShaders.

More patches will follow with optimizations about reusing 3D graphics contexts and compiled shaders.

Tests: css3/filters/custom-filter-shader-cache.html

css3/filters/missing-custom-filter-shader.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):

Updated to use the StyleCustomFilterProgram instead of the CustomFilterOperation.

  • platform/graphics/filters/CustomFilterOperation.h: Renamed from Source/WebCore/rendering/style/CustomFilterOperation.h.

(WebCore::CustomFilterOperation::create):

Accepts a CustomFilterProgram instead of vertex and fragment CachedShaders.

(WebCore::CustomFilterOperation::program): Returns the CustomFilterProgram.

(WebCore::CustomFilterOperation::CustomFilterOperation):

Accepts a CustomFilterProgram instead of vertex and fragment CachedShaders.

  • platform/graphics/filters/CustomFilterProgram.cpp: Added.

(WebCore::CustomFilterProgram::CustomFilterProgram):
(WebCore::CustomFilterProgram::~CustomFilterProgram):
(WebCore::CustomFilterProgram::addClient):
(WebCore::CustomFilterProgram::removeClient):
(WebCore::CustomFilterProgram::notifyClients):
(WebCore::CustomFilterProgram::createShaderWithContext):

  • platform/graphics/filters/CustomFilterProgram.h: Added.
  • platform/graphics/filters/CustomFilterProgramClient.h: Added.

(WebCore::CustomFilterProgramClient::~CustomFilterProgramClient):

  • platform/graphics/filters/FECustomFilter.cpp:

FECustomFilter will not use strings anymore. It will just get a reference to the CustomFilterProgram.

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::initializeContext):

Using the CustomFilterProgram to generate the CustomFilterShader instance. A better name for CustomFilterShader
would be CustomFilterCompiledProgram, but I would prefer to make that change in a different patch.

  • platform/graphics/filters/FECustomFilter.h:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::notifyCustomFilterProgramLoaded):
(WebCore::FilterEffectRenderer::removeCustomFilterClients):

  • rendering/FilterEffectRenderer.h:
  • rendering/style/StyleCustomFilterProgram.h: Added.

(WebCore::StyleCustomFilterProgram::create):
(WebCore::StyleCustomFilterProgram::setVertexShader):
(WebCore::StyleCustomFilterProgram::vertexShader):
(WebCore::StyleCustomFilterProgram::setFragmentShader):
(WebCore::StyleCustomFilterProgram::fragmentShader):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):

LayoutTests:

  • css3/filters/custom-filter-shader-cache-expected.png: Added.
  • css3/filters/custom-filter-shader-cache-expected.txt: Added.
  • css3/filters/custom-filter-shader-cache.html: Added.

Testing that multiple elements can share the same shaders cached resources.

  • css3/filters/missing-custom-filter-shader-expected.png: Added.
  • css3/filters/missing-custom-filter-shader-expected.txt: Added.
  • css3/filters/missing-custom-filter-shader.html: Added.

Testing that we don't crash when shaders are missing and that we don't try to render
if one component of the pair (vertex shader, fragment shader) was not loaded yet.

05:21 Changeset [104701] by apavlov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline http/tests/media/video-buffering-repaints-controls.html for Mac Leopard Debug.

  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
04:46 Changeset [104700] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test fast/forms/radio/radio-group.html failing after r104668
https://bugs.webkit.org/show_bug.cgi?id=76051

Unreviewed gardening.

  • platform/qt/Skipped:
04:24 Changeset [104699] by apavlov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Skip failing fast/text/font-kerning.html reftest on Win7.

  • platform/chromium-win/fast/text/font-kerning-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
04:08 Changeset [104698] by achicu@adobe.com
  • 25 edits in trunk

CSS Filters: apply the filters in RenderLayerBacking::paintIntoLayer when filters cannot be composited in hardware
https://bugs.webkit.org/show_bug.cgi?id=75842

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayers have two possible states: composited or not. When composited the RenderLayerBacking::paintIntoLayer is used
to render the result inside the graphics context of the GraphicsLayer. When not composited the RenderLayer::paintLayer method will draw
the result in the graphics context of the parent layer.

Because a recent patch forced creation of composited layers for filters, this patch makes RenderLayerBacking::paintIntoLayer aware
that it might need to apply the filters when the composition engine failed to apply them in platform code.

No new tests needed, I've just updated some of the old tests to force disable the accelerated composition
so that we can still test software painted filters.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::clearFilters):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setFilters):

If filtersCanBeComposited() is false we need to reset the CoreAnimation layer to remove any previously applied filter.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::filtersCanBeComposited):

Added grayscale, brightness and contrast in the list of not accelerated filters. Otherwise an assert if triggered.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::updateBackingStore):

Moved this method from RenderLayer::updateFilterBackingStore. It had no dependencies on RenderLayer.

(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

Consolidated the filter rendering inside this helper class that is now used in both RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer.

  • rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRendererHelper::FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::haveFilterEffect):
(WebCore::FilterEffectRendererHelper::hasStartedFilterEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

Filters should apply after the opacity is applied, so I moved this down to paintLayerContents.

(WebCore::RenderLayer::paintLayerContents):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::filter):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Added software fallback rendering of the filters on composited RenderLayers.

LayoutTests:

Disabled the accelerated composition on some of the tests, so that we can test that software pipeline still works.
Note that we also have equivalent tests ending in "-hw.html" that test the accelerated composited mode.

  • css3/filters/effect-blur.html:
  • css3/filters/effect-brightness.html:
  • css3/filters/effect-combined.html:
  • css3/filters/effect-contrast.html:
  • css3/filters/effect-custom-expected.png: Reverted the expected results for CSS Shader test with WebGL enabled.
  • css3/filters/effect-custom-expected.txt: Added some output to the test, to make it easy to understand what is tested.
  • css3/filters/effect-custom.html: Also forced enabled WebGL using layoutTestController.overridePreference.
  • css3/filters/effect-drop-shadow.html:
  • css3/filters/effect-grayscale.html:
  • css3/filters/effect-hue-rotate.html:
  • css3/filters/effect-invert.html:
  • css3/filters/effect-opacity.html:
  • css3/filters/effect-saturate.html:
  • css3/filters/effect-sepia.html:
  • css3/filters/filter-repaint.html:
03:52 Changeset [104697] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline after r104678.

  • platform/gtk/Skipped: Skip failing fast/text/font-kerning.html

ref test.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
03:50 Changeset [104696] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Implement the font-kerning CSS property
https://bugs.webkit.org/show_bug.cgi?id=76033

Unreviewed gardening after r104678.

  • svg/css/getComputedStyle-basic-expected.txt:
03:27 Changeset [104695] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark http/tests/media/video-buffering-repaints-controls.html as timing out on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=75570

  • platform/chromium/test_expectations.txt:
02:58 Changeset [104694] by jochen@chromium.org
  • 10 edits in trunk/Source

Move the check for canExecuteScripts out of V8Proxy::retrieve
https://bugs.webkit.org/show_bug.cgi?id=75533

Reviewed by Adam Barth.

Source/WebCore:

This change doesn't move the check to custom/generated bindings for
individual objects, as these won't get executed if scripts are disabled
anyway.

No new tests. No functional change.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::retrieve):
(WebCore::toV8Context):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::didClearWindowObject):

02:51 Changeset [104693] by antti@apple.com
  • 2 edits in trunk/Websites/webkit.org

Remove S60 reference from webkit.org
https://bugs.webkit.org/show_bug.cgi?id=76044

Reviewed by Simon Hausmann.

There is no S60.

  • index.html:
02:49 Changeset [104692] by tony@chromium.org
  • 2 edits in trunk/Tools

Don't remove 0 byte files when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=75997

Reviewed by Csaba Osztrogonác.

If QTDIR is set, isQt() is true even when running build-webkit --chromium.

  • Scripts/webkitdirs.pm:

(determineIsQt):

02:48 JavaScript and DOM Benchmarks edited by morrita@google.com
(diff)
02:41 Changeset [104691] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Rename viewObject to viewWidget
https://bugs.webkit.org/show_bug.cgi?id=75947

Reviewed by Martin Robinson.

Rename viewObject to viewWidget for the EFL port to use WidgetBackingStore
which calls viewWidget().

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::viewSize):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit::PageClientImpl::create):
(WebKit::PageClientImpl::viewWidget):

  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

02:24 Changeset [104690] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

ShouldSkipTypeInHeader() and ShouldSkipTypeInImplementation() should be the same
https://bugs.webkit.org/show_bug.cgi?id=76030

Reviewed by Adam Barth.

Because the attributes/methods that do not appear in the implementation
do not need to appear in the header.

Tests: bindings/scripts/test/TestCallback.idl

bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType): Renamed from ShouldSkipTypeInImplementation().
(GenerateHeader): Replaced ShouldSkipTypeInImplementation() with ShouldSkipType(),
and replaced ShouldSkipTypeInHeader() with ShouldSkipType().
(GenerateImplementation): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestCallback.h: Updated the test result.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
02:14 Changeset [104689] by apavlov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, more rebaselines after r104678.

  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/chromium-win/fast/text/font-kerning-expected.png: Added.
02:11 Changeset [104688] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix more style errors in CSSParser.cpp (followup patch)
https://bugs.webkit.org/show_bug.cgi?id=76038

Reviewed by Nikolas Zimmermann.

The previous was: http://trac.webkit.org/changeset/104576
This patch mostly contains C cast to static_cast rewrites.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::ShadowParseContext::commitLength):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::parseDeprecatedGradientPoint):

02:05 Changeset [104687] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Refactor single backing store scroll code.
https://bugs.webkit.org/show_bug.cgi?id=75243

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-11
Reviewed by Zoltan Herczeg.

Remove the duplicated code and refactor the scroll procedure.
Wherever the page is scrolled, there are one screen copy and two updates.
This patch optimises the scroll procedure by less calculation.

  • ewk/ewk_view_single.cpp:

(_ewk_view_screen_move):
(_ewk_view_single_scroll_process_single):

02:04 Changeset [104686] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix release builds.

  • rendering/svg/SVGTextMetricsBuilder.cpp: (WebCore::SVGTextMetricsBuilder::measureTextRenderer):
01:26 Changeset [104685] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline fast/css/getComputedStyle/computed-style.html after r104678.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
01:24 Changeset [104684] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r101445): [V8] Generated code for custom getters and setters
with the [Supplemental] IDL is wrong
https://bugs.webkit.org/show_bug.cgi?id=76034

Reviewed by Adam Barth.

This patch fixes the class name of the implementation of custom getters
and setters, as follows.

Previous V8TestInterface.cpp:

Attribute 'supplementalStr3'
{"supplementalStr3", V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, ...},

New V8TestInterface.cpp:

Attribute 'supplementalStr3'
{"supplementalStr3", V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, ...},

Test: bindings/scripts/test/TestInterface.idl

bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):

  • bindings/scripts/test/V8/V8TestInterface.cpp:
01:16 Changeset [104683] by zimmermann@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Introduce SVGTextMetricsBuilder, which will be used to speed-up measuring of SVG text,
by using the simple code path, whenever possibly. It's not enabled yet, as it requires
a restructurization of SVGTextLayoutAttributesBuilder - its the first chunk of a set
of patches, that all together fix the performance regression and much more :-)

Doesn't affect any tests, SVGTextMetricsBuilder is not turned on yet.

  • CMakeLists.txt: Add SVGTextMetricsBuilder.cpp/h to build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Font.h:

(WebCore::Font::codePath): Make it public, to be usable from SVGTextMetricsBuilder.

  • rendering/svg/RenderSVGAllInOne.cpp: Add SVGTextMetricsBuilder.cpp to build.
  • rendering/svg/RenderSVGText.cpp:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): SVGTextMetrics::emptyMetrics() is gone, adapt code.

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics): Ditto.
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Ditto.

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics): Made public, now used in SVGTextLayoutEngine.
(WebCore::SVGTextMetrics::constructTextRun): Move to public static function, to be usable from SVGTextMetricsBuilder.

  • rendering/svg/SVGTextMetrics.h:

(WebCore::SVGTextMetrics::isEmpty): Add new isEmpty method, which replaces the == empyMetrics().
(WebCore::SVGTextMetrics::setWidth): Remove friendship with SVGTextLayoutAttributesBuilder, and make it public, to avoid another friendship.

  • rendering/svg/SVGTextMetricsBuilder.cpp: Added.

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText): New variant using WidthIterator directly, this is finally possible as SVG Fonts have been integrated into the glyph pages concept a while ago.
(WebCore::SVGTextMetricsBuilder::advanceComplexText): Complex code path, accounting for sum of glyph widths != run width.
(WebCore::SVGTextMetricsBuilder::measureTextRenderer): Either measure the text renderer, or just figure out lastCharacter.
(WebCore::SVGTextMetricsBuilder::walkTreeUntilSpecificLeafIsReached): Walks SVG <text> tree, correctly computing "lastCharacter" until the leaf is reached.
(WebCore::SVGTextMetricsBuilder::measureAllCharactersOfRenderer): Use above method.

  • rendering/svg/SVGTextMetricsBuilder.h: Added.
01:16 Changeset [104682] by apavlov@chromium.org
  • 1 edit
    1 copy
    1 move
    6 adds in trunk/LayoutTests

[Chromium] Unreviewed, add baselines for http/tests/media/video-buffering-repaints-controls.html

  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Copied from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
01:02 Changeset [104681] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed trivial build fix: Removed unnecessary QHttpRequestHeader
inclusion (and the file is removed in newer Qt 5 versions).

  • Api/qwebpage.cpp:
01:02 Changeset [104680] by hausmann@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

[Qt][WK2] Fix the build for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=75964

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-11
Reviewed by Simon Hausmann.

Source/WebKit:

  • WebKit.pri: Added the new files to the buildsystem.

Source/WebKit/qt:

Added QHttpHeader, QHttpResponseHeader and QHttpRequestHeader
that were removed from Qt. They are now kept under a private header
and only the relevant code is present.

  • Api/qhttpheader.cpp: Added.

(QHttpHeader::QHttpHeader):
(QHttpHeader::~QHttpHeader):
(QHttpHeader::parse):
(QHttpHeader::value):
(QHttpHeader::hasKey):
(QHttpHeader::setValue):
(QHttpHeader::addValue):
(QHttpHeader::parseLine):
(QHttpHeader::toString):
(QHttpHeader::hasContentLength):
(QHttpHeader::contentLength):
(QHttpHeader::setContentLength):
(QHttpHeader::hasContentType):
(QHttpHeader::contentType):
(QHttpHeader::setContentType):
(QHttpResponseHeader::QHttpResponseHeader):
(QHttpResponseHeader::parseLine):
(QHttpResponseHeader::toString):
(QHttpRequestHeader::QHttpRequestHeader):
(QHttpRequestHeader::parseLine):
(QHttpRequestHeader::toString):

  • Api/qhttpheader_p.h: Added.

(QHttpHeader::isValid):
(QHttpHeader::setValid):
(QHttpResponseHeader::statusCode):
(QHttpResponseHeader::reasonPhrase):
(QHttpResponseHeader::majorVersion):
(QHttpResponseHeader::minorVersion):
(QHttpRequestHeader::method):
(QHttpRequestHeader::path):
(QHttpRequestHeader::majorVersion):
(QHttpRequestHeader::minorVersion):

  • WebCoreSupport/InspectorServerQt.cpp:
00:40 Changeset [104679] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

Fix fast/spatial-navigation/snav-media-elements.html
<http://webkit.org/b/76028>

Reviewed by Daniel Bates.

  • fast/spatial-navigation/snav-media-elements-expected.txt: Update

results.

  • fast/spatial-navigation/snav-media-elements.html: Fix

test-complete code path by using js-test-post-async.js. Note
that the path to js-test-post.js was incorrect, so it was never
even loaded.

00:38 Changeset [104678] by mitz@apple.com
  • 17 edits
    2 adds in trunk

<rdar://problem/10674686> Implement the font-kerning CSS property
https://bugs.webkit.org/show_bug.cgi?id=76033

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/text/font-kerning-expected.html

fast/text/font-kerning.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added code to handle
font-kerning.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added mapping from FontDescription::Kerning.
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning): Added mapping to
FontDescription::Kerning.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Added font-kerning to the set of inherited
properties.

  • css/CSSPropertyNames.in: Added -webkit-font-kerning.
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added a handler for font-kerning.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration): Updated for the number of properties that
affect the font.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Changed to enable kerning if font-kerning is set to
normal, disable it if font-kerning is set to none, and leave it to the default (determined
by the text-rendering property) if font-kerning is set to auto.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Added a Kerning enum.
(WebCore::FontDescription::kerning): Added this getter.
(WebCore::FontDescription::setKerning): Added this setter.
(WebCore::FontDescription::operator==): Updated to compare the m_kerning member.

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/text/font-kerning-expected.html: Added.
  • fast/text/font-kerning.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
00:19 Changeset [104677] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix page rendering issue on ewk_view_tiled.
https://bugs.webkit.org/show_bug.cgi?id=75686

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-11
Reviewed by Andreas Kling.

As for now the discard of ewk_tiled_backing_store doesn't reset its own contents size information
and ewk_tiled_backing_store just ignores the request if new contents size change request would contain
the same size compared to the one that it owns,
contents size change request coming from ChromeClientEfl::contentsSizeChanged() API can be skipped
and therefore web page can't be presented properly.
In order to resolve this, I just add code to reset contents size information which ewk_tiled_backing_store owns
when it discards its own data.

  • ewk/ewk_tiled_backing_store.cpp:

(ewk_tiled_backing_store_flush):

01/10/12:

23:53 Changeset [104676] by pfeldman@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

Merge 104563 - Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

TBR=pfeldman@chromium.org
BUG=109730
Review URL: http://codereview.chromium.org/9187001

23:14 Changeset [104675] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix. Forgot to revert Node.h.

  • dom/Node.h:
23:03 Changeset [104674] by rniwa@webkit.org
  • 10 edits in trunk/Source/WebCore

Revert r104210. It turned out that this patch makes improving the node list caches harder.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicSubtreeNodeList::Caches::create):
(WebCore::DynamicSubtreeNodeList::Caches::reset):

  • dom/DynamicNodeList.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore::Node::notifyLocalNodeListsLabelChanged):
(WebCore::Node::itemTypeAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):

  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::parseMappedAttribute):

  • html/HTMLLabelElement.h:
22:57 Changeset [104673] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r104263 and r104381.
http://trac.webkit.org/changeset/104263
http://trac.webkit.org/changeset/104381
https://bugs.webkit.org/show_bug.cgi?id=76029

Preparation to rollout r104210 (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10

Source/WebCore:

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):

LayoutTests:

  • fast/dom/node-list-length-after-removing-node-expected.txt: Removed.
  • fast/dom/node-list-length-after-removing-node.html: Removed.
22:20 Changeset [104672] by morrita@google.com
  • 2 edits in trunk/Websites/webkit.org

[Website] i-Bench is no longer available.
https://bugs.webkit.org/show_bug.cgi?id=76027

Reviewed by Ryosuke Niwa.

Updated the availability information of i-Bench.

  • projects/performance/index.html:
22:07 Changeset [104671] by ddkilzer@apple.com
  • 4 edits
    2 adds in trunk

Add TestWebKitAPI tests for KURL
<http://webkit.org/b/75774>

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.exp.in: Export additional KURL methods used in

testing.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a

WebCore folder and KURL.cpp source file to the project.

  • TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.

(TestWebKitAPI::WebCore::SetUp): Initialize the main thread
during setup since this test doesn't go through WebKit or
WebKit2.
(TestWebKitAPI::TEST_F): Add two basic tests.

22:07 Changeset [104670] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/Tools

Extract common code for comparing WTF::String objects into WTFStringUtilities.h

Reviewed by Adam Barth.

Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add

WTFStringUtilities.h to the project.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use

WTFStringUtilities.h.

  • TestWebKitAPI/WTFStringUtilities.h: Added.

(WTF::operator<<):

21:34 Changeset [104669] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in HTMLMediaElement::shouldDisableSleep()
https://bugs.webkit.org/show_bug.cgi?id=76025

Reviewed by Dan Bernstein.

Check nullity of m_player before dereferencing.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::shouldDisableSleep):

21:03 Changeset [104668] by tkent@chromium.org
  • 11 edits
    3 adds in trunk

Source/WebCore: A radio button not in a document should not join a radio button group
https://bugs.webkit.org/show_bug.cgi?id=45719

Reviewed by Darin Adler.

As per the standard and other browser behaviors, we should not add a
radio button not in a document to a radio button group.

So, CheckedRadioButton member functions should be called in
insertedIntoDocument() and removedFromDocument(), and they should do
nothing if the specified radio button is not in a document.

This change also fixes a bug that form owner change by 'form' attribute
didn't update radio button groups correctly.

Test: fast/forms/radio/radio-group.html

  • dom/CheckedRadioButtons.cpp:

(WebCore::shouldMakeRadioGroup): A helper function to check <input> state.
(WebCore::CheckedRadioButtons::addButton):

  • Change the argument type: HTMLFormControlElement* -> HTMLInputElement*.
  • Use shouldMakeRadioGroup().

(WebCore::CheckedRadioButtons::removeButton): ditto.

  • dom/CheckedRadioButtons.h: Change the argument types of addButton() and removeButton(): HTMLFormControlElement* -> HTMLInputElement*.
  • html/FormAssociatedElement.cpp: Do not update m_form except in setForm() and formWillBeDestroyed(). This helps us to call registerFormElement() and removeFromElement() correctly, and call willChangeForm()/didChangeForm() hooks correctly.

(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::~FormAssociatedElement):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::removedFromTree):
(WebCore::FormAssociatedElement::setForm):
(WebCore::FormAssociatedElement::willChangeForm):
This virtual function is called before the owner form is updated.
(WebCore::FormAssociatedElement::didChangeForm):
This virtual function is called after the owner form was updated.
(WebCore::FormAssociatedElement::formWillBeDestroyed):

  • Renamaed from formDestroyed()
  • Add calls to willChangeForm() and didChangeForm().

(WebCore::FormAssociatedElement::resetFormOwner): Use setForm().
(WebCore::FormAssociatedElement::formAttributeChanged): ditto.

  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement): Use setForm().
(WebCore::HTMLFormControlElement::~HTMLFormControlElement):
removeFormElement() is not needed. ~FormAssociatedElement() treats it.
(WebCore::HTMLFormControlElement::parseMappedAttribute):
No need to handle CheckedRadioButtons here. It is handled by HTMLInputElement.
(WebCore::HTMLFormControlElement::insertedIntoTree): ditto.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

Rename formDestroyed() with willDestroyForm().

(WebCore::HTMLFormElement::registerFormElement):
We don't need to handle radio button groups here.
(WebCore::HTMLFormElement::removeFormElement): ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement):
Calls setForm(0) so that it calls correct virtual functions of
HTMLInputElement.
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
Checking attached() was wrong.
(WebCore::HTMLInputElement::willChangeForm):
Remove this radio button from a radio button group for the old form.
(WebCore::HTMLInputElement::didChangeForm):
Add this radio button to a radio button group for the new form.
(WebCore::HTMLInputElement::insertedIntoDocument):
Add CheckedRadioButtons::addButton() call.
(WebCore::HTMLInputElement::removedFromDocument):
Add CheckedRadioButtons::removeButton() call.
(WebCore::HTMLInputElement::didMoveToNewDocument):
We don't need to handle CheckedRadioButton() here because
removedFromDocument() handles it.

  • html/HTMLInputElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::HTMLObjectElement): Use setForm().
(WebCore::HTMLObjectElement::~HTMLObjectElement):
removeFormElement() is not needed. ~FormAssociatedElement() treats it.

LayoutTests: A radio button not in a Document should not join a radio button group
https://bugs.webkit.org/show_bug.cgi?id=45719

Reviewed by Darin Adler.

  • fast/forms/radio/radio-group-expected.txt: Added.
  • fast/forms/radio/radio-group.html: Added.
21:02 Changeset [104667] by mrowe@apple.com
  • 2 edits in tags/Safari-535.15.2/Source/JavaScriptCore

Merge r104664.

21:02 Changeset [104666] by mrowe@apple.com
  • 5 edits in tags/Safari-535.15.2/Source

Versioning.

20:51 Changeset [104665] by mrowe@apple.com
  • 1 copy in tags/Safari-535.15.2

New tag.

20:50 Changeset [104664] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/10673792> jsc should install directly in to versioned Resources subfolder

This ensures that jsc ends up in a consistent location whether built in to the same DSTROOT
as JavaScriptCore.framework or in to a different one.

Rubber-stamped by Dan Bernstein.

  • Configurations/JSC.xcconfig: Update INSTALL_PATH.
20:50 Changeset [104663] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r104377): All pages print blank on Snow Leopard
<http://webkit.org/b/75879> / <rdar://problem/10674335>

We need to explicitly load PDFKit.framework before using PDFDocument and friends.
On SnowLeopard the framework is not necessarily loaded by anything else before we
print, which would lead to us failing to allocate the PDFDocument that we use for
drawing the content from the web process.

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKPrintingView.mm:

(pdfKitFrameworkPath): Construct the path to the PDFKit framework.
(classFromPDFKit): Ensure that the PDFKit framework is loaded, and then retrieve the
given class from it.
(pdfAnnotationLinkClass): ASSERT that we found the class.
(pdfDocumentClass): Ditto.

19:52 Changeset [104662] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unskiping more passing tests
https://bugs.webkit.org/show_bug.cgi?id=46249

Patch by João Paulo Rechi Vita <jprvita@openbossa.org> on 2012-01-10
Reviewed by Eric Seidel.

  • platform/qt/Skipped:
19:36 Changeset [104661] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Made -[WebHistoryItem copyWithZone:] allocate an object of the same class as the receiver.

Reviewed by Mark Rowe.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem copyWithZone:]):

18:54 Changeset [104660] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG inlining block linking compares BlockIndex against bytecode index
https://bugs.webkit.org/show_bug.cgi?id=76018
<rdar://problem/10671979>

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

  • fast/js/dfg-inline-many-blocks-expected.txt: Added.
  • fast/js/dfg-inline-many-blocks.html: Added.
  • fast/js/script-tests/dfg-inline-many-blocks.js: Added.

(stuff):
(foo):
(fuzz):
(baz):
(bar):

18:04 Changeset [104659] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove redundant code from DOMWindowSQLDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=76010

Reviewed by Adam Barth.

This patch removes redundant code from DOMWindowSQLDatabase.cpp.

  • Remove window->frame() check, since window->frame() is always true when window->isCurrentlyDisplayedInFrame() is true.
  • window->frame()->document() can just be window->document()

Tests: storage/open-database-creation-callback-isolated-world.html

storage/open-database-creation-callback.html
storage/open-database-empty-version.html
storage/open-database-over-quota.html
storage/open-database-set-empty-version.html
storage/open-database-while-transaction-in-progress.html

  • storage/DOMWindowSQLDatabase.cpp:

(WebCore::DOMWindowSQLDatabase::openDatabase):

17:51 Changeset [104658] by commit-queue@webkit.org
  • 12 edits
    3 adds in trunk

Repaint video controls when buffering during pause.
https://bugs.webkit.org/show_bug.cgi?id=73957

Source/WebCore:

Pipes support for a new bufferingProgressed() method on MediaControls
elements. Allows controls to be repainted as data buffers when paused.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-10
Reviewed by Hajime Morita.

Test: http/tests/media/video-buffering-repaints-controls.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::progressEventTimerFired):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::bufferingProgressed):

  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::bufferingProgressed):

  • html/shadow/MediaControlRootElementChromium.h:
  • html/shadow/MediaControls.h:

LayoutTests:

Adds video-buffering-repaints-controls test to verify the progress bar
repaints as new data is buffered when paused.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-10
Reviewed by Hajime Morita.

  • http/tests/media/video-buffering-repaints-controls.html: Added.
  • platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/win/test_expectations.txt:
17:35 Changeset [104657] by commit-queue@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r104543.
http://trac.webkit.org/changeset/104543
https://bugs.webkit.org/show_bug.cgi?id=76013

Asserts on Mac 10.6 dbg bots (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10

  • css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Removed.
  • css3/calc/block-mask-overlay-image-outset.html: Removed.
  • css3/calc/resources/mask.png: Removed.
17:19 Changeset [104656] by cmarrin@apple.com
  • 4 edits in trunk/Source

2012-01-10 Chris Marrin <cmarrin@apple.com>

Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work

Unreviewed.

17:19 Changeset [104655] by dcheng@chromium.org
  • 3 edits
    2 adds in trunk

[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
https://bugs.webkit.org/show_bug.cgi?id=75923

Reviewed by Tony Chang.

Source/WebCore:

Test: editing/pasteboard/pasting-empty-html-falls-back-to-text.html

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

LayoutTests:

  • editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt: Added.
  • editing/pasteboard/pasting-empty-html-falls-back-to-text.html: Added.
17:12 Changeset [104654] by haraken@chromium.org
  • 12 edits
    3 adds in trunk/Source/WebCore

Use the [Supplemental] IDL in SQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=76004

Reviewed by Adam Barth.

We've been working on WebKit modularization. By using the [Supplemental] IDL,
we can move SQLDatabase related code from WebCore/page/DOMWindow.{h,cpp,idl}
to WebCore/storage/DOMWindowSQLDatabase.{h,cpp,idl}.

Tests: storage/open-database-creation-callback-isolated-world.html

storage/open-database-creation-callback.html
storage/open-database-empty-version.html
storage/open-database-over-quota.html
storage/open-database-set-empty-version.html
storage/open-database-while-transaction-in-progress.html

  • CMakeLists.txt: Added DOMWindowSQLDatabase.{idl,h,cpp} to the build script.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/DOMWindow.cpp: Removed SQLDatabase related code.
  • page/DOMWindow.idl: Ditto.
  • page/DOMWindow.h: Ditto. Moved isCurrentlyDisplayedInFrame() from private: to public:

so that DOMWindowSQLDatabase::openDatabase() can access it.

  • storage/DOMWindowSQLDatabase.cpp: Added. Moved openDatabase() from DOMWindow.cpp to here.

(WebCore::DOMWindowSQLDatabase::openDatabase):

  • storage/DOMWindowSQLDatabase.h: Added. Moved openDatabase() from DOMWindow.h to here.
  • storage/DOMWindowSQLDatabase.idl: Added. Using the [Supplemental] IDL, moved openDatabase()

and SQLException from DOMWindow.idl to here.

17:10 Changeset [104653] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

padding test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76005

Reviewed by Darin Adler.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/padding-expected.txt: Added.
  • css3/calc/padding.html: Added.
17:07 Changeset [104652] by cmarrin@apple.com
  • 5 edits in trunk

CIFilter version of Sepia Tone filter doesn't match software
https://bugs.webkit.org/show_bug.cgi?id=75129

Reviewed by Simon Fraser.

Source/WebCore:

Changed sepia tone filter to use a CIColorMatrix filter with
values that match sw filter.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(interp):
(PlatformCALayer::setFilters):

LayoutTests:

Updated sepia tone results for core image filters on CA layers to match changes. Updated sw results because
they had the wrong color space

  • css3/filters/effect-sepia-expected.png:
  • css3/filters/effect-sepia-hw-expected.png:
16:42 Changeset [104651] by ostapenko.viatcheslav@nokia.com
  • 6 edits in trunk/Source

[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash
https://bugs.webkit.org/show_bug.cgi?id=74176

Reviewed by Noam Rosenthal.

Source/WebCore:

Replaces static global GL resource holder with holder shared between
TextureMapperGL instances created on the same GL context. Also adds
deallocation of GL resources when last TextureMapperGL instance on the
current GL context gets deleted.

Tested by multipleWebViewWindows and multipleWebViews Qt WK2 API tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext):
(WebCore::TextureMapperGLData::SharedGLData::glContextDataMap):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::ProgramInfo::ProgramInfo):
(WebCore::TextureMapperGLData::SharedGLData::createShaderProgram):
(WebCore::TextureMapperGLData::SharedGLData::deleteShaderProgram):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(WebCore::TextureMapperGLData::SharedGLData::initializeShaders):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):

  • platform/graphics/opengl/TextureMapperGL.h:

Source/WebKit2:

Check texture mapper exists already in ensureRootLayer to avoid recrecation.
Check if root layer was deleted already in purgeGLResources.
Added multipleWebViewWindows and multipleWebViews API tests.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):

16:39 Changeset [104650] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed, roll Chromium DEPS to r117121.

  • DEPS:
16:32 Changeset [104649] by scheib@chromium.org
  • 2 edits in trunk/Tools

Clarify run-webkit-tests options reset-results and new-baseline
https://bugs.webkit.org/show_bug.cgi?id=75993

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

16:23 Changeset [104648] by leviw@chromium.org
  • 15 edits in branches/subpixellayout

Using pixel snapped values in line width calculation in RenderBlockLineLayout. Fixing a couple ints to LayoutUnits. Fixing a bug in showLineTreeForThis that causes it to short circuit nested RenderBlocks.

16:19 Changeset [104647] by simon.fraser@apple.com
  • 4 edits in trunk

Disabled mock scrollbars should draw differently
https://bugs.webkit.org/show_bug.cgi?id=75995

Source/WebCore:

Reviewed by James Robinson.

When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.

No tests, since mock scrollbars aren't enabled by default on Mac yet.

  • platform/mock/ScrollbarThemeMock.cpp:

(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):

Tools:

Reviewed by James Robinson.

When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):

16:18 Changeset [104646] by fpizlo@apple.com
  • 10 edits
    10 adds in trunk/Source/JavaScriptCore

CodeBlock.h declares too many things
https://bugs.webkit.org/show_bug.cgi?id=76001

Rubber stamped by Gavin Barraclough.

Removed all non-CodeBlock type declarations from CodeBlock.h, and put them
into separate header files. Also removed all non-CodeBlock method implementations
from CodeBlock.cpp and put them into corresponding cpp files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/RepatchBuffer.h:
  • bytecode/CallLinkInfo.cpp: Added.

(JSC::CallLinkInfo::unlink):

  • bytecode/CallLinkInfo.h: Added.

(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::~CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::getCallLinkInfoReturnLocation):
(JSC::getCallLinkInfoBytecodeIndex):

  • bytecode/CallReturnOffsetToBytecodeOffset.h: Added.

(JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
(JSC::getCallReturnOffset):

  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
  • bytecode/CodeType.h: Added.
  • bytecode/ExpressionRangeInfo.h: Added.
  • bytecode/GlobalResolveInfo.h: Added.

(JSC::GlobalResolveInfo::GlobalResolveInfo):

  • bytecode/HandlerInfo.h: Added.
  • bytecode/LineInfo.h: Added.
  • bytecode/MethodCallLinkInfo.cpp: Added.

(JSC::MethodCallLinkInfo::reset):

  • bytecode/MethodCallLinkInfo.h: Added.

(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
(JSC::getMethodCallLinkInfoReturnLocation):
(JSC::getMethodCallLinkInfoBytecodeIndex):

  • bytecode/StructureStubInfo.h:

(JSC::getStructureStubInfoReturnLocation):
(JSC::getStructureStubInfoBytecodeIndex):

15:52 Changeset [104645] by tony@chromium.org
  • 4 edits
    4 adds in trunk

Need to handle absolutely positioned elements inside flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70793

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/insert-text-crash.html

css3/flexbox/position-absolute-child.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Skip the size of positioned elements.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Add placeholders for positioned elements.
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout): Positions the layer for the positioned child.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Handle positioned elements.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Adjust the main axis offset of the layer for positioned elements.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/insert-text-crash-expected.txt: Added.
  • css3/flexbox/insert-text-crash.html: Added.
  • css3/flexbox/position-absolute-child-expected.txt: Added.
  • css3/flexbox/position-absolute-child.html: Added.
15:50 Changeset [104644] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
https://bugs.webkit.org/show_bug.cgi?id=75938

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

Source/WebKit/chromium:

  • tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

15:48 Changeset [104643] by haraken@chromium.org
  • 17 edits in trunk/Source/WebCore

Support the [Supplemental] IDL on methods
https://bugs.webkit.org/show_bug.cgi?id=75944

Reviewed by Adam Barth.

The spec for the [Supplemental] IDL:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-supplemental-interface

Currently the [Supplemental] IDL is supported on attributes but not supported
on methods. This patch makes a change to support it.

Specifically, assume the following IDL:

interface [Supplemental=X] Y {

void func();

}

Then the code generator generates the following V8X.cpp.

void funcCallback(Arguments& args) {

X* imp = V8X::toNative(args.Holder());
Y::func(imp);

}

Similar code is also generated for JS, ObjC, GObject and CPP bindings.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorCPP.pm: Modified as described above.

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm: Ditto.

(GenerateFunction):

  • bindings/scripts/CodeGeneratorJS.pm: Ditto.

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateFunctionCallString):

  • bindings/scripts/generate-bindings.pl: Ditto.
  • bindings/scripts/test/TestSupplemental.idl: Added test cases for [Supplemental] methods.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.

(WebDOMTestInterface::supplementalMethod1):
(WebDOMTestInterface::supplementalMethod2):

  • bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.

(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface supplementalMethod1]):
(-[DOMTestInterface supplementalMethod2:objArg:]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::TestInterfaceInternal::supplementalMethod1Callback):
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):

15:44 Changeset [104642] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Chromium rebaseline after r104625.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
15:37 Changeset [104641] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed, roll Chromium DEPS to r117109.

  • DEPS:
15:37 Changeset [104640] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Qt rebaseline after r104625.

  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
15:35 Changeset [104639] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[Refactoring] Rename attributes in TestSupplemental.idl to clarify
that they are supplemental attributes
https://bugs.webkit.org/show_bug.cgi?id=75942

Reviewed by Adam Barth.

This patch just renames attributes in TestSupplemental.idl
to make it easy to find in {JS,V8,WebKitDOM,DOM,WebDOM}TestInterface.cpp
which attributes originate from TestSupplemental.idl.

  • bindings/scripts/test/TestSupplemental.idl: Just renamed three attributes.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.

(WebDOMTestInterface::supplementalStr1):
(WebDOMTestInterface::supplementalStr2):
(WebDOMTestInterface::setSupplementalStr2):

  • bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.

(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterface):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface supplementalStr1]):
(-[DOMTestInterface supplementalStr2]):
(-[DOMTestInterface setSupplementalStr2:]):
(-[DOMTestInterface ]):
(-[DOMTestInterface set:]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::TestInterfaceInternal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrSetter):

15:35 Changeset [104638] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
https://bugs.webkit.org/show_bug.cgi?id=75988

Patch by James Robinson <jamesr@chromium.org> on 2012-01-10
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/ports.py:

(WebKitPort.run_webkit_unit_tests_command):
(WebKitPort):
(ChromiumPort.run_webkit_unit_tests_command):
(ChromiumPort):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_webkit_unit_tests_command):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest.test_build_and_test):
(test_land):
(test_land_red_builders):

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
15:33 Changeset [104637] by dpranke@chromium.org
  • 8 edits
    1 add in trunk/Tools

webkitpy: add os_name, os_version to platforminfo
https://bugs.webkit.org/show_bug.cgi?id=75931

Reviewed by Eric Siedel.

As a first step in cleaning up the version parsing logic in
webkitpy.layout_tests.port, this adds common routines for
getting the os_name and os_version fields to the PlatformInfo
class. Nothing uses them yet but I've added FIXME's to some of
the code that needs to be deleted in the port files.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo):
(PlatformInfo._determine_os_name):
(PlatformInfo._determine_mac_version):
(PlatformInfo._determine_linux_version):
(PlatformInfo._determine_win_version):
(PlatformInfo.display_name):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._compute_bytes_from_vm_stat_output):
(PlatformInfo.free_bytes_memory):

  • Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.

(TestPlatformInfo):
(TestPlatformInfo.make_info):
(TestPlatformInfo.make_info.mock_run_command):
(TestPlatformInfo.setUp):
(TestPlatformInfo.tearDown):
(TestPlatformInfo.test_basic):
(TestPlatformInfo.integration_test_basic):
(TestPlatformInfo.test_display_name_mac):
(TestPlatformInfo.test_display_name_win32):
(TestPlatformInfo.test_memory_mac):
(TestPlatformInfo.test_memory_win32):
(TestPlatformInfo.test_determine_os_name):
(TestPlatformInfo.test_determine_mac_version):
(TestPlatformInfo.test_determine_linux_version):
(TestPlatformInfo.test_determine_win_version_from_tuple):
(TestPlatformInfo.test_determine_win_version_from_cmd):

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):

15:19 Changeset [104636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912

Patch by John Bauman <jbauman@chromium.org> on 2012-01-10
Reviewed by Kenneth Russell.

Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.

No new tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::maybeRestoreContext):

15:17 Changeset [104635] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Snow Leopard build fix.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
15:01 Changeset [104634] by bbudge@chromium.org
  • 8 edits
    1 add in trunk/Source/WebKit/chromium

Allow plugins to add rotate items to browser's context menu. Adds a new
WebPluginAction struct, with rotate types.
https://bugs.webkit.org/show_bug.cgi?id=75645

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebContextMenuData.h:
  • public/WebPlugin.h:

(WebKit::WebPlugin::canRotateView):
(WebKit::WebPlugin::rotateView):

  • public/WebPluginAction.h: Added.

(WebKit::WebPluginAction::WebPluginAction):

  • public/WebView.h:
  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::performMediaPlayerAction):
(WebKit::WebViewImpl::performPluginAction):

  • src/WebViewImpl.h:
14:50 Changeset [104633] by andersca@apple.com
  • 21 edits
    1 copy
    2 deletes in trunk/Source

Source/JavaScriptCore: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989
<rdar://problem/9601915>

Reviewed by Sam Weinig.

  • wtf/Functional.h:

Add function wrapper for a function that takes three parameters.

Source/WebKit2: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989

Reviewed by Sam Weinig.

Change the way the keychain calls are processed to avoid deadlocks:

  1. When a keychain call is made, the web process sends an asynchronous request message to the UI process, avoiding the need to bounce calls to the main thread (since CoreIPC only allows sending synchronous messages from the main thread). Incidentally, this fixes <rdar://problem/9428041>.
  2. The Web Process now waits on the calling thread, (for a condition variable to be signalled) for a reply message.
  3. The UI process handles the incoming message request message on the connection work queue and uses dispatch_async to a global dispatch queue where the keychain call is made. We use a global queue to prevent the connection work queue from blocking on the call.
  4. The UI process then sends an asynchronous reply message back to the web process. This message is sent from the global dispatch queue.
  5. The Web Process handles the reply message on the connection queue, adds the reply to a map and signals the condition variable that the web process is waiting on and the thread that made the keychain call can resume execution.
  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):

  • Shared/mac/SecItemRequestData.h:

(WebKit::SecItemRequestData::type):
Add a type to SecItemRequestData and encode/decode it.

  • Shared/mac/SecItemResponseData.h:

(WebKit::SecItemResponseData::resultObject):
Make this return a reference so we can call leakRef() on it.

  • Shared/mac/SecKeychainItemRequestData.cpp:

(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):

  • Shared/mac/SecKeychainItemRequestData.h:

(WebKit::SecKeychainItemRequestData::type):
Add a type, and put the OwnPtr and OwnArrayPtr in a RefCounted struct so we can
correctly copy this object.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
Don't open the connection here, the WebProcessProxy object needs to add itself as a queue client before opening.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
Remove the WebProcessProxy object from the list of connection queue clients.

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
Call didReceiveWebProcessProxyMessageOnConnectionWorkQueue.

(WebKit::WebProcessProxy::didFinishLaunching):
Add the WebProcessProxy as a queue client and open the connection.

  • UIProcess/WebProcessProxy.h:

WebProcessProxy should inherit from CoreIPC::Connection::QueueClient. Replace all individual keychain
handler functions with two generic functions, secItemRequest and secKeychainItemRequest.

  • UIProcess/WebProcessProxy.messages.in:

Replace individual keychain messages with SecItemRequest and SecKeychainItemRequest messages.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::handleSecItemRequest):
Call the right SecItem function depending on the request type and send back the result.

(WebKit::WebProcessProxy::secItemRequest):
Dispatch handleSecItemRequest on a global dispatch queue.

(WebKit::handleSecKeychainItemRequest):
Call the right SecKeychainItem function depending on the request type and send back the result.

(WebKit::WebProcessProxy::secKeychainItemRequest):
Dispatch handleSecKeychainItemRequest on a global dispatch queue.

  • WebKit2.xcodeproj/project.pbxproj:

Update for added/removed files.

  • WebProcess/WebProcess.h:

Add secItemResponse and secKeychainItemResponse message handlers.

  • WebProcess/WebProcess.messages.in:

Add SecItemResponse and SecKeychainItemResponse messages.

  • WebProcess/mac/CoreIPCClientRunLoop.h:
  • WebProcess/mac/CoreIPCClientRunLoop.mm:

This is no longer needed.

  • WebProcess/mac/KeychainItemShimMethods.h:
  • WebProcess/mac/KeychainItemShimMethods.mm:

(WebKit::managedAttributeLists):
Make this an atomically initialized static.

(WebKit::managedAttributeListsMutex):
Add an atomically initialized mutex.

(WebKit::allocateAttributeListContents):
Use the managedAttributeListsMutex to make this function callable from any thread.

(WebKit::managedKeychainItemContents):
Make this an atomically initialized static.

(WebKit::managedKeychainItemContentsMutex):
Add an atomically initialized mutex.

(WebKit::allocateKeychainItemContentData):
Use the managedAttributeListsMutex to make this function callable from any thread.

(WebKit::webFreeAttributeListContent):
Use locking so this can be called from any thread.

(WebKit::webFreeKeychainItemContent):
Ditto.

(WebKit::responseMap):
Add responseMap thread-safe singleton for holding incoming responses.

(WebKit::generateSecKeychainItemRequestID):
Return a unique item request id, using OSAtomicIncrement64Barrier for atomicity.

(WebKit::didReceiveSecKeychainItemResponse):
Pass the response over the response map.

(WebKit::sendSeqKeychainItemRequest):
Send a request message and wait for a response using ResponseMap::waitForResponse.

(WebKit::webSecKeychainItemCopyContent):
Send a request using sendSeqKeychainItemRequest.

(WebKit::webSecKeychainItemCreateFromContent):
Ditto.

(WebKit::webSecKeychainItemModifyContent):
Ditto.

  • WebProcess/mac/KeychainShimResponseMap.h:

New thread-safe helper class that stores a map of responses and lets client wait for a response
with a given ID.

(KeychainShimResponseMap::waitForResponse):
Wait until the response is available in the hash map, then return it.

(KeychainShimResponseMap::didReceiveResponse):
Add the response to the hash map and signal the condition variable.

  • WebProcess/mac/SecItemShimMethods.h:
  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::responseMap):
Add responseMap thread-safe singleton for holding incoming responses.

(WebKit::generateSecItemRequestID):
Return a unique item request id, using OSAtomicIncrement64Barrier for atomicity.

(WebKit::didReceiveSecItemResponse):
Pass the response over the response map.

(WebKit::sendSeqItemRequest):
Send a request message and wait for a response using ResponseMap::waitForResponse.

(WebKit::webSecItemCopyMatching):
Send a request using sendSeqItemRequest.

(WebKit::webSecItemAdd):
Ditto.

(WebKit::webSecItemUpdate):
Ditto.

(WebKit::webSecItemDelete):
Ditto.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::secItemResponse):
Call didReceiveSecItemResponse.

(WebKit::WebProcess::secKeychainItemResponse):
Call didReceiveSecKeychainItemResponse.

14:34 Changeset [104632] by senorblanco@chromium.org
  • 5 edits in trunk

Source/WebCore: [Chromium] Partial revert of r104566, since it breaks the shared
library build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75994

Reviewed by Dmitry Titov.

Covered by SVG feColorMatrix tests (see LayoutTests/ChangeLog).

  • WebCore.gypi:
  • platform/graphics/filters/FEColorMatrix.h:

LayoutTests: Suppress failures caused by partial revert of r104566.
https://bugs.webkit.org/show_bug.cgi?id=75994

Reviewed by Dmitry Titov.

  • platform/chromium/test_expectations.txt:
14:09 Changeset [104631] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline tests after r104575 and r104588.

  • platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
14:08 Changeset [104630] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

CodeBlock::m_numParameters should be encapsulated
https://bugs.webkit.org/show_bug.cgi?id=75985
<rdar://problem/10671020>

Reviewed by Oliver Hunt.

Encapsulated CodeBlock::m_numParameters and hooked argument profile creation
into it. This appears to be performance neutral.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::addParameter):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numParameters):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::numberOfArgumentValueProfiles):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitReturn):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::arityCheckFor):
(JSC::lazyLinkFor):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

14:03 Changeset [104629] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed test expectations update. This test needs a new baseline for Vista.

  • platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Added.
13:38 Changeset [104628] by simon.fraser@apple.com
  • 7 edits
    6 adds in trunk

Clean up RenderLayerBacking code that looks for the body
https://bugs.webkit.org/show_bug.cgi?id=39502

Source/WebCore:

Reviewed by Dave Hyatt.

Consolidate code that propagates the <body> background to the
root, adding a utility method on RenderObject that is called
by RenderBox and RenderLayerBacking.

Removed an unused method in RenderLayerBacking.

The compositiong changes are not testable, since rendererBackgroundColor()
is only used by fullscreen at present.

Tests: fast/backgrounds/root-background-propagation.html

fast/backgrounds/root-background-propagation2.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::rendererBackgroundColor):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::rendererForRootBackground):

  • rendering/RenderObject.h:

LayoutTests:

Reviewed by Dave Hyatt.

Tests for propagation of the <body> background to the root.

  • fast/backgrounds/root-background-propagation-expected.png: Added.
  • fast/backgrounds/root-background-propagation-expected.txt: Added.
  • fast/backgrounds/root-background-propagation.html: Added.
  • fast/backgrounds/root-background-propagation2-expected.png: Added.
  • fast/backgrounds/root-background-propagation2-expected.txt: Added.
  • fast/backgrounds/root-background-propagation2.html: Added.
13:30 Changeset [104627] by ojan@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Layout test rebaselines after r104606.

  • platform/chromium-win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/chromium/fast/harness/results-expected.txt.
13:24 Changeset [104626] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk/Source

[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-10
Reviewed by James Robinson.

Source/WebCore:

New unit tests: CCLayerIteratorTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h: Added.

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Added.
13:19 Changeset [104625] by ojan@chromium.org
  • 25 edits in trunk

Rename flex-align to flex-item-align.
https://bugs.webkit.org/show_bug.cgi?id=75929

Reviewed by Darin Adler.

Source/WebCore:

The spec has changed and now flex-align will be set on
the flexbox itself.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexItemAlign):
(WebCore::RenderStyleBitfields::setFlexItemAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:14 Changeset [104624] by eric.carlson@apple.com
  • 37 edits
    2 adds in trunk

Replace TextTrackCue "getCueAsSource" method with "text" attribute
https://bugs.webkit.org/show_bug.cgi?id=75646

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-mutable-text.html

  • html/HTMLMediaElement.h: getCueAsSource() -> text().
  • html/TextTrackCue.cpp:

(WebCore::TextTrackCue::setText): New. Set cue text and clear the document fragment.
(WebCore::TextTrackCue::getCueAsHTML): Allocate the document fragment if it doesn't exist.

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::text):

  • html/TextTrackCue.idl: getCueAsSource() -> text().
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::updateTextTrackDisplay): getCueAsSource() -> text().

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay): getCueAsSource() -> text().

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectCueText): processCueText is dead, long live createNewCue.
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): New, split out of processCueText.

Create a document fragment from the String argument.

(WebCore::WebVTTParser::createNewCue): Split out of processCueText.
(WebCore::WebVTTParser::constructTreeFromToken): Add a comment pointing to the spec section

with the rules for DOM construction.

  • html/track/WebVTTParser.h:

LayoutTests:

  • media/track/track-cue-mutable-text-expected.txt: Added.
  • media/track/track-cue-mutable-text.html: Added. New test for mutable cue text.
  • media/track/track-cue-nothing-to-render-expected.txt: getCueAsSource() -> text.
  • media/track/track-cue-nothing-to-render.html: Ditto.
  • media/track/track-cue-rendering-expected.txt: Ditto.
  • media/track/track-cue-rendering.html: Ditto.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Ditto.
  • media/track/track-webvtt-tc001-utf8.html: Ditto.
  • media/track/track-webvtt-tc002-bom-expected.txt: Ditto.
  • media/track/track-webvtt-tc002-bom.html: Ditto.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Ditto.
  • media/track/track-webvtt-tc003-newlines.html: Ditto.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Ditto.
  • media/track/track-webvtt-tc004-magic-header.html: Ditto.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Ditto.
  • media/track/track-webvtt-tc005-header-comment.html: Ditto.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Ditto.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Ditto.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Ditto.
  • media/track/track-webvtt-tc007-cue-no-id.html: Ditto.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Ditto.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Ditto.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Ditto.
  • media/track/track-webvtt-tc009-timings-hour.html: Ditto.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Ditto.
  • media/track/track-webvtt-tc011-blank-lines.html: Ditto.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Ditto.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Ditto.
  • platform/mac/fast/dom/Window/window-properties-expected.txt: Remove getCueAsSource.
13:14 Changeset [104623] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

DispatchOnConnectionQueue messages should have a Connection parameter
https://bugs.webkit.org/show_bug.cgi?id=75986

Reviewed by Adam Roben.

Message handlers for messages with the DispatchOnConnectionQueue should have a CoreIPC::Connection
parameter, making it easier to send messages back over that connection.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageOnConnectionQueue):

  • Scripts/webkit2/messages.py:

(async_case_statement):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::pluginProcessCrashed):

  • WebProcess/WebProcess.h:
13:12 Changeset [104622] by cmarrin@apple.com
  • 5 edits
    2 adds in trunk

Turn off the FilterTrigger in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=75914

Reviewed by Simon Fraser.

Source/WebKit/mac:

Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::allowedCompositingTriggers):

Source/WebKit2:

Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::allowedCompositingTriggers):

LayoutTests:

Test to make sure compositing layers are off for filters

  • css3/filters/should-not-have-compositing-layer-expected.txt: Added.
  • css3/filters/should-not-have-compositing-layer.html: Added.
13:09 Coding Style Guidelines edited by girard@chromium.org
Two copies of the standards exist. Removing this one, and sending readers … (diff)
13:05 Changeset [104621] by aroben@apple.com
  • 2 edits in trunk/Tools

Make it possible to type data: URLs into MiniBrowser on Windows

Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
MiniBrowser on Windows

Reviewed by Darin Adler.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
whether to prepend "http://", just look for whether the typed URL contains a colon. If it
does, we assume it already has a scheme and don't modify it.

13:01 Changeset [104620] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935

Fix 32-bit builds.

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):

12:43 Changeset [104619] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r102024): Having the Bing homepage open prevents idle sleep
https://bugs.webkit.org/show_bug.cgi?id=75972

Reviewed by Oliver Hunt.

No new tests; no testing infrastructure exists to test display sleep assertions.

Only disable idle and display sleep when a video element is not paused, not looping, and
has both a video and audio track.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Factor into updateDisableSleep() and

shouldDisplaySleep().

(WebCore::HTMLMediaElement::setLoop): Ditto.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::updateDisableSleep):
(WebCore::HTMLMediaElement::shouldDisableSleep):

  • html/HTMLMediaElement.h:
12:42 Changeset [104618] by commit-queue@webkit.org
  • 11 edits in trunk/LayoutTests

[Chromium] Rebaseline after r104585
https://bugs.webkit.org/show_bug.cgi?id=75981

Unreviewed Chromium expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10

  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium/test_expectations.txt:
12:39 Changeset [104617] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Move inspector tests into the inspector test group
https://bugs.webkit.org/show_bug.cgi?id=75926

Reviewed by Adam Barth.

And mark http/tests/inspector/resource-tree/resource-tree-document-url.html as flaky.

  • platform/chromium/test_expectations.txt:
12:30 Changeset [104616] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
https://bugs.webkit.org/show_bug.cgi?id=75921

Reviewed by Simon Fraser.

No new tests. Does not affect detectable behavior.

  • rendering/RenderLayerCompositor.cpp: Use canvas's shouldAccelerate to avoid asking

uninitialized canvas's if they're accelerated or not.
(WebCore::RenderLayerCompositor::updateBacking):

12:23 Changeset [104615] by aroben@apple.com
  • 2 edits in trunk/Tools

Make MiniBrowser automatically escape invalid URL characters typed in its URL field

Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
MiniBrowser on Windows

Reviewed by Darin Adler.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::goToURL): Pass the typed string through
CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.

12:08 Changeset [104614] by benwells@chromium.org
  • 2 edits in trunk/Tools

Adding myself (benwells) to committers.py
https://bugs.webkit.org/show_bug.cgi?id=75971

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/common/config/committers.py:
12:01 Changeset [104613] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
https://bugs.webkit.org/show_bug.cgi?id=75980

Reviewed by Mark Rowe.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with
-alloc, -initWithWebCoreHistoryItem:.

11:57 Changeset [104612] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

11:56 Changeset [104611] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

11:52 Changeset [104610] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[Chromium] Do not recreate texture updater for image layer if one exists.
https://bugs.webkit.org/show_bug.cgi?id=75589

Patch by Daniel Sievers <sievers@chromium.org> on 2012-01-10
Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/img-layer-grow.html

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::createTextureUpdater):

LayoutTests:

  • platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium/compositing/img-layer-grow-expected.txt: Added.
  • platform/chromium/compositing/img-layer-grow.html: Added.
  • platform/chromium/compositing/resources/apple.jpg: Added.
11:50 Changeset [104609] by reed@google.com
  • 2 edits in trunk/Source/WebCore

[skia] not all convex paths are convex, so recompute convexity for the problematic ones
https://bugs.webkit.org/show_bug.cgi?id=75960

Reviewed by Stephen White.

No new tests.
See related chrome issue
http://code.google.com/p/chromium/issues/detail?id=108605

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::setPathFromConvexPoints):

11:47 Changeset [104608] by senorblanco@chromium.org
  • 16 edits
    11 adds
    6 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening.

New baselines for SVG feColorMatrix tests after r104571.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/filters/feColorMatrix-saturate-expected.txt: Added.
  • svg/filters/feColorMatrix-saturate-expected.txt: Removed.
11:45 Changeset [104607] by jamesr@google.com
  • 5 edits
    1 delete in trunk/Source/WebKit/chromium

[chromium] Remove old WebMimeRegistry.h forwarding header
https://bugs.webkit.org/show_bug.cgi?id=75979

Reviewed by Ryosuke Niwa.

This isn't needed any more.

  • WebKit.gyp:
  • public/platform/WebMimeRegistry.h: Removed.
  • src/FrameLoaderClientImpl.cpp:
  • src/PlatformSupport.cpp:
  • src/WebMediaPlayerClientImpl.cpp:
11:43 Changeset [104606] by simon.fraser@apple.com
  • 4 edits in trunk/LayoutTests

Improve keyboard navigation in layout test results
https://bugs.webkit.org/show_bug.cgi?id=75901

Reviewed by Ojan Vafai.

Add support for keyboard shortcuts for navigating the list of tests,
and for flagging tests.

'i', 'k', 'k', and 'l' go foward, back, to first and to last, denoting
the current test with a red expand indicator.

'e', 'c' and 't' expand, collapse and toggle the current test.

'f' toggled a test as "flagged", which adds it to a copyable list
at the bottom of the document. The user can use flagging for whatever they want.

  • fast/harness/resources/results-test.js:

(runTests):
(runTests.isCollapsed):
():

  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
11:38 Changeset [104605] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Fix assertion failure in BackingStore::blitContents
https://bugs.webkit.org/show_bug.cgi?id=75976

Prevent an assertion failure in BackingStore::blitContents by
checking that the srcRect of the transformation matrix is non empty.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-01-10
Reviewed by Adam Treat.

Upstream BlackBerry port is not yet building and testable.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

11:27 Changeset [104604] by barraclough@apple.com
  • 11 edits in trunk

Source/JavaScriptCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935

Reviewed by Sam Weinig.

Do not allow Array length to be set if it is non-configurable, and if the new
length is less than the old length then intervening properties should removed
in reverse order. Removal of properties should cease if an intervening indexed
property being removed is non-configurable.

  • JavaScriptCore.exp:
    • Removed export for setLength.
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):

  • JSArray::setLength now takes an ExecState*

(JSC::arrayProtoFuncSlice):

  • JSArray::setLength now takes an ExecState*
  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • JSArray::setLength now takes an ExecState*

(JSC::JSArray::put):

  • JSArray::setLength now takes an ExecState*

(JSC::compareKeysForQSort):

  • Keys extracted from the map can be stored as unsigneds.

(JSC::JSArray::getOwnPropertyNames):

  • Keys extracted from the map can be stored as unsigneds.

(JSC::JSArray::setLength):

  • Check lengthIsReadOnly(), rather than copying the entire map to iterate over to determine which keys to remove, instead just copy the keys from the map to a Vector. When inSparseMode sort the keys in the Vector so that we can remove properties in reverse order.
  • runtime/JSArray.h:
    • JSArray::setLength now takes an ExecState*

Source/WebCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935

Reviewed by Sam Weinig.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::deserialize):

  • remove unnecessary call to JSArray::setLength.

LayoutTests: rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552

Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:27 Changeset [104603] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk/LayoutTests

rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552

Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:22 Changeset [104602] by barraclough@apple.com
  • 8 edits in trunk

Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Rather than strictEqual.

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnNumericProperty):

  • Missing configurablePresent() check.
  • runtime/JSObject.cpp:

(JSC::JSObject::defineOwnProperty):

  • call sameValue.
  • runtime/PropertyDescriptor.cpp:

(JSC::sameValue):

  • Moved from JSArray.cpp, fix NaN comparison.

(JSC::PropertyDescriptor::equalTo):

  • call sameValue.
  • runtime/PropertyDescriptor.h:
    • Added declaration for sameValue.

LayoutTests:

  • fast/js/array-defineOwnProperty-expected.txt:
  • fast/js/script-tests/array-defineOwnProperty.js:
    • Add new test cases.
11:21 Changeset [104601] by tony@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Fix expectations for worker-script-error.html on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=75758

Reviewed by David Levin.

The Win results appear to apply to Mac and Linux as well.

  • platform/chromium-win/fast/workers/worker-script-error-expected.txt: Removed.
  • platform/chromium/fast/workers/worker-script-error-expected.txt:
10:59 Changeset [104600] by enne@google.com
  • 10 edits in trunk/Source

[chromium] Draw debug tile borders on composited layers
https://bugs.webkit.org/show_bug.cgi?id=75680

Reviewed by James Robinson.

Source/WebCore:

On tiled layers, draw debug borders on the tiles themselves. By
default, these are one pixel wide and transparent, so should be
unobtrusive but informative. They are triggered when the layer itself
would have a debug border via the existing flags.

Also, fix the drawDebugBorderQuad function to handle arbitrarily
positioned quads, not just full layer quads. Also, fix alpha issue
with debug borders.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawDebugBorderQuad):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:

(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendDebugBorderQuad):
(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::hasDebugBorders):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

Source/WebKit/chromium:

As debug borders are not a CCSetting and are instead grabbed directly
from each graphics layer, modify the NonCompositedContentHost to say
that its graphics layer has debug borders if the page settings demand
it.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setShowDebugBorders):
(WebKit::NonCompositedContentHost::showDebugBorders):

  • src/NonCompositedContentHost.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

10:53 Changeset [104599] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.4

New tag.

10:49 Changeset [104598] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

http/tests/inspector/network-preflight-options.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=75917

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:
10:46 Changeset [104597] by vsevik@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/elementsPanel.css

Merge 104577 - Unreviewed, inspector style fix.

Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609

  • inspector/front-end/elementsPanel.css:

(#elements-content):

TBR=vsevik@chromium.org
BUG=109744
Review URL: http://codereview.chromium.org/9114043

10:44 Changeset [104596] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759

Follow-up: Remove the unused method. Keep the setter private.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-10
Reviewed by Pavel Feldman.

  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
10:23 Changeset [104595] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed, follow up to r104586: fix assertion within the loop.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchChildren):

10:05 Changeset [104594] by mario@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193

Unreviewed. Remove no longer needed GTK-specific expectation.

  • platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Removed.
09:57 Changeset [104593] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache

Reviewed by Maciej Stachowiak.

This is a non-reproducible high volume crash, so no test :(.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): Don't re-run actual "stop loading" logic if the document loader is already

stopping loading. Also add an ASSERT that might catch cases where new loads may have been started while old loads
were being stopped.

(WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.

09:49 Changeset [104592] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fixing the Mac build.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchChildren):

09:44 Changeset [104591] by mario@webkit.org
  • 7 edits
    1 move in trunk

AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193

Reviewed by Chris Fleizach.

Source/WebKit/gtk:

Add support for retrieving WebCore's AccessibilityObject's
helpText from the GTK DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::accessibilityHelpText): Returns result
of calling to helpText() over the core accessibility object's.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::helpText): Implemented.

LayoutTests:

Unskip tests now passing.

  • accessibility/aria-describedby-on-input-expected.txt: Moved from

LayoutTests/platform/mac/accessibility.

  • platform/gtk/Skipped: Unskip tests.
09:41 Changeset [104590] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74493

Unreviewed. Unskipping passing test.

  • platform/gtk/test_expectations.txt: Unskip test.
09:38 Changeset [104589] by jer.noble@apple.com
  • 4 edits in trunk

Elements can appear over fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=75913

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-zIndex.html to trigger error condition.

RenderFullScreenPlaceholder inherits the pre-fullscreen element's style, causing a stacking
context to be created. Instead of making the placeholder the parent of the RenderFullScreen
object, make the two renderers siblings. Then the stacking context created by the placeholder
will not affect the z-ordering of the RenderFullScreen.

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):

LayoutTests:

Update the test to trigger the error condition in the linked bug.

  • fullscreen/full-screen-zIndex.html:
09:34 Changeset [104588] by jchaffraix@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Unreviewed, chromium rebaselining after r104575.

The SL baseline for scroll-with-transform-layer.html is missing some scroll thumbs (http://webkit.org/b/75969).

  • platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
  • platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png: Added.
09:19 Changeset [104587] by ossy@webkit.org
  • 1 edit
    10 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.

  • platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
  • platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
  • platform/qt/fast/writing-mode/margins-expected.png: Removed.
  • platform/qt/fast/writing-mode/margins-expected.txt: Removed.
09:01 Changeset [104586] by pfeldman@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Web Inspector: add "free flow DOM editing" experiment.
https://bugs.webkit.org/show_bug.cgi?id=75955

This change enables HTML editing from Resources panel experiment.

Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • English.lproj/localizedStrings.js:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMEditor.cpp: Added.

(WebCore::DOMEditor::DOMEditor):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::patch):
(WebCore::DOMEditor::NodeDigest::NodeDigest):
(WebCore::DOMEditor::patchElement):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::patchChildren):
(WebCore::addStringToSHA1):
(WebCore::DOMEditor::createNodeDigest):

  • inspector/DOMEditor.h: Added.
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent):
(WebInspector.DOMModelResourceBinding):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.canSetContent):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

08:54 Changeset [104585] by commit-queue@webkit.org
  • 5 edits in trunk

[Chromium] Shift PathSkia to use Skia's new RawIter
https://bugs.webkit.org/show_bug.cgi?id=75703

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10
Reviewed by Nikolas Zimmermann.

Source/WebCore:

No new tests required - covered by existing tests.

  • platform/graphics/Path.h: Added comments ont he return values from iteration.
  • platform/graphics/skia/PathSkia.cpp:

(WebCore::Path::apply): Switched to SkPath::RawIter

LayoutTests:

  • platform/chromium/test_expectations.txt: Updated epxectation for tests that may change after this modification.
08:47 Changeset [104584] by ossy@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r104572.
http://trac.webkit.org/changeset/104572
https://bugs.webkit.org/show_bug.cgi?id=75967

It broke zillion tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10

Tools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
(EventSender::eventFilter):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt-wk1/Skipped:
08:45 Changeset [104583] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Clean up test expectations for mac.
https://bugs.webkit.org/show_bug.cgi?id=75966

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:44 Changeset [104582] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed potential Mac WK2 build fix.

  • UIProcess/PageClient.h: forward declare WebGestureEvent.
08:39 Changeset [104581] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Unreviewed. WebInspector: Remove unnecessary logging from the test.

  • inspector/first-open-resources.html:
08:31 Changeset [104580] by loislo@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

Unreviewed. Restore test that was removed during migration from LayoutTests folder.

  • inspector/first-open-resources.html: Added.
08:23 Changeset [104579] by jknotten@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Rebaseline fast/text/unicode-variation-selector.html following r104545.

  • platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
  • platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.
08:03 Changeset [104578] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
metrics for Android in FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=75702

Reviewed by Stephen White.

Since Skia for Android doesn't implement advanced type metric routines,
use an alternative method to calculate the number of font units for an
em size. This will be exercized by existing layout tests, as it's being
used by the ComplexTextController.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::emSizeInFontUnits):

07:59 Changeset [104577] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, inspector style fix.

Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609

  • inspector/front-end/elementsPanel.css:

(#elements-content):

07:58 Changeset [104576] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix style errors in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=75854

Reviewed by Nikolas Zimmermann.

Minor style fixes.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::filterInfoForName):

07:48 Changeset [104575] by jchaffraix@webkit.org
  • 3 edits
    7 adds in trunk

REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/layers/scroll-with-transform-composited-layer.html

fast/layers/scroll-with-transform-layer.html

The regression came from a previous optimization that was wrongly kept after r93614.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.

LayoutTests:

Added 2 tests for scrolling inside a transformed layer (either composited
or not). Unfortunately due to some platform-specifics differences, they are
not ref-tests.

  • fast/layers/scroll-with-transform-composited-layer-expected.txt: Added.
  • fast/layers/scroll-with-transform-composited-layer.html: Added.
  • fast/layers/scroll-with-transform-layer-expected.txt: Added.
  • fast/layers/scroll-with-transform-layer.html: Added.
  • platform/mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
07:47 Changeset [104574] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
https://bugs.webkit.org/show_bug.cgi?id=75957

Reviewed by Tony Gentilcore.

Revision 104502 broke Chromium compilation for platforms which disable
the Web Audio API. All references to m_audioSourceProvider should be
guarded with the ENABLE(WEB_AUDIO) conditional.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):

07:35 Changeset [104573] by ossy@webkit.org
  • 6 edits in trunk/Source/WebKit2

Unreviewed, rolling out an accidental commit r104569.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

07:32 Changeset [104572] by commit-queue@webkit.org
  • 5 edits in trunk

[Qt] fast/events/dont-loose-last-event test fails on WK1
https://bugs.webkit.org/show_bug.cgi?id=73894

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-01-10
Reviewed by Simon Hausmann.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.
This commit also removes not working DRT code to handle drag and drop,
for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Remove fast/events/dont-loose-last-event from qt-wk1 skip list.

  • platform/qt-wk1/Skipped:
07:32 Changeset [104571] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix Chrome/Mac build.

Build fix; unreviewed.

  • platform/graphics/filters/skia/FEColorMatrixSkia.cpp:

(WebCore::luminanceToAlphaMatrix):

07:25 Changeset [104570] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed potential Mac WK2 build fix.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithGestureEvent):

07:20 Changeset [104569] by kenneth@webkit.org
  • 5 edits in trunk/Source/WebKit2

WIP

07:17 Changeset [104568] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=75837

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

Changed graphicContext raw pointer to OwnPtr smart pointer.
Renamed cr to cairo and made it a RefPtr.

  • ewk/ewk_view.cpp:

(ewk_view_paint_context_new): Adjust to auto pointers use.
(ewk_view_paint_context_free): Removed explicit raw pointers delete.
Adjust to auto pointers use:
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):

07:14 Changeset [104567] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] Add font-related API tests for QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=75739

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-10
Reviewed by Zoltan Herczeg.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.
07:01 Changeset [104566] by senorblanco@chromium.org
  • 10 edits
    1 add in trunk

Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
compiling with USE(SKIA). This change will also switch the software
implementation of FEGaussianBlur to the skia implementation (ie.,
it removes the acceleration check).
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will
need a rebaseline).

  • WebCore.gypi:

Add FEColorMatrixSkia.cpp to the build.

  • platform/graphics/filters/FEColorMatrix.h:

Add platformApplySkia().

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):
Remove skia-specific code from FEGaussianBlur::platformApplySoftware().

  • platform/graphics/filters/FEGaussianBlur.h:

Make platformApplySkia() virtual, and put it behind #if USE(SKIA).

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):
Call out to platformApplySkia(), or fall back to
platformApplySoftware().

  • platform/graphics/filters/FilterEffect.h:

Add platformApplySkia().

  • platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added.

(WebCore::saturateMatrix):
(WebCore::hueRotateMatrix):
(WebCore::luminanceToAlphaMatrix):
(WebCore::FEColorMatrix::platformApplySkia):
Process color matrix effect, by calling out to generic matrix
version of SkColorMatrixFilter.

  • platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:

(WebCore::FEGaussianBlur::platformApplySkia):
Change the signature of FEGaussianBlur::platformApplySkia to be an
override of the new FilterEffect base class version.

LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines.
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

  • platform/chromium/test_expectations.txt:
06:18 Changeset [104565] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix failing WK2 layout tests after r104557

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent): Add missing break to not
handle mouseDown as gesture event.

06:13 Changeset [104564] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed buildfix.

  • UIProcess/WebPageProxy.h:
05:49 Changeset [104563] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

05:46 Changeset [104562] by kubo@profusion.mobi
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add getter for Ewk_JS_Object::view.
https://bugs.webkit.org/show_bug.cgi?id=75868

Reviewed by Andreas Kling.

So far the view associated with a given JS object was a private
property only accessible to ewk itself. This does not make much sense,
as one often needs to know which view a certain method was invoked
from, for example.

  • ewk/ewk_js.cpp:

(ewk_js_object_view_get):

  • ewk/ewk_js.h:
05:44 Changeset [104561] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
  • platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently.
  • platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
05:44 Changeset [104560] by ossy@webkit.org
  • 12 edits
    54 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Platform specific expected results tweaked by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
  • platform/qt/fast/dom/Window/window-properties.html: Updated.
  • platform/qt/fast/dom/Window/window-property-descriptors.html: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2.html: Updated.
  • platform/qt/fast/js/global-constructors.html: Updated.
05:36 Changeset [104559] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] Unreviewed -Werror build fix.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
declaration.

05:34 Changeset [104558] by hausmann@webkit.org
  • 7 edits
    1 delete in trunk/Tools

[Qt] Remove dependency to uitools
https://bugs.webkit.org/show_bug.cgi?id=75952

Reviewed by Tor Arne Vestbø.

QUiLoader is used for creating QLabel/QProgressBar widgets for
a layout test, to verify some widget embedding feature. Unfortunately
in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
depends on qttools. Since we don't really _need_ QUiLoader for our tests,
let's break the circular dependency.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::createPlugin):

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/webpage.cpp:

(WebPage::createPlugin):

  • qmake/mkspecs/features/minimal_qt.prf:
  • qmake/mkspecs/features/uitools.prf: Removed.
05:25 Changeset [104557] by kenneth@webkit.org
  • 8 edits in trunk/Source/WebKit2

Implement the input panel request/close handling

Reviewed by Simon Hausmann.

With the current patch we only request the input panel as a
response to a user tap. Close requests, on the other hand,
is always respected.

As multiple show/hide requests can happen while processing
the tap gesture, input panel visibility changes are postponed
until the tap gesture ends.

The input panel will become visible if the WebCore editor is
in canEdit mode and thus work for content-editable, meaning
that it won't close the input panel if you click on a link
(eg. editCommand) while in content-editable mode.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::didReceiveEvent):

Add a new doneWithGestureEvent method to the PageClient
as well as add a updateTextInputState similar to that of mac.

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::updateTextInputState):
(QtPageClient::doneWithGestureEvent):

Propagate the new events to the Qt EventHandler.

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:
  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleSingleTapEvent):
(setInputPanelVisible):
(QtWebPageEventHandler::updateTextInputState):
(QtWebPageEventHandler::doneWithGestureEvent):

Handle postponing of the input method visibility change
and the actual showing/hiding.

05:24 Changeset [104556] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
https://bugs.webkit.org/show_bug.cgi?id=75894

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-10
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowserApplication.h:

(MiniBrowserApplication::windowOptions):

  • MiniBrowser/qt/main.cpp:

(main):

05:06 Changeset [104555] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium test expectations update.

  • platform/chromium/test_expectations.txt:
05:00 Changeset [104554] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: typo: NetworkAgent.canClearBrowserCache -> NetworkAgent.canClearBrowserCookies.
https://bugs.webkit.org/show_bug.cgi?id=75949

Reviewed by Andreas Kling.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

04:57 Changeset [104553] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: restore front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=75625

Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):

  • inspector/front-end/TabbedPane.js:
  • inspector/front-end/externs.js:

(WebInspector.isCompactMode):

  • inspector/front-end/treeoutline.js:
04:19 Changeset [104552] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Add NULL checks to setting access obtained on frame and document.
https://bugs.webkit.org/show_bug.cgi?id=72002

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.

Adds NULL checks to setting object where it's required.
Generally WebCore checks NULL which may be returned from setting object obtained
on frame or document but in some cases these are skipped. These checks are not
needed to setting's access on page object.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::shouldAccelerate):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):

  • page/DragController.cpp:

(WebCore::DragController::draggableNode):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

  • rendering/RenderText.cpp:

(WebCore::SecureTextTimer::restartWithNewText):

04:12 WebKit Team edited by mikelawther@chromium.org
Added myself to committers list (diff)
04:11 Changeset [104551] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] DRT crashes with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=75951

Reviewed by Ossy.

  • DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where

Qt relies on font-config to define the default font family.

03:35 Changeset [104550] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Matched declaration cache should support mapped attribute declarations.
<http://webkit.org/b/75948>

Reviewed by Antti Koivisto.

Support caching of matches that include mapped attribute declarations.
To make this possible, let the cache hold references to the matched style declarations.
Otherwise, declarations are assumed to survive until ~CSSStyleSelector, which may not
be the case for CSSMappedAttributeDeclaration.

To avoid hoarding of stale CSSMappedAttributeDeclarations in the cache, do a sweep for
every 100 additions and garbage collect any entries containing a declaration that is
only referenced by the cache.

This increases cache hit rate by up to ~10% on the Alexa top sites.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedDeclarationCache):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):

  • css/CSSStyleSelector.h:
03:33 Changeset [104549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove codes to move and resize the clip.
https://bugs.webkit.org/show_bug.cgi?id=75428

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.

Remove codes to move and resize the clip because clip is not used now.
We have to show whole area of evas_object_image so we don't have to
clip any area.
In the WebKit1 Efl, the clip is used to clip the area to show during
weak zoom, so we can use codes to manipulate the clip when we want to
implement weak zoom for WebKit2 Efl.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

03:30 Changeset [104548] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] REGRESSION(r100130): Clean build feature is broken.
https://bugs.webkit.org/show_bug.cgi?id=75863

Reviewed by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(buildQMakeProject):

03:20 Changeset [104547] by gyuyoung.kim@samsung.com
  • 1 edit
    1 add in trunk/LayoutTests

Add initial test_expectations.txt for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=75940

Reviewed by Andreas Kling.

This file only has skip list for now. But, EFL patches will update
this file from now on.

  • platform/efl/test_expectations.txt: Added.
03:06 Changeset [104546] by zeno.albisser@nokia.com
  • 5 edits in trunk/Tools

[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=75885

In QML events are propagated through parents. But since the
WebView may consume key events, a shortcut might never reach
the top QtQuickItem.
Therefore an application wide event handling function in C++
needs to take care of shortcuts for MiniBrowser.

Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::reload):
(BrowserWindow::focusAddressBar):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
02:46 Changeset [104545] by bashi@chromium.org
  • 17 edits in trunk

Complex path should be used when UVS exists in text run
https://bugs.webkit.org/show_bug.cgi?id=75289

Source/WebCore:

Uses complex path when a text run contains UVS. The range from U+180B to U+180D already uses complex path.
Removes unnecessary functions that were added by r102915.

Reviewed by Dan Bernstein.

No new tests. fast/text/unicode-variation-selector.html should take care of this change.

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath): Use Complex path when the text run contains UVS.

  • platform/graphics/SimpleFontData.h: Removed updateGlyphWithVariationSelector().
  • platform/graphics/SurrogatePairAwareTextIterator.cpp: Removed unnecessary static functions.
  • platform/graphics/SurrogatePairAwareTextIterator.h: Removed hasTrailingVariationSelector().
  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): Removed UVS detection code.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed updateGlyphWithVariationSelector().
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: Ditto.
  • platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Ditto.
  • platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
  • platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
  • platform/graphics/qt/SimpleFontDataQt.cpp: Ditto.
  • platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Ditto.
  • platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.

LayoutTests:

Reviewed by Dan Bernstein.

  • platform/chromium/test_expectations.txt: Updates expectation for fast/text/unicode-variation-selector.html. Need rebaselines.
02:34 Changeset [104544] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Tools

Add --efl alias for --platform=efl to run-webkit-test
https://bugs.webkit.org/show_bug.cgi?id=75937

Reviewed by Andreas Kling.

  • Scripts/run-webkit-tests: Add --efl alias.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.

(parse_args):

02:21 Changeset [104543] by mikelawther@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896

Reviewed by Ryosuke Niwa.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
  • css3/calc/block-mask-overlay-image-outset.html: Added.
  • css3/calc/resources/mask.png: Added.
02:13 Changeset [104542] by bashi@chromium.org
  • 5 edits
    3 adds in trunk

WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
https://bugs.webkit.org/show_bug.cgi?id=73419

Source/WebCore:

Holds the CachedFont handle in CSSFontFaceSrcValue so that avoiding re-validation during style recalculation.

Reviewed by Dan Bernstein.

Test: http/tests/css/font-face-src-loading.html

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont): Added.

  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Gets the CachedFont from CSSFontFaceSrcValue object. The object will request the resource if it doesn't exist.

LayoutTests:

Reviewed by Dan Bernstein.

Adds a test that ensures re-fetching WebFonts doesn't occur after style recalculation.

  • http/tests/css/font-face-src-loading-expected.txt: Added.
  • http/tests/css/font-face-src-loading.html: Added.
  • http/tests/css/resources/webfont-request.php: Added.
01:58 Changeset [104541] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: introduce experimental setting that makes source files always editable
https://bugs.webkit.org/show_bug.cgi?id=75626

Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Timothy Hatcher.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.NavigatorScriptTreeElement.prototype.onselect):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype.setReadOnly):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):

01:08 Changeset [104540] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 116979 to 117006.

  • DEPS:
01:08 Changeset [104539] by loislo@chromium.org
  • 3 edits in trunk/PerformanceTests

Unreviewed test fix after r103683.

  • inspector/first-open-scripts.html:
  • inspector/show-panel.html:

01/09/12:

23:04 EFLWebKit edited by sh4.seo@samsung.com
(diff)
21:42 Changeset [104538] by commit-queue@webkit.org
  • 8 edits
    4 deletes in trunk/Source

Unreviewed, rolling out r104507.
http://trac.webkit.org/changeset/104507
https://bugs.webkit.org/show_bug.cgi?id=75936

Broke webkit_unit_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Removed.
21:39 Changeset [104537] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Touch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.

  • public/WebView.h:
20:44 Changeset [104536] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.

  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png:
20:12 Changeset [104535] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update for test_expectations.txt.

  • platform/chromium/test_expectations.txt:
20:10 Changeset [104534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 116459 to 116979.

  • DEPS:
19:00 Changeset [104533] by dimich@chromium.org
  • 216 edits
    3 copies
    11 moves
    3 adds
    9 deletes in trunk/LayoutTests

[Chromium] Rebaseline a lot of tests with input controls after r104494
https://bugs.webkit.org/show_bug.cgi?id=75924

Unreviewed.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png: Renamed from LayoutTests/platform/chromium/fast/block/float/032-expected.png.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/basic-inputs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-disabled-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-height-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/validation-message-appearance-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Renamed from LayoutTests/platform/chromium/fast/table/colspanMinWidth-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium/fast/forms/minWidthPercent-expected.png: Removed.
  • platform/chromium/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
  • platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Removed.
18:40 Changeset [104532] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-09 Rob Buis <rbuis@rim.com>

Upstream change to disable input[color] css rules for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=75719

Reviewed by Antonio Gomes.

Do not enable default css color rules for inputcolor? for BlackBerry port.

  • CMakeLists.txt:
18:29 Changeset [104531] by commit-queue@webkit.org
  • 7 edits
    7 adds in trunk

Source/WebCore: Implement navigator.startActivity; add IntentRequest object for managing web intents callbacks.
Web content will invoke navigator.startActivity to launch a new Web
Intents call. Each such call will map to an IntentRequest broker
object which is used by client code to correlate any return data to
the (optional) callbacks supplied by web content calls.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

Test: webintents/web-intents-api.html

  • Modules/intents/Intent.cpp: Added.

(WebCore::Intent::identifier):
(WebCore::Intent::setIdentifier):

  • Modules/intents/Intent.h: Added.
  • Modules/intents/Intent.idl: Added.
  • Modules/intents/IntentResultCallback.h: Added.

(WebCore::IntentResultCallback::~IntentResultCallback):

  • Modules/intents/IntentResultCallback.idl: Added.
  • Modules/intents/IntentsRequest.cpp: Added.
  • Modules/intents/IntentsRequest.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeTypeForCallbacks):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::dispatchIntent):

LayoutTests: Implement navigator.startActivity; add IntentsController for managing web intents callbacks.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

  • webintents/web-intents-api-expected.txt: Added.
  • webintents/web-intents-api.html: Added.
18:14 Changeset [104530] by mitz@apple.com
  • 4 edits in trunk

-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
https://bugs.webkit.org/show_bug.cgi?id=75920

Reviewed by Darin Adler.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm

  • page/mac/FrameMac.mm:

(WebCore::Frame::rangeImage): Removed the requirement that the start and end positions used
for setting the selection in the render tree be candidates.

Tools:

  • TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:

(TestWebKitAPI::TEST): Added a test for a range in a
-webkit-user-select: none; block.

18:12 Changeset [104529] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source

Get chromium/linux building again.

18:11 Changeset [104528] by morrita@google.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: Followed the renaming.

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: Followed te renaming.

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp: Followed te renaming.

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()

  • dom/TreeScopeAdopter.cpp: Added.

(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • dom/TreeScopeAdopter.h: Added.

(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

18:03 Changeset [104527] by barraclough@apple.com
  • 5 edits in trunk

Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

  • need to increment the string position.

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
    • added test cases.
17:56 Changeset [104526] by abarth@webkit.org
  • 18 edits
    9 copies
    30 adds in trunk/Source/WebCore

run-bindings-tests should exercise all the IDL attributes we use
https://bugs.webkit.org/show_bug.cgi?id=75900

Reviewed by Eric Seidel.

I just grepped through the code generator script for IDL attributes and
wrote tests for them.

  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetterPrivate.h: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.h: Added.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Added.
  • bindings/scripts/test/JS/JSTestEventTarget.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/JS/JSTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.h: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetterInternal.h: Added.
  • bindings/scripts/test/TestDomainSecurity.idl: Added.
  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/TestEventTarget.idl: Added.
  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestOverridingNameGetter.idl: Added.
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/V8/V8TestActiveDOMObject.h: Added.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp: Added.
  • bindings/scripts/test/V8/V8TestEventTarget.h: Added.
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/scripts/test/V8/V8TestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/V8/V8TestOverridingNameGetter.h: Added.
17:54 Changeset [104525] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

background position parsing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75823

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/background-position-parsing-expected-mismatch.html: Added.
  • css3/calc/background-position-parsing.html: Added.
  • css3/calc/resources/diamond.png: Added.
  • css3/calc/resources/ring.png: Added.
17:32 Changeset [104524] by dpranke@chromium.org
  • 6 edits in trunk/Tools

webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
https://bugs.webkit.org/show_bug.cgi?id=75884

Reviewed by Ryosuke Niwa.

Fix regression introduced (revealed?) in r104340. Chromium file
url syntax is different on win32 and the test results weren't
expecting that.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations._report_errors):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(TestRebaseliner.make_rebaseliner):
(TestRebaseliner.test_one_platform):
(TestRebaseliner.test_all_platforms):
(TestRebaseliner.test_png_file_with_comment):
(TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
(TestRebaseliner.test_png_file_with_comment_as_duplicate):
(TestRealMain.test_all_platforms):

17:24 Changeset [104523] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

http/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
https://bugs.webkit.org/show_bug.cgi?id=75186

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
17:21 Changeset [104522] by nduca@chromium.org
  • 6 edits in trunk/Source/WebCore

[chromium] Add documentation to updater classes
https://bugs.webkit.org/show_bug.cgi?id=75866

Reviewed by James Robinson.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
17:14 Changeset [104521] by jonlee@apple.com
  • 5 edits
    1 copy
    3 adds in trunk/LayoutTests

New pixel test results with r104351.

Unreviewed.

Moved from mac to mac-snowleopard:

  • platform/mac-snowleopard/fast/block/margin-collapse/103

New pixel test results:

  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
17:12 Changeset [104520] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

img size test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75893

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/img-size-expected-mismatch.html: Added.
  • css3/calc/img-size.html: Added.
  • css3/calc/resources/colorsquare.png: Added.
17:08 Changeset [104519] by mrowe@apple.com
  • 2 edits in tags/Safari-535.15.1/Source/JavaScriptCore

Merge r104510.

17:07 Changeset [104518] by mrowe@apple.com
  • 5 edits in tags/Safari-535.15.1/Source

Versioning.

17:07 Changeset [104517] by lforschler@apple.com
  • 2 edits
    3 copies in branches/safari-534.54-branch

Merged r102509.

17:05 Changeset [104516] by mrowe@apple.com
  • 1 copy in tags/Safari-535.15.1

New tag.

17:02 Changeset [104515] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r102377.

17:00 Changeset [104514] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r102263.

16:55 Changeset [104513] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r102016.

16:50 Changeset [104512] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r101584.

16:42 Changeset [104511] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused variable from CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=75895

Reviewed by Eric Seidel.

Unused variables aren't worth keeping around.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

16:41 Changeset [104510] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore framework target <http://webkit.org/b/75907> / <rdar://problem/10659862>

We'd like for it to be possible to build jsc without building JavaScriptCore.framework and the explicit
dependencies prevent this.

Reviewed by Dan Bernstein.

16:39 Changeset [104509] by jonlee@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Temporary fix for pixel result diffs from focus ring (darker color on WK2).
These results should be removed once the cause is found-- filed as bug:
https://bugs.webkit.org/show_bug.cgi?id=75909

Unreviewed.

  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt: Added.
16:33 Changeset [104508] by jonlee@apple.com
  • 72 edits
    21 copies
    21 adds in trunk/LayoutTests

Some gardening with fix for r104351.

Moving pixel test results from mac to mac-snowleopard (because of theme changes):

  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label01
  • platform/mac-snowleopard/fast/forms/button-cannot-be-nested
  • platform/mac-snowleopard/fast/forms/button-inner-block-reuse
  • platform/mac-snowleopard/fast/forms/control-clip-overflow
  • platform/mac-snowleopard/fast/forms/file/input-file-re-render
  • platform/mac-snowleopard/fast/forms/formmove
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur
  • platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed
  • platform/mac-snowleopard/fast/forms/listbox-scrollbar-incremental-load
  • platform/mac-snowleopard/fast/forms/menulist-width-change
  • platform/mac-snowleopard/fast/forms/option-text-clip
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2
  • platform/mac-snowleopard/fast/forms/range/slider-thumb-shared-style
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment
  • platform/mac-snowleopard/fast/forms/select-change-listbox-to-popup
  • platform/mac-snowleopard/fast/forms/select-item-background-clip
  • platform/mac-snowleopard/fast/forms/select-selected
  • platform/mac-snowleopard/fast/forms/select-size
  • platform/mac-snowleopard/fast/forms/select-visual-hebrew
  • platform/mac-snowleopard/fast/forms/textarea-scrollbar
  • platform/mac-snowleopard/fast/forms/textarea-scrolled

New pixel test results:

  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/006-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/mac/fast/forms/button-default-title-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-inner-block-reuse-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/control-clip-overflow-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/formmove-expected.png:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/mac/fast/forms/menulist-width-change-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/option-text-clip-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/forms/range/input-appearance-range-expected.png:
  • platform/mac/fast/forms/range/slider-padding-expected.png:
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-change-listbox-size-expected.png:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-item-background-clip-expected.png:
  • platform/mac/fast/forms/select-selected-expected.png:
  • platform/mac/fast/forms/select-size-expected.png:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
16:31 Changeset [104507] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk/Source

[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-09
Reviewed by James Robinson.

Source/WebCore:

New unit tests: CCLayerIteratorTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h: Added.

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Added.
16:13 Changeset [104506] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Throw exception if IDBCursor.continue() called with lower key than current
https://bugs.webkit.org/show_bug.cgi?id=74213

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

Source/WebCore:

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):

LayoutTests:

  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
16:12 Changeset [104505] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
https://bugs.webkit.org/show_bug.cgi?id=75783

Updated unit test to reflect desired behaviour now that tile/quad culling
is implemented.

Reviewed by James Robinson.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

16:03 Changeset [104504] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Tests for nested flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70776

Reviewed by Tony Chang.

  • css3/flexbox/orthogonal-flex-directions-expected.txt: Added.
  • css3/flexbox/orthogonal-flex-directions.html: Added.
16:01 Changeset [104503] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Windows Build Fix

15:56 Changeset [104502] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Fix potential issue in WebMediaPlayerClientImpl
https://bugs.webkit.org/show_bug.cgi?id=75899

Reviewed by Kenneth Russell.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):

15:53 Changeset [104501] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

15:43 Changeset [104500] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r101091.

15:32 Changeset [104499] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge 100809.

15:23 Changeset [104498] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r100677.

15:16 Changeset [104497] by lforschler@apple.com
  • 9 edits
    5 copies in branches/safari-534.54-branch

Merged r100630.

15:14 Changeset [104496] by leviw@chromium.org
  • 37 edits in branches/subpixellayout/LayoutTests/platform

Updated svg expectations

15:14 Changeset [104495] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.

Unreviewed, build fix.

test-webkitpy had a built-in self-test routine to verify that
deleting the .pyc files worked correctly. When I removed the
python24 directory in r104482, I broke the self-test.

I have deleted the self-test for now. Since I am reworking
test-webkitpy I will make sure the new version is adequately
tested.

  • Scripts/test-webkitpy:

(configure_logging):
(_clean_pyc_files):
(_clean_packages):
(init):

15:13 Changeset [104494] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Dimitri Glazkov.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintTextField):

15:05 Changeset [104493] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGText.cpp

Fix rounding problem in RenderSVGText::nodeAtFloatPoint

14:43 Changeset [104492] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=75692
Roll out possibly bad new test case.

Rubber stamped by Sam Weinig.

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
14:06 Changeset [104491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Log is a little to verbose for blackberry port
https://bugs.webkit.org/show_bug.cgi?id=75728

The BlackBerry::Platform::Log* functions take care of the call to vfprintf
which is resulting in unintentional noise in our logs. Add a conditional
directive to fix.

Change to using BlackBerry::Platform::logStreamV which does not insert
threading info and newlines unlike BlackBerry::Platform::log.

Finally, add log locking and unlocking which the BlackBerry platform
uses to ensure that N threads do not trample on each other's logs.

Patch by Adam Treat <atreat@rim.com> on 2012-01-09
Reviewed by Rob Buis.

  • wtf/Assertions.cpp:

(WTFLogLocker::WTFReportAssertionFailure):
(WTFLogLocker::WTFReportAssertionFailureWithMessage):
(WTFLogLocker::WTFReportArgumentAssertionFailure):
(WTFLogLocker::WTFReportFatalError):
(WTFLogLocker::WTFReportError):
(WTFLogLocker::WTFLog):
(WTFLogLocker::WTFLogVerbose):

14:02 Changeset [104490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compilation error on build-webkit --debug --no-3d-canvas on mac.
https://bugs.webkit.org/show_bug.cgi?id=75878

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-09
Reviewed by Alexey Proskuryakov.

  • html/canvas/WebGLContextEvent.cpp:
14:00 Changeset [104489] by dimich@chromium.org
  • 1 edit
    1 move
    1 add
    4 deletes in trunk/LayoutTests

[Chromium] Rebaseline media/media-document-audio-repaint.html for gpu tests.
https://bugs.webkit.org/show_bug.cgi?id=75888

Unreviewed.

  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/media-document-audio-repaint-expected.txt.
13:56 Changeset [104488] by barraclough@apple.com
  • 14 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75789
defineOwnProperty not implemented for Array objects

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Implements support for getter/setter & non-default attribute properties on arrays,
by forcing them into a dictionary-like 'SparseMode'. This fixes ~300 test-262
test failures.

  • JavaScriptCore.exp:
    • Updated exports.
  • dfg/DFGOperations.cpp:
    • JSArray::pop now requires an exec state.
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):

  • JSArray::pop now requires an exec state.
  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::add):

  • Add a potentially empty entry into the map.

(JSC::SparseArrayValueMap::put):

  • Changed to call setter.

(JSC::SparseArrayEntry::get):

  • calls getters.

(JSC::SparseArrayEntry::getNonSparseMode):

  • does not call getters.

(JSC::JSArray::enterSparseMode):

  • Convert into 'SparseMode' - removes the vectors, don't allow it to be recreated.

(JSC::JSArray::putDescriptor):

  • Create a numeric property based on a descriptor.

(JSC::sameValue):

  • See ES5.1 9.12.

(JSC::reject):

(JSC::JSArray::defineOwnNumericProperty):

  • Define an indexed property on an array object.

(JSC::JSArray::setLengthWritable):

  • Marks the length read-only, enters SparseMode as necessary.

(JSC::JSArray::defineOwnProperty):

  • Defines either an indexed property or 'length' on an array object.

(JSC::JSArray::getOwnPropertySlotByIndex):

  • Updated to correctly handle accessor descriptors & attributes.

(JSC::JSArray::getOwnPropertyDescriptor):

  • Updated to correctly handle accessor descriptors & attributes.

(JSC::JSArray::put):

  • Pass strict mode flag to setLength.

(JSC::JSArray::putByIndex):

  • putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.

(JSC::JSArray::putByIndexBeyondVectorLength):

  • Pass exec to SparseArrayValueMap::put.

(JSC::JSArray::deletePropertyByIndex):

  • Do not allow deletion of non-configurable properties.

(JSC::compareKeysForQSort):

  • used in implementation of getOwnPropertyNames.

(JSC::JSArray::getOwnPropertyNames):

  • Properties in the sparse map should be iterated in order.

(JSC::JSArray::setLength):

  • Updated to take a 'shouldThrow' flag, return a result indicating error.

(JSC::JSArray::pop):

  • pop should throw an error if length is not writable, even if the array is empty.

(JSC::JSArray::push):

  • putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.

(JSC::JSArray::sort):

  • Changed 'get' to 'getNonSparseMode' (can't be getters to call).

(JSC::JSArray::compactForSorting):

  • Changed 'get' to 'getNonSparseMode' (can't be getters to call).
  • runtime/JSArray.h:

(JSC::SparseArrayValueMap::lengthIsReadOnly):

  • Check if the length is read only.

(JSC::SparseArrayValueMap::setLengthIsReadOnly):

  • Mark the length as read only.

(JSC::SparseArrayValueMap::find):

  • Moved into header.

(JSC::JSArray::isLengthWritable):

  • Wraps SparseArrayValueMap::lengthIsReadOnly.
  • runtime/JSObject.cpp:

(JSC::JSObject::defineOwnProperty):

  • Should be returning the result of putDescriptor.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::attributesOverridingCurrent):

  • Added attributesOverridingCurrent - this should probably be merged with attributesWithOverride.
  • runtime/PropertyDescriptor.h:
    • Added attributesOverridingCurrent.

LayoutTests:

  • fast/js/array-defineOwnProperty-expected.txt: Added.
  • fast/js/array-defineOwnProperty.html: Added.
  • fast/js/script-tests/array-defineOwnProperty.js: Added.
    • Added tests for array properties with accessors & non-defulat attributes.
  • fast/js/mozilla/strict/15.4.4.6-expected.txt:
  • fast/js/mozilla/strict/8.12.5-expected.txt:
  • ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
    • Check in passing results.
13:50 Changeset [104487] by levin@chromium.org
  • 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp

Fix M17 build.

13:32 Changeset [104486] by tsepez@chromium.org
  • 3 edits
    4 adds in trunk

Treat code="" attribute in embed tags similarly to applet tags.
https://bugs.webkit.org/show_bug.cgi?id=75871

Reviewed by Daniel Bates.

Source/WebCore:

Tests: http/tests/security/xssAuditor/embed-tag-code-attribute-2.html

http/tests/security/xssAuditor/embed-tag-code-attribute.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterEmbedToken):

LayoutTests:

  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2.html: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute.html: Added.
13:25 Changeset [104485] by commit-queue@webkit.org
  • 13 edits in trunk

[Chromium] remove all references to the legacy accelerated 2d Canvas
implementation
https://bugs.webkit.org/show_bug.cgi?id=75108

Purging an old settings flag that is no longer referenced

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Darin Fisher.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAccelerated2dCanvasEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
13:16 Changeset [104484] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing SVG's initial transform to local coordinates to pixel snap. Also fixing widget alignment corner cases.

13:16 Changeset [104483] by aroben@apple.com
  • 2 edits in trunk/Tools

Convert Cygwin paths to Windows paths before passing them to DRT

Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
NRWT

I couldn't find a way to test this because I couldn't figure out how to override the
cygpath function as it is used by WebKitDriver.

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
Windows-style path before passing it to DRT.

13:10 Changeset [104482] by dpranke@chromium.org
  • 9 edits
    1 copy
    3 deletes in trunk/Tools

webkitpy: revamp version checking
https://bugs.webkit.org/show_bug.cgi?id=75765

Reviewed by Adam Barth.

The version-checking code in webkitpy/python24/versioning seems really
awkward and overdesigned, especially since we don't support python 2.4
any more.

In addition, I am tired of getting warnings about Python 2.6 being "a
newer release than what is supported" :).

I'm taking a page from the depot_tools python code and just creating a
new webkitpy.common.version_check module that will print a message on
stderr and call sys.exit() if we're running an unsupported version.

  • Scripts/check-webkit-style:
  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-tests:
  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/test-webkitpy:

(configure_logging):
(init):

  • Scripts/webkit-patch:

(main):

  • Scripts/webkitpy/common/system/executive.py:

(Executive._child_process_encoding):
(Executive._should_encode_child_process_arguments):

  • Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/python24/init.py: Removed.
  • Scripts/webkitpy/python24/versioning.py: Removed.
  • Scripts/webkitpy/python24/versioning_unittest.py: Removed.
13:08 Changeset [104481] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Make WebIDBDatabase::close() idempotent
https://bugs.webkit.org/show_bug.cgi?id=75751

Source/WebKit/chromium:

Allow Chromium's back-end to safely trigger the cleanup that occurs
when a database connection is closed, without tracking whether or not
the connection was previous closed by script.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::close):

LayoutTests:

Verify that calling IDBDatabase.close() twice from script is harmless.
Note that the tests pass without the related code change in the bug,
which is just for non-script use by the chromium port.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
12:58 Changeset [104480] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

remove reference to cg-specific test
https://bugs.webkit.org/show_bug.cgi?id=75881

Patch by Elliot Poger <epoger@google.com> on 2012-01-09
Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [104479] by eric.carlson@apple.com
  • 4 edits in trunk

Source/WebCore: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html
intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

No new tests, covered by existing tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_ignoreTrackDisplayUpdate.

LayoutTests: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

Re-enable <track> tests disabled after r104327.

  • platform/chromium/test_expectations.txt:
12:47 Changeset [104478] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r100343.

12:38 Changeset [104477] by abarth@webkit.org
  • 4 edits in trunk/Tools

Remove Chromium Mac CG from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=75873

Reviewed by Ojan Vafai.

This configuration no longer exists.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testOverrideJustBuildType):
(testPlatformAndBuildType):

12:22 Changeset [104476] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Add normalize attribute to ConvolverNode to disable normalization.
https://bugs.webkit.org/show_bug.cgi?id=75126

Patch by Raymond Toy <rtoy@google.com> on 2012-01-09
Reviewed by Kenneth Russell.

Tests added in convolution-mono-mono.html.

  • platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb): Add extra arg to indicate whether
normalization is enabled or not, and do it.

  • platform/audio/Reverb.h: Update declaration.
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode): Initialize attribute (to
true).
(WebCore::ConvolverNode::setBuffer): Call Reverb with
normalization argument.

  • webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::normalize): New method to return
normalization.
(WebCore::ConvolverNode::setNormalize): New method to set
normalization.

  • webaudio/ConvolverNode.idl: Add normalize attribute.
  • LayoutTests/webaudio/convolution-mono-mono.html:
  • LayoutTests/webaudio/convolution-mono-mono-expected.txt:
  • LayoutTests/webaudio/resources/convolution-testing.js:

Test for convolution. Tests only work when normalization is
disabled.

12:17 Changeset [104475] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224

Patch by Judy Hao <judy.liqiong-hao@nokia.com> on 2012-01-09
Reviewed by Philippe Normand.

Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.

Fixing memory leaks. So, no new test case is introduced.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):

12:15 Changeset [104474] by wangxianzhu@chromium.org
  • 14 edits
    1 add in trunk/Source

Avoid unnecessary TextureManager::reduceMemoryToLimit().
https://bugs.webkit.org/show_bug.cgi?id=75632

Source/WebCore:

Unnecessary TextureManager::reduceMemoryToLimit() will cause some tile
textures that are required soon to be unnecessarily removed/replaced,
and degrade performance, sometimes significantly.

For example, CCLayerTreeHost::setViewport will be called during
scrolling. The original code would call TextureManager::reduceMemoryToLimit(),
causing some textures unnecessarily discarded and then recreated
repeatedly during scrolling.

It's also unnecessary to call TextureManager::reduceMemoryToLimit()
from TextureManager::setPreferredMemoryLimitBytes() because the limit
is not a hard limit. The callers should call reduceMemoryToLimit()
explicitly if it wants it when setting the preferred memory limit.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::finishDrawingFrame): Call reduceMemoryToLimit() explicitly

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::setPreferredMemoryLimitBytes): Removed call to reduceMemoryToLimit().

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize): Changed name from setViewport(). Check change of viewportSize.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setViewportSize): Changed name from setViewport()

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Main part of the change is in Source/WebCore.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

  • WebKit.gypi:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setViewportSize):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::CCLayerTreeHostTestSetViewportSize):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::afterTest):
(WTF::TEST_F):

  • tests/TextureManagerTest.cpp: Added.

(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeTextureAllocator::deleteTexture):
(WTF::texturesMemorySize):
(WTF::createTextureManager):
(WTF::requestTexture):
(WTF::TEST):

12:02 Changeset [104473] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

There is no support for fastcall in Solaris Studio.
Fixes build on Solaris.
https://bugs.webkit.org/show_bug.cgi?id=75736

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

  • jit/JITStubs.h:
11:46 Changeset [104472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] JPEG RGB swizzling order should match platform pixel format
https://bugs.webkit.org/show_bug.cgi?id=75861

Choose between JCS_EXT_BGRX and JCS_EXT_RGBX channel swizzling
based on the configured Skia 32-bit pixel format.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-09
Reviewed by Kenneth Russell.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(rgbOutputColorSpace):

11:44 Changeset [104471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build failure on Solaris
https://bugs.webkit.org/show_bug.cgi?id=75733

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

  • wtf/ByteArray.h:
11:41 Changeset [104470] by levin@chromium.org
  • 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 104419 - [chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/9151009

11:26 Changeset [104469] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-radius is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75630

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-radius shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.
11:17 Changeset [104468] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Clean up some cruft from WTF's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420

Reviewed by Daniel Bates.

  • wtf/CMakeLists.txt: Remove the unused WTF_PORT_FLAGS variable; add

all needed paths to WTF_INCLUDE_DIRECTORIES in a single place.

11:16 Changeset [104467] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-gpu-cg-mac

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 Changeset [104466] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-snowleopard

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 Changeset [104465] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-leopard

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 Changeset [104464] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

10:38 Changeset [104463] by aroben@apple.com
  • 3 edits in trunk/Tools

Print an error message when NRWT can't run Apache

Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.check_httpd): Print an error message when Apache returns an error code instead of
failing silently.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
run Apache.
(PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
fails.

07:34 Changeset [104462] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75856

media/track/track-webvtt-tc026-voice.html is crashing on Chromium
Debug Mac after http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:32 Changeset [104461] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Gtk][ARM] Cross compiler buildbot is failing after r103040
https://bugs.webkit.org/show_bug.cgi?id=75846

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):

07:19 Changeset [104460] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r104418.
http://trac.webkit.org/changeset/104418
https://bugs.webkit.org/show_bug.cgi?id=75855

we still need to build against CG on Mac sometimes (Requested
by epoger on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
07:08 Changeset [104459] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] [AC] Simplify accelerated compositing build options
https://bugs.webkit.org/show_bug.cgi?id=75518

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-09
Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac: Remove the --enable-3d-rendering option. It's enabled by

default now when accelerated compositing is enabled.

  • GNUmakefile.am: Automatically enable 3D rendering when accelerated compositing

is turned on.

Source/WebCore:

  • GNUmakefile.am: Automatically enable 3D rendering when AC is available.
  • GNUmakefile.list.am: Clean up a comment.
06:59 Changeset [104458] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676

Reviewed by Andreas Kling.

Based on the stacks, CSSStyleSelector may be getting deleted from under the
CSSStyleSelector::appendAuthorStylesheets call. Protect by temporarily detaching
from the document. Also add assertions to catch the case.

No test, there is no known repro and the fix is speculative.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:
06:30 Changeset [104457] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use Vector<OwnPtr> for m_viewportDependentMediaQueryResults in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=75723

Reviewed by Andreas Kling.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):

  • css/CSSStyleSelector.h:
06:28 Changeset [104456] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75852

http/tests/inspector/network/download.html is timing out on mac, and
occasionally on other platforms too.

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:14 Changeset [104455] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Tools

[Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75807

This patch adds a new icon to navigationbar of the Qt MiniBrowser
which allows you to dynamically toggle whether touch mocking is
enabled or disabled.

Patch by Alexander Færøy <ahf@0x90.dk> on 2012-01-09
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::touchMockingEnabled):
(WindowOptions::setTouchMockingEnabled):

  • MiniBrowser/qt/icons/touch.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
06:05 Changeset [104454] by ossy@webkit.org
  • 2 edits
    1 copy in trunk/LayoutTests

Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
https://bugs.webkit.org/show_bug.cgi?id=75847

Reviewed by Philippe Normand.

  • fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add JSC specifix expected file as generic expected file.
  • platform/chromium/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add V8 specifix expected file.
06:00 Changeset [104453] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75849

We need to prevent TextTrack and TextTrackCue from being
garbage collected when the parent/owner is still reachable.
This is tracked in bug 73865.

Unreviewed.

  • platform/chromium/test_expectations.txt:
05:48 Changeset [104452] by alexis.menard@openbossa.org
  • 8 edits in trunk/Source/WebCore

Extend CSSValueList to allow slash separated lists.
https://bugs.webkit.org/show_bug.cgi?id=75841

Reviewed by Andreas Kling.

Multiple CSS properties are using slash to separate
various parts (e.g. border-radius) so having this
feature available in CSSValueList will make it easier
in the future to support these properties.

No new tests : existing ones should cover the refactor.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::isImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::isImplicitInitialValue):

  • css/CSSValue.h:

In order for CSSValue to not grow I moved m_isImplicitInitialValue
back to CSSInitialValue as this object is used only in CSSValuePool
and is allocated only twice.
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
Fix also usage of PassRefPtr.
(WebCore::CSSValueList::customCssText):
Refactor to use StringBuilder.

  • css/CSSValueList.h:

(WebCore::CSSValueList::createCommaSeparated):
(WebCore::CSSValueList::createSpaceSeparated):
(WebCore::CSSValueList::createSlashSeparated):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

05:22 Changeset [104451] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75844

media/track/track-cues-cuechange.html is failing after
http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

  • platform/chromium/test_expectations.txt:
04:35 Changeset [104450] by abecsi@webkit.org
  • 23 edits in trunk

[Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601

Reviewed by Kenneth Rohde Christiansen.

The current implementation uses the scale property of the QQuickWebPage
to scale the page in response to pinch gestures.
However for layout and anchoring to work correctly in QML, pinching needs
to change the page size.
This patch applies the pinch scale to the page size and to the transformation
matrix of the drawing area.
Thus the page item's coordinate system is no longer a direct representation
of the WebCore::Page coordinate system and it is no longer suitable as
an inertial frame of reference for input events. The event propagation had
to be moved to the QQuickWebView and the positions translated to content
coordinates when NativeWebEvents are created.
Re-landing with fixed event delivery for the test infrastructure.

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::geometryChanged):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::usesTraditionalDesktopBehaviour):
(QQuickWebPage::setUsesTraditionalDesktopBehaviour):
(QQuickWebPage::eventHandler):
(QQuickWebPage::setContentSize):
(QQuickWebPage::contentSize):
(QQuickWebPage::setContentScale):
(QQuickWebPage::contentScale):
(QQuickWebPage::transformFromItem):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::mapToWebContent):
(QQuickWebView::mapRectToWebContent):
(QQuickWebView::mapFromWebContent):
(QQuickWebView::mapRectFromWebContent):
(QQuickWebView::geometryChanged):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
04:13 Changeset [104449] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Set color_set function to the clipped smart class.
https://bugs.webkit.org/show_bug.cgi?id=75286

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-09
Reviewed by Andreas Kling.

Set _ewk_view_smart_color_set() function to the clipped smart class's color_set,
so application can set webpage's background color using evas_object_color_set() API.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_color_set):
(ewk_view_smart_class_init):

04:06 Changeset [104448] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75840

Unreviewed.

fast/filesystem/file-writer-abort.html is occasionally crashing
also on Windows.

  • platform/chromium/test_expectations.txt:
03:54 Changeset [104447] by noam.rosenthal@nokia.com
  • 7 edits
    1 add in trunk/Source/WebCore

[Texmap] Move surface management from TextureMapperNode to TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=75779

Instead of a TextureMapperSurfaceManager class inside of TextureMapperNode.cpp, we now
maintain that surface pool inside of the TextureMapper class. This will later allow us to
allocate intermediate surface from within TextureMapperGL, a functionality we need for
filters.

Also, surfaces are not automatically created with the viewport size, but rather with the
size passed as a parameter. The surface from the pool is the smallest texture that is
larger than the required size, or any texture if such texture is not yet allocated.

Reviewed by Kenneth Rohde Christiansen.

Tests in LayoutTests/compositing already cover this.

  • GNUmakefile.list.am: Added TextureMapper.cpp to the build.
  • Target.pri: Added TextureMapper.cpp to the build.
  • WebCore.gypi: Added TextureMapper.cpp to the build.
  • platform/graphics/texmap/TextureMapper.cpp: Added.
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::paintRecursive):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::TextureMapperNode):

02:16 Changeset [104446] by mario@webkit.org
  • 6 edits in trunk/Source

[Gtk] Regression: text-inserted events lack text inserted and current line
https://bugs.webkit.org/show_bug.cgi?id=72830

Reviewed by Martin Robinson.

Source/WebCore:

Fix issue getting the exposed text for an accessibility object at,
before of after a given offset, after changing it at least once.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_class_init): Don't initialize
gailTextUtilQuark, it won't be used anymore.
(getGailTextUtilForAtk): Don't cache the GailTextUtil as object
data, but create a new one each time this function is called.
(webkit_accessible_text_get_caret_offset): Simplified code by
using the new focusedObjectAndCaretOffsetUnignored function,
instead of the old objectAndOffsetUnignored function.
(focusedObjectAndCaretOffsetUnignored): Rewrite of the old
objectAndOffsetUnignored function so it now needs less
parameters than before and takes care of carefully selecting the
start and end visible positions to calculate the position of the
caret from the point of view of the accessibility object of
reference passed as the only input parameter now. Updated callers.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h:
  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Simplified code by calling to focusedObjectAndCaretOffsetUnignored
function, instead of the old objectAndOffsetUnignored function.

Source/WebKit/gtk:

Updated unit tests to check that both getting the current position
for the caret and the exposed text at, before or after a given
offset for an accessible object works as expected.

  • tests/testatk.c:

(runGetTextTests): For objects implementing AtkEditableText, try
to change the exposed text and retrieve it again as a full line.
(testWebkitAtkCaretOffsets): For a text control (a text entry),
set the caret offset to a value greater than 1 and retrieve it.

02:00 Changeset [104445] by antti@apple.com
  • 4 edits
    2 adds in trunk

Subtree invalidation on stylesheet change
https://bugs.webkit.org/show_bug.cgi?id=75834

Source/WebCore:

Reviewed by Andreas Kling.

Currently if we add a stylesheet with scoped selectors and matching scope elements exist,
we recalculate the entire document style. It is sufficient to invalidate the subtrees
matching the scope only.

This allows us to do less full style recalcs on many popular web sites (nytimes.com for example).
Subtree recalcs are typically much cheaper.

Test: fast/css/id-or-class-before-stylesheet.html

  • dom/Document.cpp:

(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/id-or-class-before-stylesheet-expected.txt: Added.
  • fast/css/id-or-class-before-stylesheet.html: Added.
01:53 Changeset [104444] by carlosgc@webkit.org
  • 4 edits in trunk

Unreviewed. Fix make distcheck issues.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
01:38 Changeset [104443] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument string
in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=75830

Reviewed by Adam Barth.

The code in CodeGeneratorJS.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):

01:09 Changeset [104442] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: Remove propertiesEqual().
<http://webkit.org/b/75829>

Reviewed by Antti Koivisto.

Remove propertiesEqual() since it was wrong (it only compared CSSValue pointers,
not the actual values.)

Skip comparing the style declarations in NamedNodeMap::mappedMapsEquivalent()
and just compare pointers instead. This is possible because the declarations
all come from the mapped attribute/declaration table.

  • css/CSSMutableStyleDeclaration.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

00:53 Changeset [104441] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

insertAdjacentHTML doesn't play nice with DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=75826

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html

Document nodes aren't the only non-Element ContainerNodes.

  • html/HTMLElement.cpp:

(WebCore::contextElementForInsertion):

LayoutTests:

  • fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Added.
  • fast/dom/insertAdjacentHTML-DocumentFragment-crash.html: Added.
00:42 Changeset [104440] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Any attribute with a decl() can be assumed to be mapped.
<http://webkit.org/b/75832>

Reviewed by Antti Koivisto.

Replace isMappedAttribute() check with an assertion. Only a mapped attribute
will have an associated style declaration.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

00:32 Changeset [104439] by philn@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104412.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.
  • platform/gtk/Skipped: Skip fast/text/international/spaces-combined-in-vertical-text.html
00:26 Changeset [104438] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument
string in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=75828

Reviewed by Darin Adler.

The code in CodeGeneratorV8.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

00:06 Changeset [104437] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r104412.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

01/08/12:

23:18 Changeset [104436] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation error about ListHashSetReverseIterator
https://bugs.webkit.org/show_bug.cgi?id=75372

Reviewed by Darin Adler.

There is a typo in class ListHashSetReverseIterator:
typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
Should be
typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;

  • wtf/ListHashSet.h:
23:15 Changeset [104435] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
https://bugs.webkit.org/show_bug.cgi?id=75827

Reviewed by Darin Adler.

Explicitly initialize the struct timeval to avoid compiler warnings.

  • platform/mac/ScrollAnimatorMac.mm:

(systemUptime):

23:09 Changeset [104434] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

23:01 Changeset [104433] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.3

New tag.

22:56 Changeset [104432] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

color tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75819

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/color-hsl-expected.txt: Added.
  • css3/calc/color-hsl.html: Added.
  • css3/calc/color-rgb-expected.txt: Added.
  • css3/calc/color-rgb.html: Added.
22:14 Changeset [104431] by mikelawther@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

font tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75818

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/font-expected.txt: Added.
  • css3/calc/font-monospace-expected.txt: Added.
  • css3/calc/font-monospace.html: Added.
  • css3/calc/font-size-expected.txt: Added.
  • css3/calc/font-size-fractional-expected.txt: Added.
  • css3/calc/font-size-fractional.html: Added.
  • css3/calc/font-size.html: Added.
  • css3/calc/font.html: Added.
22:01 Changeset [104430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75820

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-01-08
Reviewed by Darin Adler.

Dbates submitted a patch to release fastMalloc allocation
in GraphicsContext3DOpenGL.cpp properly.
See http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
But one thing similar to the above still remains mismatched.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getShaderInfoLog):

20:27 Changeset [104429] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

WinCE build fix after r104415.

  • jit/JITExceptions.cpp:
  • jit/JITExceptions.h:
18:57 Changeset [104428] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

border tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75815

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

Reviewed by Adam Barth.

  • css3/calc/border-expected.txt: Added.
  • css3/calc/border-radius-expected-mismatch.html: Added.
  • css3/calc/border-radius.html: Added.
  • css3/calc/border.html: Added.
18:50 Changeset [104427] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
https://bugs.webkit.org/show_bug.cgi?id=75611

Reviewed by Antonio Gomes.

In platform/network/blackberry/ResourceHandleBlackBerry.cpp, we were using
NetworkingContext::wrappedFrame() to access the frame associated with the
networking context. NetworkingContext::wrappedFrame() was added as a virtual
function by the BlackBerry porting internally. It's unnecessary because
FrameNetworkingContextBlackBerry inherits from FrameNetworkingContext which
has a protected frame() member which is exported as public in
FrameNetworkingContextBlackBerry. We don't want to upstream wrappedFrame()
as a specific change of the BlackBerry porting in
platform/network/NetworkingContext.h, so use the concrete networking context
FrameNetworkingContextBlackBerry to access the associated frame.

No functionalities changed, no new tests.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

18:41 Changeset [104426] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add intermittent timeout expectations to media/track/track-cues-cuechange.html and
media/track/track-cues-enter-exit.html. The failure is tracked by the bug 75817.

  • platform/chromium/test_expectations.txt:
18:33 Changeset [104425] by commit-queue@webkit.org
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104421.
http://trac.webkit.org/changeset/104421
https://bugs.webkit.org/show_bug.cgi?id=75816

Need to rebaseline some tests on Linux (Requested by noamr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
18:14 Changeset [104424] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

Another Chromium Windows and Chromium Linux rebaseline after r104240.
The expected result committed in r104361 was clearly wrong.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
17:01 Changeset [104423] by abarth@webkit.org
  • 6 edits in trunk/Tools

Remove support for Chromium Mac CG from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=75814

Reviewed by Eric Seidel.

This configuration no longer exists. This patch is mostly a matter of
updating config.js and removing the examples from the unit tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
16:49 Changeset [104422] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove Mac CG specific expectations in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=75813

Unreviewed.

This configuration no longer exists and this change is needed to stop
the bots from erroring out.

  • platform/chromium/test_expectations.txt:
16:46 Changeset [104421] by noam.rosenthal@nokia.com
  • 8 edits
    54 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
16:32 Changeset [104420] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Eric Seidel.

Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
(Chromium still comes before GTK and Qt).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
16:29 Changeset [104419] by levin@chromium.org
  • 4 edits
    5 adds in trunk

[chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.
16:27 Changeset [104418] by abarth@webkit.org
  • 5 edits in trunk/Source

[Chromium] Remove use_skia option from GYP
https://bugs.webkit.org/show_bug.cgi?id=75811

Reviewed by Ryosuke Niwa.

The CG configuration of Chromium Mac is no longer supported.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
16:12 Changeset [104417] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Remove the concept of core builders from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75809

Reviewed by Ryosuke Niwa.

Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
and remove the relevant code.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init):
(BuildBot._matches_regexps):
(BuildBot._builder_statuses_with_names_matching_regexps):
(BuildBot.builder_statuses):
(BuildBot.failure_map):
(BuildBot._latest_builds_from_builders):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_status_parsing):
(test_last_green_revision):
(test_last_green_revision.mock_builds_from_builders):

16:04 Changeset [104416] by abarth@webkit.org
  • 19 edits in trunk/Tools

Remove Chromium Mac CG concept from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75810

Reviewed by Ryosuke Niwa.

This configuration no longer exists. We can remove all the supporting
code from webkitpy.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
(BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build):

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.integration_test_chromium_gpu_mac):
(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest.test_baseline_paths):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):
(ChromiumMacPort.init):
(ChromiumMacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_graphics_type):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_mac):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockChromiumDRTTest.test_chromium_parse_options):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(test_url_fetcher):
(test_zip_factory):
(test_archive):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_expectations):

15:46 Changeset [104415] by fpizlo@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

The JIT's protocol for exception handling should be available to other parts of the system
https://bugs.webkit.org/show_bug.cgi?id=75808
<rdar://problem/10661025>

Reviewed by Oliver Hunt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • jit/JITExceptions.cpp: Added.

(JSC::genericThrow):
(JSC::jitThrow):

  • jit/JITExceptions.h: Added.
  • jit/JITStubs.cpp:
  • runtime/JSGlobalData.h:
15:44 Changeset [104414] by benjamin@webkit.org
  • 10 edits
    6 adds in trunk

Valid canonical URLs should have a lowercase hostname
https://bugs.webkit.org/show_bug.cgi?id=75771

Reviewed by Adam Barth.

Source/WebCore:

According to the RFC 3986 (and other browsers implementation), the hostname
of valid canonical URLs should be lowercase.

This patch lowercase the hostname in KURL::parse() similarily to what we
do for the scheme.

Tests: fast/url/host-lowercase-per-scheme.html

fast/url/safari-extension.html

  • platform/KURL.cpp:

(WebCore::isCanonicalHostnameLowercaseForScheme):
(WebCore::KURL::parse):

LayoutTests:

Update the test results for existing tests validating the hostname.

Added the test safari-extension.html for checking regressions of
the safari-extension:// protocol.

Added host-lowercase-per-scheme.html for testing the hostname is
set to lowercase for regognized Internet protocols.

  • fast/url/host-expected.txt:
  • fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • fast/url/host-lowercase-per-scheme.html: Added.
  • fast/url/idna2008-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/safari-extension-expected.txt: Added.
  • fast/url/safari-extension.html: Added.
  • fast/url/standard-url-expected.txt:
  • platform/chromium/fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • platform/chromium/fast/url/safari-extension-expected.txt: Added.
15:28 Changeset [104413] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Adam Barth.

Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
15:15 Changeset [104412] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Sam Weinig.

This patch contains only renames and FIXME comments. No behavior change.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::allowAccessToNode):
(WebCore::allowAccessToFrame):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::allowSettingJavascriptURL):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

14:48 Changeset [104411] by abarth@webkit.org
  • 15 edits in trunk/Source/WebCore

Remove deprecated toDynamicFrame and unused [CallWith=DynamicFrame]
https://bugs.webkit.org/show_bug.cgi?id=75795

Reviewed by Eric Seidel.

We've succeeded in removing all the callers fo this function, including
all the uses of CallWith=DynamicFrame in IDL files.

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
13:59 Changeset [104410] by abarth@webkit.org
  • 14 edits in trunk/Source/WebCore

NeedsUserGestureCheck IDL attribute is no longer used
https://bugs.webkit.org/show_bug.cgi?id=75794

Reviewed by Eric Seidel.

This IDL attribute is no longer used because we use static state to
keep track of the user gesture state. We can delete the code that
supports it.

  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
13:44 Changeset [104409] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r103859): WKViews leak
https://bugs.webkit.org/show_bug.cgi?id=75805

The flags changed event monitor added in r103859 was retaining the WKView (as it references
self in the handler block), causing it to leak.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Moved call to remove the flags changed event monitor from here...
(-[WKView viewDidMoveToWindow]): ...to here. Moved call to add the flags changed event
monitor to here from...
(-[WKView initWithFrame:contextRef:pageGroupRef:]): ...here.

13:33 Changeset [104408] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove unused security functions from V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=75797

Reviewed by Eric Seidel.

This functions have no callers. They can be removed.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
13:31 Changeset [104407] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
https://bugs.webkit.org/show_bug.cgi?id=75656

Reviewed by Darin Adler.

Update the implementation of SubresourceLoader::didReceiveDataArray() to conform to the
refactoring done as part of bug 71149 in r100311.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::errorLoadingResource):

  • loader/SubresourceLoader.h:
  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):

13:03 Changeset [104406] by steveblock@google.com
  • 6 edits
    9 deletes in trunk/Source/WebCore

Remove V8-specific Java Bridge code
https://bugs.webkit.org/show_bug.cgi?id=75801

Reviewed by Darin Adler.

Also remove superfluous JSC and V8 guards, as the code is now used only
with JSC.

No new tests, removing dead code only.

  • WebCore.gypi:
  • bridge/jni/JNIUtility.cpp:

(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):

  • bridge/jni/JavaType.h:
  • bridge/jni/jsc/JavaMethodJSC.cpp:

(appendClassName):
(JavaMethod::signature):

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Removed.
  • bridge/jni/v8/JNIUtilityPrivate.h: Removed.
  • bridge/jni/v8/JavaClassV8.h: Removed.
  • bridge/jni/v8/JavaFieldV8.h: Removed.
  • bridge/jni/v8/JavaInstanceV8.h: Removed.
  • bridge/jni/v8/JavaMethodV8.h: Removed.
  • bridge/jni/v8/JavaNPObjectV8.cpp: Removed.
  • bridge/jni/v8/JavaNPObjectV8.h: Removed.
  • bridge/jni/v8/JavaValueV8.h: Removed.
  • bridge/jsc/BridgeJSC.h:
11:35 Changeset [104405] by ossy@webkit.org
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104403.
http://trac.webkit.org/changeset/104403
https://bugs.webkit.org/show_bug.cgi?id=75803

It broke all tests on Qt5 (Requested by Ossy_weekend on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
11:22 Changeset [104404] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Don't create style selector in Element::recalcStyleIfNeededAfterAttributeChanged if it doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=75802

Rubber-stamped by Andreas Kling.

Element::recalcStyleIfNeededAfterAttributeChanged shouldn't create style selector for attribute
check if it doesn't already exist. We are going to need a full style recalc anyway in that case
and the constructed style selector may get throw out again.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

10:05 Changeset [104403] by noam.rosenthal@nokia.com
  • 8 edits
    55 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
08:46 Changeset [104402] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Rewrite the CSS parser of prepare-ChangeLog with unittests.
https://bugs.webkit.org/show_bug.cgi?id=75202

Reviewed by David Kilzer.

The current CSS parser can just parse simple CSSes like

foo bar baz {

property1: value;
property2: value;

}

, and cannot parse comments nor a CSS in which a selector and {
appears in different lines. This patch rewrites the CSS parser
(i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
shown in css_unittests.css.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css

  • Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.

(element1):
(element2):
(element3):
(element4.p):
(element5.p.q.r.s):
(element6#p):
(element7 element8):
(element9.p element10.q):
(element11#p element12#q):
(element13, element14):
(.p):
(#p):
(.p element15 #q element16.r element17#s):
(element18:target):
(element19):
(element20):
(element21):
(element22):

08:21 Changeset [104401] by haraken@chromium.org
  • 4 edits in trunk/Tools

The Perl parser of prepare-ChangeLog can parse here-documents
https://bugs.webkit.org/show_bug.cgi?id=73208

Reviewed by David Kilzer.

Currently prepare-ChangeLog cannot recognize here-documents in Perl,
which results in wrong subroutine names in ChangeLogs.
With this patch, prepare-ChangeLog can judge whether the line of "}"
is the end of a subroutine or a line inside a here-document.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_perl):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:

Added test cases for here-documents.
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(func16):

08:15 Changeset [104400] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the JavaScript parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75201

Reviewed by David Kilzer.

javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
of prepare-ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript): Before this patch, a string found was just
omitted from parsing. Thus,

str = "foo"
function func() {
}

was recognized as equivalent to

str = function func() {
}

This patch replaces a string with a dummy identifier 'string_appeared_here'
to tell the parser that a string appeared there.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.

(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(funcOverloaded):
(Func1.prototype.get x1):
(Func1.prototype.get x2):
(Func1.prototype.set x1):
(Func1.prototype.set x3):
(Func2.prototype.func13):
(Func2.prototype.func14):
(Func2.prototype.func15):
(func16.func17):
(func16.func18):
(func16.func19):
(func16):

03:45 Changeset [104399] by antti@apple.com
  • 5 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r104060): Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

If something triggers CSSStyleSelector construction very early, before documentElement is known,
it won't be able to resolve viewport-related media queries. In the included test case
the attribute on <html> element triggers the style selector creation. I can't repro
the fast/media/viewport-media-query.html failure but I suspect it is the same issue with
a different mechanism for early CSSStyleSelector construction.

  • Reset style selector on documentElement change.
  • Remove the code for lazy documentElement initialization. It is not an useful optimization, the children of Document rarely change.

Test: fast/media/viewport-media-query-synchronous.html

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::childrenChanged):

  • dom/Document.h:

(WebCore::Document::documentElement):

LayoutTests: Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

  • fast/media/viewport-media-query-synchronous-expected.txt: Added.
  • fast/media/viewport-media-query-synchronous.html: Added.
00:06 Changeset [104398] by levin@chromium.org
  • 12 edits
    3 adds in trunk

[chromium] Add layout test support for autosize code in FrameView.
https://bugs.webkit.org/show_bug.cgi?id=73631

Reviewed by Dmitry Titov.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Expose the new autoresize method.
(LayoutTestController::reset): Set the autoresize mode back to false.
(LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/autoresize/basic-expected.txt: Added.
  • fast/autoresize/basic.html: Added. Simple test to verify that autoresizing happens.
  • platform/efl/Skipped: Skipped the new directory since the layout test controller on this platform, doesn't support enableAutoResizeMode.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.

01/07/12:

19:59 Changeset [104397] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):

19:47 Changeset [104396] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to regenerate bindings on the Windows bot.

  • html/HTMLCollection.h:
19:41 Changeset [104395] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc()

Rubber-stamped by Adam Barth.

Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[]
and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice,
OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled,
it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(),
respectively. Hence, there may be a mismatch between the allocation and deallocation
routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using
operator new[].

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getProgramInfoLog):

16:45 Changeset [104394] by dslomov@google.com
  • 11 edits
    2 moves
    4 adds
    4 deletes in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104240.

  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed.
16:09 Changeset [104393] by dslomov@google.com
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed: updating expectations and rebaselining.
svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/.

  • platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
15:51 Changeset [104392] by dslomov@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed: updating expectations and rebaslining.
svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/.

  • platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:39 Changeset [104391] by philn@webkit.org
  • 6 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104386 and r104208.

  • platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/table/032-expected.txt:
  • platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
14:12 Changeset [104390] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: test expectations and filed WK75784.

  • platform/chromium/test_expectations.txt:
13:50 Changeset [104389] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed https://bugs.webkit.org/show_bug.cgi?id=75783.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

10:43 Changeset [104388] by cmarrin@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2012-01-07 Chris Marrin <cmarrin@apple.com>

Fixed a warning in GTK build of ANGLE

Unreviewed.

  • src/compiler/DetectRecursion.cpp: (DetectRecursion::~DetectRecursion):
09:46 Changeset [104387] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] Each test takes roughly half a second to load
https://bugs.webkit.org/show_bug.cgi?id=70699

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Set the XDG_CACHE_HOME environment variable when testing with
WebKitTestRunner. This way the testing is started with a non-existing
application cache. If the cache exists and is not empty, the emptying
and vacuuming that is performed before every test can consume a lot of
time.

This is just a temporary workaround until it becomes possible to set
a desired directory to be used as the application cache location through
WebKitWebContext.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

09:18 Changeset [104386] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Enable requestAnimationFrame in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=75773

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Tools:

Enable requestAnimationFrame for the Gtk port.

  • Scripts/build-webkit:

LayoutTests:

Skip the passing requestAnimationFrame-related tests and put
the remaining failing one under the tests that require modal
dialog implementation.

  • platform/gtk/Skipped:
07:22 Changeset [104385] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebCore

2012-01-07 Chris Marrin <cmarrin@apple.com>

Fixed ANGLE build for GNU and QT broken in https://trac.webkit.org/changeset/104363

Unreviewed.

  • GNUmakefile.list.am:
  • Target.pri:
02:08 Changeset [104384] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed C++ bindings build fix after r104383.

Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::impl):

  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:

(WebDOMTestEventConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:

(WebDOMTestInterface::impl):

  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:

(WebDOMTestMediaQueryListListener::impl):

  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:

(WebDOMTestNamedConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::impl):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::impl):

01:35 Changeset [104383] by kling@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

  • Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
01:14 Changeset [104382] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):

01:12 Changeset [104381] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
https://bugs.webkit.org/show_bug.cgi?id=75731

Reviewed by Andreas Kling.

Source/WebCore:

The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
DynamicSubtreeNodeList's m_node instead.

Test: fast/dom/node-list-length-after-removing-node.html

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):

LayoutTests:

Add a regression test. It reproduces the crash with a very high probability.

  • fast/dom/node-list-length-after-removing-node-expected.txt: Added.
  • fast/dom/node-list-length-after-removing-node.html: Added.
00:46 Changeset [104380] by abarth@webkit.org
  • 41 edits
    2 copies in trunk/Source/WebCore

Disconnecting DOMWindow properties is fragile and overly complicated
https://bugs.webkit.org/show_bug.cgi?id=75699

Reviewed by Alexey Proskuryakov.

Previously, we had to carefully check every object tree hanging off of
DOMWindow to make sure that every property correctly disconnected
itself and all its subobjects from the Frame when the DOMWindow
disconnected from the Frame.

This patch introduces DOMWindowProperty, which is a base class that
handles this work automagically, ensuring that we won't have any
dangling Frame pointers and removing a bunch of boilerplate code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • css/StyleMedia.cpp:

(WebCore::StyleMedia::StyleMedia):

  • css/StyleMedia.h:

(WebCore::StyleMedia::create):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::DOMApplicationCache):
(WebCore::DOMApplicationCache::disconnectFrame):

  • loader/appcache/DOMApplicationCache.h:
  • page/BarInfo.cpp:

(WebCore::BarInfo::BarInfo):

  • page/BarInfo.h:
  • page/Console.cpp:

(WebCore::Console::Console):
(WebCore::Console::memory):

  • page/Console.h:
  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):

  • page/DOMSelection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::registerProperty):
(WebCore::DOMWindow::unregisterProperty):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h:
  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):

  • page/Geolocation.h:
  • page/History.cpp:

(WebCore::History::History):

  • page/History.h:
  • page/Location.cpp:

(WebCore::Location::Location):

  • page/Location.h:
  • page/Navigator.cpp:

(WebCore::Navigator::Navigator):
(WebCore::Navigator::~Navigator):

  • page/Navigator.h:
  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::memory):

  • page/Performance.h:
  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::PerformanceNavigation):

  • page/PerformanceNavigation.h:
  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::PerformanceTiming):

  • page/PerformanceTiming.h:
  • page/Screen.cpp:

(WebCore::Screen::Screen):

  • page/Screen.h:
  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):

  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::DOMPluginArray):

  • plugins/DOMPluginArray.h:
  • storage/Storage.cpp:

(WebCore::Storage::Storage):

  • storage/Storage.h:
Note: See TracTimeline for information about the timeline view.