Timeline


and

01/15/12:

23:33 Changeset [105036] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Add DeviceOrientationEvent.absolute
https://bugs.webkit.org/show_bug.cgi?id=51742

Patch by Xinchao He <xinchao.he@intel.com> on 2012-01-15
Reviewed by Darin Fisher.

This patch add the DeviceOrientationEvent.absolute to follow the
latest w3c device orientation event spec.
http://www.w3.org/TR/orientation-event/

Source/WebCore:

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • dom/DeviceOrientation.cpp:

(WebCore::DeviceOrientation::create):
(WebCore::DeviceOrientation::DeviceOrientation):
(WebCore::DeviceOrientation::absolute):
(WebCore::DeviceOrientation::canProvideAbsolute):

  • dom/DeviceOrientation.h:
  • dom/DeviceOrientationEvent.idl:

Source/WebKit/chromium:

  • public/WebDeviceOrientation.h:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):

  • src/WebDeviceOrientation.cpp:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):
(WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):

20:03 Changeset [105035] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

The C calling convention logic in DFG::SpeculativeJIT should be available even
when not generating code for the DFG speculative path
https://bugs.webkit.org/show_bug.cgi?id=76355

Reviewed by Dan Bernstein.

Moved all of the logic for placing C call arguments into the right place (stack
or registers) into a new class, DFG::CCallHelpers. This class inherits from
AssemblyHelpers, another DFG grab-bag of helper functions. I could have moved
this code into AssemblyHelpers, but decided against it, because I wanted to
limit the number of methods each class in the JIT has. Hence now we have a
slightly odd organization of JIT classes in DFG: MacroAssembler (basic instruction
emission) <= AssemblyHelpers (some additional JS smarts) <= CCallHelpers
(understands calls to C functions) <= JITCompiler (can compile a graph to machine
code). Each of these except for JITCompiler can be reused for stub compilation.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGCCallHelpers.h: Added.

(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

16:57 Changeset [105034] by kling@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix wrong bug URL in ChangeLog.

15:18 Changeset [105033] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove external references to CSSPrimitiveValue::UnitTypes enum.
https://bugs.webkit.org/show_bug.cgi?id=76229

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::isCacheable):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isUnitTypeLength):
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isIdent):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isString):
(WebCore::CSSPrimitiveValue::isURI):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

15:08 BuildBot edited by gulendekorasyon@gmail.com
(diff)
15:07 WikiStart edited by gulendekorasyon@gmail.com
(diff)
15:06 UsingGitWithWebKit edited by gulendekorasyon@gmail.com
(diff)
15:02 WikiStart edited by gulendekorasyon@gmail.com
(diff)
12:14 Changeset [105032] by commit-queue@webkit.org
  • 11 edits in trunk

Fix compilation errors on build-webkit --debug --no-video on mac.
https://bugs.webkit.org/show_bug.cgi?id=75867

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-15
Reviewed by Philippe Normand.

Source/JavaScriptCore:

Make ENABLE_VIDEO_TRACK conditional on ENABLE_VIDEO, video track feature
doesn't build without video.

  • wtf/Platform.h:

Source/WebCore:

  • Some exported HTMLMediaElement symbols were guarded by FULLSCREEN_API feature instead of VIDEO.
  • Unused parameter warning in CanvasRenderingContext::wouldTaintOrigin().
  • RenderThemeMac::shouldShowPlaceholderWhenFocused() implementation wrongly guarded by VIDEO feature.
  • WebCore.exp.in:
  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • rendering/RenderThemeMac.mm:

Source/WebKit/mac:

  • WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded by VIDEO feature instead of FULLSCREEN_API.
  • _isAnyMoviePlaying implementation depends on VIDEO.
  • WebCoreSupport/WebChromeClient.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _isAnyMoviePlaying]):

Tools:

Add --[no-]video-track to build-webkit, since video track feature
depends on video.

  • Scripts/build-webkit:
11:42 Changeset [105031] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParser: Fix failing assertion below BorderImageQuadParseContext.
<http://webkit.org/b/76343> and <rdar://problem/10584969>

Reviewed by Antti Koivisto.

No longer asserts: fast/borders/inline-mask-overlay-image-outset-vertical-rl.html

  • css/CSSParser.cpp:

(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):

Clone CSSValues by copying the RefPtrs instead of going through
the CSSValuePool's create-from-double factory. This prevents an
assertion when the incoming value is CSSValueAuto.

11:01 WikiStart edited by robert@roberthogan.net
(diff)
09:17 Changeset [105030] by robert@webkit.org
  • 6 edits
    2 adds in trunk

<embed> width and height properties propagate to parent object node
https://bugs.webkit.org/show_bug.cgi?id=17688

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html

WebKit seems to have inherited this behaviour from KHTML. When the width/height
of an <embed> element is set, it propagates the values up to any parent <object>
element. There doesn't seem to be any good reason for this and it is not consistent
with the behaviour of Firefox and Opera.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::attributeChanged): Removed

  • html/HTMLEmbedElement.h:

(WebCore::HTMLEmbedElement::attributeChanged): Removed

LayoutTests:

  • fast/dom/insertedIntoDocument-child-expected.txt:
  • fast/dom/insertedIntoDocument-sibling-expected.txt: These tests were added by http://trac.webkit.org/changeset/81611. The fact that an <embed> element inserted into the document no longer passes its height/width up to its parent object node seems to prevent the node getting removed by a simple garbage collection now so the <embed> added by the test is still there at the end, creating the trailing spaces. This is consistent with Opera's treatment of the test, FF is entirely different - it doesn't add the embed node in the first place. So given that the purpose of the test is to cause a crash (?), the change in result seems benign.
  • fast/images/embed-does-not-propagate-dimensions-to-object-ancestor-expected.txt: Added.
  • fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html: Added. This tests that the width/height for an embed element does not get propagated to the parent object.
06:20 WikiStart edited by gulendekorasyon@gmail.com
(diff)
05:48 Changeset [105029] by robert@webkit.org
  • 5 edits in trunk/Source/WebCore

compareBorders() is called too often during painting
https://bugs.webkit.org/show_bug.cgi?id=73349

Reviewed by Julien Chaffraix.

Collapsed borders are re-calculated every time they are painted.
This is unnecessary, they only change with the layout or style so calculate and
cache them whenever the layout or style changes and use the cached values when
painting. The cache is stored in the table section so that the memory footprint
of a table is only increased when it has collapsing borders.

The gain in performance here consists of skipping collapsed border computation
during painting. The only path that incurs a small performance penalty is the
additional get/set on the cache when a collapsed border is computed. This penalty only applies
during style change, layout, or when the width of the table is calculated. The computed
border value is not stored in the cache when it has been calculated without its color
for borderHalfStart and co., so that code path is unaffected by this change.

No new tests, covered by existing collapsed border tests.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeDestroyed): remove entries from collapsed border cache
(WebCore::RenderTableCell::collapsedStartBorder):

Compute, and also cache if the full border including color was computed.

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder): ditto
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):

Inline the function since it is only called in paintCollapsedBorders and remove
includeColor as a parameter. Move the call to the table's style to the caller rather
than call it 4 times in a row. Use the cached border values directly.

(WebCore::RenderTableCell::cachedCollapsedRightBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedTopBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedBottomBorder): ditto
(WebCore::RenderTableCell::paintCollapsedBorders):

This function always uses the collapsed border cache now.

  • rendering/RenderTableCell.h: Make the collapsed border functions private.
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::removeCachedCollapsedBorders): The cache is deleted by the HashMap

since it is the only owner of the cached item.

(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

This will assert if there is no cached collapsed border for the side of the
cell requested by the caller.

  • rendering/RenderTableSection.h: HashMap wouldn't let me use CollapsedBorderSide in the key value for the cache so use int instead.

01/14/12:

19:14 Changeset [105028] by levin@chromium.org
  • 8 edits
    1 move in trunk/Source

HWndDC should be in platform/win instead of wtf.
https://bugs.webkit.org/show_bug.cgi?id=76314

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Source/WebCore:

No new functionality, so no new tests.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/HWndDC.h: Renamed from Source/JavaScriptCore/wtf/win/HWndDCWin.h.

I also made the class non-copyable.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

17:24 Changeset [105027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=76339

Take a page from the Gtk and Qt ports and quiet these logs unless they
are explicitly enabled via environment variable.

Patch by Adam Treat <atreat@rim.com> on 2012-01-14
Reviewed by George Staikos.

  • platform/blackberry/LoggingBlackBerry.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

16:31 Changeset [105026] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialStorage::CreateCurrentPersistentCredentials + 298

Reviewed by Anders Carlsson.

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::initializeSecItemShim): Removed an early return that was accidentally added in r105008.

15:53 Changeset [105025] by robert@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Chromium results for test added by r105021

Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
12:46 Changeset [105024] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Change expected failures from IMAGE+TEXT to TEXT on Mac.

The Mac bots do not check pixel results so displays results suppressed
as IMAGE+TEXT as unexpected failures. Change the suppressions to TEXT.
These results require rebaseline since the changes landed in r103251.

Unreviewed gardening.

  • platform/mac/test_expectations.txt:
12:31 Changeset [105023] by robert@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove reference result added in r105021.

This reference result only works in chromium-linux and qt it seems,
so remove it and allow ports to add port-specific png results.

Unreviewed.

  • css2.1/20110323/outline-color-applies-to-008-expected.html: Removed.
11:28 Changeset [105022] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
https://bugs.webkit.org/show_bug.cgi?id=76313

Patch by James Robinson <jamesr@chromium.org> on 2012-01-14
Reviewed by Adam Barth.

The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.

  • Scripts/run-chromium-webkit-unit-tests:
11:13 Changeset [105021] by robert@webkit.org
  • 5 edits
    30 adds in trunk

CSS 2.1 failure: outline-color-applies-to* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71944

Reviewed by Julien Chaffraix.

Source/WebCore:

Paint the outline color for row, row-group, header-group and footer-group
elements.

Tests: css2.1/20110323/outline-color-applies-to-001.htm

css2.1/20110323/outline-color-applies-to-002.htm
css2.1/20110323/outline-color-applies-to-003.htm
css2.1/20110323/outline-color-applies-to-004.htm
css2.1/20110323/outline-color-applies-to-005.htm
css2.1/20110323/outline-color-applies-to-006.htm
css2.1/20110323/outline-color-applies-to-007.htm
css2.1/20110323/outline-color-applies-to-008.htm
css2.1/20110323/outline-color-applies-to-009.htm
css2.1/20110323/outline-color-applies-to-010.htm
(There is no outline-color-applies-to-011.htm in the test suite.)
css2.1/20110323/outline-color-applies-to-012.htm
css2.1/20110323/outline-color-applies-to-013.htm
css2.1/20110323/outline-color-applies-to-014.htm
css2.1/20110323/outline-color-applies-to-015.htm
fast/css/outline-color-self-painting-row.htm

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::paintOutlineForRowIfNeeded): Wrapper function for painting the outline for the row.

This is used by RenderTableSection::paintObject and RenderTableRow::paint

(WebCore::RenderTableRow::paint): For rows with a self-painting layer, paint the outline. Tested by

fast/css/outline-color-self-painting-row.htm.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paint): Paint the outline for header-group, row-group and footer-groups.
(WebCore::RenderTableSection::paintObject): When iterating through the cells paint the outline of rows as required.
Doing it here avoids the need to walk the RenderTableSection's tree separately elsewhere.

LayoutTests:

  • css2.1/20110323/outline-color-applies-to-001-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-001.htm: Added.
  • css2.1/20110323/outline-color-applies-to-002-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-002.htm: Added.
  • css2.1/20110323/outline-color-applies-to-003-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-003.htm: Added.
  • css2.1/20110323/outline-color-applies-to-004-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-004.htm: Added.
  • css2.1/20110323/outline-color-applies-to-005-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-005.htm: Added.
  • css2.1/20110323/outline-color-applies-to-006-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-006.htm: Added.
  • css2.1/20110323/outline-color-applies-to-007-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-007.htm: Added.
  • css2.1/20110323/outline-color-applies-to-008-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-008.htm: Added.
  • css2.1/20110323/outline-color-applies-to-009-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-009.htm: Added.
  • css2.1/20110323/outline-color-applies-to-010-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-010.htm: Added.
  • css2.1/20110323/outline-color-applies-to-012-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-012.htm: Added.
  • css2.1/20110323/outline-color-applies-to-013-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-013.htm: Added.
  • css2.1/20110323/outline-color-applies-to-014-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-014.htm: Added.
  • css2.1/20110323/outline-color-applies-to-015-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-015.htm: Added.
  • fast/css/outline-color-self-painting-row-expected.html: Added.
  • fast/css/outline-color-self-painting-row.htm: Added.
11:11 Changeset [105020] by dslomov@google.com
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove WebKit::WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76327

Reviewed by Darin Fisher.

  • public/WebWorker.h: Removed.
  • src/WebWorkerClientImpl.cpp:
07:51 Changeset [105019] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

Unmatched transparency layer begin/end on a filtered element with an opacity ancestor
https://bugs.webkit.org/show_bug.cgi?id=76329

Source/WebCore:

Reviewed by Dan Bernstein.

When doing a paint with painting disabled on the GraphicsContext, as we do
for updating control tints, or computing text rectangles on Find, do not
apply filter effects. This is both a performance gain, and fixes an issue
with mismatched begin/end transparency layers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

Reviewed by Dan Bernstein.

Manual test with a filtered element as a descendant of an element with
opacity. Doing a Find is necessary to exercise the test.

  • ManualTests/filters/opacity-above-filter.html: Added.
05:43 Changeset [105018] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r105017.
http://trac.webkit.org/changeset/105017
https://bugs.webkit.org/show_bug.cgi?id=76333

broke the build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-14

  • gtk/jhbuild.modules:
05:23 Changeset [105017] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-14
Reviewed by Philippe Normand.

  • gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.

01/13/12:

20:41 Changeset [105016] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Skip test that started failing after r105015.

  • platform/qt/Skipped:
19:03 Changeset [105015] by ojan@chromium.org
  • 26 edits in trunk

Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Intentially gets computed style for flex-item-align:auto wrong.
Will fix this in a followup patch.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
18:47 Changeset [105014] by efidler@rim.com
  • 2 edits in trunk

GCC compiler version is not detected properly for QNX qcc variant
https://bugs.webkit.org/show_bug.cgi?id=76288

Reviewed by Rob Buis.

Provide an alternative way of getting the compiler version for GCC variants
that don't support -dumpversion (such as qcc).

  • Source/cmake/WebKitHelpers.cmake:
17:13 Changeset [105013] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Build correction after r104919.

  • WebCore.vcproj/WebCore.vcproj: Exclude ShadowContentSelectorQuery.cpp from the build, since it is built as part of DOMAllInOne.cpp.
16:42 Changeset [105012] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

16:28 Changeset [105011] by scheib@chromium.org
  • 5 edits in trunk

Pointer Lock: Change isLocked() from operator to attribute isLocked
https://bugs.webkit.org/show_bug.cgi?id=76311

Reviewed by Adam Barth.

Source/WebCore:

This patch implements the recent Mouse Lock Specification update
changing navigator.pointer.isLocked() to .isLocked.

Test pointer-lock/pointer-lock-api.html updated to new spec.

  • page/PointerLock.idl:

LayoutTests:

  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
16:25 Changeset [105010] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.5

New tag.

16:13 Changeset [105009] by jochen@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
https://bugs.webkit.org/show_bug.cgi?id=57600

Reviewed by Adam Barth.

  • http/tests/security/resources/cors-redirect.php: Added.
  • http/tests/security/resources/empty.html: Added.
  • http/tests/security/xhr-cors-redirect-expected.txt: Added.
  • http/tests/security/xhr-cors-redirect.html: Added.
16:08 Changeset [105008] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Delay updating the root compositing layer if the layer tree state is frozen
https://bugs.webkit.org/show_bug.cgi?id=76316

Reviewed by Dan Bernstein.

When the layer tree is frozen, stash the root layer in m_pendingRootCompositingLayer and set it in flushLayers.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

16:01 Changeset [105007] by commit-queue@webkit.org
  • 5 edits in trunk

noteOn, noteGrainOn and noteOff idl should take doubles
https://bugs.webkit.org/show_bug.cgi?id=76073

Patch by Raymond Toy <rtoy@google.com> on 2012-01-13
Reviewed by Adam Barth.

Source/WebCore:

Existing audiobuffersource-playbackrate and gain tests cover the
noteOn and noteOff changes.

  • webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and

noteOff take doubles.

LayoutTests:

  • webaudio/audiobuffersource-playbackrate-expected.wav: Updated
  • webaudio/gain-expected.wav: Updated
15:58 Changeset [105006] by bdakin@apple.com
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=71230
Clicking where the overlay scroll track would be should not scroll the page
-and corresponding-
<rdar://problem/9585424>

Reviewed by Alexey Proskuryakov.

These new functions indicate whether the scrollbar should participate in hit
testing. Non-overlay scrollbars always should, so they return true. Overlay
scrollbars consult the animator, which checks the current alpha.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::shouldScrollbarParticipateInHitTesting):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar:: shouldParticipateInHitTesting):

  • platform/Scrollbar.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac:: shouldScrollbarParticipateInHitTesting):

In these hit-testing functions, only hit-test when the scrollbar should
participate.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarAtPoint):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestOverflowControls):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isPointInOverflowControl):

15:56 Changeset [105005] by mitz@apple.com
  • 5 edits in trunk

REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
https://bugs.webkit.org/show_bug.cgi?id=76254

Reviewed by Anders Carlsson.

Source/WebCore:

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.

LayoutTests:

  • svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.

Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.

  • svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
15:52 Changeset [105004] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

WebAudio: Optimize calculateNormalizationScale().
https://bugs.webkit.org/show_bug.cgi?id=74372

Reviewed by Eric Carlson.

No new tests; optimization of existing code, so covered by existing test cases.

  • platform/audio/Reverb.cpp:

(WebCore::calculateNormalizationScale): Replace implementation with optimized vector

math operation.

(WebCore::Reverb::Reverb):

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsvesq): Vector math operation for squared sum of elements.

  • platform/audio/VectorMath.h:
15:40 Changeset [105003] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=76307

Reviewed by James Robinson.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

15:39 Changeset [105002] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r104352.

15:35 Changeset [105001] by abarth@webkit.org
  • 2 edits in trunk/Tools

Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

This is the rest of the patch from Bug 76300. I landed it separtely
because main.py had some stray conflict markers that I needed to clean
up first.

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester._run_tests):

15:32 Changeset [105000] by japhet@chromium.org
  • 4 edits in trunk

Source/WebCore: Revert most of the multipart changes in
http://trac.webkit.org/changeset/104756.
https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

http/tests/multipart/invalid-image-data.html
should stop asserting on chromium win dbg.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

LayoutTests: http/tests/multipart/invalid-image-data.html should no longer
be crashing on chromium win dbg.
https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

  • platform/chromium/test_expectations.txt:
15:31 Changeset [104999] by abarth@webkit.org
  • 2 edits in trunk/Tools

test-webkitpy does not run
https://bugs.webkit.org/show_bug.cgi?id=76318

Unreviewed.

Looks like some conflict markers got left in the file.

  • Scripts/webkitpy/test/main.py:

(Tester.run):

15:28 Changeset [104998] by abarth@webkit.org
  • 7 edits in trunk/Tools

Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

We don't use this functionality for anything, and it doesn't really
work. Someone in #webkit tried using it and and got sad/confused. We
should just remove it.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.push_local_commits_to_server):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.init):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(_shared_test_commit_with_message):
(GitSVNTest.test_commit_text_parsing):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.commit_with_message):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.init):
(Bugzilla.quips):
(Bugzilla.authenticate):
(Bugzilla.add_attachment_to_bug):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
(Bugzilla.clear_attachment_flags):
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
(Bugzilla.add_cc_to_bug):
(Bugzilla.post_comment_to_bug):
(Bugzilla.close_bug_as_fixed):
(Bugzilla.reassign_bug):
(reopen_bug):

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run_tests):

15:16 Changeset [104997] by lforschler@apple.com
  • 14 edits in branches/safari-534.54-branch

Merged r104269.

15:13 Changeset [104996] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r104239.

14:58 Changeset [104995] by levin@chromium.org
  • 5 edits in trunk

check-webkit-style: should encourage the use of Own* classes for Windows DC.
https://bugs.webkit.org/show_bug.cgi?id=76227

Reviewed by Dirk Pranke.

Source/JavaScriptCore:

  • wtf/win/HWndDCWin.h:

(WTF::HwndDC::HwndDC): Add a way to do GetDCEx.
There are no users, but I want to catch this in check-webkit-style
and tell any users to use HwndDC to avoid leaks.

Tools:

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_leaky_patterns): The new check.
(process_line): Added a call to the new check.
(CppChecker): Added the new error type.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTestBase):
(CppStyleTestBase.perform_leaky_pattern_check):
The check for only leaky pattern errors.
(LeakyPatternTest): Test cases.

14:52 Changeset [104994] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

14:42 Changeset [104993] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

WebAudio: Use float instead of double values for gain operations.
https://bugs.webkit.org/show_bug.cgi?id=74345

Reviewed by Sam Weinig.

No new tests; optimization of existing code, so covered by existing test cases.

The following functions now take or operate on floats instead of doubles:
(WebCore::AudioBus::scale):
(WebCore::AudioBus::processWithGainFrom):
(WebCore::AudioBus::copyWithGainFrom):
(WebCore::AudioBus::sumWithGainFrom):

  • platform/audio/AudioBus.h:

(WebCore::AudioBus::setGain):
(WebCore::AudioBus::gain):

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::scale):

  • platform/audio/AudioChannel.h:
  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

  • webaudio/AudioBufferSourceNode.h:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.h:
14:42 Changeset [104992] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104119.

14:38 Changeset [104991] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't use pending activity notification in IntentRequest
https://bugs.webkit.org/show_bug.cgi?id=76302

Patch by Greg Billock <gbillock@google.com> on 2012-01-13
Reviewed by Adam Barth.

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

14:34 Changeset [104990] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104094.

14:29 Changeset [104989] by lforschler@apple.com
  • 6 edits
    3 copies in branches/safari-534.54-branch

Merged r104086.

14:20 Changeset [104988] by lforschler@apple.com
  • 3 edits
    12 copies in branches/safari-534.54-branch

Merged r103981.

14:18 Changeset [104987] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

EQUALPOWER panner incorrectly computes gain
https://bugs.webkit.org/show_bug.cgi?id=75767

Source/WebCore:

Patch by Raymond Toy <rtoy@google.com> on 2012-01-13
Reviewed by Kenneth Russell.

Layout test added.

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan): Correct the formula.

LayoutTests:

Patch by Raymond Toy <rtoy@chromium.org> on 2012-01-13
Reviewed by Kenneth Russell.

  • webaudio/panner-equalpower.html: Added.
  • webaudio/panner-equalpower-expected.txt: Added.
  • webaudio/resources/panner-model-testing.js: Added.
  • webaudio/resources/audio-testing.js:

(createImpulseBuffer): New common utility function.

14:15 Changeset [104986] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Implement TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=76308

Reviewed by Sam Weinig.

Keep track of whether the layer tree state is frozen and suspend/resume the layer flush scheduler accordingly.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::layerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

14:00 Changeset [104985] by ojan@chromium.org
  • 26 edits in trunk

Unreviewed, rolling out r104972.
http://trac.webkit.org/changeset/104972
https://bugs.webkit.org/show_bug.cgi?id=75782

Broke some tests

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:39 Changeset [104984] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Rollout 99999 (104249).

13:38 Changeset [104983] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable implicit animations when setting the root compositing layer
https://bugs.webkit.org/show_bug.cgi?id=76304

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

13:31 Changeset [104982] by dpranke@chromium.org
  • 1 edit in trunk/Tools/ChangeLog

fix changelog

13:24 Changeset [104981] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source

Unreviewed build fix for Qt SnowLeopard build bot.

This is a workaround for the moment.

  • wtf/Platform.h:
13:23 Changeset [104980] by dpranke@chromium.org
  • 4 edits in trunk/Tools

test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

% test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

% test-wekbitpy webkitpy.test.cat_unittest

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/cat_unittest.py:
  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

13:23 Changeset [104979] by eae@chromium.org
  • 9 edits in branches/subpixellayout/Source/WebCore

Windows build fixes for WebCore.

13:20 Changeset [104978] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

-[WebTileCacheLayer setNeedsDisplay] doesn't trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=76299

Reviewed by Simon Fraser.

Override -[WebTileCacheLayer setNeedsDisplay] and call TileCache::setNeedsDisplay from there,
instead of ending up with a huge rectangle in TileCache::setNeedsDisplayInRect which causes our
tile computation logic to fail due to integer overflow when converting from CGFloats to ints.

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplay):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setNeedsDisplay]):

13:16 Changeset [104977] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

% test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

% test-wekbitpy webkitpy.test.cat_unittest

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/cat_unittest.py:
  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

13:16 Changeset [104976] by levin@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Header file is missing header guard.

Reviewed by Dirk Pranke.

  • wtf/win/HWndDCWin.h: Added the guards.
12:59 Changeset [104975] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test-webkitpy: add basic code coverage support
https://bugs.webkit.org/show_bug.cgi?id=76201

Reviewed by Adam Barth.

This test adds basic code coverage support to test-webkitpy; if
you pass the -c flag, we will generate a new coverage file. We
can start simply with this and add more features as necessary.

This patch requires coverage to be already installed on the
machine. I am not auto-installing this for now.

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run_tests):

12:54 Changeset [104974] by dpranke@chromium.org
  • 2 edits in trunk/Tools

StatusBubbleTest.test_build_bubble is failing
https://bugs.webkit.org/show_bug.cgi?id=76222

Reviewed by Adam Barth.

  • QueueStatusServer/handlers/statusbubble_unittest.py:

(StatusBubbleTest.test_build_bubble):

12:53 Changeset [104973] by simon.fraser@apple.com
  • 1 edit
    21 adds in trunk/LayoutTests

Add new baselines for various compositing tests which didn't have Mac results.

  • platform/mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/mac/compositing/animation/busy-indicator-expected.txt: Added.
  • platform/mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/mac/compositing/flat-with-transformed-child-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/mac/compositing/repaint/same-size-invalidation-expected.txt: Added.
  • platform/mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/mac/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
12:43 Changeset [104972] by ojan@chromium.org
  • 26 edits in trunk

Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Not 100% sure about this, but I think the computed value of
flex-item-align needs to take the parent's flex-align into
account for computed auto values.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::flexAlign):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:34 Changeset [104971] by jamesr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Update chromium image baselines for cross-fade-invalidation

  • platform/chromium-linux/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-invalidation-expected.png: Added.
12:31 Changeset [104970] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Eval in strict mode does not need dynamic checks
https://bugs.webkit.org/show_bug.cgi?id=76286

Patch by Andy Wingo <wingo@igalia.com> on 2012-01-13
Reviewed by Oliver Hunt.

  • runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):

Eval in strict mode cannot introduce variables, so it not impose
the need for dynamic checks.

12:13 Changeset [104969] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Fix an obviously incorrect expected result image.

Patch by Simon Fraser <simon.fraser@apple.com> on 2012-01-13

  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
11:59 Changeset [104968] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Fix an obviously incorrect expected result image.

  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
11:55 Changeset [104967] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/Tools

nrwt should use multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=75958

Add --max-locked-shards option to the nrwt for manual set
the maximum number of the locked shards

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._max_locked_shards):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ShardingTests.get_shards):
(ShardingTests.test_multiple_locked_shards):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

11:45 Changeset [104966] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Rename GraphicsContext* argument in various RenderLayer methods
https://bugs.webkit.org/show_bug.cgi?id=76283

Reviewed by James Robinson/Anders Carlsson.

Rename the GraphicsContext* parameter "p" in various RenderLayer
methods to "context". "p" was a historical name from when it was
called Painter.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):

11:42 Changeset [104965] by mihnea@adobe.com
  • 14 edits in trunk/Source/WebCore

[CSSRegions]Add back region style code removed in r104036
https://bugs.webkit.org/show_bug.cgi?id=76064

Reviewed by David Hyatt.

No new tests. The region style tests are still skipped. A follow up patch will enable
both region style for background-color and region style tests.

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::useInRegionStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::initRegionRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleInRegion):

  • rendering/RenderObject.h:

(WebCore::RenderObject::canHaveRegionStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):

11:42 Changeset [104964] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r103728.

11:41 Changeset [104963] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; added project.pbxproj changes lost in r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906

  • WebCore.xcodeproj/project.pbxproj:
11:40 Changeset [104962] by lforschler@apple.com
  • 7 edits
    6 copies in branches/safari-534.54-branch

Merge 103637.

11:26 Changeset [104961] by jocelyn.turcotte@nokia.com
  • 8 edits
    2 adds in trunk/Source

TextureMapper: Extract layer transform logic to a LayerTransform class.
https://bugs.webkit.org/show_bug.cgi?id=76291

Reviewed by Noam Rosenthal.

Source/WebCore:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/LayerTransform.cpp: Added.

(WebCore::LayerTransform::LayerTransform):
(WebCore::LayerTransform::setPosition):
(WebCore::LayerTransform::setSize):
(WebCore::LayerTransform::setAnchorPoint):
(WebCore::LayerTransform::setFlattening):
(WebCore::LayerTransform::setLocalTransform):
(WebCore::LayerTransform::setChildrenTransform):
(WebCore::LayerTransform::combined):
(WebCore::LayerTransform::combinedForChildren):
(WebCore::LayerTransform::combineTransforms):
(WebCore::LayerTransform::combineTransformsForChildren):

  • platform/graphics/texmap/LayerTransform.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::collectVisibleContentsRects):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::compareGraphicsLayersZValue):
(WebCore::TextureMapperNode::paintSelfAndChildren):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::syncCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::TextureMapperNode):

Source/WebKit2:

Move the paint call before the visible rect collection to make sure that
transforms are computed. This will increase the delay for the visible rects
to get to the WebProcess until we move this calculation out of the UI Process.
This fixes an assert triggering in LayerTransform::combineTransforms.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):

11:24 Changeset [104960] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit/efl

[EFL] SecurityPolicy whitelist interface should be exposed to EWebKit
https://bugs.webkit.org/show_bug.cgi?id=76082

Patch by Leandro Pereira <leandro@profusion.mobi> on 2012-01-13
Reviewed by Andreas Kling.

  • CMakeListsEfl.txt: Added reference to ewk_security_policy.{cpp,h}.
  • ewk/EWebKit.h: Include ewk_security_policy.h.
  • ewk/ewk_security_policy.cpp: Added.

(ewk_security_policy_whitelist_origin_add): Implemented thin layer around SecurityPolicy::addOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_del): Implemented thin layer around SecurityPolicy::removeOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_reset): Implemented thin layer around SecurityPolicy::resetOriginAccessWhitelists().

  • ewk/ewk_security_policy.h: Added.
11:19 Changeset [104959] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix for unused argument warning after r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906

Also fixed up somebody's bad merge in Source/WebCore/ChangeLog.

  • html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::WebGLObject):

11:19 Changeset [104958] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Build correction.

  • Shared/WebGraphicsContext.h: Use proper include path for RefPtrCairo.h.
11:15 Changeset [104957] by jamesr@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Update expectations

  • platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:06 Changeset [104956] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update a few expectations

  • platform/chromium/test_expectations.txt:
11:05 Changeset [104955] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

prepare-ChangeLog: Look for a text editor in a few more variables.
https://bugs.webkit.org/show_bug.cgi?id=76289

Reviewed by Ryosuke Niwa.

A text editor was looked for only in the CHANGE_LOG_EDITOR and
CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
to the OS X-specific open(1) command.

As there does not seem to be a common way of looking for a text editor
among the scripts in Tools/Scripts right now, just look at $VISUAL and
$EDITOR (set much more often than the other variables in Unix systems)
before falling back to open(1).

  • Scripts/prepare-ChangeLog:

(openChangeLogs):

11:02 Changeset [104954] by commit-queue@webkit.org
  • 24 edits
    5 copies
    1 add in trunk

Add WebGLContextGroup as step toward sharing WebGL resources
https://bugs.webkit.org/show_bug.cgi?id=75906

The WebGL Working Group will soon add the ability to share
WebGL resources among WebGL contexts. This is the necessary
prep work. NO API changes.

Added WebGLSharedObject for objects that are shared vs
WebGLContextObject for objects that are not.

Patch by Gregg Tavares <gman@google.com> on 2012-01-13
Reviewed by Kenneth Russell.

No new tests. No change in behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::WebGLBuffer):
(WebCore::WebGLBuffer::~WebGLBuffer):
(WebCore::WebGLBuffer::deleteObjectImpl):

  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLContextGroup.cpp: Added.

(WebCore::WebGLContextGroup::create):
(WebCore::WebGLContextGroup::WebGLContextGroup):
(WebCore::WebGLContextGroup::~WebGLContextGroup):
(WebCore::WebGLContextGroup::getAGraphicsContext3D):
(WebCore::WebGLContextGroup::addContext):
(WebCore::WebGLContextGroup::removeContext):
(WebCore::WebGLContextGroup::removeObject):
(WebCore::WebGLContextGroup::addObject):
(WebCore::WebGLContextGroup::detachAndRemoveAllObjects):
(WebCore::WebGLContextGroup::loseContextGroup):

  • html/canvas/WebGLContextGroup.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.
  • html/canvas/WebGLContextObject.cpp: Copied from Source/WebCore/html/canvas/WebGLShader.cpp.

(WebCore::WebGLContextObject::WebGLContextObject):
(WebCore::WebGLContextObject::~WebGLContextObject):
(WebCore::WebGLContextObject::detachContext):
(WebCore::WebGLContextObject::getAGraphicsContext3D):

  • html/canvas/WebGLContextObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.

(WebCore::WebGLContextObject::context):
(WebCore::WebGLContextObject::validate):
(WebCore::WebGLContextObject::hasGroupOrContext):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::WebGLFramebuffer):
(WebCore::WebGLFramebuffer::~WebGLFramebuffer):
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):

  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::WebGLObject):
(WebCore::WebGLObject::~WebGLObject):
(WebCore::WebGLObject::deleteObject):
(WebCore::WebGLObject::detach):
(WebCore::WebGLObject::onDetached):

  • html/canvas/WebGLObject.h:
  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::~WebGLProgram):
(WebCore::WebGLProgram::deleteObjectImpl):
(WebCore::WebGLProgram::cacheActiveAttribLocations):

  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLRenderbuffer.cpp:

(WebCore::WebGLRenderbuffer::~WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::deleteObjectImpl):

  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::checkObjectToBeBound):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createBuffer):
(WebCore::WebGLRenderingContext::createFramebuffer):
(WebCore::WebGLRenderingContext::createTexture):
(WebCore::WebGLRenderingContext::createProgram):
(WebCore::WebGLRenderingContext::createRenderbuffer):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteObject):
(WebCore::WebGLRenderingContext::deleteRenderbuffer):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateWebGLObject):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::removeSharedObject):
(WebCore::WebGLRenderingContext::addSharedObject):
(WebCore::WebGLRenderingContext::removeContextObject):
(WebCore::WebGLRenderingContext::addContextObject):
(WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
(WebCore::WebGLRenderingContext::initVertexAttrib0):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::loseContextImpl):

  • html/canvas/WebGLRenderingContext.h:

(WebCore::WebGLRenderingContext::contextGroup):

  • html/canvas/WebGLShader.cpp:

(WebCore::WebGLShader::WebGLShader):
(WebCore::WebGLShader::~WebGLShader):
(WebCore::WebGLShader::deleteObjectImpl):

  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLSharedObject.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderbuffer.cpp.

(WebCore::WebGLSharedObject::WebGLSharedObject):
(WebCore::WebGLSharedObject::~WebGLSharedObject):
(WebCore::WebGLSharedObject::detachContextGroup):
(WebCore::WebGLSharedObject::getAGraphicsContext3D):

  • html/canvas/WebGLSharedObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.

(WebCore::WebGLSharedObject::contextGroup):
(WebCore::WebGLSharedObject::isBuffer):
(WebCore::WebGLSharedObject::isFramebuffer):
(WebCore::WebGLSharedObject::isProgram):
(WebCore::WebGLSharedObject::isRenderbuffer):
(WebCore::WebGLSharedObject::isShader):
(WebCore::WebGLSharedObject::isTexture):
(WebCore::WebGLSharedObject::validate):
(WebCore::WebGLSharedObject::hasGroupOrContext):

  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::~WebGLTexture):
(WebCore::WebGLTexture::deleteObjectImpl):

  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):

  • html/canvas/WebGLVertexArrayObjectOES.h:
10:43 Changeset [104953] by lforschler@apple.com
  • 5 edits
    6 copies in branches/safari-534.54-branch

Merged r103636.

10:40 Changeset [104952] by lforschler@apple.com
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r103594.

10:37 Changeset [104951] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r103587.

10:35 Changeset [104950] by lforschler@apple.com
  • 6 edits
    3 copies in branches/safari-534.54-branch

Merged r103482.

10:26 Changeset [104949] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r103286.

10:05 Changeset [104948] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebCore

[soup] Initialize m_soupFlags in all ResourceResponse constructors.

Rubber-stamped by Gustavo Noronha Silva.

m_soupFlags was being initialized in two of the three ResourceResponse
constructors, causing some trouble in
FrameLoaderClient::dispatchDidReceiveResponse (ports which use
ResourceRequest::setSoupMessageFlags with the response's unitialized
flags).

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

09:58 Changeset [104947] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

CFURLRef to KURL conversion shouldn't turn raw paths into file URLs
https://bugs.webkit.org/show_bug.cgi?id=76251

Reviewed by Dan Bernstein.

  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Removed the offending code.
09:51 Changeset [104946] by levin@chromium.org
  • 5 edits
    1 move in trunk/Source

HWndDC is a better name than HwndDC.
https://bugs.webkit.org/show_bug.cgi?id=76281

Reviewed by Darin Adler.

Source/JavaScriptCore:

(WTF::HWndDC::HWndDC):
(WTF::HWndDC::~HWndDC):
(WTF::HWndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

09:43 Changeset [104945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Disconnecting the front-end does not disable profiling.
https://bugs.webkit.org/show_bug.cgi?id=76213

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-13
Reviewed by Pavel Feldman.

Not testable.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::clearFrontend):

09:41 Changeset [104944] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark a flaky test as flaky

  • platform/chromium/test_expectations.txt:
09:41 Changeset [104943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix missing signal in qwebframe API test for Qt5
https://bugs.webkit.org/show_bug.cgi?id=76195

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-01-13
Reviewed by Noam Rosenthal.

In Qt5 QObject has a new signal with this signature: "objectNameChanged(QString)".

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::enumerate_data):

09:04 Changeset [104942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
https://bugs.webkit.org/show_bug.cgi?id=76269

Reviewed by Martin Robinson.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

08:35 Changeset [104941] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
<http://webkit.org/b/76271>

Reviewed by Darin Adler.

Use JSC::Weak::swap() to move JSDOMWrappers into the DOMWrapperWorld's wrapper map.
This avoids invoking the JSC::Weak copy constructor and associated HandleHeap churn.

  • bindings/js/JSDOMBinding.h:

(WebCore::cacheWrapper):

08:28 Changeset [104940] by vsevik@chromium.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Added.

(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h: Added.

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Added.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
08:20 Changeset [104939] by kling@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Test that cloneNode() doesn't cause crashes when used directly after stylesheet mutation.
<http://webkit.org/b/75987>

Reviewed by Antti Koivisto.

  • fast/css/cloneNode-after-deleteRule-crash-expected.txt: Added.
  • fast/css/cloneNode-after-deleteRule-crash.html: Added.
  • fast/css/resources/cloneNode-after-deleteRule-subdocument.html: Added.
08:03 Changeset [104938] by vsevik@chromium.org
  • 12 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104935.
http://trac.webkit.org/changeset/104935
https://bugs.webkit.org/show_bug.cgi?id=76277

Breaks AppleWin compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-13

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Removed.
  • inspector/InspectorIndexedDBAgent.h: Removed.
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Removed.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
07:49 Changeset [104937] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove extern "C" from ewk_private.h
https://bugs.webkit.org/show_bug.cgi?id=76250

Reviewed by Andreas Kling.

ewk_private.h defines internal functions used by WebKit itself. There is no chance to be used by C application.
So, extern "C" keyword is unneeded in ewk_private.h.

  • ewk/ewk_private.h:
07:44 Changeset [104936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[EFL] Add OwnPtr specialization for Eina_Module.
https://bugs.webkit.org/show_bug.cgi?id=76255

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.

Add an overload for deleteOwnedPtr(Eina_Module*) on EFL port.

  • wtf/OwnPtrCommon.h:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):

07:08 Changeset [104935] by vsevik@chromium.org
  • 12 edits
    3 adds in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Added.

(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h: Added.

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Added.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
07:04 Changeset [104934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build when using TextureMapper with OpenGL/ES
https://bugs.webkit.org/show_bug.cgi?id=76268

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-13
Reviewed by Tor Arne Vestbø.

  • WebCore.pri: When the texture mapper uses OpenGL/ES, then it also relies on the

availability of libEGL by using eglGetCurrentContext(). In that case we need to link against
libEGL.

06:58 Changeset [104933] by jochen@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Don't artifically keep IDBDatabase objects alive if there are no references to it.
https://bugs.webkit.org/show_bug.cgi?id=75859

Originally, this code was added to keep the IDBDatabase object alive
even if no reference from JavaScript to the object existed, because
running transactions could still send events for this database
connection. Meanwhile, transactions are marked as active DOM objects
during their lifetime, and they keep a RefPtr to the IDBDatabase
object, so this hack is no longer required.

Reviewed by Tony Gentilcore.

Test: storage/indexeddb/delete-closed-database-object.html

  • storage/IDBDatabase.cpp:
  • storage/IDBDatabase.h:

LayoutTests: Test that an IDBDatabase object is garbage collected once no further references to it exist.
https://bugs.webkit.org/show_bug.cgi?id=75859

Reviewed by Tony Gentilcore.

  • storage/indexeddb/delete-closed-database-object-expected.txt: Added.
  • storage/indexeddb/delete-closed-database-object.html: Added.
06:41 Changeset [104932] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebCore

TextureMapper: Do the node transform computation when painting.
https://bugs.webkit.org/show_bug.cgi?id=74721

Reviewed by Noam Rosenthal.

The transform of the node tree was built during the syncCompositingState
step. This would cause an ASSERT with QWebView, trying to use a dirty transform
state since the rootTextureMapperNode in QWebFramePrivate::renderCompositedLayers
doesn't run the sync step after getting the world transform set.

This moves the transform computation from the sync to the paint step to
prevent making sure that the sync step has been run on all nodes before painting.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::computeTiles):
Remove an unused variable.
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:
06:39 Changeset [104931] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebCore

TextureMapper: Simplify transform manipulations.
https://bugs.webkit.org/show_bug.cgi?id=74719

Reviewed by Noam Rosenthal.

  • Make sure that the replica node has a complete transform and use it directly instead of keeping a copy in the source.
  • Apply the origin and position translation only once, on the target and descendants transforms.
  • Use to2dTransform() on !preserves3D layers instead of doing the flattening manually.
  • Remove mentions of perspective as this is handled by WebCore through the children transform.
  • Apply the inverse target transform on the replica only where it is needed in paintReflection since it uses the full transform in paintSelf.
  • Merge the base and local transforms.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsSelf):
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::paintReflection):

  • platform/graphics/texmap/TextureMapperNode.h:
06:38 Changeset [104930] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

TextureMapper: Fix the fillsForward transform adjustment in syncAnimations.
https://bugs.webkit.org/show_bug.cgi?id=76184

Reviewed by Noam Rosenthal.

Also make the intention clearer by using setTransform and setOpacity.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimations):

06:32 Changeset [104929] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update expectation for svg/dom/SVGPathSegList-segment-modification.svg on LEOPARD DEBUG.

  • platform/chromium/test_expectations.txt:
06:25 Changeset [104928] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector scripts navigator style fixes.

  • inspector/front-end/scriptsPanel.css:

(#scripts-editor-container-tabbed-pane .tabbed-pane-header-tab):

06:20 Changeset [104927] by jochen@chromium.org
  • 9 edits
    5 adds in trunk

Source/WebCore: Once we prepared a script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
https://bugs.webkit.org/show_bug.cgi?id=76083

Reviewed by Adam Barth.

This bug was caught by the following IE Test Center test:

http://samples.msdn.microsoft.com/ietestcenter/HTML5/show_async_test.htm?11_RemovingAsyncScript

Test: http/tests/misc/async-script-removed.html

http/tests/misc/async-script.html

  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

  • html/HTMLScriptElement.cpp:
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:

LayoutTests: Once we've prepared script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
https://bugs.webkit.org/show_bug.cgi?id=76083

Reviewed by Adam Barth.

  • http/tests/misc/async-script-expected.txt: Added.
  • http/tests/misc/async-script-removed-expected.txt: Added.
  • http/tests/misc/async-script-removed.html: Added.
  • http/tests/misc/async-script.html: Added.
  • http/tests/misc/resources/delayed-log.php: Added.
06:18 Changeset [104926] by zimmermann@webkit.org
  • 4 edits in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Antti Koivisto.

Finish SVGTextMetricsBuilder introduction, tested in my local svg-text-performance branch.
SVGTextMetricsBuilder has two public methods:
a) SVGTextMetricsBuilder::measureTextRenderer(RenderSVGInlineText*)

It will be used exclusively for non-initial, incremental layout changes. Once the inital
text layout ran, any mutation of eg. a child text node of a <tspan>, will only trigger
a rebuild of the layout attributes associated with the passed in renderer.

b) SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes(RenderSVGText*, RenderSVGInlineText* stopAtLeaf, SVGCharacterDataMap& allCharactersMap)

stopAtLeaf=0:
This carries out the initial layout phase. It measures all characters of the whole <text> subtree, and stores the SVGTextMetrics for each character
in the SVGTextLayoutAttributes, stored in the RenderSVGInlineText object. It requires a SVGCharacterDataMap allCharactersMap as input argument,
which contains a HashMap<unsigned, {float x, y, dx, dy, rotate}>, which maps each character position to a set of x/y/dx/dy/rotate values.
The SVGCharacterDataMap living in SVGTextLayoutAttributes will be filled, from the global "allCharactersMap", so that each RenderSVGInlineText only
stores the positioning information for its children, if any.

Note: SVGTextMetricsBuilder is not yet deployed, so this talks about the design, once everything is landed.

stopAtLeaf!=0:
This is never used for the initial layout phase. If the initial layout is done, and eg. a <tspan> is added to the <text> subtree, we no longer
need to rebuild the metrics map & layout attributes for the whole tree, but only for the desired <tspan>, and its previous/next sibling, if present
(which may be affected by the inclusion of another node inbetween them).

SVGTextMetricsBuilder is now finished, and will be used in the next patch chunk.
Doesn't affect any tests yet.

  • rendering/svg/SVGTextLayoutAttributes.h:

(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::SVGCharacterData::SVGCharacterData):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::MeasureTextData::MeasureTextData):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):

  • rendering/svg/SVGTextMetricsBuilder.h:
06:10 Changeset [104925] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: Fixing Win builders.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):

06:01 Changeset [104924] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[EFL] Add 'Copy Image Address' to context menu.
https://bugs.webkit.org/show_bug.cgi?id=76153

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.

Source/WebCore:

Enables 'Copy Image Address' option to context menu in WebKit-EFL as it is enabled in GTK and QT ports.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCopyImageUrlToClipboard):

Source/WebKit/efl:

Adds EWK_CONTEXT_MENU_ITEM_TAG_COPY_IMAGE_URL_TO_CLIPBOARD to Ewk_Context_Menu_Action to synchronize it with ContextMenuItem.h

  • ewk/ewk_contextmenu.h:
05:48 Changeset [104923] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: 32bit build fix.

  • inspector/DOMEditor.cpp:
  • inspector/DOMEditor.h:
05:41 Changeset [104922] by mario@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rollout r104905.
https://bugs.webkit.org/show_bug.cgi?id=76267

This patch broke tests in the GTK 64bit Debug bot.

Source/WebCore:

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

Source/WebKit/gtk:

  • tests/testatk.c:

(textCaretMovedCallback):
(testWebkitAtkCaretOffsets):
(textSelectionChangedCallback):
(testWebkitAtkTextSelections):

05:29 Changeset [104921] by apavlov@chromium.org
  • 1 edit
    4 moves
    7 adds
    4 deletes in trunk/LayoutTests

Unreviewed, rebaseline Chromium and optimize Qt/GTK baselines after r104917 using garden-o-matic.

  • platform/chromium-mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
  • svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt.
05:24 Changeset [104920] by pfeldman@chromium.org
  • 7 edits
    3 adds in trunk

Web Inspector: make HTML editing preserve node identity when node nesting level changes.
https://bugs.webkit.org/show_bug.cgi?id=76183

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html-2.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchHTMLElement):
(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::createDigest):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::markNodeAsUsed):
(WebCore::DOMEditor::dumpMap):

  • inspector/DOMEditor.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt: Added.
  • inspector/elements/set-outer-html-2.html: Added.
  • inspector/elements/set-outer-html-expected.txt:
  • inspector/elements/set-outer-html-test.js: Added.

(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step1):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step2):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step3):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite):
(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest):

  • inspector/elements/set-outer-html.html:
05:04 Changeset [104919] by commit-queue@webkit.org
  • 17 edits
    1 copy
    3 adds in trunk

ShadowContentElement should be able to use query.
https://bugs.webkit.org/show_bug.cgi?id=75302

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-13
Reviewed by Hajime Morita.

Source/WebCore:

This patch introduces a selector to query elements in ShadowContentElement.
This can be used instead of ShadowContentElement::shouldInclude in more sophisticated ways.

Tests: fast/dom/shadow/shadow-contents-select-expected.html

fast/dom/shadow/shadow-contents-select.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::SelectorDataList):

Extracted from SelectorQueryto share codes with ShadowContentSelectorQuery.

(WebCore::SelectorDataList::initialize):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::queryAll):
(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::canUseIdLookup):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::size):

  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::select):
(WebCore::ShadowContentElement::setSelect):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Added.

(WebCore::ShadowContentSelectorQuery::ShadowContentSelectorQuery):
(WebCore::ShadowContentSelectorQuery::matches):

Returns true if Node is matched by the query.

  • dom/ShadowContentSelectorQuery.h: Copied from Source/WebCore/dom/ShadowContentElement.h.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):
(WebCore::DetailsContentElement::DetailsContentElement): Re-implemented using query.
(WebCore::DetailsSummaryElement::DetailsSummaryElement): ditto.

LayoutTests:

Tests for ShadowContentElement query.

  • fast/dom/shadow/shadow-contents-select-expected.html: Added.
  • fast/dom/shadow/shadow-contents-select.html: Added.
04:39 Changeset [104918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-13

  • DEPS:
03:54 Changeset [104917] by reni@webkit.org
  • 74 edits in trunk/LayoutTests

Update Snow-Leopard SVG pixel test baseline after r104881.
Unreviewed gardening.

  • platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png:
  • platform/mac-snowleopard/svg/custom/altglyph-expected.png:
  • platform/mac-snowleopard/svg/custom/external-paintserver-reference-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac-snowleopard/svg/custom/junk-data-expected.png:
  • platform/mac-snowleopard/svg/custom/linking-base-external-reference-expected.png:
  • platform/mac-snowleopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac-snowleopard/svg/custom/path-bad-data-expected.png:
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/css-transforms-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac-snowleopard/svg/hixie/error/012-expected.png:
  • platform/mac-snowleopard/svg/in-html/circle-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac-snowleopard/svg/text/kerning-expected.png:
  • platform/mac-snowleopard/svg/text/multichar-glyph-expected.png:
  • platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
03:36 Changeset [104916] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=76252

_calculateFlags speed is about 10k edges per second.
It requires 150sec for the snapshot with 1.5m edges.
The root of problem is var node = list.shift();
shift() is not effective in term of memory and cpu.
In our case it can be replaced with pop().
Now the function works 40 times faster.

Drive by change: if statement was reformatted a bit for better readability.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateFlags):

03:25 Changeset [104915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add visible field into ewk_tiled_backing_store's data.
https://bugs.webkit.org/show_bug.cgi?id=76165

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Nikolas Zimmermann.

Using of evas_object_visible_get() API can't gurantee the correctness of
evas_object's visible status if it's called inside of evas_object's
smart_show() method.
So, a visible flag for the ewk_tiled_backing_store is added.
In addition, as tiles are not visible, ewk_tiled_backing_store will push
its own tiles into the cache when it disapear.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):

03:02 Changeset [104914] by haraken@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104907.

  • platform/chromium-mac-leopard/fast/repaint/focus-layers-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/focus-layers-expected.png: Added.
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png: Removed.
  • platform/chromium-win/fast/repaint/focus-layers-expected.png:
02:52 Changeset [104913] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] JavaScriptOutlineDialog fails to open
https://bugs.webkit.org/show_bug.cgi?id=76259

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
02:07 Changeset [104912] by vsevik@chromium.org
  • 24 edits in trunk/LayoutTests

Unreviewed tests rebaseline after r104803.

  • fast/profiler/throw-exception-from-eval-expected.txt:
  • platform/chromium-mac/http/tests/history/cross-origin-replace-history-object-child-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/xss-DENIED-javascript-execution-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-history-properties-expected.txt:
  • platform/chromium/http/tests/security/xss-eval-expected.txt:
  • platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt:
  • platform/mac-wk2/plugins/mouse-events-scaled-expected.txt:
  • platform/mac/fast/AppleScript/001-expected.txt:
  • platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/mac/plugins/plugin-initiate-popup-window-expected.txt:
  • platform/qt-wk2/plugins/document-open-expected.txt:
  • platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
  • platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt:
  • platform/win/plugins/get-value-netscape-window-expected.txt:
  • platform/win/plugins/iframe-inside-overflow-expected.txt:
  • platform/win/plugins/keyboard-events-expected.txt:
  • platform/win/plugins/mouse-events-expected.txt:
  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
  • platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt:
  • platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
02:05 Changeset [104911] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed garedening. Skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
01:41 Changeset [104910] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
https://bugs.webkit.org/show_bug.cgi?id=76247

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)

01:31 Changeset [104909] by zimmermann@webkit.org
  • 77 edits in trunk/LayoutTests

2012-01-13 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Lion SVG pixel test baseline after r104881.
Also update SVGFETurbulenceElement-*-stitchTiles-*, filter-child-repaint.svg results, which pass again.

  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/custom/altglyph-expected.png:
  • platform/mac/svg/custom/external-paintserver-reference-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/linking-base-external-reference-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac/svg/custom/use-font-face-crash-expected.png:
  • platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac/svg/dom/css-transforms-expected.png:
  • platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/in-html/circle-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/multichar-glyph-expected.png:
  • platform/mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
01:23 Changeset [104908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Unused code cleanup on ewk_tiled_model.cpp.
https://bugs.webkit.org/show_bug.cgi?id=76031

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Ryosuke Niwa.

Remove unused code from ewk_tiled_model.cpp.

  • ewk/ewk_tiled_model.cpp:
01:17 Changeset [104907] by haraken@chromium.org
  • 5 edits
    2 adds in trunk

text-decorations should not be propagated to floating, absolutely or fixed
positioned decendants
https://bugs.webkit.org/show_bug.cgi?id=18611

Reviewed by Darin Adler.

Source/WebCore:

Previously text-decorations were propagated to all child elements,
but they should not be propagated to out-of-flow descendants,
i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

Test: fast/css/text-decoration-in-descendants.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

LayoutTests:

The added test checks that text-decorations are not propagated to out-of-flow
descendants, i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

  • fast/css/text-decoration-in-descendants-expected.html: Added.
  • fast/css/text-decoration-in-descendants.html: Added.
  • platform/chromium-linux/fast/repaint/focus-layers-expected.png: Updated the test result.
  • platform/mac/fast/repaint/focus-layers-expected.png: Ditto.
01:14 Changeset [104906] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION (r104668): Crash in HTMLFormElement destructor if the
document contains radio groups with the identical name.
https://bugs.webkit.org/show_bug.cgi?id=76206

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/radio/radio-group-document-destruction.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement):
setForm(0) may register this to a document-level radio button group.
We need to unregister this from the group because
Document::checkedRadioButtons() is still accessible from other objects.

LayoutTests:

  • fast/forms/radio/radio-group-document-destruction-expected.txt: Added.
  • fast/forms/radio/radio-group-document-destruction.html: Added.
01:12 Changeset [104905] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069

Reviewed by Martin Robinson.

Source/WebCore:

Fix bug introduced with patch for Bug 72830.

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.

Source/WebKit/gtk:

Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.

  • tests/testatk.c:

(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.

01:10 Changeset [104904] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Removed duplicated unit test.

The unit test testWebkitAtkGetTextAtOffsetForms is exactly the
same test case than testWebkitAtkGetTextAtOffset, so it makes no
sense to have it duplicated.

Rubber-stamped by Martin Robinson.

  • tests/testatk.c:

(main): Removed testWebkitAtkGetTextAtOffsetForms.

01:05 Changeset [104903] by achicu@adobe.com
  • 4 edits in trunk/Source/WebCore

Refactor RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer()/paintLayerContents() to avoid duplicate code
https://bugs.webkit.org/show_bug.cgi?id=75983

Reviewed by Simon Fraser.

No new tests, just merging two duplicate methods.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

This method is used only in non-composited mode, so I've moved the check for composited mode much earlier.

(WebCore::RenderLayer::paintLayerContentsAndReflection):

Also used just in non-composited mode, it will draw the reflection and then just call paintLayerContents.

(WebCore::RenderLayer::paintLayerContents):

Old method, that is now used by both composited and non-composited mode. I've added 3 more flags used to render the
Graphics layers: Background, Foreground and Mask.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Removed all the code and delegated the work to RenderLayer::paintLayerContents.

00:47 Changeset [104902] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Mac][DRT] Should support --no-timeout
https://bugs.webkit.org/show_bug.cgi?id=76242

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-13
Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
(setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
(shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.

00:46 Changeset [104901] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r104787 if JIT_VERBOSE_OSR is defined

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

01/12/12:

23:23 Changeset [104900] by morrita@google.com
  • 88 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Mark all exported symbols in the header file automatically.
https://bugs.webkit.org/show_bug.cgi?id=72855

Reviewed by Darin Adler.

Added WTF_EXPORT_PRIVATE and JS_EXPORT_PRIVATE based on JavaScriptCore.exp files.
The change is generated by a tool calledListExportables (https://github.com/omo/ListExportables)

  • API/OpaqueJSString.h:
  • bytecode/CodeBlock.h:
  • bytecode/SamplingTool.h:
  • debugger/Debugger.h:
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.h:
  • heap/AllocationSpace.h:
  • heap/HandleHeap.h:
  • heap/Heap.h:
  • heap/MachineStackMarker.h:
  • heap/MarkStack.h:
  • heap/VTableSpectrum.h:
  • heap/WriteBarrierSupport.h:
  • parser/Nodes.h:
  • parser/ParserArena.h:
  • profiler/Profile.h:
  • runtime/ArgList.h:
  • runtime/CallData.h:
  • runtime/Completion.h:
  • runtime/ConstructData.h:
  • runtime/DateInstance.h:
  • runtime/Error.h:
  • runtime/ExceptionHelpers.h:
  • runtime/FunctionConstructor.h:
  • runtime/Identifier.h:
  • runtime/InitializeThreading.h:
  • runtime/InternalFunction.h:
  • runtime/JSArray.h:
  • runtime/JSByteArray.h:
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalThis.h:
  • runtime/JSLock.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
  • runtime/JSValue.h:
  • runtime/JSVariableObject.h:
  • runtime/Lookup.h:
  • runtime/MemoryStatistics.h:
  • runtime/ObjectPrototype.h:
  • runtime/Options.h:
  • runtime/PropertyDescriptor.h:
  • runtime/PropertyNameArray.h:
  • runtime/PropertySlot.h:
  • runtime/RegExp.h:
  • runtime/RegExpObject.h:
  • runtime/SamplingCounter.h:
  • runtime/SmallStrings.h:
  • runtime/StringObject.h:
  • runtime/Structure.h:
  • runtime/TimeoutChecker.h:
  • runtime/UString.h:
  • runtime/WriteBarrier.h:
  • wtf/ArrayBufferView.h:
  • wtf/ByteArray.h:
  • wtf/CryptographicallyRandomNumber.h:
  • wtf/CurrentTime.h:
  • wtf/DateMath.h:
  • wtf/DecimalNumber.h:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/MD5.h:
  • wtf/MainThread.h:
  • wtf/MetaAllocator.h:
  • wtf/MetaAllocatorHandle.h:
  • wtf/OSAllocator.h:
  • wtf/PageBlock.h:
  • wtf/RandomNumber.h:
  • wtf/RefCountedLeakCounter.h:
  • wtf/SHA1.h:
  • wtf/Threading.cpp:
  • wtf/Threading.h:
  • wtf/ThreadingPrimitives.h:
  • wtf/WTFThreadData.h:
  • wtf/dtoa.h:
  • wtf/text/AtomicString.h:
  • wtf/text/CString.h:
  • wtf/text/StringBuilder.h:
  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:
  • wtf/unicode/Collator.h:
  • wtf/unicode/UTF8.h:
  • yarr/Yarr.h:
  • yarr/YarrPattern.h:
22:44 Changeset [104899] by barraclough@apple.com
  • 24 edits in trunk/Source

../JavaScriptCore: [Chromium] JSExportMacros.h should be visible.
https://bugs.webkit.org/show_bug.cgi?id=76147

Patch by MORITA Hajime <morrita@google.com> on 2012-01-12
Reviewed by Tony Chang.

  • config.h:

../WebCore: Clean up putDirect (part 2)
https://bugs.webkit.org/show_bug.cgi?id=76232

Reviewed by Sam Weinig.

Rename putWithAttributes to putDirectVirtual.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putDirectVirtual):

  • bindings/js/JSDOMWindowShell.h:
22:19 Changeset [104898] by mikelawther@chromium.org
  • 5 edits in trunk/LayoutTests

losslessly optimise file size of test resource pngs
https://bugs.webkit.org/show_bug.cgi?id=76240

Reviewed by Darin Adler.

Filesizes approximately halved.

  • css3/calc/resources/colorsquare.png:
  • css3/calc/resources/diamond.png:
  • css3/calc/resources/mask.png:
  • css3/calc/resources/ring.png:
21:13 Changeset [104897] by morrita@google.com
  • 4 edits in trunk/Source

[Chromium] JSExportMacros.h should be visible.
https://bugs.webkit.org/show_bug.cgi?id=76147

Reviewed by Tony Chang.

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

No new tests. No behavior change.

  • config.h:
20:51 Changeset [104896] by commit-queue@webkit.org
  • 6 edits
    1 copy
    1 add in trunk/Source/WebCore

Split GraphicsContext3DOpenGL into several files
https://bugs.webkit.org/show_bug.cgi?id=75462

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-01-12
Reviewed by Kenneth Russell.

Split GraphicsContext3DOpenGL.cpp into three files, GraphicsContext3DOpenGLCommon.cpp,
GraphicsContext3DOpenGL.cpp & GraphicsContext3DOpenGLES.cpp so that makes gles support possible
for WebGL etc. Most of common APIs between gl and gles are in GraphicsContext3DOpenGLCommon.cpp.
The other gl and gles specific APIs are placed apart in GraphicsContext3DOpenGL.cpp &
GraphicsContext3DOpenGLES.cpp

No new tests required.

  • GNUmakefile.list.am: Added GraphicsContext3DOpenGLCommon.cpp
  • Target.pri: Added GraphicsContext3DOpenGLCommon.cpp
  • WebCore.gypi: Added GraphicsContext3DOpenGLCommon.cpp
  • WebCore.xcodeproj/project.pbxproj: Added GraphicsContext3DOpenGLCommon.cpp
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::renderbufferStorage):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Copied from Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp.

(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp: Added.

(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::texImage2D):

20:44 Changeset [104895] by levin@chromium.org
  • 5 edits
    1 move in trunk/Source

HwndDC is a better name than OwnGetDC.
https://bugs.webkit.org/show_bug.cgi?id=76235

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

This is a better name for two reasons:

  1. "Own" implies "delete". In this case, the final call is a release (ReleaseDC).
  2. "Ref" would be a better name due to the release but the RefPtr (and OwnPtr) classes always take something to hold on to. In this case, the object (the DC) is created by the class once it is given a Window to ensure that the HDC was actually created using GetDC.

(WTF::HwndDC::HwndDC):
(WTF::HwndDC::~HwndDC):
(WTF::HwndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

20:35 Changeset [104894] by eae@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

Add mac-snowleopard pixel results for tests with scrollbars
https://bugs.webkit.org/show_bug.cgi?id=76223

Reviewed by Eric Seidel.

  • platform/mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/mac-snowleopard/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/button-default-title-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol: Added.
  • platform/mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-lr: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-rl: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
20:27 Changeset [104893] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Add vsma in VectorMath to handle vector scale multiply and add and use it in AudioBus
https://bugs.webkit.org/show_bug.cgi?id=75835

When summing a audio bus, the source is multiplied with the scale and
then summed into the destination bus. Add this function to fulfill it.

Patch by Wei James <james.wei@intel.com> on 2012-01-12
Reviewed by Kenneth Russell.

  • platform/audio/AudioBus.cpp:
  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsma):

  • platform/audio/VectorMath.h:
20:06 Changeset [104892] by lforschler@apple.com
  • 1 copy in tags/Safari-535.17

New Tag.

19:59 Changeset [104891] by dimich@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

[Chromium] More rebaselines after http://trac.webkit.org/changeset/104881.
Unreviewed.

  • platform/chromium-mac-leopard/fast/overflow/005-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/br-with-clear-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-rl/002-expected.txt: Removed.
19:56 Changeset [104890] by dslomov@google.com
  • 3 edits in trunk/LayoutTests

Unreviewed: update expectation for fast/workers/worker-script-error.

  • platform/chromium/fast/workers/worker-script-error-expected.txt:
  • platform/chromium/test_expectations.txt:
18:42 Changeset [104889] by dimich@chromium.org
  • 1 edit
    11 moves
    100 adds
    13 deletes in trunk/LayoutTests

[Chromium] Rebaseline files affected by http://trac.webkit.org/changeset/104881.
They still render the old way in Chromium.
The garden-o-matic also collapsed some identical test results.
Unreviewed.

  • fast/block/float/008-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/008-expected.txt.
  • fast/block/float/019-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/019-expected.txt.
  • fast/block/float/033-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/033-expected.txt.
  • fast/block/float/035-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/035-expected.txt.
  • fast/block/positioning/negative-rel-position-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/negative-rel-position-expected.txt.
  • fast/flexbox/flex-hang-expected.txt: Renamed from LayoutTests/platform/gtk/fast/flexbox/flex-hang-expected.txt.
  • fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/gif-large-checkerboard-expected.txt.
  • fast/table/height-percent-test-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/height-percent-test-expected.txt.
  • fast/table/wide-colspan-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/wide-colspan-expected.txt.
  • fast/table/wide-column-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/wide-column-expected.txt.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/008-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/019-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/033-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/035-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/br-with-clear-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/br-with-clear-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/nested-clearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/negative-rel-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/relative-overflow-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-rl/002-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/border-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/line-height-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/positioned-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-top-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.txt.
  • platform/chromium-mac-snowleopard/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/flexbox/flex-hang-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/overflow-scroll-auto-switch-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/lists/li-br-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/005-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/023-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/height-percent-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/wide-colspan-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/wide-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/softHyphen-expected.png: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/qt/fast/block/float/008-expected.txt: Removed.
  • platform/qt/fast/block/float/019-expected.txt: Removed.
  • platform/qt/fast/block/float/033-expected.txt: Removed.
  • platform/qt/fast/block/float/035-expected.txt: Removed.
  • platform/qt/fast/block/positioning/negative-rel-position-expected.txt: Removed.
  • platform/qt/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/qt/fast/table/height-percent-test-expected.txt: Removed.
  • platform/qt/fast/table/wide-colspan-expected.txt: Removed.
  • platform/qt/fast/table/wide-column-expected.txt: Removed.
18:09 Changeset [104888] by simon.fraser@apple.com
  • 962 edits in trunk/LayoutTests

2012-01-12 Simon Fraser <simon.fraser@apple.com>

Fix the MIME types for expected images.

17:56 Changeset [104887] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chomium] Resources loaded with 304 status code have receiving time of 15000 days in network panel.
https://bugs.webkit.org/show_bug.cgi?id=76176

Reviewed by Nate Chapin.

No new tests. Can't trigger this with inspector tests. Will add one when the Resource Timing API is in.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Use monotonic time.

17:40 Changeset [104886] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Clean up putDirect (part 1)
https://bugs.webkit.org/show_bug.cgi?id=76232

Reviewed by Sam Weinig.

putDirect has ambiguous semantics, clean these up a bit.

putDirect generally behaves a bit like a fast defineOwnProperty, but one that
always creates the property, with no checking to validate the put it permitted.

It also encompasses two slightly different behaviors.
(1) a fast form of put for JSActivation, which doesn't have to handle searching

the prototype chain, getter/setter properties, or the magic proto value.
Break this out as a new method, 'putOwnDataProperty'.

(2) the version of putDirect on JSValue will also check for overwriting ReadOnly

values, in strict mode. This is, however, not so smart on a few level, since
it is only called from op_put_by_id with direct set, which is only used with
an object as the base, and is only used to put new properties onto objects.

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::put):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSObject.h:

(JSC::JSObject::putOwnDataProperty):

  • runtime/JSValue.h:
17:27 Changeset [104885] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

NSURL to KURL conversion shouldn't turn raw paths into file URLs
https://bugs.webkit.org/show_bug.cgi?id=76234

Reviewed by Darin Adler.

  • platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Removed this code.
17:16 Changeset [104884] by dimich@chromium.org
  • 4 edits
    1 move in trunk/LayoutTests

[Chromium] Rebaseline for a test modified in http://trac.webkit.org/changeset/104851
Unreviewed.

  • platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/mac/animations/cross-fade-webkit-mask-box-image-expected.txt: Renamed from LayoutTests/animations/cross-fade-webkit-mask-box-image-expected.txt.
16:58 Changeset [104883] by leviw@chromium.org
  • 36 edits in branches/subpixellayout/LayoutTests

Updating more test expectations.

16:51 Changeset [104882] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added an expected result missing from r104786.

  • fast/css/parsing-font-variant-ligatures-expected.txt: Added.
16:44 Changeset [104881] by simon.fraser@apple.com
  • 620 edits in trunk

Mitigate scrollbar differences when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=67217

Tools:

Reviewed by Dan Bernstein.

Enable mock scrollbars by default for tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Rubber-stamped by Dan Bernstein.

Update pixel results for tests up to and including LayoutTests/fast after
enabling mock scrollbars (67217), and fixing color profile issues (75662).

  • animations/missing-values-first-keyframe-expected.png:
  • animations/suspend-transform-animation-expected.png:
  • compositing/geometry/ancestor-overflow-change-expected.png:
  • compositing/iframes/composited-iframe-scroll-expected.png:
  • compositing/iframes/iframe-content-flipping-expected.png:
  • compositing/images/direct-pdf-image-expected.png:
  • compositing/images/direct-svg-image-expected.png:
  • compositing/masks/layer-mask-placement-expected.png:
  • compositing/overflow/repaint-after-losing-scrollbars-expected.png:
  • compositing/reflections/remove-add-reflection-expected.png:
  • compositing/tiling/constrained-layer-size-expected.png:
  • css3/filters/add-filter-rendering-expected.png:
  • css3/filters/crash-filter-change-expected.png:
  • css3/filters/effect-blur-expected.png:
  • css3/filters/effect-blur-hw-expected.png:
  • css3/filters/effect-brightness-expected.png:
  • css3/filters/effect-combined-expected.png:
  • css3/filters/effect-combined-hw-expected.png:
  • css3/filters/effect-contrast-expected.png:
  • css3/filters/effect-custom-expected.png:
  • css3/filters/effect-drop-shadow-expected.png:
  • css3/filters/effect-drop-shadow-hw-expected.png:
  • css3/filters/effect-grayscale-expected.png:
  • css3/filters/effect-grayscale-hw-expected.png:
  • css3/filters/effect-hue-rotate-expected.png:
  • css3/filters/effect-hue-rotate-hw-expected.png:
  • css3/filters/effect-invert-expected.png:
  • css3/filters/effect-invert-hw-expected.png:
  • css3/filters/effect-opacity-expected.png:
  • css3/filters/effect-opacity-hw-expected.png:
  • css3/filters/effect-saturate-expected.png:
  • css3/filters/effect-saturate-hw-expected.png:
  • css3/filters/effect-sepia-expected.png:
  • css3/filters/effect-sepia-hw-expected.png:
  • css3/filters/filter-region-expected.png:
  • css3/filters/filter-with-transform-expected.png:
  • css3/filters/nested-filter-expected.png:
  • css3/filters/regions-expanding-expected.png:
  • css3/filters/simple-filter-rendering-expected.png:
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • fast/block/float/float-not-removed-from-next-sibling4-expected.png:
  • fast/css-generated-content/table-parts-before-and-after-expected.png:
  • fast/images/color-jpeg-with-color-profile-expected.png:
  • fast/multicol/flipped-blocks-border-after-expected.png:
  • fast/multicol/vertical-lr/rules-with-border-before-expected.png:
  • fast/multicol/vertical-rl/rule-style-expected.png:
  • fast/multicol/vertical-rl/rules-with-border-before-expected.png:
  • platform/mac/animations/missing-values-last-keyframe-expected.png:
  • platform/mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/mac/compositing/direct-image-compositing-expected.png:
  • platform/mac/compositing/framesets/composited-frame-alignment-expected.png:
  • platform/mac/compositing/geometry/clipping-foreground-expected.png:
  • platform/mac/compositing/geometry/composited-html-size-expected.png:
  • platform/mac/compositing/geometry/fixed-in-composited-expected.png:
  • platform/mac/compositing/geometry/fixed-position-expected.png:
  • platform/mac/compositing/geometry/foreground-layer-expected.png:
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png:
  • platform/mac/compositing/geometry/repaint-foreground-layer-expected.png:
  • platform/mac/compositing/geometry/root-layer-update-expected.png:
  • platform/mac/compositing/geometry/tall-page-composited-expected.png:
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/mac/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png:
  • platform/mac/compositing/images/content-image-change-expected.png:
  • platform/mac/compositing/images/direct-image-background-color-expected.png:
  • platform/mac/compositing/masks/masked-ancestor-expected.png:
  • platform/mac/compositing/masks/multiple-masks-expected.png:
  • platform/mac/compositing/masks/simple-composited-mask-expected.png:
  • platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/mac/compositing/overflow/scrollbar-painting-expected.png:
  • platform/mac/compositing/plugins/composited-plugin-expected.png:
  • platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/compositing-change-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/reflections/masked-reflection-on-composited-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-mask-change-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-opacity-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-size-change-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/mac/compositing/reflections/reflection-opacity-expected.png:
  • platform/mac/compositing/reflections/reflection-positioning-expected.png:
  • platform/mac/compositing/reflections/reflection-positioning2-expected.png:
  • platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/mac/compositing/self-painting-layers-expected.png:
  • platform/mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/mac/compositing/webgl/webgl-background-color-expected.png:
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.png:
  • platform/mac/css1/basic/comments-expected.png:
  • platform/mac/css1/basic/containment-expected.png:
  • platform/mac/css1/basic/id_as_selector-expected.png:
  • platform/mac/css1/basic/inheritance-expected.png:
  • platform/mac/css1/box_properties/border-expected.png:
  • platform/mac/css1/box_properties/border_bottom-expected.png:
  • platform/mac/css1/box_properties/border_bottom_width-expected.png:
  • platform/mac/css1/box_properties/border_left-expected.png:
  • platform/mac/css1/box_properties/border_left_width-expected.png:
  • platform/mac/css1/box_properties/border_right_inline-expected.png:
  • platform/mac/css1/box_properties/border_right_width-expected.png:
  • platform/mac/css1/box_properties/border_style-expected.png:
  • platform/mac/css1/box_properties/border_top-expected.png:
  • platform/mac/css1/box_properties/border_top_width-expected.png:
  • platform/mac/css1/box_properties/border_width-expected.png:
  • platform/mac/css1/box_properties/clear-expected.png:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/box_properties/float_margin-expected.png:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac/css1/box_properties/height-expected.png:
  • platform/mac/css1/box_properties/margin-expected.png:
  • platform/mac/css1/box_properties/margin_bottom-expected.png:
  • platform/mac/css1/box_properties/margin_inline-expected.png:
  • platform/mac/css1/box_properties/margin_left-expected.png:
  • platform/mac/css1/box_properties/margin_right-expected.png:
  • platform/mac/css1/box_properties/margin_top-expected.png:
  • platform/mac/css1/box_properties/padding-expected.png:
  • platform/mac/css1/box_properties/padding_bottom-expected.png:
  • platform/mac/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/mac/css1/box_properties/padding_inline-expected.png:
  • platform/mac/css1/box_properties/padding_left-expected.png:
  • platform/mac/css1/box_properties/padding_right-expected.png:
  • platform/mac/css1/box_properties/padding_top-expected.png:
  • platform/mac/css1/box_properties/width-expected.png:
  • platform/mac/css1/cascade/cascade_order-expected.png:
  • platform/mac/css1/cascade/important-expected.png:
  • platform/mac/css1/classification/display-expected.png:
  • platform/mac/css1/classification/list_style_type-expected.png:
  • platform/mac/css1/classification/white_space-expected.png:
  • platform/mac/css1/color_and_background/background-expected.png:
  • platform/mac/css1/color_and_background/background_attachment-expected.png:
  • platform/mac/css1/color_and_background/background_image-expected.png:
  • platform/mac/css1/color_and_background/background_position-expected.png:
  • platform/mac/css1/color_and_background/background_repeat-expected.png:
  • platform/mac/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/mac/css1/font_properties/font-expected.png:
  • platform/mac/css1/font_properties/font_size-expected.png:
  • platform/mac/css1/font_properties/font_weight-expected.png:
  • platform/mac/css1/formatting_model/floating_elements-expected.png:
  • platform/mac/css1/formatting_model/height_of_lines-expected.png:
  • platform/mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/mac/css1/formatting_model/inline_elements-expected.png:
  • platform/mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/mac/css1/pseudo/anchor-expected.png:
  • platform/mac/css1/pseudo/firstletter-expected.png:
  • platform/mac/css1/pseudo/firstline-expected.png:
  • platform/mac/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/mac/css1/text_properties/letter_spacing-expected.png:
  • platform/mac/css1/text_properties/line_height-expected.png:
  • platform/mac/css1/text_properties/text_decoration-expected.png:
  • platform/mac/css1/text_properties/text_indent-expected.png:
  • platform/mac/css1/text_properties/text_transform-expected.png:
  • platform/mac/css1/text_properties/vertical_align-expected.png:
  • platform/mac/css1/text_properties/word_spacing-expected.png:
  • platform/mac/css1/units/color_units-expected.png:
  • platform/mac/css1/units/length_units-expected.png:
  • platform/mac/css1/units/urls-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-010-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-017-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-024-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-031-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-013-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-020-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-022-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-027-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-029-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-034-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-036-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-041-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-043-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-048-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-050-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-055-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-057-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-062-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-064-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-069-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-071-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-076-expected.png:
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-004-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-012-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-014-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/mac/css2.1/20110323/block-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/block-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-001-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-002-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-003-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-004-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-005-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-011-expected.png:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/inline-block-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/inline-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/inline-replaced-width-001-expected.png:
  • platform/mac/css2.1/20110323/inline-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/mac/css2.1/20110323/width-replaced-element-001-expected.png:
  • platform/mac/css2.1/t051201-c23-first-line-00-b-expected.png:
  • platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/mac/css2.1/t1202-counters-08-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/mac/css2.1/t1508-c527-font-01-b-expected.png:
  • platform/mac/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/mac/css3/images/cross-fade-blending-expected.png:
  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
  • platform/mac/css3/images/cross-fade-simple-expected.png:
  • platform/mac/css3/images/cross-fade-sizing-expected.png:
  • platform/mac/css3/images/cross-fade-tiled-expected.png:
  • platform/mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/mac/editing/inserting/insert-div-023-expected.png:
  • platform/mac/editing/pasteboard/paste-TIFF-expected.png:
  • platform/mac/editing/selection/focus_editable_html-expected.png:
  • platform/mac/editing/selection/iframe-expected.png:
  • platform/mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/mac/editing/selection/select-all-001-expected.png:
  • platform/mac/editing/selection/select-all-002-expected.png:
  • platform/mac/editing/selection/select-all-003-expected.png:
  • platform/mac/editing/selection/select-all-004-expected.png:
  • platform/mac/editing/selection/unrendered-001-expected.png:
  • platform/mac/editing/selection/unrendered-003-expected.png:
  • platform/mac/editing/selection/unrendered-004-expected.png:
  • platform/mac/editing/selection/unrendered-005-expected.png:
  • platform/mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/mac/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/block/basic/016-expected.png:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/mac/fast/block/basic/truncation-rtl-expected.png:
  • platform/mac/fast/block/float/008-expected.png:
  • platform/mac/fast/block/float/013-expected.png:
  • platform/mac/fast/block/float/019-expected.png:
  • platform/mac/fast/block/float/020-expected.png:
  • platform/mac/fast/block/float/021-expected.png:
  • platform/mac/fast/block/float/025-expected.png:
  • platform/mac/fast/block/float/026-expected.png:
  • platform/mac/fast/block/float/027-expected.png:
  • platform/mac/fast/block/float/028-expected.png:
  • platform/mac/fast/block/float/032-expected.png:
  • platform/mac/fast/block/float/033-expected.png:
  • platform/mac/fast/block/float/035-expected.png:
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/mac/fast/block/float/br-with-clear-2-expected.png:
  • platform/mac/fast/block/float/float-avoidance-expected.png:
  • platform/mac/fast/block/float/nested-clearance-expected.png:
  • platform/mac/fast/block/float/relative-painted-twice-expected.png:
  • platform/mac/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/margin-collapse/104-expected.png:
  • platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/block/positioning/051-expected.png:
  • platform/mac/fast/block/positioning/055-expected.png:
  • platform/mac/fast/block/positioning/auto/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/mac/fast/block/positioning/negative-rel-position-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/001-expected.png:
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/005-expected.png:
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/006-expected.png:
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/mac/fast/borders/border-image-massive-scale-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/mac/fast/borders/border-image-scaled-expected.png:
  • platform/mac/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/mac/fast/borders/rtl-border-01-expected.png:
  • platform/mac/fast/borders/rtl-border-02-expected.png:
  • platform/mac/fast/borders/rtl-border-03-expected.png:
  • platform/mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/mac/fast/box-sizing/box-sizing-expected.png:
  • platform/mac/fast/canvas/canvas-bg-expected.png:
  • platform/mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/mac/fast/canvas/canvas-text-baseline-expected.png:
  • platform/mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/mac/fast/canvas/shadow-offset-7-expected.png:
  • platform/mac/fast/css-generated-content/014-expected.png:
  • platform/mac/fast/css/005-expected.png:
  • platform/mac/fast/css/MarqueeLayoutTest-expected.png:
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/mac/fast/css/border-height-expected.png:
  • platform/mac/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/mac/fast/css/continuationCrash-expected.png:
  • platform/mac/fast/css/empty-pseudo-class-expected.png:
  • platform/mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/hsl-color-expected.png:
  • platform/mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/line-height-overflow-expected.png:
  • platform/mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/mac/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/mac/fast/css/nested-rounded-corners-expected.png:
  • platform/mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/percentage-non-integer-expected.png:
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png:
  • platform/mac/fast/css/shadow-multiple-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac/fast/css/text-transform-select-expected.png:
  • platform/mac/fast/css/transform-default-parameter-expected.png:
  • platform/mac/fast/css/word-space-extra-expected.png:
  • platform/mac/fast/dom/34176-expected.png:
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/mac/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/mac/fast/dom/focus-contenteditable-expected.png:
  • platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png:
  • platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/anchor-lock-expected.png:
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/pointer-events-2-expected.png:
  • platform/mac/fast/events/reveal-link-when-focused-expected.png:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/mac/fast/flexbox/016-expected.png:
  • platform/mac/fast/flexbox/flex-hang-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/button-default-title-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png:
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/mac/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/mac/fast/gradients/background-clipped-expected.png:
  • platform/mac/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/mac/fast/gradients/css3-color-stop-units-expected.png:
  • platform/mac/fast/gradients/css3-radial-gradients-expected.png:
  • platform/mac/fast/gradients/generated-gradients-expected.png:
  • platform/mac/fast/gradients/simple-gradients-expected.png:
  • platform/mac/fast/html/details-position-expected.png:
  • platform/mac/fast/html/details-writing-mode-expected.png:
  • platform/mac/fast/images/gif-large-checkerboard-expected.png:
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.png:
  • platform/mac/fast/images/pdf-as-background-expected.png:
  • platform/mac/fast/images/pdf-as-image-expected.png:
  • platform/mac/fast/images/pdf-as-image-landscape-expected.png:
  • platform/mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/mac/fast/inline-block/tricky-baseline-expected.png:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/mac/fast/inline/inline-continuation-borders-expected.png:
  • platform/mac/fast/inline/long-wrapped-line-expected.png:
  • platform/mac/fast/invalid/residual-style-expected.png:
  • platform/mac/fast/layers/overflow-scroll-auto-switch-expected.png:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/mac/fast/lists/001-expected.png:
  • platform/mac/fast/lists/001-vertical-expected.png:
  • platform/mac/fast/lists/003-expected.png:
  • platform/mac/fast/lists/008-expected.png:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/lists/li-br-expected.png:
  • platform/mac/fast/lists/ol-start-parsing-expected.png:
  • platform/mac/fast/lists/olstart-expected.png:
  • platform/mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-02-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-03-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-04-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-05-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-06-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-07-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-09-expected.png:
  • platform/mac/fast/media/mq-width-absolute-01-expected.png:
  • platform/mac/fast/media/mq-width-absolute-02-expected.png:
  • platform/mac/fast/media/mq-width-absolute-03-expected.png:
  • platform/mac/fast/media/mq-width-absolute-04-expected.png:
  • platform/mac/fast/multicol/client-rects-expected.png:
  • platform/mac/fast/multicol/column-break-with-balancing-expected.png:
  • platform/mac/fast/multicol/column-rules-expected.png:
  • platform/mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/float-paginate-complex-expected.png:
  • platform/mac/fast/multicol/float-paginate-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/mac/fast/multicol/layers-split-across-columns-expected.png:
  • platform/mac/fast/multicol/nested-columns-expected.png:
  • platform/mac/fast/multicol/overflow-unsplittable-expected.png:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.png:
  • platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.png:
  • platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.png:
  • platform/mac/fast/multicol/pagination-h-vertical-lr-expected.png:
  • platform/mac/fast/multicol/pagination-h-vertical-rl-expected.png:
  • platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.png:
  • platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.png:
  • platform/mac/fast/multicol/pagination-v-vertical-lr-expected.png:
  • platform/mac/fast/multicol/pagination-v-vertical-rl-expected.png:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/mac/fast/multicol/shadow-breaking-expected.png:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/mac/fast/multicol/table-vertical-align-expected.png:
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/mac/fast/overflow/002-expected.png:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/005-expected.png:
  • platform/mac/fast/overflow/006-expected.png:
  • platform/mac/fast/overflow/007-expected.png:
  • platform/mac/fast/overflow/008-expected.png:
  • platform/mac/fast/overflow/childFocusRingClip-expected.png:
  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.png:
  • platform/mac/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/mac/fast/overflow/image-selection-highlight-expected.png:
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/mac/fast/overflow/overflow-auto-table-expected.png:
  • platform/mac/fast/overflow/overflow-focus-ring-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/mac/fast/overflow/overflow-stacking-expected.png:
  • platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/mac/fast/overflow/overflow-update-transform-expected.png:
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/mac/fast/overflow/scrollbar-position-update-expected.png:
  • platform/mac/fast/overflow/table-overflow-float-expected.png:
  • platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/mac/fast/parser/document-write-option-expected.png:
  • platform/mac/fast/reflections/reflection-direction-expected.png:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/mac/fast/reflections/reflection-masks-outset-expected.png:
  • platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-expected.png:
  • platform/mac/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-tranformed-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/mac/fast/repaint/text-shadow-expected.png:
  • platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/mac/fast/replaced/005-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/width100percent-button-expected.png:
  • platform/mac/fast/replaced/width100percent-image-expected.png:
  • platform/mac/fast/selectors/166-expected.png:
  • platform/mac/fast/table/023-expected.png:
  • platform/mac/fast/table/027-vertical-expected.png:
  • platform/mac/fast/table/034-expected.png:
  • platform/mac/fast/table/038-vertical-expected.png:
  • platform/mac/fast/table/040-expected.png:
  • platform/mac/fast/table/040-vertical-expected.png:
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/mac/fast/table/border-collapsing/004-expected.png:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/mac/fast/table/edge-offsets-expected.png:
  • platform/mac/fast/table/empty-cells-expected.png:
  • platform/mac/fast/table/height-percent-test-expected.png:
  • platform/mac/fast/table/overflowHidden-expected.png:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/mac/fast/table/table-display-types-vertical-expected.png:
  • platform/mac/fast/table/wide-colspan-expected.png:
  • platform/mac/fast/table/wide-column-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/drawBidiText-expected.png:
  • platform/mac/fast/text/hyphenate-character-expected.png:
  • platform/mac/fast/text/hyphenate-limit-lines-expected.png:
  • platform/mac/fast/text/hyphenate-locale-expected.png:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/mac/fast/text/large-text-composed-char-expected.png:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/mac/fast/text/softHyphen-expected.png:
  • platform/mac/fast/text/stroking-decorations-expected.png:
  • platform/mac/fast/text/stroking-expected.png:
  • platform/mac/fast/text/text-letter-spacing-expected.png:
  • platform/mac/fast/text/wbr-expected.png:
  • platform/mac/fast/text/whitespace/024-expected.png:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/mac/fast/text/word-break-expected.png:
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.png:
  • platform/mac/fast/writing-mode/fieldsets-expected.png:
  • platform/mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
  • platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
16:33 Writing Layout Tests for DumpRenderTree edited by scheib@chromium.org
(diff)
16:31 Changeset [104880] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/WebCore

Merged r103082.

16:30 Changeset [104879] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Create a GraphicsLayer for the overhang areas if threaded scrolling is enabled
https://bugs.webkit.org/show_bug.cgi?id=76220

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

Remove PLATFORM(CHROMIUM) #ifdefs.

  • page/FrameView.h:

Ditto.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Ditto.

  • platform/ScrollableArea.h:

Ditto.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
Ditto.

(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
Make this return true if we have a scrolling coordinator.

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Remove PLATFORM(CHROMIUM) #ifdefs. Fix a bug the overhang layer was being added above the clip layer.

(WebCore::RenderLayerCompositor::destroyRootLayer):
Remove PLATFORM(CHROMIUM) #ifdefs.

  • rendering/RenderLayerCompositor.h:

Ditto.

16:29 Changeset [104878] by dimich@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Baseline for test added in http://trac.webkit.org/changeset/104851
Unreviewed.

  • platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.txt: Added.
16:28 Changeset [104877] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Merged r102024.

16:27 Changeset [104876] by bashi@chromium.org
  • 4 edits
    1 move in trunk/Source/WebCore

Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=76155

Reviewed by Tony Chang.

No new tests. No behavior change.

  • PlatformBlackBerry.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/skia/SimpleFontDataSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/SimpleFontDataSkia.cpp.

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

16:24 Changeset [104875] by lforschler@apple.com
  • 2 edits
    2 copies in branches/safari-534.54-branch/Source/WebCore

Merge pre-reqs for 102024.

16:19 Changeset [104874] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

A Frame with frame flattening can be stuck in a state in which performPostLayoutTasks() is never executed
https://bugs.webkit.org/show_bug.cgi?id=76154

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-12
Reviewed by Beth Dakin.

In a frame with inSubframeLayoutWithFrameFlattening == true, if
-m_hasPendingPostLayoutTasks == true
-FrameView::unscheduleRelayout() is executed
-->the timer m_postLayoutTasksTimer is stopped
-->no timer is scheduled due to m_hasPendingPostLayoutTasks == true && inSubframeLayoutWithFrameFlattening == true

This patch revert the handling of the postLayoutTasks to its state prior to r66552.

The timer itself is used as the only state to know if post layout tasks are scheduled.

For the case without frame flattening:
-Prior to this patch, when FrameView::unscheduleRelayout() was executed, the postLayoutTasksTimer was killed,
and the post layout tasks would be executed during the next layout().
-After this patch, the post layout tasks stay scheduled and are executed on the next event loop if layout()
was not invoked before.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::unscheduleRelayout):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::performPostLayoutTasks):

  • page/FrameView.h:
15:59 Changeset [104873] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-01-12
Reviewed by Benjamin Poulain.

https://bugs.webkit.org/show_bug.cgi?id=75991
Make the code in MemoryPressureHandler::respondToMemoryPressure shareable.

Move memory pressure handling code inside a new function (releaseMemory) so that
we could shared it between mac and iOS.

  • Configurations/WebCore.xcconfig: add MemoryPressureHandlerMac.mm into iOS build.
  • platform/MemoryPressureHandler.h:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):
(WebCore::MemoryPressureHandler::releaseMemory):

15:57 Changeset [104872] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor DOMImplementation.hasFeature logic into helper functions.
https://bugs.webkit.org/show_bug.cgi?id=76212

Reviewed by Adam Barth.

This patch should not have any behavior change. The goal was
to move our feature detection towards a more modular architecture
(as that seems to be the current trend in webkit). In a future
patch we could easily move the SVG feature detection into the
SVG directory, for example. I've also added a list of all the
Event3 features (currently commented out) which makes it obvious
how many we're missing.

  • dom/DOMImplementation.cpp:

(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
(WebCore::isEvents2Feature):
(WebCore::isEvents3Feature):
(WebCore::DOMImplementation::hasFeature):

15:51 Changeset [104871] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=76141
defineSetter/defineGetter may fail to update Accessor attribute

Reviewed by Oliver Hunt.

  • runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):

  • runtime/Structure.cpp:

(JSC::Structure::attributeChangeTransition):

  • runtime/Structure.h:
15:48 Changeset [104870] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r95607.

15:46 Changeset [104869] by lforschler@apple.com
  • 10 edits
    3 copies in branches/safari-534.54-branch

Merged r94338.

15:43 Changeset [104868] by lforschler@apple.com
  • 14 edits
    1 add in branches/safari-534.54-branch

Merged r94317.

15:34 Changeset [104867] by levin@chromium.org
  • 5 edits
    1 add in trunk/Source

[chromium] Fix DC leak in WebScreenInfoFactory.
https://bugs.webkit.org/show_bug.cgi?id=76203

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnGetDCWin.h
  • JavaScriptCore.gypi: Added OwnGetDCWin.h
  • JavaScriptCore/wtf/win/OwnGetDCWin.h: Made an owner class for GetDC which needs ReleaseDC as opposed to DeleteDC.

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo): Use OwnGetDC to ensure its release.

15:18 Changeset [104866] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

NodeIterator loses track of the reference node when the reference node is removed from the document (IETC ni_removeReferenceNode)
https://bugs.webkit.org/show_bug.cgi?id=76146

Reviewed by Eric Seidel.

Source/WebCore:

In the case where we're removing the reference node we can end up with
the wrong reference node. This patch makes sure we traverse outside of
the removed node's subtree.

This bug was caught by the following IE Test Center test:

http://samples.msdn.microsoft.com/ietestcenter/domtraversal/showdomtraversaltest.htm?ni_removeReferenceNode

Our new behavior also match Firefox.

I experimented a bit with adding ASSERT_NOT_REACHED to various branches
in NodeIterator::updateForNodeRemoval, and it seems our test coverage
for this function is relatively poor. In the future, we should
consider adding more tests for this complicated function.

Test: fast/dom/node-iterator-reference-node-removed.html

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::updateForNodeRemoval):

LayoutTests:

Test based on http://samples.msdn.microsoft.com/ietestcenter/domtraversal/showdomtraversaltest.htm?ni_removeReferenceNode

  • fast/dom/node-iterator-reference-node-removed-expected.txt: Added.
  • fast/dom/node-iterator-reference-node-removed.html: Added.
15:12 Changeset [104865] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Throw exception if IDBCursor.continue() called with key equal to current
https://bugs.webkit.org/show_bug.cgi?id=76100

Source/WebCore:

The fix for https://bugs.webkit.org/show_bug.cgi?id=74213 missed the "or equal" clause
in the spec.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

Test: storage/indexeddb/cursor-continue.html

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):

LayoutTests:

The previously existing clauses that iterated a cursor over non-unique values
by specifing a key now fail per spec, so they are changed to simply call continue().

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
14:57 Changeset [104864] by jonlee@apple.com
  • 3 edits
    2 adds in trunk

Setting value on a select element to a non existing option value should clear selection
https://bugs.webkit.org/show_bug.cgi?id=67233
<rdar://problem/10057159>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/select/setting-to-invalid-value.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setValue): Clear the selection in the cases where we cannot
find an option with the specified value. The spec states to clear the selectedness of all
options first. To avoid calling setSelectedIndex() multiple times, we clear the selected
option(s) only when don't find the appropriate option.

Also, correct the sentence style of a comment.

LayoutTests:

New tests check to see that setting the value of a select element clears the
selection, even if the value is invalid, null, or undefined.

  • fast/forms/select/setting-to-invalid-value-expected.txt: Added.
  • fast/forms/select/setting-to-invalid-value.html: Added.
14:54 Changeset [104863] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r104858.

NSDataReadingMappedIfSafe is not defined on <= 10.6. Use NSDataReadingMapped on that platform instead.

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

14:53 Changeset [104862] by lforschler@apple.com
  • 28 edits
    3 copies in branches/safari-534.54-branch

Merged r91777.

14:39 Changeset [104861] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk/Source

[skia] Track a simple opaque area when painting via PlatformContextSkia and save in LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=74352

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-12
Reviewed by Stephen White.

Source/WebCore:

New unit tests in PlatformContextSkiaTest.cpp

  • WebCore.gypi:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::drawOuterPath):
(WebCore::drawInnerPath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):

  • platform/graphics/skia/OpaqueRegionSkia.cpp: Added.

(WebCore::OpaqueRegionSkia::OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::~OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::asRect):
(WebCore::xfermodeIsOpaque):
(WebCore::xfermodePreservesOpaque):
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):

  • platform/graphics/skia/OpaqueRegionSkia.h: Added.
  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::clippedToImage):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::paintSkPaint):
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::setTrackOpaqueRegion):
(WebCore::PlatformContextSkia::opaqueRegion):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/PlatformContextSkiaTest.cpp: Added.

(WebCore::TEST):

14:18 Changeset [104860] by bdakin@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=76209
Support expanded scrollbars
-and corresponding-
<rdar://problem/10527734>

Reviewed by Sam Weinig.

All this really requires is leaving the proper amount of space for the
expanded width.

  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::supportsExpandedScrollbars):
(WebCore::ScrollbarThemeMac::scrollbarThickness):

14:15 Changeset [104859] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

WebAudio: Enable USE_CONCATENATED_IMPULSE_RESPONSES on Mac port.
https://bugs.webkit.org/show_bug.cgi?id=74328

Reviewed by Eric Carlson.

No new tests; no net change in functionality.

  • WebCore.xcodeproj/project.pbxproj: Added SincResampler class, Composite.wav to the project.

Removed IRC_*.wav resources from the project.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::createBySampleRateConverting): Uncommented this function

  • platform/audio/AudioBus.h:
  • platform/audio/HRTFElevation.cpp:
14:13 Changeset [104858] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
https://bugs.webkit.org/show_bug.cgi?id=74326

Reviewed by Darin Adler.

No new tests; no net change in functionality.

Use NSDataReadingMappedIfSafe when reading platform audio file data.

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

14:11 Changeset [104857] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

WebAudio: Use Logging instead of printf.
https://bugs.webkit.org/show_bug.cgi?id=74322

Reviewed by Darin Adler.

No new tests; no net change in functionality.

Add a new WebCoreLogLevel for WebAudio, and use this new log level instead of
printf statements in webaudio classes.

  • platform/Logging.cpp:

(WebCore::getChannelFromName):

  • platform/Logging.h:
  • platform/mac/LoggingMac.mm:

(WebCore::InitializeLoggingChannelsIfNecessary):

  • platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::print):

  • webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):

14:08 Changeset [104856] by rniwa@webkit.org
  • 4 edits
    1 add in trunk/Tools

Need a script to run tests in PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=76132

Reviewed by Adam Barth.

Add run-perf-tests to run performance tests using parser/resources/runner.js.
Unfortunately, there isn't an easy way of telling which test uses which format
so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).

All test outputs are re-formatted to match Chromium perf-bot style.

  • Scripts/run-inspector-perf-tests.py:
  • Scripts/run-perf-tests: Added.
  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._print_status):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._should_ignore_line_in_parser_test_result):
(PerfTestsRunner._process_parser_test_result):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):
(create_runner):
(run_test):
(test_run_test_set):
(test_run_test_set_for_parser_tests):
(test_collect_tests):

13:39 Changeset [104855] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make ScrollElasticityController members private
https://bugs.webkit.org/show_bug.cgi?id=76208

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::endScrollGesture):
Call ScrollElasticityController::endScrollGesture.

  • platform/mac/ScrollElasticityController.h:

Make members private.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::endScrollGesture):
Call snapRubberBand.

(WebCore::ScrollElasticityController::snapRubberBandTimerFired):
Call stopSnapRubberbandTimer.

13:34 Changeset [104854] by enne@google.com
  • 3 edits
    3 copies in branches/chromium/963

Merge 104782 - Repaint all graphics layers when their renderer offset changes
https://bugs.webkit.org/show_bug.cgi?id=75730

Reviewed by Simon Fraser.

Source/WebCore:

In RenderLayerBacking, only the main graphics layer gets repainted
when the offset changes. If the offset on other graphics layers (e.g.
the foreground layer) changes, they should get repainted as well.

Test: compositing/geometry/foreground-offset-change.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setOffsetFromRenderer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

  • platform/graphics/GraphicsLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

  • compositing/geometry/foreground-offset-change-expected.png: Added.
  • compositing/geometry/foreground-offset-change-expected.txt: Added.
  • compositing/geometry/foreground-offset-change.html: Added.

TBR=enne@google.com
Review URL: http://codereview.chromium.org/9187066

13:28 Changeset [104853] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move wheel event handling to ScrollElasticityController::handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=76205

Reviewed by Andreas Kling.

Move the code in ScrollAnimatorMac::smoothScrollWithEvent to ScrollElasticityController::handleWheelEvent and
change ScrollAnimatorMac::handleWheelEvent to just call ScrollElasticityController::handleWheelEvent.
This means that we'll not set m_haveScrolledSincePageLoad = true anymore (we used to set it in ScrollAnimatorMac::smoothScrollWithEvent),
but we already set it to true in ScrollAnimatorMac::handleWheelEvent so it already had no effect.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::elasticDeltaForReboundDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollElasticityController::handleWheelEvent):

13:26 Changeset [104852] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r92005.

13:25 Changeset [104851] by simon.fraser@apple.com
  • 5 edits
    3 adds in trunk

Borders and box masks behave incorrectly with overlapping offsets
https://bugs.webkit.org/show_bug.cgi?id=76137

Source/WebCore:

Reviewed by Dave Hyatt.

When border-image-slice sizes add up to more than the height or width
of the border-image, the middle sections should not be rendered, per spec.

Test: fast/borders/border-image-slice-constrained.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

Reviewed by Dave Hyatt.

Testcase with border-image slices adding up to more than the height/width
of the border image.

Fixed cross-fade-webkit-mask-box-image.html to use slices that are half
of the image width.

  • animations/cross-fade-webkit-mask-box-image.html:
  • fast/borders/border-image-slice-constrained.html: Added.
  • platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/mac/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/mac/fast/borders/border-image-slice-constrained-expected.txt: Added.
13:16 Changeset [104850] by mrobinson@webkit.org
  • 5 edits
    1 copy in trunk/Source/WebKit2

[GTK] [WebKit2] WebKitURIRequest and WebKitURIResponse should wrap the corresponding WebCore classes
https://bugs.webkit.org/show_bug.cgi?id=74478

Reviewed by Gustavo Noronha Silva.

Have WebKitURIRequest wrap a ResourceRquesst and WebKitURIResponse wrap a ResourceResponse.
They are the WebCore types they are meant to represent and we will need to expose more
information from them in the future to make them useful. Later we can have ResourceResponse
generate a SoupMessage lazily if necessary.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitURIRequest.cpp:

(webkit_uri_request_class_init): Remove the set property vmethod.
(webkit_uri_request_new): The URI property is no longer settable.
(webkitURIRequestCreateForResourceRequest): Added this private constructor.
(webkit_uri_request_get_uri): Now we just get the URI directly from the ResourceRequest.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkit_uri_response_class_init): Remove the set property vmethod.
(webkit_uri_response_get_uri): Get the URI directly from the ResourceReponse.
(webkit_uri_response_get_status_code): Get the status code directly from the ResourceResponse.
(webkit_uri_response_get_content_length): Get the content length directly from the ResourceResponse.
(webkitURIResponseCreateForResourceResponse): Added this private constructor.

  • UIProcess/API/gtk/WebKitURIResponsePrivate.h: Removed unnecessary methods.
13:08 Changeset [104849] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make all calls to pinnedInDirection go through the ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=76204

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

12:50 Changeset [104848] by senorblanco@chromium.org
  • 5 edits in trunk

[chromium] Re-enable Skia feColorMatrix filter implementation.
https://bugs.webkit.org/show_bug.cgi?id=76186

Source/WebCore:

This code was landed in http://trac.webkit.org/changeset/104566 and
partially reverted in http://trac.webkit.org/changeset/104632 due
to problems with the Windows Shared builder. Those problems have
been fixed in r3006, since rolled into Chrome.

Reviewed by Kenneth Russell.

Covered by SVG feColorMatrix tests.

  • WebCore.gypi:
  • platform/graphics/filters/FEColorMatrix.h:

LayoutTests:

Remove suppressions for tests which now pass.

Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
12:43 Changeset [104847] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add allowsHorizontalStretching and allowsVerticalStretching to ScrollElasticityControllerClient
https://bugs.webkit.org/show_bug.cgi?id=76202

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/ScrollElasticityController.h:
12:25 Changeset [104846] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move snapRubberBand to ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=76200

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::endScrollGesture):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(systemUptime):
(WebCore::ScrollElasticityController::snapRubberBand):

12:21 Changeset [104845] by antti@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r104060): Setting user stylesheet may leave CSSStyleSelector with stale rule pointers
https://bugs.webkit.org/show_bug.cgi?id=76191

Source/WebCore:

Reviewed by Andreas Kling.

Setting the user style sheet frees the existing user style sheet data structures. The code
in Document::updatePageGroupUserSheets then relies on styleSelectorChanged to clear the
style selector so it is not left with stale pointers. However under certain conditions
involving pending stylesheets it may bail out quickly without clearing.

Document::styleSelectorChanged has to take care that it never leaves the style selector stale
even when bailing out early.

Test: fast/css/user-stylesheet-crash.html

  • dom/Document.cpp:

(WebCore::Document::styleSelectorChanged):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/user-stylesheet-crash-expected.txt: Added.
  • fast/css/user-stylesheet-crash.html: Added.
12:14 Changeset [104844] by nduca@chromium.org
  • 13 edits in trunk/Source

[chromium] Turn off FrameRateController timesource when it is not needed
https://bugs.webkit.org/show_bug.cgi?id=76149

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(WebCore::CCDelayBasedTimeSource::active):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):

  • platform/graphics/chromium/cc/CCFrameRateController.h:
  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCTimeSource.h:

Source/WebKit/chromium:

  • tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::timeout):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCTimeSource::active):

12:06 Changeset [104843] by dpranke@chromium.org
  • 15 edits in trunk/Tools

webkitpy: clean up port unit tests in preparation for making port_name mandatory
https://bugs.webkit.org/show_bug.cgi?id=76123

Reviewed by Adam Barth.

This change updates the unit tests to be more consistent in how
ports are created, in preparation for making port_name a
mandatory parameter to the constructor and removing any version
interpretation from it.

There should be no functional changes in this patch, but some
tests that are no longer relevant have been removed or reworked.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_get_optiondefault):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest):
(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_determine_architecture_fails):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest):
(ChromiumPortTest.test_all_test_configurations):
(ChromiumPortTest.TestMacPort.init):
(ChromiumPortTest.TestLinuxPort.init):
(ChromiumPortTest.TestWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest):

  • Scripts/webkitpy/layout_tests/port/efl_unittest.py:

(EflPortTest):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest):
(MockDRTPortTest.make_port):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._port_flag_for_scripts):
(QtPort.init):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):
(QtPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortTest):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest):
(WinPortTest._assert_search_path):
(WinPortTest.test_baseline_search_path):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config.TestMacPort.init):

12:04 Changeset [104842] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Move snapRubberBandTimerFired to ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=76196

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::elasticDeltaForTimeDelta):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

11:55 Changeset [104841] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: clean up logging and provide a real --help message
https://bugs.webkit.org/show_bug.cgi?id=76142

Reviewed by Adam Barth.

This test is mostly more refactoring - it calls objects in
unittest directly instead of routing through unittest.main() --
in order to gain more control over the logging and to provide a
correct --help message. This will also give us a better
foundation for adding more feautures down the road.

This patch adds different levels of logging controlled by the
'-s', '-q', and '-v' options (see --help for details), and
removes the --verbose-logging option.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/main.py:

(Tester):
(Tester.clean_packages):
(Tester.init):
(Tester.parse_args):
(Tester.configure):
(Tester._configure_logging):
(Tester.find_modules):
(Tester._exclude):
(Tester._modules_from_paths):
(Tester.run_tests):

11:39 Changeset [104840] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Raise NON_TRANSIENT_ERR when invalid mode specified for transaction
https://bugs.webkit.org/show_bug.cgi?id=76072

Source/WebCore:

Spec was updated to detail what should be thrown: http://www.w3.org/Bugs/Public/show_bug.cgi?id=11406

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

Tests: storage/indexeddb/transaction-basics.html

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

LayoutTests:

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
11:19 Changeset [104839] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove the last non-ScrollElasticityController call from ScrollAnimatorMac::snapRubberBandTimerFired
https://bugs.webkit.org/show_bug.cgi?id=76193

Reviewed by Andreas Kling.

Use ScrollElasticityControllerClient::immediateScrollBy for the final scroll before the rubber-band timer stops.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

11:15 Changeset [104838] by jer.noble@apple.com
  • 12 edits
    4 adds in trunk

Emit an error event when a request to enter full-screen is rejected.
https://bugs.webkit.org/show_bug.cgi?id=62320

Reviewed by Eric Carlson.

Source/WebCore:

Tests: fullscreen/full-screen-request-rejected.html

fullscreen/full-screen-request-removed.html

When a request to enter full-screen is rejected, emit an event
(webkitfullscreenerror) in response. But emit the event during the next
trip through the run-loop, like the webkitfullscreenchange event, and so a new
timer and queue are necessary.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement): Emit the error event

if the request does not pass all our requirements.

  • dom/Document.h: Add new ivars.
  • dom/Document.idl: Add support for setting an onfullscreenerror attribute.
  • dom/Element.h: Ditto.
  • dom/Element.idl: Ditto.
  • dom/EventNames.h: Add the name for the error event.

LayoutTests:

  • fullscreen/full-screen-iframe-not-allowed-expected.txt:
  • fullscreen/full-screen-iframe-not-allowed.html:
  • fullscreen/full-screen-request-rejected-expected.txt: Added.
  • fullscreen/full-screen-request-rejected.html: Added.
  • fullscreen/full-screen-request-removed-expected: Added.
  • fullscreen/full-screen-request-removed.html: Added.
11:06 Changeset [104837] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=76133
ScrollAnimatorMac::mouseEnteredScrollbar() and mouseExitedScrollbar() should
only do stuff for legacy scrollbars
-and corresponding-
<rdar://problem/10603290>

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

10:38 Changeset [104836] by barraclough@apple.com
  • 10 edits in trunk

Allow accessor get/set property to be set to undefined
https://bugs.webkit.org/show_bug.cgi?id=76148

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

AccessorDescriptor properties may have their get & set properties defined to reference a function
(Callable object) or be set to undefined. Valid PropertyDescriptors created by toPropertyDescriptor
(defined from JS code via Object.defineProperty, etc) have get and set properties that are in one of
three states (1) nonexistent, (2) set to undefined, or (3) a function (any Callable object).

On the PropertyDescriptor object these three states are represneted by JSValue(), jsUndefined(), and
any JSObject* (with a constraint that this must be callable).

Logically the get/set property of an accessor descriptor on an object might be in any of the three
states above, but in practice there is no way to distinguish between the first two states. As such
we stor the get/set values in property storage in a JSObject* field, with 0 indicating absent or
undefined. When unboxing to a PropertyDescriptor, map this back to a JS undefined value.

  • runtime/GetterSetter.h:

(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):

  • Allow the getter/setter to be cleared.
  • runtime/JSArray.cpp:

(JSC::JSArray::putDescriptor):

  • Changed to call getterObject/setterObject.

(JSC::JSArray::defineOwnNumericProperty):

  • Added ASSERT.
  • runtime/JSObject.cpp:

(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):

  • Changed to call getterObject/setterObject.
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):

  • getter/setter values read from properties on object are never missing, they will now be set as undefined by 'setDescriptor'.

(JSC::toPropertyDescriptor):

  • Do not translate undefined->empty, this loses an important distinction between a get/set property being absent, or being explicitly set to undefined.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::getterObject):
(JSC::PropertyDescriptor::setterObject):

  • Accessors to convert the get/set property to an object pointer, converting undefined to 0.

(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):

  • Translate a getter/setter internally represented at 0 to undefined, indicating that it is present.
  • runtime/PropertyDescriptor.h:
    • Declare getterObject/setterObject.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Update a couple of inaccurate tests (it is invalid for a property to have both a get: and value: field; AccessorDescritor properties do not have a writable property). Add more test cases.
10:20 Changeset [104835] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

When generating derived sources, use the same compiler that is used to compile WebCore.

Fixes <http://webkit.org/b/76189>
[mac] When compiling WebCore with clang, llvm-gcc is used to generate derived sources

Reviewed by Mark Rowe.

  • DerivedSources.make: Changed to use the CC environment variable instead of hardcoded gcc.
  • WebCore.xcodeproj/project.pbxproj: Set the CC environment variable, if not already set,

according to TARGET_GCC_VERSION. CC is used by DerivedSources.make and some of the perl
scripts it invokes.

09:47 Changeset [104834] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed build fix after r104828.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::StylePainterMobile::findComboButton):

09:33 Changeset [104833] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r104829.
http://trac.webkit.org/changeset/104829
https://bugs.webkit.org/show_bug.cgi?id=76188

it broke qt-minimal (Requested by loislo1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-12

  • inspector/CodeGeneratorInspector.py:

(CodeGenerator):
(CodeGenerator.generate_type_builder):
(CodeGenerator.generate_type_builder.AdHocTypeContext):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(CodeGenerator.register_use):
(RawTypesBinding):
(RawTypesBinding.get_code_generator):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(RawTypesBinding.reduce_to_raw_type):
(TypeData.init):

  • inspector/InspectorValues.h:
09:27 Changeset [104832] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] WebProcesses crashes when composited reflections/masks are present
https://bugs.webkit.org/show_bug.cgi?id=75883

Reviewed by Kenneth Rohde Christiansen.

Make sure masks and replica layers can access layerTreeTileClient. Let masks
have the right contents/visible rect so that they can render content tiles.
Default the mask's size to be the layer's size.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::maskTarget):
(WebCore::WebGraphicsLayer::setMaskTarget):

09:06 Changeset [104831] by podivilov@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: [JSC] @ sourceURL is not respected.
https://bugs.webkit.org/show_bug.cgi?id=65532

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-url-comment.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findSourceURL):
(WebCore::ContentSearchUtils::findSourceMapURL):

  • inspector/ContentSearchUtils.h:

LayoutTests:

  • inspector/debugger/source-url-comment-expected.txt: Added.
  • inspector/debugger/source-url-comment.html: Added.
08:42 Changeset [104830] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial buildfix after r104828.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::StylePainterMobile::findComboButton):

08:40 Changeset [104829] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate array types.
https://bugs.webkit.org/show_bug.cgi?id=75284

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-12
Reviewed by Yury Semikhatsky.

New classes are generated for ecah array type instance.

  • inspector/CodeGeneratorInspector.py:

(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.init):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.init):
(TypeData.get_binding):

  • inspector/InspectorValues.h:
08:33 Changeset [104828] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Avoid string operations in mobile theme's caching mechanism
https://bugs.webkit.org/show_bug.cgi?id=75010

The string operations constantly performed in the mobile theme
to fetch or put controls in the pixmap cache can be pretty expensive.
The new mechanism harnesses the QPixmapCache::Key API instead.

Reviewed by Kenneth Rohde Christiansen.

No new tests, internal refactoring.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::qHash):
(WebCore::StylePainterMobile::findCachedControl):
(WebCore::StylePainterMobile::insertIntoCache):
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::StylePainterMobile::findPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::paintMenuList):

  • platform/qt/RenderThemeQtMobile.h:

(WebCore::KeyIdentifier::KeyIdentifier):
(WebCore::KeyIdentifier::operator==):

08:14 Changeset [104827] by vsevik@chromium.org
  • 23 edits
    4 deletes in trunk

Unreviewed, rolling out r104805.
http://trac.webkit.org/changeset/104805
https://bugs.webkit.org/show_bug.cgi?id=76180

Breaks apple win compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-12

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
(WebCore::SelectorQuery::canUseIdLookup):
(WebCore::SelectorQuery::execute):

  • dom/SelectorQuery.h:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::create):
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::shouldInclude):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Removed.
  • dom/ShadowContentSelectorQuery.h: Removed.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsContentElement::shouldInclude):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
(WebCore::DetailsSummaryElement::shouldInclude):

  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::SummaryContentElement):

  • testing/Internals.cpp:

(WebCore::Internals::createShadowContentElement):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/shadow-contents-select-expected.html: Removed.
  • fast/dom/shadow/shadow-contents-select.html: Removed.
07:28 Changeset [104826] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][WK2][Mac] Conflict of MacTypes.h defining a Fixed type after r104560.
https://bugs.webkit.org/show_bug.cgi?id=76175

Defining ENABLE_CSS_FILTERS leads to ambiguous references
due to MacTypes.h being included.
Defining CF_OPEN_SOURCE works around this problem.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:
07:14 Changeset [104825] by hausmann@webkit.org
  • 8 edits
    2 moves in trunk

Make the new WTF module build on Qt
https://bugs.webkit.org/show_bug.cgi?id=76163

Reviewed by Tor Arne Vestbø.

.:

  • WebKit.pro: Build the new WTF instead of the old one.

Source/JavaScriptCore:

Source/WTF:

With this change the WTF sources are built _here_ but _from_ their old location using a VPATH.

  • WTF.pri: Renamed from Source/JavaScriptCore/wtf/wtf.pri.
  • WTF.pro: Renamed from Source/JavaScriptCore/wtf/wtf.pro.
  • config.h: Bring this file in sync with JavaScriptCore/config.h with regards to the inclusion

/ definition of the export macros.

Tools:

  • qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
06:57 Changeset [104824] by zherczeg@webkit.org
  • 8 edits in trunk

Fix turbulence bug when stitch tiles enabled and rendered in parallel
https://bugs.webkit.org/show_bug.cgi?id=76042

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The width / height / wrap members are used by all threads
in the same time. The patch makes them local for all threads.

Fixes the layout fails in svg/dynamic-updates/SVGFETurbulence*

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::noise2D):
(WebCore::Noise::if):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):

  • platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData):

LayoutTests:

Update mac expected files.

  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
06:52 Changeset [104823] by kenneth@webkit.org
  • 9 edits in trunk/Source/WebKit2

[Qt] Set the input method hints on the QtQuick item https://bugs.webkit.org/show_bug.cgi?id=76169

Reviewed by Simon Hausmann.

Set the input method hints given the HTMLElement type and state.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:

(WebKit::EditorState::EditorState):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::updateTextInputState):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

06:44 Changeset [104822] by loislo@chromium.org
  • 3 edits
    1 add in trunk

Web Inspector: performance: restore 'log 300 messages into console' test.
https://bugs.webkit.org/show_bug.cgi?id=76170

It was removed in order of transition from layout tests to perf tests.

Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/console-300-lines.html: Added.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):

06:39 Changeset [104821] by hans@chromium.org
  • 3 edits
    2 adds in trunk

Speech input: Send text to correct element even if focus has changed
https://bugs.webkit.org/show_bug.cgi?id=76071

Reviewed by Steve Block.

Source/WebCore:

Make sure that the text from speech input ends up in the correct
element even if focus has changed since the user clicked on it.

Test: fast/speech/change-focus.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

LayoutTests:

Add test to make sure that the text from speech input ends up in the
correct element even if focus has moved away after the user clicked on it.

  • fast/speech/change-focus-expected.txt: Added.
  • fast/speech/change-focus.html: Added.
06:27 Changeset [104820] by vsevik@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, mac DumpRenderTree fix.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]):

06:08 Changeset [104819] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74493

Unreviewed. Add flaky test to GTK's test_expectations.txt.

  • platform/gtk/test_expectations.txt: Add flaky test.
05:52 Changeset [104818] by vsevik@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, updated chromium test expectations.

  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
  • platform/chromium-win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt:
  • platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
05:48 Changeset [104817] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, fix http/tests/multipart/invalid-image-data.html expectation for XP.

  • platform/chromium/test_expectations.txt:
05:37 Changeset [104816] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
04:58 Changeset [104815] by vsevik@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, rebaseline wk2 and http/tests/security/cross-frame-access-put.html test expectations after r104803.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
04:41 Changeset [104814] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening after r104803.

Remove unnecessary "line 1" from expected files.

  • platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
04:27 Changeset [104813] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104803.

  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt:
04:25 Changeset [104812] by vsevik@chromium.org
  • 2 edits in trunk/Tools

WebKitTestRunner should not print console message line number when it is equal to zero.
https://bugs.webkit.org/show_bug.cgi?id=76167

Reviewed by Csaba Osztrogonác.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willAddMessageToConsole):

04:24 Changeset [104811] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-12

  • DEPS:
04:19 Changeset [104810] by ossy@webkit.org
  • 48 edits in trunk/LayoutTests

Unreviewed gardening after r104803.

Remove unnecessary "line 0" from expected files.

  • fast/dom/exception-getting-event-handler-expected.txt:
  • fast/dom/javascript-url-exception-isolation-expected.txt:
  • fast/dom/nested-script-exceptions-expected.txt:
  • fast/events/window-onerror13-expected.txt:
  • fast/events/window-onerror16-expected.txt:
  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/js/uncaught-exception-line-number-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • http/tests/appcache/404-resource-expected.txt:
  • http/tests/appcache/manifest-redirect-expected.txt:
  • http/tests/appcache/origin-quota-expected.txt:
  • http/tests/appcache/resource-redirect-2-expected.txt:
  • http/tests/appcache/resource-redirect-expected.txt:
  • http/tests/appcache/wrong-signature-2-expected.txt:
  • http/tests/appcache/wrong-signature-expected.txt:
  • http/tests/history/cross-origin-replace-history-object-child-expected.txt:
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt:
  • http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt:
  • http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
  • http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt:
  • http/tests/security/xss-DENIED-defineProperty-expected.txt:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt:
  • inspector/console/alert-toString-exception-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
  • platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • platform/qt/plugins/document-open-expected.txt:
  • platform/qt/plugins/plugin-initiate-popup-window-expected.txt:
  • plugins/keyboard-events-expected.txt:
  • plugins/mouse-events-expected.txt:
  • plugins/mouse-events-fixedpos-expected.txt:
  • plugins/nested-plugin-objects-expected.txt:
  • plugins/netscape-destroy-plugin-script-objects-expected.txt:
  • plugins/npp-set-window-called-during-destruction-expected.txt:
  • storage/sql-error-codes-expected.txt:
  • storage/statement-error-callback-expected.txt:
  • storage/transaction-callback-exception-crash-expected.txt:
04:06 Changeset [104809] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: performance tests: fix memory leak in first-open-resources test.
https://bugs.webkit.org/show_bug.cgi?id=76049

first-open-resources doesn't reset resource panel properly after test run.

Reviewed by Yury Semikhatsky.

  • inspector/first-open-resources.html:
03:54 Changeset [104808] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: make source urls relative to source map url.
https://bugs.webkit.org/show_bug.cgi?id=75968

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/resources/source-map.json:
03:52 Changeset [104807] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix WebKit build after r104803, by setting ScriptCallStack.h role to private.

  • WebCore.xcodeproj/project.pbxproj:
03:48 Changeset [104806] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Move macro checking to functions' definition in ewk_js.cpp.
https://bugs.webkit.org/show_bug.cgi?id=76037

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-12
Reviewed by Andreas Kling.

Moves macro checking to functions' definition instead of duplicate them in source depending on macro value.
It's known practice in WebKit and EFL port.
Duplicating functions in the same file whose return value is different may confuse user,
especially if macro isn't included in a patch.

  • ewk/ewk_js.cpp:

(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_view_get):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
(ewk_js_variant_array_free):

03:23 BuildingQt5OnHarmattan edited by vestbo@webkit.org
(diff)
03:22 BuildingQt5OnHarmattan edited by vestbo@webkit.org
Update instructions to match latest changes to Qt5 (diff)
03:15 Changeset [104805] by commit-queue@webkit.org
  • 23 edits
    1 copy
    3 adds in trunk

ShadowContentElement should be able to use query.
https://bugs.webkit.org/show_bug.cgi?id=75302

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-12
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

This patch introduces a selector to query elements in ShadowContentElement.
This can be used instead of ShadowContentElement::shouldInclude in more sophisticated ways.

Tests: fast/dom/shadow/shadow-contents-select-expected.html

fast/dom/shadow/shadow-contents-select.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::SelectorDataList):

Extracted from SelectorQueryto share codes with ShadowContentSelectorQuery.

(WebCore::SelectorDataList::initialize):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::queryAll):
(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::canUseIdLookup):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::size):

  • dom/ShadowContentElement.cpp:

(WebCore::selectAttr):
(WebCore::ShadowContentElement::create):
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::select):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Added.

(WebCore::ShadowContentSelectorQuery::ShadowContentSelectorQuery):
(WebCore::ShadowContentSelectorQuery::matches):

Returns true if Node is matched by the query.

  • dom/ShadowContentSelectorQuery.h: Copied from Source/WebCore/dom/ShadowContentElement.h.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):
(WebCore::DetailsContentElement::DetailsContentElement): Re-implemented using query.
(WebCore::DetailsSummaryElement::DetailsSummaryElement): ditto.

  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::SummaryContentElement):

  • testing/Internals.cpp:

(WebCore::Internals::createShadowContentElement):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Tests for ShadowContentElement query.

  • fast/dom/shadow/shadow-contents-select-expected.html: Added.
  • fast/dom/shadow/shadow-contents-select.html: Added.
03:10 Changeset [104804] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Update and show ewk_view with updated webpage.
https://bugs.webkit.org/show_bug.cgi?id=76023

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-12
Reviewed by Andreas Kling.

Update ewk_view with BackingStore image which is rendered webpage
image by WebProcess, and show updated image's area when
PageClientImpl::setViewNeedsDisplay() is called.
The ewk_view_display() function is used to display updated area of
evas_object_image and the ewk_view_image_data_set() function is used
to set evas_object_image's data with rendered webpage.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setViewNeedsDisplay):

  • UIProcess/API/efl/ewk_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_add):
(ewk_view_display):
(ewk_view_image_data_set):

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

02:56 Changeset [104803] by vsevik@chromium.org
  • 603 edits in trunk

Make default console messages line numbers consistent.
https://bugs.webkit.org/show_bug.cgi?id=74075

Reviewed by Pavel Feldman.

Source/WebCore:

Added default values for Console::addMessage sourceURL, lineNumber and
callStack parameters, moved lineNumber after sourceURL.
Made virtual method ScriptExecutionContext::addMessage private
Added default values to ScriptExecutionContext::AddConsoleMessage sourceURL, lineNumber and
callStack parameters, moved lineNumber after sourceURL.
Reorder ScriptExecutionContext::logExceptionToConsole parameters, move lineNumber after sourceURL.
Reordered sourceURL and lineNumber parameters in inspector methods.
Made all calls to Console::addMessage() pass 0 as lineNumber by default (i.e. when line number is unknown / irrelevant).
Unset line numbers are not printed to console in QT now.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::addMessage):

  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::addConsoleMessage):

  • dom/ScriptExecutionContext.h:
  • dom/UIEvent.cpp:

(WebCore::UIEvent::warnDeprecatedLayerXYUsage):

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::printWarningToConsole):

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/ConsoleMessage.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::shouldAllowNavigation):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/Console.cpp:

(WebCore::Console::addMessage):
(WebCore::Console::groupEnd):

  • page/Console.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::printErrorMessage):

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::logErrorMessage):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::postConsoleMessageTask):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):

  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/SharedWorkerContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::logExceptionToConsole):
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::postConsoleMessageTask):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):

Source/WebKit/chromium:

Unset line numbers are not printed to console now.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::addMessageToConsole):

Source/WebKit/qt:

Unset line numbers are not printed to console now.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptConsoleMessage):

Tools:

Unset line numbers are not printed to console now.
Added Source/WebCore/inspector to efl DumpRenderTree include path.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didAddMessageToConsole):

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onConsoleMessage):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewConsoleMessage):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::javaScriptConsoleMessage):

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole):

  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:

(LayoutWebViewEventHandler::OnConsoleMessageEvent):

LayoutTests:

Removed unset line numbers in console messages from test expectations.

  • fast/canvas/svg-taint-expected.txt:
  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/events/init-events-expected.txt:
  • fast/events/mouse-relative-position-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/simulated-click-coords-expected.txt:
  • fast/forms/interactive-validation-prevented-expected.txt:
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt:
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt:
  • fast/xpath/nsresolver-bad-object-expected.txt:
  • http/tests/appcache/local-content-expected.txt:
  • http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt:
  • http/tests/canvas/philip/tests/security.drawImage.image-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.cross-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
  • http/tests/eventsource/eventsource-bad-mime-type-expected.txt:
  • http/tests/eventsource/eventsource-content-type-charset-expected.txt:
  • http/tests/history/cross-origin-replace-history-object-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network/x-frame-options-deny-expected.txt:
  • http/tests/misc/bubble-drag-events-expected.txt:
  • http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/image-blocked-src-change-expected.txt:
  • http/tests/misc/image-blocked-src-no-change-expected.txt:
  • http/tests/misc/unloadable-script-expected.txt:
  • http/tests/plugins/cross-frame-object-access-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt:
  • http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
  • http/tests/security/canvas-remote-read-svg-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt:
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-delete-expected.txt:
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-history-get-expected.txt:
  • http/tests/security/cross-frame-access-history-put-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-put-expected.txt:
  • http/tests/security/cross-frame-access-name-getter-expected.txt:
  • http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt:
  • http/tests/security/cross-frame-access-object-prototype-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-selection-expected.txt:
  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/filesystem-iframe-from-remote-expected.txt:
  • http/tests/security/frame-loading-via-document-write-expected.txt:
  • http/tests/security/frameNavigation/not-opener-expected.txt:
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt:
  • http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt:
  • http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
  • http/tests/security/local-CSS-from-remote-expected.txt:
  • http/tests/security/local-JavaScript-from-remote-expected.txt:
  • http/tests/security/local-iFrame-from-remote-expected.txt:
  • http/tests/security/local-image-from-remote-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-src-from-remote-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt:
  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
  • http/tests/security/postMessage/target-origin-expected.txt:
  • http/tests/security/redirect-BLOCKED-to-localURL-expected.txt:
  • http/tests/security/sandboxed-iframe-modify-self-expected.txt:
  • http/tests/security/sandboxed-iframe-origin-add-expected.txt:
  • http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • http/tests/security/view-source-no-javascript-url-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-hash-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-host-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-hostname-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-pathname-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-protocol-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-reload-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-search-expected.txt:
  • http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt:
  • http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt:
  • http/tests/security/xss-DENIED-frame-name-expected.txt:
  • http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt:
  • http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt:
  • http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
  • http/tests/security/xss-DENIED-javascript-with-spaces-expected.txt:
  • http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
  • http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
  • http/tests/security/xss-DENIED-synchronous-form-expected.txt:
  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt:
  • http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt:
  • http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt:
  • http/tests/security/xss-DENIED-window-open-parent-expected.txt:
  • http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • http/tests/security/xss-DENIED-xsl-document-expected.txt:
  • http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
  • http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/dom-write-URL-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/form-action-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/iframe-injection-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
  • http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt:
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt:
  • http/tests/security/xssAuditor/property-escape-expected.txt:
  • http/tests/security/xssAuditor/property-escape-long-expected.txt:
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
  • http/tests/security/xssAuditor/script-tag-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-handshake-crash-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
  • http/tests/websocket/tests/hixie76/close-before-open-expected.txt:
  • http/tests/websocket/tests/hixie76/frame-length-overflow-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-error-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch-expected.txt:
  • http/tests/websocket/tests/hixie76/long-invalid-header-expected.txt:
  • http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query-expected.txt:
  • http/tests/websocket/tests/hixie76/websocket-event-target-expected.txt:
  • http/tests/websocket/tests/hybi/bad-handshake-crash-expected.txt:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty-expected.txt:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
  • http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
  • http/tests/websocket/tests/hybi/close-before-open-expected.txt:
  • http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • http/tests/websocket/tests/hybi/close-expected.txt:
  • http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-error-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
  • http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
  • http/tests/websocket/tests/hybi/invalid-continuation-expected.txt:
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt:
  • http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt:
  • http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
  • http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt:
  • http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
  • http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • http/tests/websocket/tests/hybi/websocket-event-target-expected.txt:
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
  • http/tests/websocket/tests/hybi/workers/close-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-sync-not-supported-expected.txt:
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
  • http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt:
  • http/tests/xmlhttprequest/cross-origin-no-credential-prompt-expected.txt:
  • http/tests/xmlhttprequest/cross-site-denied-response-expected.txt:
  • http/tests/xmlhttprequest/cross-site-denied-response-sync-2-expected.txt:
  • http/tests/xmlhttprequest/cross-site-denied-response-sync-expected.txt:
  • http/tests/xmlhttprequest/get-dangerous-headers-expected.txt:
  • http/tests/xmlhttprequest/getResponseHeader-expected.txt:
  • http/tests/xmlhttprequest/onerror-event-expected.txt:
  • http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt:
  • http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt:
  • http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt:
  • http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
  • http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
  • jquery/event-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-win/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-non-ascii-expected.txt:
  • platform/chromium-win/websocket/tests/url-parsing-expected.txt:
  • platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt:
  • platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt:
  • platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt:
  • platform/chromium/fast/events/onunload-expected.txt:
  • platform/chromium/fast/events/onunload-not-on-body-expected.txt:
  • platform/chromium/fast/events/onunload-window-property-expected.txt:
  • platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt:
  • platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt:
  • platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt:
  • platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
  • platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt:
  • platform/chromium/http/tests/security/window-named-proto-expected.txt:
  • platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
  • platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • platform/chromium/media/csp-blocks-video-expected.txt:
  • platform/chromium/plugins/document-open-expected.txt:
  • platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/qt/http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
  • platform/qt/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
  • plugins/document-open-expected.txt:
  • plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt:
  • plugins/geturlnotify-during-document-teardown-expected.txt:
  • plugins/netscape-plugin-map-data-to-src-expected.txt:
  • plugins/netscape-plugin-setwindow-size-2-expected.txt:
  • plugins/netscape-plugin-setwindow-size-expected.txt:
  • plugins/no-mime-with-valid-extension-expected.txt:
  • plugins/open-and-close-window-with-plugin-expected.txt:
  • plugins/pass-different-npp-struct-expected.txt:
  • plugins/window-open-expected.txt:
  • storage/open-database-creation-callback-expected.txt:
  • storage/open-database-set-empty-version-expected.txt:
02:22 Changeset [104802] by mihnea@adobe.com
  • 6 edits in trunk/Source/WebCore

Add RenderStyle::isPositioned() helper method
https://bugs.webkit.org/show_bug.cgi?id=75959

Reviewed by Tony Chang.

No new tests since this is refactoring of existing code.

Replace (style()->position() == AbsolutePosition
style()->position() == FixedPosition)

with (style()->isPositioned()).
Replace (style()->position() != AbsolutePosition && style()->position() != FixedPosition)
with (!style()->isPositioned()).

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):
(WebCore::RenderBox::offsetFromContainer):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::isPositioned):

02:17 Changeset [104801] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/test_expectations.txt:
02:08 Changeset [104800] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Network is not available when SOUP is enabled.
https://bugs.webkit.org/show_bug.cgi?id=76112

Reviewed by Andreas Kling.

ecore_main_loop_glib_integrate should be called to use glib based library
such as SOUP.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

01:50 Changeset [104799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Modify some API's implementation to let it directly pass Eina_Rectangle into IntRect.
https://bugs.webkit.org/show_bug.cgi?id=75695

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-12
Reviewed by Andreas Kling.

Dereference Eina_Rectangle pointers so the shorter IntRect constructor can be used.

  • ewk/ewk_view.cpp:

(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
(ewk_view_paint):
(ewk_view_paint_contents):

01:46 Changeset [104798] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add PLATFORM(EFL) in SharedMemory.h, WebProcessStore.h, WebEditorClient.cpp
https://bugs.webkit.org/show_bug.cgi?id=76115

Reviewed by Andreas Kling.

This patch added PLATFORM(EFL) guard in SharedMemory.h to use UNIX_DOMAIN_SOCKETS
and WebProcessStore.h to have font family preference
and WebEditorClient.cpp to use platform specific handleKeyboardEvent(),
handleInputMethodKeydown()

  • Platform/SharedMemory.h:
  • Shared/WebPreferencesStore.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
00:02 Changeset [104797] by pfeldman@chromium.org
  • 3 edits in branches/chromium/963

Merge 104714 - Web Inspector: "undefined" instead of error message in the SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=76060

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.get message):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • inspector/debugger/source-frame-expected.txt:

TBR=pfeldman@chromium.org
BUG=109861
Review URL: http://codereview.chromium.org/9193003

01/11/12:

23:56 Changeset [104796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Rename parameter and variable name 'r' to 'rect' in IntRectEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=76140

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-11
Reviewed by Andreas Kling.

No new tests : Just for change of parameter and variable name.

  • platform/graphics/efl/IntRectEfl.cpp:

(WebCore::IntRect::IntRect):
(WebCore::IntRect::operator Eina_Rectangle):

23:48 Changeset [104795] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Update skipped file for layout test of EFL port.
https://bugs.webkit.org/show_bug.cgi?id=76024

Reviewed by Andreas Kling.

test_expectations.txt for EFL port is now containing list of skipped test cases.
But, I could notice that file 'Skipped' is proper location for the skipped test case.

In addition, some additional test cases are added to Skipped file.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
23:18 Changeset [104794] by mikelawther@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896

Reviewed by Ryosuke Niwa.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
  • css3/calc/block-mask-overlay-image-outset.html: Added.
  • css3/calc/resources/mask.png: Added.
23:14 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
23:07 Changeset [104793] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

QuerySelector should not have side effect.
https://bugs.webkit.org/show_bug.cgi?id=75298

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-11
Reviewed by Antti Koivisto.

Since SelectorChecker is not collecting-rules-only mode, it may set some flags in render styles
if some pseudo types (e.g. first-of-type) are used.

No new tests. Covered by existing tests.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):

Made collecting rules only.

22:58 Changeset [104792] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Web process should use the same locale than UI process
https://bugs.webkit.org/show_bug.cgi?id=76054

Reviewed by Gustavo Noronha Silva.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::childSetupFunction): Make child process use the same
locale than its parent.

22:47 Changeset [104791] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Add WebArrayBuffer support in WebSocket to WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=75080

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-01-11
Reviewed by Darin Fisher.

  • public/WebSocket.h: Add interface to send WebArrayBuffer, and set and get receiving binary object type.
  • public/WebSocketClient.h: Add interface to receive WebArrayBuffer.

(WebKit::WebSocketClient::didReceiveArrayBuffer):

  • src/WebSocketImpl.cpp: Add various binary types handling.

(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::binaryType):
(WebKit::WebSocketImpl::setBinaryType):
(WebKit::WebSocketImpl::sendArrayBuffer):
(WebKit::WebSocketImpl::didReceiveBinaryData):

  • src/WebSocketImpl.h: Add methods to handle various binary types.
22:38 Changeset [104790] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Baseline for new test added in http://trac.webkit.org/changeset/104786

Unreviewed.

  • platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt: Added.
21:52 Changeset [104789] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

21:42 Changeset [104788] by lforschler@apple.com
  • 1 copy in tags/Safari-535.16

New Tag.

20:33 Changeset [104787] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

CodeBlock::m_executeCounter should be renamed to CodeBlock::m_jitExecuteCounter
https://bugs.webkit.org/show_bug.cgi?id=76144
<rdar://problem/10681711>

Rubber stamped by Gavin Barraclough.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

20:29 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
20:29 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
20:28 WebKitEFLLayoutTest created by gyuyoung.kim@samsung.com
20:15 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
20:10 Changeset [104786] by mitz@apple.com
  • 22 edits
    3 adds in trunk

<rdar://problem/10679035> Implement font-variant-ligatures: {no-}common-ligatures
https://bugs.webkit.org/show_bug.cgi?id=76103

Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/css/parsing-font-variant-ligatures.html

fast/text/font-variant-ligatures-expected.html
fast/text/font-variant-ligatures.html

Added support for all font-variant-ligatures values in the style system and in
FontDescription, and made the {no-}common-ligatures value keywords control basic ligatures.
The {no-}{discretionary,historical}-ligatures keywords have no effect on rendering at this
time.

font-variant-ligatures was not made part of the font shorthand property.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added code to handle
font-variant-ligatures.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added code to handle font-variant-ligatures.
(WebCore::CSSParser::parseFontVariantLigatures): Added. Parses font-variant-ligatures.

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Added font-variant-ligatures to the set of
inherited properties.

  • css/CSSPropertyNames.in: Added -webkit-font-variant-ligatures.
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): Added. Copies
{common,discretionary,historical}LigaturesState from the parent style font description.
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): Added. Sets
{common,discretionary,historical}LigaturesState to normal.
(WebCore::ApplyPropertyFontVariantLigatures::applyValue): Added.
(WebCore::ApplyPropertyFontVariantLigatures::createHandler): Added.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added a handler for
font-variant-ligatures.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration): Updated for the number of properties that
affect the font.
(WebCore::CSSStyleSelector::applyProperty): Added CSSPropertyWebkitFontVariantLigatures to
the switch statement, which needs to list all values in SVG-disabled builds.

  • css/CSSValueKeywords.in: Added the value keywords

{no-}{common,discretionary,historical}-ligatures.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Changed to enable ligatures if common ligatures are
enabled in the font description, disable them if they are disabled, and leave them to the
default (determined by the text-rendering property) if they are in the normal state.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Added initializers.
(WebCore::FontDescription::commonLigaturesState): Added this accessor.
(WebCore::FontDescription::discretionaryLigaturesState): Ditto.
(WebCore::FontDescription::historicalLigaturesState): Ditto.
(WebCore::FontDescription::setCommonLigaturesState): Ditto.
(WebCore::FontDescription::setDiscretionaryLigaturesState): Ditto.
(WebCore::FontDescription::setHistoricalLigaturesState): Ditto.
(WebCore::FontDescription::operator==): Updated to compare the ligatures state members.

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/parsing-font-variant-ligatures.html: Added.
  • fast/text/font-variant-ligatures-expected.html: Added.
  • fast/text/font-variant-ligatures.html: Added.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
19:55 Changeset [104785] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Overflow on flexitems doesn't work
https://bugs.webkit.org/show_bug.cgi?id=70979

Reviewed by Ojan Vafai.

Add test cases for flex items that overflow. There should be
non-disabled scrollbars.

  • css3/flexbox/child-overflow-expected.html: Added.
  • css3/flexbox/child-overflow.html: Added.
19:53 Changeset [104784] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Merge 'Getter'/'Setter' attributes into 'Accessor'
https://bugs.webkit.org/show_bug.cgi?id=76141

Reviewed by Filip Pizlo.

These are currently ambiguous (and used inconsistently). It would logically appear
that either being bit set implies that the corresponding type of accessor is present
but (a) we don't correctly enforce this, and (b) this means the attributes would not
be able to distinguish between a data descriptor and an accessor descriptor with
neither a getter nor setter defined (which is a descriptor permissible under the spec).
This ambiguity would lead to unsafe property caching behavior (though this does not
represent an actual current bug, since we are currently unable to create descriptors
that have neither a getter nor setter, it just prevents us from doing so).

  • runtime/Arguments.cpp:

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::JSArray::putDescriptor):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorDefineProperty):

  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
(JSC::PropertyDescriptor::setSetter):
(JSC::PropertyDescriptor::setGetter):
(JSC::PropertyDescriptor::attributesOverridingCurrent):

19:53 Changeset [104783] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

margin test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76000

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/margin-expected.txt: Added.
  • css3/calc/margin.html: Added.
19:46 Changeset [104782] by enne@google.com
  • 5 edits
    3 adds in trunk

Repaint all graphics layers when their renderer offset changes
https://bugs.webkit.org/show_bug.cgi?id=75730

Reviewed by Simon Fraser.

Source/WebCore:

In RenderLayerBacking, only the main graphics layer gets repainted
when the offset changes. If the offset on other graphics layers (e.g.
the foreground layer) changes, they should get repainted as well.

Test: compositing/geometry/foreground-offset-change.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setOffsetFromRenderer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

  • platform/graphics/GraphicsLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

  • compositing/geometry/foreground-offset-change-expected.png: Added.
  • compositing/geometry/foreground-offset-change-expected.txt: Added.
  • compositing/geometry/foreground-offset-change.html: Added.
18:30 Changeset [104781] by dimich@chromium.org
  • 12 edits in trunk/LayoutTests

[Chromium] Rebaseline test images for input controls
after http://src.chromium.org/viewvc/chrome?view=rev&revision=117217
https://bugs.webkit.org/show_bug.cgi?id=76134

Unreviewed.

  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
18:26 Changeset [104780] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] TiledLayerChromium drops invalidates that occur during
LayerTextureUpdater::prepareToUpdate
https://bugs.webkit.org/show_bug.cgi?id=76067

Patch by Scott Violet <sky@google.com> on 2012-01-11
Reviewed by James Robinson.

Source/WebCore:

Test coverage in TiledLayerChromiumTest.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::prepareCount):
(WTF::FakeLayerTextureUpdater::clearPrepareCount):
(WTF::FakeLayerTextureUpdater::lastUpdateRect):
(WTF::FakeTiledLayerChromium::fakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::setRectToInvalidate):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):

18:03 Changeset [104779] by eae@chromium.org
  • 29 edits in branches/subpixellayout/LayoutTests/platform/mac-snowleopard/fast/forms

Updated test expectations for mac for a couple of form tests.

17:57 Changeset [104778] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[JSC] Remove redundant arguments from [Supplemental] custom methods
https://bugs.webkit.org/show_bug.cgi?id=76127

Reviewed by Adam Barth.

Since in JSC a callback of custom methods is non-static, we do not need
to pass a pointer of an implementation object.

Before (JSTestInterface.cpp):

JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
{

JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));
TestInterface* impl = static_cast<TestInterface*>(castedThis->impl());
return castedThis->supplementalStr3(impl, exec);

}

After (JSTestInterface.cpp):

JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
{

JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));

return castedThis->supplementalStr3(exec); JSTestInterface knows 'impl'.

}

Tests: bindings/scripts/test/TestInterface.idl

http/tests/websocket/tests/*
webaudio/*

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Previously when we specify [CustomGetter, CustomSetter], the header for
the custom setter was not generated. This patch fixes the bug.
(GenerateImplementation):

  • bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed redundant DOMWindow* from webkitAudioContext().

(WebCore::JSDOMWindow::webkitAudioContext):

  • bindings/js/JSDOMWindowWebSocketCustom.cpp: Removed redundant DOMWindow* from webSocket().

(WebCore::JSDOMWindow::webSocket):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.

(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalStr3):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
17:30 Changeset [104777] by barraclough@apple.com
  • 5 edits in trunk

Object.defineProperty([], 'length', {}) should not make length read-only
https://bugs.webkit.org/show_bug.cgi?id=76097

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • We should be checking writablePresent().

LayoutTests:

  • fast/js/array-defineOwnProperty-expected.txt:
  • fast/js/script-tests/array-defineOwnProperty.js:
    • Added test.
17:29 Changeset [104776] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Share cairo specific codes with EFL port.
https://bugs.webkit.org/show_bug.cgi?id=75457

Reviewed by Brent Fulgham.

Change PLATFORM(GTK) to USE(CAIRO) in WebGraphicsContext{h,cpp} to share
with EFL port.

  • Shared/WebGraphicsContext.cpp:

(WebKit::WebGraphicsContext::WebGraphicsContext):

  • Shared/WebGraphicsContext.h:
17:24 Changeset [104775] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
https://bugs.webkit.org/show_bug.cgi?id=76120

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/forms/no-autofocus-in-sandbox.html

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • The HTML5 spec says that we shouldn't autofocus elements when the automatic features are sandboxed.

LayoutTests:

  • fast/forms/no-autofocus-in-sandbox-expected.txt: Added.
  • fast/forms/no-autofocus-in-sandbox.html: Added.
17:23 Changeset [104774] by fpizlo@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Code duplication for invoking the JIT and DFG should be reduced
https://bugs.webkit.org/show_bug.cgi?id=76117
<rdar://problem/10680189>

Rubber stamped by Geoff Garen.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITDriver.h: Added.

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

17:17 Changeset [104773] by bdakin@apple.com
  • 9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=75904
WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all
the time
-and corresponding-
<rdar://problem/10498816>

Reviewed by Darin Adler.

Source/WebCore:

This patch gets rid of the optional parameter called onlyUpdateScrollbars for
mouseMoved() and instead moves that functionality into its own function
called passMouseMovedEventToScrollbars().

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::passMouseMovedEventToScrollbars):

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseMovedEventToScrollbars):

Source/WebKit/mac:

New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we
have one.

  • WebView/WebHTMLView.mm:

(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLViewPrivate clear]):

When we know that mouse movements won't affect anything other than
scrollbars, call our new function passMouseMovedEventToScrollbars(),
otherwise we'll call the old mouseMoved().
(mouseEventIsPartOfClickOrDrag):
(-[WebHTMLView _updateMouseoverWithEvent:]):

Make sure not to remove the mouse observer when there are legacy scrollbars.
(-[WebHTMLView removeMouseMovedObserver]):

Set up a tracking area when the window is not key to ensure that the WebView
gets the relevant events. Remove it when the window is key again so that we
rely on the existing mechanism.
(-[WebHTMLView windowDidBecomeKey:]):
(-[WebHTMLView windowDidResignKey:]):

Source/WebKit2:

This patch gets rid of the optional parameter called onlyUpdateScrollbars for
WebCore::EventHandler::mouseMoved() and instead moves that functionality into
its own function called passMouseMovedEventToScrollbars().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

17:17 WebKit Team edited by haraken@chromium.org
(diff)
17:15 Changeset [104772] by kbr@google.com
  • 2 edits
    2 copies in branches/chromium/963

Merge 104736 - [v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-11
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/9186030

17:02 Changeset [104771] by commit-queue@webkit.org
  • 18 edits in trunk

IndexedDB: Methods should throw TRANSACTION_INACTIVE_ERR when transaction is completed/aborted
https://bugs.webkit.org/show_bug.cgi?id=76108

Source/WebCore:

Updated IDBDatabaseException error codes to match spec (the pre-DOM4 version),
including updated description strings, and changed relevant store and index
methods to raise the expected exception type now that it is detailed in the spec.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-11
Reviewed by Tony Chang.

Tests: storage/indexeddb/transaction-basics.html

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):

  • storage/IDBDatabaseException.cpp:
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::count):

LayoutTests:

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-11
Reviewed by Tony Chang.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
17:00 Changeset [104770] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Bytecode dumping is broken for call opcodes (due to two new operands)
https://bugs.webkit.org/show_bug.cgi?id=75886

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp): Made a helper function, so I wouldn't have
to fix this more than once. The helper function skips the extra two operands
at the end of the opcode, used for optimization.

(JSC::CodeBlock::dump): Used the helper function.

  • bytecode/CodeBlock.h: Declared the helper function.
17:00 Changeset [104769] by kbr@google.com
  • 1 edit
    3 copies in branches/chromium/963

Merge 104732 - [chromium] Color profiles are incorrect for images without premultiplied alpha
https://bugs.webkit.org/show_bug.cgi?id=75999

Reviewed by Stephen White.

Source/WebCore:

Don't apply the color profile if the user has requested separate alpha.

Test: fast/canvas/webgl/texture-color-profile.html

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::setStatus):

LayoutTests:

Verify that the image's contents don't get destroyed if using both
separate alpha as well as the browser's colorspace conversion.

  • fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
  • fast/canvas/webgl/texture-color-profile-expected.txt: Added.
  • fast/canvas/webgl/texture-color-profile.html: Added.

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/9187038

16:58 Changeset [104768] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: push more logic into webkitpy.test.main, clean up code
https://bugs.webkit.org/show_bug.cgi?id=76021

Reviewed by Eric Seidel.

I plan to add more functionality to test-webkitpy, but it is
difficult to hack on now; this patch is the first of two that
brings test-webkitpy more inline with current coding style by
pushing more logic into the webkitpy.test.main.Tester class (so
that it will be testable itself).

There should be no functional changes in this patch.

  • Scripts/test-webkitpy:

(_path_from_webkit_root):

  • Scripts/webkitpy/test/main.py:

(Tester):
(Tester.init):
(Tester.configure_logging):
(Tester.configure_logging.filter):
(Tester.clean_packages):
(Tester.run_tests):

16:56 Changeset [104767] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

Implement the [Supplemental] IDL for custom methods
https://bugs.webkit.org/show_bug.cgi?id=76036

Reviewed by Adam Barth.

We have implemented the [Supplemental] IDL for non-custom methods in bug 75944.
This patch implements it for custom methods. This patch modifies only CodeGeneratorV8.pm,
since CodeGeneratorJS.pm requires no change and other code generators
do not support custom methods.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/TestSupplemental.idl: Added a custom method with the [Supplemental] IDL.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.

(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface supplementalMethod3]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
16:51 Changeset [104766] by leviw@chromium.org
  • 8 edits in branches/subpixellayout/LayoutTests

Updating and rebaselining remaining failing fast/dom tests.

16:48 Changeset [104765] by kbr@google.com
  • 1 edit in branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

Merge 104636 - [chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912

Patch by John Bauman <jbauman@chromium.org> on 2012-01-10
Reviewed by Kenneth Russell.

Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.

No new tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::maybeRestoreContext):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/9148050

16:26 Changeset [104764] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

implement layout tests for <video> with media stream
https://bugs.webkit.org/show_bug.cgi?id=74882

Patch by Wei Jia <wjia@chromium.org> on 2012-01-11
Reviewed by Kent Tamura.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.

(WebKit::WebUserMediaClientMock::create):
(WebKit::WebUserMediaClientMock::IsMockStream):
(WebKit::WebUserMediaClientMock::requestUserMedia):
(WebKit::WebUserMediaClientMock::cancelUserMediaRequest):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.

(WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebKit::WebUserMediaClientMock::WebUserMediaClientMock):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::userMediaClient):
(WebViewHost::userMediaClientMock):
(WebViewHost::createMediaPlayer):
(WebViewHost::mediaStreamUtil):
(WebViewHost::testMediaStreamClient):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • platform/chromium/media/video-capture-preview-expected.txt: Added.
  • platform/chromium/media/video-capture-preview.html: Added.
16:24 Changeset [104763] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, build fix.

Fix chromium-win's version remapping to work correctly on Win 7 SP1.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):

16:14 Changeset [104762] by ggaren@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
https://bugs.webkit.org/show_bug.cgi?id=75911

Source/JavaScriptCore:

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNodeForLeftHandSide): Cleanup: No need to
explicitly cast to our return type in C++.

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode): Make sure to copy our function
into a temporary register before evaluating our arguments, since argument
evaluation might include function calls or assignments that overwrite our callee by name.

LayoutTests:

Reviewed by Filip Pizlo.

  • fast/js/function-argument-evaluation-expected.txt: Added.
  • fast/js/function-argument-evaluation.html: Added.
16:08 Changeset [104761] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable
https://bugs.webkit.org/show_bug.cgi?id=76085

Reviewed by Eric Seidel.

As far as I can tell, the IETC test of this feature is wrong.
NETWORK_NO_SOURCE should be immutable on the interface object and on
the interface prototype object, but JavaScript should be able to shadow
the property on an instance.

  • media/network-no-source-const-shadow-expected.txt: Added.
  • media/network-no-source-const-shadow.html: Added.
16:07 Changeset [104760] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Sheriffbot build fix. Don't emit empty lines on IRC.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(LastGreenRevision.execute):

16:02 Changeset [104759] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r88479.

15:57 Changeset [104758] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix build issue on Windows when Qt is configured with -ltcg

https://bugs.webkit.org/show_bug.cgi?id=75003

Patch by Shaw Andy <andy.shaw@digia.com> on 2011-12-21
Rubber-stamped by Simon Hausmann.

  • WebCore.pri:
15:56 Changeset [104757] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Eric Seidel.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintTextField):

LayoutTests: iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
https://bugs.webkit.org/show_bug.cgi?id=76111

Reviewed by Eric Seidel.

Test based on video-no-autoplay.html.

  • media/no-auto-play-in-sandbox-expected.txt: Added.
  • media/no-auto-play-in-sandbox.html: Added.
  • media/resources/no-auto-play-in-sandbox-iframe.html: Added.
15:54 Changeset [104756] by japhet@chromium.org
  • 6 edits in trunk/Source/WebCore

SubresourceLoader cleanup post r100311.

  1. Simplify matching incrementRequestCount()/decrementRequestCount() calls.
  2. Remove CachedImage custom code from SubresourceLoader.
  3. Add a bunch of ASSERTs.
  4. Remove the multipart-only call to didReceiveData() from didReceiveResponse(), since didReceiveData() would get called immediately after anyway.

https://bugs.webkit.org/show_bug.cgi?id=75887

Reviewed by Adam Barth.

No new tests, refactor only.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Remove multipart special case, handle it in didReceiveData().
(WebCore::SubresourceLoader::didReceiveData): Handle multipart state here, since we will receive only one

didReceiveData() call per multipart segment, but no didFinishLoading() call.

  • loader/SubresourceLoader.h: Add a RequestCountTracker subclass to reduce complexity of ensuring we don't

decrement request count twice on CachedResourceLoader.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::setResponse): Move CachedImage::clear() call out of SubresourceLoader, since it's

kind of a layering violation as is.

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
15:51 Changeset [104755] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

IndexedDB: Version change transaction should abort if constraints fail during createIndex
https://bugs.webkit.org/show_bug.cgi?id=76094

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-11
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/index-population.html

  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):

  • storage/IDBObjectStoreBackendImpl.cpp:

LayoutTests:

  • storage/indexeddb/index-population-expected.txt: Added.
  • storage/indexeddb/index-population.html: Added.
15:46 Changeset [104754] by rniwa@webkit.org
  • 7 edits in trunk/Tools

last-green-revision should report the revision that succeeded on all bots
https://bugs.webkit.org/show_bug.cgi?id=76109

Reviewed by Adam Barth.

Add an algorithm to find the last known good revision among the specified bots. For a revision to be
considered green by this algorithm, all matching builders must have a successful run at the revision
or two consecutive successful runs before and after the revision.

Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
that resulted in an exception when the user didn't pass BUILDER_NAME argument.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._revisions_for_builder):
(BuildBot):
(BuildBot._find_green_revision):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_revisions_for_builder):
(test_find_green_revision):
(test_last_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(LastGreenRevision.execute):

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_lgr):

  • Scripts/webkitpy/tool/commands/queries.py:

(LastGreenRevision):

15:42 Changeset [104753] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, fix build bustage on win32 introduced by r104725.

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockChromiumDRTTest.test_pixeltestfails):

15:27 Changeset [104752] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

line height test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75998

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/line-height-expected.txt: Added.
  • css3/calc/line-height.html: Added.
15:27 Changeset [104751] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

v8-regexp spends 35% of its time allocating and copying internal regexp results data
https://bugs.webkit.org/show_bug.cgi?id=76079

Reviewed by Geoffrey Garen.

Added a new RegExpResults struct that has the input string, the number of
subexpressions and the output vector. Changed RegExpConstructor to
include a RegExpConstructorPrivate instead of having a reference to one.
Changed RegExpMatchesArray to include a RegExpResults instead of a
reference to a RegExpConstructorPrivate. Created an overloaded assignment
operator to assign a RegExpConstructorPrivate to a RegExpResults.
Collectively this change is worth 24% performance improvement to v8-regexp.

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpResult::operator=):
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):
(JSC::RegExpMatchesArray::~RegExpMatchesArray):
(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::arrayOfMatches):
(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):
(JSC::RegExpConstructor::setInput):
(JSC::RegExpConstructor::input):
(JSC::RegExpConstructor::setMultiline):
(JSC::RegExpConstructor::multiline):

  • runtime/RegExpConstructor.h:

(JSC::RegExpResult::RegExpResult):
(JSC::RegExpConstructor::performMatch):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):

15:15 Changeset [104750] by commit-queue@webkit.org
  • 4 edits in trunk

Typo in error message: Unexpected token 'defualt'
https://bugs.webkit.org/show_bug.cgi?id=75105

Patch by Eugene Girard <girard@google.com> on 2012-01-11
Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • parser/Parser.h:

(JSC::Parser::getTokenName):

LayoutTests:

  • fast/js/reserved-words-as-property-expected.txt:
15:04 Changeset [104749] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix duplicate expectations from r104715.
This was causing the Chromium Windows tests not to run.

  • platform/chromium/test_expectations.txt:
14:44 Changeset [104748] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

Switch web intents to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76092

Patch by Greg Billock <gbillock@google.com> on 2012-01-11
Reviewed by Adam Barth.

  • Modules/intents/DOMWindowIntents.idl: Added.
  • WebCore.gypi:
  • page/DOMWindow.idl:
14:35 Changeset [104747] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

Rename HTMLInputElement::setDefaultName to setInitialName.
https://bugs.webkit.org/show_bug.cgi?id=76039

Reviewed by Darin Adler.

Source/WebCore:

Rename setDefaultName to setInitialName, make it protected, and add two
assertions.

This change should not change any behavior.

Test: fast/forms/isindex-name.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setInitialName):

  • Renamed from setDefaultName.
  • Add assertions.
  • html/HTMLInputElement.h:

Rename setDefaultName to setInitialName, and move it to protected.

  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
Update a setDefaultName callsite.
(WebCore::HTMLIsIndexElement::parseMappedAttribute):
A style fix.

LayoutTests:

  • fast/forms/isindex-name-expected.txt: Added.
  • fast/forms/isindex-name.html: Added.
14:13 Changeset [104746] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=76088
The common case of content type = text/plain is not optimized and the plugin database is initialized instead

In the dom/DOMImplementation.cpp file you can find the comment that text/plain is
optimized so that the plugin database is not loaded. Unfortunately, this has been
regressed since the patch for http://bugs.webkit.org/show_bug.cgi?id=16815 which
refactored a bunch of the plugin code. Now, the plugin database is initialized
before we handle text/plain. This line in DOMImplementation.cpp triggers
the plugin initialization:

pluginData = frame->page()->pluginData();

The case of image types != PDF and the case of HTML5 video content type are also
not optimized to be handled before plugin initialization.

The solution is to refactor so all of these content types are handled before
we initialize the plugin database.

Patch by Adam Treat <atreat@rim.com> on 2012-01-11
Reviewed by Adam Treat.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

14:10 Changeset [104745] by jochen@chromium.org
  • 2 edits in trunk/Tools

[Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
https://bugs.webkit.org/show_bug.cgi?id=75618

Eventually, we should get away from setting the display's color profile, as the mac port is doing now.

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestHelper.mm:

(installLayoutTestColorProfile):
(restoreUserColorProfile):
(main):

14:01 Changeset [104744] by andersca@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Assertion failure in JSC::allocateCell trying to allocate a JSString
https://bugs.webkit.org/show_bug.cgi?id=76101

Reviewed by Adam Roben.

Remove the ExecutableBase::s_info and JSString::s_info static member variables from the .def file and
export them explicitly using the JS_EXPORTDATA macro.

member variables explicitly using

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Executable.h:
  • runtime/JSString.h:
13:52 Changeset [104743] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build correction.

  • UIProcess/WebPageProxy.h: Don't define viewWidget for WinCairo port.
13:52 Changeset [104742] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[chromium] Make Skia canvas opaque for root layer tiles
https://bugs.webkit.org/show_bug.cgi?id=75939

Patch by Alexandre Elias <aelias@google.com> on 2012-01-11
Reviewed by James Robinson.

Skia has extra optimizations if a bitmap has the "opaque" flag -- in
particular, it doesn't do an unnecessary memset at creation time.
Pass down the LayerChromium's opaque flag to Skia.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::setIsNonCompositedContent):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::setIsNonCompositedContent):

  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::PlatformCanvas):
(WebCore::PlatformCanvas::resize):

  • platform/graphics/chromium/PlatformCanvas.h:

(WebCore::PlatformCanvas::setOpaque):
(WebCore::PlatformCanvas::opaque):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setIsNonCompositedContent):

13:43 Changeset [104741] by eae@chromium.org
  • 1713 edits
    790 copies
    182 deletes in branches/subpixellayout

Merging trunk changes up until 104725 into subpixel branch.

13:42 Changeset [104740] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy: fix -v and eliminate some spurious warnings
https://bugs.webkit.org/show_bug.cgi?id=76099

Reviewed by Adam Barth.

when we added support for --xml output, we broke the -v flag.

Also, fix the code to swallow a harmless warning from
VCSUtils.pm and fix a deprecated warning in jsonchecker.py.

test-webkitpy is now silent again except for the one known
logging issue.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit):

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(test_commit_message_for_this_commit):

  • Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONChecker.check):
(JSONChecker.line_number_from_json_exception):

  • Scripts/webkitpy/test/main.py:

(Tester.run_tests):

13:36 Changeset [104739] by dpranke@chromium.org
  • 8 edits in trunk/Tools

webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
https://bugs.webkit.org/show_bug.cgi?id=76084

Reviewed by Adam Barth.

This will help make it easier to catch layering violations. This
change just refactors test code; there are no changes to
production code.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.make_port):
(PortTest.test_find_no_paths_specified):
(PortTest.test_find_one_test):
(PortTest.test_find_glob):
(PortTest.test_find_with_skipped_directories):
(PortTest.test_find_with_skipped_directories_2):
(PortTest.test_parse_reftest_list):
(PortTest.test_httpd_returns_error_code):
(PortTest.test_virtual_methods):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest._assert_baseline_path):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths.test_paths):
(ChromiumGpuTest.test_test_files):
(ChromiumGpuTest.test_test_files.test_paths):
(ChromiumGpuTest):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_check_illegal_port_names):
(ChromiumLinuxPortTest.test_determine_architecture_fails):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.make_port):
(DriverTest):
(DriverTest.assertVirtual):
(DriverTest._assert_wrapper):
(DriverTest.test_virtual_driver_methods):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockDRTPortTest.test_port_name_in_constructor):
(MockDRTTest.assertTest):
(MockDRTTest.test_main):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(WebKitPortUnitTests.test_default_options):
(test_runtime_feature_list):
(test_test_expectations):

13:23 Changeset [104738] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[BlackBerry] ASSERT failure in BackingStorePrivate::blitVisibleContents()
https://bugs.webkit.org/show_bug.cgi?id=76096

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-01-11
Reviewed by Rob Buis.

We shouldn't blit visible contents for direct rendering. Guard it from
call sites.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):

13:12 Changeset [104737] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Webaudio layout tests need to override the WebKitWebAudioEnabled
https://bugs.webkit.org/show_bug.cgi?id=76066

Patch by Raymond Toy <rtoy@google.com> on 2012-01-11
Reviewed by Tony Chang.

  • webaudio/convolution-mono-mono.html:

Load audio-testing.js to add override for WebKitWebAudioEnabled.

13:06 Changeset [104736] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-11
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
12:55 Changeset [104735] by ojan@chromium.org
  • 3 edits in trunk/Tools

Style skipped tests in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=76091

Reviewed by Tony Chang.

  • TestResultServer/static-dashboards/dashboard_base.js:

Removed "FLAKY" from this list since we don't ever mark individual runs
as flaky. Also deleted an outdated line.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
12:41 Changeset [104734] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Coverity] Address some uninit constructor issues in WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=74977

Patch by Greg Billock <gbillock@google.com> on 2012-01-11
Reviewed by Ryosuke Niwa.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):

  • dom/DeviceMotionData.cpp:

(WebCore::DeviceMotionData::DeviceMotionData):

  • dom/DeviceOrientation.cpp:

(WebCore::DeviceOrientation::DeviceOrientation):

12:38 Changeset [104733] by ojan@chromium.org
  • 3 edits in trunk/Tools

Remove gtest normalization code from the test results server
https://bugs.webkit.org/show_bug.cgi?id=76089

Reviewed by Tony Chang.

The normalization now happens on the gtest side.

  • TestResultServer/model/jsonresults.py:

(JsonResults.merge):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_gtest):

12:17 Changeset [104732] by kbr@google.com
  • 3 edits
    3 adds in trunk

[chromium] Color profiles are incorrect for images without premultiplied alpha
https://bugs.webkit.org/show_bug.cgi?id=75999

Reviewed by Stephen White.

Source/WebCore:

Don't apply the color profile if the user has requested separate alpha.

Test: fast/canvas/webgl/texture-color-profile.html

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::setStatus):

LayoutTests:

Verify that the image's contents don't get destroyed if using both
separate alpha as well as the browser's colorspace conversion.

  • fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
  • fast/canvas/webgl/texture-color-profile-expected.txt: Added.
  • fast/canvas/webgl/texture-color-profile.html: Added.
12:01 Changeset [104731] by ojan@chromium.org
  • 3 edits in trunk/Tools

Be more aggressive about deleting unnecessary results from the test-results-server json files
https://bugs.webkit.org/show_bug.cgi?id=76086

Reviewed by Tony Chang.

Remove any tests that only contain skip/pass/nodata values whose runtime
is less than 5 seconds.

  • TestResultServer/model/jsonresults.py:

(JsonResults._normalize_results_json):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_remove_test):
(JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):

11:57 Changeset [104730] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

Rounding accumulatedOffset in nodeAtPoint when entering an SVG context to properly align to the root's actual rendering area

11:53 Changeset [104729] by rniwa@webkit.org
  • 7 edits in trunk/Tools

last-green-revision should give us per-bot information
https://bugs.webkit.org/show_bug.cgi?id=76011

Reviewed by Adam Barth.

Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
we report the latest green run on each bot from the last 100 runs.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._fetch_builder_page):
(BuildBot):
(BuildBot._green_revision_for_builder):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_green_revision_for_builder):
(test_last_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(LastGreenRevision.execute):

  • Scripts/webkitpy/tool/commands/queries.py:

(LastGreenRevision.execute):

11:49 Changeset [104728] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][Texmap] LayoutTests/compositing/masks/masked-ancestor does not render correctly.
https://bugs.webkit.org/show_bug.cgi?id=75910

Reviewed by Simon Hausmann.

Handle the mask surface correctly when drawing in two passes. Also, improve the readability
of the code that decides whether to draw in two passes.

LayoutTests/compositing/masks/masked-ancestor.html tests this.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::hasMoreThanOneTile):
(WebCore::TextureMapperNode::paintRecursive):

  • platform/graphics/texmap/TextureMapperNode.h:
11:38 Changeset [104727] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Webpages flash white when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=76080
<rdar://problem/9893565>

Reviewed by Dan Bernstein.

Introduce a _windowHasValidBackingStore boolean and only paint the background (white or clear)
if it's false.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
Set _windowHasValidBackingStore to false if the new size is different from the old size.

(-[WKView viewDidMoveToWindow]):
Set _windowHasValidBackingStore to false.

(-[WKView _windowDidMiniaturize:]):
Set _windowHasValidBackingStore to false.

(-[WKView _windowDidChangeBackingProperties:]):
Set _windowHasValidBackingStore to false.

(-[WKView drawRect:]):
Only call drawPageBackground if _windowHasValidBackingStore is false. Set it to true after painting.

11:37 Changeset [104726] by dimich@chromium.org
  • 2 edits in trunk/Source/WebCore

Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to fix compile error.
https://bugs.webkit.org/show_bug.cgi?id=76081

Reviewed by David Levin.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

11:26 Changeset [104725] by dpranke@chromium.org
  • 18 edits in trunk/Tools

webkitpy: clean up version detection in webkitpy.layout_tests.port
https://bugs.webkit.org/show_bug.cgi?id=76016

Reviewed by Adam Barth.

This change updates the code in webkitpy.layout_tests.port to
use the new os_name and os_version fields on host.platform. This
gets layout_tests.port out of the version parsing business. Most
of the diffs are just cleaning up test code to accomodate the
changes.

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive):
(MockExecutive.ignore_error):
(MockExecutive2):
(MockExecutive2.ignore_error):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_mac):
(MockPlatformInfo.is_linux):
(MockPlatformInfo.is_win):

  • Scripts/webkitpy/common/system/systemhost_mock.py:

(MockSystemHost.init):

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):
(ChromiumMacPort.check_wdiff):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest):
(ChromiumMacPortTest.assert_name):
(ChromiumMacPortTest.test_versions):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):
(ChromiumPortTest.TestMacPort.init):
(ChromiumPortTest.TestLinuxPort.init):
(ChromiumPortTest.TestWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest):
(ChromiumWinTest.assert_name):
(ChromiumWinTest.test_versions):
(ChromiumWinTest.test_baseline_path):
(ChromiumWinTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest):
(FactoryTest.setUp):
(FactoryTest.assert_port):
(FactoryTest.test_mac):
(FactoryTest.test_win):
(FactoryTest.test_google_chrome):
(FactoryTest.test_gtk):
(FactoryTest.test_qt):
(FactoryTest.test_chromium_gpu):
(FactoryTest.test_chromium_gpu_linux):
(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_gpu_win):
(FactoryTest.test_chromium_mac):
(FactoryTest.test_chromium_linux):
(FactoryTest.test_chromium_win):
(FactoryTest.test_unknown_specified):
(FactoryTest.test_unknown_default):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(TestGoogleChromePort):
(TestGoogleChromePort._verify_baseline_path):
(TestGoogleChromePort._verify_expectations_overrides):
(TestGoogleChromePort.test_get_google_chrome_port):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest):
(assert_name):
(test_tests_for_other_platforms):
(test_version):
(test_versions):
(test_is_version_methods):
(test_setup_environ_for_server):
(_assert_search_path):
(test_show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest):
(WinPortTest.test_show_results_html_file):
(WinPortTest._assert_search_path):
(WinPortTest._assert_version):

10:59 Changeset [104724] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Mac GCC build.

Work around the fact that GCC doesn't work very well with Blocks and C++ objets.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::dispatchFunctionOnQueue):
(WebKit::WebProcessProxy::secItemRequest):
(WebKit::WebProcessProxy::secKeychainItemRequest):

10:36 Changeset [104723] by ap@apple.com
  • 6 edits in trunk/Source/WebCore

Reviewed by Darin Adler. Prepared by Sheriff Bot. Rolling out r94902.
http://trac.webkit.org/changeset/94902
https://bugs.webkit.org/show_bug.cgi?id=75905

Disagrees with general direction for WebKit, and makes
refactoring harder (Requested by ap on #webkit).

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::deprecatedFrameEncoding):
  • loader/DocumentWriter.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
  • platform/network/ResourceRequestBase.h:
10:32 Changeset [104722] by efidler@rim.com
  • 6 edits in trunk

Fix OpenGL dependency in CMake build system
https://bugs.webkit.org/show_bug.cgi?id=73559

Reviewed by Daniel Bates.

.:

Apparently the EFL port uses desktop OpenGL to implement WebGL, but
other ports such as BlackBerry use other libraries like OpenGL ES 2.0 or
ANGLE.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformEfl.cmake:
10:17 Changeset [104721] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for RenderBoxRegionInfo map in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=75348

Reviewed by Darin Adler.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegions): use OwnPtr.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo): use HashMap::add() instead of
get() potentially followed by set().
(WebCore::RenderRegion::takeRenderBoxRegionInfo): change to return PassOwnPtr.
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo):

  • rendering/RenderRegion.h:
10:06 Changeset [104720] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Directly-composited images sometimes appear with a wrong geometry
https://bugs.webkit.org/show_bug.cgi?id=75882

Reviewed by Simon Hausmann.

When assigning a directly composited image to a TextureMapperNode in WebKit2, we take
contentsRect() onto account. However, contentsRect() might be changed after the image
is already assigned.
We have to reassign the image when contentsRect() changes. This is a pretty cheap
operation, since the image is already converted to a texture and we simply change the
geometric values.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

09:54 Changeset [104719] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Implement setCurrentTime() and pauseAnimations() on SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=12073

Patch by Joel Webber <jgw@google.com> on 2012-01-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adds the ability to reset an SVGSMILElement internally. SVGSMILElements are no longer removed
from their containers when they become inactive, because they sometimes have to be reactivated
when the container's current time is changed.

Test: svg/animations/animate-setcurrenttime.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentTime):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::pause):
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::reset):

  • svg/animation/SVGSMILElement.h:

LayoutTests:

  • platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.png: Added.
  • platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.txt: Added.
  • svg/animations/animate-setcurrenttime.svg: Added.
09:49 Changeset [104718] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Remove workaround introduced into bug 75470
https://bugs.webkit.org/show_bug.cgi?id=75889

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-01-11
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
09:40 Changeset [104717] by dslomov@google.com
  • 6 edits
    1 delete in trunk

[Chromium] Remove obsolete references to WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76020

Reviewed by David Levin.

Source/WebKit/chromium:

  • public/WebFrameClient.h:
  • public/WebSharedWorkerClient.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h: Removed.
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
09:36 Changeset [104716] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
https://bugs.webkit.org/show_bug.cgi?id=76062

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-11
Reviewed by Yury Semikhatsky.

This only changes how constants are named in generated .h file.

  • inspector/CodeGeneratorInspector.py:
09:19 Changeset [104715] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r103130) - svg/W3C-SVG-1.1/animate-elem-*-t.svg asserting
https://bugs.webkit.org/show_bug.cgi?id=74788

Unreviewed chromium expectations update, pending a real fix.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-11

  • platform/chromium/test_expectations.txt: Added animate-elem-60-t.svg linux debug flakey crash
08:35 Changeset [104714] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: "undefined" instead of error message in the SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=76060

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.get message):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • inspector/debugger/source-frame-expected.txt:
08:18 Changeset [104713] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: make setOuterHTML use new DOMEditor, cover it with tests.
https://bugs.webkit.org/show_bug.cgi?id=76056

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::Digest::Digest):
(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchHTMLElement):
(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::createDigest):

  • inspector/DOMEditor.h:
  • inspector/Inspector-0.1.json:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype._renumber):

  • inspector/front-end/ElementsTreeOutline.js:

():

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/set-outer-html-expected.txt: Added.
  • inspector/elements/set-outer-html.html: Added.
07:49 Changeset [104712] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] css3/filters/should-not-have-compositing-layer.html is failing since added in 104622
https://bugs.webkit.org/show_bug.cgi?id=76061

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failig test.
07:16 Changeset [104711] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=42197

Unreviewed gardening.

Skip new dependent tests.

  • platform/wk2/Skipped:
07:14 Changeset [104710] by apavlov@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: introduce "source" column in the CSS profiler.
https://bugs.webkit.org/show_bug.cgi?id=75378

Reviewed by Pavel Feldman.

Rules are no longer merged by their selectors but are shown one per profile entry, with a link to
their selector in the source whenever the latter is available.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::RuleMatchingStats::RuleMatchingStats):
(WebCore::SelectorProfile::makeKey):
(WebCore::SelectorProfile::startSelector):
(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::finalURL):
(WebCore::InspectorStyleSheet::setRuleSelector):

  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
(WebInspector.CSSSelectorDataGridNode.prototype.createCell):
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.sourceComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.sidebarResized):

  • inspector/front-end/dataGrid.css:

(.data-grid:focus tr.selected a):

06:58 Changeset [104709] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Add the editor rect to the EditorState https://bugs.webkit.org/show_bug.cgi?id=76053

Reviewed by Simon Hausmann.

Also rename some members to match the new Qt naming scheme.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

06:33 Changeset [104708] by ossy@webkit.org
  • 4 edits in trunk

[Qt] Some css3 filter tests are failing after r104698
https://bugs.webkit.org/show_bug.cgi?id=76055

Reviewed by Simon Hausmann.

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.

LayoutTests:

  • platform/qt/Skipped: Unskip now passing tests.
06:17 Changeset [104707] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate enum types.
https://bugs.webkit.org/show_bug.cgi?id=74954

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-11
Reviewed by Yury Semikhatsky.

Internal map of string contants is created. C enums are created for
each JSON enum.

  • inspector/CodeGeneratorInspector.py:

(EnumConstants.add_constant):
(EnumConstants):
(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(get_in_c_type_text):
(get_setter_value_expression_pattern):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding.get_setter_value_expression_pattern):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(get_annotated_type_text):
(MethodGenerateModes.get_modes):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.StrictParameterMode):
(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode):
(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(MethodGenerateModes):
(MethodGenerateModes.CombinedMode):
(MethodGenerateModes.CombinedMode.get_setter_value_expression):

05:54 Changeset [104706] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Linking of big binaries should be serialized to avoid thrashing
https://bugs.webkit.org/show_bug.cgi?id=75977

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-11
Reviewed by Martin Robinson.

Added artificial dependencies so that libwebkitgtk is always
linked first, libwebkit2gtk second, and WebKitPluginProcess
last. Automake unfortunately replaces the whole rule used to build
the libraries if the actual name is used to add the dependency, so
we use helper variables to work around that.

  • GNUmakefile.am:
05:50 Changeset [104705] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=75908

Reviewed by Darin Adler.

There's no benefit in explicit allocating RenderRegionRange in the heap. So this
patch changes the RenderRegionRangeMap to use the value type directly instead of
the pointer.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderFlowThread.h: add default constructor to act as emptyValue()

for HashMap.

05:47 Changeset [104704] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Some css3 filter tests are failing after r104698
https://bugs.webkit.org/show_bug.cgi?id=76055

Unreviewed gardening.

  • platform/qt/Skipped:
05:38 Changeset [104703] by achicu@adobe.com
  • 1 edit in trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp

2012-01-11 Alexandru Chiculita <achicu@adobe.com>

Unreviewd build fix after http://trac.webkit.org/changeset/104702.

Moving the FilterEffectRenderer::updateBackingStore outside the ENABLE(CSS_SHADERS) block.

  • rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::notifyCustomFilterProgramLoaded):
05:24 Changeset [104702] by achicu@adobe.com
  • 14 edits
    1 move
    10 adds in trunk

[CSS Shaders] Move CustomFilterOperation to the platform layer
https://bugs.webkit.org/show_bug.cgi?id=74652

Reviewed by Chris Marrin.

Source/WebCore:

FilterOperations are now part of the platform code and cannot reference style classes directly, but
CustomFilterOperation requires to link to the CachedShader for the vertex and the fragment shader.

The fix is to introduce another object that will actually keep a link to the cached resources, so in this patch
I'm adding a new class called CustomFilterProgram that will sit in the
platform/graphics/filters directory and will be referenced from CustomFilterOperation.

CustomFilterProgram is the base class of StyleCustomFilterProgram that is created from
CSSStyleSelector when a new CustomFilterOperation is created. StyleCustomFilterProgram is responsible
with loading and keeping references to the StyleCachedShaders and the CachedShaders.

More patches will follow with optimizations about reusing 3D graphics contexts and compiled shaders.

Tests: css3/filters/custom-filter-shader-cache.html

css3/filters/missing-custom-filter-shader.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):

Updated to use the StyleCustomFilterProgram instead of the CustomFilterOperation.

  • platform/graphics/filters/CustomFilterOperation.h: Renamed from Source/WebCore/rendering/style/CustomFilterOperation.h.

(WebCore::CustomFilterOperation::create):

Accepts a CustomFilterProgram instead of vertex and fragment CachedShaders.

(WebCore::CustomFilterOperation::program): Returns the CustomFilterProgram.

(WebCore::CustomFilterOperation::CustomFilterOperation):

Accepts a CustomFilterProgram instead of vertex and fragment CachedShaders.

  • platform/graphics/filters/CustomFilterProgram.cpp: Added.

(WebCore::CustomFilterProgram::CustomFilterProgram):
(WebCore::CustomFilterProgram::~CustomFilterProgram):
(WebCore::CustomFilterProgram::addClient):
(WebCore::CustomFilterProgram::removeClient):
(WebCore::CustomFilterProgram::notifyClients):
(WebCore::CustomFilterProgram::createShaderWithContext):

  • platform/graphics/filters/CustomFilterProgram.h: Added.
  • platform/graphics/filters/CustomFilterProgramClient.h: Added.

(WebCore::CustomFilterProgramClient::~CustomFilterProgramClient):

  • platform/graphics/filters/FECustomFilter.cpp:

FECustomFilter will not use strings anymore. It will just get a reference to the CustomFilterProgram.

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::initializeContext):

Using the CustomFilterProgram to generate the CustomFilterShader instance. A better name for CustomFilterShader
would be CustomFilterCompiledProgram, but I would prefer to make that change in a different patch.

  • platform/graphics/filters/FECustomFilter.h:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::notifyCustomFilterProgramLoaded):
(WebCore::FilterEffectRenderer::removeCustomFilterClients):

  • rendering/FilterEffectRenderer.h:
  • rendering/style/StyleCustomFilterProgram.h: Added.

(WebCore::StyleCustomFilterProgram::create):
(WebCore::StyleCustomFilterProgram::setVertexShader):
(WebCore::StyleCustomFilterProgram::vertexShader):
(WebCore::StyleCustomFilterProgram::setFragmentShader):
(WebCore::StyleCustomFilterProgram::fragmentShader):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):

LayoutTests:

  • css3/filters/custom-filter-shader-cache-expected.png: Added.
  • css3/filters/custom-filter-shader-cache-expected.txt: Added.
  • css3/filters/custom-filter-shader-cache.html: Added.

Testing that multiple elements can share the same shaders cached resources.

  • css3/filters/missing-custom-filter-shader-expected.png: Added.
  • css3/filters/missing-custom-filter-shader-expected.txt: Added.
  • css3/filters/missing-custom-filter-shader.html: Added.

Testing that we don't crash when shaders are missing and that we don't try to render
if one component of the pair (vertex shader, fragment shader) was not loaded yet.

05:21 Changeset [104701] by apavlov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline http/tests/media/video-buffering-repaints-controls.html for Mac Leopard Debug.

  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
04:46 Changeset [104700] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test fast/forms/radio/radio-group.html failing after r104668
https://bugs.webkit.org/show_bug.cgi?id=76051

Unreviewed gardening.

  • platform/qt/Skipped:
04:24 Changeset [104699] by apavlov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Skip failing fast/text/font-kerning.html reftest on Win7.

  • platform/chromium-win/fast/text/font-kerning-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
04:08 Changeset [104698] by achicu@adobe.com
  • 25 edits in trunk

CSS Filters: apply the filters in RenderLayerBacking::paintIntoLayer when filters cannot be composited in hardware
https://bugs.webkit.org/show_bug.cgi?id=75842

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayers have two possible states: composited or not. When composited the RenderLayerBacking::paintIntoLayer is used
to render the result inside the graphics context of the GraphicsLayer. When not composited the RenderLayer::paintLayer method will draw
the result in the graphics context of the parent layer.

Because a recent patch forced creation of composited layers for filters, this patch makes RenderLayerBacking::paintIntoLayer aware
that it might need to apply the filters when the composition engine failed to apply them in platform code.

No new tests needed, I've just updated some of the old tests to force disable the accelerated composition
so that we can still test software painted filters.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::clearFilters):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setFilters):

If filtersCanBeComposited() is false we need to reset the CoreAnimation layer to remove any previously applied filter.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::filtersCanBeComposited):

Added grayscale, brightness and contrast in the list of not accelerated filters. Otherwise an assert if triggered.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::updateBackingStore):

Moved this method from RenderLayer::updateFilterBackingStore. It had no dependencies on RenderLayer.

(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

Consolidated the filter rendering inside this helper class that is now used in both RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer.

  • rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRendererHelper::FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::haveFilterEffect):
(WebCore::FilterEffectRendererHelper::hasStartedFilterEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

Filters should apply after the opacity is applied, so I moved this down to paintLayerContents.

(WebCore::RenderLayer::paintLayerContents):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::filter):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Added software fallback rendering of the filters on composited RenderLayers.

LayoutTests:

Disabled the accelerated composition on some of the tests, so that we can test that software pipeline still works.
Note that we also have equivalent tests ending in "-hw.html" that test the accelerated composited mode.

  • css3/filters/effect-blur.html:
  • css3/filters/effect-brightness.html:
  • css3/filters/effect-combined.html:
  • css3/filters/effect-contrast.html:
  • css3/filters/effect-custom-expected.png: Reverted the expected results for CSS Shader test with WebGL enabled.
  • css3/filters/effect-custom-expected.txt: Added some output to the test, to make it easy to understand what is tested.
  • css3/filters/effect-custom.html: Also forced enabled WebGL using layoutTestController.overridePreference.
  • css3/filters/effect-drop-shadow.html:
  • css3/filters/effect-grayscale.html:
  • css3/filters/effect-hue-rotate.html:
  • css3/filters/effect-invert.html:
  • css3/filters/effect-opacity.html:
  • css3/filters/effect-saturate.html:
  • css3/filters/effect-sepia.html:
  • css3/filters/filter-repaint.html:
03:52 Changeset [104697] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline after r104678.

  • platform/gtk/Skipped: Skip failing fast/text/font-kerning.html

ref test.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
03:50 Changeset [104696] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Implement the font-kerning CSS property
https://bugs.webkit.org/show_bug.cgi?id=76033

Unreviewed gardening after r104678.

  • svg/css/getComputedStyle-basic-expected.txt:
03:27 Changeset [104695] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark http/tests/media/video-buffering-repaints-controls.html as timing out on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=75570

  • platform/chromium/test_expectations.txt:
02:58 Changeset [104694] by jochen@chromium.org
  • 10 edits in trunk/Source

Move the check for canExecuteScripts out of V8Proxy::retrieve
https://bugs.webkit.org/show_bug.cgi?id=75533

Reviewed by Adam Barth.

Source/WebCore:

This change doesn't move the check to custom/generated bindings for
individual objects, as these won't get executed if scripts are disabled
anyway.

No new tests. No functional change.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::retrieve):
(WebCore::toV8Context):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::didClearWindowObject):

02:51 Changeset [104693] by antti@apple.com
  • 2 edits in trunk/Websites/webkit.org

Remove S60 reference from webkit.org
https://bugs.webkit.org/show_bug.cgi?id=76044

Reviewed by Simon Hausmann.

There is no S60.

  • index.html:
02:49 Changeset [104692] by tony@chromium.org
  • 2 edits in trunk/Tools

Don't remove 0 byte files when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=75997

Reviewed by Csaba Osztrogonác.

If QTDIR is set, isQt() is true even when running build-webkit --chromium.

  • Scripts/webkitdirs.pm:

(determineIsQt):

02:48 JavaScript and DOM Benchmarks edited by morrita@google.com
(diff)
02:41 Changeset [104691] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Rename viewObject to viewWidget
https://bugs.webkit.org/show_bug.cgi?id=75947

Reviewed by Martin Robinson.

Rename viewObject to viewWidget for the EFL port to use WidgetBackingStore
which calls viewWidget().

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::viewSize):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit::PageClientImpl::create):
(WebKit::PageClientImpl::viewWidget):

  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

02:24 Changeset [104690] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

ShouldSkipTypeInHeader() and ShouldSkipTypeInImplementation() should be the same
https://bugs.webkit.org/show_bug.cgi?id=76030

Reviewed by Adam Barth.

Because the attributes/methods that do not appear in the implementation
do not need to appear in the header.

Tests: bindings/scripts/test/TestCallback.idl

bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType): Renamed from ShouldSkipTypeInImplementation().
(GenerateHeader): Replaced ShouldSkipTypeInImplementation() with ShouldSkipType(),
and replaced ShouldSkipTypeInHeader() with ShouldSkipType().
(GenerateImplementation): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestCallback.h: Updated the test result.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
02:14 Changeset [104689] by apavlov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, more rebaselines after r104678.

  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/chromium-win/fast/text/font-kerning-expected.png: Added.
02:11 Changeset [104688] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix more style errors in CSSParser.cpp (followup patch)
https://bugs.webkit.org/show_bug.cgi?id=76038

Reviewed by Nikolas Zimmermann.

The previous was: http://trac.webkit.org/changeset/104576
This patch mostly contains C cast to static_cast rewrites.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::ShadowParseContext::commitLength):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::parseDeprecatedGradientPoint):

02:05 Changeset [104687] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Refactor single backing store scroll code.
https://bugs.webkit.org/show_bug.cgi?id=75243

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-11
Reviewed by Zoltan Herczeg.

Remove the duplicated code and refactor the scroll procedure.
Wherever the page is scrolled, there are one screen copy and two updates.
This patch optimises the scroll procedure by less calculation.

  • ewk/ewk_view_single.cpp:

(_ewk_view_screen_move):
(_ewk_view_single_scroll_process_single):

02:04 Changeset [104686] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix release builds.

  • rendering/svg/SVGTextMetricsBuilder.cpp: (WebCore::SVGTextMetricsBuilder::measureTextRenderer):
01:26 Changeset [104685] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline fast/css/getComputedStyle/computed-style.html after r104678.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
01:24 Changeset [104684] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r101445): [V8] Generated code for custom getters and setters
with the [Supplemental] IDL is wrong
https://bugs.webkit.org/show_bug.cgi?id=76034

Reviewed by Adam Barth.

This patch fixes the class name of the implementation of custom getters
and setters, as follows.

Previous V8TestInterface.cpp:

Attribute 'supplementalStr3'
{"supplementalStr3", V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, ...},

New V8TestInterface.cpp:

Attribute 'supplementalStr3'
{"supplementalStr3", V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, ...},

Test: bindings/scripts/test/TestInterface.idl

bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):

  • bindings/scripts/test/V8/V8TestInterface.cpp:
01:16 Changeset [104683] by zimmermann@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Introduce SVGTextMetricsBuilder, which will be used to speed-up measuring of SVG text,
by using the simple code path, whenever possibly. It's not enabled yet, as it requires
a restructurization of SVGTextLayoutAttributesBuilder - its the first chunk of a set
of patches, that all together fix the performance regression and much more :-)

Doesn't affect any tests, SVGTextMetricsBuilder is not turned on yet.

  • CMakeLists.txt: Add SVGTextMetricsBuilder.cpp/h to build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Font.h:

(WebCore::Font::codePath): Make it public, to be usable from SVGTextMetricsBuilder.

  • rendering/svg/RenderSVGAllInOne.cpp: Add SVGTextMetricsBuilder.cpp to build.
  • rendering/svg/RenderSVGText.cpp:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): SVGTextMetrics::emptyMetrics() is gone, adapt code.

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics): Ditto.
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Ditto.

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics): Made public, now used in SVGTextLayoutEngine.
(WebCore::SVGTextMetrics::constructTextRun): Move to public static function, to be usable from SVGTextMetricsBuilder.

  • rendering/svg/SVGTextMetrics.h:

(WebCore::SVGTextMetrics::isEmpty): Add new isEmpty method, which replaces the == empyMetrics().
(WebCore::SVGTextMetrics::setWidth): Remove friendship with SVGTextLayoutAttributesBuilder, and make it public, to avoid another friendship.

  • rendering/svg/SVGTextMetricsBuilder.cpp: Added.

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText): New variant using WidthIterator directly, this is finally possible as SVG Fonts have been integrated into the glyph pages concept a while ago.
(WebCore::SVGTextMetricsBuilder::advanceComplexText): Complex code path, accounting for sum of glyph widths != run width.
(WebCore::SVGTextMetricsBuilder::measureTextRenderer): Either measure the text renderer, or just figure out lastCharacter.
(WebCore::SVGTextMetricsBuilder::walkTreeUntilSpecificLeafIsReached): Walks SVG <text> tree, correctly computing "lastCharacter" until the leaf is reached.
(WebCore::SVGTextMetricsBuilder::measureAllCharactersOfRenderer): Use above method.

  • rendering/svg/SVGTextMetricsBuilder.h: Added.
01:16 Changeset [104682] by apavlov@chromium.org
  • 1 edit
    1 copy
    1 move
    6 adds in trunk/LayoutTests

[Chromium] Unreviewed, add baselines for http/tests/media/video-buffering-repaints-controls.html

  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Copied from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
01:02 Changeset [104681] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed trivial build fix: Removed unnecessary QHttpRequestHeader
inclusion (and the file is removed in newer Qt 5 versions).

  • Api/qwebpage.cpp:
01:02 Changeset [104680] by hausmann@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

[Qt][WK2] Fix the build for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=75964

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-11
Reviewed by Simon Hausmann.

Source/WebKit:

  • WebKit.pri: Added the new files to the buildsystem.

Source/WebKit/qt:

Added QHttpHeader, QHttpResponseHeader and QHttpRequestHeader
that were removed from Qt. They are now kept under a private header
and only the relevant code is present.

  • Api/qhttpheader.cpp: Added.

(QHttpHeader::QHttpHeader):
(QHttpHeader::~QHttpHeader):
(QHttpHeader::parse):
(QHttpHeader::value):
(QHttpHeader::hasKey):
(QHttpHeader::setValue):
(QHttpHeader::addValue):
(QHttpHeader::parseLine):
(QHttpHeader::toString):
(QHttpHeader::hasContentLength):
(QHttpHeader::contentLength):
(QHttpHeader::setContentLength):
(QHttpHeader::hasContentType):
(QHttpHeader::contentType):
(QHttpHeader::setContentType):
(QHttpResponseHeader::QHttpResponseHeader):
(QHttpResponseHeader::parseLine):
(QHttpResponseHeader::toString):
(QHttpRequestHeader::QHttpRequestHeader):
(QHttpRequestHeader::parseLine):
(QHttpRequestHeader::toString):

  • Api/qhttpheader_p.h: Added.

(QHttpHeader::isValid):
(QHttpHeader::setValid):
(QHttpResponseHeader::statusCode):
(QHttpResponseHeader::reasonPhrase):
(QHttpResponseHeader::majorVersion):
(QHttpResponseHeader::minorVersion):
(QHttpRequestHeader::method):
(QHttpRequestHeader::path):
(QHttpRequestHeader::majorVersion):
(QHttpRequestHeader::minorVersion):

  • WebCoreSupport/InspectorServerQt.cpp:
00:40 Changeset [104679] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

Fix fast/spatial-navigation/snav-media-elements.html
<http://webkit.org/b/76028>

Reviewed by Daniel Bates.

  • fast/spatial-navigation/snav-media-elements-expected.txt: Update

results.

  • fast/spatial-navigation/snav-media-elements.html: Fix

test-complete code path by using js-test-post-async.js. Note
that the path to js-test-post.js was incorrect, so it was never
even loaded.

00:38 Changeset [104678] by mitz@apple.com
  • 17 edits
    2 adds in trunk

<rdar://problem/10674686> Implement the font-kerning CSS property
https://bugs.webkit.org/show_bug.cgi?id=76033

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/text/font-kerning-expected.html

fast/text/font-kerning.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added code to handle
font-kerning.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added mapping from FontDescription::Kerning.
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning): Added mapping to
FontDescription::Kerning.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Added font-kerning to the set of inherited
properties.

  • css/CSSPropertyNames.in: Added -webkit-font-kerning.
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added a handler for font-kerning.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration): Updated for the number of properties that
affect the font.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Changed to enable kerning if font-kerning is set to
normal, disable it if font-kerning is set to none, and leave it to the default (determined
by the text-rendering property) if font-kerning is set to auto.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Added a Kerning enum.
(WebCore::FontDescription::kerning): Added this getter.
(WebCore::FontDescription::setKerning): Added this setter.
(WebCore::FontDescription::operator==): Updated to compare the m_kerning member.

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/text/font-kerning-expected.html: Added.
  • fast/text/font-kerning.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
00:19 Changeset [104677] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix page rendering issue on ewk_view_tiled.
https://bugs.webkit.org/show_bug.cgi?id=75686

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-11
Reviewed by Andreas Kling.

As for now the discard of ewk_tiled_backing_store doesn't reset its own contents size information
and ewk_tiled_backing_store just ignores the request if new contents size change request would contain
the same size compared to the one that it owns,
contents size change request coming from ChromeClientEfl::contentsSizeChanged() API can be skipped
and therefore web page can't be presented properly.
In order to resolve this, I just add code to reset contents size information which ewk_tiled_backing_store owns
when it discards its own data.

  • ewk/ewk_tiled_backing_store.cpp:

(ewk_tiled_backing_store_flush):

Note: See TracTimeline for information about the timeline view.