Timeline


and

01/17/12:

23:36 Changeset [105246] by rolandsteiner@chromium.org
  • 18 edits
    18 deletes in trunk

Unreviewed, rolling out r105244.
http://trac.webkit.org/changeset/105244
https://bugs.webkit.org/show_bug.cgi?id=76518

broke Chromium Mac (Requested by rolandsteiner on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-17

Source/WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::checkboxOrRadioValue):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:
  • accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

Tools:

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::AccessibilityUIElement):

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::removeSelection):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::removeSelection):

LayoutTests:

  • platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-iframe.html: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-main-window.html: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-global-point-nested.html: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-nested.html: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Removed.
  • platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Removed.
22:55 Changeset [105245] by commit-queue@webkit.org
  • 11 edits in trunk

[Internals] Should be able to access corresponding Document object.
https://bugs.webkit.org/show_bug.cgi?id=76425

.:

Added exported symbols.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

  • Source/autotools/symbols.filter:

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

  • Allow FrameDestructionObserver to re-setting the Frame reference.
  • Make Internals a subclass of FrameDestructionObserver.

Since Internals::reset() is called for each test, we can access
the acive Frame object during the test. The frame reference will be
used by coming changes.

No new tests. Covered by existing tests.

  • WebCore.exp.in:
  • page/FrameDestructionObserver.cpp:

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::observe):

  • page/FrameDestructionObserver.h:
  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::reset):

  • testing/Internals.h:

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

  • win/WebKit2.def: Added exporting symbols.
  • win/WebKit2CFLite.def: Added exporting symbols.
22:41 Changeset [105244] by dmazzoni@google.com
  • 18 edits
    18 adds in trunk

Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460

Reviewed by Chris Fleizach.

Source/WebCore:

Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html

platform/chromium/accessibility/scroll-to-global-point-nested.html
platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
platform/chromium/accessibility/scroll-to-make-visible-iframe.html
platform/chromium/accessibility/scroll-to-make-visible-main-window.html
platform/chromium/accessibility/scroll-to-make-visible-nested.html
platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):

  • accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):

Tools:

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

LayoutTests:

  • platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
  • platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
  • platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
  • platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
  • platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.
22:39 Changeset [105243] by mdelaney@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.exp.in

Fixing broken build. Missed a file in r105234.

22:06 Changeset [105242] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75089
Access-Control-Request-Headers value should be lowercase

Source/WebCore:

Access-Control-Request-Headers is used when issuing a preflight request to let the server know
the HTTP headers that will be used when the actual request is made.
As per the W3C specification, Access-Control-Request-Headers value should be set in lowercase.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html

  • loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest): setting Access-Control-Request-Headers value to lowercase

LayoutTests:

Added test to verify that the Access-Control-Request-Headers value is sent in lowercase.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php: Added.
21:49 Changeset [105241] by hayato@chromium.org
  • 4 edits in trunk/Source/WebCore

Clean EventContext and move phase-tweaking logic to EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=76414

Reviewed by Dimitri Glazkov.

No tests. No change in behavior.

  • dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents):

  • dom/EventContext.h:

(WebCore::EventContext::currentTargetSameAsTarget):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

20:28 Changeset [105240] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Use static const insted of #define macro.
https://bugs.webkit.org/show_bug.cgi?id=76499

Reviewed by Hajime Morita.

WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro.
This patch replace global variables defined by #define with const.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_zoom_set_internal):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_new):

  • ewk/ewk_view.cpp:

(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_priv_new):
(ewk_view_base_smart_set):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_pre_render_start):

20:15 Changeset [105239] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove public/WebWorker.h from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=76512

Reviewed by David Levin.

public/WebWorker.h was removed in r105020, remove references from the gyp projects.

  • WebKit.gyp:
20:13 Changeset [105238] by levin@chromium.org
  • 3 edits in trunk/Source/WebCore

Need to figure out which assert is firing when worker-read-blob-async.html fails.
https://bugs.webkit.org/show_bug.cgi?id=76503

Reviewed by Adam Barth.

No new functionality exposed so no new tests.

This is just a quick and dirty way to make these asserts unique
to expose which one of them is firing on a machine that doesn't have a
good stack trace.

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

20:02 Changeset [105237] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

20:01 Changeset [105236] by abarth@webkit.org
  • 2 edits in trunk/Tools

Enable tests on the mac-ews
https://bugs.webkit.org/show_bug.cgi?id=76502

Reviewed by Simon Fraser.

Apple now has five machines running the mac-ews. Lucas Forschler has
asked that we try enabling tests to see if we have enough bandwidth.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):

20:01 Changeset [105235] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.7

New tag.

19:59 Changeset [105234] by mdelaney@apple.com
  • 8 edits in trunk/Source

On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier.

19:24 Changeset [105233] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clear 'm_size' of DrawingBuffer in the 'clear' function
https://bugs.webkit.org/show_bug.cgi?id=76239

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-01-17
Reviewed by Kenneth Russell.

Clear the resources of DrawingBuffer but don't clear 'm_size'. This makes
's_currentResourceUsePixels' is not calculated correctly.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clear):

19:19 Changeset [105232] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add a check-webkit-style exception for GDBInterface.cpp
https://bugs.webkit.org/show_bug.cgi?id=76187

Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
that it does not fail the style check.

Patch by Sanjoy Das <sanjoy@playingwithpointers.com> on 2012-01-17
Reviewed by Martin Robinson.

  • Scripts/webkitpy/style/checker.py: Tell the style checker to not run

readability/naming tests on
Source/JavaScriptCore/jit/GDBInterface.cpp.

  • Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier): Add a test for
the above exception.

19:16 Changeset [105231] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Fix getBBox for perpendicular paths
https://bugs.webkit.org/show_bug.cgi?id=76177

Patch by Philip Rogers <pdr@google.com> on 2012-01-17
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/custom/getBBox-perpendicular-path.svg

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::unite):
(WebCore::FloatRect::uniteEvenIfEmpty):
(WebCore::FloatRect::uniteIfNonZero):

  • platform/graphics/FloatRect.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

  • svg/custom/getBBox-perpendicular-path-expected.txt: Added.
  • svg/custom/getBBox-perpendicular-path.svg: Added.
19:09 Changeset [105230] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Apply color profiles in more cases
https://bugs.webkit.org/show_bug.cgi?id=76498

Reviewed by Stephen White.

Not adding new tests, as application of the color profile is not
guaranteed for images used as textures in WebGL. Ran existing
WebGL layout tests; all pass.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::setStatus):

18:48 Changeset [105229] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark some compositing tests as failing with an IMAGE diff due to video playback problem

  • platform/chromium/test_expectations.txt:
18:43 Changeset [105228] by simon.fraser@apple.com
  • 7 edits in trunk/LayoutTests

Fix media handling in compositing tests after r105219.

Reviewed by James Robinson.

Seeking seems to have issues on Chromium, and cause these tests to
timeout, so change the tests to play, then seek back to time 0.

New image results now show the first frame of the movie.

  • compositing/resources/media-testing.js:

(ensureFrameVisible):

  • platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/self-painting-layers-expected.png:
18:18 Changeset [105227] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Rename quickLookPreviewItemsAtWindowLocation: to quickLookWithEvent:
<rdar://problem/10688913>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView quickLookWithEvent:]):

18:06 Changeset [105226] by japhet@chromium.org
  • 6 edits in trunk/Source/WebCore

Ensure we don't cancel revalidation of a CachedResource
in the middle of successful revalidation.
It's more reliable to enforce this in CachedResource than in
SubresourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=75713

Reviewed by Adam Barth.

No new test, the buggy case requires a non-stubbed window.print().

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):

  • loader/SubresourceLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::clearResourceToRevalidate):
(WebCore::CachedResource::switchClientsToRevalidatedResource):

  • loader/cache/CachedResource.h:
18:06 Changeset [105225] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

Tweak results.html keyboard handling and flagging UI
https://bugs.webkit.org/show_bug.cgi?id=76331

Reviewed by Simon Fraser.

-Make it so that hitting j/k at the start selects the first/last test
instead of the second/none'th test.
-Use the unicode black flag character instead of " (flagged)"
-Make the text color of the whole selected row red. This showed
which row was selected without being to garish I think.
-Allow for having the flagged tests be space-separated instead of
newline separated.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
18:03 Changeset [105224] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

NULL ptr in WebCore::RenderSVGInlineText::localCaretRect
https://bugs.webkit.org/show_bug.cgi?id=75851

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-17
Reviewed by Ryosuke Niwa.

.:

Added a check for null box in localCaretRect, to match test in other
implementations. Adding a manual test because the crash is not
reproducible in DRT.

  • ManualTests/svg-modify-deleted-selection.svg: Added.

Source/WebCore:

Added a check for null box in localCaretRect, to match test in other
implementations. Adding a manual test because the crash is not reproducible
in DRT.

Test: ManualTests/svg-modify-deleted-selection.svg

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

18:00 Changeset [105223] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Factored out some code into a helper function.

I think this might help getting rid of omit-frame-pointer.

Reviewed by Sam Weinig.

No benchmark change.

  • runtime/StringPrototype.cpp:

(JSC::removeUsingRegExpSearch): Moved to here...
(JSC::replaceUsingRegExpSearch): ...from here.

17:56 Changeset [105222] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp

Changing pixelSnappedScrollHeight/Width to not directly access member variables. This fixes a bug now that there's a cache and dirty bit.

17:33 Changeset [105221] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r103913 & r103915.

17:23 Changeset [105220] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge 104593.

17:18 Changeset [105219] by simon.fraser@apple.com
  • 22 edits
    1 add in trunk/LayoutTests

Reduce the number of compositing test failures
https://bugs.webkit.org/show_bug.cgi?id=76495

Reviewed by James Robinson.

General cleanup of compositing tests:

  • video tests now do a seek to guarantee that the pixel result will show a frame
  • video tests use a shared JS file (can't use media/video-test.js because it always calls dumpAsText(), which is not reversible).
  • ideo-with-invalid-source.html fixed to use a file extension so that the error event fires (bug 76494).
  • pixel results rebaselined.
  • compositing/geometry/clipped-video-controller.html:
  • compositing/geometry/video-fixed-scrolling.html:
  • compositing/geometry/video-opacity-overlay.html:
  • compositing/layers-inside-overflow-scroll.html:
  • compositing/overflow/scroll-ancestor-update.html:
  • compositing/reflections/load-video-in-reflection.html:
  • compositing/resources/media-testing.js: Added.

(ensureFrameVisible):

  • compositing/self-painting-layers.html:
  • compositing/video/video-with-invalid-source.html:
  • compositing/visibility/visibility-simple-video-layer.html:
  • platform/mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/mac/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/mac/compositing/plugins/composited-plugin-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/mac/compositing/self-painting-layers-expected.png:
  • platform/mac/compositing/video/video-background-color-expected.png:
  • platform/mac/test_expectations.txt:
17:16 Changeset [105218] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=76245
[Mac][DRT] should allow query string for the file URL.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Tony Chang.

Taught DRT about file:// as a url instead of a file path.
We are now able to use a path file:///foo/bar.html?baz as a url
with which DRT opens "/foo/bar.html" with "baz" as a query string.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(runTest):

17:11 Changeset [105217] by caio.oliveira@openbossa.org
  • 40 edits
    8 adds in trunk

Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=74455

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC::isUint8ClampedArrayPrediction):
(JSC::isActionableMutableArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateUint8ClampedArray):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::clampDoubleToByte):
(JSC::DFG::compileClampIntegerToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSCell.h:
  • runtime/JSGlobalData.h:
  • wtf/Forward.h:
  • wtf/Uint8Array.h:
  • wtf/Uint8ClampedArray.h: Added.

(WTF::Uint8ClampedArray::set):
(WTF::Uint8ClampedArray::create):
(WTF::Uint8ClampedArray::Uint8ClampedArray):
(WTF::Uint8ClampedArray::subarray):

Source/WebCore:

Test: fast/js/dfg-uint8clampedarray.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • ForwardingHeaders/wtf/Uint8ClampedArray.h: Added.
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSUint8ClampedArrayCustom.cpp: Added.

(WebCore::JSUint8ClampedArray::indexSetter):
(WebCore::toJS):
(WebCore::JSUint8ClampedArray::set):
(WebCore::JSUint8ClampedArrayConstructor::constructJSUint8ClampedArray):

  • bindings/scripts/CodeGeneratorJS.pm:

(IsTypedArrayType):
(GenerateHeader):

  • html/canvas/Uint8ClampedArray.idl: Added.
  • page/DOMWindow.idl:

Source/WTF:

  • WTF.pro:

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • fast/dom/script-tests/prototype-inheritance-2.js:

(constructorNamesForWindow):

  • fast/js/dfg-uint8clampedarray-expected.txt: Added.
  • fast/js/dfg-uint8clampedarray.html: Added.
  • fast/js/script-tests/dfg-uint8clampedarray.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/global-constructors.js:
  • platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt: Copied from LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt.
  • platform/chromium/test_expectations.txt:
16:59 Changeset [105216] by lforschler@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebCore

Merged r97303.

16:54 Changeset [105215] by lforschler@apple.com
  • 8 edits
    2 copies in branches/safari-534.54-branch

Merged r96973.

16:50 Changeset [105214] by jamesr@google.com
  • 7 edits in trunk/LayoutTests

[chromium] Update baselines

  • platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
16:41 Changeset [105213] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Tools

Check style on test_expectations.txt files before commit
https://bugs.webkit.org/show_bug.cgi?id=76484

Reviewed by Adam Barth.

Unlike other style rules, if you get the syntax of the test_expectations.txt
file wrong, the layout tests won't run. Also, this check is simple and only
slows down committing if you actually modify one of the test_expectations.txt files.

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):
(Commit.run):

  • Scripts/webkitpy/tool/steps/commit_unittest.py: Added.

(CommitTest):
(CommitTest.test_check_test_expectations):

16:33 Changeset [105212] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

Crash in in WebCore::EventHandler::mouseMoved.
https://bugs.webkit.org/show_bug.cgi?id=76462

Reviewed by Ryosuke Niwa.

Source/WebCore:

handleMouseMoveEvent call in EventHandler::mouseMoved can
blow away the frame from underneath. Protect it with a frameview
refptr.

Test: fast/events/mouse-moved-remove-frame-crash.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):

LayoutTests:

  • fast/events/mouse-moved-remove-frame-crash-expected.txt: Added.
  • fast/events/mouse-moved-remove-frame-crash.html: Added.
  • fast/events/resources/mouse-move.html: Added.
16:19 Changeset [105211] by lforschler@apple.com
  • 24 edits
    2 copies in branches/safari-534.54-branch/Source/WebCore

Merge 96966.

16:18 Changeset [105210] by kerz@chromium.org
  • 5 edits in branches/chromium/963

Merge 105070 - Web Inspector: styles sidebar rendering is broken
https://bugs.webkit.org/show_bug.cgi?id=76065

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):

  • inspector/front-end/elementsPanel.css:

(.styles-section .header .subtitle):
(.styles-section .properties):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9242032

16:16 Changeset [105209] by kerz@chromium.org
  • 2 edits in branches/chromium/963/Source/WebCore

Merge 105071 - Web Inspector: timeline record bars may overlap with the records column
https://bugs.webkit.org/show_bug.cgi?id=76387

Reviewed by Yury Semikhatsky.

  • inspector/front-end/timelinePanel.css:

(#timeline-container .split-view-sidebar-left):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9242031

16:13 Changeset [105208] by kerz@chromium.org
  • 3 edits
    3 copies in branches/chromium/963

Merge 104140 - WebKit adds vertical paddings and borders to the fixed width of CSS tables
https://bugs.webkit.org/show_bug.cgi?id=74955

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-01-05
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/css-table-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

Changed the width calculation for CSS tables to take into account horizontal
paddings and borders instead of vertical paddings and borders.

LayoutTests:

Added tests to check that the fixed width style is applied correctly to
CSS tables with respect to table paddings and borders.

  • fast/table/css-table-width-expected.txt: Added.
  • fast/table/css-table-width.html: Added.
  • fast/table/script-tests/css-table-width.js: Added.

(computeCSSTableOffsetWidth):
(computeCSSTableOffsetHeight):
(computeCSSTableProperty):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9220007

16:12 Changeset [105207] by alexis.menard@openbossa.org
  • 3 edits in trunk/LayoutTests

Increase test coverage for -webkit-border-image.
https://bugs.webkit.org/show_bug.cgi?id=76473

Reviewed by Tony Chang.

Make sure we also set the width of the border in the shorthand. It will help
in the future to remove CSSBorderImageValue class without breaking this property.

  • fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-image.html:
16:10 Changeset [105206] by ostapenko.viatcheslav@nokia.com
  • 4 edits in trunk

[Qt] Debug build fails with debug qt5
https://bugs.webkit.org/show_bug.cgi?id=76463

Reviewed by Simon Hausmann.

Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.

Source/WebKit/qt:

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

Tools:

  • QtTestBrowser/cookiejar.h:
16:06 Changeset [105205] by jamesr@google.com
  • 3 edits
    24 adds in trunk/LayoutTests

[chromium] Update expectations for line-grid tests and one random svg thing

  • platform/chromium-linux/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/chromium-linux/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/chromium-linux/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-floating-expected.txt: Added.
  • platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
  • platform/chromium-win/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-into-floats-expected.txt: Added.
  • platform/chromium-win/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-positioned-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
15:57 Changeset [105204] by jamesr@google.com
  • 5 edits
    1 move
    1 delete in trunk/LayoutTests

[chromium] Update expectations/baselines for cross-fade change

  • css3/images/cross-fade-overflow-position-expected.txt: Renamed from LayoutTests/platform/mac/css3/images/cross-fade-overflow-position-expected.txt.
  • platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/qt/css3/images/cross-fade-overflow-position-expected.txt: Removed.
15:46 Changeset [105203] by weinig@apple.com
  • 51 edits in trunk/Source

Add helper macro for forward declaring objective-c classes
https://bugs.webkit.org/show_bug.cgi?id=76485

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • wtf/Compiler.h:

Add OBJC_CLASS macro which helps reduce code when forward declaring an
objective-c class in a header which can be included from both Objective-C
and non-Objective-C files.

Source/WebCore:

  • accessibility/AccessibilityObject.h:
  • bindings/js/ScriptController.h:
  • bridge/objc/objc_utility.h:
  • page/DragClient.h:
  • page/EditorClient.h:
  • platform/AutodrainedPool.h:
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/KURL.h:
  • platform/Pasteboard.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMenuDescription.h:
  • platform/PlatformScreen.h:
  • platform/SharedBuffer.h:
  • platform/Widget.h:
  • platform/cf/SchedulePair.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/Icon.h:
  • platform/graphics/Image.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/mac/ColorMac.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerProxy.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/LocalCurrentGraphicsContext.h:
  • platform/mac/PasteboardHelper.h:
  • platform/mac/PopupMenuMac.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/cf/AuthenticationChallenge.h:
  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceResponse.h:
  • rendering/RenderThemeMac.h:

Deploy OBJC_CLASS for a little code reduction.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebDragClient.h:

Deploy OBJC_CLASS for a little code reduction.

  • config.h:

Remove duplicate copy of OBJC_CLASS.

15:31 Changeset [105202] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix duplicate expectations for canvas tests on mac

  • platform/chromium/test_expectations.txt:
15:26 Changeset [105201] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r101413): Correction panel overlaps misspelled text.
https://bugs.webkit.org/show_bug.cgi?id=74589
<rdar://problem/10585115>

When converting the rectangle from the root view, we need
to take into account the height of the rectangle.

Reviewed by Anders Carlsson.

  • WebView/WebView.mm:

(-[WebView _convertRectFromRootView:]):

15:25 Changeset [105200] by commit-queue@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74133

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-01-17
Reviewed by Tony Chang.

  • fast/regions/webkit-flow-inlines-dynamic-expected.html: Added.
  • fast/regions/webkit-flow-inlines-dynamic.html:
  • platform/efl/fast/regions/webkit-flow-inlines-dynamic-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Removed.
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Removed.
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Removed.
15:10 Changeset [105199] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: fix json import on linux
https://bugs.webkit.org/show_bug.cgi?id=76481

Reviewed by Adam Barth.

For some reason, the version of simplejson autoinstalled on my linux
box seems to be broken. We should really only be using
simplejson if json isn't available anyway, so this change looks
for json first.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

(JSONGeneratorTest.test_test_timings_trie):

15:04 Changeset [105198] by leviw@chromium.org
  • 31 edits in branches/subpixellayout/LayoutTests/platform

Rebaselining expectations for new float/line measuring changes

15:02 Changeset [105197] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Stop using pixel snapped values for x values when laying out floats. This is necessary when there are two floats on a line both at 50% width. Switching to pixel snapped values for measuring the available width when laying out bidi runs. Switching improper truncating in shrinkAvailableWidthForNewFloatIfNeeded to pixel snapped values.

14:36 Changeset [105196] by fpizlo@apple.com
  • 19 edits
    16 adds in branches/safari-534.54-branch

Merge 105107.

Source/JavaScriptCore:

2012-01-15 Filip Pizlo <fpizlo@apple.com>


DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361
<rdar://problem/10698060>


Reviewed by Geoff Garen.


Added the ability to cache JS getter calls and custom getter calls in the DFG.
Most of this is pretty mundane, since the old JIT supported this functionality
as well. But a couple interesting things had to happen:


  • There are now two variants of GetById: GetById, which works as before, and GetByIdFlush, which flushes registers prior to doing the GetById. Only GetByIdFlush can be used for caching getters. We detect which GetById style to use by looking at the inline caches of the old JIT.


  • Exception handling for getter calls planted in stubs uses a separate lookup handler routine, which uses the CodeOrigin stored in the StructureStubInfo.


This is a 40% speed-up in the Dromaeo DOM Traversal average. It removes all of
the DFG regressions we saw in Dromaeo. This is neutral on SunSpider, V8, and
Kraken.


  • bytecode/StructureStubInfo.h:
  • dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::execute):
  • dfg/DFGAssemblyHelpers.h: (JSC::DFG::AssemblyHelpers::emitExceptionCheck):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::willNeedFlush): (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGCCallHelpers.h: (JSC::DFG::CCallHelpers::setupResults):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link):
  • dfg/DFGJITCompiler.h: (JSC::DFG::PropertyAccessRecord::PropertyAccessRecord): (JSC::DFG::JITCompiler::addExceptionCheck):
  • dfg/DFGNode.h: (JSC::DFG::Node::hasIdentifier): (JSC::DFG::Node::hasHeapPrediction):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp: (JSC::DFG::Propagator::propagateNodePredictions):
  • dfg/DFGRepatch.cpp: (JSC::DFG::tryCacheGetByID): (JSC::DFG::tryBuildGetByIDList):
  • dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
  • dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

2012-01-16 Filip Pizlo <fpizlo@apple.com>


DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361
<rdar://problem/10698060>


Reviewed by Geoff Garen.


  • fast/js/dfg-custom-getter-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-inlined-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-inlined.html: Added.
  • fast/js/dfg-custom-getter-throw.html: Added.
  • fast/js/dfg-custom-getter.html: Added.
  • fast/js/dfg-getter-expected.txt: Added.
  • fast/js/dfg-getter-throw-expected.txt: Added.
  • fast/js/dfg-getter-throw.html: Added.
  • fast/js/dfg-getter.html: Added.
  • fast/js/script-tests/dfg-custom-getter-throw-inlined.js: Added. (foo): (baz): (bar):
  • fast/js/script-tests/dfg-custom-getter-throw.js: Added. (foo): (bar):
  • fast/js/script-tests/dfg-custom-getter.js: Added. (foo):
  • fast/js/script-tests/dfg-getter-throw.js: Added. (foo): (bar):
  • fast/js/script-tests/dfg-getter.js: Added. (foo):
14:31 Changeset [105195] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix failures in test-webkitpy caused by r105177.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._static_build_path):

14:14 Changeset [105194] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r105172.

  • platform/qt/css3/images/cross-fade-overflow-position-expected.png:
  • platform/qt/css3/images/cross-fade-overflow-position-expected.txt:
14:09 Changeset [105193] by tony@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/rendering/RenderFlexibleBox.cpp

Fix compilation after r105165.

The merge was bad because there have been refactoring changes that weren't
included on the branch.
Review URL: https://chromiumcodereview.appspot.com/9243024

13:44 Changeset [105192] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-534.54-branch

Merge r99649.

13:43 Changeset [105191] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=76469

Patch by Brian Salomon <bsalomon@google.com> on 2012-01-17
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
13:39 Changeset [105190] by eae@chromium.org
  • 12 edits in branches/subpixellayout

Windows build fixes for webkit, with this patch the apple windows port builds

13:37 Changeset [105189] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-534.54-branch

Merge r99982.

13:31 Changeset [105188] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r91148.

13:04 Changeset [105187] by mrowe@apple.com
  • 5 edits
    1 add in branches/safari-534.54-branch/Source/WebCore

Merge r94107.

12:57 Changeset [105186] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

SpaceSplitString: Share equivalent string piece vectors.
<http://webkit.org/b/76458>

Reviewed by Antti Koivisto.

Make SpaceSplitStringData ref-counted and cache them in a hashmap to reduce memory
usage and avoid redundant string splitting work. This reduces memory consumption
by 618 kB (on 64-bit) when viewing the full HTML5 spec at <http://whatwg.org/c>

  • dom/SpaceSplitString.h:

Add the source string to SpaceSplitStringData so we have a key for uncaching
in the destructor. Also bumped the vector's inline size from 2 to 4.

  • dom/SpaceSplitString.cpp:

(WebCore::sharedDataMap):
(WebCore::SpaceSplitStringData::create):
(WebCore::SpaceSplitStringData::createUnique):
(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitString::SpaceSplitString):
(WebCore::SpaceSplitString::set):
(WebCore::SpaceSplitStringData::createVector):

Added create helpers for SpaceSplitStringData. Moved case folding from
createVector() to create(AtomicString). Added a hash map for caching
AtomicString -> SpaceSplitStringData.

(WebCore::SpaceSplitStringData::~SpaceSplitStringData):

Remove the SpaceSplitStringData from the sharedDataMap().

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitString::ensureUnique):

Added, detaches from the shared SpaceSplitStringData if necessary.

(WebCore::SpaceSplitStringData::add):
(WebCore::SpaceSplitStringData::remove):

Assert that add() and remove() are only used on unique SpaceSplitStringData.

(WebCore::SpaceSplitString::add):
(WebCore::SpaceSplitString::remove):

Call ensureUnique() to potentially detach from a shared SpaceSplitStringData
before making modifications.

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::containsAll):

Added gratuitous fast path for containsAll(*this).

12:44 Changeset [105185] by mrowe@apple.com
  • 7 edits in branches/safari-534.54-branch/Source/WebCore

Merge r100408.

12:32 Changeset [105184] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: make PortFactory.get() be fully data-driven
https://bugs.webkit.org/show_bug.cgi?id=76360

Reviewed by Eric Seidel.

Refactor PortFactory.get() to be fully data-driven.

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.get.in):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.assert_port):

12:27 Changeset [105183] by dpranke@chromium.org
  • 23 edits in trunk/Tools

webkitpy: add determine_full_port_name(), clean up port.init()
https://bugs.webkit.org/show_bug.cgi?id=76357

Reviewed by Adam Barth.

Each Port class is now required to implement a 'port_name' field
that will match the start of all ports constructed by this class and
a 'determine_full_port_name' field that will make the port
fully-qualified.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.determine_port_name):
(Port.init):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.for):
(ChromiumPort.init):
(ChromiumPort):
(ChromiumPort._chromium_base_dir):
(ChromiumPort.path_from_chromium_base):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(ChromiumGpuLinuxPort):
(ChromiumGpuLinuxPort.init):
(ChromiumGpuMacPort):
(ChromiumGpuMacPort.init):
(ChromiumGpuWinPort):
(ChromiumGpuWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):
(ChromiumLinuxPort.determine_port_name):
(ChromiumLinuxPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):
(ChromiumMacPort.determine_port_name):
(ChromiumMacPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):
(ChromiumWinPort.determine_port_name):
(ChromiumWinPort.init):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:

(DryRunPort):
(DryRunPort.determine_port_name):
(DryRunPort.init):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.get.in):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.assert_port):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.determine_port_name):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.determine_port_name):
(GoogleChromeMacPort):
(GoogleChromeMacPort.determine_port_name):
(GoogleChromeWinPort):
(GoogleChromeWinPort.determine_port_name):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort):
(MacPort.determine_port_name):
(MacPort.init):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_versions):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort):
(MockDRTPort.determine_port_name):
(MockDRTPort.init):
(MockDRT):
(MockDRT.determine_port_name):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.make_port):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_port_name):
(QtPort.init):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort):
(TestPort.determine_port_name):
(TestPort.init):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.init):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):
(WinPort.determine_port_name):

  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

(get_test_baselines.AllPlatformsPort.init):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config.TestMacPort):
(get_test_config):

12:14 Changeset [105182] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-534.54-branch

Merge r101543.

11:59 Changeset [105181] by mrowe@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebCore

Merge r103118.

11:37 Changeset [105180] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merge r101808.

11:25 Changeset [105179] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge r104669.

11:25 Changeset [105178] by mrowe@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/WebCore

Merge r104619.

11:25 Changeset [105177] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: clean up port code in preparation for static port names
https://bugs.webkit.org/show_bug.cgi?id=76356

Reviewed by Adam Barth.

To fix bug 76215 and be able to determine appropriate port names
in webkitpy without actually constructing Port objects, we need
to shuffle some logic in the chromium ports to be able to figure
out whether we built DRT in 32 or 64-bit mode.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._chromium_base_dir):
(ChromiumPort.init):
(ChromiumPort.path_from_chromium_base):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._static_build_path):
(ChromiumLinuxPort._determine_architecture):
(ChromiumLinuxPort.init):
(ChromiumLinuxPort._build_path):

11:16 Changeset [105176] by hyatt@apple.com
  • 13 edits
    13 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=76197

Implementation of baseline grid alignment. This patch implements line grid tracking in the layout state,
and also implements the snapping of lines to baselines. It works with normal flow, positioning and floats and
with pagination, as long as the grid is inside the pagination context and not outside.

Reviewed by Simon Fraser.

Added a bunch of new tests in fast/line-grid.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setHasTextChildren):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::pageLogicalHeight):
(WebCore::LayoutState::currentLineGrid):
(WebCore::LayoutState::currentLineGridOffset):
(WebCore::LayoutState::layoutOffset):
(WebCore::LayoutState::needsBlockDirectionLocationSetBeforeLayout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::pageLogicalTopForOffset):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::lineGridBox):
(WebCore::RenderBlock::setLineGridBox):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::layoutLineGridBox):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionLogicalTopForLine):

  • rendering/RenderFlowThread.h:
  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineGridSnapAdjustment):

  • rendering/RootInlineBox.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=76197

Add tests for baseline line grid alignment.

Reviewed by Simon Fraser.

  • fast/line-grid/line-grid-floating.html: Added.
  • fast/line-grid/line-grid-inside-columns.html: Added.
  • fast/line-grid/line-grid-into-floats.html: Added.
  • fast/line-grid/line-grid-positioned.html: Added.
  • platform/mac/fast/line-grid: Added.
  • platform/mac/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-floating-expected.txt: Added.
  • platform/mac/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
  • platform/mac/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-into-floats-expected.txt: Added.
  • platform/mac/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-positioned-expected.txt: Added.
11:13 Changeset [105175] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104727.

11:10 Changeset [105174] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderImage.cpp

Fixing truncation vs pixel snapping when drawing broken images.

11:09 Changeset [105173] by vsevik@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/loader/SubresourceLoader.cpp

Merge 104887 - Web Inspector: [Chomium] Resources loaded with 304 status code have receiving time of 15000 days in network panel.
https://bugs.webkit.org/show_bug.cgi?id=76176

Reviewed by Nate Chapin.

No new tests. Can't trigger this with inspector tests. Will add one when the Resource Timing API is in.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Use monotonic time.

TBR=simonjam@chromium.org
BUG=110154
Review URL: https://chromiumcodereview.appspot.com/9243015

11:02 Changeset [105172] by timothy_horton@apple.com
  • 6 edits
    5 adds in trunk

-webkit-cross-fade doesn't respect background-size
https://bugs.webkit.org/show_bug.cgi?id=74902
<rdar://problem/10605289>

Reviewed by Simon Fraser.

CrossfadeGeneratedImage should report its intrinsic size, instead of
improperly conforming to the size of its container.

Test: css3/images/cross-fade-background-size.html

  • platform/graphics/CrossfadeGeneratedImage.h:

(WebCore::CrossfadeGeneratedImage::setContainerSize):
(WebCore::CrossfadeGeneratedImage::usesContainerSize):
(WebCore::CrossfadeGeneratedImage::hasRelativeWidth):
(WebCore::CrossfadeGeneratedImage::hasRelativeHeight):
(WebCore::CrossfadeGeneratedImage::size):

Add a test (cross-fade-background-size.html) which ensures that the
background-size CSS property interacts reasonably with -webkit-cross-fade.

Modify cross-fade-overflow-position to hit both the tiled and non-tiled codepaths.

  • css3/images/cross-fade-background-size.html: Added.
  • css3/images/cross-fade-overflow-position.html:
  • css3/images/resources/stripes-large.png: Added.
  • css3/images/resources/stripes-small.png: Added.
  • platform/mac/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/mac/css3/images/cross-fade-background-size-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.png:
  • platform/mac/css3/images/cross-fade-overflow-position-expected.txt:
11:00 Changeset [105171] by vsevik@chromium.org
  • 8 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

Web Inspector: Refactor JavaScriptOutlineDialog: extract FilteredItemSelectionDialog and reuse DialogDelegate.
https://bugs.webkit.org/show_bug.cgi?id=76455

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Dialog.js:

(WebInspector.Dialog):
(WebInspector.Dialog.prototype._hide):

  • inspector/front-end/FilteredItemSelectionDialog.js: Added.

(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.position):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.willHide):
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._hideItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._itemElementVisible):
(WebInspector.FilteredItemSelectionDialog.prototype._showItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._checkItemAt):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._scheduleFilter):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype._onScroll):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItems):
(WebInspector.FilteredItemSelectionDialog.prototype._clearHighlight):
(WebInspector.FilteredItemSelectionDialog.prototype._clearElementHighlight.changes.this._elementHighlightChanges.get if):
(WebInspector.FilteredItemSelectionDialog.prototype._clearElementHighlight):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):
(WebInspector.FilteredItemSelectionDialog.prototype._itemElementInViewport):
(WebInspector.SelectionDialogContentProvider):
(WebInspector.SelectionDialogContentProvider.prototype.itemTitleAt):
(WebInspector.SelectionDialogContentProvider.prototype.itemKeyAt):
(WebInspector.SelectionDialogContentProvider.prototype.itemsCount):
(WebInspector.SelectionDialogContentProvider.prototype.requestItems):
(WebInspector.SelectionDialogContentProvider.prototype.selectItem):
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.didAddChunk):
(WebInspector.JavaScriptOutlineDialog.install):
(WebInspector.JavaScriptOutlineDialog._show):
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.JavaScriptOutlineDialog.prototype.itemTitleAt):
(WebInspector.JavaScriptOutlineDialog.prototype.itemKeyAt):
(WebInspector.JavaScriptOutlineDialog.prototype.itemsCount):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
(WebInspector.JavaScriptOutlineDialog.prototype._appendItemElements):

  • inspector/front-end/JavaScriptOutlineDialog.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/filteredItemSelectionDialog.css: Renamed from Source/WebCore/inspector/front-end/javaScriptOutlineDialog.css.

(.js-outline-dialog > input):
(.js-outline-dialog > div.progress):
(.js-outline-dialog > div.container):
(.js-outline-dialog > .container > div.item):
(.js-outline-dialog > .container > div.item.selected):
(.js-outline-dialog > .container > div.item > span.highlight):

  • inspector/front-end/inspector.html:
10:57 Changeset [105170] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge fix for 10516690.

10:55 Changeset [105169] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Do not remove pixel failures for ref tests.
https://bugs.webkit.org/show_bug.cgi?id=76243

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-01-17
Reviewed by Tony Chang.

'NRWT --no-pixel-tests' complains when reftests are expected to
be image mismatch.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._update_summary_with_result):

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(is_reftest_failure):
(determine_result_type):

10:34 WebKit Team edited by dbates@webkit.org
(diff)
10:28 Changeset [105168] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Import some NodeIterator tests from mozilla
https://bugs.webkit.org/show_bug.cgi?id=76442

Reviewed by Daniel Bates.

These tests are imported from mozilla-central. I tried to make the
minimal changes when importing them rather than rewire them into
script-tests. They appear to have uncovered a bug, which I will
investigate in a followup patch.

  • traversal/moz-bug559526-expected.txt: Added.
  • traversal/moz-bug559526.html: Added.
  • traversal/moz-bug590771-expected.txt: Added.
  • traversal/moz-bug590771.html: Added.
  • traversal/moz-mutations-3-expected.txt: Added.
  • traversal/moz-mutations-3.html: Added.
10:26 Changeset [105167] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/10703228> ASSERTION FAILED: Uncaught exception - Cannot lock focus on image <NSImage 0x1206572a0 Size={0, 0} Reps=( )>, because it is size zero loading techcrunch.com

Reviewed by Anders Carlsson.

Avoid trying to create image snapshots for zero-sized plugins, because
it causes -[NSView lockFocus] to throw an exception.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView cacheSnapshot]):

10:11 Changeset [105166] by commit-queue@webkit.org
  • 1 edit
    3 moves in trunk

Move tests out of WebCore/manual-tests to toplevel ManualTests.
It looks like the manual-tests folder wasn't noticed by git (or me :).

Move some SVG manual tests from deprecated WebCore/manual-tests to toplevel ManualTests
https://bugs.webkit.org/show_bug.cgi?id=76437

Patch by Raul Hudea <rhudea@adobe.com> on 2012-01-17
Reviewed by Daniel Bates.

  • ManualTests/svg-animation-css-transform.html: Renamed from Source/WebCore/manual-tests/svg-animation-css-transform.html.
  • ManualTests/svg-css-animate-compound.html: Renamed from Source/WebCore/manual-tests/svg-css-animate-compound.html.
  • ManualTests/svg-css-transition-compound.html: Renamed from Source/WebCore/manual-tests/svg-css-transition-compound.html.
09:44 Changeset [105165] by tony@chromium.org
  • 4 edits
    4 copies in branches/chromium/963

Merge 104645 - Need to handle absolutely positioned elements inside flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70793

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/insert-text-crash.html

css3/flexbox/position-absolute-child.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Skip the size of positioned elements.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Add placeholders for positioned elements.
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout): Positions the layer for the positioned child.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Handle positioned elements.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Adjust the main axis offset of the layer for positioned elements.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/insert-text-crash-expected.txt: Added.
  • css3/flexbox/insert-text-crash.html: Added.
  • css3/flexbox/position-absolute-child-expected.txt: Added.
  • css3/flexbox/position-absolute-child.html: Added.

TBR=tony@chromium.org

09:35 Changeset [105164] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, avoid webkit_tests aborts due to clashing SVG test expectations.

  • platform/chromium/test_expectations.txt:
09:06 Changeset [105163] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unskip now passing tests.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-01-17
Reviewed by Csaba Osztrogonác.

08:11 Changeset [105162] by ossy@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r81225): ORWT should ignore reftests
https://bugs.webkit.org/show_bug.cgi?id=67936

Patch by Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu> on 2012-01-17
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:

(isUsedInReftest): $filename should be the first parameter
(findTestsToRun): run test if it isn't reftest

08:03 Changeset [105161] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Input text field not repainted when value is changed
https://bugs.webkit.org/show_bug.cgi?id=76279

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-17
Reviewed by Gustavo Noronha Silva.

Force pending relayouts before freezing the dirty region in a temporary.
This prevents the following code from throwing the dirty updates away
after the original paint is finished.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView): Remove the relayout.
(WebKit::ChromeClient::paint): Move the relayout here, before the
dirty region is frozen.

07:45 Changeset [105160] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: start using typedefs
https://bugs.webkit.org/show_bug.cgi?id=76382

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-17
Reviewed by Yury Semikhatsky.

Generator is patched accordingly.

  • inspector/CodeGeneratorInspector.py:

(EnumConstants.get_enum_constant_code):
(TypeBuilderPass):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.get_code_generator):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.get_in_c_type_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder.String):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.register_use):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_.TypedefString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.TypedefString.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.TypedefString.get_in_c_type_text):
(get_generate_pass_id):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.get_generate_pass_id):
(Generator.process_types.create_type_builder_caller):
(Generator.process_types.create_type_builder_caller.call_type_builder):
(Generator.process_types):

07:42 Changeset [105159] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Fix python unit test I broke with r105142

  • Scripts/webkitpy/common/config/ports_unittest.py:

(WebKitPortTest.test_gtk_port):

07:37 Changeset [105158] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[GTK] [WK2] WebKitPrivate should include the entire WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=76345

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-17
Reviewed by Gustavo Noronha Silva.

Isolate all of the WebKit2 C API includes into WebKitPrivate.h and no longer
include anything other than WebKit2.h for the C API.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp: Use WebKitPrivate.h now.
  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Ditto.
  • UIProcess/API/gtk/WebKitPrivate.h: Add WebKit2.h, WKAPICast.h and WKRetainPtr.h includes.
  • UIProcess/API/gtk/WebKitSettings.cpp: Use WebKitPrivate.h.
  • UIProcess/API/gtk/WebKitUIClient.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebContext.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebView.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWindowProperties.cpp: Ditto.
07:37 Changeset [105157] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: provide basic information about DOM character data size
https://bugs.webkit.org/show_bug.cgi?id=76059

Memory agent allows to estimate size of DOM character data and size of WebCore
strings held by JavaScript objects.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptProfiler.h:

(WebCore::ScriptProfiler::visitExternalJSStrings):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitExternalJSStrings):

  • bindings/v8/ScriptProfiler.h:
  • bindings/v8/V8Binding.cpp:

(WebCore::WebCoreStringResource::visitStrings):
(WebCore::V8BindingPerIsolateData::visitJSExternalStrings):

  • bindings/v8/V8Binding.h:
  • inspector/DOMWrapperVisitor.h:
  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::CharacterDataStatistics::DOMTreeStatistics::DOMTreeStatistics):
(WebCore::CharacterDataStatistics::DOMTreeStatistics::collectNodeStatistics):
(WebCore::CharacterDataStatistics::CounterVisitor::CounterVisitor):
(WebCore::CharacterDataStatistics::CounterVisitor::domGroups):
(WebCore::CharacterDataStatistics::CounterVisitor::strings):
(WebCore::CharacterDataStatistics::CounterVisitor::visitNode):
(WebCore::CharacterDataStatistics::CounterVisitor::visitJSExternalString):
(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
07:34 Changeset [105156] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Dialogs style and DialogDelegate interface fixes.
https://bugs.webkit.org/show_bug.cgi?id=76449

Reviewed by Pavel Feldman.

  • inspector/front-end/Dialog.js:

(WebInspector.Dialog):
(WebInspector.Dialog.currentInstance):
(WebInspector.Dialog.show):
(WebInspector.Dialog.hide):
(WebInspector.Dialog.prototype._hide):
(WebInspector.Dialog.prototype._onGlassPaneFocus):
(WebInspector.Dialog.prototype._onFocus):
(WebInspector.Dialog.prototype._position):
(WebInspector.Dialog.prototype._onKeyDown):
(WebInspector.DialogDelegate.prototype.wasShown):
(WebInspector.DialogDelegate.prototype.position):
(WebInspector.DialogDelegate.prototype.focus):
(WebInspector.DialogDelegate.prototype.onEnter):
(WebInspector.DialogDelegate.prototype.willHide):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog):
(WebInspector.GoToLineDialog.prototype.focus):
(WebInspector.GoToLineDialog.prototype._onGoClick):
(WebInspector.GoToLineDialog.prototype._applyLineNumber):
(WebInspector.GoToLineDialog.prototype.onEnter):

  • inspector/front-end/dialog.css:

(.dialog):

07:30 Changeset [105155] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser

Qt 5 no longer has that flag.

Reviewed by Simon Hausmann.

07:29 Changeset [105154] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=76403

A couple of protocol fixes.

Reviewed by Pavel Feldman.

  • inspector/ConsoleMessage.cpp: return 'log' in case some unsupported value is passed.

We cannot omit that return statement as GCC would complain on missing return statement
despite all enum values are listed.
(WebCore::messageTypeValue):

  • inspector/Inspector-0.1.json: fixed v0.1 protocol definition.
  • inspector/Inspector.json: made CachedResource.response field optional.
07:03 Changeset [105153] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: remove "Document DOM tree" class and "Detached DOM tree" from the Summary view.
https://bugs.webkit.org/show_bug.cgi?id=76450

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):

07:02 Changeset [105152] by kubo@profusion.mobi
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Emit "resource,request,willsend" from ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=76292

Reviewed by Andreas Kling.

Make ewk_view dispatch the "resource,request,willsend" signal as well,
so that it is possible to know whether the request is for the main
frame itself or for anything else.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):

  • ewk/ewk_view.h:
06:35 Changeset [105151] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Crash in fast/text/regional-indicator-symobls.html
https://bugs.webkit.org/show_bug.cgi?id=69419

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-17
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0/Skipped: Removing it from skipped list as it is working now.
06:34 Changeset [105150] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=74785

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-17
Reviewed by Csaba Osztrogonác.

Upstream bug in Qt 5 is fixed, so we can unskip the test now.

  • platform/qt-5.0/Skipped:
06:31 Changeset [105149] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66500

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-17
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0/Skipped: This test is not failing anymore,

removing it from skipped list.

06:28 Changeset [105148] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=75167

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-17
Reviewed by Csaba Osztrogonác.

Bug is fixed upstream, so it should be safe to unskip it now.

  • platform/qt-5.0/Skipped:
05:22 Changeset [105147] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2012-01-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium dependency 117616:117882

  • DEPS:
05:17 Changeset [105146] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebKit2

[Qt] Implement HTTP authentication QML API
https://bugs.webkit.org/show_bug.cgi?id=75535

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-17
Reviewed by Kenneth Rohde Christiansen.

This patch implements the QML API for handling HTTP authentication.
The implementation uses a syncronous message between the WebProcess
and the UIProcess which is called when the authenticationRequired
signal is emitted from QNAM.

Based in part upon patch by Peter Hartmann.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
(QQuickWebViewExperimental::authenticationDialog):
(QQuickWebViewExperimental::setAuthenticationDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::authenticationRequiredRequest):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtDialogRunner.cpp:

(AuthenticationDialogContextObject::AuthenticationDialogContextObject):
(AuthenticationDialogContextObject::hostname):
(AuthenticationDialogContextObject::realm):
(AuthenticationDialogContextObject::prefilledUsername):
(AuthenticationDialogContextObject::accept):
(AuthenticationDialogContextObject::reject):
(QtDialogRunner::initForAuthentication):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner::username):
(QtDialogRunner::password):
(QtDialogRunner::onAuthenticationAccepted):

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleAuthenticationRequiredRequest):

  • UIProcess/qt/QtPageClient.h:
  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onAuthenticationRequired):

  • WebProcess/qt/QtNetworkAccessManager.h:
05:09 Changeset [105145] by zimmermann@webkit.org
  • 4 edits in trunk/LayoutTests

2012-01-17 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Qt results after r105143..

  • platform/qt/svg/carto.net/window-expected.txt:
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
05:03 Changeset [105144] by zimmermann@webkit.org
  • 6 edits in trunk/LayoutTests

2012-01-17 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Gtk results after r105143..

  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
04:42 Changeset [105143] by zimmermann@webkit.org
  • 29 edits
    12 adds in trunk

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Source/WebCore:

Final patch fixing the performance regression from r81168 plus giving us more performance we ever had.
The testcase attached to bug 65711 creates 200 tspans as <text> children, and modifies just the first <tspan>s
content periodically using a timer. It ran with <3 FPS in release builds before, and now at around 60 FPS,
where the most dominant code path remaining is CG painting text. Still theres room to optimize further, as
Intruments shows.

Historically we rebuilt all SVGTextLayoutAttributes stored in the RenderSVGInlineText, whenever any
children of the <text> subtree changed, in any way. This lead to a recomputation of the x/y/dx/dy/rotate
value lists, for the whole tree, a recreation of the line box tree and finally a measurement of all characters
in the subtree.

This patch, and its previous patches preparing this, introduces progressive relayout for the SVG text subtree.
DOM tree mutations, x/y/dx/dy/rotate value lists changes, and measuring-all-characters are now strictly decoupled.

#1) x/y/dx/dy/rotate list changes:
The x/y/dx/dy/rotate lists are only ever rebuilt, if they change or upon the initial RenderSVGText layout.
This information is now cached in the so-called SVGCharacterDataMap, in each of the SVGTextLayoutAttributes,
associated with a specific RenderSVGInlineText.

#2) DOM tree mutations:
If a new RenderSVGInlineText gets added to the tree, we have to create SVGTextLayoutAttributes for the new
renderer, measure its characters, and cache the information in the attributes. Adding a new renderer to
a SVG <text> subtree can affect the positioning of the previous and next sibling in the tree, due the
whitespace merging logic. Example:

<text y="50" x="50 100 150">A<tspan></tspan> C</text>:
RenderSVGText {text} at (50,36) size 111x18 contains 1 chunk(s)

RenderSVGInlineText {#text} at (0,0) size 12x18

chunk 1 text run 1 at (50.00,50.00) startOffset 0 endOffset 1 width 12.00: "A"

RenderSVGTSpan {tspan} at (0,0) size 0x0
RenderSVGInlineText {#text} at (50,0) size 61x18

chunk 1 text run 1 at (100.00,50.00) startOffset 0 endOffset 1 width 4.00: " "
chunk 1 text run 1 at (150.00,50.00) startOffset 0 endOffset 1 width 11.00: "C"

<text y="50" x="50 100 150">A<tspan>B</tspan> C</text>:
RenderSVGText {text} at (50,36) size 115x18 contains 1 chunk(s)

RenderSVGInlineText {#text} at (0,0) size 12x18

chunk 1 text run 1 at (50.00,50.00) startOffset 0 endOffset 1 width 12.00: "A"

RenderSVGTSpan {tspan} at (0,0) size 11x18

RenderSVGInlineText {#text} at (50,0) size 11x18

chunk 1 text run 1 at (100.00,50.00) startOffset 0 endOffset 1 width 11.00: "B"

RenderSVGInlineText {#text} at (100,0) size 15x18

chunk 1 text run 1 at (150.00,50.00) startOffset 0 endOffset 2 width 15.00: " C"

Its obvious that adding a #text node as child to the <tspan> potentially affects the next & previous
siblings in the DOM tree. Take extra care of these possibilities, by properly remeasuring not only
the newly added renderer, but also the previous & next siblings layout attributes.

Mutation of text nodes, or removal of text/tspan elements from the tree is handled in the same way.

#3) Measuring the text subtree:
Don't cache the metrics information in the SVGRootInlineBox, as it doesn't survive relayouts (RenderSVGText::layout).
They're stored in the SVGTextLayoutAttributes, and will be updated if the underlying text content changes.

Tests: svg/text/append-text-node-to-tspan.html

svg/text/modify-text-node-in-tspan.html
svg/text/remove-text-node-from-tspan.html

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):

  • rendering/svg/RenderSVGInlineText.h:

(WebCore::RenderSVGInlineText::layoutAttributes):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::findPreviousAndNextAttributes):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::textDOMChanged):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):

  • rendering/svg/RenderSVGText.h:

(WebCore::RenderSVGText::layoutAttributes):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::findFirstAndLastAttributesInVector):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
(WebCore::SVGRootInlineBox::reorderValueLists):

  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextLayoutAttributes.h:
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForWholeTree):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
(WebCore::SVGTextLayoutEngine::currentVisualCharacterMetrics):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextLayoutEngine.h:

(WebCore::SVGTextLayoutEngine::layoutAttributes):

  • rendering/svg/SVGTextMetrics.h:
  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::childrenChanged):

LayoutTests:

Update some results, that changed again slightly. Land new tests covering partial SVG <text> subtree updating.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/mac/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/mac/svg/text/modify-text-node-in-tspan-expected.png: Added.
  • platform/mac/svg/text/modify-text-node-in-tspan-expected.txt: Added.
  • platform/mac/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/mac/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • svg/text/append-text-node-to-tspan.html: Added.
  • svg/text/modify-text-node-in-tspan.html: Added.
  • svg/text/remove-text-node-from-tspan.html: Added.
04:29 Changeset [105142] by kov@webkit.org
  • 3 edits in trunk/Tools

GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
https://bugs.webkit.org/show_bug.cgi?id=75857

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-16
Reviewed by Adam Barth.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): move cleaning the build to happen early,
and handle --update-gtk right after that

  • Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): pass --update-gtk as an option to
build-webkit, so that it is used in the EWS

04:20 Changeset [105141] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Unreviewed, fix Linux image expectations for two SVG tests.

  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
04:13 Changeset [105140] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058

Reviewed by Pavel Feldman.

As per the results of a war room:

  • Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
  • Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
  • Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
  • Grayed autocompletion can only be accepted with the End or Right keys.
  • Enter can accept a selected suggestion item from the list, without committing the input.
  • Retain the CSS model editing behavior as close to the existing one as possible.
  • Enable PageUp/PageDown to navigate the suggest box items.
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

03:57 Changeset [105139] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CSS backend doesn't conform to Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=76402

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::buildObjectForStyle):

03:13 Changeset [105138] by tommyw@google.com
  • 8 edits in trunk/Source/WebCore

MediaStream API: Add the mediaStream constructor
https://bugs.webkit.org/show_bug.cgi?id=76436

Adding support for creating a MediaStream using a collection of MediaStreamTracks.

Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):

  • mediastream/MediaStream.h:
  • mediastream/MediaStream.idl:
  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::component):

  • mediastream/MediaStreamTrack.h:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::didConstructMediaStream):

  • platform/mediastream/MediaStreamCenter.h:
02:51 Changeset [105137] by jsbell@chromium.org
  • 10 edits in trunk

IndexedDB: IDBIndex.get/getKey should yield undefined, not an error
https://bugs.webkit.org/show_bug.cgi?id=76116

Source/WebCore:

Pass an undefined value (for IDBIndex.get()) or a null key
(for IDBIndex.getKey()) back as the result, rather than raising
an exception.

Reviewed by Adam Barth.

Tests: storage/indexeddb/index-basics.html

storage/indexeddb/cursor-index-delete.html
storage/indexeddb/duplicates.html

  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

LayoutTests:

Reviewed by Adam Barth.

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
02:49 Changeset [105136] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r105129.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
02:39 WebKitGTK/Releasing edited by carlosgc@webkit.org
(diff)
02:26 Changeset [105135] by macpherson@chromium.org
  • 8 edits in trunk/Source/WebCore

Remove references to CSSPrimitiveValue::primitiveType().
https://bugs.webkit.org/show_bug.cgi?id=76363

Reviewed by Hajime Morita.

No new tests / refactoring only.

Goal is to remove primitiveType() completely. Only code left using it after this patch is in SVG.
I've introduced some abstractions in CSSPrimitiveValue for time and angles to reduce duplicated code elsewhere.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeDegrees):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isAngle):
(WebCore::CSSPrimitiveValue::isAttr):
(WebCore::CSSPrimitiveValue::isCounter):
(WebCore::CSSPrimitiveValue::isFontIndependentLength):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isRect):
(WebCore::CSSPrimitiveValue::isRGBColor):
(WebCore::CSSPrimitiveValue::isShape):
(WebCore::CSSPrimitiveValue::isTime):
(WebCore::CSSPrimitiveValue::computeTime):

  • css/CSSStyleSelector.cpp:

(WebCore::convertToLength):
(WebCore::createGridTrackBreadth):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::mapAnimationDelay):
(WebCore::CSSStyleSelector::mapAnimationDuration):
(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
(WebCore::CSSStyleSelector::mapNinePieceImageQuad):
(WebCore::CSSStyleSelector::colorFromPrimitiveValue):
(WebCore::CSSStyleSelector::createTransformOperations):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/MediaQueryEvaluator.cpp:

(WebCore::parseAspectRatio):
(WebCore::numberValue):
(WebCore::computeLength):

  • editing/EditingStyle.cpp:

(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::isCSSValueLength):
(WebCore::hasTransparentBackgroundColor):

02:26 Changeset [105134] by bbudge@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

AssociatedURLLoader adds support for the HTTP response header Access-Control-Expose-Header.
https://bugs.webkit.org/show_bug.cgi?id=76419

Reviewed by Adam Barth.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):

01:28 Changeset [105133] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Don't add _debug postfix to targets when building debug only

Reviewed by Simon Hausmann.

01:27 Changeset [105132] by vestbo@webkit.org
  • 4 edits
    1 add in trunk

[Qt] Add more files to project-files for easier navigation in Qt Creator

Reviewed by Simon Hausmann.

00:36 Changeset [105131] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361

Reviewed by Csaba Osztrogonác.

Fix for 32-bit.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

00:25 Changeset [105130] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt/Skipped: Skip a failing test.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
00:23 Changeset [105129] by philn@webkit.org
  • 4 edits in trunk

[GTK] fast/dom/constructed-objects-prototypes.html fails
https://bugs.webkit.org/show_bug.cgi?id=75432

Reviewed by Martin Robinson.

Tools:

  • Scripts/build-webkit: Enable video-track in GTK.

LayoutTests:

  • platform/gtk/test_expectations.txt: Test now passing no longer

needs to be skipped.

00:18 Changeset [105128] by philn@webkit.org
  • 14 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r105075 and r105085.

  • platform/gtk/editing/execCommand/insertImage-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/fast/block/float/015-expected.txt:
  • platform/gtk/fast/borders/rtl-border-05-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/inner-text-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:

01/16/12:

23:08 Changeset [105127] by rolandsteiner@chromium.org
  • 6 edits
    1 delete in trunk/LayoutTests

Unreviewed:more Chromium Linux rebaselining

  • platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.png:
22:44 Changeset [105126] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Internals] member varaibles should follow naming convention.
https://bugs.webkit.org/show_bug.cgi?id=76426

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-16
Reviewed by Kent Tamura.

No new tests. Just a rename.

  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

  • testing/Internals.h:
22:02 Changeset [105125] by rolandsteiner@chromium.org
  • 8 edits
    6 deletes in trunk/LayoutTests

Unreviewed: updated baselines for Chromium Linux

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
21:28 WebKit Team edited by sh4.seo@samsung.com
(diff)
21:24 Changeset [105124] by rolandsteiner@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed: rebaselining fast/backgrounds/mask-box-image

  • platform/chromium-mac-snowleopard/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-box-image-expected.txt: Added.
19:56 Changeset [105123] by hayato@chromium.org
  • 5 edits in trunk

Implement multiple AT_TARGET event dispatching in regard to shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=76217

Reviewed by Dimitri Glazkov.

The original motivation is to fix the regression: Event.eventPhase is not set to 2
(at target) when handling dblclick event in <input> element.
Since the issue is not specific to <input> element, but general one, this patch fixes
the regression by adapting a living draft spec of shadow DOM.
This won't break a compatibility if there is no shadow boundaries in event dispatching.
See the following shadow dom spec how multiple AT_TARGET events work.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch

Source/WebCore:

  • dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents):

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
19:47 Changeset [105122] by toyoshim@chromium.org
  • 2 edits in trunk/Tools

Add toyoshim as a committer.
https://bugs.webkit.org/show_bug.cgi?id=76390

Reviewed by Hajime Morita.

  • Scripts/webkitpy/common/config/committers.py:
19:35 Changeset [105121] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

platformRequest(QNX) need to get the conditional information from ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=75216

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-01-16
Reviewed by George Staikos.

Pass the isConditional() flag in ResourceRequest to the QNX platform's network request.
QNX platform's network needs this flag to determine whether to use disk-cache.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(ResourceRequest::initializePlatformRequest):

18:25 Changeset [105120] by robert@webkit.org
  • 5 edits
    6 adds in trunk

Heap-use-after-free in WebCore::RenderBlock::selectionGaps
https://bugs.webkit.org/show_bug.cgi?id=75013

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/multiple-captions-crash3.html

fast/table/multiple-captions-crash4.html
fast/table/multiple-captions-crash5.html

When a child float is removed, the parent needs to ensure any reference to the
child is also removed from the floating objects list in any sibling block that
it intruded into.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

In multiple-captions-crash3.html a floating object is added as a child to a caption element, then removed and
added as a child to another caption element. When added to the first caption element it is added
to the floating objects list of both the parent tbody element and the keygen element, as it intrudes
into the latter. When removed, a stale reference to the floating object remains in the keygen element.
When the keygen element is in layout it attempts to access the stale reference to the floating object and
crashes. The fix is to ensure that any floats added as intruding floats to sibling blocks are removed
when the child is removed from the tree.

multiple-captions-crash4.html and multiple-captions-crash5.html are variants of this scenario.

  • fast/table/multiple-captions-crash3-expected.html: Added.
  • fast/table/multiple-captions-crash3.html: Added.
  • fast/table/multiple-captions-crash4-expected.html: Added.
  • fast/table/multiple-captions-crash4.html: Added.
  • fast/table/multiple-captions-crash5-expected.html: Added.
  • fast/table/multiple-captions-crash5.html: Added.
18:00 Changeset [105119] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge r99591.

17:49 Changeset [105118] by mrowe@apple.com
  • 8 edits in branches/safari-534.54-branch/Source

Merge r103860.

17:33 Changeset [105117] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104049.

17:21 Changeset [105116] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r103925.

17:21 Changeset [105115] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r103871.

17:21 Changeset [105114] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r103869.

17:21 Changeset [105113] by mrowe@apple.com
  • 19 edits in branches/safari-534.54-branch/Source

Merge r103858.

17:17 Changeset [105112] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10702758> REGRESSION: Every Safari Reader WKView leaks

Reviewed by John Sullivan and Ada Chan.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]): Since this method can be called multiple times in a row
while [self window] is non-nil, check if there isn’t already an event monitor before adding
a new one.

17:12 Changeset [105111] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION: r102553 Autocorrection bubble doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=76408
<rdar://problem/10644746>

Prior to r102553 Editor::markAllMisspellingsAndBadGrammarInRanges() used to pass its
textCheckingOptions directly to markAndReplaceFor(). Now a request object is used,
but, when the object is created, the TextCheckingTypeShowCorrectionPanel flag is dropped.

Reviewed by Darin Adler.

  • editing/Editor.cpp:

(WebCore::Editor::resolveTextCheckingTypeMask): Add TextCheckingTypeShowCorrectionPanel to
the returned checkingTypes when appropriate.

17:10 Changeset [105110] by lforschler@apple.com
  • 1 edit
    2 copies in branches/safari-534.54-branch/LayoutTests

Merged r100471.

17:06 Changeset [105109] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r104660.

17:04 Changeset [105108] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r104762.

16:53 Changeset [105107] by fpizlo@apple.com
  • 18 edits
    15 adds in trunk

DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361
<rdar://problem/10698060>

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added the ability to cache JS getter calls and custom getter calls in the DFG.
Most of this is pretty mundane, since the old JIT supported this functionality
as well. But a couple interesting things had to happen:

  • There are now two variants of GetById: GetById, which works as before, and GetByIdFlush, which flushes registers prior to doing the GetById. Only GetByIdFlush can be used for caching getters. We detect which GetById style to use by looking at the inline caches of the old JIT.


  • Exception handling for getter calls planted in stubs uses a separate lookup handler routine, which uses the CodeOrigin stored in the StructureStubInfo.


This is a 40% speed-up in the Dromaeo DOM Traversal average. It removes all of
the DFG regressions we saw in Dromaeo. This is neutral on SunSpider, V8, and
Kraken.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitExceptionCheck):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::willNeedFlush):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupResults):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::JITCompiler::addExceptionCheck):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/dfg-custom-getter-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-inlined-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-inlined.html: Added.
  • fast/js/dfg-custom-getter-throw.html: Added.
  • fast/js/dfg-custom-getter.html: Added.
  • fast/js/dfg-getter-expected.txt: Added.
  • fast/js/dfg-getter-throw-expected.txt: Added.
  • fast/js/dfg-getter-throw.html: Added.
  • fast/js/dfg-getter.html: Added.
  • fast/js/script-tests/dfg-custom-getter-throw-inlined.js: Added.

(foo):
(baz):
(bar):

  • fast/js/script-tests/dfg-custom-getter-throw.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-custom-getter.js: Added.

(foo):

  • fast/js/script-tests/dfg-getter-throw.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-getter.js: Added.

(foo):

16:36 Changeset [105106] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Fix <rdar://problem/10678175>.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notityPositionChanged):

16:25 Changeset [105105] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when calling SecItemAdd with a null result pointer
https://bugs.webkit.org/show_bug.cgi?id=76407
<rdar://problem/10696087>

Reviewed by Brady Eidson.

Add null check.

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::webSecItemAdd):

16:19 Changeset [105104] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-534.54-branch

Merge r102540.

16:16 Changeset [105103] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Build correction. Switch to Apple style builds without
the _debug postfix so that launching tools, etc., will work properly.

  • win/tools/vsprops/debug_wincairo.vsprops: Remove use of _debug in

output files to be consistent with WebKit build/test tools.

16:08 Changeset [105102] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge fix for 9593456.

16:04 Changeset [105101] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

A follow-up fix for:
A warning is logged to console when typing a bare "/" in Safari address bar
https://bugs.webkit.org/show_bug.cgi?id=76236

<rdar://problem/10702986>

Reviewed by John Sullivan.

  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a path when there is a base URL.
15:55 Changeset [105100] by mrowe@apple.com
  • 9 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r96014.

15:46 Changeset [105099] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge r104378.

15:46 Changeset [105098] by jonlee@apple.com
  • 10 edits in trunk/Source

Build fix for r105086.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • notifications/NotificationCenter.idl: change to use ENABLE_TEXT_NOTIFICATIONS_ONLY, which is only defined on Mac platform.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
15:38 Changeset [105097] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104663.

15:38 Changeset [105096] by mrowe@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104377.

15:38 Changeset [105095] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix typo in StyledElement::mappedAttributeCount().
<http://webkit.org/b/76393>

Rubber-stamped by Antti Koivisto.

  • dom/StyledElement.h:

(WebCore::StyledElement::mappedAttributeCount): Less &&, more ?:

14:49 Changeset [105094] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for r105086.

  • notifications/NotificationCenter.idl: expand ENABLE macro for .idl.
14:39 Changeset [105093] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

Cache CSSStyleSelector::Features in RuleSets
https://bugs.webkit.org/show_bug.cgi?id=76337

Reviewed by Andreas Kling.

Currently whenever the style selector is updated we go through all the applicable rules and
collect the used features again. We should keep the features around as part of the RuleSets
and update them incrementally. Collecting the features will then be just a matter of taking
the union of all features used by the RuleSets.

This is 1-2% CPU time reduction (engadget, nytimes) due less time spent in feature collection.

This also simplifies the code by removing the need to cache the default style sheet features
separately.

  • css/CSSStyleSelector.cpp:


Remove the global siblingRulesInDefaultStyle and uncommonAttributeRulesInDefaultStyle RuleSets.
These are now part of the cached features of the defaultStyle.


(WebCore::RuleSet::features):

Add a field for caching the features.


(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::collectFeatures):

Unify the features of all RuleSets.
Create RuleSets for sibling and uncommon attribute lookups at the end.


(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::Features::add):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromRuleData):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):

Collect the features when adding the rules rather than as a separate pass through all the rules.


  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::RuleSelectorPair::RuleSelectorPair):

Use Vector instead of a RuleSet for sibling and uncommon attribute selectors so unifying
Features is simpler.

14:37 Changeset [105092] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Huge filter area cause hangs and malloc failures
https://bugs.webkit.org/show_bug.cgi?id=75711

Reviewed by Dean Jackson.

Filtering an element with a child that had a huge negative text-indent
was extremely slow, because transparencyClipBox() returned a huge rect.

Add a method, paintingExtent(), that wraps transparencyClipBox()
and intersects it with the paintDirtyRect to constrain the size
of the rect used for filters and transparency layers.

Transparency layer extent is not testable in layout tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintingExtent):
(WebCore::RenderLayer::beginTransparencyLayers): Floating point literals are required
to avoid ambiguous constructor call.
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):

  • rendering/RenderLayer.h:
14:21 Changeset [105091] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

Borders and box masks behave incorrectly with overlapping offsets
https://bugs.webkit.org/show_bug.cgi?id=76137

Source/WebCore:

Reviewed by Dean Jackson.

There are some correct behaviors for -webkit-mask-box-image where
parts of the mask are missing (when the sum of the slice sizes is
greater than one dimension of the image). To render correctly
in these cases, always use a transparency layer when rendering
the mask.

Test: fast/backgrounds/mask-box-image.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintMaskImages):

LayoutTests:

Reviewed by Dean Jackson.

Test -webkit-mask-box-image with large slice sizes, with and
without a transform.

  • fast/backgrounds/mask-box-image.html: Added.
  • fast/backgrounds/resources/dot.png: Added.
  • platform/mac/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/mac/fast/backgrounds/mask-box-image-expected.txt: Added.
14:19 Changeset [105090] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

Filtered element with composited content beneath it must be composited
https://bugs.webkit.org/show_bug.cgi?id=76322

Source/WebCore:

Reviewed by Dean Jackson.

If a RenderLayer has a filter effect, and a composited descendant, then
that layer must also be composited so that the filter is applied via
the compositing system, rather than via painting (otherwise the filter
will not affect the descendant).

Test: css3/filters/filtered-compositing-descendant.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):

LayoutTests:

Reviewed by Dean Jackson.

Testcase with a filtered element having a composited child.

  • css3/filters/filtered-compositing-descendant-expected.png: Added.
  • css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • css3/filters/filtered-compositing-descendant.html: Added.
13:53 Changeset [105089] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix assertion failure in mappedAttributesEquivalent().
<http://webkit.org/b/76393>

Rubber-stamped by Antti Koivisto.

The assertion that two mapped attributes with matching name/value will always
have the exact same decl() was wrong, so make it a proper check once again.

  • css/CSSStyleSelector.cpp:

(WebCore::mappedAttributesEquivalent):

13:31 Changeset [105088] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

[WinCairo] Build fix after r104155. Several debug targets were not
properly including the '*Common' property sheets.

  • DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
  • DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
  • WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
13:18 Changeset [105087] by bbudge@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Changes AssociatedURLLoader to remove non-whitelisted HTTP response headers for CORS requests,
and Set-Cookie and Set-Cookie2 response headers for all requests.
https://bugs.webkit.org/show_bug.cgi?id=76228

Reviewed by Adam Barth.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::create):
(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
(WebKit::AssociatedURLLoader::loadAsynchronously):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::didReceiveResponse):
(WebKit::TEST_F):

13:11 Changeset [105086] by jonlee@apple.com
  • 4 edits in trunk/Source

Remove HTML notifications support on Mac
https://bugs.webkit.org/show_bug.cgi?id=76401
<rdar://problem/10589881>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • wtf/Platform.h: Define ENABLE_HTML_NOTIFICATIONS macro.

Source/WebCore:

  • notifications/NotificationCenter.idl:
12:50 Changeset [105085] by commit-queue@webkit.org
  • 12 edits
    25 adds in trunk

Add offline web applications API applicationCache.abort.
https://bugs.webkit.org/show_bug.cgi?id=76270

Patch by xueqing huang <huangxueqing@baidu.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests:
http/tests/appcache/abort-cache-onchecking.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
http/tests/appcache/abort-cache-ondownloading.html
http/tests/appcache/abort-cache-ondownloading-manifest-404.html
http/tests/appcache/abort-cache-ondownloading-resource-404.html
http/tests/appcache/abort-cache-onprogress.html

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):

  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::abort):

  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::abort):

  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::abort):

LayoutTests:

  • http/tests/appcache/abort-cache-onchecking-expected.txt: Added.
  • http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-onchecking-manifest-404.html: Added.
  • http/tests/appcache/abort-cache-onchecking-resource-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-onchecking-resource-404.html: Added.
  • http/tests/appcache/abort-cache-onchecking.html: Added.
  • http/tests/appcache/abort-cache-ondownloading-expected.txt: Added.
  • http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-ondownloading-manifest-404.html: Added.
  • http/tests/appcache/abort-cache-ondownloading-resource-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-ondownloading-resource-404.html: Added.
  • http/tests/appcache/abort-cache-ondownloading.html: Added.
  • http/tests/appcache/abort-cache-onprogress-expected.txt: Added.
  • http/tests/appcache/abort-cache-onprogress.html: Added.
  • http/tests/appcache/resources/abort-cache-onchecking-resource-404.manifest: Added.
  • http/tests/appcache/resources/abort-cache-onchecking.manifest: Added.
  • http/tests/appcache/resources/abort-cache-onchecking.text: Added.
  • http/tests/appcache/resources/abort-cache-ondownloading-resource-404.manifest: Added.
  • http/tests/appcache/resources/abort-cache-ondownloading.manifest: Added.
  • http/tests/appcache/resources/abort-cache-ondownloading.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-1.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-2.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-3.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-4.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress.manifest: Added.
  • platform/chromium/test_expectations.txt:
12:28 Changeset [105084] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove caching of mapped attribute count on NamedNodeMap.
<http://webkit.org/b/76393>

Reviewed by Antti Koivisto.

Stop caching the mapped attribute count on Element's attribute map, effectively
shrinking NamedNodeMap by one CPU word. The price we pay is always walking over
the map in matchAllRules(), even if it has no mapped attribute styles.

This reduces memory consumption by 605 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>

  • css/CSSStyleSelector.cpp:

(WebCore::mappedAttributesEquivalent):

Moved here from NamedNodeMap::mappedMapsEquivalent() to accomodate the only
user under the added assumption that the two attribute maps have the same
number of mapped attributes.

(WebCore::CSSStyleSelector::matchAllRules):

We don't have NamedNodeMap::hasMappedAttributes() at our convenience any
more so walk the attribute map (if there is one) looking for styles to add.

(WebCore::CSSStyleSelector::canShareStyleWithElement):

Compare the elements' mapped attribute counts at an earlier time. This is
slightly more expensive but we used to do it near the end anyway and this
ends up rejecting elements that can't share style before doing a lot of
semi-expensive checks.

  • dom/StyledElement.h:

(WebCore::StyledElement::mappedAttributeCount):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::mappedAttributeCount):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::clearAttributes):

Remove NamedNodeMap::m_mappedAttributeCount and add a function that walks
the attribute map counting the attributes that have a decl().

  • dom/NamedNodeMap.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

Remove declAdded()/declRemoved() callbacks.

12:22 Changeset [105083] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

12:02 Changeset [105082] by ossy@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r105072): It broke committers_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=76396

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers_unittest.py:

(CommittersTest._assert_fuzz_match): It should handle more names.
(CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.

12:01 Changeset [105081] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.6

New tag.

11:50 Changeset [105080] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r91324.

11:28 Changeset [105079] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Added necessary header files to VectorMath.cpp to fix Chromium compile error.

  • platform/audio/VectorMath.cpp:
10:53 Changeset [105078] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

WebAudio: Optimize AudioChannel::maxAbsValue().
https://bugs.webkit.org/show_bug.cgi?id=74359

Reviewed by Eric Carlson.

No new tests; optimization of existing code, so covered by existing test cases.

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::maxAbsValue): Replace implementation with optimized vector math

operation.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vmaxmgv): Vector math operation for determining maximum

magnitude in a vector.

  • platform/audio/VectorMath.h:
10:46 Changeset [105077] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

A warning is logged to console when typing a bare "/" in Safari address bar
https://bugs.webkit.org/show_bug.cgi?id=76236

Reviewed by John Sullivan.

  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths.
10:42 Changeset [105076] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=41210
Cross Origin XMLHttpRequest can not expose headers indicated in Access-Control-Expose-Headers HTTP Response Header

Source/WebCore:

Parsing the "Access-Control-Expose-Headers" in the XMLHTTPRequest response header.
If the custom response-header is part of Access-Control-Expose-Headers, then consider that custom response-header as a valid one.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/access-control-response-with-expose-headers.html

  • loader/CrossOriginAccessControl.cpp:

(WebCore::parseAccessControlExposeHeadersAllowList): parsing logic of Access-Control-Expose-Headers

  • loader/CrossOriginAccessControl.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders): checking whether the custom response-header is part of "Access-Control-Expose-Headers"
(WebCore::XMLHttpRequest::getResponseHeader): checking whether the custom response-header is part of "Access-Control-Expose-Headers"

LayoutTests:

Added test cases for Access-Control-Expose-Headers

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/access-control-response-with-expose-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-response-with-expose-headers.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-response-with-expose-headers.php: Added.
10:40 Changeset [105075] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-16
Reviewed by Philippe Normand.

  • gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
10:17 Changeset [105074] by zeno.albisser@nokia.com
  • 8 edits in trunk/Source

[Qt] Fix QT_VERSION related warnings when building on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=76340

Source/JavaScriptCore:

This bug was caused by r104826.
As already mentioned for https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.

Reviewed by Tor Arne Vestbø.

  • wtf/Platform.h:

Source/WebKit2:

This bug was caused by r104826.
As was already mentioned for https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.

Reviewed by Tor Arne Vestbø.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerUpdateInfo::WebLayerUpdateInfo):
(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.h:
10:05 Changeset [105073] by apavlov@chromium.org
  • 55 edits
    2 copies
    1 move
    8 adds
    14 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG tests after r105061.

  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/tref-update-expected.txt:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-03-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.txt:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.txt:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium/svg/text/bidi-text-anchor-direction-expected.png: Removed.
10:03 Changeset [105072] by danw@gnome.org
  • 2 edits in trunk/Tools

Add myself as a committer

Unreviewed

  • Scripts/webkitpy/common/config/committers.py:
09:31 Changeset [105071] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: timeline record bars may overlap with the records column
https://bugs.webkit.org/show_bug.cgi?id=76387

Reviewed by Yury Semikhatsky.

  • inspector/front-end/timelinePanel.css:

(#timeline-container .split-view-sidebar-left):

09:24 Changeset [105070] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: styles sidebar rendering is broken
https://bugs.webkit.org/show_bug.cgi?id=76065

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):

  • inspector/front-end/elementsPanel.css:

(.styles-section .header .subtitle):
(.styles-section .properties):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.

09:18 Changeset [105069] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.

Some recent versions of a few Linux distributions have started passing
--as-needed and --no-copy-dt-needed-entries by default to the linker,
which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
needed a few symbols from libjavascriptcore_efl.so.

  • DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME

before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
libraries are searched in the right order by the linker.

09:17 Changeset [105068] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Inremental build problem revealed by https://bugs.webkit.org/show_bug.cgi?id=74455

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri: supplemental_dependency.tmp must depends on idl files too.
08:56 Changeset [105067] by pfeldman@chromium.org
  • 13 edits in trunk

Web Inspector: do not merge iframes into a single DOM hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=76383

Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/DOMEditor.h:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerFirstChild):
(WebCore::InspectorDOMAgent::innerParentNode):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._ownerDocumentId):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.findNode.processChildren):

  • inspector/console/console-dirxml-expected.txt:
  • inspector/console/console-tests-expected.txt:
  • inspector/elements/set-outer-html-body.html:
  • inspector/styles/styles-iframe.html:
08:47 Changeset [105066] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: setCurrentFocusElement should not update selection when focus is moved to text field or text area.
https://bugs.webkit.org/show_bug.cgi?id=76384

Reviewed by Timothy Hatcher.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog):

  • inspector/front-end/UIUtils.js:

(WebInspector._isTextEditingElement):
(WebInspector.setCurrentFocusElement):

08:13 Changeset [105065] by philn@webkit.org
  • 2 edits in trunk/Tools

[GTK] set audio resources path in NRTW
https://bugs.webkit.org/show_bug.cgi?id=76380

Reviewed by Martin Robinson.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
the uninstalled audio resources are used during webaudio tests.

08:08 Changeset [105064] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r105061.

  • platform/gtk/svg/carto.net/colourpicker-expected.txt:
  • platform/gtk/svg/carto.net/combobox-expected.txt:
  • platform/gtk/svg/carto.net/slider-expected.txt:
  • platform/gtk/svg/carto.net/textbox-expected.txt:
08:00 Changeset [105063] by philn@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-slice-constrained-expected.txt: Added.
  • platform/gtk/fast/text/unicode-variation-selector-expected.txt: Added.
  • platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/gtk/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/gtk/media/video-colorspace-yuv422-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • platform/gtk/svg/filters/filter-refresh-expected.txt: Added.
06:28 Changeset [105062] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Remove references to PagePointer in the FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=76342

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-16
Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):

  • WebProcess/qt/QtNetworkAccessManager.h:
06:04 Changeset [105061] by zimmermann@webkit.org
  • 38 edits in trunk

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable simple code path in SVGTextMetricsBuilder, allowing fast-measurement of simple text.
This affects the geometry of several <text> elements, thus several tests need rebaselining.

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):

LayoutTests:

Update some test results after enabling the simple code path to measure SVG text.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.txt:
  • platform/mac/svg/text/text-deco-01-b-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.txt:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
05:44 Changeset [105060] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate array types.
https://bugs.webkit.org/show_bug.cgi?id=75284

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-16
Reviewed by Yury Semikhatsky.

New classes are generated for ecah array type instance. Some includes
and ifdefs are fixed.

  • inspector/CodeGeneratorInspector.py:

(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.init):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.init):
(TypeData.get_binding):

  • inspector/ConsoleMessage.cpp:
  • inspector/InspectorValues.h:
05:40 Changeset [105059] by carlosgc@webkit.org
  • 4 edits in trunk

[GTK] Update NEWS and configure.ac for 1.7.4 release
https://bugs.webkit.org/show_bug.cgi?id=76375

Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.4.
05:35 Changeset [105058] by pfeldman@chromium.org
  • 5 edits
    3 adds in trunk

Web Inspector: editing body multiplies head
https://bugs.webkit.org/show_bug.cgi?id=62272

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-01-15
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html-body.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::insertBefore):

  • inspector/DOMEditor.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

LayoutTests:

  • inspector/elements/resources/set-outer-html-body-iframe.html: Added.
  • inspector/elements/set-outer-html-body-expected.txt: Added.
  • inspector/elements/set-outer-html-body.html: Added.
05:08 Changeset [105057] by zimmermann@webkit.org
  • 15 edits in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Change the way we store x/y/dx/dy/rotate values for a <text> element and its ancestors.

SVGTextLayoutAttributesBuilder used to hold a Vector<float> for x/y/dx/dy/rotate, each as big
as the whole text subtree length. For each character, that has an absolute position, or rotation
the value was stored in this list. For all other characters a special empty value marker was stored.

This is highly inefficient, and is now replaced with a HashMap<unsigned, SVGCharacterData> where
SVGCharacterData is a struct, holding float x/y/dx/dy/rotate. The code is now optimized for the
common case, where only a few characters actually specify such values, eg:
<text x="50" y="90">looooong text<tspan x="50" y="30">abc</tspan></text>.

NOTE: There are still some inefficiencies in this patch (especially the copying of SVGTextLayoutAttributes).
To keep the patch size smaller, I decided to fix this in another patch, and only fix the memory issue with this patch.

This reduces the memory consumption from 35MB to 10MB on the attached testcase in bug 65711.

Doesn't affect any test, yet. A follow-up commit will enable the usage of the simple code path, using WidthIterator,
in SVGTextMetricsBuilder, which will result in several layout test changes, because of geometry changes.

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::RenderSVGInlineText):
(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGInlineText.h:

(WebCore::RenderSVGInlineText::layoutAttributes):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::swapItemsInLayoutAttributes):
(WebCore::findFirstAndLastAttributesInVector):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::dumpSVGCharacterDataMapValue):
(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributes.h:

(WebCore::SVGTextLayoutAttributes::characterDataMap):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):
(WebCore::processRenderSVGInlineText):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
(WebCore::updateCharacterData):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutAttributesBuilder.h:

(WebCore::SVGTextLayoutAttributesBuilder::clearTextPositioningElements):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextLayoutEngine.h:

(WebCore::SVGTextLayoutEngine::layoutAttributes):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):

05:00 Changeset [105056] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSCanvasValue can't be renamed, enforce this at compile-time.
<http://webkit.org/b/76352>

Reviewed by Antti Koivisto.

Have the CSSCanvasValue constructor take the name as an argument instead of
having a setName() that's only called from one place in CSSParser.

  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::create):
(WebCore::CSSCanvasValue::CSSCanvasValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCanvas):

04:57 Changeset [105055] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
<http://webkit.org/b/76374>

Reviewed by Antti Koivisto.

Pass CSSValueLtr/CSSValueRtl directly to setProperty() instead of parsing "ltr"/"rtl".

  • css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

04:25 Changeset [105054] by carlosgc@webkit.org
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Fix typo.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
04:19 Changeset [105053] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
https://bugs.webkit.org/show_bug.cgi?id=76369

Reviewed by Xan Lopez.

If there's an installed version of webkit and there are new
symbols in the build tree, gtkdoc-scanobj fails due to undefined
references, because the env ldflags are given before the local
ones.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

04:05 Changeset [105052] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code
https://bugs.webkit.org/show_bug.cgi?id=76043

Re-use appendAuthorStylesheets() from within CSSStyleSelector constructor.

Reviewed by Antti Koivisto.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/StyleSheetList.h:

(WebCore::StyleSheetList::vector):

03:40 UsingGitWithWebKit edited by peter@chromium.org
Revert spam-change (diff)
03:39 BuildBot edited by peter@chromium.org
Revert spam-change (diff)
03:32 Changeset [105051] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r105040.
http://trac.webkit.org/changeset/105040
https://bugs.webkit.org/show_bug.cgi?id=76373

Breaks Win (dbg) canary builder (Requested by apavlov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-16

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Removed.
  • tests/data/event_target.html: Removed.
03:31 Changeset [105050] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[crash] Renderer crashes when spell checking a disabled input field.
https://bugs.webkit.org/show_bug.cgi?id=75941

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-16
Reviewed by Hajime Morita.

.:

  • ManualTests/editing-disabled-node-replace-crash.html: Added.

Source/WebCore:

We confirm the selection is editable before replacing text.

Tests: ManualTests/editing-disabled-node-replace-crash.html

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

03:28 Changeset [105049] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac.
https://bugs.webkit.org/show_bug.cgi?id=75865

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.

Source/WebCore:

  • WebCore.exp.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyDisplay::isValidDisplayValue):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):

  • rendering/FilterEffectRenderer.cpp:
  • svg/SVGElementInstance.idl:

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):

03:09 Changeset [105048] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compilation error on build-webkit --debug --no-request-animation-frame on mac.
https://bugs.webkit.org/show_bug.cgi?id=75875

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.

  • dom/Document.cpp:

(WebCore::Document::windowScreenDidChange):

03:04 Changeset [105047] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark two inspector/debugger tests as SLOW on Linux Debug.

  • platform/chromium/test_expectations.txt:
02:55 Changeset [105046] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, suppres webaudio/gain.html failures on Windows.

  • platform/chromium/test_expectations.txt:
02:51 Changeset [105045] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341

Unreviewed trivial buildfix/typo fix after r105043.

  • inspector/front-end/WebKit.qrc:
02:23 Changeset [105044] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Solaris Studio supports alignment macros too
https://bugs.webkit.org/show_bug.cgi?id=75453

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-16
Reviewed by Hajime Morita.

  • wtf/Alignment.h:
01:56 Changeset [105043] by vsevik@chromium.org
  • 7 edits
    1 move
    1 add in trunk/Source/WebCore

Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341

Fixed dialog: in old implementation dialog never hides if you press mouse button
on Go button and release it somewhere else.
Dialog functionality extracted to be used for search dialog.

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Dialog.js: Added.

(WebInspector.Dialog):
(WebInspector.Dialog.show):
(WebInspector.Dialog.prototype._hide):
(WebInspector.Dialog.prototype._onFocus):
(WebInspector.Dialog.prototype._doFocus):
(WebInspector.Dialog.prototype._position):
(WebInspector.Dialog.prototype._onKeyDown):
(WebInspector.Dialog.prototype._onClick):
(WebInspector.DialogDelegate):
(WebInspector.DialogDelegate.prototype.get defaultFocusedElement):
(WebInspector.DialogDelegate.prototype.get okButton):
(WebInspector.DialogDelegate.prototype.onAction):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog):
(WebInspector.GoToLineDialog._show):
(WebInspector.GoToLineDialog.prototype.get defaultFocusedElement):
(WebInspector.GoToLineDialog.prototype.get okButton):
(WebInspector.GoToLineDialog.prototype.onAction):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/dialog.css: Renamed from Source/WebCore/inspector/front-end/goToLineDialog.css.

(.dialog-glass-pane):
(.dialog):
(.dialog-contents):
(.go-to-line-dialog input):
(.go-to-line-dialog button):
(.go-to-line-dialog button:active):

  • inspector/front-end/inspector.html:
01:41 Changeset [105042] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Build fix when using pango as font backends.
https://bugs.webkit.org/show_bug.cgi?id=76368

Unreviewed build fix.

  • ewk/ewk_view.cpp: include RefPtrCairo.h
01:37 Changeset [105041] by jochen@chromium.org
  • 7 edits in trunk

ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350

Reviewed by Adam Barth.

Source/WebCore:

The CachedResourceLoader only keeps a raw pointer to a ScriptElement.
If an async ScriptElement is removed from the document before it is
executed, it might be garbage collected before the script is loaded, so
it's never run.

By making the ScriptRunner keep an explicit reference to the
ScriptElement while it's loading (as is done for sync ScriptElements),
we can guarantee that the ScriptElement lives until it is executed.

No more flaky timeouts: http/tests/misc/async-script.html:

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::~ScriptRunner):
(WebCore::ScriptRunner::queueScriptForExecution):
(WebCore::ScriptRunner::notifyScriptReady):

  • dom/ScriptRunner.h:

(WebCore::ScriptRunner::hasPendingScripts):

LayoutTests:

  • http/tests/misc/async-script.html:
  • platform/qt/Skipped: unskip http/tests/misc/async-script.html
01:23 Changeset [105040] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

Reland chromium event dispatch test from https://bugs.webkit.org/show_bug.cgi?id=72988
https://bugs.webkit.org/show_bug.cgi?id=73837

The original patch had a mistake that caused it to fail (not sure how I
missed that or why the bots didn't catch it).

Patch by Dave Michael <dmichael@chromium.org> on 2012-01-16
Reviewed by Hajime Morita.

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Added.

(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::DispatchEventTest::createMessageEvent):
(WebKit::TEST_F):

  • tests/data/event_target.html: Added.
01:16 Changeset [105039] by reni@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; added WebCore.exp.in changes lost in r105036.

  • WebCore.exp.in:
00:47 Changeset [105038] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350

  • platform/qt/Skipped: Skip http/tests/misc/async-script.html until fix.
00:42 Changeset [105037] by yuqiang.xian@intel.com
  • 6 edits in trunk/Source/JavaScriptCore

Build fix on 32bit if verbose debug is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=76351

Reviewed by Hajime Morita.

Mostly change "%lu" to "%zu" to print a "size_t" variable.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

01/15/12:

23:33 Changeset [105036] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Add DeviceOrientationEvent.absolute
https://bugs.webkit.org/show_bug.cgi?id=51742

Patch by Xinchao He <xinchao.he@intel.com> on 2012-01-15
Reviewed by Darin Fisher.

This patch add the DeviceOrientationEvent.absolute to follow the
latest w3c device orientation event spec.
http://www.w3.org/TR/orientation-event/

Source/WebCore:

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • dom/DeviceOrientation.cpp:

(WebCore::DeviceOrientation::create):
(WebCore::DeviceOrientation::DeviceOrientation):
(WebCore::DeviceOrientation::absolute):
(WebCore::DeviceOrientation::canProvideAbsolute):

  • dom/DeviceOrientation.h:
  • dom/DeviceOrientationEvent.idl:

Source/WebKit/chromium:

  • public/WebDeviceOrientation.h:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):

  • src/WebDeviceOrientation.cpp:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):
(WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):

20:03 Changeset [105035] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

The C calling convention logic in DFG::SpeculativeJIT should be available even
when not generating code for the DFG speculative path
https://bugs.webkit.org/show_bug.cgi?id=76355

Reviewed by Dan Bernstein.

Moved all of the logic for placing C call arguments into the right place (stack
or registers) into a new class, DFG::CCallHelpers. This class inherits from
AssemblyHelpers, another DFG grab-bag of helper functions. I could have moved
this code into AssemblyHelpers, but decided against it, because I wanted to
limit the number of methods each class in the JIT has. Hence now we have a
slightly odd organization of JIT classes in DFG: MacroAssembler (basic instruction
emission) <= AssemblyHelpers (some additional JS smarts) <= CCallHelpers
(understands calls to C functions) <= JITCompiler (can compile a graph to machine
code). Each of these except for JITCompiler can be reused for stub compilation.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGCCallHelpers.h: Added.

(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

16:57 Changeset [105034] by kling@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix wrong bug URL in ChangeLog.

15:18 Changeset [105033] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove external references to CSSPrimitiveValue::UnitTypes enum.
https://bugs.webkit.org/show_bug.cgi?id=76229

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::isCacheable):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isUnitTypeLength):
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isIdent):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isString):
(WebCore::CSSPrimitiveValue::isURI):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

15:08 BuildBot edited by gulendekorasyon@gmail.com
(diff)
15:07 WikiStart edited by gulendekorasyon@gmail.com
(diff)
15:06 UsingGitWithWebKit edited by gulendekorasyon@gmail.com
(diff)
15:02 WikiStart edited by gulendekorasyon@gmail.com
(diff)
12:14 Changeset [105032] by commit-queue@webkit.org
  • 11 edits in trunk

Fix compilation errors on build-webkit --debug --no-video on mac.
https://bugs.webkit.org/show_bug.cgi?id=75867

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-15
Reviewed by Philippe Normand.

Source/JavaScriptCore:

Make ENABLE_VIDEO_TRACK conditional on ENABLE_VIDEO, video track feature
doesn't build without video.

  • wtf/Platform.h:

Source/WebCore:

  • Some exported HTMLMediaElement symbols were guarded by FULLSCREEN_API feature instead of VIDEO.
  • Unused parameter warning in CanvasRenderingContext::wouldTaintOrigin().
  • RenderThemeMac::shouldShowPlaceholderWhenFocused() implementation wrongly guarded by VIDEO feature.
  • WebCore.exp.in:
  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • rendering/RenderThemeMac.mm:

Source/WebKit/mac:

  • WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded by VIDEO feature instead of FULLSCREEN_API.
  • _isAnyMoviePlaying implementation depends on VIDEO.
  • WebCoreSupport/WebChromeClient.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _isAnyMoviePlaying]):

Tools:

Add --[no-]video-track to build-webkit, since video track feature
depends on video.

  • Scripts/build-webkit:
11:42 Changeset [105031] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParser: Fix failing assertion below BorderImageQuadParseContext.
<http://webkit.org/b/76343> and <rdar://problem/10584969>

Reviewed by Antti Koivisto.

No longer asserts: fast/borders/inline-mask-overlay-image-outset-vertical-rl.html

  • css/CSSParser.cpp:

(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):

Clone CSSValues by copying the RefPtrs instead of going through
the CSSValuePool's create-from-double factory. This prevents an
assertion when the incoming value is CSSValueAuto.

11:01 WikiStart edited by robert@roberthogan.net
(diff)
09:17 Changeset [105030] by robert@webkit.org
  • 6 edits
    2 adds in trunk

<embed> width and height properties propagate to parent object node
https://bugs.webkit.org/show_bug.cgi?id=17688

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html

WebKit seems to have inherited this behaviour from KHTML. When the width/height
of an <embed> element is set, it propagates the values up to any parent <object>
element. There doesn't seem to be any good reason for this and it is not consistent
with the behaviour of Firefox and Opera.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::attributeChanged): Removed

  • html/HTMLEmbedElement.h:

(WebCore::HTMLEmbedElement::attributeChanged): Removed

LayoutTests:

  • fast/dom/insertedIntoDocument-child-expected.txt:
  • fast/dom/insertedIntoDocument-sibling-expected.txt: These tests were added by http://trac.webkit.org/changeset/81611. The fact that an <embed> element inserted into the document no longer passes its height/width up to its parent object node seems to prevent the node getting removed by a simple garbage collection now so the <embed> added by the test is still there at the end, creating the trailing spaces. This is consistent with Opera's treatment of the test, FF is entirely different - it doesn't add the embed node in the first place. So given that the purpose of the test is to cause a crash (?), the change in result seems benign.
  • fast/images/embed-does-not-propagate-dimensions-to-object-ancestor-expected.txt: Added.
  • fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html: Added. This tests that the width/height for an embed element does not get propagated to the parent object.
06:20 WikiStart edited by gulendekorasyon@gmail.com
(diff)
05:48 Changeset [105029] by robert@webkit.org
  • 5 edits in trunk/Source/WebCore

compareBorders() is called too often during painting
https://bugs.webkit.org/show_bug.cgi?id=73349

Reviewed by Julien Chaffraix.

Collapsed borders are re-calculated every time they are painted.
This is unnecessary, they only change with the layout or style so calculate and
cache them whenever the layout or style changes and use the cached values when
painting. The cache is stored in the table section so that the memory footprint
of a table is only increased when it has collapsing borders.

The gain in performance here consists of skipping collapsed border computation
during painting. The only path that incurs a small performance penalty is the
additional get/set on the cache when a collapsed border is computed. This penalty only applies
during style change, layout, or when the width of the table is calculated. The computed
border value is not stored in the cache when it has been calculated without its color
for borderHalfStart and co., so that code path is unaffected by this change.

No new tests, covered by existing collapsed border tests.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeDestroyed): remove entries from collapsed border cache
(WebCore::RenderTableCell::collapsedStartBorder):

Compute, and also cache if the full border including color was computed.

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder): ditto
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):

Inline the function since it is only called in paintCollapsedBorders and remove
includeColor as a parameter. Move the call to the table's style to the caller rather
than call it 4 times in a row. Use the cached border values directly.

(WebCore::RenderTableCell::cachedCollapsedRightBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedTopBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedBottomBorder): ditto
(WebCore::RenderTableCell::paintCollapsedBorders):

This function always uses the collapsed border cache now.

  • rendering/RenderTableCell.h: Make the collapsed border functions private.
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::removeCachedCollapsedBorders): The cache is deleted by the HashMap

since it is the only owner of the cached item.

(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

This will assert if there is no cached collapsed border for the side of the
cell requested by the caller.

  • rendering/RenderTableSection.h: HashMap wouldn't let me use CollapsedBorderSide in the key value for the cache so use int instead.

01/14/12:

19:14 Changeset [105028] by levin@chromium.org
  • 8 edits
    1 move in trunk/Source

HWndDC should be in platform/win instead of wtf.
https://bugs.webkit.org/show_bug.cgi?id=76314

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Source/WebCore:

No new functionality, so no new tests.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/HWndDC.h: Renamed from Source/JavaScriptCore/wtf/win/HWndDCWin.h.

I also made the class non-copyable.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

17:24 Changeset [105027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=76339

Take a page from the Gtk and Qt ports and quiet these logs unless they
are explicitly enabled via environment variable.

Patch by Adam Treat <atreat@rim.com> on 2012-01-14
Reviewed by George Staikos.

  • platform/blackberry/LoggingBlackBerry.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

16:31 Changeset [105026] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialStorage::CreateCurrentPersistentCredentials + 298

Reviewed by Anders Carlsson.

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::initializeSecItemShim): Removed an early return that was accidentally added in r105008.

15:53 Changeset [105025] by robert@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Chromium results for test added by r105021

Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
12:46 Changeset [105024] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Change expected failures from IMAGE+TEXT to TEXT on Mac.

The Mac bots do not check pixel results so displays results suppressed
as IMAGE+TEXT as unexpected failures. Change the suppressions to TEXT.
These results require rebaseline since the changes landed in r103251.

Unreviewed gardening.

  • platform/mac/test_expectations.txt:
12:31 Changeset [105023] by robert@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove reference result added in r105021.

This reference result only works in chromium-linux and qt it seems,
so remove it and allow ports to add port-specific png results.

Unreviewed.

  • css2.1/20110323/outline-color-applies-to-008-expected.html: Removed.
11:28 Changeset [105022] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
https://bugs.webkit.org/show_bug.cgi?id=76313

Patch by James Robinson <jamesr@chromium.org> on 2012-01-14
Reviewed by Adam Barth.

The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.

  • Scripts/run-chromium-webkit-unit-tests:
11:13 Changeset [105021] by robert@webkit.org
  • 5 edits
    30 adds in trunk

CSS 2.1 failure: outline-color-applies-to* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71944

Reviewed by Julien Chaffraix.

Source/WebCore:

Paint the outline color for row, row-group, header-group and footer-group
elements.

Tests: css2.1/20110323/outline-color-applies-to-001.htm

css2.1/20110323/outline-color-applies-to-002.htm
css2.1/20110323/outline-color-applies-to-003.htm
css2.1/20110323/outline-color-applies-to-004.htm
css2.1/20110323/outline-color-applies-to-005.htm
css2.1/20110323/outline-color-applies-to-006.htm
css2.1/20110323/outline-color-applies-to-007.htm
css2.1/20110323/outline-color-applies-to-008.htm
css2.1/20110323/outline-color-applies-to-009.htm
css2.1/20110323/outline-color-applies-to-010.htm
(There is no outline-color-applies-to-011.htm in the test suite.)
css2.1/20110323/outline-color-applies-to-012.htm
css2.1/20110323/outline-color-applies-to-013.htm
css2.1/20110323/outline-color-applies-to-014.htm
css2.1/20110323/outline-color-applies-to-015.htm
fast/css/outline-color-self-painting-row.htm

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::paintOutlineForRowIfNeeded): Wrapper function for painting the outline for the row.

This is used by RenderTableSection::paintObject and RenderTableRow::paint

(WebCore::RenderTableRow::paint): For rows with a self-painting layer, paint the outline. Tested by

fast/css/outline-color-self-painting-row.htm.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paint): Paint the outline for header-group, row-group and footer-groups.
(WebCore::RenderTableSection::paintObject): When iterating through the cells paint the outline of rows as required.
Doing it here avoids the need to walk the RenderTableSection's tree separately elsewhere.

LayoutTests:

  • css2.1/20110323/outline-color-applies-to-001-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-001.htm: Added.
  • css2.1/20110323/outline-color-applies-to-002-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-002.htm: Added.
  • css2.1/20110323/outline-color-applies-to-003-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-003.htm: Added.
  • css2.1/20110323/outline-color-applies-to-004-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-004.htm: Added.
  • css2.1/20110323/outline-color-applies-to-005-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-005.htm: Added.
  • css2.1/20110323/outline-color-applies-to-006-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-006.htm: Added.
  • css2.1/20110323/outline-color-applies-to-007-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-007.htm: Added.
  • css2.1/20110323/outline-color-applies-to-008-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-008.htm: Added.
  • css2.1/20110323/outline-color-applies-to-009-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-009.htm: Added.
  • css2.1/20110323/outline-color-applies-to-010-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-010.htm: Added.
  • css2.1/20110323/outline-color-applies-to-012-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-012.htm: Added.
  • css2.1/20110323/outline-color-applies-to-013-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-013.htm: Added.
  • css2.1/20110323/outline-color-applies-to-014-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-014.htm: Added.
  • css2.1/20110323/outline-color-applies-to-015-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-015.htm: Added.
  • fast/css/outline-color-self-painting-row-expected.html: Added.
  • fast/css/outline-color-self-painting-row.htm: Added.
11:11 Changeset [105020] by dslomov@google.com
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove WebKit::WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76327

Reviewed by Darin Fisher.

  • public/WebWorker.h: Removed.
  • src/WebWorkerClientImpl.cpp:
07:51 Changeset [105019] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

Unmatched transparency layer begin/end on a filtered element with an opacity ancestor
https://bugs.webkit.org/show_bug.cgi?id=76329

Source/WebCore:

Reviewed by Dan Bernstein.

When doing a paint with painting disabled on the GraphicsContext, as we do
for updating control tints, or computing text rectangles on Find, do not
apply filter effects. This is both a performance gain, and fixes an issue
with mismatched begin/end transparency layers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

Reviewed by Dan Bernstein.

Manual test with a filtered element as a descendant of an element with
opacity. Doing a Find is necessary to exercise the test.

  • ManualTests/filters/opacity-above-filter.html: Added.
05:43 Changeset [105018] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r105017.
http://trac.webkit.org/changeset/105017
https://bugs.webkit.org/show_bug.cgi?id=76333

broke the build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-14

  • gtk/jhbuild.modules:
05:23 Changeset [105017] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-14
Reviewed by Philippe Normand.

  • gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.

01/13/12:

20:41 Changeset [105016] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Skip test that started failing after r105015.

  • platform/qt/Skipped:
19:03 Changeset [105015] by ojan@chromium.org
  • 26 edits in trunk

Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Intentially gets computed style for flex-item-align:auto wrong.
Will fix this in a followup patch.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
18:47 Changeset [105014] by efidler@rim.com
  • 2 edits in trunk

GCC compiler version is not detected properly for QNX qcc variant
https://bugs.webkit.org/show_bug.cgi?id=76288

Reviewed by Rob Buis.

Provide an alternative way of getting the compiler version for GCC variants
that don't support -dumpversion (such as qcc).

  • Source/cmake/WebKitHelpers.cmake:
17:13 Changeset [105013] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Build correction after r104919.

  • WebCore.vcproj/WebCore.vcproj: Exclude ShadowContentSelectorQuery.cpp from the build, since it is built as part of DOMAllInOne.cpp.
16:42 Changeset [105012] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

16:28 Changeset [105011] by scheib@chromium.org
  • 5 edits in trunk

Pointer Lock: Change isLocked() from operator to attribute isLocked
https://bugs.webkit.org/show_bug.cgi?id=76311

Reviewed by Adam Barth.

Source/WebCore:

This patch implements the recent Mouse Lock Specification update
changing navigator.pointer.isLocked() to .isLocked.

Test pointer-lock/pointer-lock-api.html updated to new spec.

  • page/PointerLock.idl:

LayoutTests:

  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
16:25 Changeset [105010] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.5

New tag.

16:13 Changeset [105009] by jochen@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
https://bugs.webkit.org/show_bug.cgi?id=57600

Reviewed by Adam Barth.

  • http/tests/security/resources/cors-redirect.php: Added.
  • http/tests/security/resources/empty.html: Added.
  • http/tests/security/xhr-cors-redirect-expected.txt: Added.
  • http/tests/security/xhr-cors-redirect.html: Added.
16:08 Changeset [105008] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Delay updating the root compositing layer if the layer tree state is frozen
https://bugs.webkit.org/show_bug.cgi?id=76316

Reviewed by Dan Bernstein.

When the layer tree is frozen, stash the root layer in m_pendingRootCompositingLayer and set it in flushLayers.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

16:01 Changeset [105007] by commit-queue@webkit.org
  • 5 edits in trunk

noteOn, noteGrainOn and noteOff idl should take doubles
https://bugs.webkit.org/show_bug.cgi?id=76073

Patch by Raymond Toy <rtoy@google.com> on 2012-01-13
Reviewed by Adam Barth.

Source/WebCore:

Existing audiobuffersource-playbackrate and gain tests cover the
noteOn and noteOff changes.

  • webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and

noteOff take doubles.

LayoutTests:

  • webaudio/audiobuffersource-playbackrate-expected.wav: Updated
  • webaudio/gain-expected.wav: Updated
15:58 Changeset [105006] by bdakin@apple.com
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=71230
Clicking where the overlay scroll track would be should not scroll the page
-and corresponding-
<rdar://problem/9585424>

Reviewed by Alexey Proskuryakov.

These new functions indicate whether the scrollbar should participate in hit
testing. Non-overlay scrollbars always should, so they return true. Overlay
scrollbars consult the animator, which checks the current alpha.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::shouldScrollbarParticipateInHitTesting):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar:: shouldParticipateInHitTesting):

  • platform/Scrollbar.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac:: shouldScrollbarParticipateInHitTesting):

In these hit-testing functions, only hit-test when the scrollbar should
participate.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarAtPoint):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestOverflowControls):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isPointInOverflowControl):

15:56 Changeset [105005] by mitz@apple.com
  • 5 edits in trunk

REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
https://bugs.webkit.org/show_bug.cgi?id=76254

Reviewed by Anders Carlsson.

Source/WebCore:

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.

LayoutTests:

  • svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.

Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.

  • svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
15:52 Changeset [105004] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

WebAudio: Optimize calculateNormalizationScale().
https://bugs.webkit.org/show_bug.cgi?id=74372

Reviewed by Eric Carlson.

No new tests; optimization of existing code, so covered by existing test cases.

  • platform/audio/Reverb.cpp:

(WebCore::calculateNormalizationScale): Replace implementation with optimized vector

math operation.

(WebCore::Reverb::Reverb):

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsvesq): Vector math operation for squared sum of elements.

  • platform/audio/VectorMath.h:
15:40 Changeset [105003] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=76307

Reviewed by James Robinson.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

15:39 Changeset [105002] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r104352.

15:35 Changeset [105001] by abarth@webkit.org
  • 2 edits in trunk/Tools

Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

This is the rest of the patch from Bug 76300. I landed it separtely
because main.py had some stray conflict markers that I needed to clean
up first.

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester._run_tests):

15:32 Changeset [105000] by japhet@chromium.org
  • 4 edits in trunk

Source/WebCore: Revert most of the multipart changes in
http://trac.webkit.org/changeset/104756.
https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

http/tests/multipart/invalid-image-data.html
should stop asserting on chromium win dbg.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

LayoutTests: http/tests/multipart/invalid-image-data.html should no longer
be crashing on chromium win dbg.
https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

  • platform/chromium/test_expectations.txt:
15:31 Changeset [104999] by abarth@webkit.org
  • 2 edits in trunk/Tools

test-webkitpy does not run
https://bugs.webkit.org/show_bug.cgi?id=76318

Unreviewed.

Looks like some conflict markers got left in the file.

  • Scripts/webkitpy/test/main.py:

(Tester.run):

15:28 Changeset [104998] by abarth@webkit.org
  • 7 edits in trunk/Tools

Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

We don't use this functionality for anything, and it doesn't really
work. Someone in #webkit tried using it and and got sad/confused. We
should just remove it.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.push_local_commits_to_server):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.init):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(_shared_test_commit_with_message):
(GitSVNTest.test_commit_text_parsing):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.commit_with_message):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.init):
(Bugzilla.quips):
(Bugzilla.authenticate):
(Bugzilla.add_attachment_to_bug):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
(Bugzilla.clear_attachment_flags):
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
(Bugzilla.add_cc_to_bug):
(Bugzilla.post_comment_to_bug):
(Bugzilla.close_bug_as_fixed):
(Bugzilla.reassign_bug):
(reopen_bug):

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run_tests):

15:16 Changeset [104997] by lforschler@apple.com
  • 14 edits in branches/safari-534.54-branch

Merged r104269.

15:13 Changeset [104996] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r104239.

14:58 Changeset [104995] by levin@chromium.org
  • 5 edits in trunk

check-webkit-style: should encourage the use of Own* classes for Windows DC.
https://bugs.webkit.org/show_bug.cgi?id=76227

Reviewed by Dirk Pranke.

Source/JavaScriptCore:

  • wtf/win/HWndDCWin.h:

(WTF::HwndDC::HwndDC): Add a way to do GetDCEx.
There are no users, but I want to catch this in check-webkit-style
and tell any users to use HwndDC to avoid leaks.

Tools:

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_leaky_patterns): The new check.
(process_line): Added a call to the new check.
(CppChecker): Added the new error type.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTestBase):
(CppStyleTestBase.perform_leaky_pattern_check):
The check for only leaky pattern errors.
(LeakyPatternTest): Test cases.

14:52 Changeset [104994] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

14:42 Changeset [104993] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

WebAudio: Use float instead of double values for gain operations.
https://bugs.webkit.org/show_bug.cgi?id=74345

Reviewed by Sam Weinig.

No new tests; optimization of existing code, so covered by existing test cases.

The following functions now take or operate on floats instead of doubles:
(WebCore::AudioBus::scale):
(WebCore::AudioBus::processWithGainFrom):
(WebCore::AudioBus::copyWithGainFrom):
(WebCore::AudioBus::sumWithGainFrom):

  • platform/audio/AudioBus.h:

(WebCore::AudioBus::setGain):
(WebCore::AudioBus::gain):

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::scale):

  • platform/audio/AudioChannel.h:
  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

  • webaudio/AudioBufferSourceNode.h:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.h:
14:42 Changeset [104992] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104119.

14:38 Changeset [104991] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't use pending activity notification in IntentRequest
https://bugs.webkit.org/show_bug.cgi?id=76302

Patch by Greg Billock <gbillock@google.com> on 2012-01-13
Reviewed by Adam Barth.

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

14:34 Changeset [104990] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104094.

14:29 Changeset [104989] by lforschler@apple.com
  • 6 edits
    3 copies in branches/safari-534.54-branch

Merged r104086.

14:20 Changeset [104988] by lforschler@apple.com
  • 3 edits
    12 copies in branches/safari-534.54-branch

Merged r103981.

14:18 Changeset [104987] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

EQUALPOWER panner incorrectly computes gain
https://bugs.webkit.org/show_bug.cgi?id=75767

Source/WebCore:

Patch by Raymond Toy <rtoy@google.com> on 2012-01-13
Reviewed by Kenneth Russell.

Layout test added.

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan): Correct the formula.

LayoutTests:

Patch by Raymond Toy <rtoy@chromium.org> on 2012-01-13
Reviewed by Kenneth Russell.

  • webaudio/panner-equalpower.html: Added.
  • webaudio/panner-equalpower-expected.txt: Added.
  • webaudio/resources/panner-model-testing.js: Added.
  • webaudio/resources/audio-testing.js:

(createImpulseBuffer): New common utility function.

14:15 Changeset [104986] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Implement TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=76308

Reviewed by Sam Weinig.

Keep track of whether the layer tree state is frozen and suspend/resume the layer flush scheduler accordingly.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::layerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

14:00 Changeset [104985] by ojan@chromium.org
  • 26 edits in trunk

Unreviewed, rolling out r104972.
http://trac.webkit.org/changeset/104972
https://bugs.webkit.org/show_bug.cgi?id=75782

Broke some tests

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:39 Changeset [104984] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Rollout 99999 (104249).

13:38 Changeset [104983] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable implicit animations when setting the root compositing layer
https://bugs.webkit.org/show_bug.cgi?id=76304

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

13:31 Changeset [104982] by dpranke@chromium.org
  • 1 edit in trunk/Tools/ChangeLog

fix changelog

13:24 Changeset [104981] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source

Unreviewed build fix for Qt SnowLeopard build bot.

This is a workaround for the moment.

  • wtf/Platform.h:
13:23 Changeset [104980] by dpranke@chromium.org
  • 4 edits in trunk/Tools

test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

% test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

% test-wekbitpy webkitpy.test.cat_unittest

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/cat_unittest.py:
  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

13:23 Changeset [104979] by eae@chromium.org
  • 9 edits in branches/subpixellayout/Source/WebCore

Windows build fixes for WebCore.

13:20 Changeset [104978] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

-[WebTileCacheLayer setNeedsDisplay] doesn't trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=76299

Reviewed by Simon Fraser.

Override -[WebTileCacheLayer setNeedsDisplay] and call TileCache::setNeedsDisplay from there,
instead of ending up with a huge rectangle in TileCache::setNeedsDisplayInRect which causes our
tile computation logic to fail due to integer overflow when converting from CGFloats to ints.

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplay):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setNeedsDisplay]):

13:16 Changeset [104977] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

% test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

% test-wekbitpy webkitpy.test.cat_unittest

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/cat_unittest.py:
  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

13:16 Changeset [104976] by levin@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Header file is missing header guard.

Reviewed by Dirk Pranke.

  • wtf/win/HWndDCWin.h: Added the guards.
12:59 Changeset [104975] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test-webkitpy: add basic code coverage support
https://bugs.webkit.org/show_bug.cgi?id=76201

Reviewed by Adam Barth.

This test adds basic code coverage support to test-webkitpy; if
you pass the -c flag, we will generate a new coverage file. We
can start simply with this and add more features as necessary.

This patch requires coverage to be already installed on the
machine. I am not auto-installing this for now.

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run_tests):

12:54 Changeset [104974] by dpranke@chromium.org
  • 2 edits in trunk/Tools

StatusBubbleTest.test_build_bubble is failing
https://bugs.webkit.org/show_bug.cgi?id=76222

Reviewed by Adam Barth.

  • QueueStatusServer/handlers/statusbubble_unittest.py:

(StatusBubbleTest.test_build_bubble):

12:53 Changeset [104973] by simon.fraser@apple.com
  • 1 edit
    21 adds in trunk/LayoutTests

Add new baselines for various compositing tests which didn't have Mac results.

  • platform/mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/mac/compositing/animation/busy-indicator-expected.txt: Added.
  • platform/mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/mac/compositing/flat-with-transformed-child-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/mac/compositing/repaint/same-size-invalidation-expected.txt: Added.
  • platform/mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/mac/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
12:43 Changeset [104972] by ojan@chromium.org
  • 26 edits in trunk

Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Not 100% sure about this, but I think the computed value of
flex-item-align needs to take the parent's flex-align into
account for computed auto values.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::flexAlign):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:34 Changeset [104971] by jamesr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Update chromium image baselines for cross-fade-invalidation

  • platform/chromium-linux/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-invalidation-expected.png: Added.
12:31 Changeset [104970] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Eval in strict mode does not need dynamic checks
https://bugs.webkit.org/show_bug.cgi?id=76286

Patch by Andy Wingo <wingo@igalia.com> on 2012-01-13
Reviewed by Oliver Hunt.

  • runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):

Eval in strict mode cannot introduce variables, so it not impose
the need for dynamic checks.

12:13 Changeset [104969] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Fix an obviously incorrect expected result image.

Patch by Simon Fraser <simon.fraser@apple.com> on 2012-01-13

  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
11:59 Changeset [104968] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Fix an obviously incorrect expected result image.

  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
11:55 Changeset [104967] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/Tools

nrwt should use multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=75958

Add --max-locked-shards option to the nrwt for manual set
the maximum number of the locked shards

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._max_locked_shards):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ShardingTests.get_shards):
(ShardingTests.test_multiple_locked_shards):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

11:45 Changeset [104966] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Rename GraphicsContext* argument in various RenderLayer methods
https://bugs.webkit.org/show_bug.cgi?id=76283

Reviewed by James Robinson/Anders Carlsson.

Rename the GraphicsContext* parameter "p" in various RenderLayer
methods to "context". "p" was a historical name from when it was
called Painter.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):

11:42 Changeset [104965] by mihnea@adobe.com
  • 14 edits in trunk/Source/WebCore

[CSSRegions]Add back region style code removed in r104036
https://bugs.webkit.org/show_bug.cgi?id=76064

Reviewed by David Hyatt.

No new tests. The region style tests are still skipped. A follow up patch will enable
both region style for background-color and region style tests.

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::useInRegionStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::initRegionRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleInRegion):

  • rendering/RenderObject.h:

(WebCore::RenderObject::canHaveRegionStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):

11:42 Changeset [104964] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch

Merged r103728.

11:41 Changeset [104963] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; added project.pbxproj changes lost in r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906

  • WebCore.xcodeproj/project.pbxproj:
11:40 Changeset [104962] by lforschler@apple.com
  • 7 edits
    6 copies in branches/safari-534.54-branch

Merge 103637.

11:26 Changeset [104961] by jocelyn.turcotte@nokia.com
  • 8 edits
    2 adds in trunk/Source

TextureMapper: Extract layer transform logic to a LayerTransform class.
https://bugs.webkit.org/show_bug.cgi?id=76291

Reviewed by Noam Rosenthal.

Source/WebCore:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/LayerTransform.cpp: Added.

(WebCore::LayerTransform::LayerTransform):
(WebCore::LayerTransform::setPosition):
(WebCore::LayerTransform::setSize):
(WebCore::LayerTransform::setAnchorPoint):
(WebCore::LayerTransform::setFlattening):
(WebCore::LayerTransform::setLocalTransform):
(WebCore::LayerTransform::setChildrenTransform):
(WebCore::LayerTransform::combined):
(WebCore::LayerTransform::combinedForChildren):
(WebCore::LayerTransform::combineTransforms):
(WebCore::LayerTransform::combineTransformsForChildren):

  • platform/graphics/texmap/LayerTransform.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::collectVisibleContentsRects):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::compareGraphicsLayersZValue):
(WebCore::TextureMapperNode::paintSelfAndChildren):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::syncCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::TextureMapperNode):

Source/WebKit2:

Move the paint call before the visible rect collection to make sure that
transforms are computed. This will increase the delay for the visible rects
to get to the WebProcess until we move this calculation out of the UI Process.
This fixes an assert triggering in LayerTransform::combineTransforms.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):

11:24 Changeset [104960] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit/efl

[EFL] SecurityPolicy whitelist interface should be exposed to EWebKit
https://bugs.webkit.org/show_bug.cgi?id=76082

Patch by Leandro Pereira <leandro@profusion.mobi> on 2012-01-13
Reviewed by Andreas Kling.

  • CMakeListsEfl.txt: Added reference to ewk_security_policy.{cpp,h}.
  • ewk/EWebKit.h: Include ewk_security_policy.h.
  • ewk/ewk_security_policy.cpp: Added.

(ewk_security_policy_whitelist_origin_add): Implemented thin layer around SecurityPolicy::addOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_del): Implemented thin layer around SecurityPolicy::removeOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_reset): Implemented thin layer around SecurityPolicy::resetOriginAccessWhitelists().

  • ewk/ewk_security_policy.h: Added.
11:19 Changeset [104959] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix for unused argument warning after r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906

Also fixed up somebody's bad merge in Source/WebCore/ChangeLog.

  • html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::WebGLObject):

11:19 Changeset [104958] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Build correction.

  • Shared/WebGraphicsContext.h: Use proper include path for RefPtrCairo.h.
11:15 Changeset [104957] by jamesr@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Update expectations

  • platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:06 Changeset [104956] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update a few expectations

  • platform/chromium/test_expectations.txt:
11:05 Changeset [104955] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

prepare-ChangeLog: Look for a text editor in a few more variables.
https://bugs.webkit.org/show_bug.cgi?id=76289

Reviewed by Ryosuke Niwa.

A text editor was looked for only in the CHANGE_LOG_EDITOR and
CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
to the OS X-specific open(1) command.

As there does not seem to be a common way of looking for a text editor
among the scripts in Tools/Scripts right now, just look at $VISUAL and
$EDITOR (set much more often than the other variables in Unix systems)
before falling back to open(1).

  • Scripts/prepare-ChangeLog:

(openChangeLogs):

11:02 Changeset [104954] by commit-queue@webkit.org
  • 24 edits
    5 copies
    1 add in trunk

Add WebGLContextGroup as step toward sharing WebGL resources
https://bugs.webkit.org/show_bug.cgi?id=75906

The WebGL Working Group will soon add the ability to share
WebGL resources among WebGL contexts. This is the necessary
prep work. NO API changes.

Added WebGLSharedObject for objects that are shared vs
WebGLContextObject for objects that are not.

Patch by Gregg Tavares <gman@google.com> on 2012-01-13
Reviewed by Kenneth Russell.

No new tests. No change in behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::WebGLBuffer):
(WebCore::WebGLBuffer::~WebGLBuffer):
(WebCore::WebGLBuffer::deleteObjectImpl):

  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLContextGroup.cpp: Added.

(WebCore::WebGLContextGroup::create):
(WebCore::WebGLContextGroup::WebGLContextGroup):
(WebCore::WebGLContextGroup::~WebGLContextGroup):
(WebCore::WebGLContextGroup::getAGraphicsContext3D):
(WebCore::WebGLContextGroup::addContext):
(WebCore::WebGLContextGroup::removeContext):
(WebCore::WebGLContextGroup::removeObject):
(WebCore::WebGLContextGroup::addObject):
(WebCore::WebGLContextGroup::detachAndRemoveAllObjects):
(WebCore::WebGLContextGroup::loseContextGroup):

  • html/canvas/WebGLContextGroup.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.
  • html/canvas/WebGLContextObject.cpp: Copied from Source/WebCore/html/canvas/WebGLShader.cpp.

(WebCore::WebGLContextObject::WebGLContextObject):
(WebCore::WebGLContextObject::~WebGLContextObject):
(WebCore::WebGLContextObject::detachContext):
(WebCore::WebGLContextObject::getAGraphicsContext3D):

  • html/canvas/WebGLContextObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.

(WebCore::WebGLContextObject::context):
(WebCore::WebGLContextObject::validate):
(WebCore::WebGLContextObject::hasGroupOrContext):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::WebGLFramebuffer):
(WebCore::WebGLFramebuffer::~WebGLFramebuffer):
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):

  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::WebGLObject):
(WebCore::WebGLObject::~WebGLObject):
(WebCore::WebGLObject::deleteObject):
(WebCore::WebGLObject::detach):
(WebCore::WebGLObject::onDetached):

  • html/canvas/WebGLObject.h:
  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::~WebGLProgram):
(WebCore::WebGLProgram::deleteObjectImpl):
(WebCore::WebGLProgram::cacheActiveAttribLocations):

  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLRenderbuffer.cpp:

(WebCore::WebGLRenderbuffer::~WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::deleteObjectImpl):

  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::checkObjectToBeBound):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createBuffer):
(WebCore::WebGLRenderingContext::createFramebuffer):
(WebCore::WebGLRenderingContext::createTexture):
(WebCore::WebGLRenderingContext::createProgram):
(WebCore::WebGLRenderingContext::createRenderbuffer):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteObject):
(WebCore::WebGLRenderingContext::deleteRenderbuffer):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateWebGLObject):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::removeSharedObject):
(WebCore::WebGLRenderingContext::addSharedObject):
(WebCore::WebGLRenderingContext::removeContextObject):
(WebCore::WebGLRenderingContext::addContextObject):
(WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
(WebCore::WebGLRenderingContext::initVertexAttrib0):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::loseContextImpl):

  • html/canvas/WebGLRenderingContext.h:

(WebCore::WebGLRenderingContext::contextGroup):

  • html/canvas/WebGLShader.cpp:

(WebCore::WebGLShader::WebGLShader):
(WebCore::WebGLShader::~WebGLShader):
(WebCore::WebGLShader::deleteObjectImpl):

  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLSharedObject.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderbuffer.cpp.

(WebCore::WebGLSharedObject::WebGLSharedObject):
(WebCore::WebGLSharedObject::~WebGLSharedObject):
(WebCore::WebGLSharedObject::detachContextGroup):
(WebCore::WebGLSharedObject::getAGraphicsContext3D):

  • html/canvas/WebGLSharedObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.

(WebCore::WebGLSharedObject::contextGroup):
(WebCore::WebGLSharedObject::isBuffer):
(WebCore::WebGLSharedObject::isFramebuffer):
(WebCore::WebGLSharedObject::isProgram):
(WebCore::WebGLSharedObject::isRenderbuffer):
(WebCore::WebGLSharedObject::isShader):
(WebCore::WebGLSharedObject::isTexture):
(WebCore::WebGLSharedObject::validate):
(WebCore::WebGLSharedObject::hasGroupOrContext):

  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::~WebGLTexture):
(WebCore::WebGLTexture::deleteObjectImpl):

  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):

  • html/canvas/WebGLVertexArrayObjectOES.h:
10:43 Changeset [104953] by lforschler@apple.com
  • 5 edits
    6 copies in branches/safari-534.54-branch

Merged r103636.

10:40 Changeset [104952] by lforschler@apple.com
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r103594.

10:37 Changeset [104951] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r103587.

10:35 Changeset [104950] by lforschler@apple.com
  • 6 edits
    3 copies in branches/safari-534.54-branch

Merged r103482.

10:26 Changeset [104949] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r103286.

10:05 Changeset [104948] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebCore

[soup] Initialize m_soupFlags in all ResourceResponse constructors.

Rubber-stamped by Gustavo Noronha Silva.

m_soupFlags was being initialized in two of the three ResourceResponse
constructors, causing some trouble in
FrameLoaderClient::dispatchDidReceiveResponse (ports which use
ResourceRequest::setSoupMessageFlags with the response's unitialized
flags).

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

09:58 Changeset [104947] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

CFURLRef to KURL conversion shouldn't turn raw paths into file URLs
https://bugs.webkit.org/show_bug.cgi?id=76251

Reviewed by Dan Bernstein.

  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Removed the offending code.
09:51 Changeset [104946] by levin@chromium.org
  • 5 edits
    1 move in trunk/Source

HWndDC is a better name than HwndDC.
https://bugs.webkit.org/show_bug.cgi?id=76281

Reviewed by Darin Adler.

Source/JavaScriptCore:

(WTF::HWndDC::HWndDC):
(WTF::HWndDC::~HWndDC):
(WTF::HWndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

09:43 Changeset [104945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Disconnecting the front-end does not disable profiling.
https://bugs.webkit.org/show_bug.cgi?id=76213

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-13
Reviewed by Pavel Feldman.

Not testable.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::clearFrontend):

09:41 Changeset [104944] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark a flaky test as flaky

  • platform/chromium/test_expectations.txt:
09:41 Changeset [104943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix missing signal in qwebframe API test for Qt5
https://bugs.webkit.org/show_bug.cgi?id=76195

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-01-13
Reviewed by Noam Rosenthal.

In Qt5 QObject has a new signal with this signature: "objectNameChanged(QString)".

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::enumerate_data):

09:04 Changeset [104942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
https://bugs.webkit.org/show_bug.cgi?id=76269

Reviewed by Martin Robinson.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

08:35 Changeset [104941] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
<http://webkit.org/b/76271>

Reviewed by Darin Adler.

Use JSC::Weak::swap() to move JSDOMWrappers into the DOMWrapperWorld's wrapper map.
This avoids invoking the JSC::Weak copy constructor and associated HandleHeap churn.

  • bindings/js/JSDOMBinding.h:

(WebCore::cacheWrapper):

08:28 Changeset [104940] by vsevik@chromium.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Added.

(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h: Added.

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Added.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
08:20 Changeset [104939] by kling@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Test that cloneNode() doesn't cause crashes when used directly after stylesheet mutation.
<http://webkit.org/b/75987>

Reviewed by Antti Koivisto.

  • fast/css/cloneNode-after-deleteRule-crash-expected.txt: Added.
  • fast/css/cloneNode-after-deleteRule-crash.html: Added.
  • fast/css/resources/cloneNode-after-deleteRule-subdocument.html: Added.
08:03 Changeset [104938] by vsevik@chromium.org
  • 12 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104935.
http://trac.webkit.org/changeset/104935
https://bugs.webkit.org/show_bug.cgi?id=76277

Breaks AppleWin compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-13

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Removed.
  • inspector/InspectorIndexedDBAgent.h: Removed.
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Removed.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
07:49 Changeset [104937] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove extern "C" from ewk_private.h
https://bugs.webkit.org/show_bug.cgi?id=76250

Reviewed by Andreas Kling.

ewk_private.h defines internal functions used by WebKit itself. There is no chance to be used by C application.
So, extern "C" keyword is unneeded in ewk_private.h.

  • ewk/ewk_private.h:
07:44 Changeset [104936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[EFL] Add OwnPtr specialization for Eina_Module.
https://bugs.webkit.org/show_bug.cgi?id=76255

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.

Add an overload for deleteOwnedPtr(Eina_Module*) on EFL port.

  • wtf/OwnPtrCommon.h:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):

07:08 Changeset [104935] by vsevik@chromium.org
  • 12 edits
    3 adds in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Added.

(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h: Added.

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Added.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
07:04 Changeset [104934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build when using TextureMapper with OpenGL/ES
https://bugs.webkit.org/show_bug.cgi?id=76268

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-13
Reviewed by Tor Arne Vestbø.

  • WebCore.pri: When the texture mapper uses OpenGL/ES, then it also relies on the

availability of libEGL by using eglGetCurrentContext(). In that case we need to link against
libEGL.

06:58 Changeset [104933] by jochen@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Don't artifically keep IDBDatabase objects alive if there are no references to it.
https://bugs.webkit.org/show_bug.cgi?id=75859

Originally, this code was added to keep the IDBDatabase object alive
even if no reference from JavaScript to the object existed, because
running transactions could still send events for this database
connection. Meanwhile, transactions are marked as active DOM objects
during their lifetime, and they keep a RefPtr to the IDBDatabase
object, so this hack is no longer required.

Reviewed by Tony Gentilcore.

Test: storage/indexeddb/delete-closed-database-object.html

  • storage/IDBDatabase.cpp:
  • storage/IDBDatabase.h:

LayoutTests: Test that an IDBDatabase object is garbage collected once no further references to it exist.
https://bugs.webkit.org/show_bug.cgi?id=75859

Reviewed by Tony Gentilcore.

  • storage/indexeddb/delete-closed-database-object-expected.txt: Added.
  • storage/indexeddb/delete-closed-database-object.html: Added.
06:41 Changeset [104932] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebCore

TextureMapper: Do the node transform computation when painting.
https://bugs.webkit.org/show_bug.cgi?id=74721

Reviewed by Noam Rosenthal.

The transform of the node tree was built during the syncCompositingState
step. This would cause an ASSERT with QWebView, trying to use a dirty transform
state since the rootTextureMapperNode in QWebFramePrivate::renderCompositedLayers
doesn't run the sync step after getting the world transform set.

This moves the transform computation from the sync to the paint step to
prevent making sure that the sync step has been run on all nodes before painting.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::computeTiles):
Remove an unused variable.
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:
06:39 Changeset [104931] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebCore

TextureMapper: Simplify transform manipulations.
https://bugs.webkit.org/show_bug.cgi?id=74719

Reviewed by Noam Rosenthal.

  • Make sure that the replica node has a complete transform and use it directly instead of keeping a copy in the source.
  • Apply the origin and position translation only once, on the target and descendants transforms.
  • Use to2dTransform() on !preserves3D layers instead of doing the flattening manually.
  • Remove mentions of perspective as this is handled by WebCore through the children transform.
  • Apply the inverse target transform on the replica only where it is needed in paintReflection since it uses the full transform in paintSelf.
  • Merge the base and local transforms.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsSelf):
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::paintReflection):

  • platform/graphics/texmap/TextureMapperNode.h:
06:38 Changeset [104930] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

TextureMapper: Fix the fillsForward transform adjustment in syncAnimations.
https://bugs.webkit.org/show_bug.cgi?id=76184

Reviewed by Noam Rosenthal.

Also make the intention clearer by using setTransform and setOpacity.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimations):

06:32 Changeset [104929] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update expectation for svg/dom/SVGPathSegList-segment-modification.svg on LEOPARD DEBUG.

  • platform/chromium/test_expectations.txt:
06:25 Changeset [104928] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector scripts navigator style fixes.

  • inspector/front-end/scriptsPanel.css:

(#scripts-editor-container-tabbed-pane .tabbed-pane-header-tab):

06:20 Changeset [104927] by jochen@chromium.org
  • 9 edits
    5 adds in trunk

Source/WebCore: Once we prepared a script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
https://bugs.webkit.org/show_bug.cgi?id=76083

Reviewed by Adam Barth.

This bug was caught by the following IE Test Center test:

http://samples.msdn.microsoft.com/ietestcenter/HTML5/show_async_test.htm?11_RemovingAsyncScript

Test: http/tests/misc/async-script-removed.html

http/tests/misc/async-script.html

  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

  • html/HTMLScriptElement.cpp:
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:

LayoutTests: Once we've prepared script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
https://bugs.webkit.org/show_bug.cgi?id=76083

Reviewed by Adam Barth.

  • http/tests/misc/async-script-expected.txt: Added.
  • http/tests/misc/async-script-removed-expected.txt: Added.
  • http/tests/misc/async-script-removed.html: Added.
  • http/tests/misc/async-script.html: Added.
  • http/tests/misc/resources/delayed-log.php: Added.
06:18 Changeset [104926] by zimmermann@webkit.org
  • 4 edits in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Antti Koivisto.

Finish SVGTextMetricsBuilder introduction, tested in my local svg-text-performance branch.
SVGTextMetricsBuilder has two public methods:
a) SVGTextMetricsBuilder::measureTextRenderer(RenderSVGInlineText*)

It will be used exclusively for non-initial, incremental layout changes. Once the inital
text layout ran, any mutation of eg. a child text node of a <tspan>, will only trigger
a rebuild of the layout attributes associated with the passed in renderer.

b) SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes(RenderSVGText*, RenderSVGInlineText* stopAtLeaf, SVGCharacterDataMap& allCharactersMap)

stopAtLeaf=0:
This carries out the initial layout phase. It measures all characters of the whole <text> subtree, and stores the SVGTextMetrics for each character
in the SVGTextLayoutAttributes, stored in the RenderSVGInlineText object. It requires a SVGCharacterDataMap allCharactersMap as input argument,
which contains a HashMap<unsigned, {float x, y, dx, dy, rotate}>, which maps each character position to a set of x/y/dx/dy/rotate values.
The SVGCharacterDataMap living in SVGTextLayoutAttributes will be filled, from the global "allCharactersMap", so that each RenderSVGInlineText only
stores the positioning information for its children, if any.

Note: SVGTextMetricsBuilder is not yet deployed, so this talks about the design, once everything is landed.

stopAtLeaf!=0:
This is never used for the initial layout phase. If the initial layout is done, and eg. a <tspan> is added to the <text> subtree, we no longer
need to rebuild the metrics map & layout attributes for the whole tree, but only for the desired <tspan>, and its previous/next sibling, if present
(which may be affected by the inclusion of another node inbetween them).

SVGTextMetricsBuilder is now finished, and will be used in the next patch chunk.
Doesn't affect any tests yet.

  • rendering/svg/SVGTextLayoutAttributes.h:

(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::SVGCharacterData::SVGCharacterData):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::MeasureTextData::MeasureTextData):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):

  • rendering/svg/SVGTextMetricsBuilder.h:
06:10 Changeset [104925] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: Fixing Win builders.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):

06:01 Changeset [104924] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[EFL] Add 'Copy Image Address' to context menu.
https://bugs.webkit.org/show_bug.cgi?id=76153

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.

Source/WebCore:

Enables 'Copy Image Address' option to context menu in WebKit-EFL as it is enabled in GTK and QT ports.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCopyImageUrlToClipboard):

Source/WebKit/efl:

Adds EWK_CONTEXT_MENU_ITEM_TAG_COPY_IMAGE_URL_TO_CLIPBOARD to Ewk_Context_Menu_Action to synchronize it with ContextMenuItem.h

  • ewk/ewk_contextmenu.h:
05:48 Changeset [104923] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: 32bit build fix.

  • inspector/DOMEditor.cpp:
  • inspector/DOMEditor.h:
05:41 Changeset [104922] by mario@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rollout r104905.
https://bugs.webkit.org/show_bug.cgi?id=76267

This patch broke tests in the GTK 64bit Debug bot.

Source/WebCore:

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

Source/WebKit/gtk:

  • tests/testatk.c:

(textCaretMovedCallback):
(testWebkitAtkCaretOffsets):
(textSelectionChangedCallback):
(testWebkitAtkTextSelections):

05:29 Changeset [104921] by apavlov@chromium.org
  • 1 edit
    4 moves
    7 adds
    4 deletes in trunk/LayoutTests

Unreviewed, rebaseline Chromium and optimize Qt/GTK baselines after r104917 using garden-o-matic.

  • platform/chromium-mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
  • svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt.
05:24 Changeset [104920] by pfeldman@chromium.org
  • 7 edits
    3 adds in trunk

Web Inspector: make HTML editing preserve node identity when node nesting level changes.
https://bugs.webkit.org/show_bug.cgi?id=76183

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html-2.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchHTMLElement):
(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::createDigest):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::markNodeAsUsed):
(WebCore::DOMEditor::dumpMap):

  • inspector/DOMEditor.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt: Added.
  • inspector/elements/set-outer-html-2.html: Added.
  • inspector/elements/set-outer-html-expected.txt:
  • inspector/elements/set-outer-html-test.js: Added.

(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step1):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step2):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step3):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite):
(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest):

  • inspector/elements/set-outer-html.html:
05:04 Changeset [104919] by commit-queue@webkit.org
  • 17 edits
    1 copy
    3 adds in trunk

ShadowContentElement should be able to use query.
https://bugs.webkit.org/show_bug.cgi?id=75302

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-13
Reviewed by Hajime Morita.

Source/WebCore:

This patch introduces a selector to query elements in ShadowContentElement.
This can be used instead of ShadowContentElement::shouldInclude in more sophisticated ways.

Tests: fast/dom/shadow/shadow-contents-select-expected.html

fast/dom/shadow/shadow-contents-select.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::SelectorDataList):

Extracted from SelectorQueryto share codes with ShadowContentSelectorQuery.

(WebCore::SelectorDataList::initialize):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::queryAll):
(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::canUseIdLookup):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::size):

  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::select):
(WebCore::ShadowContentElement::setSelect):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Added.

(WebCore::ShadowContentSelectorQuery::ShadowContentSelectorQuery):
(WebCore::ShadowContentSelectorQuery::matches):

Returns true if Node is matched by the query.

  • dom/ShadowContentSelectorQuery.h: Copied from Source/WebCore/dom/ShadowContentElement.h.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):
(WebCore::DetailsContentElement::DetailsContentElement): Re-implemented using query.
(WebCore::DetailsSummaryElement::DetailsSummaryElement): ditto.

LayoutTests:

Tests for ShadowContentElement query.

  • fast/dom/shadow/shadow-contents-select-expected.html: Added.
  • fast/dom/shadow/shadow-contents-select.html: Added.
04:39 Changeset [104918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-13

  • DEPS:
03:54 Changeset [104917] by reni@webkit.org
  • 74 edits in trunk/LayoutTests

Update Snow-Leopard SVG pixel test baseline after r104881.
Unreviewed gardening.

  • platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png:
  • platform/mac-snowleopard/svg/custom/altglyph-expected.png:
  • platform/mac-snowleopard/svg/custom/external-paintserver-reference-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac-snowleopard/svg/custom/junk-data-expected.png:
  • platform/mac-snowleopard/svg/custom/linking-base-external-reference-expected.png:
  • platform/mac-snowleopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac-snowleopard/svg/custom/path-bad-data-expected.png:
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/css-transforms-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac-snowleopard/svg/hixie/error/012-expected.png:
  • platform/mac-snowleopard/svg/in-html/circle-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac-snowleopard/svg/text/kerning-expected.png:
  • platform/mac-snowleopard/svg/text/multichar-glyph-expected.png:
  • platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
03:36 Changeset [104916] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=76252

_calculateFlags speed is about 10k edges per second.
It requires 150sec for the snapshot with 1.5m edges.
The root of problem is var node = list.shift();
shift() is not effective in term of memory and cpu.
In our case it can be replaced with pop().
Now the function works 40 times faster.

Drive by change: if statement was reformatted a bit for better readability.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateFlags):

03:25 Changeset [104915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add visible field into ewk_tiled_backing_store's data.
https://bugs.webkit.org/show_bug.cgi?id=76165

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Nikolas Zimmermann.

Using of evas_object_visible_get() API can't gurantee the correctness of
evas_object's visible status if it's called inside of evas_object's
smart_show() method.
So, a visible flag for the ewk_tiled_backing_store is added.
In addition, as tiles are not visible, ewk_tiled_backing_store will push
its own tiles into the cache when it disapear.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):

03:02 Changeset [104914] by haraken@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104907.

  • platform/chromium-mac-leopard/fast/repaint/focus-layers-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/focus-layers-expected.png: Added.
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png: Removed.
  • platform/chromium-win/fast/repaint/focus-layers-expected.png:
02:52 Changeset [104913] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] JavaScriptOutlineDialog fails to open
https://bugs.webkit.org/show_bug.cgi?id=76259

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
02:07 Changeset [104912] by vsevik@chromium.org
  • 24 edits in trunk/LayoutTests

Unreviewed tests rebaseline after r104803.

  • fast/profiler/throw-exception-from-eval-expected.txt:
  • platform/chromium-mac/http/tests/history/cross-origin-replace-history-object-child-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/xss-DENIED-javascript-execution-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-history-properties-expected.txt:
  • platform/chromium/http/tests/security/xss-eval-expected.txt:
  • platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt:
  • platform/mac-wk2/plugins/mouse-events-scaled-expected.txt:
  • platform/mac/fast/AppleScript/001-expected.txt:
  • platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/mac/plugins/plugin-initiate-popup-window-expected.txt:
  • platform/qt-wk2/plugins/document-open-expected.txt:
  • platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
  • platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt:
  • platform/win/plugins/get-value-netscape-window-expected.txt:
  • platform/win/plugins/iframe-inside-overflow-expected.txt:
  • platform/win/plugins/keyboard-events-expected.txt:
  • platform/win/plugins/mouse-events-expected.txt:
  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
  • platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt:
  • platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
02:05 Changeset [104911] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed garedening. Skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
01:41 Changeset [104910] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
https://bugs.webkit.org/show_bug.cgi?id=76247

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)

01:31 Changeset [104909] by zimmermann@webkit.org
  • 77 edits in trunk/LayoutTests

2012-01-13 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Lion SVG pixel test baseline after r104881.
Also update SVGFETurbulenceElement-*-stitchTiles-*, filter-child-repaint.svg results, which pass again.

  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/custom/altglyph-expected.png:
  • platform/mac/svg/custom/external-paintserver-reference-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/linking-base-external-reference-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac/svg/custom/use-font-face-crash-expected.png:
  • platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac/svg/dom/css-transforms-expected.png:
  • platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/in-html/circle-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/multichar-glyph-expected.png:
  • platform/mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
01:23 Changeset [104908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Unused code cleanup on ewk_tiled_model.cpp.
https://bugs.webkit.org/show_bug.cgi?id=76031

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Ryosuke Niwa.

Remove unused code from ewk_tiled_model.cpp.

  • ewk/ewk_tiled_model.cpp:
01:17 Changeset [104907] by haraken@chromium.org
  • 5 edits
    2 adds in trunk

text-decorations should not be propagated to floating, absolutely or fixed
positioned decendants
https://bugs.webkit.org/show_bug.cgi?id=18611

Reviewed by Darin Adler.

Source/WebCore:

Previously text-decorations were propagated to all child elements,
but they should not be propagated to out-of-flow descendants,
i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

Test: fast/css/text-decoration-in-descendants.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

LayoutTests:

The added test checks that text-decorations are not propagated to out-of-flow
descendants, i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

  • fast/css/text-decoration-in-descendants-expected.html: Added.
  • fast/css/text-decoration-in-descendants.html: Added.
  • platform/chromium-linux/fast/repaint/focus-layers-expected.png: Updated the test result.
  • platform/mac/fast/repaint/focus-layers-expected.png: Ditto.
01:14 Changeset [104906] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION (r104668): Crash in HTMLFormElement destructor if the
document contains radio groups with the identical name.
https://bugs.webkit.org/show_bug.cgi?id=76206

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/radio/radio-group-document-destruction.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement):
setForm(0) may register this to a document-level radio button group.
We need to unregister this from the group because
Document::checkedRadioButtons() is still accessible from other objects.

LayoutTests:

  • fast/forms/radio/radio-group-document-destruction-expected.txt: Added.
  • fast/forms/radio/radio-group-document-destruction.html: Added.
01:12 Changeset [104905] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069

Reviewed by Martin Robinson.

Source/WebCore:

Fix bug introduced with patch for Bug 72830.

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.

Source/WebKit/gtk:

Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.

  • tests/testatk.c:

(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.

01:10 Changeset [104904] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Removed duplicated unit test.

The unit test testWebkitAtkGetTextAtOffsetForms is exactly the
same test case than testWebkitAtkGetTextAtOffset, so it makes no
sense to have it duplicated.

Rubber-stamped by Martin Robinson.

  • tests/testatk.c:

(main): Removed testWebkitAtkGetTextAtOffsetForms.

01:05 Changeset [104903] by achicu@adobe.com
  • 4 edits in trunk/Source/WebCore

Refactor RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer()/paintLayerContents() to avoid duplicate code
https://bugs.webkit.org/show_bug.cgi?id=75983

Reviewed by Simon Fraser.

No new tests, just merging two duplicate methods.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

This method is used only in non-composited mode, so I've moved the check for composited mode much earlier.

(WebCore::RenderLayer::paintLayerContentsAndReflection):

Also used just in non-composited mode, it will draw the reflection and then just call paintLayerContents.

(WebCore::RenderLayer::paintLayerContents):

Old method, that is now used by both composited and non-composited mode. I've added 3 more flags used to render the
Graphics layers: Background, Foreground and Mask.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Removed all the code and delegated the work to RenderLayer::paintLayerContents.

00:47 Changeset [104902] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Mac][DRT] Should support --no-timeout
https://bugs.webkit.org/show_bug.cgi?id=76242

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-13
Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
(setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
(shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.

00:46 Changeset [104901] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r104787 if JIT_VERBOSE_OSR is defined

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

Note: See TracTimeline for information about the timeline view.