Timeline
Jan 22, 2012:
- 11:08 PM Changeset in webkit [105594] by
-
- 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js
Merge 105261 - Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363
Reviewed by Pavel Feldman.
This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9279002
- 9:36 PM Changeset in webkit [105593] by
-
- 1 edit in branches/chromium/963/Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present
https://bugs.webkit.org/show_bug.cgi?id=76508
Patch by Kazuhiro Inaba <kinaba@chromium.org> on 2012-01-19
Reviewed by Kent Tamura.
Wrapped GetGlyphIndices() API calls so that when they failed we trigger font
loading outside the sandbox and retry the call.
No new auto tests since the bug involves the system's occasional cache behavior
and thus there's no reliable way to reproduce and test the situation.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::getGlyphIndices):
GDI call wrapper ensuring fonts to be loaded.
(WebCore::initSpaceGlyph):
Changed to use the wrapper function.
(WebCore::fillBMPGlyphs):
Changed to use the wrapper function.
Introduced scoped HDC management by HWndDC.
(WebCore::GlyphPage::fill):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9280004
- 6:13 PM Changeset in webkit [105592] by
-
- 2 edits in trunk/Tools
Windows python test build fix.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- 11:51 AM Changeset in webkit [105591] by
-
- 2 edits in trunk/LayoutTests
2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo, which makes the style bot warn on every patch.
- platform/chromium/test_expectations.txt:
- 11:29 AM Changeset in webkit [105590] by
-
- 7 edits in trunk/Source
[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069
Reviewed by Martin Robinson.
Source/WebCore:
Fix bug introduced with patch for Bug 72830.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isDescendantOfObject): New function,
to check if an accessibility object is a descendant of other object.
(WebCore::AccessibilityObject::isAncestorOfObject): New function,
to check if an accessibility object is an ancestor of other object.
- accessibility/AccessibilityObject.h:
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset): Make sure to pass the
right reference object to objectFocusedAndCaretOffsetUnignored.
(objectFocusedAndCaretOffsetUnignored): Use positionBeforeNode
instead of firstPositionInNode for calculating the begining of the
range used to calculate the offsets. Ensure that the reference
object is never a descendant of the actual object being returned.
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.
Source/WebKit/gtk:
Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.
- tests/testatk.c:
(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.
- 4:50 AM Changeset in webkit [105589] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping passing test.
- platform/gtk/Skipped: unskipped
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- 3:52 AM Changeset in webkit [105588] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping test passing after r79655.
- platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl
- 2:12 AM Changeset in webkit [105587] by
-
- 4 edits in trunk
[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631
Reviewed by Martin Robinson.
Tools:
DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewConsoleMessage):
LayoutTests:
Unskipped a couple of tests after fix.
- platform/gtk/Skipped:
- 1:11 AM Changeset in webkit [105586] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms that error out on warn-unused-parameter.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- 12:47 AM Changeset in webkit [105585] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
Jan 21, 2012:
- 7:45 PM Changeset in webkit [105584] by
-
- 2 edits in trunk
[GTK][PATCH] Enable MathML support by default
https://bugs.webkit.org/show_bug.cgi?id=76790
Patch by Priit Laes <plaes@plaes.org> on 2012-01-21
Reviewed by Martin Robinson.
- configure.ac: Enable MathML by default.
- 7:30 PM Changeset in webkit [105583] by
-
- 13 edits in trunk/Source
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672
Patch by David Reveman <reveman@chromium.org> on 2012-01-21
Reviewed by Adam Barth.
Source/WebCore:
Use a new set of textures for each commit when incremental
texture updates are enabled.
This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 5:43 PM Changeset in webkit [105582] by
-
- 1 edit2 adds in trunk/LayoutTests
Add baselines for test after http://trac.webkit.org/changeset/105575.
This baseline looks very similar to the existing non-Chromium baseline.
- platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- 5:36 PM Changeset in webkit [105581] by
-
- 8 edits9 adds1 delete in trunk/Source/JavaScriptCore
DFG should not have code that directly decodes the states of old JIT inline
cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768
Reviewed by Sam Weinig.
Introduced new classes (like GetByIdStatus) that encapsulate the set of things
that the DFG would like to know about property accesses and calls. Whereas it
previously got this information by directly decoding the data structures used
by the old JIT for inline caching, it now uses these classes, which do the work
for it. This should make it somewhat more straight forward to introduce new
ways of profiling the same information.
Also hoisted StructureSet into bytecode/ from dfg/, because it's now used by
code in bytecode/.
Making this work right involved carefully ensuring that the heuristics for
choosing how to handle property accesses was at least as good as what we had
before, since I completely restructured that code. Currently the performance
looks neutral. Since I rewrote the code I did change some things that I never
liked before, like previously if a put_bu_id had executed exactly once then
we'd compile it as if it had taken slow-path. Executing once is special because
then the inline cache is not baked in, so there is no information about how the
DFG should optimize the code. Now this is rationalized: if the put_by_id does
not offer enough information to be optimized (i.e. had executed 0 or 1 times)
then we turn it into a forced OSR exit (i.e. a patch point). However, get_by_id
still has the old behavior; I left it that way because I didn't want to make
too many changes at once.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkStatus.cpp: Added.
(JSC::CallLinkStatus::computeFor):
- bytecode/CallLinkStatus.h: Added.
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(JSC::CallLinkStatus::couldTakeSlowPath):
(JSC::CallLinkStatus::callTarget):
- bytecode/GetByIdStatus.cpp: Added.
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h: Added.
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::state):
(JSC::GetByIdStatus::isSet):
(JSC::GetByIdStatus::operator!):
(JSC::GetByIdStatus::isSimpleDirect):
(JSC::GetByIdStatus::takesSlowPath):
(JSC::GetByIdStatus::makesCalls):
(JSC::GetByIdStatus::structureSet):
(JSC::GetByIdStatus::offset):
- bytecode/MethodCallLinkStatus.cpp: Added.
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/MethodCallLinkStatus.h: Added.
(JSC::MethodCallLinkStatus::MethodCallLinkStatus):
(JSC::MethodCallLinkStatus::isSet):
(JSC::MethodCallLinkStatus::operator!):
(JSC::MethodCallLinkStatus::needsPrototypeCheck):
(JSC::MethodCallLinkStatus::structure):
(JSC::MethodCallLinkStatus::prototypeStructure):
(JSC::MethodCallLinkStatus::function):
(JSC::MethodCallLinkStatus::prototype):
- bytecode/PutByIdStatus.cpp: Added.
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h: Added.
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::state):
(JSC::PutByIdStatus::isSet):
(JSC::PutByIdStatus::operator!):
(JSC::PutByIdStatus::isSimpleReplace):
(JSC::PutByIdStatus::isSimpleTransition):
(JSC::PutByIdStatus::takesSlowPath):
(JSC::PutByIdStatus::oldStructure):
(JSC::PutByIdStatus::newStructure):
(JSC::PutByIdStatus::structureChain):
(JSC::PutByIdStatus::offset):
- bytecode/StructureSet.h: Added.
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::clear):
(JSC::StructureSet::add):
(JSC::StructureSet::addAll):
(JSC::StructureSet::remove):
(JSC::StructureSet::contains):
(JSC::StructureSet::isSubsetOf):
(JSC::StructureSet::isSupersetOf):
(JSC::StructureSet::size):
(JSC::StructureSet::at):
(JSC::StructureSet::operator[]):
(JSC::StructureSet::last):
(JSC::StructureSet::predictionFromStructures):
(JSC::StructureSet::operator==):
(JSC::StructureSet::dump):
- dfg/DFGAbstractValue.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGStructureSet.h: Removed.
- 5:09 PM Changeset in webkit [105580] by
-
- 4 edits6 adds in trunk
Add .url attribute alongside .URL in EventSource and WebSocket to comply with the specs but not break existing usage.
https://bugs.webkit.org/show_bug.cgi?id=40899
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-21
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/eventsource/eventsource-url-attribute.html
http/tests/websocket/tests/hixie76/url-attribute.html
http/tests/websocket/tests/hybi/url-attribute.html
- page/EventSource.idl:
- websockets/WebSocket.idl:
LayoutTests:
- fast/eventsource/eventsource-url-attribute-expected.txt: Added.
- fast/eventsource/eventsource-url-attribute.html: Added.
- http/tests/websocket/tests/hixie76/url-attribute-expected.txt: Added.
- http/tests/websocket/tests/hixie76/url-attribute.html: Added.
- http/tests/websocket/tests/hybi/url-attribute-expected.txt: Added.
- http/tests/websocket/tests/hybi/url-attribute.html: Added.
- 4:48 PM Changeset in webkit [105579] by
-
- 5 edits in trunk/Source/JavaScriptCore
JIT compilation should not require ExecState
https://bugs.webkit.org/show_bug.cgi?id=76729
<rdar://problem/10731545>
Reviewed by Gavin Barraclough.
Changed the relevant JIT driver functions to take JSGlobalData& instead of
ExecState*, since really they just needed the global data.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 3:56 PM Changeset in webkit [105578] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r105564.
http://trac.webkit.org/changeset/105564
https://bugs.webkit.org/show_bug.cgi?id=76792
Does not compile on Chromium Mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-21
Source/WebCore:
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 9:19 AM Changeset in webkit [105577] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green.
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- 7:40 AM Changeset in webkit [105576] by
-
- 19 edits6 adds in trunk
Implement hardware accelerated Brightness and contrast filters
https://bugs.webkit.org/show_bug.cgi?id=75521
https://bugs.webkit.org/show_bug.cgi?id=76719
Reviewed by Simon Fraser.
Source/WebCore:
Implemented hardware accelerated brightness and contrast filters. This also fixes
the bug where grayscale filter was accidentally never getting hardware accelerated.
It also complies with proposed spec changes for the brightness filter to be additive
rather than multiplicative, according to https://bugs.webkit.org/show_bug.cgi?id=76719.
Had to make both fixes in the same patch because I had to change the allowed brightness
values for the hardware version, so I had to change the software version as well.
Tests: css3/filters/effect-brightness-hw.html
css3/filters/effect-contrast-hw.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
LayoutTests:
New tests for hardware accelerated brightness and contrast filters. Also
added brightness and contrast values to effect-combined-hw test. And changed
brightness values in effect-brightness.html to reflect new spec.
Also fixed parsing and computed style tests to reflect new brightness spec.
- css3/filters/effect-brightness-expected.png:
- css3/filters/effect-brightness-hw-expected.png: Added.
- css3/filters/effect-brightness-hw-expected.txt: Added.
- css3/filters/effect-brightness-hw.html: Added.
- css3/filters/effect-brightness.html:
- css3/filters/effect-combined-expected.png:
- css3/filters/effect-combined-hw-expected.png:
- css3/filters/effect-combined-hw-expected.txt:
- css3/filters/effect-combined-hw.html:
- css3/filters/effect-combined.html:
- css3/filters/effect-contrast-hw-expected.png: Added.
- css3/filters/effect-contrast-hw-expected.txt: Added.
- css3/filters/effect-contrast-hw.html: Added.
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/filter-property-parsing-invalid-expected.txt:
- css3/filters/script-tests/filter-property-computed-style.js:
- css3/filters/script-tests/filter-property-parsing-invalid.js:
- css3/filters/script-tests/filter-property-parsing.js:
- 4:28 AM Changeset in webkit [105575] by
-
- 5 edits3 adds in trunk
2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780
Reviewed by Antti Koivisto.
Add new testcase covering preserveAspectRatio="none" + <feImage>, which is now fixed.
- platform/chromium/test_expectations.txt: Add new test, that needs a rebaseline.
- platform/mac/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/mac/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- svg/filters/feImage-preserveAspectratio.svg: Added.
2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780
Reviewed by Antti Koivisto.
preserveAspectRatio="none" was ignored in SVGFEImage. It always called transformRect() w/o checking
whether it was supposed to transform the rect or not - move code from RenderSVGImage right into
transformRect(), to do nothing if preserveAspectRatio="none" was given.
Test: svg/filters/feImage-preserveAspectratio.svg
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
- 2:18 AM Changeset in webkit [105574] by
-
- 3 edits6 adds in trunk
history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)
https://bugs.webkit.org/show_bug.cgi?id=76721
Reviewed by Mihai Parparita.
Source/WebCore:
Tests: http/tests/history/replacestate-post-to-get-2.html
http/tests/history/replacestate-post-to-get.html
- loader/HistoryController.cpp:
(WebCore::HistoryController::replaceState):
LayoutTests:
- http/tests/history/replacestate-post-to-get-2-expected.txt: Added.
- http/tests/history/replacestate-post-to-get-2.html: Added.
- http/tests/history/replacestate-post-to-get-expected.txt: Added.
- http/tests/history/replacestate-post-to-get.html: Added.
- http/tests/history/resources/replacestate-current.php: Added.
- http/tests/history/resources/replacestate-forward-back.php: Added.
- 2:00 AM Changeset in webkit [105573] by
-
- 7 edits2 adds in trunk
Null dereference in SVGDocumentExtensions::removePendingResource when updating <use>'s href
https://bugs.webkit.org/show_bug.cgi?id=69284
Patch by Florin Malita <fmalita@google.com> on 2012-01-21
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/custom/use-crash-pending-resource.svg
The crash is caused by assumptions in SVGUseElement that xlink:href is the only
pending resource. This patch adds support for dealing with multiple pending resources.
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::hasPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForElement):
- svg/SVGDocumentExtensions.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
Renamed SVGDocumentExtensions::hasPendingResources -> Renamed SVGDocumentExtensions::hasPendingResource.
Renamed SVGDocumentExtensions::isElementInPendingResources -> SVGDocumentExtensions::isElementPendingResources.
Added support for querying and removing pending resources for a specific element.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::buildPendingResource):
Refactored to support multiple pending resources.
LayoutTests:
- svg/custom/use-crash-pending-resource-expected.txt: Added.
- svg/custom/use-crash-pending-resource.svg: Added.
- 12:51 AM Changeset in webkit [105572] by
-
- 4 edits in trunk
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html
https://bugs.webkit.org/show_bug.cgi?id=64671
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-21
Reviewed by Nikolas Zimmermann.
Source/WebCore:
No new tests. This change is to fix crashes in existing tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::beginListChanged): If the new begin time is
later than the current end time, and the event time is also after then
end time (but we have not yet updated to that time) and the animation
is active, we need to make the animation inactive explicitly.
LayoutTests:
- platform/chromium/test_expectations.txt: Marking all svg/W3C-SVG-1.1/animate-elem* tests
as flakey pending this change being committed and new results.
- 12:42 AM Changeset in webkit [105571] by
-
- 4 edits in trunk/Source/WebKit2
Make WebKit2 remember the height of the Web Inspector when it is docked.
Reviewed by Dan Bernstein.
- Shared/WebPreferencesStore.h: Added InspectorAttachedHeight.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call WebPreferencesStore::setInspectorAttachedHeight.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Set the height of the inspector's WKView to inspectorAttachedHeight.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Remove unneeded setNeedsDisplay: calls.
- 12:17 AM Changeset in webkit [105570] by
-
- 4 edits in trunk/Source/WebCore
PopupMenuClient::multiple() should be const
https://bugs.webkit.org/show_bug.cgi?id=76771
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-21
Reviewed by Kent Tamura.
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::multiple):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
- rendering/RenderMenuList.h:
Jan 20, 2012:
- 10:06 PM Changeset in webkit [105569] by
-
- 6 edits4 adds in trunk/Source/WebCore
Switch indexeddb to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76723
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-01-20
Reviewed by Adam Barth.
No new tests required, all existing tests pass.
- Modules/indexeddb: Added.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp: Added. webkitIndexedDB() method previously in DOMWindow.cpp
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::~DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h: Added.
- Modules/indexeddb/DOMWindowIndexedDatabase.idl: Added. attributes previously in DOMWindow.idl
- WebCore.gyp/WebCore.gyp: add Modules/indexeddb/ directory
- WebCore.gypi: add Modules/indexeddb/*
- page/DOMWindow.cpp: remove webkitIndexedDB() method, add accessor methods for m_idbFactory
(WebCore::DOMWindow::getIDBFactory):
(WebCore::DOMWindow::setIDBFactory):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 8:11 PM Changeset in webkit [105568] by
-
- 2 edits in trunk/Source/WebCore
Allow isContextThread to be called while in ~ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=76756
Reviewed by Adam Barth.
It is possible for objects to get torn down or get called from ~ScriptExecutionContext
and in turn call isContextThread. The resulting behavior is undefined. This change defines
the behavior. I don't know of any places that do this but I have a test that is rarely
failing due to isContextThread being false. This is my best guess as to why, and I
don't see a reason to try to avoid calling isContextThread at this point.
No new functionality exposed so no new tests.
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isContextThread):
- 7:32 PM Changeset in webkit [105567] by
-
- 3 edits in trunk/Tools
The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
https://bugs.webkit.org/show_bug.cgi?id=76752
Reviewed by Eric Seidel.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_leaky_patterns):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(LeakyPatternTest.test_create_dc):
(LeakyPatternTest.test_create_compatible_dc):
- 7:19 PM Changeset in webkit [105566] by
-
- 6 edits in trunk/Source
[chromium] Write unit tests for compositor-thread zooming
https://bugs.webkit.org/show_bug.cgi?id=71529
Patch by Alexandre Elias <aelias@google.com> on 2012-01-20
Reviewed by James Robinson.
Add unit tests for pinch zoom and page scale animation. Includes
small cleanups in CCLayerTreeHostImpl for testability.
Source/WebCore:
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):
- 7:03 PM Changeset in webkit [105565] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] Division by zero error in QtViewportInteractionEngine::setItemRectVisible
https://bugs.webkit.org/show_bug.cgi?id=76674
Reviewed by Kenneth Rohde Christiansen.
Make sure that itemRect is not empty.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
- 6:49 PM Changeset in webkit [105564] by
-
- 13 edits in trunk/Source
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672
Patch by David Reveman <reveman@chromium.org> on 2012-01-20
Reviewed by James Robinson.
Source/WebCore:
Use a new set of textures for each commit when incremental
texture updates are enabled.
This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 6:35 PM Changeset in webkit [105563] by
-
- 720 edits in branches/subpixellayout/Source
Merge missing trunk changes (up until 105194) into branch.
- 6:34 PM Changeset in webkit [105562] by
-
- 2 edits in trunk/Source/WebCore
De-zippering incorrectly snaps to target gain
https://bugs.webkit.org/show_bug.cgi?id=76741
Reviewed by Kenneth Russell.
- platform/audio/AudioBus.cpp:
- 6:21 PM Changeset in webkit [105561] by
-
- 3 edits4 adds in trunk
[chromium] Partially filled pixels do not occlude pixels below them.
https://bugs.webkit.org/show_bug.cgi?id=76658
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-20
Reviewed by James Robinson.
Source/WebCore:
Test: compositing/culling/tile-occlusion-boundaries.html
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::enclosedIntRect):
(WebCore::CCQuadCuller::cullOccludedQuads):
LayoutTests:
- compositing/culling/tile-occlusion-boundaries-expected.png: Added.
- compositing/culling/tile-occlusion-boundaries-expected.txt: Added.
- compositing/culling/tile-occlusion-boundaries.html: Added.
- compositing/resources/green.jpg: Added.
- 6:06 PM Changeset in webkit [105560] by
-
- 2 edits in trunk/Tools
Changed my status in commiters.py
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 5:34 PM Changeset in webkit [105559] by
-
- 4 edits in trunk/Source
Small cleanup of {get,put}CurrentFrame for WebMediaPlayerClientImpl/CCVideoLayerImpl.
https://bugs.webkit.org/show_bug.cgi?id=76332
Patch by Ami Fischman <fischman@chromium.org> on 2012-01-20
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
Source/WebKit/chromium:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
- 5:16 PM Changeset in webkit [105558] by
-
- 2 edits in trunk/Source/WebKit2
Drag/drop of a file into a WebView on Windows needs to allow access to that file
https://bugs.webkit.org/show_bug.cgi?id=76753
<rdar://problem/10731719>
Reviewed by Alexey Proskuryakov.
The Windows drag/drop code path was missing the code to open a file read exception.
Added code to match the Mac version, while allowing directories and multiple files to
also be dragged (matching our previous behavior).
- UIProcess/win/WebView.cpp:
(WebKit::maybeCreateSandboxExtensionFromDragData): Added.
(WebKit::WebView::Drop): Add a universal read exception if we're dragging a file into a WebView to open it.
- 5:11 PM Changeset in webkit [105557] by
-
- 1 edit1 add in trunk/LayoutTests
Add a Chromium-specific baselines for
fast/dom/Window/open-invalid-url.html. Although this expected result
says "FAIL", the behavior seems to be reasonable.
- platform/chromium/fast/dom/Window/open-invalid-url-expected.txt: Added.
- 4:45 PM Changeset in webkit [105556] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764 Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
Reviewed by Sam Weinig.
No way to reproduce without special malloc debugging and that doesn't even reproduce on all platforms. So still no test.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame): Protect m_frame for the duration of this method.
- 4:36 PM Changeset in webkit [105555] by
-
- 3 edits in trunk/Source/JavaScriptCore
Make OwnPtr<HDC> work for the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76738
Reviewed by Jian Li.
- JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnPtrWin.cpp to the
Chromium Windows build.
- wtf/OwnPtrCommon.h: Changed from platform WIN to OS WIN for
OwnPtr<HDC> and similar constructs.
- 4:09 PM Changeset in webkit [105554] by
-
- 2 edits in trunk/Source/WebCore
WebCore should not send invalid URLs to client createWindow methods.
https://bugs.webkit.org/show_bug.cgi?id=39017
Unreviewed test fix.
- page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Let empty URLs through.
- 4:05 PM Changeset in webkit [105553] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from 118291 to 118493.
- DEPS:
- 4:03 PM Changeset in webkit [105552] by
-
- 23 edits in trunk/Source
Make WebCore RunLoop work for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76739
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/RunLoop.cpp:
Specialize RunLoop initialization for Mac, where it can happen on any thread.
- platform/RunLoop.h:
Add RunLoop constructor that takes a CFRunLoopRef on the mac for initializing
the main thread.
- platform/mac/RunLoopMac.mm:
(WebCore::RunLoop::initializeMainRunLoop):
Add new implementation that can work from any thread (and multiple threads at the
same time if necessary).
(WebCore::RunLoop::current):
Treat the main thread specially, not storing it in thread specific data.
(WebCore::RunLoop::main):
Copy main accessor since it needs access to the file static.
(WebCore::RunLoop::RunLoop):
Add constructor which takes a CFRunLoopRef.
Source/WebKit/mac:
- Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter initialize]):
- History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]):
- Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]):
- Misc/WebIconDatabase.mm:
(+[WebIconDatabase initialize]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm:
(+[WebUndoStep initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm:
(+[WebDataSourcePrivate initialize]):
- WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):
- WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
- WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]):
- WebView/WebView.mm:
(+[WebView initialize]):
- WebView/WebViewData.mm:
(+[WebViewPrivate initialize]):
Initialized the main run loop in addition to other initialization.
- 3:47 PM Changeset in webkit [105551] by
-
- 2 edits in trunk/Tools
run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
https://bugs.webkit.org/show_bug.cgi?id=76748
Reviewed by Ryosuke Niwa.
It crawls the whole subtree and then doesn't use the data. Cutting this out
saves 4 seconds warm and 17 seconds cold on my Mac Pro.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
- 3:36 PM Changeset in webkit [105550] by
-
- 2 edits in trunk/Tools
Another tiny tweak to the garden-o-matic CSS. This makes things line
up slightly nicer when there aren't any failures.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#summary):
- 3:23 PM Changeset in webkit [105549] by
-
- 4 edits2 adds in trunk
Crash in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=76606
<rdar://problem/10720970>
Reviewed by Dirk Schulze.
Notify SVGResourcesCache and superclass when RenderSVGInline is about
to be destroyed, preventing a crash.
Test: svg/custom/crash-inline-container-client.html
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::willBeDestroyed):
- rendering/svg/RenderSVGInline.h:
- svg/custom/crash-inline-container-client-expected.txt: Added.
- svg/custom/crash-inline-container-client.html: Added.
- 3:22 PM Changeset in webkit [105548] by
-
- 3 edits2 adds in trunk
WebCore should not send invalid URLs to client createWindow methods.
https://bugs.webkit.org/show_bug.cgi?id=39017
Reviewed by Sam Weinig.
Test: fast/dom/window/open-invalid-url.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Bail out early for invalid URLs.
- 3:21 PM Changeset in webkit [105547] by
-
- 2 edits in trunk/Source/WebKit/chromium
Revert r105545. Something got broken about gclient/gyp but I can't figure out what.
- DEPS:
- 3:00 PM Changeset in webkit [105546] by
-
- 2 edits in trunk/Source/WebCore
Remove unused variable in RenderReplaced after r105513
https://bugs.webkit.org/show_bug.cgi?id=76742
Reviewed by Daniel Bates.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
- 2:59 PM Changeset in webkit [105545] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from 118291 to 118530.
- DEPS:
- 2:49 PM Changeset in webkit [105544] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Plumb damage from accelerated canvas 2D.
https://bugs.webkit.org/show_bug.cgi?id=76728
Patch by Jonathan Backer <backer@chromium.org> on 2012-01-20
Reviewed by Kenneth Russell.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::contentChanged):
- 2:17 PM Changeset in webkit [105543] by
-
- 5 edits in trunk/Tools
run-perf-tests should support --test-results-server option
https://bugs.webkit.org/show_bug.cgi?id=76680
Reviewed by Adam Barth.
Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
to be used by perf bots. Also refactor file_uploader as needed.
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.init):
(FileUploader.upload_single_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader):
(FileUploader._upload_data):
(FileUploader._upload_data.callback):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.upload_json_files):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json):
(PerfTestsRunner._upload_json):
(PerfTestsRunner._run_tests_set):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_with_upload_json):
(test_run_with_upload_json.mock_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader):
(test_upload_json.MockFileUploader.init):
(test_upload_json.MockFileUploader.upload_single_file):
(test_parse_args):
- 2:16 PM Changeset in webkit [105542] by
-
- 4 edits2 adds in trunk
Crash in RenderTable::borderBefore
https://bugs.webkit.org/show_bug.cgi?id=75215
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/crash-beforeBorder-dirty-section.html
This is a regression from r97661 that added some calls to get the object's borders but tables are a
special case and they may need to recompute some sections' pointers.
The whole sections' pointers lazy recomputation logic is unfortunately far from being bullet proof and
this change is only a mitigation for the current crash.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
Make sure we recompute our sections. The change was made here to avoid hitting the
path used inside the table code (ie outerBorder{Before|After}) that shouldn't be
affected.
- rendering/RenderTable.h:
(WebCore::RenderTable::topSection):
Added an ASSERT to catch more bad use in the future.
LayoutTests:
- fast/table/crash-beforeBorder-dirty-section-expected.txt: Added.
- fast/table/crash-beforeBorder-dirty-section.html: Added.
- 2:10 PM Changeset in webkit [105541] by
-
- 14 edits in branches/subpixellayout/Source
Fixing widget painting on all platforms, and fixing an issue where nested NSViews were handed a subpixel value for the visible area. Correcting an enclosingIntRect usage in PaintInfo. Cleaning up some unnecessary changes to shrink patch noise.
- 1:19 PM Changeset in webkit [105540] by
-
- 3 edits in trunk/Source/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=76444
This breaks builds.
- WebView/WebPreferences.mm:
- WebView/WebPreferencesPrivate.h:
- 1:05 PM Changeset in webkit [105539] by
-
- 7 edits in trunk/Source/JavaScriptCore
Removed some regexp entry boilerplate code
https://bugs.webkit.org/show_bug.cgi?id=76687
Reviewed by Darin Adler.
1% - 2% speedup on regexp tests, no change overall.
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- ASSERT that our startIndex is non-negative, because anything less would be uncivilized.
- ASSERT that our input is not the null string for the same reason.
- No need to test for startOffset being past the end of the string, since the regular expression engine will do this test for us.
- No need to initialize the output vector, since the regular expression engine will fill it in for us.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::interpret):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
RegExp used to do these jobs for us, but now we do them for ourselves
because it's a better separation of concerns, and the JIT can do them
more efficiently than C++ code:
- Test for "past the end" before doing any matching -- otherwise a* will match with zero length past the end of the string, which is wrong.
- Initialize the output vector before doing any matching.
- 1:05 PM Changeset in webkit [105538] by
-
- 3 edits1 add in trunk
Add proper offset to position right click to simulate a context menu invocation.
https://bugs.webkit.org/show_bug.cgi?id=76421
Patch by Marc-Andre Decoste <mad@chromium.org> on 2012-01-20
Reviewed by Ojan Vafai.
.:
- ManualTests/win/contextmenu-key3.html: Added.
Source/WebCore:
Manual tests only because DRT doesn't support context menu key.
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
- 1:01 PM Changeset in webkit [105537] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build fix for no-DFG configuration.
Needed for <rdar://problem/10727689>.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfiledOpcode):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- 12:55 PM Changeset in webkit [105536] by
-
- 2 edits in trunk/Tools
The party time image overlaps real content! This patch makes the
image centered vertically.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#onebar.partytime #summary):
- 12:40 PM Changeset in webkit [105535] by
-
- 6 edits in trunk/Tools
Refactor TestExpectationsParser in preparation for caching the results
https://bugs.webkit.org/show_bug.cgi?id=76669
Reviewed by Dimitri Glazkov.
Make everything private expect for the parse method.
Eventually, we'll need the expectations lines to not be modified
outside of TestExpectationsParser so we can cache the results.
This makes check-webkit-style of the chromium test_expectations.txt file
go from ~17 seconds to ~12 seconds on my Mac Pro.
This patch is just a refactor in preparation, so no new tests.
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
(TestExpectationEditorTests.make_parsed_expectation_lines):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.parse):
(TestExpectationParser):
(TestExpectationParser._parse_line):
(TestExpectationParser._tokenize):
(TestExpectationParser._tokenize_list):
(TestExpectationsModel._clear_expectations_for_test):
(TestExpectations.init):
(TestExpectations._add_expectations):
(TestExpectations._add_skipped_tests):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationParserTests.test_parse_empty_string):
(TestExpectationSerializerTests.assert_round_trip):
(TestExpectationSerializerTests.assert_list_round_trip):
- Scripts/webkitpy/tool/commands/expectations.py:
(OptimizeExpectations.execute):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningExpectationsUpdater.update_expectations):
- 12:22 PM Changeset in webkit [105534] by
-
- 3 edits in trunk/Tools
Follow-up to previous patch: don't produce NaN when the revision number
is missing.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
- 12:22 PM Changeset in webkit [105533] by
-
- 20 edits in trunk/Source/JavaScriptCore
Bytecode instructions that may have value profiling should have a direct inline
link to the ValueProfile instance
https://bugs.webkit.org/show_bug.cgi?id=76682
<rdar://problem/10727689>
Reviewed by Sam Weinig.
Each opcode that gets value profiled now has a link to its ValueProfile. This
required rationalizing the emission of value profiles for opcode combos, like
op_method_check/op_get_by_id and op_call/op_call_put_result. It only makes
sense for one of them to have a value profile link, and it makes most sense
for it to be the one that actually sets the result. The previous behavior was
to have op_method_check profile for op_get_by_id when they were used together,
but otherwise for op_get_by_id to have its own profiles. op_call already did
the right thing; all profiling was done by op_call_put_result.
But rationalizing this code required breaking some of the natural boundaries
that the code had; for instance the code in DFG that emits a GetById in place
of both op_method_check and op_get_by_id must now know that it's the latter of
those that has the value profile, while the first of those constitutes the OSR
target. Hence each CodeOrigin must now have two bytecode indices - one for
OSR exit and one for profiling.
Finally this change required some refiddling of our optimization heuristics,
because now all code blocks have "more instructions" due to the value profile
slots.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfileForBytecodeOffset):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::bytecodeIndexForValueProfile):
- bytecode/Instruction.h:
(JSC::Instruction::Instruction):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
- runtime/Options.cpp:
(JSC::Options::initializeOptions):
- 12:21 PM Changeset in webkit [105532] by
-
- 4 edits in trunk
Unreviewed, rolling out r105426.
http://trac.webkit.org/changeset/105426
https://bugs.webkit.org/show_bug.cgi?id=76726
Might have caused a 20% regression in the PLT (Requested by
abarth|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-20
Source/WebCore:
- rendering/RenderObject.h:
(WebCore::RenderObject::style):
LayoutTests:
- platform/mac-snowleopard/Skipped:
- 12:08 PM Changeset in webkit [105531] by
-
- 17 edits in trunk/Source
[chromium] Revert a couple of changes in fileapi/ that break tests in chromeos.
https://bugs.webkit.org/show_bug.cgi?id=76718
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-01-20
Reviewed by Darin Fisher.
Source/WebCore:
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::getIdentifier):
(WebCore::BlobURL::createBlobURL):
- fileapi/BlobURL.h:
(WebCore::BlobURL::blobProtocol):
- fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::crackFileSystemURL):
- fileapi/DOMFileSystemBase.h:
- fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
- fileapi/FileWriter.cpp:
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestFileSystem):
- page/DOMWindow.h:
- platform/AsyncFileSystem.cpp:
- platform/AsyncFileSystem.h:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
Source/WebKit/chromium:
- public/platform/WebFileSystem.h:
- src/AssertMatchingEnums.cpp:
- src/AsyncFileSystemChromium.cpp:
- src/AsyncFileSystemChromium.h:
- 11:44 AM Changeset in webkit [105530] by
-
- 4 edits in trunk/Tools
Garden-o-matic should tell me which revisions have been checked by all the bots
https://bugs.webkit.org/show_bug.cgi?id=76722
Reviewed by Dimitri Glazkov.
This information helps me know when it's safe for me to roll a
candidate revision.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
- 11:23 AM Changeset in webkit [105529] by
-
- 6 edits in trunk/Source/WebCore
Refactor canvas drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76635
CCCanvasLayerImpl no longer handles drawing itself, but produces a list of CCCanvasDrawQuads.
These quads are then drawn by LayerRendererChromium.
This is a refactor, so no new tests were added.
Patch by Tim Dresser <tdresser@chromium.org> on 2012-01-20
Reviewed by James Robinson.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCanvasQuad):
- platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp:
(WebCore::CCCanvasDrawQuad::create):
(WebCore::CCCanvasDrawQuad::CCCanvasDrawQuad):
- platform/graphics/chromium/cc/CCCanvasDrawQuad.h:
(WebCore::CCCanvasDrawQuad::textureId):
(WebCore::CCCanvasDrawQuad::hasAlpha):
(WebCore::CCCanvasDrawQuad::premultipliedAlpha):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
- 11:08 AM Changeset in webkit [105528] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Do not recompute viewport on same page navigation
https://bugs.webkit.org/show_bug.cgi?id=75576
Reviewed by Darin Fisher.
Added parameter isNavigationWithinPage to WebViewImpl::didCommitLoad
that indicates whether a same-page navigation has just occurred.
The page scale factor flag is reset only on navigation to a new page.
If the flag is not set, viewport and page scale will be recomputed on
layoutUpdated.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::observeNewNavigation):
- src/WebViewImpl.h:
- 11:06 AM Changeset in webkit [105527] by
-
- 1 edit5 adds in trunk/LayoutTests
Add new baselines for a test introduced in
http://trac.webkit.org/changeset/105515. These all appear to be
correct.
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-mac-leopard/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-win/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-win/fast/borders/scaled-border-image-expected.txt: Added.
- 11:03 AM Changeset in webkit [105526] by
-
- 10 edits9 adds23 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/105513. Even
though these results look different on different platforms, the tests
seem to be aiming for the two boxes to look the same, which they do.
Also, removed some redundant results.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/97619-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png: Removed.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.png: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- 10:52 AM Changeset in webkit [105525] by
-
- 2 edits in trunk/LayoutTests
This test fails.
- platform/chromium/test_expectations.txt:
- 10:17 AM Changeset in webkit [105524] by
-
- 3 edits2 adds in trunk
Crash in xsltParseGlobalVariable.
https://bugs.webkit.org/show_bug.cgi?id=75978
Reviewed by Andreas Kling.
Source/WebCore:
The code missed to reset the stylesheet pointer after we fail
to compile the XSLT stylesheet. As a result, the stylesheet gets
reused with a removed document in the next transformToFragment call.
Test: fast/xsl/xslt-transform-to-fragment-crash.html
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::transformToString):
LayoutTests:
- fast/xsl/xslt-transform-to-fragment-crash-expected.txt: Added.
- fast/xsl/xslt-transform-to-fragment-crash.html: Added.
- 9:36 AM Changeset in webkit [105523] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708
- platform/qt-wk2/Skipped: Typo fix after last change.
- 9:35 AM Changeset in webkit [105522] by
-
- 2 edits in trunk/Tools
build-webkit: Don't spit out congratulations message on Ctrl+C
Reviewed by Andreas Kling.
- 9:07 AM Changeset in webkit [105521] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708
- platform/qt-wk2/Skipped: Skip failing tests to paint the bot green.
- 9:06 AM Changeset in webkit [105520] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r105486.
- fast/dom/constructed-objects-prototypes-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 8:49 AM Changeset in webkit [105519] by
-
- 2 edits in trunk/Tools
[GTK] Allow extra jhbuild modulesets
https://bugs.webkit.org/show_bug.cgi?id=76691
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuildrc: Extra modulesets and modules can be added in
JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
env variables respectively. Use comma-separated values. Example:
WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
- 8:32 AM Changeset in webkit [105518] by
-
- 22 edits in trunk/LayoutTests
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Unreviewed gardening after r105513, update Qt specific results.
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/qt/svg/wicd/rightsizing-grid-expected.png:
- platform/qt/svg/wicd/rightsizing-grid-expected.txt:
- platform/qt/tables/mozilla/bugs/bug101674-expected.png:
- platform/qt/tables/mozilla/bugs/bug101674-expected.txt:
- platform/qt/tables/mozilla/bugs/bug86708-expected.png:
- platform/qt/tables/mozilla/bugs/bug86708-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- 8:24 AM Changeset in webkit [105517] by
-
- 9 edits in trunk/Source/WebKit2
[Qt] Trigger forcing accelerated compositing from the UI process side.
https://bugs.webkit.org/show_bug.cgi?id=76296
Reviewed by Noam Rosenthal.
Some messages can be sent from the web view to the LayerTreeHost before
accelerated compositing is entered on the web process and signaled back.
By letting the UI process decide if AC has to be forced, we can create
the LayerTreeHostProxy earlier to send messages to the web process while
AC is being entered there.
This patch also fixes the flow of DidRenderFrame and RenderNextFrame messages
by setting the m_waitingForUIProcess flag properly and only send the
RenderNextFrame once the painting thread on the UI process is ready to paint.
This fixes the first visible content rect message not being received when
loading pages from the disk.
- Shared/WebPreferencesStore.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::didRenderFrame):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
- 7:56 AM Changeset in webkit [105516] by
-
- 13 edits in trunk/LayoutTests
2012-01-20 Nikolas Zimmermann <nzimmermann@rim.com>
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Not reviewed. Rebaseline gtk results.
- platform/gtk/fast/block/float/015-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/gtk/svg/custom/use-font-face-crash-expected.txt:
- platform/gtk/svg/wicd/rightsizing-grid-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug101674-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug86708-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- 7:51 AM Changeset in webkit [105515] by
-
- 3 edits3 adds in trunk
REGRESSION (r98852): apple.com navigation bar is broken under full-page zoom
https://bugs.webkit.org/show_bug.cgi?id=76249
Reviewed by Andreas Kling.
Source/WebCore:
Fix regression with full-page zoom & border-image. paintNinePieceImage() expects local, unzoomed coordinates.
Restore the behaviour as it was before r98852, fixing the regression.
Test: fast/borders/scaled-border-image.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
Add new test covering zooming + border-image, which regressed.
- fast/borders/scaled-border-image.html: Added.
- platform/mac/fast/borders/scaled-border-image-expected.png: Added.
- platform/mac/fast/borders/scaled-border-image-expected.txt: Added.
- 7:33 AM Changeset in webkit [105514] by
-
- 39 edits3 adds in trunk
[CSSRegion]Expose DOM interface for WebKitCSSRegionRule
https://bugs.webkit.org/show_bug.cgi?id=73985
Reviewed by Antti Koivisto.
Source/WebCore:
Start by exposing the interface and the cssRules attribute of type CSSRuleList.
Test: fast/regions/webkit-region-rule.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- css/WebKitCSSRegionRule.cpp:
- css/WebKitCSSRegionRule.h:
- css/WebKitCSSRegionRule.idl:
- page/DOMWindow.idl:
LayoutTests:
Start by exposing the interface and the cssRules attribute of type CSSRuleList.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/regions/webkit-region-rule-expected.txt: Added.
- fast/regions/webkit-region-rule.html: Added.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 7:30 AM Changeset in webkit [105513] by
-
- 58 edits in trunk
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Reviewed by Antti Koivisto.
Source/WebCore:
Remove a gazillion of hacks out of our SVG implementation, by correctly differentiating between the
SVG width/height attributes and the CSS width/height properties. They need to be treated independently
when handling the intrinsic size negotiation, according to both CSS 2.1 & SVG 1.1 2nd Edition specs.
Fixes several bugs in the LayoutTests/svg/custom/*object*sizing tests, we now match Opera perfectly. FF still has some bugs, and IE9 as well.
- css/svg.css: Remove hardcoded, width/height: 100% on <svg>.
- rendering/RenderBox.h:
(WebCore::RenderBox::computeIntrinsicRatioInformation): Make 'intrinsicRatio' a float, and add 'intrinsicSize' as seperated FloatSize, to avoid confusion.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Add forgotton case for percentage intrinsic sizes, that lead to workarounds in other places, that can now be removed.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth): Directly use imageHasRelativeWidth/Height(), it does differentiate between SVG/CSS width/height attributes/properties now.
(WebCore::RenderImage::computeIntrinsicRatioInformation): Adapt to 'intrinsicRatio' argument change.
- rendering/RenderImage.h: Ditto.
- rendering/RenderReplaced.cpp: Refactor existing code, break out firstContainingBlockWithLogicalWidth/hasReplacedLogicalWidth/hasReplacedLogicalHeight/hasAutoHeightOrContainingBlockWithAutoHeight.
(WebCore::firstContainingBlockWithLogicalWidth): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalWidth): Refactored, and exported, so SVGSVGElement::widthAttributeEstablishesViewport() can use it.
(WebCore::hasAutoHeightOrContainingBlockWithAutoHeight): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalHeight): Refactored, and exported, so SVGSVGElement::heightAttributeEstablishesViewport() can use it.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Adapt to 'intrinsicRatio' changes ('intrinsicSize' is now decoupled from it). Refactor so that RenderSVGRoot can directly use it as well!
(WebCore::RenderReplaced::computeReplacedLogicalHeight): Ditto.
- rendering/RenderReplaced.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Only determine the intrinsic size & ratio using the SVG width/height attributes, not the CSS width/height properties, as it's specified.
(WebCore::resolveLengthAttributeForSVG): Helper function for computeReplacedLogicalWidth/Height, that scales Length values that come from SVG width/height attributes.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Finally remove home-brewn size computation logic - it can be fully shared with RenderReplaced now that we inherit from it.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::viewport): Export viewport() for easier length resolution.
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport): Finally clean up this hell, and make it easy to understand. Only need to resolve lengths against either RenderSVGRoot or RenderSVGViewportContainer now.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport): Remove wrong code and disable this. Its not used, and we have no test coverage for it. Its current implementation didn't make any sense.
(WebCore::SVGSVGElement::parseMappedAttribute): Remove hacks mapping SVG width/height attributes to CSS properties.
(WebCore::SVGSVGElement::svgAttributeChanged): Ditto.
(WebCore::SVGSVGElement::localCoordinateSpaceTransform): Refactored.
(WebCore::SVGSVGElement::currentViewBoxRect): Ditto.
(WebCore::SVGSVGElement::currentViewportSize): Ditto.
(WebCore::SVGSVGElement::widthAttributeEstablishesViewport): Main logic determining if the SVG or CSS properties establish the viewport - a direct transliteration from the spec.
(WebCore::SVGSVGElement::heightAttributeEstablishesViewport): Ditto.
(WebCore::SVGSVGElement::intrinsicWidth): Helper.
(WebCore::SVGSVGElement::intrinsicHeight): Ditto.
- svg/SVGSVGElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::size): Cleanup code.
(WebCore::SVGImage::hasRelativeWidth): Added, avoids hacks in RenderBoxModelObject.
(WebCore::SVGImage::hasRelativeHeight): Ditto.
(WebCore::SVGImage::computeIntrinsicDimensions): Make use of new SVGSVGElement::computeIntrinsicDimensions.
- svg/graphics/SVGImage.h:
LayoutTests:
Update SVG pixel test baseline.
- platform/mac/svg/custom/dynamic-empty-path-expected.png: Marginal changes.
- platform/mac/svg/custom/fractional-rects-expected.png: Ditto.
- platform/mac/svg/custom/js-update-container-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Align with Opera, gives same result now. All *object*sizing* tests are passing now.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Ditto.
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Marginal changes.
- platform/mac/svg/custom/viewBox-hit-expected.png: Ditto.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-background-images-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug101674-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug101674-expected.txt: Ditto.
- platform/mac/tables/mozilla/bugs/bug86708-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug86708-expected.txt: Ditto.
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.png: Ditto.
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt: Ditto.
- svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Fix test, now that our bug is fixed.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Ditto.
- svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Ditto.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Ditto.
- svg/foreignObject/text-tref-02-b-expected.txt: Size is not reported anymore.
- 7:03 AM Changeset in webkit [105512] by
-
- 5 edits4 adds in trunk
window.innerWidth/Height should not include page scale
https://bugs.webkit.org/show_bug.cgi?id=76555
Source/WebCore:
The DOM attributes window.innerWidth and window.innerHeight should be in
CSS pixels instead of device pixels. Currently the text zoom factor is
cancelled out when calculating these values, but the same also needs to
be done for the page scale.
There is an additional subtlety concerning frames/iframes since their
visible content rectangle is already in (unscaled) CSS pixels. By using
Frame::frameScaleFactor() we avoid unnecessarily cancelling out the page
scale factor in this case.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-20
Reviewed by Kenneth Rohde Christiansen.
Tests: fast/dom/iframe-inner-size-scaling.html
fast/dom/window-inner-size-scaling.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
LayoutTests:
Add two tests for window.innerWidth and window.innerHeight interaction
with page scaling.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-20
Reviewed by Kenneth Rohde Christiansen.
- fast/dom/iframe-inner-size-scaling-expected.txt: Added.
- fast/dom/iframe-inner-size-scaling.html: Added.
- fast/dom/window-inner-size-scaling-expected.txt: Added.
- fast/dom/window-inner-size-scaling.html: Added.
- fast/frames/frame-set-rotation-hit.html: Calculate the panel height before changing the page scale, because the visual viewport changes with the page scale.
- fast/frames/frame-set-scaling-hit.html: Ditto.
- 6:53 AM Changeset in webkit [105511] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] animations tests fails which uses suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=43905
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-20
Reviewed by Csaba Osztrogonác.
They seem to pass correctly on my machine.
- platform/qt/Skipped:
- platform/qt/animations/additive-transform-animations-expected.txt: Added.
- 6:49 AM Changeset in webkit [105510] by
-
- 9 edits2 adds in trunk/LayoutTests
new baselines for crbug 110493
https://bugs.webkit.org/show_bug.cgi?id=76629
Patch by Elliot Poger <epoger@google.com> on 2012-01-20
Reviewed by Dirk Pranke.
- platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-linux/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-win/svg/custom/focus-ring-expected.png:
- platform/chromium/test_expectations.txt:
- 6:29 AM Changeset in webkit [105509] by
-
- 2 edits1 delete in trunk
Unreviewed; Windows buildbot update failure fix.
- ../ManualTests/data-transfer-items-file-dragout.html: Removed the notion of test:lorem-text.html.
- ../ManualTests/resources/test:lorem-text.html: Removed as this doesn't work on Windows.
- 4:36 AM Changeset in webkit [105508] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Skip failing tests.
- platform/qt-wk2/Skipped: Skip tests because of https://bugs.webkit.org/show_bug.cgi?id=76699
- platform/wk2/Skipped: Skip a test because of missing layoutTestController.setEditingBehavior
- 4:31 AM Changeset in webkit [105507] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [chromium] add WebDevToolsFrontendClient::openInNewTab for upcoming WebCore change.
https://bugs.webkit.org/show_bug.cgi?id=76698
Reviewed by Yury Semikhatsky.
- public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::openInNewTab):
- 4:21 AM BuildingGtk edited by
- Added libxtst-dev - needed for jhbuilding the at-spi bits required for … (diff)
- 4:08 AM Changeset in webkit [105506] by
-
- 30 edits8 adds in trunk
Add DataTransferItems support for drag-and-drop'ed files and texts
https://bugs.webkit.org/show_bug.cgi?id=76367
Reviewed by Tony Chang.
WebKit-svn:
- ManualTests/data-transfer-items-file-dragout.html: Added.
- ManualTests/resources/test:lorem-text.html: Added.
WebKit-svn/LayoutTests:
- editing/pasteboard/data-transfer-items-drag-drop-file-expected.txt: Added.
- editing/pasteboard/data-transfer-items-drag-drop-file.html: Added.
- editing/pasteboard/data-transfer-items-drag-drop-string-expected.txt: Added.
- editing/pasteboard/data-transfer-items-drag-drop-string.html: Added.
- platform/gtk/Skipped: Added the new tests as the platform does not support dataTransferItems yet.
- platform/mac/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
WebKit-svn/Source/WebCore:
Per http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransfer-interface
the new interface should also support drag-and-dropped files and texts in
addition to pasted texts/images. The user apps should also be able to add
texts/files to the drag store by calling event.dataTransfer.items.add().
This patch adds drag-and-drop'ed items support in DataTransferItem and
DataTransferItemList so that they work for dropped files and texts (as well as
the copy-pasted texts/images).
This patch also adds customized toJS()/toV8() code to Blob/File javascript
binding so that the JS code can get either Blob or File underlying object
where the API returns Blob. This change is necessary since we return Blob
from DataTransferItem.getAsFile() for pasted images but want to return File
for dropped files.
Tests: editing/pasteboard/data-transfer-items-drag-drop-file.html
editing/pasteboard/data-transfer-items-drag-drop-string.html
- GNUmakefile.list.am: Added entries for the new {JS,V8}BlobCustom.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.gypi: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSBlobCustom.cpp: Added toJS custom code that returns File or
Blob depending on the return value of isFile().
(WebCore::toJS):
- bindings/v8/custom/V8BlobCustom.cpp: Added toV8 custom code.
(WebCore::toV8):
- dom/DataTransferItem.h: Added a new create() method which takes File.
- dom/DataTransferItemList.cpp: Added add(File) method.
(WebCore::DataTransferItemList::add):
- dom/DataTransferItemList.h: Ditto.
- dom/DataTransferItemList.idl: Ditto.
- fileapi/Blob.idl: Added CustomToJS for toJS/toV8.
- platform/chromium/ClipboardChromium.cpp: Added code for drag-and-drop'ed items.
(WebCore::ClipboardChromium::items): Revised.
(WebCore::ClipboardChromium::mayUpdateItems): Added.
(WebCore::ClipboardChromium::isStorageUpdated): Added.
- platform/chromium/ClipboardChromium.h:
- platform/chromium/DataTransferItemChromium.cpp: Added a new constructor that
takes File and updated getAsFile() to make it support dropped files.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsFile):
- platform/chromium/DataTransferItemChromium.h:
- platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::addInternalItem):
- platform/chromium/DataTransferItemListChromium.cpp: Added overrides implementation for m_item accessors to make them reflect the changes in the owner clipboard.
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::mayUpdateItems): Added.
- platform/qt/DataTransferItemQt.cpp: Added a new constructor that takes File and updated
getAsFile() to make it support dropped files.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsFile):
- platform/qt/DataTransferItemQt.h:
- 3:43 AM Changeset in webkit [105505] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Unreviewed, unskipping test passing after r105286.
- platform/gtk/Skipped: Unskip test.
- 3:39 AM Changeset in webkit [105504] by
-
- 7 edits in trunk/Source/WebKit2
Unreviewed, rolling out r105497.
http://trac.webkit.org/changeset/105497
https://bugs.webkit.org/show_bug.cgi?id=76696
Leaking in Qt layout tests and timing out in GTK API tests.
(Requested by jturcotte on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-20
- Shared/WebPreferencesStore.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
- 3:29 AM Changeset in webkit [105503] by
-
- 17 edits6 adds in trunk
[GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
https://bugs.webkit.org/show_bug.cgi?id=72589
Reviewed by Martin Robinson.
.:
New optional dependency for WK2's accessibility unit test: AT-SPI2.
- configure.ac: Check for AT-SPI2 when building with WK2 support.
Source/WebKit2:
Expose the accessibility hierarchy in the multi-process
architecture of WK2 through AtkSocket and AtkPlug.
Make the WebView widget return an AtkSocket when calling to
gtk_widget_get_accessible().
- GNUmakefile.am: Add new files.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_init):
(webkitWebViewBaseGetAccessible):
(webkit_web_view_base_class_init):
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp: Added.
(webkitWebViewBaseAccessibleWidgetFinalize):
(webkitWebViewBaseAccessibleWidgetDestroyed):
(webkitWebViewBaseAccessibleInitialize):
(webkitWebViewBaseAccessibleRefStateSet):
(webkitWebViewBaseAccessibleGetIndexInParent):
(webkit_web_view_base_accessible_init):
(webkit_web_view_base_accessible_class_init):
(webkitWebViewBaseAccessibleNew):
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.h: Added.
Make the WebPage create an AtkPlug on its initialization and
sending the ID of that plug to the UI process, so it can embed the
plug in the socket.
Also, take care of all the needed wrapping around the WebCore's
accessibility objects, exposing them in the UI process's
accessibility hierarchy thanks to the socket-plug connection.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::accessibilityPlugID):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/gtk/WebPageAccessibilityObject.cpp: Added.
(accessibilityRootObjectWrapper):
(webPageAccessibilityObjectInitialize):
(webPageAccessibilityObjectGetIndexInParent):
(webPageAccessibilityObjectGetNChildren):
(webPageAccessibilityObjectRefChild):
(web_page_accessibility_object_init):
(web_page_accessibility_object_class_init):
(webPageAccessibilityObjectNew):
(webPageAccessibilityObjectRefresh):
- WebProcess/WebPage/gtk/WebPageAccessibilityObject.h: Added.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):
New unit test for checking accessibility support in WK2GTK.
- UIProcess/API/gtk/tests/AccessibilityTestServer.cpp: Added.
(loadChangedCallback): Notify the parent process (the test)
when ready.
(main):
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp: Added.
(stopTestServer):
(sigAbortHandler):
(testServerMonitorThreadFunc):
(startTestServerMonitor):
(startTestServer):
(checkAtspiAccessible):
(findTestServerApplication):
(testAtspiBasicHierarchy):
(beforeAll):
(afterAll):
Tools:
Ensure the accessibility infrastructure is available when running
the unit tests, otherwise WK2's accessibility tests won't work.
- Scripts/run-gtk-tests:
(TestRunner):
(TestRunner._lookup_atspi2_binary): New. Looks for the directory
where at-spi2's stuff is located (like at-spi-bus-launcher and
at-spi2-registryd).
(TestRunner.run): Initialize the accessibility infrastructure.
- gtk/generate-gtkdoc:
(get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
- gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
- 3:10 AM Changeset in webkit [105502] by
-
- 16 edits2 adds2 deletes in trunk
remove CSSBorderImageValue
https://bugs.webkit.org/show_bug.cgi?id=75563
Reviewed by Tony Chang.
Source/WebCore:
Remove CSSBorderImageValue as border-image is a shorthand therefore we don't
need a dedicated CSS class type for it. CSSBorderImageValue was here for
-webkit-border-image which is not a shorthand. This is the first step to move border-image
close to a correct shorthand implementation while keeping -webkit-border-image being a regular
CSS property.
No new tests : It's a refactor, existing tests should cover it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSBorderImage.cpp: Added.
(WebCore::createBorderImageValue):
- css/CSSBorderImage.h: Added.
- css/CSSBorderImageValue.cpp: Removed.
- css/CSSBorderImageValue.h: Removed.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::commitBorderImage):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):
- css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
LayoutTests:
Modify the expected output as now border-image is a CSSValueList.
- fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
- 2:51 AM Changeset in webkit [105501] by
-
- 2 edits in branches/chromium/963/Source/WebCore/inspector/front-end
Merge 105140 (re-land) - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058
Reviewed by Pavel Feldman.
As per the results of a war room:
- Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
- Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
- Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
- Grayed autocompletion can only be accepted with the End or Right keys.
- Enter can accept a selected suggestion item from the list, without committing the input.
- Retain the CSS model editing behavior as close to the existing one as possible.
- Enable PageUp/PageDown to navigate the suggest box items.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271002
- 2:29 AM Changeset in webkit [105500] by
-
- 21 edits3 adds in trunk
Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76353
Reviewed by Hajime Morita.
Add ShadowRoot.idl, which is enabled only on chromium port since this is
under development feature.
ShadowRoot.idl contains minimum API so that we can test it.
Other APIs should be added on other changes so that we can isolate issues.
Source/WebCore:
Test: fast/dom/shadow/shadow-root-js-api.html
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::host):
- dom/ShadowRoot.idl: Added.
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableShadowDOM):
(WebKit::WebRuntimeFeatures::isShadowDOMEnabled):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
- fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
- fast/dom/shadow/shadow-root-js-api.html: Added.
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 2:17 AM Changeset in webkit [105499] by
-
- 2 edits in branches/chromium/963/Source/WebCore/inspector/front-end
Revert 105252 - Merge 105140 - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058
Reviewed by Pavel Feldman.
As per the results of a war room:
- Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
- Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
- Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
- Grayed autocompletion can only be accepted with the End or Right keys.
- Enter can accept a selected suggestion item from the list, without committing the input.
- Retain the CSS model editing behavior as close to the existing one as possible.
- Enable PageUp/PageDown to navigate the suggest box items.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252006
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9131006
- 2:04 AM Changeset in webkit [105498] by
-
- 3 edits3 adds in trunk
[Qt] Public API watch dog auto test.
https://bugs.webkit.org/show_bug.cgi?id=73922
Reviewed by Simon Hausmann.
This test aims to prevent unintended/unapproved
modifications to the public QML API.
.:
- Source/tests.pri:
Source/WebKit2:
- UIProcess/API/qt/tests/publicapi/publicapi.pro: Added.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Added.
(isCheckedEnum):
(isCheckedClass):
(checkKnownType):
(gatherAPI):
(tst_publicapi::publicAPI):
- 2:02 AM Changeset in webkit [105497] by
-
- 7 edits in trunk/Source/WebKit2
[Qt] Trigger forcing accelerated compositing from the UI process side.
https://bugs.webkit.org/show_bug.cgi?id=76296
Reviewed by Noam Rosenthal.
Some messages can be sent from the web view to the LayerTreeHost before
accelerated compositing is entered on the web process and signaled back.
By letting the UI process decide if AC has to be forced, we can create
the LayerTreeHostProxy earlier to send messages to the web process while
AC is being entered there.
This fixes the first visible content rect message not being received when
loading pages from the disk.
- Shared/WebPreferencesStore.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
- 1:57 AM Changeset in webkit [105496] by
-
- 2 edits in trunk/Tools
[GTK] GTK's DRT not to log events for already defunct objects
https://bugs.webkit.org/show_bug.cgi?id=76620
Reviewed by Martin Robinson.
Do not log 'state-change:defunct' events.
- DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
(printAccessibilityEvent): Early return if a
'state-change:defunct' signal is passed.
(axObjectEventListener): Pass the signal name and value in
separate parameters to printAccessibilityEvent.
- 1:39 AM Changeset in webkit [105495] by
-
- 2 edits in trunk/Source/JavaScriptCore
undefined reference to symbol eina_module_free
https://bugs.webkit.org/show_bug.cgi?id=76681
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-20
Reviewed by Martin Robinson.
eina_module_free has been used without including eina libraries after r104936.
- wtf/PlatformEfl.cmake: Add EINA_LIBRARIES.
- 1:23 AM Changeset in webkit [105494] by
-
- 2 edits in trunk/Websites/webkit.org
Each style rule should have its own ID.
https://bugs.webkit.org/show_bug.cgi?id=76428
Reviewed by David Levin.
- coding/coding-style.html: Add an id attribute to each of li elements,
and add code to set title="#id-name" and to make li elements clickable.
- 1:12 AM Changeset in webkit [105493] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r105486.
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 1:05 AM Changeset in webkit [105492] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a new failing test.
- platform/qt/Skipped:
- 12:59 AM Changeset in webkit [105491] by
-
- 7 edits2 copies in trunk/Source/WebKit/chromium
[chromium] Chromium should have EditorClientImpl::checkTextOfParagraph.
https://bugs.webkit.org/show_bug.cgi?id=74071
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-20
Reviewed by Darin Fisher.
Spellchecker on Mac has more sophisticated interface for spellchecking (checkTextOfParagraph).
If the other ports have the same interface, code can be clearer and easy to extend.
This patch introduces such an interface. The implementation will be done not in WebKit but in Chromium.
Also, currently WebKit::WebTextCheckingResult and WebCore::TextCheckingResult have different forms.
They should be corresponding apparently. This patch introduces such correspondence.
- WebKit.gyp:
- public/WebSpellCheckClient.h:
(WebKit::WebSpellCheckClient::checkTextOfParagraph):
A new interface for spellchecking.
- public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
Changed so that WebTextCheckingResult corresponds to WebCore::TextCheckingResult.
- public/WebTextCheckingType.h: Copied from Source/WebKit/chromium/public/WebTextCheckingResult.h.
- src/AssertMatchingEnums.cpp:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::checkTextOfParagraph):
- src/EditorClientImpl.h:
- src/WebTextCheckingResult.cpp: Copied from Source/WebKit/chromium/public/WebTextCheckingResult.h.
(WebKit::WebTextCheckingResult::operator TextCheckingResult):
- 12:47 AM Changeset in webkit [105490] by
-
- 6 edits in trunk/Source/WebCore
Change LocalizedNumber interface
https://bugs.webkit.org/show_bug.cgi?id=76613
Reviewed by Hajime Morita.
Change the functions of LocalizedNumber from:
double parseLocalizedNumber(const String&);
String formatLocalizedNumber(double, unsigned fractionDigits);
To:
String convertToLocalizedNumber(const String&, usnigned fractionDigits);
String convertFromLocalizedNumber(const String&);
in order that we can avoid conversion from/to a double value.
The fractionDigits argumetn of convertToLocalizedNumber() will be
removed in the future. We need it because we'd like to recycle the old
functions to implement new functions for now and functions in
LocalizedNumber can't call functions in HTMLParserIdioms.cpp.
No new tests because the change doesn't make any behavior change.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::visibleValue):
Use convertToLocalizedNumber.
(WebCore::NumberInputType::convertFromVisibleValue):
Use convertFromLocalizedNumber.
(WebCore::NumberInputType::isAcceptableValue): ditto.
- platform/text/LocalizedNumber.h:
Remove parseLocalizedNumber and formatLocalizedNumber, and
introduce convertToLocalizedNumber and convertFromLocalizedNumber.
- platform/text/LocalizedNumberICU.cpp:
(WebCore::parseLocalizedNumber): Make this static.
(WebCore::formatLocalizedNumber): Make this static.
(WebCore::convertToLocalizedNumber): Implement this with formatLocalizedNumber.
(WebCore::convertFromLocalizedNumber): Implement this with parseLocalizedNumber.
- platform/text/LocalizedNumberNone.cpp:
(WebCore::convertToLocalizedNumber):
Implement this as a function returning the input string.
(WebCore::convertFromLocalizedNumber): ditto.
- platform/text/mac/LocalizedNumberMac.mm:
(WebCore::parseLocalizedNumber): Make this static.
(WebCore::formatLocalizedNumber): Make this static.
(WebCore::convertToLocalizedNumber): Implement this with formatLocalizedNumber.
(WebCore::convertFromLocalizedNumber): Implement this with parseLocalizedNumber.
- 12:42 AM Changeset in webkit [105489] by
-
- 6 edits in trunk/Source/WebKit/chromium
[chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily.
https://bugs.webkit.org/show_bug.cgi?id=73971
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-20
Reviewed by Darin Fisher.
This interface is necessary to recheck spelling of an arbitrary element.
- public/WebFrame.h:
- public/WebNode.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::requestTextChecking):
Requests spellchecking for the element having current selection.
- src/WebFrameImpl.h:
- src/WebNode.cpp:
(WebKit::WebNode::rootEditableElement):
Takes a root editable element from Node.
- 12:26 AM Changeset in webkit [105488] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: problem with Ctrl - <arrows> shortcuts in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=76622
Reviewed by Yury Semikhatsky.
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.set readOnly):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewer.prototype.wasShown):
(WebInspector.TextViewer.prototype.willHide):
- inspector/front-end/UIUtils.js:
(WebInspector.isInEditMode):
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
- 12:04 AM Changeset in webkit [105487] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test results rebaseline after r105457.
- fast/canvas/canvas-webkitLineDash-expected.txt:
- 12:00 AM Changeset in webkit [105486] by
-
- 11 edits3 adds in trunk
Source/WebCore: Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386
Reviewed by Adam Barth.
Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing -
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html
- html/DOMURL.cpp: Added HashMap for local static objects.
(WebCore::PublicURLManager::PublicURLManager):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
(WebCore::publicURLManagerMap):
(WebCore::publicURLManager):
(WebCore::publicBlobURLs):
(WebCore::publicStreamURLs):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
- html/DOMURL.h:
(WebCore::DOMURL::create):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::DOMURL):
- html/DOMURL.idl:
- page/DOMWindow.cpp: Removed object initialization for DOMURL.
- page/DOMWindow.h: ditto.
- page/DOMWindow.idl: ditto.
- workers/WorkerContext.cpp: ditto.
- workers/WorkerContext.h: ditto.
- workers/WorkerContext.idl: ditto.
LayoutTests: Migrate createObjectURL & revokeObjectURL to static (Class) methods
https://bugs.webkit.org/show_bug.cgi?id=74386
Reviewed by Adam Barth.
Added test to check if createObjectURL & revokeObjectURL are static functions.
- fast/dom/DOMURL: Added.
- fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
- fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
Jan 19, 2012:
- 11:45 PM Changeset in webkit [105485] by
-
- 18 edits3 adds in trunk
Source/WebCore: CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime
https://bugs.webkit.org/show_bug.cgi?id=76444
Added setCSSCustomFilterEnabled/isCSSCustomFilterEnabled that is false by default.
I've enabled it by default on Apple Mac, to make sure there's no behavior change. Anyway, CSS shaders need
WebGL enabled, so it ends up being disabled by default.
Reviewed by Nikolas Zimmermann.
Test: css3/filters/effect-custom-disabled.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFilter):
Do not parse the custom() function when shaders are disabled.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Do not overwrite the old style->filter() if parsing fails.
(WebCore::CSSStyleSelector::createFilterOperations):
Do not continue if one custom() filter fails to parse.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setCSSCustomFilterEnabled):
(WebCore::Settings::isCSSCustomFilterEnabled):
- rendering/FilterEffectRenderer.cpp:
(WebCore::isCSSCustomFilterEnabled):
(WebCore::FilterEffectRenderer::build):
Avoid creating the filter when shaders are disabled. It may happen to get here if shaders were disabled between parsing and rendering.
Source/WebKit/mac: CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime
https://bugs.webkit.org/show_bug.cgi?id=76444
Added private WebPreference property called "WebKitCSSCustomFilterEnabled".
Reviewed by Nikolas Zimmermann.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences cssCustomFilterEnabled]):
(-[WebPreferences setCSSCustomFilterEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2: CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime
https://bugs.webkit.org/show_bug.cgi?id=76444
Reviewed by Nikolas Zimmermann.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCSSCustomFilterEnabled):
(WKPreferencesGetCSSCustomFilterEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests: CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime
https://bugs.webkit.org/show_bug.cgi?id=76444
Reviewed by Nikolas Zimmermann.
- css3/filters/effect-custom-disabled-expected.txt: Added.
- css3/filters/effect-custom-disabled.html: Added.
- css3/filters/script-tests/effect-custom-disabled.js: Added.
(testInvalidFilterRule):
- platform/wk2/Skipped:
Skipped a couple of tests that call overridePreference.
- 11:18 PM Changeset in webkit [105484] by
-
- 3 edits in trunk/Source/WebCore
Node::canHaveLightChildRendererWithShadow is not used anywhere.
https://bugs.webkit.org/show_bug.cgi?id=76627
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-19
Reviewed by Darin Adler.
Since Node::canHaveLightChildRendererWithShadow is not overriden anywhere, and it returns always false.
We can remove it.
No new tests, because no change in behavior.
- dom/Node.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
- 10:39 PM Changeset in webkit [105483] by
-
- 8 edits in trunk/Source
Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline
https://bugs.webkit.org/show_bug.cgi?id=76625
Reviewed by David Levin.
Source/WebCore:
No new tests as this patch has no functional changes.
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::getIdentifier):
(WebCore::BlobURL::createBlobURL):
- fileapi/BlobURL.h:
- fileapi/FileWriter.cpp:
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
- platform/AsyncFileSystem.cpp:
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystem::toURL):
(WebCore::AsyncFileSystem::isAvailable):
- platform/AsyncFileSystem.h:
Source/WebKit/chromium:
Also removing (almost) duplicated implementation of AsyncFileSystem::crackFileSystem.
- src/AsyncFileSystemChromium.cpp:
- 9:25 PM Changeset in webkit [105482] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: add layout test to Chromium test_expectations.txt file after changes to Mac underline drawing.
- platform/chromium/test_expectations.txt:
- 8:58 PM Changeset in webkit [105481] by
-
- 5 edits in tags/Safari-535.18.1/Source
Versioning
- 8:54 PM Changeset in webkit [105480] by
-
- 5 edits in trunk/Source
Versioning.
- 8:33 PM Changeset in webkit [105479] by
-
- 1 copy in tags/Safari-535.18.1
New Tag.
- 7:44 PM Changeset in webkit [105478] by
-
- 1 copy in tags/Safari-535.18
New Tag.
- 7:36 PM Changeset in webkit [105477] by
-
- 2 edits in trunk/Websites/webkit.org
Remove "Safari 5.1 shipped" text from debugging instructions; move misplaced </ol>
Rubber-stamped by Sam Weinig.
- building/debug.html:
- 7:22 PM Changeset in webkit [105476] by
-
- 2 edits in trunk/Source/WebKit2
Replace improper #import with an #include.
- UIProcess/Plugins/PluginProcessProxy.cpp:
Fixes warnings.
- 7:04 PM Changeset in webkit [105475] by
-
- 64 edits6 moves in trunk/Source
Move RunLoop to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=76471
Reviewed by Anders Carlsson.
Source/WebCore:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add newly moved files.
- platform/RunLoop.cpp: Moved from Source/WebKit2/Platform/RunLoop.cpp.
- platform/RunLoop.h: Moved from Source/WebKit2/Platform/RunLoop.h.
- platform/gtk/RunLoopGtk.cpp: Moved from Source/WebKit2/Platform/gtk/RunLoopGtk.cpp.
- platform/mac/RunLoopMac.mm: Moved from Source/WebKit2/Platform/mac/RunLoopMac.mm.
- platform/qt/RunLoopQt.cpp: Moved from Source/WebKit2/Platform/qt/RunLoopQt.cpp.
- platform/win/RunLoopWin.cpp: Moved from Source/WebKit2/Platform/win/RunLoopWin.cpp.
Move the files.
Source/WebKit2:
- GNUmakefile.am:
- Platform/CoreIPC/Connection.cpp:
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginProcess.cpp:
- PluginProcess/PluginProcess.h:
- PluginProcess/WebProcessConnection.cpp:
- PluginProcess/mac/PluginProcessMainMac.mm:
- PluginProcess/qt/PluginProcessMainQt.cpp:
- Shared/ChildProcess.cpp:
- Shared/ChildProcess.h:
- Target.pri:
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/WKView.mm:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Launcher/ThreadLauncher.cpp:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Launcher/mac/ThreadLauncherMac.mm:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
- UIProcess/Launcher/win/ThreadLauncherWin.cpp:
- UIProcess/LayerTreeHostProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
- UIProcess/ResponsivenessTimer.cpp:
- UIProcess/ResponsivenessTimer.h:
- UIProcess/TiledDrawingAreaProxy.h:
- UIProcess/VisitedLinkProvider.h:
- UIProcess/WebConnectionToWebProcess.cpp:
- UIProcess/WebConnectionToWebProcess.h:
- UIProcess/WebContext.cpp:
- UIProcess/win/WebView.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebConnectionToUIProcess.cpp:
- WebProcess/WebConnectionToUIProcess.h:
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/EventDispatcher.cpp:
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
(WebKit::WebProcess::runLoop):
- WebProcess/gtk/WebProcessMainGtk.cpp:
- WebProcess/mac/WebProcessMainMac.mm:
- WebProcess/qt/WebProcessMainQt.cpp:
- WebProcess/win/WebProcessMainWin.cpp:
- win/WebKit2.vcproj:
Remove RunLoop code and update #includes.
- 7:02 PM Changeset in webkit [105474] by
-
- 2 edits in trunk/Tools
Unreviewed build fix. Wrong variable being used as the cwd for git
remote update command.
- gtk/run-with-jhbuild:
(update_jhbuild):
- 6:51 PM Changeset in webkit [105473] by
-
- 4 edits2 adds in trunk
Fix inconsistent text selection behavior with option-shift-left/right/up/down.
https://bugs.webkit.org/show_bug.cgi?id=75652
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-19
Reviewed by Enrica Casucci.
On Mac, selecting backwards by word, line or paragraph from the middle
of some text, and then going forward leaves the caret back in the middle
with no selection, instead of directly selecting to the other end of the
word/line/paragraph (Unix/Windows behavior). Fix this by adding a new
editing behavior to control whether the selection should go across the
initial position of the caret directly or not in situations like the one
outlined above.
Source/WebCore:
Test: editing/selection/selection-extend-should-not-move-across-caret-on-mac.html
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldExtendSelectionByWordOrLineAcrossCaret):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify):
LayoutTests:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt: Added.
- editing/selection/selection-extend-should-not-move-across-caret-on-mac.html: Added.
- 6:45 PM Changeset in webkit [105472] by
-
- 2 edits in trunk/Tools
[GTK] ensure the jhbuild used by webkit is as up-to-date as needed
https://bugs.webkit.org/show_bug.cgi?id=76585
Reviewed by Martin Robinson.
This allows us to specify a minimum version of jhbuild required,
while also providing stability against changes done to the master
branch, by letting us choose what is the exact version that will
be used.
- gtk/run-with-jhbuild: refactored for more hackability and easier
reading
(jhbuild_installed): checks whether jhbuild is installed
(jhbuild_cloned): checks whether jhbuild has been cloned
(jhbuild_at_expected_revision): checks whether jhbuild is at the
expected revision
(update_jhbuild): brings jhbuild to the expected revision
(clone_jhbuild): clones jhbuild
(install_jhbuild): build and installs jhbuild
(update_webkitgtk_libs): runs update-webkitgtk-libs
(ensure_jhbuild): high-level logic to decide whether and which of
the steps above are executed
- 6:41 PM Changeset in webkit [105471] by
-
- 4 edits3 adds in trunk
Regression (r98735): Video chat moles in Gmail render incorrectly on Mac OS
https://bugs.webkit.org/show_bug.cgi?id=75682
Source/WebCore:
Reviewed by James Robinson.
RenderLayerBacking::isSimpleContainerCompositingLayer() gave incorret
results in the case where the layer itself was visibility:hidden, but
where it had visible, non-composited descendant layers.
Fix by breaking RenderLayerBacking::hasVisibleNonCompositingDescendants()
into two methods, one that tests for renderers in this layer which
render stuff (and are thus affected by visibility on this layer), and
another which walks descendant, non-composited layers looking for those
which are visible.
Removed an early return in the "renderObject->node()->isDocumentNode()"
clause, because we want to run the same code that we run for non-document
nodes.
Test: compositing/visibility/layer-visible-content.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::containsNonEmptyRenderers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):
- rendering/RenderLayerBacking.h:
LayoutTests:
Reviewed by James Robinson.
Testcase with a combination of visibility:hidden, overflow, positioning and
transforms.
- compositing/visibility/layer-visible-content-expected.png: Added.
- compositing/visibility/layer-visible-content-expected.txt: Added.
- compositing/visibility/layer-visible-content.html: Added.
- 6:21 PM Changeset in webkit [105470] by
-
- 11 edits in trunk/Source
[chromium] Draw gutter quads outside root content layer
https://bugs.webkit.org/show_bug.cgi?id=76328
Patch by Alexandre Elias <aelias@google.com> on 2012-01-19
Reviewed by James Robinson.
Add new layer property "backgroundCoversViewport". If the content
layers don't fully cover the render surface, this code calculates the
difference between the root clip rect and the root content layer and
draws up to four background-color quads in exactly the area that would
be undrawn.
Test: CCTiledLayerImplTest::backgroundCoversViewport
Source/WebCore:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBackgroundCoversViewport):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::backgroundCoversViewport):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setBackgroundCoversViewport):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::backgroundCoversViewport):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCTiledLayerImplTest.cpp:
(WebCore::TEST):
- tests/LayerChromiumTest.cpp:
- 6:03 PM Changeset in webkit [105469] by
-
- 7 edits2 copies in trunk/Source/WebKit/chromium
Web Intents chromium API modifications to track IntentRequest invocation method
https://bugs.webkit.org/show_bug.cgi?id=76014
Patch by Greg Billock <gbillock@google.com> on 2012-01-19
Reviewed by Darin Fisher.
- public/WebFrameClient.h:
(WebKit::WebFrameClient::dispatchIntent):
- public/WebIntent.h:
- public/WebIntentRequest.h: Added.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchIntent):
- src/FrameLoaderClientImpl.h:
- src/WebIntent.cpp:
- src/WebIntentRequest.cpp: Added.
- 5:47 PM Changeset in webkit [105468] by
-
- 4 edits in trunk
[Skia Mac] Match style of platform error underline for misspellings
https://bugs.webkit.org/show_bug.cgi?id=76556
Reviewed by Stephen White.
Source/WebCore:
Add Darwin-specific code in Skia to draw the error underline so that
it matches the CoreGraphics style.
Many existing layout tests inadvertantly trigger the misspelling
underline by including the word 'foo' in an editable field. Those
tests are temporarily suppressed separately in an edit to
test_expectations.txt.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):
LayoutTests:
Suppress editing tests with misspellings, since the error underline
is drawn differently.
- platform/chromium/test_expectations.txt:
- 5:34 PM Changeset in webkit [105467] by
-
- 5 edits in trunk/Source/WebCore
[Texmap] TextureMapper creates two many big intermediate surfaces
https://bugs.webkit.org/show_bug.cgi?id=76336
Reviewed by Simon Hausmann.
The following has been done to optimize surface allocation:
- Instead of using a viewport-size surface, use a surface in the size of the layer's bounding rect and apply the transform after the content has been rendered into it.
- Avoid generating intermediate surface for occasions where they're not necessary, such as nested reflections without opacity.
- Releasing of textures from the pool is now implicit, based on refCount.
- Do not use intermediate surfaces for preserve-3d layers. This is in alignment with other ports.
Tests in LayoutTests/compositing/masks and LayoutTests/compositing/reflection cover this.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::paintSelfAndChildren):
(WebCore::TextureMapperNode::intermediateSurfaceRect):
(WebCore::TextureMapperNode::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperNode::isVisible):
(WebCore::TextureMapperNode::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperNode::paintRecursive):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):
- platform/graphics/texmap/TextureMapperNode.h:
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
- 5:22 PM Changeset in webkit [105466] by
-
- 2 edits in trunk/LayoutTests
[Chromium] A Skia roll will break some tests - marking as expected
https://bugs.webkit.org/show_bug.cgi?id=76638
Unreviewed test_expectations update.
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-19
- platform/chromium/test_expectations.txt: Adding MAC to svg/custom/zero-path-square-cap-rendering.svg
- 5:10 PM Changeset in webkit [105465] by
-
- 2 edits in trunk/Tools
[WK2] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76653
Reviewed by John Sullivan.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
Do print a slash if there are no path components.
- 4:57 PM Changeset in webkit [105464] by
-
- 3 edits in trunk/Tools
webkit-patch cannot rollout patches without changelog/bug number
https://bugs.webkit.org/show_bug.cgi?id=75962
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/download.py:
(AbstractRolloutPrepCommand._prepare_state):
- Scripts/webkitpy/tool/commands/download_unittest.py:
(AbstractRolloutPrepCommandTest.test_prepare_state):
- 4:44 PM Changeset in webkit [105463] by
-
- 3 edits2 adds in trunk
Assertion failure in WebCore::HTMLFrameElementBase::insertedIntoDocument()
https://bugs.webkit.org/show_bug.cgi?id=50312
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Removed the ASSERT and updated the comment.
Test: fast/frames/assert-on-insertedIntoDocument.html
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
LayoutTests:
- fast/frames/assert-on-insertedIntoDocument-expected.txt: Added.
- fast/frames/assert-on-insertedIntoDocument.html: Added.
- 4:29 PM Changeset in webkit [105462] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Replace WGC3D visibility extension with resource_usage extension. [Part 1 of 3]
https://bugs.webkit.org/show_bug.cgi?id=76634
Patch by Michal Mocny <mmocny@google.com> on 2012-01-19
Reviewed by Kenneth Russell.
- public/platform/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):
(WebKit::WebGraphicsContext3D::setResourceUsageCHROMIUM):
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::setVisibilityCHROMIUM):
- tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::setResourceUsageCHROMIUM):
- 4:13 PM Changeset in webkit [105461] by
-
- 4 edits in trunk
[WK2] fast/url/degenerate-file-base.html fails
https://bugs.webkit.org/show_bug.cgi?id=76619
Reviewed by Adam Roben.
Tools:
A URL generated form local path for loading had an extra slash, making document.URL
incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
- WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
LayoutTests:
- platform/qt-wk2/Skipped: Unskipped the test.
- 4:07 PM Changeset in webkit [105460] by
-
- 36 edits in trunk/Source
[chromium] Remove CCLayerDelegate, add ContentLayerDelegate for painting
https://bugs.webkit.org/show_bug.cgi?id=76663
Reviewed by Kenneth Russell.
Source/WebCore:
CCLayerDelegate used to be an interface with a half-dozen callbacks on it, but now it has only one call -
paintContents() - and that one call is only valid for one subclass of LayerChromium, ContentLayerChromium. This
removes the CCLayerDelegate pointer from LayerChromium and adds a ContentLayerDelegate for the paint call.
The majority of the code changes in this patch are removing the nil parameter from various places that construct
LayerChromium instances. Also tightens the type of GraphicsLayerChromium::m_layer to ContentLayerChromium.
Refactoring/removing dead code, so no new tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
- platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
- platform/graphics/chromium/CanvasLayerChromium.h:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
- platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerDelegate::~ContentLayerDelegate):
(WebCore::ContentLayerChromium::clearDelegate):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::platformLayer):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::create):
(WebCore::ImageLayerChromium::ImageLayerChromium):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::create):
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::create):
(WebCore::PluginLayerChromium::PluginLayerChromium):
- platform/graphics/chromium/PluginLayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::drawsContent):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::create):
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
- platform/graphics/chromium/WebGLLayerChromium.h:
Source/WebKit/chromium:
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
- src/WebContentLayerImpl.h:
- src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
- src/WebExternalTextureLayerImpl.h:
- src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
- src/WebLayerImpl.h:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::TEST):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::ContentLayerChromiumWithUpdateTracking::create):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
- tests/LayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
- tests/TreeSynchronizerTest.cpp:
(WebCore::MockLayerChromium::MockLayerChromium):
(WebCore::TEST):
- 4:00 PM Changeset in webkit [105459] by
-
- 2 edits in trunk/Source/JavaScriptCore
[chromium] Remove an obsolete comment about features.gypi
https://bugs.webkit.org/show_bug.cgi?id=76643
There can be only one features.gypi.
Reviewed by James Robinson.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 3:48 PM Changeset in webkit [105458] by
-
- 1 edit5 adds in trunk/LayoutTests
Add Chromium-specific image baselines for
fast/css/text-overflow-input.html. These results all appear to be
correct.
- platform/chromium-linux/fast/css/text-overflow-input-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/text-overflow-input-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-input-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-input-expected.txt: Added.
- 3:47 PM Changeset in webkit [105457] by
-
- 9 edits in trunk
[Coverity] Fix uninitialized constructor defects in .../html
https://bugs.webkit.org/show_bug.cgi?id=74965
Patch by Greg Billock <gbillock@google.com> on 2012-01-19
Reviewed by Simon Fraser.
Test: fast/canvas/script-tests/canvas-webkitLineDash.js
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
- html/StepRange.cpp:
(WebCore::StepRange::StepRange):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
- html/canvas/CanvasStyle.h:
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
- html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::WebGLGetInfo):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::CSSPreloadScanner):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::WebVTTParser):
- 3:38 PM Changeset in webkit [105456] by
-
- 13 edits1 move1 add in trunk/PerformanceTests
PerformanceTests's runner.js shouldn't be Parser-specific
https://bugs.webkit.org/show_bug.cgi?id=76670
Reviewed by Ryosuke Niwa.
This runner script is used by a bunch of difference performance tests.
It shouldn't be in the Parser directory anymore.
- Bindings/event-target-wrapper.html:
- Mutation/append-child-deep.html:
- Mutation/append-child.html:
- Mutation/inner-html.html:
- Mutation/remove-child-deep.html:
- Mutation/remove-child.html:
- Parser/html-parser.html:
- Parser/html5-full-render.html:
- Parser/resources/runner.js: Removed.
- Parser/simple-url.html:
- Parser/tiny-innerHTML.html:
- Parser/url-parser.html:
- Parser/xml-parser.html:
- resources: Added.
- resources/runner.js: Copied from PerformanceTests/Parser/resources/runner.js.
- 3:34 PM Changeset in webkit [105455] by
-
- 2 edits in trunk/LayoutTests
[SKIA / CHROMIUM] Add another test to test_expectations to prepare for change to use sw-rasterized paths in skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=76469
Patch by Brian Salomon <bsalomon@google.com> on 2012-01-19
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 3:20 PM Changeset in webkit [105454] by
-
- 8 edits in trunk
CSS Shaders: Remove the setTimeout from the layout tests
https://bugs.webkit.org/show_bug.cgi?id=76535
Reviewed by Tony Chang.
Source/WebCore:
We had setTimeout on old tests because the snapshot picture was taken too early, before the shaders were loaded.
The problem was that the RenderLayer was notified that the shader was loaded only after the onload event was triggered,
so a simple setTimeout(0) would have fixed the issue, but better than that would be to to always call CachedResource::data
in CachedShader::data, which notifies the load earlier (before onload).
No new tests, just removed the setTimeout from old ones.
- loader/cache/CachedShader.cpp:
(WebCore::CachedShader::data):
LayoutTests:
No need for setTimeout anymore, so I've removed them from the custom filter tests.
- css3/filters/custom-filter-shader-cache.html:
- css3/filters/effect-custom-combined-missing.html:
- css3/filters/effect-custom-parameters.html:
- css3/filters/effect-custom.html:
- css3/filters/missing-custom-filter-shader.html:
- 3:07 PM Changeset in webkit [105453] by
-
- 2 edits in trunk/Source/WebCore
Improve touch handling performance by reusing the hitTest result
https://bugs.webkit.org/show_bug.cgi?id=75506
Patch by Min Qin <qinmin@google.com> on 2012-01-19
Reviewed by Adam Barth.
This is a performance optimization and should not cause behavior changes. Existing tests should cover it.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- 3:01 PM Changeset in webkit [105452] by
-
- 3 edits in trunk/Tools
check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
https://bugs.webkit.org/show_bug.cgi?id=76510
Reviewed by Adam Barth.
Unlike other style rules, if you get the syntax of the test_expectations.txt
file wrong, the layout tests won't run. Also, this check is simple and only
slows down committing if you actually modify one of the test_expectations.txt files.
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_check_covers_all_configurations):
(TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
(TestExpectationsTestCase):
(assert_lines_lint):
- 2:56 PM Changeset in webkit [105451] by
-
- 8 edits7 adds in trunk
Add text-overflow support that allows placeholder and value text to show an ellipsis when not focused
https://bugs.webkit.org/show_bug.cgi?id=76118
<rdar://problem/9271742>
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/css/text-overflow-input-focus-placeholder-expected.html
fast/css/text-overflow-input-focus-placeholder.html
fast/css/text-overflow-input-focus-value-expected.html
fast/css/text-overflow-input-focus-value.html
fast/css/text-overflow-input.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange): When the style of the text control
changes, we update the text overflow property of the placeholder.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle): When the style of the text control
changes, we update the text overflow property of the inner text block.
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated): The text of the value and placeholder should
only contain the ellipsis if the input's text-overflow property is set to ellipsis, and the input is not focused.
- rendering/RenderTextControlSingleLine.h:
LayoutTests:
- fast/css/text-overflow-input-focus-placeholder-expected.html: Added.
- fast/css/text-overflow-input-focus-placeholder.html: Added.
- fast/css/text-overflow-input-focus-value-expected.html: Added.
- fast/css/text-overflow-input-focus-value.html: Added.
- fast/css/text-overflow-input.html: Added.
New baselines:
- platform/mac/fast/css/text-overflow-input-expected.png: Added.
- platform/mac/fast/css/text-overflow-input-expected.txt: Added.
Needs baselines:
- platform/chromium/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
- 2:50 PM Changeset in webkit [105450] by
-
- 2 edits in trunk/Tools
Build fix. Revert an unintentional change to WebKitDriver in r105443.
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.init):
- 2:46 PM Changeset in webkit [105449] by
-
- 6 edits in trunk
remove the duplicated build rules from WebKit.gyp, Tools.gyp
https://bugs.webkit.org/show_bug.cgi?id=73384
Reviewed by Tony Chang.
Source/WebKit/chromium:
This patch removes the no-longer-necessary conditional logic for
build_webkit_exes_from_webkit_gyp; we now always build the exes
from their own dedicated gyp files.
- WebKit.gyp:
- WebKitUnitTests.gyp:
- gyp_webkit:
Tools:
This patch removes the no-longer-necessary conditional logic for
build_webkit_exes_from_webkit_gyp; we now always build the exes
from their own dedicated gyp files.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 2:36 PM Changeset in webkit [105448] by
-
- 1 edit1 add in trunk/LayoutTests
Add a V8-specific baseline for fast/regex/syntax-errors.html.
- platform/chromium/fast/regex/syntax-errors-expected.txt: Added.
- 2:07 PM Changeset in webkit [105447] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit/win
Merged r92291.
- 2:07 PM Changeset in webkit [105446] by
-
- 2 edits in trunk/LayoutTests
This test can also timeout.
- platform/chromium/test_expectations.txt:
- 2:04 PM Changeset in webkit [105445] by
-
- 2 edits in trunk/Tools
make-new-script-test should work with HTTP tests
https://bugs.webkit.org/show_bug.cgi?id=76603
Reviewed by Adam Roben.
- Scripts/make-new-script-test:
(makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
now also creates absolute paths for HTTP.
- 1:57 PM Changeset in webkit [105444] by
-
- 6 edits2 adds in trunk
Implicit creation of a regular expression should eagerly check for syntax errors
https://bugs.webkit.org/show_bug.cgi?id=76642
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This is a correctness fix and a slight optimization.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch): Check for syntax errors because that's the
correct behavior.
- runtime/RegExp.cpp:
(JSC::RegExp::match): ASSERT that we aren't a syntax error. (One line
of code change, many lines of indentation change.)
Since we have no clients that try to match a RegExp that is a syntax error,
let's optimize out the check.
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/code-serialize-paren-expected.txt:
- fast/js/script-tests/code-serialize-paren.js: This test was secretly
broken due to a regexp syntax error. Now fixed.
- fast/regex/syntax-errors-expected.txt: Added.
- fast/regex/syntax-errors.html: Added.
- 1:50 PM Changeset in webkit [105443] by
-
- 13 edits1 copy in trunk
Some perf tests time out when ran by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=76612
Reviewed by Dirk Pranke and Eric Seidel.
PerformanceTests:
Replace all images in html5.html by geenbox.png to avoid accessing whatwg.org when
running the parser tests. Also call dumpAsText, waitUntilDone, and notifyDone automatically
inside runner.js to avoid having to call them in individual tests.
- Bindings/event-target-wrapper.html: Removed calls to layoutTestController methods since
they are now called by runner.js automatically.
- Parser/resources/greenbox.png: Copied from LayoutTests/fast/css/resources/greenbox.png.
- Parser/resources/html5.html:
- Parser/resources/runner.js:
(runLoop):
Tools:
Always pass --no-timeout to DumpRenderTree from run-perf-tests.
Otherwise some tests such as Parser/xml-parser.html will timeout.
--no-timeout option is currently supported by Chromium and Mac ports.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.create_driver):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.init):
(ChromiumDriver._wrapper_options):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.init):
(DriverProxy.init):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.init):
(WebKitDriver.cmd_line):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_read_binary_block):
(WebKitDriverTest):
(WebKitDriverTest.test_no_timeout):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_tests_run.RecordingTestDriver.init):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._run_tests_set):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
- 1:49 PM Changeset in webkit [105442] by
-
- 28 edits8 adds in trunk/Source
Implement a new allocator for backing stores
https://bugs.webkit.org/show_bug.cgi?id=75181
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
We want to move away from using fastMalloc for the backing stores for
some of our objects (e.g. JSArray, JSObject, JSString, etc). These backing
stores have a nice property in that they only have a single owner (i.e. a
single pointer to them at any one time). One way that we can take advantage
of this property is to implement a simple bump allocator/copying collector,
which will run alongside our normal mark/sweep collector, that only needs to
update the single owner pointer rather than having to redirect an arbitrary
number of pointers in from-space to to-space.
This plan can give us a number of benefits. We can beat fastMalloc in terms
of both performance and memory usage, we can track how much memory we're using
far more accurately than our rough estimation now through the use of
reportExtraMemoryCost, and we can allocate arbitrary size objects (as opposed
to being limited to size classes like we have been historically). This is also
another step toward moving away from lazy destruction, which will improve our memory footprint.
We start by creating said allocator and moving the ArrayStorage for JSArray
to use it rather than fastMalloc.
The design of the collector is as follows:
Allocation:
-The collector allocates 64KB chunks from the OS to use for object allocation.
-Each chunk contains an offset, a flag indicating if the block has been pinned,
and a payload, along with next and prev pointers so that they can be put in DoublyLinkedLists.
-Any allocation greater than 64KB gets its own separate oversize block, which
is managed separately from the rest.
-If the allocator receives a request for more than the remaining amount in the
current block, it grabs a fresh block.
-Grabbing a fresh block means grabbing one off of the global free list (which is now
shared between the mark/sweep allocator and the bump allocator) if there is one.
If there isn't a new one we do one of two things: allocate a new block from the OS
if we're not ready for a GC yet, or run a GC and then try again. If we still don't
have enough space after the GC, we allocate a new block from the OS.
Garbage collection:
-At the start of garbage collection during conservative stack scanning, if we encounter
what appears to be a pointer to a bump-allocated block of memory, we pin that block so
that it will not be copied for this round of collection.
-We also pin any oversize blocks that we encounter, which effectively doubles as a
"mark bit" for that block. Any oversize blocks that aren't pinned at the end of copying
are given back to the OS.
-Marking threads are now also responsible for copying bump-allocated objects to newSpace
-Each marking thread has a private 64KB block into which it copies bump-allocated objects that it encounters.
-When that block fills up, the marking thread gives it back to the allocator and requests a new one.
-When all marking has concluded, each thread gives back its copy block, even if it isn't full.
-At the conclusion of copying (which is done by the end of the marking phase), we un-pin
any pinned blocks and give any blocks left in from-space to the global free list.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
- heap/AllocationSpace.h:
(JSC::AllocationSpace::waterMark):
- heap/BumpBlock.h: Added.
(JSC::BumpBlock::BumpBlock):
- heap/BumpSpace.cpp: Added.
(JSC::BumpSpace::tryAllocateSlowCase):
- heap/BumpSpace.h: Added.
(JSC::BumpSpace::isInCopyPhase):
(JSC::BumpSpace::totalMemoryAllocated):
(JSC::BumpSpace::totalMemoryUtilized):
- heap/BumpSpaceInlineMethods.h: Added.
(JSC::BumpSpace::BumpSpace):
(JSC::BumpSpace::init):
(JSC::BumpSpace::contains):
(JSC::BumpSpace::pin):
(JSC::BumpSpace::startedCopying):
(JSC::BumpSpace::doneCopying):
(JSC::BumpSpace::doneFillingBlock):
(JSC::BumpSpace::recycleBlock):
(JSC::BumpSpace::getFreshBlock):
(JSC::BumpSpace::borrowBlock):
(JSC::BumpSpace::addNewBlock):
(JSC::BumpSpace::allocateNewBlock):
(JSC::BumpSpace::fitsInBlock):
(JSC::BumpSpace::fitsInCurrentBlock):
(JSC::BumpSpace::tryAllocate):
(JSC::BumpSpace::tryAllocateOversize):
(JSC::BumpSpace::allocateFromBlock):
(JSC::BumpSpace::tryReallocate):
(JSC::BumpSpace::tryReallocateOversize):
(JSC::BumpSpace::isOversize):
(JSC::BumpSpace::isPinned):
(JSC::BumpSpace::oversizeBlockFor):
(JSC::BumpSpace::blockFor):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::add):
- heap/ConservativeRoots.h:
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
(JSC::Heap::releaseFreeBlocks):
- heap/Heap.h:
(JSC::Heap::waterMark):
(JSC::Heap::highWaterMark):
(JSC::Heap::setHighWaterMark):
(JSC::Heap::tryAllocateStorage):
(JSC::Heap::tryReallocateStorage):
- heap/HeapBlock.h: Added.
(JSC::HeapBlock::HeapBlock):
- heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::copy):
(JSC::SlotVisitor::copyAndAppend):
(JSC::SlotVisitor::doneCopying):
- heap/MarkStack.h:
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock):
- heap/MarkedBlock.h:
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
- heap/MarkedSpace.h:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::resetAllocator):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::SlotVisitor):
- heap/TinyBloomFilter.h:
(JSC::TinyBloomFilter::reset):
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):
(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::~JSArray):
(JSC::JSArray::enterSparseMode):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::visitChildren):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):
- runtime/JSArray.h:
(JSC::JSArray::inSparseMode):
(JSC::JSArray::isLengthWritable):
- wtf/CheckedBoolean.h: Added.
(CheckedBoolean::CheckedBoolean):
(CheckedBoolean::~CheckedBoolean):
(CheckedBoolean::operator bool):
- wtf/DoublyLinkedList.h:
(WTF::::push):
- wtf/StdLibExtras.h:
(WTF::isPointerAligned):
Source/JavaScriptGlue:
Added forwarding header for new CheckedBoolean used in the bump allocator.
- ForwardingHeaders/wtf/CheckedBoolean.h: Added.
Source/WebCore:
No new tests.
Added forwarding header for new CheckedBoolean used in the bump allocator.
- ForwardingHeaders/wtf/CheckedBoolean.h: Added.
- 1:41 PM Changeset in webkit [105441] by
-
- 5 edits2 adds in trunk
Crash in CompositeEditCommand::ensureComposition
https://bugs.webkit.org/show_bug.cgi?id=76207
Reviewed by Chang Shu.
Source/WebCore:
The crash was caused by TypingCommand not kept alive when new editing commands are executed
during adding more typings to the open last typing command since m_lastEditCommand is replaced
by the new command. Fixed the bug by keeping them alive a little longer with RefPtr.
Test: editing/execCommand/editing-command-while-executing-typing-command-crash.html
- editing/FrameSelection.cpp:
(WebCore::shouldStopBlinkingDueToTypingCommand):
(WebCore::FrameSelection::updateAppearance):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::closeTyping):
- editing/TypingCommand.h:
LayoutTests:
Add a regression test.
- editing/execCommand/editing-command-while-executing-typing-command-crash-expected.txt: Added.
- editing/execCommand/editing-command-while-executing-typing-command-crash.html: Added.
- 1:16 PM Changeset in webkit [105440] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed debug build fix.
Remove ASSERT that the cached match is cacheable (we don't store that flag anymore.)
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):
- 12:55 PM Changeset in webkit [105439] by
-
- 10 edits in trunk/Source/WebKit2
Need a WebKit2 API for setting media volume https://bugs.webkit.org/show_bug.cgi?id=76560
Reviewed by Dan Bernstein.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode): Encode the mediaVolume parameter.
(WebKit::WebPageCreationParameters::decode): Decode the mediaVolume parameter.
- Shared/WebPageCreationParameters.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetMediaVolume): Call WebPageProxy::setMediaVolume().
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize new data member m_mediaVolume.
(WebKit::WebPageProxy::setMediaVolume): Bail if the volume hasn't changed. Update m_mediaVolume
and bail if the page is no longer valid. Otherwise, send a WebPage::SetMediaVolume message to
the web process.
(WebKit::WebPageProxy::creationParameters): Add media volume to the creation parameters.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize media volume from the WebPageCreationParameters.
(WebKit::WebPage::setMediaVolume): Call Page::setMediaVolume().
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Add the SetMediaVolume message.
- 12:52 PM Changeset in webkit [105438] by
-
- 2 edits in trunk/Source/WebCore
Fix Debug build after r105433
Unreviewed, build fix.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::recalcCollapsedBorders):
- 12:47 PM Changeset in webkit [105437] by
-
- 3 edits in trunk/Tools
Add support for window.print to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=76479
When used in a test window.print goes into print mode and then
straight out again. This will allow the afterprint event to be
tested by having the afterprint event happen before the dump
happens.
Reviewed by Mihai Parparita.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::printPage):
- DumpRenderTree/chromium/WebViewHost.h:
- 12:35 PM Changeset in webkit [105436] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, Roll DEPS to most recent LKGR (118291).
- DEPS:
- 12:32 PM Changeset in webkit [105435] by
-
- 3 edits in trunk/Source/WebCore
CSSStyleSelector: Factor 'isCacheable' flag out of MatchedResult.
<http://webkit.org/b/76376>
Reviewed by Antti Koivisto.
Break up the MatchResult struct into MatchResult and MatchRanges. The matched
declaration cache only needs the ranges, so we save 4 bytes per entry.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::MatchRanges::MatchRanges):
(WebCore::CSSStyleSelector::MatchResult::MatchResult):
- 12:28 PM Changeset in webkit [105434] by
-
- 6 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=75192
Reviewed by Darin Adler.
Notify the media element when tracks are added to and removed from a document instead of
a tree because we don't want to trigger loading unless a track element is in the document.
Test: media/track/track-delete-during-setup.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWasRemoved): Renamed from trackWillBeRemoved because it is
now called after removal.
- html/HTMLMediaElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoDocument): Was insertedIntoTree. Use this instead
because we care about when a track is inserted and removed from a document, not a tree.
(WebCore::HTMLTrackElement::removedFromDocument): Ditto.
- html/HTMLTrackElement.h:
- 12:27 PM Changeset in webkit [105433] by
-
- 3 edits2 adds in trunk
Hit ASSERTION FAILED: table()->collapseBorders() on techcrunch.com
https://bugs.webkit.org/show_bug.cgi?id=76405
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/css/nested-table-with-collapsed-borders.html
Change recalcCollapsedBorders() so that it only collects border values for the current
table. Calculating the borders for nested tables was wrong as well as wasting cycles, though it would never
have impacted rendering since a cell only paints the borders that match its own.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::recalcCollapsedBorders):
LayoutTests:
- fast/css/nested-table-with-collapsed-borders-expected.html: Added.
- fast/css/nested-table-with-collapsed-borders.html: Added.
- 12:03 PM Changeset in webkit [105432] by
-
- 2 edits5 adds4 deletes in trunk/Websites/webkit.org
Update Debugging on Mac OS X instructions for Safari 5.1/WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=67102
Reviewed by Eric Seidel.
Add instructions for debugging UIProcess and WebProcess using Xcode 4.
- building/active-scheme-xcode4.png: Added.
- building/build-settings-tab-xcode4.png: Added.
- building/build-window.png: Removed.
- building/custom-executable-xcode4.png: Added.
- building/custom-executable.png: Removed.
- building/debug-mac-uiprocess.html: Added.
- building/debug.html:
- building/debug.png: Removed.
- building/info-tab.png: Removed.
- building/run-xcode4.png: Added.
- 12:01 PM Changeset in webkit [105431] by
-
- 54 edits in trunk/Source
Make WebAudio API const-correct.
https://bugs.webkit.org/show_bug.cgi?id=76573
Reviewed by Daniel Bates.
Source/WebCore:
No new tests; no net change in functionality, so covered by existing tests.
The non-const data() accessor was renamed mutableData() to expose const-correctness
bugs during compile time:
- platform/audio/AudioChannel.h:
(WebCore::AudioChannel::mutableData):
The following functions were made const correct:
- platform/audio/AudioArray.h:
(WebCore::AudioArray::copyToRange):
- platform/audio/AudioBus.h:
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
- platform/audio/FFTConvolver.cpp:
(WebCore::FFTConvolver::process):
- platform/audio/FFTConvolver.h:
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::doPaddedFFT):
(WebCore::FFTFrame::doFFT):
- platform/audio/FFTFrame.h:
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
- platform/audio/ReverbConvolverStage.h:
- platform/audio/ReverbInputBuffer.cpp:
(WebCore::ReverbInputBuffer::write):
- platform/audio/ReverbInputBuffer.h:
- platform/audio/SincResampler.cpp:
(WebCore::SincResampler::process):
- platform/audio/SincResampler.h:
- platform/audio/ZeroPole.cpp:
(WebCore::ZeroPole::process):
- platform/audio/ZeroPole.h:
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::channelByType):
- platform/audio/AudioBus.h:
(WebCore::AudioBus::gain):
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::process):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/AudioProcessor.h:
- platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::process):
- platform/audio/DynamicsCompressor.h:
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::process):
- platform/audio/DynamicsCompressorKernel.h:
- platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
- platform/audio/EqualPowerPanner.h:
- platform/audio/HRTFElevation.h:
(WebCore::HRTFElevation::numberOfAzimuths):
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::pan):
- platform/audio/HRTFPanner.h:
- platform/audio/Panner.h:
- platform/audio/Reverb.cpp:
(WebCore::Reverb::process):
- platform/audio/Reverb.h:
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::process):
- platform/audio/ReverbConvolver.h:
- platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
(WebCore::FFTFrame::doFFT):
- platform/audio/mkl/FFTFrameMKL.cpp:
(WebCore::FFTFrame::doFFT):
The following functions were modified to use the renamed mutableData() accessor:
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::processWithGainFromMonoStereo):
(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
- platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::scale):
(WebCore::AudioChannel::copyFrom):
(WebCore::AudioChannel::copyFromRange):
(WebCore::AudioChannel::sumFrom):
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::process):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::process):
- platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::process):
- platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
- platform/audio/HRTFKernel.cpp:
(WebCore::extractAverageGroupDelay):
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createImpulseResponse):
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::pan):
- platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::process):
- platform/audio/Reverb.cpp:
(WebCore::Reverb::process):
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::process):
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
- platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::doFFT):
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
- webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::process):
- webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::process):
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::render):
- webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::writeInput):
- webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::process):
Source/WebKit/chromium:
The following functions were modified to use the renamed mutableData() accessor:
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
(WebCore::AudioDestinationChromium::FIFO::consume):
- src/WebAudioData.cpp:
(WebCore::WebAudioBus::channelData):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
- 11:15 AM Changeset in webkit [105430] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, inspector closure compilation fix.
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/TabbedEditorContainer.js:
- 11:13 AM Changeset in webkit [105429] by
-
- 8 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=76644
Before landing support for centering, fix the keyword value to match the latest draft.
The new keyword is "contain" instead of "bounds."
Revised the existing parsing tests to reflect the updated value.
Reviewed by Dan Bernstein.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineGridSnap):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- fast/line-grid/line-grid-snap-parsing-expected.txt:
- fast/line-grid/script-tests/line-grid-snap-parsing.js:
- 11:00 AM Changeset in webkit [105428] by
-
- 10 edits1 copy2 adds in trunk/Source
Enable use of precompiled headers in Chromium port on Windows.
Bug 76381 - Use precompiled headers in Chromium port on Windows
https://bugs.webkit.org/show_bug.cgi?id=76381
Patch by Joi Sigurdsson <joi@chromium.org> on 2012-01-19
Reviewed by Tony Chang.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp: Include WinPrecompile.gypi.
Source/Platform:
- Platform.gyp/Platform.gyp: Include WinPrecompile.gypi.
Source/WebCore:
No new tests needed; if the change builds and existing tests pass
that should provide enough coverage.
- WebCore.gyp/WebCore.gyp: Include WinPrecompile.gypi.
Source/WebKit/chromium:
- WebKit.gyp: Include WinPrecompile.gypi.
- WinPrecompile.cpp: Added.
- WinPrecompile.gypi: Added.
- WinPrecompile.h: Added.
Source/WTF:
- WTF.gyp/WTF.gyp: Include WinPrecompile.gypi.
- 10:57 AM Changeset in webkit [105427] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Switching tabs in TabbedEditorContainer should reveal selected script in navigator.
https://bugs.webkit.org/show_bug.cgi?id=76636
Reviewed by Pavel Feldman.
Renamed FileSelector's ScriptSelected event into FileSelected, added EditorSelected
event to EditorContainer.
Renamed _showSourceFrame into _showFile.
Made _uiSourceCodeRemoved reuse _removeSourceFrame.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.scriptSelected):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._showAndRevealInFileSelector):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
- 10:55 AM Changeset in webkit [105426] by
-
- 4 edits in trunk
[CSSRegions]Add support for background-color in region styling
https://bugs.webkit.org/show_bug.cgi?id=71488
Reviewed by David Hyatt.
Source/WebCore:
This patch enables region styling again. The region styling tests were also added back.
With the improvements from https://bugs.webkit.org/show_bug.cgi?id=76265, hopefully we will not see the same 3% regressions
in performance.
- rendering/RenderObject.h:
(WebCore::RenderObject::style):
LayoutTests:
Add back the region styling tests.
- platform/mac-snowleopard/Skipped:
- 10:53 AM Changeset in webkit [105425] by
-
- 2 edits in trunk/Source/WebCore
Crash at WebCore::MediaControlRootElement::makeOpaque + 97
https://bugs.webkit.org/show_bug.cgi?id=76391
Reviewed by John Sullivan.
No new tests; Speculative fix for crash.
Crash report data suggests this crash is occurring as the document is being
closed. Check the nullity of document()->page() before deref-ing.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeOpaque):
- 10:36 AM Changeset in webkit [105424] by
-
- 2 edits in trunk
Rubber-stamped by Martin Robinson.
- Source/autotools/symbols.filter: try to fix the 32 bits release
bot by also adding the symbol it generates
- 10:05 AM Changeset in webkit [105423] by
-
- 2 edits in trunk/Source/WebCore
Layout Test fast/text/international/spaces-combined-in-vertical-text.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75787
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-19
Reviewed by Simon Fraser.
This is a tweak to my patch in r104322. On some platforms
RenderCombineText::combineText() can abort early during inline
iteration, causing this loop in skipLeadingWhitespace to spin,
hence the layout test timeouts. This patch accounts for that
condition and makes the loop iteration more robust.
No new test because this is fixing a failure on an existing test.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
- 9:54 AM Changeset in webkit [105422] by
-
- 1 edit in branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt
clean up branch expectations
- 9:52 AM Changeset in webkit [105421] by
-
- 2 edits in trunk/Source/WebCore
HRTFPanner not rendering correctly on mac port
https://bugs.webkit.org/show_bug.cgi?id=76397
Reviewed by Eric Carlson.
No new tests; HRTF results are currently not testable.
Re-generate the Composite.wav file from its constituent azimuth & elevation files.
- platform/audio/resources/Composite.wav:
- 9:45 AM Changeset in webkit [105420] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=76577
Fix crash when nested line grids are used. Make sure to bail out if no line grid
is found rather than crashing.
Reviewed by Dan Bernstein.
Source/WebCore:
Added fast/line-grid/line-grid-nested.html.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::establishLineGrid):
LayoutTests:
- fast/line-grid/line-grid-nested-expected.txt: Added.
- fast/line-grid/line-grid-nested.html: Added.
- 9:40 AM Changeset in webkit [105419] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] WebKit2 GTK+ API public headers are not installed
https://bugs.webkit.org/show_bug.cgi?id=76626
Reviewed by Martin Robinson.
- GNUmakefile.am: Rename webkit2gtk_headers as
libwebkit2gtkinclude_HEADERS to match libwebkit2gtkincludedir so
that headers are installed during make install.
- 9:34 AM Changeset in webkit [105418] by
-
- 2 edits in trunk/LayoutTests
[Chromium] A Skia roll will break some tests - marking as expected
https://bugs.webkit.org/show_bug.cgi?id=76638
Unreviewed test_expectations update.
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-19
- platform/chromium/test_expectations.txt:
- 9:30 AM Changeset in webkit [105417] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add print-backgrounds setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76616
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_print_backgrounds):
(webkit_settings_set_print_backgrounds):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
- 8:55 AM Changeset in webkit [105416] by
-
- 4 edits in trunk
editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
https://bugs.webkit.org/show_bug.cgi?id=76588
<rdar://problem/9325183>
Source/WebCore:
Reviewed by Dan Bernstein.
Added TestWebKitAPI test.
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
Tools:
Added test.
Reviewed by Dan Bernstein.
- TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):
- 8:39 AM Changeset in webkit [105415] by
-
- 11 edits2 adds in trunk
Web Inspector: Implement screen resolution emulation backend
https://bugs.webkit.org/show_bug.cgi?id=76532
Reviewed by Pavel Feldman.
Source/WebCore:
The emulation affects [min-|max-]device-(width|height) media queries, window.screen.(width|height),
and window.inner(Width|Height).
Test: inspector/styles/override-screen-size.html
- css/MediaQueryEvaluator.cpp:
(WebCore::device_heightMediaFeatureEval): Apply device-height override if necessary.
(WebCore::device_widthMediaFeatureEval): Apply device-width override if necessary.
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::startSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::didMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::didProcessRule):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::applyScreenWidthOverrideImpl):
(WebCore::InspectorInstrumentation::applyScreenHeightOverrideImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::applyScreenWidthOverride):
(WebCore::InspectorInstrumentation::applyScreenHeightOverride):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setScreenSizeOverride):
(WebCore::InspectorPageAgent::applyScreenWidthOverride):
(WebCore::InspectorPageAgent::applyScreenHeightOverride):
(WebCore::InspectorPageAgent::updateFrameViewFixedLayout):
(WebCore::InspectorPageAgent::clearFrameViewFixedLayout):
(WebCore::InspectorPageAgent::setFrameViewFixedLayout):
- inspector/InspectorPageAgent.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight): Apply height override if necessary.
(WebCore::DOMWindow::innerWidth): Apply width override if necessary.
- page/Screen.cpp:
(WebCore::Screen::height): Apply height override if necessary.
(WebCore::Screen::width): Apply width override if necessary.
LayoutTests:
- inspector/styles/override-screen-size-expected.txt: Added.
- inspector/styles/override-screen-size.html: Added.
- 8:36 AM Changeset in webkit [105414] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update for a new failing test.
- platform/gtk/test_expectations.txt:
- 7:37 AM Changeset in webkit [105413] by
-
- 13 edits in trunk/Source
[Qt] Handle the layers visible rect calculation on the web process.
https://bugs.webkit.org/show_bug.cgi?id=74720
Reviewed by Noam Rosenthal.
Source/WebCore:
Remove all visible rect calculation related code from TextureMapperNode.
- platform/graphics/texmap/TextureMapperNode.cpp:
- platform/graphics/texmap/TextureMapperNode.h:
Source/WebKit2:
The layers now get their visible rect on the web process through the
root layer when the UI process call setVisibleContentRectAndScale,
previously only used for the non-composited content layer.
The rect is then carried down the layers in the tree which apply it the inverse
of their transform before handing it to their tiled backing store.
This ensures that new layers get a proper visible rect right on creation,
and also that simultaneous visible rect and scale changes are applied synchronously.
This patch also uses clampedBoundsOfProjectedQuad instead of mapRect
to transform the visible rect correctly for 3D transformed layers.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::updateDesktopViewportSize):
(QQuickWebViewPrivate::updateTouchViewportSize):
(QQuickWebView::geometryChanged):
Make sure that the visible rect is updated for the desktop view as well.
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/LayerTreeHostProxy.h:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectAndScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- WebProcess/WebPage/LayerTreeHost.messages.in:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
- 7:27 AM Changeset in webkit [105412] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening skipping 3 new test failures.
- platform/gtk/Skipped:
- 7:12 AM Changeset in webkit [105411] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unskip passing test.
- platform/qt/Skipped:
- 7:05 AM Changeset in webkit [105410] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Improve focus switching in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=76628
Reviewed by Pavel Feldman.
- inspector/front-end/Dialog.js:
(WebInspector.Dialog.prototype._hide):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showSourceLine):
- 5:56 AM Changeset in webkit [105409] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: Add isSelfOrAnsector and isSelfOrDescendant methods to utilities.
https://bugs.webkit.org/show_bug.cgi?id=76618
Added isSelfOrAncestor, isSelfOrDescendant and WebInspector.restoreFocusFromElement methods.
Reviewed by Pavel Feldman.
- inspector/front-end/Drawer.js:
- inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype._onBlur):
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
- inspector/front-end/Popover.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showUISourceCode):
- inspector/front-end/StylesSidebarPane.js:
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.detach):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
- inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.restoreFocusFromElement):
- inspector/front-end/utilities.js:
(Element.prototype.isInsertionCaretInside):
():
- 5:53 AM Changeset in webkit [105408] by
-
- 6 edits in trunk/Source/WebCore
DynamicNodeList: Simplify internal Caches object.
<http://webkit.org/b/76600>
Reviewed by Ryosuke Niwa.
Move m_caches from DynamicSubtreeNodeList and ChildNodeList up into DynamicNodeList.
Remove the inheritance from RefCounted and store it simply as "Caches m_caches"
This avoids one heap allocation per DynamicNodeList. Also reordered the Caches members
to pack slightly better on 64-bit.
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):
- dom/ChildNodeList.h:
- dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
- dom/DynamicNodeList.h:
(WebCore::DynamicNodeList::invalidateCache):
- dom/Node.cpp:
(WebCore::NodeRareData::clearChildNodeListCache):
- 5:47 AM Changeset in webkit [105407] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: TabbedPane closeAllTabs does not close all tabs.
https://bugs.webkit.org/show_bug.cgi?id=76624
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeAllTabs):
- 5:32 AM Changeset in webkit [105406] by
-
- 2 edits in trunk/Source/WebCore
image/pjpeg not supported for decoding on BlackBerry platform
https://bugs.webkit.org/show_bug.cgi?id=76595
Reviewed by Antonio Gomes.
Add image/pjpeg as one of the supported types for image decoding on BlackBerry platform.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 5:04 AM Changeset in webkit [105405] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip new failing tests.
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- 5:03 AM Changeset in webkit [105404] by
-
- 45 edits in trunk
Unreviewed, rolling out r105402.
http://trac.webkit.org/changeset/105402
https://bugs.webkit.org/show_bug.cgi?id=76623
Layout test problems (Requested by WildFox on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-19
Source/WebCore:
- css/svg.css:
(svg):
- rendering/RenderBox.h:
(WebCore::RenderBox::computeIntrinsicRatioInformation):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeIntrinsicRatioInformation):
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::logicalHeightIsAuto):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
- rendering/RenderReplaced.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGViewportContainer.h:
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport):
(WebCore::SVGSVGElement::parseMappedAttribute):
(WebCore::updateCSSForAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::currentViewBoxRect):
- svg/SVGSVGElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::size):
(WebCore::SVGImage::computeIntrinsicDimensions):
- svg/graphics/SVGImage.h:
LayoutTests:
- platform/mac/svg/custom/dynamic-empty-path-expected.png:
- platform/mac/svg/custom/fractional-rects-expected.png:
- platform/mac/svg/custom/js-update-container-expected.png:
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
- platform/mac/svg/custom/viewBox-hit-expected.png:
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml:
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml:
- svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml:
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml:
- svg/foreignObject/text-tref-02-b-expected.txt:
- 4:59 AM Changeset in webkit [105403] by
-
- 11 edits2 adds in trunk
Strange Result for getComputedStyle on borderWidth set in em
https://bugs.webkit.org/show_bug.cgi?id=18294
Reviewed by Tony Chang.
Source/WebCore:
BorderValue stores its width on a 12 bits unsigned. This patch
increase it to 27. The patch also modify the way to set the
width or to get it, we now use a unsigned rather than a short.
Test: fast/css/border-width-large.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::AnimationBase::ensurePropertyMap):
- platform/animation/AnimationUtilities.h:
(WebCore::blend):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
- rendering/style/BorderData.h:
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
- rendering/style/BorderValue.h:
(WebCore::BorderValue::width):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::borderLeftWidth):
(WebCore::RenderStyleBitfields::borderRightWidth):
(WebCore::RenderStyleBitfields::borderTopWidth):
(WebCore::RenderStyleBitfields::borderBottomWidth):
(WebCore::RenderStyleBitfields::setBorderLeftWidth):
(WebCore::RenderStyleBitfields::setBorderRightWidth):
(WebCore::RenderStyleBitfields::setBorderTopWidth):
(WebCore::RenderStyleBitfields::setBorderBottomWidth):
(WebCore::RenderStyleBitfields::initialBorderWidth):
(WebCore::RenderStyleBitfields::initialColumnRuleWidth):
(WebCore::RenderStyleBitfields::initialOutlineWidth):
LayoutTests:
This test covers that setting big values to border-width will
return correct values.
- fast/css/border-width-large-expected.txt: Added.
- fast/css/border-width-large.html: Added.
- 4:41 AM Changeset in webkit [105402] by
-
- 45 edits in trunk
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Reviewed by Antti Koivisto.
Source/WebCore:
Remove a gazillion of hacks out of our SVG implementation, by correctly differentiating between the
SVG width/height attributes and the CSS width/height properties. They need to be treated independently
when handling the intrinsic size negotiation, according to both CSS 2.1 & SVG 1.1 2nd Edition specs.
Fixes several bugs in the LayoutTests/svg/custom/*object*sizing tests, we now match Opera perfectly. FF still has some bugs, and IE9 as well.
- css/svg.css: Remove hardcoded, width/height: 100% on <svg>.
- rendering/RenderBox.h:
(WebCore::RenderBox::computeIntrinsicRatioInformation): Make 'intrinsicRatio' a float, and add 'intrinsicSize' as seperated FloatSize, to avoid confusion.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Add forgotton case for percentage intrinsic sizes, that lead to workarounds in other places, that can now be removed.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth): Directly use imageHasRelativeWidth/Height(), it does differentiate between SVG/CSS width/height attributes/properties now.
(WebCore::RenderImage::computeIntrinsicRatioInformation): Adapt to 'intrinsicRatio' argument change.
- rendering/RenderImage.h: Ditto.
- rendering/RenderReplaced.cpp: Refactor existing code, break out firstContainingBlockWithLogicalWidth/hasReplacedLogicalWidth/hasReplacedLogicalHeight/hasAutoHeightOrContainingBlockWithAutoHeight.
(WebCore::firstContainingBlockWithLogicalWidth): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalWidth): Refactored, and exported, so SVGSVGElement::widthAttributeEstablishesViewport() can use it.
(WebCore::hasAutoHeightOrContainingBlockWithAutoHeight): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalHeight): Refactored, and exported, so SVGSVGElement::heightAttributeEstablishesViewport() can use it.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Adapt to 'intrinsicRatio' changes ('intrinsicSize' is now decoupled from it). Refactor so that RenderSVGRoot can directly use it as well!
(WebCore::RenderReplaced::computeReplacedLogicalHeight): Ditto.
- rendering/RenderReplaced.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Only determine the intrinsic size & ratio using the SVG width/height attributes, not the CSS width/height properties, as it's specified.
(WebCore::resolveLengthAttributeForSVG): Helper function for computeReplacedLogicalWidth/Height, that scales Length values that come from SVG width/height attributes.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Finally remove home-brewn size computation logic - it can be fully shared with RenderReplaced now that we inherit from it.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::viewport): Export viewport() for easier length resolution.
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport): Finally clean up this hell, and make it easy to understand. Only need to resolve lengths against either RenderSVGRoot or RenderSVGViewportContainer now.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport): Remove wrong code and disable this. Its not used, and we have no test coverage for it. Its current implementation didn't make any sense.
(WebCore::SVGSVGElement::parseMappedAttribute): Remove hacks mapping SVG width/height attributes to CSS properties.
(WebCore::SVGSVGElement::svgAttributeChanged): Ditto.
(WebCore::SVGSVGElement::localCoordinateSpaceTransform): Refactored.
(WebCore::SVGSVGElement::currentViewBoxRect): Ditto.
(WebCore::SVGSVGElement::currentViewportSize): Ditto.
(WebCore::SVGSVGElement::widthAttributeEstablishesViewport): Main logic determining if the SVG or CSS properties establish the viewport - a direct transliteration from the spec.
(WebCore::SVGSVGElement::heightAttributeEstablishesViewport): Ditto.
(WebCore::SVGSVGElement::intrinsicWidth): Helper.
(WebCore::SVGSVGElement::intrinsicHeight): Ditto.
- svg/SVGSVGElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::size): Cleanup code.
(WebCore::SVGImage::hasRelativeWidth): Added, avoids hacks in RenderBoxModelObject.
(WebCore::SVGImage::hasRelativeHeight): Ditto.
(WebCore::SVGImage::computeIntrinsicDimensions): Make use of new SVGSVGElement::computeIntrinsicDimensions.
- svg/graphics/SVGImage.h:
LayoutTests:
Update SVG pixel test baseline.
- platform/mac/svg/custom/dynamic-empty-path-expected.png: Marginal changes.
- platform/mac/svg/custom/fractional-rects-expected.png: Ditto.
- platform/mac/svg/custom/js-update-container-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Align with Opera, gives same result now. All *object*sizing* tests are passing now.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Ditto.
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Marginal changes.
- platform/mac/svg/custom/viewBox-hit-expected.png: Ditto.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Ditto.
- svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Fix test, now that our bug is fixed.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Ditto.
- svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Ditto.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Ditto.
- svg/foreignObject/text-tref-02-b-expected.txt: Size is not reported anymore.
- 4:17 AM Changeset in webkit [105401] by
-
- 3 edits in trunk/LayoutTests
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446
Reviewed by Pavel Feldman.
Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
select text too far after the end position, making the selection currently disappear, which
is a bug, but can be avoided in this testcase.
- platform/chromium/test_expectations.txt: Unskip test.
- svg/text/resources/SelectionTestCase.js:
(selectRange): Subtract -1 from absEndPos.x.
- 3:18 AM Changeset in webkit [105400] by
-
- 2 edits in trunk/Tools
[Qt] Do full incremental builds until bots use update-webkit
Rubber-stamped by Simon Hausmann.
- 3:06 AM Changeset in webkit [105399] by
-
- 2 edits in trunk/Tools
Fix the Qt build
Unreviewed build fix.
- Scripts/webkitdirs.pm:
(buildQMakeProjects):
- 3:00 AM Changeset in webkit [105398] by
-
- 6 edits in trunk
[Qt] Make build-webkit always do safe incremental builds after update-webkit
When building against Qt5 with GCC we would just run 'make' in the build dir,
and rely on the dependency files output by GCC (-MD) to handle dependency
tracking, but that fails for special-cases like adding a Q_OBJECT macro
to a header.
To guarantee that an incrmental build will work, we have to run 'make qmake',
which we now do on every build-webkit that's followed by a successful run
of update-webkit. The reasoning is that update-webkit can result in such
potential corner-cases being applied, and since we can't know for sure
unless we inspect the diff and account for all the corner cases we assume
the worst and always run 'make qmake'.
After a succesful run of build-webkit we proceed to do just 'make' for any
subsequent runs, since we assume that the developer knows what kind of
changes he/she is doing, and when a 'make qmake' is needed.
Reviewed by Simon Hausmann.
- 2:24 AM Changeset in webkit [105397] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing tests.
- platform/qt-5.0/Skipped:
- platform/qt-wk2/Skipped:
- 2:16 AM Changeset in webkit [105396] by
-
- 5 edits4 adds in trunk
drop event isn't fired for contentEditable in edit drag
https://bugs.webkit.org/show_bug.cgi?id=57185
Reviewed by Adam Barth.
Source/WebCore:
Dispatch drop and dragend events after edit drag per HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#drag-and-drop-processing-model
There are two major differences between the spec and WebKit's new behavior:
While the spec says we have to insert the dragged contents immediately after dispatching drop event
and delete the source in the default event handler of dragend event, doing so in WebKit is extremely
difficult because of the way we manage the selection. Instead, we continue to delete the source
and insert the dragged contents immediately after the drop event; this behavior matches that of Firefox 9.
When the dragged contents and the destination of the move is in the same text node, ReplaceSelectionCommand
may end up replacing it with a new text node. But this removal causes a problem when EventHandler uses
the node to dispatch dragend event because the node is "orphaned" from its parent at that point. To mitigate
this issue, we update the dragState's m_dragSrc when the node is orphaned by the edit drag. While this behavior
may differ from the spec and other browsers, not delivering dragend to the editing host seems strictly worse than
dispatching it at the slightly wrong target.
Tests: fast/events/moving-text-should-fire-drop-and-dragend-events-2.html
fast/events/moving-text-should-fire-drop-and-dragend-events.html
- page/DragController.cpp:
(WebCore::DragController::performDrag): Dispatch drop event even when m_isHandlingDrag is true as long
as DragDestinationActionDHTML is an acceptable action.
(WebCore::DragController::concludeEditDrag): Call updateDragStateAfterEditDragIfNeeded after inserting
the dragged contents. This is necessary when ReplaceSelectionCommand or MoveSelectionCommand modifies
the source node while inserting the dragged contents.
- page/EventHandler.cpp:
(WebCore::EventHandler::performDragAndDrop): Clear the drag state only if drop event's default action
was prevented so that we dispatch dragevent event later.
(WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded): Update dragState's m_dragSrc when the node
is orphaned. See above for the rationale.
- page/EventHandler.h:
LayoutTests:
Added tests ensure moving text in contenteditable regions fire dragstart, drop, and dragend events.
- fast/events/moving-text-should-fire-drop-and-dragend-events-2-expected.txt: Added.
- fast/events/moving-text-should-fire-drop-and-dragend-events-2.html: Added.
- fast/events/moving-text-should-fire-drop-and-dragend-events-expected.txt: Added.
- fast/events/moving-text-should-fire-drop-and-dragend-events.html: Added.
- 1:58 AM Changeset in webkit [105395] by
-
- 14 edits in trunk/Source
Cleanup: Move chrome-specific filesystem type handling code (for FileSystem API) under chromium directory
https://bugs.webkit.org/show_bug.cgi?id=76551
Reviewed by Darin Fisher.
WebKit-svn/Source/WebCore:
Moved the implementation of crackFileSystemURL() and toURL() from
WebCore/fileapi/DOMFileSystemBase into WebCore/platform/AsyncFileSystem
so that each platform can extend/implement their behavior if necessary.
No new tests since this patch has no functionality changes. (Existing
tests should pass)
- fileapi/DOMFileSystemBase.cpp: Moved the implementation of
crackFileSystemURL() to AsyncFileSystem
(WebCore::DOMFileSystemBase::crackFileSystemURL):
- fileapi/DOMFileSystemBase.h:
- fileapi/EntryBase.cpp: Moved the implementation of toURL() to AsyncFileSystem
(WebCore::EntryBase::toURL):
- page/DOMWindow.cpp: Removed chrome-specific type handling code.
(WebCore::DOMWindow::webkitRequestFileSystem):
- page/DOMWindow.h: Removed chrome-specific filesystem type
(EXTERNAL).
- platform/AsyncFileSystem.cpp: Added default implementation of toURL() and crackFileSystemURL()
(WebCore::AsyncFileSystem::toURL):
(WebCore::AsyncFileSystem::crackFileSystemURL):
- platform/AsyncFileSystem.h:
- workers/WorkerContext.cpp: Removed chrome-specific type handling code.
(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
WebKit-svn/Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp: Removed matching assertion for TypeExternal as it's no longer defined separately.
- src/AsyncFileSystemChromium.cpp: Added crackFileSystemURL() and toURL() implementation that
handle chrome-specific filesystem type (EXTERNAL) as well as regular TEMPORARY/PERSISTENT types.
(WebCore::AsyncFileSystem::crackFileSystemURL): Added.
(WebCore::AsyncFileSystemChromium::toURL): Added.
- src/AsyncFileSystemChromium.h:
- 1:22 AM Changeset in webkit [105394] by
-
- 7 edits in trunk/Source/WebCore
Cache RenderStyle pointer as a method to avoid performance regression for region styling
https://bugs.webkit.org/show_bug.cgi?id=76265
Reviewed by David Hyatt.
No new tests since this is just refactoring.
When region styling was enabled in https://bugs.webkit.org/show_bug.cgi?id=71488,
it introduced a performance regression due to the change of RenderObject::style() method.
This patch tries to avoid a new performance regression when region styling will be enabled again.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateBoxModelInfoFromStyle):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
- rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::computePreferredLogicalWidths):
- 1:08 AM Changeset in webkit [105393] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present
https://bugs.webkit.org/show_bug.cgi?id=76508
Patch by Kazuhiro Inaba <kinaba@chromium.org> on 2012-01-19
Reviewed by Kent Tamura.
Wrapped GetGlyphIndices() API calls so that when they failed we trigger font
loading outside the sandbox and retry the call.
No new auto tests since the bug involves the system's occasional cache behavior
and thus there's no reliable way to reproduce and test the situation.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::getGlyphIndices):
GDI call wrapper ensuring fonts to be loaded.
(WebCore::initSpaceGlyph):
Changed to use the wrapper function.
(WebCore::fillBMPGlyphs):
Changed to use the wrapper function.
Introduced scoped HDC management by HWndDC.
(WebCore::GlyphPage::fill):
- 12:58 AM Changeset in webkit [105392] by
-
- 14 edits in trunk/LayoutTests
Unreviewed - re-enables tests on chromium-mac by making minor changes to cause the expectations to be identical on all Chromium configurations.
- 12:31 AM Changeset in webkit [105391] by
-
- 7 edits in trunk
createAttributeNS should understand that "xmlns" is allowed in the http://www.w3.org/2000/xmlns/
https://bugs.webkit.org/show_bug.cgi?id=76579
Reviewed by Eric Seidel.
Source/WebCore:
This patch cleans up a tiny corner case involving the (somewhat
magical) xmlns attribute that we uncovered when working on
setAttributeNS.
Tests: fast/dom/Document/createAttributeNS-namespace-err.html
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::hasValidNamespaceForElements):
(WebCore::Document::hasValidNamespaceForAttributes):
(WebCore::Document::createElementNS):
(WebCore::Document::createAttributeNS):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::setAttributeNS):
LayoutTests:
- fast/dom/Document/createAttributeNS-namespace-err-expected.txt:
- fast/dom/Document/script-tests/createAttributeNS-namespace-err.js:
- 12:29 AM Changeset in webkit [105390] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for DEBUG: remove comparison of an unsigned variable with '>= 0' in ASSERT.
No new tests. (no functionality change)
- webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
Jan 18, 2012:
- 11:52 PM Changeset in webkit [105389] by
-
- 2 edits in trunk/Source/WebCore
[v8] Low efficiency of writing long string from web application to plugin.
https://bugs.webkit.org/show_bug.cgi?id=76592
The efficiency will be improved by 300 times in the best case, when the
size of string reaches 1MB.
Patch by Li Yin <li.yin@intel.com> on 2012-01-18
Reviewed by Adam Barth.
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
- 11:39 PM Changeset in webkit [105388] by
-
- 2 edits2 adds in trunk
Assigning to Element.prefix should throw exception when using illegal characters
https://bugs.webkit.org/show_bug.cgi?id=76589
Reviewed by Eric Seidel.
This patch fixes a FIXME and implements the INVALID_CHARACTER_ERR
exception described in
http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-NodeNSPrefix
Tests: fast/dom/Element/prefix-setter-exception.html
- dom/Node.cpp:
(WebCore::isValidNameStartCharacter):
(WebCore::isValidNameCharacter):
(WebCore::hasInvalidValidNameCharacters):
(WebCore::Node::checkSetPrefix):
- 11:05 PM Changeset in webkit [105387] by
-
- 6 edits2 adds in trunk
ShadowContent query should be able to have fallback elements.
https://bugs.webkit.org/show_bug.cgi?id=75306
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
Reviewed by Hajime Morita.
Source/WebCore:
When no elements are selected by a shadow content element selector query,
light children are selected as a fallback elements.
Test: fast/dom/shadow/shadow-contents-fallback.html
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
Considers fallback phase. When no elements are chosen, the phase is set to 'fallback'.
(WebCore::NodeRenderingContext::nextRenderer):
Takes fallback phase into account.
(WebCore::NodeRenderingContext::previousRenderer): ditto.
- dom/NodeRenderingContext.h:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
Calculates inclusions before attaching light children.
- html/shadow/HTMLContentElement.h:
(WebCore::HTMLContentElement::hasInclusion):
LayoutTests:
- fast/dom/shadow/shadow-contents-fallback-expected.txt: Added.
- fast/dom/shadow/shadow-contents-fallback.html: Added.
- 10:51 PM Changeset in webkit [105386] by
-
- 4 edits2 adds in trunk
REGRESSION(r100111): A 'change' event does not fire when a mouse drag
occurs to switch elements in a listbox <select>
https://bugs.webkit.org/show_bug.cgi?id=76244
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/select/listbox-drag-in-non-multiple.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateSelectedState):
Do not update m_activeSelectionState for non-multiple <select>.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Use setActiveSelection*Index() and updateListBoxSelection(true) instead
of updateSelectedState() because updateSelectedState() updates
m_lastOnChangeSelection and will prevent the mouseup handler from
dispatching 'change' event.
We should not call listBoxOnChange() in the mousemove handler in order
to align the behavior of IE and Firefox.
LayoutTests:
- fast/forms/resources/common.js:
(mouseMoveToIndexInListbox): Added.
- fast/forms/select/listbox-drag-in-non-multiple-expected.txt: Added.
- fast/forms/select/listbox-drag-in-non-multiple.html: Added.
- 10:30 PM Changeset in webkit [105385] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 10:29 PM Changeset in webkit [105384] by
-
- 1 copy in tags/Safari-534.54.8
New tag.
- 10:25 PM Changeset in webkit [105383] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit2
Merge <rdar://problem/10516690>
- 10:11 PM Changeset in webkit [105382] by
-
- 2 edits in trunk/LayoutTests
update resolve-url-sync-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=76581
Reviewed by Eric Seidel.
- http/tests/filesystem/workers/resolve-url-sync-expected.txt:
- 10:00 PM Changeset in webkit [105381] by
-
- 7 edits1 add in trunk
run-perf-tests should support Skipped list
https://bugs.webkit.org/show_bug.cgi?id=76594
Reviewed by Adam Barth.
PerformanceTests:
Add Skipped list to be used by run-perf-tests as it can only runs tests in
Bindings, Parser, and inspector at the moment.
- Skipped: Added.
Tools:
Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.perf_tests_dir):
(Port.skipped_perf_tests):
(Port.skips_perf_test):
(Port.relative_perf_test_filename):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.perf_tests_dir):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._expectations_from_skipped_files):
(WebKitPort):
(WebKitPort.skipped_layout_tests):
(WebKitPort.skipped_perf_tests):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_collect_tests_with_skipped_list):
(test_collect_tests_with_skipped_list.add_file):
- 9:56 PM Changeset in webkit [105380] by
-
- 6 edits1 add in trunk/Source/WebKit/chromium
Pass content-security-policy directive into shared workers.
https://bugs.webkit.org/show_bug.cgi?id=75660
Reviewed by Darin Fisher.
- public/WebContentSecurityPolicy.h: Added.
- public/WebSharedWorker.h:
(WebKit::WebSharedWorker::startWorkerContext):
- src/AssertMatchingEnums.cpp:
- src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
- src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
- src/WebSharedWorkerImpl.h:
- 9:40 PM Changeset in webkit [105379] by
-
- 3 edits3 adds in trunk
setAttributeNS should comply with the obscure rules of DOM2, just like createAttributeNS and createElementNS do
https://bugs.webkit.org/show_bug.cgi?id=76143
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/Element/setAttributeNS-namespace-err.html
- dom/Element.cpp:
(WebCore::Element::setAttributeNS):
LayoutTests:
- fast/dom/Element/script-tests/setAttributeNS-namespace-err.js: Added.
(assert):
(stringForExceptionCode):
(assertEquals):
(sourceify):
(runNSTests):
- fast/dom/Element/setAttributeNS-namespace-err-expected.txt: Added.
- fast/dom/Element/setAttributeNS-namespace-err.html: Added.
- 9:20 PM Changeset in webkit [105378] by
-
- 5 edits in trunk
Unreviewed, rolling out r105376.
http://trac.webkit.org/changeset/105376
https://bugs.webkit.org/show_bug.cgi?id=76601
Roll 76493 back in after discussion with jsbell (Requested by
rolandsteiner on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-18
Source/WebCore:
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoSerializedValue):
LayoutTests:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- 8:18 PM Changeset in webkit [105377] by
-
- 4 edits8 adds in trunk/Source
[chromium] Create a base-class CCAnimation to represent compositor animations
https://bugs.webkit.org/show_bug.cgi?id=73233
Source/WebCore:
Adds a kernel for running animations on the chromium compositor
thread.
Patch by Ian Vollick <vollick@chromium.org> on 2012-01-18
Reviewed by Kenneth Russell.
- WebCore.gypi:
- platform/graphics/chromium/cc/CCActiveAnimation.cpp: Added.
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::isFinishedAt):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
- platform/graphics/chromium/cc/CCActiveAnimation.h: Added.
(WebCore::CCActiveAnimation::create):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::group):
(WebCore::CCActiveAnimation::targetProperty):
(WebCore::CCActiveAnimation::runState):
(WebCore::CCActiveAnimation::iterations):
(WebCore::CCActiveAnimation::setIterations):
(WebCore::CCActiveAnimation::startTime):
(WebCore::CCActiveAnimation::setStartTime):
(WebCore::CCActiveAnimation::isFinished):
(WebCore::CCActiveAnimation::animationCurve):
- platform/graphics/chromium/cc/CCAnimationCurve.cpp: Added.
(WebCore::CCAnimationCurve::toFloatAnimationCurve):
(WebCore::CCAnimationCurve::toTransformAnimationCurve):
- platform/graphics/chromium/cc/CCAnimationCurve.h: Added.
(WebCore::CCAnimationCurve::~CCAnimationCurve):
(WebCore::CCFloatAnimationCurve::~CCFloatAnimationCurve):
(WebCore::CCFloatAnimationCurve::type):
(WebCore::CCTransformAnimationCurve::~CCTransformAnimationCurve):
(WebCore::CCTransformAnimationCurve::type):
- platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp: Added.
(WebCore::CCLayerAnimationControllerImpl::create):
(WebCore::CCLayerAnimationControllerImpl::CCLayerAnimationControllerImpl):
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::add):
(WebCore::CCLayerAnimationControllerImpl::getActiveAnimation):
(WebCore::CCLayerAnimationControllerImpl::hasActiveAnimation):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::resolveConflicts):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h: Added.
(WebCore::CCLayerAnimationControllerImplClient::~CCLayerAnimationControllerImplClient):
Source/WebKit/chromium:
Patch by Ian Vollick <vollick@chromium.org> on 2012-01-18
Reviewed by Kenneth Russell.
- WebKit.gypi:
- tests/CCActiveAnimationTest.cpp: Added.
(WebCore::FakeFloatAnimation::duration):
(WebCore::FakeFloatAnimation::getValue):
(WebCore::createActiveAnimation):
(WebCore::TEST):
- tests/CCLayerAnimationControllerImplTest.cpp: Added.
(WebCore::FakeControllerClient::FakeControllerClient):
(WebCore::FakeControllerClient::~FakeControllerClient):
(WebCore::FakeControllerClient::opacity):
(WebCore::FakeControllerClient::setOpacity):
(WebCore::FakeControllerClient::transform):
(WebCore::FakeControllerClient::setTransform):
(WebCore::FakeControllerClient::animationControllerImplDidActivate):
(WebCore::FakeControllerClient::activeControllers):
(WebCore::FakeTransformTransition::FakeTransformTransition):
(WebCore::FakeTransformTransition::duration):
(WebCore::FakeTransformTransition::getValue):
(WebCore::FakeFloatTransition::FakeFloatTransition):
(WebCore::FakeFloatTransition::duration):
(WebCore::FakeFloatTransition::getValue):
(WebCore::TEST):
- 8:07 PM Changeset in webkit [105376] by
-
- 5 edits in trunk
Unreviewed, rolling out r105331.
http://trac.webkit.org/changeset/105331
https://bugs.webkit.org/show_bug.cgi?id=76599
May have broken Chromium InjectIDBKey browser_test (Requested
by rolandsteiner on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-18
Source/WebCore:
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoSerializedValue):
LayoutTests:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- 8:02 PM Changeset in webkit [105375] by
-
- 3 edits in trunk/Source/WebCore
Remove some unused code in AudioContext
https://bugs.webkit.org/show_bug.cgi?id=76506
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-18
Reviewed by Kenneth Russell.
No new tests required.
- webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::uninitialize):
- webaudio/AudioContext.h:
- 7:28 PM Changeset in webkit [105374] by
-
- 2 edits in trunk/Tools
Fix path to chromium_src_dir introduced in previous change.
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 7:22 PM Changeset in webkit [105373] by
-
- 3 edits in trunk/Source/WebCore
Only create AudioBus with required number of channels for AudioNodeOutput
https://bugs.webkit.org/show_bug.cgi?id=76417
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-18
Reviewed by Kenneth Russell.
No new tests required.
- webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::updateNumberOfChannels):
(WebCore::AudioNodeOutput::pull):
- webaudio/AudioNodeOutput.h:
- 6:55 PM Changeset in webkit [105372] by
-
- 11 edits2 adds in trunk
Cache and reuse the NodeList returned by Node::childNodes().
<http://webkit.org/b/76591>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Instead of only caching the DynamicNodeList::Caches for .childNodes on NodeRareData,
cache the full ChildNodeList object. Lifetime management is left to wrappers who
invalidate the cached (raw) pointer via Node::removeCachedChildNodeList(), called
from ~ChildNodeList().
This is a slight behavior change, in that Node.childNodes === Node.childNodes will
now be true. This matches the behavior of both Firefox and Opera.
This reduces memory consumption by 192 kB (on 32-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>
Test: fast/dom/gc-9.html
fast/dom/node-childNodes-idempotence.html
- dom/Node.cpp:
(WebCore::Node::childNodes):
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::childNodeList):
(WebCore::NodeRareData::setChildNodeList):
Only construct one ChildNodeList per Node and store it on NodeRareData for
retrieval across childNodes() calls.
- dom/ChildNodeList.h:
(WebCore::ChildNodeList::create):
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
Construct the Caches at creation instead of passing it to the constructor.
(WebCore::ChildNodeList::reset):
Added, resets the internal cache.
(WebCore::ChildNodeList::~ChildNodeList):
Call Node::removeCachedChildNodeList().
- dom/DynamicNodeList.cpp:
- dom/DynamicNodeList.h:
Have DynamicNodeList (and subclasses) respond "true" to isDynamicNodeList().
Previously only DynamicSubtreeNodeList (and subclasses) were doing this.
Without it, JSC may GC our ChildNodeLists prematurely (due to NodeList's
isReachableFromOpaqueRoots() implementation checking isDynamicNodeList().)
- dom/Node.h:
- dom/Node.cpp:
(WebCore::Node::removeCachedChildNodeList):
Added for ~ChildNodeList() to remove the pointer to itself from the Node.
(WebCore::NodeRareData::clearChildNodeListCache):
Call ChildNodeList::reset().
LayoutTests:
Updated gc-9.html to document the new lifetime characteristics of a .childNodes with
custom properties. Also added a test to verify that .childNodes === .childNodes.
- fast/dom/gc-9-expected.txt:
- fast/dom/gc-9.html:
- fast/dom/node-childNodes-idempotence-expected.txt: Added.
- fast/dom/node-childNodes-idempotence.html: Added.
- 6:39 PM Changeset in webkit [105371] by
-
- 12 edits in trunk/Source
Unreviewed, rolling out r105366.
http://trac.webkit.org/changeset/105366
https://bugs.webkit.org/show_bug.cgi?id=76015
Breaks CCLayerTreeHostImplTest unit test
Source/WebCore:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::drawsOpaque):
(WebCore::CCDrawQuad::needsBlending):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:
(WebCore::CCSolidColorDrawQuad::CCSolidColorDrawQuad):
- platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
- platform/graphics/chromium/cc/CCTileDrawQuad.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::syncTextureId):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
- tests/CCQuadCullerTest.cpp:
(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
- tests/CCTiledLayerImplTest.cpp:
(WebCore::createLayer):
(WebCore::TEST):
(WebCore::getQuads):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):
- 6:02 PM Changeset in webkit [105370] by
-
- 2 edits in trunk/Source/WebCore
Save two ID checks on CSS Min/Width property validation
https://bugs.webkit.org/show_bug.cgi?id=76565
The same validation is done again in the next case statement. Check for
CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value
is a number.
Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-18
Reviewed by Andreas Kling.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 5:54 PM Changeset in webkit [105369] by
-
- 9 edits5 adds in trunk
Need infrastructure to test Content-Disposition filename encoding support
https://bugs.webkit.org/show_bug.cgi?id=76572
<rdar://problem/6421825>
Reviewed by Sam Weinig.
Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
WebKitTestRunner does not have a policy delegate yet, bug 42546.
- DumpRenderTree/mac/PolicyDelegate.mm: (dispositionTypeFromContentDispositionHeader): (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
- 5:53 PM Changeset in webkit [105368] by
-
- 2 edits in trunk/Source/WebKit2
Another build fix for r105364.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Missing #if.
- 5:44 PM Changeset in webkit [105367] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for r105364. Unreviewed.
- WebProcess/Notifications/WebNotificationManager.cpp: Wrap methods in #if ENABLE(NOTIFICATIONS)
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
- 5:42 PM Changeset in webkit [105366] by
-
- 12 edits in trunk/Source
[chromium] Use region reported painted opaque for draw culling
https://bugs.webkit.org/show_bug.cgi?id=76015
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-18
Reviewed by James Robinson.
Source/WebCore:
New unit tests in CCQuadCullerTest.cpp and CCTiledLayerImplTest.cpp
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::opaqueRect):
(WebCore::CCDrawQuad::needsBlending):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
- platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
- platform/graphics/chromium/cc/CCTileDrawQuad.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::opaqueRect):
(WebCore::DrawableTile::setOpaqueRect):
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::pushTileProperties):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
- tests/CCQuadCullerTest.cpp:
(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
(WebCore::TEST):
- tests/CCTiledLayerImplTest.cpp:
(WebCore::createLayer):
(WebCore::TEST):
(WebCore::getQuads):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):
- 5:19 PM Changeset in webkit [105365] by
-
- 3 edits in trunk/Source/WebCore
HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading
https://bugs.webkit.org/show_bug.cgi?id=76568
Reviewed by Eric Carlson.
This fires a progress event when going from a non-empty state to idle,
for the same reason that a progress event is fired when going from a
non-idle state to loaded. Also consolidated logic in a single helper method.
No new tests because the decision of if/when a user agent sets the network state
to idle is up to the user agent in this scenario.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
- html/HTMLMediaElement.h:
- 5:14 PM Changeset in webkit [105364] by
-
- 34 edits in trunk/Source
[WK2] Sync call for notifications permissions causes flashes on gmail.com
https://bugs.webkit.org/show_bug.cgi?id=76570
<rdar://problem/10647155>
Reviewed by Anders Carlsson and Sam Weinig.
Source/WebCore:
- WebCore.exp.in: Export SecurityOrigin::toString().
Add runtime setting to enable/disable notifications.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h: Add new bit for whether notifications are enabled.
(WebCore::Settings::setNotificationsEnabled):
(WebCore::Settings::notificationsEnabled):
Source/WebKit2:
The website code figures out the permission level for its security origin by making a JS call (called
checkPermission()) that is synchronous. The way this was implemented was to make a synchronous call from
the WebNotificationManager to its proxy. That call goes to the WK API layer to find the policy, and
returns that policy back to the JS.
The synchronous nature of this call causes the white flash to appear in certain cases.
To fix this, the checkPermission() call is handled all within the web process, instead of going up into
the UI process. To do this, the web process initializes the WebNotificationManager with a copy of the
notification permissions. Any time the WK client makes a change to the permissions, that gets sent down
asynchronously, and the cached copy in WebNotificationManager gets updated.
A page's settings may disable notifications altogether. Before, this would have been handled by the WK
client, since retrieving the permissions were also handled there. Now that the lookup happens in the web
process, we need to add that setting in WebCore.
Update notification permissions to use the security origin's string representation, rather than its
database identifier.
- UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
- UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show): Registering the provider with the manager is handled in
initialize() now.
(WebKit::WebNotificationManagerProxy::cancel): Registering the provider with the manager is handled in
initialize() now.
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestNotificationPermission):
(WebKit::WebPageProxy::showNotification):
- UIProcess/WebPageProxy.h:
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest): Only start the request if notifications
are enabled.
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Only show notification is they are enabled.
(WebKit::WebNotificationManager::cancel): Only cancel if notifications are enabled.
Remove synchronous message to get policy for a given origin. Instead, use the cached copy in
WebNotificationManager.
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::policyForOrigin): Looks for the permission in the cached copy.
If it doesn't exist, return NotificationPresenter::PermissionNotAllowed.
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::permissionLevel): Update permissionLevel to use
policyForOrigin().
Remove old WK API function to get the policy. Because this function was the only synchronous message,
we remove the sync-message-related functions also. Also, add in some #includes that might have been
omitted in prior patches.
- UIProcess/API/C/WKNotificationProvider.h:
- UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Remove NotificationPermissionLevel.
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
- UIProcess/Notifications/WebNotificationProvider.h: Remove policyForNotificationPermissionAtOrigin().
- UIProcess/Notifications/WebNotificationProvider.cpp:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage): Remove conditional to forward sync messages to the
notification manager proxy.
Mechanism for client to update the permissions copy in WebNotificationManager.
- WebProcess/Notifications/WebNotificationManager.messages.in: Add new messages
didUpdateNotificationDecision and didRemoveNotificationDecisions.
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision): Update the entry.
(WebKit::WebNotificationManager::didRemoveNotificationDecisions): Remove the entry.
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies): Convert the array of
origins to remove, and send it to the WebNotificationManager.
- UIProcess/API/C/WKNotificationManager.h: Expose these update functions as WK API.
- UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidUpdateNotificationPolicy):
(WKNotificationManagerProviderDidRemoveNotificationPolicies):
Initialize WebNotificationManager with permissions. Initialize WebPage with notifications enabled bit
from settings.
- Shared/WebProcessCreationParameters.h: Add map of notification permissions as part of the
parameters.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- UIProcess/Notifications/WebNotificationProvider.h: Retrieve copy of existing notification permissions.
- UIProcess/Notifications/WebNotificationProvider.cpp:
- UIProcess/API/C/WKNotificationProvider.h: Add WK API to get a copy of the permissions.
- UIProcess/Notifications/WebNotificationManagerProxy.h: Add populateCopyOfNotificationPermissions().
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::initializeProvider): Add the manager at the time of initialization.
Similar calls in show() and cancel() are removed in following patch.
(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions): Clear the existing copy.
Populate with origin string, and whether that origin is allowed to post. If no decision has been made
by the user, then there should be no item in this dictionary.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess): When the web process is initialized, we get a copy of the
permissions, and send it to the web process to initialize the notification manager.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize the notification manager.
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::initialize): Initialize the permissions copy.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set notifications enabled bit from settings.
Expose toString() method from WebCore::SecurityOrigin. Work is also towards bug 74956.
- Shared/API/c/WKSecurityOrigin.h: Refactor WKSecurityOriginCreateFromIdentifier to
WKSecurityOriginCreateFromDatabaseIdentifier and add WKSecurityOriginCreateFromString function.
- Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCopyToString):
Refactor WebSecurityOrigin::create() to WebSecurityOrigin::createFromDatabaseIdentifier()
and add WebSecurityOrigin::createFromString().
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::createFromString):
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
(WebKit::WebSecurityOrigin::toString): Added function.
Refactor with renamed createFromDatabaseIdentifier() method.
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
Add WK API calls to change notificationsEnabled bit in WebCore::Settings.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetNotificationsEnabled):
(WKPreferencesGetNotificationsEnabled):
- UIProcess/API/C/WKPreferences.h:
- 5:11 PM Changeset in webkit [105363] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Fix InjectIDBKeyTest.SubProperty test failure
https://bugs.webkit.org/show_bug.cgi?id=76582
Correct the test, now that https://bugs.webkit.org/show_bug.cgi?id=76493
changes the semantics so that intermediate objects are created if possible
to satisfy autoIncrement keypaths.
Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-18
Reviewed by James Robinson.
- tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
- 5:09 PM Changeset in webkit [105362] by
-
- 4 edits3 copies in branches/safari-534.54-branch
Merged r95580.
- 5:08 PM Changeset in webkit [105361] by
-
- 1 edit4 copies in branches/chromium/963
Merge 103851 - REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
BUG=104325
Review URL: https://chromiumcodereview.appspot.com/9252034
- 5:06 PM Changeset in webkit [105360] by
-
- 1 edit4 copies in branches/chromium/912
Merge 103851 - REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
BUG=104325
Review URL: https://chromiumcodereview.appspot.com/9216003
- 4:57 PM Changeset in webkit [105359] by
-
- 2 edits6 copies in branches/chromium/963
Merge 104328 - [CSSRegions]Crash while collecting svg elements in render flow thread.
https://bugs.webkit.org/show_bug.cgi?id=73735
BUG=106309
Review URL: http://codereview.chromium.org/9250028
- 4:56 PM Changeset in webkit [105358] by
-
- 7 edits in branches/safari-534.54-branch
Merge 89155.
- 4:55 PM Changeset in webkit [105357] by
-
- 2 edits6 copies in branches/chromium/912
Merge 104328 - [CSSRegions]Crash while collecting svg elements in render flow thread.
https://bugs.webkit.org/show_bug.cgi?id=73735
BUG=106309
Review URL: http://codereview.chromium.org/9253028
- 4:52 PM Changeset in webkit [105356] by
-
- 3 edits in branches/chromium/963
Merge 103429 - Source/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
BUG=107873
Review URL: https://chromiumcodereview.appspot.com/9255031
- 4:49 PM Changeset in webkit [105355] by
-
- 3 edits in branches/chromium/912
Merge 103429 - Source/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
BUG=107873
Review URL: https://chromiumcodereview.appspot.com/9254017
- 4:42 PM Changeset in webkit [105354] by
-
- 1 edit3 copies in branches/chromium/963
Merge 103206 - Positioned Floats: Assertion hit in fast/block/positioning/positioned-float-layout-after-image-load.html
BUG=107939
Review URL: https://chromiumcodereview.appspot.com/9232038
- 4:39 PM Changeset in webkit [105353] by
-
- 1 edit3 copies in branches/chromium/912
Merge 103206 - Positioned Floats: Assertion hit in fast/block/positioning/positioned-float-layout-after-image-load.html
BUG=107939
Review URL: https://chromiumcodereview.appspot.com/9253026
- 4:39 PM Changeset in webkit [105352] by
-
- 1 edit3 copies in branches/chromium/963
Merge 103979 - v8 binding: npCreateV8ScriptObject() should not returned an existing V8NPObject if the rootObject doesn't match
BUG=107616
Review URL: https://chromiumcodereview.appspot.com/9250027
- 4:39 PM Changeset in webkit [105351] by
-
- 1 edit3 copies in branches/chromium/912
Merge 103979 - v8 binding: npCreateV8ScriptObject() should not returned an existing V8NPObject if the rootObject doesn't match
BUG=107616
Review URL: https://chromiumcodereview.appspot.com/9260002
- 4:34 PM Changeset in webkit [105350] by
-
- 3 edits2 copies in branches/chromium/912
Merge 104123 - Crash due to first-letter block processing
BUG=107277
Review URL: https://chromiumcodereview.appspot.com/9249043
- 4:34 PM Changeset in webkit [105349] by
-
- 3 edits2 copies in branches/chromium/963
Merge 104123 - Crash due to first-letter block processing
BUG=107277
Review URL: https://chromiumcodereview.appspot.com/9252031
- 4:31 PM Changeset in webkit [105348] by
-
- 1 edit2 copies in branches/chromium/963
Merge 104317 - Crash with range selection across different documents.
BUG=106484
Review URL: https://chromiumcodereview.appspot.com/9251030
- 4:31 PM Changeset in webkit [105347] by
-
- 1 edit2 copies in branches/chromium/912
Merge 104317 - Crash with range selection across different documents.
BUG=106484
Review URL: https://chromiumcodereview.appspot.com/9250025
- 4:30 PM Changeset in webkit [105346] by
-
- 3 edits6 copies in branches/chromium/963
Merge 105120 - Heap-use-after-free in WebCore::RenderBlock::selectionGaps
Review URL: https://chromiumcodereview.appspot.com/9251029
- 4:26 PM Changeset in webkit [105345] by
-
- 1 edit in branches/chromium/963/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Merge 104609 - [skia] not all convex paths are convex, so recompute convexity for the problematic ones
BUG=108605
Review URL: https://chromiumcodereview.appspot.com/9250022
- 4:25 PM Changeset in webkit [105344] by
-
- 3 edits6 copies in branches/chromium/912
Merge 105120 - Heap-use-after-free in WebCore::RenderBlock::selectionGaps
BUG=108267
Review URL: https://chromiumcodereview.appspot.com/9250021
- 4:24 PM Changeset in webkit [105343] by
-
- 1 edit in branches/chromium/912/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Merge 104609 - [skia] not all convex paths are convex, so recompute convexity for the problematic ones
BUG=108605
Review URL: https://chromiumcodereview.appspot.com/9254016
- 4:22 PM Changeset in webkit [105342] by
-
- 1 edit2 copies in branches/chromium/963
Merge 104441 - insertAdjacentHTML doesn't play nice with DocumentFragment
BUG=109556
Review URL: https://chromiumcodereview.appspot.com/9250020
- 4:21 PM Changeset in webkit [105341] by
-
- 1 edit2 copies in branches/chromium/963
Merge 104275 - Fix a crash by importing an element of which local name ends with ":input".
BUG=108461
Review URL: https://chromiumcodereview.appspot.com/9249042
- 4:18 PM Changeset in webkit [105340] by
-
- 1 edit2 copies in branches/chromium/912
Merge 104275 - Fix a crash by importing an element of which local name ends with ":input".
BUG=108461
Review URL: https://chromiumcodereview.appspot.com/9249041
- 4:16 PM Changeset in webkit [105339] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (r88886): Tabs restore blank when running Safari with a nightly build for the first time
https://bugs.webkit.org/show_bug.cgi?id=76587
<rdar://problem/9739135>
Reviewed by Sam Weinig.
- UIProcess/cf/WebPageProxyCF.cpp:
Change CurrentSessionStateDataVersion back to 2.
- WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeString):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString):
Backport the CoreIPC string encoding and decoding functions that were in place prior to r88886.
- 4:12 PM Changeset in webkit [105338] by
-
- 2 edits2 copies in branches/chromium/963
Merge 104183 - Source/WebCore: Crash due to reparenting of relpositioned object under anonymous block
https://bugs.webkit.org/show_bug.cgi?id=70848
The associated test case creates a condition where a relative
positioned renderer is a descendant of an anonymous block for a
table column. The anonymous block is the containingBlock() for the
relpositioned renderer. Removal of a div causes the anonymous blocks to
be merged, and the renderer becomes a descendant of a different block.
Since the new containingBlock() has an empty positionedObject list,
the relpositioned renderer does not get layout after being dirtied.
This patch changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous
block itself. It also adds an ASSERT to insertPositionedObject()
to flag any other cases where something is trying to create a
positioned object list on an anonymous block.
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
LayoutTests: Crash due to reparenting of relpositioned object in table
https://bugs.webkit.org/show_bug.cgi?id=70848
Adding test that exercises the crash condition in bug 70848.
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.
- fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Added
- fast/css/relative-position-replaced-in-table-display-crash.html: Added
Review URL: http://codereview.chromium.org/9263001
- 4:10 PM Changeset in webkit [105337] by
-
- 2 edits2 copies in branches/chromium/912
Merge 104183 - Source/WebCore: Crash due to reparenting of relpositioned object under anonymous block
https://bugs.webkit.org/show_bug.cgi?id=70848
The associated test case creates a condition where a relative
positioned renderer is a descendant of an anonymous block for a
table column. The anonymous block is the containingBlock() for the
relpositioned renderer. Removal of a div causes the anonymous blocks to
be merged, and the renderer becomes a descendant of a different block.
Since the new containingBlock() has an empty positionedObject list,
the relpositioned renderer does not get layout after being dirtied.
This patch changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous
block itself. It also adds an ASSERT to insertPositionedObject()
to flag any other cases where something is trying to create a
positioned object list on an anonymous block.
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
LayoutTests: Crash due to reparenting of relpositioned object in table
https://bugs.webkit.org/show_bug.cgi?id=70848
Adding test that exercises the crash condition in bug 70848.
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.
- fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Added
- fast/css/relative-position-replaced-in-table-display-crash.html: Added
Review URL: http://codereview.chromium.org/9232034
- 4:08 PM Changeset in webkit [105336] by
-
- 1 edit2 copies in branches/chromium/912
Merge 104441 - insertAdjacentHTML doesn't play nice with DocumentFragment
BUG=109556
Review URL: https://chromiumcodereview.appspot.com/9249040
- 4:07 PM Changeset in webkit [105335] by
-
- 2 edits in trunk/Tools
Fix tests from http://trac.webkit.org/changeset/105332.
The code assumed that if you passed an options object with a configuration
attribute that it would have a valid value. A bunch of the testing mocks
do things like having a configuration value of None.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
- 3:40 PM Changeset in webkit [105334] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update a few chromium expectations.
- platform/chromium/test_expectations.txt:
- 3:29 PM Changeset in webkit [105333] by
-
- 2 edits in trunk/Source/WebCore
Provide access to user's list of preferred languages
https://bugs.webkit.org/show_bug.cgi?id=76138
Reviewed by Timothy Hatcher.
No new tests, tested by fast/harness/user-preferred-language.html.
- platform/mac/Language.mm:
(WebCore::platformUserPreferredLanguages): Don't over-release a the CFStrings returned by
CFLocaleCopyPreferredLanguages.
- 3:14 PM Changeset in webkit [105332] by
-
- 3 edits in trunk/Tools
Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=76576
Reviewed by Adam Barth.
Avoid calling default_configuration in base.py. We don't need it for
checking test_expectations.txt style. It takes ~0.5 seconds to run on my
Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
from common.executive.
At some point someone should probably look into why that call is so slow
since it's on the critical path for run-webkit-tests and build-webkit startup.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_exepectations_path):
- 3:07 PM Changeset in webkit [105331] by
-
- 5 edits in trunk
IndexedDB: Implement create-intermediate-objects semantics when injecting values via keyPaths
https://bugs.webkit.org/show_bug.cgi?id=76493
Source/WebCore:
Reviewed by Tony Chang.
Tests: storage/indexeddb/objectstore-autoincrement.html
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoSerializedValue):
LayoutTests:
Per discussion on public-webapps, when injecting a key into a value, create intermediate
objects if necessary.
Reviewed by Tony Chang.
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- 3:03 PM Changeset in webkit [105330] by
-
- 7 edits1 move1 add in trunk
[chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
https://bugs.webkit.org/show_bug.cgi?id=76505
Reviewed by Tony Chang.
.:
Update with newly-generated files.
- .gitignore:
Source/WebKit/chromium:
Update path to Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp.
- All.gyp:
- gyp_webkit:
- change to using All.gyp
- change build_webkit_exes_from_webkit_gyp to 0
Tools:
Update chromium build script to use All.gyp instead of WebKit.gyp
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
- Scripts/webkitdirs.pm:
- 2:58 PM Changeset in webkit [105329] by
-
- 7 edits in trunk
IndexedDB: Invalid keys yielded by key paths should raise exceptions, not error callbacks
https://bugs.webkit.org/show_bug.cgi?id=76075
Reviewed by Tony Chang.
Source/WebCore:
Tests: storage/indexeddb/objectstore-basics.html
- storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
LayoutTests:
- storage/indexeddb/mozilla/bad-keypath-expected.txt:
- storage/indexeddb/mozilla/bad-keypath.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- 2:49 PM Changeset in webkit [105328] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix compile error from bug #76211
https://bugs.webkit.org/show_bug.cgi?id=76575
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-18
Reviewed by James Robinson.
No new tests. Fixing compile only.
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
- 2:49 PM Changeset in webkit [105327] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update chromium linux pixel baseline for svg test
- platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-expected.png:
- 2:48 PM Changeset in webkit [105326] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] WebKit-3.0.gir does not include information about C includes or exported packages
https://bugs.webkit.org/show_bug.cgi?id=49875
Patch by Evan Nemerson <evan@coeus-group.com> on 2012-01-18
Reviewed by Martin Robinson.
- GNUmakefile.am: Add some information to the GIR generator to fix
Vala binding generation.
- 2:43 PM Changeset in webkit [105325] by
-
- 2 edits in trunk/Tools
Don’t hardcode the path to ‘make‘.
Patch by Sam Weinig <sam@webkit.org> on 2012-01-18
Reviewed by Dan Bernstein.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 2:39 PM Changeset in webkit [105324] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Check for permission before using IndexedDB from a worker.
https://bugs.webkit.org/show_bug.cgi?id=76500
Reviewed by David Levin.
- src/IDBFactoryBackendProxy.cpp:
(WebKit::AllowIndexedDBMainThreadBridge::create):
(WebKit::AllowIndexedDBMainThreadBridge::cancel):
(WebKit::AllowIndexedDBMainThreadBridge::result):
(WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
(WebKit::AllowIndexedDBMainThreadBridge::AllowIndexedDBMainThreadBridge):
(WebKit::AllowIndexedDBMainThreadBridge::allowIndexedDBTask): Call
webView->permissionClient()->allowIndexedDB on the main thread because
ContentSettingsObserver::AllowIndexedDB(), which is called down the
chain, expects to be run on the main thread.
(WebKit::AllowIndexedDBMainThreadBridge::didComplete):
(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread): Wait for
main permission check to complete on main thread before proceeding on
worker thread.
- 2:37 PM Changeset in webkit [105323] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Add a flag telling plug-in if it can enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=76467
Reviewed by Anders Carlsson.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Added a private flag.
- 2:34 PM Changeset in webkit [105322] by
-
- 2 edits in trunk/Tools
Adding myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=76569
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 2:32 PM Changeset in webkit [105321] by
-
- 3 edits2 adds in trunk
REGRESSION (r104000): AdBlock extension fails to load/function
https://bugs.webkit.org/show_bug.cgi?id=75554
Reviewed by Andy Estes.
Source/WebCore:
Previously, we would claim the documentElement was available before
we'd actually attached it to the DOM (which we now do via the
attachment queue). This issue was noted in the code with a FIXME
comment, but there was no test coverage for the issue. This patch
resolves the FIXME and adds a test.
Test: userscripts/document-element-available-at-start.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
LayoutTests:
This test checks that the documentElement is available when user
scripts are run at document start.
- userscripts/document-element-available-at-start-expected.txt: Added.
- userscripts/document-element-available-at-start.html: Added.
- 2:27 PM Changeset in webkit [105320] by
-
- 2 edits in trunk/LayoutTests
[SKIA / CHROMIUM] Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=76469
Patch by Brian Salomon <bsalomon@google.com> on 2012-01-18
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 2:13 PM Changeset in webkit [105319] by
-
- 4 edits in trunk/Tools
Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
https://bugs.webkit.org/show_bug.cgi?id=76567
Reviewed by Eric Seidel.
Current the AppleMac port has slightly more failures than we allow on
the EWS, causing the mac-ews to spin. This patch ups the limit a bit,
which should hopefully let the mac-ews run to completion. Once
AppleMac has fewer failures, we can lower the cap again.
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_layout_test_results):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 2:07 PM Changeset in webkit [105318] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] MediaStream API: Make WebMediaStreamDescriptor copyable
https://bugs.webkit.org/show_bug.cgi?id=76526
Reviewed by Darin Fisher.
This patch adds a copy constructor and a assignment operator to WebMediaStreamDescriptor.
- public/platform/WebMediaStreamDescriptor.h:
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::operator=):
- src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::assign):
- 1:58 PM Changeset in webkit [105317] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r105310): Two inspector tests fails
https://bugs.webkit.org/show_bug.cgi?id=76566
- platform/qt/Skipped: Skip failing tests to paint the bot green.
- 1:47 PM Changeset in webkit [105316] by
-
- 2 edits4 adds in trunk/LayoutTests
[chromium] Update expectations, add a few new baselines.
- platform/chromium/http/tests/misc/bubble-drag-events-expected.txt: Added.
- platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
- platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:45 PM Changeset in webkit [105315] by
-
- 33 edits4 adds in trunk
Provide access to user's list of preferred languages
https://bugs.webkit.org/show_bug.cgi?id=76138
Reviewed by Alexey Proskuryakov.
.:
- Source/autotools/symbols.filter: List the new functions.
Source/WebCore:
Test: fast/harness/user-preferred-language.html
- WebCore.exp.in: Export the new functions.
- WebCore.order: Ditto.
- Target.pri: Include new files.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCoreTestSupport.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/Language.cpp:
(WebCore::defaultLanguage): Return userPreferredLanguages[0].
(WebCore::preferredLanguagesOverride): New, return the languages override.
(WebCore::overrideUserPreferredLanguages): New, set the languages override.
(WebCore::userPreferredLanguages): New, return the languages array.
- platform/Language.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
- platform/chromium/LanguageChromium.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
- platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
- platform/gtk/LanguageGtk.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
- platform/mac/Language.mm:
(+[WebLanguageChangeObserver _webkit_languagePreferencesDidChange]): Flag the user languages
as invalid.
(WebCore::platformLanguage): Removed.
(WebCore::platformUserPreferredLanguages): New, return the list of user preferred languages.
- platform/qt/LanguageQt.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
- platform/win/LanguageWin.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
- testing/Internals.cpp:
(WebCore::Internals::userPreferredLanguages): New, return the platform's user preferred languages.
(WebCore::Internals::setUserPreferredLanguages): New, override the user's preferred languages.
- testing/Internals.h:
- testing/Internals.idl: Add userPreferredLanguages.
- testing/js/JSInternalsCustom.cpp:
(WebCore::JSInternals::userPreferredLanguages): New.
(WebCore::JSInternals::setUserPreferredLanguages): New.
- testing/v8/V8InternalsCustom.cpp:
(WebCore::V8Internals::userPreferredLanguagesAccessorGetter): New.
(WebCore::V8Internals::userPreferredLanguagesAccessorSetter): New.
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Encode the languages array.
(WebKit::WebProcessCreationParameters::decode): Decode the languages array.
- Shared/WebProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::languageChanged): Override the WebProcess userPreferredLanguages.
(WebKit::WebContext::ensureWebProcess): Initialize parameters.languages.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Override user languages array.
(WebKit::WebProcess::userPreferredLanguagesChanged): Ditto.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Define UserPreferredLanguagesChanged.
- win/WebKit2.def: Export the new functions.
- win/WebKit2CFLite.def: Ditto.
Tools:
- GNUmakefile.am: Add JSInternalsCustom.cpp.
LayoutTests:
- fast/harness/user-preferred-language-expected.txt: Added.
- fast/harness/user-preferred-language.html: Added.
- 1:41 PM Changeset in webkit [105314] by
-
- 14 edits1 add in trunk/Source
[chromium] Enable tracking opaque region in Skia graphics context, return it from LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=76211
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-18
Reviewed by James Robinson.
Source/WebCore:
New unit tests in LayerTextureUpdaterTest.cpp
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/PlatformCanvas.h:
(WebCore::PlatformCanvas::Painter::skiaContext):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::SkPictureCanvasLayerTextureUpdater::setOpaque):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/LayerTextureUpdaterTest.cpp: Added.
(WebCore::TestLayerPainterChromium::TestLayerPainterChromium):
(WebCore::TestLayerPainterChromium::paint):
(WebCore::PaintFillOpaque::operator()):
(WebCore::PaintFillAlpha::operator()):
(WebCore::TEST):
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
- 1:34 PM Changeset in webkit [105313] by
-
- 2 edits in trunk/LayoutTests
[Qt] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76563
- platform/qt/Skipped: Skip http/tests/misc/iframe-invalid-source-crash.html until fix.
- 1:23 PM Changeset in webkit [105312] by
-
- 5 edits2 adds1 delete in trunk/LayoutTests
[chromium] Update pixel results due to skia roll
- platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- 1:03 PM Changeset in webkit [105311] by
-
- 16 edits4 copies2 moves in trunk/Source
[chromium] Refactor canvas, plugin, and video drawing to be more data-driven
https://bugs.webkit.org/show_bug.cgi?id=76274
Patch by Tim Dresser <tdresser@chromium.org> on 2012-01-18
Reviewed by James Robinson.
Source/WebCore:
This is the first step in refactoring canvas, plugin, and video drawing.
The CCCustomLayerDrawQuad implementation has been copied to CCCanvasDrawQuad, CCPluginDrawQuad and CCVideoDrawQuad.
All references to CustomLayer have been removed.
As this is a refactor, no new tests were added. CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers was modified to
no longer test culling.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCanvasQuad):
(WebCore::LayerRendererChromium::drawVideoQuad):
(WebCore::LayerRendererChromium::drawPluginQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCCanvasDrawQuad::create):
(WebCore::CCCanvasDrawQuad::CCCanvasDrawQuad):
- platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCCanvasDrawQuad::layer):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toCanvasDrawQuad):
(WebCore::CCDrawQuad::toVideoDrawQuad):
(WebCore::CCDrawQuad::toPluginDrawQuad):
- platform/graphics/chromium/cc/CCDrawQuad.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCPluginDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):
- platform/graphics/chromium/cc/CCPluginDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCPluginDrawQuad::layer):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCVideoDrawQuad::layer):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
Source/WebKit/chromium:
No longer test culling in CCLayerTreeHostImplTest.blendingOffWhenDrawingLayers.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setExpectation):
(WebKit::BlendStateCheckLayer::quadsAppended):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(WebKit::TEST_F):
- 12:59 PM Changeset in webkit [105310] by
-
- 9 edits4 adds in trunk
Web Inspector: Unsafe cross origin access errors should show stack trace in console.
https://bugs.webkit.org/show_bug.cgi?id=73099
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/console-cross-origin-iframe-logging.html
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::reportUnsafeAccessTo):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addConsoleMessage):
- dom/ScriptExecutionContext.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldAllowNavigation):
- page/Console.cpp:
(WebCore::Console::addMessage):
- page/Console.h:
- page/DOMWindow.cpp:
(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::stackTrace):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::printErrorMessage):
LayoutTests:
- http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
- http/tests/inspector/console-cross-origin-iframe-logging.html: Added.
- http/tests/inspector/resources/cross-origin-iframe.html: Added.
- platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
- 12:33 PM Changeset in webkit [105309] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r98935.
- 12:29 PM Changeset in webkit [105308] by
-
- 13 edits in trunk/Source/WebCore
Add [CallWith] support for attributes in JSC/V8 idl code generators.
Part of https://bugs.webkit.org/show_bug.cgi?id=76035
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-18
Reviewed by Adam Barth.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateAttributeCallWith):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateAttributeCallWith):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::withScriptStateAttribute):
(WebDOMTestObj::setWithScriptStateAttribute):
(WebDOMTestObj::withScriptExecutionContextAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAttribute):
(WebDOMTestObj::withScriptStateAttributeRaises):
(WebDOMTestObj::setWithScriptStateAttributeRaises):
(WebDOMTestObj::withScriptExecutionContextAttributeRaises):
(WebDOMTestObj::setWithScriptExecutionContextAttributeRaises):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptStateAttribute]):
(-[DOMTestObj setWithScriptStateAttribute:]):
(-[DOMTestObj withScriptExecutionContextAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAttribute:]):
(-[DOMTestObj withScriptStateAttributeRaises]):
(-[DOMTestObj setWithScriptStateAttributeRaises:]):
(-[DOMTestObj withScriptExecutionContextAttributeRaises]):
(-[DOMTestObj setWithScriptExecutionContextAttributeRaises:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeRaisesAttrSetter):
- 12:18 PM Changeset in webkit [105307] by
-
- 3 edits in trunk/LayoutTests
file:// doesn't work as base URL
https://bugs.webkit.org/show_bug.cgi?id=76496
Updating more layout test results.
- fast/loader/url-parse-1-expected.txt: This was already in the patch, just failed to land.
- http/tests/misc/bubble-drag-events-expected.txt: Missed that one among failure noise.
- 12:16 PM Changeset in webkit [105306] by
-
- 3708 edits382 copies47 deletes in branches/subpixellayout
Merging trunk changes up until 105194 into subpixel branch.
- 12:12 PM Changeset in webkit [105305] by
-
- 4 edits in trunk
[Qt][WK2] Broken build with undefined reference to shm_open and shm_unlink
https://bugs.webkit.org/show_bug.cgi?id=76538
Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-01-18
Reviewed by Tor Arne Vestbø.
The -lrt parameter was coming before -lWebKit2 during linkage.
Moved rt lib inclusion from Source/api.pri to WebKit2.pri as it should be aware
of its own dependencies instead of letting WebKit guess about. Letting
it on api.pri can lead to a wrong parameter's order during linker phase.
Ubuntu 11.10 was giving errors about SharedMemory (shm_open and
shm_unlink undefined symbols).
.:
- Source/api.pri:
Source/WebKit2:
The issue was fixed with the help of Aloisio Almeida and Lauro Venancio.
- WebKit2.pri:
- 12:04 PM WebKit Team edited by
- Adding Jon Lee as committer. (diff)
- 11:59 AM Changeset in webkit [105304] by
-
- 2 edits in trunk/LayoutTests
add test expections ahead of skia DEPS roll
https://bugs.webkit.org/show_bug.cgi?id=76477
Reviewed by NOBODY: Unreviewed
see http://code.google.com/p/chromium/issues/detail?id=110493
- platform/chromium/test_expectations.txt:
- 11:48 AM Changeset in webkit [105303] by
-
- 15 edits2 adds2 deletes in trunk/LayoutTests
[chromium] Update expectations and baselines for various tests
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
- platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
- platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-all-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewBox-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
- platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.txt:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium/test_expectations.txt:
- 11:39 AM Changeset in webkit [105302] by
-
- 2 edits in trunk/Tools
Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
configurations.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.init):
- 11:24 AM Changeset in webkit [105301] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit/mac
Merged r105291.
- 10:59 AM Changeset in webkit [105300] by
-
- 1 edit in branches/safari-534.54-branch/LayoutTests/fast/dom/importNode-confusing-localName.html
Merge layoutest fix from 10695015.
- 10:58 AM Changeset in webkit [105299] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: fix failing inspector test.
- inspector/elements/set-html-via-resource.html:
- 10:57 AM Changeset in webkit [105298] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r104275.
- 10:51 AM Changeset in webkit [105297] by
-
- 3 edits6 copies in branches/safari-534.54-branch
Merged r97088.
- 10:49 AM Changeset in webkit [105296] by
-
- 5 edits3 adds in trunk
[CG] Rasterized scaling of transformed SVG shapes with gradient fill and -webkit-svg-shadow applied
https://bugs.webkit.org/show_bug.cgi?id=76482
<rdar://problem/10415483>
Reviewed by Simon Fraser.
Scale the CGLayer used when filling or stroking a shadowed path or rect with
a gradient in GraphicsContextCG. Previously, the CGLayer was created and rendered
into at the untransformed size of the shape, leading to pixelation when it was
then scaled up and drawn into the destination.
Add AffineTransform::mapSize() to map a size through a transformation.
Test: svg/custom/transform-with-shadow-and-gradient.svg
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
- platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapSize): Added.
- platform/graphics/transforms/AffineTransform.h:
Add a test that ensures that SVG shapes are drawn crisply when transformed
if they have both a gradient fill and -webkit-svg-shadow applied.
- platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
- platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
- svg/custom/transform-with-shadow-and-gradient.svg: Added.
- 10:46 AM Changeset in webkit [105295] by
-
- 18 edits18 adds in trunk
Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460
Reviewed by Chris Fleizach.
Source/WebCore:
Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html
platform/chromium/accessibility/scroll-to-global-point-nested.html
platform/chromium/accessibility/scroll-to-global-point-iframe.html
platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html
platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
platform/chromium/accessibility/scroll-to-make-visible-iframe.html
platform/chromium/accessibility/scroll-to-make-visible-main-window.html
platform/chromium/accessibility/scroll-to-make-visible-nested.html
platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html
- accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
- accessibility/AccessibilityScrollView.h:
Source/WebKit/chromium:
- public/WebAccessibilityObject.h:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):
Tools:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):
- DumpRenderTree/chromium/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
LayoutTests:
- platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
- platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
- platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
- platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
- platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
- platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
- platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
- platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
- platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
- platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.
- 10:41 AM Changeset in webkit [105294] by
-
- 7 edits3 adds in trunk
file:// doesn't work as base URL
https://bugs.webkit.org/show_bug.cgi?id=76496
Reviewed by Darin Adler.
Test: fast/url/degenerate-file-base.html
- platform/KURL.cpp: (WebCore::KURL::parse): Handle degenerate file URLs properly.
- 10:41 AM Changeset in webkit [105293] by
-
- 6 edits2 copies in branches/safari-534.54-branch
Merged r95371.
- 10:20 AM Changeset in webkit [105292] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Web Inspector: highlight DOM nodes from detached DOM trees.
https://bugs.webkit.org/show_bug.cgi?id=76545
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isNativeRoot):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
- inspector/front-end/heapProfiler.css:
(.detached-dom-tree-node):
- 10:12 AM Changeset in webkit [105291] by
-
- 4 edits1 add in trunk
Source/WebKit/mac: Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
https://bugs.webkit.org/show_bug.cgi?id=76490
<rdar://problem/9460733>
Starting with Lion, there is no more NSForegroundColor attribute in the dictionary
if the color matches the default (solid black).
The fix consists in treating the lack of color as solid black instead of transparent as
we did before.
Added a TestWebKitAPI test.
Reviewed by Darin Adler and Dan Bernstein.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]):
Tools: Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
https://bugs.webkit.org/show_bug.cgi?id=76490
<rdar://problem/9460733>
Added TestWebKitAPI test.
Reviewed by Dan Bernstein.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
- TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
changeAttributes to the WebView.
- 10:10 AM Changeset in webkit [105290] by
-
- 3 edits in trunk/Source/JavaScriptCore
Cross-platform processor core counter fix
https://bugs.webkit.org/show_bug.cgi?id=76540
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-18
Reviewed by Zoltan Herczeg.
I attached "OS(FREEBSD)" to "#if OS(DARWIN) OS(OPENBSD) OS(NETBSD)" and I removed the OS checking macros from ParallelJobsGeneric.cpp because
the NumberOfCores.cpp contains them for counting CPU cores.
The processor core counter patch located at
https://bugs.webkit.org/show_bug.cgi?id=76530
- wtf/NumberOfCores.cpp:
- wtf/ParallelJobsGeneric.cpp:
- 10:06 AM Changeset in webkit [105289] by
-
- 4 edits in trunk/Source
[GTK] Listen to GDK_SCROLL_MASK
https://bugs.webkit.org/show_bug.cgi?id=76529
Source/WebKit/gtk:
Set GDK_SCROLL_MASK explicitly, as WebKitWebView does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.
Patch by Carlos Garnacho <carlosg@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(webkit_web_view_realize):
Source/WebKit2:
Set GDK_SCROLL_MASK explicitly, as WebKitWebViewBase does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.
Patch by Carlos Garnacho <carlosg@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):
- 9:56 AM Changeset in webkit [105288] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: there should be a way to set HTML for given frame.
https://bugs.webkit.org/show_bug.cgi?id=76548
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
- inspector/InspectorPageAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMModelResourceBinding.prototype.setContent.callbackWrapper):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
- 9:41 AM Changeset in webkit [105287] by
-
- 2 edits in trunk/LayoutTests
[Qt] fontCache related assertion revealed by r105143
https://bugs.webkit.org/show_bug.cgi?id=76534
Unreviewed gardening. Skip a guilty test to paint the bot green.
- platform/qt/Skipped:
- 9:40 AM Changeset in webkit [105286] by
-
- 2 edits in trunk/Source/WebCore
[GTK] [regression] A couple of tests failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76549
Reviewed by Gustavo Noronha Silva.
Fixes a regression added by r105253. The method that
RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
instead of popsMenuByArrowKeys().
No new tests as it's already covered by
fast/forms/select-popup-pagekeys.html and
fast/forms/select/menulist-onchange-fired-with-key-up-down.html
that started to fail after the revision mentioned above.
- platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):
- 9:35 AM Changeset in webkit [105285] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix the debug build.
Unreviewed.
- UIProcess/qt/QtWebPageEventHandler.cpp:
(setInputPanelVisible): Remove assertion from non-member function.
- 9:27 AM Changeset in webkit [105284] by
-
- 2 edits1 add in trunk/LayoutTests
Not reviewed: adding missing test data file.
- inspector/elements/resources/set-html-via-resource-iframe.html: Added.
- platform/qt/Skipped:
- 9:19 AM Changeset in webkit [105283] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r105262.
https://bugs.webkit.org/show_bug.cgi?id=76457
- platform/qt/Skipped: Skip inspector/elements/set-html-via-resource.html until proper fix.
- 9:14 AM Changeset in webkit [105282] by
-
- 7 edits in trunk
Web Inspector: omit compression field in HAR entries for resources coming from cache
https://bugs.webkit.org/show_bug.cgi?id=76543
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype.get responseCompression):
LayoutTests:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-headers-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
- 9:09 AM Changeset in webkit [105281] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests, simplify qt-wk2 skipped list.
- platform/qt-wk2/Skipped:
- platform/wk2/Skipped:
- 8:57 AM Changeset in webkit [105280] by
-
- 5 edits in trunk
[CSSRegions]Fix region style code in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=76453
Reviewed by Antti Koivisto.
Source/WebCore:
Follow up after comments in https://bugs.webkit.org/show_bug.cgi?id=76064.
With the new approach, the css rule specificity is correctly taken into account
when applying the region style rule.
No new tests, the region style tests are still disabled.
- css/CSSStyleSelector.cpp:
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::checkRegionStyle):
(WebCore::CSSStyleSelector::checkRegionSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSelector.h:
LayoutTests:
Fix the test as it was not taking into account the selector specificity.
- fast/regions/region-style-block-background-color.html:
- 8:39 AM Changeset in webkit [105279] by
-
- 7 edits in trunk
Mac fails to fire an 'error' event for a <video> <source> having an URL with no file extension
https://bugs.webkit.org/show_bug.cgi?id=76494
Reviewed by Eric Carlson.
No new tests; fixes compositing/video/video-with-invalid-source.html. Modified
media/video-source-error-no-candidate.html to check error condition.
When we run out of media engines for a given resource, inform the media player client
that resource loading failed by calling mediaPlayerResourceNotSupported().
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerResourceNotSupported):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerResourceNotSupported):
- 8:06 AM Changeset in webkit [105278] by
-
- 2 edits in trunk/LayoutTests
WebKit2 needs layoutTestController.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=42197
Unreviewed gardening, skip failing tests due to this bug.
- platform/wk2/Skipped:
- 8:02 AM Changeset in webkit [105277] by
-
- 2 edits in trunk/LayoutTests
[Qt] Test fonts metric differencies with Qt5
https://bugs.webkit.org/show_bug.cgi?id=75710
Unreviewed gardening, unskip now passing tests after tesfont fix
- platform/qt-5.0/Skipped:
- 7:42 AM Changeset in webkit [105276] by
-
- 19 edits11 adds in trunk
CSS Shaders: Parse float parameters for the custom() filter syntax
https://bugs.webkit.org/show_bug.cgi?id=76253
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Custom CSS filters allow passing parameters from CSS to the underlying rendering technology (in this case WebGL Shaders).
This patch adds support for parameters of types float, vec2, vec3 and vec4.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustomParamsAttribute
Tests: css3/filters/effect-custom-combined-missing.html
css3/filters/effect-custom-parameters.html
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added CustomFilterParameter.h, CustomFilterNumberParameter.h and CustomFilterOperation.cpp to the projects.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterNumberParameter):
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterParameter):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
Added the computed parameters in alphabetic order (CustomFilterOperation always keeps the parameters sorted).
- css/CSSComputedStyleDeclaration.h:
- css/CSSStyleSelector.cpp:
(WebCore::sortParametersByNameComparator):
(WebCore::CSSStyleSelector::parseCustomFilterNumberParamter):
(WebCore::CSSStyleSelector::parseCustomFilterParameterList):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
Added parsing for float, vec2, vec3 and vec4. The values are space separated.
- css/CSSStyleSelector.h:
- platform/graphics/filters/CustomFilterNumberParameter.h: Added.
(WebCore::CustomFilterNumberParameter::create):
(WebCore::CustomFilterNumberParameter::size):
(WebCore::CustomFilterNumberParameter::valueAt):
(WebCore::CustomFilterNumberParameter::addValue):
(WebCore::CustomFilterNumberParameter::CustomFilterNumberParameter):
- platform/graphics/filters/CustomFilterOperation.cpp: Added.
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::~CustomFilterOperation):
Moved constructor and destructor in CustomFilterOperation.cpp to avoid including CustomFilterParameter everywhere.
(WebCore::CustomFilterOperation::hasSortedParameterList):
Debug runtime check that we always have parameters in alphabetic order.
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::create):
(WebCore::CustomFilterOperation::parameters):
Just added the parameters list. Not using a map, but keeping the items sorted by name. We need them sorted
to make it easy and fast to merge two CustomFilterOperations during animations.
- platform/graphics/filters/CustomFilterParameter.h: Added.
(WebCore::CustomFilterParameter::~CustomFilterParameter):
(WebCore::CustomFilterParameter::parameterType):
(WebCore::CustomFilterParameter::name):
(WebCore::CustomFilterParameter::CustomFilterParameter):
- platform/graphics/filters/CustomFilterShader.cpp:
(WebCore::CustomFilterShader::uniformLocationByName):
- platform/graphics/filters/CustomFilterShader.h:
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::bindProgramNumberParameters):
(WebCore::FECustomFilter::bindProgramParameters):
Added code that maps the parameters from CSS to WebGL.
(WebCore::FECustomFilter::bindProgramAndBuffers):
- platform/graphics/filters/FECustomFilter.h:
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
Fixed a case when the filter was not created, letting the filter add itself as a source of its own.
Also added a test case for this particular case: css3/filters/effect-custom-combined-missing.html.
LayoutTests:
- css3/filters/custom-filter-property-computed-style-expected.txt:
- css3/filters/effect-custom-combined-missing-expected.png: Added.
- css3/filters/effect-custom-combined-missing-expected.txt: Added.
- css3/filters/effect-custom-combined-missing.html: Added.
Testing that missing shader filters will not enter an infinite loop.
- css3/filters/effect-custom-parameters-expected.png: Added.
- css3/filters/effect-custom-parameters-expected.txt: Added.
- css3/filters/effect-custom-parameters.html: Added.
- css3/filters/resources/color-offset-parameters.fs: Added.
- css3/filters/resources/vertex-offset-parameters.vs: Added.
Testing parameter passing from CSS to WebGL.
- css3/filters/script-tests/custom-filter-property-computed-style.js:
Added computed style checks for number parameters.
- 7:36 AM Changeset in webkit [105275] by
-
- 10 edits in trunk/Source/WebKit2
[Qt] Zoom in to the focused node only when vkb starts becoming visible https://bugs.webkit.org/show_bug.cgi?id=76174
Reviewed by Simon Hausmann.
Remove the old code which always zoomed in when something got focus,
even via JavaScript, and replaced it with code checking the state of
the Qt input panel.
Also make sure that we do not zoom in or request the input panel if
the item is not focused.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtPageClient.cpp:
- UIProcess/qt/QtPageClient.h:
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::inputPanelVisibleChanged):
- UIProcess/qt/QtWebPageEventHandler.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
- 7:21 AM Changeset in webkit [105274] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: resource tree model leaks frames
https://bugs.webkit.org/show_bug.cgi?id=76533
Reviewed by Pavel Feldman.
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._removeFrame):
(WebInspector.ResourceTreeFrame.prototype._removeChildFrame):
- 7:07 AM Changeset in webkit [105273] by
-
- 2 edits in trunk/Source/JavaScriptCore
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Unreviewed cross-MinGW buildfix after r105270.
- wtf/NumberOfCores.cpp: Use windows.h instead of Windows.h.
- 6:20 AM Changeset in webkit [105272] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Enable support for Open Script dialog based on FilteredItemSelectionDialog.
https://bugs.webkit.org/show_bug.cgi?id=76466
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.install):
(WebInspector.OpenResourceDialog._show):
(WebInspector.OpenResourceDialog.createShortcut):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showUISourceCode):
- 6:15 AM Changeset in webkit [105271] by
-
- 3 edits in trunk/LayoutTests
[Qt] Update another SVG expected after r105247.
Unreviewed.
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
- 6:15 AM Changeset in webkit [105270] by
-
- 11 edits2 adds in trunk/Source
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-18
Reviewed by Zoltan Herczeg.
Source/JavaScriptCore:
Two files have been created that include the processor core counter function.
It used to be in ParallelJobsGeneric.h/cpp before.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Options.cpp:
(JSC::Options::initializeOptions):
- wtf/CMakeLists.txt:
- wtf/NumberOfCores.cpp: Added.
(WTF::numberOfProcessorCores):
- wtf/NumberOfCores.h: Added.
- wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
- wtf/ParallelJobsGeneric.h:
Source/WTF:
Two files have been added to the project, namely NumberOfCores.h/cpp,
that include a CPU core number determining function.
- WTF.pro:
- 5:57 AM Changeset in webkit [105269] by
-
- 2 edits in trunk/LayoutTests
[Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143
https://bugs.webkit.org/show_bug.cgi?id=76534
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 5:52 AM Changeset in webkit [105268] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: follow up to r105262, fixing front-end compilation.
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):
- 5:35 AM Changeset in webkit [105267] by
-
- 10 edits in trunk
[Qt] Consolidate layout test crash logging
https://bugs.webkit.org/show_bug.cgi?id=75088
Reviewed by Simon Hausmann.
Move backtrace generating logic into WTFReportBacktrace
and add a way to deinstall signal handlers if we know
that we have already printed the backtrace.
.:
- Source/qtwebkit-export.map:
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/Assertions.cpp:
(WTFLogLocker::WTFReportBacktrace):
(WTFLogLocker::WTFSetCrashHook):
(WTFLogLocker::WTFInvokeCrashHook):
- wtf/Assertions.h:
Tools:
- DumpRenderTree/qt/main.cpp:
(crashHandler):
(setupSignalHandlers):
(WTFCrashHook):
(main):
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::crashHandler):
(WTR::setupSignalHandlers):
(WTR::crashHook):
(WTR::InjectedBundle::platformInitialize):
- 5:26 AM Changeset in webkit [105266] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after testfonts update.
- platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png:
- platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt:
- 5:15 AM Changeset in webkit [105265] by
-
- 23 edits in trunk/LayoutTests
[Qt] Update some SVG expected after r105247.
Unreviewed.
- platform/qt/svg/custom/linking-a-03-b-all-expected.png:
- platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
- platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
- platform/qt/svg/custom/pointer-events-image-expected.png:
- platform/qt/svg/custom/pointer-events-image-expected.txt:
- platform/qt/svg/custom/pointer-events-text-expected.png:
- platform/qt/svg/custom/pointer-events-text-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- 5:00 AM Changeset in webkit [105264] by
-
- 2 edits in trunk/LayoutTests
[GTK] platform/gtk/accessibility/combo-box-collapsed-selection-changed.html is failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76531
Unreviewed. Skip test now failing in the GTK port.
- platform/gtk/Skipped: Skip test.
- 5:00 AM Changeset in webkit [105263] by
-
- 2 edits in trunk/Tools
Unreviewed build fix after r105256.
There was a cyclic dependency between self._port and self._host assigments.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- 4:52 AM Changeset in webkit [105262] by
-
- 10 edits2 adds in trunk
Web Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
https://bugs.webkit.org/show_bug.cgi?id=76457
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/elements/set-html-via-resource.html
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.setAttributeValue):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.moveTo):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._buildHighlightConfig):
(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype._captureDOM.callback):
(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):
(WebInspector.DOMModelResourceBinding.prototype.setContent.withDocument):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
LayoutTests:
- inspector/elements/resources/set-outer-html-body-iframe.html:
- inspector/elements/set-html-via-resource-expected.txt: Added.
- inspector/elements/set-html-via-resource.html: Added.
- 4:46 AM Changeset in webkit [105261] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363
Reviewed by Pavel Feldman.
This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
- 3:33 AM Changeset in webkit [105260] by
-
- 2 edits in trunk/Tools
Add new watchlist rule for the Qt build system
Reviewed by Simon Hausmann.
- 3:32 AM Changeset in webkit [105259] by
-
- 4 edits in trunk
[Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
Reviewed by Simon Hausmann.
- 3:32 AM Changeset in webkit [105258] by
-
- 4 edits in trunk/Tools
[Qt] Allow building only a subset of the WebKit sub-projects
Fixes build-jsc, broken in r104825.
We no longer need the intermediate buildQMakeQtProject(), as we're the
only port using qmake, and buildQMakeProject is now highly Qt specific.
Reviewed by Simon Hausmann.
- 3:25 AM Changeset in webkit [105257] by
-
- 11 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r105247 and r105253.
- platform/gtk/css3/images/cross-fade-overflow-position-expected.txt:
- platform/gtk/fast/forms/implicit-submission-expected.txt:
- platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
- platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
- platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
- platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
- platform/gtk/svg/custom/pointer-events-image-css-transform-expected.txt:
- platform/gtk/svg/custom/pointer-events-image-expected.txt:
- platform/gtk/svg/custom/pointer-events-text-css-transform-expected.txt:
- platform/gtk/svg/custom/pointer-events-text-expected.txt:
- 2:52 AM Changeset in webkit [105256] by
-
- 4 edits in trunk/Tools
run-perf-tests should generate a json file that summaries the result
https://bugs.webkit.org/show_bug.cgi?id=76504
Reviewed by Adam Barth.
Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
New option --outout-json-path specifies the json file's path, and --source-json-path specifies
another json file to be merged into the generated json file.
Also fixed a bug that --build wasn't set by default.
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.webkit_base):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json_if_specified):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest):
(create_runner):
(test_run_test_set):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_summary_json):
(test_collect_tests):
(test_parse_args):
- 2:52 AM Changeset in webkit [105255] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=76525
Removed missing build headers.
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
- WebCore.xcodeproj/project.pbxproj:
- 2:40 AM Changeset in webkit [105254] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, fix clashing svg/custom/linking-a-03-b-viewBox.svg expectation.
- platform/chromium/test_expectations.txt:
- 2:39 AM Changeset in webkit [105253] by
-
- 6 edits in trunk/Source/WebCore
Use RenderTheme in HTMLSelectElement instead of #defines.
<http://webkit.org/b/76519>
Patch by Jun Mukai <mukai@chromium.org> on 2012-01-18
Reviewed by Kent Tamura.
Tests: no new tests because of no behavioral changes.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
- platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuByArrowKeys):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::popsMenuByArrowKeys):
(WebCore::RenderTheme::popsMenuBySpaceOrReturn):
- rendering/RenderThemeChromiumLinux.h:
(WebCore::RenderThemeChromiumLinux::popsMenuBySpaceOrReturn):
- rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::popsMenuByArrowKeys):
- 2:15 AM Changeset in webkit [105252] by
-
- 2 edits in branches/chromium/963/Source/WebCore/inspector/front-end
Merge 105140 - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058
Reviewed by Pavel Feldman.
As per the results of a war room:
- Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
- Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
- Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
- Grayed autocompletion can only be accepted with the End or Right keys.
- Enter can accept a selected suggestion item from the list, without committing the input.
- Retain the CSS model editing behavior as close to the existing one as possible.
- Enable PageUp/PageDown to navigate the suggest box items.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252006
- 2:08 AM Changeset in webkit [105251] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: Chromium test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 2:00 AM Changeset in webkit [105250] by
-
- 3 edits3 adds in trunk
Source/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309
Reviewed by Nikolas Zimmermann.
updateWidgetPositions can blow away the owning renderer
and its frameview, so need to protect it with refptr.
Test: svg/dom/parent-view-layout-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::forceLayoutParentViewIfNeeded):
LayoutTests: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309
Reviewed by Nikolas Zimmermann.
- svg/dom/parent-view-layout-crash-expected.txt: Added.
- svg/dom/parent-view-layout-crash.html: Added.
- svg/dom/resources/svg-font-face.svg: Added.
- 1:22 AM EFLWebKitCodingStyle edited by
- (diff)
- 1:22 AM EFLWebKitCodingStyle edited by
- (diff)
- 1:15 AM Changeset in webkit [105249] by
-
- 29 edits6 moves in trunk
Move ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass of HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=76241
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
Reviewed by Dimitri Glazkov.
.:
- Source/autotools/symbols.filter: Exposed necessary symbols.
Source/WebCore:
Renamed ShadowContentElement to HTMLContentElement, and move it from dom/ to html/.
Also, ShadowInclusionSelector and ShadowContentSelectorQuery are renamed to
Content InclusionSelector and ContentSelectorQuery respectively.
No new tests, because no change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
- dom/NodeRenderingContext.h:
(WebCore::NodeRenderingContext::includer):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):
- dom/ShadowRoot.h:
- html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
- html/HTMLElementsAllInOne.cpp:
- html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
- html/shadow/ContentInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowInclusionSelector.cpp.
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ContentInclusionSelector::ContentInclusionSelector):
(WebCore::ContentInclusionSelector::~ContentInclusionSelector):
(WebCore::ContentInclusionSelector::select):
(WebCore::ContentInclusionSelector::unselect):
(WebCore::ContentInclusionSelector::findFor):
(WebCore::ContentInclusionSelector::didSelect):
(WebCore::ContentInclusionSelector::willSelectOver):
- html/shadow/ContentInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowInclusionSelector.h.
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ContentInclusionSelector::hasCandidates):
- html/shadow/ContentSelectorQuery.cpp: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.cpp.
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
- html/shadow/ContentSelectorQuery.h: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.h.
- html/shadow/HTMLContentElement.cpp: Renamed from Source/WebCore/dom/ShadowContentElement.cpp.
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::~HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::select):
(WebCore::HTMLContentElement::setSelect):
- html/shadow/HTMLContentElement.h: Renamed from Source/WebCore/dom/ShadowContentElement.h.
(WebCore::HTMLContentElement::inclusions):
(WebCore::HTMLContentElement::isContentElement):
(WebCore::HTMLContentElement::rendererIsNeeded):
(WebCore::HTMLContentElement::createRenderer):
(WebCore::toHTMLContentElement):
- testing/Internals.cpp:
(WebCore::Internals::createContentElement):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def: Exposed necessary symbols.
- win/WebKit2CFLite.def: ditto.
LayoutTests:
Renamed internals.createShadowContentElement to internals.createContentElement.
- fast/dom/shadow/content-element-includer.html:
- fast/dom/shadow/content-element-renderers.html:
- fast/dom/shadow/create-content-element.html:
- fast/dom/shadow/shadow-contents-select.html:
- 1:04 AM Changeset in webkit [105248] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ build after r105245.
- Source/autotools/symbols.filter: Fix symbol name.
- 12:45 AM Changeset in webkit [105247] by
-
- 31 edits in trunk
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446
Reviewed by Zoltan Herczeg.
Source/WebCore:
Let RenderSVGRoot inherit from RenderReplaced, instead of faking RenderReplaced, by inherting from RenderBox
and calling setReplaced(true) in the constructor. The outermost <svg> element is a replaced element in the
sense of CSS, and thus this is just a logical move. It fixes some issues where the <svg> root appeared
as selection leaf, covered by existing tests.
It allows us to simplify the painting, as outlines, etc. are painted by RenderReplaced now.
While I was it, speed up the local to border box computations by caching the result.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::willBeDestroyed):
(WebCore::RenderSVGRoot::styleWillChange):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::updateFromElement):
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
(WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::canHaveChildren):
(WebCore::RenderSVGRoot::canBeSelectionLeaf):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):
LayoutTests:
Update test results after making RenderSVGRoot inherit from RenderReplaced.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/custom/linking-a-03-b-all-expected.png: Text layout changed, we didn't relayout the tree when entering a new view before.
- platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Ditto.
- platform/mac/svg/custom/linking-a-03-b-viewBox-expected.png: Ditto.
- platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt: Ditto.
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png: Ditto.
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: Moving the circle, triggered a selection before, where it shouldn't. It's gone now.
- platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Ditto.
- platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Ditto.
- platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Caret position which is reported changed, due the selection leaf changes.
- platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Ditto.
- platform/mac/svg/custom/pointer-events-image-expected.png: Ditto.
- platform/mac/svg/custom/pointer-events-image-expected.txt: Ditto.
- platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Ditto.
- platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Ditto.
- platform/mac/svg/custom/pointer-events-text-expected.png: Ditto.
- platform/mac/svg/custom/pointer-events-text-expected.txt: Ditto.
- platform/mac/svg/foreignObject/text-tref-02-b-expected.png: This now reports a valid size for the RenderSVGRoot in the <fO> subtree.
- svg/foreignObject/text-tref-02-b-expected.txt: Ditto.