Timeline
Jan 24, 2012:
- 11:58 PM Changeset in webkit [105852] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Skip failing tests.
- platform/qt-wk2/Skipped:
- platform/wk2/Skipped:
- 11:49 PM Changeset in webkit [105851] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.
- platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
- platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
- 11:01 PM Changeset in webkit [105850] by
-
- 2 edits in trunk/Tools
Build fix. Trigger Chromium Mac Release (Perf) on new commits.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:48 PM Changeset in webkit [105849] by
-
- 16 edits2 adds in trunk
<style scoped>: Implement registering of <style scoped> with the scoping element
https://bugs.webkit.org/show_bug.cgi?id=67790
.:
windows.internals updates
Reviewed by Dimitri Glazkov.
- Source/autotools/symbols.filter:
Source/WebCore:
Implement registering of a <style> element with its parent element if the 'scoped' attribute is set.
Update the registration whenever the 'scoped' attribute is changed,
or the <style> element eneters or leaves the tree.
Also, extend windows.internals to allow for testing of the registration ref-counting.
Reviewed by Dimitri Glazkov.
Test: fast/css/style-scoped/registering.html
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::hasScopedHTMLStyleChild):
(WebCore::Element::numberOfScopedHTMLStyleChildren):
(WebCore::Element::registerScopedHTMLStyleChild):
(WebCore::Element::unregisterScopedHTMLStyleChild):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::registerScopedHTMLStyleChild):
(WebCore::ElementRareData::unregisterScopedHTMLStyleChild):
(WebCore::ElementRareData::hasScopedHTMLStyleChild):
(WebCore::ElementRareData::numberOfScopedHTMLStyleChildren):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::parseMappedAttribute):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::insertedIntoDocument):
(WebCore::HTMLStyleElement::removedFromDocument):
(WebCore::HTMLStyleElement::willRemove):
- html/HTMLStyleElement.h:
- testing/Internals.cpp:
(WebCore::Internals::numberOfScopedHTMLStyleChildren):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
Add symbols for windows.internals.numberOfScopedHTMLStyleChildren
Reviewed by Dimitri Glazkov.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Tests that registration of <style scoped> with its parent is performed correctly
in various circumstances.
Reviewed by Dimitri Glazkov.
- fast/css/style-scoped/registering-expected.txt: Added.
- fast/css/style-scoped/registering.html: Added.
- 10:08 PM Changeset in webkit [105848] by
-
- 3 edits in trunk/Tools
WebKit needs public performance tests running on public bots
https://bugs.webkit.org/show_bug.cgi?id=10266
Reviewed by Adam Barth.
Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(UploadPerfTestResults):
(BuildAndPerfTestFactory):
(BuildAndPerfTestFactory.init):
- 9:27 PM Changeset in webkit [105847] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105843>
(https://bugs.webkit.org/show_bug.cgi?id=75049)
Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").
- platform/KURL.h:
(WebCore::KURL::innerURL):
- 9:17 PM Changeset in webkit [105846] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed chromium test fix.
- src/js/Tests.js:
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):
- 7:28 PM Changeset in webkit [105845] by
-
- 7 edits1 add in trunk/Source
Source/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76735
This is to add skipped layers to their RenderSurface's layer list so that they
are considered in the next update. Without this change, m_skipsDraw = false sticks
with the layer for the remainder of its lifetime.
Reviewed by James Robinson.
Tests: Unit test (TiledLayerChromiumTest.cpp)
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::drawsContent):
- platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::skipsDraw):
Source/WebKit/chromium: Adding a test to verify that m_skipsDraw gets reset between frames for
tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=76735
Reviewed by James Robinson.
- WebKit.gypi:
- tests/FakeCCLayerTreeHostClient.h: Added.
(WebCore::FakeCCLayerTreeHostClient::updateAnimations):
(WebCore::FakeCCLayerTreeHostClient::layout):
(WebCore::FakeCCLayerTreeHostClient::applyScrollAndScale):
(WebCore::FakeCCLayerTreeHostClient::createLayerTreeHostContext3D):
(WebCore::FakeCCLayerTreeHostClient::didRecreateGraphicsContext):
(WebCore::FakeCCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::FakeCCLayerTreeHostClient::didCompleteSwapBuffers):
(WebCore::FakeCCLayerTreeHostClient::scheduleComposite):
- tests/LayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::skipsDraw):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):
- 6:47 PM Changeset in webkit [105844] by
-
- 6 edits in trunk/Source/WebCore
Invalidate r105697, r105766, r105809 and r105805
https://bugs.webkit.org/show_bug.cgi?id=76970
Reviewed by Adam Barth.
I've been trying to stop rebuilding .h/.cpp files generated by
unchanged IDLs (bug 76836), but the approach was wrong.
This patch invalidates patches committed in r105697, r105766,
r105809 and r105805.
In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm
so that they overwrite .h/.cpp files only when the bytes differ.
By this fix, we were able to stop rebuilding .h/.cpp files that are not
changed. However, the fix has made generate-bindings.pl run for almost
all IDLs every time. The reason is as follows:
(0) Assume that there are A.idl, B.idl and C.idl.
(1) Modify A.idl.
(2) First build.
(3) supplemental_dependency.tmp is updated.
(4) generate-bindings.pl runs for A.idl, B.idl and C.idl.
(5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated.
(6) Second build.
(7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(8) B.h, B.cpp, C.h and C.cpp are not updated.
(9) Third build.
(10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(11) B.h, B.cpp, C.h and C.cpp are not updated.
...
We should fix the bug somehow, but how to fix it is not obvious.
For the time being, this patch invalidates r105697, r105766, r105809
and r105805.
No tests. No change in behavior.
- bindings/scripts/CodeGenerator.pm:
(UpdateFile):
- bindings/scripts/CodeGeneratorCPP.pm:
(WriteData):
- bindings/scripts/CodeGeneratorJS.pm:
(WriteData):
- bindings/scripts/CodeGeneratorObjC.pm:
(WriteData):
- bindings/scripts/CodeGeneratorV8.pm:
(WriteData):
- 6:20 PM Changeset in webkit [105843] by
-
- 6 edits in trunk/Source/WebCore
Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049
Reviewed by Adam Barth.
No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it. This patch
merely enables that, without changing behavior.
- fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL): Add missing escaping of URL path.
- page/SecurityOrigin.cpp:
(WebCore::extractInnerURL): Use innerURL member, if it's populated.
- platform/KURL.h:
(WebCore::KURL::innerURL): Add innerURL member.
- platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F / in paths; it's much more readable, and it's safe.
- platform/KURLGooglePrivate.h:
(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.
- 6:13 PM Changeset in webkit [105842] by
-
- 2 edits in trunk/Tools
Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960
Reviewed by Adam Barth.
Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
on my Mac Pro.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.init):
(Bugzilla._get_browser):
(Bugzilla):
(Bugzilla._set_browser):
- 6:02 PM Changeset in webkit [105841] by
-
- 4 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC
Reviewed by Oliver Hunt.
Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):
- Track live handle objects in a map.
(WTF::MetaAllocator::release):
- Removed support for handles with null m_allocator (no longer used).
- Notify the tracker of handles being released.
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
- Moved functionality out into MetaAllocator::release.
(WTF::MetaAllocatorHandle::shrink):
- Removed support for handles with null m_allocator (no longer used).
(WTF::MetaAllocator::MetaAllocator):
- Initialize m_tracker.
(WTF::MetaAllocator::allocate):
- Notify the tracker of new allocations.
- wtf/MetaAllocator.h:
(WTF::MetaAllocatorTracker::find):
- Lookup a MetaAllocatorHandle based on an address inside the allocation.
(WTF::MetaAllocator::trackAllocations):
- Register a callback object to track allocation state.
- wtf/MetaAllocatorHandle.h:
- Remove unused createSelfManagedHandle/constructor.
(WTF::MetaAllocatorHandle::key):
- Added, for use in RedBlackTree.
- 5:44 PM Changeset in webkit [105840] by
-
- 9 edits1 delete in trunk
Death to JavaScriptGlue.
Rubber-stamped by Geoffrey Garen.
.:
- Source/JavaScriptGlue: Removed.
- Source/Makefile: Stop building JavaScriptGlue.
Tools:
- BuildSlaveSupport/build-launcher-app:
(copyNightlyLauncher):
- Scripts/build-webkit:
- Scripts/do-file-rename:
- Scripts/do-webcore-rename:
- Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
- Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
path in conjunction with a cross-platform path.
(ShouldBuildTest):
- 5:40 PM Changeset in webkit [105839] by
-
- 5 edits in tags/Safari-535.18.3/Source
Versioning.
- 5:38 PM Changeset in webkit [105838] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaky.
- platform/chromium/test_expectations.txt:
- 5:19 PM Changeset in webkit [105837] by
-
- 8 edits2 adds in trunk/Tools
webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836
Reviewed by David Kilzer.
Previously parser_unittests.pl can just test the returned value of
get_function_line_ranges() in prepare-ChangeLog. This patch fixes
parser_unittests.pl so that it also tests the stdout and stderr of
get_function_line_ranges().
This patch adds css_unittests_warning.css, which contains test cases
for warning messages of the CSS parser of prepare-ChangeLog.
- Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
(captureOutput): Captures the stdout and stderr of a given method.
(convertAbsolutepathToWebKitPath): Converts absolute paths in a given
string to relative paths.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
(element1):
(element2):
(element3):
(element4):
():
(element5):
(element6):
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
Just updated the test results, i.e. added stdout and stderr results.
No essential changes in the test results.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
- 5:14 PM Changeset in webkit [105836] by
-
- 9 edits in tags/Safari-535.18.3/Source/WebKit2
Merged 105517 and 105806.
- 5:03 PM Changeset in webkit [105835] by
-
- 2 edits in trunk/Tools
webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963
Reviewed by Adam Barth.
r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.
- Scripts/new-run-webkit-httpd:
(run):
(main):
- 4:56 PM Changeset in webkit [105834] by
-
- 2 edits in trunk/Tools
garden-o-matic pixel zoomer should let you look at every pixel of the image
https://bugs.webkit.org/show_bug.cgi?id=76962
Reviewed by Ojan Vafai.
Previously, you couldn't get up to the right and bottom pixels.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
- 4:48 PM Changeset in webkit [105833] by
-
- 1 copy in tags/Safari-535.18.3
New Tag.
- 4:27 PM Changeset in webkit [105832] by
-
- 5 edits in trunk
Clear some bogus executable bits that r105828 set.
- 4:22 PM Changeset in webkit [105831] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Linux-specific overrides.
- platform/chromium-linux/fast/css/min-width-with-spanned-cell-expected.png: Added.
- platform/chromium-linux/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
- 4:16 PM Changeset in webkit [105830] by
-
- 1520 edits981 copies87 deletes in branches/subpixellayout
Merging trunk changes up until 105803 into subpixel branch.
- 3:58 PM Changeset in webkit [105829] by
-
- 4 edits in trunk
WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>
Source/WebKit/mac:
The Inspector bar calls the typingAttributes methods on the clients that support it
to retrieve the set of attributes representing the style at the selection and uses
this information to update the state of the B, I and U buttons.
If this method is not supported, it defaults to the attributes of the previous
character position, reporting an incorrect state.
This occurs only when we have a caret selection.
Reviewed by Alexey Proskuryakov.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
(-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
(-[WebHTMLView typingAttributes]): Added.
Tools:
Added test to verify that WebHTMLView supports the typingAttributes method and that it
works as expected.
Reviewed by Alexey Proskuryakov.
- TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):
- 3:53 PM Changeset in webkit [105828] by
-
- 4 edits2 adds in trunk
Crash in updateFirstLetter() from unnecessary anonymous block
https://bugs.webkit.org/show_bug.cgi?id=72675
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-24
Reviewed by David Hyatt.
Source/WebCore:
There was a problem with anonymous blocks not getting removed when
their only block flow siblings are removed if they also have non-block
flow first-letter siblings (i.e. floats). This patch modifies
RenderBlock::removeChild() to look for this situation and strip out
unnecessary anonymous container blocks if it occurs.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added
- rendering/RenderBlock.h:
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added
LayoutTests:
Adding a test that cause a div to be removed from between a floating
first-letter block and its remaining text. If the anonymous block is
removed as an immediate consequence of the div removal, this shouldn't
crash.
- fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
- fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added
- 3:51 PM Changeset in webkit [105827] by
-
- 2 edits in trunk/LayoutTests
Mark these tests as flaky.
- platform/chromium/test_expectations.txt:
- 3:48 PM Changeset in webkit [105826] by
-
- 11 edits1 copy1 add in trunk
[chromium] event.dataTransfer.types should not return "Text" or "URL"
https://bugs.webkit.org/show_bug.cgi?id=76218
Source/WebCore:
Per the spec, "Text" and "URL" are special values handled for IE compatibility reasons in
dataTransfer.setData() and dataTransfer.getData(). These values should not be exposed
elsewhere.
Reviewed by Tony Chang.
Test: fast/events/dropzone-005.html
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):
LayoutTests:
Reviewed by Tony Chang.
- editing/pasteboard/dataTransfer-setData-getData-expected.txt:
- fast/events/dropzone-002.html:
- fast/events/dropzone-005-expected.txt: Added.
- fast/events/dropzone-005.html: Modified from LayoutTests/fast/events/dropzone-002.html.
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win-wk2/Skipped:
- 3:46 PM Changeset in webkit [105825] by
-
- 6 edits in trunk/Source/WebCore
Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946
Just a const-correctness change.
Reviewed by Tony Chang.
No new tests since no functionality changed.
- dom/DataTransferItemList.h:
(DataTransferItemList):
- platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::length):
- platform/chromium/DataTransferItemListChromium.h:
(DataTransferItemListChromium):
- platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::length):
- platform/qt/DataTransferItemListQt.h:
(DataTransferItemListQt):
- 3:37 PM Changeset in webkit [105824] by
-
- 1 edit2 deletes in branches/chromium/963
Revert 105795 - Merge 105685 - Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
BUG=108918
Review URL: https://chromiumcodereview.appspot.com/9214019
TBR=tsepez@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271032
- 3:34 PM Changeset in webkit [105823] by
-
- 5 edits7 adds in trunk/LayoutTests
Update table image baselines after http://trac.webkit.org/changeset/105775.
- platform/chromium-mac-leopard/fast/table/027-expected.png:
- platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/table/027-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/table/027-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
- platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.txt: Added.
- platform/chromium-win/fast/css/min-width-with-spanned-cell-expected.png: Added.
- platform/chromium-win/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
- platform/chromium-win/fast/table/027-expected.png:
- platform/chromium-win/fast/table/027-vertical-expected.png:
- 3:30 PM Changeset in webkit [105822] by
-
- 1 edit5 adds2 deletes in trunk/LayoutTests
More tweaks after leviw's updating of Mac baselines.
- platform/chromium-linux-x86/fast/multicol: Removed.
- platform/chromium-linux/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
- platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.
- 3:27 PM WebKit Team edited by
- (diff)
- 3:26 PM Changeset in webkit [105821] by
-
- 1 edit in branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt
fix branch test expectations
- 3:21 PM Changeset in webkit [105820] by
-
- 4 edits2 adds in trunk
REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
https://bugs.webkit.org/show_bug.cgi?id=76317
Reviewed by Darin Adler.
Source/WebCore:
Test: scrollbars/scroll-rtl-or-bt-layer.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
scrolling to the just computed offset.
LayoutTests:
- platform/win/Skipped:
- scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
- scrollbars/scroll-rtl-or-bt-layer.html: Added.
- 3:14 PM Changeset in webkit [105819] by
-
- 2 edits in trunk/Source/WebCore
Fix all of the builds after r105812.
- loader/EmptyClients.h: Move the #include in to the correct #if.
- 3:07 PM Changeset in webkit [105818] by
-
- 4 edits2 copies in branches/chromium/963
Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
clearRenderRegionRangeMap breakage fixed by replacing statements from https://trac.webkit.org/changeset/102234
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9113038
- 3:00 PM Changeset in webkit [105817] by
-
- 4 edits2 deletes in branches/chromium/963
Revert 105784 - Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9129033
TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9290001
- 2:54 PM Changeset in webkit [105816] by
-
- 3 edits in trunk/Source/JavaScriptCore
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665
Reviewed by Geoffrey Garen.
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
Also added a temporary variable to avoid warnings from GCC.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new. Also added a temporary variable to avoid warnings from GCC.
- runtime/JSObject.h:
- 2:52 PM Changeset in webkit [105815] by
-
- 4 edits in trunk/Source/WebCore
[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
https://bugs.webkit.org/show_bug.cgi?id=76944.
Reviewed by David Levin.
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieveWindowForCallingContext):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
- 2:39 PM Changeset in webkit [105814] by
-
- 3 edits in trunk/LayoutTests
Change reference of revokeObjectURL in worker-apply-blob-url-to-xhr.html to use webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=76942
Reviewed by Jian Li.
- fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(onmessage):
- platform/chromium/test_expectations.txt:
- 2:36 PM Changeset in webkit [105813] by
-
- 9 edits in trunk/Source/WebCore
Updated bindings test expectations after my last patch.
Not reviewed.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
- bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
(WebCore::jsTestOverridingNameGetterPrototypeFunctionAnotherFunction):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
- 2:36 PM Changeset in webkit [105812] by
-
- 3 edits in trunk/Source/WebCore
Change dispatchIntent API to pure virtual in FrameLoaderClient.
The Windows compiler needs this to deal with the forward declaration
of WebCore::IntentRequest.
https://bugs.webkit.org/show_bug.cgi?id=76940
Patch by Greg Billock <gbillock@google.com> on 2012-01-24
Reviewed by Adam Barth.
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
- loader/FrameLoaderClient.h:
- 2:31 PM Changeset in webkit [105811] by
-
- 3 edits2 adds in trunk
JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861
Source/JavaScriptCore:
Fixed two failing layout tests after my last patch.
Reviewed by Gavin Barraclough.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort): Call value() after calling toString(), as
in all other cases.
I missed this case because the JSString* type has a valid operator<,
so the compiler didn't complain.
LayoutTests:
Reviewed by Gavin Barraclough.
Added a unit test for something I got wrong while writing this patch.
- fast/js/add-to-primitive-expected.txt: Added.
- fast/js/add-to-primitive.html: Added.
- 2:25 PM Changeset in webkit [105810] by
-
- 3 edits2 copies in branches/chromium/963
Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9271030
- 2:24 PM Changeset in webkit [105809] by
-
- 2 edits in trunk/Source/WebCore
CodeGeneratorJS.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76922
Reviewed by Darin Adler.
This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorJS.pm so that
it overwrites the output .h/.cpp only if the bytes differ.
No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated JS*.h and JS*.cpp do not change.
- bindings/scripts/CodeGeneratorJS.pm:
(WriteData): Used UpdateFileIfChanged().
- 2:23 PM Changeset in webkit [105808] by
-
- 15 edits5 copies in branches/chromium/963
Merge 100473 - CSS 2.1 failure: border-collapse-offset-002.htm fails
BUG=109094
- 2:17 PM Changeset in webkit [105807] by
-
- 3 edits2 deletes in branches/chromium/963
Revert 105788 - Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9117049
TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271029
- 2:10 PM Changeset in webkit [105806] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=76928
Accelerated drawing should force compositing mode
-and corresponding-
<rdar://problem/10697417>
Reviewed by Simon Fraser.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 2:09 PM Changeset in webkit [105805] by
-
- 2 edits in trunk/Source/WebCore
CodeGeneratorCPP.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76926
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorCPP.pm so that
it overwrites the output .h/.cpp only if the bytes differ.
No tests. No change in behavior.
Manually confirm that when you add a new attribute to Element.idl,
the time-stamps of unrelated WebDOM*.h and WebDOM*.cpp do not change.
- bindings/scripts/CodeGeneratorCPP.pm:
(WriteData): Used UpdateFileIfChanged().
- 2:04 PM Changeset in webkit [105804] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r105238.
http://trac.webkit.org/changeset/105238
https://bugs.webkit.org/show_bug.cgi?id=76943
Remove the assert text hack as it served its purpose.
(Requested by dave_levin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24
- dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):
- 1:43 PM Changeset in webkit [105803] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] In CodeGeneratorGObject.pm, merge
GeneratePrivateHeader() into WriteData()
https://bugs.webkit.org/show_bug.cgi?id=76923
Reviewed by Adam Barth.
This patch merges GeneratePrivateHeader() into WriteData(),
so that all code to output .h/.cpp is managed by WriteData(),
just like other CodeGenerator*.pm does.
No tests. No change in behavior.
Confirm that GTK/GObject build passes.
- bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
(WriteData): Copied GeneratePrivateHeader() to here.
Removed $hasLegacyParen, $hasRealParent and $hasParent
since they are not used.
(GenerateInterface):
- 1:38 PM Changeset in webkit [105802] by
-
- 1 edit2 adds in trunk/LayoutTests
Add expected results for test introduced in http://trac.webkit.org/changeset/105769
- fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
- fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
- 1:38 PM Changeset in webkit [105801] by
-
- 3 edits in trunk/Tools
Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
https://bugs.webkit.org/show_bug.cgi?id=76884
Patch by James Robinson <jamesr@chromium.org> on 2012-01-24
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout.execute):
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
(SheriffIRCBotTest.test_rollout):
(SheriffIRCBotTest.test_revert):
(SheriffIRCBotTest.test_multi_rollout):
(SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):
- 1:32 PM Changeset in webkit [105800] by
-
- 4 edits in trunk
dropzone does not normalize type strings
https://bugs.webkit.org/show_bug.cgi?id=76925
Source/WebCore:
Per the HTML spec, we are supposed to normalize types during dropzone processing by
lowercasing them.
Reviewed by Tony Chang.
Tests: fast/events/dropzone-002.html
- dom/Clipboard.cpp:
(WebCore::Clipboard::hasDropZoneType):
LayoutTests:
Reviewed by Tony Chang.
- fast/events/dropzone-002.html: Update layout test to check case normalization as well.
- 1:31 PM Changeset in webkit [105799] by
-
- 1 edit4 adds in trunk/LayoutTests
Qt and Gtk results for tests added in r105775
Unreviewed.
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Added.
- platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
- platform/qt/fast/css/min-width-with-spanned-cell-expected.txt: Added.
- platform/qt/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
- 1:27 PM Changeset in webkit [105798] by
-
- 5 edits in branches/chromium/963/Source/WebCore/loader
Merge 105226 - Ensure we don't cancel revalidation of a CachedResource
in the middle of successful revalidation.
It's more reliable to enforce this in CachedResource than in
SubresourceLoader.
BUG=108544
Review URL: https://chromiumcodereview.appspot.com/9283038
- 1:27 PM Changeset in webkit [105797] by
-
- 4 edits in trunk/Tools
The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
https://bugs.webkit.org/show_bug.cgi?id=75531
Reviewed by David Kilzer.
Previously, the cpp parser of prepare-ChangeLog could not detect a change
outside methods. Consider the following cpp file.
namespace N {
int a; this change does not appear on ChangeLog.
class C {
int b; this change does not appear on ChangeLog.
void f()
{
int c; this change appears on ChangeLog.
}
int d; this change does not appear on ChangeLog.
};
int e; this change does not appear on ChangeLog.
};
The previous prepare-ChangeLog outputs just methods in which a change is found:
(N::C::f):
This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
and methods in which a change is found:
(N):
(N::C):
(N::C::f):
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp): Modified as described above.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
(Class104):
(Class105):
(Class106):
(Class106::func32):
(Class106::func33):
(NameSpace3):
(NameSpace4):
(NameSpace5):
(NameSpace6):
(Class107):
(NameSpace5::NameSpace6::Class107::func34):
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
- 1:24 PM Changeset in webkit [105796] by
-
- 3 edits in trunk/Tools
prepare-ChangeLog outputs warnings for top-level { ... } blocks
https://bugs.webkit.org/show_bug.cgi?id=75943
Reviewed by David Kilzer.
Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
because it does not distinguish '}' at the end of a subroutine
with '}' at the end of a if or for statement.
foo.pl:
if (1) {
}
for (@v) {
}
output:
nested functions found at top-level at foo.pl:2
nested functions found at top-level at foo.pl:4
This patch fixes the bug.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_perl):
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
Added test cases. No change in the test results.
- 1:23 PM Changeset in webkit [105795] by
-
- 1 edit2 copies in branches/chromium/963
Merge 105685 - Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
BUG=108918
Review URL: https://chromiumcodereview.appspot.com/9214019
- 1:22 PM Changeset in webkit [105794] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed: removing WebWorker.h again after r105684.
- WebKit.gyp:
- 1:20 PM Changeset in webkit [105793] by
-
- 2 edits in trunk/Tools
r105674 broke check-webkit-style for chromium's test_expectations.
Unreviewed, build fix.
We now need to pass in a platform name of 'chromium' if we want
the chromium port; options.chromium is no longer recognized. I
will follow this patch up with a separate patch that has a test,
but this at least fixes the build.
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_exepectations_path):
- 1:18 PM Changeset in webkit [105792] by
-
- 1 edit3 copies in branches/chromium/963
Merge 105769 - Crash when rendering -webkit-column-span.
BUG=105459
Review URL: https://chromiumcodereview.appspot.com/9129034
- 1:18 PM Changeset in webkit [105791] by
-
- 24 edits in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Don't expose functions for the ATK interfaces in header files.
Expose only the initialization function for each interface, and
use the generic functions from ATK interfaces where needed.
- accessibility/gtk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionDoAction): Made this function static.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
(webkitAccessibleActionInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceAction.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentRefAccessibleAtPoint): Made this function static.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.
(webkitAccessibleComponentInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentGetAttributeValue): Made this function static.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
(webkitAccessibleDocumentInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextSetRunAttributes): Made this function static.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.
(webkitAccessibleEditableTextInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp:
(webkitAccessibleHyperlinkImplGetHyperlink): Made this function static.
(webkitAccessibleHyperlinkImplInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink): Made this function static.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.
(webkitAccessibleHypertextInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition): Made this function static.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.
(webkitAccessibleImageInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceImage.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp:
(webkitAccessibleSelectionAddSelection): Made this function static.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.
(webkitAccessibleSelectionInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): Made this function static.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.
(webkitAccessibleTableInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceTable.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Made this function static.
(textForObject): Ditto.
(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.
(webkitAccessibleTextInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceText.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue): Made this function static.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
(webkitAccessibleValueInterfaceInit): Moved to the bottom.
- accessibility/gtk/WebKitAccessibleInterfaceValue.h: Removed all
functions but the one for initializing the interface from here.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName): Replace call to
webkitAccessibleTextGetText with atk_text_get_text.
- 1:12 PM Changeset in webkit [105790] by
-
- 1 edit2 copies in branches/chromium/963
Merge 105750 - Crash when accessing removed parent in InlineTextBox.
BUG=105157
Review URL: https://chromiumcodereview.appspot.com/9160034
- 1:09 PM Changeset in webkit [105789] by
-
- 5 edits in trunk/Tools
check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745
Patch by Ojan Vafai <ojan@chromium.org> on 2012-01-20
Reviewed by Dimitri Glazkov.
When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.
Also, got rid of the double-printing of errors when linting through check-webkit-style.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.lint):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
(test_error_on_different_platform):
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):
- 1:08 PM Changeset in webkit [105788] by
-
- 3 edits2 copies in branches/chromium/963
Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9117049
- 1:07 PM Changeset in webkit [105787] by
-
- 1 edit2 copies in branches/chromium/963
Merge 105524 - Crash in xsltParseGlobalVariable.
BUG=109716
Review URL: https://chromiumcodereview.appspot.com/9285028
- 1:00 PM Changeset in webkit [105786] by
-
- 1 edit2 copies in branches/chromium/963
Merge 104845 - REGRESSION(r104060): Setting user stylesheet may leave CSSStyleSelector with stale rule pointers
BUG=109743
Review URL: https://chromiumcodereview.appspot.com/9212063
- 12:57 PM Changeset in webkit [105785] by
-
- 1 edit3 copies in branches/chromium/963
Merge 105250 - Source/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
BUG=110112
Review URL: https://chromiumcodereview.appspot.com/9146052
- 12:55 PM Changeset in webkit [105784] by
-
- 4 edits2 copies in branches/chromium/963
Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9129033
- 12:51 PM Changeset in webkit [105783] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Add null check for ContentLayerChromium::m_delegate back to ContentLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76887
Reviewed by Dimitri Glazkov.
A ContentLayerChromium's m_delegate pointer is nulled out when its owning GraphicsLayerChromium is destroyed.
It's possible in some circumstances for this to happen during painting. The null check for this pointer was
erroneously removed from the base class TiledLayerChromium in r105460.
No new tests since we don't know how to reproduce this sort of layer mutation during paint (not for lack of
trying!). Fix based on crash reports from the field.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::drawsContent):
- platform/graphics/chromium/ContentLayerChromium.h:
- 12:51 PM Changeset in webkit [105782] by
-
- 2 edits2 copies in branches/chromium/963
Merge 105542 - Crash in RenderTable::borderBefore
BUG=108207
Review URL: https://chromiumcodereview.appspot.com/9212061
- 12:48 PM Changeset in webkit [105781] by
-
- 9 edits in branches/chromium/963
Merge 105612 - <feImage> has problems referencing local elements
BUG=110360
Review URL: https://chromiumcodereview.appspot.com/9117045
- 12:47 PM Changeset in webkit [105780] by
-
- 1 edit2 copies in branches/chromium/963
Merge 103650 - Fix crash when adding paragraph in contenteditable with role=textbox.
BUG=106671
Review URL: https://chromiumcodereview.appspot.com/9285027
- 12:43 PM Changeset in webkit [105779] by
-
- 1 edit in branches/chromium/963/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Merge 105423 - Layout Test fast/text/international/spaces-combined-in-vertical-text.html is failing
BUG=90105
Review URL: https://chromiumcodereview.appspot.com/9212060
- 12:42 PM Changeset in webkit [105778] by
-
- 2 edits2 adds in trunk/LayoutTests
Chromium Mac Lepoard overrides following the Chromium Mac Snow Leopard baselines.
- platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
- platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:
- 12:42 PM Changeset in webkit [105777] by
-
- 1 edit2 copies in branches/chromium/963
Merge 104322 - ASSERT failure due to combine-text with preceding spaces
BUG=90105
Review URL: https://chromiumcodereview.appspot.com/9284036
- 12:40 PM Changeset in webkit [105776] by
-
- 1 edit3 copies in branches/chromium/963
Merge 105212 - Crash in in WebCore::EventHandler::mouseMoved.
BUG=110374
Review URL: https://chromiumcodereview.appspot.com/9160033
- 12:32 PM Changeset in webkit [105775] by
-
- 9 edits6 adds in trunk
REGRESSION (r102040): Wrong column widths when row has colspan and unwrappable text
https://bugs.webkit.org/show_bug.cgi?id=74874
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/css/min-width-with-spanned-cell-fixed.html
fast/css/min-width-with-spanned-cell.html
A cell with unwrappable text must be as wide as the text is long. If it is a colspan in a table whose
columns are all percent and the width of the span cell is wider than the cells it spans in any other
row then it will squeeze those cells beyond the width required to display their contents.
To fix this ensure that the squeezing of cells within a span respects the minimum width determined by
their contents. The squeezing remains for fixed layout tables as per FF and Opera.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
LayoutTests:
- fast/css/min-width-with-spanned-cell-expected.png: Added.
- fast/css/min-width-with-spanned-cell-expected.txt: Added.
- fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
- fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
- fast/css/min-width-with-spanned-cell-fixed.html: Added.
- fast/css/min-width-with-spanned-cell.html: Added.
- platform/chromium-linux/fast/table/027-expected.png:
1 px difference - benign
- platform/chromium-linux/fast/table/027-vertical-expected.png:
This is a progression - previously the image in the last cell was
extruding from the table in a 800x600 view.
- platform/chromium-win/fast/table/027-expected.txt:
- platform/chromium-win/fast/table/027-vertical-expected.txt:
- platform/mac/test_expectations.txt: Suppress 027* tests for rebaseline.
- platform/win/test_expectations.txt: ditto
The 2 tests are skipped on gtk and qt.
- 12:29 PM Changeset in webkit [105774] by
-
- 22 edits in trunk/Source
MediaStream API: Split the MediaStream track list into audio/video specific ones.
https://bugs.webkit.org/show_bug.cgi?id=76614
Source/WebCore:
The latest draft of the WebRTC standard have split the MediaStream combined track list
into audio/video specific ones.
Reviewed by Darin Fisher.
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
- mediastream/LocalMediaStream.h:
- mediastream/MediaStream.cpp:
(WebCore::processTrackList):
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
- mediastream/MediaStream.h:
(WebCore::MediaStream::audioTracks):
(WebCore::MediaStream::videoTracks):
- mediastream/MediaStream.idl:
- mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::component):
- mediastream/MediaStreamTrack.h:
- mediastream/UserMediaClient.h:
- mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):
- mediastream/UserMediaRequest.h:
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
- platform/mediastream/MediaStreamCenter.h:
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::numberOfAudioComponents):
(WebCore::MediaStreamDescriptor::audioComponent):
(WebCore::MediaStreamDescriptor::numberOfVideoComponents):
(WebCore::MediaStreamDescriptor::videoComponent):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
Source/WebKit/chromium:
Reviewed by Darin Fisher.
- public/WebUserMediaClient.h:
(WebKit::WebUserMediaClient::requestUserMedia):
- public/WebUserMediaRequest.h:
- public/platform/WebMediaStreamDescriptor.h:
- src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
- src/UserMediaClientImpl.h:
- src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::sources):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):
(WebKit::WebMediaStreamDescriptor::initialize):
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::requestSucceeded):
- 12:27 PM Changeset in webkit [105773] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r105738.
http://trac.webkit.org/changeset/105738
https://bugs.webkit.org/show_bug.cgi?id=76930
caused fast/css/getComputedStyle/computed-style-border-
image.html to crash (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24
- dom/NamedNodeMap.cpp:
- dom/NamedNodeMap.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::style):
(WebCore::StyledElement::addSubresourceAttributeURLs):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
- 12:24 PM Changeset in webkit [105772] by
-
- 4 edits2 adds in trunk
REGRESSION (r73385): Marquee with behavior="alternate" is not working
https://bugs.webkit.org/show_bug.cgi?id=64230
Patch by Parag Radke <nrqv63@motorola.com> on 2012-01-24
Reviewed by Simon Fraser.
Source/WebCore:
This patch gives correct content width for marquee, which computes
correct start position to scroll marquee.
Test: fast/html/marquee-alternate.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
We need(style()->marqueeBehavior() != MALTERNATE) check as we always need the marquee's
actual content width to compute the initial/end position in case of 'MALTERNATE'.
So we need to calculate the logical width in Alternate case even if fixed width is specified
as content has to animate between renderBox().right().x() - contentWidth() and
renderBox().left().x() + contentWidth().
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
Using PreferredLogicalWidth in place of LayoutOverflow for calculating correct content width.
LayoutTests:
Added a test case to check marquee alternate behavior with fixed width.
- fast/html/marquee-alternate-expected.txt: Added.
- fast/html/marquee-alternate.html: Added.
- 12:22 PM Changeset in webkit [105771] by
-
- 4 edits in trunk/Source/WebCore
RenderInline: Skip caching the computed line height.
<http://webkit.org/b/76929>
Reviewed by David Hyatt.
Stop caching the computed line height on RenderInline and make retrieving it from
RenderStyle slightly cheaper, freeing up 4 bytes per RenderInline instance.
This appears to be mostly performance neutral, I don't get more than the occasional
sample hit when instrumenting heavier web pages.
This reduces memory consumption by 228 kB (both 32/64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::lineHeight):
- rendering/RenderInline.h:
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::computedLineHeight):
Optimize computedLineHeight() to mitigate some of the damage of calling
it more often.
- 12:10 PM Changeset in webkit [105770] by
-
- 6 edits in trunk/Tools
check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745
Reviewed by Dimitri Glazkov.
When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.
Also, got rid of the double-printing of errors when linting through check-webkit-style.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.lint):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
(test_error_on_different_platform):
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):
- 12:04 PM Changeset in webkit [105769] by
-
- 3 edits5 adds in trunk
Crash when rendering -webkit-column-span.
https://bugs.webkit.org/show_bug.cgi?id=73265
Reviewed by David Hyatt.
Source/WebCore:
This patch addresses 2 problems causing crashes in multi-column layout
- Trying to render -webkit-column-span for :before, :after caused re-entrancy in updateBeforeAfterContent while working on splitFlow.
- Cloning a block which has its :before, :after content not added yet, caused issues because cloneBlock will definitely have its :before, :after content created when setStyle() is called. So, we would overwrite cloneBlock with a wrong childrenInline value.
Tests: fast/multicol/clone-block-children-inline-mismatch-crash.html
fast/multicol/span/generated-child-split-flow-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::columnsBlockForSpanningElement):
LayoutTests:
- fast/multicol/clone-block-children-inline-mismatch-crash-expected.txt: Added.
- fast/multicol/clone-block-children-inline-mismatch-crash.html: Added.
- fast/multicol/span/generated-child-split-flow-crash.html: Added.
- platform/mac-snowleopard/fast/multicol/span: Added.
- platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
- 11:52 AM Changeset in webkit [105768] by
-
- 5 edits2 adds in trunk
Incorrect positioning of floating pseudo-elements in table captions
https://bugs.webkit.org/show_bug.cgi?id=76664
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/table/caption-encloses-overhanging-float-expected.html
fast/table/caption-encloses-overhanging-float.html
Allow table captions to expand and enclose overhanging floats. When performing
layout on a caption ensure that its logical top is set so that it does not mistakenly
conclude that floats in a previous sibling are intruding into it when they're not.
Mostly diagnosed by Abhishek Arya.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats): add table captions to the list
that can enclosed overhanging floats.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layoutCaption): use the best available approximation of the caption's logical
top offset before laying it out.
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
LayoutTests:
- fast/table/caption-encloses-overhanging-float-expected.html: Added.
- fast/table/caption-encloses-overhanging-float.html: Added.
- 11:43 AM Changeset in webkit [105767] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Merged r105556.
- 11:40 AM Changeset in webkit [105766] by
-
- 2 edits in trunk/Source/WebCore
In CodeGeneratorV8.pm, overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76920
Reviewed by Darin Adler.
This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorV8.pm so that
it overwrites the output .h/.cpp only if the bytes differ.
No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated V8*.h and V8*.cpp do not change.
- bindings/scripts/CodeGeneratorV8.pm:
(WriteData): Used UpdateFileIfChanged().
- 11:39 AM Changeset in webkit [105765] by
-
- 2 edits7 adds6 deletes in trunk/LayoutTests
Similar to the change below, this patch creates Chromium Mac specific
baselines after the Apple Mac changes in
http://trac.webkit.org/changeset/105753.
- fast/block/positioning/028-expected.txt: Added.
- fast/block/positioning/031-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/positioning/028-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/positioning/031-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
- platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
- platform/gtk/fast/block/positioning/028-expected.txt: Removed.
- platform/gtk/fast/block/positioning/031-expected.txt: Removed.
- platform/mac/fast/block/positioning/028-expected.txt: Removed.
- platform/mac/fast/block/positioning/031-expected.txt: Removed.
- platform/qt/fast/block/positioning/028-expected.txt: Removed.
- platform/qt/fast/block/positioning/031-expected.txt: Removed.
- 11:35 AM Changeset in webkit [105764] by
-
- 6 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merged r105638.
- 11:28 AM Changeset in webkit [105763] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit2
Merged r105558.
- 11:26 AM Changeset in webkit [105762] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for Qt.
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
- 11:25 AM Changeset in webkit [105761] by
-
- 7 edits in trunk/Source/WebCore
[Refactoring] Remove finish() from all CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=76918
Reviewed by Darin Adler.
Now finish() is empty in all CodeGenerator*.pm. This patch removes them.
No tests. No change in behavior.
- bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- 11:07 AM Changeset in webkit [105760] by
-
- 2 edits in trunk/Source/WebKit/mac
pageCacheSupportsPlugins should default to true on WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76891
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-24
Reviewed by Joseph Pecoraro.
The default was left out of r102619 by accident.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- 11:01 AM Changeset in webkit [105759] by
-
- 2 edits in trunk/Tools
Another build fix attempt after r105543.
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_as_multipart_form_data):
- 10:55 AM Changeset in webkit [105758] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: incorrect highlight position when searching in console
https://bugs.webkit.org/show_bug.cgi?id=76837
Reviewed by Yury Semikhatsky.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.clearHighlight):
(WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults):
(WebInspector.ConsoleMessageImpl.prototype._highlightSearchResultsInElement):
(WebInspector.ConsoleMessageImpl.prototype.matchesRegex):
- 10:54 AM Changeset in webkit [105757] by
-
- 20 edits in trunk/Source
Show layer borders for scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=76888
Source/WebCore:
Reviewed by Beth Dakin.
When compositing layer borders are showing, show the borders
for scrollbars layers. This reduces confusion about whether scrollbars
are rendering into their own layers.
Requires a new parameter to two GraphicsLayerClient methods.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::showDebugBorders):
(WebCore::GraphicsLayer::showRepaintCounter):
- platform/graphics/GraphicsLayerClient.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::showDebugBorders):
(WebCore::RenderLayerBacking::showRepaintCounter):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::showDebugBorders):
(WebCore::RenderLayerCompositor::showRepaintCounter):
- rendering/RenderLayerCompositor.h:
Source/WebKit/chromium:
Reviewed by Beth Dakin.
Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):
- src/NonCompositedContentHost.h:
- src/PageOverlay.cpp:
(WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders):
(WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
Source/WebKit/win:
Reviewed by Beth Dakin.
Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().
- WebView.cpp:
(WebView::showDebugBorders):
(WebView::showRepaintCounter):
- WebView.h:
Source/WebKit2:
Reviewed by Beth Dakin.
Update for new signatures of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().
- UIProcess/LayerTreeHostProxy.h:
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::showDebugBorders):
(WebKit::LayerTreeHostCA::showRepaintCounter):
- WebProcess/WebPage/ca/LayerTreeHostCA.h:
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
- 10:51 AM Changeset in webkit [105756] by
-
- 5 edits in trunk/Source
[windows] Convert usage of GetDC to HWndDC Part 3.
https://bugs.webkit.org/show_bug.cgi?id=76889
Reviewed by Adam Roben.
Source/WebCore:
No new functionality so no new tests.
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem): Simple replacement.
(WebCore::UniscribeController::shape): Use the delayed allocation.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint): Fix a dc leak and use the dellayed allocation.
Source/WebKit2:
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::paint): Fix a dc leak and use the dellayed allocation.
- 10:49 AM Changeset in webkit [105755] by
-
- 1 edit4 adds1 delete in trunk/LayoutTests
Update Chromium-specific baselines that used to use Apple Mac results
before http://trac.webkit.org/changeset/105744.
- platform/chromium-mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Added.
- platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.
- 10:48 AM Changeset in webkit [105754] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Fix coding style in the ATK AccessibilityObject wrapper.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
(webkitAccessibleGetParent):
(webkitAccessibleGetNChildren):
(webkitAccessibleRefChild):
(webkitAccessibleGetIndexInParent):
(webkitAccessibleGetAttributes):
(atkRole):
(webkitAccessibleGetRole):
(setAtkStateSetFromCoreObject):
(webkitAccessibleRefStateSet):
(webkitAccessibleRefRelationSet):
(webkitAccessibleInit):
(webkitAccessibleFinalize):
(webkit_accessible_class_init):
- 10:41 AM Changeset in webkit [105753] by
-
- 16 edits365 adds in trunk/LayoutTests
Update Snow Leopard image test expectations
https://bugs.webkit.org/show_bug.cgi?id=76869
Rubber stamped by Simon Fraser.
Addingmore SnowLeopard image expectations for tests failing due to subtle differences in rendering
between SnowLeopard and Lion. Also fixing those that hadn't been updated to the new mock scrollbars.
- platform/mac-snowleopard/css3/filters: Added.
- platform/mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
- platform/mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
- platform/mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-custom-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-custom-parameters-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
- platform/mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
- platform/mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
- platform/mac-snowleopard/css3/filters/filter-region-expected.png: Added.
- platform/mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
- platform/mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
- platform/mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
- platform/mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
- platform/mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
- platform/mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
- platform/mac-snowleopard/css3/images: Added.
- platform/mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
- platform/mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
- platform/mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
- platform/mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
- platform/mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
- platform/mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3: Added.
- platform/mac-snowleopard/css3/selectors3/html: Added.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39b-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39c-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xhtml: Added.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39a-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39b-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39c-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xml: Added.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Added.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Added.
- platform/mac-snowleopard/editing/inserting: Added.
- platform/mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
- platform/mac-snowleopard/editing/pasteboard: Added.
- platform/mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
- platform/mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
- platform/mac-snowleopard/editing/selection: Added.
- platform/mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
- platform/mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content: Added.
- platform/mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/list-type-after-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/list-type-before-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds: Added.
- platform/mac-snowleopard/fast/backgrounds/repeat: Added.
- platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds/size: Added.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/mac-snowleopard/fast/block/basic: Added.
- platform/mac-snowleopard/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/mac-snowleopard/fast/block/float: Added.
- platform/mac-snowleopard/fast/block/float/020-expected.png: Added.
- platform/mac-snowleopard/fast/block/float/float-avoidance-expected.png: Added.
- platform/mac-snowleopard/fast/block/margin-collapse/103-expected.png:
- platform/mac-snowleopard/fast/block/positioning: Added.
- platform/mac-snowleopard/fast/block/positioning/028-expected.png: Added.
- platform/mac-snowleopard/fast/block/positioning/031-expected.png: Added.
- platform/mac-snowleopard/fast/borders: Added.
- platform/mac-snowleopard/fast/borders/border-image-massive-scale-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-scale-transform-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-scaled-expected.png: Added.
- platform/mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/mac-snowleopard/fast/borders/inline-mask-overlay-image-expected.png: Added.
- platform/mac-snowleopard/fast/borders/rtl-border-01-expected.png: Added.
- platform/mac-snowleopard/fast/borders/rtl-border-02-expected.png: Added.
- platform/mac-snowleopard/fast/borders/rtl-border-03-expected.png: Added.
- platform/mac-snowleopard/fast/canvas: Added.
- platform/mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/mac-snowleopard/fast/canvas/canvas-incremental-repaint-expected.png: Added.
- platform/mac-snowleopard/fast/canvas/shadow-offset-7-expected.png: Added.
- platform/mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
- platform/mac-snowleopard/fast/css/background-shorthand-invalid-url-expected.png: Added.
- platform/mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
- platform/mac-snowleopard/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
- platform/mac-snowleopard/fast/css/color-correction-on-background-image-expected.png: Added.
- platform/mac-snowleopard/fast/css/continuationCrash-expected.png: Added.
- platform/mac-snowleopard/fast/css/font-family-pictograph-expected.png: Added.
- platform/mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
- platform/mac-snowleopard/fast/css/outline-narrowLine-expected.png: Added.
- platform/mac-snowleopard/fast/css/text-overflow-input-expected.png: Added.
- platform/mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
- platform/mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
- platform/mac-snowleopard/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
- platform/mac-snowleopard/fast/dom/52776-expected.png:
- platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
- platform/mac-snowleopard/fast/encoding: Added.
- platform/mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Added.
- platform/mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Added.
- platform/mac-snowleopard/fast/forms/basic-textareas-expected.png:
- platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac-snowleopard/fast/forms/fieldset-align-expected.png:
- platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
- platform/mac-snowleopard/fast/forms/form-hides-table-expected.png:
- platform/mac-snowleopard/fast/forms/input-table-expected.png:
- platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
- platform/mac-snowleopard/fast/forms/textAreaLineHeight-expected.png:
- platform/mac-snowleopard/fast/forms/textarea-scroll-height-expected.png:
- platform/mac-snowleopard/fast/gradients: Added.
- platform/mac-snowleopard/fast/gradients/crash-on-zero-radius-expected.png: Added.
- platform/mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
- platform/mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
- platform/mac-snowleopard/fast/gradients/gradient-after-transparent-border-expected.png: Added.
- platform/mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
- platform/mac-snowleopard/fast/images: Added.
- platform/mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
- platform/mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
- platform/mac-snowleopard/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
- platform/mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
- platform/mac-snowleopard/fast/images/pdf-as-background-expected.png: Added.
- platform/mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
- platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
- platform/mac-snowleopard/fast/inline: Added.
- platform/mac-snowleopard/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
- platform/mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/mac-snowleopard/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
- platform/mac-snowleopard/fast/lists: Added.
- platform/mac-snowleopard/fast/lists/003-expected.png: Added.
- platform/mac-snowleopard/fast/media: Added.
- platform/mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/column-rules-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/column-rules-stacking-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/float-avoidance-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/float-multicol-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/layers-in-multicol-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/nested-columns-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/overflow-across-columns-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/positive-leading-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/scrolling-overflow-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/single-line-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span: Added.
- platform/mac-snowleopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
- platform/mac-snowleopard/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
- platform/mac-snowleopard/fast/overflow/006-expected.png: Added.
- platform/mac-snowleopard/fast/overflow/overflow-focus-ring-expected.png: Added.
- platform/mac-snowleopard/fast/overflow/overflow-x-y-expected.png:
- platform/mac-snowleopard/fast/parser: Added.
- platform/mac-snowleopard/fast/parser/document-write-option-expected.png: Added.
- platform/mac-snowleopard/fast/reflections: Added.
- platform/mac-snowleopard/fast/reflections/reflection-direction-expected.png: Added.
- platform/mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
- platform/mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
- platform/mac-snowleopard/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/text-shadow-expected.png: Added.
- platform/mac-snowleopard/fast/repaint/text-shadow-horizontal-expected.png: Added.
- platform/mac-snowleopard/fast/replaced: Added.
- platform/mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/mac-snowleopard/fast/replaced/width100percent-button-expected.png: Added.
- platform/mac-snowleopard/fast/ruby: Added.
- platform/mac-snowleopard/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
- platform/mac-snowleopard/fast/selectors: Added.
- platform/mac-snowleopard/fast/selectors/166-expected.png: Added.
- platform/mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
- platform/mac-snowleopard/fast/table: Added.
- platform/mac-snowleopard/fast/table/auto-100-percent-width-expected.png: Added.
- platform/mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
- platform/mac-snowleopard/fast/table/frame-and-rules-expected.png: Added.
- platform/mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
- platform/mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
- platform/mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
- platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png:
- platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.png: Added.
- platform/mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
- platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
- platform/mac-snowleopard/fast/text/hyphens-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/bidi-menulist-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png:
- platform/mac-snowleopard/fast/text/international/hebrew-vowels-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
- platform/mac-snowleopard/fast/text/midword-break-after-breakable-char-expected.png: Added.
- platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
- platform/mac-snowleopard/fast/text/stroking-decorations-expected.png: Added.
- platform/mac-snowleopard/fast/text/stroking-expected.png: Added.
- platform/mac-snowleopard/fast/text/text-letter-spacing-expected.png: Added.
- platform/mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
- platform/mac-snowleopard/fast/text/wbr-expected.png: Added.
- platform/mac-snowleopard/fast/text/whitespace: Added.
- platform/mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
- platform/mac-snowleopard/fast/writing-mode: Added.
- platform/mac-snowleopard/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
- platform/mac-snowleopard/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
- platform/mac-snowleopard/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
- platform/mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Added.
- platform/mac-snowleopard/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
- platform/mac-snowleopard/fonts: Added.
- platform/mac-snowleopard/fonts/cursive-expected.png: Added.
- platform/mac-snowleopard/fonts/default-expected.png: Added.
- platform/mac-snowleopard/fonts/fantasy-expected.png: Added.
- platform/mac-snowleopard/fonts/monospace-expected.png: Added.
- platform/mac-snowleopard/fonts/sans-serif-expected.png: Added.
- platform/mac-snowleopard/fonts/serif-expected.png: Added.
- platform/mac-snowleopard/fullscreen: Added.
- platform/mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
- platform/mac-snowleopard/http/tests/media: Added.
- platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
- platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
- platform/mac-snowleopard/http/tests/security: Added.
- platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Added.
- platform/mac-snowleopard/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
- platform/mac-snowleopard/media/controls-layout-direction-expected.png: Added.
- platform/mac-snowleopard/media/controls-without-preload-expected.txt: Added.
- platform/mac-snowleopard/media/media-document-audio-repaint-expected.png: Added.
- platform/mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
- platform/mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
- platform/mac-snowleopard/media/video-colorspace-yuv420-expected.png: Added.
- platform/mac-snowleopard/media/video-colorspace-yuv422-expected.png: Added.
- platform/mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
- platform/mac-snowleopard/media/video-layer-crash-expected.png:
- platform/mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
- platform/mac-snowleopard/media/video-zoom-expected.png: Added.
- platform/mac-snowleopard/platform/mac/editing: Added.
- platform/mac-snowleopard/platform/mac/editing/selection: Added.
- platform/mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
- platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
- platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
- platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
- platform/mac-snowleopard/platform/mac/scrollbars: Added.
- platform/mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
- platform/mac-snowleopard/plugins: Added.
- platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
- platform/mac-snowleopard/printing: Added.
- platform/mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
- platform/mac-snowleopard/printing/media-queries-print-expected.png: Added.
- platform/mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
- platform/mac-snowleopard/printing/return-from-printing-mode-expected.png: Added.
- platform/mac-snowleopard/scrollbars: Added.
- platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
- platform/mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Added.
- platform/mac-snowleopard/tables: Added.
- platform/mac-snowleopard/tables/mozilla: Added.
- platform/mac-snowleopard/tables/mozilla/bugs: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug10269-2-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug1055-1-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2479-1-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug3977-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug5835-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug7112-1-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/bugs/bug7112-2-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/collapsing_borders: Added.
- platform/mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core: Added.
- platform/mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/cell_heights-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_fix-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/nested1-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/one_row-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_index-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/other: Added.
- platform/mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/other/nestedTables-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/other/test3-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/other/test6-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
- platform/mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
- platform/mac-snowleopard/transforms: Added.
- platform/mac-snowleopard/transforms/2d: Added.
- platform/mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
- platform/mac-snowleopard/transforms/2d/transform-fixed-container-expected.png: Added.
- platform/mac-snowleopard/transforms/3d: Added.
- platform/mac-snowleopard/transforms/3d/general: Added.
- platform/mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
- platform/mac-snowleopard/transforms/3d/point-mapping: Added.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
- platform/mac-snowleopard/webarchive: Added.
- platform/mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
- platform/mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
- platform/mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
- 10:37 AM Changeset in webkit [105752] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Cleanup the list of includes in WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Removes
'include' lines that are no longer needed after the refactor.
- 10:34 AM Changeset in webkit [105751] by
-
- 2 edits1 delete in trunk/Source/WebCore
[EFL] Remove CookieJarEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=76916
Reviewed by Gustavo Noronha Silva.
CookieJarEfl.cpp has not been used for years -- we either need
CookieJarCurl or CookieJarSoup depending on the chosen network
backend.
No new tests, just an unused file being removed.
- WebCore.gypi: Remove reference to CookieJarEfl.cpp.
- platform/efl/CookieJarEfl.cpp: Removed.
- 10:33 AM Changeset in webkit [105750] by
-
- 3 edits2 adds in trunk
Crash when accessing removed parent in InlineTextBox.
https://bugs.webkit.org/show_bug.cgi?id=72982
Reviewed by James Robinson.
Source/WebCore:
The crash happens because:
- We add heading element(h1) before the span element(span1), causing splitflow on the anonymous block containing BeforeText, span1(and SpanText) and AfterText.
- span1 moves to the cloneBlock (continuation).
- Our anonymous block and cloneBlock are both marked for layout, however we still have a copy of our lineboxes with its childs as the textboxes belonging to SpanText.
- Our anonymous block only child BeforeText is getting removed, so we dont have any children anymore and we delete our lineboxes, leaving behind the children textboxes belonging to SpanText.
- SpanText is getting destroyed, so it tries to inform removed parent lineboxes causing the crash.
Test: fast/block/block-remove-child-delete-line-box-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
LayoutTests:
Tests passes if it does not crash on ASSERT(!m_hasBadParent)
in InlineBox::parent().
- fast/block/block-remove-child-delete-line-box-crash-expected.txt: Added.
- fast/block/block-remove-child-delete-line-box-crash.html: Added.
- 10:28 AM Changeset in webkit [105749] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkTable interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceTable.cpp: Added.
(core):
(cell):
(cellIndex):
(cellAtIndex):
(webkitAccessibleTableInterfaceInit):
(webkitAccessibleTableRefAt):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
(webkitAccessibleTableGetCaption):
(webkitAccessibleTableGetColumnDescription):
(webkitAccessibleTableGetRowDescription):
- accessibility/gtk/WebKitAccessibleInterfaceTable.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkTable interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceTable.[h|cpp].
- WebCore.gypi: Ditto.
- 10:25 AM Changeset in webkit [105748] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Scripts panel tabbed editor container should have gray background when there are no open tabs.
https://bugs.webkit.org/show_bug.cgi?id=76903
Reviewed by Yury Semikhatsky.
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._updateTabElements):
- inspector/front-end/tabbedPane.css:
(.tabbed-pane-content.has-no-tabs):
- 10:22 AM Changeset in webkit [105747] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: OpenResourceDialog should work when there are no open tabs in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=76907
Reviewed by Yury Semikhatsky.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.install):
- inspector/front-end/ScriptsPanel.js:
- 10:03 AM Changeset in webkit [105746] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] [GTK] TestDownloads hitting an assertion in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=76915
Reviewed by Martin Robinson.
No new tests required as it fixes some assertions in a unit test.
- WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
- 10:02 AM Changeset in webkit [105745] by
-
- 6 edits2 adds in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
https://bugs.webkit.org/show_bug.cgi?id=76868
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
Reviewed by Yury Semikhatsky.
Configurations of (hopefully) all build systems are fixed.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.py:
(dash_to_camelcase):
(InspectorFrontend_h):
(InspectorBackendDispatcher_h):
- 9:57 AM Changeset in webkit [105744] by
-
- 3 edits203 adds in trunk/LayoutTests
Update Snow Leopard image test expectations
https://bugs.webkit.org/show_bug.cgi?id=76869
Reviewed by Simon Fraser.
Adding SnowLeopard image expectations for tests failing due to subtle differences in rendering
between SnowLeopard and Lion. Also fixing those that hadn't been updated to the new mock scrollbars.
- platform/mac-snowleopard/animations: Added.
- platform/mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
- platform/mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
- platform/mac-snowleopard/animations/suspend-transform-animation-expected.png: Added.
- platform/mac-snowleopard/compositing/color-matching: Added.
- platform/mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
- platform/mac-snowleopard/compositing/flat-with-transformed-child-expected.png: Added.
- platform/mac-snowleopard/compositing/framesets: Added.
- platform/mac-snowleopard/compositing/framesets/composited-frame-alignment-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry: Added.
- platform/mac-snowleopard/compositing/geometry/clipping-foreground-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/composited-html-size-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/fixed-in-composited-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/foreground-layer-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/repaint-foreground-layer-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/root-layer-update-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
- platform/mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
- platform/mac-snowleopard/compositing/iframes: Added.
- platform/mac-snowleopard/compositing/iframes/composited-iframe-scroll-expected.png: Added.
- platform/mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Added.
- platform/mac-snowleopard/compositing/images: Added.
- platform/mac-snowleopard/compositing/images/content-image-change-expected.png: Added.
- platform/mac-snowleopard/compositing/images/direct-image-background-color-expected.png: Added.
- platform/mac-snowleopard/compositing/images/direct-pdf-image-expected.png: Added.
- platform/mac-snowleopard/compositing/images/direct-svg-image-expected.png: Added.
- platform/mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
- platform/mac-snowleopard/compositing/masks: Added.
- platform/mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
- platform/mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
- platform/mac-snowleopard/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/mac-snowleopard/compositing/overflow: Added.
- platform/mac-snowleopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
- platform/mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/mac-snowleopard/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/mac-snowleopard/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/mac-snowleopard/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
- platform/mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections: Added.
- platform/mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-opacity-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/reflection-opacity-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/remove-add-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png: Added.
- platform/mac-snowleopard/compositing/repaint: Added.
- platform/mac-snowleopard/compositing/repaint/same-size-invalidation-expected.png: Added.
- platform/mac-snowleopard/compositing/scaling: Added.
- platform/mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/mac-snowleopard/compositing/scrollbar-painting-expected.png: Added.
- platform/mac-snowleopard/compositing/self-painting-layers-expected.png: Added.
- platform/mac-snowleopard/compositing/shadows: Added.
- platform/mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/mac-snowleopard/compositing/tiling: Added.
- platform/mac-snowleopard/compositing/tiling/constrained-layer-size-expected.png: Added.
- platform/mac-snowleopard/compositing/transitions: Added.
- platform/mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/mac-snowleopard/compositing/video: Added.
- platform/mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
- platform/mac-snowleopard/compositing/visibility: Added.
- platform/mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Added.
- platform/mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
- platform/mac-snowleopard/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
- platform/mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
- platform/mac-snowleopard/compositing/webgl: Added.
- platform/mac-snowleopard/compositing/webgl/webgl-background-color-expected.png: Added.
- platform/mac-snowleopard/compositing/webgl/webgl-no-alpha-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties: Added.
- platform/mac-snowleopard/css1/box_properties/border_bottom-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/border_left-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/border_right_inline-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/margin_inline-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/margin_left-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/margin_right-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/padding_bottom_inline-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/padding_inline-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/padding_left-expected.png: Added.
- platform/mac-snowleopard/css1/box_properties/padding_right-expected.png: Added.
- platform/mac-snowleopard/css1/cascade: Added.
- platform/mac-snowleopard/css1/cascade/important-expected.png: Added.
- platform/mac-snowleopard/css1/classification: Added.
- platform/mac-snowleopard/css1/classification/display-expected.png: Added.
- platform/mac-snowleopard/css1/color_and_background: Added.
- platform/mac-snowleopard/css1/color_and_background/background_image-expected.png: Added.
- platform/mac-snowleopard/css1/color_and_background/background_position-expected.png: Added.
- platform/mac-snowleopard/css1/color_and_background/background_repeat-expected.png: Added.
- platform/mac-snowleopard/css1/font_properties/font-expected.png:
- platform/mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
- platform/mac-snowleopard/css1/formatting_model: Added.
- platform/mac-snowleopard/css1/formatting_model/inline_elements-expected.png: Added.
- platform/mac-snowleopard/css1/pseudo: Added.
- platform/mac-snowleopard/css1/pseudo/firstletter-expected.png: Added.
- platform/mac-snowleopard/css1/pseudo/firstline-expected.png: Added.
- platform/mac-snowleopard/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
- platform/mac-snowleopard/css1/pseudo/pseudo_elements_in_selectors-expected.png: Added.
- platform/mac-snowleopard/css1/text_properties: Added.
- platform/mac-snowleopard/css1/text_properties/text_decoration-expected.png: Added.
- platform/mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
- platform/mac-snowleopard/css1/units: Added.
- platform/mac-snowleopard/css1/units/urls-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/block-replaced-height-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/block-replaced-width-006-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
- platform/mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-height-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-002-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-004-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-005-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-011-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/height-width-table-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-002-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-003-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-004-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-005-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-006-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-007-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-008-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-009-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-010-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-012-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-013-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-014-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-015-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
- platform/mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/width-replaced-element-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/t051201-c23-first-line-00-b-expected.png: Added.
- platform/mac-snowleopard/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
- platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png:
- platform/mac-snowleopard/css2.1/t1508-c527-font-01-b-expected.png: Added.
- 9:46 AM Changeset in webkit [105743] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
https://bugs.webkit.org/show_bug.cgi?id=76868
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
Reviewed by Yury Semikhatsky.
Configurations of (hopefully) all build systems are fixed.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.py:
(dash_to_camelcase):
(InspectorFrontend_h):
(InspectorBackendDispatcher_h):
- 8:59 AM Changeset in webkit [105742] by
-
- 23 edits1 copy25 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing tests and add/update platform specific expected files for them.
- platform/qt/Skipped:
- platform/qt/dom/xhtml/level3/core/canonicalform08-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/canonicalform08-expected.txt:
- platform/qt/dom/xhtml/level3/core/canonicalform09-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/canonicalform09-expected.txt:
- platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
- platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
- platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
- platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
- platform/qt/editing/pasteboard/paste-noscript-expected.png: Added.
- platform/qt/editing/pasteboard/paste-noscript-expected.txt: Added.
- platform/qt/editing/style/style-3681552-fix-001-expected.png: Added.
- platform/qt/editing/style/style-3681552-fix-001-expected.txt:
- platform/qt/editing/style/style-3681552-fix-002-expected.png: Added.
- platform/qt/editing/style/style-3681552-fix-002-expected.txt: Copied from LayoutTests/platform/qt/editing/style/typing-style-002-expected.txt.
- platform/qt/editing/style/style-boundary-002-expected.png: Added.
- platform/qt/editing/style/style-boundary-002-expected.txt:
- platform/qt/editing/style/style-boundary-003-expected.png: Added.
- platform/qt/editing/style/style-boundary-003-expected.txt:
- platform/qt/editing/style/style-boundary-005-expected.png: Added.
- platform/qt/editing/style/style-boundary-005-expected.txt:
- platform/qt/editing/style/typing-style-001-expected.png: Added.
- platform/qt/editing/style/typing-style-001-expected.txt:
- platform/qt/editing/style/typing-style-002-expected.png: Added.
- platform/qt/editing/style/typing-style-002-expected.txt:
- platform/qt/fast/css/text-overflow-input-expected.png: Added.
- 8:58 AM Changeset in webkit [105741] by
-
- 2 edits in trunk/Tools
Build fix attempt after r105543.
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_as_multipart_form_data):
- 8:22 AM Changeset in webkit [105740] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkValue interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceValue.cpp: Added.
(core):
(webkitAccessibleValueInterfaceInit):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
- accessibility/gtk/WebKitAccessibleInterfaceValue.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkValue interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceValue.[h|cpp].
- WebCore.gypi: Ditto.
- 8:09 AM Changeset in webkit [105739] by
-
- 13 edits in trunk/Source/WebCore
Reduce internal use of CSSStyleDeclaration base class
https://bugs.webkit.org/show_bug.cgi?id=76904
Reviewed by Andreas Kling.
Internally WebCore should use the more specific CSSMutableStyleDeclaration and CSSComputedStyleDeclaration types.
The CSSStyleDeclaration base should be used in the DOM API functions only. This will make it easier to separate
internal style sheet implementation from the DOM in the future.
- Switch CSSStyleDeclaration -> CSSMutableStyleDeclaration where feasible
- Use StyledElement::ensureInlineStyleDecl() instead of Element::style() (which is a DOM API function)
- Remove Attribute::style() which looks like a DOM API function but is not exposed.
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
- dom/Attr.h:
(WebCore::Attr::style):
- dom/Attribute.h:
- editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
- editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
- page/PageSerializer.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 7:42 AM Changeset in webkit [105738] by
-
- 5 edits in trunk/Source/WebCore
Make elements that don't have attributes smaller.
<http://webkit.org/b/76876>
Reviewed by Antti Koivisto.
Move the inline style declaration from StyledElement to NamedNodeMap, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.
This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
(WebCore::NamedNodeMap::createInlineStyleDecl):
- dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::inlineStyleDecl):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::addSubresourceAttributeURLs):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
- 7:17 AM Changeset in webkit [105737] by
-
- 13 edits in trunk/Source
[Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
https://bugs.webkit.org/show_bug.cgi?id=76877
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add BitmapTexture::updateRawContents(), which allows uploading image data to a texture
without changing its format or swizzling RGB. The data has to be in the texture's native
format.
No new tests, this affects performance on all existing tests.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateRawContents):
- platform/graphics/qt/TextureMapperQt.cpp:
- platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::updateRawContents):
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
- platform/graphics/texmap/TextureMapperNode.h:
Source/WebKit2:
Instead of copying QImages, pass a reference to the ShareableBitmap that was originally
created by the web process. Also, swizzle the image's RGB in the web process, before it's
transferred to the UI process.
Data flow before change:
(Web Process) Render to image -> IPC -> (UI Process) Copy (render queue) -> Copy Swizzled RGB -> Upload
Data flow after change:
(Web Process) Render to image -> swizzle RGB -> IPC -> (UI Process) -> Upload
- Shared/ShareableBitmap.h:
- Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::swizzleRGB):
- UIProcess/LayerTreeHostProxy.h:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
- 6:53 AM Changeset in webkit [105736] by
-
- 2 edits in trunk/Tools
Unreviewed, skip WK2 API test timing out on some GTK bots.
WebKit2APITests/TestDownloads is consistently timing out on the
32bit release and 64bit debug bots.
- Scripts/run-gtk-tests:
(TestRunner): Skip WebKit2APITests/TestDownloads.
- 6:35 AM Changeset in webkit [105735] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: inspector/debugger/dom-breakpoints.html started to fail after r105642
https://bugs.webkit.org/show_bug.cgi?id=76908
Reviewed by Yury Semikhatsky.
- css/CSSMutableStyleDeclaration.cpp:
- 5:58 AM Changeset in webkit [105734] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846
Reviewed by Tor Arne Vestbø.
- bindings/scripts/CodeGeneratorJS.pm: Warning fix after r105683.
(WriteData):
- 5:32 AM Changeset in webkit [105733] by
-
- 4 edits in trunk
[Qt] Fix the build with the newes Qt5 hashes
https://bugs.webkit.org/show_bug.cgi?id=76657
Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-01-24
Reviewed by Simon Hausmann.
Source/WebCore:
No new tests needed.
- platform/graphics/cairo/OpenGLShims.cpp:
(WebCore::getProcAddress): Adopt API changes.
Tools:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
- 5:30 AM Changeset in webkit [105732] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] QtWebIconDatabaseClient leaves a dangling pointer on WebIconDatabase after its destruction
https://bugs.webkit.org/show_bug.cgi?id=76399
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-24
Reviewed by Simon Hausmann.
Due a circular dependency between WebContext and WebProcessProxy, WebContext it not
being destroyed, neither WebIconDatabase. As QtWebIconDatabaseClient's life time is the same
as QtWebContext and this one is being destroyed, the remaining reference to our client
on WebIconDatabase should be cleaned upon its destruction.
- UIProcess/qt/QtWebIconDatabaseClient.cpp:
(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::~QtWebIconDatabaseClient): Clear client pointer on WebIconDatabase.
- UIProcess/qt/QtWebIconDatabaseClient.h: Make this client hold a reference to WebIconDatabase.
- 5:28 AM Changeset in webkit [105731] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Incremental build problem.
https://bugs.webkit.org/show_bug.cgi?id=74687
It is necessary to set mathattrs.in dependency for generating MathMLNames.cpp file.
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-01-24
Reviewed by Csaba Osztrogonác.
- DerivedSources.pri:
I added missing depend.
- 4:55 AM Changeset in webkit [105730] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectation
- platform/chromium/test_expectations.txt:
perf/adding-radio-buttons.html is TEXT on Mac.
- 4:31 AM Changeset in webkit [105729] by
-
- 2 edits in trunk/Tools
[Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
building with MinGW inside cmd.exe will require the same construct. Instead
we assume that when the first character in PWD is a '/' we're running under
Cygwin, and use the normal unix way of setting environment variables.
Reviewed by Simon Hausmann.
- 4:28 AM Changeset in webkit [105728] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933
Add a test that checks handling of url strings.
Add a test that verifies replies in case of multiple
available application url schemes.
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
- 4:25 AM Changeset in webkit [105727] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkSelection interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp: Added.
(core):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkitAccessibleSelectionInterfaceInit):
(webkitAccessibleSelectionAddSelection):
(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionRefSelection):
(webkitAccessibleSelectionGetSelectionCount):
(webkitAccessibleSelectionIsChildSelected):
(webkitAccessibleSelectionRemoveSelection):
(webkitAccessibleSelectionSelectAllSelection):
- accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkSelection interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceSelection.[h|cpp].
- WebCore.gypi: Ditto.
- 4:04 AM Changeset in webkit [105726] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkImage interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceImage.cpp: Added.
(core):
(webkitAccessibleImageInterfaceInit):
(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageDescription):
(webkitAccessibleImageGetImageSize):
- accessibility/gtk/WebKitAccessibleInterfaceImage.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkImage interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceImage.[h|cpp].
- WebCore.gypi: Ditto.
- 3:58 AM Changeset in webkit [105725] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkHypertext interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp: Added.
(core):
(webkitAccessibleHypertextInterfaceInit):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
- accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkHypertext interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceHypertext.[h|cpp].
- WebCore.gypi: Ditto.
- 3:55 AM Changeset in webkit [105724] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkHyperlinkImpl interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp: Added.
(webkitAccessibleHyperlinkImplInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
- accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkHyperlinkImpl interface.
(webkit_accessible_class_init):
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceHyperlinkImpl.[h|cpp].
- WebCore.gypi: Ditto.
- 3:49 AM Changeset in webkit [105723] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Fix /webkit2/WebKitWebView/reload after r105688
https://bugs.webkit.org/show_bug.cgi?id=76898
Reviewed by Alejandro G. Castro.
- UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::reload): Add reload method that clears events
and initializes progress.
- UIProcess/API/gtk/tests/LoadTrackingTest.h:
- UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testWebViewReload): Use LoadTrackingTest::reload() instead of
webkit_web_view_reload().
- 3:47 AM Changeset in webkit [105722] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkEditableText interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp: Added.
(core):
(webkitAccessibleEditableTextInterfaceInit):
(webkitAccessibleEditableTextSetRunAttributes):
(webkitAccessibleEditableTextSetTextContents):
(webkitAccessibleEditableTextInsertText):
(webkitAccessibleEditableTextCopyText):
(webkitAccessibleEditableTextCutText):
(webkitAccessibleEditableTextDeleteText):
(webkitAccessibleEditableTextPasteText):
- accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkEditableText interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceEditableText.[h|cpp].
- WebCore.gypi: Ditto.
- 3:40 AM Changeset in webkit [105721] by
-
- 6 edits1 copy1 add in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkDocument interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp: Added.
(core):
(documentAttributeValue):
(webkitAccessibleDocumentInterfaceInit):
(webkitAccessibleDocumentGetAttributeValue):
(webkitAccessibleDocumentGetAttributes):
(webkitAccessibleDocumentGetLocale):
- accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Added.
Move common function addAttributeToSet() out from the wrapper to
the utility file, used from WebKitAccessibleInterfaceDocument.cpp.
- accessibility/gtk/WebKitAccessibleUtil.cpp:
(addToAtkAttributeSet): Taken from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleUtil.h:
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove local
implementation of addAttributeToSet, as well as all the code related
to the implementation of the AtkDocument interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceDocument.[h|cpp].
- WebCore.gypi: Ditto.
- 3:29 AM Changeset in webkit [105720] by
-
- 7 edits in trunk/Source/WebKit/chromium
[Chromium] Add WebKit API for Pointer Lock
https://bugs.webkit.org/show_bug.cgi?id=76410
Reviewed by Darin Fisher.
Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
into a series of patches, this stubs out the API.
- public/WebWidget.h:
(WebKit::WebWidget::didCompletePointerLock):
(WebKit::WebWidget::didNotCompletePointerLock):
(WebKit::WebWidget::didLosePointerLock):
- public/WebWidgetClient.h:
(WebKit::WebWidgetClient::requestPointerLock):
(WebKit::WebWidgetClient::requestPointerUnlock):
(WebKit::WebWidgetClient::isPointerLocked):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::requestPointerLock):
(WebKit::ChromeClientImpl::requestPointerUnlock):
(WebKit::ChromeClientImpl::isPointerLocked):
- src/ChromeClientImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::didCompletePointerLock):
(WebKit::WebViewImpl::didNotCompletePointerLock):
(WebKit::WebViewImpl::didLosePointerLock):
(WebKit::WebViewImpl::requestPointerLock):
(WebKit::WebViewImpl::requestPointerUnlock):
(WebKit::WebViewImpl::isPointerLocked):
(WebKit::WebViewImpl::pointerLockMouseEvent):
- src/WebViewImpl.h:
- 3:22 AM Changeset in webkit [105719] by
-
- 7 edits in trunk
Some qmake build files must include Qt5's "quick" module.
https://bugs.webkit.org/show_bug.cgi?id=76671
Unreviewed build fix.
.:
- Source/api.pri:
Source/WebKit2:
- UIProcess/API/qt/tests/tests.pri:
Tools:
- MiniBrowser/qt/MiniBrowser.pro:
- WebKitTestRunner/Target.pri:
- 3:19 AM Changeset in webkit [105718] by
-
- 2 edits in trunk/Tools
[Qt] Fix the event timestamps for touch mocking
Reviewed by Simon Hausmann.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
- 3:05 AM Changeset in webkit [105717] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectation
- platform/chromium/test_expectations.txt:
perf/adding-radio-buttons.html is MISSING on buildbots.
- 3:03 AM Changeset in webkit [105716] by
-
- 6 edits1 copy1 add in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkComponent interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp: Added.
(core):
(atkToContents):
(webkitAccessibleComponentInterfaceInit):
(webkitAccessibleComponentRefAccessibleAtPoint):
(webkitAccessibleComponentGetExtents):
(webkitAccessibleComponentGrabFocus):
- accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Added.
Move common function contentsToAtk() out from the wrapper to the
utility file, used from WebKitAccessibleInterfaceComponent.cpp.
- accessibility/gtk/WebKitAccessibleUtil.cpp:
(contentsRelativeToAtkCoordinateType): Taken from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleUtil.h:
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove local
implementation of contentsToAtk, as well as all the code related
to the implementation of the AtkComponent interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceComponent.[h|cpp].
- WebCore.gypi: Ditto.
- 2:51 AM Changeset in webkit [105715] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip new failing tests to paint the bots green.
- platform/qt-5.0/Skipped:
- platform/qt/Skipped:
- 2:32 AM Changeset in webkit [105714] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Makes finish() of CodeGeneratorV8.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76841
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
As refactoring, we are planning to remove finish() from
all CodeGenerators. This patch makes finish() of
CodeGeneratorV8.pm empty.
No new tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(finish): Made it empty. We will remove finish() after
making finish() of all CodeGenerators empty.
(GenerateInterface): Modified to call WriteData().
(WriteData): Simple code refactoring.
Removed if(defined $IMPL).
Removed if(defined $HEADER).
$IMPL -> IMPL.
$HEADER -> HEADER.
- 2:17 AM Changeset in webkit [105713] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for GTK after r105698.
- bindings/js/JSPeerConnectionCustom.cpp:
(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):
- 2:12 AM Changeset in webkit [105712] by
-
- 2 edits in trunk/Source/WebCore
Fix build erros on Mac by r105706.
https://bugs.webkit.org/show_bug.cgi?id=76763
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compressedTexImage2D): Removed unused argument names.
(WebCore::WebGLRenderingContext::compressedTexSubImage2D): ditto.
- 2:03 AM Changeset in webkit [105711] by
-
- 15 edits1 copy in trunk/Source/WebKit2
[Qt][WK2] Application URL schemes cause asserts when using debug.
https://bugs.webkit.org/show_bug.cgi?id=76700
Instances of QtNetworkRequestData / QtNetworkReplyData are meant
to be used for transfering data over IPC. To allow transferring
instances of these classes over IPC they need to be copyable,
and it must be possible to create such instances on the stack.
Because classes that inherit from RefCounted always need to be
used in connection with RefPtr, QtNetworkRequestData and
QtNetworkReplyData cannot inherit directly from RefCounted.
Deleting an object that inherits from RefCounted, without
the proper sequence of ref()/deref() being called by it's
RefPtr, causes asserts when running a debug version.
Reviewed by Simon Hausmann.
- Shared/qt/QtNetworkReplyData.h:
(WebKit::QtRefCountedNetworkReplyData::data):
- Shared/qt/QtNetworkRequestData.cpp:
(WebKit::QtRefCountedNetworkRequestData::QtRefCountedNetworkRequestData):
- Shared/qt/QtNetworkRequestData.h:
(WebKit::QtRefCountedNetworkRequestData::data):
- Target.pri:
- UIProcess/API/qt/qquicknetworkreply.cpp:
(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::contentType):
(QQuickNetworkReply::setContentType):
(QQuickNetworkReply::operation):
(QQuickNetworkReply::setOperation):
(QQuickNetworkReply::contentDisposition):
(QQuickNetworkReply::setContentDisposition):
(QQuickNetworkReply::location):
(QQuickNetworkReply::setLocation):
(QQuickNetworkReply::lastModified):
(QQuickNetworkReply::setLastModified):
(QQuickNetworkReply::cookie):
(QQuickNetworkReply::setCookie):
(QQuickNetworkReply::userAgent):
(QQuickNetworkReply::setUserAgent):
(QQuickNetworkReply::server):
(QQuickNetworkReply::setServer):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
(QQuickNetworkReply::networkRequestData):
(QQuickNetworkReply::setNetworkRequestData):
(QQuickNetworkReply::networkReplyData):
- UIProcess/API/qt/qquicknetworkreply_p.h:
- UIProcess/API/qt/qquicknetworkrequest.cpp:
(QQuickNetworkRequest::QQuickNetworkRequest):
(QQuickNetworkRequest::setNetworkRequestData):
(QQuickNetworkRequest::url):
- UIProcess/API/qt/qquicknetworkrequest_p.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::invokeApplicationSchemeHandler):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/WebPageProxy.h:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleApplicationSchemeRequest):
- UIProcess/qt/QtPageClient.h:
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):
- WebProcess/qt/QtNetworkReply.cpp:
(WebKit::QtNetworkReply::setData):
(WebKit::QtNetworkReply::readData):
- 2:02 AM Changeset in webkit [105710] by
-
- 15 edits4 adds in trunk
Introduce RadioButtonGroup class to keep track of the group members and required state
https://bugs.webkit.org/show_bug.cgi?id=74909
Reviewed by Darin Adler.
Source/WebCore:
RadioButtonGroup contains a set of member radio buttons in the group,
and "required" status of the group. This helps implementing correct
radio button validity, and improving performance of updating validity
status of radio buttons.
This change fixes the following bugs:
- A radio button should be "required" if one of a member of the same group has the "required" attribute. https://bugs.webkit.org/show_bug.cgi?id=76365
- :invalid style is not applied when a checked radio button is removed from its radio group https://bugs.webkit.org/show_bug.cgi?id=74914
- Loading a page with N radio buttons in a group takes O(N2) time.
Tests: fast/forms/radio/radio-live-validation-style.html
perf/adding-radio-buttons.html
- dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::isEmpty):
(WebCore::RadioButtonGroup::isRequired):
(WebCore::RadioButtonGroup::checkedButton):
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::create):
(WebCore::RadioButtonGroup::isValid):
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::setNeedsValidityCheckForAllButtons):
Add RadioButtonGroup class. It keeps track of pointers to member radio
buttons and required status of the group in addition to the checked
radio button pointer.
(WebCore::CheckedRadioButtons::CheckedRadioButtons):
(WebCore::CheckedRadioButtons::~CheckedRadioButtons):
Define empty constructor and destructor in order to avoid exposing
RadioButtonGroup class.
(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::updateCheckedState):
(WebCore::CheckedRadioButtons::requiredAttributeChanged):
(WebCore::CheckedRadioButtons::checkedButtonForGroup):
(WebCore::CheckedRadioButtons::isInRequiredGroup):
(WebCore::CheckedRadioButtons::removeButton):
Change the HashMap member of this class so that it maps a group name to
a RadioButtonGroup object. These functions just get a RadioButtonGroup
object and call a corresponding member function of RadioButtonGroup.
- dom/CheckedRadioButtons.h: Update declarations.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::requiredAttributeChanged):
Move a part of parseMappedAttribute() into requiredAttributeChanged().
- html/HTMLFormControlElement.h: Add requiredAttributeChanged().
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::valueMissing):
Move required check code to InputType::valueMissing implementations.
RadioInputType needs special handling for checking required state.
readOnly() and disabled() are unnecessary because willValidate() checks them.
(WebCore::HTMLInputElement::setChecked):
Call new function CheckedRadioButtons::updateCheckedState() instead of
removeButton() and updateCheckedRadioButtons().
(WebCore::HTMLInputElement::requiredAttributeChanged):
Override this to call CheckedRadioButtons::requiredAttributeChanged().
- html/HTMLInputElement.h: Add requiredAttributeChanged().
- html/RadioInputType.cpp:
(WebCore::RadioInputType::valueMissing):
Check required state by CheckedRadioButtons::isInRequiredGroup().
- html/RadioInputType.h: Remove attach().
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::valueMissing):
Move required check from HTMLInputElement::valueMissing().
- html/FileInputType.cpp:
(WebCore::FileInputType::valueMissing): ditto.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::valueMissing): ditto.
LayoutTests:
- fast/forms/radio/radio-live-validation-style-expected.txt: Added.
- fast/forms/radio/radio-live-validation-style.html: Added.
- fast/forms/script-tests/ValidityState-valueMissing-radio.js:
- Update the expectation for the behavior change of https://bugs.webkit.org/show_bug.cgi?id=76365
- Add test cases for radio buttons not in a radio button group.
- fast/forms/ValidityState-valueMissing-radio-expected.txt: ditto.
- perf/adding-radio-buttons-expected.txt: Added.
- perf/adding-radio-buttons.html: Added.
- 1:56 AM Changeset in webkit [105709] by
-
- 4 edits4 adds in trunk
[chromium] PNG image with CMYK ICC color profile renders color-inverted and squashed
https://bugs.webkit.org/show_bug.cgi?id=76804
Reviewed by Adam Barth.
Source/WebCore:
Use color profiles for PNG images only if their embedded color profile is from an RGB
color space input device.
Test: fast/images/rgb-png-with-cmyk-color-profile.html
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::rgbColorProfile): Return true if the profile has an RGB color space.
(WebCore::ImageDecoder::inputDeviceColorProfile): Return true if the profile is from an input device.
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::readColorProfile): Ignore PNG image embedded color profile unless the profile
comes from an RGB color space input device.
(WebCore::PNGImageDecoder::headerAvailable): Minor white-space removals courtesy Xcode.
LayoutTests:
- fast/images/resources/rgb-png-with-cmyk-color-profile.png: Added.
- fast/images/rgb-png-with-cmyk-color-profile-expected.txt: Added.
- fast/images/rgb-png-with-cmyk-color-profile.html: Added.
- platform/mac/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
- 1:45 AM Changeset in webkit [105708] by
-
- 11 edits3 adds in trunk
[GTK] Implement DownloadClient in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72952
Reviewed by Martin Robinson.
Source/WebKit2:
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitDownloadClient.cpp: Added.
(didStart): Call webkitWebContextDownloadStarted().
(didReceiveResponse): Call webkitDownloadSetResponse() with the
received response.
(didReceiveData): Call webkitDownloadNotifyProgress().
(decideDestinationWithSuggestedFilename): Call
webkitDownloadDecideDestinationWithSuggestedFilename().
(didCreateDestination): Call webkitDownloadDestinationCreated().
(didFail): Call webkitDownloadFailed() or
webkitDownloadCancelled() if the download was cancelled before
failing.
(didCancel): Call webkitDownloadCancelled().
(didFinish): Call webkitDownloadFinished().
(attachDownloadClientToContext): Add
implementation for download client callbacks.
- UIProcess/API/gtk/WebKitDownloadClient.h: Added.
- UIProcess/API/gtk/WebKitError.cpp:
(webkit_download_error_quark): Add quark for download errors.
- UIProcess/API/gtk/WebKitError.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_class_init): Add download-started signal.
(createDefaultWebContext): Initialize the download client.
(downloadsMap): HashMap containing download objects for all
ongoing download operations.
(webkit_web_context_download_uri): Start a new download for the
given URI.
(webkitWebContextGetOrCreateDownload): Helper function to create a
new download object or return the existing one from the downloads map.
(webkitWebContextRemoveDownload): Remove the download object from
the downloads map.
(webkitWebContextDownloadStarted): Emit
WebKitWebContext::download-started for the given download object.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/GNUmakefile.am: Add new test for downloads.
- UIProcess/API/gtk/tests/TestDownloads.cpp: Added.
(getWebKit1TestResoucesDir):
(testDownloadLocalFile):
(testDownloadLocalFileError):
(serverCallback):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(beforeAll):
(afterAll):
Tools:
- gtk/generate-gtkdoc:
(get_webkit2_options): Ignore WebKitDownloadClient.
- 1:25 AM Changeset in webkit [105707] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix sticky DOM breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=64437
Reviewed by Yury Semikhatsky.
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
- 1:19 AM Changeset in webkit [105706] by
-
- 5 edits2 adds in trunk
Expose WebGL texture compression methods on WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=76763
Patch by Gregg Tavares <gman@google.com> on 2012-01-24
Reviewed by Kenneth Russell.
Source/WebCore:
Test: fast/canvas/webgl/compressed-tex-image.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
LayoutTests:
- fast/canvas/webgl/compressed-tex-image-expected.txt: Added.
- fast/canvas/webgl/compressed-tex-image.html: Added.
- 12:54 AM Changeset in webkit [105705] by
-
- 13 edits1 add1 delete in trunk
[V8] Add Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=76803
Reviewed by Kenneth Russell.
Source/JavaScriptCore:
- wtf/ArrayBufferView.h:
(WTF::ArrayBufferView::isUnsignedByteClampedArray): Added.
- wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::isUnsignedByteClampedArray): Overridden to return true.
Source/WebCore:
No new tests. fast/js/script-tests/dfg-uint8clampedarray.js should pass on chromium port.
- WebCore.gypi: Added required files.
- bindings/scripts/CodeGeneratorV8.pm:
(IsTypedArrayType): Added Uint8ClampedArray.
- bindings/v8/SerializedScriptValue.cpp: Added the tag for Uint8ClampedArray.
(WebCore::V8ObjectMap::Writer::writeArrayBufferView): Appends the tag when buffer is Uint8ClampedArray.
(WebCore::V8ObjectMap::Reader::readArrayBufferView): Creates Uint8ClampedArray instance when the tag represents Uint8ClampedArray.
- bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Added.
(WebCore::V8Uint8ClampedArray::constructorCallback):
(WebCore::V8Uint8ClampedArray::setCallback):
(WebCore::toV8):
- page/Crypto.cpp: Added isUnsignedByteClampedArray() call to isIntegerArray().
- page/DOMWindow.idl: Removed ifdefs.
- workers/WorkerContext.idl: Added Uint8ArrayConstructor.
LayoutTests:
- platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt: Removed.
- platform/chromium/test_expectations.txt: Removed fast/js/dfg-uint8clampedarray.html.
- 12:49 AM Changeset in webkit [105704] by
-
- 13 edits3 adds in trunk/Source
[GTK] Add WebKitDownload to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72949
Reviewed by Martin Robinson.
Source/JavaScriptCore:
- wtf/gobject/GOwnPtr.cpp:
(WTF::GTimer): Use g_timer_destroy() to free a GTimer.
- wtf/gobject/GOwnPtr.h: Add GTimer template.
- wtf/gobject/GTypedefs.h: Add GTimer forward declaration.
Source/WebKit2:
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitDownload.cpp: Added.
(webkitDownloadFinalize):
(webkitDownloadGetProperty):
(webkitDownloadDecideDestination):
(webkit_download_init):
(webkit_download_class_init):
(webkitDownloadCreate): Create a new WebKitDownload for a given
WKDownloadRef.
(webkitDownloadSetResponse): Set the network response of the
download.
(webkitDownloadIsCancelled): Whether the download has been
cancelled by the user.
(webkitDownloadNotifyProgress): Emit notify::estimated-progress if
needed.
(webkitDownloadFailed): Emit WebKitDownload::failed with the given
error.
(webkitDownloadCancelled): Emit WebKitDownload::failed with
cancelled error.
(webkitDownloadFinished): Emit WebKitDownload::finished.
(webkitDownloadDecideDestinationWithSuggestedFilename): Emit
WebKitDownload::decide-destination.
(webkitDownloadDestinationCreated): Emit
WebKitDownload::created-destination.
(webkit_download_get_destination): Return the destination URI of
the download.
(webkit_download_set_destination): Set the destination URI of the
download.
(webkit_download_get_response): Return the response received by
the server.
(webkit_download_cancel): Cancel the download.
(webkit_download_get_estimated_progress): Return the estimated
progress.
(webkit_download_get_elapsed_time): Return the time elapsed since
the download started.
- UIProcess/API/gtk/WebKitDownload.h: Added.
- UIProcess/API/gtk/WebKitDownloadPrivate.h: Added.
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitURIResponse.cpp:
(webkitURIResponseGetResourceResponse):
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_download_get_type().
- UIProcess/API/gtk/webkit2.h: Include WebKitDownload.h.
- UIProcess/API/gtk/webkit2marshal.list:
- 12:35 AM Changeset in webkit [105703] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for GTK Debug build after r105698.
- bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::webkitGetUserMedia):
- 12:26 AM Changeset in webkit [105702] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Qt LinuxSH4 build after r105698.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
Jan 23, 2012:
- 11:47 PM Changeset in webkit [105701] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] http/tests/navigation/anchor-frames-gbk.html fails
https://bugs.webkit.org/show_bug.cgi?id=76896
- platform/qt-wk2/Skipped: Skip the failing test.
- 11:38 PM Changeset in webkit [105700] by
-
- 2 edits in trunk/Source/WebCore
Avoid spurious rebuilds on vs2010 due to DerivedSources not existing
https://bugs.webkit.org/show_bug.cgi?id=76873
Patch by Scott Graham <scottmg@chromium.org> on 2012-01-23
Reviewed by Adam Barth.
- WebCore.gyp/WebCore.gyp:
- 11:37 PM Changeset in webkit [105699] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r105647.
- platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png: Added.
- platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
- 11:34 PM Changeset in webkit [105698] by
-
- 93 edits in trunk/Source
JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861
Reviewed by Gavin Barraclough.
This makes the common case -- toString() on a string -- faster and
inline-able. (Not a measureable speedup, but we can now remove a bunch
of duplicate hand-rolled code for this optimization.)
This also clarifies the boundary between "C++ strings" and "JS strings".
In all cases other than true, false, null, undefined, and multi-digit
numbers, the JS runtime was just retrieving a UString from a JSString,
so returning a JSString* is strictly better. In the other cases, we can
optimize to avoid creating a new JSString if we care to, but it doesn't
seem to be a big deal.
- JavaScriptCore.exp: Export!
- jsc.cpp:
(functionPrint):
(functionDebug):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):
- API/JSValueRef.cpp:
(JSValueToStringCopy):
- bytecode/CodeBlock.cpp:
(JSC::valueToSourceString): Call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- dfg/DFGOperations.cpp:
(JSC::DFG::operationValueAddNotNumber):
- jit/JITStubs.cpp:
(op_add): Updated for removal of toPrimitiveString():
all '+' operands can use toString(), except for object operands, which
need to take a slow path to call toPrimitive().
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
- runtime/DateConstructor.cpp:
(JSC::dateParse):
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Call value() after calling toString(), as above.
- runtime/ErrorInstance.h:
(JSC::ErrorInstance::create): Simplified down to one canonical create()
function, to make string handling easier.
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp:
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
- runtime/JSArray.cpp:
(JSC::JSArray::sort): Call value() after calling toString(), as above.
- runtime/JSCell.cpp:
- runtime/JSCell.h: Removed JSCell::toString() because JSValue does this
job now. Doing it in JSCell is slower (requires extra type checking), and
creates the misimpression that language-defined toString() behavior is
an implementation detail of JSCell.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape): Call value() after calling toString(), as above.
- runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::Stringifier):
(JSC::JSONProtoFuncParse): Removed some manual optimization that toString()
takes care of.
- runtime/JSObject.cpp:
(JSC::JSObject::toString):
- runtime/JSObject.h: Updated to return JSString*.
- runtime/JSString.cpp:
- runtime/JSString.h:
(JSC::JSValue::toString): Removed, since I removed JSCell::toString().
- runtime/JSValue.cpp:
(JSC::JSValue::toStringSlowCase): Removed toPrimitiveString(), and re-
spawned toStringSlowCase() from its zombie corpse, since toPrimitiveString()
basically did what we want all the time. (Note that the toPrimitive()
preference changes from NoPreference to PreferString, because that's
how ToString is defined in the language. op_add does not want this behavior.)
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString): A little simpler, now that toString()
returns a JSString*.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable): More calls to value(), as above.
- runtime/Operations.cpp:
(JSC::jsAddSlowCase): Need to check for object before taking the toString()
fast path becuase adding an object to a string requires calling toPrimitive()
on the object, not toString(). (They differ in their preferred conversion
type.)
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsStringFromArguments): This code gets simpler, now that toString()
does the right thing.
(JSC::jsAdd): Now checks for object, just like jsAddSlowCase().
- runtime/RegExpConstructor.cpp:
(JSC::setRegExpConstructorInput):
(JSC::constructRegExp):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString): More calls to value(), as above.
- runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
(JSC::callStringConstructor): This code gets simpler, now that toString()
does the right thing.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString): Some of this code gets simpler, now that toString()
does the right thing. More calls to value(), as above.
../JavaScriptGlue:
Reviewed by Gavin Barraclough.
- JSUtils.cpp:
(KJSValueToCFTypeInternal):
../WebCore:
Reviewed by Gavin Barraclough.
Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMBinding.cpp:
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::JSDOMFormData::append):
- bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::putDelegate):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::documentWrite):
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange):
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPort):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::putDelegate):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getExtension):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
(WebCore::JSWebSocket::send):
(WebCore::JSWebSocket::close):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::importScripts):
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::send):
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
- bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::toString):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateEventListenerCall):
(JSValueToNative):
(GenerateConstructorDefinition):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
- bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
- bridge/jni/jsc/JavaFieldJSC.cpp:
(JavaField::dispatchValueFromInstance):
(JavaField::valueFromInstance):
(JavaField::dispatchSetValueToInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- testing/js/JSInternalsCustom.cpp:
(WebCore::JSInternals::setUserPreferredLanguages):
../WebKit/mac:
Reviewed by Gavin Barraclough.
Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
../WebKit2:
Reviewed by Gavin Barraclough.
Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
- 11:09 PM Changeset in webkit [105697] by
-
- 3 edits in trunk/Source/WebCore
In CodeGeneratorObjC.pm, overwrite the output .h/.mm
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76874
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp/.mm files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorObjC.pm so that
it overwrites the output .h/.mm only if the bytes differ.
No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated DOM*.h and DOM*.mm do not change.
- bindings/scripts/CodeGenerator.pm:
(UpdateFileIfChanged): Added. This method writes data to a file
only if the data is different from the data in the current file.
- bindings/scripts/CodeGeneratorObjC.pm:
(WriteData): Used UpdateFileIfChanged().
- 10:46 PM Changeset in webkit [105696] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23
- DEPS:
- 10:43 PM Changeset in webkit [105695] by
-
- 7 edits10 adds in trunk
REGRESSION: Downloaded file name fallback encodings are not set correctly
https://bugs.webkit.org/show_bug.cgi?id=76862
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/download/default-encoding.html
http/tests/download/form-submission-result.html
http/tests/download/inherited-encoding.html
http/tests/download/literal-utf-8.html
- loader/DocumentWriter.cpp:
- loader/DocumentWriter.h:
Removed deprecatedFrameEncoding. Due to changes in Document::encoding behavior, it can now
be used in its place.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Instead of hunting
down a correct loader (and active one is not always correct any more), just use opening document's
encoding.
LayoutTests:
- http/tests/download/default-encoding-expected.txt: Added.
- http/tests/download/default-encoding.html: Added.
- http/tests/download/inherited-encoding-expected.txt: Added.
- http/tests/download/inherited-encoding.html: Added.
- http/tests/download/literal-utf-8-expected.txt: Added.
- http/tests/download/literal-utf-8.html: Added.
- http/tests/download/resources/literal-koi8-r.php: Added.
- http/tests/download/resources/literal-utf-8.php: Added.
- http/tests/download/inherited-encoding-form-submission-result-expected.txt: Added.
- http/tests/download/inherited-encoding-form-submission-result.html: Added.
- 10:26 PM Changeset in webkit [105694] by
-
- 10 edits in trunk
Implement flex-pack:distribute
https://bugs.webkit.org/show_bug.cgi?id=76864
Reviewed by Tony Chang.
Source/WebCore:
See http://dev.w3.org/csswg/css3-flexbox/#flex-pack.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
- css/CSSValueKeywords.in:
- rendering/RenderFlexibleBox.cpp:
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/004-expected.txt:
- css3/flexbox/004.html:
- 9:44 PM Changeset in webkit [105693] by
-
- 5 edits in trunk/Source/WebCore
Implement CSS clip property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74913
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSPrimitiveValue.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
This new function aims to provide a single call for converting many CSSPrimitiveValue
values to Lengths. It is templated to allow the caller to specify which conversions
are appropriate depending on the context in which the value is used.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 9:19 PM Changeset in webkit [105692] by
-
- 2 edits2 copies in branches/chromium/963
Merge 105386 - REGRESSION(r100111): A 'change' event does not fire when a mouse drag
occurs to switch elements in a listbox <select>
https://bugs.webkit.org/show_bug.cgi?id=76244
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/select/listbox-drag-in-non-multiple.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateSelectedState):
Do not update m_activeSelectionState for non-multiple <select>.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Use setActiveSelection*Index() and updateListBoxSelection(true) instead
of updateSelectedState() because updateSelectedState() updates
m_lastOnChangeSelection and will prevent the mouseup handler from
dispatching 'change' event.
We should not call listBoxOnChange() in the mousemove handler in order
to align the behavior of IE and Firefox.
LayoutTests:
- fast/forms/resources/common.js:
(mouseMoveToIndexInListbox): Added.
- fast/forms/select/listbox-drag-in-non-multiple-expected.txt: Added.
- fast/forms/select/listbox-drag-in-non-multiple.html: Added.
TBR=tkent@chromium.org
BUG=crbug.com/110068
Review URL: https://chromiumcodereview.appspot.com/9285007
- 9:08 PM Changeset in webkit [105691] by
-
- 5 edits15 adds in trunk
decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...).
https://bugs.webkit.org/show_bug.cgi?id=71316
Reviewed by Daniel Bates.
Source/WebCore:
Pass trailing unescaped bytes into the character set decoder to get correct
results in the presence of encodings which re-use ASCII values in sequences.
Tests: http/tests/navigation/anchor-frames-gbk.html
http/tests/security/xssAuditor/iframe-onload-GBK-char.html
http/tests/security/xssAuditor/img-onerror-GBK-char.html
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html
http/tests/security/xssAuditor/script-tag-Big5-char.html
http/tests/security/xssAuditor/script-tag-Big5-char2.html
- platform/text/DecodeEscapeSequences.h:
(WebCore::Unicode16BitEscapeSequence::findInString):
(WebCore::Unicode16BitEscapeSequence::findEndOfRun):
(WebCore::Unicode16BitEscapeSequence::decodeRun):
(WebCore::URLEscapeSequence::findInString):
(WebCore::URLEscapeSequence::findEndOfRun):
(WebCore::URLEscapeSequence::decodeRun):
(WebCore::decodeEscapeSequences):
LayoutTests:
- http/tests/navigation/anchor-frames-gbk-expected.txt: Added.
- http/tests/navigation/anchor-frames-gbk.html: Added.
- http/tests/navigation/resources/frame-with-anchor-gbk.html: Added.
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-onload-GBK-char.html: Added.
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-GBK-char.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char.html: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char2.html: Added.
- platform/chromium/test_expectations.txt:
- 9:04 PM Changeset in webkit [105690] by
-
- 2 edits in trunk/Source/WebCore
Fix a build break in a clean compile of the Chromium port (at least
reported by tbreisacher).
- css/CSSStyleDeclaration.cpp:
- 8:53 PM Changeset in webkit [105689] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] QQuickWebView is initializing touch mode twice while being constructed
https://bugs.webkit.org/show_bug.cgi?id=76859
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-01-23
Reviewed by Kenneth Rohde Christiansen.
Removing d->initializeTouch() from QQuickWebView::QQuickWebView()
since in QQuickWebViewPrivate::initialize() there is a call for
setUseTraditionalDesktopBehaviour(false), which will call initializeTouch.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::QQuickWebView):
- 8:40 PM Changeset in webkit [105688] by
-
- 6 edits in trunk/Source/WebKit2
[GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible
https://bugs.webkit.org/show_bug.cgi?id=76755
Reviewed by Alejandro G. Castro.
Always clear the loading events when loading new content in the load tracking
test. In the WebView test correctly handle loading HTML with a URL that isn't
"about:blank."
- UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::loadURI): Reset the class state when starting a new load.
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
- UIProcess/API/gtk/tests/LoadTrackingTest.h: Added new method definitions.
- UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(assertNormalLoadHappened): No longer clear loading events. The fixture handles that now.
(testLoadHtml): Update to reflect new method name.
(testLoadPlainText): Ditto.
(testLoadRequest): Ditto.
(testWebViewReload): Ditto.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadHtml): Properly interpret the baseURL parameter.
- UIProcess/API/gtk/tests/WebViewTest.h: Make loading methods virtual.
- 8:38 PM Changeset in webkit [105687] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Clean up old WebSharedWorker::startWorkerContext() method.
https://bugs.webkit.org/show_bug.cgi?id=76853
Reviewed by Darin Fisher.
- public/WebSharedWorker.h:
- src/WebSharedWorkerImpl.cpp:
- src/WebSharedWorkerImpl.h:
- 8:23 PM Changeset in webkit [105686] by
-
- 10 edits in trunk
[GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-23
Reviewed by Martin Robinson.
Source/WebCore:
When the WEBKIT_TOP_LEVEL environment variable is set, resources
should be loaded from the source tree to which the variable is
pointing. This approach is used when performing testing on the
Gtk port.
No new tests, changes cause one test to pass.
- platform/graphics/gtk/ImageGtk.cpp:
(getPathToImageResource): Also make changes to the resource path
construction code on Windows.
(WebCore::Image::loadPlatformResource):
Tools:
WEBKIT_TOP_LEVEL environment variable is now set directly in either
WebKitTestRunner or DumpRenderTree through usage of a compilation-time
macro. This way both tools can be run outside the test harness without
the need to manually set the environment variable.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getTopLevelPath):
- GNUmakefile.am:
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
- WebKitTestRunner/GNUmakefile.am:
- WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WTR::InjectedBundle::platformInitialize):
LayoutTests:
Unskip newly-passing editing test.
- platform/gtk/Skipped:
- 8:15 PM Changeset in webkit [105685] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
https://webkit.org/b/76842
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/table/crash-section-logical-height-changed-needsCellRecalc.html
The issue was that we would access our section's structure when it was dirty.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Bail out if we need cells recalculation as our internal structure is not up-to-date
and we will recompute all the rows' heights as part of the recomputation anyway.
LayoutTests:
- fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt: Added.
- fast/table/crash-section-logical-height-changed-needsCellRecalc.html: Added.
- 8:07 PM Changeset in webkit [105684] by
-
- 7 edits2 adds in trunk
Source/WebKit/chromium: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Expose WebCore::WorkerThread::workerThreadCount() in API layer
for DumpRenderTree.
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebWorkerInfo.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
- src/WebWorkerInfo.cpp: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit::WebWorkerInfo::dedicatedWorkerCount):
Tools: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Reviewed by Darin Fisher.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::workerThreadCount):
- DumpRenderTree/chromium/LayoutTestController.h:
LayoutTests: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Reviewed by Darin Fisher.
- platform/chromium/test_expectations.txt:
- 7:59 PM Changeset in webkit [105683] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp files generated
by unchanged IDLs (bug 76836).
As a refactoring, we are planning to remove finish() from all
CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm
empty.
No new tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(finish): Made it empty. We will remove finish() after
making finish() of all CodeGenerators empty.
(GenerateInterface): Modified to call WriteData().
(WriteData): Simple code refactoring.
Removed if(defined $IMPL).
Removed if(defined $HEADER).
Removed if(defined $DEPS).
$IMPL -> IMPL.
$HEADER -> HEADER.
$DEPS -> DEPS.
- 7:55 PM Changeset in webkit [105682] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r105676.
http://trac.webkit.org/changeset/105676
https://bugs.webkit.org/show_bug.cgi?id=76665
Breaks build on max due to compile warnings.
- runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::allocatePropertyStorage):
- runtime/JSObject.h:
- 7:20 PM Changeset in webkit [105681] by
-
- 5 edits in trunk/Source/WebKit/chromium
Fine tune Web Intents Chromium API
https://bugs.webkit.org/show_bug.cgi?id=76754
Patch by Greg Billock <gbillock@google.com> on 2012-01-23
Reviewed by Darin Fisher.
- public/WebIntent.h:
- public/WebIntentServiceInfo.h:
- src/WebIntent.cpp:
- src/WebIntentServiceInfo.cpp:
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
- 6:45 PM Changeset in webkit [105680] by
-
- 5 edits in trunk/Source
[chromium] updateRect is incorrect when contentBounds != bounds
https://bugs.webkit.org/show_bug.cgi?id=72919
Reviewed by James Robinson.
Source/WebCore:
Unit test added to TiledLayerChromiumTest.cpp
The m_updateRect member in LayerChromium types is used to track
what was painted for that layer. For tiled layers (especially
image layers), the updateRect was being given with respect to the
size of the content, rather than the size of the layer. This patch
adds a conversion so that updateRect is always with respect to the
layer size, so that damage tracking will work correctly in those
cases.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WTF::FakeTiledLayerWithScaledBounds::setContentBounds):
(WTF::FakeTiledLayerWithScaledBounds::contentBounds):
(WTF::FakeTiledLayerWithScaledBounds::updateRect):
(WTF::TEST):
- 6:39 PM Changeset in webkit [105679] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.
https://bugs.webkit.org/show_bug.cgi?id=76706
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-23
Reviewed by Pavel Feldman.
Changed DOMAgent.copyNode to call getOuterHTML and use the callback function to
return the text to InspectorFrontendHost.copyText. This will make all copy
functions use the same code path.
Not testable.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.copyNode.copy):
(WebInspector.DOMNode.prototype.copyNode):
- 6:36 PM Changeset in webkit [105678] by
-
- 3 edits in trunk/Source/WebCore
Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
https://bugs.webkit.org/show_bug.cgi?id=69490
Reviewed by Andreas Kling.
Covered by existing tests.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
Use float multiplier instead of double.
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Use float multiplier instead of double.
- css/CSSPrimitiveValue.h:
Change type signatures of computeLength template prototype.
- 6:33 PM Changeset in webkit [105677] by
-
- 66 adds in branches/subpixellayout/Source
Add missing files
- 6:29 PM Changeset in webkit [105676] by
-
- 3 edits in trunk/Source/JavaScriptCore
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665
Reviewed by Geoffrey Garen.
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new.
- runtime/JSObject.h:
- 6:18 PM Changeset in webkit [105675] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium][WebSocket] Remove binary communication using WebData in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=76608
Reviewed by Darin Fisher.
- public/WebSocket.h: Remove BinaryTypeData definition and sendBinary(const WebData&).
- public/WebSocketClient.h: Remove didReceiveBinaryData(const WebData&).
- src/WebSocketImpl.cpp: Remove WebData related code and set default binary type as BinaryTypeBlob.
(WebKit::WebSocketImpl::WebSocketImpl): Remove sendBinary(const WebData&).
(WebKit::WebSocketImpl::didReceiveBinaryData): Remove WebData supporting code.
- src/WebSocketImpl.h: Remove sendBinary(const WebData&).
- 6:09 PM Changeset in webkit [105674] by
-
- 4 edits in trunk/Tools
nrwt: make --chromium work like --qt
https://bugs.webkit.org/show_bug.cgi?id=76875
Reviewed by Adam Barth.
--chromium used to have to be handled differently from --qt
due to the way the PortFactory was implemented; there's not
really a good reason for that any more so this patch makes
things slightly more consistent and eliminates the
options.chromium flag (--chromium is now truly a synonym for
--platform chromium).
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port):
(PortFactory.get):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.setUp):
(FactoryTest.test_chromium_mac):
(FactoryTest.test_chromium_linux):
(FactoryTest.test_chromium_win):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 6:05 PM Changeset in webkit [105673] by
-
- 2 edits in trunk/Tools
run-webkit-tests needs to propagate --chromium
https://bugs.webkit.org/show_bug.cgi?id=76870
Reviewed by Eric Seidel.
run-webkit-tests removes '--chromium' argument from @ARGV when
determining which port to run, which means that that doesn't
propagate to new-run-webkit-tests. That's bad (and is handled
for the other ports by re-adding the flag, but apparently we're
just now noticing for Chromium).
- Scripts/run-webkit-tests:
- 6:00 PM Changeset in webkit [105672] by
-
- 4 edits in trunk/LayoutTests
Unreviewed test expectations fixes for a couple of window/frame tests.
- http/tests/security/cross-frame-access-put-expected.txt:
Updated expectations to reflect that window.frameElement now has the type
HTMLIFrameElement. The test itself has already been updated.
- platform/mac/fast/dom/Window/window-properties-expected.txt:
Added window.applicationCache.abort method.
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
Added DOMURL class.
- 5:59 PM Changeset in webkit [105671] by
-
- 2 edits in trunk/Source/WebCore
[GTK][PATCH] More build silencing with (AM_V_...)
https://bugs.webkit.org/show_bug.cgi?id=76791
Patch by Priit Laes <plaes@plaes.org> on 2012-01-23
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Silence is golden...
- 5:54 PM Changeset in webkit [105670] by
-
- 14 edits in trunk/Source/WebKit2
[Qt] Implement SSL error handling QML API.
https://bugs.webkit.org/show_bug.cgi?id=76793
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-23
Reviewed by Simon Hausmann.
This patch implements support for accepting or rejecting invalid SSL
certificates from the QML API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::certificateVerificationRequest):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtDialogRunner.cpp:
(CertificateVerificationDialogContextObject::CertificateVerificationDialogContextObject):
(CertificateVerificationDialogContextObject::hostname):
(CertificateVerificationDialogContextObject::accept):
(CertificateVerificationDialogContextObject::reject):
(QtDialogRunner::initForCertificateVerification):
- UIProcess/qt/QtDialogRunner.h:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleCertificateVerificationRequest):
- UIProcess/qt/QtPageClient.h:
- WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onSslErrors):
- WebProcess/qt/QtNetworkAccessManager.h:
- 5:47 PM Changeset in webkit [105669] by
-
- 4 edits in trunk
More build fixing after r105646.
Source/JavaScriptCore:
- JavaScriptCore.exp:
Tools:
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
(TestWebKitAPI::TestNode::key):
- 5:36 PM Changeset in webkit [105668] by
-
- 12 edits in trunk/Source/WebCore
MicroData: Remove ExceptionCode& from setAttribute() call.
https://bugs.webkit.org/show_bug.cgi?id=76695
Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.
Changeset http://trac.webkit.org/changeset/103296 removed unused
ExceptionCode& argument from Element::setAttribute(QualifiedName).
Hence updating all calls to setAttribute() method in MicroData code.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setItemValueText):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setItemValueText):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::setItemValueText):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::setItemValueText):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setItemValueText):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setItemValueText):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setItemValueText):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::setItemValueText):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::setItemValueText):
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::setItemValueText):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::setItemValueText):
- 5:31 PM Changeset in webkit [105667] by
-
- 6 edits in trunk/Source
[windows] Convert usages of GetDC to HWndDC Part 2.
https://bugs.webkit.org/show_bug.cgi?id=76750
Reviewed by Adam Roben.
Source/WebKit/win:
- FullscreenVideoController.cpp:
(createCompatibleDCForWindow): Moved out the code which creates a DC for a window
to keep the same scope for the DC lifetime.
(FullscreenVideoController::draw): Switch to using OwnPtr<HDC>
since createCompatibleDCForWindow returns a PassOwnPtr.
- WebNodeHighlight.cpp:
(WebNodeHighlight::update):
Cleaned up leaks from calling GetDC without release.
Note that there is a potential leak of hdc that previously existed
and still does in an early exit scenario. (This could be easily fixed
by using OwnPtr<HDC> but I was trying to keep this patch focused.)
- WebView.cpp:
(WebView::scrollBackingStore): Typical conversion.
(WebView::updateBackingStore): Reduced the scope of windowDC to be
right where it is being used.
(WebView::performLayeredWindowUpdate): Typical conversion.
(WebView::paintIntoBackingStore): Ditto.
Source/WebKit2:
- Shared/win/ShareableBitmapWin.cpp:
(WebKit::ShareableBitmap::windowsContext): Fix incorrect usage of OwnPtr<HDC> which
would do a DeleteDC instead of a ReleaseDC.
- 5:21 PM Changeset in webkit [105666] by
-
- 2 edits in trunk/Tools
Unreviewed build fix - r105646 broke this.
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
(TestWebKitAPI::TestNode::TestNode):
(TestWebKitAPI::TestNode::key):
(TestWebKitAPI::RedBlackTreeTest::assertEqual):
(TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
(TestWebKitAPI::RedBlackTreeTest::testDriver):
- 5:21 PM Changeset in webkit [105665] by
-
- 3 edits2 adds in trunk
Fix crash when a focused node is removed while in processing focusin event.
https://bugs.webkit.org/show_bug.cgi?id=76656
Reviewed by Dimitri Glazkov.
Source/WebCore:
Test: fast/events/focus-remove-focuesed-node.html
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
LayoutTests:
- fast/events/focus-remove-focuesed-node-expected.txt: Added.
- fast/events/focus-remove-focuesed-node.html: Added.
- 5:16 PM Changeset in webkit [105664] by
-
- 4 edits in trunk/LayoutTests
Switch media/audio-data-url.html layout test to base64-encoded WAV data.
https://bugs.webkit.org/show_bug.cgi?id=76759
Reviewed by Eric Carlson.
- media/audio-data-url-expected.txt:
- media/audio-data-url.html:
- platform/chromium/test_expectations.txt:
- 5:10 PM Changeset in webkit [105663] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r105658.
http://trac.webkit.org/changeset/105658
https://bugs.webkit.org/show_bug.cgi?id=76883
We want this eventually, but not right at this moment
(Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- 5:09 PM Changeset in webkit [105662] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build
https://bugs.webkit.org/show_bug.cgi?id=76879
Reviewed by Dirk Pranke.
- WebKit.gyp:
- 5:07 PM Changeset in webkit [105661] by
-
- 13 edits in trunk/Source
[windows] Convert usages of GetDC to HWndDC Part 1.
https://bugs.webkit.org/show_bug.cgi?id=76744
Reviewed by Adam Roben.
Source/WebCore:
No new functionality so no new tests.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters): Changed GetDC to HWndDC
and removed ReleaseDC.
(WebCore::createGDIFont): Ditto.
(WebCore::FontCache::getTraitsInFamily): Ditto.
- platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit): Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont): Ditto.
(WebCore::SimpleFontData::containsCharacters): Ditto.
(WebCore::SimpleFontData::determinePitch): Ditto.
(WebCore::SimpleFontData::boundsForGDIGlyph): Ditto.
(WebCore::SimpleFontData::widthForGDIGlyph): Ditto.
(WebCore::SimpleFontData::scriptFontProperties): Ditto.
- platform/win/CursorWin.cpp:
(WebCore::createSharedCursor): Ditto.
- platform/win/DragImageCGWin.cpp:
(WebCore::scaleDragImage): Ditto.
(WebCore::createDragImageFromImage): Ditto.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): Ditto.
Source/WebKit/win:
- WebIconDatabase.cpp:
(createDIB): Changed GetDC to HWndDC and removed ReleaseDC.
Source/WebKit2:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::flashBackingStoreUpdates): Typical conversion.
- 4:54 PM Changeset in webkit [105660] by
-
- 5 edits in trunk/Source/WebCore
[GTK] Scrollbars do not respect the has-backward-stepper and has-forward-stepper properties
https://bugs.webkit.org/show_bug.cgi?id=76747
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-23
Reviewed by Gustavo Noronha Silva.
No new tests. Regressions are covered by existing tests, but testing
different GTK+ theme configurations is not possible yet.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): If there is no back stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): If there is no forward stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::trackRect): Adjust track rect calculation to account for when there is
no steppers.
- platform/gtk/ScrollbarThemeGtk.h: New members describing whether there are primary steppers.
- platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Look at the theme to determine if there
are primary foward and back steppers.
- platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.
- 4:47 PM Changeset in webkit [105659] by
-
- 3 edits4 adds in trunk
REGRESSION(r105396): drag state is not cleared after each drag
https://bugs.webkit.org/show_bug.cgi?id=76878
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Revert a part of r105396 that made performDragAndDrop not call clearDragState
when the default action was not prevented since it caused a regression.
I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
but I can't think of a test case where this becomes a problem at the moment.
Since this area is not well tested, revert the change instead of making further
changes to the code base.
Tests: fast/events/clear-drag-state.html
fast/events/clear-edit-drag-state.html
- page/EventHandler.cpp:
(WebCore::EventHandler::performDragAndDrop):
LayoutTests:
Add a regression test to ensure we don't fire extra dragenter event
on the second drag at an element that contains the dragged content.
- fast/events/clear-drag-state-expected.txt: Added.
- fast/events/clear-drag-state.html: Added.
- fast/events/clear-edit-drag-state-expected.txt: Added.
- fast/events/clear-edit-drag-state.html: Added.
- 4:41 PM Changeset in webkit [105658] by
-
- 2 edits in trunk/Tools
garden-o-matic should support Chromium Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=76880
Reviewed by Eric Seidel.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- 4:40 PM Changeset in webkit [105657] by
-
- 5 edits in trunk/Source/WebCore
Fixed typo in exception messages
https://bugs.webkit.org/show_bug.cgi?id=76710
Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-23
Reviewed by Alexey Proskuryakov.
- dom/DOMCoreException.cpp:
- fileapi/FileException.cpp:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):
- xml/XMLHttpRequestException.cpp:
- 4:35 PM Changeset in webkit [105656] by
-
- 2 edits in trunk/Source/WebCore
Allow delayed DC allocation in HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76737
Reviewed by Adam Roben.
No new functionality exposed so no new tests.
- platform/win/HWndDC.h: Changed this slightly to allow
for allocating a window DC after the initial creation since
this pattern occurrs in several places so this makes it easy to
replace them in an upcoming change.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::setHWnd):
(WebCore::HWndDC::clear):
- 4:26 PM Changeset in webkit [105655] by
-
- 6 edits in trunk/Source/WebCore
MicroData: Compilation error while building Webkit with --microdata.
https://bugs.webkit.org/show_bug.cgi?id=76703
Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.
- dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):
- dom/MicroDataItemList.h:
- dom/NodeRareData.h:
(WebCore::NodeRareData::properties):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
- html/HTMLPropertiesCollection.h:
- 4:22 PM Changeset in webkit [105654] by
-
- 8 edits in trunk/Source/WebCore
[chromium] Convert uses of GetDC to HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76290
Reviewed by Dmitry Titov.
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::createFontIndirectAndGetWinName):
(WebCore::fontContainsCharacter):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
- platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::FontMap::getAscent):
(WebCore::FontMap::getSpaceGlyph):
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore::systemFontSize):
(WebCore::pointsToPixels):
- 4:13 PM Changeset in webkit [105653] by
-
- 2 edits in trunk/Websites/webkit.org
website: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
https://bugs.webkit.org/show_bug.cgi?id=76544
Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23
Reviewed by Darin Adler.
WEBKITOUTPUTDIR is not only for Windows.
- building/build.html:
- 4:01 PM Changeset in webkit [105652] by
-
- 3 edits in trunk/Tools
check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_operator_methods):
- 4:00 PM Changeset in webkit [105651] by
-
- 4 edits1 add3 deletes in trunk/LayoutTests
Reduce throttling on video-buffering-repaints-controls test to prevent timeout.
https://bugs.webkit.org/show_bug.cgi?id=76113
Also reduces flakiness by checking for a repaint between progress and
suspend events versus just between progress events.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
Reviewed by Adam Barth.
- http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
- http/tests/media/video-buffering-repaints-controls.html:
- platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
- platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- 3:49 PM Changeset in webkit [105650] by
-
- 4 edits in trunk/Tools
run-perf-tests should report server-side errors
https://bugs.webkit.org/show_bug.cgi?id=76802
Reviewed by Tony Chang.
Report errors whenever server's response doesn't match "OK".
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_single_text_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._upload_json):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):
- 3:46 PM Changeset in webkit [105649] by
-
- 5 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=75799
Calling intersectsNode on a detached range should throw.
Source/WebCore:
INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.
Test: fast/dom/Range/range-intersectsNode-exception.html
- dom/Range.cpp:
(WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.
LayoutTests:
Added test case to verify the exception thrown while calling intersectsNode on a detached range.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.
- fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
- fast/dom/Range/range-intersectsNode-exception.html: Added.
- fast/dom/Range/range-intersectsNode-expected.txt:
- fast/dom/Range/resources/intersectsNode.js: Modified the test case to catch the exception.
- 3:35 PM Changeset in webkit [105648] by
-
- 19 edits1 delete in trunk/Source/WebCore
Convert DataTransferItem/DataTransferItemList back into an interface class
https://bugs.webkit.org/show_bug.cgi?id=76856
When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
share the same data anymore so it doesn't make sense to keep that code in a common location.
Reviewed by David Levin.
Covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DataTransferItem.cpp:
- dom/DataTransferItem.h:
- dom/DataTransferItemList.cpp: Removed.
- dom/DataTransferItemList.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::clipboardChromium):
- platform/chromium/DataTransferItemChromium.h:
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
- platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
- platform/chromium/DataTransferItemListChromium.h:
- platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):
- platform/qt/DataTransferItemListQt.h:
- platform/qt/DataTransferItemQt.cpp:
(WebCore::DataTransferItemQt::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsString):
(WebCore::DataTransferItemQt::getAsFile):
- platform/qt/DataTransferItemQt.h:
(WebCore::DataTransferItemQt::kind):
(WebCore::DataTransferItemQt::type):
- 3:32 PM Changeset in webkit [105647] by
-
- 1 edit2 adds in trunk/LayoutTests
getComputedStyle margin percentage test for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=76130
Reviewed by Darin Adler.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
- css3/calc/getComputedStyle-margin-percentage.html: Added.
- 3:30 PM Changeset in webkit [105646] by
-
- 5 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC
Reviewed by Geoff Garen.
Step 2: generalize RedBlackTree. The profiler is going to want tio use
a RedBlackTree, allow this class to work with subclasses of
RedBlackTree::Node, Node should not need to know the names of the m_key
and m_value fields (the subclass can provide a key() accessor), and
RedBlackTree does not need to know anything about ValueType.
- JavaScriptCore.exp:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
- wtf/MetaAllocator.h:
(WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
(WTF::MetaAllocator::FreeSpaceNode::key):
- wtf/MetaAllocatorHandle.h:
(WTF::MetaAllocatorHandle::key):
- wtf/RedBlackTree.h:
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):
- 3:01 PM Changeset in webkit [105645] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.
- css/CSSMutableStyleDeclaration.cpp:
- 2:42 PM Changeset in webkit [105644] by
-
- 4 edits in trunk/Tools
run-perf-tests ignore Skipped list on chromium
https://bugs.webkit.org/show_bug.cgi?id=76764
Reviewed by Dirk Pranke.
Move skipped_perf_tests from WebKit port to Base port so that Chromium port
can also find skipped list. Chromium port only uses test_expectations.txt for
layout tests but performacne tests don't use test_expectations.txt so Chromium port
also needs to use Skipped list.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._tests_from_skipped_file_contents):
(Port):
(Port._expectations_from_skipped_files):
(Port.skipped_perf_tests):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_skipped_perf_tests):
(PortTest.test_skipped_perf_tests.add_text_file):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort._skipped_file_search_paths):
(WebKitPort.skipped_layout_tests):
- 2:37 PM Changeset in webkit [105643] by
-
- 3 edits in trunk/Source/WebCore
Update uniteIfNonZero to use isZero.
https://bugs.webkit.org/show_bug.cgi?id=76637
Patch by Philip Rogers <pdr@google.com> on 2012-01-23
Reviewed by Darin Adler.
No new tests. (I found no existing codepath that would be affected by
this change but I think this change is still valuable in preventing
future bugs.)
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):
The following change is a minor followup to
https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
related to the rest of this patch.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
- 2:26 PM Changeset in webkit [105642] by
-
- 24 edits2 deletes in trunk/Source/WebCore
Eliminate CSSElementStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=76848
Reviewed by Andreas Kling.
CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.
Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
shrinks all inline style declarations by one pointer.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.h:
(WebCore::root):
- css/CSSAllInOne.cpp:
- css/CSSElementStyleDeclaration.cpp: Removed.
- css/CSSElementStyleDeclaration.h: Removed.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
(WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
Merge the CSSElementStyleDeclaration::styleSheet() logic here.
- css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- 2:07 PM Changeset in webkit [105641] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r105640.
http://trac.webkit.org/changeset/105640
https://bugs.webkit.org/show_bug.cgi?id=76849
Broke the chromium build.
- DEPS:
- 1:41 PM Changeset in webkit [105640] by
-
- 2 edits in trunk/Source/WebKit/chromium
rolling chromium DEPS to r118713
https://bugs.webkit.org/show_bug.cgi?id=76849
Patch by Justin Novosad <junov@chromium.org> on 2012-01-23
Reviewed by Stephen White.
This is to pick up a change to skia build configuration
- DEPS:
- 1:39 PM Changeset in webkit [105639] by
-
- 4 edits in trunk
Fix the build after r105635.
Source/JavaScriptCore:
- JavaScriptCore.exp:
Tools:
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- 1:36 PM Changeset in webkit [105638] by
-
- 6 edits in trunk/Source/JavaScriptCore
Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310
Reviewed by Sam Weinig.
Removed StackBounds and the stack() function from JSGlobalData since it no
longer accessed any members of JSGlobalData.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThread):
- parser/Parser.cpp:
(JSC::::Parser):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- 1:35 PM Changeset in webkit [105637] by
-
- 3 edits in trunk/Source/WebCore
Use OVERRIDE for PopupMenuClient's implementations
https://bugs.webkit.org/show_bug.cgi?id=76774
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23
Reviewed by Darin Adler.
- rendering/RenderMenuList.h: Also sort the methods to the same
order as PopupMenuClient.
- rendering/RenderTextControlSingleLine.h:
- 1:08 PM Changeset in webkit [105636] by
-
- 24 edits in trunk/Source/JavaScriptCore
Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855
Rubber stanmped by Geoff Garen.
Mechanical change - pass CodeBlock through to the executable allocator,
such that we will be able to map ranges of JIT code back to their owner.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
- assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp:
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
- 12:42 PM Changeset in webkit [105635] by
-
- 16 edits in trunk
Basic enhancements to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67081
Source/JavaScriptCore:
This change contains the following enhancements to StringBuilder,
for convenience, performance, testability, etc.:
- Change toStringPreserveCapacity() to const
- new public methods: capacity(), swap(), toAtomicString(), canShrink() and append(const StringBuilder&)
- == and != opearators to compare StringBuilders and a StringBuilder/String
Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp
Reviewed by Darin Adler.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/text/AtomicString.cpp:
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
(WTF::SubstringTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::add):
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::canShrink):
(WTF::StringBuilder::shrinkToFit):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::toAtomicString):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::capacity):
(WTF::StringBuilder::is8Bit):
(WTF::StringBuilder::swap):
(WTF::equal):
(WTF::operator==):
(WTF::operator!=):
- wtf/text/StringImpl.h:
Source/WebCore:
These changes are because we explicitly disallowed StringBuilder's
copy constructor and assignment operator, and the change of return
type of StringBuilder::toString().
Reviewed by Darin Adler.
No new tests. All layout tests and unit tests should run as before.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
- svg/SVGPathStringBuilder.h:
(WebCore::SVGPathStringBuilder::cleanup):
Source/WebKit/chromium:
This change is because we explicitly disallowed StringBuilder's
copy constructor and assignment operator.
Reviewed by Darin Adler.
No new tests. All layout tests and unit tests should run as before.
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
Tools:
Reviewed by Darin Adler.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- 12:00 PM Changeset in webkit [105634] by
-
- 6 edits11 adds in trunk/Source
[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732
Reviewed by James Robinson.
Source/WebCore:
Add WebSolidColorLayer to paint solid-color layers without a backing texture.
Test: unit test for CCSolidColorLayerImpl.
- WebCore.gypi:
- platform/graphics/chromium/SolidColorLayerChromium.cpp: Added.
(WebCore::SolidColorLayerChromium::createCCLayerImpl):
(WebCore::SolidColorLayerChromium::create):
(WebCore::SolidColorLayerChromium::SolidColorLayerChromium):
(WebCore::SolidColorLayerChromium::~SolidColorLayerChromium):
- platform/graphics/chromium/SolidColorLayerChromium.h: Added.
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added.
(WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::quadTransform):
(WebCore::CCSolidColorLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added.
(WebCore::CCSolidColorLayerImpl::create):
(WebCore::CCSolidColorLayerImpl::layerTypeAsString):
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- public/platform/WebSolidColorLayer.h: Added.
- src/WebSolidColorLayer.cpp: Added.
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
- src/WebSolidColorLayerImpl.cpp: Added.
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl):
- src/WebSolidColorLayerImpl.h: Added.
- tests/CCLayerTestCommon.cpp: Added.
(CCLayerTestCommon::completelyContains):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):
- tests/CCLayerTestCommon.h: Added.
- tests/CCSolidColorLayerImplTest.cpp: Added.
(CCLayerTestCommon::TEST):
- tests/CCTiledLayerImplTest.cpp:
- 11:39 AM Changeset in webkit [105633] by
-
- 32 edits15 adds24 deletes in trunk/LayoutTests
Update the baselines for a number of tests that use gradients. The new
results are just slightly different than the old results.
- fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
- fast/gradients/border-image-gradient-expected.txt: Added.
- fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
- platform/chromium-linux-x86/fast/gradients: Removed.
- platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
- platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
- platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
- platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
- platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
- platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
- platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
- platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
- platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
- platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
- platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
- platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
- platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients: Removed.
- platform/chromium-win-xp/svg/as-background-image: Removed.
- platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
- platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
- platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
- platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
- platform/chromium-win/fast/gradients/generated-gradients-expected.png:
- platform/chromium-win/fast/gradients/simple-gradients-expected.png:
- platform/chromium-win/fast/reflections/reflection-masks-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-expected.png:
- platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
- platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- 9:20 AM Changeset in webkit [105632] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix Qt build.
Not reviewed.
- css/CSSElementStyleDeclaration.cpp:
- css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
- 9:00 AM Changeset in webkit [105631] by
-
- 3 edits in trunk/Source/WebCore
Move m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
<http://webkit.org/b/76833>
Reviewed by Antti Koivisto.
Move HTMLAnchorElement::m_rootEditableElementForSelectionOnMouseDown to a rare
data-style hashmap, effectively shrinking HTMLAnchorElement by one CPU word.
The pointer is only used during interactive event handling, so it shouldn't have
any noticeable effects on web performance.
This reduces memory consumption by 256 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::~HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
(WebCore::rootEditableElementMap):
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
(WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown):
- html/HTMLAnchorElement.h:
- 8:49 AM Changeset in webkit [105630] by
-
- 17 edits1 delete in trunk/Source/WebCore
Eliminate CSSElementStyleDeclaration subclasses
https://bugs.webkit.org/show_bug.cgi?id=76827
Reviewed by Andreas Kling.
CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no real purpose.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSElementStyleDeclaration.cpp:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSElementStyleDeclaration::styleSheet):
- css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createInline):
(WebCore::toCSSElementStyleDeclaration):
- css/CSSInlineStyleDeclaration.h: Removed.
- css/CSSMutableStyleDeclaration.cpp:
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- 8:45 AM Changeset in webkit [105629] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.
- platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer
which is no longer tied to 3D_CANVAS.
- 8:37 AM Changeset in webkit [105628] by
-
- 3 edits in trunk/Source/WebCore
Not reviewed: annotate inspector's js so that it compiled.
- inspector/front-end/ElementsTreeOutline.js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
- 8:32 AM Changeset in webkit [105627] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark another test as flaky crash.
- platform/gtk/test_expectations.txt:
editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.
- 8:24 AM Changeset in webkit [105626] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] fix WebAudio build after r105431
https://bugs.webkit.org/show_bug.cgi?id=76819
Reviewed by Martin Robinson.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel): Use mutableData()
when copying.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Drop constness when setting the buffer
data pointer.
- 8:20 AM Changeset in webkit [105625] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: add touch events to the event listeners list.
https://bugs.webkit.org/show_bug.cgi?id=76830
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
- 7:52 AM Changeset in webkit [105624] by
-
- 3 edits16 adds in trunk/LayoutTests
Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
flaky tests and added baselines for 15 tests.
- platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
- platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
- platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
- platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
- platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
- platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
- platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
- platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
- platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
- platform/gtk/test_expectations.txt:
- 7:47 AM Changeset in webkit [105623] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: inspector close button is missing in the dock-to-right mode.
https://bugs.webkit.org/show_bug.cgi?id=76829
Reviewed by Timothy Hatcher.
- inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.get _setCompactMode):
- 7:25 AM BuildingGtk edited by
- added gst modules in example moduleset (diff)
- 7:24 AM Changeset in webkit [105622] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r105613.
- platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
- platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.
- 7:17 AM Changeset in webkit [105621] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
https://bugs.webkit.org/show_bug.cgi?id=76705
Reviewed by Pavel Feldman.
- inspector/Inspector.json:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
- inspector/InspectorIndexedDBAgent.h:
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype._requestId):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabasesForFrameRequest):
(WebInspector.IndexedDBDispatcher):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
- 7:10 AM Changeset in webkit [105620] by
-
- 5 edits3 adds in trunk
Web Inspector: Inspecting an element inside an iframe no longer works
https://bugs.webkit.org/show_bug.cgi?id=76808
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: http/tests/inspector/inspect-element.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::innerParentNode):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._setChildrenPayload):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
LayoutTests:
- http/tests/inspector/inspect-element-expected.txt: Added.
- http/tests/inspector/inspect-element.html: Added.
- http/tests/inspector/resources/inspect-element-iframe.html: Added.
- 6:52 AM Changeset in webkit [105619] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: response.bodySize in HAR is invalid (negative) for cached resources
https://bugs.webkit.org/show_bug.cgi?id=76823
Reviewed by Yury Semikhatsky.
- fix response.bodySize for cached resources;
Also some drive-by fixes:
- pretty-print HAR when exported
- proper annotation for JSON.stringify()
- de-obfuscate a piece of code in TimelinePanel
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.get responseBodySize):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):
- 6:45 AM Changeset in webkit [105618] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkAction interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceAction.cpp: Added.
(core):
(webkitAccessibleActionInterfaceInit):
(webkitAccessibleActionDoAction):
(webkitAccessibleActionGetNActions):
(webkitAccessibleActionGetDescription):
(webkitAccessibleActionGetKeybinding):
(webkitAccessibleActionGetName):
- accessibility/gtk/WebKitAccessibleInterfaceAction.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkAction interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceAction.[h|cpp].
- WebCore.gypi: Ditto.
- 6:36 AM Changeset in webkit [105617] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817
Reviewed by Gustavo Noronha Silva.
No need to use xprop to remove the AT_SPI_BUS property since
run-gtk-tests will always run new instances of Xvfb.
- Scripts/run-gtk-tests:
(TestRunner): Unskip TestWebKitAccessibility.
(TestRunner.run): Uncomment lines for launching the accessibility
bus and registry daemon, and remove lines for running xprop.
- 6:32 AM Changeset in webkit [105616] by
-
- 2 edits in trunk/Tools
[Qt] Don't warn about override and final being C++11 extensions
Clang will emit a warning when these extensions are used without passing
--std=c++11, but we use feature checking to decide if we have the right
extensions, so we can safely ignore these warnings. The XCode and Windows
project files have the same workaround.
The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
we only have one extra compiler for Objective-C, which is also used for
Objective-C++ sources, so we have to pass the flag, even if it doesn't
make sense for Objective-C.
Reviewed by Simon Hausmann.
- 6:12 AM Changeset in webkit [105615] by
-
- 2 edits in trunk/LayoutTests
Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.
- platform/chromium/test_expectations.txt:
- 6:03 AM Changeset in webkit [105614] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed rebaseline after r105613 (SVG animation repaint issue...).
- platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
- 5:05 AM BuildingGtk edited by
- (diff)
- 5:01 AM BuildingGtk edited by
- (diff)
- 5:00 AM BuildingGtk edited by
- (diff)
- 4:59 AM BuildingGtk edited by
- Add info on WEBKIT_EXTRA_MODULE{S,SETS} (diff)
- 4:48 AM Changeset in webkit [105613] by
-
- 9 edits6 adds in trunk
SVG animation repaint issue with image and dynamic clipPath
https://bugs.webkit.org/show_bug.cgi?id=76559
Reviewed by Zoltan Herczeg.
Source/WebCore:
Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
to correctly handle relative length resolution as well.
RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
and thus fails to update its boundaries in some cases.
The logic is also inconsistent, compared to the other renderers.
Fix that properly, by reusing the method used in RenderSVGViewportContainer.
Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
still needs layout, leading to wrong results.
I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.
Tests: svg/custom/relative-sized-image.xhtml
svg/repaint/image-with-clip-path.svg
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
- rendering/svg/RenderSVGImage.h:
(WebCore::RenderSVGImage::setNeedsBoundariesUpdate):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
LayoutTests:
Update results after fixing RenderSVGImage repainting.
- platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/mac/svg/custom/relative-sized-image-expected.png: Added.
- platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
- platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
- svg/custom/relative-sized-image.xhtml: Added.
- svg/repaint/image-with-clip-path-expected.txt: Added.
- svg/repaint/image-with-clip-path.svg: Added.
- 4:42 AM Changeset in webkit [105612] by
-
- 11 edits in trunk
<feImage> has problems referencing local elements
https://bugs.webkit.org/show_bug.cgi?id=76800
Reviewed by Zoltan Herczeg.
Source/WebCore:
<feImage> referencing local elements are currently rendered into an ImageBuffer
by SVGFEImageElement, using the local coordinates of the referenced renderer.
This approach is buggy and should be avoided, by moving the rendering fully
into SVGFEImage, which takes care of respecting the correct transformations.
This fixes <feImage> + local references, which currently breaks two tests in trunk.
Covered by existing tests.
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::createWithImage):
(WebCore::FEImage::createWithIRIReference):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
(WebCore::FEImage::platformApplySoftware):
(WebCore::FEImage::externalRepresentation):
- svg/graphics/filters/SVGFEImage.h:
(WebCore::FEImage::~FEImage):
- svg/graphics/filters/SVGFilter.h:
(WebCore::SVGFilter::absoluteTransform):
LayoutTests:
Update svg/filters/feImage-reference-* results, which are fixed now.
- platform/chromium/test_expectations.txt : Updated.
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
- svg/filters/feImage-reference-invalidation-expected.png:
- svg/filters/feImage-reference-svg-primitive-expected.png:
- 4:39 AM Changeset in webkit [105611] by
-
- 2 edits in trunk/Source/WebCore
2012-01-23 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix Mac build, by exporting a new symbol.
- WebCore.exp.in:
- 3:55 AM Changeset in webkit [105610] by
-
- 5 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Move common function returnString() from the wrapper and
hyperlink implementations to a new utility file.
- accessibility/gtk/WebKitAccessibleUtil.cpp: Added.
(returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
WebKitAccessibleHyperlink.cpp
- accessibility/gtk/WebKitAccessibleUtil.h: Added.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local
implementation of returnString.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
- WebCore.gypi: Ditto.
- 3:51 AM Changeset in webkit [105609] by
-
- 2 edits in trunk/LayoutTests
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690
Unreviewed gardening after r105605.
- fast/events/ime-composition-events-001-expected.txt: Updated.
- 3:46 AM Changeset in webkit [105608] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Fix typo in class struct (parent class field had the wrong type),
fix coding style issues and update date in headers.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp:
- accessibility/gtk/WebKitAccessibleHyperlink.h:
- 3:43 AM Changeset in webkit [105607] by
-
- 7 edits in trunk/Source
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Source/WebCore:
Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.
- accessibility/gtk/WebKitAccessibleWrapperAtk.h:
Update calls to WebKitAccessible's public functions.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(core): Update call.
Source/WebKit/gtk:
Update callers to WebKitAccessible's public functions.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):
- 3:17 AM Changeset in webkit [105606] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing files, remove deleted files and
fix indentation.
- 2:41 AM Changeset in webkit [105605] by
-
- 4 edits in trunk
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690
- 2:21 AM Changeset in webkit [105604] by
-
- 10 edits2 moves in trunk/Source
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Source/WebCore:
Rename the file for the ATK AccessibilityObject wrapper to be more
coherent with the rest of the files in the same directory.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp.
(fallbackObject):
(returnString):
(core):
(webkit_accessible_get_name):
(webkit_accessible_get_description):
(setAtkRelationSetFromCoreObject):
(isRootObject):
(atkParentOfRootObject):
(webkit_accessible_get_parent):
(getNChildrenForTable):
(webkit_accessible_get_n_children):
(getChildForTable):
(webkit_accessible_ref_child):
(getIndexInParentForCellInRow):
(webkit_accessible_get_index_in_parent):
(addAttributeToSet):
(webkit_accessible_get_attributes):
(atkRole):
(webkit_accessible_get_role):
(selectionBelongsToObject):
(isTextWithCaret):
(setAtkStateSetFromCoreObject):
(webkit_accessible_ref_state_set):
(webkit_accessible_ref_relation_set):
(webkit_accessible_init):
(webkit_accessible_finalize):
(webkit_accessible_class_init):
(webkit_accessible_get_type):
(webkit_accessible_action_do_action):
(webkit_accessible_action_get_n_actions):
(webkit_accessible_action_get_description):
(webkit_accessible_action_get_keybinding):
(webkit_accessible_action_get_name):
(atk_action_interface_init):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkit_accessible_selection_add_selection):
(webkit_accessible_selection_clear_selection):
(webkit_accessible_selection_ref_selection):
(webkit_accessible_selection_get_selection_count):
(webkit_accessible_selection_is_child_selected):
(webkit_accessible_selection_remove_selection):
(webkit_accessible_selection_select_all_selection):
(atk_selection_interface_init):
(utf8Substr):
(convertUniCharToUTF8):
(textForRenderer):
(textForObject):
(webkit_accessible_text_get_text):
(getGailTextUtilForAtk):
(getPangoLayoutForAtk):
(webkit_accessible_text_get_text_after_offset):
(webkit_accessible_text_get_text_at_offset):
(webkit_accessible_text_get_text_before_offset):
(webkit_accessible_text_get_character_at_offset):
(webkit_accessible_text_get_caret_offset):
(baselinePositionForRenderObject):
(getAttributeSetForAccessibilityObject):
(compareAttribute):
(attributeSetDifference):
(accessibilityObjectLength):
(getAccessibilityObjectForOffset):
(getRunAttributesFromAccesibilityObject):
(webkit_accessible_text_get_run_attributes):
(webkit_accessible_text_get_default_attributes):
(textExtents):
(webkit_accessible_text_get_character_extents):
(webkit_accessible_text_get_range_extents):
(webkit_accessible_text_get_character_count):
(webkit_accessible_text_get_offset_at_point):
(getSelectionOffsetsForObject):
(webkit_accessible_text_get_n_selections):
(webkit_accessible_text_get_selection):
(webkit_accessible_text_add_selection):
(webkit_accessible_text_set_selection):
(webkit_accessible_text_remove_selection):
(webkit_accessible_text_set_caret_offset):
(atk_text_interface_init):
(webkit_accessible_editable_text_set_run_attributes):
(webkit_accessible_editable_text_set_text_contents):
(webkit_accessible_editable_text_insert_text):
(webkit_accessible_editable_text_copy_text):
(webkit_accessible_editable_text_cut_text):
(webkit_accessible_editable_text_delete_text):
(webkit_accessible_editable_text_paste_text):
(atk_editable_text_interface_init):
(contentsToAtk):
(atkToContents):
(webkit_accessible_component_ref_accessible_at_point):
(webkit_accessible_component_get_extents):
(webkit_accessible_component_grab_focus):
(atk_component_interface_init):
(webkit_accessible_image_get_image_position):
(webkit_accessible_image_get_image_description):
(webkit_accessible_image_get_image_size):
(atk_image_interface_init):
(cell):
(cellIndex):
(cellAtIndex):
(webkit_accessible_table_ref_at):
(webkit_accessible_table_get_index_at):
(webkit_accessible_table_get_column_at_index):
(webkit_accessible_table_get_row_at_index):
(webkit_accessible_table_get_n_columns):
(webkit_accessible_table_get_n_rows):
(webkit_accessible_table_get_column_extent_at):
(webkit_accessible_table_get_row_extent_at):
(webkit_accessible_table_get_column_header):
(webkit_accessible_table_get_row_header):
(webkit_accessible_table_get_caption):
(webkit_accessible_table_get_column_description):
(webkit_accessible_table_get_row_description):
(atk_table_interface_init):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
(atkHypertextInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
(atkHyperlinkImplInterfaceInit):
(documentAttributeValue):
(webkit_accessible_document_get_attribute_value):
(webkit_accessible_document_get_attributes):
(webkit_accessible_document_get_locale):
(atk_document_interface_init):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
(atkValueInterfaceInit):
(GetAtkInterfaceTypeFromWAIType):
(getInterfaceMaskFromObject):
(getUniqueAccessibilityTypeName):
(getAccessibilityTypeFromObject):
(webkit_accessible_new):
(webkit_accessible_get_accessibility_object):
(webkit_accessible_detach):
(webkit_accessible_get_focused_element):
(objectFocusedAndCaretOffsetUnignored):
- accessibility/gtk/WebKitAccessibleWrapperAtk.h: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.h.
Update the include for the AccessibilityObject wrapper header.
- accessibility/gtk/AXObjectCacheAtk.cpp: Update include.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp: Ditto.
- accessibility/gtk/WebKitAccessibleHyperlink.h: Ditto.
- editing/gtk/FrameSelectionGtk.cpp:
Update filename for the ATK wrapper in build files.
- GNUmakefile.list.am: Updated.
- WebCore.gypi: Updated.
Source/WebKit/gtk:
Update the include for the AccessibilityObject wrapper header.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Update include.
- webkit/webkitwebframe.cpp: Ditto.
- 2:14 AM Changeset in webkit [105603] by
-
- 3 edits in trunk/Tools
[Qt] Change how build-webkit decides when to do full incremental builds
Instead of relying on update-webkit (which isn't run on the bots) to
decide when to do a full incremental build (make qmake), we let the
build-webkit script itself check the current SVN revision against the
previous build (by storing it in .webkit.config).
If the two differ we assume a full incremental build is needed, since
the new revisions might have introduced problematic things like new
Q_OBJECT macros. If not, we assume the developer is doing changes
locally, and revert to doing a plain 'make'.
In addition, when the build fails in the latter case, we inform the
developer of possible pitfalls and how to manually run 'make qmake'.
Reviewed by Ossy.
- 2:09 AM Changeset in webkit [105602] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed follow-up to r105596, added missing test resources.
- http/tests/inspector/resources/har-pages-iframe.html: Added.
- http/tests/inspector/resources/har-pages-navigation-target.html: Added.
- 2:05 AM Changeset in webkit [105601] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817
Reviewed by Philippe Normand.
Temporarily comment the lines related to launching the ATSPI bus
and registry daemon, which are making the bots to fail randomly.
- Scripts/run-gtk-tests:
(TestRunner): Skip TestWebKitAccessibility, as it won't run
properly if the ATSPI infrastructure is not properly initialized.
(TestRunner.run): Comment lines related to initialization of ATSPI.
- 2:04 AM Changeset in webkit [105600] by
-
- 18 edits in trunk/Source
Web Inspector: PageAgent.open() dosen't belong to the protocol.
https://bugs.webkit.org/show_bug.cgi?id=74790
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::openInNewTab):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
- inspector/InspectorPageAgent.h:
- inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._openInNewTab):
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
- inspector/front-end/inspector.js:
(WebInspector.openResource):
Source/WebKit/chromium:
- public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::openInNewTab):
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::openInNewTab):
(WebKit::InspectorFrontendClientImpl::saveAs):
- src/InspectorFrontendClientImpl.h:
- 1:59 AM Changeset in webkit [105599] by
-
- 9 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r101742.
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 1:23 AM Changeset in webkit [105598] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles)
https://bugs.webkit.org/show_bug.cgi?id=76813
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):
- 1:13 AM Changeset in webkit [105597] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening, marked 2 tests as flaky on Debug and
unskipped another needing new baselines.
- platform/gtk/test_expectations.txt:
- 1:02 AM Changeset in webkit [105596] by
-
- 9 edits2 adds in trunk
Web Inspector: HAR pageref attributes are wrong and inconsistent with pages array
https://bugs.webkit.org/show_bug.cgi?id=76398
Reviewed by Pavel Feldman.
Source/WebCore:
- introduce a notion of LoadPage;
- move page load times to LoadPage;
- associate network resources with LoadPage;
- export pages for all available resoruces to HAR, not just the last page;
- use page ids, not document URLs in HAR entries to refer to pages;
- use page URL as a title field of a HAR page;
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertPage):
(WebInspector.HARLog.prototype._pageEventTime):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):
(WebInspector.Page):
(WebInspector.Page.prototype.get id):
(WebInspector.Page.prototype.get url):
(WebInspector.Page.prototype.get contentLoadTime):
(WebInspector.Page.prototype.set contentLoadTime):
(WebInspector.Page.prototype.get loadTime):
(WebInspector.Page.prototype.set loadTime):
(WebInspector.Page.prototype.get startTime):
(WebInspector.Page.prototype._bindResource):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get page):
(WebInspector.Resource.prototype.set page):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get page):
(WebInspector.PageDispatcher.prototype.domContentEventFired):
(WebInspector.PageDispatcher.prototype.loadEventFired):
LayoutTests:
- http/tests/inspector/resource-har-headers-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:
- 12:58 AM Changeset in webkit [105595] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening, marked a test as flaky and unskipped
several needing new baselines.
- platform/gtk/test_expectations.txt:
Jan 22, 2012:
- 11:08 PM Changeset in webkit [105594] by
-
- 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js
Merge 105261 - Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363
Reviewed by Pavel Feldman.
This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9279002
- 9:36 PM Changeset in webkit [105593] by
-
- 1 edit in branches/chromium/963/Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present
https://bugs.webkit.org/show_bug.cgi?id=76508
Patch by Kazuhiro Inaba <kinaba@chromium.org> on 2012-01-19
Reviewed by Kent Tamura.
Wrapped GetGlyphIndices() API calls so that when they failed we trigger font
loading outside the sandbox and retry the call.
No new auto tests since the bug involves the system's occasional cache behavior
and thus there's no reliable way to reproduce and test the situation.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::getGlyphIndices):
GDI call wrapper ensuring fonts to be loaded.
(WebCore::initSpaceGlyph):
Changed to use the wrapper function.
(WebCore::fillBMPGlyphs):
Changed to use the wrapper function.
Introduced scoped HDC management by HWndDC.
(WebCore::GlyphPage::fill):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9280004
- 6:13 PM Changeset in webkit [105592] by
-
- 2 edits in trunk/Tools
Windows python test build fix.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- 11:51 AM Changeset in webkit [105591] by
-
- 2 edits in trunk/LayoutTests
2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo, which makes the style bot warn on every patch.
- platform/chromium/test_expectations.txt:
- 11:29 AM Changeset in webkit [105590] by
-
- 7 edits in trunk/Source
[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069
Reviewed by Martin Robinson.
Source/WebCore:
Fix bug introduced with patch for Bug 72830.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isDescendantOfObject): New function,
to check if an accessibility object is a descendant of other object.
(WebCore::AccessibilityObject::isAncestorOfObject): New function,
to check if an accessibility object is an ancestor of other object.
- accessibility/AccessibilityObject.h:
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset): Make sure to pass the
right reference object to objectFocusedAndCaretOffsetUnignored.
(objectFocusedAndCaretOffsetUnignored): Use positionBeforeNode
instead of firstPositionInNode for calculating the begining of the
range used to calculate the offsets. Ensure that the reference
object is never a descendant of the actual object being returned.
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.
Source/WebKit/gtk:
Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.
- tests/testatk.c:
(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.
- 4:50 AM Changeset in webkit [105589] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping passing test.
- platform/gtk/Skipped: unskipped
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- 3:52 AM Changeset in webkit [105588] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping test passing after r79655.
- platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl
- 2:12 AM Changeset in webkit [105587] by
-
- 4 edits in trunk
[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631
Reviewed by Martin Robinson.
Tools:
DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewConsoleMessage):
LayoutTests:
Unskipped a couple of tests after fix.
- platform/gtk/Skipped:
- 1:11 AM Changeset in webkit [105586] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms that error out on warn-unused-parameter.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- 12:47 AM Changeset in webkit [105585] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
Jan 21, 2012:
- 7:45 PM Changeset in webkit [105584] by
-
- 2 edits in trunk
[GTK][PATCH] Enable MathML support by default
https://bugs.webkit.org/show_bug.cgi?id=76790
Patch by Priit Laes <plaes@plaes.org> on 2012-01-21
Reviewed by Martin Robinson.
- configure.ac: Enable MathML by default.
- 7:30 PM Changeset in webkit [105583] by
-
- 13 edits in trunk/Source
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672
Patch by David Reveman <reveman@chromium.org> on 2012-01-21
Reviewed by Adam Barth.
Source/WebCore:
Use a new set of textures for each commit when incremental
texture updates are enabled.
This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 5:43 PM Changeset in webkit [105582] by
-
- 1 edit2 adds in trunk/LayoutTests
Add baselines for test after http://trac.webkit.org/changeset/105575.
This baseline looks very similar to the existing non-Chromium baseline.
- platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- 5:36 PM Changeset in webkit [105581] by
-
- 8 edits9 adds1 delete in trunk/Source/JavaScriptCore
DFG should not have code that directly decodes the states of old JIT inline
cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768
Reviewed by Sam Weinig.
Introduced new classes (like GetByIdStatus) that encapsulate the set of things
that the DFG would like to know about property accesses and calls. Whereas it
previously got this information by directly decoding the data structures used
by the old JIT for inline caching, it now uses these classes, which do the work
for it. This should make it somewhat more straight forward to introduce new
ways of profiling the same information.
Also hoisted StructureSet into bytecode/ from dfg/, because it's now used by
code in bytecode/.
Making this work right involved carefully ensuring that the heuristics for
choosing how to handle property accesses was at least as good as what we had
before, since I completely restructured that code. Currently the performance
looks neutral. Since I rewrote the code I did change some things that I never
liked before, like previously if a put_bu_id had executed exactly once then
we'd compile it as if it had taken slow-path. Executing once is special because
then the inline cache is not baked in, so there is no information about how the
DFG should optimize the code. Now this is rationalized: if the put_by_id does
not offer enough information to be optimized (i.e. had executed 0 or 1 times)
then we turn it into a forced OSR exit (i.e. a patch point). However, get_by_id
still has the old behavior; I left it that way because I didn't want to make
too many changes at once.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkStatus.cpp: Added.
(JSC::CallLinkStatus::computeFor):
- bytecode/CallLinkStatus.h: Added.
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(JSC::CallLinkStatus::couldTakeSlowPath):
(JSC::CallLinkStatus::callTarget):
- bytecode/GetByIdStatus.cpp: Added.
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h: Added.
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::state):
(JSC::GetByIdStatus::isSet):
(JSC::GetByIdStatus::operator!):
(JSC::GetByIdStatus::isSimpleDirect):
(JSC::GetByIdStatus::takesSlowPath):
(JSC::GetByIdStatus::makesCalls):
(JSC::GetByIdStatus::structureSet):
(JSC::GetByIdStatus::offset):
- bytecode/MethodCallLinkStatus.cpp: Added.
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/MethodCallLinkStatus.h: Added.
(JSC::MethodCallLinkStatus::MethodCallLinkStatus):
(JSC::MethodCallLinkStatus::isSet):
(JSC::MethodCallLinkStatus::operator!):
(JSC::MethodCallLinkStatus::needsPrototypeCheck):
(JSC::MethodCallLinkStatus::structure):
(JSC::MethodCallLinkStatus::prototypeStructure):
(JSC::MethodCallLinkStatus::function):
(JSC::MethodCallLinkStatus::prototype):
- bytecode/PutByIdStatus.cpp: Added.
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h: Added.
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::state):
(JSC::PutByIdStatus::isSet):
(JSC::PutByIdStatus::operator!):
(JSC::PutByIdStatus::isSimpleReplace):
(JSC::PutByIdStatus::isSimpleTransition):
(JSC::PutByIdStatus::takesSlowPath):
(JSC::PutByIdStatus::oldStructure):
(JSC::PutByIdStatus::newStructure):
(JSC::PutByIdStatus::structureChain):
(JSC::PutByIdStatus::offset):
- bytecode/StructureSet.h: Added.
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::clear):
(JSC::StructureSet::add):
(JSC::StructureSet::addAll):
(JSC::StructureSet::remove):
(JSC::StructureSet::contains):
(JSC::StructureSet::isSubsetOf):
(JSC::StructureSet::isSupersetOf):
(JSC::StructureSet::size):
(JSC::StructureSet::at):
(JSC::StructureSet::operator[]):
(JSC::StructureSet::last):
(JSC::StructureSet::predictionFromStructures):
(JSC::StructureSet::operator==):
(JSC::StructureSet::dump):
- dfg/DFGAbstractValue.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGStructureSet.h: Removed.
- 5:09 PM Changeset in webkit [105580] by
-
- 4 edits6 adds in trunk
Add .url attribute alongside .URL in EventSource and WebSocket to comply with the specs but not break existing usage.
https://bugs.webkit.org/show_bug.cgi?id=40899
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-21
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/eventsource/eventsource-url-attribute.html
http/tests/websocket/tests/hixie76/url-attribute.html
http/tests/websocket/tests/hybi/url-attribute.html
- page/EventSource.idl:
- websockets/WebSocket.idl:
LayoutTests:
- fast/eventsource/eventsource-url-attribute-expected.txt: Added.
- fast/eventsource/eventsource-url-attribute.html: Added.
- http/tests/websocket/tests/hixie76/url-attribute-expected.txt: Added.
- http/tests/websocket/tests/hixie76/url-attribute.html: Added.
- http/tests/websocket/tests/hybi/url-attribute-expected.txt: Added.
- http/tests/websocket/tests/hybi/url-attribute.html: Added.
- 4:48 PM Changeset in webkit [105579] by
-
- 5 edits in trunk/Source/JavaScriptCore
JIT compilation should not require ExecState
https://bugs.webkit.org/show_bug.cgi?id=76729
<rdar://problem/10731545>
Reviewed by Gavin Barraclough.
Changed the relevant JIT driver functions to take JSGlobalData& instead of
ExecState*, since really they just needed the global data.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 3:56 PM Changeset in webkit [105578] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r105564.
http://trac.webkit.org/changeset/105564
https://bugs.webkit.org/show_bug.cgi?id=76792
Does not compile on Chromium Mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-21
Source/WebCore:
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 9:19 AM Changeset in webkit [105577] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green.
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- 7:40 AM Changeset in webkit [105576] by
-
- 19 edits6 adds in trunk
Implement hardware accelerated Brightness and contrast filters
https://bugs.webkit.org/show_bug.cgi?id=75521
https://bugs.webkit.org/show_bug.cgi?id=76719
Reviewed by Simon Fraser.
Source/WebCore:
Implemented hardware accelerated brightness and contrast filters. This also fixes
the bug where grayscale filter was accidentally never getting hardware accelerated.
It also complies with proposed spec changes for the brightness filter to be additive
rather than multiplicative, according to https://bugs.webkit.org/show_bug.cgi?id=76719.
Had to make both fixes in the same patch because I had to change the allowed brightness
values for the hardware version, so I had to change the software version as well.
Tests: css3/filters/effect-brightness-hw.html
css3/filters/effect-contrast-hw.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
LayoutTests:
New tests for hardware accelerated brightness and contrast filters. Also
added brightness and contrast values to effect-combined-hw test. And changed
brightness values in effect-brightness.html to reflect new spec.
Also fixed parsing and computed style tests to reflect new brightness spec.
- css3/filters/effect-brightness-expected.png:
- css3/filters/effect-brightness-hw-expected.png: Added.
- css3/filters/effect-brightness-hw-expected.txt: Added.
- css3/filters/effect-brightness-hw.html: Added.
- css3/filters/effect-brightness.html:
- css3/filters/effect-combined-expected.png:
- css3/filters/effect-combined-hw-expected.png:
- css3/filters/effect-combined-hw-expected.txt:
- css3/filters/effect-combined-hw.html:
- css3/filters/effect-combined.html:
- css3/filters/effect-contrast-hw-expected.png: Added.
- css3/filters/effect-contrast-hw-expected.txt: Added.
- css3/filters/effect-contrast-hw.html: Added.
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/filter-property-parsing-invalid-expected.txt:
- css3/filters/script-tests/filter-property-computed-style.js:
- css3/filters/script-tests/filter-property-parsing-invalid.js:
- css3/filters/script-tests/filter-property-parsing.js:
- 4:28 AM Changeset in webkit [105575] by
-
- 5 edits3 adds in trunk
2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780
Reviewed by Antti Koivisto.
Add new testcase covering preserveAspectRatio="none" + <feImage>, which is now fixed.
- platform/chromium/test_expectations.txt: Add new test, that needs a rebaseline.
- platform/mac/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/mac/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- svg/filters/feImage-preserveAspectratio.svg: Added.
2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780
Reviewed by Antti Koivisto.
preserveAspectRatio="none" was ignored in SVGFEImage. It always called transformRect() w/o checking
whether it was supposed to transform the rect or not - move code from RenderSVGImage right into
transformRect(), to do nothing if preserveAspectRatio="none" was given.
Test: svg/filters/feImage-preserveAspectratio.svg
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
- 2:18 AM Changeset in webkit [105574] by
-
- 3 edits6 adds in trunk
history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)
https://bugs.webkit.org/show_bug.cgi?id=76721
Reviewed by Mihai Parparita.
Source/WebCore:
Tests: http/tests/history/replacestate-post-to-get-2.html
http/tests/history/replacestate-post-to-get.html
- loader/HistoryController.cpp:
(WebCore::HistoryController::replaceState):
LayoutTests:
- http/tests/history/replacestate-post-to-get-2-expected.txt: Added.
- http/tests/history/replacestate-post-to-get-2.html: Added.
- http/tests/history/replacestate-post-to-get-expected.txt: Added.
- http/tests/history/replacestate-post-to-get.html: Added.
- http/tests/history/resources/replacestate-current.php: Added.
- http/tests/history/resources/replacestate-forward-back.php: Added.
- 2:00 AM Changeset in webkit [105573] by
-
- 7 edits2 adds in trunk
Null dereference in SVGDocumentExtensions::removePendingResource when updating <use>'s href
https://bugs.webkit.org/show_bug.cgi?id=69284
Patch by Florin Malita <fmalita@google.com> on 2012-01-21
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/custom/use-crash-pending-resource.svg
The crash is caused by assumptions in SVGUseElement that xlink:href is the only
pending resource. This patch adds support for dealing with multiple pending resources.
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::hasPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForElement):
- svg/SVGDocumentExtensions.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
Renamed SVGDocumentExtensions::hasPendingResources -> Renamed SVGDocumentExtensions::hasPendingResource.
Renamed SVGDocumentExtensions::isElementInPendingResources -> SVGDocumentExtensions::isElementPendingResources.
Added support for querying and removing pending resources for a specific element.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::buildPendingResource):
Refactored to support multiple pending resources.
LayoutTests:
- svg/custom/use-crash-pending-resource-expected.txt: Added.
- svg/custom/use-crash-pending-resource.svg: Added.
- 12:51 AM Changeset in webkit [105572] by
-
- 4 edits in trunk
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html
https://bugs.webkit.org/show_bug.cgi?id=64671
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-21
Reviewed by Nikolas Zimmermann.
Source/WebCore:
No new tests. This change is to fix crashes in existing tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::beginListChanged): If the new begin time is
later than the current end time, and the event time is also after then
end time (but we have not yet updated to that time) and the animation
is active, we need to make the animation inactive explicitly.
LayoutTests:
- platform/chromium/test_expectations.txt: Marking all svg/W3C-SVG-1.1/animate-elem* tests
as flakey pending this change being committed and new results.
- 12:42 AM Changeset in webkit [105571] by
-
- 4 edits in trunk/Source/WebKit2
Make WebKit2 remember the height of the Web Inspector when it is docked.
Reviewed by Dan Bernstein.
- Shared/WebPreferencesStore.h: Added InspectorAttachedHeight.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call WebPreferencesStore::setInspectorAttachedHeight.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Set the height of the inspector's WKView to inspectorAttachedHeight.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Remove unneeded setNeedsDisplay: calls.
- 12:17 AM Changeset in webkit [105570] by
-
- 4 edits in trunk/Source/WebCore
PopupMenuClient::multiple() should be const
https://bugs.webkit.org/show_bug.cgi?id=76771
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-21
Reviewed by Kent Tamura.
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::multiple):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
- rendering/RenderMenuList.h:
Jan 20, 2012:
- 10:06 PM Changeset in webkit [105569] by
-
- 6 edits4 adds in trunk/Source/WebCore
Switch indexeddb to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76723
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-01-20
Reviewed by Adam Barth.
No new tests required, all existing tests pass.
- Modules/indexeddb: Added.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp: Added. webkitIndexedDB() method previously in DOMWindow.cpp
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::~DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h: Added.
- Modules/indexeddb/DOMWindowIndexedDatabase.idl: Added. attributes previously in DOMWindow.idl
- WebCore.gyp/WebCore.gyp: add Modules/indexeddb/ directory
- WebCore.gypi: add Modules/indexeddb/*
- page/DOMWindow.cpp: remove webkitIndexedDB() method, add accessor methods for m_idbFactory
(WebCore::DOMWindow::getIDBFactory):
(WebCore::DOMWindow::setIDBFactory):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 8:11 PM Changeset in webkit [105568] by
-
- 2 edits in trunk/Source/WebCore
Allow isContextThread to be called while in ~ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=76756
Reviewed by Adam Barth.
It is possible for objects to get torn down or get called from ~ScriptExecutionContext
and in turn call isContextThread. The resulting behavior is undefined. This change defines
the behavior. I don't know of any places that do this but I have a test that is rarely
failing due to isContextThread being false. This is my best guess as to why, and I
don't see a reason to try to avoid calling isContextThread at this point.
No new functionality exposed so no new tests.
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isContextThread):
- 7:32 PM Changeset in webkit [105567] by
-
- 3 edits in trunk/Tools
The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
https://bugs.webkit.org/show_bug.cgi?id=76752
Reviewed by Eric Seidel.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_leaky_patterns):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(LeakyPatternTest.test_create_dc):
(LeakyPatternTest.test_create_compatible_dc):
- 7:19 PM Changeset in webkit [105566] by
-
- 6 edits in trunk/Source
[chromium] Write unit tests for compositor-thread zooming
https://bugs.webkit.org/show_bug.cgi?id=71529
Patch by Alexandre Elias <aelias@google.com> on 2012-01-20
Reviewed by James Robinson.
Add unit tests for pinch zoom and page scale animation. Includes
small cleanups in CCLayerTreeHostImpl for testability.
Source/WebCore:
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):
- 7:03 PM Changeset in webkit [105565] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] Division by zero error in QtViewportInteractionEngine::setItemRectVisible
https://bugs.webkit.org/show_bug.cgi?id=76674
Reviewed by Kenneth Rohde Christiansen.
Make sure that itemRect is not empty.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
- 6:49 PM Changeset in webkit [105564] by
-
- 13 edits in trunk/Source
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672
Patch by David Reveman <reveman@chromium.org> on 2012-01-20
Reviewed by James Robinson.
Source/WebCore:
Use a new set of textures for each commit when incremental
texture updates are enabled.
This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 6:35 PM Changeset in webkit [105563] by
-
- 720 edits in branches/subpixellayout/Source
Merge missing trunk changes (up until 105194) into branch.
- 6:34 PM Changeset in webkit [105562] by
-
- 2 edits in trunk/Source/WebCore
De-zippering incorrectly snaps to target gain
https://bugs.webkit.org/show_bug.cgi?id=76741
Reviewed by Kenneth Russell.
- platform/audio/AudioBus.cpp:
- 6:21 PM Changeset in webkit [105561] by
-
- 3 edits4 adds in trunk
[chromium] Partially filled pixels do not occlude pixels below them.
https://bugs.webkit.org/show_bug.cgi?id=76658
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-20
Reviewed by James Robinson.
Source/WebCore:
Test: compositing/culling/tile-occlusion-boundaries.html
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::enclosedIntRect):
(WebCore::CCQuadCuller::cullOccludedQuads):
LayoutTests:
- compositing/culling/tile-occlusion-boundaries-expected.png: Added.
- compositing/culling/tile-occlusion-boundaries-expected.txt: Added.
- compositing/culling/tile-occlusion-boundaries.html: Added.
- compositing/resources/green.jpg: Added.
- 6:06 PM Changeset in webkit [105560] by
-
- 2 edits in trunk/Tools
Changed my status in commiters.py
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 5:34 PM Changeset in webkit [105559] by
-
- 4 edits in trunk/Source
Small cleanup of {get,put}CurrentFrame for WebMediaPlayerClientImpl/CCVideoLayerImpl.
https://bugs.webkit.org/show_bug.cgi?id=76332
Patch by Ami Fischman <fischman@chromium.org> on 2012-01-20
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
Source/WebKit/chromium:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
- 5:16 PM Changeset in webkit [105558] by
-
- 2 edits in trunk/Source/WebKit2
Drag/drop of a file into a WebView on Windows needs to allow access to that file
https://bugs.webkit.org/show_bug.cgi?id=76753
<rdar://problem/10731719>
Reviewed by Alexey Proskuryakov.
The Windows drag/drop code path was missing the code to open a file read exception.
Added code to match the Mac version, while allowing directories and multiple files to
also be dragged (matching our previous behavior).
- UIProcess/win/WebView.cpp:
(WebKit::maybeCreateSandboxExtensionFromDragData): Added.
(WebKit::WebView::Drop): Add a universal read exception if we're dragging a file into a WebView to open it.
- 5:11 PM Changeset in webkit [105557] by
-
- 1 edit1 add in trunk/LayoutTests
Add a Chromium-specific baselines for
fast/dom/Window/open-invalid-url.html. Although this expected result
says "FAIL", the behavior seems to be reasonable.
- platform/chromium/fast/dom/Window/open-invalid-url-expected.txt: Added.
- 4:45 PM Changeset in webkit [105556] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764 Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
Reviewed by Sam Weinig.
No way to reproduce without special malloc debugging and that doesn't even reproduce on all platforms. So still no test.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame): Protect m_frame for the duration of this method.
- 4:36 PM Changeset in webkit [105555] by
-
- 3 edits in trunk/Source/JavaScriptCore
Make OwnPtr<HDC> work for the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76738
Reviewed by Jian Li.
- JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnPtrWin.cpp to the
Chromium Windows build.
- wtf/OwnPtrCommon.h: Changed from platform WIN to OS WIN for
OwnPtr<HDC> and similar constructs.
- 4:09 PM Changeset in webkit [105554] by
-
- 2 edits in trunk/Source/WebCore
WebCore should not send invalid URLs to client createWindow methods.
https://bugs.webkit.org/show_bug.cgi?id=39017
Unreviewed test fix.
- page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Let empty URLs through.
- 4:05 PM Changeset in webkit [105553] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from 118291 to 118493.
- DEPS:
- 4:03 PM Changeset in webkit [105552] by
-
- 23 edits in trunk/Source
Make WebCore RunLoop work for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76739
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/RunLoop.cpp:
Specialize RunLoop initialization for Mac, where it can happen on any thread.
- platform/RunLoop.h:
Add RunLoop constructor that takes a CFRunLoopRef on the mac for initializing
the main thread.
- platform/mac/RunLoopMac.mm:
(WebCore::RunLoop::initializeMainRunLoop):
Add new implementation that can work from any thread (and multiple threads at the
same time if necessary).
(WebCore::RunLoop::current):
Treat the main thread specially, not storing it in thread specific data.
(WebCore::RunLoop::main):
Copy main accessor since it needs access to the file static.
(WebCore::RunLoop::RunLoop):
Add constructor which takes a CFRunLoopRef.
Source/WebKit/mac:
- Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter initialize]):
- History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]):
- Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]):
- Misc/WebIconDatabase.mm:
(+[WebIconDatabase initialize]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm:
(+[WebUndoStep initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm:
(+[WebDataSourcePrivate initialize]):
- WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):
- WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
- WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]):
- WebView/WebView.mm:
(+[WebView initialize]):
- WebView/WebViewData.mm:
(+[WebViewPrivate initialize]):
Initialized the main run loop in addition to other initialization.
- 3:47 PM Changeset in webkit [105551] by
-
- 2 edits in trunk/Tools
run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
https://bugs.webkit.org/show_bug.cgi?id=76748
Reviewed by Ryosuke Niwa.
It crawls the whole subtree and then doesn't use the data. Cutting this out
saves 4 seconds warm and 17 seconds cold on my Mac Pro.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
- 3:36 PM Changeset in webkit [105550] by
-
- 2 edits in trunk/Tools
Another tiny tweak to the garden-o-matic CSS. This makes things line
up slightly nicer when there aren't any failures.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#summary):
- 3:23 PM Changeset in webkit [105549] by
-
- 4 edits2 adds in trunk
Crash in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=76606
<rdar://problem/10720970>
Reviewed by Dirk Schulze.
Notify SVGResourcesCache and superclass when RenderSVGInline is about
to be destroyed, preventing a crash.
Test: svg/custom/crash-inline-container-client.html
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::willBeDestroyed):
- rendering/svg/RenderSVGInline.h:
- svg/custom/crash-inline-container-client-expected.txt: Added.
- svg/custom/crash-inline-container-client.html: Added.
- 3:22 PM Changeset in webkit [105548] by
-
- 3 edits2 adds in trunk
WebCore should not send invalid URLs to client createWindow methods.
https://bugs.webkit.org/show_bug.cgi?id=39017
Reviewed by Sam Weinig.
Test: fast/dom/window/open-invalid-url.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Bail out early for invalid URLs.
- 3:21 PM Changeset in webkit [105547] by
-
- 2 edits in trunk/Source/WebKit/chromium
Revert r105545. Something got broken about gclient/gyp but I can't figure out what.
- DEPS:
- 3:00 PM Changeset in webkit [105546] by
-
- 2 edits in trunk/Source/WebCore
Remove unused variable in RenderReplaced after r105513
https://bugs.webkit.org/show_bug.cgi?id=76742
Reviewed by Daniel Bates.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
- 2:59 PM Changeset in webkit [105545] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from 118291 to 118530.
- DEPS:
- 2:49 PM Changeset in webkit [105544] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Plumb damage from accelerated canvas 2D.
https://bugs.webkit.org/show_bug.cgi?id=76728
Patch by Jonathan Backer <backer@chromium.org> on 2012-01-20
Reviewed by Kenneth Russell.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::contentChanged):
- 2:17 PM Changeset in webkit [105543] by
-
- 5 edits in trunk/Tools
run-perf-tests should support --test-results-server option
https://bugs.webkit.org/show_bug.cgi?id=76680
Reviewed by Adam Barth.
Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
to be used by perf bots. Also refactor file_uploader as needed.
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.init):
(FileUploader.upload_single_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader):
(FileUploader._upload_data):
(FileUploader._upload_data.callback):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.upload_json_files):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json):
(PerfTestsRunner._upload_json):
(PerfTestsRunner._run_tests_set):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_with_upload_json):
(test_run_with_upload_json.mock_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader):
(test_upload_json.MockFileUploader.init):
(test_upload_json.MockFileUploader.upload_single_file):
(test_parse_args):
- 2:16 PM Changeset in webkit [105542] by
-
- 4 edits2 adds in trunk
Crash in RenderTable::borderBefore
https://bugs.webkit.org/show_bug.cgi?id=75215
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/crash-beforeBorder-dirty-section.html
This is a regression from r97661 that added some calls to get the object's borders but tables are a
special case and they may need to recompute some sections' pointers.
The whole sections' pointers lazy recomputation logic is unfortunately far from being bullet proof and
this change is only a mitigation for the current crash.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
Make sure we recompute our sections. The change was made here to avoid hitting the
path used inside the table code (ie outerBorder{Before|After}) that shouldn't be
affected.
- rendering/RenderTable.h:
(WebCore::RenderTable::topSection):
Added an ASSERT to catch more bad use in the future.
LayoutTests:
- fast/table/crash-beforeBorder-dirty-section-expected.txt: Added.
- fast/table/crash-beforeBorder-dirty-section.html: Added.
- 2:10 PM Changeset in webkit [105541] by
-
- 14 edits in branches/subpixellayout/Source
Fixing widget painting on all platforms, and fixing an issue where nested NSViews were handed a subpixel value for the visible area. Correcting an enclosingIntRect usage in PaintInfo. Cleaning up some unnecessary changes to shrink patch noise.
- 1:19 PM Changeset in webkit [105540] by
-
- 3 edits in trunk/Source/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=76444
This breaks builds.
- WebView/WebPreferences.mm:
- WebView/WebPreferencesPrivate.h:
- 1:05 PM Changeset in webkit [105539] by
-
- 7 edits in trunk/Source/JavaScriptCore
Removed some regexp entry boilerplate code
https://bugs.webkit.org/show_bug.cgi?id=76687
Reviewed by Darin Adler.
1% - 2% speedup on regexp tests, no change overall.
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- ASSERT that our startIndex is non-negative, because anything less would be uncivilized.
- ASSERT that our input is not the null string for the same reason.
- No need to test for startOffset being past the end of the string, since the regular expression engine will do this test for us.
- No need to initialize the output vector, since the regular expression engine will fill it in for us.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::interpret):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
RegExp used to do these jobs for us, but now we do them for ourselves
because it's a better separation of concerns, and the JIT can do them
more efficiently than C++ code:
- Test for "past the end" before doing any matching -- otherwise a* will match with zero length past the end of the string, which is wrong.
- Initialize the output vector before doing any matching.
- 1:05 PM Changeset in webkit [105538] by
-
- 3 edits1 add in trunk
Add proper offset to position right click to simulate a context menu invocation.
https://bugs.webkit.org/show_bug.cgi?id=76421
Patch by Marc-Andre Decoste <mad@chromium.org> on 2012-01-20
Reviewed by Ojan Vafai.
.:
- ManualTests/win/contextmenu-key3.html: Added.
Source/WebCore:
Manual tests only because DRT doesn't support context menu key.
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
- 1:01 PM Changeset in webkit [105537] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build fix for no-DFG configuration.
Needed for <rdar://problem/10727689>.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfiledOpcode):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- 12:55 PM Changeset in webkit [105536] by
-
- 2 edits in trunk/Tools
The party time image overlaps real content! This patch makes the
image centered vertically.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#onebar.partytime #summary):
- 12:40 PM Changeset in webkit [105535] by
-
- 6 edits in trunk/Tools
Refactor TestExpectationsParser in preparation for caching the results
https://bugs.webkit.org/show_bug.cgi?id=76669
Reviewed by Dimitri Glazkov.
Make everything private expect for the parse method.
Eventually, we'll need the expectations lines to not be modified
outside of TestExpectationsParser so we can cache the results.
This makes check-webkit-style of the chromium test_expectations.txt file
go from ~17 seconds to ~12 seconds on my Mac Pro.
This patch is just a refactor in preparation, so no new tests.
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
(TestExpectationEditorTests.make_parsed_expectation_lines):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.parse):
(TestExpectationParser):
(TestExpectationParser._parse_line):
(TestExpectationParser._tokenize):
(TestExpectationParser._tokenize_list):
(TestExpectationsModel._clear_expectations_for_test):
(TestExpectations.init):
(TestExpectations._add_expectations):
(TestExpectations._add_skipped_tests):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationParserTests.test_parse_empty_string):
(TestExpectationSerializerTests.assert_round_trip):
(TestExpectationSerializerTests.assert_list_round_trip):
- Scripts/webkitpy/tool/commands/expectations.py:
(OptimizeExpectations.execute):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningExpectationsUpdater.update_expectations):
- 12:22 PM Changeset in webkit [105534] by
-
- 3 edits in trunk/Tools
Follow-up to previous patch: don't produce NaN when the revision number
is missing.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
- 12:22 PM Changeset in webkit [105533] by
-
- 20 edits in trunk/Source/JavaScriptCore
Bytecode instructions that may have value profiling should have a direct inline
link to the ValueProfile instance
https://bugs.webkit.org/show_bug.cgi?id=76682
<rdar://problem/10727689>
Reviewed by Sam Weinig.
Each opcode that gets value profiled now has a link to its ValueProfile. This
required rationalizing the emission of value profiles for opcode combos, like
op_method_check/op_get_by_id and op_call/op_call_put_result. It only makes
sense for one of them to have a value profile link, and it makes most sense
for it to be the one that actually sets the result. The previous behavior was
to have op_method_check profile for op_get_by_id when they were used together,
but otherwise for op_get_by_id to have its own profiles. op_call already did
the right thing; all profiling was done by op_call_put_result.
But rationalizing this code required breaking some of the natural boundaries
that the code had; for instance the code in DFG that emits a GetById in place
of both op_method_check and op_get_by_id must now know that it's the latter of
those that has the value profile, while the first of those constitutes the OSR
target. Hence each CodeOrigin must now have two bytecode indices - one for
OSR exit and one for profiling.
Finally this change required some refiddling of our optimization heuristics,
because now all code blocks have "more instructions" due to the value profile
slots.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfileForBytecodeOffset):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::bytecodeIndexForValueProfile):
- bytecode/Instruction.h:
(JSC::Instruction::Instruction):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
- runtime/Options.cpp:
(JSC::Options::initializeOptions):
- 12:21 PM Changeset in webkit [105532] by
-
- 4 edits in trunk
Unreviewed, rolling out r105426.
http://trac.webkit.org/changeset/105426
https://bugs.webkit.org/show_bug.cgi?id=76726
Might have caused a 20% regression in the PLT (Requested by
abarth|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-20
Source/WebCore:
- rendering/RenderObject.h:
(WebCore::RenderObject::style):
LayoutTests:
- platform/mac-snowleopard/Skipped:
- 12:08 PM Changeset in webkit [105531] by
-
- 17 edits in trunk/Source
[chromium] Revert a couple of changes in fileapi/ that break tests in chromeos.
https://bugs.webkit.org/show_bug.cgi?id=76718
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-01-20
Reviewed by Darin Fisher.
Source/WebCore:
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::getIdentifier):
(WebCore::BlobURL::createBlobURL):
- fileapi/BlobURL.h:
(WebCore::BlobURL::blobProtocol):
- fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::crackFileSystemURL):
- fileapi/DOMFileSystemBase.h:
- fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
- fileapi/FileWriter.cpp:
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestFileSystem):
- page/DOMWindow.h:
- platform/AsyncFileSystem.cpp:
- platform/AsyncFileSystem.h:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
Source/WebKit/chromium:
- public/platform/WebFileSystem.h:
- src/AssertMatchingEnums.cpp:
- src/AsyncFileSystemChromium.cpp:
- src/AsyncFileSystemChromium.h:
- 11:44 AM Changeset in webkit [105530] by
-
- 4 edits in trunk/Tools
Garden-o-matic should tell me which revisions have been checked by all the bots
https://bugs.webkit.org/show_bug.cgi?id=76722
Reviewed by Dimitri Glazkov.
This information helps me know when it's safe for me to roll a
candidate revision.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
- 11:23 AM Changeset in webkit [105529] by
-
- 6 edits in trunk/Source/WebCore
Refactor canvas drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76635
CCCanvasLayerImpl no longer handles drawing itself, but produces a list of CCCanvasDrawQuads.
These quads are then drawn by LayerRendererChromium.
This is a refactor, so no new tests were added.
Patch by Tim Dresser <tdresser@chromium.org> on 2012-01-20
Reviewed by James Robinson.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCanvasQuad):
- platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp:
(WebCore::CCCanvasDrawQuad::create):
(WebCore::CCCanvasDrawQuad::CCCanvasDrawQuad):
- platform/graphics/chromium/cc/CCCanvasDrawQuad.h:
(WebCore::CCCanvasDrawQuad::textureId):
(WebCore::CCCanvasDrawQuad::hasAlpha):
(WebCore::CCCanvasDrawQuad::premultipliedAlpha):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
- 11:08 AM Changeset in webkit [105528] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Do not recompute viewport on same page navigation
https://bugs.webkit.org/show_bug.cgi?id=75576
Reviewed by Darin Fisher.
Added parameter isNavigationWithinPage to WebViewImpl::didCommitLoad
that indicates whether a same-page navigation has just occurred.
The page scale factor flag is reset only on navigation to a new page.
If the flag is not set, viewport and page scale will be recomputed on
layoutUpdated.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::observeNewNavigation):
- src/WebViewImpl.h:
- 11:06 AM Changeset in webkit [105527] by
-
- 1 edit5 adds in trunk/LayoutTests
Add new baselines for a test introduced in
http://trac.webkit.org/changeset/105515. These all appear to be
correct.
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-mac-leopard/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-win/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-win/fast/borders/scaled-border-image-expected.txt: Added.
- 11:03 AM Changeset in webkit [105526] by
-
- 10 edits9 adds23 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/105513. Even
though these results look different on different platforms, the tests
seem to be aiming for the two boxes to look the same, which they do.
Also, removed some redundant results.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/97619-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png: Removed.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.png: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- 10:52 AM Changeset in webkit [105525] by
-
- 2 edits in trunk/LayoutTests
This test fails.
- platform/chromium/test_expectations.txt:
- 10:17 AM Changeset in webkit [105524] by
-
- 3 edits2 adds in trunk
Crash in xsltParseGlobalVariable.
https://bugs.webkit.org/show_bug.cgi?id=75978
Reviewed by Andreas Kling.
Source/WebCore:
The code missed to reset the stylesheet pointer after we fail
to compile the XSLT stylesheet. As a result, the stylesheet gets
reused with a removed document in the next transformToFragment call.
Test: fast/xsl/xslt-transform-to-fragment-crash.html
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::transformToString):
LayoutTests:
- fast/xsl/xslt-transform-to-fragment-crash-expected.txt: Added.
- fast/xsl/xslt-transform-to-fragment-crash.html: Added.
- 9:36 AM Changeset in webkit [105523] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708
- platform/qt-wk2/Skipped: Typo fix after last change.
- 9:35 AM Changeset in webkit [105522] by
-
- 2 edits in trunk/Tools
build-webkit: Don't spit out congratulations message on Ctrl+C
Reviewed by Andreas Kling.
- 9:07 AM Changeset in webkit [105521] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708
- platform/qt-wk2/Skipped: Skip failing tests to paint the bot green.
- 9:06 AM Changeset in webkit [105520] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r105486.
- fast/dom/constructed-objects-prototypes-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 8:49 AM Changeset in webkit [105519] by
-
- 2 edits in trunk/Tools
[GTK] Allow extra jhbuild modulesets
https://bugs.webkit.org/show_bug.cgi?id=76691
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuildrc: Extra modulesets and modules can be added in
JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
env variables respectively. Use comma-separated values. Example:
WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
- 8:32 AM Changeset in webkit [105518] by
-
- 22 edits in trunk/LayoutTests
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Unreviewed gardening after r105513, update Qt specific results.
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/qt/svg/wicd/rightsizing-grid-expected.png:
- platform/qt/svg/wicd/rightsizing-grid-expected.txt:
- platform/qt/tables/mozilla/bugs/bug101674-expected.png:
- platform/qt/tables/mozilla/bugs/bug101674-expected.txt:
- platform/qt/tables/mozilla/bugs/bug86708-expected.png:
- platform/qt/tables/mozilla/bugs/bug86708-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- 8:24 AM Changeset in webkit [105517] by
-
- 9 edits in trunk/Source/WebKit2
[Qt] Trigger forcing accelerated compositing from the UI process side.
https://bugs.webkit.org/show_bug.cgi?id=76296
Reviewed by Noam Rosenthal.
Some messages can be sent from the web view to the LayerTreeHost before
accelerated compositing is entered on the web process and signaled back.
By letting the UI process decide if AC has to be forced, we can create
the LayerTreeHostProxy earlier to send messages to the web process while
AC is being entered there.
This patch also fixes the flow of DidRenderFrame and RenderNextFrame messages
by setting the m_waitingForUIProcess flag properly and only send the
RenderNextFrame once the painting thread on the UI process is ready to paint.
This fixes the first visible content rect message not being received when
loading pages from the disk.
- Shared/WebPreferencesStore.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::didRenderFrame):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
- 7:56 AM Changeset in webkit [105516] by
-
- 13 edits in trunk/LayoutTests
2012-01-20 Nikolas Zimmermann <nzimmermann@rim.com>
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Not reviewed. Rebaseline gtk results.
- platform/gtk/fast/block/float/015-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
- platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/gtk/svg/custom/use-font-face-crash-expected.txt:
- platform/gtk/svg/wicd/rightsizing-grid-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug101674-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug86708-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- 7:51 AM Changeset in webkit [105515] by
-
- 3 edits3 adds in trunk
REGRESSION (r98852): apple.com navigation bar is broken under full-page zoom
https://bugs.webkit.org/show_bug.cgi?id=76249
Reviewed by Andreas Kling.
Source/WebCore:
Fix regression with full-page zoom & border-image. paintNinePieceImage() expects local, unzoomed coordinates.
Restore the behaviour as it was before r98852, fixing the regression.
Test: fast/borders/scaled-border-image.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
Add new test covering zooming + border-image, which regressed.
- fast/borders/scaled-border-image.html: Added.
- platform/mac/fast/borders/scaled-border-image-expected.png: Added.
- platform/mac/fast/borders/scaled-border-image-expected.txt: Added.
- 7:33 AM Changeset in webkit [105514] by
-
- 39 edits3 adds in trunk
[CSSRegion]Expose DOM interface for WebKitCSSRegionRule
https://bugs.webkit.org/show_bug.cgi?id=73985
Reviewed by Antti Koivisto.
Source/WebCore:
Start by exposing the interface and the cssRules attribute of type CSSRuleList.
Test: fast/regions/webkit-region-rule.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- css/WebKitCSSRegionRule.cpp:
- css/WebKitCSSRegionRule.h:
- css/WebKitCSSRegionRule.idl:
- page/DOMWindow.idl:
LayoutTests:
Start by exposing the interface and the cssRules attribute of type CSSRuleList.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/regions/webkit-region-rule-expected.txt: Added.
- fast/regions/webkit-region-rule.html: Added.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 7:30 AM Changeset in webkit [105513] by
-
- 58 edits in trunk
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447
Reviewed by Antti Koivisto.
Source/WebCore:
Remove a gazillion of hacks out of our SVG implementation, by correctly differentiating between the
SVG width/height attributes and the CSS width/height properties. They need to be treated independently
when handling the intrinsic size negotiation, according to both CSS 2.1 & SVG 1.1 2nd Edition specs.
Fixes several bugs in the LayoutTests/svg/custom/*object*sizing tests, we now match Opera perfectly. FF still has some bugs, and IE9 as well.
- css/svg.css: Remove hardcoded, width/height: 100% on <svg>.
- rendering/RenderBox.h:
(WebCore::RenderBox::computeIntrinsicRatioInformation): Make 'intrinsicRatio' a float, and add 'intrinsicSize' as seperated FloatSize, to avoid confusion.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Add forgotton case for percentage intrinsic sizes, that lead to workarounds in other places, that can now be removed.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth): Directly use imageHasRelativeWidth/Height(), it does differentiate between SVG/CSS width/height attributes/properties now.
(WebCore::RenderImage::computeIntrinsicRatioInformation): Adapt to 'intrinsicRatio' argument change.
- rendering/RenderImage.h: Ditto.
- rendering/RenderReplaced.cpp: Refactor existing code, break out firstContainingBlockWithLogicalWidth/hasReplacedLogicalWidth/hasReplacedLogicalHeight/hasAutoHeightOrContainingBlockWithAutoHeight.
(WebCore::firstContainingBlockWithLogicalWidth): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalWidth): Refactored, and exported, so SVGSVGElement::widthAttributeEstablishesViewport() can use it.
(WebCore::hasAutoHeightOrContainingBlockWithAutoHeight): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalHeight): Refactored, and exported, so SVGSVGElement::heightAttributeEstablishesViewport() can use it.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Adapt to 'intrinsicRatio' changes ('intrinsicSize' is now decoupled from it). Refactor so that RenderSVGRoot can directly use it as well!
(WebCore::RenderReplaced::computeReplacedLogicalHeight): Ditto.
- rendering/RenderReplaced.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Only determine the intrinsic size & ratio using the SVG width/height attributes, not the CSS width/height properties, as it's specified.
(WebCore::resolveLengthAttributeForSVG): Helper function for computeReplacedLogicalWidth/Height, that scales Length values that come from SVG width/height attributes.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Finally remove home-brewn size computation logic - it can be fully shared with RenderReplaced now that we inherit from it.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::viewport): Export viewport() for easier length resolution.
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport): Finally clean up this hell, and make it easy to understand. Only need to resolve lengths against either RenderSVGRoot or RenderSVGViewportContainer now.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport): Remove wrong code and disable this. Its not used, and we have no test coverage for it. Its current implementation didn't make any sense.
(WebCore::SVGSVGElement::parseMappedAttribute): Remove hacks mapping SVG width/height attributes to CSS properties.
(WebCore::SVGSVGElement::svgAttributeChanged): Ditto.
(WebCore::SVGSVGElement::localCoordinateSpaceTransform): Refactored.
(WebCore::SVGSVGElement::currentViewBoxRect): Ditto.
(WebCore::SVGSVGElement::currentViewportSize): Ditto.
(WebCore::SVGSVGElement::widthAttributeEstablishesViewport): Main logic determining if the SVG or CSS properties establish the viewport - a direct transliteration from the spec.
(WebCore::SVGSVGElement::heightAttributeEstablishesViewport): Ditto.
(WebCore::SVGSVGElement::intrinsicWidth): Helper.
(WebCore::SVGSVGElement::intrinsicHeight): Ditto.
- svg/SVGSVGElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::size): Cleanup code.
(WebCore::SVGImage::hasRelativeWidth): Added, avoids hacks in RenderBoxModelObject.
(WebCore::SVGImage::hasRelativeHeight): Ditto.
(WebCore::SVGImage::computeIntrinsicDimensions): Make use of new SVGSVGElement::computeIntrinsicDimensions.
- svg/graphics/SVGImage.h:
LayoutTests:
Update SVG pixel test baseline.
- platform/mac/svg/custom/dynamic-empty-path-expected.png: Marginal changes.
- platform/mac/svg/custom/fractional-rects-expected.png: Ditto.
- platform/mac/svg/custom/js-update-container-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Align with Opera, gives same result now. All *object*sizing* tests are passing now.
- platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Ditto.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Ditto.
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Marginal changes.
- platform/mac/svg/custom/viewBox-hit-expected.png: Ditto.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-background-images-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Ditto.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug101674-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug101674-expected.txt: Ditto.
- platform/mac/tables/mozilla/bugs/bug86708-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug86708-expected.txt: Ditto.
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.png: Ditto.
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt: Ditto.
- svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Fix test, now that our bug is fixed.
- svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Ditto.
- svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Ditto.
- svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Ditto.
- svg/foreignObject/text-tref-02-b-expected.txt: Size is not reported anymore.
- 7:03 AM Changeset in webkit [105512] by
-
- 5 edits4 adds in trunk
window.innerWidth/Height should not include page scale
https://bugs.webkit.org/show_bug.cgi?id=76555
Source/WebCore:
The DOM attributes window.innerWidth and window.innerHeight should be in
CSS pixels instead of device pixels. Currently the text zoom factor is
cancelled out when calculating these values, but the same also needs to
be done for the page scale.
There is an additional subtlety concerning frames/iframes since their
visible content rectangle is already in (unscaled) CSS pixels. By using
Frame::frameScaleFactor() we avoid unnecessarily cancelling out the page
scale factor in this case.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-20
Reviewed by Kenneth Rohde Christiansen.
Tests: fast/dom/iframe-inner-size-scaling.html
fast/dom/window-inner-size-scaling.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
LayoutTests:
Add two tests for window.innerWidth and window.innerHeight interaction
with page scaling.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-20
Reviewed by Kenneth Rohde Christiansen.
- fast/dom/iframe-inner-size-scaling-expected.txt: Added.
- fast/dom/iframe-inner-size-scaling.html: Added.
- fast/dom/window-inner-size-scaling-expected.txt: Added.
- fast/dom/window-inner-size-scaling.html: Added.
- fast/frames/frame-set-rotation-hit.html: Calculate the panel height before changing the page scale, because the visual viewport changes with the page scale.
- fast/frames/frame-set-scaling-hit.html: Ditto.
- 6:53 AM Changeset in webkit [105511] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] animations tests fails which uses suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=43905
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-20
Reviewed by Csaba Osztrogonác.
They seem to pass correctly on my machine.
- platform/qt/Skipped:
- platform/qt/animations/additive-transform-animations-expected.txt: Added.
- 6:49 AM Changeset in webkit [105510] by
-
- 9 edits2 adds in trunk/LayoutTests
new baselines for crbug 110493
https://bugs.webkit.org/show_bug.cgi?id=76629
Patch by Elliot Poger <epoger@google.com> on 2012-01-20
Reviewed by Dirk Pranke.
- platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-linux/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-win/svg/custom/focus-ring-expected.png:
- platform/chromium/test_expectations.txt:
- 6:29 AM Changeset in webkit [105509] by
-
- 2 edits1 delete in trunk
Unreviewed; Windows buildbot update failure fix.
- ../ManualTests/data-transfer-items-file-dragout.html: Removed the notion of test:lorem-text.html.
- ../ManualTests/resources/test:lorem-text.html: Removed as this doesn't work on Windows.
- 4:36 AM Changeset in webkit [105508] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Skip failing tests.
- platform/qt-wk2/Skipped: Skip tests because of https://bugs.webkit.org/show_bug.cgi?id=76699
- platform/wk2/Skipped: Skip a test because of missing layoutTestController.setEditingBehavior
- 4:31 AM Changeset in webkit [105507] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [chromium] add WebDevToolsFrontendClient::openInNewTab for upcoming WebCore change.
https://bugs.webkit.org/show_bug.cgi?id=76698
Reviewed by Yury Semikhatsky.
- public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::openInNewTab):
- 4:21 AM BuildingGtk edited by
- Added libxtst-dev - needed for jhbuilding the at-spi bits required for … (diff)
- 4:08 AM Changeset in webkit [105506] by
-
- 30 edits8 adds in trunk
Add DataTransferItems support for drag-and-drop'ed files and texts
https://bugs.webkit.org/show_bug.cgi?id=76367
Reviewed by Tony Chang.
WebKit-svn:
- ManualTests/data-transfer-items-file-dragout.html: Added.
- ManualTests/resources/test:lorem-text.html: Added.
WebKit-svn/LayoutTests:
- editing/pasteboard/data-transfer-items-drag-drop-file-expected.txt: Added.
- editing/pasteboard/data-transfer-items-drag-drop-file.html: Added.
- editing/pasteboard/data-transfer-items-drag-drop-string-expected.txt: Added.
- editing/pasteboard/data-transfer-items-drag-drop-string.html: Added.
- platform/gtk/Skipped: Added the new tests as the platform does not support dataTransferItems yet.
- platform/mac/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
WebKit-svn/Source/WebCore:
Per http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransfer-interface
the new interface should also support drag-and-dropped files and texts in
addition to pasted texts/images. The user apps should also be able to add
texts/files to the drag store by calling event.dataTransfer.items.add().
This patch adds drag-and-drop'ed items support in DataTransferItem and
DataTransferItemList so that they work for dropped files and texts (as well as
the copy-pasted texts/images).
This patch also adds customized toJS()/toV8() code to Blob/File javascript
binding so that the JS code can get either Blob or File underlying object
where the API returns Blob. This change is necessary since we return Blob
from DataTransferItem.getAsFile() for pasted images but want to return File
for dropped files.
Tests: editing/pasteboard/data-transfer-items-drag-drop-file.html
editing/pasteboard/data-transfer-items-drag-drop-string.html
- GNUmakefile.list.am: Added entries for the new {JS,V8}BlobCustom.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.gypi: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSBlobCustom.cpp: Added toJS custom code that returns File or
Blob depending on the return value of isFile().
(WebCore::toJS):
- bindings/v8/custom/V8BlobCustom.cpp: Added toV8 custom code.
(WebCore::toV8):
- dom/DataTransferItem.h: Added a new create() method which takes File.
- dom/DataTransferItemList.cpp: Added add(File) method.
(WebCore::DataTransferItemList::add):
- dom/DataTransferItemList.h: Ditto.
- dom/DataTransferItemList.idl: Ditto.
- fileapi/Blob.idl: Added CustomToJS for toJS/toV8.
- platform/chromium/ClipboardChromium.cpp: Added code for drag-and-drop'ed items.
(WebCore::ClipboardChromium::items): Revised.
(WebCore::ClipboardChromium::mayUpdateItems): Added.
(WebCore::ClipboardChromium::isStorageUpdated): Added.
- platform/chromium/ClipboardChromium.h:
- platform/chromium/DataTransferItemChromium.cpp: Added a new constructor that
takes File and updated getAsFile() to make it support dropped files.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsFile):
- platform/chromium/DataTransferItemChromium.h:
- platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::addInternalItem):
- platform/chromium/DataTransferItemListChromium.cpp: Added overrides implementation for m_item accessors to make them reflect the changes in the owner clipboard.
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::mayUpdateItems): Added.
- platform/qt/DataTransferItemQt.cpp: Added a new constructor that takes File and updated
getAsFile() to make it support dropped files.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsFile):
- platform/qt/DataTransferItemQt.h:
- 3:43 AM Changeset in webkit [105505] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Unreviewed, unskipping test passing after r105286.
- platform/gtk/Skipped: Unskip test.
- 3:39 AM Changeset in webkit [105504] by
-
- 7 edits in trunk/Source/WebKit2
Unreviewed, rolling out r105497.
http://trac.webkit.org/changeset/105497
https://bugs.webkit.org/show_bug.cgi?id=76696
Leaking in Qt layout tests and timing out in GTK API tests.
(Requested by jturcotte on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-20
- Shared/WebPreferencesStore.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
- 3:29 AM Changeset in webkit [105503] by
-
- 17 edits6 adds in trunk
[GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
https://bugs.webkit.org/show_bug.cgi?id=72589
Reviewed by Martin Robinson.
.:
New optional dependency for WK2's accessibility unit test: AT-SPI2.
- configure.ac: Check for AT-SPI2 when building with WK2 support.
Source/WebKit2:
Expose the accessibility hierarchy in the multi-process
architecture of WK2 through AtkSocket and AtkPlug.
Make the WebView widget return an AtkSocket when calling to
gtk_widget_get_accessible().
- GNUmakefile.am: Add new files.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_init):
(webkitWebViewBaseGetAccessible):
(webkit_web_view_base_class_init):
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp: Added.
(webkitWebViewBaseAccessibleWidgetFinalize):
(webkitWebViewBaseAccessibleWidgetDestroyed):
(webkitWebViewBaseAccessibleInitialize):
(webkitWebViewBaseAccessibleRefStateSet):
(webkitWebViewBaseAccessibleGetIndexInParent):
(webkit_web_view_base_accessible_init):
(webkit_web_view_base_accessible_class_init):
(webkitWebViewBaseAccessibleNew):
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.h: Added.
Make the WebPage create an AtkPlug on its initialization and
sending the ID of that plug to the UI process, so it can embed the
plug in the socket.
Also, take care of all the needed wrapping around the WebCore's
accessibility objects, exposing them in the UI process's
accessibility hierarchy thanks to the socket-plug connection.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::accessibilityPlugID):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/gtk/WebPageAccessibilityObject.cpp: Added.
(accessibilityRootObjectWrapper):
(webPageAccessibilityObjectInitialize):
(webPageAccessibilityObjectGetIndexInParent):
(webPageAccessibilityObjectGetNChildren):
(webPageAccessibilityObjectRefChild):
(web_page_accessibility_object_init):
(web_page_accessibility_object_class_init):
(webPageAccessibilityObjectNew):
(webPageAccessibilityObjectRefresh):
- WebProcess/WebPage/gtk/WebPageAccessibilityObject.h: Added.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):
New unit test for checking accessibility support in WK2GTK.
- UIProcess/API/gtk/tests/AccessibilityTestServer.cpp: Added.
(loadChangedCallback): Notify the parent process (the test)
when ready.
(main):
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp: Added.
(stopTestServer):
(sigAbortHandler):
(testServerMonitorThreadFunc):
(startTestServerMonitor):
(startTestServer):
(checkAtspiAccessible):
(findTestServerApplication):
(testAtspiBasicHierarchy):
(beforeAll):
(afterAll):
Tools:
Ensure the accessibility infrastructure is available when running
the unit tests, otherwise WK2's accessibility tests won't work.
- Scripts/run-gtk-tests:
(TestRunner):
(TestRunner._lookup_atspi2_binary): New. Looks for the directory
where at-spi2's stuff is located (like at-spi-bus-launcher and
at-spi2-registryd).
(TestRunner.run): Initialize the accessibility infrastructure.
- gtk/generate-gtkdoc:
(get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
- gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
- 3:10 AM Changeset in webkit [105502] by
-
- 16 edits2 adds2 deletes in trunk
remove CSSBorderImageValue
https://bugs.webkit.org/show_bug.cgi?id=75563
Reviewed by Tony Chang.
Source/WebCore:
Remove CSSBorderImageValue as border-image is a shorthand therefore we don't
need a dedicated CSS class type for it. CSSBorderImageValue was here for
-webkit-border-image which is not a shorthand. This is the first step to move border-image
close to a correct shorthand implementation while keeping -webkit-border-image being a regular
CSS property.
No new tests : It's a refactor, existing tests should cover it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSBorderImage.cpp: Added.
(WebCore::createBorderImageValue):
- css/CSSBorderImage.h: Added.
- css/CSSBorderImageValue.cpp: Removed.
- css/CSSBorderImageValue.h: Removed.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::commitBorderImage):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):
- css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
LayoutTests:
Modify the expected output as now border-image is a CSSValueList.
- fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
- 2:51 AM Changeset in webkit [105501] by
-
- 2 edits in branches/chromium/963/Source/WebCore/inspector/front-end
Merge 105140 (re-land) - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058
Reviewed by Pavel Feldman.
As per the results of a war room:
- Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
- Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
- Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
- Grayed autocompletion can only be accepted with the End or Right keys.
- Enter can accept a selected suggestion item from the list, without committing the input.
- Retain the CSS model editing behavior as close to the existing one as possible.
- Enable PageUp/PageDown to navigate the suggest box items.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271002
- 2:29 AM Changeset in webkit [105500] by
-
- 21 edits3 adds in trunk
Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76353
Reviewed by Hajime Morita.
Add ShadowRoot.idl, which is enabled only on chromium port since this is
under development feature.
ShadowRoot.idl contains minimum API so that we can test it.
Other APIs should be added on other changes so that we can isolate issues.
Source/WebCore:
Test: fast/dom/shadow/shadow-root-js-api.html
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::host):
- dom/ShadowRoot.idl: Added.
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableShadowDOM):
(WebKit::WebRuntimeFeatures::isShadowDOMEnabled):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
- fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
- fast/dom/shadow/shadow-root-js-api.html: Added.
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 2:17 AM Changeset in webkit [105499] by
-
- 2 edits in branches/chromium/963/Source/WebCore/inspector/front-end
Revert 105252 - Merge 105140 - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058
Reviewed by Pavel Feldman.
As per the results of a war room:
- Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
- Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
- Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
- Grayed autocompletion can only be accepted with the End or Right keys.
- Enter can accept a selected suggestion item from the list, without committing the input.
- Retain the CSS model editing behavior as close to the existing one as possible.
- Enable PageUp/PageDown to navigate the suggest box items.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252006
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9131006
- 2:04 AM Changeset in webkit [105498] by
-
- 3 edits3 adds in trunk
[Qt] Public API watch dog auto test.
https://bugs.webkit.org/show_bug.cgi?id=73922
Reviewed by Simon Hausmann.
This test aims to prevent unintended/unapproved
modifications to the public QML API.
.:
- Source/tests.pri:
Source/WebKit2:
- UIProcess/API/qt/tests/publicapi/publicapi.pro: Added.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Added.
(isCheckedEnum):
(isCheckedClass):
(checkKnownType):
(gatherAPI):
(tst_publicapi::publicAPI):
- 2:02 AM Changeset in webkit [105497] by
-
- 7 edits in trunk/Source/WebKit2
[Qt] Trigger forcing accelerated compositing from the UI process side.
https://bugs.webkit.org/show_bug.cgi?id=76296
Reviewed by Noam Rosenthal.
Some messages can be sent from the web view to the LayerTreeHost before
accelerated compositing is entered on the web process and signaled back.
By letting the UI process decide if AC has to be forced, we can create
the LayerTreeHostProxy earlier to send messages to the web process while
AC is being entered there.
This fixes the first visible content rect message not being received when
loading pages from the disk.
- Shared/WebPreferencesStore.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
- 1:57 AM Changeset in webkit [105496] by
-
- 2 edits in trunk/Tools
[GTK] GTK's DRT not to log events for already defunct objects
https://bugs.webkit.org/show_bug.cgi?id=76620
Reviewed by Martin Robinson.
Do not log 'state-change:defunct' events.
- DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
(printAccessibilityEvent): Early return if a
'state-change:defunct' signal is passed.
(axObjectEventListener): Pass the signal name and value in
separate parameters to printAccessibilityEvent.
- 1:39 AM Changeset in webkit [105495] by
-
- 2 edits in trunk/Source/JavaScriptCore
undefined reference to symbol eina_module_free
https://bugs.webkit.org/show_bug.cgi?id=76681
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-20
Reviewed by Martin Robinson.
eina_module_free has been used without including eina libraries after r104936.
- wtf/PlatformEfl.cmake: Add EINA_LIBRARIES.
- 1:23 AM Changeset in webkit [105494] by
-
- 2 edits in trunk/Websites/webkit.org
Each style rule should have its own ID.
https://bugs.webkit.org/show_bug.cgi?id=76428
Reviewed by David Levin.
- coding/coding-style.html: Add an id attribute to each of li elements,
and add code to set title="#id-name" and to make li elements clickable.
- 1:12 AM Changeset in webkit [105493] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r105486.
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 1:05 AM Changeset in webkit [105492] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a new failing test.
- platform/qt/Skipped:
- 12:59 AM Changeset in webkit [105491] by
-
- 7 edits2 copies in trunk/Source/WebKit/chromium
[chromium] Chromium should have EditorClientImpl::checkTextOfParagraph.
https://bugs.webkit.org/show_bug.cgi?id=74071
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-20
Reviewed by Darin Fisher.
Spellchecker on Mac has more sophisticated interface for spellchecking (checkTextOfParagraph).
If the other ports have the same interface, code can be clearer and easy to extend.
This patch introduces such an interface. The implementation will be done not in WebKit but in Chromium.
Also, currently WebKit::WebTextCheckingResult and WebCore::TextCheckingResult have different forms.
They should be corresponding apparently. This patch introduces such correspondence.
- WebKit.gyp:
- public/WebSpellCheckClient.h:
(WebKit::WebSpellCheckClient::checkTextOfParagraph):
A new interface for spellchecking.
- public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
Changed so that WebTextCheckingResult corresponds to WebCore::TextCheckingResult.
- public/WebTextCheckingType.h: Copied from Source/WebKit/chromium/public/WebTextCheckingResult.h.
- src/AssertMatchingEnums.cpp:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::checkTextOfParagraph):
- src/EditorClientImpl.h:
- src/WebTextCheckingResult.cpp: Copied from Source/WebKit/chromium/public/WebTextCheckingResult.h.
(WebKit::WebTextCheckingResult::operator TextCheckingResult):
- 12:47 AM Changeset in webkit [105490] by
-
- 6 edits in trunk/Source/WebCore
Change LocalizedNumber interface
https://bugs.webkit.org/show_bug.cgi?id=76613
Reviewed by Hajime Morita.
Change the functions of LocalizedNumber from:
double parseLocalizedNumber(const String&);
String formatLocalizedNumber(double, unsigned fractionDigits);
To:
String convertToLocalizedNumber(const String&, usnigned fractionDigits);
String convertFromLocalizedNumber(const String&);
in order that we can avoid conversion from/to a double value.
The fractionDigits argumetn of convertToLocalizedNumber() will be
removed in the future. We need it because we'd like to recycle the old
functions to implement new functions for now and functions in
LocalizedNumber can't call functions in HTMLParserIdioms.cpp.
No new tests because the change doesn't make any behavior change.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::visibleValue):
Use convertToLocalizedNumber.
(WebCore::NumberInputType::convertFromVisibleValue):
Use convertFromLocalizedNumber.
(WebCore::NumberInputType::isAcceptableValue): ditto.
- platform/text/LocalizedNumber.h:
Remove parseLocalizedNumber and formatLocalizedNumber, and
introduce convertToLocalizedNumber and convertFromLocalizedNumber.
- platform/text/LocalizedNumberICU.cpp:
(WebCore::parseLocalizedNumber): Make this static.
(WebCore::formatLocalizedNumber): Make this static.
(WebCore::convertToLocalizedNumber): Implement this with formatLocalizedNumber.
(WebCore::convertFromLocalizedNumber): Implement this with parseLocalizedNumber.
- platform/text/LocalizedNumberNone.cpp:
(WebCore::convertToLocalizedNumber):
Implement this as a function returning the input string.
(WebCore::convertFromLocalizedNumber): ditto.
- platform/text/mac/LocalizedNumberMac.mm:
(WebCore::parseLocalizedNumber): Make this static.
(WebCore::formatLocalizedNumber): Make this static.
(WebCore::convertToLocalizedNumber): Implement this with formatLocalizedNumber.
(WebCore::convertFromLocalizedNumber): Implement this with parseLocalizedNumber.
- 12:42 AM Changeset in webkit [105489] by
-
- 6 edits in trunk/Source/WebKit/chromium
[chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily.
https://bugs.webkit.org/show_bug.cgi?id=73971
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-20
Reviewed by Darin Fisher.
This interface is necessary to recheck spelling of an arbitrary element.
- public/WebFrame.h:
- public/WebNode.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::requestTextChecking):
Requests spellchecking for the element having current selection.
- src/WebFrameImpl.h:
- src/WebNode.cpp:
(WebKit::WebNode::rootEditableElement):
Takes a root editable element from Node.
- 12:26 AM Changeset in webkit [105488] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: problem with Ctrl - <arrows> shortcuts in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=76622
Reviewed by Yury Semikhatsky.
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.set readOnly):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewer.prototype.wasShown):
(WebInspector.TextViewer.prototype.willHide):
- inspector/front-end/UIUtils.js:
(WebInspector.isInEditMode):
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
- 12:04 AM Changeset in webkit [105487] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test results rebaseline after r105457.
- fast/canvas/canvas-webkitLineDash-expected.txt:
- 12:00 AM Changeset in webkit [105486] by
-
- 11 edits3 adds in trunk
Source/WebCore: Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386
Reviewed by Adam Barth.
Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing -
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html
- html/DOMURL.cpp: Added HashMap for local static objects.
(WebCore::PublicURLManager::PublicURLManager):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
(WebCore::publicURLManagerMap):
(WebCore::publicURLManager):
(WebCore::publicBlobURLs):
(WebCore::publicStreamURLs):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
- html/DOMURL.h:
(WebCore::DOMURL::create):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::DOMURL):
- html/DOMURL.idl:
- page/DOMWindow.cpp: Removed object initialization for DOMURL.
- page/DOMWindow.h: ditto.
- page/DOMWindow.idl: ditto.
- workers/WorkerContext.cpp: ditto.
- workers/WorkerContext.h: ditto.
- workers/WorkerContext.idl: ditto.
LayoutTests: Migrate createObjectURL & revokeObjectURL to static (Class) methods
https://bugs.webkit.org/show_bug.cgi?id=74386
Reviewed by Adam Barth.
Added test to check if createObjectURL & revokeObjectURL are static functions.
- fast/dom/DOMURL: Added.
- fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
- fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.